Change in vdsm[master]: storage: Organize imports in storage.iscsiadm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.iscsiadm
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a356824572c14da5baa862cf20e872767fb52e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.threadPool

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage: Organize imports in storage.threadPool
..

storage: Organize imports in storage.threadPool

Change-Id: If7e96ac259029aa12ee548a8113c1fbcbf82d26c
Signed-off-by: Nir Soffer 
---
M vdsm/storage/threadPool.py
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/55259/1

diff --git a/vdsm/storage/threadPool.py b/vdsm/storage/threadPool.py
index 594a6b9..1ac10c9 100644
--- a/vdsm/storage/threadPool.py
+++ b/vdsm/storage/threadPool.py
@@ -7,10 +7,13 @@
 #
 
 from __future__ import print_function
-import threading
-from time import sleep
-from Queue import Queue, Empty
+
 import logging
+import threading
+
+from Queue import Queue, Empty
+from time import sleep
+
 from vdsm import concurrent
 
 


-- 
To view, visit https://gerrit.ovirt.org/55259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7e96ac259029aa12ee548a8113c1fbcbf82d26c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Oraganize imports in storage.sdc

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage: Oraganize imports in storage.sdc
..

storage: Oraganize imports in storage.sdc

Change-Id: Id949a69853e2c97a4f1177cd3e717b9c956d03c8
Signed-off-by: Nir Soffer 
---
M vdsm/storage/sdc.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/55260/1

diff --git a/vdsm/storage/sdc.py b/vdsm/storage/sdc.py
index d068b88..7efeafb 100644
--- a/vdsm/storage/sdc.py
+++ b/vdsm/storage/sdc.py
@@ -28,9 +28,9 @@
 from vdsm.config import config
 from vdsm.storage import exception as se
 
-import multipath
 import lvm
 import misc
+import multipath
 
 # Default cache age until forcibly refreshed
 DEFAULT_REFRESH_INTERVAL = 300


-- 
To view, visit https://gerrit.ovirt.org/55260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id949a69853e2c97a4f1177cd3e717b9c956d03c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.threadPool

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.threadPool
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7e96ac259029aa12ee548a8113c1fbcbf82d26c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Oraganize imports in storage.sdc

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Oraganize imports in storage.sdc
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id949a69853e2c97a4f1177cd3e717b9c956d03c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.iscsiadm

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage: Organize imports in storage.iscsiadm
..

storage: Organize imports in storage.iscsiadm

Change-Id: Ie6a356824572c14da5baa862cf20e872767fb52e
Signed-off-by: Nir Soffer 
---
M vdsm/storage/iscsiadm.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/55261/1

diff --git a/vdsm/storage/iscsiadm.py b/vdsm/storage/iscsiadm.py
index 03e2e97..9285d09 100644
--- a/vdsm/storage/iscsiadm.py
+++ b/vdsm/storage/iscsiadm.py
@@ -19,12 +19,15 @@
 #
 
 import re
+
 from collections import namedtuple
 from threading import Lock
-import misc
+
 from vdsm import constants
 from vdsm.utils import AsyncProcessOperation
 
+import misc
+
 # iscsiadm exit statuses
 ISCSI_ERR_SESS_EXISTS = 15
 ISCSI_ERR_LOGIN_AUTH_FAILED = 24


-- 
To view, visit https://gerrit.ovirt.org/55261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6a356824572c14da5baa862cf20e872767fb52e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Fix copyright years in storage.imagetickets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Fix copyright years in storage.imagetickets
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55257
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0abb7d2f8d2aa3f952cd37c3813afc696a4cef58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.outOfProcess

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.outOfProcess
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I723200491287229da72edf5179e1646df9f40195
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Fix copyright years in storage.imagetickets

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage: Fix copyright years in storage.imagetickets
..

storage: Fix copyright years in storage.imagetickets

This module does not cotain any code from 2009.

Change-Id: I0abb7d2f8d2aa3f952cd37c3813afc696a4cef58
Signed-off-by: Nir Soffer 
---
M vdsm/storage/imagetickets.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/55257/1

diff --git a/vdsm/storage/imagetickets.py b/vdsm/storage/imagetickets.py
index dfa14d6..085d8c0 100644
--- a/vdsm/storage/imagetickets.py
+++ b/vdsm/storage/imagetickets.py
@@ -1,5 +1,5 @@
 #
-# Copyright 2009-2016 Red Hat, Inc.
+# Copyright 2016 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by


-- 
To view, visit https://gerrit.ovirt.org/55257
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0abb7d2f8d2aa3f952cd37c3813afc696a4cef58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Fix copyright years in storage.imagetickets

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Fix copyright years in storage.imagetickets
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55257
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0abb7d2f8d2aa3f952cd37c3813afc696a4cef58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.imagetickets

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Organize imports in storage.imagetickets
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91bc1c76ba3c6bd6ad79c7b4b751df7024c6f29b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.imagetickets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.imagetickets
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91bc1c76ba3c6bd6ad79c7b4b751df7024c6f29b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.outOfProcess

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage: Organize imports in storage.outOfProcess
..

storage: Organize imports in storage.outOfProcess

Change-Id: I723200491287229da72edf5179e1646df9f40195
Signed-off-by: Nir Soffer 
---
M vdsm/storage/outOfProcess.py
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/55256/1

diff --git a/vdsm/storage/outOfProcess.py b/vdsm/storage/outOfProcess.py
index 40c78d5..47daac3 100644
--- a/vdsm/storage/outOfProcess.py
+++ b/vdsm/storage/outOfProcess.py
@@ -17,28 +17,29 @@
 #
 # Refer to the README and COPYING files for full details of the license
 #
+
 import errno
 import grp
 import logging
 import os
 import stat
 import sys
+import threading
 import types
-from warnings import warn
 import weakref
 
-from vdsm import constants
-from vdsm.config import config
-from vdsm.storage import exception as se
-
-import threading
 from functools import partial
+from warnings import warn
 
 try:
 from ioprocess import IOProcess
 except ImportError:
 pass
 
+from vdsm import constants
+from vdsm.config import config
+from vdsm.storage import exception as se
+
 from remoteFileHandler import RemoteFileHandlerPool
 
 RFH = 'rfh'


-- 
To view, visit https://gerrit.ovirt.org/55256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I723200491287229da72edf5179e1646df9f40195
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.imagetickets

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage: Organize imports in storage.imagetickets
..

storage: Organize imports in storage.imagetickets

3rd party libraries such as ovirt_image_daemon should appear before vdsm
library modules.

Change-Id: I91bc1c76ba3c6bd6ad79c7b4b751df7024c6f29b
Signed-off-by: Nir Soffer 
---
M vdsm/storage/imagetickets.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/55258/1

diff --git a/vdsm/storage/imagetickets.py b/vdsm/storage/imagetickets.py
index 085d8c0..6301b27 100644
--- a/vdsm/storage/imagetickets.py
+++ b/vdsm/storage/imagetickets.py
@@ -26,14 +26,14 @@
 
 from contextlib import closing
 
-from vdsm import constants
-from vdsm.storage import exception as se
-
 try:
 from ovirt_image_daemon import uhttp
 except ImportError:
 uhttp = None
 
+from vdsm import constants
+from vdsm.storage import exception as se
+
 DAEMON_SOCK = os.path.join(constants.P_VDSM_RUN, "ovirt-image-daemon.sock")
 
 log = logging.getLogger('storage.imagetickets')


-- 
To view, visit https://gerrit.ovirt.org/55258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91bc1c76ba3c6bd6ad79c7b4b751df7024c6f29b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage:  Move threadLocal module to vdsm storage lib
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 27:

(8 comments)

https://gerrit.ovirt.org/#/c/52864/27/lib/api/schemaapi.py
File lib/api/schemaapi.py:

Line 37: from vdsm import constants
Line 38: 
Line 39: localpath = os.path.dirname(__file__)
Line 40: installedpath = constants.P_VDSM_RPC
Line 41: for directory in localpath, installedpath:
This works but very confusing - please use:

for directory in (localpath, installedpath):
...
Line 42: path = os.path.join(directory, schema_name + '.yaml')
Line 43: # we use source tree and deployment directory
Line 44: # so we need to check whether file exists
Line 45: if os.access(path, os.R_OK):


Line 41: for directory in localpath, installedpath:
Line 42: path = os.path.join(directory, schema_name + '.yaml')
Line 43: # we use source tree and deployment directory
Line 44: # so we need to check whether file exists
Line 45: if os.access(path, os.R_OK):
Do you want to test if the file exists, or accessible? If you want to check if 
the file exists, use os.path.exists().

If the file exists and not readable to vdsm we should blow up loudly, not skip 
the file silently.
Line 46: return path
Line 47: 
Line 48: raise SchemaNotFound("Unable to find API schema file in %s or %s",
Line 49:  localpath, installedpath)


Line 42: path = os.path.join(directory, schema_name + '.yaml')
Line 43: # we use source tree and deployment directory
Line 44: # so we need to check whether file exists
Line 45: if os.access(path, os.R_OK):
Line 46: return path
This code will skip *existing* schema but unreadable in one directory, and 
return the next. We should return the first and fail when trying to read it.
Line 47: 
Line 48: raise SchemaNotFound("Unable to find API schema file in %s or %s",
Line 49:  localpath, installedpath)
Line 50: 


Line 56: self._types = {}
Line 57: try:
Line 58: for path in paths:
Line 59: with open(path) as f:
Line 60: loaded_schema = yaml.load(f)
Once you loaded the schema, you can close the file. The current code will close 
the file only when finishing the update. This is very interesting in this 
context, but a general bad practice.

Should be:

with open(...) as f:
schema = yaml.load(f)
update ...
Line 61: types = loaded_schema.pop('types')
Line 62: self._types.update(types)
Line 63: self._methods.update(loaded_schema)
Line 64: except IOError:


Line 61: types = loaded_schema.pop('types')
Line 62: self._types.update(types)
Line 63: self._methods.update(loaded_schema)
Line 64: except IOError:
Line 65: raise SchemaNotFound("Unable to find API schema file")
Are you sure this always raises IOError? and never OSError? the safe way to  
catch both is to use EnvironmentError, their parent class.
Line 66: 
Line 67: def get_params(self, class_name, method_name):
Line 68: return self.get_method(class_name, method_name).get('params', 
[])
Line 69: 


Line 64: except IOError:
Line 65: raise SchemaNotFound("Unable to find API schema file")
Line 66: 
Line 67: def get_params(self, class_name, method_name):
Line 68: return self.get_method(class_name, method_name).get('params', 
[])
This assumes that get_method return always a dict...

It will raise AttributeError when you try None.get('params', [])
Line 69: 
Line 70: def get_ret_param(self, class_name, method_name):
Line 71: return self.get_method(class_name, method_name).get('return', 
{})
Line 72: 


Line 70: def get_ret_param(self, class_name, method_name):
Line 71: return self.get_method(class_name, method_name).get('return', 
{})
Line 72: 
Line 73: def get_method(self, class_name, method_name):
Line 74: return self._methods.get('%s.%s' % (class_name, method_name))
This may return None...
Line 75: 
Line 76: def get_type(self, type_name):


Line 73: def get_method(self, class_name, method_name):
Line 74: return self._methods.get('%s.%s' % (class_name, method_name))
Line 75: 
Line 76: def get_type(self, type_name):
Line 77: return self._types.get(type_name)
Why do you use _types.get(name) and not _types[name]?

The first form will return None, leading to unclear AttributeError when someone 
try to call methods on None, which the seconds form wil fail in a very clear 
way with KeyError. Typically it is much easier to debug, and it is also faster.

Same for other accessors.


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit 

Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage:  Move threadLocal module to vdsm storage lib
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage:  Move threadLocal module to vdsm storage lib
..

storage:  Move threadLocal module to vdsm storage lib

Move storage.threadLocal to vdsm.storage.threadlocal

Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2
Signed-off-by: Nir Soffer 
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/storage/Makefile.am
R lib/vdsm/storage/threadlocal.py
M vdsm.spec.in
M vdsm/storage/Makefile.am
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/task.py
M vdsm/storage/volume.py
12 files changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/55255/1

diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 7cd497c..cfa77cd 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -67,6 +67,7 @@
 ./usr/lib/python2.7/dist-packages/vdsm/storage/persistent.py
 ./usr/lib/python2.7/dist-packages/vdsm/storage/securable.py
 ./usr/lib/python2.7/dist-packages/vdsm/storage/sync.py
+./usr/lib/python2.7/dist-packages/vdsm/storage/threadlocal.py
 ./usr/lib/python2.7/dist-packages/vdsm/supervdsm.py
 ./usr/lib/python2.7/dist-packages/vdsm/taskset.py
 ./usr/lib/python2.7/dist-packages/vdsm/tool/__init__.py
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 9671eed..95d0953 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -115,7 +115,6 @@
 ./usr/share/vdsm/storage/storage_mailbox.py
 ./usr/share/vdsm/storage/task.py
 ./usr/share/vdsm/storage/taskManager.py
-./usr/share/vdsm/storage/threadLocal.py
 ./usr/share/vdsm/storage/threadPool.py
 ./usr/share/vdsm/storage/volume.py
 ./usr/share/vdsm/sitecustomize.py
diff --git a/lib/vdsm/storage/Makefile.am b/lib/vdsm/storage/Makefile.am
index b98e713..d5a1106 100644
--- a/lib/vdsm/storage/Makefile.am
+++ b/lib/vdsm/storage/Makefile.am
@@ -28,4 +28,5 @@
persistent.py \
securable.py \
sync.py \
+   threadlocal.py \
$(NULL)
diff --git a/vdsm/storage/threadLocal.py b/lib/vdsm/storage/threadlocal.py
similarity index 95%
rename from vdsm/storage/threadLocal.py
rename to lib/vdsm/storage/threadlocal.py
index ea245d0..d76f9e1 100644
--- a/vdsm/storage/threadLocal.py
+++ b/lib/vdsm/storage/threadlocal.py
@@ -1,5 +1,5 @@
 #
-# Copyright 2011 Red Hat, Inc.
+# Copyright 2011-2016 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 13918f3..04ab65e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -946,7 +946,6 @@
 %{_datadir}/%{vdsm_name}/storage/storageServer.py*
 %{_datadir}/%{vdsm_name}/storage/taskManager.py*
 %{_datadir}/%{vdsm_name}/storage/task.py*
-%{_datadir}/%{vdsm_name}/storage/threadLocal.py*
 %{_datadir}/%{vdsm_name}/storage/threadPool.py*
 %{_datadir}/%{vdsm_name}/storage/volume.py*
 %{_datadir}/%{vdsm_name}/storage/imageRepository/__init__.py*
@@ -1151,6 +1150,7 @@
 %{python_sitelib}/%{vdsm_name}/storage/persistent.py*
 %{python_sitelib}/%{vdsm_name}/storage/securable.py*
 %{python_sitelib}/%{vdsm_name}/storage/sync.py*
+%{python_sitelib}/%{vdsm_name}/storage/threadlocal.py*
 %{python_sitelib}/%{vdsm_name}/tc/__init__.py*
 %{python_sitelib}/%{vdsm_name}/tc/_parser.py*
 %{python_sitelib}/%{vdsm_name}/tc/_wrapper.py*
diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am
index 20011b8..d964084 100644
--- a/vdsm/storage/Makefile.am
+++ b/vdsm/storage/Makefile.am
@@ -63,7 +63,6 @@
storageServer.py \
taskManager.py \
task.py \
-   threadLocal.py \
threadPool.py \
volume.py
 
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 18ff490..a42bbf6 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -27,6 +27,7 @@
 from vdsm import exception
 from vdsm.config import config
 from vdsm.storage import exception as se
+from vdsm.storage.threadlocal import vars
 import vdsm.utils as utils
 
 import volume
@@ -39,7 +40,6 @@
 import task
 import lvm
 import resourceManager as rm
-from threadLocal import vars
 from sdc import sdCache
 from resourceFactories import LVM_ACTIVATION_NAMESPACE
 import fileUtils
diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index 0afe6f3..a78a328 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -28,6 +28,7 @@
 from vdsm.storage import exception as se
 from vdsm.storage.constants import FILE_VOLUME_PERMISSIONS
 from vdsm.storage.constants import LEASE_FILEEXT
+from vdsm.storage.threadlocal import vars
 
 from sdc import sdCache
 import outOfProcess as oop
@@ -38,7 +39,6 @@
 import misc
 from misc import deprecated
 import task
-from threadLocal import vars
 
 META_FILEEXT = ".meta"
 

Change in vdsm[master]: monitoring: Add process helpers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Add process helpers
..


Patch Set 2: Verified+1

Verified using the tests.

-- 
To view, visit https://gerrit.ovirt.org/55254
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a8e452ce2acd3aebdc76212a534e6d4a5638d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 31: Verified+1

Verified using the tests.

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 14: Verified+1

Verified using the tests.

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 31:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Add process helpers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Add process helpers
..


Patch Set 2:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55254
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a8e452ce2acd3aebdc76212a534e6d4a5638d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 14:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 13:

This version rename the module using the same style as asyncore and asynchat. 
The code is mostly take from asyncio, but the usage is limited to asyncore and 
asynchat.

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Make QCOW2_COMPAT configurable

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Make QCOW2_COMPAT configurable
..


Patch Set 2: Code-Review+1

Thanks Pavel! Waiting for another ack from storage.

-- 
To view, visit https://gerrit.ovirt.org/54759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5272171a4b4931698911ab251e3a34c286908be4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Gashev 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Add process helpers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Add process helpers
..


Patch Set 1:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55254
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a8e452ce2acd3aebdc76212a534e6d4a5638d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 30:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 13:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Add process helpers

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: monitoring: Add process helpers
..

monitoring: Add process helpers

Add helpers for running processes using the event loop:

BufferedReader   read data from file descriptor or a pipe and notify
 when the read was completed. Useful for collecting
 process output.

Reaper   wait until process exits and return its exit code.
 Useful when process has closed th standard streams
 before terminating.

Change-Id: Ic7a8e452ce2acd3aebdc76212a534e6d4a5638d9
Bug-Url: https://bugzilla.redhat.com/1081962
Signed-off-by: Nir Soffer 
---
M lib/vdsm/storage/asyncevent.py
M tests/storage_asyncevent_test.py
2 files changed, 161 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/55254/1

diff --git a/lib/vdsm/storage/asyncevent.py b/lib/vdsm/storage/asyncevent.py
index 6d4c29f..cc8cab2 100644
--- a/lib/vdsm/storage/asyncevent.py
+++ b/lib/vdsm/storage/asyncevent.py
@@ -455,3 +455,70 @@
 self._wfd = -1
 os.close(wfd)
 asyncore.file_dispatcher.close(self)
+
+
+class BufferedReader(asyncore.file_dispatcher):
+"""
+Read from file until file is close and notify when read was completed.
+"""
+
+def __init__(self, fd, complete, bufsize=4096, map=None):
+asyncore.file_dispatcher.__init__(self, fd, map=map)
+filecontrol.set_close_on_exec(self._fileno)
+self._complete = complete
+self._bufsize = bufsize
+self._data = bytearray()
+
+def handle_read(self):
+chunk = self.socket.read(self._bufsize)
+if not chunk:
+self.handle_close()
+return
+self._data += chunk
+
+def handle_close(self):
+self._complete(self._data)
+self.close()
+
+def handle_error(self):
+log.exception("Unhandled error in %s", self)
+self.handle_close()
+
+def close(self):
+# asyncore.dispatcher define closing attribute, but doe not use it.
+if self.closing:
+return
+self.closing = True
+self._complete = None
+asyncore.file_dispatcher.close(self)
+
+def writable(self):
+return False
+
+
+class Reaper(object):
+"""
+Wait for process and notify when it has terminated.
+"""
+
+def __init__(self, loop, proc, complete, min_interval=2**-5,
+ max_interval=1.0):
+self._loop = loop
+self._proc = proc
+self._complete = complete
+self._interval = min_interval
+self._max_interval = max_interval
+self._count = 0
+self._loop.call_later(self._interval, self.reap)
+
+def reap(self):
+self._count += 1
+rc = self._proc.poll()
+if rc is None:
+if self._interval < self._max_interval:
+self._interval *= 2
+self._loop.call_later(self._interval, self.reap)
+return
+log.debug("Process %s terminated (count=%d)", self._proc, self._count)
+self._complete(rc)
+self._complete = None
diff --git a/tests/storage_asyncevent_test.py b/tests/storage_asyncevent_test.py
index eaa50be..ec18412 100644
--- a/tests/storage_asyncevent_test.py
+++ b/tests/storage_asyncevent_test.py
@@ -21,9 +21,12 @@
 from __future__ import print_function
 
 import asyncore
+import os
 import random
 import socket
+import subprocess
 import time
+from contextlib import closing
 
 from testValidation import slowtest
 from testlib import VdsmTestCase
@@ -487,3 +490,94 @@
 
 def writable(self):
 return False
+
+
+@expandPermutations
+class TestBufferedReader(VdsmTestCase):
+
+def setUp(self):
+self.loop = asyncevent.EventLoop()
+self.received = None
+
+def tearDown(self):
+self.loop.close()
+
+def complete(self, data):
+self.received = data
+self.loop.stop()
+
+@permutations([
+# size, bufsize
+(0, 1),
+(1, 32),
+(1024, 256),
+(4096, 1024),
+(16384, 4096),
+(65536, 16384),
+])
+def test_read(self, size, bufsize):
+data = b"x" * size
+r, w = os.pipe()
+reader = self.loop.create_dispatcher(
+asyncevent.BufferedReader, r, self.complete, bufsize=bufsize)
+with closing(reader):
+os.close(r)  # Dupped by BufferedReader
+Sender(self.loop, w, data, bufsize)
+self.loop.run_forever()
+self.assertEqual(self.received, data)
+
+
+class Sender(object):
+
+def __init__(self, loop, fd, data, bufsize):
+self.loop = loop
+self.fd = fd
+self.data = data
+self.pos = 0
+self.bufsize = bufsize
+self.loop.call_soon(self.send)
+
+def send(self):
+if self.pos == len(self.data):
+ 

Change in vdsm[master]: spec: bump safelease version

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: bump safelease version
..


Patch Set 6: Verified+1

the safelease package is available on CentOS 7:

[root@goji ~]# yum info safelease
Loaded plugins: fastestmirror, langpacks
Loading mirror speeds from cached hostfile
 * base: ct.mirror.garr.it
 * epel: mirrors.ircam.fr
 * extras: ct.mirror.garr.it
 * ovirt-3.5: ftp.plusline.net
 * ovirt-3.5-epel: mirrors.ircam.fr
 * ovirt-3.6: ftp.plusline.net
 * ovirt-3.6-epel: mirrors.ircam.fr
 * updates: ct.mirror.garr.it
Installed Packages
Name: safelease
Arch: x86_64
Version : 1.0
Release : 7.el7
Size: 43 k
Repo: installed
From repo   : ovirt-3.6-epel
Summary : Legacy locking utility for VDSM
URL : http://www.ovirt.org/Safelease
License : GPLv2+
Description : Safelease is a legacy cluster lock utility used by VDSM. It is 
based on
: the algorithm presented in the article "Light-Weight Leases for
: Storage-Centric Coordination" by G Chockler and D Malkhi.

-- 
To view, visit https://gerrit.ovirt.org/54798
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib96fee604db1fa73f9b000c26a27153c54a94f86
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1:

It looks like hsm makes them optional:

@public
def createStoragePool(self, poolType, spUUID, poolName, masterDom,
  domList, masterVersion, lockPolicy=None,
  lockRenewalIntervalSec=None, leaseTimeSec=None,
  ioOpTimeoutSec=None, leaseRetries=None,
  options=None):

not sure why they are defined as required on API.py level.

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1:

It looks like xmlrpc was providing some default values:

 def poolCreate(self, poolType, spUUID, poolName, masterDom, domList,
masterVersion, lockPolicy=None, lockRenewalIntervalSec=None,
leaseTimeSec=None, ioOpTimeoutSec=None,
leaseRetries=None, options=None):

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Make QCOW2_COMPAT configurable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Make QCOW2_COMPAT configurable
..


Patch Set 2:

* #1317850::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1317850::OK, public bug
* Check Product::#1317850::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5272171a4b4931698911ab251e3a34c286908be4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Gashev 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1:

Sandro checking API.py I can see following params needed by this call :
def __init__(self, UUID):

and

def create(self, name, masterSdUUID, masterVersion, domainList,
   lockRenewalIntervalSec, leaseTimeSec, ioOpTimeoutSec,
   leaseRetries)

All of the params are required so need to be provided.

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..


jsonrpcvdscli: getStorageDomainsList verb

Add getStorageDomainsList used by ovirt-hoste-engine-setup.

Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
Reviewed-on: https://gerrit.ovirt.org/55249
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Sandro Bonazzola: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


jsonrpcvdscli: connectStorageServer verb

Add connectStorageServer used by ovirt-hoste-engine-setup.

Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
Reviewed-on: https://gerrit.ovirt.org/55247
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Sandro Bonazzola: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: usage of yaml schema

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: bridge: usage of yaml schema
..


Patch Set 10: Verified+1

Fixed issue with default types such as tuple and dict. Yaml parser assumed them 
to be strings. Verified by calling getDeviceList using UI.

-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 10: Verified+1

Rebase only no code changes.

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 27: Verified+1

Updated default types in schema file. No code changes.

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: el7: require newly available python34-nose

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: el7: require newly available python34-nose
..


Patch Set 8:

When I run a build on el7 it fails with:

error: Failed build dependencies:
python34-nose is needed by vdsm-4.17.999-839.git248f9bb.el7.noarch
python34-six is needed by vdsm-4.17.999-839.git248f9bb.el7.noarch

Please fix.

-- 
To view, visit https://gerrit.ovirt.org/54685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e19a5bbbf71227230bc3c354453e5884dc10764
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1: Verified-1

[ ERROR ] Failed to execute stage 'Misc configuration': Attempt to call 
function: > with arguments: (u'e37bf754-e0f3-4515-98b9-4e8b4572f33b', 
u'hosted_datacenter', u'b6fce4d5-f142-4e61-89c9-dd80c5930e7c', 
[u'b6fce4d5-f142-4e61-89c9-dd80c5930e7c', 
u'5d6d70e5-34ab-4654-8880-7297bab5b8e4'], 1) error: create() takes exactly 9 
arguments (6 given)

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: usage of yaml schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridge: usage of yaml schema
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: fix naming style

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridge: fix naming style
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54948
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I149b233303a7bddfc52a7d690e77ae91b8152f84
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 27:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

[automation]

gerrit-hooks has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 131, in 
_executeMethod
method['method']()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 1283, in _misc
self._createStorageDomain()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 857, in _createStorageDomain
raise RuntimeError(status['status']['message'])
RuntimeError: Invalid parameter: 'sdUUID=1


jsonrpc.Executor/4::INFO::2016-03-25 
16:54:55,132::logUtils::49::dispatcher::(wrapper) Run and protect: 
createStorageDomain(storageType=u'5d6d70e5-34ab-4654-8880-7297bab5b8e4', 
sdUUID=1, domainName=u'mididell.ho
me:/home/sata', typeSpecificArg=u'hosted_storage', domClass=1, domVersion=3, 
options=None)
jsonrpc.Executor/4::ERROR::2016-03-25 
16:54:55,133::task::868::Storage.TaskManager.Task::(_setError) 
Task=`c56872b6-90fb-4859-bdec-3373f2355176`::Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 875, in _run
return fn(*args, **kargs)
  File "/usr/lib/python2.7/site-packages/vdsm/logUtils.py", line 50, in wrapper
res = f(*args, **kwargs)
  File "/usr/share/vdsm/storage/hsm.py", line 2641, in createStorageDomain
misc.validateUUID(sdUUID, 'sdUUID')
  File "/usr/share/vdsm/storage/misc.py", line 430, in validateUUID
raise se.InvalidParameterException(name, uuid)
InvalidParameterException: Invalid parameter: 'sdUUID=1'
jsonrpc.Executor/4::DEBUG::2016-03-25 
16:54:55,133::task::887::Storage.TaskManager.Task::(_run) 
Task=`c56872b6-90fb-4859-bdec-3373f2355176`::Task._run: 
c56872b6-90fb-4859-bdec-3373f2355176 (u'5d6d70e5-34ab-4654-
8880-7297bab5b8e4', 1, u'mididell.home:/home/sata', u'hosted_storage', 1, 3) {} 
failed - stopping task


Looks again that vdscli and jsonrpcvdscli use different arguments ordering.

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: add storage verbs
..

jsonrpcvdscli: add storage verbs

Add verbs used by ovirt-hosted-engine-setup for
handling the storage setup.

Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 27 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/55252/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 918b361..11738a2 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -39,18 +39,39 @@
 
 
 _COMMAND_CONVERTER = {
+'activateStorageDomain': 'StorageDomain.activate',
+'connectStoragePool': 'StoragePool.connect',
 'connectStorageServer': 'StoragePool.connectStorageServer',
 'create': 'VM.create',
+'createStorageDomain': 'StorageDomain.create',
+'createStoragePool': 'StoragePool.create',
+'createVG': 'LVMVolumeGroup.create',
 'destroy': 'VM.destroy',
+'destroyStoragePool': 'StoragePool.destroy',
+'detachStorageDomain': 'StorageDomain.detach',
+'disconnectStoragePool': 'StoragePool.disconnect',
 'disconnectStorageServer': 'StoragePool.disconnectStorageServer',
+'discoverSendTargets': 'ISCSIConnection.discoverSendTargets',
+'formatStorageDomain': 'StorageDomain.format',
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
+'getDeviceList': 'Host.getDeviceList',
+'getStorageDomainInfo': 'StorageDomain.getInfo',
 'getStorageDomainsList': 'Host.getStorageDomains',
+'getStorageDomainStats': 'StorageDomain.getStats',
+'getStoragePoolInfo': 'StoragePool.getInfo',
+'getSpmStatus': 'StoragePool.getSpmStatus',
 'getVdsCapabilities': 'Host.getCapabilities',
 'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',
+'getVGInfo': 'LVMVolumeGroup.getInfo',
 'getVmStats': 'VM.getStats',
+'glusterVolumeCreate': 'GlusterVolume.create',
+'glusterVolumeSet': 'GlusterVolume.set',
+'glusterVolumesList': 'GlusterVolume.list',
+'glusterVolumeStart': 'GlusterVolume.start',
+'glusterTasksList': 'GlusterTask.list',
 'hotplugDisk': 'VM.hotplugDisk',
 'hotplugNic': 'VM.hotplugNic',
 'hotunplugDisk': 'VM.hotunplugDisk',
@@ -58,13 +79,19 @@
 'list': 'Host.getVMList',
 'migrationCreate': 'VM.migrationCreate',
 'ping': 'Host.ping',
+'repoStats': 'Host.getStorageRepoStats',
 'setBalloonTarget': 'VM.setBalloonTarget',
 'setCpuTunePeriod': 'VM.setCpuTunePeriod',
 'setCpuTuneQuota': 'VM.setCpuTuneQuota',
 'setMOMPolicy': 'Host.setMOMPolicy',
 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
 'setupNetworks': 'Host.setupNetworks',
+'spmStart': 'StoragePool.spmStart',
+'spmStop': 'StoragePool.spmStop',
+'startMonitoringDomain': 'Host.startMonitoringDomain',
+'stopMonitoringDomain': 'Host.stopMonitoringDomain',
 'updateVmPolicy': 'VM.updateVmPolicy',
+'validateStorageDomain': 'StorageDomain.validate',
 }
 
 


-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Move saveState() out of constructor

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: Move saveState() out of constructor
..


Patch Set 6:

(1 comment)

I'm thinking again about the error paths.

https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 685: if not acquired:
Line 686: self._vmAsyncStartError = 
response.error('migrateLimit')
Line 687: self._vmStartEvent.set()
Line 688: return
Line 689: 
I'd rather move the saveState() here from line 668 here.
reasons:
1. it is still in the sync portion thanks to the vmStartEvent event
2. it prevents any form of concurrent saveState() run between the thread 
running Vm.run() and the creation thread
Line 690: self._vmStartEvent.set()
Line 691: try:
Line 692: self.memCommit()
Line 693: with self._ongoingCreations:


-- 
To view, visit https://gerrit.ovirt.org/53950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: configurator: libvirt: do not jump on virtlogd

[fromani]

Francesco Romani has posted comments on this change.

Change subject: configurator: libvirt: do not jump on virtlogd
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55225
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I548560af8e78a69210917c36d229206663beaaf7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: disconnectStorageServer verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: disconnectStorageServer verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: configurator: libvirt: do not jump on virtlogd

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configurator: libvirt: do not jump on virtlogd
..


Patch Set 4:

* #1318902::Update tracker: OK
* Set MODIFIED::bug 1318902#1318902IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/55225
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I548560af8e78a69210917c36d229206663beaaf7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: configurator: libvirt: do not jump on virtlogd

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: configurator: libvirt: do not jump on virtlogd
..


configurator: libvirt: do not jump on virtlogd

Libvirt 1.3.0 adds and uses by default a new service called virtlogd
to prevent malicious QEMU guests to DoS the virtualization host.
For more details, the initial announcement is here:
https://www.redhat.com/archives/libvir-list/2015-November/msg00085.html

The feature seems promising and helpful, but we are
not eager to jump early on this bandwagon, do we disable
this for the near future.

Once the feature is stable and we run our integration test,
we will re-enable it.

Change-Id: I548560af8e78a69210917c36d229206663beaaf7
Backport-To: 3.6
Temporary-Patch: yes
Bug-Url: https://bugzilla.redhat.com/1318902
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/55189
Continuous-Integration: Jenkins CI
Reviewed-by: Michal Skrivanek 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/55225
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/55225
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I548560af8e78a69210917c36d229206663beaaf7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: configurator: libvirt: do not jump on virtlogd

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: configurator: libvirt: do not jump on virtlogd
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55225
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I548560af8e78a69210917c36d229206663beaaf7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: disconnectStorageServer verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: disconnectStorageServer verb
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: disconnectStorageServer verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: disconnectStorageServer verb
..

jsonrpcvdscli: disconnectStorageServer verb

Add disconnectStorageServer used by ovirt-hoste-engine-setup.

Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/55250/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index af0e9d6..918b361 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -42,6 +42,7 @@
 'connectStorageServer': 'StoragePool.connectStorageServer',
 'create': 'VM.create',
 'destroy': 'VM.destroy',
+'disconnectStorageServer': 'StoragePool.disconnectStorageServer',
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',


-- 
To view, visit https://gerrit.ovirt.org/55250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: configurator: libvirt: do not jump on virtlogd

[fromani]

Francesco Romani has posted comments on this change.

Change subject: configurator: libvirt: do not jump on virtlogd
..


Patch Set 3: Verified+1

re-verified on branch:

HOji> 14:41:42 root [~]$ grep stdio /etc/libvirt/qemu.conf
stdio_handler="file"
HOji> 14:42:31 root [~]$ rpm -qa | grep libvirt-daemon
libvirt-daemon-driver-qemu-1.2.17-13.el7.x86_64
libvirt-daemon-1.2.17-13.el7.x86_64
libvirt-daemon-driver-storage-1.2.17-13.el7.x86_64
libvirt-daemon-driver-interface-1.2.17-13.el7.x86_64
libvirt-daemon-driver-nodedev-1.2.17-13.el7.x86_64
libvirt-daemon-config-nwfilter-1.2.17-13.el7.x86_64
libvirt-daemon-driver-nwfilter-1.2.17-13.el7.x86_64
libvirt-daemon-driver-secret-1.2.17-13.el7.x86_64
libvirt-daemon-driver-network-1.2.17-13.el7.x86_64
libvirt-daemon-kvm-1.2.17-13.el7.x86_64
HOji> 14:42:40 root [~]$ rpm -qa | grep qemu-kvm
qemu-kvm-tools-ev-2.3.0-31.el7_2.7.1.x86_64
qemu-kvm-ev-2.3.0-31.el7_2.7.1.x86_64
qemu-kvm-common-ev-2.3.0-31.el7_2.7.1.x86_64
HOji> 14:42:45 root [~]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.2 (Maipo)


works OK as expected.

-- 
To view, visit https://gerrit.ovirt.org/55225
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I548560af8e78a69210917c36d229206663beaaf7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: el7: require newly available python34-nose

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: el7: require newly available python34-nose
..


el7: require newly available python34-nose

Recently, (as of rhbz#1294865 and rhbz#1294862) six and nose are
available to python3 users via EPEL7. This patch requires their
availability on build hosts.

Change-Id: I8e19a5bbbf71227230bc3c354453e5884dc10764
Signed-off-by: Dan Kenigsberg 
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: https://gerrit.ovirt.org/54685
Continuous-Integration: Jenkins CI
---
M Makefile.am
M automation/build-artifacts.repos.el7
C automation/check-merged.packages.el7
R automation/check-merged.packages.fc23
C automation/check-patch.packages.el7
R automation/check-patch.packages.fc23
M automation/check-patch.repos.el7
M tests/Makefile.am
M vdsm.spec.in
9 files changed, 17 insertions(+), 19 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e19a5bbbf71227230bc3c354453e5884dc10764
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: el7: require newly available python34-nose

[automation]

gerrit-hooks has posted comments on this change.

Change subject: el7: require newly available python34-nose
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e19a5bbbf71227230bc3c354453e5884dc10764
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: el7: require newly available python34-nose

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: el7: require newly available python34-nose
..


Patch Set 7: Code-Review+2 Verified+1

build passes on el7 and f23.

-- 
To view, visit https://gerrit.ovirt.org/54685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e19a5bbbf71227230bc3c354453e5884dc10764
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..

jsonrpcvdscli: getStorageDomainsList verb

Add getStorageDomainsList used by ovirt-hoste-engine-setup.

Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/55249/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 88e2cf5..af0e9d6 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -45,6 +45,7 @@
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
+'getStorageDomainsList': 'Host.getStorageDomains',
 'getVdsCapabilities': 'Host.getCapabilities',
 'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',


-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 1: Code-Review+2

It looks like required params are provided in wrong order. The mapping looks OK.

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 1: Verified+1

Changed order between spUUID and type in the call and it worked.
Note that vdscli and jsonrpcvdscli are using different ordering.

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: common handling of exceptions
..


virt: common handling of exceptions

Vm methods should not return responses directly.
Rather, they should raise proper exception,
and a common layer should translate them in responses.

In case of succesfull completion, this code automatically
produces a generic success response. Should the method
require extra fields, it can return a dictionary
with the keys to be added to the success response.

Using this way the method could also override the default
keys (e.g. the message). This is not clean but it could
be needed for backward compatibility.

Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Bug-Url: https://bugzilla.redhat.com/1316128
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/54664
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M debian/vdsm-python.install
M lib/vdsm/virt/Makefile.am
A lib/vdsm/virt/api.py
M tests/Makefile.am
A tests/virt_api_test.py
M vdsm.spec.in
6 files changed, 173 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 15:

* #1316128::Update tracker: OK
* Set MODIFIED::bug 1316128#1316128FAILED, illegal change from NEW

-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getConnectedStoragePoolsList verb

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..


jsonrpcvdscli: getConnectedStoragePoolsList verb

Add getConnectedStoragePoolsList used by ovirt-hoste-engine-setup.

Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
Reviewed-on: https://gerrit.ovirt.org/55246
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Sandro Bonazzola: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getConnectedStoragePoolsList verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..


jsonrpcvdscli: add getVdsHardwareInfo verb

Add getVdsHardwareInfo used by ovirt-hoste-engine-setup.

Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
Reviewed-on: https://gerrit.ovirt.org/55244
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Francesco Romani 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Sandro Bonazzola: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 1: Verified-1

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 1: Verified+1

Arguments as in xmlrpc call are: arguments: (1, 
'----', [{'protocol_version': 3, 'connection': 
'mididell.home:/home/sata', 'user': 'kvm', 'id': 
'c0fa7e2f-8b36-41c2-abac-6b8999b7c5d3'}])


Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 131, in 
_executeMethod
method['method']()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 1267, in _late_customization
self._getExistingDomain()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 602, in _getExistingDomain
self._storageServerConnection()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 788, in _storageServerConnection
raise RuntimeError(status['status']['message'])
RuntimeError: Error storage server connection: 
(u"domType=----, spUUID=1, 
conList=[{u'protocol_version': 3, u'connection': u'mididell.home:/home/sata', 
u'user': u'kvm', u'id': u'c
0fa7e2f-8b36-41c2-abac-6b8999b7c5d3'}]",)


jsonrpc.Executor/4::INFO::2016-03-25 
14:49:20,087::logUtils::49::dispatcher::(wrapper) Run and protect: 
connectStorageServer(domType=u'----', spUUID=1, 
conList=[{u'protocol_version': 3, u'connection': u'mididell.home:/home/sata', 
u'user': u'kvm', u'id': u'c0fa7e2f-8b36-41c2-abac-6b8999b7c5d3'}], options=None)
jsonrpc.Executor/4::ERROR::2016-03-25 
14:49:20,087::task::868::Storage.TaskManager.Task::(_setError) 
Task=`81ff52b6-75f7-4996-a989-6d70a0937fd5`::Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 875, in _run
return fn(*args, **kargs)
  File "/usr/lib/python2.7/site-packages/vdsm/logUtils.py", line 50, in wrapper
res = f(*args, **kwargs)
  File "/usr/share/vdsm/storage/hsm.py", line 2423, in connectStorageServer
conInfo = _connectionDict2ConnectionInfo(domType, conDef)
  File "/usr/share/vdsm/storage/hsm.py", line 193, in 
_connectionDict2ConnectionInfo
typeName = CON_TYPE_ID_2_CON_TYPE[conTypeId]
KeyError: u'----'
jsonrpc.Executor/4::DEBUG::2016-03-25 
14:49:20,087::task::887::Storage.TaskManager.Task::(_run) 
Task=`81ff52b6-75f7-4996-a989-6d70a0937fd5`::Task._run: 
81ff52b6-75f7-4996-a989-6d70a0937fd5 (u'----', 
1, [{u'protocol_version': 3, u'connection': u'mididell.home:/home/sata', 
u'user': u'kvm', u'id': u'c0fa7e2f-8b36-41c2-abac-6b8999b7c5d3'}]) {} failed - 
stopping task
jsonrpc.Executor/4::DEBUG::2016-03-25 
14:49:20,087::task::1248::Storage.TaskManager.Task::(stop) 
Task=`81ff52b6-75f7-4996-a989-6d70a0937fd5`::stopping in state preparing (force 
False)
jsonrpc.Executor/4::DEBUG::2016-03-25 
14:49:20,087::task::995::Storage.TaskManager.Task::(_decref) 
Task=`81ff52b6-75f7-4996-a989-6d70a0937fd5`::ref 1 aborting True

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: connectStorageServer verb
..

jsonrpcvdscli: connectStorageServer verb

Add connectStorageServer used by ovirt-hoste-engine-setup.

Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/55247/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 6ad330a..88e2cf5 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -39,6 +39,7 @@
 
 
 _COMMAND_CONVERTER = {
+'connectStorageServer': 'StoragePool.connectStorageServer',
 'create': 'VM.create',
 'destroy': 'VM.destroy',
 'fullList': 'Host.getVMFullList',


-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getConnectedStoragePoolsList verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getConnectedStoragePoolsList verb

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getConnectedStoragePoolsList verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getConnectedStoragePoolsList verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..

jsonrpcvdscli: getConnectedStoragePoolsList verb

Add getConnectedStoragePoolsList used by ovirt-hoste-engine-setup.

Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/55246/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 919e4bf..6ad330a 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -43,6 +43,7 @@
 'destroy': 'VM.destroy',
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
+'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
 'getVdsCapabilities': 'Host.getCapabilities',
 'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',


-- 
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[fromani]

Francesco Romani has posted comments on this change.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..


Patch Set 8: Verified+1

re-verified on FC23

-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..


Patch Set 8:

re-verified on FC23

-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 14: Verified+1

Verified using the tests.

-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..

jsonrpcvdscli: add getVdsHardwareInfo verb

Add getVdsHardwareInfo used by ovirt-hoste-engine-setup.

Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/55244/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index ada5ff5..919e4bf 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -44,6 +44,7 @@
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
 'getVdsCapabilities': 'Host.getCapabilities',
+'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',
 'getVmStats': 'VM.getStats',
 'hotplugDisk': 'VM.hotplugDisk',


-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: use the new response handling

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: use the new response handling
..


Patch Set 9:

(14 comments)

https://gerrit.ovirt.org/#/c/54799/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3937
Line 3938
Line 3939
Line 3940
Line 3941
ValueError is raised form int(target) of from libvirt?

If it si fro int(), please separate the error handlers.


Line 2535: # Find the proper device object
Line 2536: found_device = self._findDeviceByNameOrPath(device_name,
Line 2537: device_path)
Line 2538: if found_device is None:
Line 2539: raise exception.UpdateIOTuneError(
Device not found is a generic error that should be raised by 
_findDeviceByNameOrPath. We should check if the engine can accept such error 
instead of UpdateIOTuneError.
Line 2540: "Device {} not found".format(device_name))
Line 2541: 
Line 2542: # Merge the update with current values
Line 2543: dom = found_device.getXML()


Line 2551: # Verify the ioTune params
Line 2552: try:
Line 2553: found_device._validateIoTuneParams(io_tune)
Line 2554: except ValueError:
Line 2555: raise exception.UpdateIOTuneError('Invalid ioTune 
value')
This error should be raised by _validateIoTuneParams, so this code would be:

found_device._validateIoTuneParams(io_tune)

Without any error checking.

We can also make this change later, but if work on single verbs level, I think 
we should do the fix properly now.

Also the error here should be InvalidParameterError, not IOTune specifc error, 
since we did not try to update iotune parameters. Should check with engine guys 
if this is possible.
Line 2556: 
Line 2557: try:
Line 2558: self._dom.setBlockIoTune(found_device.name, io_tune,
Line 2559:  
libvirt.VIR_DOMAIN_AFFECT_LIVE)


Line 2559:  
libvirt.VIR_DOMAIN_AFFECT_LIVE)
Line 2560: except libvirt.libvirtError as e:
Line 2561: self.log.exception("setVmIoTune failed")
Line 2562: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 2563: raise exception.NoSuchVM()
It would be nice to have wrap the domain object so libvirt.VIR_ERR_NO_DOMAIN 
will raise always NoSuchVM() without having to duplicate this code everywhere.
Line 2564: else:
Line 2565: raise exception.UpdateIOTuneError(e.message)
Line 2566: 
Line 2567: # Update both the ioTune arguments and device xml DOM


Line 2561: self.log.exception("setVmIoTune failed")
Line 2562: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 2563: raise exception.NoSuchVM()
Line 2564: else:
Line 2565: raise exception.UpdateIOTuneError(e.message)
It would be nice to raise here LibvirtError from the domain object wrapper, and 
remove this specific iotune error. Should check with engine guys if this is 
possible.
Line 2566: 
Line 2567: # Update both the ioTune arguments and device xml DOM
Line 2568: # so we are still up-to-date
Line 2569: # TODO: improve once libvirt gets support for iotune 
events


Line 3933: @api.method
Line 3934: def setBalloonTarget(self, target):
Line 3935: 
Line 3936: if not self._dom.connected:
Line 3937: raise exception.BalloonError()
This should raise something like VMNotRunning, not balloon specific error, so 
same error handling can be reused everywhere.
Line 3938: try:
Line 3939: target = int(target)
Line 3940: self._dom.setMemory(target)
Line 3941: except ValueError:


Line 3938: try:
Line 3939: target = int(target)
Line 3940: self._dom.setMemory(target)
Line 3941: except ValueError:
Line 3942: raise exception.BalloonError('an integer is required for 
target')
Again, this should be InvalidParameterError
Line 3943: except libvirt.libvirtError as e:
Line 3944: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3945: raise exception.NoSuchVM()
Line 3946: raise exception.BalloonError(e.message)


Line 3941: except ValueError:
Line 3942: raise exception.BalloonError('an integer is required for 
target')
Line 3943: except libvirt.libvirtError as e:
Line 3944: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3945: raise exception.NoSuchVM()
No such vm again, should not be duplicated in any verb.
Line 3946: raise exception.BalloonError(e.message)
Line 3947: else:
Line 3948: for dev in 

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable 
afterwards
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: use the new response handling

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: use the new response handling
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/54799/8//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Let's start using the new api.method
Line 10: decoratore to handle exceptions and response
Line 11: from few methods already in need of some
Line 12: refactoring and cleanup.
> Not random: I'm starting from the APIs which most need a cleanup.
So I suggest to wait until all apis are changed before we merge the series, to 
avoid mixed error handling in the same code.
Line 13: 
Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b


-- 
To view, visit https://gerrit.ovirt.org/54799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable 
afterwards
..


Patch Set 12:

(4 comments)

https://gerrit.ovirt.org/#/c/54555/12/lib/vdsm/network/configurators/__init__.py
File lib/vdsm/network/configurators/__init__.py:

PS12, Line 214: ipv6_supported
> We seem to need this only when enable=False.
Good point. We better not be silent when the user orders to set up an IPv6 
network on a system where it is not possible. So I extracted the condition out.


PS12, Line 227: logging.warning
> Do we really need it? Won't we explode if something unexpected will happen?
I am afraid I don't follow you.

If you question the purpose of the context manager, well, the code touching 
possibly inexistent sysctl nodes is more likely to explode, unlike other parts 
of ifcfg, which delegates dirty work to initscripts.

But I cannot recall if this in fact protects us more from actually missing 
devices or from the missing /proc/sys/net/ipv6 tree.


https://gerrit.ovirt.org/#/c/54555/12/tests/functional/networkTests.py
File tests/functional/networkTests.py:

PS12, Line 1888: @cleanupNet
> Just checking with you: If the test fail, do we see the correct backtrace? 
This is how the test would fail before https://gerrit.ovirt.org/#/c/55078/ was 
merged. We can see both the inner and the outer function in the backtrace.

No dummies were left over after the tests.

[root@localhost tests]# cd /usr/share/vdsm/tests/; ip link del dev bond0; 
NOSE_TESTMATCH='test_setupNetworks_swap_slaves_between_bonds|test_static_ip_configuration_'
 ./run_tests.sh --enable-slow-tests functional/networkTests.py
Cannot find device "bond0"
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
functional.networkTests.NetworkTest
test_setupNetworks_swap_slaves_between_bondsOK
test_static_ip_configuration_dual_to_v4 FAIL
test_static_ip_configuration_dual_to_v6_and_backOK
test_static_ip_configuration_v4_to_dual OK

==
FAIL: test_static_ip_configuration_dual_to_v4 
(functional.networkTests.NetworkTest)
--
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1883, in 
test_static_ip_configuration_dual_to_v4
self._test_static_ip_configuration(([4, 6], [4]))
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 213, in wrapper
func(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1926, in 
_test_static_ip_configuration
change_ip_configuration_and_verify(ip_families)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1909, in 
change_ip_configuration_and_verify
self.assertEqual(status, SUCCESS, msg)
AssertionError: Nic dummy_w13LD already enslaved to bond1
 >> begin captured logging << 
root: DEBUG: /usr/bin/taskset --cpu-list 0-0 /usr/sbin/tc qdisc show (cwd None)
root: DEBUG: SUCCESS:  = '';  = 0
root: INFO: Adding bond0({'nics': ['dummy_YIvgK', 'dummy_gPt3w'], 'options': 
'mode=0'})
root: INFO: Adding bond1({'nics': ['dummy_mN94G', 'dummy_w13LD'], 'options': 
'mode=0'})
SuperVdsmProxy: DEBUG: Trying to connect to Super Vdsm
- >> end captured logging << -

--
Ran 4 tests in 48.035s

FAILED (failures=1)


PS12, Line 1889: _test_static_ip_configuration
> Thanks, now I understand what is actually tested.
I haven't seen the helper running: what matters is the 'test' prefix.


-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches