Change in vdsm[master]: lib: logUtils: add devel_warn function

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 2:

devel_warn is too ugly, I rushed this patch too early, to not forget about this 
issue. Let's use the logger approach.

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: logUtils: add devel_warn function

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/2/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:

Line 254: _devlog = logging.getLogger('devel')
Line 255: 
Line 256: 
Line 257: def devel_warn(message):
Line 258: if config.getboolean('devel', 'python_warnings_enable'):
> This is very ugly we should kill this option instead.
i guess we shouldn't want this config value if we don't use the broken python 
warning module anymore


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: logUtils: add devel_warn function

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 2: Code-Review-1

(2 comments)

I think we should use the standard logging configuration.

- Add devel logger in logger.conf, set level to ERROR. Developers can change 
the log level of this logger using logger.conf or setLogLevel api. 

- Use this logger when we want to log developer warnings

logging.getLogger('devel').warning(...)

- Not sure we need the devel_warn helper, if you add it, it should provide the 
same signature as Logger.warning.

https://gerrit.ovirt.org/#/c/62209/2/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:

Line 253: 
Line 254: _devlog = logging.getLogger('devel')
Line 255: 
Line 256: 
Line 257: def devel_warn(message):
This is not useful logger interface,  we want to use the same format provided 
by standard logger (log.XXX(fmt, *args)).
Line 258: if config.getboolean('devel', 'python_warnings_enable'):


Line 254: _devlog = logging.getLogger('devel')
Line 255: 
Line 256: 
Line 257: def devel_warn(message):
Line 258: if config.getboolean('devel', 'python_warnings_enable'):
This is very ugly we should kill this option instead.


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: logUtils: add devel_warn function

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 2:

* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: logUtils: add devel_warn function

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org