Change in vdsm[master]: misc: Rename event threads to event/N
gerrit-hooks has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Nir Soffer has submitted this change and it was merged. Change subject: misc: Rename event threads to event/N .. misc: Rename event threads to event/N Each time we submit an event using storage.misc.Event, we start one or two threads. Until now, the threads were using the default Thread-N names. This patch renames these threads to event/N, matching other thread names, and making it easier to detect these threads in system commands like ps or htop. Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/63521 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-by: Adam Litke --- M lib/vdsm/storage/misc.py 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified; Passed CI tests Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Adam Litke has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Adam Litke has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Francesco Romani has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Nir Soffer has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 4: Continuous-Integration+1 CI failures not relevant. -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Nir Soffer has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
gerrit-hooks has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Nir Soffer has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/63521/3//COMMIT_MSG Commit Message: Line 6: Line 7: misc: Rename event threads to event/N Line 8: Line 9: Each time we submit an event using storage.misc.Event, we start one or Line 10: tow threads. Until now, the thread were using the default Thread-N > ->two Fixed Line 11: names. Line 12: Line 13: This patch renames these threads to event/N, matching other thread Line 14: names, and making it easier to detect these threads in system commands -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Freddy Rolland has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63521/3//COMMIT_MSG Commit Message: PS3, Line 10: tow ->two -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Nir Soffer has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
gerrit-hooks has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
gerrit-hooks has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
gerrit-hooks has posted comments on this change. Change subject: misc: Rename event threads to event/N .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: misc: Rename event threads to event/N
Nir Soffer has uploaded a new change for review. Change subject: misc: Rename event threads to event/N .. misc: Rename event threads to event/N Each time we submit an event using storage.misc.Event, we start one or tow threads. Until now, the thread were using the default Thread-N names. This patch renames these threads to event/N, matching other thread names, and making it easier to detect these threads in system commands like ps or htop. Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Signed-off-by: Nir Soffer --- M lib/vdsm/storage/misc.py 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/63521/1 diff --git a/lib/vdsm/storage/misc.py b/lib/vdsm/storage/misc.py index 31a07b0..57b54df 100644 --- a/lib/vdsm/storage/misc.py +++ b/lib/vdsm/storage/misc.py @@ -490,6 +490,9 @@ class Event(object): + +_next = itertools.count().next + def __init__(self, name, sync=False): self._log = logging.getLogger("Storage.Event.%s" % name) self.name = name @@ -520,8 +523,9 @@ if self._sync: func(*args, **kwargs) else: -concurrent.thread(func, args=args, - kwargs=kwargs).start() +t = concurrent.thread(func, args=args, kwargs=kwargs, + name="event/%d" % self._next()) +t.start() except: self._log.warn("Could not run registered method because " "of an exception", exc_info=True) @@ -530,7 +534,9 @@ def emit(self, *args, **kwargs): if len(self._registrar) > 0: -concurrent.thread(self._emit, args=args, kwargs=kwargs).start() +t = concurrent.thread(self._emit, args=args, kwargs=kwargs, + name="event/%d" % self._next()) +t.start() def killall(name, signum, group=False): -- To view, visit https://gerrit.ovirt.org/63521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org