Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Nir Soffer has submitted this change and it was merged. Change subject: storage: Move threadLocal module to vdsm storage lib .. storage: Move threadLocal module to vdsm storage lib Move storage.threadLocal to vdsm.storage.threadlocal Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/55255 Continuous-Integration: Jenkins CI Reviewed-by: Freddy Rolland Reviewed-by: Ala Hino Reviewed-by: Adam Litke --- M lib/vdsm/storage/Makefile.am R lib/vdsm/storage/threadlocal.py M tests/storage_sdm_api_test.py M vdsm.spec.in M vdsm/storage/Makefile.am M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/sdm/api/base.py M vdsm/storage/task.py M vdsm/storage/volume.py 12 files changed, 14 insertions(+), 13 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Adam Litke has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Ala Hino has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Freddy Rolland has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Nir Soffer has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 6: Rebased manually after changes in master, no code change. Please review again. -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Nir Soffer has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Nir Soffer has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 6: Manual rebase, no code change. -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
Amit Aviram has abandoned this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Abandoned We have this patch, waiting for verification: https://gerrit.ovirt.org/55255/ -- To view, visit https://gerrit.ovirt.org/56575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/56575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
Nir Soffer has posted comments on this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Patch Set 3: We have this patch, waiting for verification: https://gerrit.ovirt.org/55255/ -- To view, visit https://gerrit.ovirt.org/56575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
Freddy Rolland has posted comments on this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/56575/3/vdsm/storage/sdm/api/base.py File vdsm/storage/sdm/api/base.py: PS3, Line 2: 2015 Add 2016 Line 23: import logging Line 24: Line 25: from vdsm import jobs Line 26: from vdsm import exception Line 27: remove empty line Line 28: from vdsm.storage.threadLocal import vars Line 29: Line 30: Line 31: class Job(jobs.Job): -- To view, visit https://gerrit.ovirt.org/56575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
Jenkins CI has posted comments on this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Patch Set 2: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/56575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: move threadLocal module to vdsm storage lib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: move threadLocal module to vdsm storage lib
Amit Aviram has uploaded a new change for review. Change subject: storage: move threadLocal module to vdsm storage lib .. storage: move threadLocal module to vdsm storage lib This patch moves the module storage/threadPool.py to vdsm/storage/threadLocal.py. Change-Id: I9b3e106598b1b76478505a7709a74f2841f782fa Signed-off-by: Amit Aviram --- M lib/vdsm/storage/Makefile.am R lib/vdsm/storage/threadLocal.py M vdsm.spec.in M vdsm/storage/Makefile.am M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/sdm/api/base.py M vdsm/storage/task.py M vdsm/storage/volume.py 11 files changed, 12 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/56575/1 diff --git a/lib/vdsm/storage/Makefile.am b/lib/vdsm/storage/Makefile.am index 720eafd..e482e6d 100644 --- a/lib/vdsm/storage/Makefile.am +++ b/lib/vdsm/storage/Makefile.am @@ -31,5 +31,6 @@ rwlock.py \ securable.py \ sync.py \ + threadLocal.py \ threadPool.py \ $(NULL) diff --git a/vdsm/storage/threadLocal.py b/lib/vdsm/storage/threadLocal.py similarity index 91% rename from vdsm/storage/threadLocal.py rename to lib/vdsm/storage/threadLocal.py index ea245d0..5fabb64 100644 --- a/vdsm/storage/threadLocal.py +++ b/lib/vdsm/storage/threadLocal.py @@ -1,5 +1,5 @@ # -# Copyright 2011 Red Hat, Inc. +# Copyright 2011-2016 Red Hat, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -18,6 +18,8 @@ # Refer to the README and COPYING files for full details of the license # +from __future__ import absolute_import + import threading vars = threading.local() diff --git a/vdsm.spec.in b/vdsm.spec.in index 037ccc5..a0f02b7 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -961,7 +961,6 @@ %{_datadir}/%{vdsm_name}/storage/storageServer.py* %{_datadir}/%{vdsm_name}/storage/taskManager.py* %{_datadir}/%{vdsm_name}/storage/task.py* -%{_datadir}/%{vdsm_name}/storage/threadLocal.py* %{_datadir}/%{vdsm_name}/storage/volume.py* %{_datadir}/%{vdsm_name}/storage/imageRepository/__init__.py* %{_datadir}/%{vdsm_name}/storage/imageRepository/formatConverter.py* @@ -1181,6 +1180,7 @@ %{python_sitelib}/%{vdsm_name}/storage/rwlock.py* %{python_sitelib}/%{vdsm_name}/storage/securable.py* %{python_sitelib}/%{vdsm_name}/storage/sync.py* +%{python_sitelib}/%{vdsm_name}/storage/threadLocal.py* %{python_sitelib}/%{vdsm_name}/storage/threadPool.py* %{python_sitelib}/%{vdsm_name}/tc/__init__.py* %{python_sitelib}/%{vdsm_name}/tc/_parser.py* diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am index ff598ac..c5884ec 100644 --- a/vdsm/storage/Makefile.am +++ b/vdsm/storage/Makefile.am @@ -60,7 +60,6 @@ storageServer.py \ taskManager.py \ task.py \ - threadLocal.py \ volume.py dist_vdsmexec_SCRIPTS = \ diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index d33e137..2372774 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -28,6 +28,7 @@ from vdsm.config import config from vdsm.storage import exception as se from vdsm.storage import fileUtils +from vdsm.storage.threadLocal import vars import vdsm.utils as utils import volume @@ -40,7 +41,6 @@ import task import lvm import resourceManager as rm -from threadLocal import vars from sdc import sdCache from resourceFactories import LVM_ACTIVATION_NAMESPACE diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py index 0afe6f3..db74732 100644 --- a/vdsm/storage/fileVolume.py +++ b/vdsm/storage/fileVolume.py @@ -28,6 +28,7 @@ from vdsm.storage import exception as se from vdsm.storage.constants import FILE_VOLUME_PERMISSIONS from vdsm.storage.constants import LEASE_FILEEXT +from vdsm.storage.threadLocal import vars from sdc import sdCache import outOfProcess as oop @@ -38,7 +39,6 @@ import misc from misc import deprecated import task -from threadLocal import vars META_FILEEXT = ".meta" LEASE_FILEOFFSET = 0 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index bd33b25..c0968e1 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -49,6 +49,7 @@ from vdsm.storage import mount from vdsm.storage.constants import STORAGE from vdsm.storage.constants import SECTOR_SIZE +from vdsm.storage.threadLocal import vars import sp from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS @@ -72,7 +73,6 @@ from misc import deprecated import taskManager import clusterlock -from threadLocal import vars import resourceManager as rm from resourceFactories import IMAGE_NAMESPACE import devicemapper diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index 381b2a1..68923dc 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -30,6 +30,7 @@ from vdsm.config impo
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Maor Lipchuk has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55255/2/lib/vdsm/storage/threadlocal.py File lib/vdsm/storage/threadlocal.py: Line 1: # Line 2: # Copyright 2011-2016 Red Hat, Inc. > We don't use these rules; we update the range when a module is modified. I'm not familiar with the copyright format rules we use in vdsm so I will leave this review to someone who does Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Nir Soffer has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55255/2/lib/vdsm/storage/threadlocal.py File lib/vdsm/storage/threadlocal.py: Line 1: # Line 2: # Copyright 2011-2016 Red Hat, Inc. > Not sure about the copyright change, unless this file was changed every yea We don't use these rules; we update the range when a module is modified. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Maor Lipchuk has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55255/2/lib/vdsm/storage/threadlocal.py File lib/vdsm/storage/threadlocal.py: Line 1: # Line 2: # Copyright 2011-2016 Red Hat, Inc. Not sure about the copyright change, unless this file was changed every year until 2016. Based on the GNU Copyright Notices: https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html "You can use a range (‘2008-2010’) instead of listing individual years (‘2008, 2009, 2010’) if and only if: 1) every year in the range, inclusive, really is a “copyrightable” year that would be listed individually;" Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Freddy Rolland has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
gerrit-hooks has posted comments on this change. Change subject: storage: Move threadLocal module to vdsm storage lib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib
Nir Soffer has uploaded a new change for review. Change subject: storage: Move threadLocal module to vdsm storage lib .. storage: Move threadLocal module to vdsm storage lib Move storage.threadLocal to vdsm.storage.threadlocal Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2 Signed-off-by: Nir Soffer --- M debian/vdsm-python.install M debian/vdsm.install M lib/vdsm/storage/Makefile.am R lib/vdsm/storage/threadlocal.py M vdsm.spec.in M vdsm/storage/Makefile.am M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/task.py M vdsm/storage/volume.py 12 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/55255/1 diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install index 7cd497c..cfa77cd 100644 --- a/debian/vdsm-python.install +++ b/debian/vdsm-python.install @@ -67,6 +67,7 @@ ./usr/lib/python2.7/dist-packages/vdsm/storage/persistent.py ./usr/lib/python2.7/dist-packages/vdsm/storage/securable.py ./usr/lib/python2.7/dist-packages/vdsm/storage/sync.py +./usr/lib/python2.7/dist-packages/vdsm/storage/threadlocal.py ./usr/lib/python2.7/dist-packages/vdsm/supervdsm.py ./usr/lib/python2.7/dist-packages/vdsm/taskset.py ./usr/lib/python2.7/dist-packages/vdsm/tool/__init__.py diff --git a/debian/vdsm.install b/debian/vdsm.install index 9671eed..95d0953 100644 --- a/debian/vdsm.install +++ b/debian/vdsm.install @@ -115,7 +115,6 @@ ./usr/share/vdsm/storage/storage_mailbox.py ./usr/share/vdsm/storage/task.py ./usr/share/vdsm/storage/taskManager.py -./usr/share/vdsm/storage/threadLocal.py ./usr/share/vdsm/storage/threadPool.py ./usr/share/vdsm/storage/volume.py ./usr/share/vdsm/sitecustomize.py diff --git a/lib/vdsm/storage/Makefile.am b/lib/vdsm/storage/Makefile.am index b98e713..d5a1106 100644 --- a/lib/vdsm/storage/Makefile.am +++ b/lib/vdsm/storage/Makefile.am @@ -28,4 +28,5 @@ persistent.py \ securable.py \ sync.py \ + threadlocal.py \ $(NULL) diff --git a/vdsm/storage/threadLocal.py b/lib/vdsm/storage/threadlocal.py similarity index 95% rename from vdsm/storage/threadLocal.py rename to lib/vdsm/storage/threadlocal.py index ea245d0..d76f9e1 100644 --- a/vdsm/storage/threadLocal.py +++ b/lib/vdsm/storage/threadlocal.py @@ -1,5 +1,5 @@ # -# Copyright 2011 Red Hat, Inc. +# Copyright 2011-2016 Red Hat, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by diff --git a/vdsm.spec.in b/vdsm.spec.in index 13918f3..04ab65e 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -946,7 +946,6 @@ %{_datadir}/%{vdsm_name}/storage/storageServer.py* %{_datadir}/%{vdsm_name}/storage/taskManager.py* %{_datadir}/%{vdsm_name}/storage/task.py* -%{_datadir}/%{vdsm_name}/storage/threadLocal.py* %{_datadir}/%{vdsm_name}/storage/threadPool.py* %{_datadir}/%{vdsm_name}/storage/volume.py* %{_datadir}/%{vdsm_name}/storage/imageRepository/__init__.py* @@ -1151,6 +1150,7 @@ %{python_sitelib}/%{vdsm_name}/storage/persistent.py* %{python_sitelib}/%{vdsm_name}/storage/securable.py* %{python_sitelib}/%{vdsm_name}/storage/sync.py* +%{python_sitelib}/%{vdsm_name}/storage/threadlocal.py* %{python_sitelib}/%{vdsm_name}/tc/__init__.py* %{python_sitelib}/%{vdsm_name}/tc/_parser.py* %{python_sitelib}/%{vdsm_name}/tc/_wrapper.py* diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am index 20011b8..d964084 100644 --- a/vdsm/storage/Makefile.am +++ b/vdsm/storage/Makefile.am @@ -63,7 +63,6 @@ storageServer.py \ taskManager.py \ task.py \ - threadLocal.py \ threadPool.py \ volume.py diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index 18ff490..a42bbf6 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -27,6 +27,7 @@ from vdsm import exception from vdsm.config import config from vdsm.storage import exception as se +from vdsm.storage.threadlocal import vars import vdsm.utils as utils import volume @@ -39,7 +40,6 @@ import task import lvm import resourceManager as rm -from threadLocal import vars from sdc import sdCache from resourceFactories import LVM_ACTIVATION_NAMESPACE import fileUtils diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py index 0afe6f3..a78a328 100644 --- a/vdsm/storage/fileVolume.py +++ b/vdsm/storage/fileVolume.py @@ -28,6 +28,7 @@ from vdsm.storage import exception as se from vdsm.storage.constants import FILE_VOLUME_PERMISSIONS from vdsm.storage.constants import LEASE_FILEEXT +from vdsm.storage.threadlocal import vars from sdc import sdCache import outOfProcess as oop @@ -38,7 +39,6 @@ import misc from misc import deprecated import task -from threadLocal import vars META_FILEEXT = ".meta" LEASE_FILEOFFSET = 0 diff --git a/vd