Re: [ANNOUNCE] wayland 1.10.91

2016-05-24 Thread Bryce Harrington 
On Tue, May 24, 2016 at 09:49:20AM +0800, Jonas Ådahl wrote:
> On Mon, May 23, 2016 at 02:22:45PM -0700, Bryce Harrington wrote:
> > On Fri, May 20, 2016 at 03:35:15PM -0700, Bryce Harrington wrote:
> > > On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote:
> > > > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
> > > > > On Wed, 4 May 2016 11:46:23 -0700
> > > > > Bryce Harrington  wrote:
> > > > > 
> > > > > > On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> > > > > > > Here's the alpha for the upcoming 1.11 release.  I'll summarize 
> > > > > > > the
> > > > > > > major features for this release in the beta announcement, but see 
> > > > > > > below
> > > > > > > for the detailed listing.
> > > > > > > 
> > > > > > > The schedule going forward is:
> > > > > > > 
> > > > > > >   √ 1.11-alpha on May 3rd.  Major features done by this point.
> > > > 
> > > > It looks like someone (pq?) has marked some patches we decided to leave
> > > > for post-1.11 as deferred in patchwork.  I've followed suit and moved
> > > > other patchsets there which are new APIs or that sound like feature
> > > > work.
> > > 
> > > The patch queue has been fully processed now, except for a few items.
> > > 
> > >   https://patchwork.freedesktop.org/project/wayland/patches/
> > > 
> > > What wasn't landable as-is has been marked as deferred for now, and I
> > > will move them back to the main queue once the release is out.
> > > 
> > > > 3. xwayland drag-and-drop window creation [Carlos]
> > > >- Looks ok to be but xwayland isn't my area
> > > >- Been in the queue a long time, but no reviews to date
> > > >- From the commit description sounds WIP-ish and that there was
> > > >  planned some followup work, but not sure if that happened?
> > > 
> > > https://patchwork.freedesktop.org/patch/74663/
> > > 
> > > I'm still unsure what to do with this drag-and-drop patch.  I'm
> > > defaulting to defer it at this point, but it seems to fix a legitimate
> > > crash bug so I'm reticent to kick it down the road without at least a
> > > next action identified.  It's a short patch, can someone take a quick
> > > look and give an opinion on it?
> > 
> > Due to lack of response I've deferred this one.
> 
> As stated in the other mail thread that brought up this patch, I think
> it seems better to land it now, rather than keep crashing.

I completely agree it would be nice to land this, but someone still
needs to actually respond with a review of the patch.

Bryce
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-23 Thread Jonas Ådahl 
On Mon, May 23, 2016 at 02:22:45PM -0700, Bryce Harrington wrote:
> On Fri, May 20, 2016 at 03:35:15PM -0700, Bryce Harrington wrote:
> > On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote:
> > > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
> > > > On Wed, 4 May 2016 11:46:23 -0700
> > > > Bryce Harrington  wrote:
> > > > 
> > > > > On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> > > > > > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > > > > > major features for this release in the beta announcement, but see 
> > > > > > below
> > > > > > for the detailed listing.
> > > > > > 
> > > > > > The schedule going forward is:
> > > > > > 
> > > > > >   √ 1.11-alpha on May 3rd.  Major features done by this point.
> > > 
> > > It looks like someone (pq?) has marked some patches we decided to leave
> > > for post-1.11 as deferred in patchwork.  I've followed suit and moved
> > > other patchsets there which are new APIs or that sound like feature
> > > work.
> > 
> > The patch queue has been fully processed now, except for a few items.
> > 
> >   https://patchwork.freedesktop.org/project/wayland/patches/
> > 
> > What wasn't landable as-is has been marked as deferred for now, and I
> > will move them back to the main queue once the release is out.
> > 
> > > 3. xwayland drag-and-drop window creation [Carlos]
> > >- Looks ok to be but xwayland isn't my area
> > >- Been in the queue a long time, but no reviews to date
> > >- From the commit description sounds WIP-ish and that there was
> > >  planned some followup work, but not sure if that happened?
> > 
> > https://patchwork.freedesktop.org/patch/74663/
> > 
> > I'm still unsure what to do with this drag-and-drop patch.  I'm
> > defaulting to defer it at this point, but it seems to fix a legitimate
> > crash bug so I'm reticent to kick it down the road without at least a
> > next action identified.  It's a short patch, can someone take a quick
> > look and give an opinion on it?
> 
> Due to lack of response I've deferred this one.

As stated in the other mail thread that brought up this patch, I think
it seems better to land it now, rather than keep crashing. When I
tested, it was very easy to crash weston by just dragging from an
Xwayland window outside of its frame (onto the desktop shell client).


Jonas

> 
> Bryce
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-23 Thread Bryce Harrington 
On Fri, May 20, 2016 at 03:35:15PM -0700, Bryce Harrington wrote:
> On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote:
> > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
> > > On Wed, 4 May 2016 11:46:23 -0700
> > > Bryce Harrington  wrote:
> > > 
> > > > On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> > > > > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > > > > major features for this release in the beta announcement, but see 
> > > > > below
> > > > > for the detailed listing.
> > > > > 
> > > > > The schedule going forward is:
> > > > > 
> > > > >   √ 1.11-alpha on May 3rd.  Major features done by this point.
> > 
> > It looks like someone (pq?) has marked some patches we decided to leave
> > for post-1.11 as deferred in patchwork.  I've followed suit and moved
> > other patchsets there which are new APIs or that sound like feature
> > work.
> 
> The patch queue has been fully processed now, except for a few items.
> 
>   https://patchwork.freedesktop.org/project/wayland/patches/
> 
> What wasn't landable as-is has been marked as deferred for now, and I
> will move them back to the main queue once the release is out.
> 
> > 3. xwayland drag-and-drop window creation [Carlos]
> >- Looks ok to be but xwayland isn't my area
> >- Been in the queue a long time, but no reviews to date
> >- From the commit description sounds WIP-ish and that there was
> >  planned some followup work, but not sure if that happened?
> 
> https://patchwork.freedesktop.org/patch/74663/
> 
> I'm still unsure what to do with this drag-and-drop patch.  I'm
> defaulting to defer it at this point, but it seems to fix a legitimate
> crash bug so I'm reticent to kick it down the road without at least a
> next action identified.  It's a short patch, can someone take a quick
> look and give an opinion on it?

Due to lack of response I've deferred this one.

Bryce
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-20 Thread Bryce Harrington 
On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote:
> On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
> > On Wed, 4 May 2016 11:46:23 -0700
> > Bryce Harrington  wrote:
> > 
> > > On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> > > > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > > > major features for this release in the beta announcement, but see below
> > > > for the detailed listing.
> > > > 
> > > > The schedule going forward is:
> > > > 
> > > >   √ 1.11-alpha on May 3rd.  Major features done by this point.
> 
> It looks like someone (pq?) has marked some patches we decided to leave
> for post-1.11 as deferred in patchwork.  I've followed suit and moved
> other patchsets there which are new APIs or that sound like feature
> work.

The patch queue has been fully processed now, except for a few items.

  https://patchwork.freedesktop.org/project/wayland/patches/

What wasn't landable as-is has been marked as deferred for now, and I
will move them back to the main queue once the release is out.

> 3. xwayland drag-and-drop window creation [Carlos]
>- Looks ok to be but xwayland isn't my area
>- Been in the queue a long time, but no reviews to date
>- From the commit description sounds WIP-ish and that there was
>  planned some followup work, but not sure if that happened?

https://patchwork.freedesktop.org/patch/74663/

I'm still unsure what to do with this drag-and-drop patch.  I'm
defaulting to defer it at this point, but it seems to fix a legitimate
crash bug so I'm reticent to kick it down the road without at least a
next action identified.  It's a short patch, can someone take a quick
look and give an opinion on it?



https://patchwork.freedesktop.org/patch/88324/

build: Define wayland prereq version

I posted a new version of this with quoting fixed.  This one is a
priority for the release, but given the lateness in the cycle I'd like
to have a R-b or two before I land it.


Bryce
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-12 Thread Bryce Harrington 
On Wed, May 11, 2016 at 05:32:37PM -0500, Yong Bakos wrote:
> On May 11, 2016, at 2:32 PM, Yong Bakos  wrote:
> > 
> > On May 11, 2016, at 2:11 PM, Bryce Harrington  wrote:
> >> 
> >> On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
> >>> On Wed, 4 May 2016 11:46:23 -0700
> >>> Bryce Harrington  wrote:
> >>> 
>  On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > major features for this release in the beta announcement, but see below
> > for the detailed listing.
> > 
> > The schedule going forward is:
> > 
> > √ 1.11-alpha on May 3rd.  Major features done by this point.
> >> 
> >> It looks like someone (pq?) has marked some patches we decided to leave
> >> for post-1.11 as deferred in patchwork.  I've followed suit and moved
> >> other patchsets there which are new APIs or that sound like feature
> >> work.
> >> 
> >> Following are what remains.  Most of these I think should be deferred
> >> but am not 100% certain, so would appreciate hearing other people's
> >> thoughts:
> > 
> > Hi Bryce,
> > I have on my list to review #5 below (text input protocol), and I should
> > have that done today (May 11). Or I can submit patches after it's merged.
> > 
> > yong
> 
> Actually, I did review #5 (v2 for text input protocol), but at the time
> I had to manually re-construct the reply as I was receiving mailing list
> digests at the time... so Patchwork didn't associate my response.
> 
> https://lists.freedesktop.org/archives/wayland-devel/2016-April/027922.html
> 
> The things I pointed out weren't fixed, but they were all writing corrections,
> which I can submit after a merge.
> 
> yong

Thanks for reviewing it.  The patch is against wayland-protocols, whose
release schedule isn't sync'd with the wayland/weston schedule, so
there's no impact if this patch needs more time.

Bryce

> >> 1. Detect keyboard capabilities, refactor seat capability [Derek]
> >>  - Awaiting review by jadahl
> >>  - Over a year old now, probably needs rebased too...
> >> 
> >> 2. xdg_popup behavior of input devices [Carlos]
> >>  - Protocol additions for xdg-shell, needs review by xdg devels
> >>  - Been in the queue a long time, but no reviews to date
> >>  - No idea about disposition for this
> >> 
> >> 3. xwayland drag-and-drop window creation [Carlos]
> >>  - Looks ok to be but xwayland isn't my area
> >>  - Been in the queue a long time, but no reviews to date
> >>  - From the commit description sounds WIP-ish and that there was
> >>planned some followup work, but not sure if that happened?
> >> 
> >> 4. Pointer locking (3 patches) [Jonas]
> >>  - Was planned to land this feature for 1.11
> >>  - Reviewers requested changes, but I'm not spotting a v2 for this
> >>  - At a minimum needs updated for trunk, since the protocol files are
> >>now in wayland-protocols
> >>  - I'll mark it 'Changes Requested' and hope it will return for
> >>consideration for 1.12.
> >> 
> >> 5. V2 for text input protocol [Jan Arne]
> >>  - This is intended for wayland-protocols so not really pertinent to
> >>the release.  But is on v6 and hasn't received further reviews,
> >>perhaps it's time to land it?
> >> 
> >> 6. FreeRDP fixes (6 patches) [David]
> >>  - Build fixes are suitable for landing now, so I consider at least
> >>the first 3 patches here good candidates for including in 1.11
> >>  - No R-b's other than my own; I'd be more comfortable landing if we
> >>had another set of R-b's on this.
> >> 
> >> 7. compositor-drm clone mode + fixes (8 patches) [Emmanuel]
> >>  - The fixes look straightforward and probably ok to land
> >>  - I haven't reviewed the clone mode feature, but offhand judging by
> >>the length of the patch it looks like post-1.11 stuff.
> >> 
> >> 8. get_subsurface double-buffered protocol [pq]
> >>  - Is getting strong reviews, but also requests for tests 
> >>  - There is debate on its thread as to whether to land vs. leave for
> >>1.12
> >> 
> >> 9. Don't set_fullscreen on already fullscreen surfaces [Emmanuel]
> >>  - Short fix, might be worth including in 1.11
> >>  - Needs another R-b or two, but may be an easy thing to land
> >> 
> >> 10. compositor fixes (2 patches) [pq]
> >> 11. eventdemo fixes (3 patches) [pq]
> >>  - These sound landable for 1.11 offhand, but I haven't reviewed.
> >>  - Needs R-b's
> >> 
> >> 12. ivi_layout_surface API
> >>  - Straightforward patch, looks fine to me
> >>  - Not sure about landing new API during feature freeze though
> >>  - Needs R-b's
> >> 
> > - 1.11-beta around May 17th.
> > 
> > - 1.11-rc1 around May 24th.
> > 
> > - 1.11.0 release around May 31st.
> > 
> > At this time consider Wayland in feature freeze mode.  We'll continue to
> > land minor enhancements through beta, and focus on bug fixes 
> > thereafter.

Re: [ANNOUNCE] wayland 1.10.91

2016-05-12 Thread Bryce Harrington 
On Thu, May 12, 2016 at 11:20:46AM +0300, Pekka Paalanen wrote:
> On Thu, 12 May 2016 10:38:56 +0800
> Jonas Ådahl  wrote:
> 
> > On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote:
> > > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:  
> > > > On Wed, 4 May 2016 11:46:23 -0700
> > > > Bryce Harrington  wrote:
> > > >   
> > > > > On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:  
> > > > > > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > > > > > major features for this release in the beta announcement, but see 
> > > > > > below
> > > > > > for the detailed listing.
> > > > > > 
> > > > > > The schedule going forward is:
> > > > > > 
> > > > > >   √ 1.11-alpha on May 3rd.  Major features done by this point.  
> > > 
> > > It looks like someone (pq?) has marked some patches we decided to leave
> > > for post-1.11 as deferred in patchwork.  I've followed suit and moved
> > > other patchsets there which are new APIs or that sound like feature
> > > work.
> > > 
> > > Following are what remains.  Most of these I think should be deferred
> > > but am not 100% certain, so would appreciate hearing other people's
> > > thoughts:
> 
> > > 8. get_subsurface double-buffered protocol [pq]
> > >- Is getting strong reviews, but also requests for tests 
> > >- There is debate on its thread as to whether to land vs. leave for
> > >  1.12  
> > 
> > We are waiting with this one until 1.12.
> 
> At least if I don't post the weston patches for it and get them
> reviewed before beta. It will be tight, but I try.
> 
> > > 10. compositor fixes (2 patches) [pq]
> > > 11. eventdemo fixes (3 patches) [pq]
> > >- These sound landable for 1.11 offhand, but I haven't reviewed.
> > >- Needs R-b's
> 
> Yup, no need to defer these, IMO.
> 
> > > 12. ivi_layout_surface API
> > >- Straightforward patch, looks fine to me
> > >- Not sure about landing new API during feature freeze though
> > >- Needs R-b's
> 
> At least patches 1 and 2 I will be pushing in a moment, they got
> reviewed.
> 
> Patch 3 should maybe perhaps wait for after 1.11.

Alright, I've deferred that one and left the rest on the todo list for
1.11.

Bryce

> -BEGIN PGP SIGNATURE-
> Version: GnuPG v2
> 
> iQIVAwUBVzQ83iNf5bQRqqqnAQhARg//TxAC1ztwMj1yyYfIZWssRjgag/ZK8hSC
> qywq8FDXyAnN8TAC1jVk6HmzycyPeznY1wtcdwpBGAoi3umh1grNERuXpoYdrXpZ
> m79MUs80gVsDPIEjGTD67zoDg/VpQcrfhmoieUojbG1FIM87b/Z0yBx8yUNjUEVa
> sIJUVosWZ1XXzgEY6+XxivZDjliUrO9sV2rEWpKNOjeA3L3haVy54iXAaRZ66JkU
> H7TRBzANnPzTNpj5GUsGRAlXG8uW8nEfzoffhyaLQM7fx+ZGmed/aws/zu8UA9Cd
> IBMcYNr2EB2F5U1XP1ons7J5yDTKeUkN4iyurBaFk/8+/SMOvTCtkN5x4fpLtmyS
> OZFPfmxZgMkw69xPg9R5HcaAhXZOOmI7yt/MyIOZc7awKUMnvHpgM3BBIWY9bu6V
> VOJNjIflE1Uq7kVYxOqhl4alS8jd/mBUeCPeao6m7R8sB23LRvfwMUjWWKjpnl2M
> oZ/OvziphBrRt8+Dvb2zP5Z51ZwVSTwsT5GwLZucdIK7jWsT2Z5Hc9uec9PDtF+q
> jeosrMPl1Lhm4UpItNYH6hXkkjtVdrpyDNIt7lONqCLBEj7j/V5SESj6dV/QLUR2
> aNm72ng9FIjqTpMi3xjBRC6W5vTbfKlpzlhm8sMGfGSGfs6Je6daNtPwvUiPcJ+/
> 2yyCiHLSx5w=
> =gRnl
> -END PGP SIGNATURE-

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-12 Thread Bryce Harrington 
On Thu, May 12, 2016 at 10:38:56AM +0800, Jonas Ådahl wrote:
> On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote:
> > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
> > > On Wed, 4 May 2016 11:46:23 -0700
> > > Bryce Harrington  wrote:
> > > 
> > > > On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> > > > > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > > > > major features for this release in the beta announcement, but see 
> > > > > below
> > > > > for the detailed listing.
> > > > > 
> > > > > The schedule going forward is:
> > > > > 
> > > > >   √ 1.11-alpha on May 3rd.  Major features done by this point.
> > 
> > It looks like someone (pq?) has marked some patches we decided to leave
> > for post-1.11 as deferred in patchwork.  I've followed suit and moved
> > other patchsets there which are new APIs or that sound like feature
> > work.
> > 
> > Following are what remains.  Most of these I think should be deferred
> > but am not 100% certain, so would appreciate hearing other people's
> > thoughts:
> > 
> > 
> > 1. Detect keyboard capabilities, refactor seat capability [Derek]
> >- Awaiting review by jadahl
> >- Over a year old now, probably needs rebased too...
> 
> I have completely forgotten about this one, sorry about that. I could
> take it upon me to review this if its valuable for 1.11, but as far as I
> remember I was not very happy about the internal API changes.

I expect the turnaround is too short to make it by beta, but given it's
age I think you should put a priority on giving derek feedback on it in
the coming weeks.

I'll mark it postponed for 1.11 though, since sounds like you have some
doubts that you'll need to debate with derek.

> > 2. xdg_popup behavior of input devices [Carlos]
> >- Protocol additions for xdg-shell, needs review by xdg devels
> >- Been in the queue a long time, but no reviews to date
> >- No idea about disposition for this
> 
> Any changes to xdg_shell should target the v6, it needs to be rebased.
> Might be something good to revisit before finalizing a v6.

Sounds good, I'll mark as Changes Requested and send a note to Carlos to
retarget it.

> > 3. xwayland drag-and-drop window creation [Carlos]
> >- Looks ok to be but xwayland isn't my area
> >- Been in the queue a long time, but no reviews to date
> >- From the commit description sounds WIP-ish and that there was
> >  planned some followup work, but not sure if that happened?
> 
> This one can have my Acked-by for 1.11 since it avoids crashing weston.
> As far as I can tell, wayland<->xwayland dnd is currently broken either
> way, and hopefully Carlos can have a look for 1.12.

Thanks.  I'll put this on the todo list for beta.

> > 4. Pointer locking (3 patches) [Jonas]
> >- Was planned to land this feature for 1.11
> >- Reviewers requested changes, but I'm not spotting a v2 for this
> >- At a minimum needs updated for trunk, since the protocol files are
> >  now in wayland-protocols
> >- I'll mark it 'Changes Requested' and hope it will return for
> >  consideration for 1.12.
> 
> I won't work on these for 1.11.

*Nod*

> > 5. V2 for text input protocol [Jan Arne]
> >- This is intended for wayland-protocols so not really pertinent to
> >  the release.  But is on v6 and hasn't received further reviews,
> >  perhaps it's time to land it?
> 
> There has been some disagreements on various parts being out-of-scope
> for said protocol. I think we need to discuss this one further before
> landing.

Alright, will leave it as is.

> > 8. get_subsurface double-buffered protocol [pq]
> >- Is getting strong reviews, but also requests for tests 
> >- There is debate on its thread as to whether to land vs. leave for
> >  1.12
> 
> We are waiting with this one until 1.12.

Per pq's response I'll leave this one as is for the moment.

Thanks for looking at these,

Bryce
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-12 Thread Pekka Paalanen 
On Thu, 12 May 2016 10:38:56 +0800
Jonas Ådahl  wrote:

> On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote:
> > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:  
> > > On Wed, 4 May 2016 11:46:23 -0700
> > > Bryce Harrington  wrote:
> > >   
> > > > On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:  
> > > > > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > > > > major features for this release in the beta announcement, but see 
> > > > > below
> > > > > for the detailed listing.
> > > > > 
> > > > > The schedule going forward is:
> > > > > 
> > > > >   √ 1.11-alpha on May 3rd.  Major features done by this point.  
> > 
> > It looks like someone (pq?) has marked some patches we decided to leave
> > for post-1.11 as deferred in patchwork.  I've followed suit and moved
> > other patchsets there which are new APIs or that sound like feature
> > work.
> > 
> > Following are what remains.  Most of these I think should be deferred
> > but am not 100% certain, so would appreciate hearing other people's
> > thoughts:

> > 8. get_subsurface double-buffered protocol [pq]
> >- Is getting strong reviews, but also requests for tests 
> >- There is debate on its thread as to whether to land vs. leave for
> >  1.12  
> 
> We are waiting with this one until 1.12.

At least if I don't post the weston patches for it and get them
reviewed before beta. It will be tight, but I try.

> > 10. compositor fixes (2 patches) [pq]
> > 11. eventdemo fixes (3 patches) [pq]
> >- These sound landable for 1.11 offhand, but I haven't reviewed.
> >- Needs R-b's

Yup, no need to defer these, IMO.

> > 12. ivi_layout_surface API
> >- Straightforward patch, looks fine to me
> >- Not sure about landing new API during feature freeze though
> >- Needs R-b's

At least patches 1 and 2 I will be pushing in a moment, they got
reviewed.

Patch 3 should maybe perhaps wait for after 1.11.


Thanks,
pq


pgp4MsQa13cX3.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-12 Thread Hardening 
Le 11/05/2016 21:11, Bryce Harrington a écrit :
> On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
>> On Wed, 4 May 2016 11:46:23 -0700
>> Bryce Harrington  wrote:
>>
>>> On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
 Here's the alpha for the upcoming 1.11 release.  I'll summarize the
 major features for this release in the beta announcement, but see below
 for the detailed listing.

 The schedule going forward is:

   √ 1.11-alpha on May 3rd.  Major features done by this point.
> 
> It looks like someone (pq?) has marked some patches we decided to leave
> for post-1.11 as deferred in patchwork.  I've followed suit and moved
> other patchsets there which are new APIs or that sound like feature
> work.
> 
> Following are what remains.  Most of these I think should be deferred
> but am not 100% certain, so would appreciate hearing other people's
> thoughts:
> 
> 
> 1. Detect keyboard capabilities, refactor seat capability [Derek]
>- Awaiting review by jadahl
>- Over a year old now, probably needs rebased too...
> 
> 2. xdg_popup behavior of input devices [Carlos]
>- Protocol additions for xdg-shell, needs review by xdg devels
>- Been in the queue a long time, but no reviews to date
>- No idea about disposition for this
> 
> 3. xwayland drag-and-drop window creation [Carlos]
>- Looks ok to be but xwayland isn't my area
>- Been in the queue a long time, but no reviews to date
>- From the commit description sounds WIP-ish and that there was
>  planned some followup work, but not sure if that happened?
> 
> 4. Pointer locking (3 patches) [Jonas]
>- Was planned to land this feature for 1.11
>- Reviewers requested changes, but I'm not spotting a v2 for this
>- At a minimum needs updated for trunk, since the protocol files are
>  now in wayland-protocols
>- I'll mark it 'Changes Requested' and hope it will return for
>  consideration for 1.12.
> 
> 5. V2 for text input protocol [Jan Arne]
>- This is intended for wayland-protocols so not really pertinent to
>  the release.  But is on v6 and hasn't received further reviews,
>  perhaps it's time to land it?
> 
> 6. FreeRDP fixes (6 patches) [David]
>- Build fixes are suitable for landing now, so I consider at least
>  the first 3 patches here good candidates for including in 1.11
>- No R-b's other than my own; I'd be more comfortable landing if we
>  had another set of R-b's on this.

Just a note: the last 2 patches fix a bug that has been there for year
with output mode switch. As the RDP compositor is the only one that can
use permanent mode switching, it exposes the bug, but the correction
works for all others.

> 
> 7. compositor-drm clone mode + fixes (8 patches) [Emmanuel]
>- The fixes look straightforward and probably ok to land
>- I haven't reviewed the clone mode feature, but offhand judging by
>  the length of the patch it looks like post-1.11 stuff.
> 
> 8. get_subsurface double-buffered protocol [pq]
>- Is getting strong reviews, but also requests for tests 
>- There is debate on its thread as to whether to land vs. leave for
>  1.12
> 
> 9. Don't set_fullscreen on already fullscreen surfaces [Emmanuel]
>- Short fix, might be worth including in 1.11
>- Needs another R-b or two, but may be an easy thing to land
> 
> 10. compositor fixes (2 patches) [pq]
> 11. eventdemo fixes (3 patches) [pq]
>- These sound landable for 1.11 offhand, but I haven't reviewed.
>- Needs R-b's
> 
> 12. ivi_layout_surface API
>- Straightforward patch, looks fine to me
>- Not sure about landing new API during feature freeze though
>- Needs R-b's
> 


-- 
David FORT
website: http://www.hardening-consulting.com/

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-11 Thread Jonas Ådahl 
On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote:
> On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
> > On Wed, 4 May 2016 11:46:23 -0700
> > Bryce Harrington  wrote:
> > 
> > > On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> > > > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > > > major features for this release in the beta announcement, but see below
> > > > for the detailed listing.
> > > > 
> > > > The schedule going forward is:
> > > > 
> > > >   √ 1.11-alpha on May 3rd.  Major features done by this point.
> 
> It looks like someone (pq?) has marked some patches we decided to leave
> for post-1.11 as deferred in patchwork.  I've followed suit and moved
> other patchsets there which are new APIs or that sound like feature
> work.
> 
> Following are what remains.  Most of these I think should be deferred
> but am not 100% certain, so would appreciate hearing other people's
> thoughts:
> 
> 
> 1. Detect keyboard capabilities, refactor seat capability [Derek]
>- Awaiting review by jadahl
>- Over a year old now, probably needs rebased too...

I have completely forgotten about this one, sorry about that. I could
take it upon me to review this if its valuable for 1.11, but as far as I
remember I was not very happy about the internal API changes.

> 
> 2. xdg_popup behavior of input devices [Carlos]
>- Protocol additions for xdg-shell, needs review by xdg devels
>- Been in the queue a long time, but no reviews to date
>- No idea about disposition for this

Any changes to xdg_shell should target the v6, it needs to be rebased.
Might be something good to revisit before finalizing a v6.

> 
> 3. xwayland drag-and-drop window creation [Carlos]
>- Looks ok to be but xwayland isn't my area
>- Been in the queue a long time, but no reviews to date
>- From the commit description sounds WIP-ish and that there was
>  planned some followup work, but not sure if that happened?

This one can have my Acked-by for 1.11 since it avoids crashing weston.
As far as I can tell, wayland<->xwayland dnd is currently broken either
way, and hopefully Carlos can have a look for 1.12.

> 
> 4. Pointer locking (3 patches) [Jonas]
>- Was planned to land this feature for 1.11
>- Reviewers requested changes, but I'm not spotting a v2 for this
>- At a minimum needs updated for trunk, since the protocol files are
>  now in wayland-protocols
>- I'll mark it 'Changes Requested' and hope it will return for
>  consideration for 1.12.

I won't work on these for 1.11.

> 
> 5. V2 for text input protocol [Jan Arne]
>- This is intended for wayland-protocols so not really pertinent to
>  the release.  But is on v6 and hasn't received further reviews,
>  perhaps it's time to land it?

There has been some disagreements on various parts being out-of-scope
for said protocol. I think we need to discuss this one further before
landing.

> 
> 6. FreeRDP fixes (6 patches) [David]
>- Build fixes are suitable for landing now, so I consider at least
>  the first 3 patches here good candidates for including in 1.11
>- No R-b's other than my own; I'd be more comfortable landing if we
>  had another set of R-b's on this.
> 
> 7. compositor-drm clone mode + fixes (8 patches) [Emmanuel]
>- The fixes look straightforward and probably ok to land
>- I haven't reviewed the clone mode feature, but offhand judging by
>  the length of the patch it looks like post-1.11 stuff.
> 
> 8. get_subsurface double-buffered protocol [pq]
>- Is getting strong reviews, but also requests for tests 
>- There is debate on its thread as to whether to land vs. leave for
>  1.12

We are waiting with this one until 1.12.

> 
> 9. Don't set_fullscreen on already fullscreen surfaces [Emmanuel]
>- Short fix, might be worth including in 1.11
>- Needs another R-b or two, but may be an easy thing to land
> 
> 10. compositor fixes (2 patches) [pq]
> 11. eventdemo fixes (3 patches) [pq]
>- These sound landable for 1.11 offhand, but I haven't reviewed.
>- Needs R-b's
> 
> 12. ivi_layout_surface API
>- Straightforward patch, looks fine to me
>- Not sure about landing new API during feature freeze though
>- Needs R-b's
> 

For the ones I didn't comment on, I have no input right now.


Jonas
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [ANNOUNCE] wayland 1.10.91

2016-05-11 Thread Yong Bakos 
On May 11, 2016, at 2:32 PM, Yong Bakos  wrote:
> 
> On May 11, 2016, at 2:11 PM, Bryce Harrington  wrote:
>> 
>> On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote:
>>> On Wed, 4 May 2016 11:46:23 -0700
>>> Bryce Harrington  wrote:
>>> 
 On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> major features for this release in the beta announcement, but see below
> for the detailed listing.
> 
> The schedule going forward is:
> 
> √ 1.11-alpha on May 3rd.  Major features done by this point.
>> 
>> It looks like someone (pq?) has marked some patches we decided to leave
>> for post-1.11 as deferred in patchwork.  I've followed suit and moved
>> other patchsets there which are new APIs or that sound like feature
>> work.
>> 
>> Following are what remains.  Most of these I think should be deferred
>> but am not 100% certain, so would appreciate hearing other people's
>> thoughts:
> 
> Hi Bryce,
> I have on my list to review #5 below (text input protocol), and I should
> have that done today (May 11). Or I can submit patches after it's merged.
> 
> yong

Actually, I did review #5 (v2 for text input protocol), but at the time
I had to manually re-construct the reply as I was receiving mailing list
digests at the time... so Patchwork didn't associate my response.

https://lists.freedesktop.org/archives/wayland-devel/2016-April/027922.html

The things I pointed out weren't fixed, but they were all writing corrections,
which I can submit after a merge.

yong


> 
>> 
>> 1. Detect keyboard capabilities, refactor seat capability [Derek]
>>  - Awaiting review by jadahl
>>  - Over a year old now, probably needs rebased too...
>> 
>> 2. xdg_popup behavior of input devices [Carlos]
>>  - Protocol additions for xdg-shell, needs review by xdg devels
>>  - Been in the queue a long time, but no reviews to date
>>  - No idea about disposition for this
>> 
>> 3. xwayland drag-and-drop window creation [Carlos]
>>  - Looks ok to be but xwayland isn't my area
>>  - Been in the queue a long time, but no reviews to date
>>  - From the commit description sounds WIP-ish and that there was
>>planned some followup work, but not sure if that happened?
>> 
>> 4. Pointer locking (3 patches) [Jonas]
>>  - Was planned to land this feature for 1.11
>>  - Reviewers requested changes, but I'm not spotting a v2 for this
>>  - At a minimum needs updated for trunk, since the protocol files are
>>now in wayland-protocols
>>  - I'll mark it 'Changes Requested' and hope it will return for
>>consideration for 1.12.
>> 
>> 5. V2 for text input protocol [Jan Arne]
>>  - This is intended for wayland-protocols so not really pertinent to
>>the release.  But is on v6 and hasn't received further reviews,
>>perhaps it's time to land it?
>> 
>> 6. FreeRDP fixes (6 patches) [David]
>>  - Build fixes are suitable for landing now, so I consider at least
>>the first 3 patches here good candidates for including in 1.11
>>  - No R-b's other than my own; I'd be more comfortable landing if we
>>had another set of R-b's on this.
>> 
>> 7. compositor-drm clone mode + fixes (8 patches) [Emmanuel]
>>  - The fixes look straightforward and probably ok to land
>>  - I haven't reviewed the clone mode feature, but offhand judging by
>>the length of the patch it looks like post-1.11 stuff.
>> 
>> 8. get_subsurface double-buffered protocol [pq]
>>  - Is getting strong reviews, but also requests for tests 
>>  - There is debate on its thread as to whether to land vs. leave for
>>1.12
>> 
>> 9. Don't set_fullscreen on already fullscreen surfaces [Emmanuel]
>>  - Short fix, might be worth including in 1.11
>>  - Needs another R-b or two, but may be an easy thing to land
>> 
>> 10. compositor fixes (2 patches) [pq]
>> 11. eventdemo fixes (3 patches) [pq]
>>  - These sound landable for 1.11 offhand, but I haven't reviewed.
>>  - Needs R-b's
>> 
>> 12. ivi_layout_surface API
>>  - Straightforward patch, looks fine to me
>>  - Not sure about landing new API during feature freeze though
>>  - Needs R-b's
>> 
> - 1.11-beta around May 17th.
> 
> - 1.11-rc1 around May 24th.
> 
> - 1.11.0 release around May 31st.
> 
> At this time consider Wayland in feature freeze mode.  We'll continue to
> land minor enhancements through beta, and focus on bug fixes thereafter.  
 
 Do we need to up the version requirements for weston's libwayland client
 or server dependency, or the version of wayland-protocol?
>>> 
>>> Hi Bryce,
>>> 
>>> Wayland-protocol deps should all be dealt with as they happen. I
>>> believe we have the policy to land changes in wayland-protocols first
>>> and have a w-p release, and then land weston patches depending on them,
>>> bumping the dependency on configure.ac at the same time. That's what
>>> I've

Re: [ANNOUNCE] wayland 1.10.91

2016-05-06 Thread Pekka Paalanen 
On Wed, 4 May 2016 11:46:23 -0700
Bryce Harrington  wrote:

> On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote:
> > Here's the alpha for the upcoming 1.11 release.  I'll summarize the
> > major features for this release in the beta announcement, but see below
> > for the detailed listing.
> > 
> > The schedule going forward is:
> > 
> >   √ 1.11-alpha on May 3rd.  Major features done by this point.
> > 
> >   - 1.11-beta around May 17th.
> > 
> >   - 1.11-rc1 around May 24th.
> > 
> >   - 1.11.0 release around May 31st.
> > 
> > At this time consider Wayland in feature freeze mode.  We'll continue to
> > land minor enhancements through beta, and focus on bug fixes thereafter.  
> 
> Do we need to up the version requirements for weston's libwayland client
> or server dependency, or the version of wayland-protocol?

Hi Bryce,

Wayland-protocol deps should all be dealt with as they happen. I
believe we have the policy to land changes in wayland-protocols first
and have a w-p release, and then land weston patches depending on them,
bumping the dependency on configure.ac at the same time. That's what
I've been doing anyway.

Unfortunately, we cannot do the same with libwayland since it would add
considerable delay in landing such weston patches.

> In both cases, it looked to me that no, Weston doesn't depend on any of
> the recent changes.  We currently depend on wayland-protocols 1.2, and
> the changes for 1.3 are primarily tablet protocol, support of which
> doesn't sound like landable for Weston at this point.  Post 1.3 w-p
> changes of note are the presentation-time protocol, which I'm not
> certain of.

None of the presentation-time changes after 1.2 and 1.3 change any
semantics, so no bump needed for them.

> Weston currently depends on wayland-server 1.10 and wayland-client
> 1.5.91.  I could just bump the server version just to be safe, but
> offhand I'm not recalling if we did introduce any changes this cycle
> that actually requires it?  As to the client dependency, I've never been
> clear on when that should be bumped, or if what the implications on
> clients would be if we did; I'd love some advice/clarification on that
> for future reference if nothing else.

I looked through libwayland changes post-1.10 release, and the only ABI
change is the addition of the proxy wrappers, which is not used in
Weston. ABI additions are easy to spot by looking for changes to the
headers. It's unlikely to have other kind of changes, except perhaps
scanner.c generated code.

To keep things simpler, I would suggest we keep the all of
libweston-server, -client, and -cursor dependencies at the same number
in Weston. I'm not sure you even can build things from Weston without
both -server and -client. If you use both, they surely are the same
version.

The client dependency may have been forgotten, and the server
dependency will hide any issues it might have.

Of course, whenever anyone sends a Weston patch that needs something
new from libwayland, the commit message should say so. Maybe we could
add a XXX comment in configure.ac also, like my weston patches do for
wayland-protocols before there is a wayland-protocols release?

> Other than that, I've been assuming that if there are any other
> build-dependency changes, they'd have been patched directly.  But it
> would be great at this point to do fresh builds/installs on whatever
> hardware variations are at hand just to doublecheck, and get patches in
> for fixes.  I'll make a priority to review those.

Indeed.


Thanks,
pq


> > Changes:
> > 
> > 
> > Auke Booij (1):
> >   protocol: add support for cross-interface enum attributes
> > 
> > Bill Spitzak (1):
> >   doc: Use enum argument type to make links in protocol documentation
> > 
> > Bryce Harrington (3):
> >   configure.ac: bump to version 1.10.90 for open development
> >   doc: Note strong recommendation to use S-o-b in contributions
> >   configure.ac: bump to version 1.10.91 for the alpha release
> > 
> > Derek Foreman (9):
> >   resource-test: Use wl_seat instead of wl_display for testing
> >   server: validate resource versions at creation time
> >   build: Add an --enable-fatal-warnings configure option
> >   build: build distcheck with --enable-fatal-warnings
> >   Revert "build: build distcheck with --enable-fatal-warnings"
> >   Revert "server: validate resource versions at creation time"
> >   shm: Split pool reference counting into external and internal 
> > references
> >   shm: Defer wl_shm_pool_resize if a pool has external references
> >   shm: Log a warning if a shm buffer address is requested when it may 
> > be invalid
> > 
> > Emil Velikov (3):
> >   scanner: move include directives before extern "C" wrapper
> >   server: move include directives before extern "C" wrapper
> >   utils: move include directives before extern "C" wrapper
> > 
> > Eric