date:20110525

[webkit-changes] [87364] trunk/Source/JavaScriptCore

2011-05-25 Thread barraclough

Title: [87364] trunk/Source/_javascript_Core








Revision 87364
Author barraclo...@apple.com
Date 2011-05-25 23:58:55 -0700 (Wed, 25 May 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=61506

Reviewed by Sam Weinig.

Move the silent spill/fill methods in the DFG JIT to the JITCodeGenerator
so that they are available to the SpeculativeJIT.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
* dfg/DFGNonSpeculativeJIT.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87363 => 87364)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-26 06:48:12 UTC (rev 87363)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-26 06:58:55 UTC (rev 87364)
@@ -1,3 +1,21 @@
+2011-05-25  Gavin Barraclough  
+
+Reviewed by Sam Weinig.
+
+https://bugs.webkit.org/show_bug.cgi?id=61506
+
+Move the silent spill/fill methods in the DFG JIT to the JITCodeGenerator
+so that they are available to the SpeculativeJIT.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::JITCodeGenerator::silentSpillGPR):
+(JSC::DFG::JITCodeGenerator::silentSpillFPR):
+(JSC::DFG::JITCodeGenerator::silentFillGPR):
+(JSC::DFG::JITCodeGenerator::silentFillFPR):
+(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
+(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
+* dfg/DFGNonSpeculativeJIT.h:
+
 2011-05-25  Ryosuke Niwa  
 
 An attempt to revive Windows bots.


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (87363 => 87364)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-05-26 06:48:12 UTC (rev 87363)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-05-26 06:58:55 UTC (rev 87364)
@@ -153,6 +153,147 @@
 {
 }
 
+// These methods are used when generating 'unexpected'
+// calls out from JIT code to C++ helper routines -
+// they spill all live values to the appropriate
+// slots in the RegisterFile without changing any state
+// in the GenerationInfo.
+void silentSpillGPR(VirtualRegister spillMe, GPRReg exclude = InvalidGPRReg)
+{
+GenerationInfo& info = m_generationInfo[spillMe];
+ASSERT(info.registerFormat() != DataFormatNone && info.registerFormat() != DataFormatDouble);
+
+if (!info.needsSpill() || (info.gpr() == exclude))
+return;
+
+DataFormat registerFormat = info.registerFormat();
+
+if (registerFormat == DataFormatInteger) {
+m_jit.orPtr(GPRInfo::tagTypeNumberRegister, info.gpr());
+m_jit.storePtr(info.gpr(), JITCompiler::addressFor(spillMe));
+} else {
+ASSERT(registerFormat & DataFormatJS || registerFormat == DataFormatCell);
+m_jit.storePtr(info.gpr(), JITCompiler::addressFor(spillMe));
+}
+}
+void silentSpillFPR(VirtualRegister spillMe, GPRReg canTrample, FPRReg exclude = InvalidFPRReg)
+{
+GenerationInfo& info = m_generationInfo[spillMe];
+ASSERT(info.registerFormat() == DataFormatDouble);
+
+if (!info.needsSpill() || (info.fpr() == exclude))
+return;
+
+boxDouble(info.fpr(), canTrample);
+m_jit.storePtr(canTrample, JITCompiler::addressFor(spillMe));
+}
+
+void silentFillGPR(VirtualRegister spillMe, GPRReg exclude = InvalidGPRReg)
+{
+GenerationInfo& info = m_generationInfo[spillMe];
+if (info.gpr() == exclude)
+return;
+
+NodeIndex nodeIndex = info.nodeIndex();
+Node& node = m_jit.graph()[nodeIndex];
+ASSERT(info.registerFormat() != DataFormatNone && info.registerFormat() != DataFormatDouble);
+DataFormat registerFormat = info.registerFormat();
+
+if (registerFormat == DataFormatInteger) {
+if (node.isConstant()) {
+ASSERT(isInt32Constant(nodeIndex));
+m_jit.move(Imm32(valueOfInt32Constant(nodeIndex)), info.gpr());
+} else
+m_jit.load32(JITCompiler::addressFor(spillMe), info.gpr());
+return;
+}
+
+if (node.isConstant())
+m_jit.move(constantAsJSValueAsImmPtr(nodeIndex), info.gpr());
+else {
+ASSERT(registerFormat & DataFormatJS || registerFormat == DataFormatCell);
+m_jit.loadPtr(JITCompiler::addressFor(spillMe), info.gpr());
+}
+}
+void silentFillFPR(VirtualRegister spillMe, GPRReg canTrample, FPRReg exclude = InvalidFPRReg)
+{
+GenerationInfo& info = m_generationInfo[spillM

[webkit-changes] [87363] trunk

2011-05-25 Thread jer . noble

Title: [87363] trunk








Revision 87363
Author jer.no...@apple.com
Date 2011-05-25 23:48:12 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Jer Noble  

Reviewed by Dan Bernstein.

30 second rewind button dysfunctional viewing trailers fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=61505

Add support for painting MediaReturnToRealtimeButton, as well as hide and show
the correct default video control buttons when entering full-screen mode.

* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::enteredFullscreen): Show the "Back 30s" and
"Return to Realtime" buttons for Live Streams in full-screen mode.
(WebCore::MediaControlRootElement::exitedFullscreen): Reset the styles of
all the buttons affected by enteredFullscreen().
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart): Add support for
MediaReturnToRealtimeButton.
2011-05-25  Jer Noble  

Reviewed by Dan Bernstein.

30 second rewind button dysfunctional viewing trailers fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=61505

Updated WKSI Libraries with new images for Backward buttons in default
video controls.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/fullscreenQuickTime.css
trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp
trunk/Source/WebCore/rendering/RenderMediaControls.cpp
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a
trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a




Diff

Modified: trunk/Source/WebCore/ChangeLog (87362 => 87363)

--- trunk/Source/WebCore/ChangeLog	2011-05-26 06:46:18 UTC (rev 87362)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 06:48:12 UTC (rev 87363)
@@ -1,3 +1,24 @@
+2011-05-25  Jer Noble  
+
+Reviewed by Dan Bernstein.
+
+30 second rewind button dysfunctional viewing trailers fullscreen.
+https://bugs.webkit.org/show_bug.cgi?id=61505
+
+Add support for painting MediaReturnToRealtimeButton, as well as hide and show
+the correct default video control buttons when entering full-screen mode.
+
+* css/fullscreenQuickTime.css:
+(video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
+* html/shadow/MediaControlRootElement.cpp:
+(WebCore::MediaControlRootElement::enteredFullscreen): Show the "Back 30s" and
+"Return to Realtime" buttons for Live Streams in full-screen mode.
+(WebCore::MediaControlRootElement::exitedFullscreen): Reset the styles of 
+all the buttons affected by enteredFullscreen().
+* rendering/RenderMediaControls.cpp:
+(WebCore::RenderMediaControls::paintMediaControlsPart): Add support for 
+MediaReturnToRealtimeButton.
+
 2011-05-25  Luke Macpherson   
 
 Reviewed by Dimitri Glazkov.


Modified: trunk/Source/WebCore/css/fullscreenQuickTime.css (87362 => 87363)

--- trunk/Source/WebCore/css/fullscreenQuickTime.css	2011-05-26 06:46:18 UTC (rev 87362)
+++ trunk/Source/WebCore/css/fullscreenQuickTime.css	2011-05-26 06:48:12 UTC (rev 87363)
@@ -134,6 +134,15 @@
 top: 13px;
 }
 
+video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button {
+position: absolute;
+display: -webkit-box;
+width: 29px;
+height: 16px;
+left: 262px;
+top: 13px;
+}
+
 video:-webkit-full-screen::-webkit-media-controls-seek-forward-button {
 position: absolute;
 display: -webkit-box;


Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp (87362 => 87363)

--- trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp	2011-05-26 06:46:18 UTC (rev 87362)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp	2011-05-26 06:48:12 UTC (rev 87363)
@@ -409,11 +409,17 @@
 
 void MediaControlRootElement::enteredFullscreen()
 {
-if (m_mediaElement->movieLoadType() == MediaPlayer::LiveStream || m_mediaElement->movieLoadType() == MediaPlayer::StoredStream) {
+if (m_mediaElement->movieLoadType() == MediaPlayer::LiveStream) {
 m_seekBackButton->hide();
 m_seekForwardButton->hide();
-} else
+m_rewindButton->show();
+m_returnToRealTimeButton->show();
+} else {
+m_seekBackButton->show();
+m_seekForwardButton->show();
 m_rewindButton->hide();
+m_returnToRealTimeButton->hide();
+}
 }
 
 void MediaControlRootElement::exitedFullscreen()
@@ -424,6 +430,7 @@
 m_rewindButton->show();
 m_seekBackButton->show();
 m_seekForwardButton->show();
+m_returnToRealTimeButton->show();
 }
 
 void MediaC

[webkit-changes] [87362] trunk/Source/WebCore

2011-05-25 Thread commit-queue

Title: [87362] trunk/Source/WebCore








Revision 87362
Author commit-qu...@webkit.org
Date 2011-05-25 23:46:18 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Luke Macpherson   

Reviewed by Dimitri Glazkov.

Implement various CSS font properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=60603

No new tests - refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyFont):
Added templated class to handle font properties
(WebCore::ApplyPropertyFontWeight):
Added class to handle font weight calculation
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Instantiate ApplyPropertyFont/ApplyPropertyFontWeight for appropriate properties.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove properties that are now implemented in CSSStyleApplyProperty
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::fontDescription):
Added getter for m_style->fontDescription()
(WebCore::CSSStyleSelector::parentFontDescription):
Added getter for m_parentStyle->fontDescription()
(WebCore::CSSStyleSelector::setFontDescription):
Added setter for m_style->setFontDescription() that automatically sets m_fontDirty

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (87361 => 87362)

--- trunk/Source/WebCore/ChangeLog	2011-05-26 06:20:35 UTC (rev 87361)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 06:46:18 UTC (rev 87362)
@@ -1,3 +1,30 @@
+2011-05-25  Luke Macpherson   
+
+Reviewed by Dimitri Glazkov.
+
+Implement various CSS font properties in CSSStyleApplyProperty.
+https://bugs.webkit.org/show_bug.cgi?id=60603
+
+No new tests - refactoring only.
+
+* css/CSSStyleApplyProperty.cpp:
+(WebCore::ApplyPropertyFont):
+Added templated class to handle font properties
+(WebCore::ApplyPropertyFontWeight):
+Added class to handle font weight calculation
+(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
+Instantiate ApplyPropertyFont/ApplyPropertyFontWeight for appropriate properties.
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Remove properties that are now implemented in CSSStyleApplyProperty
+* css/CSSStyleSelector.h:
+(WebCore::CSSStyleSelector::fontDescription):
+Added getter for m_style->fontDescription()
+(WebCore::CSSStyleSelector::parentFontDescription):
+Added getter for m_parentStyle->fontDescription()
+(WebCore::CSSStyleSelector::setFontDescription):
+Added setter for m_style->setFontDescription() that automatically sets m_fontDirty
+
 2011-05-25  James Simonsen  
 
 Reviewed by Adam Barth.


Modified: trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp (87361 => 87362)

--- trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp	2011-05-26 06:20:35 UTC (rev 87361)
+++ trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp	2011-05-26 06:46:18 UTC (rev 87362)
@@ -369,6 +369,79 @@
 }
 };
 
+template 
+class ApplyPropertyFont : public ApplyPropertyBase {
+public:
+typedef T (FontDescription::*GetterFunction)() const;
+typedef void (FontDescription::*SetterFunction)(T);
+
+ApplyPropertyFont(GetterFunction getter, SetterFunction setter, T initial)
+: m_getter(getter)
+, m_setter(setter)
+, m_initial(initial)
+{
+}
+
+private:
+virtual void applyInheritValue(CSSStyleSelector* selector) const
+{
+FontDescription fontDescription = selector->fontDescription();
+(fontDescription.*m_setter)((selector->parentFontDescription().*m_getter)());
+selector->setFontDescription(fontDescription);
+}
+
+virtual void applyInitialValue(CSSStyleSelector* selector) const
+{
+FontDescription fontDescription = selector->fontDescription();
+(fontDescription.*m_setter)(m_initial);
+selector->setFontDescription(fontDescription);
+}
+
+virtual void applyValue(CSSStyleSelector* selector, CSSValue* value) const
+{
+if (!value->isPrimitiveValue())
+return;
+CSSPrimitiveValue* primitiveValue = static_cast(value);
+FontDescription fontDescription = selector->fontDescription();
+(fontDescription.*m_setter)(*primitiveValue);
+selector->setFontDescription(fontDescription);
+}
+
+GetterFunction m_getter;
+SetterFunction m_setter;
+T m_initial;
+};
+
+class ApplyPropertyFontWeight : public ApplyPropertyFont {
+public:
+ApplyPropertyFontWeight()
+: ApplyPropertyFont(&FontDescription::weight, &FontDescription::setWeight, FontWeightNormal)
+

[webkit-changes] [87361] trunk/Source/WebCore

2011-05-25 Thread simonjam

Title: [87361] trunk/Source/WebCore








Revision 87361
Author simon...@chromium.org
Date 2011-05-25 23:20:35 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  James Simonsen  

Reviewed by Adam Barth.

Add site-specific hack for zipcar.com with old versions of requirejs.
https://bugs.webkit.org/show_bug.cgi?id=61321

Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
order. This used to work in webkit by setting a bogus script type (script/cache), then
changing the type to a valid one when they wanted to execute it. This hack translates the
behavior into the new API (by disabling forceAsync).

* html/HTMLScriptElement.cpp:
(WebCore::needsOldRequirejsQuirk): Added.
(WebCore::HTMLScriptElement::insertedIntoDocument):
If hack is needed, set a proper script type so script loads.
If script isn't async, disable forceAsync so script executes in order.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLScriptElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87360 => 87361)

--- trunk/Source/WebCore/ChangeLog	2011-05-26 06:15:19 UTC (rev 87360)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 06:20:35 UTC (rev 87361)
@@ -1,3 +1,21 @@
+2011-05-25  James Simonsen  
+
+Reviewed by Adam Barth.
+
+Add site-specific hack for zipcar.com with old versions of requirejs.
+https://bugs.webkit.org/show_bug.cgi?id=61321
+
+Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
+order. This used to work in webkit by setting a bogus script type (script/cache), then
+changing the type to a valid one when they wanted to execute it. This hack translates the
+behavior into the new API (by disabling forceAsync).
+
+* html/HTMLScriptElement.cpp:
+(WebCore::needsOldRequirejsQuirk): Added.
+(WebCore::HTMLScriptElement::insertedIntoDocument):
+If hack is needed, set a proper script type so script loads.
+If script isn't async, disable forceAsync so script executes in order.
+
 2011-05-25  Andreas Kling  
 
 Reviewed by David Levin.


Modified: trunk/Source/WebCore/html/HTMLScriptElement.cpp (87360 => 87361)

--- trunk/Source/WebCore/html/HTMLScriptElement.cpp	2011-05-26 06:15:19 UTC (rev 87360)
+++ trunk/Source/WebCore/html/HTMLScriptElement.cpp	2011-05-26 06:20:35 UTC (rev 87361)
@@ -29,6 +29,7 @@
 #include "EventNames.h"
 #include "HTMLNames.h"
 #include "ScriptEventListener.h"
+#include "Settings.h"
 #include "Text.h"
 
 namespace WebCore {
@@ -81,8 +82,33 @@
 HTMLElement::parseMappedAttribute(attr);
 }
 
+static bool needsOldRequirejsQuirk(HTMLScriptElement* element)
+{
+if (element->fastGetAttribute(typeAttr) != "script/cache")
+return false;
+
+Document* document = element->document();
+
+const KURL& url = ""
+if (!equalIgnoringCase(url.host(), "www.zipcar.com"))
+return false;
+
+Settings* settings = document->settings();
+if (!settings)
+return false;
+if (!settings->needsSiteSpecificQuirks())
+return false;
+
+return true;
+}
+
 void HTMLScriptElement::insertedIntoDocument()
 {
+if (needsOldRequirejsQuirk(this)) {
+if (!asyncAttributeValue())
+handleAsyncAttribute(); // Clear forceAsync, so this script loads in parallel, but executes in order.
+setAttribute(typeAttr, "text/_javascript_");
+}
 HTMLElement::insertedIntoDocument();
 ScriptElement::insertedIntoDocument();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87359] trunk/Source/JavaScriptCore

2011-05-25 Thread barraclough

Title: [87359] trunk/Source/_javascript_Core








Revision 87359
Author barraclo...@apple.com
Date 2011-05-25 22:32:18 -0700 (Wed, 25 May 2011)


Log Message
An attempt to revive Windows bots.

Patch by Ryosuke Niwa  on 2011-05-25
* runtime/RegExp.cpp:
* runtime/RegExp.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp
trunk/Source/_javascript_Core/runtime/Executable.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87358 => 87359)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-26 05:19:25 UTC (rev 87358)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-26 05:32:18 UTC (rev 87359)
@@ -9,6 +9,66 @@
 
 Reviewed by Sam Weinig.
 
+Bug 61503 - Move population of CodeBlock::m_structureStubInfos into JIT
+
+This data structure, used at runtime by the JIT, is currently unnecessarily populated
+with default entries during byte compilation.
+
+Aside from meaning that there is JIT specific code in the bytecompiler, this also ties
+us to one entry per corresponding bytecode op, which may be undesirable. Instead,
+populate this array from the JIT.
+
+The type StructureStubInfo has two unused states, one for gets & one for puts. Unify
+these, so that the class can have a default constructor (and to simply switch statements
+in code walking over the table).
+
+This change has ramification for the DFG JIT, in that the DFG JIT used this datastructure
+to check for functions containing property access. Instead do so in the DFGByteCodeParser.
+
+* bytecode/CodeBlock.cpp:
+(JSC::printStructureStubInfo):
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::setNumberOfStructureStubInfos):
+(JSC::CodeBlock::numberOfStructureStubInfos):
+* bytecode/StructureStubInfo.cpp:
+(JSC::StructureStubInfo::deref):
+(JSC::StructureStubInfo::visitAggregate):
+* bytecode/StructureStubInfo.h:
+(JSC::StructureStubInfo::StructureStubInfo):
+* bytecompiler/BytecodeGenerator.cpp:
+(JSC::BytecodeGenerator::emitGetById):
+(JSC::BytecodeGenerator::emitPutById):
+(JSC::BytecodeGenerator::emitDirectPutById):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+* jit/JIT.cpp:
+(JSC::JIT::JIT):
+(JSC::JIT::privateCompileMainPass):
+(JSC::JIT::privateCompileSlowCases):
+(JSC::JIT::privateCompile):
+* jit/JIT.h:
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emit_op_get_by_id):
+(JSC::JIT::emit_op_put_by_id):
+(JSC::JIT::emit_op_method_check):
+(JSC::JIT::compileGetByIdHotPath):
+(JSC::JIT::compileGetByIdSlowCase):
+(JSC::JIT::emitSlow_op_put_by_id):
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::emit_op_get_by_id):
+(JSC::JIT::emitSlow_op_get_by_id):
+(JSC::JIT::emit_op_put_by_id):
+(JSC::JIT::emitSlow_op_put_by_id):
+(JSC::JIT::emit_op_method_check):
+(JSC::JIT::compileGetByIdHotPath):
+(JSC::JIT::compileGetByIdSlowCase):
+* runtime/Executable.cpp:
+(JSC::tryDFGCompile):
+
+2011-05-25  Gavin Barraclough  
+
+Reviewed by Sam Weinig.
+
 Bug 61501 - Unify AbstractMacroAssembler::differenceBetween methods.
 
 * assembler/AbstractMacroAssembler.h:


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (87358 => 87359)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-05-26 05:19:25 UTC (rev 87358)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-05-26 05:32:18 UTC (rev 87359)
@@ -252,12 +252,9 @@
 case access_put_by_id_replace:
 printf("  [%4d] %s: %s\n", instructionOffset, "put_by_id_replace", pointerToSourceString(stubInfo.u.putByIdReplace.baseObjectStructure).utf8().data());
 return;
-case access_get_by_id:
-printf("  [%4d] %s\n", instructionOffset, "get_by_id");
+case access_unset:
+printf("  [%4d] %s\n", instructionOffset, "unset");
 return;
-case access_put_by_id:
-printf("  [%4d] %s\n", instructionOffset, "put_by_id");
-return;
 case access_get_by_id_generic:
 printf("  [%4d] %s\n", instructionOffset, "op_get_by_id_generic");
 return;


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (87358 => 87359)

--- trunk/Source

[webkit-changes] [87358] trunk/Source/JavaScriptCore

2011-05-25 Thread rniwa

Title: [87358] trunk/Source/_javascript_Core








Revision 87358
Author rn...@webkit.org
Date 2011-05-25 22:19:25 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Ryosuke Niwa  

An attempt to revive Windows bots.

* runtime/RegExp.cpp:
* runtime/RegExp.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87357 => 87358)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-26 04:16:36 UTC (rev 87357)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-26 05:19:25 UTC (rev 87358)
@@ -1,3 +1,10 @@
+2011-05-25  Ryosuke Niwa  
+
+An attempt to revive Windows bots.
+
+* runtime/RegExp.cpp:
+* runtime/RegExp.h:
+
 2011-05-25  Gavin Barraclough  
 
 Reviewed by Sam Weinig.


Modified: trunk/Source/_javascript_Core/runtime/RegExp.cpp (87357 => 87358)

--- trunk/Source/_javascript_Core/runtime/RegExp.cpp	2011-05-26 04:16:36 UTC (rev 87357)
+++ trunk/Source/_javascript_Core/runtime/RegExp.cpp	2011-05-26 05:19:25 UTC (rev 87358)
@@ -282,5 +282,5 @@
 printf("%-40.40s %16.16s %10d %10d\n", formattedPattern, jitAddr, m_rtMatchCallCount, m_rtMatchFoundCount);
 }
 #endif
-
+
 } // namespace JSC


Modified: trunk/Source/_javascript_Core/runtime/RegExp.h (87357 => 87358)

--- trunk/Source/_javascript_Core/runtime/RegExp.h	2011-05-26 04:16:36 UTC (rev 87357)
+++ trunk/Source/_javascript_Core/runtime/RegExp.h	2011-05-26 05:19:25 UTC (rev 87358)
@@ -52,7 +52,7 @@
 
 int match(JSGlobalData&, const UString&, int startOffset, Vector* ovector = 0);
 unsigned numSubpatterns() const { return m_numSubpatterns; }
-
+
 void invalidateCode();
 
 #if ENABLE(REGEXP_TRACING)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87357] trunk/LayoutTests

2011-05-25 Thread commit-queue

Title: [87357] trunk/LayoutTests








Revision 87357
Author commit-qu...@webkit.org
Date 2011-05-25 21:16:36 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Igor Oliveira  

Reviewed by Antonio Gomes.

[Qt] REGRESSION(r87298) Skip drag-not-loaded-image.html failing test
https://bugs.webkit.org/show_bug.cgi?id=61465

Skip drag-not-loaded-image.html layout test from Qt. see bug 31332

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (87356 => 87357)

--- trunk/LayoutTests/ChangeLog	2011-05-26 04:12:41 UTC (rev 87356)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 04:16:36 UTC (rev 87357)
@@ -1,3 +1,14 @@
+2011-05-25  Igor Oliveira  
+
+Reviewed by Antonio Gomes.
+
+[Qt] REGRESSION(r87298) Skip drag-not-loaded-image.html failing test
+https://bugs.webkit.org/show_bug.cgi?id=61465
+
+Skip drag-not-loaded-image.html layout test from Qt. see bug 31332
+
+* platform/qt/Skipped:
+
 2011-05-25  Steve Lacey  
 
 Reviewed by Eric Carlson.


Modified: trunk/LayoutTests/platform/qt/Skipped (87356 => 87357)

--- trunk/LayoutTests/platform/qt/Skipped	2011-05-26 04:12:41 UTC (rev 87356)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-05-26 04:16:36 UTC (rev 87357)
@@ -132,6 +132,7 @@
 http/tests/local/drag-over-remote-content.html
 http/tests/local/fileapi
 http/tests/security/drag-drop-same-unique-origin.html
+http/tests/misc/drag-not-loaded-image.html
 # CONSOLE MESSAGE: line 72: TypeError: Result of _expression_ 'eventSender.beginDragWithFiles' [undefined] is not a function.
 http/tests/local/blob/send-hybrid-blob.html
 http/tests/local/blob/send-sliced-data-blob.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87356] trunk/Source/JavaScriptCore

2011-05-25 Thread barraclough

Title: [87356] trunk/Source/_javascript_Core








Revision 87356
Author barraclo...@apple.com
Date 2011-05-25 21:12:41 -0700 (Wed, 25 May 2011)


Log Message
Bug 61501 - Unify AbstractMacroAssembler::differenceBetween methods.

Reviewed by Sam Weinig.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Call::fromTailJump):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::Jump::isSet):
(JSC::AbstractMacroAssembler::differenceBetween):
(JSC::AbstractMacroAssembler::linkJump):
(JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::link):
(JSC::LinkBuffer::locationOf):
(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::returnAddressOffset):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::linkCall):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::linkCall):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::linkCall):
* assembler/MacroAssemblerSH4.cpp:
(JSC::MacroAssemblerSH4::linkCall):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::linkCall):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::linkCall):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/assembler/LinkBuffer.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87355 => 87356)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-26 04:05:42 UTC (rev 87355)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-26 04:12:41 UTC (rev 87356)
@@ -2,6 +2,40 @@
 
 Reviewed by Sam Weinig.
 
+Bug 61501 - Unify AbstractMacroAssembler::differenceBetween methods.
+
+* assembler/AbstractMacroAssembler.h:
+(JSC::AbstractMacroAssembler::Call::Call):
+(JSC::AbstractMacroAssembler::Call::fromTailJump):
+(JSC::AbstractMacroAssembler::Jump::Jump):
+(JSC::AbstractMacroAssembler::Jump::link):
+(JSC::AbstractMacroAssembler::Jump::linkTo):
+(JSC::AbstractMacroAssembler::Jump::isSet):
+(JSC::AbstractMacroAssembler::differenceBetween):
+(JSC::AbstractMacroAssembler::linkJump):
+(JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):
+* assembler/LinkBuffer.h:
+(JSC::LinkBuffer::link):
+(JSC::LinkBuffer::locationOf):
+(JSC::LinkBuffer::locationOfNearCall):
+(JSC::LinkBuffer::returnAddressOffset):
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::linkCall):
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::linkCall):
+* assembler/MacroAssemblerMIPS.h:
+(JSC::MacroAssemblerMIPS::linkCall):
+* assembler/MacroAssemblerSH4.cpp:
+(JSC::MacroAssemblerSH4::linkCall):
+* assembler/MacroAssemblerX86.h:
+(JSC::MacroAssemblerX86::linkCall):
+* assembler/MacroAssemblerX86_64.h:
+(JSC::MacroAssemblerX86_64::linkCall):
+
+2011-05-25  Gavin Barraclough  
+
+Reviewed by Sam Weinig.
+
 https://bugs.webkit.org/show_bug.cgi?id=61500
 Add JSObject::offsetOfPropertyStorage
 


Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (87355 => 87356)

--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h	2011-05-26 04:05:42 UTC (rev 87355)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h	2011-05-26 04:12:41 UTC (rev 87356)
@@ -361,7 +361,7 @@
 }
 
 Call(AssemblerLabel jmp, Flags flags)
-: m_jmp(jmp)
+: m_label(jmp)
 , m_flags(flags)
 {
 }
@@ -373,10 +373,10 @@
 
 static Call fromTailJump(Jump jump)
 {
-return Call(jump.m_jmp, Linkable);
+return Call(jump.m_label, Linkable);
 }
 
-AssemblerLabel m_jmp;
+AssemblerLabel m_label;
 private:
 Flags m_flags;
 };
@@ -400,14 +400,14 @@
 #if CPU(ARM_THUMB2)
 // Fixme: this information should be stored in the instruction stream, not in the Jump object.
 Jump(AssemblerLabel jmp, ARMv7Assembler::JumpType type, ARMv7Assembler::Condition condition = ARMv7Assembler::ConditionInvalid)
-: m_jmp(jmp)
+: m_label(jmp)
 , m_type(type)
 , m_condition(condition)
 {
 }
 #else
 Jump(AssemblerLabel jmp)
-: m_jmp(jmp)
+: m_label

[webkit-changes] [87355] trunk/Source/JavaScriptCore

2011-05-25 Thread barraclough

Title: [87355] trunk/Source/_javascript_Core








Revision 87355
Author barraclo...@apple.com
Date 2011-05-25 21:05:42 -0700 (Wed, 25 May 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=61500
Add JSObject::offsetOfPropertyStorage

Reviewed by Sam Weinig.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
* runtime/JSObject.h:
(JSC::JSObject::offsetOfPropertyStorage):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87354 => 87355)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-26 03:50:11 UTC (rev 87354)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-26 04:05:42 UTC (rev 87355)
@@ -1,3 +1,23 @@
+2011-05-25  Gavin Barraclough  
+
+Reviewed by Sam Weinig.
+
+https://bugs.webkit.org/show_bug.cgi?id=61500
+Add JSObject::offsetOfPropertyStorage
+
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::compileGetDirectOffset):
+(JSC::JIT::compileGetByIdHotPath):
+(JSC::JIT::emit_op_put_by_id):
+(JSC::JIT::compilePutDirectOffset):
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::compileGetByIdHotPath):
+(JSC::JIT::emit_op_put_by_id):
+(JSC::JIT::compilePutDirectOffset):
+(JSC::JIT::compileGetDirectOffset):
+* runtime/JSObject.h:
+(JSC::JSObject::offsetOfPropertyStorage):
+
 2011-05-25  Oliver Hunt  
 
 Reviewed by Geoffrey Garen.


Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp (87354 => 87355)

--- trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp	2011-05-26 03:50:11 UTC (rev 87354)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp	2011-05-26 04:05:42 UTC (rev 87355)
@@ -140,7 +140,7 @@
 
 void JIT::compileGetDirectOffset(RegisterID base, RegisterID result, RegisterID offset, RegisterID scratch)
 {
-loadPtr(Address(base, OBJECT_OFFSETOF(JSObject, m_propertyStorage)), scratch);
+loadPtr(Address(base, JSObject::offsetOfPropertyStorage()), scratch);
 loadPtr(BaseIndex(scratch, offset, ScalePtr, 0), result);
 }
 
@@ -419,7 +419,7 @@
 ASSERT_JIT_OFFSET(differenceBetween(hotPathBegin, structureToCompare), patchOffsetGetByIdStructure);
 ASSERT_JIT_OFFSET(differenceBetween(hotPathBegin, structureCheck), patchOffsetGetByIdBranchToSlowCase)
 
-loadPtr(Address(regT0, OBJECT_OFFSETOF(JSObject, m_propertyStorage)), regT0);
+loadPtr(Address(regT0, JSObject::offsetOfPropertyStorage()), regT0);
 DataLabelCompact displacementLabel = loadPtrWithCompactAddressOffsetPatch(Address(regT0, patchGetByIdDefaultOffset), regT0);
 ASSERT_JIT_OFFSET_UNUSED(displacementLabel, differenceBetween(hotPathBegin, displacementLabel), patchOffsetGetByIdPropertyMapOffset);
 
@@ -495,7 +495,7 @@
 addSlowCase(branchPtrWithPatch(NotEqual, Address(regT0, JSCell::structureOffset()), structureToCompare, TrustedImmPtr(reinterpret_cast(patchGetByIdDefaultStructure;
 ASSERT_JIT_OFFSET(differenceBetween(hotPathBegin, structureToCompare), patchOffsetPutByIdStructure);
 
-loadPtr(Address(regT0, OBJECT_OFFSETOF(JSObject, m_propertyStorage)), regT0);
+loadPtr(Address(regT0, JSObject::offsetOfPropertyStorage()), regT0);
 DataLabel32 displacementLabel = storePtrWithAddressOffsetPatch(regT1, Address(regT0, patchPutByIdDefaultOffset));
 
 END_UNINTERRUPTED_SEQUENCE(sequencePutById);
@@ -532,7 +532,7 @@
 if (structure->isUsingInlineStorage())
 offset += JSObject::offsetOfInlineStorage();
 else
-loadPtr(Address(base, OBJECT_OFFSETOF(JSObject, m_propertyStorage)), base);
+loadPtr(Address(base, JSObject::offsetOfPropertyStorage()), base);
 storePtr(value, Address(base, offset));
 }
 
@@ -544,7 +544,7 @@
 offset += JSObject::offsetOfInlineStorage();
 loadPtr(Address(base, offset), result);
 } else {
-loadPtr(Address(base, OBJECT_OFFSETOF(JSObject, m_propertyStorage)), result);
+loadPtr(Address(base, JSObject::offsetOfPropertyStorage()), result);
 loadPtr(Address(result, offset), result);
 }
 }


Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp (87354 => 87355)

--- trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp	2011-05-26 03:50:11 UTC (rev 87354)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp	2011-05-26 04:05:42 UTC (rev 87355)
@@ -434,7 +434,7 @@
 ASSERT_JIT_OFFSET(differenceBetween(hotPathBegin, structureToCompare), patchOffsetGetByIdStructure);
 ASSERT_JIT_OFFSET(differenceBetween

[webkit-changes] [87353] trunk

2011-05-25 Thread commit-queue

Title: [87353] trunk








Revision 87353
Author commit-qu...@webkit.org
Date 2011-05-25 20:32:07 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Gregg Tavares  

Reviewed by Kenneth Russell.

Add 'noExtensions' option to Web/GraphicsContext3D attributes.
https://bugs.webkit.org/show_bug.cgi?id=61460

* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
* Source/WebCore/platform/graphics/GraphicsContext3D.h:
* Source/WebKit/chromium/public/WebGraphicsContext3D.h:
* Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h
trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp




Diff

Modified: trunk/ChangeLog (87352 => 87353)

--- trunk/ChangeLog	2011-05-26 03:13:31 UTC (rev 87352)
+++ trunk/ChangeLog	2011-05-26 03:32:07 UTC (rev 87353)
@@ -1,3 +1,15 @@
+2011-05-25  Gregg Tavares  
+
+Reviewed by Kenneth Russell.
+
+Add 'noExtensions' option to Web/GraphicsContext3D attributes.
+https://bugs.webkit.org/show_bug.cgi?id=61460
+
+* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
+* Source/WebCore/platform/graphics/GraphicsContext3D.h:
+* Source/WebKit/chromium/public/WebGraphicsContext3D.h:
+* Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:
+
 2011-05-24  Keishi Hattori  
 
 Reviewed by Kent Tamura.


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (87352 => 87353)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2011-05-26 03:13:31 UTC (rev 87352)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2011-05-26 03:32:07 UTC (rev 87353)
@@ -369,6 +369,7 @@
 attributes.antialias = false;
 }
 
+attributes.noExtensions = true;
 RefPtr context(GraphicsContext3D::create(attributes, hostWindow));
 
 if (!context) {


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h (87352 => 87353)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h	2011-05-26 03:13:31 UTC (rev 87352)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h	2011-05-26 03:32:07 UTC (rev 87353)
@@ -427,6 +427,7 @@
 , premultipliedAlpha(true)
 , canRecoverFromContextLoss(true)
 , preserveDrawingBuffer(false)
+, noExtensions(false)
 {
 }
 
@@ -437,6 +438,7 @@
 bool premultipliedAlpha;
 bool canRecoverFromContextLoss;
 bool preserveDrawingBuffer;
+bool noExtensions;
 };
 
 enum RenderStyle {


Modified: trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h (87352 => 87353)

--- trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h	2011-05-26 03:13:31 UTC (rev 87352)
+++ trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h	2011-05-26 03:32:07 UTC (rev 87353)
@@ -85,6 +85,7 @@
 , antialias(true)
 , premultipliedAlpha(true)
 , canRecoverFromContextLoss(true)
+, noExtensions(false)
 {
 }
 
@@ -94,6 +95,7 @@
 bool antialias;
 bool premultipliedAlpha;
 bool canRecoverFromContextLoss;
+bool noExtensions;
 };
 
 class WebGraphicsContextLostCallback {


Modified: trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp (87352 => 87353)

--- trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	2011-05-26 03:13:31 UTC (rev 87352)
+++ trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	2011-05-26 03:32:07 UTC (rev 87353)
@@ -109,6 +109,7 @@
 webAttributes.antialias = attrs.antialias;
 webAttributes.premultipliedAlpha = attrs.premultipliedAlpha;
 webAttributes.canRecoverFromContextLoss = attrs.canRecoverFromContextLoss;
+webAttributes.noExtensions = attrs.noExtensions;
 OwnPtr webContext = adoptPtr(WebKit::webKitClient()->createGraphicsContext3D());
 if (!webContext)
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87352] trunk/Source/WebCore

2011-05-25 Thread leviw

Title: [87352] trunk/Source/WebCore








Revision 87352
Author le...@chromium.org
Date 2011-05-25 20:13:31 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Levi Weintraub  

Reviewed by Eric Seidel.

Switch itemBoundingBoxRect to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60789

Changing itemBoundingBoxRect to use an IntPoint representing the offset
to be added tot he box rect instead of a pair of ints.

No new tests since this is just refactoring.

* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::elementAccessibilityHitTest):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::elementRect):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::itemBoundingBoxRect):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::nodeAtPoint):
* rendering/RenderListBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp
trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (87351 => 87352)

--- trunk/Source/WebCore/ChangeLog	2011-05-26 02:31:38 UTC (rev 87351)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 03:13:31 UTC (rev 87352)
@@ -1,3 +1,27 @@
+2011-05-25  Levi Weintraub  
+
+Reviewed by Eric Seidel.
+
+Switch itemBoundingBoxRect to use IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=60789
+
+Changing itemBoundingBoxRect to use an IntPoint representing the offset
+to be added tot he box rect instead of a pair of ints.
+
+No new tests since this is just refactoring.
+
+* accessibility/AccessibilityListBox.cpp:
+(WebCore::AccessibilityListBox::elementAccessibilityHitTest):
+* accessibility/AccessibilityListBoxOption.cpp:
+(WebCore::AccessibilityListBoxOption::elementRect):
+* rendering/RenderListBox.cpp:
+(WebCore::RenderListBox::itemBoundingBoxRect):
+(WebCore::RenderListBox::addFocusRingRects):
+(WebCore::RenderListBox::paintItemForeground):
+(WebCore::RenderListBox::paintItemBackground):
+(WebCore::RenderListBox::nodeAtPoint):
+* rendering/RenderListBox.h:
+
 2011-05-24  MORITA Hajime  
 
 Reviewed by Dimitri Glazkov.


Modified: trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp (87351 => 87352)

--- trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp	2011-05-26 02:31:38 UTC (rev 87351)
+++ trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp	2011-05-26 03:13:31 UTC (rev 87352)
@@ -179,7 +179,7 @@
 AccessibilityObject* listBoxOption = 0;
 unsigned length = m_children.size();
 for (unsigned i = 0; i < length; i++) {
-IntRect rect = toRenderListBox(m_renderer)->itemBoundingBoxRect(parentRect.x(), parentRect.y(), i);
+IntRect rect = toRenderListBox(m_renderer)->itemBoundingBoxRect(parentRect.location(), i);
 // The cast to HTMLElement below is safe because the only other possible listItem type
 // would be a WMLElement, but WML builds don't use accessibility features at all.
 if (rect.contains(point)) {


Modified: trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp (87351 => 87352)

--- trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp	2011-05-26 02:31:38 UTC (rev 87351)
+++ trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp	2011-05-26 03:13:31 UTC (rev 87352)
@@ -100,7 +100,7 @@
 IntRect parentRect = listBoxRenderer->document()->axObjectCache()->getOrCreate(listBoxRenderer)->boundingBoxRect();
 int index = listBoxOptionIndex();
 if (index != -1)
-rect = toRenderListBox(listBoxRenderer)->itemBoundingBoxRect(parentRect.x(), parentRect.y(), index);
+rect = toRenderListBox(listBoxRenderer)->itemBoundingBoxRect(parentRect.location(), index);
 
 return rect;
 }


Modified: trunk/Source/WebCore/rendering/RenderListBox.cpp (87351 => 87352)

--- trunk/Source/WebCore/rendering/RenderListBox.cpp	2011-05-26 02:31:38 UTC (rev 87351)
+++ trunk/Source/WebCore/rendering/RenderListBox.cpp	2011-05-26 03:13:31 UTC (rev 87352)
@@ -249,10 +249,10 @@
 return RenderBox::baselinePosition(baselineType, firstLine, lineDirection, linePositionMode) - baselineAdjustment;
 }
 
-IntRect RenderListBox::itemBoundingBoxRect(int tx, int ty, int index)
+IntRect RenderListBox::itemBoundingBoxRect(const IntPoint& additionalOffset, int index)
 {
-return IntRect(tx + borderLeft() + paddingLeft(),
-   ty + borderTop() + paddingTop() + itemHeight() * (index - m_indexOffset),
+return IntRect(additiona

[webkit-changes] [87351] trunk

2011-05-25 Thread morrita

Title: [87351] trunk








Revision 87351
Author morr...@google.com
Date 2011-05-25 19:31:38 -0700 (Wed, 25 May 2011)


Log Message
2011-05-24  MORITA Hajime  

RenderText with empty text is not created inside ShadowContentElement
https://bugs.webkit.org/show_bug.cgi?id=6

- Added tests that capture the probelem.
- Updated expectations that were wrong.

* fast/html/details-replace-summary-child.html: Added.
* fast/html/details-replace-text.html: Added.
* platform/gtk/fast/html/details-no-summary4-expected.txt:
* platform/gtk/fast/html/details-open-_javascript_-expected.txt:
* platform/gtk/fast/html/details-open4-expected.txt:
* platform/mac/fast/html/details-add-details-child-2-expected.txt:
* platform/mac/fast/html/details-no-summary4-expected.txt:
* platform/mac/fast/html/details-open-_javascript_-expected.txt:
* platform/mac/fast/html/details-open4-expected.txt:
* platform/mac/fast/html/details-replace-summary-child-expected.png: Added.
* platform/mac/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/mac/fast/html/details-replace-text-expected.png: Added.
* platform/mac/fast/html/details-replace-text-expected.txt: Added.
* platform/qt/fast/html/details-no-summary4-expected.txt:
* platform/qt/fast/html/details-open-_javascript_-expected.txt:
* platform/qt/fast/html/details-open4-expected.txt:
2011-05-24  MORITA Hajime  

Reviewed by Dimitri Glazkov.

RenderText with empty text is not created inside ShadowContentElement
https://bugs.webkit.org/show_bug.cgi?id=6

- Changed Text::rendererIsNeeded() to be shadow-aware.
- previousRenderer(), nextRenderer() and parentRenderer() on NodeRenderingContext is now
  safe even if it's used with an attached node, which was originally used only during attach().
  We need this change because these APIs are called inside CharacterData::updateRenderer() callstack.

Tests: fast/html/details-replace-summary-child.html
   fast/html/details-replace-text.html

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
* dom/NodeRenderingContext.h:
(WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
* dom/Text.cpp:
(WebCore::Text::rendererIsNeeded):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/gtk/fast/html/details-no-summary4-expected.txt
trunk/LayoutTests/platform/gtk/fast/html/details-open-_javascript_-expected.txt
trunk/LayoutTests/platform/gtk/fast/html/details-open4-expected.txt
trunk/LayoutTests/platform/mac/fast/html/details-add-details-child-2-expected.txt
trunk/LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt
trunk/LayoutTests/platform/mac/fast/html/details-open-_javascript_-expected.txt
trunk/LayoutTests/platform/mac/fast/html/details-open4-expected.txt
trunk/LayoutTests/platform/qt/fast/html/details-no-summary4-expected.txt
trunk/LayoutTests/platform/qt/fast/html/details-open-_javascript_-expected.txt
trunk/LayoutTests/platform/qt/fast/html/details-open4-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/NodeRenderingContext.cpp
trunk/Source/WebCore/dom/NodeRenderingContext.h
trunk/Source/WebCore/dom/Text.cpp


Added Paths

trunk/LayoutTests/fast/html/details-replace-summary-child.html
trunk/LayoutTests/fast/html/details-replace-text.html
trunk/LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.png
trunk/LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt
trunk/LayoutTests/platform/mac/fast/html/details-replace-text-expected.png
trunk/LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87350 => 87351)

--- trunk/LayoutTests/ChangeLog	2011-05-26 01:58:06 UTC (rev 87350)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 02:31:38 UTC (rev 87351)
@@ -1,3 +1,28 @@
+2011-05-24  MORITA Hajime  
+
+RenderText with empty text is not created inside ShadowContentElement 
+https://bugs.webkit.org/show_bug.cgi?id=6
+
+- Added tests that capture the probelem.
+- Updated expectations that were wrong.
+
+* fast/html/details-replace-summary-child.html: Added.
+* fast/html/details-replace-text.html: Added.
+* platform/gtk/fast/html/details-no-summary4-expected.txt:
+* platform/gtk/fast/html/details-open-_javascript_-expected.txt:
+* platform/gtk/fast/html/details-open4-expected.txt:
+* platform/m

[webkit-changes] [87350] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87350] trunk/LayoutTests








Revision 87350
Author ad...@chromium.org
Date 2011-05-25 18:58:06 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Add Win/CRASH expectation for new crashy plugin test,
reported as http://crbug.com/83994.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87349 => 87350)

--- trunk/LayoutTests/ChangeLog	2011-05-26 01:50:55 UTC (rev 87349)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 01:58:06 UTC (rev 87350)
@@ -1,5 +1,12 @@
 2011-05-25  Adam Klein  
 
+Unreviewed. Add Win/CRASH expectation for new crashy plugin test,
+reported as http://crbug.com/83994.
+
+* platform/chromium/test_expectations.txt:
+
+2011-05-25  Adam Klein  
+
 Unreviewed. Temporarily ignore MHTML test failures on Windows
 while we dig into it in http://crbug.com/83833.
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87349 => 87350)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 01:50:55 UTC (rev 87349)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 01:58:06 UTC (rev 87350)
@@ -4153,3 +4153,6 @@
 BUGCR83833 WIN : mhtml/page_with_image_unmht.mht = MISSING
 BUGCR83833 WIN : mhtml/simple_page_ie.mht = MISSING
 BUGCR83833 WIN : mhtml/simple_page_unmht.mht = MISSING
+
+// New test added in r87324
+BUGCR83994 WIN : platform/win/plugins/call-_javascript_-that-destroys-plugin.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87349] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87349] trunk/LayoutTests








Revision 87349
Author ad...@chromium.org
Date 2011-05-25 18:50:55 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Temporarily ignore MHTML test failures on Windows
while we dig into it in http://crbug.com/83833.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87348 => 87349)

--- trunk/LayoutTests/ChangeLog	2011-05-26 01:48:25 UTC (rev 87348)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 01:50:55 UTC (rev 87349)
@@ -1,3 +1,10 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Temporarily ignore MHTML test failures on Windows
+while we dig into it in http://crbug.com/83833.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Qi Zhang  
 
 Reviewed by Simon Hausmann.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87348 => 87349)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 01:48:25 UTC (rev 87348)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 01:50:55 UTC (rev 87349)
@@ -4143,3 +4143,13 @@
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE
 
 BUGWK61486 DEBUG : http/tests/misc/drag-not-loaded-image.html = CRASH
+
+// New tests added in r87189
+BUGCR83833 WIN : mhtml/multi_frames_ie.mht = MISSING
+BUGCR83833 WIN : mhtml/multi_frames_unmht.mht = MISSING
+BUGCR83833 WIN : mhtml/page_with_css_and_js_ie.mht = MISSING
+BUGCR83833 WIN : mhtml/page_with_css_and_js_unmht.mht = MISSING
+BUGCR83833 WIN : mhtml/page_with_image_ie.mht = MISSING
+BUGCR83833 WIN : mhtml/page_with_image_unmht.mht = MISSING
+BUGCR83833 WIN : mhtml/simple_page_ie.mht = MISSING
+BUGCR83833 WIN : mhtml/simple_page_unmht.mht = MISSING






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87348] trunk

2011-05-25 Thread qi . 2 . zhang

Title: [87348] trunk








Revision 87348
Author qi.2.zh...@nokia.com
Date 2011-05-25 18:48:25 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Qi Zhang  

Reviewed by Simon Hausmann.

WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697

* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
2011-05-25  Qi Zhang  

Reviewed by Simon Hausmann.

WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697

Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetPrivateBrowsingEnabled):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-05-25  Qi Zhang  

Reviewed by Simon Hausmann.

WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697

Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setPrivateBrowsingEnabled):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/Skipped
trunk/LayoutTests/platform/qt-wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h




Diff

Modified: trunk/LayoutTests/ChangeLog (87347 => 87348)

--- trunk/LayoutTests/ChangeLog	2011-05-26 01:30:27 UTC (rev 87347)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 01:48:25 UTC (rev 87348)
@@ -1,3 +1,13 @@
+2011-05-25  Qi Zhang  
+
+Reviewed by Simon Hausmann.
+
+WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
+https://bugs.webkit.org/show_bug.cgi?id=42697
+
+* platform/mac-wk2/Skipped:
+* platform/qt-wk2/Skipped:
+
 2011-05-25  Adam Klein  
 
 Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only.


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (87347 => 87348)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2011-05-26 01:30:27 UTC (rev 87347)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2011-05-26 01:48:25 UTC (rev 87348)
@@ -1382,12 +1382,6 @@
 # 
 security/set-form-autocomplete-attribute.html
 
-# WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
-# 
-storage/domstorage/localstorage/private-browsing-affects-storage.html
-storage/domstorage/sessionstorage/private-browsing-affects-storage.html
-storage/private-browsing-noread-nowrite.html
-
 # WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
 # 
 http/tests/appcache/max-size.html


Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (87347 => 87348)

--- trunk/LayoutTests/platform/qt-wk2/Skipped	2011-05-26 01:30:27 UTC (rev 87347)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped	2011-05-26 01:48:25 UTC (rev 87348)
@@ -1773,11 +1773,6 @@
 # 
 security/set-form-autocomplete-attribute.html
 
-# WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
-# 
-storage/domstorage/localstorage/private-browsing-affects-storage.html
-storage/domstorage/sessionstorage/private-browsing-affects-storage.html
-
 # WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
 # 
 http/tests/appcache/max-size.html
@@ -2866,7 +2861,6 @@
 sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7.html
 sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7.html
 sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7.html
-storage/private-browsing-noread-nowrite.html
 svg/animations/animate-calcMode-spline-by.html
 svg/animations/animate-calcMode-spline-from-by.html
 svg/animations/animate-calcMode-spline-from-to.html


Modified: trunk/Source/WebKit2/ChangeLog (87347 => 87348)

--- tr

[webkit-changes] [87347] trunk/Source/WebCore

2011-05-25 Thread commit-queue

Title: [87347] trunk/Source/WebCore








Revision 87347
Author commit-qu...@webkit.org
Date 2011-05-25 18:30:27 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Sailesh Agrawal  

Reviewed by Tony Chang.

Rename ScrollbarOverlayUtilitiesMac to ScrollbarOverlayUtilitiesChromiumMac
https://bugs.webkit.org/show_bug.cgi?id=61401

ScrollbarOverlayUtilitiesMac.mm was being excluded from the WebCore project. Fix was to make sure the file name ended with ChromiumMac.

* WebCore.gypi:
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.h.
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm.
* platform/chromium/ScrollbarOverlayUtilitiesMac.h: Removed.
* platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi


Added Paths

trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm


Removed Paths

trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (87346 => 87347)

--- trunk/Source/WebCore/ChangeLog	2011-05-26 01:12:46 UTC (rev 87346)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 01:30:27 UTC (rev 87347)
@@ -1,3 +1,18 @@
+2011-05-25  Sailesh Agrawal  
+
+Reviewed by Tony Chang.
+
+Rename ScrollbarOverlayUtilitiesMac to ScrollbarOverlayUtilitiesChromiumMac
+https://bugs.webkit.org/show_bug.cgi?id=61401
+
+ScrollbarOverlayUtilitiesMac.mm was being excluded from the WebCore project. Fix was to make sure the file name ended with ChromiumMac.
+
+* WebCore.gypi:
+* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.h.
+* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm.
+* platform/chromium/ScrollbarOverlayUtilitiesMac.h: Removed.
+* platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Removed.
+
 2011-05-25  James Robinson  
 
 Reviewed by Geoffrey Garen


Modified: trunk/Source/WebCore/WebCore.gypi (87346 => 87347)

--- trunk/Source/WebCore/WebCore.gypi	2011-05-26 01:12:46 UTC (rev 87346)
+++ trunk/Source/WebCore/WebCore.gypi	2011-05-26 01:30:27 UTC (rev 87347)
@@ -3829,8 +3829,8 @@
 'platform/chromium/ReadableDataObject.cpp',
 'platform/chromium/ReadableDataObject.h',
 'platform/chromium/SSLKeyGeneratorChromium.cpp',
-'platform/chromium/ScrollbarOverlayUtilitiesMac.h',
-'platform/chromium/ScrollbarOverlayUtilitiesMac.mm',
+'platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h',
+'platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm',
 'platform/chromium/ScrollbarThemeChromium.cpp',
 'platform/chromium/ScrollbarThemeChromium.h',
 'platform/chromium/ScrollbarThemeChromiumLinux.cpp',


Copied: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h (from rev 87346, trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.h) (0 => 87347)

--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h	(rev 0)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h	2011-05-26 01:30:27 UTC (rev 87347)
@@ -0,0 +1,101 @@
+/*
+ * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
+ * Copyright (C) 2011 Google Inc. All Rights Reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ *

[webkit-changes] [87346] trunk/Source

2011-05-25 Thread oliver

Title: [87346] trunk/Source








Revision 87346
Author oli...@apple.com
Date 2011-05-25 18:12:46 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Oliver Hunt  

Reviewed by Geoffrey Garen.

Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490

Make RegExp GC allocated.  Basically mechanical change to replace
most use of [Pass]RefPtr with RegExp* or WriteBarrier
where actual ownership happens.

Made the RegExpCache use Strong<> references currently to avoid any
changes in behaviour.

* _javascript_Core.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addRegExp):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):
* bytecompiler/BytecodeGenerator.h:
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
(JSC::JSGlobalData::addRegExpToTrace):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:
(JSC::RegExp::createStructure):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
* runtime/RegExpCache.h:
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::visitChildren):
* runtime/RegExpObject.h:
(JSC::RegExpObject::setRegExp):
(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
(JSC::regExpProtoFuncCompile):
* runtime/RegExpPrototype.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
2011-05-25  James Robinson  

Reviewed by Geoffrey Garen

CachedResource overhead size calculation ignores the actual size of the URL
https://bugs.webkit.org/show_bug.cgi?id=61481

CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
it.  When the resource is a large data: URL, for example representing image or audio data, the URL size itself
can be significant.

This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
other types of strings instead of a fixed number.

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::overheadSize):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h
trunk/Source/_javascript_Core/runtime/RegExpCache.cpp
trunk/Source/_javascript_Core/runtime/RegExpCache.h
trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.h
trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp
trunk/Source/_javascript_Core/runtime/RegExpPrototype.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87345 => 87346)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-26 01:08:57 UTC (rev 87345)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-26 01:12:46 UTC (rev 87346)
@@ -1,9 +1,5 @@
 2011-05-25  Oliver Hunt  
 
-Revert last change, something weird happened when I went to land.
-
-2011-05-25  Oliver Hunt  
-
 Reviewed by Geoffrey Garen.
 
 Make RegExp GC allocated


Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (87345 => 87346)

--- trunk/Source/_javascript_Core/_javascript_Core.exp	2011-05-26 01:08:57 UTC (rev 87345)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp	2011-05-26 01:12:46 UTC (rev

[webkit-changes] [87345] trunk/Source

2011-05-25 Thread oliver

Title: [87345] trunk/Source








Revision 87345
Author oli...@apple.com
Date 2011-05-25 18:08:57 -0700 (Wed, 25 May 2011)


Log Message
Revert last change, something weird happened when I went to land.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/jit/JITStubs.h
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h
trunk/Source/_javascript_Core/runtime/RegExpCache.cpp
trunk/Source/_javascript_Core/runtime/RegExpCache.h
trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.h
trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp
trunk/Source/_javascript_Core/runtime/RegExpPrototype.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87344 => 87345)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-26 01:08:57 UTC (rev 87345)
@@ -1,5 +1,9 @@
 2011-05-25  Oliver Hunt  
 
+Revert last change, something weird happened when I went to land.
+
+2011-05-25  Oliver Hunt  
+
 Reviewed by Geoffrey Garen.
 
 Make RegExp GC allocated


Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (87344 => 87345)

--- trunk/Source/_javascript_Core/_javascript_Core.exp	2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp	2011-05-26 01:08:57 UTC (rev 87345)
@@ -137,7 +137,7 @@
 __ZN3JSC12JSGlobalData6createENS_15ThreadStackTypeE
 __ZN3JSC12JSGlobalDataD1Ev
 __ZN3JSC12RegExpObject6s_infoE
-__ZN3JSC12RegExpObjectC1EPNS_14JSGlobalObjectEPNS_9StructureEPNS_6RegExpE
+__ZN3JSC12RegExpObjectC1EPNS_14JSGlobalObjectEPNS_9StructureEN3WTF17NonNullPassRefPtrINS_6RegExpEEE
 __ZN3JSC12SamplingTool5setupEv
 __ZN3JSC12SmallStrings17createEmptyStringEPNS_12JSGlobalDataE
 __ZN3JSC12SmallStrings27createSingleCharacterStringEPNS_12JSGlobalDataEh


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (87344 => 87345)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-05-26 01:08:57 UTC (rev 87345)
@@ -18,7 +18,7 @@
 ??0MD5@WTF@@QAE@XZ
 ??0Mutex@WTF@@QAE@XZ
 ??0RefCountedLeakCounter@WTF@@QAE@PBD@Z
-??0RegExpObject@JSC@@QAE@PAVJSGlobalObject@1@PAVStructure@1@PAVRegExp@1@JSC@@@WTF@@@Z
+??0RegExpObject@JSC@@QAE@PAVJSGlobalObject@1@PAVStructure@1@V?$NonNullPassRefPtr@VRegExp@JSC@@@WTF@@@Z
 ??0SHA1@WTF@@QAE@XZ
 ??0StringObject@JSC@@QAE@PAVExecState@1@PAVStructure@1@ABVUString@1@@Z
 ??0Structure@JSC@@AAE@AAVJSGlobalData@1@VJSValue@1@ABVTypeInfo@1@IPBUClassInfo@1@@Z


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (87344 => 87345)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-05-26 01:08:57 UTC (rev 87345)
@@ -1470,13 +1470,8 @@
 {
 visitor.append(&m_globalObject);
 visitor.append(&m_ownerExecutable);
-if (m_rareData) {
+if (m_rareData)
 m_rareData->m_evalCodeCache.visitAggregate(visitor);
-size_t regExpCount = m_rareData->m_regexps.size();
-WriteBarrier* regexps = m_rareData->m_regexps.data();
-for (size_t i = 0; i < regExpCount; i++)
-visitor.append(regexps + i);
-}
 visitor.appendValues(m_constantRegisters.data(), m_constantRegisters.size());
 for (size_t i = 0; i < m_functionExprs.size(); ++i)
 visitor.append(&m_functionExprs[i]);


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (87344 => 87345)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2011-05-26 01:08:57 UTC (rev 87345)
@@ -36,7 +36,7 @@
 #include "JSGlobalObject.h"
 #include "JumpTable.h"
 #include "Nodes.h"
-#include "RegExpObject.h"
+#include "RegExp.h"

[webkit-changes] [87344] trunk/Source/WebCore

2011-05-25 Thread jamesr

Title: [87344] trunk/Source/WebCore








Revision 87344
Author jam...@google.com
Date 2011-05-25 18:07:57 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  James Robinson  

Reviewed by Geoffrey Garen

CachedResource overhead size calculation ignores the actual size of the URL
https://bugs.webkit.org/show_bug.cgi?id=61481

CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
it.  When the resource is a large data: URL, for example representing image or audio data, the URL size itself
can be significant.

This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
other types of strings instead of a fixed number.

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::overheadSize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87343 => 87344)

--- trunk/Source/WebCore/ChangeLog	2011-05-26 01:01:16 UTC (rev 87343)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 01:07:57 UTC (rev 87344)
@@ -1,3 +1,20 @@
+2011-05-25  James Robinson  
+
+Reviewed by Geoffrey Garen
+
+CachedResource overhead size calculation ignores the actual size of the URL
+https://bugs.webkit.org/show_bug.cgi?id=61481
+
+CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
+it.  When the resource is a large data: URL, for example representing image or audio data, the URL size itself
+can be significant.
+
+This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
+other types of strings instead of a fixed number.
+
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::overheadSize):
+
 2011-05-25  Oliver Hunt  
 
 Reviewed by Geoffrey Garen.


Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (87343 => 87344)

--- trunk/Source/WebCore/loader/cache/CachedResource.cpp	2011-05-26 01:01:16 UTC (rev 87343)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp	2011-05-26 01:07:57 UTC (rev 87344)
@@ -607,11 +607,8 @@
 
 unsigned CachedResource::overheadSize() const
 {
-return sizeof(CachedResource) + m_response.memoryUsage() + 576;
-/*
-576 = 192 +   // average size of m_url
-  384;// average size of m_clients hash map
-*/
+static const int kAverageClientsHashMapSize = 384;
+return sizeof(CachedResource) + m_response.memoryUsage() + kAverageClientsHashMapSize + m_resourceRequest.url().string().length() * 2;
 }
 
 void CachedResource::setLoadPriority(ResourceLoadPriority loadPriority) 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87343] trunk/Source

2011-05-25 Thread oliver

Title: [87343] trunk/Source








Revision 87343
Author oli...@apple.com
Date 2011-05-25 18:01:16 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Oliver Hunt  

Reviewed by Geoffrey Garen.

Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490

Make RegExp GC allocated.  Basically mechanical change to replace
most use of [Pass]RefPtr with RegExp* or WriteBarrier
where actual ownership happens.

Made the RegExpCache use Strong<> references currently to avoid any
changes in behaviour.

* _javascript_Core.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addRegExp):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):
* bytecompiler/BytecodeGenerator.h:
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
(JSC::JSGlobalData::addRegExpToTrace):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:
(JSC::RegExp::createStructure):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
* runtime/RegExpCache.h:
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::visitChildren):
* runtime/RegExpObject.h:
(JSC::RegExpObject::setRegExp):
(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
(JSC::regExpProtoFuncCompile):
* runtime/RegExpPrototype.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
2011-05-25  Oliver Hunt  

Reviewed by Geoffrey Garen.

Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490

RegExp is GC'd so we don't need the RefPtr shenanigans anymore.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/jit/JITStubs.h
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h
trunk/Source/_javascript_Core/runtime/RegExpCache.cpp
trunk/Source/_javascript_Core/runtime/RegExpCache.h
trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.h
trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp
trunk/Source/_javascript_Core/runtime/RegExpPrototype.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87342 => 87343)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-26 00:59:47 UTC (rev 87342)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-26 01:01:16 UTC (rev 87343)
@@ -2,6 +2,63 @@
 
 Reviewed by Geoffrey Garen.
 
+Make RegExp GC allocated
+https://bugs.webkit.org/show_bug.cgi?id=61490
+
+Make RegExp GC allocated.  Basically mechanical change to replace
+most use of [Pass]RefPtr with RegExp* or WriteBarrier
+where actual ownership happens.
+
+Made the RegExpCache use Strong<> references currently to avoid any
+changes in behaviour.
+
+* _javascript_Core.exp:
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::visitAggregate):
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::addRegExp):
+* bytecompiler/BytecodeGenerator.cpp:
+(JSC::BytecodeGenerator::addRegExp):
+(JSC::BytecodeGenerator::emitNewRegExp):
+* bytecompiler/BytecodeGenerator.h

[webkit-changes] [87342] trunk/Source/WebKit/chromium

2011-05-25 Thread commit-queue

Title: [87342] trunk/Source/WebKit/chromium








Revision 87342
Author commit-qu...@webkit.org
Date 2011-05-25 17:59:47 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Shishir Agrawal  

Reviewed by Dimitri Glazkov.

Fix crash in Chromium memory test.
https://bugs.webkit.org/show_bug.cgi?id=61451

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (87341 => 87342)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-05-26 00:52:17 UTC (rev 87341)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-05-26 00:59:47 UTC (rev 87342)
@@ -1,3 +1,13 @@
+2011-05-25  Shishir Agrawal  
+
+Reviewed by Dimitri Glazkov.
+
+Fix crash in Chromium memory test.
+https://bugs.webkit.org/show_bug.cgi?id=61451
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::WebViewImpl):
+
 2011-05-25  Sheriff Bot  
 
 Unreviewed, rolling out r87333.


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (87341 => 87342)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-26 00:52:17 UTC (rev 87341)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-26 00:59:47 UTC (rev 87342)
@@ -368,7 +368,8 @@
 m_page->setGroupName(pageGroupName);
 
 #if ENABLE(PAGE_VISIBILITY_API)
-setVisibilityState(m_client->visibilityState(), true);
+if (m_client)
+setVisibilityState(m_client->visibilityState(), true);
 #endif
 
 m_inspectorSettingsMap = adoptPtr(new SettingsMap);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87341] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87341] trunk/LayoutTests








Revision 87341
Author ad...@chromium.org
Date 2011-05-25 17:52:17 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87340 => 87341)

--- trunk/LayoutTests/ChangeLog	2011-05-26 00:44:16 UTC (rev 87340)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 00:52:17 UTC (rev 87341)
@@ -1,3 +1,9 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Jer Noble  
 
 Unreviewed; Skip failing tests after r87328.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87340 => 87341)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 00:44:16 UTC (rev 87340)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 00:52:17 UTC (rev 87341)
@@ -4142,4 +4142,4 @@
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html = IMAGE
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE
 
-BUGWK61486 : http/tests/misc/drag-not-loaded-image.html = CRASH
+BUGWK61486 DEBUG : http/tests/misc/drag-not-loaded-image.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87340] trunk/LayoutTests

2011-05-25 Thread jer . noble

Title: [87340] trunk/LayoutTests








Revision 87340
Author jer.no...@apple.com
Date 2011-05-25 17:44:16 -0700 (Wed, 25 May 2011)


Log Message
Unreviewed; Skip failing tests after r87328.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (87339 => 87340)

--- trunk/LayoutTests/ChangeLog	2011-05-26 00:27:05 UTC (rev 87339)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 00:44:16 UTC (rev 87340)
@@ -1,3 +1,9 @@
+2011-05-25  Jer Noble  
+
+Unreviewed; Skip failing tests after r87328.
+
+* platform/mac/Skipped:
+
 2011-05-25  Adam Klein  
 
 Unreviewed. Test expectations update.


Modified: trunk/LayoutTests/platform/mac/Skipped (87339 => 87340)

--- trunk/LayoutTests/platform/mac/Skipped	2011-05-26 00:27:05 UTC (rev 87339)
+++ trunk/LayoutTests/platform/mac/Skipped	2011-05-26 00:44:16 UTC (rev 87340)
@@ -359,3 +359,6 @@
 # console long eval test is timeout 60616
 inspector/console/console-long-eval-crash.html
 
+# Fails after r87328:
+# https://bugs.webkit.org/show_bug.cgi?id=61487
+http/tests/media/video-cross-site.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87339] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87339] trunk/LayoutTests








Revision 87339
Author ad...@chromium.org
Date 2011-05-25 17:27:05 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Test expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87338 => 87339)

--- trunk/LayoutTests/ChangeLog	2011-05-26 00:24:04 UTC (rev 87338)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 00:27:05 UTC (rev 87339)
@@ -1,5 +1,11 @@
 2011-05-25  Adam Klein  
 
+Unreviewed. Test expectations update.
+
+* platform/chromium/test_expectations.txt:
+
+2011-05-25  Adam Klein  
+
 Unreviewed. Rebaseline svg tests after r87310.
 
 * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87338 => 87339)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 00:24:04 UTC (rev 87338)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 00:27:05 UTC (rev 87339)
@@ -3852,7 +3852,7 @@
 
 BUGSENORBLANCO WIN LINUX : animations/animation-drt-api-multiple-keyframes.html = TEXT
 BUGSENORBLANCO WIN LINUX : animations/animation-drt-api.html = TEXT
-BUGSENORBLANCO GPU LEOPARD : compositing/direct-image-compositing.html = IMAGE CRASH
+BUGSENORBLANCO GPU MAC : compositing/direct-image-compositing.html = IMAGE CRASH
 BUGSENORBLANCO MAC LINUX : fast/css/string-quote-binary.html = CRASH PASS
 BUGSENORBLANCO LINUX : fast/events/panScroll-click-hyperlink.html = TEXT
 BUGSENORBLANCO : fast/files/domurl-script-execution-context-crash.html = CRASH PASS
@@ -4141,3 +4141,5 @@
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html = IMAGE
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html = IMAGE
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE
+
+BUGWK61486 : http/tests/misc/drag-not-loaded-image.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87338] trunk/Source/WebKit/chromium

2011-05-25 Thread adamk

Title: [87338] trunk/Source/WebKit/chromium








Revision 87338
Author ad...@chromium.org
Date 2011-05-25 17:24:04 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Sheriff Bot  

Unreviewed, rolling out r87333.
http://trac.webkit.org/changeset/87333
https://bugs.webkit.org/show_bug.cgi?id=61488

Breaks Chromium build due to pure virtual methods. (Requested
by aklein on #webkit).

* public/WebWidget.h:
* src/WebPopupMenuImpl.cpp:
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (87337 => 87338)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-05-26 00:24:04 UTC (rev 87338)
@@ -1,3 +1,18 @@
+2011-05-25  Sheriff Bot  
+
+Unreviewed, rolling out r87333.
+http://trac.webkit.org/changeset/87333
+https://bugs.webkit.org/show_bug.cgi?id=61488
+
+Breaks Chromium build due to pure virtual methods. (Requested
+by aklein on #webkit).
+
+* public/WebWidget.h:
+* src/WebPopupMenuImpl.cpp:
+* src/WebPopupMenuImpl.h:
+* src/WebViewImpl.cpp:
+* src/WebViewImpl.h:
+
 2011-05-25  Sailesh Agrawal  
 
 Reviewed by Darin Fisher.


Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (87337 => 87338)

--- trunk/Source/WebKit/chromium/public/WebWidget.h	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h	2011-05-26 00:24:04 UTC (rev 87338)
@@ -55,19 +55,9 @@
 // Returns the current size of the WebWidget.
 virtual WebSize size() = 0;
 
-// Used to group a series of resize events. For example, if the user
-// drags a resizer then willStartLiveResize will be called, followed by a
-// sequence of resize events, ending with willEndLiveResize when the user
-// lets go of the resizer.
-virtual void willStartLiveResize() = 0;
-
 // Called to resize the WebWidget.
 virtual void resize(const WebSize&) = 0;
 
-// Ends a group of resize events that was started with a call to
-// willStartLiveResize.
-virtual void willEndLiveResize() = 0;
-
 // Called to update imperative animation state.  This should be called before
 // paint, although the client can rate-limit these calls.
 virtual void animate() = 0;


Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp (87337 => 87338)

--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp	2011-05-26 00:24:04 UTC (rev 87338)
@@ -136,10 +136,6 @@
 deref();  // Balances ref() from WebWidget::Create
 }
 
-void WebPopupMenuImpl::willStartLiveResize()
-{
-}
-
 void WebPopupMenuImpl::resize(const WebSize& newSize)
 {
 if (m_size == newSize)
@@ -157,10 +153,6 @@
 }
 }
 
-void WebPopupMenuImpl::willEndLiveResize()
-{
-}
-
 void WebPopupMenuImpl::animate()
 {
 }


Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h (87337 => 87338)

--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h	2011-05-26 00:24:04 UTC (rev 87338)
@@ -62,9 +62,7 @@
 // WebWidget
 virtual void close();
 virtual WebSize size() { return m_size; }
-virtual void willStartLiveResize();
 virtual void resize(const WebSize&);
-virtual void willEndLiveResize();
 virtual void animate();
 virtual void layout();
 virtual void paint(WebCanvas* canvas, const WebRect& rect);


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (87337 => 87338)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-26 00:24:04 UTC (rev 87338)
@@ -972,12 +972,6 @@
 deref();  // Balances ref() acquired in WebView::create
 }
 
-void WebViewImpl::willStartLiveResize()
-{
-if (mainFrameImpl() && mainFrameImpl()->frameView())
-mainFrameImpl()->frameView()->willStartLiveResize();
-}
-
 void WebViewImpl::resize(const WebSize& newSize)
 {
 if (m_size == newSize)
@@ -1008,12 +1002,6 @@
 #endif
 }
 
-void WebViewImpl::willEndLiveResize()
-{
-if (mainFrameImpl() && mainFrameImpl()->frameView())
-mainFrameImpl()->frameView()->willEndLiveResize();
-}
-
 void WebViewImpl::animate()
 {
 TRACE_EVENT("WebViewImpl::animate", this, 0);


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (87337 => 87338)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.h	2011-05-26 0

[webkit-changes] [87337] trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

2011-05-25 Thread jam

Title: [87337] trunk/Source/WebKit/chromium/src/WebViewImpl.cpp








Revision 87337
Author j...@chromium.org
Date 2011-05-25 17:04:22 -0700 (Wed, 25 May 2011)


Log Message
Revert 79703 since it broke pdf scrolling (http://crbug.com/81878) - 2011-02-15  Brett Wilson  

Reviewed by Darin Fisher.

Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
https://bugs.webkit.org/show_bug.cgi?id=54503

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

TBR=bre...@chromium.org

Modified Paths

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (87336 => 87337)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-25 23:54:02 UTC (rev 87336)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-26 00:04:22 UTC (rev 87337)
@@ -1188,49 +1188,36 @@
 m_currentInputEvent = &inputEvent;
 
 if (m_mouseCaptureNode.get() && WebInputEvent::isMouseEventType(inputEvent.type)) {
-const int mouseButtonModifierMask = WebInputEvent::LeftButtonDown | WebInputEvent::MiddleButtonDown | WebInputEvent::RightButtonDown;
-if (inputEvent.type == WebInputEvent::MouseDown ||
-(inputEvent.modifiers & mouseButtonModifierMask) == 0) {
-// It's possible the mouse was released and we didn't get the "up"
-// message. This can happen if a dialog pops up while the mouse is
-// held, for example. This will leave us "stuck" in capture mode.
-// If we get a new mouse down message or any other mouse message
-// where no "down" flags are set, we know the user is no longer
-// dragging and we can release the capture and fall through to the
-// regular event processing.
+// Save m_mouseCaptureNode since mouseCaptureLost() will clear it.
+RefPtr node = m_mouseCaptureNode;
+
+// Not all platforms call mouseCaptureLost() directly.
+if (inputEvent.type == WebInputEvent::MouseUp)
 mouseCaptureLost();
-} else {
-// Save m_mouseCaptureNode since mouseCaptureLost() will clear it.
-RefPtr node = m_mouseCaptureNode;
 
-// Not all platforms call mouseCaptureLost() directly.
-if (inputEvent.type == WebInputEvent::MouseUp)
-mouseCaptureLost();
-
-AtomicString eventType;
-switch (inputEvent.type) {
-case WebInputEvent::MouseMove:
-eventType = eventNames().mousemoveEvent;
-break;
-case WebInputEvent::MouseLeave:
-eventType = eventNames().mouseoutEvent;
-break;
-case WebInputEvent::MouseDown:
-eventType = eventNames().mousedownEvent;
-break;
-case WebInputEvent::MouseUp:
-eventType = eventNames().mouseupEvent;
-break;
-default:
-ASSERT_NOT_REACHED();
-}
-
-node->dispatchMouseEvent(
-  PlatformMouseEventBuilder(mainFrameImpl()->frameView(), *static_cast(&inputEvent)),
-  eventType, static_cast(&inputEvent)->clickCount);
-m_currentInputEvent = 0;
-return true;
+AtomicString eventType;
+switch (inputEvent.type) {
+case WebInputEvent::MouseMove:
+eventType = eventNames().mousemoveEvent;
+break;
+case WebInputEvent::MouseLeave:
+eventType = eventNames().mouseoutEvent;
+break;
+case WebInputEvent::MouseDown:
+eventType = eventNames().mousedownEvent;
+break;
+case WebInputEvent::MouseUp:
+eventType = eventNames().mouseupEvent;
+break;
+default:
+ASSERT_NOT_REACHED();
 }
+
+node->dispatchMouseEvent(
+  PlatformMouseEventBuilder(mainFrameImpl()->frameView(), *static_cast(&inputEvent)),
+  eventType, static_cast(&inputEvent)->clickCount);
+m_currentInputEvent = 0;
+return true;
 }
 
 bool handled = true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87336] trunk/Source/WebCore

2011-05-25 Thread mrobinson

Title: [87336] trunk/Source/WebCore








Revision 87336
Author mrobin...@webkit.org
Date 2011-05-25 16:54:02 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Martin Robinson  

Reviewed by Dirk Schulze.

[Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo
https://bugs.webkit.org/show_bug.cgi?id=60185

Remove Cairo #ifdefs from GraphicsContext.h by pushing the global alpha
state into PlatformContextCairo. Since Cairo is the only platform that needs
to store this, this is the proper place for it. Change the image mask stack into
a more generic state stack that can keep track of the multiple bits of platform
specific state and properly handle save/restore pairs.

No new tests. This is just a code refactor.

* platform/graphics/GraphicsContext.h: Remove Cairo #ifdefs.
(WebCore::GraphicsContextState::GraphicsContextState): Ditto.
* platform/graphics/cairo/ContextShadowCairo.cpp: Access global alpha from PlatformContextCairo now.
(WebCore::ContextShadow::drawRectShadow):
* platform/graphics/cairo/FontCairo.cpp: Ditto.
(WebCore::Font::drawGlyphs):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill): Ditto.
(WebCore::setPlatformStroke): Ditto.
(WebCore::GraphicsContext::setAlpha): Ditto.
* platform/graphics/cairo/PlatformContextCairo.cpp: Moved ImageMaskInformation class from the
header file, since it can be private now. Abstract the image mask state and the global alpha
in a generic State class.
(WebCore::ImageMaskInformation::update):
(WebCore::ImageMaskInformation::isValid):
(WebCore::ImageMaskInformation::maskSurface):
(WebCore::ImageMaskInformation::maskRect):
(WebCore::PlatformContextCairo::State::State): Added.
(WebCore::PlatformContextCairo::PlatformContextCairo): Intialize the state
class when this class is constructed.
(WebCore::PlatformContextCairo::restore): Now pop the last state off the state stack.
(WebCore::PlatformContextCairo::~PlatformContextCairo): Added this so that we can forward
declare the State class in the header.
(WebCore::PlatformContextCairo::save): Push a new state onto the stack.
(WebCore::PlatformContextCairo::pushImageMask): Operate on the state stack now.
(WebCore::PlatformContextCairo::globalAlpha): Added.
(WebCore::PlatformContextCairo::setGlobalAlpha): Added.
(WebCore::PlatformContextCairo::drawSurfaceToContext: Call globalAlpha().
* platform/graphics/cairo/PlatformContextCairo.h: Changed the image mask stack
into a more generic state stack, much like PlatformContextChromium.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/cairo/ContextShadowCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (87335 => 87336)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 23:41:07 UTC (rev 87335)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 23:54:02 UTC (rev 87336)
@@ -1,3 +1,49 @@
+2011-05-25  Martin Robinson  
+
+Reviewed by Dirk Schulze.
+
+[Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo
+https://bugs.webkit.org/show_bug.cgi?id=60185
+
+Remove Cairo #ifdefs from GraphicsContext.h by pushing the global alpha
+state into PlatformContextCairo. Since Cairo is the only platform that needs
+to store this, this is the proper place for it. Change the image mask stack into
+a more generic state stack that can keep track of the multiple bits of platform
+specific state and properly handle save/restore pairs.
+
+No new tests. This is just a code refactor.
+
+* platform/graphics/GraphicsContext.h: Remove Cairo #ifdefs.
+(WebCore::GraphicsContextState::GraphicsContextState): Ditto.
+* platform/graphics/cairo/ContextShadowCairo.cpp: Access global alpha from PlatformContextCairo now.
+(WebCore::ContextShadow::drawRectShadow):
+* platform/graphics/cairo/FontCairo.cpp: Ditto.
+(WebCore::Font::drawGlyphs):
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+(WebCore::setPlatformFill): Ditto.
+(WebCore::setPlatformStroke): Ditto.
+(WebCore::GraphicsContext::setAlpha): Ditto.
+* platform/graphics/cairo/PlatformContextCairo.cpp: Moved ImageMaskInformation class from the
+header file, since it can be private now. Abstract the image mask state and the global alpha
+in a

[webkit-changes] [87335] trunk/Source

2011-05-25 Thread mrowe

Title: [87335] trunk/Source








Revision 87335
Author mr...@apple.com
Date 2011-05-25 16:41:07 -0700 (Wed, 25 May 2011)


Log Message
 Need some way to query user gesture state from injected bundle

Reviewed by Sam Weinig.

Source/WebCore:

* WebCore.exp.in: Add an export that WebKit2 needs.

Source/WebKit2:

Add WKBundleIsProcessingUserGesture.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleIsPageBoxVisible):
(WKBundleIsProcessingUserGesture):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::isProcessingUserGesture):
* WebProcess/InjectedBundle/InjectedBundle.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (87334 => 87335)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 23:41:07 UTC (rev 87335)
@@ -1,3 +1,11 @@
+2011-05-25  Mark Rowe  
+
+Reviewed by Sam Weinig.
+
+ Need some way to query user gesture state from injected bundle
+
+* WebCore.exp.in: Add an export that WebKit2 needs.
+
 2011-05-25  Jer Noble  
 
 Ureviewed; Build fix for Leopard and Snow Leopard.


Modified: trunk/Source/WebCore/WebCore.exp.in (87334 => 87335)

--- trunk/Source/WebCore/WebCore.exp.in	2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-05-25 23:41:07 UTC (rev 87335)
@@ -540,6 +540,7 @@
 __ZN7WebCore20ResourceResponseBase24setExpectedContentLengthEx
 __ZN7WebCore20ResourceResponseBaseC2Ev
 __ZN7WebCore20SpaceSplitStringData12createVectorEv
+__ZN7WebCore20UserGestureIndicator23s_processingUserGestureE
 __ZN7WebCore20UserGestureIndicatorC1ENS_26ProcessingUserGestureStateE
 __ZN7WebCore20UserGestureIndicatorD1Ev
 __ZN7WebCore20makeRGBA32FromFloatsE


Modified: trunk/Source/WebKit2/ChangeLog (87334 => 87335)

--- trunk/Source/WebKit2/ChangeLog	2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebKit2/ChangeLog	2011-05-25 23:41:07 UTC (rev 87335)
@@ -1,3 +1,19 @@
+2011-05-25  Mark Rowe  
+
+Reviewed by Sam Weinig.
+
+ Need some way to query user gesture state from injected bundle
+
+Add WKBundleIsProcessingUserGesture.
+
+* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+(WKBundleIsPageBoxVisible):
+(WKBundleIsProcessingUserGesture):
+* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+* WebProcess/InjectedBundle/InjectedBundle.cpp:
+(WebKit::InjectedBundle::isProcessingUserGesture):
+* WebProcess/InjectedBundle/InjectedBundle.h:
+
 2011-05-24  Jer Noble  
 
 Reviewed by Darin Adler.


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (87334 => 87335)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp	2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp	2011-05-25 23:41:07 UTC (rev 87335)
@@ -193,7 +193,12 @@
 return toCopiedAPI(toImpl(bundleRef)->pageSizeAndMarginsInPixels(toImpl(frameRef), pageIndex, width, height, marginTop, marginRight, marginBottom, marginLeft));
 }
 
-WK_EXPORT bool WKBundleIsPageBoxVisible(WKBundleRef bundleRef, WKBundleFrameRef frameRef, int pageIndex)
+bool WKBundleIsPageBoxVisible(WKBundleRef bundleRef, WKBundleFrameRef frameRef, int pageIndex)
 {
 return toImpl(bundleRef)->isPageBoxVisible(toImpl(frameRef), pageIndex);
 }
+
+bool WKBundleIsProcessingUserGesture(WKBundleRef)
+{
+return InjectedBundle::isProcessingUserGesture();
+}


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h (87334 => 87335)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h	2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h	2011-05-25 23:41:07 UTC (rev 87335)
@@ -79,6 +79,8 @@
 WK_EXPORT void WKBundleRemoveOriginAccessWhitelistEntry(WKBundleRef bundle, WKStringRef, WKStringRef, WKStringRef, bool);
 WK_EXPORT void WKBundleResetOriginAccessWhitelists(WKBundleRef bundle);
 
+WK_EXPORT bool WKBundleIsProcessingUserGesture(WKBundleRef bundle);
+
 #ifdef __cplusplus
 }
 #endif


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (87334 => 87335)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp	2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp	2011-05-25 23:41:07 UTC (rev 87335)
@@ -51,6 +51,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -216,6 +217,11 @@
 return PrintContext::isPageBoxV

[webkit-changes] [87334] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87334] trunk/LayoutTests








Revision 87334
Author ad...@chromium.org
Date 2011-05-25 16:39:48 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Rebaseline svg tests after r87310.

* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (87333 => 87334)

--- trunk/LayoutTests/ChangeLog	2011-05-25 23:30:41 UTC (rev 87333)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 23:39:48 UTC (rev 87334)
@@ -1,5 +1,20 @@
 2011-05-25  Adam Klein  
 
+Unreviewed. Rebaseline svg tests after r87310.
+
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+* platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
+* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+
+2011-05-25  Adam Klein  
+
 Unreviewed. Removing test_expectations for non-existent tests.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt (0 => 87334)

--- trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt	2011-05-25 23:39:48 UTC (rev 87334)
@@ -0,0 +1,40 @@
+layer at (0,0) size 480x360
+  RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+  RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (82,20) size 362x264
+  RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGResourceFilter {filter} [id="null"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+RenderSVGResourceFilter {filter} [id="nullreg"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+  RenderSVGContainer {g} at (90,20) size 80x114
+RenderSVGPath {circle} at (1

[webkit-changes] [87333] trunk/Source/WebKit/chromium

2011-05-25 Thread commit-queue

Title: [87333] trunk/Source/WebKit/chromium








Revision 87333
Author commit-qu...@webkit.org
Date 2011-05-25 16:30:41 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Sailesh Agrawal  

Reviewed by Darin Fisher.

Expose willStartLiveResize and willEndLiveResize in WebWidget
https://bugs.webkit.org/show_bug.cgi?id=60518

* public/WebWidget.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::willStartLiveResize):
(WebKit::WebPopupMenuImpl::willEndLiveResize):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::willStartLiveResize):
(WebKit::WebViewImpl::willEndLiveResize):
* src/WebViewImpl.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (87332 => 87333)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-05-25 23:09:56 UTC (rev 87332)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-05-25 23:30:41 UTC (rev 87333)
@@ -1,3 +1,20 @@
+2011-05-25  Sailesh Agrawal  
+
+Reviewed by Darin Fisher.
+
+Expose willStartLiveResize and willEndLiveResize in WebWidget
+https://bugs.webkit.org/show_bug.cgi?id=60518
+
+* public/WebWidget.h:
+* src/WebPopupMenuImpl.cpp:
+(WebKit::WebPopupMenuImpl::willStartLiveResize):
+(WebKit::WebPopupMenuImpl::willEndLiveResize):
+* src/WebPopupMenuImpl.h:
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::willStartLiveResize):
+(WebKit::WebViewImpl::willEndLiveResize):
+* src/WebViewImpl.h:
+
 2011-05-25  Sheriff Bot  
 
 Unreviewed, rolling out r87257.


Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (87332 => 87333)

--- trunk/Source/WebKit/chromium/public/WebWidget.h	2011-05-25 23:09:56 UTC (rev 87332)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h	2011-05-25 23:30:41 UTC (rev 87333)
@@ -55,9 +55,19 @@
 // Returns the current size of the WebWidget.
 virtual WebSize size() = 0;
 
+// Used to group a series of resize events. For example, if the user
+// drags a resizer then willStartLiveResize will be called, followed by a
+// sequence of resize events, ending with willEndLiveResize when the user
+// lets go of the resizer.
+virtual void willStartLiveResize() = 0;
+
 // Called to resize the WebWidget.
 virtual void resize(const WebSize&) = 0;
 
+// Ends a group of resize events that was started with a call to
+// willStartLiveResize.
+virtual void willEndLiveResize() = 0;
+
 // Called to update imperative animation state.  This should be called before
 // paint, although the client can rate-limit these calls.
 virtual void animate() = 0;


Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp (87332 => 87333)

--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp	2011-05-25 23:09:56 UTC (rev 87332)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp	2011-05-25 23:30:41 UTC (rev 87333)
@@ -136,6 +136,10 @@
 deref();  // Balances ref() from WebWidget::Create
 }
 
+void WebPopupMenuImpl::willStartLiveResize()
+{
+}
+
 void WebPopupMenuImpl::resize(const WebSize& newSize)
 {
 if (m_size == newSize)
@@ -153,6 +157,10 @@
 }
 }
 
+void WebPopupMenuImpl::willEndLiveResize()
+{
+}
+
 void WebPopupMenuImpl::animate()
 {
 }


Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h (87332 => 87333)

--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h	2011-05-25 23:09:56 UTC (rev 87332)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h	2011-05-25 23:30:41 UTC (rev 87333)
@@ -62,7 +62,9 @@
 // WebWidget
 virtual void close();
 virtual WebSize size() { return m_size; }
+virtual void willStartLiveResize();
 virtual void resize(const WebSize&);
+virtual void willEndLiveResize();
 virtual void animate();
 virtual void layout();
 virtual void paint(WebCanvas* canvas, const WebRect& rect);


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (87332 => 87333)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-25 23:09:56 UTC (rev 87332)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-25 23:30:41 UTC (rev 87333)
@@ -972,6 +972,12 @@
 deref();  // Balances ref() acquired in WebView::create
 }
 
+void WebViewImpl::willStartLiveResize()
+{
+if (mainFrameImpl() && mainFrameImpl()->frameView())
+mainFrameImpl()->frameView()->willStartLiveResize();
+}
+
 void WebViewImpl::resize(const WebSize& newSize)
 {
 if (m_size == newSize)
@@ -1002,6 +1008,12 @@
 #endif
 }
 
+void WebViewImpl::willEndLiveResize()
+{
+if (mainFrameImpl() && mainFrameImpl()->frameView())
+ma

[webkit-changes] [87332] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87332] trunk/LayoutTests








Revision 87332
Author ad...@chromium.org
Date 2011-05-25 16:09:56 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Removing test_expectations for non-existent tests.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87331 => 87332)

--- trunk/LayoutTests/ChangeLog	2011-05-25 23:08:28 UTC (rev 87331)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 23:09:56 UTC (rev 87332)
@@ -1,3 +1,9 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Removing test_expectations for non-existent tests.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Jer Noble  
 
 Unreviewed; Update Skipped list for failing tests.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87331 => 87332)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 23:08:28 UTC (rev 87331)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 23:09:56 UTC (rev 87332)
@@ -2426,9 +2426,6 @@
 BUGCR58970 LINUX : svg/text/text-tselect-02-f.svg = IMAGE PASS
 BUGCR58931 WIN LINUX : svg/W3C-SVG-1.1/pservers-grad-17-b.svg = IMAGE PASS
 
-// Failing from around r62021
-BUGCR15797 WIN : fast/dom/object-embed-plugin-scripting.html = TIMEOUT PASS TEXT
-
 // Failing from r69420, mac failing from r71493:r71496
 BUGCR58735 SLOW : http/tests/misc/prefetch-purpose.html = PASS
 
@@ -4134,26 +4131,6 @@
 // New tests added in r87274
 BUGCR83865 : fast/forms/color/input-value-sanitization-color.html = FAIL PASS
 
-// Regression from webkit r87257
-BUGWK61431 DEBUG : storage/indexeddb/create-and-remove-object-store.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/cursor-continue.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/cursor-index-delete.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/cursor-update.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/database-basics.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/duplicates.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/exception-in-event-aborts.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/index-cursor.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/migrate-basics.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/objectstore-basics.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/objectstore-cursor.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/open-cursor.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/request-event-propagation.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/set_version_queue.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/transaction-after-close.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/transaction-basics.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/transaction-event-propagation.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/transaction-rollback.html = CRASH
-
 // New tests added in webkit r87284
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-dx-attr.html = IMAGE
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-dy-attr.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87331] trunk/Source/WebCore

2011-05-25 Thread jer . noble

Title: [87331] trunk/Source/WebCore








Revision 87331
Author jer.no...@apple.com
Date 2011-05-25 16:08:28 -0700 (Wed, 25 May 2011)


Log Message
Ureviewed; Build fix for Leopard and Snow Leopard.

Move _wkQTMovieResolvedURL outside of a #if check for Leopard and SL.

* WebCore.exp.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (87330 => 87331)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 23:05:29 UTC (rev 87330)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 23:08:28 UTC (rev 87331)
@@ -1,3 +1,11 @@
+2011-05-25  Jer Noble  
+
+Ureviewed; Build fix for Leopard and Snow Leopard.
+
+Move _wkQTMovieResolvedURL outside of a #if check for Leopard and SL.
+
+* WebCore.exp.in:
+
 2011-05-25  Michael Saboff  
 
 Reviewed by Sam Weinig.


Modified: trunk/Source/WebCore/WebCore.exp.in (87330 => 87331)

--- trunk/Source/WebCore/WebCore.exp.in	2011-05-25 23:05:29 UTC (rev 87330)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-05-25 23:08:28 UTC (rev 87331)
@@ -1375,6 +1375,7 @@
 _wkQTMovieMaxTimeLoaded
 _wkQTMovieMaxTimeLoadedChangeNotification
 _wkQTMovieMaxTimeSeekable
+_wkQTMovieResolvedURL
 _wkQTMovieSelectPreferredAlternates
 _wkQTMovieSetShowClosedCaptions
 _wkQTMovieViewSetDrawSynchronously
@@ -1458,7 +1459,6 @@
 _wkVerticalScrollbarPainterForController
 _wkWillEndLiveResize
 _wkWillStartLiveResize
-_wkQTMovieResolvedURL
 _wkAVAssetResolvedURL
 #else
 _wkGetNSEventMomentumPhase






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87330] trunk/Source/WebCore

2011-05-25 Thread msaboff

Title: [87330] trunk/Source/WebCore








Revision 87330
Author msab...@apple.com
Date 2011-05-25 16:05:29 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Michael Saboff  

Reviewed by Sam Weinig.

Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
https://bugs.webkit.org/show_bug.cgi?id=61478

Cleanup of further comments after patch was landed.  Changes include
using /2 instead of >>1, adding a blank line after class include,
making method names start with lower case and adding clarifying
comments.

No new tests as the changes are stylistic and not functional.

* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneLiveResourcesToPercentage):
(WebCore::MemoryCache::pruneDeadResourcesToPercentage):
* loader/cache/MemoryCache.h:
(WebCore::MemoryCache::pruneToPercentage):
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/MemoryCache.cpp
trunk/Source/WebCore/loader/cache/MemoryCache.h
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (87329 => 87330)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 23:00:45 UTC (rev 87329)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 23:05:29 UTC (rev 87330)
@@ -1,3 +1,25 @@
+2011-05-25  Michael Saboff  
+
+Reviewed by Sam Weinig.
+
+Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
+https://bugs.webkit.org/show_bug.cgi?id=61478
+
+Cleanup of further comments after patch was landed.  Changes include
+using /2 instead of >>1, adding a blank line after class include,
+making method names start with lower case and adding clarifying
+comments.
+
+No new tests as the changes are stylistic and not functional.
+
+* loader/cache/MemoryCache.cpp:
+(WebCore::MemoryCache::pruneLiveResourcesToPercentage):
+(WebCore::MemoryCache::pruneDeadResourcesToPercentage):
+* loader/cache/MemoryCache.h:
+(WebCore::MemoryCache::pruneToPercentage):
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::respondToMemoryPressure):
+
 2011-05-25  Stephanie Lewis  
 
 Reviewed by Brady Eidson.


Modified: trunk/Source/WebCore/loader/cache/MemoryCache.cpp (87329 => 87330)

--- trunk/Source/WebCore/loader/cache/MemoryCache.cpp	2011-05-25 23:00:45 UTC (rev 87329)
+++ trunk/Source/WebCore/loader/cache/MemoryCache.cpp	2011-05-25 23:05:29 UTC (rev 87330)
@@ -176,7 +176,7 @@
 pruneLiveResourcesToSize(targetSize);
 }
 
-void MemoryCache::PruneLiveResourcesToPercentage(float prunePercentage)
+void MemoryCache::pruneLiveResourcesToPercentage(float prunePercentage)
 {
 if (!m_pruneEnabled)
 return;
@@ -239,7 +239,7 @@
 pruneDeadResourcesToSize(targetSize);
 }
 
-void MemoryCache::PruneDeadResourcesToPercentage(float prunePercentage)
+void MemoryCache::pruneDeadResourcesToPercentage(float prunePercentage)
 {
 if (!m_pruneEnabled)
 return;


Modified: trunk/Source/WebCore/loader/cache/MemoryCache.h (87329 => 87330)

--- trunk/Source/WebCore/loader/cache/MemoryCache.h	2011-05-25 23:00:45 UTC (rev 87329)
+++ trunk/Source/WebCore/loader/cache/MemoryCache.h	2011-05-25 23:05:29 UTC (rev 87330)
@@ -141,8 +141,8 @@
 
 void pruneToPercentage(float targetPercentLive)
 {
-PruneDeadResourcesToPercentage(targetPercentLive); // Prune dead first, in case it was "borrowing" capacity from live.
-PruneLiveResourcesToPercentage(targetPercentLive);
+pruneDeadResourcesToPercentage(targetPercentLive); // Prune dead first, in case it was "borrowing" capacity from live.
+pruneLiveResourcesToPercentage(targetPercentLive);
 }
 
 void setDeadDecodedDataDeletionInterval(double interval) { m_deadDecodedDataDeletionInterval = interval; }
@@ -193,8 +193,8 @@
 // pruneLive*() - Flush decoded data from resources still referenced by Web pages.
 void pruneDeadResources(); // Automatically decide how much to prune.
 void pruneLiveResources();
-void PruneDeadResourcesToPercentage(float prunePercentage);
-void PruneLiveResourcesToPercentage(float prunePercentage);
+void pruneDeadResourcesToPercentage(float prunePercentage); // Prune to % current size
+void pruneLiveResourcesToPercentage(float prunePercentage);
 void pruneDeadResourcesToSize(unsigned targetSize);
 void pruneLiveResourcesToSize(unsigned targetSize);
 


Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (87329 => 87330)

--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2011-05-25 23:00:45 UTC (rev 87329)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2011-05-25 23:05:29 UTC (rev 87330)
@@ -25,6 +2

[webkit-changes] [87329] trunk/Source

2011-05-25 Thread slewis

Title: [87329] trunk/Source








Revision 87329
Author sle...@apple.com
Date 2011-05-25 16:00:45 -0700 (Wed, 25 May 2011)


Log Message
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=61407
part of 
Move Quicklook quirk down into WebCore so it can be caculated when the user
starts a reload.  Restructure the conditions so it only called when absolutely 
necessary.
  
Reviewed by Brady Eidson.

No change in functionality so no new tests.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):

Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=61407
part of 
Remove Quicklook pref.  Moving it enirely down into WebCore so it can
be calculated only on reloads.

Reviewed by Brady Eidson.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/platform/network/cf/ResourceRequest.h
trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (87328 => 87329)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 23:00:45 UTC (rev 87329)
@@ -1,3 +1,25 @@
+2011-05-25  Stephanie Lewis  
+
+Reviewed by Brady Eidson.
+
+https://bugs.webkit.org/show_bug.cgi?id=61407
+part of 
+Move Quicklook quirk down into WebCore so it can be caculated when the user
+starts a reload.  Restructure the conditions so it only called when absolutely 
+necessary.
+  
+No change in functionality so no new tests.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::subresourceCachePolicy):
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+* platform/network/cf/ResourceRequest.h:
+* platform/network/mac/ResourceRequestMac.mm:
+(WebCore::initQuickLookResourceCachingQuirks):
+(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
+
 2011-05-24  Jer Noble  
 
 Reviewed by Darin Adler.


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (87328 => 87329)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2011-05-25 23:00:45 UTC (rev 87329)
@@ -2407,15 +2407,16 @@
 if (parentCachePolicy != CachePolicyVerify)
 return parentCachePolicy;
 }
+
+if (m_loadType == FrameLoadTypeReload)
+return CachePolicyRevalidate;
 
 const ResourceRequest& request(documentLoader()->request());
-Settings* settings = m_frame->settings();
-if (settings && settings->useQuickLookResourceCachingQuirks() && request.cachePolicy() == ReloadIgnoringCacheData && !equalIgnoringCase(request.httpMethod(), "post"))
+#if PLATFORM(MAC)
+if (request.cachePolicy() == ReloadIgnoringCacheData && !equalIgnoringCase(request.httpMethod(), "post") && ResourceRequest::useQuickLookResourceCachingQuirks())
 return CachePolicyRevalidate;
+#endif
 
-if (m_loadType == FrameLoadTypeReload)
-return CachePolicyRevalidate;
-
 if (request.cachePolicy() == ReturnCacheDataElseLoad)
 return CachePolicyHistoryBuffer;
 


Modified: trunk/Source/WebCore/page/Settings.cpp (87328 => 87329)

--- trunk/Source/WebCore/page/Settings.cpp	2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/page/Settings.cpp	2011-05-25 23:00:45 UTC (rev 87329)
@@ -177,7 +177,6 @@
 , m_usePreHTML5ParserQuirks(false)
 , m_hyperlinkAuditingEnabled(false)
 , m_crossOriginCheckInGetMatchedCSSRulesDisabled(false)
-, m_useQuickLookResourceCachingQuirks(false)
 , m_forceCompositingMode(false)
 , m_shouldInjectUserScriptsInInitialEmptyDocument(false)
 , m_allowDisplayOfInsecureContent(true)


Modified: trunk/Source/WebCore/page/Settings.h (87328 => 87329)

--- trunk/Source/WebCore/page/Settings.h	2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/page/Settings.h	2011-05-25 23:00:45 UTC (rev 87329)
@@ -394,9 +394,6 @@
 void setCrossOriginCheckInGetMatchedCSSRulesDisabled(bool flag) { m_crossOriginCheckInGetMatchedCSSRulesDisabled = flag; }
 bool crossOriginCheckInGetMatchedCSSRu

[webkit-changes] [87328] trunk

2011-05-25 Thread jer . noble

Title: [87328] trunk








Revision 87328
Author jer.no...@apple.com
Date 2011-05-25 15:53:23 -0700 (Wed, 25 May 2011)


Log Message
2011-05-24  Jer Noble  

Reviewed by Darin Adler.

Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

No new tests; Covered by media/video-canvas-source.html.

Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected
by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when
creating an AVAsset or QTMovie. Instead, we should just reject local->remote and
remote->local and make our answer to hasSingleSecurityOrigin dynamic.

When checking whether a given request has a single security origin, use a
SecurityOrigin to check the host, port, and scheme.

* WebCore.exp.in:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::assetURL): Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Exchange ForbidCrossSiteReference
for ForbidRemoteReferenceToLocal and ForbidLocalReferenceToRemote
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check to see that the
requested and resolved URLs have the same host and port.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Exchange NoCrossSiteAttribute for
NoRemoteToLocalSiteAttribute and NoLocalToRemoteSiteAttribute.
(WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): Check to see that the
requested and resolved URLs have the same host and port.
* platform/mac/WebCoreSystemInterface.h: Added wkAVAssetResolvedURL.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
2011-05-24  Jer Noble  

Reviewed by Darin Adler.

Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
wkQTMovieResolvedURL.
2011-05-24  Jer Noble  

Reviewed by Darin Adler.

Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
wkQTMovieResolvedURL.
2011-05-25  Jer Noble  

Reviewed by Darin Adler.

Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

Added functions to retrieve the resolved URL for media types supported on
mac.

* WebKitSystemInterface.h:
* WebKitSystemInterface.m:
(WKAVAssetResolvedURL): Added.
(WKQTMovieResolvedURL): Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm
trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h
trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/WebKitSystemInterface.h
trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a
trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a




Diff

Modified: trunk/Source/WebCore/ChangeLog (87327 => 87328)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 22:49:56 UTC (rev 87327)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 22:53:23 UTC (rev 87328)
@@ -1,3 +1,37 @@
+2011-05-24  Jer Noble  
+
+Reviewed by Darin Adler.
+
+Video fails to play on Vimeo
+https://bugs.webkit.org/show_bug.cgi?id=61403
+
+No new tests; Covered by media/video-canvas-source.html.
+
+Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected
+by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when
+creating an AVAsset or QTMovie. Instead, we should just reject local->remote and
+remote->local and make our answer to hasSingleSecurityOrigin dynamic.
+
+When checking whether a given request has a single security origin, use a 
+SecurityOrigin to check the host, port, and scheme.

[webkit-changes] [87327] trunk/Source/JavaScriptCore

2011-05-25 Thread oliver

Title: [87327] trunk/Source/_javascript_Core








Revision 87327
Author oli...@apple.com
Date 2011-05-25 15:49:56 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Oliver Hunt  

Reviewed by Geoffrey Garen.

Generate regexp code lazily
https://bugs.webkit.org/show_bug.cgi?id=61476

RegExp construction now simply validates the RegExp, it does
not perform actual codegen.

* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::recompile):
(JSC::RegExp::compile):
(JSC::RegExp::match):
* runtime/RegExp.h:
(JSC::RegExp::recompileIfNecessary):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::performMatch):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSplit):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h
trunk/Source/_javascript_Core/runtime/RegExpConstructor.h
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87326 => 87327)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-25 22:46:51 UTC (rev 87326)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-25 22:49:56 UTC (rev 87327)
@@ -1,3 +1,30 @@
+2011-05-25  Oliver Hunt  
+
+Reviewed by Geoffrey Garen.
+
+Generate regexp code lazily
+https://bugs.webkit.org/show_bug.cgi?id=61476
+
+RegExp construction now simply validates the RegExp, it does
+not perform actual codegen.
+
+* runtime/RegExp.cpp:
+(JSC::RegExp::RegExp):
+(JSC::RegExp::recompile):
+(JSC::RegExp::compile):
+(JSC::RegExp::match):
+* runtime/RegExp.h:
+(JSC::RegExp::recompileIfNecessary):
+* runtime/RegExpConstructor.h:
+(JSC::RegExpConstructor::performMatch):
+* runtime/RegExpObject.cpp:
+(JSC::RegExpObject::match):
+* runtime/StringPrototype.cpp:
+(JSC::stringProtoFuncReplace):
+(JSC::stringProtoFuncMatch):
+(JSC::stringProtoFuncSearch):
+(JSC::stringProtoFuncSplit):
+
 2011-05-24  Geoffrey Garen  
 
 Reviewed by Geoffrey Garen.


Modified: trunk/Source/_javascript_Core/runtime/RegExp.cpp (87326 => 87327)

--- trunk/Source/_javascript_Core/runtime/RegExp.cpp	2011-05-25 22:46:51 UTC (rev 87326)
+++ trunk/Source/_javascript_Core/runtime/RegExp.cpp	2011-05-25 22:49:56 UTC (rev 87327)
@@ -73,8 +73,9 @@
 OwnPtr m_regExpBytecode;
 };
 
-inline RegExp::RegExp(JSGlobalData* globalData, const UString& patternString, RegExpFlags flags)
-: m_patternString(patternString)
+inline RegExp::RegExp(JSGlobalData*, const UString& patternString, RegExpFlags flags)
+: m_state(NotCompiled)
+, m_patternString(patternString)
 , m_flags(flags)
 , m_constructionError(0)
 , m_numSubpatterns(0)
@@ -82,9 +83,12 @@
 , m_rtMatchCallCount(0)
 , m_rtMatchFoundCount(0)
 #endif
-, m_representation(adoptPtr(new RegExpRepresentation))
 {
-m_state = compile(globalData);
+Yarr::YarrPattern pattern(m_patternString, ignoreCase(), multiline(), &m_constructionError);
+if (m_constructionError)
+m_state = ParseError;
+else
+m_numSubpatterns = pattern.m_numSubpatterns;
 }
 
 RegExp::~RegExp()
@@ -100,37 +104,42 @@
 return res.release();
 }
 
-RegExp::RegExpState RegExp::compile(JSGlobalData* globalData)
+void RegExp::compile(JSGlobalData* globalData)
 {
+ASSERT(m_state == NotCompiled);
+m_representation = adoptPtr(new RegExpRepresentation);
 Yarr::YarrPattern pattern(m_patternString, ignoreCase(), multiline(), &m_constructionError);
-if (m_constructionError)
-return ParseError;
+if (m_constructionError) {
+ASSERT_NOT_REACHED();
+m_state = ParseError;
+return;
+}
 
-m_numSubpatterns = pattern.m_numSubpatterns;
+ASSERT(m_numSubpatterns == pattern.m_numSubpatterns);
 
-RegExpState res = ByteCode;
+m_state = ByteCode;
 
 #if ENABLE(YARR_JIT)
 if (!pattern.m_containsBackreferences && globalData->canUseJIT()) {
 Yarr::jitCompile(pattern, globalData, m_representation->m_regExpJITCode);
 #if ENABLE(YARR_JIT_DEBUG)
 if (!m_representation->m_regExpJITCode.isFallBack())
-res = JITCode;
+m_state = JITCode;
 else
-res = ByteCode;
+m_state = ByteCode;
 #else
-if (!m_representation->m_regExpJITCode.isFallBack())
-return JITCode;
+if (!m_representation->m_regExpJITCode.isFallBack()) {
+m_state = JITCode;
+return;
+}
 #endif
 }
 #endif
 
 m_re

[webkit-changes] [87326] trunk/LayoutTests

2011-05-25 Thread jer . noble

Title: [87326] trunk/LayoutTests








Revision 87326
Author jer.no...@apple.com
Date 2011-05-25 15:46:51 -0700 (Wed, 25 May 2011)


Log Message
Unreviewed; Update Skipped list for failing tests.

A new full-screen test requires  full screen support, which does not
exist on mac-leopard.  Follow-up to r87322.

* platform/mac-leopard/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-leopard/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (87325 => 87326)

--- trunk/LayoutTests/ChangeLog	2011-05-25 22:03:52 UTC (rev 87325)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 22:46:51 UTC (rev 87326)
@@ -1,3 +1,12 @@
+2011-05-25  Jer Noble  
+
+Unreviewed; Update Skipped list for failing tests.
+
+A new full-screen test requires  full screen support, which does not
+exist on mac-leopard.  Follow-up to r87322.
+
+* platform/mac-leopard/Skipped:
+
 2011-05-25  Adam Klein  
 
 Unreviewed. Test expectations update, followup to r87291.


Modified: trunk/LayoutTests/platform/mac-leopard/Skipped (87325 => 87326)

--- trunk/LayoutTests/platform/mac-leopard/Skipped	2011-05-25 22:03:52 UTC (rev 87325)
+++ trunk/LayoutTests/platform/mac-leopard/Skipped	2011-05-25 22:46:51 UTC (rev 87326)
@@ -22,6 +22,7 @@
 # These tests requires fullscreen  support
 media/media-fullscreen-inline.html
 media/media-fullscreen-not-in-document.html
+fullscreen/full-screen-iframe-legacy.html
 
 # Tests of accessibility functionality not supported on Leopard
 accessibility/aria-list-and-listitem.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87325] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87325] trunk/LayoutTests








Revision 87325
Author ad...@chromium.org
Date 2011-05-25 15:03:52 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Test expectations update, followup to r87291.

The aforementioned change cleared out these files, when the intent
seems to have been removal to remove them.

* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed.
* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed.
* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed.
* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt
trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt
trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt
trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87324 => 87325)

--- trunk/LayoutTests/ChangeLog	2011-05-25 21:56:21 UTC (rev 87324)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 22:03:52 UTC (rev 87325)
@@ -1,3 +1,15 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Test expectations update, followup to r87291.
+
+The aforementioned change cleared out these files, when the intent
+seems to have been removal to remove them.
+
+* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed.
+* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed.
+* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed.
+* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed.
+
 2011-05-25  Jon Honeycutt  
 
 REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery


Deleted: trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt ( => )

Deleted: trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt
===


Deleted: trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt ( => )

Deleted: trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt
===






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87324] trunk

2011-05-25 Thread jhoneycutt

Title: [87324] trunk








Revision 87324
Author jhoneyc...@apple.com
Date 2011-05-25 14:56:21 -0700 (Wed, 25 May 2011)


Log Message
REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
https://bugs.webkit.org/show_bug.cgi?id=61428


Reviewed by Adam Roben.

Source/WebKit2:

The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate _javascript_ that removes the plug-in from the page. Flash then
crashes when we return to Flash code.

* Platform/WorkItem.h:
(DerefWorkItem::DerefWorkItem):
Initialize m_ptr.
(DerefWorkItem::execute):
Deref the object.
(WorkItem::createDeref):
Create and return a DerefWorkItem.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::unprotectPluginFromDestruction):
If the PluginView has only one reference left, deref it asynchronously.

Tools:

The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate _javascript_ that removes the plug-in from the page. Flash then
crashes when we return to Flash code.

This test emulates that behavior.

* DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
(CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
Initialize member vars.
(CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
Remove our custom property from the message window, and destroy it.
(CallJSThatDestroysPlugin::NPP_Destroy):
Set m_isDestroyed, log that the plug-in was destroyed, and notify the
layout test controller that we're done.
(wndProc):
Get the PluginTest object, and call its runTest() function.
(CallJSThatDestroysPlugin::NPP_New):
Setup the test: register a class for the message-only window, create
it, and post a message to it to run the test.
(CallJSThatDestroysPlugin::runTest):
Execute JS that removes the plug-in from the page, and if we're not
destroyed, log a success message.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Add new test to project.

LayoutTests:

* platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt: Added.
* platform/win/plugins/call-_javascript_-that-destroys-plugin.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/WorkItem.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj


Added Paths

trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt
trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin.html
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (87323 => 87324)

--- trunk/LayoutTests/ChangeLog	2011-05-25 21:47:39 UTC (rev 87323)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 21:56:21 UTC (rev 87324)
@@ -1,3 +1,14 @@
+2011-05-25  Jon Honeycutt  
+
+REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
+https://bugs.webkit.org/show_bug.cgi?id=61428
+
+
+Reviewed by Adam Roben.
+
+* platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt: Added.
+* platform/win/plugins/call-_javascript_-that-destroys-plugin.html: Added.
+
 2011-05-25  Andrew Scherkus  
 
 Reviewed by Eric Carlson.


Added: trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt (0 => 87324)

--- trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt	2011-05-25 21:56:21 UTC (rev 87324)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 0: PLUGIN: Success: executed script, and plug-in is not yet destroyed.
+CONSOLE MESSAGE: line 0: PLUGIN: Plug-in destroyed.
+This tests that, if a plug-in directs the browser to evaluate _javascript_ that removes the plug-in from the page, the plug-in is destroyed asynchronously.


Added: trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin.html (0 => 87324)

--- trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin.html	(rev 0)
+++ trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin.html	2011-05-25 21:56:21 UTC (rev 87324)
@@ -0,0 +1,15 @@
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+
+
+This tests that, if a plug-in directs the browser to evaluate _javascript_ that removes the plug-in from the page,
+the plug-in is destroyed asynchronously.
+
+
+


Modified: trunk/Source/WebKit2/ChangeLog (87323 => 87324)

--- trunk/Source/WebKit2/ChangeLog	2011-05-25 21:47:39 UTC (rev 87323)
+++ trunk/Source/WebKit2/ChangeLog	2011-05-25 21:56:21 UTC (rev 87324)
@@ -1,3 +1,28 @@
+2011-05-

[webkit-changes] [87323] trunk

2011-05-25 Thread scherkus

Title: [87323] trunk








Revision 87323
Author scher...@chromium.org
Date 2011-05-25 14:47:39 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Andrew Scherkus  

Reviewed by Eric Carlson.

Fix media element regression where ended event stopped firing after changing the src attribute.

https://bugs.webkit.org/show_bug.cgi?id=61336

* media/media-ended-expected.txt: Added.
* media/media-ended.html: Added.
2011-05-25  Andrew Scherkus  

Reviewed by Eric Carlson.

Fix media element regression where ended event stopped firing after changing the src attribute.

https://bugs.webkit.org/show_bug.cgi?id=61336

Test: media/media-ended.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp


Added Paths

trunk/LayoutTests/media/media-ended-expected.txt
trunk/LayoutTests/media/media-ended.html




Diff

Modified: trunk/LayoutTests/ChangeLog (87322 => 87323)

--- trunk/LayoutTests/ChangeLog	2011-05-25 21:38:31 UTC (rev 87322)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 21:47:39 UTC (rev 87323)
@@ -1,3 +1,14 @@
+2011-05-25  Andrew Scherkus  
+
+Reviewed by Eric Carlson.
+
+Fix media element regression where ended event stopped firing after changing the src attribute.
+
+https://bugs.webkit.org/show_bug.cgi?id=61336
+
+* media/media-ended-expected.txt: Added.
+* media/media-ended.html: Added.
+
 2011-05-25  Jer Noble  
 
 Reviewed by Darin Adler.


Added: trunk/LayoutTests/media/media-ended-expected.txt (0 => 87323)

--- trunk/LayoutTests/media/media-ended-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-ended-expected.txt	2011-05-25 21:47:39 UTC (rev 87323)
@@ -0,0 +1,13 @@
+Test ended by:
+
+Play to the end.
+When 'ended' event fires, change the source.
+Verify that 'ended' event fires again on different source.
+EVENT(ended)
+EXPECTED (audio.ended == 'true') OK
+EXPECTED (audio.ended == 'false') OK
+
+EVENT(ended)
+EXPECTED (audio.ended == 'true') OK
+END OF TEST
+


Added: trunk/LayoutTests/media/media-ended.html (0 => 87323)

--- trunk/LayoutTests/media/media-ended.html	(rev 0)
+++ trunk/LayoutTests/media/media-ended.html	2011-05-25 21:47:39 UTC (rev 87323)
@@ -0,0 +1,51 @@
+
+
+
+
+var endedCount = 0;
+var canplaythroughCount = 0;
+var audio;
+
+function start()
+{
+audio = document.querySelector("audio");
+waitForEvent("ended", ended);
+
+audio.src = "" "content/silence")
+}
+
+function ended()
+{
+switch (++endedCount)
+{
+case 1:
+testExpected("audio.ended", true);
+
+// Change src but don't seek so that internal state isn't reset.
+audio.src = "" "content/silence")
+testExpected("audio.ended", false);
+
+consoleWrite("");
+break;
+case 2:
+testExpected("audio.ended", true);
+endTest();
+break;
+}
+}
+
+
+
+
+Test ended by:
+
+Play to the end.
+When 'ended' event fires, change the source.
+Verify that 'ended' event fires again on different source.
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (87322 => 87323)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 21:38:31 UTC (rev 87322)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 21:47:39 UTC (rev 87323)
@@ -1,3 +1,16 @@
+2011-05-25  Andrew Scherkus  
+
+Reviewed by Eric Carlson.
+
+Fix media element regression where ended event stopped firing after changing the src attribute.
+
+https://bugs.webkit.org/show_bug.cgi?id=61336
+
+Test: media/media-ended.html
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::prepareForLoad):
+
 2011-05-25  Jer Noble  
 
 Reviewed by Darin Adler.


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (87322 => 87323)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2011-05-25 21:38:31 UTC (rev 87322)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2011-05-25 21:47:39 UTC (rev 87323)
@@ -515,6 +515,7 @@
 // Perform the cleanup required for the resource load algorithm to run.
 stopPeriodicTimers();
 m_loadTimer.stop();
+m_sentEndEvent = false;
 m_sentStalledEvent = false;
 m_haveFiredLoadedData = false;
 m_completelyLoaded = false;






___
webkit-changes mailing list
webkit-changes@lists.webki

[webkit-changes] [87322] trunk

2011-05-25 Thread jer . noble

Title: [87322] trunk








Revision 87322
Author jer.no...@apple.com
Date 2011-05-25 14:38:31 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Jer Noble  

Reviewed by Darin Adler.

REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
https://bugs.webkit.org/show_bug.cgi?id=61461

* fullscreen/full-screen-iframe-legacy-expected.txt: Added.
* fullscreen/full-screen-iframe-legacy.html: Added.
* fullscreen/resources/legacy.html: Added.
2011-05-25  Jer Noble  

Reviewed by Darin Adler.

REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
https://bugs.webkit.org/show_bug.cgi?id=61461

Tests: fullscreen/full-screen-iframe-legacy.html

Allow calls from the legacy full-screen API to bypass the iframe
"webkitallowfullscreen" requirement by adding a parameter to
Document::webkitRequestFullScreenForElement specifying the strictness
of that check.  Specify this new parameter everywhere that function is
called, including in the default controls' full-screen button handler.

* dom/Document.cpp:
(WebCore::Document::webkitRequestFullScreenForElement):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::requestFullScreen): Renamed from webkitRequestFullScreen.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/shadow/MediaControlElements.cpp


Added Paths

trunk/LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt
trunk/LayoutTests/fullscreen/full-screen-iframe-legacy.html
trunk/LayoutTests/fullscreen/resources/legacy.html




Diff

Modified: trunk/LayoutTests/ChangeLog (87321 => 87322)

--- trunk/LayoutTests/ChangeLog	2011-05-25 21:33:15 UTC (rev 87321)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 21:38:31 UTC (rev 87322)
@@ -1,3 +1,14 @@
+2011-05-25  Jer Noble  
+
+Reviewed by Darin Adler.
+
+REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
+https://bugs.webkit.org/show_bug.cgi?id=61461
+
+* fullscreen/full-screen-iframe-legacy-expected.txt: Added.
+* fullscreen/full-screen-iframe-legacy.html: Added.
+* fullscreen/resources/legacy.html: Added.
+
 2011-05-25  Caio Marcelo de Oliveira Filho  
 
 Reviewed by Andreas Kling.


Added: trunk/LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt (0 => 87322)

--- trunk/LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt	(rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt	2011-05-25 21:38:31 UTC (rev 87322)
@@ -0,0 +1,8 @@
+Test for bug 61461: Handle entering full screen security restrictions
+
+To test manually, click the video "full screen" button - the page should enter full screen mode.
+
+EVENT(webkitfullscreenchange)
+TEST(document.getElementById('frame').contentDocument.width==document.width) OK
+END OF TEST
+


Added: trunk/LayoutTests/fullscreen/full-screen-iframe-legacy.html (0 => 87322)

--- trunk/LayoutTests/fullscreen/full-screen-iframe-legacy.html	(rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-legacy.html	2011-05-25 21:38:31 UTC (rev 87322)
@@ -0,0 +1,27 @@
+Test for : 
+Handle entering full screen security restrictions
+To test manually, click the video "full screen" button - the page should enter full screen mode.
+
+function runTest() {
+var frame = document.getElementById('frame');
+
+waitForEvent(frame.contentDocument, 'webkitfullscreenchange', function() { 
+test("document.getElementById('frame').contentDocument.width==document.width")
+endTest();
+});
+
+runWithKeyDown(function() {
+
+setTimeout(function() { 
+consoleWrite("FAIL - did not enter full screen!"); 
+endTest(); 
+}, 50);
+
+var video = frame.contentDocument.getElementsByTagName('video')[0];
+video.webkitEnterFullScreen();
+});
+}
+
+
+


Added: trunk/LayoutTests/fullscreen/resources/legacy.html (0 => 87322)

--- trunk/LayoutTests/fullscreen/resources/legacy.html	(rev 0)
+++ trunk/LayoutTests/fullscreen/resources/legacy.html	2011-05-25 21:38:31 UTC (rev 87322)
@@ -0,0 +1,7 @@
+
+
+video = mediaElement = document.getElementsByTagName('video')[0];
+var mediaFile = findMediaFile("video", "../../media/content/test");
+video.src = ""
+


Modified: trunk/Source/WebCore/ChangeLog (87321 => 87322)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 21:33:15 UTC (rev 87321)
+++ tru

[webkit-changes] [87321] trunk/Tools

2011-05-25 Thread tony

Title: [87321] trunk/Tools








Revision 87321
Author t...@chromium.org
Date 2011-05-25 14:33:15 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Tony Chang  

Reviewed by Adam Barth.

webkitpy's NetworkTransaction shouldn't use mechanize
https://bugs.webkit.org/show_bug.cgi?id=61450

mechanize.HTTPError is just an alias for urllib2.HTTPError, so
use urllib2 directly.  Re-add NetworkTransaction to
test_results_uploader.py (reverting r87124).

* Scripts/webkitpy/common/net/networktransaction.py:
* Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/networktransaction.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py




Diff

Modified: trunk/Tools/ChangeLog (87320 => 87321)

--- trunk/Tools/ChangeLog	2011-05-25 21:31:37 UTC (rev 87320)
+++ trunk/Tools/ChangeLog	2011-05-25 21:33:15 UTC (rev 87321)
@@ -1,3 +1,17 @@
+2011-05-25  Tony Chang  
+
+Reviewed by Adam Barth.
+
+webkitpy's NetworkTransaction shouldn't use mechanize
+https://bugs.webkit.org/show_bug.cgi?id=61450
+
+mechanize.HTTPError is just an alias for urllib2.HTTPError, so
+use urllib2 directly.  Re-add NetworkTransaction to
+test_results_uploader.py (reverting r87124).
+
+* Scripts/webkitpy/common/net/networktransaction.py:
+* Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
+
 2011-05-25  Kevin Ollivier  
 
 [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA


Modified: trunk/Tools/Scripts/webkitpy/common/net/networktransaction.py (87320 => 87321)

--- trunk/Tools/Scripts/webkitpy/common/net/networktransaction.py	2011-05-25 21:31:37 UTC (rev 87320)
+++ trunk/Tools/Scripts/webkitpy/common/net/networktransaction.py	2011-05-25 21:33:15 UTC (rev 87321)
@@ -28,6 +28,7 @@
 
 import logging
 import time
+import urllib2
 
 from webkitpy.common.system.deprecated_logging import log
 
@@ -49,12 +50,10 @@
 def run(self, request):
 self._total_sleep = 0
 self._backoff_seconds = self._initial_backoff_seconds
-from webkitpy.thirdparty.autoinstalled import mechanize
 while True:
 try:
 return request()
-# FIXME: We should catch urllib2.HTTPError here too.
-except mechanize.HTTPError, e:
+except urllib2.HTTPError, e:
 if self._convert_404_to_None and e.code == 404:
 return None
 self._check_for_timeout()


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py (87320 => 87321)

--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py	2011-05-25 21:31:37 UTC (rev 87320)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py	2011-05-25 21:33:15 UTC (rev 87321)
@@ -34,6 +34,8 @@
 import socket
 import urllib2
 
+from webkitpy.common.net.networktransaction import NetworkTransaction
+
 def get_mime_type(filename):
 return mimetypes.guess_type(filename)[0] or 'application/octet-stream'
 
@@ -99,6 +101,7 @@
 orig_timeout = socket.getdefaulttimeout()
 try:
 socket.setdefaulttimeout(timeout_seconds)
-self._upload_files(params, file_objs)
+NetworkTransaction(timeout_seconds=timeout_seconds).run(
+lambda: self._upload_files(params, file_objs))
 finally:
 socket.setdefaulttimeout(orig_timeout)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87320] trunk/LayoutTests

2011-05-25 Thread caio . oliveira

Title: [87320] trunk/LayoutTests








Revision 87320
Author caio.olive...@openbossa.org
Date 2011-05-25 14:31:37 -0700 (Wed, 25 May 2011)


Log Message
[Qt] Missing update for expected results in LayoutTests after r87315
https://bugs.webkit.org/show_bug.cgi?id=61467

Reviewed by Andreas Kling.

We now expose __qt_sender__ as a non-enumarated property in the
global object. Fix our expectations in relevant tests.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87319 => 87320)

--- trunk/LayoutTests/ChangeLog	2011-05-25 21:29:32 UTC (rev 87319)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 21:31:37 UTC (rev 87320)
@@ -1,3 +1,16 @@
+2011-05-25  Caio Marcelo de Oliveira Filho  
+
+Reviewed by Andreas Kling.
+
+[Qt] Missing update for expected results in LayoutTests after r87315
+https://bugs.webkit.org/show_bug.cgi?id=61467
+
+We now expose __qt_sender__ as a non-enumarated property in the
+global object. Fix our expectations in relevant tests.
+
+* platform/qt/fast/dom/Window/window-properties-expected.txt:
+* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
+
 2011-05-25  Kulanthaivel Palanichamy  
 
 Reviewed by David Hyatt.


Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (87319 => 87320)

--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt	2011-05-25 21:29:32 UTC (rev 87319)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt	2011-05-25 21:31:37 UTC (rev 87320)
@@ -2146,6 +2146,7 @@
 window.XSLTProcessor.prototype.setParameter [function]
 window.XSLTProcessor.prototype.transformToDocument [function]
 window.XSLTProcessor.prototype.transformToFragment [function]
+window.__qt_sender__ [undefined]
 window.addEventListener [function]
 window.alert [function]
 window.applicationCache [object DOMApplicationCache]


Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (87319 => 87320)

--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt	2011-05-25 21:29:32 UTC (rev 87319)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt	2011-05-25 21:31:37 UTC (rev 87320)
@@ -333,6 +333,7 @@
 PASS typeof Object.getOwnPropertyDescriptor(window, 'XPathException') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'XPathResult') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'XSLTProcessor') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, '__qt_sender__') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'applicationCache') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'areArraysEqual') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'clientInformation') is 'object'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87319] trunk

2011-05-25 Thread commit-queue

Title: [87319] trunk








Revision 87319
Author commit-qu...@webkit.org
Date 2011-05-25 14:29:32 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Kulanthaivel Palanichamy  

Reviewed by David Hyatt.

Selector matching doesn't update when DOM changes ("[data-a=x] #x")
https://bugs.webkit.org/show_bug.cgi?id=60752

Added test cases for all the attribute selector types (CSS2.1 & CSS3).

* fast/css/attribute-selector-begin-dynamic-no-elementstyle-expected.txt: Added.
* fast/css/attribute-selector-begin-dynamic-no-elementstyle.html: Added.
* fast/css/attribute-selector-contain-dynamic-no-elementstyle-expected.txt: Added.
* fast/css/attribute-selector-contain-dynamic-no-elementstyle.html: Added.
* fast/css/attribute-selector-end-dynamic-no-elementstyle-expected.txt: Added.
* fast/css/attribute-selector-end-dynamic-no-elementstyle.html: Added.
* fast/css/attribute-selector-exact-dynamic-no-elementstyle-expected.txt: Added.
* fast/css/attribute-selector-exact-dynamic-no-elementstyle.html: Added.
* fast/css/attribute-selector-hyphen-dynamic-no-elementstyle-expected.txt: Added.
* fast/css/attribute-selector-hyphen-dynamic-no-elementstyle.html: Added.
* fast/css/attribute-selector-list-dynamic-no-elementstyle-expected.txt: Added.
* fast/css/attribute-selector-list-dynamic-no-elementstyle.html: Added.
* fast/css/attribute-selector-set-dynamic-no-elementstyle-expected.txt: Added.
* fast/css/attribute-selector-set-dynamic-no-elementstyle.html: Added.
2011-05-25  Kulanthaivel Palanichamy  

Reviewed by David Hyatt.

Selector matching doesn't update when DOM changes ("[data-a=x] #x")
https://bugs.webkit.org/show_bug.cgi?id=60752

Currently CSSStyleSelector maintains a HashSet of attributes (m_selectorAttrs)
which are used in CSS attribute selectors to determine the need for style
recalculation whenever element attributes are manipulated in DOM.
In certain conditions (element with no style, element is styled and attribute
is not a mapped attribute, attribute is of type 'type' or read-only)
even when attribute selector matches for an element, the attribute is not
added to m_selectorAttrs. This results in missing style recalculations
when a DOM element attribute is changed and is not found in m_selectorAttrs.

Removing the above said conditions in
CSSStyleSelector::SelectorChecker::checkOneSelector() for registering
attributes in m_selectorAttrs will solve this issue. But this particular
function is called numerous times which triggers adding duplicate attributes
again and again.

This patch follows the approach taken for collecting ids in selectors, where
all the attributes in selectors are added to a HashSet at the time of adding
style rules to CSSStyleSelector from StyleSheets and when
CSSStyleSelector::hasSelectorForAttribute() is called, the attribute is
simply looked up in this pre-populated hash set.

Test: fast/css/attribute-selector-dynamic-no-elementstyle.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::collectFeaturesFromSelector):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::hasSelectorForAttribute):
* css/CSSStyleSelector.h:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h


Added Paths

trunk/LayoutTests/fast/css/attribute-selector-begin-dynamic-no-elementstyle-expected.txt
trunk/LayoutTests/fast/css/attribute-selector-begin-dynamic-no-elementstyle.html
trunk/LayoutTests/fast/css/attribute-selector-contain-dynamic-no-elementstyle-expected.txt
trunk/LayoutTests/fast/css/attribute-selector-contain-dynamic-no-elementstyle.html
trunk/LayoutTests/fast/css/attribute-selector-end-dynamic-no-elementstyle-expected.txt
trunk/LayoutTests/fast/css/attribute-selector-end-dynamic-no-elementstyle.html
trunk/LayoutTests/fast/css/attribute-selector-exact-dynamic-no-elementstyle-expected.txt
trunk/LayoutTests/fast/css/attribute-selector-exact-dynamic-no-elementstyle.html
trunk/LayoutTests/fast/css/attribute-selector-hyphen-dynamic-no-elementstyle-expected.txt
trunk/LayoutTests/fast/css/attribute-selector-hyphen-dynamic-no-elementstyle.html
trunk/LayoutTests/fast/css/attribute-selector-list-dynamic-no-elementstyle-expected.txt
trunk/LayoutTests/fast/css/attribute-selector-list-dynamic-no-elementstyle.html
trunk/LayoutTests/fast/css/attribute-selector-set-dynamic-no-elementstyle-expected.txt
trunk/LayoutTests/fast/css/attribute-selector-set-dynami

[webkit-changes] [87318] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87318] trunk/LayoutTests








Revision 87318
Author ad...@chromium.org
Date 2011-05-25 14:23:05 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Update chromium expectations after r87307.

* platform/chromium/test_expectations.txt: suppress, WK61470.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87317 => 87318)

--- trunk/LayoutTests/ChangeLog	2011-05-25 20:32:37 UTC (rev 87317)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 21:23:05 UTC (rev 87318)
@@ -1,3 +1,9 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Update chromium expectations after r87307.
+
+* platform/chromium/test_expectations.txt: suppress, WK61470.
+
 2011-05-25  Sheriff Bot  
 
 Unreviewed, rolling out r87257.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87317 => 87318)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 20:32:37 UTC (rev 87317)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 21:23:05 UTC (rev 87318)
@@ -1022,8 +1022,9 @@
 // Skia/GPU Anti-aliasing
 BUGCR78458 WIN LINUX GPU : fast/canvas/arc360.html = IMAGE
 BUGCR78458 WIN LINUX GPU : fast/canvas/quadraticCurveTo.xml = IMAGE
-BUGCR78458 WIN LINUX GPU : fast/canvas/canvas-composite.html = IMAGE
 
+BUGWK61470 : fast/canvas/canvas-composite.html = IMAGE
+
 // -
 // Other failures
 // -






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87317] trunk/Source/WebCore

2011-05-25 Thread rniwa

Title: [87317] trunk/Source/WebCore








Revision 87317
Author rn...@webkit.org
Date 2011-05-25 13:32:37 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Ryosuke Niwa  

Reviewed by James Robinson.

CSSStyleSelector should provide a way to obtain rules from non-author stylesheets
https://bugs.webkit.org/show_bug.cgi?id=61454

Replaced bool and enum arguments of styleRulesForElement and pseudoStyleRulesForElement
by one enum, and provided a way to obtain rules from UA/user stylesheets.

* css/CSSRule.h: Removed CSSRuleFilter.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleRulesForElement): See above.
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
* css/CSSStyleSelector.h: Moved CSSRuleFilter here.
* editing/markup.cpp:
(WebCore::styleFromMatchedRulesForElement): Calls styleRulesForElement.
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode): Ditto.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSRule.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
trunk/Source/WebCore/page/DOMWindow.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87316 => 87317)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 19:37:18 UTC (rev 87316)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 20:32:37 UTC (rev 87317)
@@ -1,3 +1,25 @@
+2011-05-25  Ryosuke Niwa  
+
+Reviewed by James Robinson.
+
+CSSStyleSelector should provide a way to obtain rules from non-author stylesheets
+https://bugs.webkit.org/show_bug.cgi?id=61454
+
+Replaced bool and enum arguments of styleRulesForElement and pseudoStyleRulesForElement
+by one enum, and provided a way to obtain rules from UA/user stylesheets.
+
+* css/CSSRule.h: Removed CSSRuleFilter.
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::styleRulesForElement): See above.
+(WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
+* css/CSSStyleSelector.h: Moved CSSRuleFilter here.
+* editing/markup.cpp:
+(WebCore::styleFromMatchedRulesForElement): Calls styleRulesForElement.
+* inspector/InspectorCSSAgent.cpp:
+(WebCore::InspectorCSSAgent::getStylesForNode): Ditto.
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::getMatchedCSSRules): Ditto.
+
 2011-05-25  Caio Marcelo de Oliveira Filho  
 
 Reviewed by Andreas Kling.


Modified: trunk/Source/WebCore/css/CSSRule.h (87316 => 87317)

--- trunk/Source/WebCore/css/CSSRule.h	2011-05-25 19:37:18 UTC (rev 87316)
+++ trunk/Source/WebCore/css/CSSRule.h	2011-05-25 20:32:37 UTC (rev 87317)
@@ -30,11 +30,6 @@
 
 typedef int ExceptionCode;
 
-enum CSSRuleFilter {
-AllCSSRules,
-SameOriginCSSRulesOnly
-}; 
-
 class CSSRule : public StyleBase {
 public:
 // FIXME: Change name to Type.


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (87316 => 87317)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-05-25 19:37:18 UTC (rev 87316)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-05-25 20:32:37 UTC (rev 87317)
@@ -1991,12 +1991,12 @@
 }
 }
 
-PassRefPtr CSSStyleSelector::styleRulesForElement(Element* e, bool authorOnly, bool includeEmptyRules, CSSRuleFilter filter)
+PassRefPtr CSSStyleSelector::styleRulesForElement(Element* e, unsigned rulesToInclude)
 {
-return pseudoStyleRulesForElement(e, NOPSEUDO, authorOnly, includeEmptyRules, filter);
+return pseudoStyleRulesForElement(e, NOPSEUDO, rulesToInclude);
 }
 
-PassRefPtr CSSStyleSelector::pseudoStyleRulesForElement(Element* e, PseudoId pseudoId, bool authorOnly, bool includeEmptyRules, CSSRuleFilter filter)
+PassRefPtr CSSStyleSelector::pseudoStyleRulesForElement(Element* e, PseudoId pseudoId, unsigned rulesToInclude)
 {
 if (!e || !e->document()->haveStylesheetsLoaded())
 return 0;
@@ -2006,7 +2006,7 @@
 initElement(e);
 initForStyleResolve(e, 0, pseudoId);
 
-if (!authorOnly) {
+if (rulesToInclude & UAAndUserCSSRules) {
 int firstUARule = -1, lastUARule = -1;
 // First we match rules from the user agent sheet.
 matchUARules(firstUARule, lastUARule);
@@ -2014,16 +2014,16 @@
 // Now we check user sheet rules.
 if (m_matchAuthorAndUserStyles) {
 int firstUserRule = -1, lastUserRule = -1;
-matchRules(m_userStyle.get(), firstUserRule, lastUserRule, includeEmptyRules);
+matchRules(m_userStyle.get(), firstUserRule, lastUserRule, rulesToInclude & EmptyCSSRules);
 }
 }
 
 if (m_matchAuthorAndUserStyles) {
-m_checker.m_sameOriginOnly = (filter == SameOriginCSSRulesOnly);
+m_che

[webkit-changes] [87316] trunk/Source/JavaScriptCore

2011-05-25 Thread ggaren

Title: [87316] trunk/Source/_javascript_Core








Revision 87316
Author gga...@apple.com
Date 2011-05-25 12:37:18 -0700 (Wed, 25 May 2011)


Log Message
2011-05-24  Geoffrey Garen  

Reviewed by Geoffrey Garen.

Removed MarkSetProperties because it was unused
https://bugs.webkit.org/show_bug.cgi?id=61418

* heap/MarkStack.h:
(JSC::MarkSet::MarkSet):
(JSC::MarkStack::append):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSArray.h:
(JSC::JSArray::visitChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/WriteBarrier.h:
(JSC::MarkStack::appendValues):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MarkStack.h
trunk/Source/_javascript_Core/runtime/JSActivation.cpp
trunk/Source/_javascript_Core/runtime/JSArray.h
trunk/Source/_javascript_Core/runtime/JSPropertyNameIterator.cpp
trunk/Source/_javascript_Core/runtime/WriteBarrier.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87315 => 87316)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-25 19:28:22 UTC (rev 87315)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-25 19:37:18 UTC (rev 87316)
@@ -1,3 +1,22 @@
+2011-05-24  Geoffrey Garen  
+
+Reviewed by Geoffrey Garen.
+
+Removed MarkSetProperties because it was unused
+https://bugs.webkit.org/show_bug.cgi?id=61418
+
+* heap/MarkStack.h:
+(JSC::MarkSet::MarkSet):
+(JSC::MarkStack::append):
+* runtime/JSActivation.cpp:
+(JSC::JSActivation::visitChildren):
+* runtime/JSArray.h:
+(JSC::JSArray::visitChildrenDirect):
+* runtime/JSPropertyNameIterator.cpp:
+(JSC::JSPropertyNameIterator::visitChildren):
+* runtime/WriteBarrier.h:
+(JSC::MarkStack::appendValues):
+
 2011-05-25  Oliver Hunt  
 
 Reviewed by Geoffrey Garen.


Modified: trunk/Source/_javascript_Core/heap/MarkStack.h (87315 => 87316)

--- trunk/Source/_javascript_Core/heap/MarkStack.h	2011-05-25 19:28:22 UTC (rev 87315)
+++ trunk/Source/_javascript_Core/heap/MarkStack.h	2011-05-25 19:37:18 UTC (rev 87316)
@@ -43,14 +43,11 @@
 class Register;
 template class WriteBarrierBase;
 
-enum MarkSetProperties { MayContainNullValues, NoNullValues };
-
 struct MarkSet {
-MarkSet(JSValue* values, JSValue* end, MarkSetProperties);
+MarkSet(JSValue* values, JSValue* end);
 
 JSValue* m_values;
 JSValue* m_end;
-MarkSetProperties m_properties;
 };
 
 template class MarkStackArray {
@@ -90,7 +87,7 @@
 void append(ConservativeRoots&);
 
 template inline void append(WriteBarrierBase*);
-inline void appendValues(WriteBarrierBase*, size_t count, MarkSetProperties = NoNullValues);
+inline void appendValues(WriteBarrierBase*, size_t count);
 
 bool addOpaqueRoot(void*);
 bool containsOpaqueRoot(void*);
@@ -155,10 +152,9 @@
 return m_opaqueRoots.size();
 }
 
-inline MarkSet::MarkSet(JSValue* values, JSValue* end, MarkSetProperties properties)
+inline MarkSet::MarkSet(JSValue* values, JSValue* end)
 : m_values(values)
 , m_end(end)
-, m_properties(properties)
 {
 ASSERT(values);
 }
@@ -251,7 +247,7 @@
 #if ENABLE(GC_VALIDATION)
 validateSet(slot, count);
 #endif
-m_markSets.append(MarkSet(slot, slot + count, NoNullValues));
+m_markSets.append(MarkSet(slot, slot + count));
 }
 
 ALWAYS_INLINE void MarkStack::append(JSValue* value)


Modified: trunk/Source/_javascript_Core/runtime/JSActivation.cpp (87315 => 87316)

--- trunk/Source/_javascript_Core/runtime/JSActivation.cpp	2011-05-25 19:28:22 UTC (rev 87315)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.cpp	2011-05-25 19:37:18 UTC (rev 87316)
@@ -73,7 +73,7 @@
 visitor.appendValues(registerArray, m_numParametersMinusThis);
 
 // Skip the call frame, which sits between the parameters and vars.
-visitor.appendValues(registerArray + m_numParametersMinusThis + RegisterFile::CallFrameHeaderSize, m_numCapturedVars, MayContainNullValues);
+visitor.appendValues(registerArray + m_numParametersMinusThis + RegisterFile::CallFrameHeaderSize, m_numCapturedVars);
 }
 
 inline bool JSActivation::symbolTableGet(const Identifier& propertyName, PropertySlot& slot)


Modified: trunk/Source/_javascript_Core/runtime/JSArray.h (87315 => 87316)

--- trunk/Source/_javascript_Core/runtime/JSArray.h	2011-05-25 19:28:22 UTC (rev 87315)
+++ trunk/Source/_javascript_Core/runtime/JSArray.h	2011-05-25 19:37:18 UTC (rev 87316)
@@ -192,7 +192,7 @@
 ArrayStorage* storage = m_storage;
 
 unsigned usedVectorLength = std::min(storage->m_length, m_vectorLength);
-visitor.appendValues(storage->m_vec

[webkit-changes] [87315] trunk/Source

2011-05-25 Thread caio . oliveira

Title: [87315] trunk/Source








Revision 87315
Author caio.olive...@openbossa.org
Date 2011-05-25 12:28:22 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Caio Marcelo de Oliveira Filho  

Reviewed by Andreas Kling.

[Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
https://bugs.webkit.org/show_bug.cgi?id=61343

Create a stack to keep track of the sender objects. This is simpler than
the similar mechanism in QObject (C++ API), that keeps a stack per-object.

Since we do not support multiple threads, one static stack will be enough for
handling the behavior.

This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::qtSenderStack):
We have one static stack of QObject*. The top of the stack contains the
last object that emitted signal that called a _javascript_ function.

* bridge/qt/qt_instance.h:
(JSC::Bindings::QtInstance::QtSenderStack::top):
(JSC::Bindings::QtInstance::QtSenderStack::push):
(JSC::Bindings::QtInstance::QtSenderStack::pop):
Minimal functionality to manipulate the sender stack.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):
Remove the previous code that modified the scope chain. Push the sender object
to the stack before calling the _javascript_ function (the "slot" in Qt-speak) and
pop it afterwards.
2011-05-25  Caio Marcelo de Oliveira Filho  

Reviewed by Andreas Kling.

[Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
https://bugs.webkit.org/show_bug.cgi?id=61343

Create a '__qt_sender__' property in the global object, that returns the top of
the qtSenderStack. This is an alternative implementation for the feature of
providing a way for a function (acting as a Qt 'slot') discover which object
emitted the signal that caused it to be executed.

This reduces the coupling of the Qt bridge and JSC internal implementation. The
patch tries to use as much JSC public API as possible.

This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
Instead of emitting the QWebPage::_javascript_WindowObjectCleared() directly, calls
a QWebPagePrivate function to do it.

* Api/qwebframe_p.h:
* Api/qwebframe.cpp:
(QWebFramePrivate::didClearedWindowObject):
Before emitting the signal mentioned, adds the '__qt_sender__' to the fresh
global object.

(qtSenderCallback):
Returns the JSObjectRef corresponding to the top of qtSenderStack.

(QWebFramePrivate::addQtSenderToGlobalObject):
Create a property with a qtSenderCallback as getter function in the global object.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/qt/qt_instance.cpp
trunk/Source/WebCore/bridge/qt/qt_instance.h
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp
trunk/Source/WebKit/qt/Api/qwebframe.cpp
trunk/Source/WebKit/qt/Api/qwebframe_p.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87314 => 87315)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 19:25:50 UTC (rev 87314)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 19:28:22 UTC (rev 87315)
@@ -1,3 +1,35 @@
+2011-05-25  Caio Marcelo de Oliveira Filho  
+
+Reviewed by Andreas Kling.
+
+[Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
+https://bugs.webkit.org/show_bug.cgi?id=61343
+
+Create a stack to keep track of the sender objects. This is simpler than
+the similar mechanism in QObject (C++ API), that keeps a stack per-object.
+
+Since we do not support multiple threads, one static stack will be enough for
+handling the behavior.
+
+This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.
+
+* bridge/qt/qt_instance.cpp:
+(JSC::Bindings::QtInstance::qtSenderStack):
+We have one static stack of QObject*. The top of the stack contains the
+last object that emitted signal that called a _javascript_ function.
+
+* bridge/qt/qt_instance.h:
+(JSC::Bindings::QtInstance::QtSenderStack::top):
+(JSC::Bindings::QtInstance::QtSenderStack::push):
+(JSC::Bindings::QtInstance::QtSenderStack::pop):
+Minimal functionality to manipulate the sender stack.
+
+* bridge/qt/qt_runtime.cpp:
+(JSC::Bindings::QtConnectionObject::execute):
+Remove the previous code that modified the scope chain. Push the sender object
+to the stack before calling the _javascri

[webkit-changes] [87314] trunk/Tools

2011-05-25 Thread kevino

Title: [87314] trunk/Tools








Revision 87314
Author kev...@webkit.org
Date 2011-05-25 12:25:50 -0700 (Wed, 25 May 2011)


Log Message
[Chromium] Unreviewed build fix, do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
until the port begins using those export macros.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/config.h




Diff

Modified: trunk/Tools/ChangeLog (87313 => 87314)

--- trunk/Tools/ChangeLog	2011-05-25 19:23:39 UTC (rev 87313)
+++ trunk/Tools/ChangeLog	2011-05-25 19:25:50 UTC (rev 87314)
@@ -1,3 +1,10 @@
+2011-05-25  Kevin Ollivier  
+
+[Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
+until the port begins using those export macros.
+
+* DumpRenderTree/chromium/config.h:
+
 2011-05-25  Sheriff Bot  
 
 Unreviewed, rolling out r87257.


Modified: trunk/Tools/DumpRenderTree/chromium/config.h (87313 => 87314)

--- trunk/Tools/DumpRenderTree/chromium/config.h	2011-05-25 19:23:39 UTC (rev 87313)
+++ trunk/Tools/DumpRenderTree/chromium/config.h	2011-05-25 19:25:50 UTC (rev 87314)
@@ -53,7 +53,7 @@
 #define JS_EXPORTDATA
 #endif
 
-#define WTF_EXPORT_PRIVATE JS_EXPORTDATA
-#define JS_EXPORT_PRIVATE JS_EXPORTDATA
+#define WTF_EXPORT_PRIVATE
+#define JS_EXPORT_PRIVATE
 
 #endif // config_h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87313] trunk

2011-05-25 Thread commit-queue

Title: [87313] trunk








Revision 87313
Author commit-qu...@webkit.org
Date 2011-05-25 12:23:39 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Sheriff Bot  

Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457

This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).

* storage/indexeddb/migrate-basics-expected.txt: Removed.
* storage/indexeddb/migrate-basics.html: Removed.
2011-05-25  Sheriff Bot  

Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457

This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).

* storage/IDBBackingStore.h:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
* storage/IDBLevelDBBackingStore.cpp:
* storage/IDBLevelDBBackingStore.h:
* storage/IDBSQLiteBackingStore.cpp:
* storage/IDBSQLiteBackingStore.h:
2011-05-25  Sheriff Bot  

Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457

This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).

* public/WebIDBFactory.h:
* src/AssertMatchingEnums.cpp:
* src/IDBFactoryBackendProxy.cpp:
* src/IDBFactoryBackendProxy.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
2011-05-25  Sheriff Bot  

Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457

This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::clearAllDatabases):
* DumpRenderTree/chromium/LayoutTestController.h:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBBackingStore.h
trunk/Source/WebCore/storage/IDBFactoryBackendImpl.cpp
trunk/Source/WebCore/storage/IDBFactoryBackendImpl.h
trunk/Source/WebCore/storage/IDBFactoryBackendInterface.h
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.h
trunk/Source/WebCore/storage/IDBSQLiteBackingStore.cpp
trunk/Source/WebCore/storage/IDBSQLiteBackingStore.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBFactory.h
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.h
trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h


Removed Paths

trunk/LayoutTests/storage/indexeddb/migrate-basics-expected.txt
trunk/LayoutTests/storage/indexeddb/migrate-basics.html




Diff

Modified: trunk/LayoutTests/ChangeLog (87312 => 87313)

--- trunk/LayoutTests/ChangeLog	2011-05-25 19:22:25 UTC (rev 87312)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 19:23:39 UTC (rev 87313)
@@ -1,3 +1,15 @@
+2011-05-25  Sheriff Bot  
+
+Unreviewed, rolling out r87257.
+http://trac.webkit.org/changeset/87257
+https://bugs.webkit.org/show_bug.cgi?id=61457
+
+This broke layout tests, see bug 61431. (Requested by
+hwennborg on #webkit).
+
+* storage/indexeddb/migrate-basics-expected.txt: Removed.
+* storage/indexeddb/migrate-basics.html: Removed.
+
 2011-05-25  Qi Zhang  
 
 Reviewed by Andreas Kling.


Deleted: trunk/LayoutTests/storage/indexeddb/migrate-basics-expected.txt (87312 => 87313)

--- trunk/LayoutTests/storage/indexeddb/migrate-basics-expected.txt	2011-05-25 19:22:25 UTC (rev 87312)
+++ trunk/LayoutTests/storage/indexeddb/migrate-basics-expected.txt	2011-05-25 19:23:39 UTC (rev 87313)
@@ -1,36 +0,0 @@
-Test migration from SQLite to LevelDB.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-webkitIndexedDB.open('MigrationDatabase')
-sqliteCreateSuccess():
-db = event.target.result
-db.setVersion('new version')
-sqliteSetVersionSuccess():
-window.db.createObjectStore('PlainOldStore', {autoIncrement: false})
-store = window.db.createObjectStore('StoreWithKeyPath', {keyPath: 'id', autoIncrement: true})
-window.db.createObjectStore('StoreWithAutoIncrement', {autoIncrem

[webkit-changes] [87311] trunk

2011-05-25 Thread qi . 2 . zhang

Title: [87311] trunk








Revision 87311
Author qi.2.zh...@nokia.com
Date 2011-05-25 12:20:29 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Qi Zhang  

Reviewed by Andreas Kling.

[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438

Unskip test case and provide expect result files.

* platform/qt/Skipped:
* platform/qt/fast/css/disabled-author-styles-expected.png: Added.
* platform/qt/fast/css/disabled-author-styles-expected.txt: Added.
2011-05-25  Qi Zhang  

Reviewed by Andreas Kling.

[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438

Provided API setAuthorAndUserStylesEnabled for DumpRenderTree.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-05-25  Qi Zhang  

Reviewed by Andreas Kling.

[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438

Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setAuthorAndUserStylesEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h


Added Paths

trunk/LayoutTests/platform/qt/fast/css/disabled-author-styles-expected.png
trunk/LayoutTests/platform/qt/fast/css/disabled-author-styles-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87310 => 87311)

--- trunk/LayoutTests/ChangeLog	2011-05-25 19:01:46 UTC (rev 87310)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 19:20:29 UTC (rev 87311)
@@ -1,3 +1,16 @@
+2011-05-25  Qi Zhang  
+
+Reviewed by Andreas Kling.
+
+[Qt] fast/css/disabled-author-styles.html failed
+https://bugs.webkit.org/show_bug.cgi?id=61438
+
+Unskip test case and provide expect result files.
+
+* platform/qt/Skipped:
+* platform/qt/fast/css/disabled-author-styles-expected.png: Added.
+* platform/qt/fast/css/disabled-author-styles-expected.txt: Added.
+
 2011-05-25  Rob Buis  
 
 Reviewed by Eric Seidel.


Modified: trunk/LayoutTests/platform/qt/Skipped (87310 => 87311)

--- trunk/LayoutTests/platform/qt/Skipped	2011-05-25 19:01:46 UTC (rev 87310)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-05-25 19:20:29 UTC (rev 87311)
@@ -1390,7 +1390,6 @@
 fast/block/float/editable-text-overlapping-float.html
 fast/block/margin-collapse/103.html
 fast/block/positioning/auto/006.html
-fast/css/disabled-author-styles.html
 fast/css/text-overflow-ellipsis-bidi.html
 fast/css/text-overflow-ellipsis.html
 fast/css/text-overflow-ellipsis-strict.html


Added: trunk/LayoutTests/platform/qt/fast/css/disabled-author-styles-expected.png (0 => 87311)

--- trunk/LayoutTests/platform/qt/fast/css/disabled-author-styles-expected.png	(rev 0)
+++ trunk/LayoutTests/platform/qt/fast/css/disabled-author-styles-expected.png	2011-05-25 19:20:29 UTC (rev 87311)
@@ -0,0 +1,13 @@
+\x89PNG
+
+
+IHDR X\x9Av\x82psBIT|d\x88	pHYs\xC4\xC4\x95+)tEXtchecksum8ae60e05cde35dba37e5d7ef71fc56e3beHBIDATx\x9C\xED\xDDo\xAC\xD6u\xFD\xC7\xF17&\xA2\x89C\xFBg:S\x99\x95\xE9l\xB6\xB1\x9C7JB72\x97$A-6\xC1%!A[\x8E\xA5cFu\xBCa\x9B\xA6\xD60[1\x8B\xE6b9ș\x8B\xA4
+M7\xE90l\x83\xE6\x84\xF8\x9C\xCF\xEF\xE39\xFF\xE4\xF8"=\x9B\x93s}\xAF\xEB\xF3\xFD|?\xDF\xEF\x8D\xEB\xC9\xF9^#Zk\xADN9\xD9\xFEw F\x801\x88 @\x8Cb#@\x80\xC4 F\x801\x880@\xBA\xBA\xBAj\xE4ȑ5o޼\xFA\xC9O~R#F\x8C\xA8#FԽ\xF7\xDE[_\xFF\xFA\xD7k\xECر5gΜ\xAA\xAA\xFA\xC67\xBE\xD1\xD9\xFE\x97\xBF\xFC\xA5\xCF1\xAF\xBB\xEE\xBA\xFA\xE0?X\xFB\xF6\xED\xBE#	\xECq\x9E\xA8+V\xF4\xB9\x9F͛7עE\x8B\x9C\xC7W\xBF\xFA\xD5a\x9D\xEB`\xC6\xEBo\xDEC\xB5lٲ\xC8Z\xFF\xB7\xECyx\xBB\xD1Zk\xFD=\xE1\xEE\xBBﮑ#G\xD6\xFC\xF9\xF3\xBF`Ĉ\xAA\xAAz\xF1\xC5kҤI\xF5\xC4O\xD4\xEAի\xEB\x81\xA8\x9E\x9E\x9Ez\xC7;\xDE\xD1k\xFB\xF1\x8C;\xB6v\xEF\xDE]۶m\xABw\xBF\xFB\xDDC\x9A\xF0\xAAU\xABj\xF2\xE4\xC9\xF5\xBE\xF7\xBDoH\xAF\xCE\xF1{\x9C'j\xA0\xFDf\xC3=\xD7\xF4>

[webkit-changes] [87310] trunk

2011-05-25 Thread rwlbuis

Title: [87310] trunk








Revision 87310
Author rwlb...@webkit.org
Date 2011-05-25 12:01:46 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Rob Buis  

Reviewed by Eric Seidel.

WebKit does not handle missing filter elements correctly
https://bugs.webkit.org/show_bug.cgi?id=12569

Updated improved pixel test result and add new SVG1.1 SE test and results.

* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
* svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.
2011-05-25  Rob Buis  

Reviewed by Eric Seidel.
New test rubber-stamped by Dirk Schulze.

WebKit does not handle missing filter elements correctly
https://bugs.webkit.org/show_bug.cgi?id=12569

Do not render elements that reference non-existant filters.

Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg

* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::prepareToRenderSVGContent):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp


Added Paths

trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
trunk/LayoutTests/svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (87309 => 87310)

--- trunk/LayoutTests/ChangeLog	2011-05-25 18:51:27 UTC (rev 87309)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 19:01:46 UTC (rev 87310)
@@ -1,3 +1,17 @@
+2011-05-25  Rob Buis  
+
+Reviewed by Eric Seidel.
+
+WebKit does not handle missing filter elements correctly
+https://bugs.webkit.org/show_bug.cgi?id=12569
+
+Updated improved pixel test result and add new SVG1.1 SE test and results.
+
+* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+* svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.
+
 2011-05-25  Nate Chapin  
 
 Reviewed by Adam Barth.


Modified: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt (0 => 87310)

--- trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt	2011-05-25 19:01:46 UTC (rev 87310)
@@ -0,0 +1,40 @@
+layer at (0,0) size 480x360
+  RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+  RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (82,20) size 364x265
+  RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGResourceFilter {filter} [id="null"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+RenderSVGResourceFilter {filter} [id="nullreg"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+  RenderSVGContainer {g} at (90,20) size 80x115
+RenderSVGPath {circle} at (100,30) size 60x60 [fill={[type=SOLID] [color=#FF]}] [cx=130.00] [cy=60.00] [r=30.00]
+RenderSVGPath {circle} at (90,20) size 80x80 [fill={[type=SOLID] [color=#00FF00]}] [cx=130.00] [cy=60.00] [r=40.00]
+RenderSVGText {text} at (95,111) size 70x24 contains 1 chunk(s)
+  RenderSVGInlineText {#text} at (0,0) size 70x24
+chunk 1 (middle anchor) text run 1 at (95.50,130.00) startOffset 0 endOffset 9 width 69.00: "No filter"
+  RenderSVGContainer {g} at (82,162) size 96x123
+RenderSVGPath {circle} at (100,180) size 60x60 [fill={[type=SOLID] [color=#00FF00]}] [cx=130.00] [cy=210.00] [r=30.00]
+RenderSVGPath {circle} at (82,162) size 96x96 [fill={[type=SOLID] [color=#FF]}] [cx=130.00] [cy=210.00] [r=40.00]
+  [filter="null"] RenderSVGResourceFilter {filter} at (82,162) size 96x96
+RenderSVGText {text} at (91,261) size 78x24 contains 1 chunk(s)
+  RenderSVGInlineText {#text} at (0,0) size 78x24
+chunk 1 (middle anchor) text run 1 at (91.50,280.00) startOffset 0 endOffset 11 width 77.00: "Null filter"
+  RenderSVGCo

[webkit-changes] [87309] trunk

2011-05-25 Thread japhet

Title: [87309] trunk








Revision 87309
Author jap...@chromium.org
Date 2011-05-25 11:51:27 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Nate Chapin  

Reviewed by Adam Barth.

Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like
XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled.
https://bugs.webkit.org/show_bug.cgi?id=59113

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source.
* dom/Document.h:
(WebCore::Document::isViewSource): Renamed from usesViewSourceStyles().
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/view-source-no-_javascript_-url-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/ScriptControllerBase.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/HTMLViewSourceDocument.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/xml/XMLTreeViewer.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (87308 => 87309)

--- trunk/LayoutTests/ChangeLog	2011-05-25 18:48:25 UTC (rev 87308)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 18:51:27 UTC (rev 87309)
@@ -1,3 +1,11 @@
+2011-05-25  Nate Chapin  
+
+Reviewed by Adam Barth.
+
+Add new console output for https://bugs.webkit.org/show_bug.cgi?id=59113.
+
+* http/tests/security/view-source-no-_javascript_-url-expected.txt:
+
 2011-05-25  Julien Chaffraix  
 
 Reviewed by James Robinson.


Modified: trunk/LayoutTests/http/tests/security/view-source-no-_javascript_-url-expected.txt (87308 => 87309)

--- trunk/LayoutTests/http/tests/security/view-source-no-_javascript_-url-expected.txt	2011-05-25 18:48:25 UTC (rev 87308)
+++ trunk/LayoutTests/http/tests/security/view-source-no-_javascript_-url-expected.txt	2011-05-25 18:51:27 UTC (rev 87309)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://127.0.0.1:8000/security/resources/innocent-victim.html from frame with URL http://127.0.0.1:8000/security/view-source-no-_javascript_-url.html. Domains, protocols and ports must match.
+
 This test passes if it does not alert FAIL.
 
 


Modified: trunk/Source/WebCore/ChangeLog (87308 => 87309)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 18:48:25 UTC (rev 87308)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 18:51:27 UTC (rev 87309)
@@ -1,3 +1,27 @@
+2011-05-25  Nate Chapin  
+
+Reviewed by Adam Barth.
+
+Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like
+XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled.
+https://bugs.webkit.org/show_bug.cgi?id=59113
+
+* bindings/ScriptControllerBase.cpp:
+(WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case.
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::matchUARules):
+* dom/Document.cpp:
+(WebCore::Document::Document):
+(WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source.
+* dom/Document.h:
+(WebCore::Document::isViewSource): Renamed from usesViewSourceStyles().
+* html/HTMLViewSourceDocument.cpp:
+(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::receivedFirstData):
+* xml/XMLTreeViewer.cpp:
+(WebCore::XMLTreeViewer::transformDocumentToTreeView):
+
 2011-05-25  Julien Chaffraix  
 
 Reviewed by James Robinson.


Modified: trunk/Source/WebCore/bindings/ScriptControllerBase.cpp (87308 => 87309)

--- trunk/Source/WebCore/bindings/ScriptControllerBase.cpp	2011-05-25 18:48:25 UTC (rev 87308)
+++ trunk/Source/WebCore/bindings/ScriptControllerBase.cpp	2011-05-25 18:51:27 UTC (rev 87309)
@@ -29,6 +29,7 @@
 #include "Page.h"
 #include "ScriptSourceCode.h"
 #include "ScriptValue.h"
+#include "SecurityOrigin.

[webkit-changes] [87308] trunk/Source/JavaScriptCore

2011-05-25 Thread oliver

Title: [87308] trunk/Source/_javascript_Core








Revision 87308
Author oli...@apple.com
Date 2011-05-25 11:48:25 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Oliver Hunt  

Reviewed by Geoffrey Garen.

Make allocations with guard pages ensure that the allocation succeeded
https://bugs.webkit.org/show_bug.cgi?id=61453

Add null checks, and make PageBlock's operator bool() use
the realbase, rather than the start of usable memory.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
* wtf/PageBlock.h:
(WTF::PageBlock::operator bool):
(WTF::PageBlock::PageBlock):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/OSAllocatorPosix.cpp
trunk/Source/_javascript_Core/wtf/PageBlock.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87307 => 87308)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-25 18:45:56 UTC (rev 87307)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-25 18:48:25 UTC (rev 87308)
@@ -1,3 +1,19 @@
+2011-05-25  Oliver Hunt  
+
+Reviewed by Geoffrey Garen.
+
+Make allocations with guard pages ensure that the allocation succeeded
+https://bugs.webkit.org/show_bug.cgi?id=61453
+
+Add null checks, and make PageBlock's operator bool() use
+the realbase, rather than the start of usable memory.
+
+* wtf/OSAllocatorPosix.cpp:
+(WTF::OSAllocator::reserveAndCommit):
+* wtf/PageBlock.h:
+(WTF::PageBlock::operator bool):
+(WTF::PageBlock::PageBlock):
+
 2011-04-10  Kevin Ollivier  
 
 Reviewed by Eric Seidel.


Modified: trunk/Source/_javascript_Core/wtf/OSAllocatorPosix.cpp (87307 => 87308)

--- trunk/Source/_javascript_Core/wtf/OSAllocatorPosix.cpp	2011-05-25 18:45:56 UTC (rev 87307)
+++ trunk/Source/_javascript_Core/wtf/OSAllocatorPosix.cpp	2011-05-25 18:48:25 UTC (rev 87308)
@@ -95,9 +95,15 @@
 #endif
 
 result = mmap(result, bytes, protection, flags, fd, 0);
-if (result == MAP_FAILED)
-CRASH();
-if (includesGuardPages) {
+if (result == MAP_FAILED) {
+#if ENABLE(INTERPRETER)
+if (executable)
+result = 0;
+else
+#endif
+CRASH();
+}
+if (result && includesGuardPages) {
 mprotect(result, pageSize(), PROT_NONE);
 mprotect(static_cast(result) + bytes - pageSize(), pageSize(), PROT_NONE);
 }


Modified: trunk/Source/_javascript_Core/wtf/PageBlock.h (87307 => 87308)

--- trunk/Source/_javascript_Core/wtf/PageBlock.h	2011-05-25 18:45:56 UTC (rev 87307)
+++ trunk/Source/_javascript_Core/wtf/PageBlock.h	2011-05-25 18:48:25 UTC (rev 87308)
@@ -42,7 +42,7 @@
 void* base() const { return m_base; }
 size_t size() const { return m_size; }
 
-operator bool() const { return !!m_base; }
+operator bool() const { return !!m_realBase; }
 
 bool contains(void* containedBase, size_t containedSize)
 {
@@ -72,7 +72,7 @@
 
 inline PageBlock::PageBlock(void* base, size_t size, bool hasGuardPages)
 : m_realBase(base)
-, m_base(static_cast(base) + (hasGuardPages ? pageSize() : 0))
+, m_base(static_cast(base) + ((base && hasGuardPages) ? pageSize() : 0))
 , m_size(size)
 {
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87307] trunk

2011-05-25 Thread jchaffraix

Title: [87307] trunk








Revision 87307
Author jchaffr...@webkit.org
Date 2011-05-25 11:45:56 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Julien Chaffraix  

Reviewed by James Robinson.

http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
https://bugs.webkit.org/show_bug.cgi?id=39027

And:

- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html
  https://bugs.webkit.org/show_bug.cgi?id=48295

- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html
  https://bugs.webkit.org/show_bug.cgi?id=48304

- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html
https://bugs.webkit.org/show_bug.cgi?id=48305

* canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
Those 2 tests need a trailing line that was added as part of this change.

* fast/canvas/canvas-composite-alpha.html: Updated the test result to match the specification.
The changes are fairly simple:
  - Clear up the destination rectangle as it should be always transparent now (source is transparent
outside the source rectangle).
  - Clear the composition rectangle if source or destination is transparent.
  - Fixed the test when run in the browser.
Validated the changes against FF and Opera (IE 9 cannot render this test).

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
Re-enable 4 tests.
2011-05-25  Julien Chaffraix  

Reviewed by James Robinson.

http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
https://bugs.webkit.org/show_bug.cgi?id=39027

And:

- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html
  https://bugs.webkit.org/show_bug.cgi?id=48295

- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html
  https://bugs.webkit.org/show_bug.cgi?id=48304

- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html
https://bugs.webkit.org/show_bug.cgi?id=48305

Those 4 tests have the same root cause for failing. Instead of splitting them in 2 fixes, I squashed
them together as the fix is common.

Based on an older work by Ariya Hidayat.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect): Added call displayTransparencyEverywhere for those 2
cases if we have to.

(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyEverywhere): This method returns true if
the spec says to display transparency everywhere. We only do so for source-in and source-out for now.
(WebCore::CanvasRenderingContext2D::displayTransparencyEverywhere): This method implements the spec
(which matches other browsers' behavior) and "display transparency elsewhere".

* html/canvas/CanvasRenderingContext2D.h: Added the two previous methods.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt
trunk/LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt
trunk/LayoutTests/fast/canvas/canvas-composite-alpha.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h




Diff

Modified: trunk/LayoutTests/ChangeLog (87306 => 87307)

--- trunk/LayoutTests/ChangeLog	2011-05-25 17:58:48 UTC (rev 87306)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 18:45:56 UTC (rev 87307)
@@ -1,3 +1,39 @@
+2011-05-25  Julien Chaffraix  
+
+Reviewed by James Robinson.
+
+http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
+https://bugs.webkit.org/show_bug.cgi?id=39027
+
+And:
+
+- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html
+  https://bugs.webkit.org/show_bug.cgi?id=48295
+
+- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html
+  https://bugs.webkit.org/show_bug.cgi?id=48304
+
+- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html
+https://bugs.webkit.org/show_bug.cgi?id=48305
+
+* canvas/philip/tests/2d.composite.uncovered.pattern

[webkit-changes] [87306] trunk/LayoutTests

2011-05-25 Thread robert

Title: [87306] trunk/LayoutTests








Revision 87306
Author rob...@webkit.org
Date 2011-05-25 10:58:48 -0700 (Wed, 25 May 2011)


Log Message
2011-05-20  Robert Hogan  

Reviewed by Geoffrey Garen.

[Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html

Use the test netscape plugin instead of quicktime.
Allows the test to pass on Qt/Gtk/Chromium as well as Mac.

https://bugs.webkit.org/show_bug.cgi?id=61182
http://code.google.com/p/chromium/issues/detail?id=15797

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* plugins/embed-attributes-setting-expected.txt:
* plugins/embed-attributes-setting.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/plugins/embed-attributes-setting-expected.txt
trunk/LayoutTests/plugins/embed-attributes-setting.html




Diff

Modified: trunk/LayoutTests/ChangeLog (87305 => 87306)

--- trunk/LayoutTests/ChangeLog	2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 17:58:48 UTC (rev 87306)
@@ -1,3 +1,21 @@
+2011-05-20  Robert Hogan  
+
+Reviewed by Geoffrey Garen.
+
+[Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html
+
+Use the test netscape plugin instead of quicktime.
+Allows the test to pass on Qt/Gtk/Chromium as well as Mac.
+
+https://bugs.webkit.org/show_bug.cgi?id=61182
+http://code.google.com/p/chromium/issues/detail?id=15797
+
+* platform/chromium/test_expectations.txt:
+* platform/gtk/Skipped:
+* platform/qt/Skipped:
+* plugins/embed-attributes-setting-expected.txt:
+* plugins/embed-attributes-setting.html:
+
 2011-05-25  Leon Scroggins  
 
 Reviewed by Steve Block.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87305 => 87306)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 17:58:48 UTC (rev 87306)
@@ -1142,10 +1142,6 @@
 // overlap, but it's very close and quite different from the Windows version
 BUGCR10350 LINUX : fast/replaced/width100percent-radio.html = FAIL
 
-// These tests are marked as failing on Linux because they depend on QuickTime.
-// See the bug for more discussion.
-BUGCR15797 LINUX : plugins/embed-attributes-setting.html = FAIL CRASH
-
 // Skip because we throw an exception before we get to dumpAsText.
 BUGCR10351 SKIP MAC : http/tests/plugins/geturlnotify-from-npp-destroystream.html = FAIL
 


Modified: trunk/LayoutTests/platform/gtk/Skipped (87305 => 87306)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-05-25 17:58:48 UTC (rev 87306)
@@ -580,7 +580,6 @@
 
 # Tests in plugins/ directory
 #   Tests failing, need to implement NPP_HandleEvent() in TestNetscapePlugin
-plugins/embed-attributes-setting.html
 plugins/get-url-with-blank-target.html
 plugins/plugin-initiate-popup-window.html
 


Modified: trunk/LayoutTests/platform/qt/Skipped (87305 => 87306)

--- trunk/LayoutTests/platform/qt/Skipped	2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-05-25 17:58:48 UTC (rev 87306)
@@ -355,9 +355,6 @@
 #  plugins rendered in incorrect position ?
 plugins/embed-attributes-style.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=61182
-plugins/embed-attributes-setting.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=41292
 plugins/plugin-initiate-popup-window.html
 


Modified: trunk/LayoutTests/plugins/embed-attributes-setting-expected.txt (87305 => 87306)

--- trunk/LayoutTests/plugins/embed-attributes-setting-expected.txt	2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/plugins/embed-attributes-setting-expected.txt	2011-05-25 17:58:48 UTC (rev 87306)
@@ -5,11 +5,11 @@
 PASS: embed.getAttribute('width') should be 1 and is.
 PASS: embed.getAttribute('type') should be 1 and is.
 PASS: embed.getAttribute('src') should be 1 and is.
-PASS: typeof embed.Play should be function and is.
+PASS: typeof embed.testCallback should be function and is.
 --
 [Embed is dynamically created element with only type specified]
-PASS: typeof embed.Play should be function and is.
+PASS: typeof embed.testCallback should be function and is.
 --
 [Embed is dynamically created element with only src specified]
-PASS: typeof embed.Play should be function and is.
+PASS: typeof embed.testCallback should be function and is.
  


Modified: trunk/LayoutTests/plugins/embed-attributes-setting.html (87305 => 87306)

--- trunk/LayoutTests/plugins/embed-attributes-setting.html	2011-05-25 17:22:23 UTC (rev 87305)
+++ trunk/LayoutTests/plugins/embed-attributes-setting.html	2011-05-25 17:58:48 UTC (rev

[webkit-changes] [87305] trunk/Source/WebKit2

2011-05-25 Thread mitz

Title: [87305] trunk/Source/WebKit2








Revision 87305
Author m...@apple.com
Date 2011-05-25 10:22:23 -0700 (Wed, 25 May 2011)


Log Message
 REGRESSION (r86851): Plug-ins disappear when scrolled with non-1 page scale
https://bugs.webkit.org/show_bug.cgi?id=61448

Reviewed by Anders Carlsson.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectInWindowCoordinates): Correct for page scale
after intersecting the two rectangles.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (87304 => 87305)

--- trunk/Source/WebKit2/ChangeLog	2011-05-25 17:10:03 UTC (rev 87304)
+++ trunk/Source/WebKit2/ChangeLog	2011-05-25 17:22:23 UTC (rev 87305)
@@ -1,3 +1,14 @@
+2011-05-25  Dan Bernstein  
+
+Reviewed by Anders Carlsson.
+
+ REGRESSION (r86851): Plug-ins disappear when scrolled with non-1 page scale
+https://bugs.webkit.org/show_bug.cgi?id=61448
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::clipRectInWindowCoordinates): Correct for page scale
+after intersecting the two rectangles.
+
 2011-05-24  Timothy Hatcher  
 
 Make the Web Inspector bring the right window to the front when docked.


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (87304 => 87305)

--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2011-05-25 17:10:03 UTC (rev 87304)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2011-05-25 17:22:23 UTC (rev 87305)
@@ -659,19 +659,20 @@
 
 IntRect PluginView::clipRectInWindowCoordinates() const
 {
-ASSERT(parent());
-
 // Get the frame rect in window coordinates.
 IntRect frameRectInWindowCoordinates = parent()->contentsToWindow(frameRect());
-frameRectInWindowCoordinates.scale(1 / frame()->pageScaleFactor());
 
+Frame* frame = this->frame();
+
 // Get the window clip rect for the enclosing layer (in window coordinates).
 RenderLayer* layer = m_pluginElement->renderer()->enclosingLayer();
-FrameView* parentView = m_pluginElement->document()->frame()->view();
-IntRect windowClipRect = parentView->windowClipRectForLayer(layer, true);
+IntRect windowClipRect = frame->view()->windowClipRectForLayer(layer, true);
 
 // Intersect the two rects to get the view clip rect in window coordinates.
-return intersection(frameRectInWindowCoordinates, windowClipRect);
+frameRectInWindowCoordinates.intersect(windowClipRect);
+
+frameRectInWindowCoordinates.scale(1 / frame->pageScaleFactor());
+return frameRectInWindowCoordinates;
 }
 
 void PluginView::focusPluginElement()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87304] trunk/Source/JavaScriptCore

2011-05-25 Thread kevino

Title: [87304] trunk/Source/_javascript_Core








Revision 87304
Author kev...@webkit.org
Date 2011-05-25 10:10:03 -0700 (Wed, 25 May 2011)


Log Message
Reviewed by Eric Seidel.

Add JS_EXPORT_PRIVATE macro for exported methods in bytecompiler headers.

https://bugs.webkit.org/show_bug.cgi?id=27551

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87303 => 87304)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-25 17:06:32 UTC (rev 87303)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-25 17:10:03 UTC (rev 87304)
@@ -1,3 +1,13 @@
+2011-04-10  Kevin Ollivier  
+
+Reviewed by Eric Seidel.
+
+Add JS_EXPORT_PRIVATE macro for exported methods in bytecompiler headers.
+
+https://bugs.webkit.org/show_bug.cgi?id=27551
+
+* bytecompiler/BytecodeGenerator.h:
+
 2011-05-24  Keishi Hattori  
 
 Reviewed by Kent Tamura.


Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h (87303 => 87304)

--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h	2011-05-25 17:06:32 UTC (rev 87303)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h	2011-05-25 17:10:03 UTC (rev 87304)
@@ -89,7 +89,7 @@
 typedef DeclarationStacks::VarStack VarStack;
 typedef DeclarationStacks::FunctionStack FunctionStack;
 
-static void setDumpsGeneratedCode(bool dumpsGeneratedCode);
+JS_EXPORT_PRIVATE static void setDumpsGeneratedCode(bool dumpsGeneratedCode);
 static bool dumpsGeneratedCode();
 
 BytecodeGenerator(ProgramNode*, ScopeChainNode*, SymbolTable*, ProgramCodeBlock*);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87303] trunk/Source/WebCore

2011-05-25 Thread leviw

Title: [87303] trunk/Source/WebCore








Revision 87303
Author le...@chromium.org
Date 2011-05-25 10:06:32 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Levi Weintraub  

Reviewed by Eric Seidel.

Add IntPoint versions of IntRect::move and IntPoint::move
https://bugs.webkit.org/show_bug.cgi?id=61390

Adding move methods to IntRect and IntPoint that take an IntPoint
that's acting as an offset. Since we also apply negative offsets,
also adding a single parameter operator- for IntPoint.

No new tests since this is refactoring.

* page/FrameView.cpp:
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::convertChildToSelf):
(WebCore::ScrollView::convertSelfToChild):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::invalidatePart):
* platform/graphics/IntPoint.h:
(WebCore::IntPoint::move):
(WebCore::operator-):
* platform/graphics/IntRect.h:
(WebCore::IntRect::move):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::requestedRegionOfInputImageData):
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::updateSubRect):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::selectionGaps):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::localCaretRect):
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::paint):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
* rendering/RenderInputSpeech.cpp:
(WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
* rendering/RenderLayerBacking.cpp:
(WebCore::paintScrollbar):
(WebCore::RenderLayerBacking::paintContents):
* rendering/RenderLayerCompositor.cpp:
(WebCore::paintScrollbar):
(WebCore::RenderLayerCompositor::paintContents):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeRectForRepaint):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp
trunk/Source/WebCore/platform/graphics/IntPoint.h
trunk/Source/WebCore/platform/graphics/IntRect.h
trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp
trunk/Source/WebCore/platform/graphics/gpu/Texture.cpp
trunk/Source/WebCore/platform/mac/WidgetMac.mm
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderDetailsMarker.cpp
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderInputSpeech.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderListItem.cpp
trunk/Source/WebCore/rendering/RenderListMarker.cpp
trunk/Source/WebCore/rendering/RenderTableCell.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
trunk/Source/WebCore/rendering/RenderView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87302 => 87303)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 17:04:47 UTC (rev 87302)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 17:06:32 UTC (rev 87303)
@@ -2,6 +2,71 @@
 
 Reviewed by Eric Seidel.
 
+Add IntPoint versions of IntRect::move and IntPoint::move
+https://bugs.webkit.org/show_bug.cgi?id=61390
+
+Adding move methods to IntRect and IntPoint that take an IntPoint
+that's acting as an offset. Since we also apply negative offsets,
+also adding a single parameter operator- for IntPoint.
+
+No new tests since this is refactoring.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::invalidateScrollbarRect):
+(WebCore::FrameView::convertFromRenderer):
+(WebCore::FrameView::convertToRenderer):
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::wheelEvent):

[webkit-changes] [87302] trunk/Source/WebCore

2011-05-25 Thread leviw

Title: [87302] trunk/Source/WebCore








Revision 87302
Author le...@chromium.org
Date 2011-05-25 10:04:47 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Levi Weintraub  

Reviewed by Eric Seidel.

Switch addFocusRingRects to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60783

Switching addFocusRingRects to use an IntPoint representing the offset being
applied instead of a pair of ints.

No new tests as this is only refactoring.

* platform/graphics/FloatSize.h:
(WebCore::flooredIntPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addFocusRingRects):
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addFocusRingRects):
* rendering/RenderInline.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
* rendering/RenderListBox.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::absoluteFocusRingQuads):
* rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::addFocusRingRects):
* rendering/RenderTextControlSingleLine.h:
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addFocusRingRects):
* rendering/svg/RenderSVGContainer.h:
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::addFocusRingRects):
* rendering/svg/RenderSVGImage.h:
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::addFocusRingRects):
* rendering/svg/RenderSVGPath.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FloatSize.h
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderTextControl.cpp
trunk/Source/WebCore/rendering/RenderTextControl.h
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h
trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGContainer.h
trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGImage.h
trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGPath.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (87301 => 87302)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 16:50:53 UTC (rev 87301)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 17:04:47 UTC (rev 87302)
@@ -1,3 +1,50 @@
+2011-05-25  Levi Weintraub  
+
+Reviewed by Eric Seidel.
+
+Switch addFocusRingRects to use IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=60783
+
+Switching addFocusRingRects to use an IntPoint representing the offset being
+applied instead of a pair of ints.
+
+No new tests as this is only refactoring.
+
+* platform/graphics/FloatSize.h:
+(WebCore::flooredIntPoint):
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::addFocusRingRects):
+* rendering/RenderBlock.h:
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::addFocusRingRects):
+* rendering/RenderBox.h:
+* rendering/RenderInline.cpp:
+(WebCore::RenderInline::addFocusRingRects):
+* rendering/RenderInline.h:
+* rendering/RenderListBox.cpp:
+(WebCore::RenderListBox::addFocusRingRects):
+* rendering/RenderListBox.h:
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::paintFocusRing):
+(WebCore::RenderObject::absoluteFocusRingQuads):
+* rendering/RenderObject.h:
+(WebCore::RenderObject::addFocusRingRects):
+* rendering/RenderTextControl.cpp:
+(WebCore::RenderTextControl::addFocusRingRects):
+* rendering/RenderTextControl.h:
+* rendering/RenderTextControlSingleLine.cpp:
+(WebCore::RenderTextControlSingleLine::addFocusRingRects):
+* rendering/RenderTextControlSingleLine.h:
+* rendering/svg/RenderSVGContainer.cpp:
+(WebCore::RenderSVGContainer::addFocusRingRects):
+

[webkit-changes] [87301] trunk/Source/WebCore

2011-05-25 Thread commit-queue

Title: [87301] trunk/Source/WebCore








Revision 87301
Author commit-qu...@webkit.org
Date 2011-05-25 09:50:53 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Sheriff Bot  

Unreviewed, rolling out r87229.
http://trac.webkit.org/changeset/87229
https://bugs.webkit.org/show_bug.cgi?id=61445

Lots of tests crashing in
CFNetwork!URLResponse::createFilenameFromResponseHeaders on
Windows XP (Requested by aroben on #webkit).

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
trunk/Source/WebCore/platform/network/cf/ResourceResponse.h
trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp
trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (87300 => 87301)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 16:48:03 UTC (rev 87300)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 16:50:53 UTC (rev 87301)
@@ -1,3 +1,42 @@
+2011-05-25  Sheriff Bot  
+
+Unreviewed, rolling out r87229.
+http://trac.webkit.org/changeset/87229
+https://bugs.webkit.org/show_bug.cgi?id=61445
+
+Lots of tests crashing in
+CFNetwork!URLResponse::createFilenameFromResponseHeaders on
+Windows XP (Requested by aroben on #webkit).
+
+* platform/network/ResourceResponseBase.cpp:
+(WebCore::ResourceResponseBase::adopt):
+(WebCore::ResourceResponseBase::suggestedFilename):
+(WebCore::ResourceResponseBase::setSuggestedFilename):
+(WebCore::ResourceResponseBase::httpStatusText):
+(WebCore::ResourceResponseBase::setHTTPStatusText):
+(WebCore::ResourceResponseBase::httpHeaderField):
+(WebCore::ResourceResponseBase::setHTTPHeaderField):
+(WebCore::ResourceResponseBase::httpHeaderFields):
+(WebCore::ResourceResponseBase::isAttachment):
+(WebCore::ResourceResponseBase::setLastModifiedDate):
+(WebCore::ResourceResponseBase::lastModifiedDate):
+(WebCore::ResourceResponseBase::wasCached):
+(WebCore::ResourceResponseBase::connectionReused):
+(WebCore::ResourceResponseBase::setConnectionReused):
+(WebCore::ResourceResponseBase::connectionID):
+(WebCore::ResourceResponseBase::setConnectionID):
+(WebCore::ResourceResponseBase::resourceLoadTiming):
+(WebCore::ResourceResponseBase::setResourceLoadTiming):
+(WebCore::ResourceResponseBase::resourceLoadInfo):
+(WebCore::ResourceResponseBase::setResourceLoadInfo):
+* platform/network/ResourceResponseBase.h:
+* platform/network/cf/ResourceResponse.h:
+(WebCore::ResourceResponse::ResourceResponse):
+* platform/network/cf/ResourceResponseCFNet.cpp:
+(WebCore::ResourceResponse::platformLazyInit):
+* platform/network/mac/ResourceResponseMac.mm:
+(WebCore::ResourceResponse::platformLazyInit):
+
 2011-05-25  Igor Oliveira  
 
 Reviewed by Antonio Gomes.


Modified: trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp (87300 => 87301)

--- trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp	2011-05-25 16:48:03 UTC (rev 87300)
+++ trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp	2011-05-25 16:50:53 UTC

[webkit-changes] [87300] trunk/LayoutTests

2011-05-25 Thread commit-queue

Title: [87300] trunk/LayoutTests








Revision 87300
Author commit-qu...@webkit.org
Date 2011-05-25 09:48:03 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Leon Scroggins  

Reviewed by Steve Block.

Update chromium expectations for more canvas fixes.
https://bugs.webkit.org/show_bug.cgi?id=61433

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87299 => 87300)

--- trunk/LayoutTests/ChangeLog	2011-05-25 16:38:29 UTC (rev 87299)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 16:48:03 UTC (rev 87300)
@@ -1,3 +1,12 @@
+2011-05-25  Leon Scroggins  
+
+Reviewed by Steve Block.
+
+Update chromium expectations for more canvas fixes.
+https://bugs.webkit.org/show_bug.cgi?id=61433
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Igor Oliveira  
 
 Reviewed by Antonio Gomes.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87299 => 87300)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 16:38:29 UTC (rev 87299)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 16:48:03 UTC (rev 87300)
@@ -997,7 +997,6 @@
 
 // shadow rendering issues
 BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-shadow.html = TEXT
-BUGCR79896 WIN7 GPU : fast/canvas/canvas-strokePath-shadow.html = TEXT
 
 BUGWK57547 LINUX GPU : fast/canvas/canvas-strokeRect-gradient-shadow.html = TEXT TIMEOUT
 
@@ -1006,7 +1005,6 @@
 
 // Misc. render failures
 BUGCR81718 WIN LINUX GPU : compositing/tiling/huge-layer-img.html = CRASH
-BUGCR81601 WIN LINUX GPU : fast/repaint/canvas-putImageData.html = IMAGE+TEXT
 BUGCR81606 WIN LINUX GPU : fast/canvas/drawImage-with-globalAlpha.html = IMAGE
 
 // fillRect failures






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87299] trunk/Tools

2011-05-25 Thread aroben

Title: [87299] trunk/Tools








Revision 87299
Author aro...@apple.com
Date 2011-05-25 09:38:29 -0700 (Wed, 25 May 2011)


Log Message
Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures

Fixes  TestFailures page should show when run-webkit-tests
started exiting early due to too many crashes, timeouts, or failures

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
run-webkit-tests exits early due to too many failures, pass that information in another
argument to the callback.
(Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
the new structure of the object passed to the callback.
(Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
getNumberOfFailingTests and to pass that along to our own callbacks.
(Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
from _getFailingTests and to store that value in the history object.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(.info): Added.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Updated for change in structure to the history
object and to add a note when run-webkit-tests exited early due to too many failures.
(ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
latestBuildInfos since each entry now contains more than just the tester and failure count.
Now displays a message for testers where the latest build exited early due to too many
failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
store that value in latestBuildInfos.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (87298 => 87299)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js	2011-05-25 16:33:57 UTC (rev 87298)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js	2011-05-25 16:38:29 UTC (rev 87299)
@@ -102,30 +102,27 @@
 var layoutTestStep = data.steps.findFirst(function(step) { return step.name === 'layout-test'; });
 if (!layoutTestStep) {
 self._cache[cacheKey] = -1;
-callback(self._cache[cacheKey]);
+callback(self._cache[cacheKey], false);
 return;
 }
 
 if (!('isStarted' in layoutTestStep)) {
 // run-webkit-tests never even ran.
 self._cache[cacheKey] = -1;
-callback(self._cache[cacheKey]);
+callback(self._cache[cacheKey], false);
 return;
 }
 
 if (!('results' in layoutTestStep) || layoutTestStep.results[0] === 0) {
 // All tests passed.
 self._cache[cacheKey] = 0;
-callback(self._cache[cacheKey]);
+callback(self._cache[cacheKey], false);
 return;
 }
 
-if (/^Exiting early/.test(layoutTestStep.results[1][0])) {
-// Too many tests crashed or timed out. We can't know for sure how many failed.
-self._cache[cacheKey] = -1;
-callback(self._cache[cacheKey]);
-return;
-}
+var tooManyFailures = false;
+if (/^Exiting early/.test(layoutTestStep.results[1][0]))
+tooManyFailures = true;
 
 var failureCount = layoutTestStep.results[1].reduce(function(sum, outputLine) {
 var match = /^(\d+) test cases/.exec(outputLine);
@@ -135,7 +132,7 @@
 }, 0);
 
 self._cache[cacheKey] = failureCount;
-callback(failureCount);
+callback(failureCount, tooManyFailures);
 });
 },
 
@@ -143,12 +140,22 @@
  * Preiodically calls callback until all current failures have been explained. Callback is
  * passed an object like the following:
  * {
- * 'r2_1 (1)': {
- * 'css1/basic/class_as_selector2.html': 'fail',
+ * 'r12347 (681)': {
+ * 'tooManyFailures': false,
+ * 'tests': {
+ * 'css1/basic/class_as_selector2.html': 'fail',
+ * },
  * },
- * 'r1_1 (0)': {
- * 'css1/basic/class_as_selector.html': 'crash',
+ * 'r12346 (680)': {
+ *

[webkit-changes] [87298] trunk

2011-05-25 Thread commit-queue

Title: [87298] trunk








Revision 87298
Author commit-qu...@webkit.org
Date 2011-05-25 09:33:57 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Igor Oliveira  

Reviewed by Antonio Gomes.

[Qt] QtWebKit crashes when dragging not loaded images
https://bugs.webkit.org/show_bug.cgi?id=61314

Checks if WebKit crashes when dragging an image not yet loaded.

* http/tests/misc/drag-not-loaded-image-expected.txt: Added.
* http/tests/misc/drag-not-loaded-image.html: Added.
2011-05-25  Igor Oliveira  

Reviewed by Antonio Gomes.

[Qt] QtWebKit crashes when dragging not loaded images
https://bugs.webkit.org/show_bug.cgi?id=61314

Checks if nativeImageForCurrentFrame is a valid pointer.

Test: http/tests/misc/drag-not-loaded-image.html

* platform/qt/DragImageQt.cpp:
(WebCore::createDragImageFromImage):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/DragImageQt.cpp


Added Paths

trunk/LayoutTests/http/tests/misc/drag-not-loaded-image-expected.txt
trunk/LayoutTests/http/tests/misc/drag-not-loaded-image.html




Diff

Modified: trunk/LayoutTests/ChangeLog (87297 => 87298)

--- trunk/LayoutTests/ChangeLog	2011-05-25 16:27:30 UTC (rev 87297)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 16:33:57 UTC (rev 87298)
@@ -1,3 +1,15 @@
+2011-05-25  Igor Oliveira  
+
+Reviewed by Antonio Gomes.
+
+[Qt] QtWebKit crashes when dragging not loaded images
+https://bugs.webkit.org/show_bug.cgi?id=61314
+
+Checks if WebKit crashes when dragging an image not yet loaded.
+
+* http/tests/misc/drag-not-loaded-image-expected.txt: Added.
+* http/tests/misc/drag-not-loaded-image.html: Added.
+
 2011-05-25  Andrey Kosyakov  
 
 Unreviewed. Skipped 3 new inspector tests that time out on gtk.


Added: trunk/LayoutTests/http/tests/misc/drag-not-loaded-image-expected.txt (0 => 87298)

--- trunk/LayoutTests/http/tests/misc/drag-not-loaded-image-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/misc/drag-not-loaded-image-expected.txt	2011-05-25 16:33:57 UTC (rev 87298)
@@ -0,0 +1,3 @@
+
+Success
+


Added: trunk/LayoutTests/http/tests/misc/drag-not-loaded-image.html (0 => 87298)

--- trunk/LayoutTests/http/tests/misc/drag-not-loaded-image.html	(rev 0)
+++ trunk/LayoutTests/http/tests/misc/drag-not-loaded-image.html	2011-05-25 16:33:57 UTC (rev 87298)
@@ -0,0 +1,44 @@
+
+
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+}
+
+function log(text)
+{
+var console = document.getElementById('console');
+console.appendChild(document.createTextNode(text));
+console.appendChild(document.createElement('br'));
+}
+
+
+
+
+ 
+var e = document.getElementById("imageSlow");
+function runTest() {
+readyState = document.readyState;
+if (readyState == 'complete') {
+log("Success")
+layoutTestController.notifyDone()
+} else if (readyState == 'loading' || readyState == 'interactive') {
+x = e.offsetLeft + e.offsetWidth / 2;
+y = e.offsetTop + e.offsetHeight / 2;
+
+eventSender.mouseMoveTo(x, y);
+eventSender.mouseDown();
+eventSender.mouseMoveTo(x + 100, y + 100);
+eventSender.mouseUp();
+setTimeout("runTest()", 50);
+}
+}
+
+runTest();
+
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (87297 => 87298)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 16:27:30 UTC (rev 87297)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 16:33:57 UTC (rev 87298)
@@ -1,3 +1,17 @@
+2011-05-25  Igor Oliveira  
+
+Reviewed by Antonio Gomes.
+
+[Qt] QtWebKit crashes when dragging not loaded images
+https://bugs.webkit.org/show_bug.cgi?id=61314
+
+Checks if nativeImageForCurrentFrame is a valid pointer.
+
+Test: http/tests/misc/drag-not-loaded-image.html
+
+* platform/qt/DragImageQt.cpp:
+(WebCore::createDragImageFromImage):
+
 2011-05-25  Ryuan Choi  
 
 Reviewed by Xan Lopez.


Modified: trunk/Source/WebCore/platform/qt/DragImageQt.cpp (87297 => 87298)

--- trunk/Source/WebCore/platform/qt/DragImageQt.cpp	2011-05-25 16:27:30 UTC (rev 87297)
+++ trunk/Source/WebCore/platform/qt/DragImageQt.cpp	2011-05-25 16:33:57 UTC (rev 87298)
@@ -63,7 +63,7 @@
 
 DragImageRef createDragImageFromImage(Image* image)
 {
-if (!image)
+if (!image || !image->nativeImageForCurrentFrame())
 return 0;
 
 return new QPixmap(*image->nativeImageForCurrentFrame());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87297] trunk/Source/WebCore

2011-05-25 Thread commit-queue

Title: [87297] trunk/Source/WebCore








Revision 87297
Author commit-qu...@webkit.org
Date 2011-05-25 09:27:30 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Ryuan Choi  

Reviewed by Xan Lopez.

[GTK] combobox and scrollbar are rendered small size at gtk+2.22.0
https://bugs.webkit.org/show_bug.cgi?id=61436

Fix arguments of gdk_drawable_get_size.

No new tests, no behavior change.

* platform/gtk/GtkVersioning.c:
(getGdkDrawableSize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GtkVersioning.c




Diff

Modified: trunk/Source/WebCore/ChangeLog (87296 => 87297)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 14:58:32 UTC (rev 87296)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 16:27:30 UTC (rev 87297)
@@ -1,3 +1,17 @@
+2011-05-25  Ryuan Choi  
+
+Reviewed by Xan Lopez.
+
+[GTK] combobox and scrollbar are rendered small size at gtk+2.22.0
+https://bugs.webkit.org/show_bug.cgi?id=61436
+
+Fix arguments of gdk_drawable_get_size.
+
+No new tests, no behavior change.
+
+* platform/gtk/GtkVersioning.c:
+(getGdkDrawableSize):
+
 2011-05-23  Alexander Pavlov  
 
 Reviewed by Yury Semikhatsky.


Modified: trunk/Source/WebCore/platform/gtk/GtkVersioning.c (87296 => 87297)

--- trunk/Source/WebCore/platform/gtk/GtkVersioning.c	2011-05-25 14:58:32 UTC (rev 87296)
+++ trunk/Source/WebCore/platform/gtk/GtkVersioning.c	2011-05-25 16:27:30 UTC (rev 87297)
@@ -278,7 +278,7 @@
 #else
 void getGdkDrawableSize(GdkDrawable *drawable, int *width, int *height)
 {
-gdk_drawable_get_size(drawable, &width, &height);
+gdk_drawable_get_size(drawable, width, height);
 }
 #endif // GTK_CHECK_VERSION(2, 24, 0)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87296] trunk/LayoutTests

2011-05-25 Thread caseq

Title: [87296] trunk/LayoutTests








Revision 87296
Author ca...@chromium.org
Date 2011-05-25 07:58:32 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Andrey Kosyakov  

Unreviewed. Skipped 3 new inspector tests that time out on gtk.

* platform/gtk/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (87295 => 87296)

--- trunk/LayoutTests/ChangeLog	2011-05-25 14:20:23 UTC (rev 87295)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 14:58:32 UTC (rev 87296)
@@ -1,3 +1,9 @@
+2011-05-25  Andrey Kosyakov  
+
+Unreviewed. Skipped 3 new inspector tests that time out on gtk.
+
+* platform/gtk/Skipped:
+
 2011-05-25  Gabor Loki  
 
 Rubber-stamped by Csaba Osztrogonác.


Modified: trunk/LayoutTests/platform/gtk/Skipped (87295 => 87296)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-05-25 14:20:23 UTC (rev 87295)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-05-25 14:58:32 UTC (rev 87296)
@@ -1376,6 +1376,11 @@
 http/tests/inspector/network/network-size-sync.html
 http/tests/inspector/network/network-size.html
 
+# https://bugs.webkit.org/show_bug.cgi?id=61437
+http/tests/inspector/network/network-clear-after-disabled.html
+http/tests/inspector/network/network-close-load-open.html
+http/tests/inspector/network/network-open-load-reopen.html
+
 # https://bugs.webkit.org/show_bug.cgi?id=56966
 # window.clientWidth and window.clientHeight do not include scrollbar allocation
 fast/overflow/horizontal-scroll-after-back.html
@@ -1452,4 +1457,4 @@
 media/video-src-invalid-poster.html
 
 # https://bugs.webkit.org/show_bug.cgi?id=61396
-fast/events/scroll-in-scaled-page-with-overflow-hidden.html
\ No newline at end of file
+fast/events/scroll-in-scaled-page-with-overflow-hidden.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87295] trunk/LayoutTests

2011-05-25 Thread loki

Title: [87295] trunk/LayoutTests








Revision 87295
Author l...@webkit.org
Date 2011-05-25 07:20:23 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Gabor Loki  

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip failed tests after r87290 and r87292 on ARM

* platform/qt-arm/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-arm/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (87294 => 87295)

--- trunk/LayoutTests/ChangeLog	2011-05-25 14:02:10 UTC (rev 87294)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 14:20:23 UTC (rev 87295)
@@ -1,3 +1,11 @@
+2011-05-25  Gabor Loki  
+
+Rubber-stamped by Csaba Osztrogonác.
+
+[Qt] Skip failed tests after r87290 and r87292 on ARM
+
+* platform/qt-arm/Skipped:
+
 2011-05-25  Anton Muhin  
 
 Unreviewed.


Modified: trunk/LayoutTests/platform/qt-arm/Skipped (87294 => 87295)

--- trunk/LayoutTests/platform/qt-arm/Skipped	2011-05-25 14:02:10 UTC (rev 87294)
+++ trunk/LayoutTests/platform/qt-arm/Skipped	2011-05-25 14:20:23 UTC (rev 87295)
@@ -38,6 +38,19 @@
 
 # Failing tests because of missing anti-aliased fonts
 transitions/move-after-transition.html
+# after r87290
+transforms/2d/compound-transforms-vs-containers.html
+transforms/2d/transform-borderbox.html
+transforms/2d/transform-origin-borderbox.html
+transforms/2d/zoom-menulist.html
+transforms/no_transform_hit_testing.html
+transforms/svg-vs-css.xhtml
+# after r87292
+fast/block/float/float-not-removed-from-next-sibling.html
+fast/block/float/float-not-removed-from-next-sibling2.html
+fast/block/float/float-not-removed-from-next-sibling3.html
+fast/block/float/float-not-removed-from-next-sibling4.html
+fast/transforms/transform-positioned-ancestor.html
 
 # Failing tests
 animations/3d/change-transform-in-end-event.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87294] trunk/Source/WebCore

2011-05-25 Thread apavlov

Title: [87294] trunk/Source/WebCore








Revision 87294
Author apav...@chromium.org
Date 2011-05-25 07:02:10 -0700 (Wed, 25 May 2011)


Log Message
2011-05-23  Alexander Pavlov  

Reviewed by Yury Semikhatsky.

Web Inspector: extreme lagging when searching for "img[src*="
https://bugs.webkit.org/show_bug.cgi?id=61282

No new tests, as this is a refactoring: ElementsTreeElement DOM is manipulated directly
when built and search-highlighted, rather than through innerHTML.

* inspector/front-end/DOMSyntaxHighlighter.js:
(WebInspector.DOMSyntaxHighlighter):
(WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
(WebInspector.ElementsTreeElement.prototype.hideSearchHighlights):
(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryShow):
(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryHide):
(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):
(WebInspector.ElementsTreeElement.prototype._addNewAttribute):
(WebInspector.ElementsTreeElement.prototype.updateTitle):
(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
():
* inspector/front-end/utilities.js:
():

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DOMSyntaxHighlighter.js
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
trunk/Source/WebCore/inspector/front-end/utilities.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (87293 => 87294)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 12:34:04 UTC (rev 87293)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 14:02:10 UTC (rev 87294)
@@ -1,3 +1,31 @@
+2011-05-23  Alexander Pavlov  
+
+Reviewed by Yury Semikhatsky.
+
+Web Inspector: extreme lagging when searching for "img[src*="
+https://bugs.webkit.org/show_bug.cgi?id=61282
+
+No new tests, as this is a refactoring: ElementsTreeElement DOM is manipulated directly
+when built and search-highlighted, rather than through innerHTML.
+
+* inspector/front-end/DOMSyntaxHighlighter.js:
+(WebInspector.DOMSyntaxHighlighter):
+(WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel.prototype._hideSearchHighlights):
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
+(WebInspector.ElementsTreeElement.prototype.hideSearchHighlights):
+(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryShow):
+(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryHide):
+(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):
+(WebInspector.ElementsTreeElement.prototype._addNewAttribute):
+(WebInspector.ElementsTreeElement.prototype.updateTitle):
+(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
+():
+* inspector/front-end/utilities.js:
+():
+
 2011-05-25  Leandro Gracia Gil  
 
 Reviewed by Tony Gentilcore.


Modified: trunk/Source/WebCore/inspector/front-end/DOMSyntaxHighlighter.js (87293 => 87294)

--- trunk/Source/WebCore/inspector/front-end/DOMSyntaxHighlighter.js	2011-05-25 12:34:04 UTC (rev 87293)
+++ trunk/Source/WebCore/inspector/front-end/DOMSyntaxHighlighter.js	2011-05-25 14:02:10 UTC (rev 87294)
@@ -28,9 +28,10 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-WebInspector.DOMSyntaxHighlighter = function(mimeType)
+WebInspector.DOMSyntaxHighlighter = function(mimeType, stripExtraWhitespace)
 {
 this._tokenizer = WebInspector.SourceTokenizer.Registry.getInstance().getTokenizer(mimeType);
+this._stripExtraWhitespace = stripExtraWhitespace;
 }
 
 WebInspector.DOMSyntaxHighlighter.prototype = {
@@ -38,6 +39,8 @@
 {
 var span = document.createElement("span");
 span.className = "webkit-" + className;
+if (this._stripExtraWhitespace)
+content = content.replace(/^[\n\r]*/, "").replace(/\s*$/, "");
 span.appendChild(document.createTextNode(content));
 return span;
 },


Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (87293 => 87294)

--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2011-05-25 12:34:04 UTC (rev 87293)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2011-05-25 14:02:10 UTC (rev 87294)
@@ -393,7 +393,7 @@
 var node = this._searchResults[

[webkit-changes] [87292] trunk/Source/WebCore

2011-05-25 Thread keishi

Title: [87292] trunk/Source/WebCore








Revision 87292
Author kei...@webkit.org
Date 2011-05-25 04:55:13 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Keishi Hattori  

Reviewed by Kent Tamura.

Move ElementWithPseudoId to separate file
https://bugs.webkit.org/show_bug.cgi?id=61430

No new tests because no behavior changes.

* CMakeLists.txt: Added ElementWithPseudoId.cpp
* GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
* WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
* WebCore.pro: Added ElementWithPseudoId.{h,cpp}
* WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
* WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
* html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
* html/shadow/ElementWithPseudoId.cpp: Added.
(WebCore::ElementWithPseudoId::shadowPseudoId):
* html/shadow/ElementWithPseudoId.h: Added.
(WebCore::ElementWithPseudoId::create):
(WebCore::ElementWithPseudoId::ElementWithPseudoId):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/ValidationMessage.cpp


Added Paths

trunk/Source/WebCore/html/shadow/ElementWithPseudoId.cpp
trunk/Source/WebCore/html/shadow/ElementWithPseudoId.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (87291 => 87292)

--- trunk/Source/WebCore/CMakeLists.txt	2011-05-25 11:43:46 UTC (rev 87291)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-05-25 11:55:13 UTC (rev 87292)
@@ -877,6 +877,7 @@
 html/parser/TextViewSourceParser.cpp
 html/parser/XSSFilter.cpp
 
+html/shadow/ElementWithPseudoId.cpp
 html/shadow/DetailsMarkerControl.cpp
 html/shadow/MediaControls.cpp
 html/shadow/MediaControlRootElement.cpp


Modified: trunk/Source/WebCore/ChangeLog (87291 => 87292)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 11:43:46 UTC (rev 87291)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 11:55:13 UTC (rev 87292)
@@ -1,3 +1,25 @@
+2011-05-25  Keishi Hattori  
+
+Reviewed by Kent Tamura.
+
+Move ElementWithPseudoId to separate file
+https://bugs.webkit.org/show_bug.cgi?id=61430
+
+No new tests because no behavior changes.
+
+* CMakeLists.txt: Added ElementWithPseudoId.cpp
+* GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
+* WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
+* WebCore.pro: Added ElementWithPseudoId.{h,cpp}
+* WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
+* WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
+* html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
+* html/shadow/ElementWithPseudoId.cpp: Added.
+(WebCore::ElementWithPseudoId::shadowPseudoId):
+* html/shadow/ElementWithPseudoId.h: Added.
+(WebCore::ElementWithPseudoId::create):
+(WebCore::ElementWithPseudoId::ElementWithPseudoId):
+
 2011-05-25  Alexis Menard  
 
 Reviewed by Antonio Gomes.


Modified: trunk/Source/WebCore/GNUmakefile.list.am (87291 => 87292)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-05-25 11:43:46 UTC (rev 87291)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-05-25 11:55:13 UTC (rev 87292)
@@ -1828,6 +1828,8 @@
 	Source/WebCore/html/parser/TextViewSourceParser.h \
 	Source/WebCore/html/parser/XSSFilter.cpp \
 	Source/WebCore/html/parser/XSSFilter.h \
+	Source/WebCore/html/shadow/ElementWithPseudoId.cpp \
+	Source/WebCore/html/shadow/ElementWithPseudoId.h \
 	Source/WebCore/html/shadow/DetailsMarkerControl.cpp \
 	Source/WebCore/html/shadow/DetailsMarkerControl.h \
 	Source/WebCore/html/shadow/MediaControls.cpp \


Modified: trunk/Source/WebCore/WebCore.gypi (87291 => 87292)

--- trunk/Source/WebCore/WebCore.gypi	2011-05-25 11:43:46 UTC (rev 87291)
+++ trunk/Source/WebCore/WebCore.gypi	2011-05-25 11:55:13 UTC (rev 87292)
@@ -3175,6 +3175,8 @@
 'html/parser/TextViewSourceParser.h',
 'html/parser/XSSFilter.cpp',
 'html/parser/XSSFilter.h',
+'html/shadow/ElementWithPseudoId.cpp',
+'html/shadow/ElementWithPseudoId.h',
 'html/shadow/DetailsMarkerControl.cpp',
 'html/shadow/DetailsMarkerControl.h',
 'html/shadow/MediaControls.cpp',


Modified: trunk/Source/WebCore/WebCore.pro (87291 => 87292)

--- trunk/Source/WebCore/WebCore.pro	2011-05-25 11:43:46 UTC (rev 87291)
+++ trunk/Source/WebCore/WebCore.pro	2011-05-25 11:55:13 UTC (rev 87292)
@@ -796,6 +796,7 @@
 html/parser/TextDocumentParser.cpp \
 html/parser/TextViewSourceParser.cpp \
 html/parser/XSSFilter.cpp \
+html/shadow/ElementWithPseudoI

[webkit-changes] [87291] trunk/LayoutTests

2011-05-25 Thread antonm

Title: [87291] trunk/LayoutTests








Revision 87291
Author ant...@chromium.org
Date 2011-05-25 04:43:46 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Anton Muhin  

Unreviewed.

Update test expectations after 3.3.6.1 v8 roll.

* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt:
* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt:
* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt:
* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt:
* platform/chromium/ietestcenter: Added.
* platform/chromium/ietestcenter/_javascript_: Added.
* platform/chromium/ietestcenter/_javascript_/15.4.4.14-5-28-expected.txt: Added.
* platform/chromium/ietestcenter/_javascript_/15.4.4.15-5-28-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt
trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt
trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt
trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium/ietestcenter/
trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/
trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/15.4.4.14-5-28-expected.txt
trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/15.4.4.15-5-28-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87290 => 87291)

--- trunk/LayoutTests/ChangeLog	2011-05-25 11:39:41 UTC (rev 87290)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 11:43:46 UTC (rev 87291)
@@ -1,3 +1,18 @@
+2011-05-25  Anton Muhin  
+
+Unreviewed.
+
+Update test expectations after 3.3.6.1 v8 roll.
+
+* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt:
+* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt:
+* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt:
+* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt:
+* platform/chromium/ietestcenter: Added.
+* platform/chromium/ietestcenter/_javascript_: Added.
+* platform/chromium/ietestcenter/_javascript_/15.4.4.14-5-28-expected.txt: Added.
+* platform/chromium/ietestcenter/_javascript_/15.4.4.15-5-28-expected.txt: Added.
+
 2011-05-25  Gabor Loki  
 
 Rubber-stamped by Csaba Osztrogonác.


Added: trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/15.4.4.14-5-28-expected.txt (0 => 87291)

--- trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/15.4.4.14-5-28-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/15.4.4.14-5-28-expected.txt	2011-05-25 11:43:46 UTC (rev 87291)
@@ -0,0 +1,11 @@
+15.4.4.14-5-28 (TestCases/chapter15/15.4/15.4.4/15.4.4.14/15.4.4.14-5-28.js) Array.prototype.indexOf - any side-effects in ToPrimitive processing of 'fromIndex' don't occur if step 1 throw an exception
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS ES5Harness.preconditionPassed is true
+PASS ES5Harness.testPassed is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/15.4.4.15-5-28-expected.txt (0 => 87291)

--- trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/15.4.4.15-5-28-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/ietestcenter/_javascript_/15.4.4.15-5-28-expected.txt	2011-05-25 11:43:46 UTC (rev 87291)
@@ -0,0 +1,11 @@
+15.4.4.15-5-28 (TestCases/chapter15/15.4/15.4.4/15.4.4.15/15.4.4.15-5-28.js) Array.prototype.lastIndexOf - any side-effects in ToPrimitive processing of 'fromIndex' don't occur if step 1 throw an exception
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS ES5Harness.preconditionPassed is true
+PASS ES5Harness.testPassed is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Modified: trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt (87290 => 87291)

--- trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt	2011-05-25 11:39:41 UTC (rev 87290)
+++ trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt	2011-05-25 11:43:46 UTC (rev 87291)
@@ -1,11 +0,0 @@
-15.5.4.20-1-1 (TestCases/chapter15/15.5/15.5.4/15.5.4.20/15.5.4.20-1-1.js) String.prototype.trim throws TypeError when string is undefined
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS ES5Harness.preconditionPassed is true
-FAIL ES5Harness.testPassed shou

[webkit-changes] [87290] trunk/Source/WebCore

2011-05-25 Thread alexis . menard

Title: [87290] trunk/Source/WebCore








Revision 87290
Author alexis.men...@openbossa.org
Date 2011-05-25 04:39:41 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Alexis Menard  

Reviewed by Antonio Gomes.

[Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=34635

Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
application with -style plastique for example, therefore the code used for other styles should also be
used whenever the current style is not the Mac style.

* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::paint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87289 => 87290)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 11:21:29 UTC (rev 87289)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 11:39:41 UTC (rev 87290)
@@ -1,3 +1,18 @@
+2011-05-25  Alexis Menard  
+
+Reviewed by Antonio Gomes.
+
+[Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
+https://bugs.webkit.org/show_bug.cgi?id=34635
+
+Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
+two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
+application with -style plastique for example, therefore the code used for other styles should also be
+used whenever the current style is not the Mac style.
+
+* platform/qt/ScrollbarThemeQt.cpp:
+(WebCore::ScrollbarThemeQt::paint):
+
 2011-05-25  Yuta Kitamura  
 
 Reviewed by Kent Tamura.


Modified: trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp (87289 => 87290)

--- trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp	2011-05-25 11:21:29 UTC (rev 87289)
+++ trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp	2011-05-25 11:39:41 UTC (rev 87290)
@@ -35,7 +35,9 @@
 #include "Scrollbar.h"
 
 #include 
-#include 
+#ifdef Q_WS_MAC
+#include 
+#endif
 #include 
 #include 
 #include 
@@ -154,18 +156,23 @@
 p.painter->setClipRect(opt->rect.intersected(damageRect), Qt::IntersectClip);
 
 #ifdef Q_WS_MAC
-p.drawComplexControl(QStyle::CC_ScrollBar, *opt);
-#else
-const QPoint topLeft = opt->rect.topLeft();
-p.painter->translate(topLeft);
-opt->rect.moveTo(QPoint(0, 0));
+// FIXME: We also need to check the widget style but today ScrollbarTheme is not aware of the page so we
+// can't get the widget.
+if (qobject_cast(style()))
+p.drawComplexControl(QStyle::CC_ScrollBar, *opt);
+else
+#endif
+{
+const QPoint topLeft = opt->rect.topLeft();
+p.painter->translate(topLeft);
+opt->rect.moveTo(QPoint(0, 0));
 
-// The QStyle expects the background to be already filled
-p.painter->fillRect(opt->rect, opt->palette.background());
+// The QStyle expects the background to be already filled.
+p.painter->fillRect(opt->rect, opt->palette.background());
 
-p.drawComplexControl(QStyle::CC_ScrollBar, *opt);
-opt->rect.moveTo(topLeft);
-#endif
+p.drawComplexControl(QStyle::CC_ScrollBar, *opt);
+opt->rect.moveTo(topLeft);
+}
 p.painter->restore();
 
 return true;
@@ -182,7 +189,7 @@
 
 bool ScrollbarThemeQt::shouldCenterOnThumb(Scrollbar*, const PlatformMouseEvent& evt)
 {
-// Middle click centers slider thumb (if supported)
+// Middle click centers slider thumb (if supported).
 return style()->styleHint(QStyle::SH_ScrollBar_MiddleClickAbsolutePosition) && evt.button() == MiddleButton;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87289] trunk/LayoutTests

2011-05-25 Thread ukai

Title: [87289] trunk/LayoutTests








Revision 87289
Author u...@chromium.org
Date 2011-05-25 04:21:29 -0700 (Wed, 25 May 2011)


Log Message
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt: svn/dynamic-updates failing

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87288 => 87289)

--- trunk/LayoutTests/ChangeLog	2011-05-25 11:19:39 UTC (rev 87288)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 11:21:29 UTC (rev 87289)
@@ -12,6 +12,14 @@
 
 Update chromium test expectations.
 
+* platform/chromium/test_expectations.txt: svn/dynamic-updates failing
+
+2011-05-25  Fumitoshi Ukai  
+
+Unreviewed.
+
+Update chromium test expectations.
+
 * platform/chromium/test_expectations.txt: mhtml tests pass
 
 2011-05-25  Fumitoshi Ukai  


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87288 => 87289)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 11:19:39 UTC (rev 87288)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 11:21:29 UTC (rev 87289)
@@ -4162,3 +4162,14 @@
 BUGWK61431 DEBUG : storage/indexeddb/transaction-basics.html = CRASH
 BUGWK61431 DEBUG : storage/indexeddb/transaction-event-propagation.html = CRASH
 BUGWK61431 DEBUG : storage/indexeddb/transaction-rollback.html = CRASH
+
+// New tests added in webkit r87284
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-dx-attr.html = IMAGE
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-dy-attr.html = IMAGE
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-rotate-attr.html = IMAGE
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-x-attr.html = IMAGE
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-y-attr.html = IMAGE
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-dx-prop.html = IMAGE
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html = IMAGE
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html = IMAGE
+BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87288] trunk/LayoutTests

2011-05-25 Thread loki

Title: [87288] trunk/LayoutTests








Revision 87288
Author l...@webkit.org
Date 2011-05-25 04:19:39 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Gabor Loki  

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip a flakey timed out test on ARM

* platform/qt-arm/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-arm/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (87287 => 87288)

--- trunk/LayoutTests/ChangeLog	2011-05-25 11:08:55 UTC (rev 87287)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 11:19:39 UTC (rev 87288)
@@ -1,3 +1,11 @@
+2011-05-25  Gabor Loki  
+
+Rubber-stamped by Csaba Osztrogonác.
+
+[Qt] Skip a flakey timed out test on ARM
+
+* platform/qt-arm/Skipped:
+
 2011-05-25  Fumitoshi Ukai  
 
 Unreviewed.


Modified: trunk/LayoutTests/platform/qt-arm/Skipped (87287 => 87288)

--- trunk/LayoutTests/platform/qt-arm/Skipped	2011-05-25 11:08:55 UTC (rev 87287)
+++ trunk/LayoutTests/platform/qt-arm/Skipped	2011-05-25 11:19:39 UTC (rev 87288)
@@ -33,6 +33,9 @@
 storage/change-version-handle-reuse.html
 storage/change-version-no-crash-on-preflight-failure.html
 
+# Flakey timed out test (r87278-r87279)
+fast/js/regexp-char-insensitive.html
+
 # Failing tests because of missing anti-aliased fonts
 transitions/move-after-transition.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87287] trunk/LayoutTests

2011-05-25 Thread ukai

Title: [87287] trunk/LayoutTests








Revision 87287
Author u...@chromium.org
Date 2011-05-25 04:08:55 -0700 (Wed, 25 May 2011)


Log Message
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt: mhtml tests pass

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87286 => 87287)

--- trunk/LayoutTests/ChangeLog	2011-05-25 11:00:08 UTC (rev 87286)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 11:08:55 UTC (rev 87287)
@@ -4,6 +4,14 @@
 
 Update chromium test expectations.
 
+* platform/chromium/test_expectations.txt: mhtml tests pass
+
+2011-05-25  Fumitoshi Ukai  
+
+Unreviewed.
+
+Update chromium test expectations.
+
 * platform/chromium/test_expectations.txt:
 
 2011-05-25  Fumitoshi Ukai  


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87286 => 87287)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 11:00:08 UTC (rev 87286)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 11:08:55 UTC (rev 87287)
@@ -4140,16 +4140,6 @@
 
 BUGWK61370 LINUX : svg/W3C-SVG-1.1/fonts-glyph-04-t.svg = IMAGE
 
-// New tests added in r87189
-BUGCR83833 : mhtml/multi_frames_ie.mht = MISSING
-BUGCR83833 : mhtml/multi_frames_unmht.mht = MISSING
-BUGCR83833 : mhtml/page_with_css_and_js_ie.mht = MISSING
-BUGCR83833 : mhtml/page_with_css_and_js_unmht.mht = MISSING
-BUGCR83833 : mhtml/page_with_image_ie.mht = MISSING
-BUGCR83833 : mhtml/page_with_image_unmht.mht = MISSING
-BUGCR83833 : mhtml/simple_page_ie.mht = MISSING
-BUGCR83833 : mhtml/simple_page_unmht.mht = MISSING
-
 // New tests added in r87274
 BUGCR83865 : fast/forms/color/input-value-sanitization-color.html = FAIL PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87286] trunk/LayoutTests

2011-05-25 Thread ukai

Title: [87286] trunk/LayoutTests








Revision 87286
Author u...@chromium.org
Date 2011-05-25 04:00:08 -0700 (Wed, 25 May 2011)


Log Message
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87285 => 87286)

--- trunk/LayoutTests/ChangeLog	2011-05-25 10:41:39 UTC (rev 87285)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 11:00:08 UTC (rev 87286)
@@ -6,6 +6,14 @@
 
 * platform/chromium/test_expectations.txt:
 
+2011-05-25  Fumitoshi Ukai  
+
+Unreviewed.
+
+Update chromium test expectations.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Felician Marton  
 
 Reviewed by Csaba Osztrogonác.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87285 => 87286)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 10:41:39 UTC (rev 87285)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 11:00:08 UTC (rev 87286)
@@ -4152,3 +4152,23 @@
 
 // New tests added in r87274
 BUGCR83865 : fast/forms/color/input-value-sanitization-color.html = FAIL PASS
+
+// Regression from webkit r87257
+BUGWK61431 DEBUG : storage/indexeddb/create-and-remove-object-store.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/cursor-continue.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/cursor-index-delete.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/cursor-update.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/database-basics.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/duplicates.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/exception-in-event-aborts.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/index-cursor.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/migrate-basics.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/objectstore-basics.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/objectstore-cursor.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/open-cursor.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/request-event-propagation.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/set_version_queue.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/transaction-after-close.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/transaction-basics.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/transaction-event-propagation.html = CRASH
+BUGWK61431 DEBUG : storage/indexeddb/transaction-rollback.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87285] trunk/LayoutTests

2011-05-25 Thread ukai

Title: [87285] trunk/LayoutTests








Revision 87285
Author u...@chromium.org
Date 2011-05-25 03:41:39 -0700 (Wed, 25 May 2011)


Log Message
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87284 => 87285)

--- trunk/LayoutTests/ChangeLog	2011-05-25 10:34:20 UTC (rev 87284)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 10:41:39 UTC (rev 87285)
@@ -1,3 +1,11 @@
+2011-05-25  Fumitoshi Ukai  
+
+Unreviewed.
+
+Update chromium test expectations.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Felician Marton  
 
 Reviewed by Csaba Osztrogonác.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87284 => 87285)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 10:34:20 UTC (rev 87284)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 10:41:39 UTC (rev 87285)
@@ -4149,3 +4149,6 @@
 BUGCR83833 : mhtml/page_with_image_unmht.mht = MISSING
 BUGCR83833 : mhtml/simple_page_ie.mht = MISSING
 BUGCR83833 : mhtml/simple_page_unmht.mht = MISSING
+
+// New tests added in r87274
+BUGCR83865 : fast/forms/color/input-value-sanitization-color.html = FAIL PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87283] trunk/LayoutTests

2011-05-25 Thread yutak

Title: [87283] trunk/LayoutTests








Revision 87283
Author yu...@chromium.org
Date 2011-05-25 03:12:35 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Yuta Kitamura  

Reviewed by Kent Tamura.

[Chromium] Clean up WebSocket test expectations
https://bugs.webkit.org/show_bug.cgi?id=61429

* platform/chromium/test_expectations.txt:
Remove two test expectations for tests that are no longer failing.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87282 => 87283)

--- trunk/LayoutTests/ChangeLog	2011-05-25 09:52:36 UTC (rev 87282)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 10:12:35 UTC (rev 87283)
@@ -2,6 +2,16 @@
 
 Reviewed by Kent Tamura.
 
+[Chromium] Clean up WebSocket test expectations
+https://bugs.webkit.org/show_bug.cgi?id=61429
+
+* platform/chromium/test_expectations.txt:
+Remove two test expectations for tests that are no longer failing.
+
+2011-05-25  Yuta Kitamura  
+
+Reviewed by Kent Tamura.
+
 WebSocket: Use fail() when WebSocketChannel has failed
 https://bugs.webkit.org/show_bug.cgi?id=61353
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87282 => 87283)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 09:52:36 UTC (rev 87282)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 10:12:35 UTC (rev 87283)
@@ -2095,8 +2095,6 @@
 // Hard to pin down which roll introduced the flakiness.
 BUGCR45106 WIN : svg/clip-path/clip-path-evenodd-nonzero.svg = PASS CRASH
 
-BUGCR45720 WIN LINUX : http/tests/websocket/tests/reload-crash.html = PASS CRASH
-
 // Chromium does not support cancel for notifications permissions.
 BUGWK42798 SKIP : fast/notifications/notifications-cancel-request-permission.html = FAIL
 
@@ -2266,8 +2264,6 @@
 // Slow test introduced in r64817
 BUGCR51571 WIN : http/tests/misc/bad-charset-alias.html = TIMEOUT PASS
 
-BUGCR51869 : http/tests/websocket/tests/frame-length-overflow.html = TEXT PASS
-
 BUGCR51854 WIN SLOW : http/tests/storage/callbacks-are-called-in-correct-context.html = PASS
 
 // Regressions from r65229






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87282] trunk

2011-05-25 Thread yutak

Title: [87282] trunk








Revision 87282
Author yu...@chromium.org
Date 2011-05-25 02:52:36 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Yuta Kitamura  

Reviewed by Kent Tamura.

WebSocket: Use fail() when WebSocketChannel has failed
https://bugs.webkit.org/show_bug.cgi?id=61353

* http/tests/websocket/tests/frame-length-overflow-expected.txt:
Added a new console message.
2011-05-25  Yuta Kitamura  

Reviewed by Kent Tamura.

WebSocket: Use fail() when WebSocketChannel has failed
https://bugs.webkit.org/show_bug.cgi?id=61353

An existing error message has been modified, but it is impossible
to test this message in LayoutTests because it is only shown when
memory allocation has failed, which is hard to reproduce reliably.

One new message has been added. It is covered by an existing test
http/tests/websocket/tests/frame-length-overflow.html.

There is no other change in behavior. No new tests are added.

* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::fail):
Do not close if we know the socket stream is already closed. This does not
change the behavior, because SocketStreamBase does nothing if it is already
closed.
(WebCore::WebSocketChannel::didOpen):
(WebCore::WebSocketChannel::didReceiveData):
We need to set m_shouldDiscardReceivedData to true before calling fail(),
so I moved the error message from appendToBuffer() to here.
The error message was rephrased in order to improve readability.
(WebCore::WebSocketChannel::appendToBuffer):
Unnested the code.
(WebCore::WebSocketChannel::processBuffer):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/websocket/tests/frame-length-overflow-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/websockets/WebSocketChannel.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (87281 => 87282)

--- trunk/LayoutTests/ChangeLog	2011-05-25 09:35:43 UTC (rev 87281)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 09:52:36 UTC (rev 87282)
@@ -1,3 +1,13 @@
+2011-05-25  Yuta Kitamura  
+
+Reviewed by Kent Tamura.
+
+WebSocket: Use fail() when WebSocketChannel has failed
+https://bugs.webkit.org/show_bug.cgi?id=61353
+
+* http/tests/websocket/tests/frame-length-overflow-expected.txt:
+Added a new console message.
+
 2011-05-24  Pavel Podivilov  
 
 Reviewed by Yury Semikhatsky.


Modified: trunk/LayoutTests/http/tests/websocket/tests/frame-length-overflow-expected.txt (87281 => 87282)

--- trunk/LayoutTests/http/tests/websocket/tests/frame-length-overflow-expected.txt	2011-05-25 09:35:43 UTC (rev 87281)
+++ trunk/LayoutTests/http/tests/websocket/tests/frame-length-overflow-expected.txt	2011-05-25 09:52:36 UTC (rev 87282)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 0: WebSocket frame length too large
 Make sure WebSocket does not crash and report error when it sees length overflow
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


Modified: trunk/Source/WebCore/ChangeLog (87281 => 87282)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 09:35:43 UTC (rev 87281)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 09:52:36 UTC (rev 87282)
@@ -1,3 +1,33 @@
+2011-05-25  Yuta Kitamura  
+
+Reviewed by Kent Tamura.
+
+WebSocket: Use fail() when WebSocketChannel has failed
+https://bugs.webkit.org/show_bug.cgi?id=61353
+
+An existing error message has been modified, but it is impossible
+to test this message in LayoutTests because it is only shown when
+memory allocation has failed, which is hard to reproduce reliably.
+
+One new message has been added. It is covered by an existing test
+http/tests/websocket/tests/frame-length-overflow.html.
+
+There is no other change in behavior. No new tests are added.
+
+* websockets/WebSocketChannel.cpp:
+(WebCore::WebSocketChannel::fail):
+Do not close if we know the socket stream is already closed. This does not
+change the behavior, because SocketStreamBase does nothing if it is already
+closed.
+(WebCore::WebSocketChannel::didOpen):
+(WebCore::WebSocketChannel::didReceiveData):
+We need to set m_shouldDiscardReceivedData to true before calling fail(),
+so I moved the error message from appendToBuffer() to here.
+The error message was rephrased in order to improve readability.
+(WebCore::WebSocketChannel::appendToBuffer):
+Unnested the code.
+(WebCore::WebSocketChannel::processBuffer):
+
 2011-05-16  Alexander Pavlov  
 
 Reviewed by David Levin.


Modified: trunk/Source/WebCore/websockets/WebSocketChannel.cpp (87281 => 87282)

--- trunk/Source/WebCore/websockets/WebSocketChannel.cpp	2011-05-25 09:35:43 UTC (rev 87281)
+++ trunk/

[webkit-changes] [87281] trunk/Source/WebCore

2011-05-25 Thread apavlov

Title: [87281] trunk/Source/WebCore








Revision 87281
Author apav...@chromium.org
Date 2011-05-25 02:35:43 -0700 (Wed, 25 May 2011)


Log Message
2011-05-16  Alexander Pavlov  

Reviewed by David Levin.

CSSParser: m_implicitShorthand should probably be RAII
https://bugs.webkit.org/show_bug.cgi?id=51586

It was impossible to entirely eliminate the m_implicitShorthand manual changes
due to the parseFill*() method stateful call chains.

No new tests, as this is a refactoring.

* css/CSSParser.cpp:
(ImplicitScope::ImplicitScope):
(ImplicitScope::~ImplicitScope):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseBorderRadius):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87280 => 87281)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 09:03:11 UTC (rev 87280)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 09:35:43 UTC (rev 87281)
@@ -1,3 +1,22 @@
+2011-05-16  Alexander Pavlov  
+
+Reviewed by David Levin.
+
+CSSParser: m_implicitShorthand should probably be RAII
+https://bugs.webkit.org/show_bug.cgi?id=51586
+
+It was impossible to entirely eliminate the m_implicitShorthand manual changes
+due to the parseFill*() method stateful call chains.
+
+No new tests, as this is a refactoring.
+
+* css/CSSParser.cpp:
+(ImplicitScope::ImplicitScope):
+(ImplicitScope::~ImplicitScope):
+(WebCore::CSSParser::parseShorthand):
+(WebCore::CSSParser::parse4Values):
+(WebCore::CSSParser::parseBorderRadius):
+
 2011-05-24  Pavel Podivilov  
 
 Reviewed by Yury Semikhatsky.


Modified: trunk/Source/WebCore/css/CSSParser.cpp (87280 => 87281)

--- trunk/Source/WebCore/css/CSSParser.cpp	2011-05-25 09:03:11 UTC (rev 87280)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2011-05-25 09:35:43 UTC (rev 87281)
@@ -92,6 +92,33 @@
 using namespace std;
 using namespace WTF;
 
+namespace {
+
+enum PropertyType {
+PropertyExplicit,
+PropertyImplicit
+};
+
+class ImplicitScope {
+WTF_MAKE_NONCOPYABLE(ImplicitScope);
+public:
+ImplicitScope(WebCore::CSSParser* parser, PropertyType propertyType)
+: m_parser(parser)
+{
+m_parser->m_implicitShorthand = propertyType == PropertyImplicit;
+}
+
+~ImplicitScope()
+{
+m_parser->m_implicitShorthand = false;
+}
+
+private:
+WebCore::CSSParser* m_parser;
+};
+
+} // namespace
+
 namespace WebCore {
 
 static const unsigned INVALID_NUM_PARSED_PROPERTIES = UINT_MAX;
@@ -2382,12 +2409,11 @@
 }
 
 // Fill in any remaining properties with the initial value.
-m_implicitShorthand = true;
+ImplicitScope implicitScope(this, PropertyImplicit);
 for (int i = 0; i < numProperties; ++i) {
 if (!fnd[i])
 addProperty(properties[i], CSSInitialValue::createImplicit(), important);
 }
-m_implicitShorthand = false;
 
 return true;
 }
@@ -2412,31 +2438,28 @@
 if (!parseValue(properties[0], important))
 return false;
 CSSValue *value = m_parsedProperties[m_numParsedProperties-1]->value();
-m_implicitShorthand = true;
+ImplicitScope implicitScope(this, PropertyImplicit);
 addProperty(properties[1], value, important);
 addProperty(properties[2], value, important);
 addProperty(properties[3], value, important);
-m_implicitShorthand = false;
 break;
 }
 case 2: {
 if (!parseValue(properties[0], important) || !parseValue(properties[1], important))
 return false;
 CSSValue *value = m_parsedProperties[m_numParsedProperties-2]->value();
-m_implicitShorthand = true;
+ImplicitScope implicitScope(this, PropertyImplicit);
 addProperty(properties[2], value, important);
 value = m_parsedProperties[m_numParsedProperties-2]->value();
 addProperty(properties[3], value, important);
-m_implicitShorthand = false;
 break;
 }
 case 3: {
 if (!parseValue(properties[0], important) || !parseValue(properties[1], important) || !parseValue(properties[2], important))
 return false;
 CSSValue *value = m_parsedProperties[m_numParsedProperties-2]->value();
-m_implicitShorthand = true;
+ImplicitScope implicitScope(this, PropertyImplicit);
 addProperty(properties[3], value, important);
-m_implicitShorthand = false;
 break;
 }
 case 4: {
@@ -4995,12 +5018,11 @@
 } else
 completeBorderRadii(radii[1]);
 
-m_implicitShorthand = true;
+ImplicitScope implicitScope(this, PropertyImplicit);
 addProperty(CSSPro

[webkit-changes] [87280] trunk

2011-05-25 Thread podivilov

Title: [87280] trunk








Revision 87280
Author podivi...@chromium.org
Date 2011-05-25 02:03:11 -0700 (Wed, 25 May 2011)


Log Message
2011-05-24  Pavel Podivilov  

Reviewed by Yury Semikhatsky.

Web Inspector: inspected page crashes when call stack is empty after live edit.
https://bugs.webkit.org/show_bug.cgi?id=61364

* inspector/debugger/live-edit-expected.txt:
* inspector/debugger/live-edit.html:
* platform/chromium/test_expectations.txt:
2011-05-24  Pavel Podivilov  

Reviewed by Yury Semikhatsky.

Web Inspector: inspected page crashes when call stack is empty after live edit.
https://bugs.webkit.org/show_bug.cgi?id=61364

* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/live-edit-expected.txt
trunk/LayoutTests/inspector/debugger/live-edit.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptDebugServer.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (87279 => 87280)

--- trunk/LayoutTests/ChangeLog	2011-05-25 07:48:53 UTC (rev 87279)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 09:03:11 UTC (rev 87280)
@@ -1,3 +1,14 @@
+2011-05-24  Pavel Podivilov  
+
+Reviewed by Yury Semikhatsky.
+
+Web Inspector: inspected page crashes when call stack is empty after live edit.
+https://bugs.webkit.org/show_bug.cgi?id=61364
+
+* inspector/debugger/live-edit-expected.txt:
+* inspector/debugger/live-edit.html:
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Mads Ager  
 
 Reviewed by Adam Barth.


Modified: trunk/LayoutTests/inspector/debugger/live-edit-expected.txt (87279 => 87280)

--- trunk/LayoutTests/inspector/debugger/live-edit-expected.txt	2011-05-25 07:48:53 UTC (rev 87279)
+++ trunk/LayoutTests/inspector/debugger/live-edit-expected.txt	2011-05-25 09:03:11 UTC (rev 87280)
@@ -13,14 +13,15 @@
 
 Running: testLiveEditWhenPaused
 Script execution paused.
+Script execution resumed.
+
+Running: testNoCrashWhenOnlyOneFunctionOnStack
+Script execution paused.
 Call stack:
 0) f1 (edit-me-when-paused.js:13)
-1)  (:1)
-2) eval ((internal script):146)
-3) InjectedScript._evaluateOn (:283)
-4) InjectedScript._evaluateAndWrap (:265)
-5) InjectedScript.evaluate (:245)
 Script execution resumed.
+Script execution paused.
+Script execution resumed.
 
 Running: testBreakpointsUpdated
 Debugger was disabled.


Modified: trunk/LayoutTests/inspector/debugger/live-edit.html (87279 => 87280)

--- trunk/LayoutTests/inspector/debugger/live-edit.html	2011-05-25 07:48:53 UTC (rev 87279)
+++ trunk/LayoutTests/inspector/debugger/live-edit.html	2011-05-25 09:03:11 UTC (rev 87280)
@@ -51,7 +51,6 @@
 
 function didEditScriptSource()
 {
-InspectorTest.captureStackTrace(WebInspector.debuggerModel.callFrames);
 InspectorTest.resumeExecution();
 }
 
@@ -62,6 +61,28 @@
 }
 },
 
+function testNoCrashWhenOnlyOneFunctionOnStack(next)
+{
+InspectorTest.showScriptSource("edit-me-when-paused.js", didShowScriptSource);
+
+function didShowScriptSource(sourceFrame)
+{
+InspectorTest.waitUntilPaused(paused);
+InspectorTest.evaluateInPage("setTimeout(f1, 0)");
+}
+
+function paused(callFrames)
+{
+InspectorTest.captureStackTrace(callFrames);
+replaceInSource(panel.visibleView, "debugger;", "debugger;\n", didEditScriptSource);
+}
+
+function didEditScriptSource()
+{
+InspectorTest.resumeExecution(InspectorTest.waitUntilPaused.bind(InspectorTest, InspectorTest.resumeExecution.bind(InspectorTest, next)));
+}
+},
+
 function testBreakpointsUpdated(next)
 {
 InspectorTest.showScriptSource("edit-me.js", didShowScriptSource);
@@ -91,7 +112,7 @@
 {
 InspectorTest.addSniffer(WebInspector.debuggerModel, "_didEditScriptSource", callback);
 sourceFrame._textViewer._mainPanel.readOnly = false;
-sourceFrame.startEditing();
+sourceFrame.beforeTextChanged();
 var oldRange, newRange;
 var lines = sourceFrame._textModel._lines;
 for (var i = 0; i < lines.length; ++i) {
@@ -105,7 +126,7 @@
 newRange = new WebInspector.TextRange(i, column, i + lineEndings.length - 1, lastLineLength);
 break;
 }
-sourceFrame.endEditing(oldRange, newRange);
+sourceFrame.afterTextChanged(oldRange, newRange);
 sourceFrame._textViewer._commitEditing();
 }
 };


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87279 => 87280)

--- trunk/LayoutTests/

[webkit-changes] [87279] trunk/LayoutTests

2011-05-25 Thread ager

Title: [87279] trunk/LayoutTests








Revision 87279
Author a...@chromium.org
Date 2011-05-25 00:48:53 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Mads Ager  

Reviewed by Adam Barth.

Update chromium expectations after removal of execScript from V8
https://bugs.webkit.org/show_bug.cgi?id=61267

* platform/chromium/fast/dom/prototype-inheritance-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87278 => 87279)

--- trunk/LayoutTests/ChangeLog	2011-05-25 07:45:33 UTC (rev 87278)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 07:48:53 UTC (rev 87279)
@@ -1,3 +1,12 @@
+2011-05-25  Mads Ager  
+
+Reviewed by Adam Barth.
+
+Update chromium expectations after removal of execScript from V8
+https://bugs.webkit.org/show_bug.cgi?id=61267
+
+* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
+
 2011-05-23  Yury Semikhatsky  
 
 Reviewed by Adam Barth.


Modified: trunk/LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt (87278 => 87279)

--- trunk/LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt	2011-05-25 07:45:33 UTC (rev 87278)
+++ trunk/LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt	2011-05-25 07:48:53 UTC (rev 87279)
@@ -697,8 +697,6 @@
 PASS inner.escape.constructor.isInner is true
 PASS inner.eval.isInner is true
 PASS inner.eval.constructor.isInner is true
-PASS inner.execScript.isInner is true
-PASS inner.execScript.constructor.isInner is true
 PASS inner.find.isInner is true
 PASS inner.find.constructor.isInner is true
 FAIL inner.focus.isInner should be true. Was false.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87278] trunk

2011-05-25 Thread yurys

Title: [87278] trunk








Revision 87278
Author yu...@chromium.org
Date 2011-05-25 00:45:33 -0700 (Wed, 25 May 2011)


Log Message
2011-05-23  Yury Semikhatsky  

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194

Test: inspector/console/console-eval-syntax-error.html

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error

2011-05-23  Yury Semikhatsky  

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194

* inspector/console/console-eval-syntax-error-expected.txt: Added.
* inspector/console/console-eval-syntax-error.html: Added.
* platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp


Added Paths

trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
trunk/LayoutTests/inspector/console/console-eval-syntax-error.html
trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87277 => 87278)

--- trunk/LayoutTests/ChangeLog	2011-05-25 07:17:21 UTC (rev 87277)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 07:45:33 UTC (rev 87278)
@@ -1,3 +1,14 @@
+2011-05-23  Yury Semikhatsky  
+
+Reviewed by Adam Barth.
+
+Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
+https://bugs.webkit.org/show_bug.cgi?id=61194
+
+* inspector/console/console-eval-syntax-error-expected.txt: Added.
+* inspector/console/console-eval-syntax-error.html: Added.
+* platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.
+
 2011-05-24  Keishi Hattori  
 
 Reviewed by Kent Tamura.


Added: trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt (0 => 87278)

--- trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt	2011-05-25 07:45:33 UTC (rev 87278)
@@ -0,0 +1,5 @@
+Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser. Bug 61194.
+
+foo().
+Error
+
Property changes on: trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/console/console-eval-syntax-error.html (0 => 87278)

--- trunk/LayoutTests/inspector/console/console-eval-syntax-error.html	(rev 0)
+++ trunk/LayoutTests/inspector/console/console-eval-syntax-error.html	2011-05-25 07:45:33 UTC (rev 87278)
@@ -0,0 +1,25 @@
+
+
+
+function test()
+{
+InspectorTest.evaluateInConsole("foo().", step1);
+
+function step1()
+{
+InspectorTest.dumpConsoleMessages();
+InspectorTest.completeTest();
+}
+}
+
+
+
+
+
+Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser.
+
+
+
+
Property changes on: trunk/LayoutTests/inspector/console/console-eval-syntax-error.html
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt (0 => 87278)

--- trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt	2011-05-25 07:45:33 UTC (rev 87278)
@@ -0,0 +1,5 @@
+Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser. Bug 61194.
+
+foo().
+SyntaxError
+
Property changes on: trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (87277 => 87278)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 07:17:21 UTC (rev 87277)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 07:45:33 UTC (rev 87278)
@@ -1,3 +1,15 @@
+2011-05-23  Yury Semikhatsky  
+
+Reviewed by Adam Barth.
+
+Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
+https://bugs.webkit.org/show_bug.cgi?id=61194
+
+Test: inspector/console/console-eval-syntax-error.html
+
+* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+(WebCore::V8InjectedScriptHost::evalua

[webkit-changes] [87277] trunk/Source/WebCore

2011-05-25 Thread yuzo

Title: [87277] trunk/Source/WebCore








Revision 87277
Author y...@google.com
Date 2011-05-25 00:17:21 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Yuzo Fujishima  

Reviewed by Kent Tamura.

Fix for Bug 61352 - Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA
https://bugs.webkit.org/show_bug.cgi?id=61352

No new tests because no behavior changes.

* html/shadow/MediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::layout):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::layout):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
* rendering/RenderView.h:
(WebCore::RenderView::disableLayoutState):
(WebCore::RenderView::enableLayoutState):
(WebCore::LayoutStateDisabler::LayoutStateDisabler):
(WebCore::LayoutStateDisabler::~LayoutStateDisabler):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/MediaControlElements.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListItem.cpp
trunk/Source/WebCore/rendering/RenderMedia.cpp
trunk/Source/WebCore/rendering/RenderView.h
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87276 => 87277)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 06:42:11 UTC (rev 87276)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 07:17:21 UTC (rev 87277)
@@ -1,3 +1,36 @@
+2011-05-25  Yuzo Fujishima  
+
+Reviewed by Kent Tamura.
+
+Fix for Bug 61352 - Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA
+https://bugs.webkit.org/show_bug.cgi?id=61352
+
+No new tests because no behavior changes.
+
+* html/shadow/MediaControlElements.cpp:
+(WebCore::RenderMediaVolumeSliderContainer::layout):
+* page/FrameView.cpp:
+(WebCore::FrameView::layout):
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::repaintOverhangingFloats):
+(WebCore::RenderBlock::updateFirstLetter):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::updateLayerPositions):
+(WebCore::RenderLayer::updateScrollInfoAfterLayout):
+* rendering/RenderListBox.cpp:
+(WebCore::RenderListBox::layout):
+* rendering/RenderListItem.cpp:
+(WebCore::RenderListItem::updateMarkerLocation):
+* rendering/RenderMedia.cpp:
+(WebCore::RenderMedia::layout):
+* rendering/RenderView.h:
+(WebCore::RenderView::disableLayoutState):
+(WebCore::RenderView::enableLayoutState):
+(WebCore::LayoutStateDisabler::LayoutStateDisabler):
+(WebCore::LayoutStateDisabler::~LayoutStateDisabler):
+* rendering/svg/RenderSVGRoot.cpp:
+(WebCore::RenderSVGRoot::layout):
+
 2011-05-24  Csaba Osztrogonác  
 
 [Qt] Unreviewed typo fix after r87228.


Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (87276 => 87277)

--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp	2011-05-25 06:42:11 UTC (rev 87276)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp	2011-05-25 07:17:21 UTC (rev 87277)
@@ -167,15 +167,11 @@
 
 RenderBox* buttonBox = toRenderBox(previousSibling());
 
-if (view())
-view()->disableLayoutState();
+LayoutStateDisabler layoutStateDisabler(view());
 
 IntPoint offset = theme()->volumeSliderOffsetFromMuteButton(buttonBox, IntSize(width(), height()));
 setX(offset.x() + buttonBox->offsetLeft());
 setY(offset.y() + buttonBox->offsetTop());
-
-if (view())
-view()->enableLayoutState();
 }
 
 inline MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement(HTMLMediaElement* mediaElement)


Modified: trunk/Source/WebCore/page/FrameView.cpp (87276 => 87277)

--- trunk/Source/WebCore/page/FrameView.cpp	2011-05-25 06:42:11 UTC (rev 87276)
+++ trunk/Source/WebCore/page/FrameView.cpp	2011-05-25 07:17:21 UTC (rev 87277)
@@ -978,26 +978,23 @@
 
 m_actionScheduler->pause();
 
-bool disableLayoutState = false;
-if (subtree) {
-RenderView* view = root->view();
-disableLayoutState = view->shouldDisableLayoutStateForSubtree(root);
-

83 matches

Mail list logo