[webkit-changes] [98836] trunk/Source/WebKit/chromium
Title: [98836] trunk/Source/WebKit/chromium Revision 98836 Author vange...@chromium.org Date 2011-10-31 00:10:01 -0700 (Mon, 31 Oct 2011) Log Message Add missing declaration in WebSettings.h https://bugs.webkit.org/show_bug.cgi?id=71165 Reviewed by Darin Fisher. * public/WebSettings.h: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebSettings.h Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (98835 => 98836) --- trunk/Source/WebKit/chromium/ChangeLog 2011-10-31 02:50:30 UTC (rev 98835) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-31 07:10:01 UTC (rev 98836) @@ -1,3 +1,12 @@ +2011-10-31 Vangelis Kokkevis vange...@chromium.org + +Add missing declaration in WebSettings.h +https://bugs.webkit.org/show_bug.cgi?id=71165 + +Reviewed by Darin Fisher. + +* public/WebSettings.h: + 2011-10-29 Jochen Eisinger joc...@chromium.org Implement IDBFactory.deleteDatabase Modified: trunk/Source/WebKit/chromium/public/WebSettings.h (98835 => 98836) --- trunk/Source/WebKit/chromium/public/WebSettings.h 2011-10-31 02:50:30 UTC (rev 98835) +++ trunk/Source/WebKit/chromium/public/WebSettings.h 2011-10-31 07:10:01 UTC (rev 98836) @@ -112,6 +112,7 @@ virtual void setAcceleratedCompositingForPluginsEnabled(bool) = 0; virtual void setAcceleratedCompositingForAnimationEnabled(bool) = 0; virtual void setAccelerated2dCanvasEnabled(bool) = 0; +virtual void setAcceleratedCompositingForFixedPositionEnabled(bool) = 0; virtual void setLegacyAccelerated2dCanvasEnabled(bool) = 0; virtual void setMinimumAccelerated2dCanvasSize(int) = 0; virtual void setAcceleratedDrawingEnabled(bool) = 0; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98838] trunk/LayoutTests
Title: [98838] trunk/LayoutTests Revision 98838 Author ca...@chromium.org Date 2011-10-31 01:28:13 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed. compositing/visibility/visibility-image-layers.html fails on GPU. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98837 => 98838) --- trunk/LayoutTests/ChangeLog 2011-10-31 07:48:21 UTC (rev 98837) +++ trunk/LayoutTests/ChangeLog 2011-10-31 08:28:13 UTC (rev 98838) @@ -1,3 +1,9 @@ +2011-10-31 Andrey Kosyakov ca...@chromium.org + +Unreviewed. compositing/visibility/visibility-image-layers.html fails on GPU. + +* platform/chromium/test_expectations.txt: + 2011-10-30 Yuta Kitamura yu...@chromium.org WebSocket: iframe in reload-crash.html reloads forever Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98837 => 98838) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 07:48:21 UTC (rev 98837) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 08:28:13 UTC (rev 98838) @@ -3929,3 +3929,4 @@ BUGWK71139 SNOWLEOPARD : fast/frames/sandboxed-iframe-navigation-targetlink.html = CRASH PASS BUGWK71181 : fast/forms/input-step-as-double.html = PASS TEXT +BUGWK71209 GPU : compositing/visibility/visibility-image-layers.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98839] trunk
Title: [98839] trunk
Revision 98839
Author apav...@chromium.org
Date 2011-10-31 01:37:32 -0700 (Mon, 31 Oct 2011)
Log Message
Web Inspector: Using keyboard to increment/decrement units is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=71119
Reviewed by Pavel Feldman.
Source/WebCore:
This change makes the behavior consistent with that described at http://trac.webkit.org/wiki/WebInspector
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.alteredFloatNumber):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
LayoutTests:
* inspector/styles/up-down-numerics-and-colors-expected.txt:
* inspector/styles/up-down-numerics-and-colors.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/styles/up-down-numerics-and-colors-expected.txt
trunk/LayoutTests/inspector/styles/up-down-numerics-and-colors.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Diff
Modified: trunk/LayoutTests/ChangeLog (98838 => 98839)
--- trunk/LayoutTests/ChangeLog 2011-10-31 08:28:13 UTC (rev 98838)
+++ trunk/LayoutTests/ChangeLog 2011-10-31 08:37:32 UTC (rev 98839)
@@ -1,3 +1,13 @@
+2011-10-28 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: Using keyboard to increment/decrement units is inconsistent
+https://bugs.webkit.org/show_bug.cgi?id=71119
+
+Reviewed by Pavel Feldman.
+
+* inspector/styles/up-down-numerics-and-colors-expected.txt:
+* inspector/styles/up-down-numerics-and-colors.html:
+
2011-10-31 Andrey Kosyakov ca...@chromium.org
Unreviewed. compositing/visibility/visibility-image-layers.html fails on GPU.
Modified: trunk/LayoutTests/inspector/styles/up-down-numerics-and-colors-expected.txt (98838 => 98839)
--- trunk/LayoutTests/inspector/styles/up-down-numerics-and-colors-expected.txt 2011-10-31 08:28:13 UTC (rev 98838)
+++ trunk/LayoutTests/inspector/styles/up-down-numerics-and-colors-expected.txt 2011-10-31 08:37:32 UTC (rev 98839)
@@ -9,7 +9,7 @@
color: #EE3;
Running: testAlterNumber
-opacity: 10.6;
+opacity: 11.6;
Running: testAlterBigNumber
-webkit-transform: rotate(165537deg);
Modified: trunk/LayoutTests/inspector/styles/up-down-numerics-and-colors.html (98838 => 98839)
--- trunk/LayoutTests/inspector/styles/up-down-numerics-and-colors.html 2011-10-31 08:28:13 UTC (rev 98838)
+++ trunk/LayoutTests/inspector/styles/up-down-numerics-and-colors.html 2011-10-31 08:37:32 UTC (rev 98839)
@@ -48,8 +48,13 @@
{
var opacityTreeElement = section.findTreeElementWithName(opacity);
opacityTreeElement.startEditing(opacityTreeElement.valueElement);
+// 0.5 (initial)
+opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent(Up, false, true, false)); // Alt-Up
+// 0.6
opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent(Up));
+// 1.6
opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent(PageUp));
+// 11.6
InspectorTest.addResult(opacityTreeElement.listItemElement.textContent);
next();
},
Modified: trunk/Source/WebCore/ChangeLog (98838 => 98839)
--- trunk/Source/WebCore/ChangeLog 2011-10-31 08:28:13 UTC (rev 98838)
+++ trunk/Source/WebCore/ChangeLog 2011-10-31 08:37:32 UTC (rev 98839)
@@ -1,3 +1,16 @@
+2011-10-28 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: Using keyboard to increment/decrement units is inconsistent
+https://bugs.webkit.org/show_bug.cgi?id=71119
+
+Reviewed by Pavel Feldman.
+
+This change makes the behavior consistent with that described at http://trac.webkit.org/wiki/WebInspector
+
+* inspector/front-end/StylesSidebarPane.js:
+(WebInspector.StylesSidebarPane.alteredFloatNumber):
+(WebInspector.StylesSidebarPane.prototype._attributesModified):
+
2011-10-29 Martin Robinson mrobin...@igalia.com
[GTK] Switch to a backing store approach for painting WebKitWebView
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (98838 => 98839)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-10-31 08:28:13 UTC (rev 98838)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-10-31 08:37:32 UTC (rev 98839)
@@ -133,39 +133,25 @@
WebInspector.StylesSidebarPane.alteredFloatNumber = function(number, event)
{
var arrowKeyPressed = (event.keyIdentifier === Up || event.keyIdentifier === Down);
-// If the number is near zero or the number is one and the direction will take it near zero.
-var numberNearZero = (number 1 number -1);
-if (number === 1 event.keyIdentifier === Down)
-numberNearZero = true;
-else if (number === -1 event.keyIdentifier === Up)
-numberNearZero = true;
-var result;
-if (numberNearZero
[webkit-changes] [98840] trunk/Source/WebCore
Title: [98840] trunk/Source/WebCore Revision 98840 Author pfeld...@chromium.org Date 2011-10-31 02:18:30 -0700 (Mon, 31 Oct 2011) Log Message Web Inspector: factor out ResourceUtils, clean up externs. https://bugs.webkit.org/show_bug.cgi?id=71192 Patch by Pavel Feldman pfeld...@chromium.org on 2011-10-31 Reviewed by Yury Semikhatsky. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/compile-front-end.sh: * inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl.prototype._linkifyLocation): * inspector/front-end/DebuggerPresentationModel.js: * inspector/front-end/ProfilesPanel.js: * inspector/front-end/Resource.js: (WebInspector.Resource.displayName): * inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._createResource): * inspector/front-end/ResourceUtils.js: Added. (WebInspector.resourceForURL): (WebInspector.forAllResources): (WebInspector.displayNameForURL): (WebInspector.linkifyStringAsFragmentWithCustomLinkifier): (WebInspector.registerLinkifierPlugin): (WebInspector.linkifyStringAsFragment): (WebInspector.linkifyURLAsNode): (WebInspector.linkifyURL): (WebInspector.formatLinkText): (WebInspector.linkifyResourceAsNode): (WebInspector.resourceURLForRelatedNode.callback): (WebInspector.resourceURLForRelatedNode): (WebInspector.populateHrefContextMenu): (WebInspector.completeURL): * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.selectElement): * inspector/front-end/WebKit.qrc: * inspector/front-end/externs.js: * inspector/front-end/inspector.html: * inspector/front-end/inspector.js: (WebInspector.networkResourceById): * inspector/front-end/utilities.js: (setupPrototypeUtilities.Element.prototype.selectionLeftOffset): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/compile-front-end.sh trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js trunk/Source/WebCore/inspector/front-end/Resource.js trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/externs.js trunk/Source/WebCore/inspector/front-end/inspector.html trunk/Source/WebCore/inspector/front-end/inspector.js trunk/Source/WebCore/inspector/front-end/utilities.js Added Paths trunk/Source/WebCore/inspector/front-end/ResourceUtils.js Diff Modified: trunk/Source/WebCore/ChangeLog (98839 => 98840) --- trunk/Source/WebCore/ChangeLog 2011-10-31 08:37:32 UTC (rev 98839) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 09:18:30 UTC (rev 98840) @@ -1,3 +1,46 @@ +2011-10-31 Pavel Feldman pfeld...@chromium.org + +Web Inspector: factor out ResourceUtils, clean up externs. +https://bugs.webkit.org/show_bug.cgi?id=71192 + +Reviewed by Yury Semikhatsky. + +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/compile-front-end.sh: +* inspector/front-end/ConsoleMessage.js: +(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation): +* inspector/front-end/DebuggerPresentationModel.js: +* inspector/front-end/ProfilesPanel.js: +* inspector/front-end/Resource.js: +(WebInspector.Resource.displayName): +* inspector/front-end/ResourceTreeModel.js: +(WebInspector.ResourceTreeModel.prototype._createResource): +* inspector/front-end/ResourceUtils.js: Added. +(WebInspector.resourceForURL): +(WebInspector.forAllResources): +(WebInspector.displayNameForURL): +(WebInspector.linkifyStringAsFragmentWithCustomLinkifier): +(WebInspector.registerLinkifierPlugin): +(WebInspector.linkifyStringAsFragment): +(WebInspector.linkifyURLAsNode): +(WebInspector.linkifyURL): +(WebInspector.formatLinkText): +(WebInspector.linkifyResourceAsNode): +(WebInspector.resourceURLForRelatedNode.callback): +(WebInspector.resourceURLForRelatedNode): +(WebInspector.populateHrefContextMenu): +(WebInspector.completeURL): +* inspector/front-end/StylesSidebarPane.js: +(WebInspector.StylePropertyTreeElement.prototype.selectElement): +* inspector/front-end/WebKit.qrc: +* inspector/front-end/externs.js: +* inspector/front-end/inspector.html: +* inspector/front-end/inspector.js: +(WebInspector.networkResourceById): +* inspector/front-end/utilities.js: +(setupPrototypeUtilities.Element.prototype.selectionLeftOffset): + 2011-10-28 Alexander Pavlov apav...@chromium.org Web Inspector: Using keyboard to increment/decrement units is inconsistent Modified:
[webkit-changes] [98841] trunk/LayoutTests
Title: [98841] trunk/LayoutTests Revision 98841 Author ca...@chromium.org Date 2011-10-31 02:35:58 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98840 => 98841) --- trunk/LayoutTests/ChangeLog 2011-10-31 09:18:30 UTC (rev 98840) +++ trunk/LayoutTests/ChangeLog 2011-10-31 09:35:58 UTC (rev 98841) @@ -1,3 +1,9 @@ +2011-10-31 Andrey Kosyakov ca...@chromium.org + +Unreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG. + +* platform/chromium/test_expectations.txt: + 2011-10-28 Alexander Pavlov apav...@chromium.org Web Inspector: Using keyboard to increment/decrement units is inconsistent Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98840 => 98841) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 09:18:30 UTC (rev 98840) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 09:35:58 UTC (rev 98841) @@ -3930,3 +3930,5 @@ BUGWK71181 : fast/forms/input-step-as-double.html = PASS TEXT BUGWK71209 GPU : compositing/visibility/visibility-image-layers.html = IMAGE + +BUGWK71211 GPU LINUX DEBUG : fast/canvas/shadow-offset-3.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98842] trunk/Source
Title: [98842] trunk/Source Revision 98842 Author carlo...@webkit.org Date 2011-10-31 03:26:48 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed. Fix make distcheck build. Source/WebCore: * GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST. Source/WebKit2: * GNUmakefile.am: Remove docs/GNUmakefile.in from EXTRA_DIST, since its generation was removed from configure.ac in r98498. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am Diff Modified: trunk/Source/WebCore/ChangeLog (98841 => 98842) --- trunk/Source/WebCore/ChangeLog 2011-10-31 09:35:58 UTC (rev 98841) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 10:26:48 UTC (rev 98842) @@ -1,3 +1,10 @@ +2011-10-31 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix make distcheck build. + +* GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and +EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST. + 2011-10-31 Pavel Feldman pfeld...@chromium.org Web Inspector: factor out ResourceUtils, clean up externs. Modified: trunk/Source/WebCore/GNUmakefile.am (98841 => 98842) --- trunk/Source/WebCore/GNUmakefile.am 2011-10-31 09:35:58 UTC (rev 98841) +++ trunk/Source/WebCore/GNUmakefile.am 2011-10-31 10:26:48 UTC (rev 98842) @@ -657,6 +657,7 @@ $(WebCore)/bindings/scripts/CodeGenerator.pm \ $(WebCore)/bindings/scripts/IDLParser.pm \ $(WebCore)/bindings/scripts/IDLStructure.pm \ + $(WebCore)/bindings/scripts/InFilesCompiler.pm \ $(WebCore)/bindings/scripts/InFilesParser.pm \ $(WebCore)/bindings/scripts/generate-bindings.pl \ $(WebCore)/bindings/scripts/preprocessor.pm @@ -857,20 +858,16 @@ $(shell ls $(srcdir)/Source/WebCore/xml/*.idl) \ Source/ThirdParty/ANGLE/src/compiler/glslang.l \ Source/ThirdParty/ANGLE/src/compiler/glslang.y \ - Source/WebCore/bindings/scripts/CodeGenerator.pm \ - Source/WebCore/bindings/scripts/IDLParser.pm \ - Source/WebCore/bindings/scripts/IDLStructure.pm \ - Source/WebCore/bindings/scripts/InFilesParser.pm \ - Source/WebCore/bindings/scripts/generate-bindings.pl \ - Source/WebCore/bindings/scripts/preprocessor.pm \ Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm \ Source/WebCore/bindings/scripts/CodeGeneratorJS.pm \ Source/WebCore/bindings/scripts/CodeGenerator.pm \ - Source/WebCore/bindings/scripts/generate-bindings.pl \ - Source/WebCore/bindings/scripts/gobject-generate-headers.pl \ Source/WebCore/bindings/scripts/IDLParser.pm \ Source/WebCore/bindings/scripts/IDLStructure.pm \ + Source/WebCore/bindings/scripts/InFilesCompiler.pm \ Source/WebCore/bindings/scripts/InFilesParser.pm \ + Source/WebCore/bindings/scripts/generate-bindings.pl \ + Source/WebCore/bindings/scripts/gobject-generate-headers.pl \ + Source/WebCore/bindings/scripts/preprocessor.pm \ Source/WebCore/ChangeLog \ Source/WebCore/css/CSSGrammar.y \ Source/WebCore/css/CSSPropertyNames.in \ Modified: trunk/Source/WebKit2/ChangeLog (98841 => 98842) --- trunk/Source/WebKit2/ChangeLog 2011-10-31 09:35:58 UTC (rev 98841) +++ trunk/Source/WebKit2/ChangeLog 2011-10-31 10:26:48 UTC (rev 98842) @@ -1,3 +1,10 @@ +2011-10-31 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix make distcheck build. + +* GNUmakefile.am: Remove docs/GNUmakefile.in from EXTRA_DIST, +since its generation was removed from configure.ac in r98498. + 2011-10-28 Jeff Miller je...@apple.com More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac Modified: trunk/Source/WebKit2/GNUmakefile.am (98841 => 98842) --- trunk/Source/WebKit2/GNUmakefile.am 2011-10-31 09:35:58 UTC (rev 98841) +++ trunk/Source/WebKit2/GNUmakefile.am 2011-10-31 10:26:48 UTC (rev 98842) @@ -1395,7 +1395,6 @@ $(WebKit2)/UIProcess/API/gtk/docs/webkit2gtk-sections.txt \ $(WebKit2)/UIProcess/API/gtk/docs/version.xml.in \ $(WebKit2)/UIProcess/API/gtk/docs/webkit2gtk.types \ - $(WebKit2)/UIProcess/API/gtk/docs/GNUmakefile.in \ $(WebKit2)/Scripts/generate-message-receiver.py \ $(WebKit2)/Scripts/generate-messages-header.py \ $(WebKit2)/Scripts/webkit2/__init__.py \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98843] trunk/LayoutTests
Title: [98843] trunk/LayoutTests Revision 98843 Author ca...@chromium.org Date 2011-10-31 03:28:34 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed. Removed Mac10.5 CG expectation for css2.1/20110323/block-non-replaced-width-008.htm, marked it as fail. * platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Removed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Removed Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (98842 => 98843) --- trunk/LayoutTests/ChangeLog 2011-10-31 10:26:48 UTC (rev 98842) +++ trunk/LayoutTests/ChangeLog 2011-10-31 10:28:34 UTC (rev 98843) @@ -1,5 +1,13 @@ 2011-10-31 Andrey Kosyakov ca...@chromium.org +Unreviewed. +Removed 10.5 CG expectation for css2.1/20110323/block-non-replaced-width-008.htm, marked it as fail. + +* platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Removed. +* platform/chromium/test_expectations.txt: + +2011-10-31 Andrey Kosyakov ca...@chromium.org + Unreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98842 => 98843) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 10:26:48 UTC (rev 98842) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 10:28:34 UTC (rev 98843) @@ -3932,3 +3932,4 @@ BUGWK71209 GPU : compositing/visibility/visibility-image-layers.html = IMAGE BUGWK71211 GPU LINUX DEBUG : fast/canvas/shadow-offset-3.html = PASS CRASH +BUGWK71214 LEOPARD CPU-CG : css2.1/20110323/block-non-replaced-width-008.htm = FAIL Deleted: trunk/LayoutTests/platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98844] trunk/Source/WebCore
Title: [98844] trunk/Source/WebCore
Revision 98844
Author an...@apple.com
Date 2011-10-31 04:23:34 -0700 (Mon, 31 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=71012
Use StringHasher to generate the matched declaration cache hash
Reviewed by Sam Weinig.
Make sure the MatchedStyleDeclarations are fully zero-initialized as we calculate a hash over a raw memory array of these.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
* css/CSSStyleSelector.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98843 => 98844)
--- trunk/Source/WebCore/ChangeLog 2011-10-31 10:28:34 UTC (rev 98843)
+++ trunk/Source/WebCore/ChangeLog 2011-10-31 11:23:34 UTC (rev 98844)
@@ -1,3 +1,17 @@
+2011-10-31 Antti Koivisto an...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=71012
+Use StringHasher to generate the matched declaration cache hash
+
+Reviewed by Sam Weinig.
+
+Make sure the MatchedStyleDeclarations are fully zero-initialized as we calculate a hash over a raw memory array of these.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):
+(WebCore::CSSStyleSelector::addMatchedDeclaration):
+* css/CSSStyleSelector.h:
+
2011-10-31 Carlos Garcia Campos cgar...@igalia.com
Unreviewed. Fix make distcheck build.
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (98843 => 98844)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-31 10:28:34 UTC (rev 98843)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-31 11:23:34 UTC (rev 98844)
@@ -593,9 +593,18 @@
#endif
}
-void CSSStyleSelector::addMatchedDeclaration(CSSMutableStyleDeclaration* decl, unsigned linkMatchType)
+CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration()
+{
+// Make sure all memory is zero initializes as we calculate hash over the bytes of this object.
+memset(this, 0, sizeof(*this));
+}
+
+void CSSStyleSelector::addMatchedDeclaration(CSSMutableStyleDeclaration* styleDeclaration, unsigned linkMatchType)
{
-m_matchedDecls.append(MatchedStyleDeclaration(decl, linkMatchType));
+m_matchedDecls.grow(m_matchedDecls.size() + 1);
+MatchedStyleDeclaration newDeclaration = m_matchedDecls.last();
+newDeclaration.styleDeclaration = styleDeclaration;
+newDeclaration.linkMatchType = linkMatchType;
}
void CSSStyleSelector::matchRules(RuleSet* rules, int firstRuleIndex, int lastRuleIndex, bool includeEmptyRules)
Modified: trunk/Source/WebCore/css/CSSStyleSelector.h (98843 => 98844)
--- trunk/Source/WebCore/css/CSSStyleSelector.h 2011-10-31 10:28:34 UTC (rev 98843)
+++ trunk/Source/WebCore/css/CSSStyleSelector.h 2011-10-31 11:23:34 UTC (rev 98844)
@@ -330,7 +330,7 @@
void loadPendingImages();
struct MatchedStyleDeclaration {
-MatchedStyleDeclaration(CSSMutableStyleDeclaration* decl, unsigned type) : styleDeclaration(decl), linkMatchType(type) { }
+MatchedStyleDeclaration();
CSSMutableStyleDeclaration* styleDeclaration;
unsigned linkMatchType;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98845] trunk/Source/WebKit2
Title: [98845] trunk/Source/WebKit2
Revision 98845
Author carlo...@webkit.org
Date 2011-10-31 04:45:37 -0700 (Mon, 31 Oct 2011)
Log Message
[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71109
Reviewed by Martin Robinson.
* GNUmakefile.am: Add WebKitSettingsPrivate.h.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webkitSettingsAttachSettingsToPage): Set the preferences of the
given WebKitSettings object to the page group of the given WKPage.
* UIProcess/API/gtk/WebKitSettingsPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the default WebKitSettings for
the view.
(webkit_web_view_set_settings):
(webkit_web_view_get_settings):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSettings):
(beforeAll):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp
Added Paths
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettingsPrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98844 => 98845)
--- trunk/Source/WebKit2/ChangeLog 2011-10-31 11:23:34 UTC (rev 98844)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 11:45:37 UTC (rev 98845)
@@ -1,5 +1,28 @@
2011-10-31 Carlos Garcia Campos cgar...@igalia.com
+[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=71109
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: Add WebKitSettingsPrivate.h.
+* UIProcess/API/gtk/WebKitSettings.cpp:
+(webkitSettingsAttachSettingsToPage): Set the preferences of the
+given WebKitSettings object to the page group of the given WKPage.
+* UIProcess/API/gtk/WebKitSettingsPrivate.h: Added.
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewConstructed): Create the default WebKitSettings for
+the view.
+(webkit_web_view_set_settings):
+(webkit_web_view_get_settings):
+* UIProcess/API/gtk/WebKitWebView.h:
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
+* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
+(testWebViewSettings):
+(beforeAll):
+
+2011-10-31 Carlos Garcia Campos cgar...@igalia.com
+
Unreviewed. Fix make distcheck build.
* GNUmakefile.am: Remove docs/GNUmakefile.in from EXTRA_DIST,
Modified: trunk/Source/WebKit2/GNUmakefile.am (98844 => 98845)
--- trunk/Source/WebKit2/GNUmakefile.am 2011-10-31 11:23:34 UTC (rev 98844)
+++ trunk/Source/WebKit2/GNUmakefile.am 2011-10-31 11:45:37 UTC (rev 98845)
@@ -497,6 +497,7 @@
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h \
Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp \
Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h \
+ Source/WebKit2/UIProcess/API/gtk/WebKitSettingsPrivate.h \
Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h \
Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp \
Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h \
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (98844 => 98845)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2011-10-31 11:23:34 UTC (rev 98844)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2011-10-31 11:45:37 UTC (rev 98845)
@@ -32,9 +32,8 @@
#include WebKitSettings.h
#include WebKitPrivate.h
-#include WebKit2/WKPreferences.h
+#include WebKitSettingsPrivate.h
#include WebKit2/WKRetainPtr.h
-#include WebKit2/WKType.h
#include glib/gi18n-lib.h
struct _WebKitSettingsPrivate {
@@ -380,6 +379,11 @@
priv-preferences = adoptWK(WKPreferencesCreate());
}
+void webkitSettingsAttachSettingsToPage(WebKitSettings* settings, WKPageRef wkPage)
+{
+WKPageGroupSetPreferences(WKPageGetPageGroup(wkPage), settings-priv-preferences.get());
+}
+
/**
* webkit_settings_new:
*
Added: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettingsPrivate.h (0 => 98845)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettingsPrivate.h (rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettingsPrivate.h 2011-10-31 11:45:37 UTC (rev 98845)
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2011 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *
[webkit-changes] [98846] trunk/Source/WebKit2
Title: [98846] trunk/Source/WebKit2
Revision 98846
Author carlo...@webkit.org
Date 2011-10-31 04:55:52 -0700 (Mon, 31 Oct 2011)
Log Message
[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=7
Reviewed by Martin Robinson.
Convenient method to create a WebKitSettings object with initial
settings.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_new_with_settings):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsNewWithSettings):
(beforeAll):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98845 => 98846)
--- trunk/Source/WebKit2/ChangeLog 2011-10-31 11:45:37 UTC (rev 98845)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 11:55:52 UTC (rev 98846)
@@ -1,5 +1,23 @@
2011-10-31 Carlos Garcia Campos cgar...@igalia.com
+[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=7
+
+Reviewed by Martin Robinson.
+
+Convenient method to create a WebKitSettings object with initial
+settings.
+
+* UIProcess/API/gtk/WebKitSettings.cpp:
+(webkit_settings_new_with_settings):
+* UIProcess/API/gtk/WebKitSettings.h:
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
+* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
+(testWebKitSettingsNewWithSettings):
+(beforeAll):
+
+2011-10-31 Carlos Garcia Campos cgar...@igalia.com
+
[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71109
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (98845 => 98846)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2011-10-31 11:45:37 UTC (rev 98845)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2011-10-31 11:55:52 UTC (rev 98846)
@@ -388,7 +388,8 @@
* webkit_settings_new:
*
* Creates a new #WebKitSettings instance with default values. It must
- * be manually attached to a WebView.
+ * be manually attached to a #WebKitWebView.
+ * See also webkit_settings_new_with_settings().
*
* Returns: a new #WebKitSettings instance.
*/
@@ -398,6 +399,26 @@
}
/**
+ * webkit_settings_new_with_settings:
+ * @first_setting_name: name of first setting to set
+ * @...: value of first setting, followed by more settings,
+ *%NULL-terminated
+ *
+ * Creates a new #WebKitSettings instance with the given settings. It must
+ * be manually attached to a #WebKitWebView.
+ *
+ * Returns: a new #WebKitSettings instance.
+ */
+WebKitSettings* webkit_settings_new_with_settings(const gchar* firstSettingName, ...)
+{
+va_list args;
+va_start(args, firstSettingName);
+WebKitSettings* settings = WEBKIT_SETTINGS(g_object_new_valist(WEBKIT_TYPE_SETTINGS, firstSettingName, args));
+va_end(args);
+return settings;
+}
+
+/**
* webkit_settings_get_enable_javascript:
* @settings: a #WebKitSettings
*
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h (98845 => 98846)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h 2011-10-31 11:45:37 UTC (rev 98845)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h 2011-10-31 11:55:52 UTC (rev 98846)
@@ -71,90 +71,94 @@
webkit_settings_get_type(void);
WEBKIT_API WebKitSettings *
-webkit_settings_new(void);
+webkit_settings_new(void);
+WEBKIT_API WebKitSettings *
+webkit_settings_new_with_settings (const gchar*first_setting_name,
+...);
+
WEBKIT_API gboolean
-webkit_settings_get_enable_javascript (WebKitSettings* settings);
+webkit_settings_get_enable_javascript (WebKitSettings *settings);
WEBKIT_API void
-webkit_settings_set_enable_javascript (WebKitSettings* settings,
-gboolean enabled);
+webkit_settings_set_enable_javascript (WebKitSettings *settings,
+gbooleanenabled);
WEBKIT_API gboolean
-webkit_settings_get_auto_load_images (WebKitSettings* settings);
+webkit_settings_get_auto_load_images (WebKitSettings *settings);
WEBKIT_API void
-webkit_settings_set_auto_load_images (WebKitSettings* settings,
-
[webkit-changes] [98847] trunk
Title: [98847] trunk
Revision 98847
Author pfeld...@chromium.org
Date 2011-10-31 04:55:59 -0700 (Mon, 31 Oct 2011)
Log Message
Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/bind-script-to-resource.html
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
* inspector/front-end/Script.js:
LayoutTests:
* inspector/debugger/bind-script-to-resource-expected.txt: Added.
* inspector/debugger/bind-script-to-resource.html: Added.
* inspector/debugger/linkifier.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/linkifier-expected.txt
trunk/LayoutTests/inspector/debugger/linkifier.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/Script.js
Added Paths
trunk/LayoutTests/inspector/debugger/bind-script-to-resource-expected.txt
trunk/LayoutTests/inspector/debugger/bind-script-to-resource.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98846 => 98847)
--- trunk/LayoutTests/ChangeLog 2011-10-31 11:55:52 UTC (rev 98846)
+++ trunk/LayoutTests/ChangeLog 2011-10-31 11:55:59 UTC (rev 98847)
@@ -1,3 +1,14 @@
+2011-10-31 Pavel Feldman pfeld...@google.com
+
+Web Inspector: do not map scripts generated with document.write to the document resources.
+https://bugs.webkit.org/show_bug.cgi?id=71114
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/bind-script-to-resource-expected.txt: Added.
+* inspector/debugger/bind-script-to-resource.html: Added.
+* inspector/debugger/linkifier.html:
+
2011-10-31 Andrey Kosyakov ca...@chromium.org
Unreviewed.
Added: trunk/LayoutTests/inspector/debugger/bind-script-to-resource-expected.txt (0 => 98847)
--- trunk/LayoutTests/inspector/debugger/bind-script-to-resource-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/debugger/bind-script-to-resource-expected.txt 2011-10-31 11:55:59 UTC (rev 98847)
@@ -0,0 +1,19 @@
+Tests that only inline scripts are bound to the resource, while the ones generated with document.write are not. Bug 71099
+
+Debugger was enabled.
+There should be 4 scripts:
+script1: bind-script-to-resource.html
+script2: bind-script-to-resource.html
+script3: debugger-test.js
+script4: inspector-test.js
+
+There should be 3 resources, each resource should have 1 script:
+url1 : debugger-test.js
+script: debugger-test.js
+url2 : inspector-test.js
+script: inspector-test.js
+url3 : bind-script-to-resource.html
+script: bind-script-to-resource.html
+document url:bind-script-to-resource.html
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/inspector/debugger/bind-script-to-resource-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/debugger/bind-script-to-resource.html (0 => 98847)
--- trunk/LayoutTests/inspector/debugger/bind-script-to-resource.html (rev 0)
+++ trunk/LayoutTests/inspector/debugger/bind-script-to-resource.html 2011-10-31 11:55:59 UTC (rev 98847)
@@ -0,0 +1,66 @@
+html
+head
+script src=""
+script src=""
+
+script
+
+document.write(scrip + tfunction foo() { }/sc + ript);
+
+var test = function()
+{
+var scripts = [];
+InspectorTest.startDebuggerTest(step1);
+
+function step1()
+{
+var model = WebInspector.debuggerPresentationModel;
+
+var scriptURLs = [];
+for (var scriptId in model._rawSourceCodeForScriptId) {
+var script = WebInspector.debuggerModel.scripts[scriptId];
+scriptURLs.push(WebInspector.displayNameForURL(script.sourceURL));
+}
+scriptURLs.sort();
+InspectorTest.assertEquals(4, scriptURLs.length);
+InspectorTest.addResult(There should be 4 scripts:);
+for (var i = 0; i scriptURLs.length; ++i)
+InspectorTest.addResult(script + (i+1) + : + scriptURLs[i]);
+
+var urls =
[webkit-changes] [98848] trunk/LayoutTests
Title: [98848] trunk/LayoutTests Revision 98848 Author ca...@chromium.org Date 2011-10-31 05:00:37 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98847 => 98848) --- trunk/LayoutTests/ChangeLog 2011-10-31 11:55:59 UTC (rev 98847) +++ trunk/LayoutTests/ChangeLog 2011-10-31 12:00:37 UTC (rev 98848) @@ -1,3 +1,9 @@ +2011-10-31 Andrey Kosyakov ca...@chromium.org + +Unreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG. + +* platform/chromium/test_expectations.txt: + 2011-10-31 Pavel Feldman pfeld...@google.com Web Inspector: do not map scripts generated with document.write to the document resources. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98847 => 98848) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 11:55:59 UTC (rev 98847) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 12:00:37 UTC (rev 98848) @@ -3933,3 +3933,4 @@ BUGWK71211 GPU LINUX DEBUG : fast/canvas/shadow-offset-3.html = PASS CRASH BUGWK71214 LEOPARD CPU-CG : css2.1/20110323/block-non-replaced-width-008.htm = FAIL +BUGWK71215 SNOWLEOPARD DEBUG : animations/change-keyframes.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98849] trunk/LayoutTests
Title: [98849] trunk/LayoutTests Revision 98849 Author vse...@chromium.org Date 2011-10-31 05:28:37 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html on QT. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (98848 => 98849) --- trunk/LayoutTests/ChangeLog 2011-10-31 12:00:37 UTC (rev 98848) +++ trunk/LayoutTests/ChangeLog 2011-10-31 12:28:37 UTC (rev 98849) @@ -1,3 +1,9 @@ +2011-10-31 Vsevolod Vlasov vse...@chromium.org + +Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html on QT. + +* platform/qt/Skipped: + 2011-10-31 Andrey Kosyakov ca...@chromium.org Unreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG. Modified: trunk/LayoutTests/platform/qt/Skipped (98848 => 98849) --- trunk/LayoutTests/platform/qt/Skipped 2011-10-31 12:00:37 UTC (rev 98848) +++ trunk/LayoutTests/platform/qt/Skipped 2011-10-31 12:28:37 UTC (rev 98849) @@ -2239,6 +2239,10 @@ inspector/debugger/source-frame.html inspector/styles/styles-update-from-js.html +# Test fails because script pretty-print does not work in inspector on JSC when paused on breakpoint. +# https://bugs.webkit.org/show_bug.cgi?id=71120 +inspector/debugger/selected-call-frame-after-formatting-source.html + # Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths # from Font, making it possible to reuse the simple text code path for SVG Fonts # https://bugs.webkit.org/show_bug.cgi?id=59085 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98850] trunk/Source/WebCore
Title: [98850] trunk/Source/WebCore Revision 98850 Author yu...@chromium.org Date 2011-10-31 05:45:40 -0700 (Mon, 31 Oct 2011) Log Message 2011-10-31 Yury Semikhatsky yu...@chromium.org Unreviewed. Add ResourcePreviewView.js to the list of inspector front-end files on Qt. * inspector/front-end/WebKit.qrc: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/WebKit.qrc Diff Modified: trunk/Source/WebCore/ChangeLog (98849 => 98850) --- trunk/Source/WebCore/ChangeLog 2011-10-31 12:28:37 UTC (rev 98849) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 12:45:40 UTC (rev 98850) @@ -1,3 +1,10 @@ +2011-10-31 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Add ResourcePreviewView.js to the list of inspector front-end +files on Qt. + +* inspector/front-end/WebKit.qrc: + 2011-10-31 Pavel Feldman pfeld...@google.com Web Inspector: do not map scripts generated with document.write to the document resources. Modified: trunk/Source/WebCore/inspector/front-end/WebKit.qrc (98849 => 98850) --- trunk/Source/WebCore/inspector/front-end/WebKit.qrc 2011-10-31 12:28:37 UTC (rev 98849) +++ trunk/Source/WebCore/inspector/front-end/WebKit.qrc 2011-10-31 12:45:40 UTC (rev 98850) @@ -98,6 +98,7 @@ fileResourceJSONView.js/file fileResourceHTMLView.js/file fileResourceHeadersView.js/file +fileResourcePreviewView.js/file fileResourceResponseView.js/file fileResourceTimingView.js/file fileResourceTreeModel.js/file ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98854] trunk/Tools
Title: [98854] trunk/Tools Revision 98854 Author kenn...@webkit.org Date 2011-10-31 07:15:09 -0700 (Mon, 31 Oct 2011) Log Message [Qt] MiniBrowser doesn't resize as the size is always overridden https://bugs.webkit.org/show_bug.cgi?id=71212 Reviewed by Simon Hausmann. Remove call overriden the size. * MiniBrowser/qt/main.cpp: (main): Modified Paths trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/qt/main.cpp Diff Modified: trunk/Tools/ChangeLog (98853 => 98854) --- trunk/Tools/ChangeLog 2011-10-31 14:13:14 UTC (rev 98853) +++ trunk/Tools/ChangeLog 2011-10-31 14:15:09 UTC (rev 98854) @@ -1,3 +1,15 @@ +2011-10-31 Kenneth Rohde Christiansen kenn...@webkit.org + +[Qt] MiniBrowser doesn't resize as the size is always overridden +https://bugs.webkit.org/show_bug.cgi?id=71212 + +Reviewed by Simon Hausmann. + +Remove call overriden the size. + +* MiniBrowser/qt/main.cpp: +(main): + 2011-10-30 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r98819, r98823, r98825, and r98830. Modified: trunk/Tools/MiniBrowser/qt/main.cpp (98853 => 98854) --- trunk/Tools/MiniBrowser/qt/main.cpp 2011-10-31 14:13:14 UTC (rev 98853) +++ trunk/Tools/MiniBrowser/qt/main.cpp 2011-10-31 14:15:09 UTC (rev 98854) @@ -61,7 +61,6 @@ BrowserWindow* window = new BrowserWindow(app.m_windowOptions); window-load(urls.at(0)); -window-setGeometry(100, 100, 800, 600); for (int i = 1; i urls.size(); ++i) window-newWindow(urls.at(i)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98855] trunk/Source
Title: [98855] trunk/Source Revision 98855 Author pfeld...@chromium.org Date 2011-10-31 07:32:40 -0700 (Mon, 31 Oct 2011) Log Message Web Inspector: move localization support into UIUtil.js, reduce externs. https://bugs.webkit.org/show_bug.cgi?id=71220 Reviewed by Yury Semikhatsky. Source/WebCore: * inspector/compile-front-end.sh: * inspector/front-end/AdvancedSearchController.js: (WebInspector.SearchView.prototype.focus): * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.afterShow): * inspector/front-end/Drawer.js: * inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._hide): * inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen.prototype.show): (WebInspector.HelpScreen.prototype.hide): (WebInspector.HelpScreen.prototype._onBlur): * inspector/front-end/InspectorFrontendHostStub.js: * inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut._keyName): * inspector/front-end/Panel.js: (WebInspector.Panel.prototype.wasShown): * inspector/front-end/SearchController.js: (WebInspector.SearchController.prototype._onSearchFieldManualFocus): (WebInspector.SearchController.prototype._onKeyDown): * inspector/front-end/Settings.js: * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): * inspector/front-end/Toolbar.js: (WebInspector.Toolbar.prototype._toolbarDragStart): * inspector/front-end/UIUtils.js: (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing.var): (WebInspector.startEditing): (WebInspector.UIString): (WebInspector.useLowerCaseMenuTitles): (WebInspector.platform): (WebInspector.isMac): (WebInspector.platformFlavor): (WebInspector.port): (WebInspector.installPortStyles): (WebInspector._windowFocused): (WebInspector._windowBlurred): (WebInspector.previousFocusElement): (WebInspector.currentFocusElement): (WebInspector._focusChanged): (WebInspector.setCurrentFocusElement): * inspector/front-end/externs.js: (Event.prototype.initWebKitWheelEvent): (window.getComputedStyle): (InspectorBackend.runAfterPendingDispatches): * inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.addMainEventListeners): Source/WebKit/chromium: * src/js/DevTools.js: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/compile-front-end.sh trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js trunk/Source/WebCore/inspector/front-end/ConsoleView.js trunk/Source/WebCore/inspector/front-end/Drawer.js trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js trunk/Source/WebCore/inspector/front-end/HelpScreen.js trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js trunk/Source/WebCore/inspector/front-end/KeyboardShortcut.js trunk/Source/WebCore/inspector/front-end/Panel.js trunk/Source/WebCore/inspector/front-end/SearchController.js trunk/Source/WebCore/inspector/front-end/Settings.js trunk/Source/WebCore/inspector/front-end/SourceFrame.js trunk/Source/WebCore/inspector/front-end/Toolbar.js trunk/Source/WebCore/inspector/front-end/UIUtils.js trunk/Source/WebCore/inspector/front-end/externs.js trunk/Source/WebCore/inspector/front-end/inspector.js trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/js/DevTools.js Diff Modified: trunk/Source/WebCore/ChangeLog (98854 => 98855) --- trunk/Source/WebCore/ChangeLog 2011-10-31 14:15:09 UTC (rev 98854) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 14:32:40 UTC (rev 98855) @@ -1,3 +1,60 @@ +2011-10-31 Pavel Feldman pfeld...@google.com + +Web Inspector: move localization support into UIUtil.js, reduce externs. +https://bugs.webkit.org/show_bug.cgi?id=71220 + +Reviewed by Yury Semikhatsky. + +* inspector/compile-front-end.sh: +* inspector/front-end/AdvancedSearchController.js: +(WebInspector.SearchView.prototype.focus): +* inspector/front-end/ConsoleView.js: +(WebInspector.ConsoleView.prototype.afterShow): +* inspector/front-end/Drawer.js: +* inspector/front-end/GoToLineDialog.js: +(WebInspector.GoToLineDialog.prototype._hide): +* inspector/front-end/HelpScreen.js: +(WebInspector.HelpScreen.prototype.show): +(WebInspector.HelpScreen.prototype.hide): +(WebInspector.HelpScreen.prototype._onBlur): +* inspector/front-end/InspectorFrontendHostStub.js: +* inspector/front-end/KeyboardShortcut.js: +(WebInspector.KeyboardShortcut._keyName): +* inspector/front-end/Panel.js: +(WebInspector.Panel.prototype.wasShown): +* inspector/front-end/SearchController.js: +(WebInspector.SearchController.prototype._onSearchFieldManualFocus): +(WebInspector.SearchController.prototype._onKeyDown): +* inspector/front-end/Settings.js: +* inspector/front-end/SourceFrame.js: +(WebInspector.SourceFrame): +* inspector/front-end/Toolbar.js: +
[webkit-changes] [98857] trunk/Source/WebCore
Title: [98857] trunk/Source/WebCore Revision 98857 Author pfeld...@chromium.org Date 2011-10-31 08:29:38 -0700 (Mon, 31 Oct 2011) Log Message 2011-10-31 Pavel Feldman pfeld...@google.com Not reviewed: reorder inspector js files to fix remote mode. * inspector/front-end/inspector.html: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/inspector.html Diff Modified: trunk/Source/WebCore/ChangeLog (98856 => 98857) --- trunk/Source/WebCore/ChangeLog 2011-10-31 15:09:02 UTC (rev 98856) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 15:29:38 UTC (rev 98857) @@ -1,3 +1,9 @@ +2011-10-31 Pavel Feldman pfeld...@google.com + +Not reviewed: reorder inspector js files to fix remote mode. + +* inspector/front-end/inspector.html: + 2011-10-28 Alexander Pavlov apav...@chromium.org Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management Modified: trunk/Source/WebCore/inspector/front-end/inspector.html (98856 => 98857) --- trunk/Source/WebCore/inspector/front-end/inspector.html 2011-10-31 15:09:02 UTC (rev 98856) +++ trunk/Source/WebCore/inspector/front-end/inspector.html 2011-10-31 15:29:38 UTC (rev 98857) @@ -41,10 +41,10 @@ script type=text/_javascript_ src="" script type=text/_javascript_ src="" script type=text/_javascript_ src="" -script type=text/_javascript_ src="" script type=text/_javascript_ src="" script type=text/_javascript_ src="" script type=text/_javascript_ src="" +script type=text/_javascript_ src="" script type=text/_javascript_ src="" script type=text/_javascript_ src="" script type=text/_javascript_ src="" ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98859] trunk/Source/WebCore
Title: [98859] trunk/Source/WebCore Revision 98859 Author andreas.kl...@nokia.com Date 2011-10-31 08:53:14 -0700 (Mon, 31 Oct 2011) Log Message CSSRule: Devirtualize type() and isFooRule() https://bugs.webkit.org/show_bug.cgi?id=71221 Reviewed by Antti Koivisto. Store the rule type in a CSSRule member (packed with the parent-is-rule flag) and let the isFooRule() functions return type() == FOO_TYPE. CSSPageRule will no longer return true for isStyleRule(), tweaked call sites accordingly. * css/CSSCharsetRule.cpp: (WebCore::CSSCharsetRule::CSSCharsetRule): * css/CSSCharsetRule.h: * css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::CSSFontFaceRule): * css/CSSFontFaceRule.h: * css/CSSImportRule.cpp: (WebCore::CSSImportRule::CSSImportRule): * css/CSSImportRule.h: * css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule): * css/CSSMediaRule.h: * css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): * css/CSSPageRule.h: * css/CSSRegionStyleRule.cpp: (WebCore::CSSRegionStyleRule::CSSRegionStyleRule): * css/CSSRegionStyleRule.h: * css/CSSRule.h: (WebCore::CSSRule::type): (WebCore::CSSRule::isCharsetRule): (WebCore::CSSRule::isFontFaceRule): (WebCore::CSSRule::isKeyframeRule): (WebCore::CSSRule::isKeyframesRule): (WebCore::CSSRule::isMediaRule): (WebCore::CSSRule::isPageRule): (WebCore::CSSRule::isStyleRule): (WebCore::CSSRule::isRegionStyleRule): (WebCore::CSSRule::isImportRule): (WebCore::CSSRule::CSSRule): * css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule): * css/CSSStyleRule.h: * css/CSSStyleSelector.cpp: (WebCore::RuleSet::addPageRule): (WebCore::RuleSet::addRulesFromSheet): (WebCore::RuleSet::addStyleRule): * css/CSSUnknownRule.h: (WebCore::CSSUnknownRule::CSSUnknownRule): * css/WebKitCSSKeyframeRule.cpp: (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule): * css/WebKitCSSKeyframeRule.h: * css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule): * css/WebKitCSSKeyframesRule.h: * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::asCSSStyleRule): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSCharsetRule.cpp trunk/Source/WebCore/css/CSSCharsetRule.h trunk/Source/WebCore/css/CSSFontFaceRule.cpp trunk/Source/WebCore/css/CSSFontFaceRule.h trunk/Source/WebCore/css/CSSImportRule.cpp trunk/Source/WebCore/css/CSSImportRule.h trunk/Source/WebCore/css/CSSMediaRule.cpp trunk/Source/WebCore/css/CSSMediaRule.h trunk/Source/WebCore/css/CSSPageRule.cpp trunk/Source/WebCore/css/CSSPageRule.h trunk/Source/WebCore/css/CSSRegionStyleRule.cpp trunk/Source/WebCore/css/CSSRegionStyleRule.h trunk/Source/WebCore/css/CSSRule.h trunk/Source/WebCore/css/CSSStyleRule.cpp trunk/Source/WebCore/css/CSSStyleRule.h trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/css/CSSUnknownRule.h trunk/Source/WebCore/css/WebKitCSSKeyframeRule.cpp trunk/Source/WebCore/css/WebKitCSSKeyframeRule.h trunk/Source/WebCore/css/WebKitCSSKeyframesRule.cpp trunk/Source/WebCore/css/WebKitCSSKeyframesRule.h trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98858 => 98859) --- trunk/Source/WebCore/ChangeLog 2011-10-31 15:49:04 UTC (rev 98858) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 15:53:14 UTC (rev 98859) @@ -1,3 +1,64 @@ +2011-10-31 Andreas Kling kl...@webkit.org + +CSSRule: Devirtualize type() and isFooRule() +https://bugs.webkit.org/show_bug.cgi?id=71221 + +Reviewed by Antti Koivisto. + +Store the rule type in a CSSRule member (packed with the parent-is-rule flag) +and let the isFooRule() functions return type() == FOO_TYPE. + +CSSPageRule will no longer return true for isStyleRule(), tweaked call sites +accordingly. + +* css/CSSCharsetRule.cpp: +(WebCore::CSSCharsetRule::CSSCharsetRule): +* css/CSSCharsetRule.h: +* css/CSSFontFaceRule.cpp: +(WebCore::CSSFontFaceRule::CSSFontFaceRule): +* css/CSSFontFaceRule.h: +* css/CSSImportRule.cpp: +(WebCore::CSSImportRule::CSSImportRule): +* css/CSSImportRule.h: +* css/CSSMediaRule.cpp: +(WebCore::CSSMediaRule::CSSMediaRule): +* css/CSSMediaRule.h: +* css/CSSPageRule.cpp: +(WebCore::CSSPageRule::CSSPageRule): +* css/CSSPageRule.h: +* css/CSSRegionStyleRule.cpp: +(WebCore::CSSRegionStyleRule::CSSRegionStyleRule): +* css/CSSRegionStyleRule.h: +* css/CSSRule.h: +(WebCore::CSSRule::type): +(WebCore::CSSRule::isCharsetRule): +(WebCore::CSSRule::isFontFaceRule): +(WebCore::CSSRule::isKeyframeRule): +(WebCore::CSSRule::isKeyframesRule): +(WebCore::CSSRule::isMediaRule): +(WebCore::CSSRule::isPageRule): +(WebCore::CSSRule::isStyleRule): +(WebCore::CSSRule::isRegionStyleRule): +(WebCore::CSSRule::isImportRule): +(WebCore::CSSRule::CSSRule): +*
[webkit-changes] [98860] trunk
Title: [98860] trunk
Revision 98860
Author ann...@chromium.org
Date 2011-10-31 09:35:56 -0700 (Mon, 31 Oct 2011)
Log Message
Implement load notification and events for track.
https://bugs.webkit.org/show_bug.cgi?id=71054
Reviewed by Eric Carlson.
Source/WebCore:
Tests: media/track/track-load-error-readyState.html
media/track/track-load-from-element-readyState.html
media/track/track-load-from-src-readyState.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):
* html/HTMLMediaElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):
* html/HTMLTrackElement.h:
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::cueLoadingCompleted):
LayoutTests:
* media/track/track-load-error-readyState-expected.txt: Added.
* media/track/track-load-error-readyState.html: Added.
* media/track/track-load-from-element-readyState-expected.txt: Added.
* media/track/track-load-from-element-readyState.html: Added.
* media/track/track-load-from-src-readyState-expected.txt: Added.
* media/track/track-load-from-src-readyState.html: Added.
* platform/mac/Skipped:
* platform/win/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLTrackElement.cpp
trunk/Source/WebCore/html/HTMLTrackElement.h
trunk/Source/WebCore/html/LoadableTextTrack.cpp
Added Paths
trunk/LayoutTests/media/track/track-load-error-readyState-expected.txt
trunk/LayoutTests/media/track/track-load-error-readyState.html
trunk/LayoutTests/media/track/track-load-from-element-readyState-expected.txt
trunk/LayoutTests/media/track/track-load-from-element-readyState.html
trunk/LayoutTests/media/track/track-load-from-src-readyState-expected.txt
trunk/LayoutTests/media/track/track-load-from-src-readyState.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98859 => 98860)
--- trunk/LayoutTests/ChangeLog 2011-10-31 15:53:14 UTC (rev 98859)
+++ trunk/LayoutTests/ChangeLog 2011-10-31 16:35:56 UTC (rev 98860)
@@ -1,3 +1,19 @@
+2011-10-31 Anna Cavender ann...@chromium.org
+
+Implement load notification and events for track.
+https://bugs.webkit.org/show_bug.cgi?id=71054
+
+Reviewed by Eric Carlson.
+
+* media/track/track-load-error-readyState-expected.txt: Added.
+* media/track/track-load-error-readyState.html: Added.
+* media/track/track-load-from-element-readyState-expected.txt: Added.
+* media/track/track-load-from-element-readyState.html: Added.
+* media/track/track-load-from-src-readyState-expected.txt: Added.
+* media/track/track-load-from-src-readyState.html: Added.
+* platform/mac/Skipped:
+* platform/win/Skipped:
+
2011-10-31 Nikolas Zimmermann nzimmerm...@rim.com
CSS 2.1 failure: background-intrinsic-*
Added: trunk/LayoutTests/media/track/track-load-error-readyState-expected.txt (0 => 98860)
--- trunk/LayoutTests/media/track/track-load-error-readyState-expected.txt (rev 0)
+++ trunk/LayoutTests/media/track/track-load-error-readyState-expected.txt 2011-10-31 16:35:56 UTC (rev 98860)
@@ -0,0 +1,6 @@
+Tests the error event on HTMLTrackElement and ERROR readyState on TextTrack.
+
+EVENT(error)
+EXPECTED (track.track.readyState == '3') OK
+END OF TEST
+
Property changes on: trunk/LayoutTests/media/track/track-load-error-readyState-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/media/track/track-load-error-readyState.html (0 => 98860)
--- trunk/LayoutTests/media/track/track-load-error-readyState.html (rev 0)
+++ trunk/LayoutTests/media/track/track-load-error-readyState.html 2011-10-31 16:35:56 UTC (rev 98860)
@@ -0,0 +1,26 @@
+!DOCTYPE html
+html
+head
+meta http-equiv=Content-Type content=text/html; charset=utf-8 /
+
+script src=""
+script src=""
+script
+
+function trackError()
+{
+consoleWrite(EVENT(error));
+track = document.getElementById('testTrackError');
+testExpected(track.track.readyState, TextTrack.Error);
+endTest();
+}
+
+/script
+/head
+body
+pTests the error event on HTMLTrackElement and ERROR readyState on TextTrack./p
+video id=videotests
+track id=testTrackError src="" _onerror_=trackError()
+/video
+/body
+/html
Property changes on:
[webkit-changes] [98861] trunk/Source/WebCore
Title: [98861] trunk/Source/WebCore
Revision 98861
Author andreas.kl...@nokia.com
Date 2011-10-31 10:02:49 -0700 (Mon, 31 Oct 2011)
Log Message
CSSRule: Devirtualize insertedIntoParent()
https://bugs.webkit.org/show_bug.cgi?id=71223
Reviewed by Antti Koivisto.
Moved insertedIntoParent() down into CSSImportRule and renamed it to
requestStyleSheet(). CSSImportRule is the only user of this function.
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::requestStyleSheet):
* css/CSSImportRule.h:
* css/CSSRule.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insertRule):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSImportRule.cpp
trunk/Source/WebCore/css/CSSImportRule.h
trunk/Source/WebCore/css/CSSRule.h
trunk/Source/WebCore/css/CSSStyleSheet.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98860 => 98861)
--- trunk/Source/WebCore/ChangeLog 2011-10-31 16:35:56 UTC (rev 98860)
+++ trunk/Source/WebCore/ChangeLog 2011-10-31 17:02:49 UTC (rev 98861)
@@ -1,3 +1,21 @@
+2011-10-31 Andreas Kling kl...@webkit.org
+
+CSSRule: Devirtualize insertedIntoParent()
+https://bugs.webkit.org/show_bug.cgi?id=71223
+
+Reviewed by Antti Koivisto.
+
+Moved insertedIntoParent() down into CSSImportRule and renamed it to
+requestStyleSheet(). CSSImportRule is the only user of this function.
+
+* css/CSSImportRule.cpp:
+(WebCore::CSSImportRule::requestStyleSheet):
+* css/CSSImportRule.h:
+* css/CSSRule.h:
+* css/CSSStyleSheet.cpp:
+(WebCore::CSSStyleSheet::append):
+(WebCore::CSSStyleSheet::insertRule):
+
2011-10-31 Anna Cavender ann...@chromium.org
Implement load notification and events for track.
Modified: trunk/Source/WebCore/css/CSSImportRule.cpp (98860 => 98861)
--- trunk/Source/WebCore/css/CSSImportRule.cpp 2011-10-31 16:35:56 UTC (rev 98860)
+++ trunk/Source/WebCore/css/CSSImportRule.cpp 2011-10-31 17:02:49 UTC (rev 98861)
@@ -109,7 +109,7 @@
return m_loading || (m_styleSheet m_styleSheet-isLoading());
}
-void CSSImportRule::insertedIntoParent()
+void CSSImportRule::requestStyleSheet()
{
CSSStyleSheet* parentSheet = parentStyleSheet();
if (!parentSheet || !parentSheet-document())
Modified: trunk/Source/WebCore/css/CSSImportRule.h (98860 => 98861)
--- trunk/Source/WebCore/css/CSSImportRule.h 2011-10-31 16:35:56 UTC (rev 98860)
+++ trunk/Source/WebCore/css/CSSImportRule.h 2011-10-31 17:02:49 UTC (rev 98861)
@@ -54,11 +54,11 @@
virtual void addSubresourceStyleURLs(ListHashSetKURL urls);
+void requestStyleSheet();
+
private:
CSSImportRule(CSSStyleSheet* parent, const String href, PassRefPtrMediaList);
-virtual void insertedIntoParent();
-
// from CachedResourceClient
virtual void setCSSStyleSheet(const String href, const KURL baseURL, const String charset, const CachedCSSStyleSheet*);
Modified: trunk/Source/WebCore/css/CSSRule.h (98860 => 98861)
--- trunk/Source/WebCore/css/CSSRule.h 2011-10-31 16:35:56 UTC (rev 98860)
+++ trunk/Source/WebCore/css/CSSRule.h 2011-10-31 17:02:49 UTC (rev 98861)
@@ -96,8 +96,6 @@
virtual void addSubresourceStyleURLs(ListHashSetKURL) { }
-virtual void insertedIntoParent() { }
-
KURL baseURL() const
{
if (CSSStyleSheet* parentSheet = parentStyleSheet())
Modified: trunk/Source/WebCore/css/CSSStyleSheet.cpp (98860 => 98861)
--- trunk/Source/WebCore/css/CSSStyleSheet.cpp 2011-10-31 16:35:56 UTC (rev 98860)
+++ trunk/Source/WebCore/css/CSSStyleSheet.cpp 2011-10-31 17:02:49 UTC (rev 98861)
@@ -88,7 +88,8 @@
{
CSSRule* c = child.get();
m_children.append(child);
-c-insertedIntoParent();
+if (c-isImportRule())
+static_castCSSImportRule*(c)-requestStyleSheet();
}
void CSSStyleSheet::remove(unsigned index)
@@ -136,7 +137,8 @@
CSSRule* c = r.get();
m_children.insert(index, r.release());
-c-insertedIntoParent();
+if (c-isImportRule())
+static_castCSSImportRule*(c)-requestStyleSheet();
styleSheetChanged();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98864] trunk/Source/WebKit/gtk
Title: [98864] trunk/Source/WebKit/gtk Revision 98864 Author carlo...@webkit.org Date 2011-10-31 10:43:06 -0700 (Mon, 31 Oct 2011) Log Message [GTK] Install html and tmpl dirs in a $(DOC_MODULE) dir in tarball https://bugs.webkit.org/show_bug.cgi?id=71224 Reviewed by Martin Robinson. * GNUmakefile.gtk-doc.am: Copy html and tmpl dirs to $(distdir)/$(DOC_MODULE). Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/GNUmakefile.gtk-doc.am Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (98863 => 98864) --- trunk/Source/WebKit/gtk/ChangeLog 2011-10-31 17:38:27 UTC (rev 98863) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-10-31 17:43:06 UTC (rev 98864) @@ -1,3 +1,13 @@ +2011-10-31 Carlos Garcia Campos cgar...@igalia.com + +[GTK] Install html and tmpl dirs in a $(DOC_MODULE) dir in tarball +https://bugs.webkit.org/show_bug.cgi?id=71224 + +Reviewed by Martin Robinson. + +* GNUmakefile.gtk-doc.am: Copy html and tmpl dirs to +$(distdir)/$(DOC_MODULE). + 2011-10-29 Martin Robinson mrobin...@igalia.com [GTK] Switch to a backing store approach for painting WebKitWebView Modified: trunk/Source/WebKit/gtk/GNUmakefile.gtk-doc.am (98863 => 98864) --- trunk/Source/WebKit/gtk/GNUmakefile.gtk-doc.am 2011-10-31 17:38:27 UTC (rev 98863) +++ trunk/Source/WebKit/gtk/GNUmakefile.gtk-doc.am 2011-10-31 17:43:06 UTC (rev 98864) @@ -196,13 +196,13 @@ dist-hook: doc-dist-hook doc-dist-hook: dist-check-gtkdoc dist-hook-local - @mkdir $(distdir)/tmpl - @mkdir $(distdir)/html - @-cp ./Documentation/tmpl/*.sgml $(distdir)/tmpl - @cp ./Documentation/html/* $(distdir)/html + @mkdir -p $(distdir)/$(DOC_MODULE)/tmpl + @mkdir -p $(distdir)/$(DOC_MODULE)/html + @-cp ./Documentation/tmpl/*.sgml $(distdir)/$(DOC_MODULE)/tmpl + @cp ./Documentation/html/* $(distdir)/$(DOC_MODULE)/html @-cp ./Documentation/$(DOC_MODULE).types $(distdir)/ @-cp ./Documentation/$(DOC_MODULE)-sections.txt $(distdir)/ @cd $(distdir) rm -f $(DISTCLEANFILES) - @$(GTKDOC_REBASE) --online --relative --html-dir=$(distdir)/html + @$(GTKDOC_REBASE) --online --relative --html-dir=$(distdir)/$(DOC_MODULE)/html .PHONY : dist-hook-local docs ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98865] trunk/LayoutTests
Title: [98865] trunk/LayoutTests
Revision 98865
Author john...@google.com
Date 2011-10-31 10:46:17 -0700 (Mon, 31 Oct 2011)
Log Message
Unreviewed, expectations for fast/js tests.
* platform/chromium/fast/js/regexp-caching-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium/fast/js/regexp-caching-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98864 => 98865)
--- trunk/LayoutTests/ChangeLog 2011-10-31 17:43:06 UTC (rev 98864)
+++ trunk/LayoutTests/ChangeLog 2011-10-31 17:46:17 UTC (rev 98865)
@@ -1,3 +1,10 @@
+2011-10-31 John Gregg john...@google.com
+
+Unreviewed, expectations for fast/js tests.
+
+* platform/chromium/fast/js/regexp-caching-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
2011-10-31 Andrey Kosyakov ca...@chromium.org
Unreviewed tests rebaseline following r98852.
Added: trunk/LayoutTests/platform/chromium/fast/js/regexp-caching-expected.txt (0 => 98865)
--- trunk/LayoutTests/platform/chromium/fast/js/regexp-caching-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/js/regexp-caching-expected.txt 2011-10-31 17:46:17 UTC (rev 98865)
@@ -0,0 +1,95 @@
+This test checks our implementation of the special RegExp member variables.
+
+Properties of RegExp at startup:
+$1: {} (read-only)
+$2: {} (read-only)
+$3: {} (read-only)
+$4: {} (read-only)
+$5: {} (read-only)
+$6: {} (read-only)
+$7: {} (read-only)
+$8: {} (read-only)
+$9: {} (read-only)
+input: {} (read-write)
+lastMatch: {} (read-only)
+lastParen: {} (read-only)
+leftContext: {} (read-only)
+multiline: {false} (read-write)
+rightContext: {} (read-only)
+
+Properties of RegExp after /(1)(2)(3)(4)(5)(6)(7)(8)(9)(0)/.exec(1234567890):
+$1: {1}
+$2: {2}
+$3: {3}
+$4: {4}
+$5: {5}
+$6: {6}
+$7: {7}
+$8: {8}
+$9: {9}
+input: {1234567890}
+lastMatch: {1234567890}
+lastParen: {0}
+leftContext: {}
+multiline: {false}
+rightContext: {}
+
+RegExp.$0 does not exist
+RegExp.$10 does not exist
+RegExp uses RegExp.input
+RegExp.multiline coerces values to booleans
+RegExp.input coerces values to strings
+
+Properties of RegExp after /(1)(2)(3)(4)(5)(6)(7)(8)(9)(0)/.exec(XXX):
+$1: {1}
+$2: {2}
+$3: {3}
+$4: {4}
+$5: {5}
+$6: {6}
+$7: {7}
+$8: {8}
+$9: {9}
+input: {0}
+lastMatch: {1234567890}
+lastParen: {0}
+leftContext: {}
+multiline: {true}
+rightContext: {}
+
+-- [Cleared RegExp values] --
+Properties of RegExp after 1234567890.search(/(1)(2)(3)(4)(5)(6)(7)(8)(9)(0)/):
+$1: {1}
+$2: {2}
+$3: {3}
+$4: {4}
+$5: {5}
+$6: {6}
+$7: {7}
+$8: {8}
+$9: {9}
+input: {1234567890}
+lastMatch: {1234567890}
+lastParen: {0}
+leftContext: {}
+multiline: {true}
+rightContext: {}
+
+-- [Cleared RegExp values] --
+Properties of RegExp after 1234567890.replace(/(1)(2)(3)(4)(5)(6)(7)(8)(9)(0)/):
+$1: {1}
+$2: {2}
+$3: {3}
+$4: {4}
+$5: {5}
+$6: {6}
+$7: {7}
+$8: {8}
+$9: {9}
+input: {1234567890}
+lastMatch: {1234567890}
+lastParen: {0}
+leftContext: {}
+multiline: {true}
+rightContext: {}
+
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98864 => 98865)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 17:43:06 UTC (rev 98864)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 17:46:17 UTC (rev 98865)
@@ -3922,6 +3922,8 @@
BUGWK71127 : fast/js/array-functions-non-arrays.html = TEXT
BUGWK71127 : fast/js/toString-overrides.html = TEXT
BUGWK71127 : fast/js/toString-recursion.html = TEXT
+BUGWK71127 : fast/js/kde/RegExp.html = TEXT
+BUGWK71127 : fast/js/exception-sequencing-binops2.html = TEXT
BUGWK71139 SNOWLEOPARD : http/tests/security/cross-frame-access-custom.html = CRASH PASS
BUGWK71139 SNOWLEOPARD : fast/frames/content-opacity-2.html = CRASH PASS
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98866] trunk/LayoutTests
Title: [98866] trunk/LayoutTests Revision 98866 Author ca...@chromium.org Date 2011-10-31 10:54:08 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed. Marked tests as failing after r98852. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98865 => 98866) --- trunk/LayoutTests/ChangeLog 2011-10-31 17:46:17 UTC (rev 98865) +++ trunk/LayoutTests/ChangeLog 2011-10-31 17:54:08 UTC (rev 98866) @@ -1,3 +1,9 @@ +2011-10-31 Andrey Kosyakov ca...@chromium.org + +Unreviewed. Marked tests as failing after r98852. + +* platform/chromium/test_expectations.txt: + 2011-10-31 John Gregg john...@google.com Unreviewed, expectations for fast/js tests. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98865 => 98866) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 17:46:17 UTC (rev 98865) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 17:54:08 UTC (rev 98866) @@ -1575,7 +1575,6 @@ // Disable these while we're back to using GDI for text drawing. These give slightly // different results than with Skia. When we switch back to Skia, we can // reenable these. -BUGCR99500 WIN : svg/as-background-image/animated-svg-as-background.html = IMAGE BUGCR99500 WIN : svg/batik/text/textStyles.svg = IMAGE BUGCR99500 WIN : svg/custom/simple-text-double-shadow.svg = IMAGE @@ -3936,3 +3935,7 @@ BUGWK71211 GPU LINUX DEBUG : fast/canvas/shadow-offset-3.html = PASS CRASH BUGWK71214 LEOPARD CPU-CG : css2.1/20110323/block-non-replaced-width-008.htm = FAIL BUGWK71215 SNOWLEOPARD DEBUG : animations/change-keyframes.html = TEXT + +BUGWK71226 : svg/as-background-image/animated-svg-as-background.html = IMAGE +BUGWK71226 : svg/zoom/page/zoom-coords-viewattr-01-b.svg = IMAGE+TEXT +BUGWK71226 : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98869] branches/subpixellayout/Source/WebCore
Title: [98869] branches/subpixellayout/Source/WebCore
Revision 98869
Author le...@chromium.org
Date 2011-10-31 12:06:13 -0700 (Mon, 31 Oct 2011)
Log Message
Adding explicit FixedRect constructors to IntRect. Previously, FixedRect-IntRect went through FloatRect, which lost precision and caused overflow in some cases. Fixing some scrollbar paint issues on Mac.
Modified Paths
branches/subpixellayout/Source/WebCore/page/mac/FrameMac.mm
branches/subpixellayout/Source/WebCore/platform/graphics/FixedPoint.h
branches/subpixellayout/Source/WebCore/platform/graphics/IntRect.cpp
branches/subpixellayout/Source/WebCore/platform/graphics/IntRect.h
branches/subpixellayout/Source/WebCore/platform/mac/WidgetMac.mm
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderScrollbarPart.cpp
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGText.cpp
branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/page/mac/FrameMac.mm (98868 => 98869)
--- branches/subpixellayout/Source/WebCore/page/mac/FrameMac.mm 2011-10-31 18:54:42 UTC (rev 98868)
+++ branches/subpixellayout/Source/WebCore/page/mac/FrameMac.mm 2011-10-31 19:06:13 UTC (rev 98869)
@@ -79,7 +79,7 @@
GraphicsContext graphicsContext((CGContextRef)[[NSGraphicsContext currentContext] graphicsPort]);
graphicsContext.save();
graphicsContext.translate(-rect.origin.x, -rect.origin.y);
-m_view-paintContents(graphicsContext, IntRect(rect));
+m_view-paintContents(graphicsContext, FixedRect(rect));
graphicsContext.restore();
[resultImage unlockFocus];
Modified: branches/subpixellayout/Source/WebCore/platform/graphics/FixedPoint.h (98868 => 98869)
--- branches/subpixellayout/Source/WebCore/platform/graphics/FixedPoint.h 2011-10-31 18:54:42 UTC (rev 98868)
+++ branches/subpixellayout/Source/WebCore/platform/graphics/FixedPoint.h 2011-10-31 19:06:13 UTC (rev 98869)
@@ -229,6 +229,11 @@
return FixedSize(a.x(), a.y());
}
+inline IntPoint flooredIntPoint(const FixedPoint point)
+{
+return IntPoint(point.x().toInt(), point.y().toInt());
+}
+
inline IntPoint roundedIntPoint(const FixedPoint point)
{
return IntPoint(point.x().round(), point.y().round());
Modified: branches/subpixellayout/Source/WebCore/platform/graphics/IntRect.cpp (98868 => 98869)
--- branches/subpixellayout/Source/WebCore/platform/graphics/IntRect.cpp 2011-10-31 18:54:42 UTC (rev 98868)
+++ branches/subpixellayout/Source/WebCore/platform/graphics/IntRect.cpp 2011-10-31 19:06:13 UTC (rev 98869)
@@ -26,6 +26,7 @@
#include config.h
#include IntRect.h
+#include FixedRect.h
#include FloatRect.h
#include algorithm
@@ -40,6 +41,12 @@
{
}
+IntRect::IntRect(const FixedRect r)
+: m_location(flooredIntPoint(r.location()))
+, m_size(flooredIntSize(r.size()))
+{
+}
+
bool IntRect::intersects(const IntRect other) const
{
// Checking emptiness handles negative widths as well as zero.
Modified: branches/subpixellayout/Source/WebCore/platform/graphics/IntRect.h (98868 => 98869)
--- branches/subpixellayout/Source/WebCore/platform/graphics/IntRect.h 2011-10-31 18:54:42 UTC (rev 98868)
+++ branches/subpixellayout/Source/WebCore/platform/graphics/IntRect.h 2011-10-31 19:06:13 UTC (rev 98869)
@@ -71,6 +71,7 @@
namespace WebCore {
class FloatRect;
+class FixedRect;
class IntRect {
public:
@@ -81,6 +82,7 @@
: m_location(IntPoint(x, y)), m_size(IntSize(width, height)) { }
explicit IntRect(const FloatRect rect); // don't do this implicitly since it's lossy
+explicit IntRect(const FixedRect rect); // don't do this implicitly since it's lossy
IntPoint location() const { return m_location; }
IntSize size() const { return m_size; }
Modified: branches/subpixellayout/Source/WebCore/platform/mac/WidgetMac.mm (98868 => 98869)
--- branches/subpixellayout/Source/WebCore/platform/mac/WidgetMac.mm 2011-10-31 18:54:42 UTC (rev 98868)
+++ branches/subpixellayout/Source/WebCore/platform/mac/WidgetMac.mm 2011-10-31 19:06:13 UTC (rev 98869)
@@ -284,7 +284,7 @@
return IntRect(rect);
BEGIN_BLOCK_OBJC_EXCEPTIONS;
-return IntRect([rootWidget-platformWidget() convertRect:rect toView:nil]);
+return IntRect(FloatRect([rootWidget-platformWidget() convertRect:rect toView:nil]));
END_BLOCK_OBJC_EXCEPTIONS;
return rect;
@@ -296,7 +296,7 @@
return rect;
BEGIN_BLOCK_OBJC_EXCEPTIONS;
-return IntRect([rootWidget-platformWidget() convertRect:rect toView:nil]);
+return IntRect(FloatRect([rootWidget-platformWidget() convertRect:rect toView:nil]));
END_BLOCK_OBJC_EXCEPTIONS;
return rect;
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp (98868 => 98869)
---
[webkit-changes] [98870] trunk/LayoutTests
Title: [98870] trunk/LayoutTests Revision 98870 Author ca...@chromium.org Date 2011-10-31 12:09:20 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed. Fixed duplicate lines in test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98869 => 98870) --- trunk/LayoutTests/ChangeLog 2011-10-31 19:06:13 UTC (rev 98869) +++ trunk/LayoutTests/ChangeLog 2011-10-31 19:09:20 UTC (rev 98870) @@ -1,5 +1,11 @@ 2011-10-31 Andrey Kosyakov ca...@chromium.org +Unreviewed. Fixed duplicate lines in test expectations. + +* platform/chromium/test_expectations.txt: + +2011-10-31 Andrey Kosyakov ca...@chromium.org + Unreviewed. More rebaselines after r98852. * platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-003-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98869 => 98870) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 19:06:13 UTC (rev 98869) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 19:09:20 UTC (rev 98870) @@ -951,8 +951,6 @@ BUGCR3244 LINUX WIN : fast/backgrounds/svg-as-mask.html = FAIL BUGCR3244 LINUX WIN : svg/batik/masking/maskRegions.svg = FAIL BUGCR3244 LINUX WIN : svg/zoom/page/zoom-mask-with-percentages.svg = FAIL -BUGCR3244 SLOW WIN RELEASE : fast/backgrounds/animated-svg-as-mask.html = FAIL -BUGCR3244 LINUX : fast/backgrounds/animated-svg-as-mask.html = FAIL // More tests that fail because of masks not working properly. // New tests. We should fix these, but they don't need to block the current release BUGCR3244 LINUX WIN : fast/backgrounds/repeat/mask-negative-offset-repeat.html = FAIL @@ -3938,6 +3936,5 @@ BUGWK71226 : svg/as-background-image/animated-svg-as-background.html = IMAGE BUGWK71226 : svg/zoom/page/zoom-coords-viewattr-01-b.svg = IMAGE+TEXT BUGWK71226 : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE+TEXT -BUGWK71226 : fast/backgrounds/animated-svg-as-mask.html = IMAGE BUGWK71226 MAC WIN7 : fast/backgrounds/animated-svg-as-mask.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98873] trunk/Source/WebKit2
Title: [98873] trunk/Source/WebKit2 Revision 98873 Author ander...@apple.com Date 2011-10-31 13:22:21 -0700 (Mon, 31 Oct 2011) Log Message Rename a couple of NetscapePlugin and PluginProxy member variables https://bugs.webkit.org/show_bug.cgi?id=71086 Reviewed by Sam Weinig. * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::invalidate): (WebKit::NetscapePlugin::callSetWindow): (WebKit::NetscapePlugin::snapshot): (WebKit::NetscapePlugin::deprecatedGeometryDidChange): * WebProcess/Plugins/Netscape/NetscapePlugin.h: * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPaint): (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: (WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate): (WebKit::NetscapePlugin::platformPaint): * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::paint): (WebKit::PluginProxy::geometryDidChange): (WebKit::PluginProxy::deprecatedGeometryDidChange): (WebKit::PluginProxy::update): * WebProcess/Plugins/PluginProxy.h: * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::viewGeometryDidChange): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (98872 => 98873) --- trunk/Source/WebKit2/ChangeLog 2011-10-31 19:51:55 UTC (rev 98872) +++ trunk/Source/WebKit2/ChangeLog 2011-10-31 20:22:21 UTC (rev 98873) @@ -1,3 +1,34 @@ +2011-10-27 Anders Carlsson ander...@apple.com + +Rename a couple of NetscapePlugin and PluginProxy member variables +https://bugs.webkit.org/show_bug.cgi?id=71086 + +Reviewed by Sam Weinig. + +* WebProcess/Plugins/Netscape/NetscapePlugin.cpp: +(WebKit::NetscapePlugin::invalidate): +(WebKit::NetscapePlugin::callSetWindow): +(WebKit::NetscapePlugin::snapshot): +(WebKit::NetscapePlugin::deprecatedGeometryDidChange): +* WebProcess/Plugins/Netscape/NetscapePlugin.h: +* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: +(WebKit::NetscapePlugin::platformPaint): +(WebKit::NetscapePlugin::platformHandleMouseEvent): +(WebKit::NetscapePlugin::platformHandleWheelEvent): +(WebKit::NetscapePlugin::platformHandleMouseEnterEvent): +(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): +* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: +(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate): +(WebKit::NetscapePlugin::platformPaint): +* WebProcess/Plugins/PluginProxy.cpp: +(WebKit::PluginProxy::paint): +(WebKit::PluginProxy::geometryDidChange): +(WebKit::PluginProxy::deprecatedGeometryDidChange): +(WebKit::PluginProxy::update): +* WebProcess/Plugins/PluginProxy.h: +* WebProcess/Plugins/PluginView.cpp: +(WebKit::PluginView::viewGeometryDidChange): + 2011-10-31 Andras Becsi andras.be...@nokia.com [Qt][WK2] Fix qmltests after r98460 added widgets dependency. Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (98872 => 98873) --- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-31 19:51:55 UTC (rev 98872) +++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-31 20:22:21 UTC (rev 98873) @@ -118,7 +118,7 @@ IntRect rect; if (!invalidRect) -rect = IntRect(0, 0, m_frameRect.width(), m_frameRect.height()); +rect = IntRect(0, 0, m_frameRectInWindowCoordinates.width(), m_frameRectInWindowCoordinates.height()); else rect = IntRect(invalidRect-left, invalidRect-top, invalidRect-right - invalidRect-left, invalidRect-bottom - invalidRect-top); @@ -484,15 +484,15 @@ m_npWindow.x = 0; m_npWindow.y = 0; #else -m_npWindow.x = m_frameRect.x(); -m_npWindow.y = m_frameRect.y(); +m_npWindow.x = m_frameRectInWindowCoordinates.x(); +m_npWindow.y = m_frameRectInWindowCoordinates.y(); #endif -m_npWindow.width = m_frameRect.width(); -m_npWindow.height = m_frameRect.height(); -m_npWindow.clipRect.top = m_clipRect.y(); -m_npWindow.clipRect.left = m_clipRect.x(); -m_npWindow.clipRect.bottom = m_clipRect.maxY(); -m_npWindow.clipRect.right = m_clipRect.maxX(); +m_npWindow.width =
[webkit-changes] [98874] branches/safari-534.52-branch/Source/WebCore
Title: [98874] branches/safari-534.52-branch/Source/WebCore
Revision 98874
Author lforsch...@apple.com
Date 2011-10-31 13:25:06 -0700 (Mon, 31 Oct 2011)
Log Message
Merged r98389.
Modified Paths
branches/safari-534.52-branch/Source/WebCore/ChangeLog
branches/safari-534.52-branch/Source/WebCore/loader/HistoryController.cpp
Diff
Modified: branches/safari-534.52-branch/Source/WebCore/ChangeLog (98873 => 98874)
--- branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-31 20:22:21 UTC (rev 98873)
+++ branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-31 20:25:06 UTC (rev 98874)
@@ -1,3 +1,22 @@
+2011-10-31 Lucas Forschler lforsch...@apple.com
+
+Merge 98389
+
+2011-10-25 Anders Carlsson ander...@apple.com
+
+REGRESSION(97821): HistoryController::itemsAreClones crashes a lot
+https://bugs.webkit.org/show_bug.cgi?id=70827
+rdar://problem/10342925
+
+Reviewed by Adam Barth.
+
+Check that m_currentItem is non-null before passing it to itemsAreClones. While I wasn't
+able to make a test case that would reproduce this crash, we do check m_currentItem for null
+everywhere else, and the crash log indicates that this would fix the crash.
+
+* loader/HistoryController.cpp:
+(WebCore::HistoryController::recursiveUpdateForCommit):
+
2011-10-27 Lucas Forschler lforsch...@apple.com
Merge 98503
Modified: branches/safari-534.52-branch/Source/WebCore/loader/HistoryController.cpp (98873 => 98874)
--- branches/safari-534.52-branch/Source/WebCore/loader/HistoryController.cpp 2011-10-31 20:22:21 UTC (rev 98873)
+++ branches/safari-534.52-branch/Source/WebCore/loader/HistoryController.cpp 2011-10-31 20:25:06 UTC (rev 98874)
@@ -471,7 +471,7 @@
// For each frame that already had the content the item requested (based on
// (a matching URL and frame tree snapshot), just restore the scroll position.
// Save form state (works from currentItem, since m_frameLoadComplete is true)
-if (itemsAreClones(m_currentItem.get(), m_provisionalItem.get())) {
+if (m_currentItem itemsAreClones(m_currentItem.get(), m_provisionalItem.get())) {
ASSERT(m_frameLoadComplete);
saveDocumentState();
saveScrollPositionAndViewStateToItem(m_currentItem.get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98875] trunk/LayoutTests
Title: [98875] trunk/LayoutTests Revision 98875 Author john...@google.com Date 2011-10-31 13:29:38 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98874 => 98875) --- trunk/LayoutTests/ChangeLog 2011-10-31 20:25:06 UTC (rev 98874) +++ trunk/LayoutTests/ChangeLog 2011-10-31 20:29:38 UTC (rev 98875) @@ -1,3 +1,9 @@ +2011-10-31 John Gregg john...@google.com + +Unreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847 + +* platform/chromium/test_expectations.txt: + 2011-10-31 Kenji Imasaki imas...@chromium.org Did rebaselines for failing tests for fullscreen layout tests. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98874 => 98875) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 20:25:06 UTC (rev 98874) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 20:29:38 UTC (rev 98875) @@ -3936,5 +3936,6 @@ BUGWK71226 : svg/as-background-image/animated-svg-as-background.html = IMAGE BUGWK71226 : svg/zoom/page/zoom-coords-viewattr-01-b.svg = IMAGE+TEXT BUGWK71226 : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE+TEXT -BUGWK71226 MAC WIN7 : fast/backgrounds/animated-svg-as-mask.html = IMAGE+TEXT +BUGWK71226 : fast/backgrounds/animated-svg-as-mask.html = IMAGE+TEXT IMAGE +BUGWK71233 : inspector/debugger/bind-script-to-resource.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98876] branches/subpixellayout/Source
Title: [98876] branches/subpixellayout/Source
Revision 98876
Author e...@chromium.org
Date 2011-10-31 13:31:26 -0700 (Mon, 31 Oct 2011)
Log Message
Change WebKit/WebKit2 to use explicit conversion between FixedRect/Point/Size and the int equivalents. Follow up to change 98869.
Modified Paths
branches/subpixellayout/Source/WebCore/WebCore.exp.in
branches/subpixellayout/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm
branches/subpixellayout/Source/WebKit/mac/WebView/WebHTMLView.mm
branches/subpixellayout/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm
branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/WebCore.exp.in (98875 => 98876)
--- branches/subpixellayout/Source/WebCore/WebCore.exp.in 2011-10-31 20:29:38 UTC (rev 98875)
+++ branches/subpixellayout/Source/WebCore/WebCore.exp.in 2011-10-31 20:31:26 UTC (rev 98876)
@@ -879,6 +879,7 @@
__ZN7WebCore7IntRect5scaleEf
__ZN7WebCore7IntRect5uniteERKS0_
__ZN7WebCore7IntRect9intersectERKS0_
+__ZN7WebCore7IntRectC1ERKNS_9FixedRectE
__ZN7WebCore7IntRectC1ERKNS_9FloatRectE
__ZN7WebCore7IntSizeC1ERK6CGSize
__ZN7WebCore7TextRun19allowsRoundingHacksEv
Modified: branches/subpixellayout/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm (98875 => 98876)
--- branches/subpixellayout/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm 2011-10-31 20:29:38 UTC (rev 98875)
+++ branches/subpixellayout/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm 2011-10-31 20:31:26 UTC (rev 98876)
@@ -851,7 +851,7 @@
- (void)invalidatePluginContentRect:(NSRect)rect
{
if (RenderBoxModelObject *renderer = toRenderBoxModelObject(_element-renderer())) {
-IntRect contentRect(rect);
+IntRect contentRect(enclosingIntRect(rect));
contentRect.move(renderer-borderLeft() + renderer-paddingLeft(), renderer-borderTop() + renderer-paddingTop());
renderer-repaintRectangle(contentRect);
@@ -936,4 +936,3 @@
} // namespace WebKit
#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
Modified: branches/subpixellayout/Source/WebKit/mac/WebView/WebHTMLView.mm (98875 => 98876)
--- branches/subpixellayout/Source/WebKit/mac/WebView/WebHTMLView.mm 2011-10-31 20:29:38 UTC (rev 98875)
+++ branches/subpixellayout/Source/WebKit/mac/WebView/WebHTMLView.mm 2011-10-31 20:31:26 UTC (rev 98876)
@@ -292,7 +292,7 @@
}
NSRect invalidRectInWebFrameViewCoordinates = [enclosingWebFrameView convertRect:invalidRect fromView:self];
-IntRect invalidRectInFrameViewCoordinates(invalidRectInWebFrameViewCoordinates);
+IntRect invalidRectInFrameViewCoordinates(enclosingIntRect(invalidRectInWebFrameViewCoordinates));
if (![enclosingWebFrameView isFlipped])
invalidRectInFrameViewCoordinates.setY(frameView-frameRect().size().height() - invalidRectInFrameViewCoordinates.maxY());
Modified: branches/subpixellayout/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm (98875 => 98876)
--- branches/subpixellayout/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm 2011-10-31 20:29:38 UTC (rev 98875)
+++ branches/subpixellayout/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm 2011-10-31 20:31:26 UTC (rev 98876)
@@ -426,7 +426,7 @@
{
ASSERT(isMainThread());
-IntRect rect(nsRect);
+IntRect rect(enclosingIntRect(nsRect));
rect.scale(1 / _totalScaleFactorForPrinting);
HashMapWebCore::IntRect, Vectoruint8_t ::iterator pagePreviewIterator = _pagePreviews.find(rect);
if (pagePreviewIterator == _pagePreviews.end()) {
Modified: branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp (98875 => 98876)
--- branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp 2011-10-31 20:29:38 UTC (rev 98875)
+++ branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp 2011-10-31 20:31:26 UTC (rev 98876)
@@ -223,7 +223,7 @@
CGRect box = CGPDFPageGetBoxRect(pdfPage, kCGPDFCropBox);
if (CGRectIsEmpty(box))
box = CGPDFPageGetBoxRect(pdfPage, kCGPDFMediaBox);
-m_pageBoxes.append(IntRect(box));
+m_pageBoxes.append(enclosingIntRect(box));
m_pdfDocumentSize.setWidth(max(m_pdfDocumentSize.width(), static_castint(box.size.width)));
m_pdfDocumentSize.expand(0, box.size.height);
}
@@ -655,7 +655,7 @@
AppUnit horizontalScrollbarHeight = (m_horizontalScrollbar !m_horizontalScrollbar-isOverlayScrollbar()) ? m_horizontalScrollbar-height() : AppUnit();
AppUnit verticalScrollbarWidth = (m_verticalScrollbar !m_verticalScrollbar-isOverlayScrollbar()) ? m_verticalScrollbar-width() : AppUnit();
-IntPoint maximumOffset((m_pdfDocumentSize.width() - m_pluginSize.width() + verticalScrollbarWidth, m_pdfDocumentSize.height() - m_pluginSize.height() + horizontalScrollbarHeight).ceil());
+IntPoint
[webkit-changes] [98877] trunk/Tools
Title: [98877] trunk/Tools Revision 98877 Author e...@webkit.org Date 2011-10-31 13:50:51 -0700 (Mon, 31 Oct 2011) Log Message webkitpy tests depend too much on the user's environment https://bugs.webkit.org/show_bug.cgi?id=71234 Reviewed by Dirk Pranke. This change just makes a bunch of our older tests use more modern mocking to avoid trying to launch processes or read from the user's filesystem during unittesting. I found many of these by adding an assert in Executive.run_command that we were not unittesting. I can't add that assert always as there are some valid uses of Executive during unittesting. Once I fix more of these, I may find a way to add such an assert conditionally. * Scripts/webkitpy/common/checkout/baselineoptimizer.py: * Scripts/webkitpy/common/net/credentials_unittest.py: * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py trunk/Tools/Scripts/webkitpy/common/net/credentials_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py Diff Modified: trunk/Tools/ChangeLog (98876 => 98877) --- trunk/Tools/ChangeLog 2011-10-31 20:31:26 UTC (rev 98876) +++ trunk/Tools/ChangeLog 2011-10-31 20:50:51 UTC (rev 98877) @@ -1,3 +1,25 @@ +2011-10-31 Eric Seidel e...@webkit.org + +webkitpy tests depend too much on the user's environment +https://bugs.webkit.org/show_bug.cgi?id=71234 + +Reviewed by Dirk Pranke. + +This change just makes a bunch of our older tests use +more modern mocking to avoid trying to launch processes +or read from the user's filesystem during unittesting. + +I found many of these by adding an assert in Executive.run_command +that we were not unittesting. I can't add that assert always +as there are some valid uses of Executive during unittesting. +Once I fix more of these, I may find a way to add such an assert conditionally. + +* Scripts/webkitpy/common/checkout/baselineoptimizer.py: +* Scripts/webkitpy/common/net/credentials_unittest.py: +* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: +* Scripts/webkitpy/layout_tests/port/base.py: +* Scripts/webkitpy/layout_tests/port/base_unittest.py: + 2011-10-31 Kenneth Rohde Christiansen kenn...@webkit.org [Qt] MiniBrowser doesn't resize as the size is always overridden Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py (98876 => 98877) --- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py 2011-10-31 20:31:26 UTC (rev 98876) +++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py 2011-10-31 20:50:51 UTC (rev 98877) @@ -43,7 +43,9 @@ fallback_path = ['LayoutTests'] for port_name in port_factory.all_port_names(): -port = port_factory.get(port_name) +# FIXME: This should pass User and Executive as well to allow for easy mocking. +# Alternatively, we should get a pre-mocked PortFactory from tool. +port = port_factory.get(port_name, filesystem=fs) webkit_base = port.webkit_base() search_path = port.baseline_search_path() if search_path: Modified: trunk/Tools/Scripts/webkitpy/common/net/credentials_unittest.py (98876 => 98877) --- trunk/Tools/Scripts/webkitpy/common/net/credentials_unittest.py 2011-10-31 20:31:26 UTC (rev 98876) +++ trunk/Tools/Scripts/webkitpy/common/net/credentials_unittest.py 2011-10-31 20:50:51 UTC (rev 98877) @@ -35,6 +35,7 @@ from webkitpy.common.system.executive import Executive from webkitpy.common.system.outputcapture import OutputCapture from webkitpy.thirdparty.mock import Mock +from webkitpy.tool.mocktool import MockOptions, MockUser, MockExecutive # FIXME: Other unit tests probably want this class. @@ -51,6 +52,14 @@ os.rmdir(self._directory_path) +# Note: All tests should use this class instead of Credentials directly to avoid using a real Executive. +class MockedCredentials(Credentials): +def __init__(self, *args, **kwargs): +if 'executive' not in kwargs: +kwargs['executive'] = MockExecutive() +Credentials.__init__(self, *args, **kwargs) + + class CredentialsTest(unittest.TestCase): example_security_output = keychain: /Users/test/Library/Keychains/login.keychain class: inet @@ -79,7 +88,7 @@ def test_keychain_lookup_on_non_mac(self): -class FakeCredentials(Credentials): +class FakeCredentials(MockedCredentials): def _is_mac_os_x(self): return False credentials = FakeCredentials(bugs.webkit.org) @@ -87,10 +96,11 @@
[webkit-changes] [98878] trunk/Source/JavaScriptCore
Title: [98878] trunk/Source/_javascript_Core
Revision 98878
Author fpi...@apple.com
Date 2011-10-31 14:03:21 -0700 (Mon, 31 Oct 2011)
Log Message
REGRESSION (r97118): Reproducible crash in JSCell::toPrimitive when adding
https://bugs.webkit.org/show_bug.cgi?id=71227
Reviewed by Oliver Hunt.
No new tests, since while I can see exactly where the DFG went wrong on the
site in question from looking at the generated machine code, and while I can
certainly believe that such a scenario would happen, I cannot visualize how
to make it happen reproducibly. It requires an odd combination of double
values getting spilled and then refilled, but then reboxed at just the right
time so that the spilled value is an unboxed double while the in-register
value is a boxed double.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98877 => 98878)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-31 20:50:51 UTC (rev 98877)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-31 21:03:21 UTC (rev 98878)
@@ -1,3 +1,21 @@
+2011-10-31 Filip Pizlo fpi...@apple.com
+
+REGRESSION (r97118): Reproducible crash in JSCell::toPrimitive when adding
+https://bugs.webkit.org/show_bug.cgi?id=71227
+
+Reviewed by Oliver Hunt.
+
+No new tests, since while I can see exactly where the DFG went wrong on the
+site in question from looking at the generated machine code, and while I can
+certainly believe that such a scenario would happen, I cannot visualize how
+to make it happen reproducibly. It requires an odd combination of double
+values getting spilled and then refilled, but then reboxed at just the right
+time so that the spilled value is an unboxed double while the in-register
+value is a boxed double.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::JITCodeGenerator::silentFillGPR):
+
2011-10-30 Filip Pizlo fpi...@apple.com
JSParser::parsePrimaryExpression should have an overflow check
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (98877 => 98878)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-31 20:50:51 UTC (rev 98877)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-31 21:03:21 UTC (rev 98878)
@@ -397,6 +397,10 @@
ASSERT(registerFormat == DataFormatJSInteger);
m_jit.load32(JITCompiler::payloadFor(spillMe), info.gpr());
m_jit.orPtr(GPRInfo::tagTypeNumberRegister, info.gpr());
+} else if (info.spillFormat() == DataFormatDouble) {
+ASSERT(registerFormat == DataFormatJSDouble);
+m_jit.loadPtr(JITCompiler::addressFor(spillMe), info.gpr());
+m_jit.subPtr(GPRInfo::tagTypeNumberRegister, info.gpr());
} else
m_jit.loadPtr(JITCompiler::addressFor(spillMe), info.gpr());
#else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98879] trunk
Title: [98879] trunk Revision 98879 Author dslo...@google.com Date 2011-10-31 14:07:22 -0700 (Mon, 31 Oct 2011) Log Message Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70658 [JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage. Transfer of MessagePorts implemented. Reviewed by David Levin. * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::serialize): (WebCore::CloneSerializer::CloneSerializer): (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::deserialize): (WebCore::CloneDeserializer::CloneDeserializer): (WebCore::CloneDeserializer::readTerminal): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::deserialize): LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=70658 [JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage. Some 'FAIL's remain in expected test results. These are due to the fact that JSC bindings chose not to throw type error exception for non-serializable values - non-serializable values are serialized as null. Reviewed by David Levin. * fast/dom/Window/window-postmessage-args-expected.txt: * fast/events/message-port-multi-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt trunk/LayoutTests/fast/events/message-port-multi-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp Diff Modified: trunk/LayoutTests/ChangeLog (98878 => 98879) --- trunk/LayoutTests/ChangeLog 2011-10-31 21:03:21 UTC (rev 98878) +++ trunk/LayoutTests/ChangeLog 2011-10-31 21:07:22 UTC (rev 98879) @@ -1,3 +1,16 @@ +2011-10-31 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=70658 +[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage. +Some 'FAIL's remain in expected test results. These are due to the fact that +JSC bindings chose not to throw type error exception for non-serializable values - +non-serializable values are serialized as null. + +Reviewed by David Levin. + +* fast/dom/Window/window-postmessage-args-expected.txt: +* fast/events/message-port-multi-expected.txt: + 2011-10-31 John Gregg john...@google.com Unreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847 Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (98878 => 98879) --- trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-10-31 21:03:21 UTC (rev 98878) +++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-10-31 21:07:22 UTC (rev 98879) @@ -31,7 +31,7 @@ Received message '2147483648' with 0 ports. Received message '2147483648' with 0 ports. Received message '[object Object]' with 2 ports. -Received message '[object Object]' with 2 ports. -Received message '[object Object],[object Object]' with 2 ports. +Received message '[object MessagePort]' with 2 ports. +Received message '[object MessagePort],[object MessagePort]' with 2 ports. Received message 'done' with 0 ports. Modified: trunk/LayoutTests/fast/events/message-port-multi-expected.txt (98878 => 98879) --- trunk/LayoutTests/fast/events/message-port-multi-expected.txt 2011-10-31 21:03:21 UTC (rev 98878) +++ trunk/LayoutTests/fast/events/message-port-multi-expected.txt 2011-10-31 21:07:22 UTC (rev 98879) @@ -15,9 +15,9 @@ PASS event.ports contains two ports when two ports sent PASS event.ports contains two ports when two ports re-sent after error FAIL Sending host object should throw -FAIL send-port: port transfer failed -FAIL send-port-twice: failed to transfer one port twice -FAIL send-two-ports: failed to transfer two ports +PASS send-port: transferred one port +PASS send-port-twice: transferred one port twice +PASS send-two-ports: transferred two ports FAIL Unexpected message [object Object] TEST COMPLETE Modified: trunk/Source/WebCore/ChangeLog (98878 => 98879) --- trunk/Source/WebCore/ChangeLog 2011-10-31 21:03:21 UTC (rev 98878) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 21:07:22 UTC (rev 98879) @@ -1,3 +1,21 @@ +2011-10-31 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=70658 +[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage. +Transfer of MessagePorts implemented. + +Reviewed by David Levin. + +* bindings/js/SerializedScriptValue.cpp: +(WebCore::CloneSerializer::serialize): +(WebCore::CloneSerializer::CloneSerializer): +(WebCore::CloneSerializer::dumpIfTerminal): +(WebCore::CloneDeserializer::deserialize): +(WebCore::CloneDeserializer::CloneDeserializer): +(WebCore::CloneDeserializer::readTerminal): +(WebCore::SerializedScriptValue::create): +
[webkit-changes] [98880] branches/safari-534.52-branch/Source
Title: [98880] branches/safari-534.52-branch/Source Revision 98880 Author lforsch...@apple.com Date 2011-10-31 14:23:33 -0700 (Mon, 31 Oct 2011) Log Message Versioning. Modified Paths branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig (98879 => 98880) --- branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-31 21:07:22 UTC (rev 98879) +++ branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-31 21:23:33 UTC (rev 98880) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (98879 => 98880) --- branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-31 21:07:22 UTC (rev 98879) +++ branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-31 21:23:33 UTC (rev 98880) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig (98879 => 98880) --- branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-31 21:07:22 UTC (rev 98879) +++ branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-31 21:23:33 UTC (rev 98880) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig (98879 => 98880) --- branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-31 21:07:22 UTC (rev 98879) +++ branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-31 21:23:33 UTC (rev 98880) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig (98879 => 98880) --- branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-31 21:07:22 UTC (rev 98879) +++ branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-31 21:23:33 UTC (rev 98880) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98883] trunk/Source/WebCore
Title: [98883] trunk/Source/WebCore
Revision 98883
Author e...@chromium.org
Date 2011-10-31 14:33:35 -0700 (Mon, 31 Oct 2011)
Log Message
Overridden LayoutRect method still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71166
Reviewed by Eric Seidel.
Change all virtual controlClipRect, windowResizerRect, windowClipRect,
visibleContentRect, scrollCornerRect, outlineBoundsForRepaint and
localCaretRect functions to have the same signature.
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::windowResizerRect):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.h:
* rendering/RenderButton.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::visibleContentRect):
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::localCaretRect):
* rendering/RenderObject.h:
(WebCore::RenderObject::outlineBoundsForRepaint):
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::linesBoundingBox):
* rendering/RenderText.h:
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
* rendering/svg/RenderSVGInlineText.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderButton.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderText.cpp
trunk/Source/WebCore/rendering/RenderText.h
trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98882 => 98883)
--- trunk/Source/WebCore/ChangeLog 2011-10-31 21:31:32 UTC (rev 98882)
+++ trunk/Source/WebCore/ChangeLog 2011-10-31 21:33:35 UTC (rev 98883)
@@ -1,3 +1,39 @@
+2011-10-31 Emil A Eklund e...@chromium.org
+
+Overridden LayoutRect method still uses IntRects
+https://bugs.webkit.org/show_bug.cgi?id=71166
+
+Reviewed by Eric Seidel.
+
+Change all virtual controlClipRect, windowResizerRect, windowClipRect,
+visibleContentRect, scrollCornerRect, outlineBoundsForRepaint and
+localCaretRect functions to have the same signature.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::windowClipRect):
+(WebCore::FrameView::windowClipRectForLayer):
+(WebCore::FrameView::windowResizerRect):
+* page/FrameView.h:
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::wheelEvent):
+* platform/ScrollView.h:
+* platform/ScrollableArea.h:
+* rendering/RenderButton.h:
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::visibleContentRect):
+* rendering/RenderLayer.h:
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::localCaretRect):
+* rendering/RenderObject.h:
+(WebCore::RenderObject::outlineBoundsForRepaint):
+* rendering/RenderText.cpp:
+(WebCore::RenderText::localCaretRect):
+(WebCore::RenderText::linesBoundingBox):
+* rendering/RenderText.h:
+* rendering/svg/RenderSVGInlineText.cpp:
+(WebCore::RenderSVGInlineText::localCaretRect):
+* rendering/svg/RenderSVGInlineText.h:
+
2011-10-31 Dmitry Lomov dslo...@google.com
https://bugs.webkit.org/show_bug.cgi?id=70658
Modified: trunk/Source/WebCore/page/FrameView.cpp (98882 => 98883)
--- trunk/Source/WebCore/page/FrameView.cpp 2011-10-31 21:31:32 UTC (rev 98882)
+++ trunk/Source/WebCore/page/FrameView.cpp 2011-10-31 21:33:35 UTC (rev 98883)
@@ -2309,15 +2309,15 @@
}
-LayoutRect FrameView::windowClipRect(bool clipToContents) const
+IntRect FrameView::windowClipRect(bool clipToContents) const
{
ASSERT(m_frame-view() == this);
if (paintsEntireContents())
-return LayoutRect(LayoutPoint(), contentsSize());
+return IntRect(IntPoint(), contentsSize());
// Set our clip rect to be our contents.
-LayoutRect clipRect = contentsToWindow(visibleContentRect(!clipToContents));
+IntRect clipRect = contentsToWindow(visibleContentRect(!clipToContents));
if (!m_frame || !m_frame-ownerElement())
return clipRect;
@@ -2333,14 +2333,14 @@
return clipRect;
}
-LayoutRect FrameView::windowClipRectForLayer(const RenderLayer* layer, bool clipToLayerContents) const
+IntRect FrameView::windowClipRectForLayer(const RenderLayer* layer, bool clipToLayerContents) const
{
// If we have no layer, just return our window clip rect.
if (!layer)
return
[webkit-changes] [98885] trunk
Title: [98885] trunk
Revision 98885
Author yu...@chromium.org
Date 2011-10-31 15:03:22 -0700 (Mon, 31 Oct 2011)
Log Message
window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991
Source/WebCore:
Uncaught syntax errors in inline event handlers are now reported to
window.onerror handler.
Reviewed by Geoffrey Garen.
Tests: fast/events/window-onerror-exception-in-attr.html
fast/events/window-onerror-syntax-error-in-attr.html
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction): report exception as usual
if it happens during event handler compilation.
LayoutTests:
Added a couple of window.onerror tests for the cases when uncaught exception
occurs in inline event handler. Test for non-syntax errors passed before this change
as well and just extends test coverage for window.onerror functionality.
Reviewed by Geoffrey Garen.
* fast/events/window-onerror-exception-in-attr-expected.txt: Added.
* fast/events/window-onerror-exception-in-attr.html: Added.
* fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
* fast/events/window-onerror-syntax-error-in-attr.html: Added.
* platform/chromium/fast/events/window-onerror-exception-in-attr-expected.txt: Added.
* platform/chromium/fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp
Added Paths
trunk/LayoutTests/fast/events/window-onerror-exception-in-attr-expected.txt
trunk/LayoutTests/fast/events/window-onerror-exception-in-attr.html
trunk/LayoutTests/fast/events/window-onerror-syntax-error-in-attr-expected.txt
trunk/LayoutTests/fast/events/window-onerror-syntax-error-in-attr.html
trunk/LayoutTests/platform/chromium/fast/events/window-onerror-exception-in-attr-expected.txt
trunk/LayoutTests/platform/chromium/fast/events/window-onerror-syntax-error-in-attr-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98884 => 98885)
--- trunk/LayoutTests/ChangeLog 2011-10-31 21:34:59 UTC (rev 98884)
+++ trunk/LayoutTests/ChangeLog 2011-10-31 22:03:22 UTC (rev 98885)
@@ -1,3 +1,21 @@
+2011-10-31 Yury Semikhatsky yu...@chromium.org
+
+window.onerror doesn't work with inline (attribute) scripts
+https://bugs.webkit.org/show_bug.cgi?id=70991
+
+Added a couple of window.onerror tests for the cases when uncaught exception
+occurs in inline event handler. Test for non-syntax errors passed before this change
+as well and just extends test coverage for window.onerror functionality.
+
+Reviewed by Geoffrey Garen.
+
+* fast/events/window-onerror-exception-in-attr-expected.txt: Added.
+* fast/events/window-onerror-exception-in-attr.html: Added.
+* fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
+* fast/events/window-onerror-syntax-error-in-attr.html: Added.
+* platform/chromium/fast/events/window-onerror-exception-in-attr-expected.txt: Added.
+* platform/chromium/fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
+
2011-10-31 John Gregg john...@google.com
Unreviewed, more expectations changes for svg.
Added: trunk/LayoutTests/fast/events/window-onerror-exception-in-attr-expected.txt (0 => 98885)
--- trunk/LayoutTests/fast/events/window-onerror-exception-in-attr-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/window-onerror-exception-in-attr-expected.txt 2011-10-31 22:03:22 UTC (rev 98885)
@@ -0,0 +1,6 @@
+Test that window.onerror is called on window object when there is an exception(excluding syntax errors) in attribute handler. Bug 70991.
+
+Main frame window.onerror: TypeError: 'null' is not an object (evaluating 'null.m') at window-onerror-exception-in-attr.html:10
+Main frame window.onerror: TypeError: 'null' is not an object (evaluating 'null.m') at window-onerror-exception-in-attr.html:36
+Main frame window.onerror: TypeError: 'null' is not an object (evaluating 'null.m') at window-onerror-exception-in-attr.html:36
+Button 1 Button 2 Button 3
Added: trunk/LayoutTests/fast/events/window-onerror-exception-in-attr.html (0 => 98885)
--- trunk/LayoutTests/fast/events/window-onerror-exception-in-attr.html (rev 0)
+++ trunk/LayoutTests/fast/events/window-onerror-exception-in-attr.html 2011-10-31 22:03:22 UTC (rev 98885)
@@ -0,0 +1,38 @@
+html
+head
+script src=""
+/script
+/head
+body
+pTest that window.onerror is called on window object when there is an exception(excluding syntax errors)
+in attribute handler. a href="" 70991/a./p
+div id=console/div
+button id=btn1 _onclick_=null.m()Button 1/button
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function log(msg) {
+document.getElementById(console).innerHTML += msg + br;
+}
+
+window._onerror_ =
[webkit-changes] [98888] trunk
Title: [9] trunk
Revision 9
Author commit-qu...@webkit.org
Date 2011-10-31 15:22:50 -0700 (Mon, 31 Oct 2011)
Log Message
Microdata: Support for itemid attribute.
https://bugs.webkit.org/show_bug.cgi?id=71007
Patch by Arko Saha a...@motorola.com on 2011-10-31
Reviewed by Ryosuke Niwa.
Source/WebCore:
itemid attribute: To give a global identifier for the Microdata items.
The itemid attribute, if specified, must have a value that is a valid URL potentially
surrounded by spaces.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#attr-itemid
Tests: fast/dom/MicroData/itemid-attribute-test.html
fast/dom/MicroData/itemid-must-see-resolved-url.html
* html/HTMLElement.idl:
LayoutTests:
Added test-cases for itemid attribute.
* fast/dom/MicroData/itemid-attribute-test-expected.txt: Added.
* fast/dom/MicroData/itemid-attribute-test.html: Added.
* fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Added.
* fast/dom/MicroData/itemid-must-see-resolved-url.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLElement.idl
Added Paths
trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test-expected.txt
trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test.html
trunk/LayoutTests/fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt
trunk/LayoutTests/fast/dom/MicroData/itemid-must-see-resolved-url.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98887 => 9)
--- trunk/LayoutTests/ChangeLog 2011-10-31 22:13:01 UTC (rev 98887)
+++ trunk/LayoutTests/ChangeLog 2011-10-31 22:22:50 UTC (rev 9)
@@ -1,3 +1,17 @@
+2011-10-31 Arko Saha a...@motorola.com
+
+Microdata: Support for itemid attribute.
+https://bugs.webkit.org/show_bug.cgi?id=71007
+
+Reviewed by Ryosuke Niwa.
+
+Added test-cases for itemid attribute.
+
+* fast/dom/MicroData/itemid-attribute-test-expected.txt: Added.
+* fast/dom/MicroData/itemid-attribute-test.html: Added.
+* fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Added.
+* fast/dom/MicroData/itemid-must-see-resolved-url.html: Added.
+
2011-10-31 Benjamin Poulain benja...@webkit.org
The test input-paste-undo.html needs update to work properly
Added: trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test-expected.txt (0 => 9)
--- trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test-expected.txt 2011-10-31 22:22:50 UTC (rev 9)
@@ -0,0 +1,35 @@
+itemid attribute simple test.
+
+Created element of type: div
+Set attribute: itemid, value: http://example.com/foo
+
+The itemId attribute must be defined.
+PASS element.itemId is defined.
+PASS element.itemId is 'http://example.com/foo'
+
+itemId attribute must be case-senaitive.
+Created element of type: div
+Set attribute: itemid, value: http://example.com/FOO
+PASS createElement('div', {itemid: 'http://example.com/FOO'}).itemId == 'http://example.com/FOO'; is true
+
+itemId must strip leading and trailing whitespace.
+Created element of type: div
+Set attribute: itemid, value: http://example.com/foo
+PASS createElement('div', {itemid: ' http://example.com/foo '}).itemId == 'http://example.com/foo'; is true
+
+itemId must strip leading whitespace.
+Created element of type: div
+Set attribute: itemid, value: http://example.com/foo
+PASS createElement('div', {itemid: ' http://example.com/foo'}).itemId == 'http://example.com/foo'; is true
+
+itemId must strip trailing whitespace.
+Created element of type: div
+Set attribute: itemid, value: http://example.com/foo
+PASS createElement('div', {itemid: 'http://example.com/foo '}).itemId == 'http://example.com/foo'; is true
+
+itemId must be read/write.
+PASS element.itemId = 'http://example.com/bar'; element.itemId == 'http://example.com/bar' is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test.html (0 => 9)
--- trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test.html (rev 0)
+++ trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test.html 2011-10-31 22:22:50 UTC (rev 9)
@@ -0,0 +1,36 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+/head
+body
+pitemid attribute simple test./p
+div id=console/div
+script
+var element = createElement('div', {itemid: 'http://example.com/foo'});
+
+debug(brThe itemId attribute must be defined.);
+shouldBeDefined(element.itemId);
+shouldBe(element.itemId, 'http://example.com/foo');
+
+debug(britemId attribute must be case-senaitive.);
+shouldBeTrue(createElement('div', {itemid: 'http://example.com/FOO'}).itemId == 'http://example.com/FOO';);
+
+debug(britemId must strip leading and trailing whitespace.);
+shouldBeTrue(createElement('div', {itemid: ' http://example.com/foo
[webkit-changes] [98889] trunk/Source
Title: [98889] trunk/Source Revision 98889 Author mhahnenb...@apple.com Date 2011-10-31 15:24:20 -0700 (Mon, 31 Oct 2011) Log Message De-virtualize JSObject::defineGetter https://bugs.webkit.org/show_bug.cgi?id=71134 Reviewed by Darin Adler. Source/_javascript_Core: Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter with static versions. Replaced all call sites with lookups in the MethodTable. * _javascript_Core.exp: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: * debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::defineGetter): * debugger/DebuggerActivation.h: * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): * runtime/ClassInfo.h: * runtime/JSCell.cpp: (JSC::JSCell::defineGetter): * runtime/JSCell.h: * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::defineGetter): * runtime/JSGlobalObject.h: * runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::putDescriptor): * runtime/JSObject.h: * runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncDefineGetter): Source/WebCore: No new tests. Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter with static versions. Replaced all call sites with lookups in the MethodTable. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::defineGetter): * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::defineGetter): * bindings/js/JSDOMWindowShell.h: * bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::defineGetter): (WebCore::JSLocationPrototype::defineGetter): * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): Source/WebKit/qt: Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter with static versions. Replaced all call sites with lookups in the MethodTable. * Api/qwebframe.cpp: (QWebFramePrivate::addQtSenderToGlobalObject): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.exp trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/debugger/DebuggerActivation.cpp trunk/Source/_javascript_Core/debugger/DebuggerActivation.h trunk/Source/_javascript_Core/interpreter/Interpreter.cpp trunk/Source/_javascript_Core/jit/JITStubs.cpp trunk/Source/_javascript_Core/runtime/ClassInfo.h trunk/Source/_javascript_Core/runtime/JSCell.cpp trunk/Source/_javascript_Core/runtime/JSCell.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/JSObject.h trunk/Source/_javascript_Core/runtime/ObjectPrototype.cpp trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp trunk/Source/WebCore/bindings/js/JSDOMWindowShell.cpp trunk/Source/WebCore/bindings/js/JSDOMWindowShell.h trunk/Source/WebCore/bindings/js/JSLocationCustom.cpp trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebKit/qt/Api/qwebframe.cpp trunk/Source/WebKit/qt/ChangeLog Diff Modified: trunk/Source/_javascript_Core/ChangeLog (9 => 98889) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-31 22:22:50 UTC (rev 9) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-31 22:24:20 UTC (rev 98889) @@ -1,3 +1,36 @@ +2011-10-31 Mark Hahnenberg mhahnenb...@apple.com + +De-virtualize JSObject::defineGetter +https://bugs.webkit.org/show_bug.cgi?id=71134 + +Reviewed by Darin Adler. + +Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter +with static versions. Replaced all call sites with lookups in the MethodTable. + +* _javascript_Core.exp: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: +* debugger/DebuggerActivation.cpp: +(JSC::DebuggerActivation::defineGetter): +* debugger/DebuggerActivation.h: +* interpreter/Interpreter.cpp: +(JSC::Interpreter::privateExecute): +* jit/JITStubs.cpp: +(JSC::DEFINE_STUB_FUNCTION): +* runtime/ClassInfo.h: +* runtime/JSCell.cpp: +(JSC::JSCell::defineGetter): +* runtime/JSCell.h: +* runtime/JSGlobalObject.cpp: +(JSC::JSGlobalObject::defineGetter): +* runtime/JSGlobalObject.h: +* runtime/JSObject.cpp: +(JSC::JSObject::defineGetter): +(JSC::putDescriptor): +* runtime/JSObject.h: +* runtime/ObjectPrototype.cpp: +(JSC::objectProtoFuncDefineGetter): + 2011-10-31 Michael Saboff msab...@apple.com Towards 8-bit Strings: Move Lexer and Parser Objects out of JSGlobalData Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (9 => 98889) --- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-10-31 22:22:50 UTC (rev 9) +++
[webkit-changes] [98890] trunk/Source/WebKit/efl
Title: [98890] trunk/Source/WebKit/efl
Revision 98890
Author commit-qu...@webkit.org
Date 2011-10-31 15:31:16 -0700 (Mon, 31 Oct 2011)
Log Message
[EFL] Make cache flush when max size of cache has been changed
https://bugs.webkit.org/show_bug.cgi?id=70805
Patch by Tomasz Morawski t.moraw...@samsung.com on 2011-10-31
Reviewed by Ryosuke Niwa.
Calls the ewk_tile_unused_cache_auto_flush function after changing max
size of cache when ewk_tile_unused_cache_max_set is called. Without
this change when new value is lower than the old one the cache may use
more memory than max value set. This situation is not expected by the
user.
* ewk/ewk_tiled_model.cpp:
(ewk_tile_unused_cache_max_set):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (98889 => 98890)
--- trunk/Source/WebKit/efl/ChangeLog 2011-10-31 22:24:20 UTC (rev 98889)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-10-31 22:31:16 UTC (rev 98890)
@@ -1,3 +1,19 @@
+2011-10-31 Tomasz Morawski t.moraw...@samsung.com
+
+[EFL] Make cache flush when max size of cache has been changed
+https://bugs.webkit.org/show_bug.cgi?id=70805
+
+Reviewed by Ryosuke Niwa.
+
+Calls the ewk_tile_unused_cache_auto_flush function after changing max
+size of cache when ewk_tile_unused_cache_max_set is called. Without
+this change when new value is lower than the old one the cache may use
+more memory than max value set. This situation is not expected by the
+user.
+
+* ewk/ewk_tiled_model.cpp:
+(ewk_tile_unused_cache_max_set):
+
2011-10-28 Jochen Eisinger joc...@chromium.org
Rename a number of methods mentioning _javascript_ to just Script instead
Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp (98889 => 98890)
--- trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp 2011-10-31 22:24:20 UTC (rev 98889)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp 2011-10-31 22:31:16 UTC (rev 98890)
@@ -633,7 +633,11 @@
void ewk_tile_unused_cache_max_set(Ewk_Tile_Unused_Cache* tileUnusedCache, size_t max)
{
EINA_SAFETY_ON_NULL_RETURN(tileUnusedCache);
+size_t oldMax = tileUnusedCache-memory.max;
tileUnusedCache-memory.max = max;
+/* Cache flush when new max is lower then old one */
+if (oldMax max)
+ewk_tile_unused_cache_auto_flush(tileUnusedCache);
}
size_t ewk_tile_unused_cache_max_get(const Ewk_Tile_Unused_Cache* tileUnusedCache)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98891] trunk/Source/JavaScriptCore
Title: [98891] trunk/Source/_javascript_Core Revision 98891 Author commit-qu...@webkit.org Date 2011-10-31 15:38:06 -0700 (Mon, 31 Oct 2011) Log Message Fix DFG JIT compilation on Linux targets. https://bugs.webkit.org/show_bug.cgi?id=70904 Patch by Andy Wingo wi...@igalia.com on 2011-10-31 Reviewed by Darin Adler. * jit/JITStubs.cpp (SYMBOL_STRING_RELOCATION): Simplify this macro. * dfg/DFGOperations.cpp (SYMBOL_STRING_RELOCATION): Copy the simplified definition from jit/JITStubs.cpp. (FUNCTION_WRAPPER_WITH_RETURN_ADDRESS, getHostCallReturnValue): Use the macro to access trampoline targets through the PLT on PIC systems, instead of introducing a text relocation. Otherwise, the library fails to link. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGOperations.cpp trunk/Source/_javascript_Core/jit/JITStubs.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98890 => 98891) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-31 22:31:16 UTC (rev 98890) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-31 22:38:06 UTC (rev 98891) @@ -1,3 +1,20 @@ +2011-10-31 Andy Wingo wi...@igalia.com + +Fix DFG JIT compilation on Linux targets. +https://bugs.webkit.org/show_bug.cgi?id=70904 + +Reviewed by Darin Adler. + +* jit/JITStubs.cpp (SYMBOL_STRING_RELOCATION): Simplify this +macro. + +* dfg/DFGOperations.cpp (SYMBOL_STRING_RELOCATION): Copy the +simplified definition from jit/JITStubs.cpp. +(FUNCTION_WRAPPER_WITH_RETURN_ADDRESS, getHostCallReturnValue): +Use the macro to access trampoline targets through the PLT on PIC +systems, instead of introducing a text relocation. Otherwise, the +library fails to link. + 2011-10-31 Mark Hahnenberg mhahnenb...@apple.com De-virtualize JSObject::defineGetter Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (98890 => 98891) --- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-10-31 22:31:16 UTC (rev 98890) +++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-10-31 22:38:06 UTC (rev 98891) @@ -42,6 +42,14 @@ #define SYMBOL_STRING(name) #name #endif +#if (OS(LINUX) || OS(FREEBSD)) CPU(X86_64) +#define SYMBOL_STRING_RELOCATION(name) #name @plt +#elif CPU(X86) COMPILER(MINGW) +#define SYMBOL_STRING_RELOCATION(name) @ #name @4 +#else +#define SYMBOL_STRING_RELOCATION(name) SYMBOL_STRING(name) +#endif + #if CPU(X86_64) #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, register) \ @@ -49,7 +57,7 @@ .globl SYMBOL_STRING(function) \n \ SYMBOL_STRING(function) : \n \ mov (%rsp), % STRINGIZE(register) \n \ -jmp SYMBOL_STRING(function) WithReturnAddress \n \ +jmp SYMBOL_STRING_RELOCATION(function##WithReturnAddress) \n \ ); #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS_E(function)FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, rsi) #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS_ECI(function) FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, rcx) @@ -63,7 +71,7 @@ SYMBOL_STRING(function) : \n \ mov (%esp), %eax\n \ mov %eax, STRINGIZE(offset) (%esp)\n \ -jmp SYMBOL_STRING(function) WithReturnAddress \n \ +jmp SYMBOL_STRING_RELOCATION(function##WithReturnAddress) \n \ ); #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS_E(function)FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, 8) #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS_ECI(function) FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, 16) @@ -509,7 +517,7 @@ SYMBOL_STRING(getHostCallReturnValue) : \n mov -40(%r13), %r13\n mov %r13, %rdi\n -jmp SYMBOL_STRING(getHostCallReturnValueWithExecState) \n +jmp SYMBOL_STRING_RELOCATION(getHostCallReturnValueWithExecState) \n ); #elif CPU(X86) asm ( @@ -517,7 +525,7 @@ SYMBOL_STRING(getHostCallReturnValue) : \n mov -40(%edi), %edi\n mov %edi, 4(%esp)\n -jmp SYMBOL_STRING(getHostCallReturnValueWithExecState) \n +jmp SYMBOL_STRING_RELOCATION(getHostCallReturnValueWithExecState) \n ); #endif Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (98890 => 98891) --- trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-10-31 22:31:16 UTC (rev 98890) +++ trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-10-31 22:38:06 UTC (rev 98891) @@ -82,12 +82,10 @@ #if (OS(LINUX) || OS(FREEBSD)) CPU(X86_64) #define SYMBOL_STRING_RELOCATION(name) #name @plt -#elif OS(DARWIN) || (CPU(X86_64) COMPILER(MINGW) !GCC_VERSION_AT_LEAST(4, 5, 0)) -#define SYMBOL_STRING_RELOCATION(name) _ #name #elif CPU(X86) COMPILER(MINGW) #define SYMBOL_STRING_RELOCATION(name) @ #name @4 #else -#define SYMBOL_STRING_RELOCATION(name) #name +#define SYMBOL_STRING_RELOCATION(name) SYMBOL_STRING(name) #endif #if OS(DARWIN) ___ webkit-changes mailing list webkit-changes@lists.webkit.org
[webkit-changes] [98892] trunk/Source
Title: [98892] trunk/Source
Revision 98892
Author ander...@apple.com
Date 2011-10-31 15:51:19 -0700 (Mon, 31 Oct 2011)
Log Message
More work on making plug-ins work better with transforms
https://bugs.webkit.org/show_bug.cgi?id=71241
Reviewed by Darin Adler.
Source/WebCore:
Export symbols used by WebKit2.
* WebCore.exp.in:
Source/WebKit2:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
Implement NetscapePlugin::geometryDidChange and store the plug-in size,
the clip rect and the root view transform. Use the transform to compute the window
relative frame and clip rects.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add new member variables.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):
Always call the new Plugin::geometryDidChange.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98891 => 98892)
--- trunk/Source/WebCore/ChangeLog 2011-10-31 22:38:06 UTC (rev 98891)
+++ trunk/Source/WebCore/ChangeLog 2011-10-31 22:51:19 UTC (rev 98892)
@@ -1,3 +1,14 @@
+2011-10-31 Anders Carlsson ander...@apple.com
+
+More work on making plug-ins work better with transforms
+https://bugs.webkit.org/show_bug.cgi?id=71241
+
+Reviewed by Darin Adler.
+
+Export symbols used by WebKit2.
+
+* WebCore.exp.in:
+
2011-10-31 Mark Hahnenberg mhahnenb...@apple.com
De-virtualize JSObject::defineGetter
Modified: trunk/Source/WebCore/WebCore.exp.in (98891 => 98892)
--- trunk/Source/WebCore/WebCore.exp.in 2011-10-31 22:38:06 UTC (rev 98891)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-10-31 22:51:19 UTC (rev 98892)
@@ -402,6 +402,7 @@
__ZN7WebCore14StorageTracker32syncFileSystemAndTrackerDatabaseEv
__ZN7WebCore14endOfParagraphERKNS_15VisiblePositionENS_27EditingBoundaryCrossingRuleE
__ZN7WebCore15AffineTransformC1Edd
+__ZN7WebCore15AffineTransformC1Ev
__ZN7WebCore15ArchiveResource6createEN3WTF10PassRefPtrINS_12SharedBufferEEERKNS_4KURLERKNS1_6StringESA_SA_RKNS_16ResourceResponseE
__ZN7WebCore15DOMWrapperWorld13clearWrappersEv
__ZN7WebCore15DOMWrapperWorldD1Ev
@@ -1221,6 +1222,7 @@
__ZNK7WebCore14SecurityOrigin10canDisplayERKNS_4KURLE
__ZNK7WebCore14SecurityOrigin18databaseIdentifierEv
__ZNK7WebCore14SecurityOrigin5equalEPKS0_
+__ZNK7WebCore15AffineTransform8mapPointERKNS_8IntPointE
__ZNK7WebCore15FocusController18focusedOrMainFrameEv
__ZNK7WebCore15GraphicsContext15platformContextEv
__ZNK7WebCore15GraphicsContext16paintingDisabledEv
Modified: trunk/Source/WebKit2/ChangeLog (98891 => 98892)
--- trunk/Source/WebKit2/ChangeLog 2011-10-31 22:38:06 UTC (rev 98891)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 22:51:19 UTC (rev 98892)
@@ -1,3 +1,23 @@
+2011-10-31 Anders Carlsson ander...@apple.com
+
+More work on making plug-ins work better with transforms
+https://bugs.webkit.org/show_bug.cgi?id=71241
+
+Reviewed by Darin Adler.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::geometryDidChange):
+Implement NetscapePlugin::geometryDidChange and store the plug-in size,
+the clip rect and the root view transform. Use the transform to compute the window
+relative frame and clip rects.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.h:
+Add new member variables.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::viewGeometryDidChange):
+Always call the new Plugin::geometryDidChange.
+
2011-10-27 Anders Carlsson ander...@apple.com
Rename a couple of NetscapePlugin and PluginProxy member variables
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (98891 => 98892)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-31 22:38:06 UTC (rev 98891)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-31 22:51:19 UTC (rev 98892)
@@ -678,8 +678,25 @@
void NetscapePlugin::geometryDidChange(const IntSize pluginSize, const IntRect clipRect, const AffineTransform pluginToRootViewTransform)
{
-// FIXME: This isn't called yet.
-ASSERT_NOT_REACHED();
+ASSERT(m_isStarted);
+
+if (pluginSize == m_pluginSize m_clipRect == clipRect m_pluginToRootViewTransform == pluginToRootViewTransform) {
+// Nothing to do.
+return;
+}
+
+m_pluginSize = pluginSize;
+m_clipRect = clipRect;
+m_pluginToRootViewTransform = pluginToRootViewTransform;
+
+IntPoint frameRectLocationInWindowCoordinates = m_pluginToRootViewTransform.mapPoint(IntPoint());
+m_frameRectInWindowCoordinates =
[webkit-changes] [98893] trunk/Source/WebCore
Title: [98893] trunk/Source/WebCore Revision 98893 Author podivi...@chromium.org Date 2011-10-31 15:52:58 -0700 (Mon, 31 Oct 2011) Log Message Update XMLHttpRequest.send idl declaration to match implementation. https://bugs.webkit.org/show_bug.cgi?id=71121 Reviewed by Adam Barth. * xml/XMLHttpRequest.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/xml/XMLHttpRequest.idl Diff Modified: trunk/Source/WebCore/ChangeLog (98892 => 98893) --- trunk/Source/WebCore/ChangeLog 2011-10-31 22:51:19 UTC (rev 98892) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 22:52:58 UTC (rev 98893) @@ -1,3 +1,12 @@ +2011-10-31 Pavel Podivilov podivi...@chromium.org + +Update XMLHttpRequest.send idl declaration to match implementation. +https://bugs.webkit.org/show_bug.cgi?id=71121 + +Reviewed by Adam Barth. + +* xml/XMLHttpRequest.idl: + 2011-10-31 Anders Carlsson ander...@apple.com More work on making plug-ins work better with transforms Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (98892 => 98893) --- trunk/Source/WebCore/xml/XMLHttpRequest.idl 2011-10-31 22:51:19 UTC (rev 98892) +++ trunk/Source/WebCore/xml/XMLHttpRequest.idl 2011-10-31 22:52:58 UTC (rev 98893) @@ -71,10 +71,18 @@ void setRequestHeader(in DOMString header, in DOMString value) raises(DOMException); -// void send(); -// void send(in DOMString data); +[Custom] void send() +raises(DOMException); +[Custom] void send(in ArrayBuffer data) +raises(DOMException); +[Conditional=BLOB, Custom] void send(in Blob data) +raises(DOMException); [Custom] void send(in Document data) raises(DOMException); +[Custom] void send(in DOMString data) +raises(DOMException); +[Custom] void send(in DOMFormData data) +raises(DOMException); void abort(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98894] trunk/Source/WebKit2
Title: [98894] trunk/Source/WebKit2
Revision 98894
Author je...@apple.com
Date 2011-10-31 15:55:01 -0700 (Mon, 31 Oct 2011)
Log Message
Add more APIs to WKUserContentURLPattern.h
https://bugs.webkit.org/show_bug.cgi?id=71245
Add additional WKUserContentURLPattern APIs to match what was provided by
the equivalent WebKit1 API.
Reviewed by Darin Adler.
* Shared/API/c/WKUserContentURLPattern.cpp:
(WKUserContentURLPatternCopyHost): Added.
(WKUserContentURLPatternCopyScheme): Added.
(WKUserContentURLPatternIsValid): Added.
(WKUserContentURLPatternMatchesSubdomains): Added.
* Shared/API/c/WKUserContentURLPattern.h: Added new APIs.
* Shared/WebUserContentURLPattern.h:
(WebKit::WebUserContentURLPattern::host): Added.
(WebKit::WebUserContentURLPattern::scheme): Added.
(WebKit::WebUserContentURLPattern::isValid): Added.
(WebKit::WebUserContentURLPattern::matchesSubdomains): Added.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.cpp
trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h
trunk/Source/WebKit2/Shared/WebUserContentURLPattern.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98893 => 98894)
--- trunk/Source/WebKit2/ChangeLog 2011-10-31 22:52:58 UTC (rev 98893)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 22:55:01 UTC (rev 98894)
@@ -1,3 +1,27 @@
+2011-10-31 Jeff Miller je...@apple.com
+
+Add more APIs to WKUserContentURLPattern.h
+https://bugs.webkit.org/show_bug.cgi?id=71245
+
+Add additional WKUserContentURLPattern APIs to match what was provided by
+the equivalent WebKit1 API.
+
+Reviewed by Darin Adler.
+
+* Shared/API/c/WKUserContentURLPattern.cpp:
+(WKUserContentURLPatternCopyHost): Added.
+(WKUserContentURLPatternCopyScheme): Added.
+(WKUserContentURLPatternIsValid): Added.
+(WKUserContentURLPatternMatchesSubdomains): Added.
+
+* Shared/API/c/WKUserContentURLPattern.h: Added new APIs.
+
+* Shared/WebUserContentURLPattern.h:
+(WebKit::WebUserContentURLPattern::host): Added.
+(WebKit::WebUserContentURLPattern::scheme): Added.
+(WebKit::WebUserContentURLPattern::isValid): Added.
+(WebKit::WebUserContentURLPattern::matchesSubdomains): Added.
+
2011-10-31 Anders Carlsson ander...@apple.com
More work on making plug-ins work better with transforms
Modified: trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.cpp (98893 => 98894)
--- trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.cpp 2011-10-31 22:52:58 UTC (rev 98893)
+++ trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.cpp 2011-10-31 22:55:01 UTC (rev 98894)
@@ -27,6 +27,7 @@
#include WKUserContentURLPattern.h
#include WKAPICast.h
+#include WKString.h
#include WebUserContentURLPattern.h
using namespace WebKit;
@@ -42,7 +43,27 @@
return toAPI(userContentURLPattern.release().leakRef());
}
+WKStringRef WKUserContentURLPatternCopyHost(WKUserContentURLPatternRef urlPatternRef)
+{
+return toCopiedAPI(toImpl(urlPatternRef)-host());
+}
+
+WKStringRef WKUserContentURLPatternCopyScheme(WKUserContentURLPatternRef urlPatternRef)
+{
+return toCopiedAPI(toImpl(urlPatternRef)-scheme());
+}
+
+bool WKUserContentURLPatternIsValid(WKUserContentURLPatternRef urlPatternRef)
+{
+return toImpl(urlPatternRef)-isValid();
+}
+
bool WKUserContentURLPatternMatchesURL(WKUserContentURLPatternRef urlPatternRef, WKURLRef urlRef)
{
return toImpl(urlPatternRef)-matchesURL(toWTFString(urlRef));
}
+
+bool WKUserContentURLPatternMatchesSubdomains(WKUserContentURLPatternRef urlPatternRef)
+{
+return toImpl(urlPatternRef)-matchesSubdomains();
+}
Modified: trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h (98893 => 98894)
--- trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h 2011-10-31 22:52:58 UTC (rev 98893)
+++ trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h 2011-10-31 22:55:01 UTC (rev 98894)
@@ -37,7 +37,11 @@
WK_EXPORT WKUserContentURLPatternRef WKUserContentURLPatternCreate(WKStringRef patternRef);
+WK_EXPORT WKStringRef WKUserContentURLPatternCopyHost(WKUserContentURLPatternRef urlPatternRef);
+WK_EXPORT WKStringRef WKUserContentURLPatternCopyScheme(WKUserContentURLPatternRef urlPatternRef);
+WK_EXPORT bool WKUserContentURLPatternIsValid(WKUserContentURLPatternRef urlPatternRef);
WK_EXPORT bool WKUserContentURLPatternMatchesURL(WKUserContentURLPatternRef urlPatternRef, WKURLRef urlRef);
+WK_EXPORT bool WKUserContentURLPatternMatchesSubdomains(WKUserContentURLPatternRef urlPatternRef);
#ifdef __cplusplus
}
Modified: trunk/Source/WebKit2/Shared/WebUserContentURLPattern.h (98893 => 98894)
--- trunk/Source/WebKit2/Shared/WebUserContentURLPattern.h 2011-10-31 22:52:58 UTC (rev 98893)
+++ trunk/Source/WebKit2/Shared/WebUserContentURLPattern.h 2011-10-31 22:55:01 UTC (rev 98894)
@@ -43,7 +43,11 @@
[webkit-changes] [98896] trunk
Title: [98896] trunk Revision 98896 Author commit-qu...@webkit.org Date 2011-10-31 16:02:48 -0700 (Mon, 31 Oct 2011) Log Message text/plain form encoding ignored and incorrectly specified in request header. https://bugs.webkit.org/show_bug.cgi?id=20795 Patch by Vineet Chaudhary vineet.chaudh...@motorola.com on 2011-10-31 Reviewed by Darin Adler. Source/WebCore: This patch fixes the behaviour of forms where enctype is set to text/plain, encoding is also text/plain. Tests: fast/forms/form-get-textplain.html http/tests/misc/form-post-textplain.html * loader/FormSubmission.cpp: (WebCore::FormSubmission::create): * platform/network/FormData.cpp: (WebCore::FormData::create): (WebCore::FormData::appendKeyValuePairItems): * platform/network/FormData.h: (WebCore::FormData::parseEncodingType): * platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::addKeyValuePairAsFormData): Modified encoding scheme for text/plain. * platform/network/FormDataBuilder.h: LayoutTests: Added tests for GET and POST methods for text/plain enctype. Forms submitted using GET with a content-type of text/plain actually, send data in URL encoded in the URL. Forms with POST method and content-type of text/plain actually send data in text/plain. Modified expected results for mailto tests as per the new behavior. * fast/forms/form-get-textplain-expected.txt: Added. * fast/forms/form-get-textplain.html: Added. * fast/forms/mailto/post-multiple-items-text-plain-expected.txt: * fast/forms/mailto/post-text-plain-expected.txt: * fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt: * http/tests/misc/form-post-textplain-expected.txt: Added. * http/tests/misc/form-post-textplain.html: Added. * http/tests/misc/resources/form-post-textplain.php: Added. * platform/chromium/test_expectations.txt: * platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: * platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: * platform/qt/test_expectations.txt: * platform/win/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/mailto/post-multiple-items-text-plain-expected.txt trunk/LayoutTests/fast/forms/mailto/post-text-plain-expected.txt trunk/LayoutTests/fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt trunk/LayoutTests/platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt trunk/LayoutTests/platform/qt/test_expectations.txt trunk/LayoutTests/platform/win/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/FormSubmission.cpp trunk/Source/WebCore/platform/network/FormData.cpp trunk/Source/WebCore/platform/network/FormData.h trunk/Source/WebCore/platform/network/FormDataBuilder.cpp trunk/Source/WebCore/platform/network/FormDataBuilder.h Added Paths trunk/LayoutTests/fast/forms/form-get-textplain-expected.txt trunk/LayoutTests/fast/forms/form-get-textplain.html trunk/LayoutTests/http/tests/misc/form-post-textplain-expected.txt trunk/LayoutTests/http/tests/misc/form-post-textplain.html trunk/LayoutTests/http/tests/misc/resources/form-post-textplain.php Diff Modified: trunk/LayoutTests/ChangeLog (98895 => 98896) --- trunk/LayoutTests/ChangeLog 2011-10-31 23:00:42 UTC (rev 98895) +++ trunk/LayoutTests/ChangeLog 2011-10-31 23:02:48 UTC (rev 98896) @@ -1,3 +1,30 @@ +2011-10-31 Vineet Chaudhary vineet.chaudh...@motorola.com + +text/plain form encoding ignored and incorrectly specified in request header. +https://bugs.webkit.org/show_bug.cgi?id=20795 + +Reviewed by Darin Adler. + +Added tests for GET and POST methods for text/plain enctype. +Forms submitted using GET with a content-type of text/plain actually, +send data in URL encoded in the URL. +Forms with POST method and content-type of text/plain actually send data in text/plain. +Modified expected results for mailto tests as per the new behavior. + +* fast/forms/form-get-textplain-expected.txt: Added. +* fast/forms/form-get-textplain.html: Added. +* fast/forms/mailto/post-multiple-items-text-plain-expected.txt: +* fast/forms/mailto/post-text-plain-expected.txt: +* fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt: +* http/tests/misc/form-post-textplain-expected.txt: Added. +* http/tests/misc/form-post-textplain.html: Added. +* http/tests/misc/resources/form-post-textplain.php: Added. +* platform/chromium/test_expectations.txt: +* platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: +* platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: +* platform/qt/test_expectations.txt: +* platform/win/test_expectations.txt: +
[webkit-changes] [98897] trunk/Source/WebKit2
Title: [98897] trunk/Source/WebKit2
Revision 98897
Author ander...@apple.com
Date 2011-10-31 16:07:12 -0700 (Mon, 31 Oct 2011)
Log Message
Factor code to resize the plug-in backing store out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=71250
Reviewed by Adam Roben.
Add a PluginProxy::contentsScaleFactor helper function to get rid of a bunch of PLATFORM(MAC) #ifdefs,
and move the code to update the backing store out into a separate function.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::contentsScaleFactor):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::update):
* WebProcess/Plugins/PluginProxy.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98896 => 98897)
--- trunk/Source/WebKit2/ChangeLog 2011-10-31 23:02:48 UTC (rev 98896)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 23:07:12 UTC (rev 98897)
@@ -1,3 +1,22 @@
+2011-10-31 Anders Carlsson ander...@apple.com
+
+Factor code to resize the plug-in backing store out into a separate function
+https://bugs.webkit.org/show_bug.cgi?id=71250
+
+Reviewed by Adam Roben.
+
+Add a PluginProxy::contentsScaleFactor helper function to get rid of a bunch of PLATFORM(MAC) #ifdefs,
+and move the code to update the backing store out into a separate function.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::initialize):
+(WebKit::PluginProxy::paint):
+(WebKit::PluginProxy::geometryDidChange):
+(WebKit::PluginProxy::contentsScaleFactor):
+(WebKit::PluginProxy::updateBackingStore):
+(WebKit::PluginProxy::update):
+* WebProcess/Plugins/PluginProxy.h:
+
2011-10-31 Jeff Miller je...@apple.com
Add more APIs to WKUserContentURLPattern.h
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (98896 => 98897)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-31 23:02:48 UTC (rev 98896)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-31 23:07:12 UTC (rev 98897)
@@ -102,7 +102,7 @@
creationParameters.isAcceleratedCompositingEnabled = controller()-isAcceleratedCompositingEnabled();
#endif
#if PLATFORM(MAC)
-creationParameters.contentsScaleFactor = controller()-contentsScaleFactor();
+creationParameters.contentsScaleFactor = contentsScaleFactor();
#endif
bool result = false;
@@ -135,21 +135,15 @@
if (!needsBackingStore() || !m_backingStore)
return;
-#if PLATFORM(MAC)
-float contentsScaleFactor = controller()-contentsScaleFactor();
-#else
-float contentsScaleFactor = 1;
-#endif
-
if (!m_pluginBackingStoreContainsValidData) {
m_connection-connection()-sendSync(Messages::PluginControllerProxy::PaintEntirePlugin(), Messages::PluginControllerProxy::PaintEntirePlugin::Reply(), m_pluginInstanceID);
// Blit the plug-in backing store into our own backing store.
OwnPtrWebCore::GraphicsContext graphicsContext = m_backingStore-createGraphicsContext();
-graphicsContext-applyDeviceScaleFactor(contentsScaleFactor);
+graphicsContext-applyDeviceScaleFactor(contentsScaleFactor());
graphicsContext-setCompositeOperation(CompositeCopy);
-m_pluginBackingStore-paint(*graphicsContext, contentsScaleFactor, IntPoint(), IntRect(0, 0, m_frameRectInWindowCoordinates.width(), m_frameRectInWindowCoordinates.height()));
+m_pluginBackingStore-paint(*graphicsContext, contentsScaleFactor(), IntPoint(), IntRect(0, 0, m_frameRectInWindowCoordinates.width(), m_frameRectInWindowCoordinates.height()));
m_pluginBackingStoreContainsValidData = true;
}
@@ -157,7 +151,7 @@
IntRect dirtyRectInPluginCoordinates = dirtyRect;
dirtyRectInPluginCoordinates.move(-m_frameRectInWindowCoordinates.x(), -m_frameRectInWindowCoordinates.y());
-m_backingStore-paint(*graphicsContext, contentsScaleFactor, dirtyRect.location(), dirtyRectInPluginCoordinates);
+m_backingStore-paint(*graphicsContext, contentsScaleFactor(), dirtyRect.location(), dirtyRectInPluginCoordinates);
if (m_waitingForPaintInResponseToUpdate) {
m_waitingForPaintInResponseToUpdate = false;
@@ -186,38 +180,17 @@
{
ASSERT(m_isStarted);
-#if PLATFORM(MAC)
-float contentsScaleFactor = controller()-contentsScaleFactor();
-#else
-float contentsScaleFactor = 1;
-#endif
-
if (m_frameRectInWindowCoordinates.isEmpty() || !needsBackingStore()) {
ShareableBitmap::Handle pluginBackingStoreHandle;
-m_connection-connection()-send(Messages::PluginControllerProxy::GeometryDidChange(m_frameRectInWindowCoordinates, m_clipRectInWindowCoordinates, contentsScaleFactor,
[webkit-changes] [98898] trunk/Source/WebKit2
Title: [98898] trunk/Source/WebKit2
Revision 98898
Author ander...@apple.com
Date 2011-10-31 16:08:28 -0700 (Mon, 31 Oct 2011)
Log Message
Fix the X11 build.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98897 => 98898)
--- trunk/Source/WebKit2/ChangeLog 2011-10-31 23:07:12 UTC (rev 98897)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 23:08:28 UTC (rev 98898)
@@ -1,5 +1,17 @@
2011-10-31 Anders Carlsson ander...@apple.com
+Fix the X11 build.
+
+* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+(WebKit::NetscapePlugin::platformGeometryDidChange):
+(WebKit::NetscapePlugin::platformPaint):
+(WebKit::NetscapePlugin::platformHandleMouseEvent):
+(WebKit::NetscapePlugin::platformHandleWheelEvent):
+(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
+(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
+
+2011-10-31 Anders Carlsson ander...@apple.com
+
Factor code to resize the plug-in backing store out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=71250
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (98897 => 98898)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-10-31 23:07:12 UTC (rev 98897)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-10-31 23:08:28 UTC (rev 98898)
@@ -213,12 +213,12 @@
if (m_drawable)
XFreePixmap(display, m_drawable);
-if (m_frameRect.isEmpty()) {
+if (m_frameRectInWindowCoordinates.isEmpty()) {
m_drawable = 0;
return;
}
-m_drawable = XCreatePixmap(display, rootWindowID(), m_frameRect.width(), m_frameRect.height(), displayDepth());
+m_drawable = XCreatePixmap(display, rootWindowID(), m_frameRectInWindowCoordinates.width(), m_frameRectInWindowCoordinates.height(), displayDepth());
XSync(display, false); // Make sure that the server knows about the Drawable.
}
@@ -245,7 +245,7 @@
#if PLATFORM(QT)
QPainter* painter = context-platformContext();
-painter-translate(m_frameRect.x(), m_frameRect.y());
+painter-translate(m_frameRectInWindowCoordinates.x(), m_frameRectInWindowCoordinates.y());
#elif !PLATFORM(GTK)
notImplemented();
return;
@@ -259,8 +259,8 @@
exposeEvent.drawable = m_drawable;
IntRect exposedRect(dirtyRect);
-exposedRect.intersect(m_frameRect);
-exposedRect.move(-m_frameRect.x(), -m_frameRect.y());
+exposedRect.intersect(m_frameRectInWindowCoordinates);
+exposedRect.move(-m_frameRectInWindowCoordinates.x(), -m_frameRectInWindowCoordinates.y());
exposeEvent.x = exposedRect.x();
exposeEvent.y = exposedRect.y();
@@ -279,19 +279,19 @@
ASSERT(qtDrawable.depth() == static_castNPSetWindowCallbackStruct*(m_npWindow.ws_info)-depth);
painter-drawPixmap(QPoint(exposedRect.x(), exposedRect.y()), qtDrawable, exposedRect);
-painter-translate(-m_frameRect.x(), -m_frameRect.y());
+painter-translate(-m_frameRectInWindowCoordinates.x(), -m_frameRectInWindowCoordinates.y());
#elif PLATFORM(GTK)
RefPtrcairo_surface_t drawableSurface = adoptRef(cairo_xlib_surface_create(m_pluginDisplay,
m_drawable,
static_castNPSetWindowCallbackStruct*(m_npWindow.ws_info)-visual,
- m_frameRect.width(),
- m_frameRect.height()));
+ m_frameRectInWindowCoordinates.width(),
+ m_frameRectInWindowCoordinates.height()));
cairo_t* cr = context-platformContext()-cr();
cairo_save(cr);
-cairo_set_source_surface(cr, drawableSurface.get(), m_frameRect.x(), m_frameRect.y());
+cairo_set_source_surface(cr, drawableSurface.get(), m_frameRectInWindowCoordinates.x(), m_frameRectInWindowCoordinates.y());
-cairo_rectangle(cr, m_frameRect.x() + exposedRect.x(), m_frameRect.y() + exposedRect.y(), exposedRect.width(), exposedRect.height());
+cairo_rectangle(cr, m_frameRectInWindowCoordinates.x() + exposedRect.x(), m_frameRectInWindowCoordinates.y()
[webkit-changes] [98899] trunk
Title: [98899] trunk Revision 98899 Author rn...@webkit.org Date 2011-10-31 16:09:12 -0700 (Mon, 31 Oct 2011) Log Message WebKit nests pre on copy and paste when the pre is the root editable element https://bugs.webkit.org/show_bug.cgi?id=70800 Reviewed by Darin Adler. Source/WebCore: Fixed the bug by removing nested block elements in removeRedundantStylesAndKeepStyleSpanInline. Tests: editing/pasteboard/contenteditable-pre-2.html editing/pasteboard/contenteditable-pre.html * editing/ApplyStyleCommand.cpp: * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Remove block elements if it's identical to its parent and there are no contents between the two. Also remove contenteditable attribute from an element if the parent is already richly editable. (WebCore::ReplaceSelectionCommand::doApply): Remove redundant styles after removing the placeholder br so that the above check doesn't get affected by the placeholder. * editing/htmlediting.cpp: (WebCore::areIdenticalElements): Moved from ApplyStyleCommand. (WebCore::isNonTableCellHTMLBlockElement): Moved from markup.cpp. * editing/htmlediting.h: * editing/markup.cpp: LayoutTests: Added tests for copying and pasting contents inside pre. WebKit should not nest pre's. * editing/execCommand/insert-list-with-noneditable-content-expected.txt: A redundant contenteditable attribute is removed. * editing/pasteboard/4930986-2-expected.txt: Trailing space in style attribute is removed. * editing/pasteboard/contenteditable-pre-2-expected.txt: Added. * editing/pasteboard/contenteditable-pre-2.html: Added. * editing/pasteboard/contenteditable-pre-expected.txt: Added. * editing/pasteboard/contenteditable-pre.html: Added. * editing/pasteboard/copy-null-characters-expected.txt: A redundant contenteditable attribute is removed. * editing/pasteboard/paste-code-in-pre-expected.txt: Pre no longer nests itself erroneously. * editing/pasteboard/paste-pre-001-expected.txt: Ditto. * editing/pasteboard/paste-pre-002-expected.txt: Ditto. * editing/selection/4895428-4-expected.txt: A redundant contenteditable attribute is removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/execCommand/insert-list-with-noneditable-content-expected.txt trunk/LayoutTests/editing/pasteboard/4930986-2-expected.txt trunk/LayoutTests/editing/pasteboard/copy-null-characters-expected.txt trunk/LayoutTests/editing/pasteboard/paste-code-in-pre-expected.txt trunk/LayoutTests/editing/pasteboard/paste-pre-001-expected.txt trunk/LayoutTests/editing/pasteboard/paste-pre-002-expected.txt trunk/LayoutTests/editing/selection/4895428-4-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/ApplyStyleCommand.cpp trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp trunk/Source/WebCore/editing/htmlediting.cpp trunk/Source/WebCore/editing/htmlediting.h trunk/Source/WebCore/editing/markup.cpp Added Paths trunk/LayoutTests/editing/pasteboard/contenteditable-pre-2-expected.txt trunk/LayoutTests/editing/pasteboard/contenteditable-pre-2.html trunk/LayoutTests/editing/pasteboard/contenteditable-pre-expected.txt trunk/LayoutTests/editing/pasteboard/contenteditable-pre.html Diff Modified: trunk/LayoutTests/ChangeLog (98898 => 98899) --- trunk/LayoutTests/ChangeLog 2011-10-31 23:08:28 UTC (rev 98898) +++ trunk/LayoutTests/ChangeLog 2011-10-31 23:09:12 UTC (rev 98899) @@ -1,3 +1,26 @@ +2011-10-29 Ryosuke Niwa rn...@webkit.org + +WebKit nests pre on copy and paste when the pre is the root editable element +https://bugs.webkit.org/show_bug.cgi?id=70800 + +Reviewed by Darin Adler. + +Added tests for copying and pasting contents inside pre. WebKit should not nest pre's. + +* editing/execCommand/insert-list-with-noneditable-content-expected.txt: A redundant +contenteditable attribute is removed. +* editing/pasteboard/4930986-2-expected.txt: Trailing space in style attribute is removed. +* editing/pasteboard/contenteditable-pre-2-expected.txt: Added. +* editing/pasteboard/contenteditable-pre-2.html: Added. +* editing/pasteboard/contenteditable-pre-expected.txt: Added. +* editing/pasteboard/contenteditable-pre.html: Added. +* editing/pasteboard/copy-null-characters-expected.txt: A redundant contenteditable attribute +is removed. +* editing/pasteboard/paste-code-in-pre-expected.txt: Pre no longer nests itself erroneously. +* editing/pasteboard/paste-pre-001-expected.txt: Ditto. +* editing/pasteboard/paste-pre-002-expected.txt: Ditto. +* editing/selection/4895428-4-expected.txt: A redundant contenteditable attribute is removed. + 2011-10-31 Vineet Chaudhary vineet.chaudh...@motorola.com text/plain form encoding ignored and incorrectly specified in request header. Modified:
[webkit-changes] [98900] trunk/Source/WebKit/chromium
Title: [98900] trunk/Source/WebKit/chromium
Revision 98900
Author commit-qu...@webkit.org
Date 2011-10-31 16:09:39 -0700 (Mon, 31 Oct 2011)
Log Message
IndexedDB: Remove null key support (part 2)
https://bugs.webkit.org/show_bug.cgi?id=71132
Patch by Joshua Bell jsb...@chromium.org on 2011-10-31
Reviewed by Darin Fisher.
* public/WebIDBKey.h:
* src/AssertMatchingEnums.cpp:
* src/WebIDBKey.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBKey.h
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/WebIDBKey.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98899 => 98900)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-31 23:09:12 UTC (rev 98899)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-31 23:09:39 UTC (rev 98900)
@@ -1,3 +1,14 @@
+2011-10-31 Joshua Bell jsb...@chromium.org
+
+IndexedDB: Remove null key support (part 2)
+https://bugs.webkit.org/show_bug.cgi?id=71132
+
+Reviewed by Darin Fisher.
+
+* public/WebIDBKey.h:
+* src/AssertMatchingEnums.cpp:
+* src/WebIDBKey.cpp:
+
2011-10-31 Pavel Feldman pfeld...@google.com
Web Inspector: move localization support into UIUtil.js, reduce externs.
Modified: trunk/Source/WebKit/chromium/public/WebIDBKey.h (98899 => 98900)
--- trunk/Source/WebKit/chromium/public/WebIDBKey.h 2011-10-31 23:09:12 UTC (rev 98899)
+++ trunk/Source/WebKit/chromium/public/WebIDBKey.h 2011-10-31 23:09:39 UTC (rev 98900)
@@ -43,7 +43,6 @@
WebIDBKey() { }
~WebIDBKey() { reset(); }
-WEBKIT_EXPORT static WebIDBKey createNull();
WEBKIT_EXPORT static WebIDBKey createString(const WebString);
WEBKIT_EXPORT static WebIDBKey createDate(double);
WEBKIT_EXPORT static WebIDBKey createNumber(double);
@@ -59,7 +58,6 @@
}
WEBKIT_EXPORT void assign(const WebIDBKey);
-WEBKIT_EXPORT void assignNull();
WEBKIT_EXPORT void assignString(const WebString);
WEBKIT_EXPORT void assignDate(double);
WEBKIT_EXPORT void assignNumber(double);
@@ -67,12 +65,10 @@
WEBKIT_EXPORT void reset();
enum Type {
-NullType = 0,
+InvalidType = 0,
StringType,
DateType,
-NumberType,
-// Types not in WebCore::IDBKey:
-InvalidType
+NumberType
};
WEBKIT_EXPORT Type type() const;
Modified: trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp (98899 => 98900)
--- trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp 2011-10-31 23:09:12 UTC (rev 98899)
+++ trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp 2011-10-31 23:09:39 UTC (rev 98900)
@@ -396,9 +396,7 @@
COMPILE_ASSERT_MATCHING_ENUM(WebView::UserStyleInjectInExistingDocuments, InjectInExistingDocuments);
COMPILE_ASSERT_MATCHING_ENUM(WebView::UserStyleInjectInSubsequentDocuments, InjectInSubsequentDocuments);
-// FIXME: Temporary; WebIDBKey::NullType will be removed in a subsequent patch.
-// https://bugs.webkit.org/show_bug.cgi?id=70065
-COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::NullType, IDBKey::InvalidType);
+COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::InvalidType, IDBKey::InvalidType);
COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::StringType, IDBKey::StringType);
COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::DateType, IDBKey::DateType);
COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::NumberType, IDBKey::NumberType);
Modified: trunk/Source/WebKit/chromium/src/WebIDBKey.cpp (98899 => 98900)
--- trunk/Source/WebKit/chromium/src/WebIDBKey.cpp 2011-10-31 23:09:12 UTC (rev 98899)
+++ trunk/Source/WebKit/chromium/src/WebIDBKey.cpp 2011-10-31 23:09:39 UTC (rev 98900)
@@ -41,13 +41,6 @@
namespace WebKit {
-WebIDBKey WebIDBKey::createNull()
-{
-WebIDBKey key;
-key.assignNull();
-return key;
-}
-
WebIDBKey WebIDBKey::createString(const WebString string)
{
WebIDBKey key;
@@ -93,11 +86,6 @@
m_private = value.m_private;
}
-void WebIDBKey::assignNull()
-{
-m_private = 0;
-}
-
void WebIDBKey::assignString(const WebString string)
{
m_private = IDBKey::createString(string);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98902] trunk/LayoutTests
Title: [98902] trunk/LayoutTests Revision 98902 Author john...@google.com Date 2011-10-31 16:18:13 -0700 (Mon, 31 Oct 2011) Log Message Chromium rebaselines, unreviewed. * platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: * platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: * platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: * platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: * platform/chromium-gpu-win/media/audio-repaint-expected.txt: Removed. * platform/chromium-linux-x86/svg/zoom/page: Added. * platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added. * platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added. * platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added. * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png Added Paths trunk/LayoutTests/platform/chromium-linux-x86/svg/zoom/page/ trunk/LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png trunk/LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png trunk/LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-gpu-win/media/audio-repaint-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98901 => 98902) --- trunk/LayoutTests/ChangeLog 2011-10-31 23:12:04 UTC (rev 98901) +++ trunk/LayoutTests/ChangeLog 2011-10-31 23:18:13 UTC (rev 98902) @@ -1,3 +1,20 @@ +2011-10-31 John Gregg john...@google.com + +Chromium rebaselines, unreviewed. + +* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: +* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: +* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: +* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: +* platform/chromium-gpu-win/media/audio-repaint-expected.txt: Removed. +* platform/chromium-linux-x86/svg/zoom/page: Added. +* platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added. +* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added. +* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added. +* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: +* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added. +* platform/chromium/test_expectations.txt: + 2011-10-31 Ryosuke Niwa rn...@webkit.org Mac rebaseline after r98852. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98901 => 98902) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 23:12:04 UTC (rev 98901) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-31 23:18:13 UTC (rev 98902) @@ -3942,5 +3942,6 @@ BUGWK71226 : svg/zoom/page/zoom-coords-viewattr-01-b.svg = IMAGE+TEXT BUGWK71226 : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE+TEXT BUGWK71226 : fast/backgrounds/animated-svg-as-mask.html = IMAGE+TEXT IMAGE - + BUGWK71233 : inspector/debugger/bind-script-to-resource.html = TEXT + Modified: trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png (Binary files differ) Modified:
[webkit-changes] [98903] trunk/Source/JavaScriptCore
Title: [98903] trunk/Source/_javascript_Core
Revision 98903
Author commit-qu...@webkit.org
Date 2011-10-31 16:18:49 -0700 (Mon, 31 Oct 2011)
Log Message
WTF::StringImpl::create(const char*, unsigned) calls itself
https://bugs.webkit.org/show_bug.cgi?id=71206
The original implementation just calls itself, causing infinite recursion.
Cast the first parameter to const LChar* to fix that.
Patch by Xianzhu Wang wangxian...@chromium.org on 2011-10-31
Reviewed by Ryosuke Niwa.
* wtf/text/StringImpl.h:
(WTF::StringImpl::create):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/text/StringImpl.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98902 => 98903)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-31 23:18:13 UTC (rev 98902)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-31 23:18:49 UTC (rev 98903)
@@ -1,3 +1,16 @@
+2011-10-31 Xianzhu Wang wangxian...@chromium.org
+
+WTF::StringImpl::create(const char*, unsigned) calls itself
+https://bugs.webkit.org/show_bug.cgi?id=71206
+
+The original implementation just calls itself, causing infinite recursion.
+Cast the first parameter to const LChar* to fix that.
+
+Reviewed by Ryosuke Niwa.
+
+* wtf/text/StringImpl.h:
+(WTF::StringImpl::create):
+
2011-10-31 Andy Wingo wi...@igalia.com
Fix DFG JIT compilation on Linux targets.
Modified: trunk/Source/_javascript_Core/wtf/text/StringImpl.h (98902 => 98903)
--- trunk/Source/_javascript_Core/wtf/text/StringImpl.h 2011-10-31 23:18:13 UTC (rev 98902)
+++ trunk/Source/_javascript_Core/wtf/text/StringImpl.h 2011-10-31 23:18:49 UTC (rev 98903)
@@ -182,9 +182,9 @@
static PassRefPtrStringImpl create(const UChar*, unsigned length);
static PassRefPtrStringImpl create(const LChar*, unsigned length);
-ALWAYS_INLINE static PassRefPtrStringImpl create(const char* s, unsigned length) { return create(s, length); };
+ALWAYS_INLINE static PassRefPtrStringImpl create(const char* s, unsigned length) { return create(reinterpret_castconst LChar*(s), length); }
static PassRefPtrStringImpl create(const LChar*);
-ALWAYS_INLINE static PassRefPtrStringImpl create(const char* s) { return create(reinterpret_castconst LChar*(s)); };
+ALWAYS_INLINE static PassRefPtrStringImpl create(const char* s) { return create(reinterpret_castconst LChar*(s)); }
static ALWAYS_INLINE PassRefPtrStringImpl create8(PassRefPtrStringImpl rep, unsigned offset, unsigned length)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98904] branches/safari-534.52-branch/Source/WebCore
Title: [98904] branches/safari-534.52-branch/Source/WebCore
Revision 98904
Author lforsch...@apple.com
Date 2011-10-31 16:19:19 -0700 (Mon, 31 Oct 2011)
Log Message
Updated fix for r98470.
Modified Paths
branches/safari-534.52-branch/Source/WebCore/ChangeLog
branches/safari-534.52-branch/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
Diff
Modified: branches/safari-534.52-branch/Source/WebCore/ChangeLog (98903 => 98904)
--- branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-31 23:18:49 UTC (rev 98903)
+++ branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-31 23:19:19 UTC (rev 98904)
@@ -1,3 +1,12 @@
+2011-10-31 Matthew Delaney mdela...@apple.com
+
+Updating patch for revision 98470 to include proper flag name.
+
+Reviewed by Mark Rowe.
+
+* platform/graphics/cg/ImageBufferCG.cpp:
+(WebCore::ImageBuffer::context): Updated flag name.
+
2011-10-31 Lucas Forschler lforsch...@apple.com
Merge 98389
Modified: branches/safari-534.52-branch/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp (98903 => 98904)
--- branches/safari-534.52-branch/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp 2011-10-31 23:18:49 UTC (rev 98903)
+++ branches/safari-534.52-branch/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp 2011-10-31 23:19:19 UTC (rev 98904)
@@ -177,7 +177,7 @@
GraphicsContext* ImageBuffer::context() const
{
// Force a flush if last flush was more than 20ms ago
-if (m_context-isAcceleratedContext()) {
+if (m_accelerateRendering) {
double elapsedTime = currentTimeMS() - m_data.m_lastFlushTime;
double maxFlushInterval = 20; // in ms
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98901] trunk/LayoutTests
Title: [98901] trunk/LayoutTests
Revision 98901
Author rn...@webkit.org
Date 2011-10-31 16:12:04 -0700 (Mon, 31 Oct 2011)
Log Message
Mac rebaseline after r98852.
* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98900 => 98901)
--- trunk/LayoutTests/ChangeLog 2011-10-31 23:09:39 UTC (rev 98900)
+++ trunk/LayoutTests/ChangeLog 2011-10-31 23:12:04 UTC (rev 98901)
@@ -1,3 +1,9 @@
+2011-10-31 Ryosuke Niwa rn...@webkit.org
+
+Mac rebaseline after r98852.
+
+* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
+
2011-10-29 Ryosuke Niwa rn...@webkit.org
WebKit nests pre on copy and paste when the pre is the root editable element
Modified: trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt (98900 => 98901)
--- trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt 2011-10-31 23:09:39 UTC (rev 98900)
+++ trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt 2011-10-31 23:12:04 UTC (rev 98901)
@@ -1,4 +1,4 @@
-layer at (0,0) size 982x3040
+layer at (0,0) size 983x3040
RenderView at (0,0) size 785x585
layer at (0,0) size 785x3040
RenderBlock {HTML} at (0,0) size 785x3040
@@ -12,7 +12,7 @@
text run at (0,0) width 541: percentage height images in DIV with no height (red) in a DIV with no height (green)
RenderBlock {DIV} at (32,750) size 657x672 [border: (3px dotted #008000)]
RenderBlock {DIV} at (35,35) size 587x602 [border: (1px solid #FF)]
- RenderImage {IMG} at (1,1) size 882x600
+ RenderImage {IMG} at (1,1) size 883x600
RenderText {#text} at (0,0) size 0x0
RenderBlock {P} at (0,1454) size 721x18
RenderText {#text} at (0,0) size 471x18
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98905] trunk/Source/WebKit2
Title: [98905] trunk/Source/WebKit2
Revision 98905
Author ander...@apple.com
Date 2011-10-31 16:28:37 -0700 (Mon, 31 Oct 2011)
Log Message
Implement PluginProxy::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71251
Reviewed by Sam Weinig.
Keep track of the plug-in size, the clip rect in plug-in coordinates and the
transformation matrix from the root view to the plug-in.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
* WebProcess/Plugins/PluginProxy.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98904 => 98905)
--- trunk/Source/WebKit2/ChangeLog 2011-10-31 23:19:19 UTC (rev 98904)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 23:28:37 UTC (rev 98905)
@@ -1,5 +1,19 @@
2011-10-31 Anders Carlsson ander...@apple.com
+Implement PluginProxy::geometryDidChange
+https://bugs.webkit.org/show_bug.cgi?id=71251
+
+Reviewed by Sam Weinig.
+
+Keep track of the plug-in size, the clip rect in plug-in coordinates and the
+transformation matrix from the root view to the plug-in.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::geometryDidChange):
+* WebProcess/Plugins/PluginProxy.h:
+
+2011-10-31 Anders Carlsson ander...@apple.com
+
Fix the X11 build.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (98904 => 98905)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-31 23:19:19 UTC (rev 98904)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-31 23:28:37 UTC (rev 98905)
@@ -216,7 +216,14 @@
void PluginProxy::geometryDidChange(const IntSize pluginSize, const IntRect clipRect, const AffineTransform pluginToRootViewTransform)
{
-// FIXME: Actually do something here.
+if (pluginSize == m_pluginSize m_clipRect == clipRect m_pluginToRootViewTransform == pluginToRootViewTransform) {
+// Nothing to do.
+return;
+}
+
+m_pluginSize = pluginSize;
+m_clipRect = clipRect;
+m_pluginToRootViewTransform = pluginToRootViewTransform;
}
void PluginProxy::visibilityDidChange()
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h (98904 => 98905)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h 2011-10-31 23:19:19 UTC (rev 98904)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h 2011-10-31 23:28:37 UTC (rev 98905)
@@ -30,6 +30,7 @@
#include Connection.h
#include Plugin.h
+#include WebCore/AffineTransform.h
#include WebCore/IntRect.h
#if PLATFORM(MAC)
@@ -139,6 +140,16 @@
RefPtrPluginProcessConnection m_connection;
uint64_t m_pluginInstanceID;
+WebCore::IntSize m_pluginSize;
+
+// The clip rect in plug-in coordinates.
+WebCore::IntRect m_clipRect;
+
+// A transform that can be used to convert from root view coordinates to plug-in coordinates.
+WebCore::AffineTransform m_pluginToRootViewTransform;
+
+// FIXME: Get rid of the window coordinate based rects.
+
// The plug-in rect in window coordinates.
WebCore::IntRect m_frameRectInWindowCoordinates;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98906] branches/safari-534.52-branch/Source
Title: [98906] branches/safari-534.52-branch/Source Revision 98906 Author lforsch...@apple.com Date 2011-10-31 16:34:02 -0700 (Mon, 31 Oct 2011) Log Message Versioning. Modified Paths branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig (98905 => 98906) --- branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-31 23:28:37 UTC (rev 98905) +++ branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-31 23:34:02 UTC (rev 98906) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (98905 => 98906) --- branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-31 23:28:37 UTC (rev 98905) +++ branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-31 23:34:02 UTC (rev 98906) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig (98905 => 98906) --- branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-31 23:28:37 UTC (rev 98905) +++ branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-31 23:34:02 UTC (rev 98906) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig (98905 => 98906) --- branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-31 23:28:37 UTC (rev 98905) +++ branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-31 23:34:02 UTC (rev 98906) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig (98905 => 98906) --- branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-31 23:28:37 UTC (rev 98905) +++ branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-31 23:34:02 UTC (rev 98906) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 7; +TINY_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98907] trunk/Source/WebKit2
Title: [98907] trunk/Source/WebKit2
Revision 98907
Author ander...@apple.com
Date 2011-10-31 16:38:27 -0700 (Mon, 31 Oct 2011)
Log Message
Remove some uses of m_frameRectInWindowCoordinates from PluginProxy
https://bugs.webkit.org/show_bug.cgi?id=71252
Reviewed by Darin Adler.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::pluginBounds):
* WebProcess/Plugins/PluginProxy.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98906 => 98907)
--- trunk/Source/WebKit2/ChangeLog 2011-10-31 23:34:02 UTC (rev 98906)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 23:38:27 UTC (rev 98907)
@@ -1,5 +1,19 @@
2011-10-31 Anders Carlsson ander...@apple.com
+Remove some uses of m_frameRectInWindowCoordinates from PluginProxy
+https://bugs.webkit.org/show_bug.cgi?id=71252
+
+Reviewed by Darin Adler.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::paint):
+(WebKit::PluginProxy::geometryDidChange):
+(WebKit::PluginProxy::updateBackingStore):
+(WebKit::PluginProxy::pluginBounds):
+* WebProcess/Plugins/PluginProxy.h:
+
+2011-10-31 Anders Carlsson ander...@apple.com
+
Implement PluginProxy::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71251
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (98906 => 98907)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-31 23:34:02 UTC (rev 98906)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-31 23:38:27 UTC (rev 98907)
@@ -143,7 +143,7 @@
graphicsContext-applyDeviceScaleFactor(contentsScaleFactor());
graphicsContext-setCompositeOperation(CompositeCopy);
-m_pluginBackingStore-paint(*graphicsContext, contentsScaleFactor(), IntPoint(), IntRect(0, 0, m_frameRectInWindowCoordinates.width(), m_frameRectInWindowCoordinates.height()));
+m_pluginBackingStore-paint(*graphicsContext, contentsScaleFactor(), IntPoint(), pluginBounds());
m_pluginBackingStoreContainsValidData = true;
}
@@ -180,7 +180,7 @@
{
ASSERT(m_isStarted);
-if (m_frameRectInWindowCoordinates.isEmpty() || !needsBackingStore()) {
+if (m_pluginSize.isEmpty() || !needsBackingStore()) {
ShareableBitmap::Handle pluginBackingStoreHandle;
m_connection-connection()-send(Messages::PluginControllerProxy::GeometryDidChange(m_frameRectInWindowCoordinates, m_clipRectInWindowCoordinates, contentsScaleFactor(), pluginBackingStoreHandle), m_pluginInstanceID, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply);
return;
@@ -462,7 +462,7 @@
bool PluginProxy::updateBackingStore()
{
-IntSize backingStoreSize = m_frameRectInWindowCoordinates.size();
+IntSize backingStoreSize = m_pluginSize;
backingStoreSize.scale(contentsScaleFactor());
if (!m_backingStore) {
@@ -490,6 +490,11 @@
return windowNPObjectID;
}
+IntRect PluginProxy::pluginBounds()
+{
+return IntRect(IntPoint(), m_pluginSize);
+}
+
void PluginProxy::getPluginElementNPObject(uint64_t pluginElementNPObjectID)
{
NPObject* pluginElementNPObject = controller()-pluginElementNPObject();
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h (98906 => 98907)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h 2011-10-31 23:34:02 UTC (rev 98906)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h 2011-10-31 23:38:27 UTC (rev 98907)
@@ -115,6 +115,7 @@
bool needsBackingStore() const;
bool updateBackingStore();
uint64_t windowNPObjectID();
+WebCore::IntRect pluginBounds();
void geometryDidChange();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98909] trunk/Source
Title: [98909] trunk/Source Revision 98909 Author wei...@apple.com Date 2011-10-31 16:43:58 -0700 (Mon, 31 Oct 2011) Log Message Remove need for virtual JSObject::unwrappedObject https://bugs.webkit.org/show_bug.cgi?id=71034 Reviewed by Geoffrey Garen. ../_javascript_Core: * _javascript_Core.exp: Update exports. * CMakeLists.txt: * GNUmakefile.list.am: * _javascript_Core.exp: * _javascript_Core.gypi: * _javascript_Core.pro: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj: * _javascript_Core.xcodeproj/project.pbxproj: Add JSGlobalThis.cpp. * runtime/JSGlobalThis.cpp: Added. (JSC::JSGlobalThis::visitChildren): (JSC::JSGlobalThis::unwrappedObject): * runtime/JSGlobalThis.h: (JSC::JSGlobalThis::createStructure): Move underlying object from JSDOMWindowShell down to JSGlobalThis and corresponding visitChildren method. * runtime/JSObject.cpp: (JSC::JSObject::unwrappedObject): Change unwrappedObject from virtual, to just needing an if check. * runtime/JSObject.h: (JSC::JSObject::isGlobalThis): * runtime/JSType.h: Add isGlobalThis predicate and type. ../WebCore: Move the member containing the global object from the JSDOMWindowShell down to the JSGlobalThis class, and update JSDOMWindowShell to go through an inline helper (which just casts) to get the window. * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::className): (WebCore::JSDOMWindowShell::getOwnPropertySlot): (WebCore::JSDOMWindowShell::getOwnPropertyDescriptor): (WebCore::JSDOMWindowShell::put): (WebCore::JSDOMWindowShell::putWithAttributes): (WebCore::JSDOMWindowShell::defineOwnProperty): (WebCore::JSDOMWindowShell::deleteProperty): (WebCore::JSDOMWindowShell::getPropertyNames): (WebCore::JSDOMWindowShell::getOwnPropertyNames): (WebCore::JSDOMWindowShell::defineGetter): (WebCore::JSDOMWindowShell::defineSetter): (WebCore::JSDOMWindowShell::lookupGetter): (WebCore::JSDOMWindowShell::lookupSetter): (WebCore::JSDOMWindowShell::impl): * bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::createStructure): Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/_javascript_Core/_javascript_Core.exp trunk/Source/_javascript_Core/_javascript_Core.gypi trunk/Source/_javascript_Core/_javascript_Core.pro trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/runtime/JSGlobalThis.h trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/JSObject.h trunk/Source/_javascript_Core/runtime/JSType.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMWindowShell.cpp trunk/Source/WebCore/bindings/js/JSDOMWindowShell.h Added Paths trunk/Source/_javascript_Core/runtime/JSGlobalThis.cpp Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (98908 => 98909) --- trunk/Source/_javascript_Core/CMakeLists.txt 2011-10-31 23:40:41 UTC (rev 98908) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2011-10-31 23:43:58 UTC (rev 98909) @@ -127,6 +127,7 @@ runtime/JSGlobalData.cpp runtime/JSGlobalObject.cpp runtime/JSGlobalObjectFunctions.cpp +runtime/JSGlobalThis.cpp runtime/JSLock.cpp runtime/JSNotAnObject.cpp runtime/JSObject.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (98908 => 98909) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-31 23:40:41 UTC (rev 98908) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-31 23:43:58 UTC (rev 98909) @@ -1,3 +1,39 @@ +2011-10-31 Sam Weinig s...@webkit.org + +Remove need for virtual JSObject::unwrappedObject +https://bugs.webkit.org/show_bug.cgi?id=71034 + +Reviewed by Geoffrey Garen. + +* _javascript_Core.exp: +Update exports. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* _javascript_Core.exp: +* _javascript_Core.gypi: +* _javascript_Core.pro: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj: +* _javascript_Core.xcodeproj/project.pbxproj: +Add JSGlobalThis.cpp. + +* runtime/JSGlobalThis.cpp: Added. +(JSC::JSGlobalThis::visitChildren): +(JSC::JSGlobalThis::unwrappedObject): +* runtime/JSGlobalThis.h: +(JSC::JSGlobalThis::createStructure): +Move underlying object from JSDOMWindowShell down to JSGlobalThis +and corresponding visitChildren method. + +* runtime/JSObject.cpp: +(JSC::JSObject::unwrappedObject): +Change unwrappedObject from virtual, to just needing an if check. + +* runtime/JSObject.h: +
[webkit-changes] [98910] trunk
Title: [98910] trunk
Revision 98910
Author ad...@chromium.org
Date 2011-10-31 16:46:50 -0700 (Mon, 31 Oct 2011)
Log Message
[MutationObservers] Support characterDataOldValue for characterData mutations
https://bugs.webkit.org/show_bug.cgi?id=70862
Reviewed by Ojan Vafai.
Source/WebCore:
* dom/CharacterData.cpp:
(WebCore::hasOldValue):
(WebCore::isOldValueRequested):
(WebCore::CharacterData::dispatchModifiedEvent):
* dom/MutationRecord.cpp:
(WebCore::MutationRecord::createCharacterData):
* dom/MutationRecord.h:
LayoutTests:
Added oldValue test cases to existing characterData tests.
* fast/mutation/observe-characterdata-expected.txt:
* fast/mutation/observe-characterdata.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mutation/observe-characterdata-expected.txt
trunk/LayoutTests/fast/mutation/observe-characterdata.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/CharacterData.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/MutationRecord.cpp
trunk/Source/WebCore/dom/MutationRecord.h
Diff
Modified: trunk/LayoutTests/ChangeLog (98909 => 98910)
--- trunk/LayoutTests/ChangeLog 2011-10-31 23:43:58 UTC (rev 98909)
+++ trunk/LayoutTests/ChangeLog 2011-10-31 23:46:50 UTC (rev 98910)
@@ -1,3 +1,15 @@
+2011-10-27 Adam Klein ad...@chromium.org
+
+[MutationObservers] Support characterDataOldValue for characterData mutations
+https://bugs.webkit.org/show_bug.cgi?id=70862
+
+Reviewed by Ojan Vafai.
+
+Added oldValue test cases to existing characterData tests.
+
+* fast/mutation/observe-characterdata-expected.txt:
+* fast/mutation/observe-characterdata.html:
+
2011-10-31 John Gregg john...@google.com
Chromium rebaselines, unreviewed.
Modified: trunk/LayoutTests/fast/mutation/observe-characterdata-expected.txt (98909 => 98910)
--- trunk/LayoutTests/fast/mutation/observe-characterdata-expected.txt 2011-10-31 23:43:58 UTC (rev 98909)
+++ trunk/LayoutTests/fast/mutation/observe-characterdata-expected.txt 2011-10-31 23:46:50 UTC (rev 98910)
@@ -33,6 +33,28 @@
PASS mutations[0].type is characterData
PASS mutations[1].type is attributes
+Testing that oldValue is returned when requested.
+PASS mutations.length is 2
+PASS mutations[0].type is characterData
+PASS mutations[0].target is charDataNode
+PASS mutations[0].oldValue is foo
+PASS mutations[1].type is characterData
+PASS mutations[1].target is charDataNode
+PASS mutations[1].oldValue is bar
+
+Testing that oldValue is delivered as requested (or not).
+PASS mutationsWithOldValue.length is 1
+PASS mutationsWithOldValue[0].type is characterData
+PASS mutationsWithOldValue[0].oldValue is foo
+PASS mutations.length is 1
+PASS mutations[0].type is characterData
+PASS mutations[0].oldValue is null
+
+An observer with multiple observations will get characterDataOldValue if any entries request it.
+PASS mutations.length is 1
+PASS mutations[0].type is characterData
+PASS mutations[0].oldValue is foo
+
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/mutation/observe-characterdata.html (98909 => 98910)
--- trunk/LayoutTests/fast/mutation/observe-characterdata.html 2011-10-31 23:43:58 UTC (rev 98909)
+++ trunk/LayoutTests/fast/mutation/observe-characterdata.html 2011-10-31 23:46:50 UTC (rev 98910)
@@ -12,6 +12,7 @@
window.jsTestIsAsync = true;
var mutations;
var mutations2;
+var mutationsWithOldValue;
var calls;
var charDataNode;
@@ -191,7 +192,121 @@
start();
}
-var tests = [testBasic, testWrongType, testMultipleObservers, testOrderingWrtDOMSubtreeModified];
+function testOldValue() {
+var div;
+var observer;
+
+function start() {
+debug('Testing that oldValue is returned when requested.');
+mutations = null;
+div = document.createElement('div');
+div.textContent = 'foo';
+charDataNode = div.firstChild;
+observer = new WebKitMutationObserver(function(mutations) {
+window.mutations = mutations;
+});
+observer.observe(charDataNode, {characterData: true, characterDataOldValue: true});
+charDataNode.textContent = 'bar';
+charDataNode.textContent = 'baz';
+setTimeout(finish, 0);
+}
+
+function finish() {
+shouldBe('mutations.length', '2');
+shouldBe('mutations[0].type', 'characterData');
+shouldBe('mutations[0].target', 'charDataNode');
+shouldBe('mutations[0].oldValue', 'foo');
+shouldBe('mutations[1].type', 'characterData');
+shouldBe('mutations[1].target', 'charDataNode');
+shouldBe('mutations[1].oldValue', 'bar');
+observer.disconnect();
+debug('');
+runNextTest();
+}
+
+start();
+}
+
+function testOldValueAsRequested() {
+var div;
+var observerWithOldValue;
+var observer;
+
+function start() {
+debug('Testing that oldValue is delivered as requested (or
[webkit-changes] [98911] trunk/Source/WebCore
Title: [98911] trunk/Source/WebCore
Revision 98911
Author jap...@chromium.org
Date 2011-10-31 16:49:47 -0700 (Mon, 31 Oct 2011)
Log Message
Rename the remaining uses of Cue in WebCore/loader/
to TextTrack.
https://bugs.webkit.org/show_bug.cgi?id=71231
Reviewed by Eric Carlson.
No new tests, strictly a renaming.
* loader/TextTrackLoader.cpp:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
* loader/cache/CachedTextTrack.cpp:
* platform/network/chromium/ResourceRequest.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/TextTrackLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp
trunk/Source/WebCore/loader/cache/CachedTextTrack.cpp
trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98910 => 98911)
--- trunk/Source/WebCore/ChangeLog 2011-10-31 23:46:50 UTC (rev 98910)
+++ trunk/Source/WebCore/ChangeLog 2011-10-31 23:49:47 UTC (rev 98911)
@@ -1,3 +1,22 @@
+2011-10-31 Nate Chapin jap...@chromium.org
+
+Rename the remaining uses of Cue in WebCore/loader/
+to TextTrack.
+https://bugs.webkit.org/show_bug.cgi?id=71231
+
+Reviewed by Eric Carlson.
+
+No new tests, strictly a renaming.
+
+* loader/TextTrackLoader.cpp:
+* loader/cache/CachedResource.cpp:
+* loader/cache/CachedResource.h:
+* loader/cache/CachedResourceLoader.cpp:
+* loader/cache/CachedResourceLoader.h:
+* loader/cache/CachedResourceRequest.cpp:
+* loader/cache/CachedTextTrack.cpp:
+* platform/network/chromium/ResourceRequest.h:
+
2011-10-27 Adam Klein ad...@chromium.org
[MutationObservers] Support characterDataOldValue for characterData mutations
Modified: trunk/Source/WebCore/loader/TextTrackLoader.cpp (98910 => 98911)
--- trunk/Source/WebCore/loader/TextTrackLoader.cpp 2011-10-31 23:46:50 UTC (rev 98910)
+++ trunk/Source/WebCore/loader/TextTrackLoader.cpp 2011-10-31 23:49:47 UTC (rev 98911)
@@ -161,7 +161,7 @@
ResourceRequest cueRequest(document-completeURL(url));
CachedResourceLoader* cachedResourceLoader = document-cachedResourceLoader();
-m_cachedCueData = static_castCachedTextTrack*(cachedResourceLoader-requestCues(cueRequest));
+m_cachedCueData = static_castCachedTextTrack*(cachedResourceLoader-requestTextTrack(cueRequest));
if (m_cachedCueData)
m_cachedCueData-addClient(this);
Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (98910 => 98911)
--- trunk/Source/WebCore/loader/cache/CachedResource.cpp 2011-10-31 23:46:50 UTC (rev 98910)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp 2011-10-31 23:49:47 UTC (rev 98911)
@@ -72,7 +72,7 @@
return ResourceLoadPriorityVeryLow;
#endif
#if ENABLE(VIDEO_TRACK)
-case CachedResource::CueResource:
+case CachedResource::TextTrackResource:
return ResourceLoadPriorityLow;
#endif
}
Modified: trunk/Source/WebCore/loader/cache/CachedResource.h (98910 => 98911)
--- trunk/Source/WebCore/loader/cache/CachedResource.h 2011-10-31 23:46:50 UTC (rev 98910)
+++ trunk/Source/WebCore/loader/cache/CachedResource.h 2011-10-31 23:49:47 UTC (rev 98911)
@@ -74,7 +74,7 @@
, LinkSubresource
#endif
#if ENABLE(VIDEO_TRACK)
-, CueResource
+, TextTrackResource
#endif
};
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (98910 => 98911)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2011-10-31 23:46:50 UTC (rev 98910)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2011-10-31 23:49:47 UTC (rev 98911)
@@ -86,7 +86,7 @@
return new CachedResource(request, CachedResource::LinkSubresource);
#endif
#if ENABLE(VIDEO_TRACK)
-case CachedResource::CueResource:
+case CachedResource::TextTrackResource:
return new CachedTextTrack(request);
#endif
}
@@ -162,9 +162,9 @@
}
#if ENABLE(VIDEO_TRACK)
-CachedTextTrack* CachedResourceLoader::requestCues(ResourceRequest request)
+CachedTextTrack* CachedResourceLoader::requestTextTrack(ResourceRequest request)
{
-return static_castCachedTextTrack*(requestResource(CachedResource::CueResource, request, String(), defaultCachedResourceOptions()));
+return static_castCachedTextTrack*(requestResource(CachedResource::TextTrackResource, request, String(), defaultCachedResourceOptions()));
}
#endif
@@ -240,7 +240,7 @@
return false;
break;
#if ENABLE(VIDEO_TRACK)
-case CachedResource::CueResource:
+case
[webkit-changes] [98914] tags/Safari-534.52.8/
Title: [98914] tags/Safari-534.52.8/ Revision 98914 Author lforsch...@apple.com Date 2011-10-31 16:53:47 -0700 (Mon, 31 Oct 2011) Log Message New tag. Added Paths tags/Safari-534.52.8/ Diff Property changes: tags/Safari-534.52.8 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98916] trunk/Source/JavaScriptCore
Title: [98916] trunk/Source/_javascript_Core
Revision 98916
Author mhahnenb...@apple.com
Date 2011-10-31 16:57:57 -0700 (Mon, 31 Oct 2011)
Log Message
Interpreter build fix
Unreviewed build fix
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/runtime/Executable.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98915 => 98916)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-31 23:56:36 UTC (rev 98915)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-31 23:57:57 UTC (rev 98916)
@@ -1,3 +1,15 @@
+2011-10-31 Mark Hahnenberg mhahnenb...@apple.com
+
+Interpreter build fix
+
+Unreviewed build fix
+
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::privateExecute):
+* runtime/Executable.cpp:
+(JSC::FunctionExecutable::compileForCallInternal):
+(JSC::FunctionExecutable::compileForConstructInternal):
+
2011-10-31 Filip Pizlo fpi...@apple.com
DFG OSR exits should add to value profiles
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (98915 => 98916)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-10-31 23:56:36 UTC (rev 98915)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-10-31 23:57:57 UTC (rev 98916)
@@ -4989,7 +4989,7 @@
JSObject* baseObj = asObject(callFrame-r(base).jsValue());
Identifier ident = codeBlock-identifier(property);
ASSERT(callFrame-r(function).jsValue().isObject());
-baseObj-methodTable()-defineGetter(baseObj, callFrame, ident, asObject(callFrame-r(function).jsValue()));
+baseObj-methodTable()-defineGetter(baseObj, callFrame, ident, asObject(callFrame-r(function).jsValue()), 0);
vPC += OPCODE_LENGTH(op_put_getter);
NEXT_INSTRUCTION();
Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (98915 => 98916)
--- trunk/Source/_javascript_Core/runtime/Executable.cpp 2011-10-31 23:56:36 UTC (rev 98915)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp 2011-10-31 23:57:57 UTC (rev 98916)
@@ -456,6 +456,7 @@
JSObject* FunctionExecutable::compileForCallInternal(ExecState* exec, ScopeChainNode* scopeChainNode, JITCode::JITType jitType)
{
#if !ENABLE(JIT)
+UNUSED_PARAM(exec);
UNUSED_PARAM(jitType);
#endif
ASSERT((jitType == JITCode::bottomTierJIT()) == !m_codeBlockForCall);
@@ -514,7 +515,10 @@
JSObject* FunctionExecutable::compileForConstructInternal(ExecState* exec, ScopeChainNode* scopeChainNode, JITCode::JITType jitType)
{
+#if !ENABLE(JIT)
UNUSED_PARAM(jitType);
+UNUSED_PARAM(exec);
+#endif
ASSERT((jitType == JITCode::bottomTierJIT()) == !m_codeBlockForConstruct);
JSObject* exception;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98917] trunk/LayoutTests
Title: [98917] trunk/LayoutTests
Revision 98917
Author o...@webkit.org
Date 2011-10-31 17:01:47 -0700 (Mon, 31 Oct 2011)
Log Message
[Qt] Unreviewed holiday gardening after r98673 and r98608.
* platform/qt/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/qt/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/fast/css/child-style-can-override-visited-style-expected.png
trunk/LayoutTests/platform/qt/fast/css/child-style-can-override-visited-style-expected.txt
trunk/LayoutTests/platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png
trunk/LayoutTests/platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt
trunk/LayoutTests/platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png
trunk/LayoutTests/platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt
trunk/LayoutTests/platform/qt/fast/multicol/block-axis-vertical-lr-expected.png
trunk/LayoutTests/platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt
trunk/LayoutTests/platform/qt/fast/multicol/block-axis-vertical-rl-expected.png
trunk/LayoutTests/platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98916 => 98917)
--- trunk/LayoutTests/ChangeLog 2011-10-31 23:57:57 UTC (rev 98916)
+++ trunk/LayoutTests/ChangeLog 2011-11-01 00:01:47 UTC (rev 98917)
@@ -1,5 +1,20 @@
2011-10-31 Csaba Osztrogonác o...@webkit.org
+[Qt] Unreviewed holiday gardening after r98673 and r98608.
+
+* platform/qt/fast/css/child-style-can-override-visited-style-expected.png: Added.
+* platform/qt/fast/css/child-style-can-override-visited-style-expected.txt: Added.
+* platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
+* platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
+* platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
+* platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
+* platform/qt/fast/multicol/block-axis-vertical-lr-expected.png: Added.
+* platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
+* platform/qt/fast/multicol/block-axis-vertical-rl-expected.png: Added.
+* platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
+
+2011-10-31 Csaba Osztrogonác o...@webkit.org
+
[Qt] Unreviewed holiday gardening after r98852.
CSS 2.1 failure: background-intrinsic-*
Added: trunk/LayoutTests/platform/qt/fast/css/child-style-can-override-visited-style-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/css/child-style-can-override-visited-style-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/fast/css/child-style-can-override-visited-style-expected.txt (0 => 98917)
--- trunk/LayoutTests/platform/qt/fast/css/child-style-can-override-visited-style-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/css/child-style-can-override-visited-style-expected.txt 2011-11-01 00:01:47 UTC (rev 98917)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock (anonymous) at (0,0) size 784x21
+RenderText {#text} at (0,0) size 399x21
+ text run at (0,0) width 399: This tests that a child style can override the :visited style.
+RenderInline {A} at (0,0) size 0x0 [color=#FF]
+ RenderText {#text} at (0,0) size 0x0
+ RenderBlock (anonymous) at (0,21) size 784x21 [color=#FF]
+RenderBlock {DIV} at (0,0) size 784x21 [color=#008000]
+ RenderText {#text} at (0,0) size 300x21
+text run at (0,0) width 300: This text should be green (and underlined)
+ RenderBlock (anonymous) at (0,42) size 784x0
+RenderInline {A} at (0,0) size 0x0 [color=#FF]
+RenderText {#text} at (0,0) size 0x0
+ RenderBlock {DIV} at (0,42) size 784x21 [color=#008000]
+RenderText {#text} at (0,0) size 179x21
+ text run at (0,0) width 179: This text should be green
[webkit-changes] [98918] trunk/LayoutTests
Title: [98918] trunk/LayoutTests Revision 98918 Author o...@webkit.org Date 2011-10-31 17:10:17 -0700 (Mon, 31 Oct 2011) Log Message [Qt] Unreviewed holiday gardening after r98852. 4 new tests fail introduced in r98852 https://bugs.webkit.org/show_bug.cgi?id=71253 * platform/qt/Skipped: Skip failing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (98917 => 98918) --- trunk/LayoutTests/ChangeLog 2011-11-01 00:01:47 UTC (rev 98917) +++ trunk/LayoutTests/ChangeLog 2011-11-01 00:10:17 UTC (rev 98918) @@ -1,5 +1,14 @@ 2011-10-31 Csaba Osztrogonác o...@webkit.org +[Qt] Unreviewed holiday gardening after r98852. + +4 new tests fail introduced in r98852 +https://bugs.webkit.org/show_bug.cgi?id=71253 + +* platform/qt/Skipped: Skip failing tests. + +2011-10-31 Csaba Osztrogonác o...@webkit.org + [Qt] Unreviewed holiday gardening after r98673 and r98608. * platform/qt/fast/css/child-style-can-override-visited-style-expected.png: Added. Modified: trunk/LayoutTests/platform/qt/Skipped (98917 => 98918) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-01 00:01:47 UTC (rev 98917) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-01 00:10:17 UTC (rev 98918) @@ -2500,3 +2500,11 @@ # [Qt] inspector/extensions/extensions-console.html is failing # https://bugs.webkit.org/show_bug.cgi?id=70905 inspector/extensions/extensions-console.html + +# [Qt] 4 new tests fail introduced in r98852 +# https://bugs.webkit.org/show_bug.cgi?id=71253 +fast/multicol/block-axis-horizontal-bt.html +fast/multicol/block-axis-horizontal-tb.html +fast/multicol/block-axis-vertical-rl.html +fast/multicol/block-axis-vertical-lr.html +fast/css/child-style-can-override-visited-style.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98919] trunk/LayoutTests
Title: [98919] trunk/LayoutTests Revision 98919 Author o...@webkit.org Date 2011-10-31 17:18:20 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed, rolling out r98918. http://trac.webkit.org/changeset/98918 https://bugs.webkit.org/show_bug.cgi?id=71256 Wrong commit (Requested by Ossy_weekend on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-31 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (98918 => 98919) --- trunk/LayoutTests/ChangeLog 2011-11-01 00:10:17 UTC (rev 98918) +++ trunk/LayoutTests/ChangeLog 2011-11-01 00:18:20 UTC (rev 98919) @@ -1,3 +1,13 @@ +2011-10-31 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r98918. +http://trac.webkit.org/changeset/98918 +https://bugs.webkit.org/show_bug.cgi?id=71256 + +Wrong commit (Requested by Ossy_weekend on #webkit). + +* platform/qt/Skipped: + 2011-10-31 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed holiday gardening after r98852. Modified: trunk/LayoutTests/platform/qt/Skipped (98918 => 98919) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-01 00:10:17 UTC (rev 98918) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-01 00:18:20 UTC (rev 98919) @@ -2500,11 +2500,3 @@ # [Qt] inspector/extensions/extensions-console.html is failing # https://bugs.webkit.org/show_bug.cgi?id=70905 inspector/extensions/extensions-console.html - -# [Qt] 4 new tests fail introduced in r98852 -# https://bugs.webkit.org/show_bug.cgi?id=71253 -fast/multicol/block-axis-horizontal-bt.html -fast/multicol/block-axis-horizontal-tb.html -fast/multicol/block-axis-vertical-rl.html -fast/multicol/block-axis-vertical-lr.html -fast/css/child-style-can-override-visited-style.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98920] trunk/LayoutTests
Title: [98920] trunk/LayoutTests Revision 98920 Author o...@webkit.org Date 2011-10-31 17:21:34 -0700 (Mon, 31 Oct 2011) Log Message [Qt] Unreviewed holiday gardening after r98852. 4 new tests fail introduced in r98852 https://bugs.webkit.org/show_bug.cgi?id=71253 * platform/qt/Skipped: Skip failing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (98919 => 98920) --- trunk/LayoutTests/ChangeLog 2011-11-01 00:18:20 UTC (rev 98919) +++ trunk/LayoutTests/ChangeLog 2011-11-01 00:21:34 UTC (rev 98920) @@ -1,3 +1,12 @@ +2011-10-31 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed holiday gardening after r98852. + +4 new tests fail introduced in r98852 +https://bugs.webkit.org/show_bug.cgi?id=71253 + +* platform/qt/Skipped: Skip failing tests. + 2011-10-31 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r98918. Modified: trunk/LayoutTests/platform/qt/Skipped (98919 => 98920) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-01 00:18:20 UTC (rev 98919) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-01 00:21:34 UTC (rev 98920) @@ -2500,3 +2500,10 @@ # [Qt] inspector/extensions/extensions-console.html is failing # https://bugs.webkit.org/show_bug.cgi?id=70905 inspector/extensions/extensions-console.html + +# [Qt] 4 new tests fail introduced in r98852 +# https://bugs.webkit.org/show_bug.cgi?id=71253 +svg/zoom/page/zoom-background-images.html +svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html +svg/zoom/page/zoom-svg-as-background-with-relative-size.html +fast/backgrounds/size/contain-and-cover-zoomed.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98921] trunk/Source/WebKit/chromium
Title: [98921] trunk/Source/WebKit/chromium
Revision 98921
Author commit-qu...@webkit.org
Date 2011-10-31 17:27:35 -0700 (Mon, 31 Oct 2011)
Log Message
[chromium] Calling methods of WebFontImpl causes assertions
https://bugs.webkit.org/show_bug.cgi?id=71232
Added FontCachePurgePreventer in several methods.
Patch by Yuzhu Shen yzs...@google.com on 2011-10-31
Reviewed by James Robinson.
* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::calculateWidth):
(WebKit::WebFontImpl::offsetForPosition):
(WebKit::WebFontImpl::selectionRectForText):
(WebKit::WebFontImpl::estimateTextBounds):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFontImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98920 => 98921)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-01 00:21:34 UTC (rev 98920)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-01 00:27:35 UTC (rev 98921)
@@ -1,3 +1,18 @@
+2011-10-31 Yuzhu Shen yzs...@google.com
+
+[chromium] Calling methods of WebFontImpl causes assertions
+https://bugs.webkit.org/show_bug.cgi?id=71232
+
+Added FontCachePurgePreventer in several methods.
+
+Reviewed by James Robinson.
+
+* src/WebFontImpl.cpp:
+(WebKit::WebFontImpl::calculateWidth):
+(WebKit::WebFontImpl::offsetForPosition):
+(WebKit::WebFontImpl::selectionRectForText):
+(WebKit::WebFontImpl::estimateTextBounds):
+
2011-10-28 Nat Duca nd...@chromium.org
[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine via CCScheduler
Modified: trunk/Source/WebKit/chromium/src/WebFontImpl.cpp (98920 => 98921)
--- trunk/Source/WebKit/chromium/src/WebFontImpl.cpp 2011-11-01 00:21:34 UTC (rev 98920)
+++ trunk/Source/WebKit/chromium/src/WebFontImpl.cpp 2011-11-01 00:27:35 UTC (rev 98921)
@@ -138,21 +138,25 @@
int WebFontImpl::calculateWidth(const WebTextRun run) const
{
+FontCachePurgePreventer fontCachePurgePreventer;
return m_font.width(run, 0);
}
int WebFontImpl::offsetForPosition(const WebTextRun run, float position) const
{
+FontCachePurgePreventer fontCachePurgePreventer;
return m_font.offsetForPosition(run, position, true);
}
WebFloatRect WebFontImpl::selectionRectForText(const WebTextRun run, const WebFloatPoint leftBaseline, int height, int from, int to) const
{
+FontCachePurgePreventer fontCachePurgePreventer;
return m_font.selectionRectForText(run, leftBaseline, height, from, to);
}
WebRect WebFontImpl::estimateTextBounds(const WebTextRun run, const WebFloatPoint leftBaseline) const
{
+FontCachePurgePreventer fontCachePurgePreventer;
int totalWidth = m_font.width(run, 0);
const FontMetrics fontMetrics = m_font.fontMetrics();
return WebRect(leftBaseline.x - (fontMetrics.ascent() + fontMetrics.descent()) / 2,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98922] trunk/LayoutTests
Title: [98922] trunk/LayoutTests Revision 98922 Author john...@google.com Date 2011-10-31 17:27:50 -0700 (Mon, 31 Oct 2011) Log Message Unreviewed gardening; bind-script-to-resource.html times out on chromium mac. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98921 => 98922) --- trunk/LayoutTests/ChangeLog 2011-11-01 00:27:35 UTC (rev 98921) +++ trunk/LayoutTests/ChangeLog 2011-11-01 00:27:50 UTC (rev 98922) @@ -1,3 +1,9 @@ +2011-10-31 John Gregg john...@google.com + +Unreviewed gardening; bind-script-to-resource.html times out on chromium mac. + +* platform/chromium/test_expectations.txt: + 2011-10-31 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed holiday gardening after r98852. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98921 => 98922) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-01 00:27:35 UTC (rev 98921) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-01 00:27:50 UTC (rev 98922) @@ -3943,5 +3943,5 @@ BUGWK71226 : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE+TEXT BUGWK71226 : fast/backgrounds/animated-svg-as-mask.html = IMAGE+TEXT IMAGE -BUGWK71233 : inspector/debugger/bind-script-to-resource.html = TEXT +BUGWK71233 : inspector/debugger/bind-script-to-resource.html = TEXT TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98923] trunk/Source/WebKit2
Title: [98923] trunk/Source/WebKit2 Revision 98923 Author ander...@apple.com Date 2011-10-31 17:29:03 -0700 (Mon, 31 Oct 2011) Log Message PluginControllerProxy should call Plugin::geometryDidChange https://bugs.webkit.org/show_bug.cgi?id=71255 Reviewed by Sam Weinig. Pass enough information over in the GeometryDidChange message sent from PluginProxy to PluginControllerProxy so that PluginControllerProxy can call Plugin::geometryDidChange. * PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::paint): (WebKit::PluginControllerProxy::invalidate): (WebKit::PluginControllerProxy::paintEntirePlugin): Update for rename from m_frameRect to m_frameRectInWindowCoordinates. (WebKit::PluginControllerProxy::geometryDidChange): This now takes the plug-in size and the plug-in to root view transform as well. * PluginProcess/PluginControllerProxy.h: Store the plug-in size and rename m_frameRect to m_frameRectInWindowCoordinates. * PluginProcess/PluginControllerProxy.messages.in: Update message signature. * PluginProcess/mac/PluginControllerProxyMac.mm: (WebKit::PluginControllerProxy::platformGeometryDidChange): Use the plug-in size instead of the frame rect size. * Shared/WebCoreArgumentCoders.cpp: (CoreIPCencode): (CoreIPCdecode): * Shared/WebCoreArgumentCoders.h: Add encoder/decoder for WebCore::AffineTransform. * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange): Compute the frame rect in window coordinates and send it over. (WebKit::PluginProxy::deprecatedGeometryDidChange): Move call to geometryDidChange() from here to the new PluginProxy::geometryDidChange. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.h trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (98922 => 98923) --- trunk/Source/WebKit2/ChangeLog 2011-11-01 00:27:50 UTC (rev 98922) +++ trunk/Source/WebKit2/ChangeLog 2011-11-01 00:29:03 UTC (rev 98923) @@ -1,5 +1,48 @@ 2011-10-31 Anders Carlsson ander...@apple.com +PluginControllerProxy should call Plugin::geometryDidChange +https://bugs.webkit.org/show_bug.cgi?id=71255 + +Reviewed by Sam Weinig. + +Pass enough information over in the GeometryDidChange message sent from +PluginProxy to PluginControllerProxy so that PluginControllerProxy can call +Plugin::geometryDidChange. + +* PluginProcess/PluginControllerProxy.cpp: +(WebKit::PluginControllerProxy::paint): +(WebKit::PluginControllerProxy::invalidate): +(WebKit::PluginControllerProxy::paintEntirePlugin): +Update for rename from m_frameRect to m_frameRectInWindowCoordinates. + +(WebKit::PluginControllerProxy::geometryDidChange): +This now takes the plug-in size and the plug-in to root view transform as well. + +* PluginProcess/PluginControllerProxy.h: +Store the plug-in size and rename m_frameRect to m_frameRectInWindowCoordinates. + +* PluginProcess/PluginControllerProxy.messages.in: +Update message signature. + +* PluginProcess/mac/PluginControllerProxyMac.mm: +(WebKit::PluginControllerProxy::platformGeometryDidChange): +Use the plug-in size instead of the frame rect size. + +* Shared/WebCoreArgumentCoders.cpp: +(CoreIPCencode): +(CoreIPCdecode): +* Shared/WebCoreArgumentCoders.h: +Add encoder/decoder for WebCore::AffineTransform. + +* WebProcess/Plugins/PluginProxy.cpp: +(WebKit::PluginProxy::geometryDidChange): +Compute the frame rect in window coordinates and send it over. + +(WebKit::PluginProxy::deprecatedGeometryDidChange): +Move call to geometryDidChange() from here to the new PluginProxy::geometryDidChange. + +2011-10-31 Anders Carlsson ander...@apple.com + Remove some uses of m_frameRectInWindowCoordinates from PluginProxy https://bugs.webkit.org/show_bug.cgi?id=71252 Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (98922 => 98923) --- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-11-01 00:27:50 UTC (rev 98922) +++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-11-01 00:29:03 UTC (rev 98923) @@ -169,7 +169,7 @@ graphicsContext-scale(FloatSize(m_contentsScaleFactor, m_contentsScaleFactor)); #endif -graphicsContext-translate(-m_frameRect.x(), -m_frameRect.y()); +graphicsContext-translate(-m_frameRectInWindowCoordinates.x(), -m_frameRectInWindowCoordinates.y()); if (m_plugin-isTransparent())
[webkit-changes] [98924] trunk/Source/WebCore
Title: [98924] trunk/Source/WebCore
Revision 98924
Author commit-qu...@webkit.org
Date 2011-10-31 17:29:08 -0700 (Mon, 31 Oct 2011)
Log Message
[GStreamer] Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042
Patch by Jonathon Jongsma jonathon.jong...@collabora.co.uk on 2011-10-31
Reviewed by Martin Robinson.
* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed.
* platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
Modified Paths
trunk/Source/WebCore/CMakeListsEfl.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Removed Paths
trunk/Source/WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.h
Diff
Modified: trunk/Source/WebCore/CMakeListsEfl.txt (98923 => 98924)
--- trunk/Source/WebCore/CMakeListsEfl.txt 2011-11-01 00:29:03 UTC (rev 98923)
+++ trunk/Source/WebCore/CMakeListsEfl.txt 2011-11-01 00:29:08 UTC (rev 98924)
@@ -192,7 +192,6 @@
${WEBCORE_DIR}/platform/graphics/gstreamer
)
LIST(APPEND WebCore_SOURCES
-platform/graphics/gstreamer/GOwnPtrGStreamer.cpp
platform/graphics/gstreamer/GRefPtrGStreamer.cpp
platform/graphics/gstreamer/GStreamerGWorld.cpp
platform/graphics/gstreamer/ImageGStreamerCairo.cpp
Modified: trunk/Source/WebCore/ChangeLog (98923 => 98924)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 00:29:03 UTC (rev 98923)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 00:29:08 UTC (rev 98924)
@@ -1,3 +1,23 @@
+2011-10-31 Jonathon Jongsma jonathon.jong...@collabora.co.uk
+
+[GStreamer] Don't use GOwnPtr for ref-counted objects
+https://bugs.webkit.org/show_bug.cgi?id=71042
+
+Reviewed by Martin Robinson.
+
+* CMakeListsEfl.txt:
+* GNUmakefile.list.am:
+* WebCore.gypi:
+* WebCore.pro:
+* platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed.
+* platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed.
+* platform/graphics/gstreamer/GStreamerGWorld.cpp:
+(WebCore::GStreamerGWorld::enterFullscreen):
+(WebCore::GStreamerGWorld::exitFullscreen):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
+(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
+
2011-10-28 Nat Duca nd...@chromium.org
[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine via CCScheduler
Modified: trunk/Source/WebCore/GNUmakefile.list.am (98923 => 98924)
--- trunk/Source/WebCore/GNUmakefile.list.am 2011-11-01 00:29:03 UTC (rev 98923)
+++ trunk/Source/WebCore/GNUmakefile.list.am 2011-11-01 00:29:08 UTC (rev 98924)
@@ -4022,8 +4022,6 @@
Source/WebCore/platform/cairo/WidgetBackingStore.h \
Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp \
Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h \
- Source/WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.cpp \
- Source/WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.h \
Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp \
Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h \
Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp \
Modified: trunk/Source/WebCore/WebCore.gypi (98923 => 98924)
--- trunk/Source/WebCore/WebCore.gypi 2011-11-01 00:29:03 UTC (rev 98923)
+++ trunk/Source/WebCore/WebCore.gypi 2011-11-01 00:29:08 UTC (rev 98924)
@@ -3662,8 +3662,6 @@
'platform/graphics/gpu/TilingData.h',
'platform/graphics/gpu/mac/DrawingBufferMac.mm',
'platform/graphics/gpu/qt/DrawingBufferQt.cpp',
-'platform/graphics/gstreamer/GOwnPtrGStreamer.cpp',
-'platform/graphics/gstreamer/GOwnPtrGStreamer.h',
'platform/graphics/gstreamer/GRefPtrGStreamer.cpp',
'platform/graphics/gstreamer/GRefPtrGStreamer.h',
'platform/graphics/gstreamer/GStreamerGWorld.cpp',
Modified: trunk/Source/WebCore/WebCore.pro (98923 => 98924)
--- trunk/Source/WebCore/WebCore.pro 2011-11-01 00:29:03 UTC (rev 98923)
+++ trunk/Source/WebCore/WebCore.pro 2011-11-01 00:29:08 UTC (rev 98924)
@@ -3127,7 +3127,6 @@
} else: contains(DEFINES, WTF_USE_GSTREAMER=1) {
HEADERS += \
-
[webkit-changes] [98925] trunk/Source/WebCore
Title: [98925] trunk/Source/WebCore Revision 98925 Author aro...@apple.com Date 2011-10-31 17:39:50 -0700 (Mon, 31 Oct 2011) Log Message Fix linker warnings on Windows * WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp and JSRequestAnimationFrameCallback.cpp from all configurations. They are already getting compiled via *AllInOne.cpp files. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj Diff Modified: trunk/Source/WebCore/ChangeLog (98924 => 98925) --- trunk/Source/WebCore/ChangeLog 2011-11-01 00:29:08 UTC (rev 98924) +++ trunk/Source/WebCore/ChangeLog 2011-11-01 00:39:50 UTC (rev 98925) @@ -1,3 +1,11 @@ +2011-10-31 Adam Roben aro...@apple.com + +Fix linker warnings on Windows + +* WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp and +JSRequestAnimationFrameCallback.cpp from all configurations. They are already getting +compiled via *AllInOne.cpp files. + 2011-10-31 Jonathon Jongsma jonathon.jong...@collabora.co.uk [GStreamer] Don't use GOwnPtr for ref-counted objects Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (98924 => 98925) --- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2011-11-01 00:29:08 UTC (rev 98924) +++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2011-11-01 00:39:50 UTC (rev 98925) @@ -51920,54 +51920,54 @@ File RelativePath=..\editing\SpellingCorrectionCommand.cpp -FileConfiguration - Name=Debug|Win32 - ExcludedFromBuild=true - -Tool - Name=VCCLCompilerTool - / -/FileConfiguration -FileConfiguration - Name=Release|Win32 - ExcludedFromBuild=true - -Tool - Name=VCCLCompilerTool - / -/FileConfiguration -FileConfiguration - Name=Debug_Cairo_CFLite|Win32 - ExcludedFromBuild=true - -Tool - Name=VCCLCompilerTool - / -/FileConfiguration -FileConfiguration - Name=Release_Cairo_CFLite|Win32 - ExcludedFromBuild=true - -Tool - Name=VCCLCompilerTool - / -/FileConfiguration -FileConfiguration - Name=Debug_All|Win32 - ExcludedFromBuild=true - -Tool - Name=VCCLCompilerTool - / -/FileConfiguration -FileConfiguration - Name=Release_LTCG|Win32 - ExcludedFromBuild=true - -Tool - Name=VCCLCompilerTool - / -/FileConfiguration +FileConfiguration + Name=Debug|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / +/FileConfiguration +FileConfiguration + Name=Release|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / +/FileConfiguration +FileConfiguration + Name=Debug_Cairo_CFLite|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / +/FileConfiguration +FileConfiguration + Name=Release_Cairo_CFLite|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / +/FileConfiguration +FileConfiguration + Name=Debug_All|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / +/FileConfiguration +FileConfiguration + Name=Production|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / +/FileConfiguration /File File RelativePath=..\editing\SpellingCorrectionCommand.h @@ -63307,6 +63307,46 @@ Name=VCCLCompilerTool / /FileConfiguration + FileConfiguration + Name=Release|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / + /FileConfiguration + FileConfiguration + Name=Debug_Cairo_CFLite|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / + /FileConfiguration + FileConfiguration + Name=Release_Cairo_CFLite|Win32 + ExcludedFromBuild=true + + Tool + Name=VCCLCompilerTool + / + /FileConfiguration +
[webkit-changes] [98927] trunk/Tools
Title: [98927] trunk/Tools
Revision 98927
Author aro...@apple.com
Date 2011-10-31 17:50:44 -0700 (Mon, 31 Oct 2011)
Log Message
Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
Fixes http://webkit.org/b/71258 REGRESSION (r98639): Leaks Viewer doesn't show recent
leaky builds
Reviewed by Anders Carlsson.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
NRWT's leaks-related output (i.e., M total leaks found! vs. M total leaks found for a
total of N bytes!).
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js (98926 => 98927)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js 2011-11-01 00:43:49 UTC (rev 98926)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js 2011-11-01 00:50:44 UTC (rev 98927)
@@ -50,7 +50,7 @@
continue;
var strings = step.text;
for (var stringIndex = 0; stringIndex strings.length; ++stringIndex) {
-var match = /^(\d+) total leaks found!$/.exec(strings[stringIndex]);
+var match = /^(\d+) total leaks found/.exec(strings[stringIndex]);
if (!match)
continue;
buildInfo.leakCount = parseInt(match[1], 10);
Modified: trunk/Tools/ChangeLog (98926 => 98927)
--- trunk/Tools/ChangeLog 2011-11-01 00:43:49 UTC (rev 98926)
+++ trunk/Tools/ChangeLog 2011-11-01 00:50:44 UTC (rev 98927)
@@ -1,3 +1,17 @@
+2011-10-31 Adam Roben aro...@apple.com
+
+Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
+
+Fixes http://webkit.org/b/71258 REGRESSION (r98639): Leaks Viewer doesn't show recent
+leaky builds
+
+Reviewed by Anders Carlsson.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
+(RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
+NRWT's leaks-related output (i.e., M total leaks found! vs. M total leaks found for a
+total of N bytes!).
+
2011-10-31 Raphael Kubo da Costa k...@profusion.mobi
[EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98928] trunk/Source/WebKit2
Title: [98928] trunk/Source/WebKit2
Revision 98928
Author ander...@apple.com
Date 2011-10-31 17:59:34 -0700 (Mon, 31 Oct 2011)
Log Message
PluginProxy::Update should pass the painted rect in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71257
Reviewed by Adam Roben.
This is one step in the process of migrating away from window relative coordinates
and use plug-in relative coordinates instead, since window relative coordinates won't work
with transforms.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Convert the dirty rect back to plug-in coordinates.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::update):
No need to convert the painted rect back to plug-in coordinates anymore.
* WebProcess/Plugins/PluginProxy.messages.in:
Document that the painted rect is in plug-in coordinates.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98927 => 98928)
--- trunk/Source/WebKit2/ChangeLog 2011-11-01 00:50:44 UTC (rev 98927)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-01 00:59:34 UTC (rev 98928)
@@ -1,5 +1,27 @@
2011-10-31 Anders Carlsson ander...@apple.com
+PluginProxy::Update should pass the painted rect in plug-in coordinates
+https://bugs.webkit.org/show_bug.cgi?id=71257
+
+Reviewed by Adam Roben.
+
+This is one step in the process of migrating away from window relative coordinates
+and use plug-in relative coordinates instead, since window relative coordinates won't work
+with transforms.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::paint):
+Convert the dirty rect back to plug-in coordinates.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::update):
+No need to convert the painted rect back to plug-in coordinates anymore.
+
+* WebProcess/Plugins/PluginProxy.messages.in:
+Document that the painted rect is in plug-in coordinates.
+
+2011-10-31 Anders Carlsson ander...@apple.com
+
PluginControllerProxy should call Plugin::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71255
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (98927 => 98928)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-11-01 00:50:44 UTC (rev 98927)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-11-01 00:59:34 UTC (rev 98928)
@@ -176,6 +176,8 @@
m_plugin-paint(graphicsContext.get(), dirtyRect);
+// Convert the dirty rect back to plug-in coordinates.
+dirtyRect.move(-m_frameRectInWindowCoordinates.x(), -m_frameRectInWindowCoordinates.y());
m_connection-connection()-send(Messages::PluginProxy::Update(dirtyRect), m_pluginInstanceID);
}
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (98927 => 98928)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-11-01 00:50:44 UTC (rev 98927)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-11-01 00:59:34 UTC (rev 98928)
@@ -551,24 +551,20 @@
void PluginProxy::update(const IntRect paintedRect)
{
-if (paintedRect == m_frameRectInWindowCoordinates)
+if (paintedRect == pluginBounds())
m_pluginBackingStoreContainsValidData = true;
-IntRect paintedRectPluginCoordinates = paintedRect;
-paintedRectPluginCoordinates.move(-m_frameRectInWindowCoordinates.x(), -m_frameRectInWindowCoordinates.y());
-
if (m_backingStore) {
// Blit the plug-in backing store into our own backing store.
OwnPtrGraphicsContext graphicsContext = m_backingStore-createGraphicsContext();
graphicsContext-applyDeviceScaleFactor(contentsScaleFactor());
graphicsContext-setCompositeOperation(CompositeCopy);
-m_pluginBackingStore-paint(*graphicsContext, contentsScaleFactor(), paintedRectPluginCoordinates.location(),
-paintedRectPluginCoordinates);
+m_pluginBackingStore-paint(*graphicsContext, contentsScaleFactor(), paintedRect.location(), paintedRect);
}
// Ask the controller to invalidate the rect for us.
m_waitingForPaintInResponseToUpdate = true;
-controller()-invalidate(paintedRectPluginCoordinates);
+controller()-invalidate(paintedRect);
}
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in (98927 => 98928)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in 2011-11-01 00:50:44 UTC (rev 98927)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in 2011-11-01 00:59:34 UTC (rev 98928)
@@ -26,7 +26,7 @@
# Asks the web process to load a URL.
LoadURL(uint64_t requestID, WTF::String
[webkit-changes] [98929] trunk/Source/WebCore
Title: [98929] trunk/Source/WebCore
Revision 98929
Author le...@chromium.org
Date 2011-10-31 18:01:57 -0700 (Mon, 31 Oct 2011)
Log Message
Amend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=71243
Reviewed by Eric Seidel.
Replacing remaining integer uses with LayoutUnits in the aforementioned classes.
No new tests -- no change in behavior.
* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::intrinsicSize):
(WebCore::RenderApplet::createWidgetIfNecessary):
* rendering/RenderApplet.h:
* rendering/RenderButton.cpp:
(WebCore::RenderButton::controlClipRect):
* rendering/RenderButton.h:
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::marginWidthForChild):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
* rendering/RenderDeprecatedFlexibleBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderApplet.cpp
trunk/Source/WebCore/rendering/RenderApplet.h
trunk/Source/WebCore/rendering/RenderButton.cpp
trunk/Source/WebCore/rendering/RenderButton.h
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98928 => 98929)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 00:59:34 UTC (rev 98928)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 01:01:57 UTC (rev 98929)
@@ -1,3 +1,29 @@
+2011-10-31 Levi Weintraub le...@chromium.org
+
+Amend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
+https://bugs.webkit.org/show_bug.cgi?id=71243
+
+Reviewed by Eric Seidel.
+
+Replacing remaining integer uses with LayoutUnits in the aforementioned classes.
+
+No new tests -- no change in behavior.
+
+* rendering/RenderApplet.cpp:
+(WebCore::RenderApplet::intrinsicSize):
+(WebCore::RenderApplet::createWidgetIfNecessary):
+* rendering/RenderApplet.h:
+* rendering/RenderButton.cpp:
+(WebCore::RenderButton::controlClipRect):
+* rendering/RenderButton.h:
+* rendering/RenderDeprecatedFlexibleBox.cpp:
+(WebCore::marginWidthForChild):
+(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
+(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
+(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
+(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
+* rendering/RenderDeprecatedFlexibleBox.h:
+
2011-10-31 Tommy Widenflycht tom...@google.com
[Chromium] Media Stream API: add the Chromium WebKit interfaces
Modified: trunk/Source/WebCore/rendering/RenderApplet.cpp (98928 => 98929)
--- trunk/Source/WebCore/rendering/RenderApplet.cpp 2011-11-01 00:59:34 UTC (rev 98928)
+++ trunk/Source/WebCore/rendering/RenderApplet.cpp 2011-11-01 01:01:57 UTC (rev 98929)
@@ -44,13 +44,13 @@
{
}
-IntSize RenderApplet::intrinsicSize() const
+LayoutSize RenderApplet::intrinsicSize() const
{
// FIXME: This doesn't make sense. We can't just start returning
// a different size once we've created the widget and expect
// layout and sizing to be correct. We should remove this and
// pass the appropriate intrinsic size in the constructor.
-return widget() ? IntSize(50, 50) : IntSize(150, 150);
+return widget() ? LayoutSize(50, 50) : LayoutSize(150, 150);
}
void RenderApplet::createWidgetIfNecessary()
@@ -63,9 +63,9 @@
// In order to work around this problem and have a correct size from the start, we will
// use fixed widths/heights from the style system when we can, since the widget might
// not have an accurate m_width/m_height.
-int contentWidth = style()-width().isFixed() ? style()-width().value() :
+LayoutUnit contentWidth = style()-width().isFixed() ? LayoutUnit(style()-width().value()) :
width() - borderAndPaddingWidth();
-int contentHeight = style()-height().isFixed() ? style()-height().value() :
+LayoutUnit contentHeight = style()-height().isFixed() ? LayoutUnit(style()-height().value()) :
height() - borderAndPaddingHeight();
for (Node* child = element-firstChild(); child; child = child-nextSibling()) {
if (child-hasTagName(paramTag)) {
@@ -77,7 +77,7 @@
Frame* frame = this-frame();
ASSERT(frame);
-setWidget(frame-loader()-subframeLoader()-createJavaAppletWidget(IntSize(contentWidth, contentHeight), element, m_args));
+setWidget(frame-loader()-subframeLoader()-createJavaAppletWidget(LayoutSize(contentWidth, contentHeight), element, m_args));
}
void RenderApplet::layout()
Modified: trunk/Source/WebCore/rendering/RenderApplet.h (98928 => 98929)
---
[webkit-changes] [98930] trunk/Source/WebCore
Title: [98930] trunk/Source/WebCore
Revision 98930
Author commit-qu...@webkit.org
Date 2011-10-31 18:06:00 -0700 (Mon, 31 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70666
BitmapImage::dataChanged() needs to clear all incomplete frames.
Patch by Peter Kasting pkast...@google.com on 2011-10-31
Reviewed by James Robinson.
No tests, as I don't know of a way to send an image to the renderer in
small pieces (with script run between pieces no less).
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::dataChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98929 => 98930)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 01:01:57 UTC (rev 98929)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 01:06:00 UTC (rev 98930)
@@ -1,3 +1,16 @@
+2011-10-31 Peter Kasting pkast...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=70666
+BitmapImage::dataChanged() needs to clear all incomplete frames.
+
+Reviewed by James Robinson.
+
+No tests, as I don't know of a way to send an image to the renderer in
+small pieces (with script run between pieces no less).
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::dataChanged):
+
2011-10-31 Levi Weintraub le...@chromium.org
Amend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (98929 => 98930)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp 2011-11-01 01:01:57 UTC (rev 98929)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp 2011-11-01 01:06:00 UTC (rev 98930)
@@ -195,21 +195,39 @@
bool BitmapImage::dataChanged(bool allDataReceived)
{
-// Because we're modifying the current frame, clear its (now possibly
-// inaccurate) metadata as well.
-destroyMetadataAndNotify((!m_frames.isEmpty() m_frames[m_frames.size() - 1].clear(true)) ? 1 : 0);
+// Clear all partially-decoded frames. For most image formats, there is only
+// one frame, but at least GIF and ICO can have more. With GIFs, the frames
+// come in order and we ask to decode them in order, waiting to request a
+// subsequent frame until the prior one is complete. Given that we clear
+// incomplete frames here, this means there is at most one incomplete frame
+// (even if we use destroyDecodedData() -- since it doesn't reset the
+// metadata), and it is after all the complete frames.
+//
+// With ICOs, on the other hand, we may ask for arbitrary frames at
+// different times (e.g. because we're displaying a higher-resolution image
+// in the content area and using a lower-resolution one for the favicon),
+// and the frames aren't even guaranteed to appear in the file in the same
+// order as in the directory, so an arbitrary number of the frames might be
+// incomplete (if we ask for frames for which we've not yet reached the
+// start of the frame data), and any or none of them might be the particular
+// frame affected by appending new data here. Thus we have to clear all the
+// incomplete frames to be safe.
+int framesCleared = 0;
+for (size_t i = 0; i m_frames.size(); ++i) {
+// NOTE: Don't call frameIsCompleteAtIndex() here, that will try to
+// decode any uncached (i.e. never-decoded or
+// cleared-on-a-previous-pass) frames!
+if (m_frames[i].m_haveMetadata !m_frames[i].m_isComplete)
+framesCleared += (m_frames[i].clear(true) ? 1 : 0);
+}
+destroyMetadataAndNotify(framesCleared);
// Feed all the data we've seen so far to the image decoder.
m_allDataReceived = allDataReceived;
m_source.setData(data(), allDataReceived);
-// Clear the frame count.
m_haveFrameCount = false;
-
m_hasUniformFrameSize = true;
-
-// Image properties will not be available until the first frame of the file
-// reaches kCGImageStatusIncomplete.
return isSizeAvailable();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98931] trunk/Source/WebCore
Title: [98931] trunk/Source/WebCore
Revision 98931
Author le...@chromium.org
Date 2011-10-31 18:09:03 -0700 (Mon, 31 Oct 2011)
Log Message
Switch RoundedRect back to integers
https://bugs.webkit.org/show_bug.cgi?id=71238
Reviewed by Darin Adler.
Changing RoundedRect back to ints from LayoutUnits. As further testing has shown, this graphics-
focused class should maintain values aligned to pixel boundaries, and therefor kept as integers.
No new tests -- no change in behavior.
* platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::inflateWithRadii):
(WebCore::RoundedRect::Radii::excludeLogicalEdges):
(WebCore::RoundedRect::RoundedRect):
* platform/graphics/RoundedRect.h:
(WebCore::RoundedRect::Radii::Radii):
(WebCore::RoundedRect::Radii::setTopLeft):
(WebCore::RoundedRect::Radii::setTopRight):
(WebCore::RoundedRect::Radii::setBottomLeft):
(WebCore::RoundedRect::Radii::setBottomRight):
(WebCore::RoundedRect::Radii::topLeft):
(WebCore::RoundedRect::Radii::topRight):
(WebCore::RoundedRect::Radii::bottomLeft):
(WebCore::RoundedRect::Radii::bottomRight):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::Radii::shrink):
(WebCore::RoundedRect::rect):
(WebCore::RoundedRect::setRect):
(WebCore::RoundedRect::move):
(WebCore::RoundedRect::inflate):
(WebCore::RoundedRect::expandRadii):
(WebCore::RoundedRect::shrinkRadii):
* rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/RoundedRect.cpp
trunk/Source/WebCore/platform/graphics/RoundedRect.h
trunk/Source/WebCore/rendering/svg/SVGRenderSupport.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98930 => 98931)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 01:06:00 UTC (rev 98930)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 01:09:03 UTC (rev 98931)
@@ -1,3 +1,41 @@
+2011-10-31 Levi Weintraub le...@chromium.org
+
+Switch RoundedRect back to integers
+https://bugs.webkit.org/show_bug.cgi?id=71238
+
+Reviewed by Darin Adler.
+
+Changing RoundedRect back to ints from LayoutUnits. As further testing has shown, this graphics-
+focused class should maintain values aligned to pixel boundaries, and therefor kept as integers.
+
+No new tests -- no change in behavior.
+
+* platform/graphics/RoundedRect.cpp:
+(WebCore::RoundedRect::Radii::scale):
+(WebCore::RoundedRect::Radii::expand):
+(WebCore::RoundedRect::inflateWithRadii):
+(WebCore::RoundedRect::Radii::excludeLogicalEdges):
+(WebCore::RoundedRect::RoundedRect):
+* platform/graphics/RoundedRect.h:
+(WebCore::RoundedRect::Radii::Radii):
+(WebCore::RoundedRect::Radii::setTopLeft):
+(WebCore::RoundedRect::Radii::setTopRight):
+(WebCore::RoundedRect::Radii::setBottomLeft):
+(WebCore::RoundedRect::Radii::setBottomRight):
+(WebCore::RoundedRect::Radii::topLeft):
+(WebCore::RoundedRect::Radii::topRight):
+(WebCore::RoundedRect::Radii::bottomLeft):
+(WebCore::RoundedRect::Radii::bottomRight):
+(WebCore::RoundedRect::Radii::expand):
+(WebCore::RoundedRect::Radii::shrink):
+(WebCore::RoundedRect::rect):
+(WebCore::RoundedRect::setRect):
+(WebCore::RoundedRect::move):
+(WebCore::RoundedRect::inflate):
+(WebCore::RoundedRect::expandRadii):
+(WebCore::RoundedRect::shrinkRadii):
+* rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include
+
2011-10-31 Peter Kasting pkast...@google.com
https://bugs.webkit.org/show_bug.cgi?id=70666
Modified: trunk/Source/WebCore/platform/graphics/RoundedRect.cpp (98930 => 98931)
--- trunk/Source/WebCore/platform/graphics/RoundedRect.cpp 2011-11-01 01:06:00 UTC (rev 98930)
+++ trunk/Source/WebCore/platform/graphics/RoundedRect.cpp 2011-11-01 01:09:03 UTC (rev 98931)
@@ -46,45 +46,45 @@
// If either radius on a corner becomes zero, reset both radii on that corner.
m_topLeft.scale(factor);
if (!m_topLeft.width() || !m_topLeft.height())
-m_topLeft = LayoutSize();
+m_topLeft = IntSize();
m_topRight.scale(factor);
if (!m_topRight.width() || !m_topRight.height())
-m_topRight = LayoutSize();
+m_topRight = IntSize();
m_bottomLeft.scale(factor);
if (!m_bottomLeft.width() || !m_bottomLeft.height())
-m_bottomLeft = LayoutSize();
+m_bottomLeft = IntSize();
m_bottomRight.scale(factor);
if (!m_bottomRight.width() || !m_bottomRight.height())
-m_bottomRight = LayoutSize();
+m_bottomRight = IntSize();
}
-void RoundedRect::Radii::expand(LayoutUnit topWidth, LayoutUnit bottomWidth, LayoutUnit leftWidth, LayoutUnit rightWidth)
+void RoundedRect::Radii::expand(int topWidth, int bottomWidth, int leftWidth, int rightWidth)
{
-
[webkit-changes] [98932] trunk/Source
Title: [98932] trunk/Source Revision 98932 Author mhahnenb...@apple.com Date 2011-10-31 18:15:06 -0700 (Mon, 31 Oct 2011) Log Message De-virtualize JSObject::defaultValue https://bugs.webkit.org/show_bug.cgi?id=71146 Reviewed by Sam Weinig. Source/_javascript_Core: Added defaultValue to the MethodTable. Replaced all virtual versions of defaultValue with static versions. Replaced all call sites with lookups in the MethodTable. * _javascript_Core.exp: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: * runtime/ClassInfo.h: * runtime/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::defaultValue): (JSC::TerminatedExecutionError::defaultValue): * runtime/ExceptionHelpers.h: * runtime/JSCell.cpp: (JSC::JSCell::defaultValue): * runtime/JSCell.h: * runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::defaultValue): * runtime/JSNotAnObject.h: * runtime/JSObject.cpp: (JSC::JSObject::getPrimitiveNumber): (JSC::JSObject::defaultValue): * runtime/JSObject.h: (JSC::JSObject::toPrimitive): Source/WebCore: No new tests. Added defaultValue to the MethodTable. Replaced all virtual versions of defaultValue with static versions. Replaced all call sites with lookups in the MethodTable. * WebCore.exp.in: * bridge/objc/objc_runtime.h: * bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcFallbackObjectImp::defaultValue): * bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::defaultValue): * bridge/runtime_object.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.exp trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/runtime/ClassInfo.h trunk/Source/_javascript_Core/runtime/ExceptionHelpers.cpp trunk/Source/_javascript_Core/runtime/ExceptionHelpers.h trunk/Source/_javascript_Core/runtime/JSCell.cpp trunk/Source/_javascript_Core/runtime/JSCell.h trunk/Source/_javascript_Core/runtime/JSNotAnObject.cpp trunk/Source/_javascript_Core/runtime/JSNotAnObject.h trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/JSObject.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/bridge/objc/objc_runtime.h trunk/Source/WebCore/bridge/objc/objc_runtime.mm trunk/Source/WebCore/bridge/runtime_object.cpp trunk/Source/WebCore/bridge/runtime_object.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98931 => 98932) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-01 01:09:03 UTC (rev 98931) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-01 01:15:06 UTC (rev 98932) @@ -1,5 +1,35 @@ 2011-10-31 Mark Hahnenberg mhahnenb...@apple.com +De-virtualize JSObject::defaultValue +https://bugs.webkit.org/show_bug.cgi?id=71146 + +Reviewed by Sam Weinig. + +Added defaultValue to the MethodTable. Replaced all virtual versions of +defaultValue with static versions. Replaced all call sites with lookups in the +MethodTable. + +* _javascript_Core.exp: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: +* runtime/ClassInfo.h: +* runtime/ExceptionHelpers.cpp: +(JSC::InterruptedExecutionError::defaultValue): +(JSC::TerminatedExecutionError::defaultValue): +* runtime/ExceptionHelpers.h: +* runtime/JSCell.cpp: +(JSC::JSCell::defaultValue): +* runtime/JSCell.h: +* runtime/JSNotAnObject.cpp: +(JSC::JSNotAnObject::defaultValue): +* runtime/JSNotAnObject.h: +* runtime/JSObject.cpp: +(JSC::JSObject::getPrimitiveNumber): +(JSC::JSObject::defaultValue): +* runtime/JSObject.h: +(JSC::JSObject::toPrimitive): + +2011-10-31 Mark Hahnenberg mhahnenb...@apple.com + Interpreter build fix Unreviewed build fix Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (98931 => 98932) --- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-11-01 01:09:03 UTC (rev 98931) +++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-11-01 01:15:06 UTC (rev 98932) @@ -304,6 +304,7 @@ __ZN3JSC8JSObject10putByIndexEPNS_6JSCellEPNS_9ExecStateEjNS_7JSValueE __ZN3JSC8JSObject11hasInstanceEPNS_9ExecStateENS_7JSValueES3_ __ZN3JSC8JSObject12defineGetterEPS0_PNS_9ExecStateERKNS_10IdentifierES1_j +__ZN3JSC8JSObject12defaultValueEPKS0_PNS_9ExecStateENS_22PreferredPrimitiveTypeE __ZN3JSC8JSObject12defineSetterEPNS_9ExecStateERKNS_10IdentifierEPS0_j __ZN3JSC8JSObject12lookupGetterEPNS_9ExecStateERKNS_10IdentifierE __ZN3JSC8JSObject12lookupSetterEPNS_9ExecStateERKNS_10IdentifierE @@ -565,7 +566,6 @@ __ZNK3JSC7UString5asciiEv __ZNK3JSC8JSObject11hasPropertyEPNS_9ExecStateERKNS_10IdentifierE __ZNK3JSC8JSObject11hasPropertyEPNS_9ExecStateEj -__ZNK3JSC8JSObject12defaultValueEPNS_9ExecStateENS_22PreferredPrimitiveTypeE __ZNK3JSC8JSObject8toNumberEPNS_9ExecStateE
[webkit-changes] [98933] trunk/Source/WebCore
Title: [98933] trunk/Source/WebCore
Revision 98933
Author r...@webkit.org
Date 2011-10-31 18:47:17 -0700 (Mon, 31 Oct 2011)
Log Message
[Qt] Build fix after r98853.
Rubber-stamped by Andreas Kling.
* xml/XSLImportRule.cpp:
* xml/XSLImportRule.h:
(WebCore::XSLImportRule::parentStyleSheet):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XSLImportRule.cpp
trunk/Source/WebCore/xml/XSLImportRule.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98932 => 98933)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 01:15:06 UTC (rev 98932)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 01:47:17 UTC (rev 98933)
@@ -1,3 +1,13 @@
+2011-10-31 Renata Hodovan r...@webkit.org
+
+[Qt] Build fix after r98853.
+
+Rubber-stamped by Andreas Kling.
+
+* xml/XSLImportRule.cpp:
+* xml/XSLImportRule.h:
+(WebCore::XSLImportRule::parentStyleSheet):
+
2011-10-31 Mark Hahnenberg mhahnenb...@apple.com
De-virtualize JSObject::defaultValue
Modified: trunk/Source/WebCore/xml/XSLImportRule.cpp (98932 => 98933)
--- trunk/Source/WebCore/xml/XSLImportRule.cpp 2011-11-01 01:15:06 UTC (rev 98932)
+++ trunk/Source/WebCore/xml/XSLImportRule.cpp 2011-11-01 01:47:17 UTC (rev 98933)
@@ -48,11 +48,6 @@
m_cachedSheet-removeClient(this);
}
-XSLStyleSheet* XSLImportRule::parentStyleSheet() const
-{
-return m_parentStyleSheet;
-}
-
void XSLImportRule::setXSLStyleSheet(const String href, const KURL baseURL, const String sheet)
{
if (m_styleSheet)
Modified: trunk/Source/WebCore/xml/XSLImportRule.h (98932 => 98933)
--- trunk/Source/WebCore/xml/XSLImportRule.h 2011-11-01 01:15:06 UTC (rev 98932)
+++ trunk/Source/WebCore/xml/XSLImportRule.h 2011-11-01 01:47:17 UTC (rev 98933)
@@ -47,7 +47,7 @@
const String href() const { return m_strHref; }
XSLStyleSheet* styleSheet() const { return m_styleSheet.get(); }
-XSLStyleSheet* parentStyleSheet() const;
+XSLStyleSheet* parentStyleSheet() const { return m_parentStyleSheet; }
void setParentStyleSheet(XSLStyleSheet* styleSheet) { m_parentStyleSheet = styleSheet; }
bool isLoading();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98934] trunk
Title: [98934] trunk
Revision 98934
Author commit-qu...@webkit.org
Date 2011-10-31 20:37:51 -0700 (Mon, 31 Oct 2011)
Log Message
V8MessageEvent::dataAccessorGetter does not return a reference to its caller
https://bugs.webkit.org/show_bug.cgi?id=71229
Patch by Dave Michael dmich...@chromium.org on 2011-10-31
Reviewed by Adam Barth.
Test: fast/events/dispatch-message-string-data.html
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
Added Paths
trunk/LayoutTests/fast/events/dispatch-message-string-data-expected.txt
trunk/LayoutTests/fast/events/dispatch-message-string-data.html
Diff
Added: trunk/LayoutTests/fast/events/dispatch-message-string-data-expected.txt (0 => 98934)
--- trunk/LayoutTests/fast/events/dispatch-message-string-data-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/dispatch-message-string-data-expected.txt 2011-11-01 03:37:51 UTC (rev 98934)
@@ -0,0 +1,4 @@
+This is a test for https://bugs.webkit.org/show_bug.cgi?id=71229 (V8MessageEvent::dataAccessorGetter does not return a reference to its caller). If it succeeds, DONE will appear below. If it fails, you should see messages containing unexpected strings that were received and/or a renderer crash.
+
+DONE
+
Added: trunk/LayoutTests/fast/events/dispatch-message-string-data.html (0 => 98934)
--- trunk/LayoutTests/fast/events/dispatch-message-string-data.html (rev 0)
+++ trunk/LayoutTests/fast/events/dispatch-message-string-data.html 2011-11-01 03:37:51 UTC (rev 98934)
@@ -0,0 +1,67 @@
+!DOCTYPE html
+html
+head
+pThis is a test for https://bugs.webkit.org/show_bug.cgi?id=71229 (V8MessageEvent::dataAccessorGetter does not return a reference to its caller). If it succeeds, DONE will appear below. If it fails, you should see messages containing unexpected strings that were received and/or a renderer crash.
+hr
+pre id=log/pre
+script
+function log(message)
+{
+document.getElementById(log).innerHTML += message + br;
+}
+
+var eventTarget;
+
+// Make a long prefix string. This seems to make it more likely that a use-
+// after-free problem will cause an observable error.
+var kPrefix = Hello;
+for (var i = 0; i 10; ++i)
+kPrefix += kPrefix;
+var num = 0;
+var endNum = 1000;
+function HandleMessage(message_event) {
+if (message_event.data !== kPrefix + num.toString()) {
+log(Expected ' + num + ', Got: ' + message_event.data + ');
+}
+if (num == endNum) {
+layoutTestController.notifyDone();
+}
+else {
+++num;
+setTimeout(SendString, 0);
+}
+}
+
+function SendString() {
+var target = document.getElementById(event_target);
+var message_event = window.document.createEvent('MessageEvent');
+message_event.initMessageEvent('message', // type
+ false, // canBubble
+ false, // cancelable
+ kPrefix + num.toString(), // data
+ '', // origin [*]
+ '', // lastEventId
+ null, // source [*]
+ []); // ports
+target.dispatchEvent(message_event);
+}
+
+function AddListener() {
+var target = document.getElementById(event_target);
+target.addEventListener(message, HandleMessage, false);
+SendString();
+}
+document.addEventListener(DOMContentLoaded, AddListener, false);
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+log(DONE);
+
+/script
+/head
+body
+div id=event_target/div
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (98933 => 98934)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 01:47:17 UTC (rev 98933)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 03:37:51 UTC (rev 98934)
@@ -1,3 +1,15 @@
+2011-10-31 Dave Michael dmich...@chromium.org
+
+V8MessageEvent::dataAccessorGetter does not return a reference to its caller
+https://bugs.webkit.org/show_bug.cgi?id=71229
+
+Reviewed by Adam Barth.
+
+Test: fast/events/dispatch-message-string-data.html
+
+* bindings/v8/custom/V8MessageEventCustom.cpp:
+(WebCore::V8MessageEvent::dataAccessorGetter):
+
2011-10-31 Renata Hodovan r...@webkit.org
[Qt] Build fix after r98853.
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp (98933 => 98934)
--- trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp 2011-11-01 01:47:17 UTC (rev 98933)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp 2011-11-01 03:37:51 UTC (rev 98934)
@@ -56,7 +56,7 @@
if (scriptValue.hasNoValue())
result = v8::Null();
else
-result =
[webkit-changes] [98935] trunk
Title: [98935] trunk
Revision 98935
Author commit-qu...@webkit.org
Date 2011-10-31 21:24:08 -0700 (Mon, 31 Oct 2011)
Log Message
Source/WebCore: Fix a crash relating to anonymous block merging in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705
Patch by Jeremy Apthorp jere...@google.com on 2011-10-31
Reviewed by Simon Fraser.
Test: fullscreen/anonymous-block-merge-crash.html
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):
LayoutTests: Test case for a crash relating to merging of anonymous blocks in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705
Patch by Jeremy Apthorp jere...@google.com on 2011-10-31
Reviewed by Simon Fraser.
* fullscreen/anonymous-block-merge-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFullScreen.cpp
Added Paths
trunk/LayoutTests/fullscreen/anonymous-block-merge-crash-expected.txt
trunk/LayoutTests/fullscreen/anonymous-block-merge-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98934 => 98935)
--- trunk/LayoutTests/ChangeLog 2011-11-01 03:37:51 UTC (rev 98934)
+++ trunk/LayoutTests/ChangeLog 2011-11-01 04:24:08 UTC (rev 98935)
@@ -1,3 +1,13 @@
+2011-10-31 Jeremy Apthorp jere...@google.com
+
+Test case for a crash relating to merging of anonymous blocks in
+RenderFullScreen::unwrapRenderer.
+https://bugs.webkit.org/show_bug.cgi?id=70705
+
+Reviewed by Simon Fraser.
+
+* fullscreen/anonymous-block-merge-crash.html: Added.
+
2011-10-31 John Gregg john...@google.com
Unreviewed gardening; bind-script-to-resource.html times out on chromium mac.
Added: trunk/LayoutTests/fullscreen/anonymous-block-merge-crash-expected.txt (0 => 98935)
--- trunk/LayoutTests/fullscreen/anonymous-block-merge-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fullscreen/anonymous-block-merge-crash-expected.txt 2011-11-01 04:24:08 UTC (rev 98935)
@@ -0,0 +1,2 @@
+PASS
+
Added: trunk/LayoutTests/fullscreen/anonymous-block-merge-crash.html (0 => 98935)
--- trunk/LayoutTests/fullscreen/anonymous-block-merge-crash.html (rev 0)
+++ trunk/LayoutTests/fullscreen/anonymous-block-merge-crash.html 2011-11-01 04:24:08 UTC (rev 98935)
@@ -0,0 +1,16 @@
+spanobjectdivPASS/div/span
+script src=""
+script
+ if (Element.prototype.webkitRequestFullScreen == undefined) {
+ } else {
+var span = document.getElementsByTagName('span')[0];
+
+document._onwebkitfullscreenchange_ = function(event) {
+ document.body.appendChild(document.createElement('div'));
+ document.webkitCancelFullScreen();
+ layoutTestController.notifyDone();
+};
+
+runWithKeyDown(function(){span.webkitRequestFullScreen()});
+ }
+/script
Modified: trunk/Source/WebCore/ChangeLog (98934 => 98935)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 03:37:51 UTC (rev 98934)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 04:24:08 UTC (rev 98935)
@@ -1,3 +1,16 @@
+2011-10-31 Jeremy Apthorp jere...@google.com
+
+Fix a crash relating to anonymous block merging in
+RenderFullScreen::unwrapRenderer.
+https://bugs.webkit.org/show_bug.cgi?id=70705
+
+Reviewed by Simon Fraser.
+
+Test: fullscreen/anonymous-block-merge-crash.html
+
+* rendering/RenderFullScreen.cpp:
+(RenderFullScreen::unwrapRenderer):
+
2011-10-31 Dave Michael dmich...@chromium.org
V8MessageEvent::dataAccessorGetter does not return a reference to its caller
Modified: trunk/Source/WebCore/rendering/RenderFullScreen.cpp (98934 => 98935)
--- trunk/Source/WebCore/rendering/RenderFullScreen.cpp 2011-11-01 03:37:51 UTC (rev 98934)
+++ trunk/Source/WebCore/rendering/RenderFullScreen.cpp 2011-11-01 04:24:08 UTC (rev 98935)
@@ -125,14 +125,11 @@
void RenderFullScreen::unwrapRenderer()
{
RenderObject* holder = placeholder() ? placeholder() : this;
-RenderObject* parent = holder-parent();
-if (parent) {
-RenderObject* child = firstChild();
-while (child) {
-RenderObject* nextChild = child-nextSibling();
+if (holder-parent()) {
+RenderObject* child;
+while ((child = firstChild())) {
child-remove();
-parent-addChild(child, holder);
-child = nextChild;
+holder-parent()-addChild(child, holder);
}
}
remove();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98936] trunk/Source/WebCore
Title: [98936] trunk/Source/WebCore
Revision 98936
Author aes...@apple.com
Date 2011-10-31 22:43:09 -0700 (Mon, 31 Oct 2011)
Log Message
Document pointer not null-checked in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71265
rdar://problem/10374427
Reviewed by Dan Bernstein.
Return false in FrameView::isOnActivePage() if m_frame-document() is
null. Other calls to m_frame-document() in FrameView also have a null
check. The frame can have a null document if the FrameLoader is loading
the initial empty document.
No test possible without triggering assertions in debug builds. This is
tracked by http://webkit.org/b/71264.
* page/FrameView.cpp:
(WebCore::FrameView::isOnActivePage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98935 => 98936)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 04:24:08 UTC (rev 98935)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 05:43:09 UTC (rev 98936)
@@ -1,3 +1,22 @@
+2011-10-31 Andy Estes aes...@apple.com
+
+Document pointer not null-checked in FrameView::isOnActivePage()
+https://bugs.webkit.org/show_bug.cgi?id=71265
+rdar://problem/10374427
+
+Reviewed by Dan Bernstein.
+
+Return false in FrameView::isOnActivePage() if m_frame-document() is
+null. Other calls to m_frame-document() in FrameView also have a null
+check. The frame can have a null document if the FrameLoader is loading
+the initial empty document.
+
+No test possible without triggering assertions in debug builds. This is
+tracked by http://webkit.org/b/71264.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::isOnActivePage):
+
2011-10-31 Jeremy Apthorp jere...@google.com
Fix a crash relating to anonymous block merging in
Modified: trunk/Source/WebCore/page/FrameView.cpp (98935 => 98936)
--- trunk/Source/WebCore/page/FrameView.cpp 2011-11-01 04:24:08 UTC (rev 98935)
+++ trunk/Source/WebCore/page/FrameView.cpp 2011-11-01 05:43:09 UTC (rev 98936)
@@ -2431,7 +2431,9 @@
{
if (m_frame-view() != this)
return false;
-return !m_frame-document()-inPageCache();
+if (Document* document = m_frame-document())
+return !document-inPageCache();
+return false;
}
ScrollableArea* FrameView::enclosingScrollableArea() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
