date:20170704

[webkit-changes] [219125] trunk/Source/WebCore

2017-07-04 Thread said

Title: [219125] trunk/Source/WebCore








Revision 219125
Author s...@apple.com
Date 2017-07-04 21:44:26 -0700 (Tue, 04 Jul 2017)


Log Message
Unreviewed, review follow-up after r218961

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::updateFromSettings):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (219124 => 219125)

--- trunk/Source/WebCore/ChangeLog	2017-07-05 00:59:11 UTC (rev 219124)
+++ trunk/Source/WebCore/ChangeLog	2017-07-05 04:44:26 UTC (rev 219125)
@@ -1,3 +1,10 @@
+2017-07-04  Said Abou-Hallawa  
+
+Unreviewed, review follow-up after r218961
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::updateFromSettings):
+
 2017-07-04  Antti Koivisto  
 
 RenderThemeCocoa::mediaControlsFormattedStringForDuration is leaking NSDateComponentsFormatters


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (219124 => 219125)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-07-05 00:59:11 UTC (rev 219124)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-07-05 04:44:26 UTC (rev 219125)
@@ -70,7 +70,9 @@
 {
 m_allowSubsampling = settings.imageSubsamplingEnabled();
 #if PLATFORM(IOS)
-if (!IOSApplication::isIBooks())
+if (IOSApplication::isIBooks())
+m_allowLargeImageAsyncDecoding = false;
+else
 #endif
 m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled();
 m_allowAnimatedImageAsyncDecoding = settings.animatedImageAsyncDecodingEnabled();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219124] trunk/Source/WTF

2017-07-04 Thread utatane . tea

Title: [219124] trunk/Source/WTF








Revision 219124
Author utatane@gmail.com
Date 2017-07-04 17:59:11 -0700 (Tue, 04 Jul 2017)


Log Message
[WTF] Make double-conversion's cache data constant and drop double_conversion::initialize()
https://bugs.webkit.org/show_bug.cgi?id=174124

Reviewed by Saam Barati.

We annotate double-conversion's cache data as const and constexpr. And move it out of function.
Since they are not involving global constructors, they are compiled as rodata and initialized
without calling double_conversion::initialize().

And we drop double_conversion::initialize() function since it is no longer necessary.

* wtf/Threading.cpp:
(WTF::initializeThreading):
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/cached-powers.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Threading.cpp
trunk/Source/WTF/wtf/dtoa/cached-powers.cc
trunk/Source/WTF/wtf/dtoa/cached-powers.h




Diff

Modified: trunk/Source/WTF/ChangeLog (219123 => 219124)

--- trunk/Source/WTF/ChangeLog	2017-07-04 22:07:53 UTC (rev 219123)
+++ trunk/Source/WTF/ChangeLog	2017-07-05 00:59:11 UTC (rev 219124)
@@ -1,5 +1,23 @@
 2017-07-04  Yusuke Suzuki  
 
+[WTF] Make double-conversion's cache data constant and drop double_conversion::initialize()
+https://bugs.webkit.org/show_bug.cgi?id=174124
+
+Reviewed by Saam Barati.
+
+We annotate double-conversion's cache data as const and constexpr. And move it out of function.
+Since they are not involving global constructors, they are compiled as rodata and initialized
+without calling double_conversion::initialize().
+
+And we drop double_conversion::initialize() function since it is no longer necessary.
+
+* wtf/Threading.cpp:
+(WTF::initializeThreading):
+* wtf/dtoa/cached-powers.cc:
+* wtf/dtoa/cached-powers.h:
+
+2017-07-04  Yusuke Suzuki  
+
 [WTF] Initialize srandom and srand with cryptographically random number
 https://bugs.webkit.org/show_bug.cgi?id=174123
 


Modified: trunk/Source/WTF/wtf/Threading.cpp (219123 => 219124)

--- trunk/Source/WTF/wtf/Threading.cpp	2017-07-04 22:07:53 UTC (rev 219123)
+++ trunk/Source/WTF/wtf/Threading.cpp	2017-07-05 00:59:11 UTC (rev 219124)
@@ -165,7 +165,6 @@
 {
 static std::once_flag initializeKey;
 std::call_once(initializeKey, [] {
-WTF::double_conversion::initialize();
 ThreadHolder::initializeOnce();
 // StringImpl::empty() does not construct its static string in a threadsafe fashion,
 // so ensure it has been initialized from here.


Modified: trunk/Source/WTF/wtf/dtoa/cached-powers.cc (219123 => 219124)

--- trunk/Source/WTF/wtf/dtoa/cached-powers.cc	2017-07-04 22:07:53 UTC (rev 219123)
+++ trunk/Source/WTF/wtf/dtoa/cached-powers.cc	2017-07-05 00:59:11 UTC (rev 219124)
@@ -44,115 +44,103 @@
 int16_t decimal_exponent;
 };
 
-static int kCachedPowersLength = 1;
-static int kCachedPowersOffset = 1;
-static const double kD_1_LOG2_10 = 0.30102999566398114;  //  1 / lg(10)
-static const CachedPower* kCachedPowers = 0;
+constexpr static const double kD_1_LOG2_10 = 0.30102999566398114;  //  1 / lg(10)
+constexpr static const CachedPower kCachedPowers[] = {
+{UINT64_2PART_C(0xfa8fd5a0, 081c0288), -1220, -348},
+{UINT64_2PART_C(0xbaaee17f, a23ebf76), -1193, -340},
+{UINT64_2PART_C(0x8b16fb20, 3055ac76), -1166, -332},
+{UINT64_2PART_C(0xcf42894a, 5dce35ea), -1140, -324},
+{UINT64_2PART_C(0x9a6bb0aa, 55653b2d), -1113, -316},
+{UINT64_2PART_C(0xe61acf03, 3d1a45df), -1087, -308},
+{UINT64_2PART_C(0xab70fe17, c79ac6ca), -1060, -300},
+{UINT64_2PART_C(0xff77b1fc, bebcdc4f), -1034, -292},
+{UINT64_2PART_C(0xbe5691ef, 416bd60c), -1007, -284},
+{UINT64_2PART_C(0x8dd01fad, 907ffc3c), -980, -276},
+{UINT64_2PART_C(0xd3515c28, 31559a83), -954, -268},
+{UINT64_2PART_C(0x9d71ac8f, ada6c9b5), -927, -260},
+{UINT64_2PART_C(0xea9c2277, 23ee8bcb), -901, -252},
+{UINT64_2PART_C(0xaecc4991, 4078536d), -874, -244},
+{UINT64_2PART_C(0x823c1279, 5db6ce57), -847, -236},
+{UINT64_2PART_C(0xc2109436, 4dfb5637), -821, -228},
+{UINT64_2PART_C(0x9096ea6f, 3848984f), -794, -220},
+{UINT64_2PART_C(0xd77485cb, 25823ac7), -768, -212},
+{UINT64_2PART_C(0xa086cfcd, 97bf97f4), -741, -204},
+{UINT64_2PART_C(0xef340a98, 172aace5), -715, -196},
+{UINT64_2PART_C(0xb23867fb, 2a35b28e), -688, -188},
+{UINT64_2PART_C(0x84c8d4df, d2c63f3b), -661, -180},
+{UINT64_2PART_C(0xc5dd4427, 1ad3cdba), -635, -172},
+{UINT64_2PART_C(0x936b9fce, bb25c996), -608, -164},
+{UINT64_2PART_C(0xdbac6c24, 7d62a584), -582, -156},
+{UINT64_2PART_C(0xa3ab6658, 0d5fdaf6), -555, -148},
+{UINT64_2PART_C(0xf3e2f893, dec3f126), -529, -140},
+

[webkit-changes] [219123] trunk/Source/WebCore

2017-07-04 Thread antti

Title: [219123] trunk/Source/WebCore








Revision 219123
Author an...@apple.com
Date 2017-07-04 15:07:53 -0700 (Tue, 04 Jul 2017)


Log Message
RenderThemeCocoa::mediaControlsFormattedStringForDuration is leaking NSDateComponentsFormatters
https://bugs.webkit.org/show_bug.cgi?id=174138

Reviewed by Ryosuke Niwa.

Saw a random spin here during media playback. Looks like we are leaking.

* rendering/RenderThemeCocoa.h:
* rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::mediaControlsFormattedStringForDuration):

Reuse NSDateComponentsFormatter.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeCocoa.h
trunk/Source/WebCore/rendering/RenderThemeCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (219122 => 219123)

--- trunk/Source/WebCore/ChangeLog	2017-07-04 20:14:28 UTC (rev 219122)
+++ trunk/Source/WebCore/ChangeLog	2017-07-04 22:07:53 UTC (rev 219123)
@@ -1,5 +1,20 @@
 2017-07-04  Antti Koivisto  
 
+RenderThemeCocoa::mediaControlsFormattedStringForDuration is leaking NSDateComponentsFormatters
+https://bugs.webkit.org/show_bug.cgi?id=174138
+
+Reviewed by Ryosuke Niwa.
+
+Saw a random spin here during media playback. Looks like we are leaking.
+
+* rendering/RenderThemeCocoa.h:
+* rendering/RenderThemeCocoa.mm:
+(WebCore::RenderThemeCocoa::mediaControlsFormattedStringForDuration):
+
+Reuse NSDateComponentsFormatter.
+
+2017-07-04  Antti Koivisto  
+
 FrameView should not set RenderView::logicalWidth directly for printing
 https://bugs.webkit.org/show_bug.cgi?id=174135
 


Modified: trunk/Source/WebCore/rendering/RenderThemeCocoa.h (219122 => 219123)

--- trunk/Source/WebCore/rendering/RenderThemeCocoa.h	2017-07-04 20:14:28 UTC (rev 219122)
+++ trunk/Source/WebCore/rendering/RenderThemeCocoa.h	2017-07-04 22:07:53 UTC (rev 219123)
@@ -26,7 +26,12 @@
 #pragma once
 
 #include "RenderTheme.h"
+#include 
 
+#if ENABLE(MEDIA_CONTROLS_SCRIPT)
+OBJC_CLASS NSDateComponentsFormatter;
+#endif
+
 namespace WebCore {
 
 class RenderThemeCocoa : public RenderTheme {
@@ -39,6 +44,9 @@
 #if ENABLE(VIDEO)
 String mediaControlsFormattedStringForDuration(double) override;
 #endif
+#if ENABLE(MEDIA_CONTROLS_SCRIPT)
+RetainPtr m_durationFormatter;
+#endif
 };
 
 }


Modified: trunk/Source/WebCore/rendering/RenderThemeCocoa.mm (219122 => 219123)

--- trunk/Source/WebCore/rendering/RenderThemeCocoa.mm	2017-07-04 20:14:28 UTC (rev 219122)
+++ trunk/Source/WebCore/rendering/RenderThemeCocoa.mm	2017-07-04 22:07:53 UTC (rev 219123)
@@ -117,12 +117,14 @@
 if (!std::isfinite(durationInSeconds))
 return WEB_UI_STRING("indefinite time", "accessibility help text for an indefinite media controller time value");
 
-NSDateComponentsFormatter *durationFormatter = [NSDateComponentsFormatter new];
-durationFormatter.unitsStyle = NSDateComponentsFormatterUnitsStyleFull;
-durationFormatter.allowedUnits = NSCalendarUnitHour | NSCalendarUnitMinute | NSCalendarUnitSecond;
-durationFormatter.formattingContext = NSFormattingContextStandalone;
-durationFormatter.maximumUnitCount = 2;
-return [durationFormatter stringFromTimeInterval:durationInSeconds];
+if (!m_durationFormatter) {
+m_durationFormatter = adoptNS([NSDateComponentsFormatter new]);
+m_durationFormatter.get().unitsStyle = NSDateComponentsFormatterUnitsStyleFull;
+m_durationFormatter.get().allowedUnits = NSCalendarUnitHour | NSCalendarUnitMinute | NSCalendarUnitSecond;
+m_durationFormatter.get().formattingContext = NSFormattingContextStandalone;
+m_durationFormatter.get().maximumUnitCount = 2;
+}
+return [m_durationFormatter.get() stringFromTimeInterval:durationInSeconds];
 #else
 return emptyString();
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219122] trunk/Tools

2017-07-04 Thread mcatanzaro

Title: [219122] trunk/Tools








Revision 219122
Author mcatanz...@igalia.com
Date 2017-07-04 13:14:28 -0700 (Tue, 04 Jul 2017)


Log Message
Remove unused EFL logo from bot watcher dashboard
https://bugs.webkit.org/show_bug.cgi?id=174136

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/e...@2x.png: Removed.

Modified Paths

trunk/Tools/ChangeLog


Removed Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/e...@2x.png




Diff

Deleted: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png

(Binary files differ)


Deleted: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/e...@2x.png

(Binary files differ)


Modified: trunk/Tools/ChangeLog (219121 => 219122)

--- trunk/Tools/ChangeLog	2017-07-04 17:58:36 UTC (rev 219121)
+++ trunk/Tools/ChangeLog	2017-07-04 20:14:28 UTC (rev 219122)
@@ -1,5 +1,15 @@
 2017-07-04  Michael Catanzaro  
 
+Remove unused EFL logo from bot watcher dashboard
+https://bugs.webkit.org/show_bug.cgi?id=174136
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/e...@2x.png: Removed.
+
+2017-07-04  Michael Catanzaro  
+
 [GTK] Add more GTK bots to dashboard
 https://bugs.webkit.org/show_bug.cgi?id=174129
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219121] trunk

2017-07-04 Thread antti

Title: [219121] trunk








Revision 219121
Author an...@apple.com
Date 2017-07-04 10:58:36 -0700 (Tue, 04 Jul 2017)


Log Message
FrameView should not set RenderView::logicalWidth directly for printing
https://bugs.webkit.org/show_bug.cgi?id=174135

Reviewed by Zalan Bujtas.

Source/WebCore:

Renderer logicalWidth should be set by layout. Direct override by RenderView when printing means
that we don't layout children in all cases when the width changes. This is currently mostly hidden
by spurious layouts but causes problems when trying to fix other things that reduces those.

* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutForPagination):

Instead of calling setLogicalWidth directly call the new setPageLogicalSize that sets both the width
and the height uniformly.

* rendering/RenderView.cpp:
(WebCore::RenderView::updateLogicalWidth):

Use pageLogicalSize->width() in printing state instead of skipping the logical width update entirely.
This ensures that the layout will progress to children when the page logical width changes.

(WebCore::RenderView::initializeLayoutState):
(WebCore::RenderView::layout):
(WebCore::RenderView::pageOrViewLogicalHeight):
(WebCore::RenderView::setPageLogicalSize):
* rendering/RenderView.h:

Replace the existing m_pageLogicalHeight with std::optional m_pageLogicalSize.

LayoutTests:

* platform/mac/printing/width-overflow-expected.txt:

This is a progression, view and root element sizes now match.
Printing output is not affected.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/printing/width-overflow-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h




Diff

Modified: trunk/LayoutTests/ChangeLog (219120 => 219121)

--- trunk/LayoutTests/ChangeLog	2017-07-04 17:51:30 UTC (rev 219120)
+++ trunk/LayoutTests/ChangeLog	2017-07-04 17:58:36 UTC (rev 219121)
@@ -1,3 +1,15 @@
+2017-07-04  Antti Koivisto  
+
+FrameView should not set RenderView::logicalWidth directly for printing
+https://bugs.webkit.org/show_bug.cgi?id=174135
+
+Reviewed by Zalan Bujtas.
+
+* platform/mac/printing/width-overflow-expected.txt:
+
+This is a progression, view and root element sizes now match.
+Printing output is not affected.
+
 2017-07-03  Saam Barati  
 
 LayoutTest workers/bomb.html is a Crash


Modified: trunk/LayoutTests/platform/mac/printing/width-overflow-expected.txt (219120 => 219121)

--- trunk/LayoutTests/platform/mac/printing/width-overflow-expected.txt	2017-07-04 17:51:30 UTC (rev 219120)
+++ trunk/LayoutTests/platform/mac/printing/width-overflow-expected.txt	2017-07-04 17:58:36 UTC (rev 219121)
@@ -1,9 +1,9 @@
 layer at (0,0) size 1300x2284
   RenderView at (0,0) size 1300x2284
-layer at (0,0) size 981x2284
-  RenderBlock {HTML} at (0,0) size 981x2284
-RenderBody {BODY} at (0,16) size 981x2252
-  RenderBlock {P} at (0,0) size 981x18
+layer at (0,0) size 1300x2284
+  RenderBlock {HTML} at (0,0) size 1300x2284
+RenderBody {BODY} at (0,16) size 1300x2252
+  RenderBlock {P} at (0,0) size 1300x18
 RenderText {#text} at (0,0) size 765x18
   text run at (0,0) width 765: "To run this test manually, print this page. If the right side of any lines is printed without being truncated, the test passes."
   RenderBlock {DIV} at (0,34) size 1300x2218


Modified: trunk/Source/WebCore/ChangeLog (219120 => 219121)

--- trunk/Source/WebCore/ChangeLog	2017-07-04 17:51:30 UTC (rev 219120)
+++ trunk/Source/WebCore/ChangeLog	2017-07-04 17:58:36 UTC (rev 219121)
@@ -1,3 +1,34 @@
+2017-07-04  Antti Koivisto  
+
+FrameView should not set RenderView::logicalWidth directly for printing
+https://bugs.webkit.org/show_bug.cgi?id=174135
+
+Reviewed by Zalan Bujtas.
+
+Renderer logicalWidth should be set by layout. Direct override by RenderView when printing means
+that we don't layout children in all cases when the width changes. This is currently mostly hidden
+by spurious layouts but causes problems when trying to fix other things that reduces those.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::forceLayoutForPagination):
+
+Instead of calling setLogicalWidth directly call the new setPageLogicalSize that sets both the width
+and the height uniformly.
+
+* rendering/RenderView.cpp:
+(WebCore::RenderView::updateLogicalWidth):
+
+Use pageLogicalSize->width() in printing state instead of skipping the logical width update entirely.
+This ensures that the layout will progress to children when the page logical width changes.
+
+(WebCore::RenderView::initializeLayoutState):
+(WebCore::RenderView::layout):
+

[webkit-changes] [219120] trunk/Tools

2017-07-04 Thread mcatanzaro

Title: [219120] trunk/Tools








Revision 219120
Author mcatanz...@igalia.com
Date 2017-07-04 10:51:30 -0700 (Tue, 04 Jul 2017)


Log Message
[GTK] Add more GTK bots to dashboard
https://bugs.webkit.org/show_bug.cgi?id=174129

Reviewed by Carlos Alberto Lopez Perez.

We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
them.

This also changes the sort order to put WPE above GTK so that it's not buried under all the
less-essential GTK bots.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js (219119 => 219120)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js	2017-07-04 17:43:18 UTC (rev 219119)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js	2017-07-04 17:51:30 UTC (rev 219120)
@@ -35,8 +35,8 @@
 Windows8: { name: "windows-8", readableName: "Windows 8", order: 50 },
 Windows7: { name: "windows-7", readableName: "Windows 7", order: 60 },
 WindowsXP: { name: "windows-xp", readableName: "Windows XP", order: 70 },
-LinuxGTK: { name : "linux-gtk", readableName: "Linux GTK", order: 90 },
-LinuxWPE: { name : "linux-wpe", readableName: "Linux WPE", order: 91 }
+LinuxWPE: { name : "linux-wpe", readableName: "Linux WPE", order: 90 },
+LinuxGTK: { name : "linux-gtk", readableName: "Linux GTK", order: 91 }
 },
 Branch: {},
 Repository: {


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (219119 => 219120)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2017-07-04 17:43:18 UTC (rev 219119)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2017-07-04 17:51:30 UTC (rev 219120)
@@ -67,13 +67,26 @@
 "Apple Win Release (Build)": {platform: Dashboard.Platform.Windows7, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
 "Apple Win 7 Debug (Tests)": {platform: Dashboard.Platform.Windows7, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
 "Apple Win 7 Release (Tests)": {platform: Dashboard.Platform.Windows7, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
+"WPE Linux 64-bit Release (Build)": {platform: Dashboard.Platform.LinuxWPE, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
+"WPE Linux 64-bit Release (Tests)": {platform: Dashboard.Platform.LinuxWPE, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
 "GTK Linux 64-bit Release (Build)": {platform: Dashboard.Platform.LinuxGTK, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
 "GTK Linux 64-bit Release (Tests)": {platform: Dashboard.Platform.LinuxGTK, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
 "GTK Linux 64-bit Debug (Build)": {platform: Dashboard.Platform.LinuxGTK, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
 "GTK Linux 64-bit Debug (Tests)": {platform: Dashboard.Platform.LinuxGTK, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
 "GTK Linux 64-bit Release (Perf)": {platform: Dashboard.Platform.LinuxGTK, debug: false, performance: true, heading: "Performance"},
-"WPE Linux 64-bit Release (Build)": {platform: Dashboard.Platform.LinuxWPE, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
-"WPE Linux 64-bit Release (Tests)": {platform: Dashboard.Platform.LinuxWPE, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2}
+"GTK LTS Builders": {platform: Dashboard.Platform.LinuxGTK, heading: "LTS Builders", combinedQueues: {
+"GTK Linux 64-bit Release Debian Stable (Build)": {heading: "Debian Stable (Build)"},
+"GTK Linux 64-bit Release Ubuntu LTS (Build)": {heading: "Ubuntu LTS (Build)"},
+}},
+"GTK Wayland Testers": {platform: Dashboard.Platform.LinuxGTK, heading: "Wayland", combinedQueues: {
+"GTK Linux 64-bit Release Wayland (Tests)": {heading: "Wayland"},
+}},
+"GTK ARM Testers": {platform: Dashboard.Platform.LinuxGTK, heading: "ARM", combinedQueues: {
+"GTK Linux ARM Release": {heading: "ARM"}
+}},
+"GTK

[webkit-changes] [219119] trunk/Source/WTF

2017-07-04 Thread utatane . tea

Title: [219119] trunk/Source/WTF








Revision 219119
Author utatane@gmail.com
Date 2017-07-04 10:43:18 -0700 (Tue, 04 Jul 2017)


Log Message
[WTF] Initialize srandom and srand with cryptographically random number
https://bugs.webkit.org/show_bug.cgi?id=174123

Reviewed by Mark Lam.

Use cryptographically random number instead of current time as a seed.

* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/RandomNumberSeed.h




Diff

Modified: trunk/Source/WTF/ChangeLog (219118 => 219119)

--- trunk/Source/WTF/ChangeLog	2017-07-04 14:02:42 UTC (rev 219118)
+++ trunk/Source/WTF/ChangeLog	2017-07-04 17:43:18 UTC (rev 219119)
@@ -1,3 +1,15 @@
+2017-07-04  Yusuke Suzuki  
+
+[WTF] Initialize srandom and srand with cryptographically random number
+https://bugs.webkit.org/show_bug.cgi?id=174123
+
+Reviewed by Mark Lam.
+
+Use cryptographically random number instead of current time as a seed.
+
+* wtf/RandomNumberSeed.h:
+(WTF::initializeRandomNumberGenerator):
+
 2017-07-04  Joseph Pecoraro  
 
 Xcode duplicate UUID for DisallowCType.h and DispatchPtr.h


Modified: trunk/Source/WTF/wtf/RandomNumberSeed.h (219118 => 219119)

--- trunk/Source/WTF/wtf/RandomNumberSeed.h	2017-07-04 14:02:42 UTC (rev 219118)
+++ trunk/Source/WTF/wtf/RandomNumberSeed.h	2017-07-04 17:43:18 UTC (rev 219119)
@@ -28,6 +28,7 @@
 
 #include 
 #include 
+#include 
 
 #if HAVE(SYS_TIME_H)
 #include 
@@ -47,12 +48,9 @@
 #elif COMPILER(MSVC) && defined(_CRT_RAND_S)
 // On Windows we use rand_s which initialises itself
 #elif OS(UNIX)
-// srandomdev is not guaranteed to exist on linux so we use this poor seed, this should be improved
-timeval time;
-gettimeofday(, 0);
-srandom(static_cast(time.tv_usec * getpid()));
+srandom(cryptographicallyRandomNumber());
 #else
-srand(static_cast(time(0)));
+srand(cryptographicallyRandomNumber());
 #endif
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219118] trunk/Tools

2017-07-04 Thread mcatanzaro

Title: [219118] trunk/Tools








Revision 219118
Author mcatanz...@igalia.com
Date 2017-07-04 07:02:42 -0700 (Tue, 04 Jul 2017)


Log Message
[WPE] Add WPE to bot watcher dashboard
https://bugs.webkit.org/show_bug.cgi?id=174119

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/w...@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.linux-wpe img.logo):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/w...@2x.png




Diff

Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT (0 => 219118)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT	2017-07-04 14:02:42 UTC (rev 219118)
@@ -0,0 +1,6 @@
+The Tux images in this directory are downloaded from Wikimedia Commons:
+
+https://en.wikipedia.org/wiki/File:Classic_flat_look_3D.svg
+
+License: "The copyright holder of this file allows anyone to use it for any purpose,
+provided that you acknowledge lew...@isc.tamu.edu and The GIMP if someone asks."


Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png

(Binary files differ)

Index: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png
===
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png	2017-07-04 11:43:14 UTC (rev 219117)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png	2017-07-04 14:02:42 UTC (rev 219118)
Property changes on: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png
___

Added: svn:mime-type
+image/png
\ No newline at end of property

Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/w...@2x.png

(Binary files differ)

Index: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/w...@2x.png
===
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/w...@2x.png	2017-07-04 11:43:14 UTC (rev 219117)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/w...@2x.png	2017-07-04 14:02:42 UTC (rev 219118)
Property changes on: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/w...@2x.png
___

Added: svn:mime-type
+image/png
\ No newline at end of property

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js (219117 => 219118)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js	2017-07-04 11:43:14 UTC (rev 219117)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js	2017-07-04 14:02:42 UTC (rev 219118)
@@ -35,7 +35,8 @@
 Windows8: { name: "windows-8", readableName: "Windows 8", order: 50 },
 Windows7: { name: "windows-7", readableName: "Windows 7", order: 60 },
 WindowsXP: { name: "windows-xp", readableName: "Windows XP", order: 70 },
-LinuxGTK: { name : "linux-gtk", readableName: "Linux GTK", order: 90 }
+LinuxGTK: { name : "linux-gtk", readableName: "Linux GTK", order: 90 },
+LinuxWPE: { name : "linux-wpe", readableName: "Linux WPE", order: 91 }
 },
 Branch: {},
 Repository: {


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (219117 => 219118)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js

[webkit-changes] [219117] trunk/Source/WTF

2017-07-04 Thread commit-queue

Title: [219117] trunk/Source/WTF








Revision 219117
Author commit-qu...@webkit.org
Date 2017-07-04 04:43:14 -0700 (Tue, 04 Jul 2017)


Log Message
Xcode duplicate UUID for DisallowCType.h and DispatchPtr.h
https://bugs.webkit.org/show_bug.cgi?id=174117

Patch by Joseph Pecoraro  on 2017-07-04
Reviewed by Alexey Proskuryakov.

* WTF.xcodeproj/project.pbxproj:
Give DisallowCType.h and DispatchPtr.h different UUIDs.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WTF/ChangeLog (219116 => 219117)

--- trunk/Source/WTF/ChangeLog	2017-07-04 11:12:26 UTC (rev 219116)
+++ trunk/Source/WTF/ChangeLog	2017-07-04 11:43:14 UTC (rev 219117)
@@ -1,3 +1,13 @@
+2017-07-04  Joseph Pecoraro  
+
+Xcode duplicate UUID for DisallowCType.h and DispatchPtr.h
+https://bugs.webkit.org/show_bug.cgi?id=174117
+
+Reviewed by Alexey Proskuryakov.
+
+* WTF.xcodeproj/project.pbxproj:
+Give DisallowCType.h and DispatchPtr.h different UUIDs.
+
 2017-07-03  Saam Barati  
 
 LayoutTest workers/bomb.html is a Crash


Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (219116 => 219117)

--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2017-07-04 11:12:26 UTC (rev 219116)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2017-07-04 11:43:14 UTC (rev 219117)
@@ -381,7 +381,7 @@
 		A8A4727B151A825A004123FF /* DecimalNumber.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DecimalNumber.cpp; sourceTree = ""; };
 		A8A4727C151A825A004123FF /* DecimalNumber.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DecimalNumber.h; sourceTree = ""; };
 		A8A4727E151A825A004123FF /* Deque.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Deque.h; sourceTree = ""; };
-		A8A4727F151A825A004123FF /* DisallowCType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DisallowCType.h; sourceTree = ""; };
+		A9A4727F151A825A004123FF /* DisallowCType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DisallowCType.h; sourceTree = ""; };
 		A8A4727F151A825A004123FF /* DispatchPtr.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DispatchPtr.h; sourceTree = ""; };
 		A8A47280151A825A004123FF /* DoublyLinkedList.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DoublyLinkedList.h; sourceTree = ""; };
 		A8A47282151A825A004123FF /* bignum-dtoa.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = "bignum-dtoa.cc"; sourceTree = ""; };
@@ -771,8 +771,8 @@
 0F2B66A417B6B4F700A7AE3F /* DeferrableRefCounted.h */,
 A561F30F1DF2642100FF675D /* DeprecatedOptional.h */,
 A8A4727E151A825A004123FF /* Deque.h */,
-A8A4727F151A825A004123FF /* DisallowCType.h */,
-A8A4727F151A825A004123FF /* DispatchPtr.h */,
+A9A4727F151A825A004123FF /* DisallowCType.h */,
+A8A4727F151A825A004123FF /* DispatchPtr.h */,
 0F4570421BE5B58F0062A629 /* Dominators.h */,
 A8A47280151A825A004123FF /* DoublyLinkedList.h */,
 A8A47297151A825A004123FF /* dtoa.cpp */,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219116] trunk/Source/WebCore

2017-07-04 Thread calvaris

Title: [219116] trunk/Source/WebCore








Revision 219116
Author calva...@igalia.com
Date 2017-07-04 04:12:26 -0700 (Tue, 04 Jul 2017)


Log Message
[EME] Solve a couple of compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=174020

Reviewed by Michael Catanzaro.

* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::isPersistentType): Added default return and
assertion.
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::updateKeyStatuses): This warning was
already solved but I think adding an assertion for the default
case can help catch errors in the future.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (219115 => 219116)

--- trunk/Source/WebCore/ChangeLog	2017-07-04 08:03:06 UTC (rev 219115)
+++ trunk/Source/WebCore/ChangeLog	2017-07-04 11:12:26 UTC (rev 219116)
@@ -1,3 +1,18 @@
+2017-07-04  Xabier Rodriguez Calvar  
+
+[EME] Solve a couple of compiler warnings
+https://bugs.webkit.org/show_bug.cgi?id=174020
+
+Reviewed by Michael Catanzaro.
+
+* Modules/encryptedmedia/CDM.cpp:
+(WebCore::CDM::isPersistentType): Added default return and
+assertion.
+* Modules/encryptedmedia/MediaKeySession.cpp:
+(WebCore::MediaKeySession::updateKeyStatuses): This warning was
+already solved but I think adding an assertion for the default
+case can help catch errors in the future.
+
 2017-07-04  Joseph Pecoraro  
 
 Cleanup some StringBuilder use


Modified: trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp (219115 => 219116)

--- trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp	2017-07-04 08:03:06 UTC (rev 219115)
+++ trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp	2017-07-04 11:12:26 UTC (rev 219116)
@@ -181,6 +181,9 @@
 // ↳ "persistent-license"
 return true;
 }
+
+ASSERT_NOT_REACHED();
+return false;
 }
 
 std::optional CDM::getSupportedConfiguration(const MediaKeySystemConfiguration& candidateConfiguration, MediaKeysRestrictions& restrictions)


Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp (219115 => 219116)

--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp	2017-07-04 08:03:06 UTC (rev 219115)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp	2017-07-04 11:12:26 UTC (rev 219116)
@@ -632,8 +632,10 @@
 case CDMInstance::KeyStatus::StatusPending:
 return MediaKeyStatus::StatusPending;
 case CDMInstance::KeyStatus::InternalError:
-break;
+return MediaKeyStatus::InternalError;
 };
+
+ASSERT_NOT_REACHED();
 return MediaKeyStatus::InternalError;
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219115] trunk/Source

2017-07-04 Thread commit-queue

Title: [219115] trunk/Source








Revision 219115
Author commit-qu...@webkit.org
Date 2017-07-04 01:03:06 -0700 (Tue, 04 Jul 2017)


Log Message
Cleanup some StringBuilder use
https://bugs.webkit.org/show_bug.cgi?id=174118

Patch by Joseph Pecoraro  on 2017-07-04
Reviewed by Andreas Kling.

Source/_javascript_Core:

* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
* tools/FunctionOverrides.cpp:
(JSC::parseClause):
* wasm/WasmOMGPlan.cpp:
* wasm/WasmPlan.cpp:
* wasm/WasmValidate.cpp:

Source/WebCore:

* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::filterICECandidate):
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
* contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):
* css/CSSFontStyleRangeValue.cpp:
(WebCore::CSSFontStyleRangeValue::customCSSText):
* css/CSSFontStyleValue.cpp:
(WebCore::CSSFontStyleValue::customCSSText):
* css/CSSGridAutoRepeatValue.cpp:
(WebCore::CSSGridAutoRepeatValue::customCSSText):
* css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceDescriptor):
* dom/Attr.cpp:
* html/canvas/WebGPURenderingContext.cpp:
* html/parser/HTMLParserIdioms.cpp:
* platform/network/ParsedContentType.cpp:
* platform/network/cocoa/CookieCocoa.mm:
* platform/text/mac/LocaleMac.mm:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::getAllResponseHeaders):

Source/WebKit2:

* NetworkProcess/capture/NetworkCaptureManager.cpp:
(WebKit::NetworkCapture::Manager::hashToPath):
* UIProcess/WebPageProxy.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp
trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp
trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmValidate.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
trunk/Source/WebCore/contentextensions/ContentExtension.cpp
trunk/Source/WebCore/css/CSSFontStyleRangeValue.cpp
trunk/Source/WebCore/css/CSSFontStyleValue.cpp
trunk/Source/WebCore/css/CSSGridAutoRepeatValue.cpp
trunk/Source/WebCore/css/parser/CSSParser.cpp
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/html/canvas/WebGPURenderingContext.cpp
trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp
trunk/Source/WebCore/platform/network/ParsedContentType.cpp
trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm
trunk/Source/WebCore/platform/text/mac/LocaleMac.mm
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/capture/NetworkCaptureManager.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (219114 => 219115)

--- trunk/Source/_javascript_Core/ChangeLog	2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-07-04 08:03:06 UTC (rev 219115)
@@ -1,3 +1,18 @@
+2017-07-04  Joseph Pecoraro  
+
+Cleanup some StringBuilder use
+https://bugs.webkit.org/show_bug.cgi?id=174118
+
+Reviewed by Andreas Kling.
+
+* runtime/FunctionConstructor.cpp:
+(JSC::constructFunctionSkippingEvalEnabledCheck):
+* tools/FunctionOverrides.cpp:
+(JSC::parseClause):
+* wasm/WasmOMGPlan.cpp:
+* wasm/WasmPlan.cpp:
+* wasm/WasmValidate.cpp:
+
 2017-07-03  Saam Barati  
 
 LayoutTest workers/bomb.html is a Crash


Modified: trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp (219114 => 219115)

--- trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp	2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp	2017-07-04 08:03:06 UTC (rev 219115)
@@ -137,7 +137,7 @@
 program = makeString("{", prefix, functionName.string(), "() {\n", body, "\n}}");
 } else {
 StringBuilder builder;
-builder.append("{");
+builder.append('{');
 builder.append(prefix);
 builder.append(functionName.string());
 builder.append('(');


Modified: trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp (219114 => 219115)

--- trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp	2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp	2017-07-04 08:03:06 UTC (rev 219115)
@@ -203,7 +203,7 @@
 FAIL_WITH_ERROR(SYNTAX_ERROR, ("Delimiter '", delimiter, "' cannot have '{', '}', or whitespace:\n", line, "\n"));
 
 String terminatorString;
-terminatorString.append("}");
+terminatorString.append('}');
 terminatorString.append(delimiter);
 
 CString terminatorCString = terminatorString.ascii();


Modified:

[webkit-changes] [219125] trunk/Source/WebCore

[webkit-changes] [219124] trunk/Source/WTF

[webkit-changes] [219123] trunk/Source/WebCore

[webkit-changes] [219122] trunk/Tools

[webkit-changes] [219121] trunk

[webkit-changes] [219120] trunk/Tools

[webkit-changes] [219119] trunk/Source/WTF

[webkit-changes] [219118] trunk/Tools

[webkit-changes] [219117] trunk/Source/WTF

[webkit-changes] [219116] trunk/Source/WebCore

[webkit-changes] [219115] trunk/Source

11 matches

Site Navigation

Mail list logo

Footer information