[webkit-changes] [224909] trunk/Source
Title: [224909] trunk/Source Revision 224909 Author beid...@apple.com Date 2017-11-15 19:05:02 -0800 (Wed, 15 Nov 2017) Log Message Implement basics of "Terminate Service Worker" algorithm. https://bugs.webkit.org/show_bug.cgi?id=179551 Reviewed by Chris Dumez. Source/WebCore: No new tests (No observable behavior change yet). * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::stopIndexedDatabase): * workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerThreadCreated): (WebCore::WorkerMessagingProxy::terminateWorkerGlobalScope): * workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): (WebCore::WorkerThread::stop): * workers/WorkerThread.h: * workers/service/context/SWContextManager.cpp: (WebCore::SWContextManager::terminateWorker): * workers/service/context/SWContextManager.h: * workers/service/server/SWServer.cpp: (WebCore::SWServer::workerContextTerminated): (WebCore::SWServer::terminateWorker): * workers/service/server/SWServer.h: * workers/service/server/SWServerToContextConnection.cpp: (WebCore::SWServerToContextConnection::workerTerminated): * workers/service/server/SWServerToContextConnection.h: * workers/service/server/SWServerWorker.cpp: (WebCore::SWServerWorker::terminate): (WebCore::SWServerWorker::contextTerminated): * workers/service/server/SWServerWorker.h: Source/WebKit: * StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::terminateWorker): * StorageProcess/ServiceWorker/WebSWServerToContextConnection.h: * StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in: * WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::terminateWorker): (WebKit::WebSWContextManagerConnection::workerTerminated): * WebProcess/Storage/WebSWContextManagerConnection.h: * WebProcess/Storage/WebSWContextManagerConnection.messages.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/WorkerGlobalScope.cpp trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp trunk/Source/WebCore/workers/WorkerThread.cpp trunk/Source/WebCore/workers/WorkerThread.h trunk/Source/WebCore/workers/service/context/SWContextManager.cpp trunk/Source/WebCore/workers/service/context/SWContextManager.h trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebCore/workers/service/server/SWServer.h trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.cpp trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp trunk/Source/WebCore/workers/service/server/SWServerWorker.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.h trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in Diff Modified: trunk/Source/WebCore/ChangeLog (224908 => 224909) --- trunk/Source/WebCore/ChangeLog 2017-11-16 01:17:02 UTC (rev 224908) +++ trunk/Source/WebCore/ChangeLog 2017-11-16 03:05:02 UTC (rev 224909) @@ -1,3 +1,42 @@ +2017-11-15 Brady Eidson + +Implement basics of "Terminate Service Worker" algorithm. +https://bugs.webkit.org/show_bug.cgi?id=179551 + +Reviewed by Chris Dumez. + +No new tests (No observable behavior change yet). + +* workers/WorkerGlobalScope.cpp: +(WebCore::WorkerGlobalScope::stopIndexedDatabase): + +* workers/WorkerMessagingProxy.cpp: +(WebCore::WorkerMessagingProxy::workerThreadCreated): +(WebCore::WorkerMessagingProxy::terminateWorkerGlobalScope): + +* workers/WorkerThread.cpp: +(WebCore::WorkerThread::workerThread): +(WebCore::WorkerThread::stop): +* workers/WorkerThread.h: + +* workers/service/context/SWContextManager.cpp: +(WebCore::SWContextManager::terminateWorker): +* workers/service/context/SWContextManager.h: + +* workers/service/server/SWServer.cpp: +(WebCore::SWServer::workerContextTerminated): +(WebCore::SWServer::terminateWorker): +* workers/service/server/SWServer.h: + +* workers/service/server/SWServerToContextConnection.cpp: +(WebCore::SWServerToContextConnection::workerTerminated): +* workers/service/server/SWServerToContextConnection.h: + +* workers/service/server/SWServerWorker.cpp: +(WebCore::SWServerWorker::terminate): +(WebCore::SWServerWorker::contextTerminated): +* workers/service/server/SWServerWorker.h: + 2017-11-15 Eric Carlson Log media readyState and networkState as strings Mod
[webkit-changes] [224908] trunk/Source/WebKit
Title: [224908] trunk/Source/WebKit Revision 224908 Author bfulg...@apple.com Date 2017-11-15 17:17:02 -0800 (Wed, 15 Nov 2017) Log Message Remove access to 'com.apple.mediaaccessibility.public' preferences in WebContent sandbox https://bugs.webkit.org/show_bug.cgi?id=179747 Reviewed by Dean Jackson. The 'mediaaccessibilityd' process handles access to MediaAccessibility preferences. We don't need to grant the WebContent Process sandbox access to them. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (224907 => 224908) --- trunk/Source/WebKit/ChangeLog 2017-11-16 00:36:30 UTC (rev 224907) +++ trunk/Source/WebKit/ChangeLog 2017-11-16 01:17:02 UTC (rev 224908) @@ -1,3 +1,16 @@ +2017-11-15 Brent Fulgham + +Remove access to 'com.apple.mediaaccessibility.public' preferences in WebContent sandbox +https://bugs.webkit.org/show_bug.cgi?id=179747 + + +Reviewed by Dean Jackson. + +The 'mediaaccessibilityd' process handles access to MediaAccessibility preferences. We don't need +to grant the WebContent Process sandbox access to them. + +* WebProcess/com.apple.WebProcess.sb.in: + 2017-11-15 Alex Christensen Revert r224885 Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (224907 => 224908) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2017-11-16 00:36:30 UTC (rev 224907) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2017-11-16 01:17:02 UTC (rev 224908) @@ -464,7 +464,9 @@ "com.apple.driver.AppleBluetoothMultitouch.trackpad" "com.apple.driver.AppleHIDMouse" "com.apple.lookup.shared" +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101200 "com.apple.mediaaccessibility" +#endif "com.apple.networkConnect" "com.apple.security" "com.apple.security.common" @@ -504,9 +506,11 @@ (if (defined? 'mach-register) (allow mach-register (global-name-regex #"^_oglprof_attach_<[0-9]+>$"))) +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101200 ;; MediaAccessibility (allow user-preference-read user-preference-write (preference-domain "com.apple.mediaaccessibility.public")) +#endif (if (positive? (string-length (param "DARWIN_USER_CACHE_DIR"))) (allow-read-write-directory-and-issue-read-write-extensions (param "DARWIN_USER_CACHE_DIR"))) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224907] trunk/Source/WTF
Title: [224907] trunk/Source/WTF Revision 224907 Author achristen...@apple.com Date 2017-11-15 16:36:30 -0800 (Wed, 15 Nov 2017) Log Message Fix fast/events/message-port-postMessage-recursive.html after r224896 https://bugs.webkit.org/show_bug.cgi?id=179749 Reviewed by Jer Noble. * wtf/mac/MainThreadMac.mm: (WTF::currentRunLoopInCommonMode): We sometimes run the runloop in kCFRunLoopDefaultMode, which should also have the responsiveness optimization. This allows the runloop to continue to iterate when we are doing lots of things on the main thread. CFRunLoop.h has a special definition of these two constants. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/mac/MainThreadMac.mm Diff Modified: trunk/Source/WTF/ChangeLog (224906 => 224907) --- trunk/Source/WTF/ChangeLog 2017-11-16 00:31:00 UTC (rev 224906) +++ trunk/Source/WTF/ChangeLog 2017-11-16 00:36:30 UTC (rev 224907) @@ -1,5 +1,18 @@ 2017-11-15 Alex Christensen +Fix fast/events/message-port-postMessage-recursive.html after r224896 +https://bugs.webkit.org/show_bug.cgi?id=179749 + +Reviewed by Jer Noble. + +* wtf/mac/MainThreadMac.mm: +(WTF::currentRunLoopInCommonMode): +We sometimes run the runloop in kCFRunLoopDefaultMode, which should also have the responsiveness optimization. +This allows the runloop to continue to iterate when we are doing lots of things on the main thread. +CFRunLoop.h has a special definition of these two constants. + +2017-11-15 Alex Christensen + WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time https://bugs.webkit.org/show_bug.cgi?id=179742 Modified: trunk/Source/WTF/wtf/mac/MainThreadMac.mm (224906 => 224907) --- trunk/Source/WTF/wtf/mac/MainThreadMac.mm 2017-11-16 00:31:00 UTC (rev 224906) +++ trunk/Source/WTF/wtf/mac/MainThreadMac.mm 2017-11-16 00:36:30 UTC (rev 224907) @@ -124,7 +124,9 @@ bool currentRunLoopInCommonMode() { -return [[NSRunLoop currentRunLoop] currentMode] == (NSString *)kCFRunLoopCommonModes; +NSString *currentMode = [[NSRunLoop currentRunLoop] currentMode]; +return currentMode == (NSString *)kCFRunLoopCommonModes +|| currentMode == (NSString *)kCFRunLoopDefaultMode; } void scheduleDispatchFunctionsOnMainThread(SchedulePairHashSet* pairs) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224906] trunk/Source/WebInspectorUI
Title: [224906] trunk/Source/WebInspectorUI Revision 224906 Author nvasil...@apple.com Date 2017-11-15 16:31:00 -0800 (Wed, 15 Nov 2017) Log Message Web Inspector: Styles Redesign: typing colon in property name should advance to value field https://bugs.webkit.org/show_bug.cgi?id=178795 Reviewed by Devin Rousso. * UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype._update): (WI.SpreadsheetStyleProperty.prototype._handleNameBeforeInput): Unlike pressing Tab or Enter, typing ":" in the property name should discard suggestion hint. (WI.SpreadsheetStyleProperty.prototype._valueCompletionDataProvider): We use 250ms debounce before updating this._property.name. When typing "font-f:", we want to discard suggestion hint (i.e. "font-family"), and immediately show autocomplete for "font-f" (in this case, invalid property). * UserInterface/Views/SpreadsheetTextField.js: (WI.SpreadsheetTextField): (WI.SpreadsheetTextField.prototype.stopEditing): (WI.SpreadsheetTextField.prototype.discardCompletion): Call spreadsheetTextFieldDidChange when discarding non-empty suggestion hint. (WI.SpreadsheetTextField.prototype.detached): (WI.SpreadsheetTextField.prototype.completionSuggestionsClickedCompletion): (WI.SpreadsheetTextField.prototype._handleBlur): (WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView): (WI.SpreadsheetTextField.prototype._updateCompletions): (WI.SpreadsheetTextField.prototype._applyCompletionHint): (WI.SpreadsheetTextField.prototype._hideCompletions): Deleted. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (224905 => 224906) --- trunk/Source/WebInspectorUI/ChangeLog 2017-11-15 23:39:54 UTC (rev 224905) +++ trunk/Source/WebInspectorUI/ChangeLog 2017-11-16 00:31:00 UTC (rev 224906) @@ -1,3 +1,35 @@ +2017-11-15 Nikita Vasilyev + +Web Inspector: Styles Redesign: typing colon in property name should advance to value field +https://bugs.webkit.org/show_bug.cgi?id=178795 + + +Reviewed by Devin Rousso. + +* UserInterface/Views/SpreadsheetStyleProperty.js: +(WI.SpreadsheetStyleProperty.prototype._update): +(WI.SpreadsheetStyleProperty.prototype._handleNameBeforeInput): +Unlike pressing Tab or Enter, typing ":" in the property name should discard suggestion hint. + +(WI.SpreadsheetStyleProperty.prototype._valueCompletionDataProvider): +We use 250ms debounce before updating this._property.name. +When typing "font-f:", we want to discard suggestion hint (i.e. "font-family"), +and immediately show autocomplete for "font-f" (in this case, invalid property). + +* UserInterface/Views/SpreadsheetTextField.js: +(WI.SpreadsheetTextField): +(WI.SpreadsheetTextField.prototype.stopEditing): +(WI.SpreadsheetTextField.prototype.discardCompletion): +Call spreadsheetTextFieldDidChange when discarding non-empty suggestion hint. + +(WI.SpreadsheetTextField.prototype.detached): +(WI.SpreadsheetTextField.prototype.completionSuggestionsClickedCompletion): +(WI.SpreadsheetTextField.prototype._handleBlur): +(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView): +(WI.SpreadsheetTextField.prototype._updateCompletions): +(WI.SpreadsheetTextField.prototype._applyCompletionHint): +(WI.SpreadsheetTextField.prototype._hideCompletions): Deleted. + 2017-11-15 Matt Baker Web Inspector: REGRESSION (r217750): Navigation sidebar broken after closing and re-opening tab Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (224905 => 224906) --- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2017-11-15 23:39:54 UTC (rev 224905) +++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2017-11-16 00:31:00 UTC (rev 224906) @@ -173,6 +173,8 @@ if (this._property.editable && this._property.enabled) { this._nameElement.tabIndex = 0; +this._nameElement.addEventListener("beforeinput", this._handleNameBeforeInput.bind(this)); + this._nameTextField = new WI.SpreadsheetTextField(this, this._nameElement, this._nameCompletionDataProvider.bind(this)); this._valueElement.tabIndex = 0; @@ -463,6 +465,16 @@ this._property.rawValue = this._valueElement.textContent.trim(); } +_handleNameBeforeInput(event) +{ +if (event.data !== ":" || event.inputType !== "insertText") +return; + +event.preventDefault(); +this._nameTextField.discardCompletion(); +this._valueTextField.startEditing(); +} + _nameCompletionDataProvider(prefix) { return WI.CSSCo
[webkit-changes] [224905] trunk/Source/WebInspectorUI
Title: [224905] trunk/Source/WebInspectorUI Revision 224905 Author mattba...@apple.com Date 2017-11-15 15:39:54 -0800 (Wed, 15 Nov 2017) Log Message Web Inspector: REGRESSION (r217750): Navigation sidebar broken after closing and re-opening tab https://bugs.webkit.org/show_bug.cgi?id=179717 Reviewed by Devin Rousso. NavigationSidebarPanels should not be created with WI.instanceForClass. * UserInterface/Views/DebuggerSidebarPanel.js: * UserInterface/Views/ResourceSidebarPanel.js: (WI.ResourceSidebarPanel): * UserInterface/Views/SearchSidebarPanel.js: (WI.SearchSidebarPanel): * UserInterface/Views/StorageSidebarPanel.js: (WI.StorageSidebarPanel): * UserInterface/Views/TabContentView.js: (WI.TabContentView.prototype.get navigationSidebarPanel): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/TabContentView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (224904 => 224905) --- trunk/Source/WebInspectorUI/ChangeLog 2017-11-15 23:25:34 UTC (rev 224904) +++ trunk/Source/WebInspectorUI/ChangeLog 2017-11-15 23:39:54 UTC (rev 224905) @@ -1,3 +1,23 @@ +2017-11-15 Matt Baker + +Web Inspector: REGRESSION (r217750): Navigation sidebar broken after closing and re-opening tab +https://bugs.webkit.org/show_bug.cgi?id=179717 + + +Reviewed by Devin Rousso. + +NavigationSidebarPanels should not be created with WI.instanceForClass. + +* UserInterface/Views/DebuggerSidebarPanel.js: +* UserInterface/Views/ResourceSidebarPanel.js: +(WI.ResourceSidebarPanel): +* UserInterface/Views/SearchSidebarPanel.js: +(WI.SearchSidebarPanel): +* UserInterface/Views/StorageSidebarPanel.js: +(WI.StorageSidebarPanel): +* UserInterface/Views/TabContentView.js: +(WI.TabContentView.prototype.get navigationSidebarPanel): + 2017-11-15 Michael Catanzaro Remove GTK web inspector images Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (224904 => 224905) --- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2017-11-15 23:25:34 UTC (rev 224904) +++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2017-11-15 23:39:54 UTC (rev 224905) @@ -25,12 +25,10 @@ WI.DebuggerSidebarPanel = class DebuggerSidebarPanel extends WI.NavigationSidebarPanel { -constructor(contentBrowser) +constructor() { super("debugger", WI.UIString("Debugger"), true); -this.contentBrowser = contentBrowser; - WI.Frame.addEventListener(WI.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this); WI.Frame.addEventListener(WI.Frame.Event.ResourceWasAdded, this._resourceAdded, this); WI.Target.addEventListener(WI.Target.Event.ResourceAdded, this._resourceAdded, this); Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js (224904 => 224905) --- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2017-11-15 23:25:34 UTC (rev 224904) +++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2017-11-15 23:39:54 UTC (rev 224905) @@ -25,12 +25,10 @@ WI.ResourceSidebarPanel = class ResourceSidebarPanel extends WI.NavigationSidebarPanel { -constructor(contentBrowser) +constructor() { super("resource", WI.UIString("Resources"), true); -this.contentBrowser = contentBrowser; - this._navigationBar = new WI.NavigationBar; this.addSubview(this._navigationBar); Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (224904 => 224905) --- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2017-11-15 23:25:34 UTC (rev 224904) +++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2017-11-15 23:39:54 UTC (rev 224905) @@ -25,12 +25,10 @@ WI.SearchSidebarPanel = class SearchSidebarPanel extends WI.NavigationSidebarPanel { -constructor(contentBrowser) +constructor() { super("search", WI.UIString("Search"), true, true); -this.contentBrowser = contentBrowser; - var searchElement = document.createElement("div"); searchElement.classList.add("search-bar"); this.element.appendChild(searchElement); Modified: trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js (224904 => 224905) --- trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js 2017-11-15 23:25:34 UTC (rev 224904) +++ trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js 2017-11-15 23:39:54 UTC (rev 224905) @@ -25,12 +2
[webkit-changes] [224904] trunk/Source/WebCore
Title: [224904] trunk/Source/WebCore Revision 224904 Author eric.carl...@apple.com Date 2017-11-15 15:25:34 -0800 (Wed, 15 Nov 2017) Log Message Log media readyState and networkState as strings https://bugs.webkit.org/show_bug.cgi?id=179732 Reviewed by Youenn Fablet. * html/HTMLMediaElement.cpp: (WebCore::convertEnumerationToString): (WebCore::HTMLMediaElement::scheduleDelayedAction): Fix logic error. (WebCore::HTMLMediaElement::pendingActionTimerFired): Fix incorrect log string. (WebCore::HTMLMediaElement::setNetworkState): Don't cast to int for logging. (WebCore::HTMLMediaElement::setReadyState): Ditto. Log when autoplay is blocked. * html/HTMLMediaElementEnums.h: (PAL::LogArgument::toString): New. (PAL::LogArgument::toString): New. * platform/graphics/MediaPlayer.cpp: (WebCore::convertEnumerationToString): * platform/graphics/MediaPlayerEnums.h: (PAL::LogArgument::toString): (PAL::LogArgument::toString): * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Log strings. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElementEnums.h trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp trunk/Source/WebCore/platform/graphics/MediaPlayerEnums.h trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (224903 => 224904) --- trunk/Source/WebCore/ChangeLog 2017-11-15 23:05:41 UTC (rev 224903) +++ trunk/Source/WebCore/ChangeLog 2017-11-15 23:25:34 UTC (rev 224904) @@ -1,3 +1,30 @@ +2017-11-15 Eric Carlson + +Log media readyState and networkState as strings +https://bugs.webkit.org/show_bug.cgi?id=179732 + +Reviewed by Youenn Fablet. + +* html/HTMLMediaElement.cpp: +(WebCore::convertEnumerationToString): +(WebCore::HTMLMediaElement::scheduleDelayedAction): Fix logic error. +(WebCore::HTMLMediaElement::pendingActionTimerFired): Fix incorrect log string. +(WebCore::HTMLMediaElement::setNetworkState): Don't cast to int for logging. +(WebCore::HTMLMediaElement::setReadyState): Ditto. Log when autoplay is blocked. + +* html/HTMLMediaElementEnums.h: +(PAL::LogArgument::toString): New. +(PAL::LogArgument::toString): New. + +* platform/graphics/MediaPlayer.cpp: +(WebCore::convertEnumerationToString): +* platform/graphics/MediaPlayerEnums.h: +(PAL::LogArgument::toString): +(PAL::LogArgument::toString): + +* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: +(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Log strings. + 2017-11-15 Youenn Fablet Service Worker fetch should handle empty responses Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (224903 => 224904) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-11-15 23:05:41 UTC (rev 224903) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-11-15 23:25:34 UTC (rev 224904) @@ -254,6 +254,40 @@ using namespace HTMLNames; +String convertEnumerationToString(HTMLMediaElement::ReadyState enumerationValue) +{ +static const NeverDestroyed values[] = { +MAKE_STATIC_STRING_IMPL("HAVE_NOTHING"), +MAKE_STATIC_STRING_IMPL("HAVE_METADATA"), +MAKE_STATIC_STRING_IMPL("HAVE_CURRENT_DATA"), +MAKE_STATIC_STRING_IMPL("HAVE_FUTURE_DATA"), +MAKE_STATIC_STRING_IMPL("HAVE_ENOUGH_DATA"), +}; +static_assert(static_cast(HTMLMediaElementEnums::HAVE_NOTHING) == 0, "HTMLMediaElement::HAVE_NOTHING is not 0 as expected"); +static_assert(static_cast(HTMLMediaElementEnums::HAVE_METADATA) == 1, "HTMLMediaElement::HAVE_METADATA is not 1 as expected"); +static_assert(static_cast(HTMLMediaElementEnums::HAVE_CURRENT_DATA) == 2, "HTMLMediaElement::HAVE_CURRENT_DATA is not 2 as expected"); +static_assert(static_cast(HTMLMediaElementEnums::HAVE_FUTURE_DATA) == 3, "HTMLMediaElement::HAVE_FUTURE_DATA is not 3 as expected"); +static_assert(static_cast(HTMLMediaElementEnums::HAVE_ENOUGH_DATA) == 4, "HTMLMediaElement::HAVE_ENOUGH_DATA is not 4 as expected"); +ASSERT(static_cast(enumerationValue) < WTF_ARRAY_LENGTH(values)); +return values[static_cast(enumerationValue)]; +} + +String convertEnumerationToString(HTMLMediaElement::NetworkState enumerationValue) +{ +static const NeverDestroyed values[] = { +MAKE_STATIC_STRING_IMPL("NETWORK_EMPTY"), +MAKE_STATIC_STRING_IMPL("NETWORK_IDLE"), +MAKE_STATIC_STRING_IMPL("NETWORK_LOADING"), +MAKE_STATIC_STRING_IMPL("NETWORK_NO_SOURCE"), +}; +static_assert(static_cast(HTMLMediaElementEnums::NETWORK_EMPTY) == 0, "HTMLMediaElement::NETWORK_EMPTY is not 0 as expected"); +static_assert(static_cast(HTMLMediaElementEnums::NETWORK_IDLE) == 1, "HTMLMediaElement::NETWORK_IDLE is not 1 as expected");
[webkit-changes] [224903] trunk
Title: [224903] trunk Revision 224903 Author commit-qu...@webkit.org Date 2017-11-15 15:05:41 -0800 (Wed, 15 Nov 2017) Log Message Service Worker fetch should handle empty responses https://bugs.webkit.org/show_bug.cgi?id=179740 Patch by Youenn Fablet on 2017-11-15 Reviewed by Alex Christensen. Source/WebCore: Covered by updated test. * Modules/streams/ReadableStreamSink.cpp: (WebCore::ReadableStreamToSharedBufferSink::enqueue): Not create a buffer until actually needed. * workers/service/context/ServiceWorkerFetch.cpp: (WebCore::ServiceWorkerFetch::processResponse): Check for null buffers. LayoutTests: * http/tests/workers/service/resources/service-worker-fetch-worker.js: (event.event.request.url.endsWith): * http/tests/workers/service/resources/service-worker-fetch.js: (async.test): * http/tests/workers/service/service-worker-fetch.https-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch-worker.js trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch.js trunk/LayoutTests/http/tests/workers/service/service-worker-fetch.https-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/streams/ReadableStreamSink.cpp trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp Diff Modified: trunk/LayoutTests/ChangeLog (224902 => 224903) --- trunk/LayoutTests/ChangeLog 2017-11-15 22:56:59 UTC (rev 224902) +++ trunk/LayoutTests/ChangeLog 2017-11-15 23:05:41 UTC (rev 224903) @@ -1,5 +1,18 @@ 2017-11-15 Youenn Fablet +Service Worker fetch should handle empty responses +https://bugs.webkit.org/show_bug.cgi?id=179740 + +Reviewed by Alex Christensen. + +* http/tests/workers/service/resources/service-worker-fetch-worker.js: +(event.event.request.url.endsWith): +* http/tests/workers/service/resources/service-worker-fetch.js: +(async.test): +* http/tests/workers/service/service-worker-fetch.https-expected.txt: + +2017-11-15 Youenn Fablet + ReloadFromOrigin loads should not select any service worker https://bugs.webkit.org/show_bug.cgi?id=179736 Modified: trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch-worker.js (224902 => 224903) --- trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch-worker.js 2017-11-15 22:56:59 UTC (rev 224902) +++ trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch-worker.js 2017-11-15 23:05:41 UTC (rev 224903) @@ -4,11 +4,18 @@ event.respondWith(new Response(null, {status: 200, statusText: status})); return; } -if (!event.request.url.endsWith(".fromserviceworker")) { -state = "unknown url"; -event.respondWith(new Response(null, {status: 404, statusText: "Not Found"})); +if (event.request.url.endsWith(".fromserviceworker")) { +status = event.request.url.substring(0, event.request.url.length - 18) + " through " + "fetch"; +event.respondWith(fetch(event.request.url.substring(0, event.request.url.length - 18))); +} +if (event.request.url.endsWith(".bodyasanemptystream")) { +var stream = new ReadableStream({ start : controller => { +controller.close(); +}}); +event.respondWith(new Response(stream, {status : 200, statusText : "Empty stream"})); return; } -status = event.request.url.substring(0, event.request.url.length - 18) + " through " + "fetch"; -event.respondWith(fetch(event.request.url.substring(0, event.request.url.length - 18))); +state = "unknown url"; +event.respondWith(new Response(null, {status: 404, statusText: "Not Found"})); +return; }); Modified: trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch.js (224902 => 224903) --- trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch.js 2017-11-15 22:56:59 UTC (rev 224902) +++ trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch.js 2017-11-15 23:05:41 UTC (rev 224903) @@ -9,8 +9,12 @@ response = await fetch("/resources/square100.png.fromserviceworker"); var buffer = await response.arrayBuffer(); -log("Got response with buffer byte length being " + buffer.byteLength); +log("Got image response with buffer byte length being " + buffer.byteLength); +response = await fetch("/resources/square100.png.bodyasanemptystream"); +var buffer = await response.arrayBuffer(); +log("Got should-be-empty response with buffer byte length being " + buffer.byteLength + " and status is " + response.statusText); + response = await fetch("status"); log("Status is " + response.statusText); } catch(e) { Modified: trunk/LayoutTests/http/tests/workers/service/service-worker-fetch.https-expected.txt (224902 => 224903) --- trunk/LayoutTests/http/tests/workers/se
[webkit-changes] [224902] trunk
Title: [224902] trunk Revision 224902 Author commit-qu...@webkit.org Date 2017-11-15 14:56:59 -0800 (Wed, 15 Nov 2017) Log Message ReloadFromOrigin loads should not select any service worker https://bugs.webkit.org/show_bug.cgi?id=179736 Patch by Youenn Fablet on 2017-11-15 Reviewed by Brady Eidson. Source/WebCore: Test: http/tests/workers/service/shift-reload-navigation.html In case of ReloadFromOrigin (equivalent of shift reload), do not select any service worker. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::startLoadingMainResource): * loader/FrameLoader.h: (WebCore::FrameLoader::isReloadingFromOrigin const): LayoutTests: * http/tests/workers/service/resources/shift-reload-navigation.js: Added. (async.test): * http/tests/workers/service/shift-reload-navigation-expected.txt: Added. * http/tests/workers/service/shift-reload-navigation.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentLoader.cpp trunk/Source/WebCore/loader/FrameLoader.h Added Paths trunk/LayoutTests/http/tests/workers/service/resources/shift-reload-navigation.js trunk/LayoutTests/http/tests/workers/service/shift-reload-navigation-expected.txt trunk/LayoutTests/http/tests/workers/service/shift-reload-navigation.html Diff Modified: trunk/LayoutTests/ChangeLog (224901 => 224902) --- trunk/LayoutTests/ChangeLog 2017-11-15 22:30:26 UTC (rev 224901) +++ trunk/LayoutTests/ChangeLog 2017-11-15 22:56:59 UTC (rev 224902) @@ -1,3 +1,15 @@ +2017-11-15 Youenn Fablet + +ReloadFromOrigin loads should not select any service worker +https://bugs.webkit.org/show_bug.cgi?id=179736 + +Reviewed by Brady Eidson. + +* http/tests/workers/service/resources/shift-reload-navigation.js: Added. +(async.test): +* http/tests/workers/service/shift-reload-navigation-expected.txt: Added. +* http/tests/workers/service/shift-reload-navigation.html: Added. + 2017-11-15 Antoine Quint [Web Animations] Implement basic to-from animations Added: trunk/LayoutTests/http/tests/workers/service/resources/shift-reload-navigation.js (0 => 224902) --- trunk/LayoutTests/http/tests/workers/service/resources/shift-reload-navigation.js (rev 0) +++ trunk/LayoutTests/http/tests/workers/service/resources/shift-reload-navigation.js 2017-11-15 22:56:59 UTC (rev 224902) @@ -0,0 +1,37 @@ +async function test() +{ +try { +try { +var response = await fetch("http://localhost:8080/resources/square100.png.fromserviceworker"); +log("Failed: fetch suceeded unexpectedly"); +} catch(e) { +log("PASS: Fetch failed as expected with: " + e); +} + +var frame = await interceptedFrame("resources/service-worker-crossorigin-fetch-worker.js", "/"); + +var response = await frame.contentWindow.fetch("http://localhost:8080/resources/square100.png.fromserviceworker"); +var buffer = await response.arrayBuffer(); +log("PASS: Got response with buffer byte length being " + buffer.byteLength); + +if (!frame.contentWindow.internals) +return Promise.rejects("Test requires internals API"); + +await new Promise(resolve => { +frame._onload_ = resolve; +frame.contentWindow.internals.forceReload(true); +}); + +// On shift reload, frame should bypass its service worker. +try { +var response = await fetch("http://localhost:8080/resources/square100.png.fromserviceworker"); +log("Failed: fetch suceeded unexpectedly"); +} catch(e) { +log("PASS: Fetch failed as expected with: " + e); +} +} catch(e) { +log("FAIL: Got exception: " + e); +} +finishSWTest(); +} +test(); Added: trunk/LayoutTests/http/tests/workers/service/shift-reload-navigation-expected.txt (0 => 224902) --- trunk/LayoutTests/http/tests/workers/service/shift-reload-navigation-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/workers/service/shift-reload-navigation-expected.txt 2017-11-15 22:56:59 UTC (rev 224902) @@ -0,0 +1,8 @@ +CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +CONSOLE MESSAGE: Fetch API cannot load http://localhost:8080/resources/square100.png.fromserviceworker. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +CONSOLE MESSAGE: Fetch API cannot load http://localhost:8080/resources/square100.png.fromserviceworker. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +PASS: Fetch failed as expected with: TypeError: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +PASS: Got response with buffer byte length being 12940 +PASS: Fetch failed as expected with: TypeError: Ori
[webkit-changes] [224901] tags/Safari-605.1.14
Title: [224901] tags/Safari-605.1.14 Revision 224901 Author jmarc...@apple.com Date 2017-11-15 14:30:26 -0800 (Wed, 15 Nov 2017) Log Message Cherry-pick r224896. rdar://problem/35519421 Modified Paths tags/Safari-605.1.14/Source/WTF/ChangeLog tags/Safari-605.1.14/Source/WTF/wtf/MainThread.cpp tags/Safari-605.1.14/Source/WTF/wtf/MainThread.h tags/Safari-605.1.14/Source/WTF/wtf/generic/MainThreadGeneric.cpp tags/Safari-605.1.14/Source/WTF/wtf/mac/MainThreadMac.mm tags/Safari-605.1.14/Source/WTF/wtf/win/MainThreadWin.cpp tags/Safari-605.1.14/Tools/ChangeLog tags/Safari-605.1.14/Tools/TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm Diff Modified: tags/Safari-605.1.14/Source/WTF/ChangeLog (224900 => 224901) --- tags/Safari-605.1.14/Source/WTF/ChangeLog 2017-11-15 22:07:10 UTC (rev 224900) +++ tags/Safari-605.1.14/Source/WTF/ChangeLog 2017-11-15 22:30:26 UTC (rev 224901) @@ -1,3 +1,33 @@ +2017-11-15 Jason Marcell + +Cherry-pick r224896. rdar://problem/35519421 + +2017-11-15 Alex Christensen + +WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time +https://bugs.webkit.org/show_bug.cgi?id=179742 + + +Reviewed by Jer Noble. + +In r224687 I fixed loading from scheduled WebViews with custom run loop modes, but in +dispatchFunctionsFromMainThread we have an optimization to yield the run loop if we have already +done more than 50ms of work on the main thread in this run loop iteration. When this happens +and we are running in a custom run loop mode, we disable this responsiveness optimization. +We are calling CFRunLoopRunInMode or [NSRunLoop acceptInputForMode:beforeDate:] in a while loop anyways, +so we would not benefit from a responsiveness optimization. We definitely don't want to reschedule +on the main thread in the common run loop mode in this case. + +* wtf/MainThread.cpp: +(WTF::dispatchFunctionsFromMainThread): +* wtf/MainThread.h: +* wtf/generic/MainThreadGeneric.cpp: +(WTF::currentRunLoopInCommonMode): +* wtf/mac/MainThreadMac.mm: +(WTF::currentRunLoopInCommonMode): +* wtf/win/MainThreadWin.cpp: +(WTF::currentRunLoopInCommonMode): + 2017-11-15 Ryan Haddad Unreviewed, rolling out r224863. Modified: tags/Safari-605.1.14/Source/WTF/wtf/MainThread.cpp (224900 => 224901) --- tags/Safari-605.1.14/Source/WTF/wtf/MainThread.cpp 2017-11-15 22:07:10 UTC (rev 224900) +++ tags/Safari-605.1.14/Source/WTF/wtf/MainThread.cpp 2017-11-15 22:30:26 UTC (rev 224901) @@ -135,7 +135,7 @@ // yield so the user input can be processed. Otherwise user may not be able to even close the window. // This code has effect only in case the scheduleDispatchFunctionsOnMainThread() is implemented in a way that // allows input events to be processed before we are back here. -if (MonotonicTime::now() - startTime > maxRunLoopSuspensionTime) { +if (MonotonicTime::now() - startTime > maxRunLoopSuspensionTime && currentRunLoopInCommonMode()) { scheduleDispatchFunctionsOnMainThread(); break; } Modified: tags/Safari-605.1.14/Source/WTF/wtf/MainThread.h (224900 => 224901) --- tags/Safari-605.1.14/Source/WTF/wtf/MainThread.h 2017-11-15 22:07:10 UTC (rev 224900) +++ tags/Safari-605.1.14/Source/WTF/wtf/MainThread.h 2017-11-15 22:30:26 UTC (rev 224901) @@ -87,6 +87,7 @@ void initializeMainThreadPlatform(); void scheduleDispatchFunctionsOnMainThread(SchedulePairHashSet* = nullptr); void dispatchFunctionsFromMainThread(); +bool currentRunLoopInCommonMode(); #if OS(DARWIN) && !USE(GLIB) #if !USE(WEB_THREAD) Modified: tags/Safari-605.1.14/Source/WTF/wtf/generic/MainThreadGeneric.cpp (224900 => 224901) --- tags/Safari-605.1.14/Source/WTF/wtf/generic/MainThreadGeneric.cpp 2017-11-15 22:07:10 UTC (rev 224900) +++ tags/Safari-605.1.14/Source/WTF/wtf/generic/MainThreadGeneric.cpp 2017-11-15 22:30:26 UTC (rev 224901) @@ -67,6 +67,11 @@ { } +bool currentRunLoopInCommonMode() +{ +return true; +} + void scheduleDispatchFunctionsOnMainThread(SchedulePairHashSet*) { // Use a RunLoop::Timer instead of RunLoop::dispatch() to be able to use a different priority and Modified: tags/Safari-605.1.14/Source/WTF/wtf/mac/MainThreadMac.mm (224900 => 224901) --- tags/Safari-605.1.14/Source/WTF/wtf/mac/MainThreadMac.mm 2017-11-15 22:07:10 UTC (rev 224900) +++ tags/Safari-605.1.14/Source/WTF/wtf/mac/MainThreadMac.mm 2017-11-15 22:30:26 UTC (rev 224901) @@ -122,6 +122,11 @@ CFRunLoopAddTimer(CFRunLoopGetCurrent(), CFRunLoopTimerCreate(0, 0, 0, 0, 0, timerFired, 0), kCFRunLoopCommonModes); } +bool currentRunLoopInCommonMode() +{ +return [[NSRunLoop currentRunLoop] currentMode] == (NSString *)kCFRunLoopCommonModes; +} + void sched
[webkit-changes] [224900] trunk/Source/WebKit
Title: [224900] trunk/Source/WebKit Revision 224900 Author achristen...@apple.com Date 2017-11-15 14:07:10 -0800 (Wed, 15 Nov 2017) Log Message Revert r224885 https://bugs.webkit.org/show_bug.cgi?id=179719 * UIProcess/API/APIContentRuleListStore.cpp: (API::compiledToFile): r224885 was a speculative fix that did not fix anything on the bots. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (224899 => 224900) --- trunk/Source/WebKit/ChangeLog 2017-11-15 21:50:04 UTC (rev 224899) +++ trunk/Source/WebKit/ChangeLog 2017-11-15 22:07:10 UTC (rev 224900) @@ -1,3 +1,12 @@ +2017-11-15 Alex Christensen + +Revert r224885 +https://bugs.webkit.org/show_bug.cgi?id=179719 + +* UIProcess/API/APIContentRuleListStore.cpp: +(API::compiledToFile): +r224885 was a speculative fix that did not fix anything on the bots. + 2017-11-15 Brent Fulgham Unreviewed build fix after r224830. Modified: trunk/Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp (224899 => 224900) --- trunk/Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp 2017-11-15 21:50:04 UTC (rev 224899) +++ trunk/Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp 2017-11-15 22:07:10 UTC (rev 224900) @@ -350,18 +350,17 @@ return ContentRuleListStore::Error::CompileFailed; } -if (!moveFile(temporaryFilePath, finalFilePath)) { -WTFLogAlways("Content Rule List compiling failed: Moving file failed."); -return ContentRuleListStore::Error::CompileFailed; -} - mappedData = adoptAndMapFile(temporaryFileHandle, 0, metaData.fileSize()); if (mappedData.isNull()) { WTFLogAlways("Content Rule List compiling failed: Mapping file failed."); -deleteFile(finalFilePath); return ContentRuleListStore::Error::CompileFailed; } +if (!moveFile(temporaryFilePath, finalFilePath)) { +WTFLogAlways("Content Rule List compiling failed: Moving file failed."); +return ContentRuleListStore::Error::CompileFailed; +} + return { }; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224899] trunk/Source/WebCore
Title: [224899] trunk/Source/WebCore Revision 224899 Author za...@apple.com Date 2017-11-15 13:50:04 -0800 (Wed, 15 Nov 2017) Log Message AX triggers sync layout while building the render tree on www.macrumors.com. https://bugs.webkit.org/show_bug.cgi?id=179741 rdar://problem/35462531 Reviewed by Antti Koivisto. It's unsafe to issue layout while mutating the render tree. If a mutation requires AX to issue a layout, it needs to be issued in a delayed manner (which the render tree mutation will trigger anyway). Unable to reproduce. * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::updateBackingStore): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityObject.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (224898 => 224899) --- trunk/Source/WebCore/ChangeLog 2017-11-15 21:36:19 UTC (rev 224898) +++ trunk/Source/WebCore/ChangeLog 2017-11-15 21:50:04 UTC (rev 224899) @@ -1,3 +1,20 @@ +2017-11-15 Zalan Bujtas + +AX triggers sync layout while building the render tree on www.macrumors.com. +https://bugs.webkit.org/show_bug.cgi?id=179741 +rdar://problem/35462531 + +Reviewed by Antti Koivisto. + +It's unsafe to issue layout while mutating the render tree. If a mutation +requires AX to issue a layout, it needs to be issued in a delayed manner (which the render +tree mutation will trigger anyway). + +Unable to reproduce. + +* accessibility/AccessibilityObject.cpp: +(WebCore::AccessibilityObject::updateBackingStore): + 2017-11-15 Antoine Quint [Web Animations] Implement basic to-from animations Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (224898 => 224899) --- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2017-11-15 21:36:19 UTC (rev 224898) +++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2017-11-15 21:50:04 UTC (rev 224899) @@ -1771,7 +1771,7 @@ RefPtr protectedThis(this); if (Document* document = this->document()) { -if (!document->view()->layoutContext().isInRenderTreeLayout()) +if (!document->view()->layoutContext().isInRenderTreeLayout() && !document->inRenderTreeUpdate()) document->updateLayoutIgnorePendingStylesheets(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224898] releases/Apple
Title: [224898] releases/Apple Revision 224898 Author m...@apple.com Date 2017-11-15 13:36:19 -0800 (Wed, 15 Nov 2017) Log Message Added a tag for Safari Technology Preview release 44. Added Paths releases/Apple/Safari Technology Preview 44/ releases/Apple/Safari Technology Preview 44/ANGLE/ releases/Apple/Safari Technology Preview 44/_javascript_Core/ releases/Apple/Safari Technology Preview 44/WTF/ releases/Apple/Safari Technology Preview 44/WebCore/ releases/Apple/Safari Technology Preview 44/WebInspectorUI/ releases/Apple/Safari Technology Preview 44/WebKit/ releases/Apple/Safari Technology Preview 44/WebKitLegacy/ releases/Apple/Safari Technology Preview 44/bmalloc/ releases/Apple/Safari Technology Preview 44/libwebrtc/ Diff Index: releases/Apple/Safari Technology Preview 44/ANGLE === --- tags/Safari-605.1.13.2/Source/ThirdParty/ANGLE 2017-11-15 21:35:38 UTC (rev 224897) +++ releases/Apple/Safari Technology Preview 44/ANGLE 2017-11-15 21:36:19 UTC (rev 224898) Property changes: releases/Apple/Safari Technology Preview 44/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 44/_javascript_Core === --- tags/Safari-605.1.13.2/Source/_javascript_Core 2017-11-15 21:35:38 UTC (rev 224897) +++ releases/Apple/Safari Technology Preview 44/_javascript_Core 2017-11-15 21:36:19 UTC (rev 224898) Property changes: releases/Apple/Safari Technology Preview 44/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 44/WTF === --- tags/Safari-605.1.13.2/Source/WTF 2017-11-15 21:35:38 UTC (rev 224897) +++ releases/Apple/Safari Technology Preview 44/WTF 2017-11-15 21:36:19 UTC (rev 224898) Property changes: releases/Apple/Safari Technology Preview 44/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 44/WebInspectorUI === --- tags/Safari-605.1.13.2/Source/WebInspectorUI 2017-11-15 21:35:38 UTC (rev 224897) +++ releases/Apple/Safari Technology Preview 44/WebInspectorUI 2017-11-15 21:36:19 UTC (rev 224898) Property changes: releases/Apple/Safari Technology Preview 44/WebInspectorUI Added: svn:mergeinfo +/trunk/Source/WebInspectorUI:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 44/bmalloc === --- tags/Safari-605.1.13.2/Source/bmalloc 2017-11-15 21:35:38 UTC (rev 224897) +++ releases/Apple/Safari Technology Preview 44/bmalloc 2017-11-15 21:36:19 UTC (rev 224898) Property changes: releases/Apple/Safari Technology Preview 44/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 44/libwebrtc === --- tags/Safari-605.1.13.2/Source/ThirdParty/libwebrtc 2017-11-15 21:35:38 UTC (rev 224897) +++ releases/Apple/Safari Technology Preview 44/libwebrtc 2017-11-15 21:36:19 UTC (rev 224898) Property changes: releases/Apple/Safari Technology Preview 44/libwebrtc Added: svn:mergeinfo +/trunk/Source/ThirdParty/libwebrtc:53455 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224897] trunk
Title: [224897] trunk Revision 224897 Author grao...@webkit.org Date 2017-11-15 13:35:38 -0800 (Wed, 15 Nov 2017) Log Message [Web Animations] Implement basic to-from animations https://bugs.webkit.org/show_bug.cgi?id=179707 Source/WebCore: We can now actually perform an animation, in software only, when provided two keyframes on an AnimationEffect. To parse a keyframes object from JS, we use the StyleResolver to create RenderStyle objects based on the strings provided for the property names and values. Then, when the DocumentTimeline indicates that animations are ready to be updated, we invalidate the style of elements with animations, so that during style resolution we can perform blending between the RenderStyles for each keyframe. Reviewed by Dean Jackson. * animation/AnimationEffect.h: (WebCore::AnimationEffect::~AnimationEffect): Deleted. * animation/AnimationTimeline.h: (WebCore::AnimationTimeline::elementToAnimationsMap const): * animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::animationResolutionTimerFired): (WebCore::DocumentTimeline::updateAnimations): Renamed from resolveAnimations() since we're not actually resolving animations, merely invalidating styles in preparation for resolution. (WebCore::DocumentTimeline::resolveAnimations): Deleted. * animation/DocumentTimeline.h: * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::create): Pass the keyframes argument to setKeyframes() and forward the exception in case one was raised in the setter. (WebCore::KeyframeEffect::setKeyframes): Pass the keyframes argument to processKeyframes() and forward the exception in case one was raised during processing. (WebCore::KeyframeEffect::processKeyframes): Deal with exactly two keyframes, set at 0 and 1 offsets, specified in array forms for the keyframes object. As we parse the content of the provided JS object, we create RenderStyle objects using the element's StyleResolver from a CSS text string we create based on the property and values as strings. (WebCore::KeyframeEffect::applyAtLocalTime): Compute the progress based on the local time and duration, using the existing CSSPropertyAnimation::blendProperties() mechanics to perform the blend between the from and to keyframes. * animation/KeyframeEffect.h: * animation/KeyframeEffect.idl: * animation/WebAnimation.cpp: (WebCore::WebAnimation::resolve): * animation/WebAnimation.h: * bindings/IDLTypes.h: (WebCore::IDLObject::nullValue): Make JSC::Strong an optional type. * dom/Document.h: (WebCore::Document::existingTimeline const): Provide an explicit method for call sites to check existence of a timeline before forcing one to be created if missing by calling timeline(). * dom/Element.cpp: (WebCore::Element::getAnimations): Do not force the creation of a timeline if one isn't already created. * style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate): When applying styles, account for any Web Animation applied to the provided element. LayoutTests: Reviewed by Dean Jackson. Update existing tests to explicitly pass null for keyframes and update WPT expectations. * http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline-expected.txt: * http/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt: * http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt: * http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt: * http/wpt/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt: * http/wpt/wk-web-animations/interfaces/element-get-animations.html: * http/wpt/wk-web-animations/timing-model/animation-creation-basic.html: * http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html: * http/wpt/wk-web-animations/timing-model/animation-interface-effect-property.html: * http/wpt/wk-web-animations/timing-model/keyframe-effect-expected.txt: * http/wpt/wk-web-animations/timing-model/keyframe-effect-interface-timing-duration.html: * http/wpt/wk-web-animations/timing-model/keyframe-effect.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline-expected.txt trunk/LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt trunk/LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt trunk/LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt trunk/LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt trunk/LayoutTests/http/wpt/wk-web-animations/interfaces/element-get-animations.html trunk/LayoutTests/http/wpt/wk-web-animations/timing-model/animation-creation-basic.html trunk/LayoutTests/http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html trunk/LayoutTests/http/wpt/wk-web-animations/ti
[webkit-changes] [224896] trunk
Title: [224896] trunk Revision 224896 Author achristen...@apple.com Date 2017-11-15 13:28:15 -0800 (Wed, 15 Nov 2017) Log Message WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time https://bugs.webkit.org/show_bug.cgi?id=179742 Reviewed by Jer Noble. Source/WTF: In r224687 I fixed loading from scheduled WebViews with custom run loop modes, but in dispatchFunctionsFromMainThread we have an optimization to yield the run loop if we have already done more than 50ms of work on the main thread in this run loop iteration. When this happens and we are running in a custom run loop mode, we disable this responsiveness optimization. We are calling CFRunLoopRunInMode or [NSRunLoop acceptInputForMode:beforeDate:] in a while loop anyways, so we would not benefit from a responsiveness optimization. We definitely don't want to reschedule on the main thread in the common run loop mode in this case. * wtf/MainThread.cpp: (WTF::dispatchFunctionsFromMainThread): * wtf/MainThread.h: * wtf/generic/MainThreadGeneric.cpp: (WTF::currentRunLoopInCommonMode): * wtf/mac/MainThreadMac.mm: (WTF::currentRunLoopInCommonMode): * wtf/win/MainThreadWin.cpp: (WTF::currentRunLoopInCommonMode): Tools: * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm: (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): Load more than one scheduled WebView to test work that typically takes more than 50 ms. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/MainThread.cpp trunk/Source/WTF/wtf/MainThread.h trunk/Source/WTF/wtf/generic/MainThreadGeneric.cpp trunk/Source/WTF/wtf/mac/MainThreadMac.mm trunk/Source/WTF/wtf/win/MainThreadWin.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm Diff Modified: trunk/Source/WTF/ChangeLog (224895 => 224896) --- trunk/Source/WTF/ChangeLog 2017-11-15 21:18:08 UTC (rev 224895) +++ trunk/Source/WTF/ChangeLog 2017-11-15 21:28:15 UTC (rev 224896) @@ -1,3 +1,29 @@ +2017-11-15 Alex Christensen + +WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time +https://bugs.webkit.org/show_bug.cgi?id=179742 + + +Reviewed by Jer Noble. + +In r224687 I fixed loading from scheduled WebViews with custom run loop modes, but in +dispatchFunctionsFromMainThread we have an optimization to yield the run loop if we have already +done more than 50ms of work on the main thread in this run loop iteration. When this happens +and we are running in a custom run loop mode, we disable this responsiveness optimization. +We are calling CFRunLoopRunInMode or [NSRunLoop acceptInputForMode:beforeDate:] in a while loop anyways, +so we would not benefit from a responsiveness optimization. We definitely don't want to reschedule +on the main thread in the common run loop mode in this case. + +* wtf/MainThread.cpp: +(WTF::dispatchFunctionsFromMainThread): +* wtf/MainThread.h: +* wtf/generic/MainThreadGeneric.cpp: +(WTF::currentRunLoopInCommonMode): +* wtf/mac/MainThreadMac.mm: +(WTF::currentRunLoopInCommonMode): +* wtf/win/MainThreadWin.cpp: +(WTF::currentRunLoopInCommonMode): + 2017-11-15 Ryan Haddad Unreviewed, rolling out r224863. Modified: trunk/Source/WTF/wtf/MainThread.cpp (224895 => 224896) --- trunk/Source/WTF/wtf/MainThread.cpp 2017-11-15 21:18:08 UTC (rev 224895) +++ trunk/Source/WTF/wtf/MainThread.cpp 2017-11-15 21:28:15 UTC (rev 224896) @@ -135,7 +135,7 @@ // yield so the user input can be processed. Otherwise user may not be able to even close the window. // This code has effect only in case the scheduleDispatchFunctionsOnMainThread() is implemented in a way that // allows input events to be processed before we are back here. -if (MonotonicTime::now() - startTime > maxRunLoopSuspensionTime) { +if (MonotonicTime::now() - startTime > maxRunLoopSuspensionTime && currentRunLoopInCommonMode()) { scheduleDispatchFunctionsOnMainThread(); break; } Modified: trunk/Source/WTF/wtf/MainThread.h (224895 => 224896) --- trunk/Source/WTF/wtf/MainThread.h 2017-11-15 21:18:08 UTC (rev 224895) +++ trunk/Source/WTF/wtf/MainThread.h 2017-11-15 21:28:15 UTC (rev 224896) @@ -87,6 +87,7 @@ void initializeMainThreadPlatform(); void scheduleDispatchFunctionsOnMainThread(SchedulePairHashSet* = nullptr); void dispatchFunctionsFromMainThread(); +bool currentRunLoopInCommonMode(); #if OS(DARWIN) && !USE(GLIB) #if !USE(WEB_THREAD) Modified: trunk/Source/WTF/wtf/generic/MainThreadGeneric.cpp (224895 => 224896) --- trunk/Source/WTF/wtf/generic/MainThreadGeneric.cpp 2017-11-15 21:18:08 UTC (rev 224895) +++ trunk/Source/WTF/wtf/generic/MainThreadGeneric.cpp 2017-11-15 21:28:15 UTC (rev 224896) @@ -67,6
[webkit-changes] [224895] tags/Safari-605.1.14/
Title: [224895] tags/Safari-605.1.14/ Revision 224895 Author jmarc...@apple.com Date 2017-11-15 13:18:08 -0800 (Wed, 15 Nov 2017) Log Message Tag Safari-605.1.14. Added Paths tags/Safari-605.1.14/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224894] trunk
Title: [224894] trunk Revision 224894 Author fred.w...@free.fr Date 2017-11-15 12:07:51 -0800 (Wed, 15 Nov 2017) Log Message ASSERTION FAILED: !renderer->needsLayout() in WebCore::RenderBlock::checkPositionedObjectsNeedLayout with MathML https://bugs.webkit.org/show_bug.cgi?id=178865 Patch by Frederic Wang on 2017-11-15 Reviewed by Manuel Rego Casasnovas. Source/WebCore: MathML token elements can contain HTML elements and hence MathML elements can contain out-of-flow positioned descendants. Also all MathML elements can be containing block and hence should position their out-of-flow positioned descendants before calling clearNeedsLayout(). This patch does that in all places in the MathML renderer classes, except a few of them: - RenderMathMLSpace, which can not have descendants. - RenderMathMLToken and RenderMathMLOperator, since they will use the layout implementation of RenderMathMLBlock when they contain non-text children. The patch also fixes an ASSERTION failure in WebCore::RenderBlock::checkPositionedObjectsNeedLayout due to some descendants that are not laid out. Test: mathml/out-of-flow-in-token-crash.html * rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::layoutBlock): Call layoutPositionedObjects. (WebCore::RenderMathMLBlock::layoutInvalidMarkup): Ditto and pass the relayoutChildren boolean. * rendering/mathml/RenderMathMLBlock.h: Add a relayoutChildren boolean to layoutInvalidMarkup. * rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::layoutBlock): Pass the relayoutChildren boolean to layoutInvalidMarkup and call layoutPositionedObjects. * rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::layoutBlock): Ditto. * rendering/mathml/RenderMathMLScripts.cpp: (WebCore::RenderMathMLScripts::layoutBlock): Ditto. * rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layoutBlock): Ditto. * rendering/mathml/RenderMathMLMenclose.cpp: (WebCore::RenderMathMLMenclose::layoutBlock): Call layoutPositionedObjects. * rendering/mathml/RenderMathMLPadded.cpp: (WebCore::RenderMathMLPadded::layoutBlock): Ditto. * rendering/mathml/RenderMathMLRow.cpp: (WebCore::RenderMathMLRow::layoutBlock): Ditto. LayoutTests: Add a test to trigger various clearNeedsLayout() in a MathML containing block with out-of-flow positioned descendants. * mathml/out-of-flow-in-token-crash-expected.txt: Added. * mathml/out-of-flow-in-token-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp trunk/Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp trunk/Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.cpp trunk/Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp Added Paths trunk/LayoutTests/mathml/out-of-flow-in-token-crash-expected.txt trunk/LayoutTests/mathml/out-of-flow-in-token-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (224893 => 224894) --- trunk/LayoutTests/ChangeLog 2017-11-15 20:02:04 UTC (rev 224893) +++ trunk/LayoutTests/ChangeLog 2017-11-15 20:07:51 UTC (rev 224894) @@ -1,3 +1,16 @@ +2017-11-15 Frederic Wang + +ASSERTION FAILED: !renderer->needsLayout() in WebCore::RenderBlock::checkPositionedObjectsNeedLayout with MathML +https://bugs.webkit.org/show_bug.cgi?id=178865 + +Reviewed by Manuel Rego Casasnovas. + +Add a test to trigger various clearNeedsLayout() in a MathML containing block with +out-of-flow positioned descendants. + +* mathml/out-of-flow-in-token-crash-expected.txt: Added. +* mathml/out-of-flow-in-token-crash.html: Added. + 2017-11-15 Nan Wang [GTK] accessibility/accessibility-object-model.html fails Added: trunk/LayoutTests/mathml/out-of-flow-in-token-crash-expected.txt (0 => 224894) --- trunk/LayoutTests/mathml/out-of-flow-in-token-crash-expected.txt (rev 0) +++ trunk/LayoutTests/mathml/out-of-flow-in-token-crash-expected.txt 2017-11-15 20:07:51 UTC (rev 224894) @@ -0,0 +1,25 @@ +This test passes if it does not crash + +RenderMathMLFenced + +RenderMathMLFraction + +RenderMathMLMath + +RenderMathMLMenclose + +RenderMathMLOperator + +RenderMathMLPadded + +RenderMathMLRoot + +RenderMathMLRow +RenderMathMLScripts + +RenderMathMLToken + +RenderMathMLUnderOver + +RenderMathMLBlock (invalid markup) + Property changes on: trunk/LayoutTests/mathml/out-of-flow-in-token-crash-expected.txt ___ Added: svn:eol-style +LF \ No newline at end of property Added: trunk/LayoutTests/mathml/out-of-flow-in-token-crash.html (0 => 224894) --- t
[webkit-changes] [224893] trunk/LayoutTests
Title: [224893] trunk/LayoutTests Revision 224893 Author n_w...@apple.com Date 2017-11-15 12:02:04 -0800 (Wed, 15 Nov 2017) Log Message [GTK] accessibility/accessibility-object-model.html fails https://bugs.webkit.org/show_bug.cgi?id=179723 Reviewed by Chris Fleizach. Updated the test to support different platforms. * accessibility/accessibility-object-model-expected.txt: * accessibility/accessibility-object-model.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/accessibility-object-model-expected.txt trunk/LayoutTests/accessibility/accessibility-object-model.html Diff Modified: trunk/LayoutTests/ChangeLog (224892 => 224893) --- trunk/LayoutTests/ChangeLog 2017-11-15 19:50:41 UTC (rev 224892) +++ trunk/LayoutTests/ChangeLog 2017-11-15 20:02:04 UTC (rev 224893) @@ -1,3 +1,15 @@ +2017-11-15 Nan Wang + +[GTK] accessibility/accessibility-object-model.html fails +https://bugs.webkit.org/show_bug.cgi?id=179723 + +Reviewed by Chris Fleizach. + +Updated the test to support different platforms. + +* accessibility/accessibility-object-model-expected.txt: +* accessibility/accessibility-object-model.html: + 2017-11-15 Chris Dumez Unreviewed, fix tests introduced in r224880. Modified: trunk/LayoutTests/accessibility/accessibility-object-model-expected.txt (224892 => 224893) --- trunk/LayoutTests/accessibility/accessibility-object-model-expected.txt 2017-11-15 19:50:41 UTC (rev 224892) +++ trunk/LayoutTests/accessibility/accessibility-object-model-expected.txt 2017-11-15 20:02:04 UTC (rev 224893) @@ -13,7 +13,7 @@ ARIA attributes should not be reflected into AOM properties. PASS axButton.role is 'AXRole: AXCheckBox' -PASS axButton.description is 'AXDescription: label' +PASS platformValueForW3CName(axButton) is "label" PASS button.accessibleNode.role is null PASS button.accessibleNode.label is null @@ -21,7 +21,7 @@ PASS button.accessibleNode.role is 'slider' PASS button.accessibleNode.label is 'AOM Label' PASS axButton.role is 'AXRole: AXSlider' -PASS axButton.description is 'AXDescription: AOM Label' +PASS platformValueForW3CName(axButton) is "AOM Label" Setting some of the AOM properties should be able to make an element accessible. PASS axParagraph == null || axParagraph == undefined is true Modified: trunk/LayoutTests/accessibility/accessibility-object-model.html (224892 => 224893) --- trunk/LayoutTests/accessibility/accessibility-object-model.html 2017-11-15 19:50:41 UTC (rev 224892) +++ trunk/LayoutTests/accessibility/accessibility-object-model.html 2017-11-15 20:02:04 UTC (rev 224893) @@ -45,7 +45,7 @@ button.setAttribute("role", "checkbox"); button.setAttribute("aria-label", "label"); shouldBe("axButton.role", "'AXRole: AXCheckBox'"); -shouldBe("axButton.description", "'AXDescription: label'"); +shouldBeEqualToString("platformValueForW3CName(axButton)", "label"); // AOM properties should be null even if we have set ARIA attributes. shouldBeNull("button.accessibleNode.role"); @@ -67,7 +67,7 @@ // The AOM property values should override ARIA attributes. shouldBe("axButton.role", "'AXRole: AXSlider'"); -shouldBe("axButton.description", "'AXDescription: AOM Label'"); +shouldBeEqualToString("platformValueForW3CName(axButton)", "AOM Label"); } function testBecomeAccessible() { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224892] trunk/LayoutTests
Title: [224892] trunk/LayoutTests Revision 224892 Author cdu...@apple.com Date 2017-11-15 11:50:41 -0800 (Wed, 15 Nov 2017) Log Message Unreviewed, fix tests introduced in r224880. This is needed because of the changes in r224876. * http/tests/workers/service/Client-properties.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/workers/service/Client-properties.html Diff Modified: trunk/LayoutTests/ChangeLog (224891 => 224892) --- trunk/LayoutTests/ChangeLog 2017-11-15 19:40:47 UTC (rev 224891) +++ trunk/LayoutTests/ChangeLog 2017-11-15 19:50:41 UTC (rev 224892) @@ -1,3 +1,11 @@ +2017-11-15 Chris Dumez + +Unreviewed, fix tests introduced in r224880. + +This is needed because of the changes in r224876. + +* http/tests/workers/service/Client-properties.html: + 2017-11-15 Youenn Fablet Some service worker tests are flaky due to console log messages Modified: trunk/LayoutTests/http/tests/workers/service/Client-properties.html (224891 => 224892) --- trunk/LayoutTests/http/tests/workers/service/Client-properties.html 2017-11-15 19:40:47 UTC (rev 224891) +++ trunk/LayoutTests/http/tests/workers/service/Client-properties.html 2017-11-15 19:50:41 UTC (rev 224892) @@ -18,8 +18,8 @@ logWindow.log(event.data); }); -navigator.serviceWorker.register("resources/Client-properties-worker.js", { }).then(function() { -navigator.serviceWorker.controller.postMessage("TEST"); +navigator.serviceWorker.register("resources/Client-properties-worker.js", { }).then(function(registration) { +registration.installing.postMessage("TEST"); }); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224891] trunk/LayoutTests
Title: [224891] trunk/LayoutTests Revision 224891 Author commit-qu...@webkit.org Date 2017-11-15 11:40:47 -0800 (Wed, 15 Nov 2017) Log Message Some service worker tests are flaky due to console log messages https://bugs.webkit.org/show_bug.cgi?id=179601 Patch by Youenn Fablet on 2017-11-15 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt: * web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt: * web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt: LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (224890 => 224891) --- trunk/LayoutTests/ChangeLog 2017-11-15 19:36:17 UTC (rev 224890) +++ trunk/LayoutTests/ChangeLog 2017-11-15 19:40:47 UTC (rev 224891) @@ -1,3 +1,12 @@ +2017-11-15 Youenn Fablet + +Some service worker tests are flaky due to console log messages +https://bugs.webkit.org/show_bug.cgi?id=179601 + +Reviewed by Alex Christensen. + +* TestExpectations: + 2017-11-15 Matt Lewis Adjusted expectations for compositing/repaint/fixed-background-scroll.html. Modified: trunk/LayoutTests/TestExpectations (224890 => 224891) --- trunk/LayoutTests/TestExpectations 2017-11-15 19:36:17 UTC (rev 224890) +++ trunk/LayoutTests/TestExpectations 2017-11-15 19:40:47 UTC (rev 224891) @@ -182,10 +182,7 @@ http/tests/workers/service/basic-install-event-waitUntil-reject.html [ Pass Timeout ] http/tests/workers/service/basic-install-event-waitUntil-resolve.html [ Pass Timeout ] http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ] -imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ Pass Failure ] webkit.org/b/179137 imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html [ Pass Failure ] -webkit.org/b/179193 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ Pass Failure ] -webkit.org/b/179193 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ Pass Failure ] webkit.org/b/179248 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html [ Pass Failure ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https.html [ Pass Failure ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-header-visibility.https.html [ Pass Failure ] @@ -210,7 +207,11 @@ imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html [ Pass Failure ] imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https.html [ Pass Failure ] imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.serviceworker.https.html [ Pass Failure ] +imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ DumpJSConsoleLogInStdErr Pass Failure ] +imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ DumpJSConsoleLogInStdErr Pass Failure ] +imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ DumpJSConsoleLogInStdErr ] + # textarea.animate is not supported imported/w3c/web-platform-tests/css/css-ui-3/caret-color-018.html [ Skip ] imported/w3c/web-platform-tests/css/css-ui-3/caret-color-019.html [ Skip ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (224890 => 224891) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-11-15 19:36:17 UTC (rev 224890) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-11-15 19:40:47 UTC (rev 224891) @@ -1,5 +1,16 @@ 2017-11-15 Youenn Fablet +Some service worker tests are flaky due to console log messages +https://bugs.webkit.org/show_bug.cgi?id=179601 + +Reviewed by Alex Christensen. + +* web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt: +* web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt: +* web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt: + +2017-11-15 Youenn Fablet + Remove service worker selection based on registration https://bugs.web
[webkit-changes] [224890] trunk/Source/WebKit
Title: [224890] trunk/Source/WebKit Revision 224890 Author bfulg...@apple.com Date 2017-11-15 11:36:17 -0800 (Wed, 15 Nov 2017) Log Message Unreviewed build fix after r224830. * WebProcess/com.apple.WebProcess.sb.in: Add missing sysctl-read permissions needed to support testing on Mac Mini hardware. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (224889 => 224890) --- trunk/Source/WebKit/ChangeLog 2017-11-15 19:28:03 UTC (rev 224889) +++ trunk/Source/WebKit/ChangeLog 2017-11-15 19:36:17 UTC (rev 224890) @@ -1,3 +1,10 @@ +2017-11-15 Brent Fulgham + +Unreviewed build fix after r224830. + +* WebProcess/com.apple.WebProcess.sb.in: Add missing sysctl-read permissions needed +to support testing on Mac Mini hardware. + 2017-11-15 Youenn Fablet Add ServiceWorker to WebProcess plumbery for FormData fetch responses Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (224889 => 224890) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2017-11-15 19:28:03 UTC (rev 224889) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2017-11-15 19:36:17 UTC (rev 224890) @@ -177,7 +177,11 @@ (deny sysctl*) (allow sysctl-read (sysctl-name +"hw.byteorder" +"hw.busfrequency_compat" "hw.busfrequency_max" +"hw.cachelinesize_compat" +"hw.cpufrequency_compat" "hw.cputype" "hw.l2cachesize" "hw.machine" @@ -184,6 +188,8 @@ "hw.memsize" "hw.model" "hw.ncpu" +"hw.pagesize_compat" +"hw.tbfrequency_compat" "hw.vectorunit" "kern.hostname" "kern.maxfilesperproc" @@ -190,6 +196,7 @@ "kern.memorystatus_level" "kern.safeboot" "kern.version" +"security.mac.sandbox.sentinel" "vm.footprint_suspend") (sysctl-name-regex #"^hw.(active|avail)cpu") (sysctl-name-regex #"^hw.(logical|physical)cpu_max") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224889] trunk/Source
Title: [224889] trunk/Source Revision 224889 Author commit-qu...@webkit.org Date 2017-11-15 11:28:03 -0800 (Wed, 15 Nov 2017) Log Message Add ServiceWorker to WebProcess plumbery for FormData fetch responses https://bugs.webkit.org/show_bug.cgi?id=179694 Patch by Youenn Fablet on 2017-11-15 Reviewed by Alex Christensen. Source/WebCore: No observable changes since we are not actually loading FormData right now. * workers/service/context/ServiceWorkerFetch.cpp: (WebCore::ServiceWorkerFetch::processResponse): * workers/service/context/ServiceWorkerFetch.h: Source/WebKit: Added plumbery from Service Worker up to Web Process to pass form data response bodies. A follow-up patch should read the data from Network Process and send it to the ResourceLoader. * Platform/IPC/FormDataReference.h: Added. (IPC::FormDataReference::FormDataReference): (IPC::FormDataReference::takeData): (IPC::FormDataReference::encode const): (IPC::FormDataReference::decode): * StorageProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::didReceiveFetchFormData): * StorageProcess/ServiceWorker/WebSWServerConnection.h: * StorageProcess/StorageProcess.cpp: (WebKit::StorageProcess::didReceiveFetchFormData): * StorageProcess/StorageProcess.h: * StorageProcess/StorageProcess.messages.in: * WebKit.xcodeproj/project.pbxproj: * WebProcess/Storage/ServiceWorkerClientFetch.cpp: (WebKit::ServiceWorkerClientFetch::didReceiveFormData): * WebProcess/Storage/ServiceWorkerClientFetch.h: * WebProcess/Storage/ServiceWorkerClientFetch.messages.in: * WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormData): * WebProcess/Storage/WebServiceWorkerFetchTaskClient.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.h trunk/Source/WebKit/StorageProcess/StorageProcess.cpp trunk/Source/WebKit/StorageProcess/StorageProcess.h trunk/Source/WebKit/StorageProcess/StorageProcess.messages.in trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.h trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.messages.in trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h Added Paths trunk/Source/WebKit/Platform/IPC/FormDataReference.h Diff Modified: trunk/Source/WebCore/ChangeLog (224888 => 224889) --- trunk/Source/WebCore/ChangeLog 2017-11-15 19:22:44 UTC (rev 224888) +++ trunk/Source/WebCore/ChangeLog 2017-11-15 19:28:03 UTC (rev 224889) @@ -1,3 +1,16 @@ +2017-11-15 Youenn Fablet + +Add ServiceWorker to WebProcess plumbery for FormData fetch responses +https://bugs.webkit.org/show_bug.cgi?id=179694 + +Reviewed by Alex Christensen. + +No observable changes since we are not actually loading FormData right now. + +* workers/service/context/ServiceWorkerFetch.cpp: +(WebCore::ServiceWorkerFetch::processResponse): +* workers/service/context/ServiceWorkerFetch.h: + 2017-11-15 Jer Noble Add a compile-time-checked string literal initializer for FourCC. Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp (224888 => 224889) --- trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp 2017-11-15 19:22:44 UTC (rev 224888) +++ trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp 2017-11-15 19:28:03 UTC (rev 224889) @@ -75,8 +75,8 @@ } auto body = response->consumeBody(); -WTF::switchOn(body, [] (Ref&) { -// FIXME: Support FormData response bodies. +WTF::switchOn(body, [&] (Ref& formData) { +client->didReceiveFormData(WTFMove(formData)); }, [&] (Ref& buffer) { client->didReceiveData(WTFMove(buffer)); }, [] (std::nullptr_t&) { Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.h (224888 => 224889) --- trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.h 2017-11-15 19:22:44 UTC (rev 224888) +++ trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.h 2017-11-15 19:28:03 UTC (rev 224889) @@ -34,6 +34,7 @@ class FetchEvent; struct FetchOptions; class FetchResponse; +class FormData; class ResourceRequest; class ResourceResponse; class SharedBuffer; @@ -46,6 +47,7 @@ virtual void didReceiveResponse(const ResourceResponse&) = 0; virtual void didReceiveData(Ref&&) = 0; +virtual void didReceiveFormData(Ref&&) = 0; virtual void didFail() = 0; virtual void didFinish() = 0; virtual void didNotHan
[webkit-changes] [224888] trunk
Title: [224888] trunk Revision 224888 Author keith_mil...@apple.com Date 2017-11-15 11:22:44 -0800 (Wed, 15 Nov 2017) Log Message Unreviewed, sort async iteration feature. * Source/cmake/WebKitFeatures.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmake/WebKitFeatures.cmake Diff Modified: trunk/ChangeLog (224887 => 224888) --- trunk/ChangeLog 2017-11-15 19:06:53 UTC (rev 224887) +++ trunk/ChangeLog 2017-11-15 19:22:44 UTC (rev 224888) @@ -1,5 +1,11 @@ 2017-11-15 Keith Miller +Unreviewed, sort async iteration feature. + +* Source/cmake/WebKitFeatures.cmake: + +2017-11-15 Keith Miller + REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures https://bugs.webkit.org/show_bug.cgi?id=179704 Modified: trunk/Source/cmake/WebKitFeatures.cmake (224887 => 224888) --- trunk/Source/cmake/WebKitFeatures.cmake 2017-11-15 19:06:53 UTC (rev 224887) +++ trunk/Source/cmake/WebKitFeatures.cmake 2017-11-15 19:22:44 UTC (rev 224888) @@ -78,6 +78,7 @@ WEBKIT_OPTION_DEFINE(ENABLE_ACCESSIBILITY "Toggle accessibility support" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_ALLINONE_BUILD "Toggle all-in-one build" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_API_TESTS "Enable public API unit tests" PRIVATE OFF) +WEBKIT_OPTION_DEFINE(ENABLE_ASYNC_ITERATION "Toggle the async iteration API." PRIVATE ON) WEBKIT_OPTION_DEFINE(ENABLE_ASYNC_SCROLLING "Enable asynchronouse scrolling" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_ATTACHMENT_ELEMENT "Toggle attachment element support" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_AVF_CAPTIONS "Toggle AVFoundation caption support" PRIVATE OFF) @@ -107,7 +108,6 @@ WEBKIT_OPTION_DEFINE(ENABLE_FILTERS_LEVEL_2 "Toggle Filters Module Level 2" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_FTPDIR "Toggle FTP directory support" PRIVATE ON) WEBKIT_OPTION_DEFINE(ENABLE_FTL_JIT "Toggle FTL support for JSC" PRIVATE ${ENABLE_FTL_DEFAULT}) -WEBKIT_OPTION_DEFINE(ENABLE_ASYNC_ITERATION "Toggle the async iteration API." PRIVATE ON) WEBKIT_OPTION_DEFINE(ENABLE_FULLSCREEN_API "Toggle Fullscreen API support" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_GAMEPAD "Toggle Gamepad support" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_GEOLOCATION "Toggle Geolocation support" PRIVATE OFF) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224887] trunk/Source/WebCore
Title: [224887] trunk/Source/WebCore Revision 224887 Author jer.no...@apple.com Date 2017-11-15 11:06:53 -0800 (Wed, 15 Nov 2017) Log Message Add a compile-time-checked string literal initializer for FourCC. https://bugs.webkit.org/show_bug.cgi?id=179706 Reviewed by Alex Christensen. Add a contexpr constructor for FourCC that takes a string literal and static_asserts that it is exactly 4 chars long. Use this string literal constructor everywhere instead of multi- character literals. * platform/graphics/FourCC.h: (WebCore::FourCC::FourCC): * platform/graphics/iso/ISOBox.cpp: (WebCore::ISOBox::parse): * platform/graphics/iso/ISOOriginalFormatBox.h: (WebCore::ISOOriginalFormatBox::boxTypeName): * platform/graphics/iso/ISOProtectionSchemeInfoBox.h: (WebCore::ISOProtectionSchemeInfoBox::boxTypeName): * platform/graphics/iso/ISOSchemeInformationBox.h: (WebCore::ISOSchemeInformationBox::boxTypeName): * platform/graphics/iso/ISOSchemeTypeBox.h: (WebCore::ISOSchemeTypeBox::boxTypeName): * platform/graphics/iso/ISOTrackEncryptionBox.h: (WebCore::ISOTrackEncryptionBox::boxTypeName): * platform/graphics/iso/ISOVTTCue.h: (WebCore::ISOWebVTTCue::boxTypeName): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/FourCC.h trunk/Source/WebCore/platform/graphics/iso/ISOBox.cpp trunk/Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h trunk/Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h trunk/Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.h trunk/Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.h trunk/Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.h trunk/Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp trunk/Source/WebCore/platform/graphics/iso/ISOVTTCue.h Diff Modified: trunk/Source/WebCore/ChangeLog (224886 => 224887) --- trunk/Source/WebCore/ChangeLog 2017-11-15 18:48:01 UTC (rev 224886) +++ trunk/Source/WebCore/ChangeLog 2017-11-15 19:06:53 UTC (rev 224887) @@ -1,3 +1,31 @@ +2017-11-15 Jer Noble + +Add a compile-time-checked string literal initializer for FourCC. +https://bugs.webkit.org/show_bug.cgi?id=179706 + +Reviewed by Alex Christensen. + +Add a contexpr constructor for FourCC that takes a string literal and static_asserts that it +is exactly 4 chars long. Use this string literal constructor everywhere instead of multi- +character literals. + +* platform/graphics/FourCC.h: +(WebCore::FourCC::FourCC): +* platform/graphics/iso/ISOBox.cpp: +(WebCore::ISOBox::parse): +* platform/graphics/iso/ISOOriginalFormatBox.h: +(WebCore::ISOOriginalFormatBox::boxTypeName): +* platform/graphics/iso/ISOProtectionSchemeInfoBox.h: +(WebCore::ISOProtectionSchemeInfoBox::boxTypeName): +* platform/graphics/iso/ISOSchemeInformationBox.h: +(WebCore::ISOSchemeInformationBox::boxTypeName): +* platform/graphics/iso/ISOSchemeTypeBox.h: +(WebCore::ISOSchemeTypeBox::boxTypeName): +* platform/graphics/iso/ISOTrackEncryptionBox.h: +(WebCore::ISOTrackEncryptionBox::boxTypeName): +* platform/graphics/iso/ISOVTTCue.h: +(WebCore::ISOWebVTTCue::boxTypeName): + 2017-11-15 Adrian Perez de Castro [Cairo] Clang warns about mismatched declaration type tag for GraphicsContextState Modified: trunk/Source/WebCore/platform/graphics/FourCC.h (224886 => 224887) --- trunk/Source/WebCore/platform/graphics/FourCC.h 2017-11-15 18:48:01 UTC (rev 224886) +++ trunk/Source/WebCore/platform/graphics/FourCC.h 2017-11-15 19:06:53 UTC (rev 224887) @@ -32,6 +32,13 @@ struct FourCC { WEBCORE_EXPORT FourCC(uint32_t value) : value(value) { } +template +constexpr FourCC(const char (&data)[N]) +{ +static_assert((N - 1) == 4, "FourCC literals must be exactly 4 characters long"); +value = data[0] << 24 | data[1] << 16 | data[2] << 8 | data[3]; +} + String toString() const; WEBCORE_EXPORT static std::optional fromString(const String&); Modified: trunk/Source/WebCore/platform/graphics/iso/ISOBox.cpp (224886 => 224887) --- trunk/Source/WebCore/platform/graphics/iso/ISOBox.cpp 2017-11-15 18:48:01 UTC (rev 224886) +++ trunk/Source/WebCore/platform/graphics/iso/ISOBox.cpp 2017-11-15 19:06:53 UTC (rev 224887) @@ -75,7 +75,7 @@ if (m_size == 1 && !checkedRead(m_size, view, offset, BigEndian)) return false; -if (m_boxType.value == 'uuid') { +if (m_boxType == "uuid") { struct ExtendedType { uint8_t value[16]; } extendedTypeStruct; Modified: trunk/Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h (224886 => 224887) --- trunk/Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h 2017-11-15 18:48:01 UTC (rev 224886) +++ trunk/Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h 2017-11-15 19:06:53 UTC (rev 224887) @@ -31,7 +31,7 @@ class ISOOriginalForm
[webkit-changes] [224886] trunk/Tools
Title: [224886] trunk/Tools Revision 224886 Author ryanhad...@apple.com Date 2017-11-15 10:48:01 -0800 (Wed, 15 Nov 2017) Log Message Unreviewed, rolling out r223781. The test is now returning false, so the FIXME is not needed anymore. Reverted changeset: "WebsiteDataStoreCustomPaths.mm is failing after r223718" https://bugs.webkit.org/show_bug.cgi?id=178596 https://trac.webkit.org/changeset/223781 Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm Diff Modified: trunk/Tools/ChangeLog (224885 => 224886) --- trunk/Tools/ChangeLog 2017-11-15 18:36:57 UTC (rev 224885) +++ trunk/Tools/ChangeLog 2017-11-15 18:48:01 UTC (rev 224886) @@ -1,5 +1,18 @@ 2017-11-15 Ryan Haddad +Unreviewed, rolling out r223781. + +The test is now returning false, so the FIXME is not needed +anymore. + +Reverted changeset: + +"WebsiteDataStoreCustomPaths.mm is failing after r223718" +https://bugs.webkit.org/show_bug.cgi?id=178596 +https://trac.webkit.org/changeset/223781 + +2017-11-15 Ryan Haddad + Unreviewed, rolling out r224863. Introduced LayoutTest crashes on iOS Simulator. Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm (224885 => 224886) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm 2017-11-15 18:36:57 UTC (rev 224885) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm 2017-11-15 18:48:01 UTC (rev 224886) @@ -216,8 +216,7 @@ receivedScriptMessage = false; TestWebKitAPI::Util::run(&receivedScriptMessage); -// FIXME: https://bugs.webkit.org/show_bug.cgi?id=178596, we should expect false and not true here. -EXPECT_TRUE([WKWebsiteDataStore _defaultDataStoreExists]); +EXPECT_FALSE([WKWebsiteDataStore _defaultDataStoreExists]); } #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224885] trunk/Source/WebKit
Title: [224885] trunk/Source/WebKit Revision 224885 Author achristen...@apple.com Date 2017-11-15 10:36:57 -0800 (Wed, 15 Nov 2017) Log Message Move a compiled WKContentRuleList to its destination before calling mmap https://bugs.webkit.org/show_bug.cgi?id=179719 Reviewed by Brady Eidson. Right now we compile a WKContentRuleList to a temporary file, call mmap, close the file, then move it. Sometimes, especially on bots running tests, the move fails because the temporary file doesn't exist any more. Moving the file before mmaping and closing the file might prevent this failure. * UIProcess/API/APIContentRuleListStore.cpp: (API::compiledToFile): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (224884 => 224885) --- trunk/Source/WebKit/ChangeLog 2017-11-15 18:31:04 UTC (rev 224884) +++ trunk/Source/WebKit/ChangeLog 2017-11-15 18:36:57 UTC (rev 224885) @@ -1,3 +1,17 @@ +2017-11-15 Alex Christensen + +Move a compiled WKContentRuleList to its destination before calling mmap +https://bugs.webkit.org/show_bug.cgi?id=179719 + +Reviewed by Brady Eidson. + +Right now we compile a WKContentRuleList to a temporary file, call mmap, close the file, then move it. +Sometimes, especially on bots running tests, the move fails because the temporary file doesn't exist +any more. Moving the file before mmaping and closing the file might prevent this failure. + +* UIProcess/API/APIContentRuleListStore.cpp: +(API::compiledToFile): + 2017-11-15 Chris Dumez [Service Workers] Implement Client API Modified: trunk/Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp (224884 => 224885) --- trunk/Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp 2017-11-15 18:31:04 UTC (rev 224884) +++ trunk/Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp 2017-11-15 18:36:57 UTC (rev 224885) @@ -349,18 +349,19 @@ closeFile(temporaryFileHandle); return ContentRuleListStore::Error::CompileFailed; } - + +if (!moveFile(temporaryFilePath, finalFilePath)) { +WTFLogAlways("Content Rule List compiling failed: Moving file failed."); +return ContentRuleListStore::Error::CompileFailed; +} + mappedData = adoptAndMapFile(temporaryFileHandle, 0, metaData.fileSize()); if (mappedData.isNull()) { WTFLogAlways("Content Rule List compiling failed: Mapping file failed."); +deleteFile(finalFilePath); return ContentRuleListStore::Error::CompileFailed; } -if (!moveFile(temporaryFilePath, finalFilePath)) { -WTFLogAlways("Content Rule List compiling failed: Moving file failed."); -return ContentRuleListStore::Error::CompileFailed; -} - return { }; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224884] trunk
Title: [224884] trunk Revision 224884 Author keith_mil...@apple.com Date 2017-11-15 10:31:04 -0800 (Wed, 15 Nov 2017) Log Message REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures https://bugs.webkit.org/show_bug.cgi?id=179704 Reviewed by Yusuke Suzuki. Add feature flag for Async iteration. * Source/cmake/WebKitFeatures.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmake/WebKitFeatures.cmake Diff Modified: trunk/ChangeLog (224883 => 224884) --- trunk/ChangeLog 2017-11-15 18:24:22 UTC (rev 224883) +++ trunk/ChangeLog 2017-11-15 18:31:04 UTC (rev 224884) @@ -1,3 +1,14 @@ +2017-11-15 Keith Miller + +REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures +https://bugs.webkit.org/show_bug.cgi?id=179704 + +Reviewed by Yusuke Suzuki. + +Add feature flag for Async iteration. + +* Source/cmake/WebKitFeatures.cmake: + 2017-11-13 Michael Catanzaro [GTK] Require woff2 1.0.2 and drop direct brotli dependency Modified: trunk/Source/cmake/WebKitFeatures.cmake (224883 => 224884) --- trunk/Source/cmake/WebKitFeatures.cmake 2017-11-15 18:24:22 UTC (rev 224883) +++ trunk/Source/cmake/WebKitFeatures.cmake 2017-11-15 18:31:04 UTC (rev 224884) @@ -107,6 +107,7 @@ WEBKIT_OPTION_DEFINE(ENABLE_FILTERS_LEVEL_2 "Toggle Filters Module Level 2" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_FTPDIR "Toggle FTP directory support" PRIVATE ON) WEBKIT_OPTION_DEFINE(ENABLE_FTL_JIT "Toggle FTL support for JSC" PRIVATE ${ENABLE_FTL_DEFAULT}) +WEBKIT_OPTION_DEFINE(ENABLE_ASYNC_ITERATION "Toggle the async iteration API." PRIVATE ON) WEBKIT_OPTION_DEFINE(ENABLE_FULLSCREEN_API "Toggle Fullscreen API support" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_GAMEPAD "Toggle Gamepad support" PRIVATE OFF) WEBKIT_OPTION_DEFINE(ENABLE_GEOLOCATION "Toggle Geolocation support" PRIVATE OFF) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224883] trunk/LayoutTests
Title: [224883] trunk/LayoutTests Revision 224883 Author jlew...@apple.com Date 2017-11-15 10:24:22 -0800 (Wed, 15 Nov 2017) Log Message Adjusted expectations for compositing/repaint/fixed-background-scroll.html. https://bugs.webkit.org/show_bug.cgi?id=154612 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (224882 => 224883) --- trunk/LayoutTests/ChangeLog 2017-11-15 18:06:05 UTC (rev 224882) +++ trunk/LayoutTests/ChangeLog 2017-11-15 18:24:22 UTC (rev 224883) @@ -1,3 +1,12 @@ +2017-11-15 Matt Lewis + +Adjusted expectations for compositing/repaint/fixed-background-scroll.html. +https://bugs.webkit.org/show_bug.cgi?id=154612 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2017-11-15 Chris Dumez [Service Workers] Implement Client API Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (224882 => 224883) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-11-15 18:06:05 UTC (rev 224882) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-11-15 18:24:22 UTC (rev 224883) @@ -358,7 +358,7 @@ webkit.org/b/165541 compositing/layer-creation/fixed-overlap-extent-rtl.html [ Failure ] webkit.org/b/165541 compositing/rtl/rtl-fixed-overflow.html [ Failure ] -webkit.org/b/154612 [ Sierra ] compositing/repaint/fixed-background-scroll.html [ Pass Failure ] +webkit.org/b/154612 [ Sierra+ ] compositing/repaint/fixed-background-scroll.html [ Pass Failure ] webkit.org/b/165589 pointer-lock/lock-lost-on-esc-in-fullscreen.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224882] trunk/Source/WebCore
Title: [224882] trunk/Source/WebCore Revision 224882 Author ape...@igalia.com Date 2017-11-15 10:06:05 -0800 (Wed, 15 Nov 2017) Log Message [Cairo] Clang warns about mismatched declaration type tag for GraphicsContextState https://bugs.webkit.org/show_bug.cgi?id=179729 Reviewed by Michael Catanzaro. No new tests needed. * platform/graphics/cairo/CairoOperations.h: Make the forward declaration use "struct" as the actual implementation of the type does. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h Diff Modified: trunk/Source/WebCore/ChangeLog (224881 => 224882) --- trunk/Source/WebCore/ChangeLog 2017-11-15 18:04:16 UTC (rev 224881) +++ trunk/Source/WebCore/ChangeLog 2017-11-15 18:06:05 UTC (rev 224882) @@ -1,3 +1,15 @@ +2017-11-15 Adrian Perez de Castro + +[Cairo] Clang warns about mismatched declaration type tag for GraphicsContextState +https://bugs.webkit.org/show_bug.cgi?id=179729 + +Reviewed by Michael Catanzaro. + +No new tests needed. + +* platform/graphics/cairo/CairoOperations.h: Make the forward declaration use "struct" +as the actual implementation of the type does. + 2017-11-15 Chris Dumez [Service Workers] Implement Client API Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h (224881 => 224882) --- trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h 2017-11-15 18:04:16 UTC (rev 224881) +++ trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h 2017-11-15 18:06:05 UTC (rev 224882) @@ -48,11 +48,12 @@ class FloatRoundedRect; class FloatSize; class GraphicsContext; -class GraphicsContextState; class Image; class Path; class PlatformContextCairo; +struct GraphicsContextState; + namespace Cairo { namespace State { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224881] branches/safari-604.4.7.1-branch/Source
Title: [224881] branches/safari-604.4.7.1-branch/Source Revision 224881 Author matthew_han...@apple.com Date 2017-11-15 10:04:16 -0800 (Wed, 15 Nov 2017) Log Message Versioning. Modified Paths branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-604.4.7.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (224880 => 224881) --- branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-11-15 18:00:24 UTC (rev 224880) +++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-11-15 18:04:16 UTC (rev 224881) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (224880 => 224881) --- branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-11-15 18:00:24 UTC (rev 224880) +++ branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-11-15 18:04:16 UTC (rev 224881) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig (224880 => 224881) --- branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2017-11-15 18:00:24 UTC (rev 224880) +++ branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2017-11-15 18:04:16 UTC (rev 224881) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (224880 => 224881) --- branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-11-15 18:00:24 UTC (rev 224880) +++ branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-11-15 18:04:16 UTC (rev 224881) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (224880 => 224881) --- branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-11-15 18:00:24 UTC (rev 224880) +++ branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-11-15 18:04:16 UTC (rev 224881) @@ -2,7 +2,7 @@ MINOR_VERSION = 4; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig (224880 => 224881) --- branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig 2017-11-15 18:00:24 UTC (rev 224880) +++ branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig 2017-11-15 18:04:16 UTC (rev 224881) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-604.4.7.1-branch/Sourc
[webkit-changes] [224880] trunk
Title: [224880] trunk Revision 224880 Author cdu...@apple.com Date 2017-11-15 10:00:24 -0800 (Wed, 15 Nov 2017) Log Message [Service Workers] Implement Client API https://bugs.webkit.org/show_bug.cgi?id=179709 Reviewed by Alex Christensen. Source/WebCore: Implement Client API as per: - https://w3c.github.io/ServiceWorker/#client-interface Tests: http/tests/workers/service/Client-properties.html http/tests/workers/service/Client-properties-subframe.html http/tests/workers/service/Client-properties-auxiliary.html * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * workers/service/ServiceWorker.cpp: (WebCore::ServiceWorker::postMessage): * workers/service/ServiceWorkerClient.cpp: (WebCore::ServiceWorkerClient::ServiceWorkerClient): (WebCore::ServiceWorkerClient::url const): (WebCore::ServiceWorkerClient::type const): (WebCore::ServiceWorkerClient::frameType const): (WebCore::ServiceWorkerClient::id const): (WebCore::ServiceWorkerClient::postMessage): * workers/service/ServiceWorkerClient.h: (WebCore::ServiceWorkerClient::create): * workers/service/ServiceWorkerClientData.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp. (WebCore::toServiceWorkerClientFrameType): (WebCore::ServiceWorkerClientData::isolatedCopy const): (WebCore::ServiceWorkerClientData::from): * workers/service/ServiceWorkerClientData.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.h. (WebCore::ServiceWorkerClientData::encode const): (WebCore::ServiceWorkerClientData::decode): * workers/service/ServiceWorkerClientIdentifier.h: (WebCore::ServiceWorkerClientIdentifier::encode const): (WebCore::ServiceWorkerClientIdentifier::decode): * workers/service/ServiceWorkerTypes.h: * workers/service/ServiceWorkerWindowClient.cpp: (WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient): * workers/service/ServiceWorkerWindowClient.h: * workers/service/context/SWContextManager.cpp: (WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope): * workers/service/context/SWContextManager.h: * workers/service/context/ServiceWorkerThread.cpp: (WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope): * workers/service/context/ServiceWorkerThread.h: * workers/service/server/SWClientConnection.h: Source/WebKit: * Shared/WebCoreArgumentCoders.cpp: * Shared/WebCoreArgumentCoders.h: * StorageProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope): * StorageProcess/ServiceWorker/WebSWServerConnection.h: * StorageProcess/ServiceWorker/WebSWServerConnection.messages.in: * WebProcess/Storage/WebSWClientConnection.cpp: (WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope): * WebProcess/Storage/WebSWClientConnection.h: * WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerGlobalScope): * WebProcess/Storage/WebSWContextManagerConnection.h: * WebProcess/Storage/WebSWContextManagerConnection.messages.in: LayoutTests: Add layout test coverage. * http/tests/workers/service/Client-properties-auxiliary-expected.txt: Added. * http/tests/workers/service/Client-properties-auxiliary.html: Added. * http/tests/workers/service/Client-properties-expected.txt: Added. * http/tests/workers/service/Client-properties-subframe-expected.txt: Added. * http/tests/workers/service/Client-properties-subframe.html: Added. * http/tests/workers/service/Client-properties.html: Added. * http/tests/workers/service/resources/Client-properties-worker.js: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/workers/service/ServiceWorker.cpp trunk/Source/WebCore/workers/service/ServiceWorkerClient.cpp trunk/Source/WebCore/workers/service/ServiceWorkerClient.h trunk/Source/WebCore/workers/service/ServiceWorkerClientIdentifier.h trunk/Source/WebCore/workers/service/ServiceWorkerClientType.h trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationData.h trunk/Source/WebCore/workers/service/ServiceWorkerTypes.h trunk/Source/WebCore/workers/service/ServiceWorkerUpdateViaCache.h trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.h trunk/Source/WebCore/workers/service/context/SWContextManager.cpp trunk/Source/WebCore/workers/service/context/SWContextManager.h trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.h trunk/Source/WebCore/workers/service/server/SWClientConnection.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.h trunk/Source/WebKit/Storag
[webkit-changes] [224878] trunk/Source/WebKit
Title: [224878] trunk/Source/WebKit Revision 224878 Author bfulg...@apple.com Date 2017-11-15 08:59:52 -0800 (Wed, 15 Nov 2017) Log Message Remove access to "com.apple.pbs.fetch_services" from WebContent sandbox https://bugs.webkit.org/show_bug.cgi?id=179689 Reviewed by Per Arne Vollan. WebKit's WebContent process should not have any need to interact with the fetch_services API exposed to the system. These interactions (if needed) should be happening in the UIProcess, so we should prevent the untrusted Web Content Process from being able to connect. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (224877 => 224878) --- trunk/Source/WebKit/ChangeLog 2017-11-15 16:56:55 UTC (rev 224877) +++ trunk/Source/WebKit/ChangeLog 2017-11-15 16:59:52 UTC (rev 224878) @@ -1,3 +1,17 @@ +2017-11-14 Brent Fulgham + +Remove access to "com.apple.pbs.fetch_services" from WebContent sandbox +https://bugs.webkit.org/show_bug.cgi?id=179689 + + +Reviewed by Per Arne Vollan. + +WebKit's WebContent process should not have any need to interact with the fetch_services +API exposed to the system. These interactions (if needed) should be happening in the UIProcess, +so we should prevent the untrusted Web Content Process from being able to connect. + +* WebProcess/com.apple.WebProcess.sb.in: + 2017-11-15 Michael Catanzaro Remove GTK web inspector images Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (224877 => 224878) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2017-11-15 16:56:55 UTC (rev 224877) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2017-11-15 16:59:52 UTC (rev 224878) @@ -653,9 +653,6 @@ (literal "/private/var/run/mDNSResponder") (remote tcp)) -(allow mach-lookup - (global-name "com.apple.pbs.fetch_services")) - #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 ;; CFNetwork (allow file-read-data (path "/private/var/db/nsurlstoraged/dafsaData.bin")) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224877] trunk
Title: [224877] trunk Revision 224877 Author mcatanz...@igalia.com Date 2017-11-15 08:56:55 -0800 (Wed, 15 Nov 2017) Log Message Remove GTK web inspector images https://bugs.webkit.org/show_bug.cgi?id=179716 Reviewed by Carlos Garcia Campos. Source/WebInspectorUI: * Scripts/copy-user-interface-resources.pl: * UserInterface/Images/gtk/AUTHORS: Removed. * UserInterface/Images/gtk/ActiveCallFrame.svg: Removed. * UserInterface/Images/gtk/AnimationPlayStatePaused.svg: Removed. * UserInterface/Images/gtk/AnimationPlayStateRunning.svg: Removed. * UserInterface/Images/gtk/ApplicationCache.png: Removed. * UserInterface/Images/gtk/applicationca...@2x.png: Removed. * UserInterface/Images/gtk/ApplicationCacheManifest.png: Removed. * UserInterface/Images/gtk/applicationcachemanif...@2x.png: Removed. * UserInterface/Images/gtk/ArrowUp.svg: Removed. * UserInterface/Images/gtk/Assertion.svg: Removed. * UserInterface/Images/gtk/BackForwardArrows.svg: Removed. * UserInterface/Images/gtk/Breakpoint.png: Removed. * UserInterface/Images/gtk/breakpo...@2x.png: Removed. * UserInterface/Images/gtk/BreakpointButton.svg: Removed. * UserInterface/Images/gtk/BreakpointInactive.png: Removed. * UserInterface/Images/gtk/breakpointinact...@2x.png: Removed. * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Removed. * UserInterface/Images/gtk/Breakpoints.svg: Removed. * UserInterface/Images/gtk/COPYING: Removed. * UserInterface/Images/gtk/COPYING_CCBYSA3: Removed. * UserInterface/Images/gtk/COPYING_LGPL2: Removed. * UserInterface/Images/gtk/CSSVariable.svg: Removed. * UserInterface/Images/gtk/CallTrees.svg: Removed. * UserInterface/Images/gtk/Canvas.svg: Removed. * UserInterface/Images/gtk/Canvas2D.svg: Removed. * UserInterface/Images/gtk/Canvas3D.svg: Removed. * UserInterface/Images/gtk/CanvasOverview.svg: Removed. * UserInterface/Images/gtk/Checkers.svg: Removed. * UserInterface/Images/gtk/Circle.svg: Removed. * UserInterface/Images/gtk/ClearBoth.svg: Removed. * UserInterface/Images/gtk/ClearLeft.svg: Removed. * UserInterface/Images/gtk/ClearRight.svg: Removed. * UserInterface/Images/gtk/ClippingCSS.png: Removed. * UserInterface/Images/gtk/clipping...@2x.png: Removed. * UserInterface/Images/gtk/ClippingCSSLarge.png: Removed. * UserInterface/Images/gtk/clippingcssla...@2x.png: Removed. * UserInterface/Images/gtk/ClippingGeneric.png: Removed. * UserInterface/Images/gtk/clippinggene...@2x.png: Removed. * UserInterface/Images/gtk/ClippingGenericLarge.png: Removed. * UserInterface/Images/gtk/clippinggenericla...@2x.png: Removed. * UserInterface/Images/gtk/ClippingJS.png: Removed. * UserInterface/Images/gtk/clippin...@2x.png: Removed. * UserInterface/Images/gtk/ClippingJSLarge.png: Removed. * UserInterface/Images/gtk/clippingjsla...@2x.png: Removed. * UserInterface/Images/gtk/Close.svg: Removed. * UserInterface/Images/gtk/CloseLarge.svg: Removed. * UserInterface/Images/gtk/CloseWhite.svg: Removed. * UserInterface/Images/gtk/ColorIcon.png: Removed. * UserInterface/Images/gtk/colori...@2x.png: Removed. * UserInterface/Images/gtk/Console.svg: Removed. * UserInterface/Images/gtk/Cookie.png: Removed. * UserInterface/Images/gtk/coo...@2x.png: Removed. * UserInterface/Images/gtk/Crosshair.svg: Removed. * UserInterface/Images/gtk/CubicBezier.svg: Removed. * UserInterface/Images/gtk/DOMBreakpoint.svg: Removed. * UserInterface/Images/gtk/DOMCharacterData.svg: Removed. * UserInterface/Images/gtk/DOMComment.svg: Removed. * UserInterface/Images/gtk/DOMDocument.svg: Removed. * UserInterface/Images/gtk/DOMDocumentType.svg: Removed. * UserInterface/Images/gtk/DOMElement.svg: Removed. * UserInterface/Images/gtk/DOMNode.svg: Removed. * UserInterface/Images/gtk/DOMTextNode.svg: Removed. * UserInterface/Images/gtk/Database.png: Removed. * UserInterface/Images/gtk/datab...@2x.png: Removed. * UserInterface/Images/gtk/DatabaseTable.png: Removed. * UserInterface/Images/gtk/databaseta...@2x.png: Removed. * UserInterface/Images/gtk/Debug.svg: Removed. * UserInterface/Images/gtk/Debugger.svg: Removed. * UserInterface/Images/gtk/DisclosureTriangles.svg: Removed. * UserInterface/Images/gtk/DockBottom.svg: Removed. * UserInterface/Images/gtk/DockLeft.svg: Removed. * UserInterface/Images/gtk/DockRight.svg: Removed. * UserInterface/Images/gtk/DocumentCSS.png: Removed. * UserInterface/Images/gtk/document...@2x.png: Removed. * UserInterface/Images/gtk/DocumentCSSLarge.png: Removed. * UserInterface/Images/gtk/documentcssla...@2x.png: Removed. * UserInterface/Images/gtk/DocumentFont.png: Removed. * UserInterface/Images/gtk/documentf...@2x.png: Removed. * UserInterface/Images/gtk/DocumentFontLarge.png: Removed. * UserInterface/Images/gtk/documentfontla...@2x.png: Removed. * UserInterface/Images/gtk/DocumentGeneric.png: Removed. * UserInterface/Images/gtk/documentgene...@2x.png: Removed. * UserInterface/Images/gtk/DocumentGenericLarge.png: Removed. * UserInterface/Images/gtk/documentgenericla...@2x.png: Removed. * UserInterface/Images/gtk/DocumentImage.png: Rem
[webkit-changes] [224876] trunk
Title: [224876] trunk Revision 224876 Author commit-qu...@webkit.org Date 2017-11-15 08:24:31 -0800 (Wed, 15 Nov 2017) Log Message Remove service worker selection based on registration https://bugs.webkit.org/show_bug.cgi?id=179705 Patch by Youenn Fablet on 2017-11-15 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/service-workers/service-worker/controller-on-reload.https-expected.txt: Source/WebCore: Covered by updated tests. Selection is now handled at navigation time. We can remove the selection/unselection of worker based on registration. * workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult): * workers/service/ServiceWorkerRegistration.cpp: (WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration): LayoutTests: Updating tests to use actual selected frames. * http/tests/inspector/network/resource-response-service-worker.html: * http/tests/inspector/network/resources/fetch-service-worker.js: * http/tests/workers/service/ServiceWorkerGlobalScope-properties.html: * http/tests/workers/service/basic-fetch.https-expected.txt: * http/tests/workers/service/cors-image-fetch-expected.txt: * http/tests/workers/service/cors-image-fetch.html: * http/tests/workers/service/image-fetch-expected.txt: * http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js: (then): * http/tests/workers/service/resources/basic-fetch-worker.js: * http/tests/workers/service/resources/basic-fetch.js: (async.test): * http/tests/workers/service/resources/cors-image-fetch.js: (async.test): (async.loadedImage): Deleted. (async.erroredImage): Deleted. (async.logStatus): Deleted. * http/tests/workers/service/resources/cors-image-fetch-iframe.html: Added. * http/tests/workers/service/resources/image-fetch.js: (async.test): (done): Deleted. (async.loadedImage): Deleted. (async.erroredImage): Deleted. (async.logStatus): Deleted. * http/tests/workers/service/resources/service-worker-crossorigin-fetch.js: (async.test): (done): Deleted. (async.logStatus): Deleted. * http/tests/workers/service/resources/service-worker-fetch.js: (async.test): (done): Deleted. (async.logStatus): Deleted. * http/tests/workers/service/resources/service-worker-importScript.js: (async.test): (async.logStatus): Deleted. * http/tests/workers/service/resources/sw-test-pre.js: (async.interceptedFrame): * http/tests/workers/service/resources/tainted-image-fetch.js: (async.test): (async.loadedImage): Deleted. (async.erroredImage): Deleted. (async.logStatus): Deleted. * http/tests/workers/service/service-worker-fetch.https-expected.txt: * http/tests/workers/service/tainted-image-fetch-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/network/resource-response-service-worker.html trunk/LayoutTests/http/tests/inspector/network/resources/fetch-service-worker.js trunk/LayoutTests/http/tests/workers/service/ServiceWorkerGlobalScope-properties.html trunk/LayoutTests/http/tests/workers/service/basic-fetch.https-expected.txt trunk/LayoutTests/http/tests/workers/service/cors-image-fetch-expected.txt trunk/LayoutTests/http/tests/workers/service/cors-image-fetch.html trunk/LayoutTests/http/tests/workers/service/image-fetch-expected.txt trunk/LayoutTests/http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js trunk/LayoutTests/http/tests/workers/service/resources/basic-fetch-worker.js trunk/LayoutTests/http/tests/workers/service/resources/basic-fetch.js trunk/LayoutTests/http/tests/workers/service/resources/cors-image-fetch.js trunk/LayoutTests/http/tests/workers/service/resources/image-fetch.js trunk/LayoutTests/http/tests/workers/service/resources/service-worker-crossorigin-fetch.js trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch.js trunk/LayoutTests/http/tests/workers/service/resources/service-worker-importScript.js trunk/LayoutTests/http/tests/workers/service/resources/sw-test-pre.js trunk/LayoutTests/http/tests/workers/service/resources/tainted-image-fetch.js trunk/LayoutTests/http/tests/workers/service/service-worker-fetch.https-expected.txt trunk/LayoutTests/http/tests/workers/service/tainted-image-fetch-expected.txt trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/controller-on-reload.https-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp Added Paths trunk/LayoutTests/http/tests/workers/service/resources/cors-image-fetch-iframe.html Diff Modified: trunk/LayoutTests/ChangeLog (224875 => 224876) --- trunk/LayoutTests/ChangeLog 2017-11-15 16:17:47 UTC (rev 224875) +++ trunk/LayoutTests/ChangeLog 2017-11-15 16:24:31 UTC (rev 224876) @@ -1,3 +1,57 @@ +2017-11-15 Youenn Fablet + +Remove service worker selection based on registration +https://bugs
[webkit-changes] [224875] trunk/Tools
Title: [224875] trunk/Tools Revision 224875 Author jbed...@apple.com Date 2017-11-15 08:17:47 -0800 (Wed, 15 Nov 2017) Log Message REGRESSION(r221877): 'future' handled incorrectly for mac https://bugs.webkit.org/show_bug.cgi?id=179711 Reviewed by Alex Christensen. * Scripts/webkitpy/port/mac.py: (MacPort.default_baseline_search_path): Use platform/mac- instead of platform/ as the baseline search path. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/mac.py Diff Modified: trunk/Tools/ChangeLog (224874 => 224875) --- trunk/Tools/ChangeLog 2017-11-15 13:26:52 UTC (rev 224874) +++ trunk/Tools/ChangeLog 2017-11-15 16:17:47 UTC (rev 224875) @@ -1,3 +1,15 @@ +2017-11-15 Jonathan Bedard + +REGRESSION(r221877): 'future' handled incorrectly for mac +https://bugs.webkit.org/show_bug.cgi?id=179711 + + +Reviewed by Alex Christensen. + +* Scripts/webkitpy/port/mac.py: +(MacPort.default_baseline_search_path): Use platform/mac- instead of +platform/ as the baseline search path. + 2017-11-14 Nan Wang AX: AOM: Implement AccessibleNode class and support label and role attributes Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (224874 => 224875) --- trunk/Tools/Scripts/webkitpy/port/mac.py 2017-11-15 13:26:52 UTC (rev 224874) +++ trunk/Tools/Scripts/webkitpy/port/mac.py 2017-11-15 16:17:47 UTC (rev 224875) @@ -76,7 +76,7 @@ def default_baseline_search_path(self): mac_version = 'mac-{}'.format(self._os_version) if mac_version.endswith(self.FUTURE_VERSION) or mac_version not in self.VERSION_FALLBACK_ORDER: -version_fallback = [self._os_version] +version_fallback = [mac_version] else: version_fallback = self.VERSION_FALLBACK_ORDER[self.VERSION_FALLBACK_ORDER.index(mac_version):-1] wk_string = 'wk1' ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224874] trunk/LayoutTests
Title: [224874] trunk/LayoutTests Revision 224874 Author ms2...@igalia.com Date 2017-11-15 05:26:52 -0800 (Wed, 15 Nov 2017) Log Message [GTK][WPE] Unreviewed test gardening https://bugs.webkit.org/show_bug.cgi?id=179726 Unreviewed test gardening. * platform/gtk/TestExpectations: Add new expectations. * platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt: Rebaseline for bug 179431. * platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline for bug 179494. * platform/wpe/TestExpectations: Remove expectations that were redundant with other (more correct) expectations in the same file, or with the new expectation file. * platform/wpe/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: Removed: bug 179094 improved the results and made them match the platform-neutral expectation file. * platform/wpe/fast/workers/self-hasOwnProperty-expected.txt: Removed: bug 179094 improved the results and made them match the platform-neutral expectation file. * platform/wpe/http/tests/uri/css-href-expected.txt: Added: missing baseline. * platform/wpe/imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub-expected.txt: Rebaseline to make the test useful as a regression test. * platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline for bug 179494. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt trunk/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt trunk/LayoutTests/platform/wpe/TestExpectations trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub-expected.txt trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt Added Paths trunk/LayoutTests/platform/wpe/http/tests/ trunk/LayoutTests/platform/wpe/http/tests/uri/ trunk/LayoutTests/platform/wpe/http/tests/uri/css-href-expected.txt Removed Paths trunk/LayoutTests/platform/wpe/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt trunk/LayoutTests/platform/wpe/fast/workers/self-hasOwnProperty-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (224873 => 224874) --- trunk/LayoutTests/ChangeLog 2017-11-15 13:00:19 UTC (rev 224873) +++ trunk/LayoutTests/ChangeLog 2017-11-15 13:26:52 UTC (rev 224874) @@ -1,3 +1,30 @@ +2017-11-15 Ms2ger + +[GTK][WPE] Unreviewed test gardening +https://bugs.webkit.org/show_bug.cgi?id=179726 + +Unreviewed test gardening. + +* platform/gtk/TestExpectations: Add new expectations. +* platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt: + Rebaseline for bug 179431. +* platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: + Rebaseline for bug 179494. +* platform/wpe/TestExpectations: Remove expectations that were redundant + with other (more correct) expectations in the same file, or with the + new expectation file. +* platform/wpe/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: + Removed: bug 179094 improved the results and made them match the + platform-neutral expectation file. +* platform/wpe/fast/workers/self-hasOwnProperty-expected.txt: + Removed: bug 179094 improved the results and made them match the + platform-neutral expectation file. +* platform/wpe/http/tests/uri/css-href-expected.txt: Added: missing baseline. +* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub-expected.txt: + Rebaseline to make the test useful as a regression test. +* platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt: + Rebaseline for bug 179494. + 2017-11-14 Nan Wang AX: AOM: Implement AccessibleNode class and support label and role attributes Modified: trunk/LayoutTests/platform/gtk/TestExpectations (224873 => 224874) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-11-15 13:00:19 UTC (rev 224873) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-11-15 13:26:52 UTC (rev 224874) @@ -3330,6 +3330,17 @@ webkit.org/b/179605 editing/execCommand/underline-selection-containing-image.html [ Failure ] +webkit.org/b/179721 media/video-fullscreen-restriction-removed.html [ Failure ] +webkit.org/b/179721 fullscreen/full-screen-iframe-legacy.html [ Timeout ] +webkit.org/b/179721 media/media-fullscreen-inline.html [ Timeout ] +webkit.org/b/179721 media/media-fullscreen-not-in-document.html [ Timeout ] +webkit.org/b/179721 media/media-fullscreen-return-to-inline.html [ Timeout ] +webkit.org/b/179721 media/video-fullscreeen-only-playback.html [ Timeout ] + +webkit.org/
[webkit-changes] [224873] trunk/Source/WebCore
Title: [224873] trunk/Source/WebCore Revision 224873 Author zandober...@gmail.com Date 2017-11-15 05:00:19 -0800 (Wed, 15 Nov 2017) Log Message [Cairo] GraphicsContext::setPlatformShadow() has to update state's shadow offset when ignoring transforms https://bugs.webkit.org/show_bug.cgi?id=179725 Reviewed by Carlos Garcia Campos. In r224753, GraphicsContext::setPlatformShadow() stopped updating the shadow offset value that's kept in GraphicsContextState. This regressed a few tests, so the adjustment of the shadow offset value in the GraphicsContext state is brought back. * platform/graphics/cairo/CairoOperations.cpp: (WebCore::Cairo::State::setShadowValues): * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformShadow): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (224872 => 224873) --- trunk/Source/WebCore/ChangeLog 2017-11-15 12:06:43 UTC (rev 224872) +++ trunk/Source/WebCore/ChangeLog 2017-11-15 13:00:19 UTC (rev 224873) @@ -1,3 +1,20 @@ +2017-11-15 Zan Dobersek + +[Cairo] GraphicsContext::setPlatformShadow() has to update state's shadow offset when ignoring transforms +https://bugs.webkit.org/show_bug.cgi?id=179725 + +Reviewed by Carlos Garcia Campos. + +In r224753, GraphicsContext::setPlatformShadow() stopped updating the +shadow offset value that's kept in GraphicsContextState. This regressed +a few tests, so the adjustment of the shadow offset value in the +GraphicsContext state is brought back. + +* platform/graphics/cairo/CairoOperations.cpp: +(WebCore::Cairo::State::setShadowValues): +* platform/graphics/cairo/GraphicsContextCairo.cpp: +(WebCore::GraphicsContext::setPlatformShadow): + 2017-11-15 Gabriel Ivascu [GTK] Automatically adjust font size when gtk-xft-dpi changes Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp (224872 => 224873) --- trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp 2017-11-15 12:06:43 UTC (rev 224872) +++ trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp 2017-11-15 13:00:19 UTC (rev 224873) @@ -400,15 +400,8 @@ void setShadowValues(PlatformContextCairo& platformContext, const FloatSize& radius, const FloatSize& offset, const Color& color, bool ignoreTransforms) { -FloatSize adjustedOffset = offset; -if (ignoreTransforms) { -// Meaning that this graphics context is associated with a CanvasRenderingContext -// We flip the height since CG and HTML5 Canvas have opposite Y axis -adjustedOffset.setHeight(-offset.height()); -} - // Cairo doesn't support shadows natively, they are drawn manually in the draw* functions using ShadowBlur. -platformContext.shadowBlur().setShadowValues(radius, adjustedOffset, color, ignoreTransforms); +platformContext.shadowBlur().setShadowValues(radius, offset, color, ignoreTransforms); } void clearShadow(PlatformContextCairo& platformContext) Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (224872 => 224873) --- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2017-11-15 12:06:43 UTC (rev 224872) +++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2017-11-15 13:00:19 UTC (rev 224873) @@ -450,9 +450,17 @@ if (paintingDisabled()) return; +FloatSize adjustedOffset = offset; +if (m_state.shadowsIgnoreTransforms) { +// Meaning that this graphics context is associated with a CanvasRenderingContext +// We flip the height since CG and HTML5 Canvas have opposite Y axis +adjustedOffset.setHeight(-offset.height()); +m_state.shadowOffset = adjustedOffset; +} + ASSERT(hasPlatformContext()); Cairo::State::setShadowValues(*platformContext(), FloatSize { blur, blur }, -offset, color, m_state.shadowsIgnoreTransforms); +adjustedOffset, color, m_state.shadowsIgnoreTransforms); } void GraphicsContext::clearPlatformShadow() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224872] trunk/Source
Title: [224872] trunk/Source Revision 224872 Author commit-qu...@webkit.org Date 2017-11-15 04:06:43 -0800 (Wed, 15 Nov 2017) Log Message [GTK] Automatically adjust font size when gtk-xft-dpi changes https://bugs.webkit.org/show_bug.cgi?id=142673 Some follow-up fixes for the previous patch. Patch by Gabriel Ivascu on 2017-11-15 Reviewed by Carlos Garcia Campos. Source/WebCore: * platform/PlatformScreen.h: * platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDPIObserverHandlersMap): (WebCore::gtkXftDPIChangedCallback): (WebCore::setScreenDPIObserverHandler): * platform/wpe/PlatformScreenWPE.cpp: (WebCore::setScreenDPIObserverHandler): Source/WebKit: * UIProcess/API/glib/WebKitSettings.cpp: (webKitSettingsDispose): (webKitSettingsConstructed): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/PlatformScreen.h trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp trunk/Source/WebCore/platform/wpe/PlatformScreenWPE.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (224871 => 224872) --- trunk/Source/WebCore/ChangeLog 2017-11-15 07:56:04 UTC (rev 224871) +++ trunk/Source/WebCore/ChangeLog 2017-11-15 12:06:43 UTC (rev 224872) @@ -1,3 +1,20 @@ +2017-11-15 Gabriel Ivascu + +[GTK] Automatically adjust font size when gtk-xft-dpi changes +https://bugs.webkit.org/show_bug.cgi?id=142673 + +Some follow-up fixes for the previous patch. + +Reviewed by Carlos Garcia Campos. + +* platform/PlatformScreen.h: +* platform/gtk/PlatformScreenGtk.cpp: +(WebCore::screenDPIObserverHandlersMap): +(WebCore::gtkXftDPIChangedCallback): +(WebCore::setScreenDPIObserverHandler): +* platform/wpe/PlatformScreenWPE.cpp: +(WebCore::setScreenDPIObserverHandler): + 2017-11-14 Nan Wang AX: AOM: Implement AccessibleNode class and support label and role attributes Modified: trunk/Source/WebCore/platform/PlatformScreen.h (224871 => 224872) --- trunk/Source/WebCore/platform/PlatformScreen.h 2017-11-15 07:56:04 UTC (rev 224871) +++ trunk/Source/WebCore/platform/PlatformScreen.h 2017-11-15 12:06:43 UTC (rev 224872) @@ -64,7 +64,7 @@ bool screenHasInvertedColors(); #if USE(GLIB) double screenDPI(); -void setScreenDPIObserverHandler(Function&&); +void setScreenDPIObserverHandler(Function&&, void*); #endif FloatRect screenRect(Widget*); Modified: trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp (224871 => 224872) --- trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp 2017-11-15 07:56:04 UTC (rev 224871) +++ trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp 2017-11-15 12:06:43 UTC (rev 224872) @@ -40,7 +40,8 @@ #include #include -#include +#include +#include namespace WebCore { @@ -113,30 +114,38 @@ return cachedDpi; } -static std::optional> screenDPIObserverHandler; +static WTF::HashMap>& screenDPIObserverHandlersMap() +{ +static WTF::NeverDestroyed>> handlersMap; +return handlersMap; +} static void gtkXftDPIChangedCallback() { -if (screenDPIObserverHandler) -(*screenDPIObserverHandler)(); +for (const auto& keyValuePair : screenDPIObserverHandlersMap()) +keyValuePair.value(); } -void setScreenDPIObserverHandler(Function&& handler) +void setScreenDPIObserverHandler(Function&& handler, void* context) { static GtkSettings* gtkSettings = gtk_settings_get_default(); static unsigned long gtkXftDpiChangedHandlerID = 0; -if (!handler) { -if (gtkSettings && gtkXftDpiChangedHandlerID) { -g_signal_handler_disconnect(gtkSettings, gtkXftDpiChangedHandlerID); -gtkXftDpiChangedHandlerID = 0; -} +if (!gtkSettings) return; + +if (handler) +screenDPIObserverHandlersMap().set(context, WTFMove(handler)); +else +screenDPIObserverHandlersMap().remove(context); + +if (!screenDPIObserverHandlersMap().isEmpty()) { +if (!gtkXftDpiChangedHandlerID) +gtkXftDpiChangedHandlerID = g_signal_connect(gtkSettings, "notify::gtk-xft-dpi", G_CALLBACK(gtkXftDPIChangedCallback), nullptr); +} else if (gtkXftDpiChangedHandlerID) { +g_signal_handler_disconnect(gtkSettings, gtkXftDpiChangedHandlerID); +gtkXftDpiChangedHandlerID = 0; } - -screenDPIObserverHandler = WTFMove(handler); -if (gtkSettings && !gtkXftDpiChangedHandlerID) -gtkXftDpiChangedHandlerID = g_signal_connect(gtkSettings, "notify::gtk-xft-dpi", G_CALLBACK(gtkXftDPIChangedCallback), nullptr); } static GdkScreen* getScreen(GtkWidget* widget) Modified: trunk/Source/WebCore/platform/wpe/PlatformScreenWPE.cpp (224871 => 224872) --- trunk/Source/WebCore/platform/wpe/PlatformScreenWPE.cpp 2017-11-15 07:56:04 UTC (rev 224871) +++ trunk/Source/WebCore/platform/wpe/PlatformScreenWPE.cpp 2017-11-15 12:06:43 UTC (rev 224872) @@ -60,7 +60,7 @@ r