[webkit-changes] [226009] trunk/Tools
Title: [226009] trunk/Tools Revision 226009 Author commit-qu...@webkit.org Date 2017-12-16 18:54:13 -0800 (Sat, 16 Dec 2017) Log Message Add a script to automate W3c web-platform-tests pull request creations from WebKit commits https://bugs.webkit.org/show_bug.cgi?id=169462 Patch by Youenn Fablet on 2017-12-16 Reviewed by Darin Adler. Adding some git helper routines used by WPT exporter. Copying WPT github utility files from Chromium. Updating web.py/web_mock.py to cope with these new files. Implementing test exporter in test_exporter.py. This script takes a WebKit commit as input and will create a WPT commit in a local WPT clone. It will then push the commit to a public GitHub repository identified by a username parameter. This parameter is passed through the command line or searched through git config/environment variables. The script can optionally create a pull request to the official WPT GitHub repository. User must provide a GitHub token to allow the script to make the PR on behalf of the user. In that case, a comment is added to the corresponding bugzilla if a bug ID is given or can be found from the change log, to easily link the pull request with the bugzilla bug. * Scripts/export-w3c-test-changes: Added. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.reset_hard): (Git): (Git.am): (Git.commit): (Git.format_patch): (Git.request_pull): (Git.remote): (Git.push): (Git.checkout_new_branch): * Scripts/webkitpy/common/net/web.py: (Web.request): Copied from Chromium. * Scripts/webkitpy/common/net/web_mock.py: Copied needed code from Chromium. * Scripts/webkitpy/w3c/test_exporter.py: Added. (TestExporter): (TestExporter.__init__): (TestExporter._init_repository): (TestExporter.download_and_commit_patch): (TestExporter.clean): (TestExporter.create_branch_with_patch): (TestExporter.push_to_public_repository): (TestExporter.make_pull_request): (TestExporter.delete_local_branch): (TestExporter.create_git_patch): (TestExporter.create_upload_remote_if_needed): (TestExporter.do_export): (parse_args): (configure_logging): (configure_logging.LogHandler): (configure_logging.LogHandler.format): (main): * Scripts/webkitpy/w3c/test_exporter_unittest.py: Added. (TestExporterTest): (TestExporterTest.MockBugzilla): (TestExporterTest.MockBugzilla.__init__): (TestExporterTest.MockBugzilla.fetch_bug_dictionary): (TestExporterTest.MockBugzilla.post_comment_to_bug): (TestExporterTest.MockGit): (TestExporterTest.MockGit.clone): (TestExporterTest.MockGit.__init__): (TestExporterTest.MockGit.fetch): (TestExporterTest.MockGit.checkout): (TestExporterTest.MockGit.reset_hard): (TestExporterTest.MockGit.push): (TestExporterTest.MockGit.format_patch): (TestExporterTest.MockGit.delete_branch): (TestExporterTest.MockGit.checkout_new_branch): (TestExporterTest.MockGit.am): (TestExporterTest.MockGit.commit): (TestExporterTest.MockGit.remote): (TestExporterTest.test_export): * Scripts/webkitpy/w3c/common.py: Copied from chromium. * Scripts/webkitpy/w3c/wpt_github.py: Copied from chromium. * Scripts/webkitpy/w3c/wpt_github_mock.py: Copied from chromium. * Scripts/webkitpy/w3c/wpt_github_unittest.py: Copied from chromium. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py trunk/Tools/Scripts/webkitpy/common/net/web.py trunk/Tools/Scripts/webkitpy/common/net/web_mock.py Added Paths trunk/Tools/Scripts/export-w3c-test-changes trunk/Tools/Scripts/webkitpy/w3c/common.py trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py trunk/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py trunk/Tools/Scripts/webkitpy/w3c/wpt_github.py trunk/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py trunk/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py Diff Modified: trunk/Tools/ChangeLog (226008 => 226009) --- trunk/Tools/ChangeLog 2017-12-16 20:57:11 UTC (rev 226008) +++ trunk/Tools/ChangeLog 2017-12-17 02:54:13 UTC (rev 226009) @@ -1,3 +1,81 @@ +2017-12-16 Youenn Fablet + +Add a script to automate W3c web-platform-tests pull request creations from WebKit commits +https://bugs.webkit.org/show_bug.cgi?id=169462 + +Reviewed by Darin Adler. + +Adding some git helper routines used by WPT exporter. +Copying WPT github utility files from Chromium. +Updating web.py/web_mock.py to cope with these new files. + +Implementing test exporter in test_exporter.py. +This script takes a WebKit commit as input and will create a WPT commit in a local WPT clone. +It will then push the commit to a public GitHub repository identified by a username parameter. +This parameter is passed through the command line or searched through git config/environment variables. + +The script can optionally create a pull request to the official WPT GitHub repository. +User must provide a GitHub token to allow the script to make the PR on behalf of the user. +In that case, a comment is added to the corresponding bugzilla if a bug
[webkit-changes] [226008] trunk
Title: [226008] trunk Revision 226008 Author m...@apple.com Date 2017-12-16 12:57:11 -0800 (Sat, 16 Dec 2017) Log Message WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:] https://bugs.webkit.org/show_bug.cgi?id=180613 Reviewed by Geoff Garen. Source/WebCore: Test: TestWebKitAPI/Tests/WebKitCocoa/WKWebViewAlwaysShowsScroller.mm * platform/ScrollView.h: Exported setScrollbarModes. Source/WebKit: Added _alwaysShowsHorizontalScroller and _alwaysShowsVerticalScroller properties to WKWebView. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): Encode new alwaysShowsHorizontalScroller and alwaysShowsVerticalScroller parameters. (WebKit::WebPageCreationParameters::decode): Decode new parameters. * Shared/WebPageCreationParameters.h: Added new alwaysShowsHorizontalScroller and alwaysShowsVerticalScroller boolean parameters. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _alwaysShowsHorizontalScroller]): New accessor that calls through to the WebPageProxy. (-[WKWebView _setAlwaysShowsHorizontalScroller:]): Ditto. (-[WKWebView _alwaysShowsVerticalScroller]): Ditto. (-[WKWebView _setAlwaysShowsVerticalScroller:]): Ditto. * UIProcess/API/Cocoa/WKWebViewPrivate.h: Declare new properties. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAlwaysShowsHorizontalScroller): Update member variable and send a message to the page. (WebKit::WebPageProxy::setAlwaysShowsVerticalScroller): Ditto. (WebKit::WebPageProxy::creationParameters): Initialize new parameters from the new member variables. * UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::alwaysShowsHorizontalScroller const): New getter. (WebKit::WebPageProxy::alwaysShowsVerticalScroller const): Ditto. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Factor alwaysShowsHorizontalScroller and alwaysShowsVerticalScroller into the initial scroller modes and scroller locks when creating the FrameView. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Initialize new m_alwaysShowsHorizontalScroller and m_alwaysShowsVerticalScroller member variables from the corresponding new creation parameters. (WebKit::WebPage::setAlwaysShowsHorizontalScroller): Update the member variable and set new scrollbar mode on the frame view if needed. (WebKit::WebPage::setAlwaysShowsVerticalScroller): Ditto. * WebProcess/WebPage/WebPage.h: (WebKit::WebPage::alwaysShowsHorizontalScroller const): New getter. (WebKit::WebPage::alwaysShowsVerticalScroller const): Ditto. * WebProcess/WebPage/WebPage.messages.in: Added new messages. Source/WebKitLegacy/mac: * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any clients. * WebView/WebDynamicScrollBarsView.h: Ditto. * WebView/WebDynamicScrollBarsView.mm: Ditto. Tools: * MiniBrowser/mac/MainMenu.xib: Added Always Show {Horizontal,Vertical} Scroller menu items to the View menu. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController validateMenuItem:]): Set the state of the new menu items based on -alwaysShow{Horizontal,Vertical}Scroller. (-[WK1BrowserWindowController toggleAlwaysShowsHorizontalScroller:]): Toggle the value. (-[WK1BrowserWindowController toggleAlwaysShowsVerticalScroller:]): Ditto. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController validateMenuItem:]): Set the state of the new menu items based on the new property. (-[WK2BrowserWindowController toggleAlwaysShowsHorizontalScroller:]): Toggle the property. (-[WK2BrowserWindowController toggleAlwaysShowsVerticalScroller:]): Ditto. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewAlwaysShowsScroller.mm: Added. (TEST): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ScrollView.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp trunk/Source/WebKit/Shared/WebPageCreationParameters.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebKit.mac.exp trunk/Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.h trunk/Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/mac/MainMenu.xib trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Added Paths trunk/Tools/TestWebKitAP
[webkit-changes] [226006] trunk/LayoutTests
Title: [226006] trunk/LayoutTests Revision 226006 Author ms2...@igalia.com Date 2017-12-16 11:05:08 -0800 (Sat, 16 Dec 2017) Log Message Enable wpt fetch tests on WPE. https://bugs.webkit.org/show_bug.cgi?id=180905 Unreviewed test gardening. New expectations are copied from GTK. * TestExpectations: mark test as flaky on all platforms. * platform/wpe/TestExpectations: * platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations Added Paths trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch/api/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch/http-cache/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (226005 => 226006) --- trunk/LayoutTests/ChangeLog 2017-12-16 18:59:29 UTC (rev 226005) +++ trunk/LayoutTests/ChangeLog 2017-12-16 19:05:08 UTC (rev 226006) @@ -1,3 +1,18 @@ +2017-12-16 Ms2ger + +Enable wpt fetch tests on WPE. +https://bugs.webkit.org/show_bug.cgi?id=180905 + +Unreviewed test gardening. + +New expectations are copied from GTK. + +* TestExpectations: mark test as flaky on all platforms. +* platform/wpe/TestExpectations: +* platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt: Added. + 2017-12-16 Youenn Fablet Skip SharedWorker and NavigationPreload service worker tests Modified: trunk/LayoutTests/TestExpectations (226005 => 226006) --- trunk/LayoutTests/TestExpectations 2017-12-16 18:59:29 UTC (rev 226005) +++ trunk/LayoutTests/TestExpectations 2017-12-16 19:05:08 UTC (rev 226006) @@ -1647,6 +1647,8 @@ webkit.org/b/177440 imported/w3c/web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter_null.tentative.html [ Pass Failure ] +webkit.org/b/157068 [ Debug ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Crash ] + # Application Manifest tests webkit.org/b/153152 http/tests/security/contentSecurityPolicy/manifest-src-allowed.html [ Skip ] webkit.org/b/153152 http/tests/security/contentSecurityPolicy/manifest-src-blocked.html [ Skip ] Modified: trunk/LayoutTests/platform/wpe/TestExpectations (226005 => 226006) --- trunk/LayoutTests/platform/wpe/TestExpectations 2017-12-16 18:59:29 UTC (rev 226005) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2017-12-16 19:05:08 UTC (rev 226006) @@ -204,7 +204,6 @@ Bug(WPE) imported/w3c/css [ Skip ] -Bug(WPE) imported/w3c/web-platform-tests/fetch [ Skip ] Bug(WPE) imported/w3c/web-platform-tests/mediacapture-fromelement [ Skip ] Bug(WPE) imported/w3c/web-platform-tests/mediacapture-streams [ Skip ] Bug(WPE) imported/w3c/web-platform-tests/media-source [ Skip ] @@ -274,6 +273,18 @@ webkit.org/b/179881 imported/w3c/web-platform-tests/encoding/eof-shift_jis.html [ ImageOnlyFailure ] +# WPT: fetch +# == + +# Expectations replated to service worker support +# --- +webkit.org/b/178576 imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html [ Failure ] +webkit.org/b/178576 imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https.html [ Failure ] +webkit.org/b/178576 imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https.html [ Failure ] +webkit.org/b/178576 imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https.html [ Failure ] +webkit.org/b/178576 imported/w3c/web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https.html [ Failure ] + + # WPT: FileAPI # imported/w3c/web-platform-tests/FileAPI [ Pass ] Added: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-expected.txt (0 => 226006) --- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/fetch
[webkit-changes] [226005] trunk
Title: [226005] trunk Revision 226005 Author romain.belless...@crf.canon.fr Date 2017-12-16 10:59:29 -0800 (Sat, 16 Dec 2017) Log Message [Readable Streams API] Fix filling of descriptor from queue https://bugs.webkit.org/show_bug.cgi?id=172717 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: Updated test expectations. * web-platform-tests/streams/readable-byte-streams/detached-buffers-expected.txt: Updated. * web-platform-tests/streams/readable-byte-streams/detached-buffers.dedicatedworker-expected.txt: Updated. * web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated. * web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated. Source/WebCore: Fixed the filling of descriptor from queue (step 10.d at [1]). When first implemented, spec comprised a bug and code was not reachable. Spec has now been fixed and code can now be reached. [1] https://streams.spec.whatwg.org/#readable-byte-stream-controller-fill-pull-into-descriptor-from-queue No new tests (covered by WPT tests, whose expectations have been updated). * Modules/streams/ReadableByteStreamInternals.js: (readableByteStreamControllerFillDescriptorFromQueue): Updated. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.dedicatedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226004 => 226005) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-16 18:57:21 UTC (rev 226004) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-16 18:59:29 UTC (rev 226005) @@ -1,3 +1,17 @@ +2017-12-16 Romain Bellessort + +[Readable Streams API] Fix filling of descriptor from queue +https://bugs.webkit.org/show_bug.cgi?id=172717 + +Reviewed by Youenn Fablet. + +Updated test expectations. + +* web-platform-tests/streams/readable-byte-streams/detached-buffers-expected.txt: Updated. +* web-platform-tests/streams/readable-byte-streams/detached-buffers.dedicatedworker-expected.txt: Updated. +* web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated. +* web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated. + 2017-12-16 Youenn Fablet Skip SharedWorker and NavigationPreload service worker tests Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers-expected.txt (226004 => 226005) --- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers-expected.txt 2017-12-16 18:57:21 UTC (rev 226004) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers-expected.txt 2017-12-16 18:59:29 UTC (rev 226005) @@ -2,7 +2,7 @@ Harness Error (TIMEOUT), message = null FAIL ReadableStream with byte source: read()ing from a closed stream still transfers the buffer assert_not_equals: a different ArrayBuffer must underlie the value got disallowed value object "[object ArrayBuffer]" -FAIL ReadableStream with byte source: read()ing from a stream with queued chunks still transfers the buffer assert_array_equals: The value read must be the enqueued Uint8Array, not the original values property 0, expected 1 but got 4 +FAIL ReadableStream with byte source: read()ing from a stream with queued chunks still transfers the buffer assert_not_equals: a different ArrayBuffer must underlie the value got disallowed value object "[object ArrayBuffer]" FAIL ReadableStream with byte source: enqueuing an already-detached buffer throws assert_throws: enqueuing an already-detached buffer must throw function "() => c.enqueue(view)" did not throw TIMEOUT ReadableStream with byte source: reading into an already-detached buffer rejects Test timed out FAIL ReadableStream with byte source: respond() throws if the BYOB request's buffer has been detached (in the readable state) assert_throws: respond() must throw if the corresponding view has become detached function "() => c.byobRequest.respond(1)" did not throw Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.dedicatedworker-expected.txt (226004 => 226005) --- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.dedicatedworker-expected.txt 2017-12-16 18:57:21 UTC (rev 226004) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-strea
[webkit-changes] [226004] trunk/LayoutTests
Title: [226004] trunk/LayoutTests Revision 226004 Author commit-qu...@webkit.org Date 2017-12-16 10:57:21 -0800 (Sat, 16 Dec 2017) Log Message Skip SharedWorker and NavigationPreload service worker tests https://bugs.webkit.org/show_bug.cgi?id=180902 Patch by Youenn Fablet on 2017-12-16 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/service-workers/service-worker/navigation-preload/broken-chunked-encoding.https-expected.txt: * web-platform-tests/service-workers/service-worker/navigation-preload/chunked-encoding.https-expected.txt: * web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https-expected.txt: * web-platform-tests/service-workers/service-worker/navigation-preload/get-state.https-expected.txt: * web-platform-tests/service-workers/service-worker/navigation-preload/redirect.https-expected.txt: * web-platform-tests/service-workers/service-worker/navigation-preload/request-headers.https-expected.txt: * web-platform-tests/service-workers/service-worker/navigation-preload/resource-timing.https-expected.txt: * web-platform-tests/service-workers/service-worker/shared-worker-controlled.https-expected.txt: LayoutTests: * TestExpectations: Skip unsupported tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog Removed Paths trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/broken-chunked-encoding.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/chunked-encoding.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/get-state.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/redirect.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/request-headers.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/resource-timing.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/shared-worker-controlled.https-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (226003 => 226004) --- trunk/LayoutTests/ChangeLog 2017-12-16 18:54:04 UTC (rev 226003) +++ trunk/LayoutTests/ChangeLog 2017-12-16 18:57:21 UTC (rev 226004) @@ -1,3 +1,12 @@ +2017-12-16 Youenn Fablet + +Skip SharedWorker and NavigationPreload service worker tests +https://bugs.webkit.org/show_bug.cgi?id=180902 + +Reviewed by Chris Dumez. + +* TestExpectations: Skip unsupported tests. + 2017-12-16 Chris Dumez Add optimization when updating a SW registration results in the exact same script Modified: trunk/LayoutTests/TestExpectations (226003 => 226004) --- trunk/LayoutTests/TestExpectations 2017-12-16 18:54:04 UTC (rev 226003) +++ trunk/LayoutTests/TestExpectations 2017-12-16 18:57:21 UTC (rev 226004) @@ -152,11 +152,6 @@ imported/w3c/web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-partial-stream.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/http-to-https-redirect-and-register.https.html [ Skip ] -imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/broken-chunked-encoding.https.html [ Skip ] -imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/chunked-encoding.https.html [ Skip ] -imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/get-state.https.html [ Skip ] -imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/redirect.https.html [ Skip ] -imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/request-headers.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/postmessage.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-msgport-to-client.https.html [ Skip ] @@ -167,6 +162,10 @@ imported/w3c/web-platform-tests/service-workers/service-worker/update-recovery.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/client-navigate.https.html [ Skip ] +# Unsupported features: SharedWorker, NavigationPreload +imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload [ Skip ] +imported/w3c/web-platform-tests/service-workers/ser
[webkit-changes] [226003] trunk/Source
Title: [226003] trunk/Source Revision 226003 Author beid...@apple.com Date 2017-12-16 10:54:04 -0800 (Sat, 16 Dec 2017) Log Message Implement getting ServiceWorker registrations for the WKWebsiteDataStore API https://bugs.webkit.org/show_bug.cgi?id=180886 Reviewed by Chris Dumez. Source/WebCore: No new tests (API test coming soon). * workers/service/server/SWServer.cpp: (WebCore::SWServer::registrationStoreImportComplete): (WebCore::SWServer::SWServer): (WebCore::SWServer::getOriginsWithRegistrations): (WebCore::SWServer::performGetOriginsWithRegistrationsCallbacks): * workers/service/server/SWServer.h: Source/WebKit: * StorageProcess/StorageProcess.cpp: (WebKit::StorageProcess::fetchWebsiteData): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebCore/workers/service/server/SWServer.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/StorageProcess/StorageProcess.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (226002 => 226003) --- trunk/Source/WebCore/ChangeLog 2017-12-16 18:33:31 UTC (rev 226002) +++ trunk/Source/WebCore/ChangeLog 2017-12-16 18:54:04 UTC (rev 226003) @@ -1,3 +1,19 @@ +2017-12-16 Brady Eidson + +Implement getting ServiceWorker registrations for the WKWebsiteDataStore API +https://bugs.webkit.org/show_bug.cgi?id=180886 + +Reviewed by Chris Dumez. + +No new tests (API test coming soon). + +* workers/service/server/SWServer.cpp: +(WebCore::SWServer::registrationStoreImportComplete): +(WebCore::SWServer::SWServer): +(WebCore::SWServer::getOriginsWithRegistrations): +(WebCore::SWServer::performGetOriginsWithRegistrationsCallbacks): +* workers/service/server/SWServer.h: + 2017-12-16 Yusuke Suzuki Remove unnecessary boolean result of start() functions Modified: trunk/Source/WebCore/workers/service/server/SWServer.cpp (226002 => 226003) --- trunk/Source/WebCore/workers/service/server/SWServer.cpp 2017-12-16 18:33:31 UTC (rev 226002) +++ trunk/Source/WebCore/workers/service/server/SWServer.cpp 2017-12-16 18:54:04 UTC (rev 226003) @@ -108,7 +108,10 @@ void SWServer::registrationStoreImportComplete() { +ASSERT(!m_importCompleted); +m_importCompleted = true; m_originStore->importComplete(); +performGetOriginsWithRegistrationsCallbacks(); } void SWServer::addRegistrationFromStore(ServiceWorkerContextData&& data) @@ -228,7 +231,7 @@ m_server.syncTerminateWorker(*worker); } -SWServer::SWServer(UniqueRef&& originStore, String&& registrationDatabaseDirectory, PAL::SessionID sessionID) +SWServer::SWServer(UniqueRef&& originStore, String&& registrationDatabaseDirectory, PAL::SessionID sessionID) : m_originStore(WTFMove(originStore)) , m_registrationStore(*this, WTFMove(registrationDatabaseDirectory)) , m_sessionID(sessionID) @@ -768,6 +771,33 @@ }); } +void SWServer::getOriginsWithRegistrations(WTF::Function&)> callback) +{ +m_getOriginsWithRegistrationsCallbacks.append(WTFMove(callback)); + +if (m_importCompleted) +performGetOriginsWithRegistrationsCallbacks(); +} + +void SWServer::performGetOriginsWithRegistrationsCallbacks() +{ +ASSERT(isMainThread()); +ASSERT(m_importCompleted); + +if (m_getOriginsWithRegistrationsCallbacks.isEmpty()) +return; + +HashSet originsWithRegistrations; +for (auto& key : m_registrations.keys()) { +originsWithRegistrations.add(key.topOrigin()); +originsWithRegistrations.add(SecurityOriginData { key.scope().protocol().toString(), key.scope().host(), key.scope().port() }); +} + +auto callbacks = WTFMove(m_getOriginsWithRegistrationsCallbacks); +for (auto& callback : callbacks) +callback(originsWithRegistrations); +} + } // namespace WebCore #endif // ENABLE(SERVICE_WORKER) Modified: trunk/Source/WebCore/workers/service/server/SWServer.h (226002 => 226003) --- trunk/Source/WebCore/workers/service/server/SWServer.h 2017-12-16 18:33:31 UTC (rev 226002) +++ trunk/Source/WebCore/workers/service/server/SWServer.h 2017-12-16 18:54:04 UTC (rev 226003) @@ -174,6 +174,8 @@ void addRegistrationFromStore(ServiceWorkerContextData&&); void registrationStoreImportComplete(); +WEBCORE_EXPORT void getOriginsWithRegistrations(WTF::Function&)>); + private: void registerConnection(Connection&); void unregisterConnection(Connection&); @@ -197,6 +199,8 @@ SWServerRegistration* registrationFromServiceWorkerIdentifier(ServiceWorkerIdentifier); void forEachClientForOrigin(const ClientOrigin&, const WTF::Function&); +void performGetOriginsWithRegistrationsCallbacks(); + enum TerminationMode { Synchronous, Asynchronous, @@ -231,6 +235,8 @@ Deque m_pendingContextDatas; HashMap> m_serviceWorkerRunRequests; PAL::SessionID m_sessionID; +bool m_importCompleted { false }; +Vector&)>>
[webkit-changes] [226002] trunk
Title: [226002] trunk Revision 226002 Author commit-qu...@webkit.org Date 2017-12-16 10:33:31 -0800 (Sat, 16 Dec 2017) Log Message [WinCairo] Move the destination of WinCairoRequirements.zip into WebKitLibraries and register it and related files as git ignore files. https://bugs.webkit.org/show_bug.cgi?id=180875 Patch by Basuke Suzuki on 2017-12-16 Reviewed by Alex Christensen. .: Add files extracted from WinCairoRequirements.zip * .gitignore: Tools: Bug fix. Specify the download destination correctly. * Scripts/update-webkit-wincairo-libs.py: Modified Paths trunk/.gitignore trunk/ChangeLog trunk/Tools/ChangeLog trunk/Tools/Scripts/update-webkit-wincairo-libs.py Diff Modified: trunk/.gitignore (226001 => 226002) --- trunk/.gitignore 2017-12-16 18:31:42 UTC (rev 226001) +++ trunk/.gitignore 2017-12-16 18:33:31 UTC (rev 226002) @@ -99,6 +99,13 @@ /WebKitLibraries/win/lib*/pthreadVC2.lib /WebKitLibraries/win/lib*/zdll.lib +# Ignore files installed by WinCairoRequirements +/WebKitLibraries/win/WinCairoRequirements.zip +/WebKitLibraries/win/WinCairoRequirements.zip.version +/WebKitLibraries/win/etc/ssl/ +/WebKitLibraries/win/include/ +/WebKitLibraries/win/tools/ + # Ignore files generated by Qt Creator: *.pro.user Modified: trunk/ChangeLog (226001 => 226002) --- trunk/ChangeLog 2017-12-16 18:31:42 UTC (rev 226001) +++ trunk/ChangeLog 2017-12-16 18:33:31 UTC (rev 226002) @@ -1,3 +1,13 @@ +2017-12-16 Basuke Suzuki + +[WinCairo] Move the destination of WinCairoRequirements.zip into WebKitLibraries and register it and related files as git ignore files. +https://bugs.webkit.org/show_bug.cgi?id=180875 + +Reviewed by Alex Christensen. + +Add files extracted from WinCairoRequirements.zip +* .gitignore: + 2017-12-14 Tomas Popela Build should fail early is needed Perl modules are not installed Modified: trunk/Tools/ChangeLog (226001 => 226002) --- trunk/Tools/ChangeLog 2017-12-16 18:31:42 UTC (rev 226001) +++ trunk/Tools/ChangeLog 2017-12-16 18:33:31 UTC (rev 226002) @@ -1,3 +1,14 @@ +2017-12-16 Basuke Suzuki + +[WinCairo] Move the destination of WinCairoRequirements.zip into WebKitLibraries and register it and related files as git ignore files. +https://bugs.webkit.org/show_bug.cgi?id=180875 + +Reviewed by Alex Christensen. + +Bug fix. Specify the download destination correctly. + +* Scripts/update-webkit-wincairo-libs.py: + 2017-12-16 Brent Fulgham Plugin processes are repeatedly spun up to do nothing Modified: trunk/Tools/Scripts/update-webkit-wincairo-libs.py (226001 => 226002) --- trunk/Tools/Scripts/update-webkit-wincairo-libs.py 2017-12-16 18:31:42 UTC (rev 226001) +++ trunk/Tools/Scripts/update-webkit-wincairo-libs.py 2017-12-16 18:33:31 UTC (rev 226002) @@ -33,7 +33,7 @@ file = 'WinCairoRequirements.zip' output = 'WebKitLibraries/win' -result = download.main([repo, file]) +result = download.main(['-o', output, repo, file]) # Only unzip if required if result == download.Status.DOWNLOADED: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [226001] trunk/LayoutTests/imported/w3c
Title: [226001] trunk/LayoutTests/imported/w3c Revision 226001 Author jiewen_...@apple.com Date 2017-12-16 10:31:42 -0800 (Sat, 16 Dec 2017) Log Message [CredentialManagement] Import Credential Management Web Platform Tests https://bugs.webkit.org/show_bug.cgi?id=172015 Reviewed by Youenn Fablet. * resources/import-expectations.json: * web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt: Added. * web-platform-tests/credential-management/credentialscontainer-create-basics.https.html: Added. * web-platform-tests/credential-management/idl.https-expected.txt: Added. * web-platform-tests/credential-management/idl.https.html: Added. * web-platform-tests/credential-management/w3c-import.log: Added. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/resources/import-expectations.json Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/ trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https.html trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/idl.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/idl.https.html trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/w3c-import.log Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226000 => 226001) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-16 18:20:04 UTC (rev 226000) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-16 18:31:42 UTC (rev 226001) @@ -1,3 +1,18 @@ +2017-12-16 Jiewen Tan + +[CredentialManagement] Import Credential Management Web Platform Tests +https://bugs.webkit.org/show_bug.cgi?id=172015 + + +Reviewed by Youenn Fablet. + +* resources/import-expectations.json: +* web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt: Added. +* web-platform-tests/credential-management/credentialscontainer-create-basics.https.html: Added. +* web-platform-tests/credential-management/idl.https-expected.txt: Added. +* web-platform-tests/credential-management/idl.https.html: Added. +* web-platform-tests/credential-management/w3c-import.log: Added. + 2017-12-16 Chris Dumez Add optimization when updating a SW registration results in the exact same script Modified: trunk/LayoutTests/imported/w3c/resources/import-expectations.json (226000 => 226001) --- trunk/LayoutTests/imported/w3c/resources/import-expectations.json 2017-12-16 18:20:04 UTC (rev 226000) +++ trunk/LayoutTests/imported/w3c/resources/import-expectations.json 2017-12-16 18:31:42 UTC (rev 226001) @@ -45,7 +45,7 @@ "web-platform-tests/cookies": "skip", "web-platform-tests/core-aam": "skip", "web-platform-tests/cors": "import", -"web-platform-tests/credential-management": "skip", +"web-platform-tests/credential-management": "import", "web-platform-tests/css": "skip", "web-platform-tests/css-backgrounds": "skip", "web-platform-tests/css-cascade": "skip", Added: trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt (0 => 226001) --- trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt 2017-12-16 18:31:42 UTC (rev 226001) @@ -0,0 +1,17 @@ + +FAIL navigator.credentials.create() with no argument. undefined is not an object (evaluating 'navigator.credentials.create') +FAIL navigator.credentials.create() with empty argument. undefined is not an object (evaluating 'navigator.credentials.create') +FAIL navigator.credentials.create() with valid PasswordCredentialData undefined is not an object (evaluating 'navigator.credentials.create') +FAIL navigator.credentials.create() with valid HTMLFormElement undefined is not an object (evaluating 'navigator.credentials.create') +FAIL navigator.credentials.create() with bogus password data undefined is not an object (evaluating 'navigator.credentials.create') +FAIL navigator.credentials.create() with valid FederatedCredentialData undefined is not an object (evaluating 'navigator.credentials.create') +FAIL navigator.credentials.create() with bogus federated data undefined is not an object (evaluating 'navigator.credentials.create') +FAIL navigator.credentials.create() with bogus publicKey data undefined is not an object (evaluating 'navigator.credentials.create') +FAIL navigator.credentials.create() returns PublicKeyCredential undefined is not an object (evaluating 'navigator.credential
[webkit-changes] [226000] trunk/Source/JavaScriptCore
Title: [226000] trunk/Source/_javascript_Core Revision 226000 Author keith_mil...@apple.com Date 2017-12-16 10:20:04 -0800 (Sat, 16 Dec 2017) Log Message Indexing should only be computed when the new structure has an indexing header. https://bugs.webkit.org/show_bug.cgi?id=180895 Reviewed by Saam Barati. If we don't have an indexing header then we point the butterfly sizeof(IndexingHeader) past the end of the butterfly. This makes the computation of the offset simpler since it doesn't depend on the indexing headeriness of the butterfly. * jit/JITOperations.cpp: * runtime/JSObject.cpp: (JSC::JSObject::createInitialUndecided): (JSC::JSObject::createInitialInt32): (JSC::JSObject::createInitialDouble): (JSC::JSObject::createInitialContiguous): (JSC::JSObject::createArrayStorage): (JSC::JSObject::convertUndecidedToArrayStorage): (JSC::JSObject::convertInt32ToArrayStorage): (JSC::JSObject::convertDoubleToArrayStorage): * runtime/JSObject.h: (JSC::JSObject::setButterfly): (JSC::JSObject::nukeStructureAndSetButterfly): * runtime/JSObjectInlines.h: (JSC::JSObject::prepareToPutDirectWithoutTransition): (JSC::JSObject::putDirectInternal): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/jit/JITOperations.cpp trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/JSObject.h trunk/Source/_javascript_Core/runtime/JSObjectInlines.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (225999 => 226000) --- trunk/Source/_javascript_Core/ChangeLog 2017-12-16 17:57:09 UTC (rev 225999) +++ trunk/Source/_javascript_Core/ChangeLog 2017-12-16 18:20:04 UTC (rev 226000) @@ -1,3 +1,32 @@ +2017-12-16 Keith Miller + +Indexing should only be computed when the new structure has an indexing header. +https://bugs.webkit.org/show_bug.cgi?id=180895 + +Reviewed by Saam Barati. + +If we don't have an indexing header then we point the butterfly +sizeof(IndexingHeader) past the end of the butterfly. This makes +the computation of the offset simpler since it doesn't depend on +the indexing headeriness of the butterfly. + +* jit/JITOperations.cpp: +* runtime/JSObject.cpp: +(JSC::JSObject::createInitialUndecided): +(JSC::JSObject::createInitialInt32): +(JSC::JSObject::createInitialDouble): +(JSC::JSObject::createInitialContiguous): +(JSC::JSObject::createArrayStorage): +(JSC::JSObject::convertUndecidedToArrayStorage): +(JSC::JSObject::convertInt32ToArrayStorage): +(JSC::JSObject::convertDoubleToArrayStorage): +* runtime/JSObject.h: +(JSC::JSObject::setButterfly): +(JSC::JSObject::nukeStructureAndSetButterfly): +* runtime/JSObjectInlines.h: +(JSC::JSObject::prepareToPutDirectWithoutTransition): +(JSC::JSObject::putDirectInternal): + 2017-12-15 Ryan Haddad Unreviewed, rolling out r225941. Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (225999 => 226000) --- trunk/Source/_javascript_Core/jit/JITOperations.cpp 2017-12-16 17:57:09 UTC (rev 225999) +++ trunk/Source/_javascript_Core/jit/JITOperations.cpp 2017-12-16 18:20:04 UTC (rev 226000) @@ -2311,7 +2311,7 @@ ASSERT(!object->structure()->outOfLineCapacity()); Butterfly* result = object->allocateMoreOutOfLineStorage(vm, 0, initialOutOfLineCapacity); -object->nukeStructureAndSetButterfly(vm, object->structureID(), result); +object->nukeStructureAndSetButterfly(vm, object->structureID(), result, object->indexingType()); return reinterpret_cast(result); } @@ -2321,7 +2321,7 @@ NativeCallFrameTracer tracer(&vm, exec); Butterfly* result = object->allocateMoreOutOfLineStorage(vm, object->structure()->outOfLineCapacity(), newSize); -object->nukeStructureAndSetButterfly(vm, object->structureID(), result); +object->nukeStructureAndSetButterfly(vm, object->structureID(), result, object->indexingType()); return reinterpret_cast(result); } Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (225999 => 226000) --- trunk/Source/_javascript_Core/runtime/JSObject.cpp 2017-12-16 17:57:09 UTC (rev 225999) +++ trunk/Source/_javascript_Core/runtime/JSObject.cpp 2017-12-16 18:20:04 UTC (rev 226000) @@ -1040,7 +1040,7 @@ StructureID oldStructureID = this->structureID(); Structure* oldStructure = vm.getStructure(oldStructureID); Structure* newStructure = Structure::nonPropertyTransition(vm, oldStructure, NonPropertyTransition::AllocateUndecided); -nukeStructureAndSetButterfly(vm, oldStructureID, newButterfly); +nukeStructureAndSetButterfly(vm, oldStructureID, newButterfly, newStructure->indexingType()); setStructure(vm, newStructure); return newButterfly; } @@ -1055,7 +1055,7 @@ StructureID oldStructureID = this->structureID(); Structure* oldStructure = vm.getStructure(oldStructureID); Structure* newS
[webkit-changes] [225999] trunk
Title: [225999] trunk Revision 225999 Author bfulg...@apple.com Date 2017-12-16 09:57:09 -0800 (Sat, 16 Dec 2017) Log Message Plugin processes are repeatedly spun up to do nothing https://bugs.webkit.org/show_bug.cgi?id=180885 Reviewed by Geoffrey Garen. Source/WebKit: Tested by TestWebKitAPI. * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::removeData): Don't ask plugins to remove data when no websites are passed to the function. Tools: * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: (runTestWithWebsiteDataStore): Check that deleting website data did not trigger any plugin processes to start up. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm Diff Modified: trunk/Source/WebKit/ChangeLog (225998 => 225999) --- trunk/Source/WebKit/ChangeLog 2017-12-16 17:54:39 UTC (rev 225998) +++ trunk/Source/WebKit/ChangeLog 2017-12-16 17:57:09 UTC (rev 225999) @@ -1,3 +1,17 @@ +2017-12-16 Brent Fulgham + +Plugin processes are repeatedly spun up to do nothing +https://bugs.webkit.org/show_bug.cgi?id=180885 + + +Reviewed by Geoffrey Garen. + +Tested by TestWebKitAPI. + +* UIProcess/WebsiteData/WebsiteDataStore.cpp: +(WebKit::WebsiteDataStore::removeData): Don't ask plugins to remove data when no websites are +passed to the function. + 2017-12-15 Chris Dumez Support updating a service worker registration's updateViaCache flag Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (225998 => 225999) --- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2017-12-16 17:54:39 UTC (rev 225998) +++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2017-12-16 17:57:09 UTC (rev 225999) @@ -1125,7 +1125,8 @@ Vector m_hostNames; }; -State::deleteData(*callbackAggregator, plugins(), WTFMove(hostNames)); +if (!hostNames.isEmpty()) +State::deleteData(*callbackAggregator, plugins(), WTFMove(hostNames)); } #endif Modified: trunk/Tools/ChangeLog (225998 => 225999) --- trunk/Tools/ChangeLog 2017-12-16 17:54:39 UTC (rev 225998) +++ trunk/Tools/ChangeLog 2017-12-16 17:57:09 UTC (rev 225999) @@ -1,3 +1,15 @@ +2017-12-16 Brent Fulgham + +Plugin processes are repeatedly spun up to do nothing +https://bugs.webkit.org/show_bug.cgi?id=180885 + + +Reviewed by Geoffrey Garen. + +* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: +(runTestWithWebsiteDataStore): Check that deleting website data did not +trigger any plugin processes to start up. + 2017-12-16 Yusuke Suzuki Remove unnecessary boolean result of start() functions Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm (225998 => 225999) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm 2017-12-16 17:54:39 UTC (rev 225998) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm 2017-12-16 17:57:09 UTC (rev 225999) @@ -29,6 +29,7 @@ #import "TestNavigationDelegate.h" #import #import +#import #import #import #import @@ -71,6 +72,10 @@ TestWebKitAPI::Util::run(&gotFlag); gotFlag = false; +// Triggering removeData when we don't have plugin data to remove should not trigger the plugin process to launch. +id pool = [WKProcessPool _sharedProcessPool]; +EXPECT_EQ([pool _pluginProcessCount], static_cast(0)); + globalCookieStore = dataStore.httpCookieStore; RetainPtr observer1 = adoptNS([[CookieObserver alloc] init]); RetainPtr observer2 = adoptNS([[CookieObserver alloc] init]); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225998] trunk
Title: [225998] trunk Revision 225998 Author utatane@gmail.com Date 2017-12-16 09:54:39 -0800 (Sat, 16 Dec 2017) Log Message Remove unnecessary boolean result of start() functions https://bugs.webkit.org/show_bug.cgi?id=180856 Reviewed by Darin Adler. Source/WebCore: No behavior change. * Modules/webaudio/AsyncAudioDecoder.cpp: (WebCore::AsyncAudioDecoder::~AsyncAudioDecoder): * Modules/webdatabase/DatabaseContext.cpp: (WebCore::DatabaseContext::databaseThread): * Modules/webdatabase/DatabaseThread.cpp: (WebCore::DatabaseThread::start): Now `Thread::create` always succeeds (if it fails, WebKit crashes). DatabaseThread::start() now always returns true. So, we do not need to return bool. * Modules/webdatabase/DatabaseThread.h: * platform/network/curl/CurlDownload.cpp: (WebCore::CurlDownload::start): * platform/network/curl/CurlDownload.h: * platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::start): * platform/network/curl/ResourceHandleCurlDelegate.cpp: (WebCore::ResourceHandleCurlDelegate::start): * platform/network/curl/ResourceHandleCurlDelegate.h: Source/WebKitLegacy/win: It always returns true. * WebDownloadCurl.cpp: (WebDownload::start): Source/WTF: CrossThreadTaskHandler's Thread is just released without calling either `waitForCompletion` or `detach`. It means that this resource of the thread is not released. * benchmarks/ConditionSpeedTest.cpp: * wtf/CrossThreadTaskHandler.cpp: (WTF::CrossThreadTaskHandler::CrossThreadTaskHandler): * wtf/CrossThreadTaskHandler.h: Tools: * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/benchmarks/ConditionSpeedTest.cpp trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp trunk/Source/WTF/wtf/CrossThreadTaskHandler.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp trunk/Source/WebCore/Modules/webdatabase/DatabaseThread.cpp trunk/Source/WebCore/Modules/webdatabase/DatabaseThread.h trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp trunk/Source/WebCore/platform/network/curl/CurlDownload.h trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp trunk/Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp trunk/Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.h trunk/Source/WebKitLegacy/win/ChangeLog trunk/Source/WebKitLegacy/win/WebDownloadCurl.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WTF/ParkingLot.cpp Diff Modified: trunk/Source/WTF/ChangeLog (225997 => 225998) --- trunk/Source/WTF/ChangeLog 2017-12-16 16:37:11 UTC (rev 225997) +++ trunk/Source/WTF/ChangeLog 2017-12-16 17:54:39 UTC (rev 225998) @@ -1,3 +1,19 @@ +2017-12-16 Yusuke Suzuki + +Remove unnecessary boolean result of start() functions +https://bugs.webkit.org/show_bug.cgi?id=180856 + +Reviewed by Darin Adler. + +CrossThreadTaskHandler's Thread is just released without calling +either `waitForCompletion` or `detach`. It means that this resource +of the thread is not released. + +* benchmarks/ConditionSpeedTest.cpp: +* wtf/CrossThreadTaskHandler.cpp: +(WTF::CrossThreadTaskHandler::CrossThreadTaskHandler): +* wtf/CrossThreadTaskHandler.h: + 2017-12-14 David Kilzer Enable -Wstrict-prototypes for WebKit Modified: trunk/Source/WTF/benchmarks/ConditionSpeedTest.cpp (225997 => 225998) --- trunk/Source/WTF/benchmarks/ConditionSpeedTest.cpp 2017-12-16 16:37:11 UTC (rev 225997) +++ trunk/Source/WTF/benchmarks/ConditionSpeedTest.cpp 2017-12-16 17:54:39 UTC (rev 225998) @@ -89,14 +89,14 @@ ConditionType emptyCondition; ConditionType fullCondition; -Vector> consumerThreads; -Vector> producerThreads; +Vector> consumerThreads; +Vector> producerThreads; Vector received; LockType receivedLock; for (unsigned i = numConsumers; i--;) { -RefPtr thread = Thread::create( +consumerThreads.append(Thread::create( "Consumer thread", [&] () { for (;;) { @@ -123,12 +123,11 @@ received.append(result); } } -}); -consumerThreads.append(thread); +})); } for (unsigned i = numProducers; i--;) { -RefPtr thread = Thread::create( +producerThreads.append(Thread::create( "Producer Thread", [&] () { for (unsigned i = 0; i < numMessagesPerProducer; ++i) { @@ -147,11 +146,10 @@ } notify(emptyCondition, mustNotify); } -}); -producerThreads.append(thread); +})); } -for (RefPtr& thread : producerThreads) +for (auto& thread : producerThreads) thread->waitForCompletion(); { @@ -160,8 +158,8 @@ }
[webkit-changes] [225997] trunk
Title: [225997] trunk Revision 225997 Author cdu...@apple.com Date 2017-12-16 08:37:11 -0800 (Sat, 16 Dec 2017) Log Message Add optimization when updating a SW registration results in the exact same script https://bugs.webkit.org/show_bug.cgi?id=180891 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Rebaseline WPT test now that all checks are passing. * web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt: Source/WebCore: Add optimization when updating a SW registration results in the exact same script: - https://w3c.github.io/ServiceWorker/#update-algorithm (step 8) No new tests, rebaselined existing test. * workers/service/server/SWServerJobQueue.cpp: (WebCore::SWServerJobQueue::scriptFetchFinished): LayoutTests: * TestExpectations: Skip bad WPT test that is timing out for us and Firefox. I'll file an upstream PR to fix it. * http/tests/workers/service/controller-change.html: * http/tests/workers/service/registration-updateViaCache-all-importScripts.html: * http/tests/workers/service/registration-updateViaCache-all.html: * http/tests/workers/service/registration-updateViaCache-imports-importScripts.html: * http/tests/workers/service/registration-updateViaCache-none-importScripts.html: * http/tests/workers/service/registration-updateViaCache-none.html: * http/tests/workers/service/resources/self_registration_update-worker.js: Removed. * http/tests/workers/service/resources/self_registration_update-worker.php: Added. * http/tests/workers/service/resources/service-worker-fetch-worker.js: * http/tests/workers/service/resources/updating-fetch-worker.php: Added. * http/tests/workers/service/resources/updating-worker.php: Added. * http/tests/workers/service/self_registration_update.html: * http/tests/workers/service/service-worker-registration-gc-event.html: Undate WebKit-specific tests to reflect behavior change. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/http/tests/workers/service/controller-change.html trunk/LayoutTests/http/tests/workers/service/registration-updateViaCache-all-importScripts.html trunk/LayoutTests/http/tests/workers/service/registration-updateViaCache-all.html trunk/LayoutTests/http/tests/workers/service/registration-updateViaCache-imports-importScripts.html trunk/LayoutTests/http/tests/workers/service/registration-updateViaCache-none-importScripts.html trunk/LayoutTests/http/tests/workers/service/registration-updateViaCache-none.html trunk/LayoutTests/http/tests/workers/service/resources/service-worker-fetch-worker.js trunk/LayoutTests/http/tests/workers/service/self_registration_update.html trunk/LayoutTests/http/tests/workers/service/service-worker-registration-gc-event.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp Added Paths trunk/LayoutTests/http/tests/workers/service/resources/self_registration_update-worker.php trunk/LayoutTests/http/tests/workers/service/resources/updating-fetch-worker.php trunk/LayoutTests/http/tests/workers/service/resources/updating-worker.php Removed Paths trunk/LayoutTests/http/tests/workers/service/resources/self_registration_update-worker.js Diff Modified: trunk/LayoutTests/ChangeLog (225996 => 225997) --- trunk/LayoutTests/ChangeLog 2017-12-16 09:26:39 UTC (rev 225996) +++ trunk/LayoutTests/ChangeLog 2017-12-16 16:37:11 UTC (rev 225997) @@ -1,3 +1,29 @@ +2017-12-16 Chris Dumez + +Add optimization when updating a SW registration results in the exact same script +https://bugs.webkit.org/show_bug.cgi?id=180891 + +Reviewed by Geoffrey Garen. + +* TestExpectations: +Skip bad WPT test that is timing out for us and Firefox. I'll file an upstream PR +to fix it. + +* http/tests/workers/service/controller-change.html: +* http/tests/workers/service/registration-updateViaCache-all-importScripts.html: +* http/tests/workers/service/registration-updateViaCache-all.html: +* http/tests/workers/service/registration-updateViaCache-imports-importScripts.html: +* http/tests/workers/service/registration-updateViaCache-none-importScripts.html: +* http/tests/workers/service/registration-updateViaCache-none.html: +* http/tests/workers/service/resources/self_registration_update-worker.js: Removed. +* http/tests/workers/service/resources/self_registration_update-worker.php: Added. +* http/tests/workers/service/resources/service-worker-fetch-worker.js: +* http/tests/workers/service/resources/updating-fetch-worker.php: Added. +* http/tests/workers/service/resources/updating-worker.php: Added. +* http/tests/workers/service/self_registration_update.html: +* http/tests/workers/servi
[webkit-changes] [225996] trunk
Title: [225996] trunk Revision 225996 Author commit-qu...@webkit.org Date 2017-12-16 01:26:39 -0800 (Sat, 16 Dec 2017) Log Message Service worker script fetch request should set the Service-Worker header https://bugs.webkit.org/show_bug.cgi?id=180889 Patch by Youenn Fablet on 2017-12-16 Reviewed by Chris Dumez. Source/WebCore: Test: http/wpt/service-workers/check-service-worker-header.https.html Update WorkerScriptLoader to take a request instead of an URL. Updates Worker implementation and use it in ServiceWorkerJob to set the missing request header. * workers/Worker.cpp: (WebCore::Worker::create): * workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadAsynchronously): * workers/WorkerScriptLoader.h: * workers/service/ServiceWorkerJob.cpp: (WebCore::ServiceWorkerJob::fetchScriptWithContext): LayoutTests: * http/wpt/service-workers/check-service-worker-header.https-expected.txt: Added. * http/wpt/service-workers/check-service-worker-header.https.html: Added. * http/wpt/service-workers/check-service-worker-header.py: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/Worker.cpp trunk/Source/WebCore/workers/WorkerScriptLoader.cpp trunk/Source/WebCore/workers/WorkerScriptLoader.h trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp Added Paths trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.https-expected.txt trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.https.html trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.py Diff Modified: trunk/LayoutTests/ChangeLog (225995 => 225996) --- trunk/LayoutTests/ChangeLog 2017-12-16 07:22:28 UTC (rev 225995) +++ trunk/LayoutTests/ChangeLog 2017-12-16 09:26:39 UTC (rev 225996) @@ -1,3 +1,14 @@ +2017-12-16 Youenn Fablet + +Service worker script fetch request should set the Service-Worker header +https://bugs.webkit.org/show_bug.cgi?id=180889 + +Reviewed by Chris Dumez. + +* http/wpt/service-workers/check-service-worker-header.https-expected.txt: Added. +* http/wpt/service-workers/check-service-worker-header.https.html: Added. +* http/wpt/service-workers/check-service-worker-header.py: Added. + 2017-12-15 Youenn Fablet WK1 webrtc/datachannel bufferedAmount tests might time out Added: trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.https-expected.txt (0 => 225996) --- trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.https-expected.txt (rev 0) +++ trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.https-expected.txt 2017-12-16 09:26:39 UTC (rev 225996) @@ -0,0 +1,3 @@ + +PASS Testing loading service worker script with the correct Service-Worker header + Added: trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.https.html (0 => 225996) --- trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.https.html (rev 0) +++ trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.https.html 2017-12-16 09:26:39 UTC (rev 225996) @@ -0,0 +1,9 @@ + +Service Worker Fetch Event + +promise_test(async (test) => { +return navigator.serviceWorker.register("check-service-worker-header.py", { scope: "/" }) +}, "Testing loading service worker script with the correct Service-Worker header"); + Added: trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.py (0 => 225996) --- trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.py (rev 0) +++ trunk/LayoutTests/http/wpt/service-workers/check-service-worker-header.py 2017-12-16 09:26:39 UTC (rev 225996) @@ -0,0 +1,5 @@ +def main(request, response): + +service_worker_header_value = request.headers.get("Service-Worker") +code = 200 if service_worker_header_value == "script" else 404 +return code, [("Content-Type", "application/_javascript_")], "" Modified: trunk/Source/WebCore/ChangeLog (225995 => 225996) --- trunk/Source/WebCore/ChangeLog 2017-12-16 07:22:28 UTC (rev 225995) +++ trunk/Source/WebCore/ChangeLog 2017-12-16 09:26:39 UTC (rev 225996) @@ -1,3 +1,23 @@ +2017-12-16 Youenn Fablet + +Service worker script fetch request should set the Service-Worker header +https://bugs.webkit.org/show_bug.cgi?id=180889 + +Reviewed by Chris Dumez. + +Test: http/wpt/service-workers/check-service-worker-header.https.html + +Update WorkerScriptLoader to take a request instead of an URL. +Updates Worker implementation and use it in ServiceWorkerJob to set the missing request header. + +* workers/Worker.cpp: +(WebCore::Worker::create): +* workers/WorkerScriptLoader.cpp: +(WebCore::WorkerScriptLoader::loadAsynchronously): +* workers/WorkerScriptLoader.h: +* workers/service/ServiceWorkerJob.c