[webkit-changes] [230100] trunk

[graouts]

Title: [230100] trunk








Revision 230100
Author grao...@webkit.org
Date 2018-03-29 22:41:47 -0700 (Thu, 29 Mar 2018)


Log Message
[Web Animations] Correctly obtain the timing function for a given keyframe
https://bugs.webkit.org/show_bug.cgi?id=184146

Reviewed by Dean Jackson.

Source/WebCore:

The way we would get the timing function for a given KeyframeValue stored in a KeyframeList was really suboptimal.
When keyframes were created, we would set the animated element's style on each keyframe, and set keyframe-specific
properties and values on top. When figuring out the timing function for a KeyframeValue, we would look at its render
style, go through its list of animations, which could include animations that are irrelevant to this specific keyframe
list since all animations from the animated element are referenced, and we would have to look up the correct animation
by name and get the timing function, even though the timing function stored on the animation was now specific to this
particular keyframe.

We now simply set a m_timingFunction member on a KeyframeValue, which is null if no explicit animation-timing-function
was provided for this keyframe in CSS, and otherwise set to a valid TimingFunction.

This fixes our behavior for a 4 existing animation tests when opted into the CSS Animations and CSS Transitions as
Web Animations feature.

* animation/KeyframeEffectReadOnly.cpp:
(WebCore::KeyframeEffectReadOnly::timingFunctionForKeyframeAtIndex):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::keyframeStylesForAnimation):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty const):
* platform/animation/TimingFunction.cpp:
(WebCore::TimingFunction::createFromCSSText):
(WebCore::TimingFunction::createFromCSSValue):
* platform/animation/TimingFunction.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
* rendering/style/KeyframeList.cpp:
(WebCore::KeyframeValue::timingFunction const): Deleted.
* rendering/style/KeyframeList.h:
(WebCore::KeyframeValue::timingFunction const):
(WebCore::KeyframeValue::setTimingFunction):

LayoutTests:

Make 4 tests opt into CSS Animations and CSS Transitions as Web Animations.

* animations/keyframe-timing-functions-transform.html:
* animations/keyframe-timing-functions.html:
* animations/keyframe-timing-functions2.html:
* animations/missing-keyframe-properties-timing-function.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/keyframe-timing-functions-transform.html
trunk/LayoutTests/animations/keyframe-timing-functions.html
trunk/LayoutTests/animations/keyframe-timing-functions2.html
trunk/LayoutTests/animations/missing-keyframe-properties-timing-function.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp
trunk/Source/WebCore/platform/animation/TimingFunction.cpp
trunk/Source/WebCore/platform/animation/TimingFunction.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/style/KeyframeList.cpp
trunk/Source/WebCore/rendering/style/KeyframeList.h




Diff

Modified: trunk/LayoutTests/ChangeLog (230099 => 230100)

--- trunk/LayoutTests/ChangeLog	2018-03-30 05:33:17 UTC (rev 230099)
+++ trunk/LayoutTests/ChangeLog	2018-03-30 05:41:47 UTC (rev 230100)
@@ -1,3 +1,17 @@
+2018-03-29  Antoine Quint  
+
+[Web Animations] Correctly obtain the timing function for a given keyframe
+https://bugs.webkit.org/show_bug.cgi?id=184146
+
+Reviewed by Dean Jackson.
+
+Make 4 tests opt into CSS Animations and CSS Transitions as Web Animations.
+
+* animations/keyframe-timing-functions-transform.html:
+* animations/keyframe-timing-functions.html:
+* animations/keyframe-timing-functions2.html:
+* animations/missing-keyframe-properties-timing-function.html:
+
 2018-03-29  Ryan Haddad  
 
 Unreviewed, rolling out r230087.


Modified: trunk/LayoutTests/animations/keyframe-timing-functions-transform.html (230099 => 230100)

--- trunk/LayoutTests/animations/keyframe-timing-functions-transform.html	2018-03-30 05:33:17 UTC (rev 230099)
+++ trunk/LayoutTests/animations/keyframe-timing-functions-transform.html	2018-03-30 05:41:47 UTC (rev 230100)
@@ -1,4 +1,4 @@
-
+
 
 
 


Modified: trunk/LayoutTests/animations/keyframe-timing-functions.html (230099 => 230100)

--- trunk/LayoutTests/animations/keyframe-timing-functions.html	2018-03-30 05:33:17 UTC (rev 230099)
+++ trunk/LayoutTests/animations/keyframe-timing-functions.html	2018-03-30 05:41:47 UTC (rev 230100)
@@ -1,5 +1,4 @@
-
+
 
 
 


Modified: trunk/LayoutTests/animations/keyframe-timing-functions2.html (230099 => 230100)

--- trunk/LayoutTests/animations/keyframe-timing-functions2.html	2018-03-30 05:33:17 UTC (rev 230099)
+++ 

[webkit-changes] [230099] trunk

[rniwa]

Title: [230099] trunk








Revision 230099
Author rn...@webkit.org
Date 2018-03-29 22:33:17 -0700 (Thu, 29 Mar 2018)


Log Message
Copying a list from Microsoft Word to TinyMCE fails when mso-list is on tags other than P
https://bugs.webkit.org/show_bug.cgi?id=182954


Reviewed by Wenson Hsieh.

Source/WebCore:

Fixed the bug by relaxing the restriction that we only preserve mso-list on p.

Tests: PasteHTML.PreservesMSOListOnH4

* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::shouldPreserveMSOListStyleForElement):

Tools:

Added a test case for a HTML generated by Microsoft Word which sets mso-list on h4.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
* TestWebKitAPI/Tests/WebKitCocoa/mso-list-compat-mode.html: Fixed the file path.
* TestWebKitAPI/Tests/WebKitCocoa/mso-list-on-h4.html: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/markup.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/mso-list-compat-mode.html


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/mso-list-on-h4.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (230098 => 230099)

--- trunk/Source/WebCore/ChangeLog	2018-03-30 05:13:32 UTC (rev 230098)
+++ trunk/Source/WebCore/ChangeLog	2018-03-30 05:33:17 UTC (rev 230099)
@@ -1,3 +1,18 @@
+2018-03-29  Ryosuke Niwa  
+
+Copying a list from Microsoft Word to TinyMCE fails when mso-list is on tags other than P
+https://bugs.webkit.org/show_bug.cgi?id=182954
+
+
+Reviewed by Wenson Hsieh.
+
+Fixed the bug by relaxing the restriction that we only preserve mso-list on p.
+
+Tests: PasteHTML.PreservesMSOListOnH4
+
+* editing/markup.cpp:
+(WebCore::StyledMarkupAccumulator::shouldPreserveMSOListStyleForElement):
+
 2018-03-29  JF Bastien  
 
 Use Forward.h instead of forward-declaring WTF::String


Modified: trunk/Source/WebCore/editing/markup.cpp (230098 => 230099)

--- trunk/Source/WebCore/editing/markup.cpp	2018-03-30 05:13:32 UTC (rev 230098)
+++ trunk/Source/WebCore/editing/markup.cpp	2018-03-30 05:33:17 UTC (rev 230099)
@@ -425,7 +425,7 @@
 
 bool StyledMarkupAccumulator::shouldPreserveMSOListStyleForElement(const Element& element)
 {
-return m_inMSOList || (m_shouldPreserveMSOList && element.hasTagName(pTag) && element.getAttribute(styleAttr).contains(";mso-list:"));
+return m_inMSOList || (m_shouldPreserveMSOList && element.getAttribute(styleAttr).contains(";mso-list:"));
 }
 
 void StyledMarkupAccumulator::appendElement(StringBuilder& out, const Element& element, bool addDisplayInline, RangeFullySelectsNode rangeFullySelectsNode)


Modified: trunk/Tools/ChangeLog (230098 => 230099)

--- trunk/Tools/ChangeLog	2018-03-30 05:13:32 UTC (rev 230098)
+++ trunk/Tools/ChangeLog	2018-03-30 05:33:17 UTC (rev 230099)
@@ -1,3 +1,18 @@
+2018-03-29  Ryosuke Niwa  
+
+Copying a list from Microsoft Word to TinyMCE fails when mso-list is on tags other than P
+https://bugs.webkit.org/show_bug.cgi?id=182954
+
+
+Reviewed by Wenson Hsieh.
+
+Added a test case for a HTML generated by Microsoft Word which sets mso-list on h4.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
+* TestWebKitAPI/Tests/WebKitCocoa/mso-list-compat-mode.html: Fixed the file path.
+* TestWebKitAPI/Tests/WebKitCocoa/mso-list-on-h4.html: Added.
+
 2018-03-29  Ross Kirsling  
 
 run-jsc-benchmarks should recognize Windows-style build directory structure.


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (230098 => 230099)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2018-03-30 05:13:32 UTC (rev 230098)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2018-03-30 05:33:17 UTC (rev 230099)
@@ -594,6 +594,7 @@
 		9B7A37C41F8AEBA5004AA228 /* CopyURL.mm in Sources */ = {isa = PBXBuildFile; fileRef = 9B7A37C21F8AEBA5004AA228 /* CopyURL.mm */; };
 		9B7D740F1F8378770006C432 /* paste-rtfd.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 9B7D740E1F8377E60006C432 /* paste-rtfd.html */; };
 		9BCB7C282013063E7C0C /* PasteHTML.mm in Sources */ = {isa = PBXBuildFile; fileRef = 9BCB7C262013063E7C0C /* PasteHTML.mm */; };
+		9BCD411A206DBCA3001D71BE /* mso-list-on-h4.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 9BCD4119206D5ED7001D71BE /* mso-list-on-h4.html */; };
 		9BD4239A1E04BD9800200395 /* AttributedSubstringForProposedRangeWithImage.mm in Sources */ = {isa = PBXBuildFile; fileRef = 9BD423991E04BD9800200395 /* AttributedSubstringForProposedRangeWithImage.mm */; };
 		

[webkit-changes] [230098] trunk/Source/JavaScriptCore

[mark . lam]

Title: [230098] trunk/Source/_javascript_Core








Revision 230098
Author mark@apple.com
Date 2018-03-29 22:13:32 -0700 (Thu, 29 Mar 2018)


Log Message
Add some pointer profiling support to B3 and Air.
https://bugs.webkit.org/show_bug.cgi?id=184165


Reviewed by JF Bastien.

* b3/B3LowerMacros.cpp:
* b3/B3LowerMacrosAfterOptimizations.cpp:
* b3/B3MathExtras.cpp:
* b3/B3ReduceStrength.cpp:
* b3/air/AirCCallSpecial.cpp:
(JSC::B3::Air::CCallSpecial::generate):
* b3/air/AirCCallSpecial.h:
* b3/testb3.cpp:
(JSC::B3::testCallSimple):
(JSC::B3::testCallRare):
(JSC::B3::testCallRareLive):
(JSC::B3::testCallSimplePure):
(JSC::B3::testCallFunctionWithHellaArguments):
(JSC::B3::testCallFunctionWithHellaArguments2):
(JSC::B3::testCallFunctionWithHellaArguments3):
(JSC::B3::testCallSimpleDouble):
(JSC::B3::testCallSimpleFloat):
(JSC::B3::testCallFunctionWithHellaDoubleArguments):
(JSC::B3::testCallFunctionWithHellaFloatArguments):
(JSC::B3::testLinearScanWithCalleeOnStack):
(JSC::B3::testInterpreter):
(JSC::B3::testLICMPure):
(JSC::B3::testLICMPureSideExits):
(JSC::B3::testLICMPureWritesPinned):
(JSC::B3::testLICMPureWrites):
(JSC::B3::testLICMReadsLocalState):
(JSC::B3::testLICMReadsPinned):
(JSC::B3::testLICMReads):
(JSC::B3::testLICMPureNotBackwardsDominant):
(JSC::B3::testLICMPureFoiledByChild):
(JSC::B3::testLICMPureNotBackwardsDominantFoiledByChild):
(JSC::B3::testLICMExitsSideways):
(JSC::B3::testLICMWritesLocalState):
(JSC::B3::testLICMWrites):
(JSC::B3::testLICMFence):
(JSC::B3::testLICMWritesPinned):
(JSC::B3::testLICMControlDependent):
(JSC::B3::testLICMControlDependentNotBackwardsDominant):
(JSC::B3::testLICMControlDependentSideExits):
(JSC::B3::testLICMReadsPinnedWritesPinned):
(JSC::B3::testLICMReadsWritesDifferentHeaps):
(JSC::B3::testLICMReadsWritesOverlappingHeaps):
(JSC::B3::testLICMDefaultCall):
(JSC::B3::testShuffleDoesntTrashCalleeSaves):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
* jit/GPRInfo.h:
* runtime/PtrTag.h:
* wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3LowerMacros.cpp
trunk/Source/_javascript_Core/b3/B3LowerMacrosAfterOptimizations.cpp
trunk/Source/_javascript_Core/b3/B3MathExtras.cpp
trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp
trunk/Source/_javascript_Core/b3/air/AirCCallSpecial.cpp
trunk/Source/_javascript_Core/b3/air/AirCCallSpecial.h
trunk/Source/_javascript_Core/b3/testb3.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/GPRInfo.h
trunk/Source/_javascript_Core/runtime/PtrTag.h
trunk/Source/_javascript_Core/wasm/WasmBinding.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230097 => 230098)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-30 05:05:15 UTC (rev 230097)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-30 05:13:32 UTC (rev 230098)
@@ -1,3 +1,64 @@
+2018-03-29  Mark Lam  
+
+Add some pointer profiling support to B3 and Air.
+https://bugs.webkit.org/show_bug.cgi?id=184165
+
+
+Reviewed by JF Bastien.
+
+* b3/B3LowerMacros.cpp:
+* b3/B3LowerMacrosAfterOptimizations.cpp:
+* b3/B3MathExtras.cpp:
+* b3/B3ReduceStrength.cpp:
+* b3/air/AirCCallSpecial.cpp:
+(JSC::B3::Air::CCallSpecial::generate):
+* b3/air/AirCCallSpecial.h:
+* b3/testb3.cpp:
+(JSC::B3::testCallSimple):
+(JSC::B3::testCallRare):
+(JSC::B3::testCallRareLive):
+(JSC::B3::testCallSimplePure):
+(JSC::B3::testCallFunctionWithHellaArguments):
+(JSC::B3::testCallFunctionWithHellaArguments2):
+(JSC::B3::testCallFunctionWithHellaArguments3):
+(JSC::B3::testCallSimpleDouble):
+(JSC::B3::testCallSimpleFloat):
+(JSC::B3::testCallFunctionWithHellaDoubleArguments):
+(JSC::B3::testCallFunctionWithHellaFloatArguments):
+(JSC::B3::testLinearScanWithCalleeOnStack):
+(JSC::B3::testInterpreter):
+(JSC::B3::testLICMPure):
+(JSC::B3::testLICMPureSideExits):
+(JSC::B3::testLICMPureWritesPinned):
+(JSC::B3::testLICMPureWrites):
+(JSC::B3::testLICMReadsLocalState):
+(JSC::B3::testLICMReadsPinned):
+(JSC::B3::testLICMReads):
+(JSC::B3::testLICMPureNotBackwardsDominant):
+(JSC::B3::testLICMPureFoiledByChild):
+(JSC::B3::testLICMPureNotBackwardsDominantFoiledByChild):
+(JSC::B3::testLICMExitsSideways):
+(JSC::B3::testLICMWritesLocalState):
+(JSC::B3::testLICMWrites):
+(JSC::B3::testLICMFence):
+(JSC::B3::testLICMWritesPinned):
+(JSC::B3::testLICMControlDependent):
+(JSC::B3::testLICMControlDependentNotBackwardsDominant):
+

[webkit-changes] [230097] trunk/Source

[jfbastien]

Title: [230097] trunk/Source








Revision 230097
Author jfbast...@apple.com
Date 2018-03-29 22:05:15 -0700 (Thu, 29 Mar 2018)


Log Message
Use Forward.h instead of forward-declaring WTF::String
https://bugs.webkit.org/show_bug.cgi?id=184172


Reviewed by Yusuke Suzuki.

As part of #184164 I'm changing WTF::String, and the forward
declarations are just wrong because I'm making it templated. We
should use Forward.h anyways, so do that instead.

Source/_javascript_Core:

* runtime/DateConversion.h:

Source/WebCore:

* css/makeprop.pl:
* platform/cocoa/PlaybackSessionInterface.h:
* platform/ios/Device.h:
* platform/ios/PlaybackSessionInterfaceAVKit.h:
* platform/ios/VideoFullscreenInterfaceAVKit.h:
* platform/win/PathWalker.h:
* testing/js/WebCoreTestSupport.h:

Source/WebKit:

* Scripts/webkit/LegacyMessages-expected.h:
* Scripts/webkit/Messages-expected.h:
* Scripts/webkit/MessagesSuperclass-expected.h:
* UIProcess/WebOpenPanelResultListenerProxy.h:

Source/WebKitLegacy/mac:

* WebView/WebScriptDebugger.h:

Source/WTF:

* wtf/Forward.h:
* wtf/HashTraits.h:
* wtf/PrintStream.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/DateConversion.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Forward.h
trunk/Source/WTF/wtf/HashTraits.h
trunk/Source/WTF/wtf/PrintStream.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h
trunk/Source/WebCore/platform/ios/Device.h
trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h
trunk/Source/WebCore/platform/win/PathWalker.h
trunk/Source/WebCore/testing/js/WebCoreTestSupport.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/LegacyMessages-expected.h
trunk/Source/WebKit/Scripts/webkit/Messages-expected.h
trunk/Source/WebKit/Scripts/webkit/MessagesSuperclass-expected.h
trunk/Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebScriptDebugger.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230096 => 230097)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,3 +1,17 @@
+2018-03-29  JF Bastien  
+
+Use Forward.h instead of forward-declaring WTF::String
+https://bugs.webkit.org/show_bug.cgi?id=184172
+
+
+Reviewed by Yusuke Suzuki.
+
+As part of #184164 I'm changing WTF::String, and the forward
+declarations are just wrong because I'm making it templated. We
+should use Forward.h anyways, so do that instead.
+
+* runtime/DateConversion.h:
+
 2018-03-29  Mark Lam  
 
 Use MacroAssemblerCodePtr in Wasm code for code pointers instead of void*.


Modified: trunk/Source/_javascript_Core/runtime/DateConversion.h (230096 => 230097)

--- trunk/Source/_javascript_Core/runtime/DateConversion.h	2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/_javascript_Core/runtime/DateConversion.h	2018-03-30 05:05:15 UTC (rev 230097)
@@ -24,12 +24,9 @@
 
 #pragma once
 
+#include 
 #include 
 
-namespace WTF {
-class String;
-} // namespace WTF
-
 namespace JSC {
 
 enum DateTimeFormat {


Modified: trunk/Source/WTF/ChangeLog (230096 => 230097)

--- trunk/Source/WTF/ChangeLog	2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WTF/ChangeLog	2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,3 +1,19 @@
+2018-03-29  JF Bastien  
+
+Use Forward.h instead of forward-declaring WTF::String
+https://bugs.webkit.org/show_bug.cgi?id=184172
+
+
+Reviewed by Yusuke Suzuki.
+
+As part of #184164 I'm changing WTF::String, and the forward
+declarations are just wrong because I'm making it templated. We
+should use Forward.h anyways, so do that instead.
+
+* wtf/Forward.h:
+* wtf/HashTraits.h:
+* wtf/PrintStream.h:
+
 2018-03-29  Yusuke Suzuki  
 
 Remove WTF_EXPORTDATA and JS_EXPORTDATA


Modified: trunk/Source/WTF/wtf/Forward.h (230096 => 230097)

--- trunk/Source/WTF/wtf/Forward.h	2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WTF/wtf/Forward.h	2018-03-30 05:05:15 UTC (rev 230097)
@@ -46,6 +46,7 @@
 class StringView;
 class TextPosition;
 class TextStream;
+class UniquedStringImpl;
 class WallTime;
 
 struct FastMalloc;


Modified: trunk/Source/WTF/wtf/HashTraits.h (230096 => 230097)

--- trunk/Source/WTF/wtf/HashTraits.h	2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WTF/wtf/HashTraits.h	2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2005-2018 Apple Inc. All rights reserved.
  *
  * This library is free software; 

[webkit-changes] [230096] trunk/Source/JavaScriptCore

[mark . lam]

Title: [230096] trunk/Source/_javascript_Core








Revision 230096
Author mark@apple.com
Date 2018-03-29 22:04:44 -0700 (Thu, 29 Mar 2018)


Log Message
Use MacroAssemblerCodePtr in Wasm code for code pointers instead of void*.
https://bugs.webkit.org/show_bug.cgi?id=184163


Reviewed by JF Bastien.

With the use of MacroAssemblerCodePtr, we now get poisoning for Wasm code pointers.

Also renamed some structs, methods, and variable names to be more accurate.
Previously, there is some confusion between a code pointer and the address of a
code pointer (sometimes referred to in the code as a "LoadLocation").  We now name
the LoadLocation variables appropriately to distinguish them from code pointers.

* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addCall):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
* wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):
* wasm/WasmCodeBlock.cpp:
(JSC::Wasm::CodeBlock::CodeBlock):
* wasm/WasmCodeBlock.h:
(JSC::Wasm::CodeBlock::entrypointLoadLocationFromFunctionIndexSpace):
(JSC::Wasm::CodeBlock::wasmEntrypointLoadLocationFromFunctionIndexSpace): Deleted.
* wasm/WasmFormat.h:
(JSC::Wasm::WasmToWasmImportableFunction::WasmToWasmImportableFunction):
(JSC::Wasm::WasmToWasmImportableFunction::offsetOfEntrypointLoadLocation):
(JSC::Wasm::CallableFunction::CallableFunction): Deleted.
(JSC::Wasm::CallableFunction::offsetOfWasmEntrypointLoadLocation): Deleted.
* wasm/WasmInstance.h:
(JSC::Wasm::Instance::offsetOfWasmEntrypointLoadLocation):
(JSC::Wasm::Instance::offsetOfWasmToEmbedderStub):
(JSC::Wasm::Instance::offsetOfWasmEntrypoint): Deleted.
(JSC::Wasm::Instance::offsetOfWasmToEmbedderStubExecutableAddress): Deleted.
* wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::work):
* wasm/WasmTable.cpp:
(JSC::Wasm::Table::Table):
(JSC::Wasm::Table::grow):
(JSC::Wasm::Table::clearFunction):
(JSC::Wasm::Table::setFunction):
* wasm/WasmTable.h:
(JSC::Wasm::Table::offsetOfFunctions):
* wasm/js/JSWebAssemblyCodeBlock.h:
* wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::finalizeCreation):
(JSC::JSWebAssemblyInstance::create):
* wasm/js/JSWebAssemblyTable.cpp:
(JSC::JSWebAssemblyTable::setFunction):
* wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::create):
(JSC::WebAssemblyFunction::WebAssemblyFunction):
* wasm/js/WebAssemblyFunction.h:
* wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):
* wasm/js/WebAssemblyWrapperFunction.cpp:
(JSC::WebAssemblyWrapperFunction::WebAssemblyWrapperFunction):
(JSC::WebAssemblyWrapperFunction::create):
* wasm/js/WebAssemblyWrapperFunction.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
trunk/Source/_javascript_Core/wasm/WasmBinding.cpp
trunk/Source/_javascript_Core/wasm/WasmCodeBlock.cpp
trunk/Source/_javascript_Core/wasm/WasmCodeBlock.h
trunk/Source/_javascript_Core/wasm/WasmFormat.h
trunk/Source/_javascript_Core/wasm/WasmInstance.h
trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmTable.cpp
trunk/Source/_javascript_Core/wasm/WasmTable.h
trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyCodeBlock.h
trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyInstance.cpp
trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyTable.cpp
trunk/Source/_javascript_Core/wasm/js/WebAssemblyFunction.cpp
trunk/Source/_javascript_Core/wasm/js/WebAssemblyFunction.h
trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp
trunk/Source/_javascript_Core/wasm/js/WebAssemblyWrapperFunction.cpp
trunk/Source/_javascript_Core/wasm/js/WebAssemblyWrapperFunction.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230095 => 230096)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-30 04:45:21 UTC (rev 230095)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-30 05:04:44 UTC (rev 230096)
@@ -1,3 +1,65 @@
+2018-03-29  Mark Lam  
+
+Use MacroAssemblerCodePtr in Wasm code for code pointers instead of void*.
+https://bugs.webkit.org/show_bug.cgi?id=184163
+
+
+Reviewed by JF Bastien.
+
+With the use of MacroAssemblerCodePtr, we now get poisoning for Wasm code pointers.
+
+Also renamed some structs, methods, and variable names to be more accurate.
+Previously, there is some confusion between a code pointer and the address of a
+code pointer (sometimes referred to in the code as a "LoadLocation").  We now name
+the LoadLocation variables appropriately to distinguish them from code pointers.
+
+* wasm/WasmB3IRGenerator.cpp:
+(JSC::Wasm::B3IRGenerator::addCall):
+(JSC::Wasm::B3IRGenerator::addCallIndirect):
+* wasm/WasmBinding.cpp:
+(JSC::Wasm::wasmToWasm):
+* wasm/WasmCodeBlock.cpp:
+(JSC::Wasm::CodeBlock::CodeBlock):
+* wasm/WasmCodeBlock.h:
+(JSC::Wasm::CodeBlock::entrypointLoadLocationFromFunctionIndexSpace):

[webkit-changes] [230095] releases/Apple

[mitz]

Title: [230095] releases/Apple








Revision 230095
Author m...@apple.com
Date 2018-03-29 21:45:21 -0700 (Thu, 29 Mar 2018)


Log Message
Added a tag for Safari 11.1.

Added Paths

releases/Apple/Safari 11.1/
releases/Apple/Safari 11.1/ANGLE/
releases/Apple/Safari 11.1/_javascript_Core/
releases/Apple/Safari 11.1/WTF/
releases/Apple/Safari 11.1/WebCore/
releases/Apple/Safari 11.1/WebInspectorUI/
releases/Apple/Safari 11.1/WebKit/
releases/Apple/Safari 11.1/WebKitLegacy/
releases/Apple/Safari 11.1/bmalloc/
releases/Apple/Safari 11.1/libwebrtc/




Diff
Index: releases/Apple/Safari 11.1/ANGLE
===
--- tags/Safari-605.1.33.1.3/Source/ThirdParty/ANGLE	2018-03-30 04:45:16 UTC (rev 230094)
+++ releases/Apple/Safari 11.1/ANGLE	2018-03-30 04:45:21 UTC (rev 230095)

Property changes: releases/Apple/Safari 11.1/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/Safari 11.1/_javascript_Core
===
--- tags/Safari-605.1.33.1.3/Source/_javascript_Core	2018-03-30 04:45:16 UTC (rev 230094)
+++ releases/Apple/Safari 11.1/_javascript_Core	2018-03-30 04:45:21 UTC (rev 230095)

Property changes: releases/Apple/Safari 11.1/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/Safari 11.1/WTF
===
--- tags/Safari-605.1.33.1.3/Source/WTF	2018-03-30 04:45:16 UTC (rev 230094)
+++ releases/Apple/Safari 11.1/WTF	2018-03-30 04:45:21 UTC (rev 230095)

Property changes: releases/Apple/Safari 11.1/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/Safari 11.1/WebInspectorUI
===
--- tags/Safari-605.1.33.1.3/Source/WebInspectorUI	2018-03-30 04:45:16 UTC (rev 230094)
+++ releases/Apple/Safari 11.1/WebInspectorUI	2018-03-30 04:45:21 UTC (rev 230095)

Property changes: releases/Apple/Safari 11.1/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455
\ No newline at end of property
Index: releases/Apple/Safari 11.1/bmalloc
===
--- tags/Safari-605.1.33.1.3/Source/bmalloc	2018-03-30 04:45:16 UTC (rev 230094)
+++ releases/Apple/Safari 11.1/bmalloc	2018-03-30 04:45:21 UTC (rev 230095)

Property changes: releases/Apple/Safari 11.1/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property
Index: releases/Apple/Safari 11.1/libwebrtc
===
--- tags/Safari-605.1.33.1.3/Source/ThirdParty/libwebrtc	2018-03-30 04:45:16 UTC (rev 230094)
+++ releases/Apple/Safari 11.1/libwebrtc	2018-03-30 04:45:21 UTC (rev 230095)

Property changes: releases/Apple/Safari 11.1/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230094] releases/Apple

[mitz]

Title: [230094] releases/Apple








Revision 230094
Author m...@apple.com
Date 2018-03-29 21:45:16 -0700 (Thu, 29 Mar 2018)


Log Message
Added a tag for iOS 11.3.

Added Paths

releases/Apple/iOS 11.3/
releases/Apple/iOS 11.3/ANGLE/
releases/Apple/iOS 11.3/_javascript_Core/
releases/Apple/iOS 11.3/WTF/
releases/Apple/iOS 11.3/WebCore/
releases/Apple/iOS 11.3/WebKit/
releases/Apple/iOS 11.3/WebKitLegacy/
releases/Apple/iOS 11.3/bmalloc/
releases/Apple/iOS 11.3/libwebrtc/




Diff
Index: releases/Apple/iOS 11.3/ANGLE
===
--- tags/Safari-605.1.33.0.2/Source/ThirdParty/ANGLE	2018-03-30 04:35:07 UTC (rev 230093)
+++ releases/Apple/iOS 11.3/ANGLE	2018-03-30 04:45:16 UTC (rev 230094)

Property changes: releases/Apple/iOS 11.3/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/iOS 11.3/_javascript_Core
===
--- tags/Safari-605.1.33.0.2/Source/_javascript_Core	2018-03-30 04:35:07 UTC (rev 230093)
+++ releases/Apple/iOS 11.3/_javascript_Core	2018-03-30 04:45:16 UTC (rev 230094)

Property changes: releases/Apple/iOS 11.3/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/iOS 11.3/WTF
===
--- tags/Safari-605.1.33.0.2/Source/WTF	2018-03-30 04:35:07 UTC (rev 230093)
+++ releases/Apple/iOS 11.3/WTF	2018-03-30 04:45:16 UTC (rev 230094)

Property changes: releases/Apple/iOS 11.3/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/iOS 11.3/bmalloc
===
--- tags/Safari-605.1.33.0.2/Source/bmalloc	2018-03-30 04:35:07 UTC (rev 230093)
+++ releases/Apple/iOS 11.3/bmalloc	2018-03-30 04:45:16 UTC (rev 230094)

Property changes: releases/Apple/iOS 11.3/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property
Index: releases/Apple/iOS 11.3/libwebrtc
===
--- tags/Safari-605.1.33.0.2/Source/ThirdParty/libwebrtc	2018-03-30 04:35:07 UTC (rev 230093)
+++ releases/Apple/iOS 11.3/libwebrtc	2018-03-30 04:45:16 UTC (rev 230094)

Property changes: releases/Apple/iOS 11.3/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230093] trunk/Tools

[ross . kirsling]

Title: [230093] trunk/Tools








Revision 230093
Author ross.kirsl...@sony.com
Date 2018-03-29 21:35:07 -0700 (Thu, 29 Mar 2018)


Log Message
run-jsc-benchmarks should recognize Windows-style build directory structure.
https://bugs.webkit.org/show_bug.cgi?id=184117

Reviewed by Yusuke Suzuki.

* Scripts/run-jsc-benchmarks:
Allow not only bin/jsc but also bin64/jsc.exe.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-benchmarks




Diff

Modified: trunk/Tools/ChangeLog (230092 => 230093)

--- trunk/Tools/ChangeLog	2018-03-30 04:16:30 UTC (rev 230092)
+++ trunk/Tools/ChangeLog	2018-03-30 04:35:07 UTC (rev 230093)
@@ -1,3 +1,13 @@
+2018-03-29  Ross Kirsling  
+
+run-jsc-benchmarks should recognize Windows-style build directory structure.
+https://bugs.webkit.org/show_bug.cgi?id=184117
+
+Reviewed by Yusuke Suzuki.
+
+* Scripts/run-jsc-benchmarks:
+Allow not only bin/jsc but also bin64/jsc.exe.
+
 2018-03-29  Zalan Bujtas  
 
 [LayoutReloaded] Decouple formatting state and context lifetime.


Modified: trunk/Tools/Scripts/run-jsc-benchmarks (230092 => 230093)

--- trunk/Tools/Scripts/run-jsc-benchmarks	2018-03-30 04:16:30 UTC (rev 230092)
+++ trunk/Tools/Scripts/run-jsc-benchmarks	2018-03-30 04:35:07 UTC (rev 230093)
@@ -1342,10 +1342,10 @@
   @libPath, @relativeBinPath = [$~.pre_match+"/Release"], "./#{$1}"
 elsif @path =~ /\/Debug\/([a-zA-Z]+)$/
   @libPath, @relativeBinPath = [$~.pre_match+"/Debug"], "./#{$1}"
-elsif @path =~ /\/Release\/bin\/([a-zA-Z]+)$/
-  @libPath, @relativeBinPath = [$~.pre_match+"/Release/lib"], "./#{$1}"
-elsif @path =~ /\/Debug\/bin\/([a-zA-Z]+)$/
-  @libPath, @relativeBinPath = [$~.pre_match+"/Debug/lib"], "./#{$1}"
+elsif @path =~ /\/Release\/bin(64|32|)\/([\.a-zA-Z]+)$/
+  @libPath, @relativeBinPath = [$~.pre_match+"/Release/lib#{$1}"], "./#{$2}"
+elsif @path =~ /\/Debug\/bin(64|32|)\/([\.a-zA-Z]+)$/
+  @libPath, @relativeBinPath = [$~.pre_match+"/Debug/lib#{$1}"], "./#{$2}"
 elsif @path =~ /\/Contents\/Resources\/([a-zA-Z]+)$/
   @libPath = [$~.pre_match + "/Contents/Resources", $~.pre_match + "/Contents/Frameworks"]
 elsif @path =~ /\/_javascript_Core.framework\/Resources\/([a-zA-Z]+)$/






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230092] trunk/Source

[utatane . tea]

Title: [230092] trunk/Source








Revision 230092
Author utatane@gmail.com
Date 2018-03-29 21:16:30 -0700 (Thu, 29 Mar 2018)


Log Message
Remove WTF_EXPORTDATA and JS_EXPORTDATA
https://bugs.webkit.org/show_bug.cgi?id=184170

Reviewed by JF Bastien.

Replace WTF_EXPORTDATA and JS_EXPORTDATA with
WTF_EXPORT_PRIVATE and JS_EXPORT_PRIVATE respectively.

Source/_javascript_Core:

* heap/WriteBarrierSupport.h:
* jit/ExecutableAllocator.cpp:
* jit/ExecutableAllocator.h:
* runtime/JSCPoison.h:
* runtime/JSCell.h:
* runtime/JSExportMacros.h:
* runtime/JSGlobalObject.h:
* runtime/JSObject.h:
* runtime/Options.h:
* runtime/PropertyDescriptor.h:
* runtime/PropertyMapHashTable.h:
* runtime/SamplingCounter.h:

Source/WTF:

* wtf/ExportMacros.h:
* wtf/Gigacage.h:
* wtf/HashTable.h:
* wtf/Threading.h:
* wtf/text/AtomicString.cpp:
* wtf/text/AtomicString.h:
* wtf/text/StringImpl.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/WriteBarrierSupport.h
trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp
trunk/Source/_javascript_Core/jit/ExecutableAllocator.h
trunk/Source/_javascript_Core/runtime/JSCPoison.h
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSExportMacros.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Source/_javascript_Core/runtime/PropertyDescriptor.h
trunk/Source/_javascript_Core/runtime/PropertyMapHashTable.h
trunk/Source/_javascript_Core/runtime/SamplingCounter.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ExportMacros.h
trunk/Source/WTF/wtf/Gigacage.h
trunk/Source/WTF/wtf/HashTable.h
trunk/Source/WTF/wtf/Threading.h
trunk/Source/WTF/wtf/text/AtomicString.cpp
trunk/Source/WTF/wtf/text/AtomicString.h
trunk/Source/WTF/wtf/text/StringImpl.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230091 => 230092)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-30 02:47:34 UTC (rev 230091)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-30 04:16:30 UTC (rev 230092)
@@ -1,3 +1,26 @@
+2018-03-29  Yusuke Suzuki  
+
+Remove WTF_EXPORTDATA and JS_EXPORTDATA
+https://bugs.webkit.org/show_bug.cgi?id=184170
+
+Reviewed by JF Bastien.
+
+Replace WTF_EXPORTDATA and JS_EXPORTDATA with
+WTF_EXPORT_PRIVATE and JS_EXPORT_PRIVATE respectively.
+
+* heap/WriteBarrierSupport.h:
+* jit/ExecutableAllocator.cpp:
+* jit/ExecutableAllocator.h:
+* runtime/JSCPoison.h:
+* runtime/JSCell.h:
+* runtime/JSExportMacros.h:
+* runtime/JSGlobalObject.h:
+* runtime/JSObject.h:
+* runtime/Options.h:
+* runtime/PropertyDescriptor.h:
+* runtime/PropertyMapHashTable.h:
+* runtime/SamplingCounter.h:
+
 2018-03-29  Ross Kirsling  
 
 MSVC __forceinline slows down JSC release build fivefold after r229391


Modified: trunk/Source/_javascript_Core/heap/WriteBarrierSupport.h (230091 => 230092)

--- trunk/Source/_javascript_Core/heap/WriteBarrierSupport.h	2018-03-30 02:47:34 UTC (rev 230091)
+++ trunk/Source/_javascript_Core/heap/WriteBarrierSupport.h	2018-03-30 04:16:30 UTC (rev 230092)
@@ -80,8 +80,8 @@
 }
 #else
 // These are necessary to work around not having conditional exports.
-JS_EXPORTDATA static char usesWithBarrierFromCpp;
-JS_EXPORTDATA static char usesWithoutBarrierFromCpp;
+JS_EXPORT_PRIVATE static char usesWithBarrierFromCpp;
+JS_EXPORT_PRIVATE static char usesWithoutBarrierFromCpp;
 #endif // ENABLE(WRITE_BARRIER_PROFILING)
 
 static void countWriteBarrier()


Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp (230091 => 230092)

--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp	2018-03-30 02:47:34 UTC (rev 230091)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp	2018-03-30 04:16:30 UTC (rev 230092)
@@ -100,11 +100,11 @@
 static const double executablePoolReservationFraction = 0.25;
 #endif
 
-JS_EXPORTDATA uintptr_t startOfFixedExecutableMemoryPool;
-JS_EXPORTDATA uintptr_t endOfFixedExecutableMemoryPool;
-JS_EXPORTDATA bool useFastPermisionsJITCopy { false };
+JS_EXPORT_PRIVATE uintptr_t startOfFixedExecutableMemoryPool;
+JS_EXPORT_PRIVATE uintptr_t endOfFixedExecutableMemoryPool;
+JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy { false };
 
-JS_EXPORTDATA JITWriteSeparateHeapsFunction jitWriteSeparateHeapsFunction;
+JS_EXPORT_PRIVATE JITWriteSeparateHeapsFunction jitWriteSeparateHeapsFunction;
 
 #if !USE(EXECUTE_ONLY_JIT_WRITE_FUNCTION) && HAVE(REMAP_JIT)
 static uintptr_t startOfFixedWritableMemoryPool;


Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.h (230091 => 230092)

--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.h	2018-03-30 02:47:34 UTC (rev 230091)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.h	

[webkit-changes] [230091] trunk/Source

[ross . kirsling]

Title: [230091] trunk/Source








Revision 230091
Author ross.kirsl...@sony.com
Date 2018-03-29 19:47:34 -0700 (Thu, 29 Mar 2018)


Log Message
MSVC __forceinline slows down JSC release build fivefold after r229391
https://bugs.webkit.org/show_bug.cgi?id=184062

Reviewed by Alex Christensen.

Source/_javascript_Core:

* jit/CCallHelpers.h:
(JSC::CCallHelpers::marshallArgumentRegister):
Exempt MSVC from a single forced inline used within recursive templates.

Source/WebCore:

* platform/graphics/FormatConverter.cpp:
Factor ALWAYS_INLINE_EXCEPT_MSVC out to WTF.

Source/WTF:

* wtf/Compiler.h:
Add ALWAYS_INLINE_EXCEPT_MSVC to support MSVC optimizer sensitivities.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/CCallHelpers.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Compiler.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FormatConverter.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230090 => 230091)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-30 02:36:03 UTC (rev 230090)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-30 02:47:34 UTC (rev 230091)
@@ -1,3 +1,14 @@
+2018-03-29  Ross Kirsling  
+
+MSVC __forceinline slows down JSC release build fivefold after r229391
+https://bugs.webkit.org/show_bug.cgi?id=184062
+
+Reviewed by Alex Christensen.
+
+* jit/CCallHelpers.h:
+(JSC::CCallHelpers::marshallArgumentRegister):
+Exempt MSVC from a single forced inline used within recursive templates.
+
 2018-03-29  Keith Miller  
 
 ArrayMode should not try to get the DFG to think it can convert TypedArrays


Modified: trunk/Source/_javascript_Core/jit/CCallHelpers.h (230090 => 230091)

--- trunk/Source/_javascript_Core/jit/CCallHelpers.h	2018-03-30 02:36:03 UTC (rev 230090)
+++ trunk/Source/_javascript_Core/jit/CCallHelpers.h	2018-03-30 02:47:34 UTC (rev 230091)
@@ -295,8 +295,9 @@
 
 #if USE(JSVALUE64)
 
+// Avoid MSVC optimization time explosion associated with __forceinline in recursive templates.
 template
-ALWAYS_INLINE void marshallArgumentRegister(ArgCollection argSourceRegs, RegType arg, Args... args)
+ALWAYS_INLINE_EXCEPT_MSVC void marshallArgumentRegister(ArgCollection argSourceRegs, RegType arg, Args... args)
 {
 using InfoType = InfoTypeForReg;
 unsigned numArgRegisters = InfoType::numberOfArgumentRegisters;


Modified: trunk/Source/WTF/ChangeLog (230090 => 230091)

--- trunk/Source/WTF/ChangeLog	2018-03-30 02:36:03 UTC (rev 230090)
+++ trunk/Source/WTF/ChangeLog	2018-03-30 02:47:34 UTC (rev 230091)
@@ -1,3 +1,13 @@
+2018-03-29  Ross Kirsling  
+
+MSVC __forceinline slows down JSC release build fivefold after r229391
+https://bugs.webkit.org/show_bug.cgi?id=184062
+
+Reviewed by Alex Christensen.
+
+* wtf/Compiler.h:
+Add ALWAYS_INLINE_EXCEPT_MSVC to support MSVC optimizer sensitivities.
+
 2018-03-29  JF Bastien  
 
 Remove WTF_EXPORT_STRING_API


Modified: trunk/Source/WTF/wtf/Compiler.h (230090 => 230091)

--- trunk/Source/WTF/wtf/Compiler.h	2018-03-30 02:36:03 UTC (rev 230090)
+++ trunk/Source/WTF/wtf/Compiler.h	2018-03-30 02:47:34 UTC (rev 230091)
@@ -178,6 +178,12 @@
 #define ALWAYS_INLINE inline
 #endif
 
+#if COMPILER(MSVC)
+#define ALWAYS_INLINE_EXCEPT_MSVC inline
+#else
+#define ALWAYS_INLINE_EXCEPT_MSVC ALWAYS_INLINE
+#endif
+
 /* WTF_EXTERN_C_{BEGIN, END} */
 
 #ifdef __cplusplus


Modified: trunk/Source/WebCore/ChangeLog (230090 => 230091)

--- trunk/Source/WebCore/ChangeLog	2018-03-30 02:36:03 UTC (rev 230090)
+++ trunk/Source/WebCore/ChangeLog	2018-03-30 02:47:34 UTC (rev 230091)
@@ -1,3 +1,13 @@
+2018-03-29  Ross Kirsling  
+
+MSVC __forceinline slows down JSC release build fivefold after r229391
+https://bugs.webkit.org/show_bug.cgi?id=184062
+
+Reviewed by Alex Christensen.
+
+* platform/graphics/FormatConverter.cpp:
+Factor ALWAYS_INLINE_EXCEPT_MSVC out to WTF.
+
 2018-03-29  Ryan Haddad  
 
 Unreviewed, rolling out r230087.


Modified: trunk/Source/WebCore/platform/graphics/FormatConverter.cpp (230090 => 230091)

--- trunk/Source/WebCore/platform/graphics/FormatConverter.cpp	2018-03-30 02:36:03 UTC (rev 230090)
+++ trunk/Source/WebCore/platform/graphics/FormatConverter.cpp	2018-03-30 02:47:34 UTC (rev 230091)
@@ -35,13 +35,6 @@
 #include "GraphicsContext3DNEON.h"
 #endif
 
-// Visual Studio crashes with a C1063 Fatal Error if everything is inlined.
-#if COMPILER(MSVC)
-#define ALWAYS_INLINE_EXCEPT_MSVC
-#else
-#define ALWAYS_INLINE_EXCEPT_MSVC ALWAYS_INLINE
-#endif
-
 namespace WebCore {
 
 
@@ -1205,6 +1198,7 @@
 #undef 

[webkit-changes] [230090] trunk/Source/WTF

[jfbastien]

Title: [230090] trunk/Source/WTF








Revision 230090
Author jfbast...@apple.com
Date 2018-03-29 19:36:03 -0700 (Thu, 29 Mar 2018)


Log Message
Remove WTF_EXPORT_STRING_API
https://bugs.webkit.org/show_bug.cgi?id=184168


Reviewed by Yusuke Suzuki.

Remove WTF_EXPORT_STRING_API as requested by a FIXME, and use
WTF_EXPORT_PRIVATE instead.

* wtf/ExportMacros.h:
* wtf/text/AtomicString.h:
* wtf/text/AtomicStringImpl.h:
* wtf/text/StringImpl.h:
* wtf/text/StringView.h:
* wtf/text/SymbolImpl.h:
* wtf/text/WTFString.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ExportMacros.h
trunk/Source/WTF/wtf/text/AtomicString.h
trunk/Source/WTF/wtf/text/AtomicStringImpl.h
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/StringView.h
trunk/Source/WTF/wtf/text/SymbolImpl.h
trunk/Source/WTF/wtf/text/WTFString.h




Diff

Modified: trunk/Source/WTF/ChangeLog (230089 => 230090)

--- trunk/Source/WTF/ChangeLog	2018-03-30 01:24:00 UTC (rev 230089)
+++ trunk/Source/WTF/ChangeLog	2018-03-30 02:36:03 UTC (rev 230090)
@@ -1,3 +1,22 @@
+2018-03-29  JF Bastien  
+
+Remove WTF_EXPORT_STRING_API
+https://bugs.webkit.org/show_bug.cgi?id=184168
+
+
+Reviewed by Yusuke Suzuki.
+
+Remove WTF_EXPORT_STRING_API as requested by a FIXME, and use
+WTF_EXPORT_PRIVATE instead.
+
+* wtf/ExportMacros.h:
+* wtf/text/AtomicString.h:
+* wtf/text/AtomicStringImpl.h:
+* wtf/text/StringImpl.h:
+* wtf/text/StringView.h:
+* wtf/text/SymbolImpl.h:
+* wtf/text/WTFString.h:
+
 2018-03-29  Commit Queue  
 
 Unreviewed, rolling out r230062.


Modified: trunk/Source/WTF/wtf/ExportMacros.h (230089 => 230090)

--- trunk/Source/WTF/wtf/ExportMacros.h	2018-03-30 01:24:00 UTC (rev 230089)
+++ trunk/Source/WTF/wtf/ExportMacros.h	2018-03-30 02:36:03 UTC (rev 230090)
@@ -88,6 +88,5 @@
 
 #endif // USE(EXPORT_MACROS)
 
-// FIXME: We should replace WTF_EXPORTDATA and WTF_EXPORT_STRING_API with WTF_EXPORT_PRIVATE.
+// FIXME: We should replace WTF_EXPORTDATA and with WTF_EXPORT_PRIVATE.
 #define WTF_EXPORTDATA WTF_EXPORT_PRIVATE
-#define WTF_EXPORT_STRING_API WTF_EXPORT_PRIVATE


Modified: trunk/Source/WTF/wtf/text/AtomicString.h (230089 => 230090)

--- trunk/Source/WTF/wtf/text/AtomicString.h	2018-03-30 01:24:00 UTC (rev 230089)
+++ trunk/Source/WTF/wtf/text/AtomicString.h	2018-03-30 02:36:03 UTC (rev 230090)
@@ -104,11 +104,11 @@
 
 UChar operator[](unsigned int i) const { return m_string[i]; }
 
-WTF_EXPORT_STRING_API static AtomicString number(int);
-WTF_EXPORT_STRING_API static AtomicString number(unsigned);
-WTF_EXPORT_STRING_API static AtomicString number(unsigned long);
-WTF_EXPORT_STRING_API static AtomicString number(unsigned long long);
-WTF_EXPORT_STRING_API static AtomicString number(double);
+WTF_EXPORT_PRIVATE static AtomicString number(int);
+WTF_EXPORT_PRIVATE static AtomicString number(unsigned);
+WTF_EXPORT_PRIVATE static AtomicString number(unsigned long);
+WTF_EXPORT_PRIVATE static AtomicString number(unsigned long long);
+WTF_EXPORT_PRIVATE static AtomicString number(double);
 // If we need more overloads of the number function, we can add all the others that String has, but these seem to do for now.
 
 bool contains(UChar character) const { return m_string.contains(character); }
@@ -133,8 +133,8 @@
 bool endsWith(UChar character) const { return m_string.endsWith(character); }
 template bool endsWith(const char ()[matchLength]) const { return m_string.endsWith(prefix); }
 
-WTF_EXPORT_STRING_API AtomicString convertToASCIILowercase() const;
-WTF_EXPORT_STRING_API AtomicString convertToASCIIUppercase() const;
+WTF_EXPORT_PRIVATE AtomicString convertToASCIILowercase() const;
+WTF_EXPORT_PRIVATE AtomicString convertToASCIIUppercase() const;
 
 int toInt(bool* ok = 0) const { return m_string.toInt(ok); }
 double toDouble(bool* ok = 0) const { return m_string.toDouble(ok); }
@@ -168,7 +168,7 @@
 enum class CaseConvertType { Upper, Lower };
 template AtomicString convertASCIICase() const;
 
-WTF_EXPORT_STRING_API static AtomicString fromUTF8Internal(const char*, const char*);
+WTF_EXPORT_PRIVATE static AtomicString fromUTF8Internal(const char*, const char*);
 
 String m_string;
 };


Modified: trunk/Source/WTF/wtf/text/AtomicStringImpl.h (230089 => 230090)

--- trunk/Source/WTF/wtf/text/AtomicStringImpl.h	2018-03-30 01:24:00 UTC (rev 230089)
+++ trunk/Source/WTF/wtf/text/AtomicStringImpl.h	2018-03-30 02:36:03 UTC (rev 230090)
@@ -29,8 +29,8 @@
 
 class AtomicStringImpl : public UniquedStringImpl {
 public:
-WTF_EXPORT_STRING_API static RefPtr lookUp(const LChar*, unsigned length);
-WTF_EXPORT_STRING_API static RefPtr lookUp(const UChar*, unsigned length);
+WTF_EXPORT_PRIVATE static RefPtr lookUp(const LChar*, unsigned length);
+

[webkit-changes] [230089] trunk

[ryanhaddad]

Title: [230089] trunk








Revision 230089
Author ryanhad...@apple.com
Date 2018-03-29 18:24:00 -0700 (Thu, 29 Mar 2018)


Log Message
Unreviewed, rolling out r230087.

Introduced LayoutTest failures.

Reverted changeset:

"FrameSelection::appearanceUpdateTimerFired should be robust
against layout passes underneath it"
https://bugs.webkit.org/show_bug.cgi?id=183395
https://trac.webkit.org/changeset/230087

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp


Removed Paths

trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt
trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html




Diff

Modified: trunk/LayoutTests/ChangeLog (230088 => 230089)

--- trunk/LayoutTests/ChangeLog	2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/LayoutTests/ChangeLog	2018-03-30 01:24:00 UTC (rev 230089)
@@ -1,3 +1,16 @@
+2018-03-29  Ryan Haddad  
+
+Unreviewed, rolling out r230087.
+
+Introduced LayoutTest failures.
+
+Reverted changeset:
+
+"FrameSelection::appearanceUpdateTimerFired should be robust
+against layout passes underneath it"
+https://bugs.webkit.org/show_bug.cgi?id=183395
+https://trac.webkit.org/changeset/230087
+
 2018-03-29  Wenson Hsieh  
 
 FrameSelection::appearanceUpdateTimerFired should be robust against layout passes underneath it


Deleted: trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt (230088 => 230089)

--- trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt	2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt	2018-03-30 01:24:00 UTC (rev 230089)
@@ -1,4 +0,0 @@
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html (230088 => 230089)

--- trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html	2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html	2018-03-30 01:24:00 UTC (rev 230089)
@@ -1,32 +0,0 @@
-
-
-
-
-body { -webkit-user-modify: read-only; }
-
-
-function reconnectSubframe() {
-document.body.appendChild(document.querySelector("iframe"));
-}
-
-function go() {
-jsTestIsAsync = true;
-if (window.finishJSTest)
-setTimeout(() => setTimeout(finishJSTest));
-
-getSelection().setPosition(document.body);
-
-if (window.internals)
-setTimeout(() => internals.setCaptionsStyleSheetOverride("* { }"));
-
-reconnectSubframe();
-}
-
-
-
-
-
-
-
-
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (230088 => 230089)

--- trunk/Source/WebCore/ChangeLog	2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/Source/WebCore/ChangeLog	2018-03-30 01:24:00 UTC (rev 230089)
@@ -1,3 +1,16 @@
+2018-03-29  Ryan Haddad  
+
+Unreviewed, rolling out r230087.
+
+Introduced LayoutTest failures.
+
+Reverted changeset:
+
+"FrameSelection::appearanceUpdateTimerFired should be robust
+against layout passes underneath it"
+https://bugs.webkit.org/show_bug.cgi?id=183395
+https://trac.webkit.org/changeset/230087
+
 2018-03-29  Wenson Hsieh  
 
 FrameSelection::appearanceUpdateTimerFired should be robust against layout passes underneath it


Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (230088 => 230089)

--- trunk/Source/WebCore/editing/FrameSelection.cpp	2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp	2018-03-30 01:24:00 UTC (rev 230089)
@@ -2441,10 +2441,6 @@
 
 void FrameSelection::appearanceUpdateTimerFired()
 {
-Ref protectedFrame(*m_frame);
-if (auto* document = protectedFrame->document())
-document->updateLayoutIgnorePendingStylesheets();
-
 updateAppearanceAfterLayoutOrStyleChange();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230088] trunk/Source/WebKit

[bburg]

Title: [230088] trunk/Source/WebKit








Revision 230088
Author bb...@apple.com
Date 2018-03-29 17:07:40 -0700 (Thu, 29 Mar 2018)


Log Message
Web Automation: clipToViewport is ignored for element screenshots
https://bugs.webkit.org/show_bug.cgi?id=184158


Reviewed by Timothy Hatcher.

In §19.2 Take Element Screenshot, step 5.2 says that we should clip
the element screenshot rect with the visible viewport rect. We don't
do that right now even though we pass over clipToViewport.

* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::snapshotRectForScreenshot):
Clip the rect to viewport if needed.

(WebKit::WebAutomationSessionProxy::takeScreenshot):
This scrollIntoView is misplaced; by this point we have already done
the math to figure out the screenshot rect. Move it before computing the rect.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (230087 => 230088)

--- trunk/Source/WebKit/ChangeLog	2018-03-29 23:05:06 UTC (rev 230087)
+++ trunk/Source/WebKit/ChangeLog	2018-03-30 00:07:40 UTC (rev 230088)
@@ -1,3 +1,23 @@
+2018-03-29  Brian Burg  
+
+Web Automation: clipToViewport is ignored for element screenshots
+https://bugs.webkit.org/show_bug.cgi?id=184158
+
+
+Reviewed by Timothy Hatcher.
+
+In §19.2 Take Element Screenshot, step 5.2 says that we should clip
+the element screenshot rect with the visible viewport rect. We don't
+do that right now even though we pass over clipToViewport.
+
+* WebProcess/Automation/WebAutomationSessionProxy.cpp:
+(WebKit::snapshotRectForScreenshot):
+Clip the rect to viewport if needed.
+
+(WebKit::WebAutomationSessionProxy::takeScreenshot):
+This scrollIntoView is misplaced; by this point we have already done
+the math to figure out the screenshot rect. Move it before computing the rect.
+
 2018-03-29  Brent Fulgham  
 
 REGRESSION(r230035): ASSERT(MACH_PORT_VALID(m_sendPort)) hit in IPC::Connection::initializeSendSource()


Modified: trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp (230087 => 230088)

--- trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp	2018-03-29 23:05:06 UTC (rev 230087)
+++ trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp	2018-03-30 00:07:40 UTC (rev 230088)
@@ -663,12 +663,20 @@
 
 static WebCore::IntRect snapshotRectForScreenshot(WebPage& page, WebCore::Element* element, bool clipToViewport)
 {
+auto* frameView = page.mainFrameView();
+if (!frameView)
+return { };
+
 if (element) {
 if (!element->renderer())
 return { };
 
 WebCore::LayoutRect topLevelRect;
-return WebCore::snappedIntRect(element->renderer()->paintingRootRect(topLevelRect));
+WebCore::IntRect elementRect = WebCore::snappedIntRect(element->renderer()->paintingRootRect(topLevelRect));
+if (clipToViewport)
+elementRect.intersect(frameView->visibleContentRect());
+
+return elementRect;
 }
 
 if (auto* frameView = page.mainFrameView())
@@ -705,6 +713,9 @@
 }
 }
 
+if (coreElement && scrollIntoViewIfNeeded)
+coreElement->scrollIntoViewIfNeeded(false);
+
 String screenshotErrorType = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::ScreenshotError);
 WebCore::IntRect snapshotRect = snapshotRectForScreenshot(*page, coreElement, clipToViewport);
 if (snapshotRect.isEmpty()) {
@@ -712,9 +723,6 @@
 return;
 }
 
-if (coreElement && scrollIntoViewIfNeeded)
-coreElement->scrollIntoViewIfNeeded(false);
-
 RefPtr image = page->scaledSnapshotWithOptions(snapshotRect, 1, SnapshotOptionsShareable);
 if (!image) {
 WebProcess::singleton().parentProcessConnection()->send(Messages::WebAutomationSession::DidTakeScreenshot(callbackID, handle, screenshotErrorType), 0);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230087] trunk

[wenson_hsieh]

Title: [230087] trunk








Revision 230087
Author wenson_hs...@apple.com
Date 2018-03-29 16:05:06 -0700 (Thu, 29 Mar 2018)


Log Message
FrameSelection::appearanceUpdateTimerFired should be robust against layout passes underneath it
https://bugs.webkit.org/show_bug.cgi?id=183395


Reviewed by Zalan Bujtas.

Source/WebCore:

In the case where a FrameSelection updates its appearance when m_appearanceUpdateTimer is fired, the
FrameSelection's Frame is unprotected, and can be removed by arbitrary script. This patch applies a simple
mitigation by wrapping the Frame in a Ref when firing the appearance update timer, and ensuring that layout is
really up to date before calling updateAppearanceAfterLayoutOrStyleChange() from the timer.

Test: editing/selection/iframe-update-selection-appearance.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::appearanceUpdateTimerFired):

LayoutTests:

Add a new layout test that passes if we didn't crash.

* editing/selection/iframe-update-selection-appearance-expected.txt: Added.
* editing/selection/iframe-update-selection-appearance.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp


Added Paths

trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt
trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html




Diff

Modified: trunk/LayoutTests/ChangeLog (230086 => 230087)

--- trunk/LayoutTests/ChangeLog	2018-03-29 23:02:09 UTC (rev 230086)
+++ trunk/LayoutTests/ChangeLog	2018-03-29 23:05:06 UTC (rev 230087)
@@ -1,3 +1,16 @@
+2018-03-29  Wenson Hsieh  
+
+FrameSelection::appearanceUpdateTimerFired should be robust against layout passes underneath it
+https://bugs.webkit.org/show_bug.cgi?id=183395
+
+
+Reviewed by Zalan Bujtas.
+
+Add a new layout test that passes if we didn't crash.
+
+* editing/selection/iframe-update-selection-appearance-expected.txt: Added.
+* editing/selection/iframe-update-selection-appearance.html: Added.
+
 2018-03-29  Per Arne Vollan  
 
 The test http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html is failing on Windows.


Added: trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt (0 => 230087)

--- trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt	2018-03-29 23:05:06 UTC (rev 230087)
@@ -0,0 +1,4 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html (0 => 230087)

--- trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html	(rev 0)
+++ trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html	2018-03-29 23:05:06 UTC (rev 230087)
@@ -0,0 +1,32 @@
+
+
+
+
+body { -webkit-user-modify: read-only; }
+
+
+function reconnectSubframe() {
+document.body.appendChild(document.querySelector("iframe"));
+}
+
+function go() {
+jsTestIsAsync = true;
+if (window.finishJSTest)
+setTimeout(() => setTimeout(finishJSTest));
+
+getSelection().setPosition(document.body);
+
+if (window.internals)
+setTimeout(() => internals.setCaptionsStyleSheetOverride("* { }"));
+
+reconnectSubframe();
+}
+
+
+
+
+
+
+
+
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (230086 => 230087)

--- trunk/Source/WebCore/ChangeLog	2018-03-29 23:02:09 UTC (rev 230086)
+++ trunk/Source/WebCore/ChangeLog	2018-03-29 23:05:06 UTC (rev 230087)
@@ -1,3 +1,21 @@
+2018-03-29  Wenson Hsieh  
+
+FrameSelection::appearanceUpdateTimerFired should be robust against layout passes underneath it
+https://bugs.webkit.org/show_bug.cgi?id=183395
+
+
+Reviewed by Zalan Bujtas.
+
+In the case where a FrameSelection updates its appearance when m_appearanceUpdateTimer is fired, the
+FrameSelection's Frame is unprotected, and can be removed by arbitrary script. This patch applies a simple
+mitigation by wrapping the Frame in a Ref when firing the appearance update timer, and ensuring that layout is
+really up to date before calling updateAppearanceAfterLayoutOrStyleChange() from the timer.
+
+Test: editing/selection/iframe-update-selection-appearance.html
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::appearanceUpdateTimerFired):
+
 2018-03-29  Daniel Bates  
 
 Substitute ArchiveFactory::isArchiveMIMEType() for ArchiveFactory::isArchiveMimeType().


Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (230086 => 230087)

--- 

[webkit-changes] [230086] trunk/Source

[jmarcell]

Title: [230086] trunk/Source








Revision 230086
Author jmarc...@apple.com
Date 2018-03-29 16:02:09 -0700 (Thu, 29 Mar 2018)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (230085 => 230086)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-29 22:20:54 UTC (rev 230085)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-29 23:02:09 UTC (rev 230086)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (230085 => 230086)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-29 22:20:54 UTC (rev 230085)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-29 23:02:09 UTC (rev 230086)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (230085 => 230086)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2018-03-29 22:20:54 UTC (rev 230085)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2018-03-29 23:02:09 UTC (rev 230086)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (230085 => 230086)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-29 22:20:54 UTC (rev 230085)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-29 23:02:09 UTC (rev 230086)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (230085 => 230086)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-29 22:20:54 UTC (rev 230085)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-29 23:02:09 UTC (rev 230086)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (230085 => 230086)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2018-03-29 22:20:54 UTC (rev 230085)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2018-03-29 23:02:09 UTC (rev 230086)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (230085 => 230086)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-29 22:20:54 UTC (rev 230085)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-29 23:02:09 UTC (rev 230086)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230085] trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h

[dino]

Title: [230085] trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h








Revision 230085
Author d...@apple.com
Date 2018-03-29 15:20:54 -0700 (Thu, 29 Mar 2018)


Log Message
iOS build fix.

* platform/graphics/cocoa/WebGLLayer.h:

Modified Paths

trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h




Diff

Modified: trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h (230084 => 230085)

--- trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h	2018-03-29 21:59:54 UTC (rev 230084)
+++ trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h	2018-03-29 22:20:54 UTC (rev 230085)
@@ -34,6 +34,9 @@
 class GraphicsContext3D;
 }
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 #if USE(OPENGL)
 @interface WebGLLayer : CALayer
 #else
@@ -64,3 +67,4 @@
 
 @end
 
+#pragma clang diagnostic pop






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230084] trunk/Source/WebKit

[bfulgham]

Title: [230084] trunk/Source/WebKit








Revision 230084
Author bfulg...@apple.com
Date 2018-03-29 14:59:54 -0700 (Thu, 29 Mar 2018)


Log Message
REGRESSION(r230035): ASSERT(MACH_PORT_VALID(m_sendPort)) hit in IPC::Connection::initializeSendSource()
https://bugs.webkit.org/show_bug.cgi?id=184122


Reviewed by Chris Dumez.

One of the new assertions added in r230035 begin firing while running tests locally. This was happening
because the WebInspector was attempting to open a new connection to a web process that had already
terminated its mach port connection (a dead port).

We should avoid opening new connections when the port we were given is already dead.

* Platform/IPC/Connection.h:
(IPC::Connection::identifierIsValid): Added.
* Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::platformInitialize): Do not perform initialization on a dead (or null) port.
(IPC::Connection::open): Add some assertions that ports are in a valid state.
(IPC::Connection::sendOutgoingMessage): Assert that the send port is not dead.
(IPC::Connection::receiveSourceEventHandler): Assert that the receive port is valid.
* UIProcess/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::didFinishLaunching): Treat a dead port as a signal that the
child process failed to launch.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching): Ditto.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching): Ditto.
* UIProcess/Storage/StorageProcessProxy.cpp:
(WebKit::StorageProcessProxy::didFinishLaunching): Ditto.
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection): Ditto.
* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::establishConnection): Ditto.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection): Ditto.
(WebKit::WebProcess::ensureWebToStorageProcessConnection): Ditto.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Connection.h
trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm
trunk/Source/WebKit/UIProcess/ChildProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp
trunk/Source/WebKit/WebProcess/Plugins/PluginProcessConnectionManager.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp
trunk/Source/WebKit/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (230083 => 230084)

--- trunk/Source/WebKit/ChangeLog	2018-03-29 21:53:35 UTC (rev 230083)
+++ trunk/Source/WebKit/ChangeLog	2018-03-29 21:59:54 UTC (rev 230084)
@@ -1,3 +1,41 @@
+2018-03-29  Brent Fulgham  
+
+REGRESSION(r230035): ASSERT(MACH_PORT_VALID(m_sendPort)) hit in IPC::Connection::initializeSendSource()
+https://bugs.webkit.org/show_bug.cgi?id=184122
+
+
+Reviewed by Chris Dumez.
+
+One of the new assertions added in r230035 begin firing while running tests locally. This was happening
+because the WebInspector was attempting to open a new connection to a web process that had already
+terminated its mach port connection (a dead port).
+
+We should avoid opening new connections when the port we were given is already dead.
+
+* Platform/IPC/Connection.h:
+(IPC::Connection::identifierIsValid): Added.
+* Platform/IPC/mac/ConnectionMac.mm:
+(IPC::Connection::platformInitialize): Do not perform initialization on a dead (or null) port.
+(IPC::Connection::open): Add some assertions that ports are in a valid state.
+(IPC::Connection::sendOutgoingMessage): Assert that the send port is not dead.
+(IPC::Connection::receiveSourceEventHandler): Assert that the receive port is valid.
+* UIProcess/ChildProcessProxy.cpp:
+(WebKit::ChildProcessProxy::didFinishLaunching): Treat a dead port as a signal that the
+child process failed to launch.
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::didFinishLaunching): Ditto.
+* UIProcess/Plugins/PluginProcessProxy.cpp:
+(WebKit::PluginProcessProxy::didFinishLaunching): Ditto.
+* UIProcess/Storage/StorageProcessProxy.cpp:
+(WebKit::StorageProcessProxy::didFinishLaunching): Ditto.
+* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
+(WebKit::PluginProcessConnectionManager::getPluginProcessConnection): Ditto.
+* WebProcess/WebPage/WebInspectorUI.cpp:
+(WebKit::WebInspectorUI::establishConnection): Ditto.
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::ensureNetworkProcessConnection): Ditto.
+(WebKit::WebProcess::ensureWebToStorageProcessConnection): Ditto.
+
 2018-03-29  Youenn Fablet  
 
 Synchronize 

[webkit-changes] [230083] trunk/Source/WebCore

[dbates]

Title: [230083] trunk/Source/WebCore








Revision 230083
Author dba...@webkit.org
Date 2018-03-29 14:53:35 -0700 (Thu, 29 Mar 2018)


Log Message
Substitute ArchiveFactory::isArchiveMIMEType() for ArchiveFactory::isArchiveMimeType().

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitLoad):
* loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::isArchiveMIMEType):
(WebCore::ArchiveFactory::isArchiveMimeType): Deleted.
* loader/archive/ArchiveFactory.h:
* platform/MIMETypeRegistry.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/archive/ArchiveFactory.cpp
trunk/Source/WebCore/loader/archive/ArchiveFactory.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (230082 => 230083)

--- trunk/Source/WebCore/ChangeLog	2018-03-29 21:49:25 UTC (rev 230082)
+++ trunk/Source/WebCore/ChangeLog	2018-03-29 21:53:35 UTC (rev 230083)
@@ -1,5 +1,17 @@
 2018-03-29  Daniel Bates  
 
+Substitute ArchiveFactory::isArchiveMIMEType() for ArchiveFactory::isArchiveMimeType().
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::commitLoad):
+* loader/archive/ArchiveFactory.cpp:
+(WebCore::ArchiveFactory::isArchiveMIMEType):
+(WebCore::ArchiveFactory::isArchiveMimeType): Deleted.
+* loader/archive/ArchiveFactory.h:
+* platform/MIMETypeRegistry.h:
+
+2018-03-29  Daniel Bates  
+
 MIMETypeRegistry should return const HashSets
 https://bugs.webkit.org/show_bug.cgi?id=184150
 


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (230082 => 230083)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2018-03-29 21:49:25 UTC (rev 230082)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2018-03-29 21:53:35 UTC (rev 230083)
@@ -941,7 +941,7 @@
 if (!frameLoader)
 return;
 #if ENABLE(WEB_ARCHIVE) || ENABLE(MHTML)
-if (ArchiveFactory::isArchiveMimeType(response().mimeType()))
+if (ArchiveFactory::isArchiveMIMEType(response().mimeType()))
 return;
 #endif
 frameLoader->client().committedLoad(this, data, length);


Modified: trunk/Source/WebCore/loader/archive/ArchiveFactory.cpp (230082 => 230083)

--- trunk/Source/WebCore/loader/archive/ArchiveFactory.cpp	2018-03-29 21:49:25 UTC (rev 230082)
+++ trunk/Source/WebCore/loader/archive/ArchiveFactory.cpp	2018-03-29 21:53:35 UTC (rev 230083)
@@ -78,7 +78,7 @@
 return map;
 }
 
-bool ArchiveFactory::isArchiveMimeType(const String& mimeType)
+bool ArchiveFactory::isArchiveMIMEType(const String& mimeType)
 {
 return !mimeType.isEmpty() && archiveMIMETypes().contains(mimeType);
 }


Modified: trunk/Source/WebCore/loader/archive/ArchiveFactory.h (230082 => 230083)

--- trunk/Source/WebCore/loader/archive/ArchiveFactory.h	2018-03-29 21:49:25 UTC (rev 230082)
+++ trunk/Source/WebCore/loader/archive/ArchiveFactory.h	2018-03-29 21:53:35 UTC (rev 230083)
@@ -38,7 +38,7 @@
 
 class ArchiveFactory {
 public:
-static bool isArchiveMimeType(const String&);
+static bool isArchiveMIMEType(const String&);
 static RefPtr create(const URL&, SharedBuffer* data, const String& mimeType);
 static void registerKnownArchiveMIMETypes();
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230082] trunk/Source/WebCore

[dbates]

Title: [230082] trunk/Source/WebCore








Revision 230082
Author dba...@webkit.org
Date 2018-03-29 14:49:25 -0700 (Thu, 29 Mar 2018)


Log Message
MIMETypeRegistry should return const HashSets
https://bugs.webkit.org/show_bug.cgi?id=184150

Reviewed by Per Arne Vollan.

Only getSupportedNonImageMIMETypes() needs to return a non-const HashSet so that
LegacyWebKit can modify the set of non-image MIME types.

* platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
(WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
(WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
(WebCore::MIMETypeRegistry::getPDFMIMETypes):
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
* platform/MIMETypeRegistry.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/MIMETypeRegistry.cpp
trunk/Source/WebCore/platform/MIMETypeRegistry.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (230081 => 230082)

--- trunk/Source/WebCore/ChangeLog	2018-03-29 21:15:26 UTC (rev 230081)
+++ trunk/Source/WebCore/ChangeLog	2018-03-29 21:49:25 UTC (rev 230082)
@@ -1,3 +1,22 @@
+2018-03-29  Daniel Bates  
+
+MIMETypeRegistry should return const HashSets
+https://bugs.webkit.org/show_bug.cgi?id=184150
+
+Reviewed by Per Arne Vollan.
+
+Only getSupportedNonImageMIMETypes() needs to return a non-const HashSet so that
+LegacyWebKit can modify the set of non-image MIME types.
+
+* platform/MIMETypeRegistry.cpp:
+(WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
+(WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
+(WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
+(WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
+(WebCore::MIMETypeRegistry::getPDFMIMETypes):
+(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
+* platform/MIMETypeRegistry.h:
+
 2018-03-29  Brady Eidson  
 
 Update Service Worker feature status.


Modified: trunk/Source/WebCore/platform/MIMETypeRegistry.cpp (230081 => 230082)

--- trunk/Source/WebCore/platform/MIMETypeRegistry.cpp	2018-03-29 21:15:26 UTC (rev 230081)
+++ trunk/Source/WebCore/platform/MIMETypeRegistry.cpp	2018-03-29 21:49:25 UTC (rev 230082)
@@ -651,7 +651,7 @@
 return false;
 }
 
-HashSet& MIMETypeRegistry::getSupportedImageMIMETypes()
+const HashSet& MIMETypeRegistry::getSupportedImageMIMETypes()
 {
 if (!supportedImageMIMETypes)
 initializeSupportedImageMIMETypes();
@@ -658,7 +658,7 @@
 return *supportedImageMIMETypes;
 }
 
-HashSet& MIMETypeRegistry::getSupportedImageResourceMIMETypes()
+const HashSet& MIMETypeRegistry::getSupportedImageResourceMIMETypes()
 {
 if (!supportedImageResourceMIMETypes)
 initializeSupportedImageMIMETypes();
@@ -665,7 +665,7 @@
 return *supportedImageResourceMIMETypes;
 }
 
-HashSet& MIMETypeRegistry::getSupportedImageMIMETypesForEncoding()
+const HashSet& MIMETypeRegistry::getSupportedImageMIMETypesForEncoding()
 {
 if (!supportedImageMIMETypesForEncoding)
 initializeSupportedImageMIMETypesForEncoding();
@@ -679,7 +679,7 @@
 return *supportedNonImageMIMETypes;
 }
 
-HashSet& MIMETypeRegistry::getSupportedMediaMIMETypes()
+const HashSet& MIMETypeRegistry::getSupportedMediaMIMETypes()
 {
 if (!supportedMediaMIMETypes)
 initializeSupportedMediaMIMETypes();
@@ -687,7 +687,7 @@
 }
 
 
-HashSet& MIMETypeRegistry::getPDFMIMETypes()
+const HashSet& MIMETypeRegistry::getPDFMIMETypes()
 {
 if (!pdfMIMETypes)
 initializePDFMIMETypes();
@@ -694,7 +694,7 @@
 return *pdfMIMETypes;
 }
 
-HashSet& MIMETypeRegistry::getUnsupportedTextMIMETypes()
+const HashSet& MIMETypeRegistry::getUnsupportedTextMIMETypes()
 {
 if (!unsupportedTextMIMETypes)
 initializeUnsupportedTextMIMETypes();


Modified: trunk/Source/WebCore/platform/MIMETypeRegistry.h (230081 => 230082)

--- trunk/Source/WebCore/platform/MIMETypeRegistry.h	2018-03-29 21:15:26 UTC (rev 230081)
+++ trunk/Source/WebCore/platform/MIMETypeRegistry.h	2018-03-29 21:49:25 UTC (rev 230082)
@@ -106,14 +106,15 @@
 
 // FIXME: WebKit coding style says we should not have the word "get" in the names of these functions.
 // FIXME: Would be nice to find a way to avoid exposing these sets, even worse exposing non-const references.
-WEBCORE_EXPORT static HashSet& 

[webkit-changes] [230081] trunk/Source/WebCore

[beidson]

Title: [230081] trunk/Source/WebCore








Revision 230081
Author beid...@apple.com
Date 2018-03-29 14:15:26 -0700 (Thu, 29 Mar 2018)


Log Message
Update Service Worker feature status.
https://bugs.webkit.org/show_bug.cgi?id=184139

Reviewed by Chris Dumez.

* features.json:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json




Diff

Modified: trunk/Source/WebCore/ChangeLog (230080 => 230081)

--- trunk/Source/WebCore/ChangeLog	2018-03-29 21:13:03 UTC (rev 230080)
+++ trunk/Source/WebCore/ChangeLog	2018-03-29 21:15:26 UTC (rev 230081)
@@ -1,3 +1,12 @@
+2018-03-29  Brady Eidson  
+
+Update Service Worker feature status.
+https://bugs.webkit.org/show_bug.cgi?id=184139
+
+Reviewed by Chris Dumez.
+
+* features.json:
+
 2018-03-29  Chris Dumez  
 
 Drop DOMWindow::frames() / DOMWindow::window() methods


Modified: trunk/Source/WebCore/features.json (230080 => 230081)

--- trunk/Source/WebCore/features.json	2018-03-29 21:13:03 UTC (rev 230080)
+++ trunk/Source/WebCore/features.json	2018-03-29 21:15:26 UTC (rev 230081)
@@ -497,7 +497,7 @@
 {
 "name": "Service Workers",
 "status": {
-"status": "Supported In Preview"
+"status": "Supported"
 },
 "url": "https://w3c.github.io/ServiceWorker/",
 "webkit-url": "https://webkit.org/b/174541",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230080] tags/Safari-606.1.11/Source

[jmarcell]

Title: [230080] tags/Safari-606.1.11/Source








Revision 230080
Author jmarc...@apple.com
Date 2018-03-29 14:13:03 -0700 (Thu, 29 Mar 2018)


Log Message
Revert r229680. rdar://problem/39011568

Modified Paths

tags/Safari-606.1.11/Source/WebCore/ChangeLog
tags/Safari-606.1.11/Source/WebCore/dom/Document.idl
tags/Safari-606.1.11/Source/WebCore/dom/Element.idl
tags/Safari-606.1.11/Source/WebKit/ChangeLog
tags/Safari-606.1.11/Source/WebKit/Scripts/GeneratePreferences.rb
tags/Safari-606.1.11/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb
tags/Safari-606.1.11/Source/WebKit/Shared/WebPreferences.yaml




Diff

Modified: tags/Safari-606.1.11/Source/WebCore/ChangeLog (230079 => 230080)

--- tags/Safari-606.1.11/Source/WebCore/ChangeLog	2018-03-29 20:36:06 UTC (rev 230079)
+++ tags/Safari-606.1.11/Source/WebCore/ChangeLog	2018-03-29 21:13:03 UTC (rev 230080)
@@ -1,3 +1,7 @@
+2018-03-29  Jason Marcell  
+
+Revert r229680. rdar://problem/39011568
+
 2018-03-28  Miguel Gomez  
 
 [GTK][WPE] Remove UpdateAtlas


Modified: tags/Safari-606.1.11/Source/WebCore/dom/Document.idl (230079 => 230080)

--- tags/Safari-606.1.11/Source/WebCore/dom/Document.idl	2018-03-29 20:36:06 UTC (rev 230079)
+++ tags/Safari-606.1.11/Source/WebCore/dom/Document.idl	2018-03-29 21:13:03 UTC (rev 230080)
@@ -144,15 +144,15 @@
 
 // Extensions from FullScreen API (https://fullscreen.spec.whatwg.org/#api).
 // FIXME: Should probably be unprefixed.
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] readonly attribute boolean webkitFullscreenEnabled;
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, ImplementedAs=webkitFullscreenElementForBindings] readonly attribute Element? webkitFullscreenElement;
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] void webkitExitFullscreen();
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] readonly attribute boolean webkitIsFullScreen; // Mozilla version.
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] readonly attribute boolean webkitFullScreenKeyboardInputAllowed; // Mozilla version.
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, ImplementedAs=webkitCurrentFullScreenElementForBindings] readonly attribute Element webkitCurrentFullScreenElement; // Mozilla version.
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] void webkitCancelFullScreen(); // Mozilla version.
-[NotEnumerable, Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] attribute EventHandler onwebkitfullscreenchange;
-[NotEnumerable, Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] attribute EventHandler onwebkitfullscreenerror;
+[Conditional=FULLSCREEN_API] readonly attribute boolean webkitFullscreenEnabled;
+[Conditional=FULLSCREEN_API, ImplementedAs=webkitFullscreenElementForBindings] readonly attribute Element? webkitFullscreenElement;
+[Conditional=FULLSCREEN_API] void webkitExitFullscreen();
+[Conditional=FULLSCREEN_API] readonly attribute boolean webkitIsFullScreen; // Mozilla version.
+[Conditional=FULLSCREEN_API] readonly attribute boolean webkitFullScreenKeyboardInputAllowed; // Mozilla version.
+[Conditional=FULLSCREEN_API, ImplementedAs=webkitCurrentFullScreenElementForBindings] readonly attribute Element webkitCurrentFullScreenElement; // Mozilla version.
+[Conditional=FULLSCREEN_API] void webkitCancelFullScreen(); // Mozilla version.
+[NotEnumerable, Conditional=FULLSCREEN_API] attribute EventHandler onwebkitfullscreenchange;
+[NotEnumerable, Conditional=FULLSCREEN_API] attribute EventHandler onwebkitfullscreenerror;
 
 // Extensions from Pointer Lock API (https://www.w3.org/TR/pointerlock/#extensions-to-the-document-interface).
 [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockchange; // FIXME: Should be enumerable.


Modified: tags/Safari-606.1.11/Source/WebCore/dom/Element.idl (230079 => 230080)

--- tags/Safari-606.1.11/Source/WebCore/dom/Element.idl	2018-03-29 20:36:06 UTC (rev 230079)
+++ tags/Safari-606.1.11/Source/WebCore/dom/Element.idl	2018-03-29 21:13:03 UTC (rev 230080)
@@ -94,8 +94,8 @@
 
 // Extensions from Full Screen API (https://fullscreen.spec.whatwg.org/#api).
 // FIXME: Should we add unprefixed versions?
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, ImplementedAs=webkitRequestFullscreen] void webkitRequestFullScreen(); // Prefixed Mozilla version.
-[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] void webkitRequestFullscreen(); // Prefixed W3C version.
+[Conditional=FULLSCREEN_API, ImplementedAs=webkitRequestFullscreen] void webkitRequestFullScreen(); // Prefixed Mozilla version.
+[Conditional=FULLSCREEN_API] void webkitRequestFullscreen(); // Prefixed W3C version.
 
 // Extensions from Pointer Lock API 

[webkit-changes] [230079] trunk/Source/WebKit

[youenn]

Title: [230079] trunk/Source/WebKit








Revision 230079
Author you...@apple.com
Date 2018-03-29 13:36:06 -0700 (Thu, 29 Mar 2018)


Log Message
Synchronize SecurityOrigin related scheme registries with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=184140

Reviewed by Chris Dumez.

Add syncing of scheme registries that are used by SecurityOrigin and ContentSecurityPolicy
so that we can properly use them in NetworkProcess as we do in WebProcess.
The registries that are not synced are:
- URLSchemeAsEmptyDocument
- URLSchemeDomainRelaxationForbidden
- URLSchemeAsCachePartitioned
- URLSchemeAsCanDisplayOnlyIfCanRequest

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::registerURLSchemeAsSecure const):
(WebKit::NetworkProcess::registerURLSchemeAsBypassingContentSecurityPolicy const):
(WebKit::NetworkProcess::registerURLSchemeAsLocal const):
(WebKit::NetworkProcess::registerURLSchemeAsNoAccess const):
(WebKit::NetworkProcess::registerURLSchemeAsDisplayIsolated const):
(WebKit::NetworkProcess::registerURLSchemeAsCORSEnabled const):
(WebKit::NetworkProcess::registerURLSchemeAsCanDisplayOnlyIfCanRequest const):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkProcessCreationParameters.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::registerURLSchemeAsSecure):
(WebKit::WebProcessPool::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit::WebProcessPool::registerURLSchemeAsLocal):
(WebKit::WebProcessPool::registerURLSchemeAsNoAccess):
(WebKit::WebProcessPool::registerURLSchemeAsDisplayIsolated):
(WebKit::WebProcessPool::registerURLSchemeAsCORSEnabled):
(WebKit::WebProcessPool::registerURLSchemeAsCanDisplayOnlyIfCanRequest):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (230078 => 230079)

--- trunk/Source/WebKit/ChangeLog	2018-03-29 19:09:01 UTC (rev 230078)
+++ trunk/Source/WebKit/ChangeLog	2018-03-29 20:36:06 UTC (rev 230079)
@@ -1,3 +1,43 @@
+2018-03-29  Youenn Fablet  
+
+Synchronize SecurityOrigin related scheme registries with NetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=184140
+
+Reviewed by Chris Dumez.
+
+Add syncing of scheme registries that are used by SecurityOrigin and ContentSecurityPolicy
+so that we can properly use them in NetworkProcess as we do in WebProcess.
+The registries that are not synced are:
+- URLSchemeAsEmptyDocument
+- URLSchemeDomainRelaxationForbidden
+- URLSchemeAsCachePartitioned
+- URLSchemeAsCanDisplayOnlyIfCanRequest
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::initializeNetworkProcess):
+(WebKit::NetworkProcess::registerURLSchemeAsSecure const):
+(WebKit::NetworkProcess::registerURLSchemeAsBypassingContentSecurityPolicy const):
+(WebKit::NetworkProcess::registerURLSchemeAsLocal const):
+(WebKit::NetworkProcess::registerURLSchemeAsNoAccess const):
+(WebKit::NetworkProcess::registerURLSchemeAsDisplayIsolated const):
+(WebKit::NetworkProcess::registerURLSchemeAsCORSEnabled const):
+(WebKit::NetworkProcess::registerURLSchemeAsCanDisplayOnlyIfCanRequest const):
+* NetworkProcess/NetworkProcess.h:
+* NetworkProcess/NetworkProcess.messages.in:
+* NetworkProcess/NetworkProcessCreationParameters.cpp:
+(WebKit::NetworkProcessCreationParameters::encode const):
+(WebKit::NetworkProcessCreationParameters::decode):
+* NetworkProcess/NetworkProcessCreationParameters.h:
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::ensureNetworkProcess):
+(WebKit::WebProcessPool::registerURLSchemeAsSecure):
+(WebKit::WebProcessPool::registerURLSchemeAsBypassingContentSecurityPolicy):
+(WebKit::WebProcessPool::registerURLSchemeAsLocal):
+(WebKit::WebProcessPool::registerURLSchemeAsNoAccess):
+(WebKit::WebProcessPool::registerURLSchemeAsDisplayIsolated):
+(WebKit::WebProcessPool::registerURLSchemeAsCORSEnabled):
+(WebKit::WebProcessPool::registerURLSchemeAsCanDisplayOnlyIfCanRequest):
+
 2018-03-29  Brent Fulgham  
 
 REGRESSION(r229480): ERROR: Unhandled web process message 

[webkit-changes] [230078] trunk/Source/JavaScriptCore

[keith_miller]

Title: [230078] trunk/Source/_javascript_Core








Revision 230078
Author keith_mil...@apple.com
Date 2018-03-29 12:09:01 -0700 (Thu, 29 Mar 2018)


Log Message
ArrayMode should not try to get the DFG to think it can convert TypedArrays
https://bugs.webkit.org/show_bug.cgi?id=184137

Reviewed by Saam Barati.

* dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230077 => 230078)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-29 16:52:33 UTC (rev 230077)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-29 19:09:01 UTC (rev 230078)
@@ -1,3 +1,13 @@
+2018-03-29  Keith Miller  
+
+ArrayMode should not try to get the DFG to think it can convert TypedArrays
+https://bugs.webkit.org/show_bug.cgi?id=184137
+
+Reviewed by Saam Barati.
+
+* dfg/DFGArrayMode.cpp:
+(JSC::DFG::ArrayMode::fromObserved):
+
 2018-03-29  Commit Queue  
 
 Unreviewed, rolling out r230062.


Modified: trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp (230077 => 230078)

--- trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp	2018-03-29 16:52:33 UTC (rev 230077)
+++ trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp	2018-03-29 19:09:01 UTC (rev 230078)
@@ -118,6 +118,10 @@
 return ArrayMode(Array::Float64Array, nonArray, Array::AsIs).withProfile(locker, profile, makeSafe);
 
 default:
+// If we have seen multiple TypedArray types, or a TypedArray and non-typed array, it doesn't make sense to try to convert the object since you can't convert typed arrays.
+if (observed & ALL_TYPED_ARRAY_MODES)
+return ArrayMode(Array::Generic, nonArray, Array::AsIs).withProfile(locker, profile, makeSafe);
+
 if ((observed & asArrayModes(NonArray)) && profile->mayInterceptIndexedAccesses(locker))
 return ArrayMode(Array::SelectUsingPredictions).withSpeculationFromProfile(locker, profile, makeSafe);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230077] trunk/Source

[cdumez]

Title: [230077] trunk/Source








Revision 230077
Author cdu...@apple.com
Date 2018-03-29 09:52:33 -0700 (Thu, 29 Mar 2018)


Log Message
Drop DOMWindow::frames() / DOMWindow::window() methods
https://bugs.webkit.org/show_bug.cgi?id=184112

Reviewed by Daniel Bates.

Drop DOMWindow::frames() / DOMWindow::window() methods as they are just aliases for DOMWindow::self().

* page/DOMWindow.h:
* page/DOMWindow.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.h
trunk/Source/WebCore/page/DOMWindow.idl
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230076 => 230077)

--- trunk/Source/WebCore/ChangeLog	2018-03-29 16:28:03 UTC (rev 230076)
+++ trunk/Source/WebCore/ChangeLog	2018-03-29 16:52:33 UTC (rev 230077)
@@ -1,3 +1,15 @@
+2018-03-29  Chris Dumez  
+
+Drop DOMWindow::frames() / DOMWindow::window() methods
+https://bugs.webkit.org/show_bug.cgi?id=184112
+
+Reviewed by Daniel Bates.
+
+Drop DOMWindow::frames() / DOMWindow::window() methods as they are just aliases for DOMWindow::self().
+
+* page/DOMWindow.h:
+* page/DOMWindow.idl:
+
 2018-03-29  Commit Queue  
 
 Unreviewed, rolling out r230062.


Modified: trunk/Source/WebCore/page/DOMWindow.h (230076 => 230077)

--- trunk/Source/WebCore/page/DOMWindow.h	2018-03-29 16:28:03 UTC (rev 230076)
+++ trunk/Source/WebCore/page/DOMWindow.h	2018-03-29 16:52:33 UTC (rev 230077)
@@ -191,11 +191,7 @@
 String defaultStatus() const;
 void setDefaultStatus(const String&);
 
-// Self-referential attributes
-
 DOMWindow* self() const;
-DOMWindow* window() const { return self(); }
-DOMWindow* frames() const { return self(); }
 
 DOMWindow* opener() const;
 void disownOpener();


Modified: trunk/Source/WebCore/page/DOMWindow.idl (230076 => 230077)

--- trunk/Source/WebCore/page/DOMWindow.idl	2018-03-29 16:28:03 UTC (rev 230076)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2018-03-29 16:52:33 UTC (rev 230077)
@@ -49,7 +49,7 @@
 PrimaryGlobal,
 ] interface DOMWindow : EventTarget {
 // The current browsing context.
-[DoNotCheckSecurity, Unforgeable] readonly attribute DOMWindow window;
+[DoNotCheckSecurity, Unforgeable, ImplementedAs=self] readonly attribute DOMWindow window;
 [Replaceable, DoNotCheckSecurityOnGetter] readonly attribute DOMWindow self;
 [Unforgeable] readonly attribute Document document;
 attribute DOMString name;
@@ -70,7 +70,7 @@
 [DoNotCheckSecurity, ForwardDeclareInHeader] void blur();
 
 // Other browsing contexts.
-[Replaceable, DoNotCheckSecurityOnGetter] readonly attribute DOMWindow frames;
+[Replaceable, DoNotCheckSecurityOnGetter, ImplementedAs=self] readonly attribute DOMWindow frames;
 [Replaceable, DoNotCheckSecurityOnGetter] readonly attribute unsigned long length;
 [DoNotCheckSecurityOnGetter, Unforgeable] readonly attribute DOMWindow? top;
 [DoNotCheckSecurityOnGetter, CustomSetter] attribute DOMWindow? opener;


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp (230076 => 230077)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp	2018-03-29 16:28:03 UTC (rev 230076)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp	2018-03-29 16:52:33 UTC (rev 230077)
@@ -962,7 +962,7 @@
 WebCore::JSMainThreadNullState state;
 g_return_val_if_fail(WEBKIT_DOM_IS_DOM_WINDOW(self), 0);
 WebCore::DOMWindow* item = WebKit::core(self);
-RefPtr gobjectResult = WTF::getPtr(item->window());
+RefPtr gobjectResult = WTF::getPtr(item->self());
 return WebKit::kit(gobjectResult.get());
 }
 
@@ -971,7 +971,7 @@
 WebCore::JSMainThreadNullState state;
 g_return_val_if_fail(WEBKIT_DOM_IS_DOM_WINDOW(self), 0);
 WebCore::DOMWindow* item = WebKit::core(self);
-RefPtr gobjectResult = WTF::getPtr(item->frames());
+RefPtr gobjectResult = WTF::getPtr(item->self());
 return WebKit::kit(gobjectResult.get());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230076] trunk/Source/WebKit

[bfulgham]

Title: [230076] trunk/Source/WebKit








Revision 230076
Author bfulg...@apple.com
Date 2018-03-29 09:28:03 -0700 (Thu, 29 Mar 2018)


Log Message
REGRESSION(r229480): ERROR: Unhandled web process message 'WebCookieManager:SetHTTPCookieAcceptPolicy'
https://bugs.webkit.org/show_bug.cgi?id=184124


Reviewed by Chris Dumez.

Cookie accept policy messages were still being sent to the WebContent process after
I removed cookie access in r229480. The WebContent process no longer recognizes these
messages, and generates logging to that effect.

This patch stops sending these unnecessary messages to the WebContent process. Only the
Network process needs to receive this information.

* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (230075 => 230076)

--- trunk/Source/WebKit/ChangeLog	2018-03-29 15:38:54 UTC (rev 230075)
+++ trunk/Source/WebKit/ChangeLog	2018-03-29 16:28:03 UTC (rev 230076)
@@ -1,3 +1,21 @@
+2018-03-29  Brent Fulgham  
+
+REGRESSION(r229480): ERROR: Unhandled web process message 'WebCookieManager:SetHTTPCookieAcceptPolicy'
+https://bugs.webkit.org/show_bug.cgi?id=184124
+
+
+Reviewed by Chris Dumez.
+
+Cookie accept policy messages were still being sent to the WebContent process after
+I removed cookie access in r229480. The WebContent process no longer recognizes these
+messages, and generates logging to that effect.
+
+This patch stops sending these unnecessary messages to the WebContent process. Only the
+Network process needs to receive this information.
+
+* UIProcess/WebCookieManagerProxy.cpp:
+(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
+
 2018-03-29  Carlos Eduardo Ramalho  
 
 [WPE] Floating point exception in WebEventFactory::createWebWheelEvent


Modified: trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp (230075 => 230076)

--- trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp	2018-03-29 15:38:54 UTC (rev 230075)
+++ trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp	2018-03-29 16:28:03 UTC (rev 230076)
@@ -252,11 +252,6 @@
 processPool()->setInitialHTTPCookieAcceptPolicy(policy);
 #endif
 
-// The policy is not sent to newly created processes (only Soup does that via setInitialHTTPCookieAcceptPolicy()). This is not a serious problem, because:
-// - When testing, we only have one WebProcess and one NetworkProcess, and WebKitTestRunner never restarts them;
-// - When not testing, Cocoa has the policy persisted, and thus new processes use it (even for ephemeral sessions).
-processPool()->sendToAllProcesses(Messages::WebCookieManager::SetHTTPCookieAcceptPolicy(policy, OptionalCallbackID()));
-
 auto callbackID = m_callbacks.put(WTFMove(callbackFunction));
 processPool()->sendToNetworkingProcess(Messages::WebCookieManager::SetHTTPCookieAcceptPolicy(policy, OptionalCallbackID(callbackID)));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230075] trunk/Tools

[zalan]

Title: [230075] trunk/Tools








Revision 230075
Author za...@apple.com
Date 2018-03-29 08:38:54 -0700 (Thu, 29 Mar 2018)


Log Message
[LayoutReloaded] Decouple formatting state and context lifetime.
https://bugs.webkit.org/show_bug.cgi?id=184136

Reviewed by Antti Koivisto.

FormattingContext is about the layout logic. We don't need to hold on to it.

* LayoutReloaded/FormattingContext/FloatingContext.js:
(FloatingContext):
(FloatingContext.prototype.computePosition):
(FloatingContext.prototype._positionForClear):
(FloatingContext.prototype._computePositionToAvoidIntrudingFloats):
(FloatingContext.prototype._addFloatingBox):
(FloatingContext.prototype._formattingContext):
(FloatingContext.prototype._formattingState):
* LayoutReloaded/FormattingContext/FormattingContext.js:
(FormattingContext):
* LayoutReloaded/FormattingState/BlockFormattingState.js:
(BlockFormattingState):
* LayoutReloaded/FormattingState/FloatingState.js:
(FloatingState):
(FloatingState.prototype.addFloating):
(FloatingState.prototype.formattingState):
(FloatingState.prototype.formattingContext): Deleted.
* LayoutReloaded/FormattingState/FormattingState.js:
(FormattingState):
(FormattingState.prototype.formattingContext): Deleted.
* LayoutReloaded/FormattingState/InlineFormattingState.js:
(InlineFormattingState):
* LayoutReloaded/LayoutState.js:
(LayoutState.prototype.layout):
(LayoutState.prototype.formattingContext):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/FormattingContext/FloatingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js
trunk/Tools/LayoutReloaded/FormattingState/BlockFormattingState.js
trunk/Tools/LayoutReloaded/FormattingState/FloatingState.js
trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js
trunk/Tools/LayoutReloaded/FormattingState/InlineFormattingState.js
trunk/Tools/LayoutReloaded/LayoutState.js




Diff

Modified: trunk/Tools/ChangeLog (230074 => 230075)

--- trunk/Tools/ChangeLog	2018-03-29 15:38:29 UTC (rev 230074)
+++ trunk/Tools/ChangeLog	2018-03-29 15:38:54 UTC (rev 230075)
@@ -1,3 +1,38 @@
+2018-03-29  Zalan Bujtas  
+
+[LayoutReloaded] Decouple formatting state and context lifetime.
+https://bugs.webkit.org/show_bug.cgi?id=184136
+
+Reviewed by Antti Koivisto.
+
+FormattingContext is about the layout logic. We don't need to hold on to it.
+
+* LayoutReloaded/FormattingContext/FloatingContext.js:
+(FloatingContext):
+(FloatingContext.prototype.computePosition):
+(FloatingContext.prototype._positionForClear):
+(FloatingContext.prototype._computePositionToAvoidIntrudingFloats):
+(FloatingContext.prototype._addFloatingBox):
+(FloatingContext.prototype._formattingContext):
+(FloatingContext.prototype._formattingState):
+* LayoutReloaded/FormattingContext/FormattingContext.js:
+(FormattingContext):
+* LayoutReloaded/FormattingState/BlockFormattingState.js:
+(BlockFormattingState):
+* LayoutReloaded/FormattingState/FloatingState.js:
+(FloatingState):
+(FloatingState.prototype.addFloating):
+(FloatingState.prototype.formattingState):
+(FloatingState.prototype.formattingContext): Deleted.
+* LayoutReloaded/FormattingState/FormattingState.js:
+(FormattingState):
+(FormattingState.prototype.formattingContext): Deleted.
+* LayoutReloaded/FormattingState/InlineFormattingState.js:
+(InlineFormattingState):
+* LayoutReloaded/LayoutState.js:
+(LayoutState.prototype.layout):
+(LayoutState.prototype.formattingContext):
+
 2018-03-28  Zalan Bujtas  
 
 [LayoutReloaded] Introduce FloatingState.


Modified: trunk/Tools/LayoutReloaded/FormattingContext/FloatingContext.js (230074 => 230075)

--- trunk/Tools/LayoutReloaded/FormattingContext/FloatingContext.js	2018-03-29 15:38:29 UTC (rev 230074)
+++ trunk/Tools/LayoutReloaded/FormattingContext/FloatingContext.js	2018-03-29 15:38:54 UTC (rev 230075)
@@ -25,17 +25,18 @@
 
 // All geometry here is absolute to the formatting context's root.
 class FloatingContext {
-constructor(floatingState) {
+constructor(floatingState, parentFormattingContext) {
 this.m_floatingState = floatingState;
+this.m_parentFormattingContext = parentFormattingContext;
 }
 
 computePosition(layoutBox) {
 if (layoutBox.isOutOfFlowPositioned())
 return;
-let displayBox = this._formattingContext().displayBox(layoutBox);
+let displayBox = this._formattingState().displayBox(layoutBox);
 if (layoutBox.isFloatingPositioned()) {
 displayBox.setTopLeft(this._positionForFloating(layoutBox));
-this._floatingState().addFloating(layoutBox);
+this._addFloatingBox(layoutBox);
 return;
 }
 if (Utils.hasClear(layoutBox))
@@ -73,7 +74,7 @@
 
 

[webkit-changes] [230074] trunk/Source/WebKit

[commit-queue]

Title: [230074] trunk/Source/WebKit








Revision 230074
Author commit-qu...@webkit.org
Date 2018-03-29 08:38:29 -0700 (Thu, 29 Mar 2018)


Log Message
[WPE] Floating point exception in WebEventFactory::createWebWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=184037

Patch by Carlos Eduardo Ramalho  on 2018-03-29
Reviewed by Žan Doberšek.

* Shared/wpe/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebWheelEvent): Use std::copysign() to avoid division by 0.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/wpe/WebEventFactory.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (230073 => 230074)

--- trunk/Source/WebKit/ChangeLog	2018-03-29 15:01:48 UTC (rev 230073)
+++ trunk/Source/WebKit/ChangeLog	2018-03-29 15:38:29 UTC (rev 230074)
@@ -1,3 +1,13 @@
+2018-03-29  Carlos Eduardo Ramalho  
+
+[WPE] Floating point exception in WebEventFactory::createWebWheelEvent
+https://bugs.webkit.org/show_bug.cgi?id=184037
+
+Reviewed by Žan Doberšek.
+
+* Shared/wpe/WebEventFactory.cpp:
+(WebKit::WebEventFactory::createWebWheelEvent): Use std::copysign() to avoid division by 0.
+
 2018-03-28  Zalan Bujtas  
 
 Make it possible to override the screen size


Modified: trunk/Source/WebKit/Shared/wpe/WebEventFactory.cpp (230073 => 230074)

--- trunk/Source/WebKit/Shared/wpe/WebEventFactory.cpp	2018-03-29 15:01:48 UTC (rev 230073)
+++ trunk/Source/WebKit/Shared/wpe/WebEventFactory.cpp	2018-03-29 15:38:29 UTC (rev 230074)
@@ -27,7 +27,7 @@
 #include "WebEventFactory.h"
 
 #include 
-#include 
+#include 
 #include 
 #include 
 
@@ -145,12 +145,12 @@
 WebCore::FloatSize delta;
 switch (event->axis) {
 case Vertical:
-wheelTicks = WebCore::FloatSize(0, event->value / std::abs(event->value));
+wheelTicks = WebCore::FloatSize(0, std::copysign(1, event->value));
 delta = wheelTicks;
 delta.scale(WebCore::Scrollbar::pixelsPerLineStep());
 break;
 case Horizontal:
-wheelTicks = WebCore::FloatSize(event->value / std::abs(event->value), 0);
+wheelTicks = WebCore::FloatSize(std::copysign(1, event->value), 0);
 delta = wheelTicks;
 delta.scale(WebCore::Scrollbar::pixelsPerLineStep());
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230073] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [230073] trunk/Source/WebCore/platform/gtk/po








Revision 230073
Author mcatanz...@igalia.com
Date 2018-03-29 08:01:48 -0700 (Thu, 29 Mar 2018)


Log Message
[l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=184132

Patch by Rafael Fontenelle  on 2018-03-29
Rubber-stamped by Michael Catanzaro.

* pt_BR.po:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/pt_BR.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (230072 => 230073)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2018-03-29 14:47:08 UTC (rev 230072)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2018-03-29 15:01:48 UTC (rev 230073)
@@ -1,3 +1,12 @@
+2018-03-29  Rafael Fontenelle  
+
+[l10n] [pt_BR] Updated Brazilian Portuguese translation
+https://bugs.webkit.org/show_bug.cgi?id=184132
+
+Rubber-stamped by Michael Catanzaro.
+
+* pt_BR.po:
+
 2018-03-04  Andika Triwidada  
 
 [l10n] Updated Indonesian translation for WebKitGTK+


Modified: trunk/Source/WebCore/platform/gtk/po/pt_BR.po (230072 => 230073)

--- trunk/Source/WebCore/platform/gtk/po/pt_BR.po	2018-03-29 14:47:08 UTC (rev 230072)
+++ trunk/Source/WebCore/platform/gtk/po/pt_BR.po	2018-03-29 15:01:48 UTC (rev 230073)
@@ -1,15 +1,15 @@
 # Brazilian Portuguese translations for WebKit package.
-# Copyright © 2017 the webkitgtk authors.
+# Copyright © 2018 the webkitgtk authors.
 # Gustavo Noronha Silva , 2009.
 # Henrique P. Machado , 2011.
 # Enrico Nicoletto , 2013.
-# Rafael Fontenelle , 2016, 2017.
+# Rafael Fontenelle , 2016-2018.
 msgid ""
 msgstr ""
 "Project-Id-Version: webkit HEAD\n"
 "Report-Msgid-Bugs-To: https://bugs.webkit.org/\n"
-"POT-Creation-Date: 2017-08-30 15:26+\n"
-"PO-Revision-Date: 2017-08-18 05:59-0200\n"
+"POT-Creation-Date: 2018-03-29 03:27+\n"
+"PO-Revision-Date: 2018-03-29 08:39-0200\n"
 "Last-Translator: Rafael Fontenelle \n"
 "Language-Team: Brazilian Portuguese \n"
 "Language: pt_BR\n"
@@ -541,14 +541,28 @@
 msgstr "autopreenchimento de informações de contato"
 
 #: ../../LocalizedStrings.cpp:630
+msgid "strong password auto fill"
+msgstr "autopreenchimento de senha forte"
+
+#: ../../LocalizedStrings.cpp:635
+#| msgid "strong password auto fill"
+msgid "strong password confirmation auto fill"
+msgstr "autopreenchimento de confirmação de senha forte"
+
+#: ../../LocalizedStrings.cpp:640
+#| msgid "strong password"
+msgid "Strong Password"
+msgstr "Senha forte"
+
+#: ../../LocalizedStrings.cpp:645
 msgid "Missing Plug-in"
 msgstr "Plug-in em falta"
 
-#: ../../LocalizedStrings.cpp:635
+#: ../../LocalizedStrings.cpp:650
 msgid "Plug-in Failure"
 msgstr "Falha em plug-in"
 
-#: ../../LocalizedStrings.cpp:640
+#: ../../LocalizedStrings.cpp:655
 msgctxt ""
 "Label text to be used if plugin is blocked by a page's Content Security "
 "Policy"
@@ -555,7 +569,7 @@
 msgid "Blocked Plug-in"
 msgstr "Plug-in bloqueado"
 
-#: ../../LocalizedStrings.cpp:645
+#: ../../LocalizedStrings.cpp:660
 msgctxt ""
 "Label text to be used when an insecure plug-in version was blocked from "
 "loading"
@@ -562,328 +576,370 @@
 msgid "Blocked Plug-in"
 msgstr "Plug-in bloqueado"
 
-#: ../../LocalizedStrings.cpp:650
+#: ../../LocalizedStrings.cpp:665
+#| msgid "Snapshotted Plug-In"
+msgctxt ""
+"Label text to be used when an unsupported plug-in was blocked from loading"
+msgid "Unsupported Plug-in"
+msgstr "Plug-in sem suporte"
+
+#: ../../LocalizedStrings.cpp:670
 #, c-format
 msgid "%d files"
 msgstr "%d arquivos"
 
-#: ../../LocalizedStrings.cpp:655
+#: ../../LocalizedStrings.cpp:675
 msgctxt "Unknown filesize FTP directory listing item"
 msgid "Unknown"
 msgstr "Desconhecido"
 
-#: ../../LocalizedStrings.cpp:674
+#: ../../LocalizedStrings.cpp:694
 #, c-format
 msgid "%s %d×%d pixels"
 msgstr "%s %d×%d pixels"
 
-#: ../../LocalizedStrings.cpp:676
+#: ../../LocalizedStrings.cpp:696
 #, c-format
 msgid " %d×%d pixels"
 msgstr " %d×%d pixels"
 
-#: ../../LocalizedStrings.cpp:682
+#: ../../LocalizedStrings.cpp:702
 msgid "Loading…"
 msgstr "Carregando…"
 
-#: ../../LocalizedStrings.cpp:687
+#: ../../LocalizedStrings.cpp:707
 msgid "Live Broadcast"
 msgstr "Transmissão ao vivo"
 
-#: ../../LocalizedStrings.cpp:693
+#: ../../LocalizedStrings.cpp:713
 msgid "audio playback"
 msgstr "Reprodução de áudio"
 
-#: ../../LocalizedStrings.cpp:695
+#: ../../LocalizedStrings.cpp:715
 msgid "video playback"
 msgstr "Reprodução de vídeo"
 
-#: ../../LocalizedStrings.cpp:697
+#: ../../LocalizedStrings.cpp:717
 msgid "mute"
 msgstr "Mudo"
 
-#: ../../LocalizedStrings.cpp:699
+#: ../../LocalizedStrings.cpp:719
 msgid "unmute"
 msgstr "Desligar mudo"
 
-#: ../../LocalizedStrings.cpp:701
+#: 

[webkit-changes] [230072] trunk/LayoutTests

[pvollan]

Title: [230072] trunk/LayoutTests








Revision 230072
Author pvol...@apple.com
Date 2018-03-29 07:47:08 -0700 (Thu, 29 Mar 2018)


Log Message
The test http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html is failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=184134

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230071 => 230072)

--- trunk/LayoutTests/ChangeLog	2018-03-29 14:13:48 UTC (rev 230071)
+++ trunk/LayoutTests/ChangeLog	2018-03-29 14:47:08 UTC (rev 230072)
@@ -1,5 +1,14 @@
 2018-03-29  Per Arne Vollan  
 
+The test http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html is failing on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=184134
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
+2018-03-29  Per Arne Vollan  
+
 The test transitions/opacity-transition-zindex.html is timing out on Windows.
 https://bugs.webkit.org/show_bug.cgi?id=184133
 


Modified: trunk/LayoutTests/platform/win/TestExpectations (230071 => 230072)

--- trunk/LayoutTests/platform/win/TestExpectations	2018-03-29 14:13:48 UTC (rev 230071)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-03-29 14:47:08 UTC (rev 230072)
@@ -3945,3 +3945,5 @@
 webkit.org/b/183955 accessibility/row-with-aria-role-in-native-table.html [ Failure ]
 
 webkit.org/b/184133 transitions/opacity-transition-zindex.html [ Skip ]
+
+webkit.org/b/184134 http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230071] trunk/LayoutTests

[pvollan]

Title: [230071] trunk/LayoutTests








Revision 230071
Author pvol...@apple.com
Date 2018-03-29 07:13:48 -0700 (Thu, 29 Mar 2018)


Log Message
The test transitions/opacity-transition-zindex.html is timing out on Windows.
https://bugs.webkit.org/show_bug.cgi?id=184133

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230070 => 230071)

--- trunk/LayoutTests/ChangeLog	2018-03-29 07:34:58 UTC (rev 230070)
+++ trunk/LayoutTests/ChangeLog	2018-03-29 14:13:48 UTC (rev 230071)
@@ -1,3 +1,12 @@
+2018-03-29  Per Arne Vollan  
+
+The test transitions/opacity-transition-zindex.html is timing out on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=184133
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2018-03-28  Antoine Quint  
 
 [Web Animations] Stop using internals.pauseTransitionAtTimeOnElement() in favor of Web Animations API for transitions tests


Modified: trunk/LayoutTests/platform/win/TestExpectations (230070 => 230071)

--- trunk/LayoutTests/platform/win/TestExpectations	2018-03-29 07:34:58 UTC (rev 230070)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-03-29 14:13:48 UTC (rev 230071)
@@ -3943,3 +3943,5 @@
 webkit.org/b/183953 imported/mozilla/css-transitions/test_keyframeeffect-getkeyframes.html [ Failure ]
 
 webkit.org/b/183955 accessibility/row-with-aria-role-in-native-table.html [ Failure ]
+
+webkit.org/b/184133 transitions/opacity-transition-zindex.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230070] trunk/Source

[commit-queue]

Title: [230070] trunk/Source








Revision 230070
Author commit-qu...@webkit.org
Date 2018-03-29 00:34:58 -0700 (Thu, 29 Mar 2018)


Log Message
Unreviewed, rolling out r230062.
https://bugs.webkit.org/show_bug.cgi?id=184128

Broke mac port. web content process crashes while loading any
web page (Requested by rniwa on #webkit).

Reverted changeset:

"MSVC __forceinline slows down JSC release build fivefold
after r229391"
https://bugs.webkit.org/show_bug.cgi?id=184062
https://trac.webkit.org/changeset/230062

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/CCallHelpers.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Compiler.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FormatConverter.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230069 => 230070)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-29 06:49:27 UTC (rev 230069)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-29 07:34:58 UTC (rev 230070)
@@ -1,3 +1,18 @@
+2018-03-29  Commit Queue  
+
+Unreviewed, rolling out r230062.
+https://bugs.webkit.org/show_bug.cgi?id=184128
+
+Broke mac port. web content process crashes while loading any
+web page (Requested by rniwa on #webkit).
+
+Reverted changeset:
+
+"MSVC __forceinline slows down JSC release build fivefold
+after r229391"
+https://bugs.webkit.org/show_bug.cgi?id=184062
+https://trac.webkit.org/changeset/230062
+
 2018-03-28  Ross Kirsling  
 
 MSVC __forceinline slows down JSC release build fivefold after r229391


Modified: trunk/Source/_javascript_Core/jit/CCallHelpers.h (230069 => 230070)

--- trunk/Source/_javascript_Core/jit/CCallHelpers.h	2018-03-29 06:49:27 UTC (rev 230069)
+++ trunk/Source/_javascript_Core/jit/CCallHelpers.h	2018-03-29 07:34:58 UTC (rev 230070)
@@ -295,9 +295,8 @@
 
 #if USE(JSVALUE64)
 
-// Avoid MSVC optimization time explosion associated with __forceinline in recursive templates.
 template
-ALWAYS_INLINE_EXCEPT_MSVC void marshallArgumentRegister(ArgCollection argSourceRegs, RegType arg, Args... args)
+ALWAYS_INLINE void marshallArgumentRegister(ArgCollection argSourceRegs, RegType arg, Args... args)
 {
 using InfoType = InfoTypeForReg;
 unsigned numArgRegisters = InfoType::numberOfArgumentRegisters;


Modified: trunk/Source/WTF/ChangeLog (230069 => 230070)

--- trunk/Source/WTF/ChangeLog	2018-03-29 06:49:27 UTC (rev 230069)
+++ trunk/Source/WTF/ChangeLog	2018-03-29 07:34:58 UTC (rev 230070)
@@ -1,3 +1,18 @@
+2018-03-29  Commit Queue  
+
+Unreviewed, rolling out r230062.
+https://bugs.webkit.org/show_bug.cgi?id=184128
+
+Broke mac port. web content process crashes while loading any
+web page (Requested by rniwa on #webkit).
+
+Reverted changeset:
+
+"MSVC __forceinline slows down JSC release build fivefold
+after r229391"
+https://bugs.webkit.org/show_bug.cgi?id=184062
+https://trac.webkit.org/changeset/230062
+
 2018-03-28  Ross Kirsling  
 
 MSVC __forceinline slows down JSC release build fivefold after r229391


Modified: trunk/Source/WTF/wtf/Compiler.h (230069 => 230070)

--- trunk/Source/WTF/wtf/Compiler.h	2018-03-29 06:49:27 UTC (rev 230069)
+++ trunk/Source/WTF/wtf/Compiler.h	2018-03-29 07:34:58 UTC (rev 230070)
@@ -178,13 +178,6 @@
 #define ALWAYS_INLINE inline
 #endif
 
-// Sometimes needed due to MSVC optimizer sensitivities.
-#if COMPILER(MSVC)
-#define ALWAYS_INLINE_EXCEPT_MSVC inline
-#else
-#define ALWAYS_INLINE_EXCEPT_MSVC ALWAYS_INLINE
-#endif
-
 /* WTF_EXTERN_C_{BEGIN, END} */
 
 #ifdef __cplusplus


Modified: trunk/Source/WebCore/ChangeLog (230069 => 230070)

--- trunk/Source/WebCore/ChangeLog	2018-03-29 06:49:27 UTC (rev 230069)
+++ trunk/Source/WebCore/ChangeLog	2018-03-29 07:34:58 UTC (rev 230070)
@@ -1,3 +1,18 @@
+2018-03-29  Commit Queue  
+
+Unreviewed, rolling out r230062.
+https://bugs.webkit.org/show_bug.cgi?id=184128
+
+Broke mac port. web content process crashes while loading any
+web page (Requested by rniwa on #webkit).
+
+Reverted changeset:
+
+"MSVC __forceinline slows down JSC release build fivefold
+after r229391"
+https://bugs.webkit.org/show_bug.cgi?id=184062
+https://trac.webkit.org/changeset/230062
+
 2018-03-28  Antoine Quint  
 
 [Web Animations] Implement more CSSPropertyBlendingClient methods


Modified: trunk/Source/WebCore/platform/graphics/FormatConverter.cpp (230069 => 230070)

--- trunk/Source/WebCore/platform/graphics/FormatConverter.cpp	2018-03-29 06:49:27 UTC (rev 230069)
+++ 

[webkit-changes] [230069] trunk/LayoutTests

[graouts]

Title: [230069] trunk/LayoutTests








Revision 230069
Author grao...@webkit.org
Date 2018-03-28 23:49:27 -0700 (Wed, 28 Mar 2018)


Log Message
[Web Animations] Stop using internals.pauseTransitionAtTimeOnElement() in favor of Web Animations API for transitions tests
https://bugs.webkit.org/show_bug.cgi?id=184097

Reviewed by Dean Jackson.

Make 55 tests opt into CSS Animations and CSS Transitions as Web Animations. These tests used the internals.pauseTransitionAtTimeOnElement()
method, but this method should be going away since the Web Animations API allows seeking and pausing. To support this, we make
transition-test-helpers.js use the Web Animations API instead of internals.pauseTransitionAtTimeOnElement() if the tests has opted
into CSS Animations and CSS Transitions as Web Animations and we know it's safe to use these APIs.

Overall, 20 of those tests used to fail with the flag on before this change.

* compositing/animation/animated-composited-inside-hidden.html:
* compositing/animation/computed-style-during-delay.html:
* compositing/reflections/nested-reflection-transition.html:
* compositing/transitions/scale-transition-no-start.html:
* compositing/transitions/singular-scale-transition.html:
* css3/calc/transitions-dependent.html:
* css3/calc/transitions.html:
* transitions/background-position-transitions.html:
* transitions/background-transitions.html:
* transitions/blendmode-transitions.html:
* transitions/border-radius-transition.html:
* transitions/clip-path-path-transitions.html:
* transitions/clip-transition.html:
* transitions/color-transition-all.html:
* transitions/color-transition-rounding.html:
* transitions/cross-fade-background-image.html:
* transitions/cubic-bezier-overflow-color.html:
* transitions/cubic-bezier-overflow-shadow.html:
* transitions/cubic-bezier-overflow-transform.html:
* transitions/default-timing-function.html:
* transitions/delay.html:
* transitions/flex-transitions.html:
* transitions/font-family-during-transition.html:
* transitions/frames-timing-function.html:
* transitions/mask-transitions.html:
* transitions/min-max-width-height-transitions.html:
* transitions/mismatched-shadow-styles.html:
* transitions/mismatched-shadow-transitions.html:
* transitions/mixed-type.html:
* transitions/move-after-transition.html:
* transitions/multiple-background-size-transitions.html:
* transitions/multiple-mask-transitions.html:
* transitions/multiple-shadow-transitions.html:
* transitions/negative-delay.html:
* transitions/opacity-transition-zindex.html:
* transitions/resources/transition-test-helpers.js:
* transitions/shape-outside-transitions.html:
* transitions/shorthand-border-transitions.html:
* transitions/shorthand-transitions.html:
* transitions/steps-timing-function.html:
* transitions/svg-layout-transition.html:
* transitions/svg-text-shadow-transition.html:
* transitions/svg-transitions.html:
* transitions/text-indent-transition.html:
* transitions/transform-op-list-match.html:
* transitions/transform-op-list-no-match.html:
* transitions/transition-end-event-rendering.html:
* transitions/transition-hit-test.html:
* transitions/transition-on-element-with-content.html:
* transitions/transition-shorthand-delay.html:
* transitions/transition-timing-function.html:
* transitions/transition-to-from-auto.html:
* transitions/transition-to-from-undefined.html:
* transitions/visited-link-color.html:
* transitions/zero-duration-in-list.html:
* transitions/zero-duration-with-non-zero-delay-start.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/animation/animated-composited-inside-hidden.html
trunk/LayoutTests/compositing/animation/computed-style-during-delay.html
trunk/LayoutTests/compositing/reflections/nested-reflection-transition.html
trunk/LayoutTests/compositing/transitions/scale-transition-no-start.html
trunk/LayoutTests/compositing/transitions/singular-scale-transition.html
trunk/LayoutTests/css3/calc/transitions-dependent.html
trunk/LayoutTests/css3/calc/transitions.html
trunk/LayoutTests/transitions/background-position-transitions.html
trunk/LayoutTests/transitions/background-transitions.html
trunk/LayoutTests/transitions/blendmode-transitions.html
trunk/LayoutTests/transitions/border-radius-transition.html
trunk/LayoutTests/transitions/clip-path-path-transitions.html
trunk/LayoutTests/transitions/clip-transition.html
trunk/LayoutTests/transitions/color-transition-all.html
trunk/LayoutTests/transitions/color-transition-rounding.html
trunk/LayoutTests/transitions/cross-fade-background-image.html
trunk/LayoutTests/transitions/cubic-bezier-overflow-color.html
trunk/LayoutTests/transitions/cubic-bezier-overflow-shadow.html
trunk/LayoutTests/transitions/cubic-bezier-overflow-transform.html
trunk/LayoutTests/transitions/default-timing-function.html
trunk/LayoutTests/transitions/delay.html
trunk/LayoutTests/transitions/flex-transitions.html
trunk/LayoutTests/transitions/font-family-during-transition.html

[webkit-changes] [230068] trunk

[graouts]

Title: [230068] trunk








Revision 230068
Author grao...@webkit.org
Date 2018-03-28 23:48:18 -0700 (Wed, 28 Mar 2018)


Log Message
[Web Animations] Implement more CSSPropertyBlendingClient methods
https://bugs.webkit.org/show_bug.cgi?id=184077

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark progressions for WPT tests.

* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
* web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:

Source/WebCore:

We only had stubs for several of the CSSPropertyBlendingClient methods and thus always implied that we
were animating non-matching transform, filter and backdrop-filter properties. We now implement those using
the same code used in KeyframeAnimation. This allows for 31 new tests to opt into the CSS Animations and
CSS Transitions as Web Animations feature.

We also ensure we only run a CSSAnimationController assertion in FrameView::didDestroyRenderTree() if
we're not using the CSS Animations and CSS Transitions as Web Animations feature.

* animation/KeyframeEffectReadOnly.cpp:
(WebCore::KeyframeEffectReadOnly::copyPropertiesFromSource):
(WebCore::KeyframeEffectReadOnly::updateBlendingKeyframes):
(WebCore::KeyframeEffectReadOnly::setBlendingKeyframes):
(WebCore::KeyframeEffectReadOnly::checkForMatchingTransformFunctionLists):
(WebCore::KeyframeEffectReadOnly::checkForMatchingFilterFunctionLists):
(WebCore::KeyframeEffectReadOnly::checkForMatchingBackdropFilterFunctionLists):
(WebCore::KeyframeEffectReadOnly::computeCSSAnimationBlendingKeyframes):
(WebCore::KeyframeEffectReadOnly::computeCSSTransitionBlendingKeyframes):
* animation/KeyframeEffectReadOnly.h:
* page/FrameView.cpp:
(WebCore::FrameView::didDestroyRenderTree):

LayoutTests:

Make 31 tests opt into the CSS Animations and CSS Transitions as Web Animations feature.

* animations/3d/replace-filling-transform.html:
* animations/additive-transform-animations.html:
* animations/animation-direction-reverse-fill-mode-hardware.html:
* animations/combo-transform-rotate+scale.html:
* animations/simultaneous-start-transform.html:
* compositing/animation/layer-for-filling-animation.html:
* compositing/reflections/animation-inside-reflection.html:
* compositing/reflections/nested-reflection-animated.html:
* css3/filters/backdrop/animation.html:
* css3/filters/composited-during-animation.html:
* css3/filters/filter-animation-from-none-hw.html:
* css3/filters/filter-animation-from-none-multi-hw.html:
* css3/filters/filter-animation-from-none-multi.html:
* css3/filters/filter-animation-from-none.html:
* css3/filters/filter-animation-hw.html:
* css3/filters/filter-animation-multi-hw.html:
* css3/filters/filter-animation-multi.html:
* css3/filters/filter-animation.html:
* css3/masking/clip-path-animation.html:
* fast/filter-image/filter-image-animation.html:
* fast/shapes/shape-outside-floats/shape-outside-animation.html:
* fast/shapes/shape-outside-floats/shape-outside-shape-image-threshold-animation.html:
* fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html:
* platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
* platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
* platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
* transitions/clip-path-transitions.html:
* transitions/color-transition-premultiplied.html:
* transitions/cross-fade-border-image.html:
* transitions/cubic-bezier-overflow-length.html:
* transitions/cubic-bezier-overflow-svg-length.html:
* transitions/delay.html:
* transitions/longhand-vs-shorthand-initial.html:
* transitions/multiple-background-transitions.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/3d/replace-filling-transform.html
trunk/LayoutTests/animations/additive-transform-animations.html
trunk/LayoutTests/animations/animation-direction-reverse-fill-mode-hardware.html
trunk/LayoutTests/animations/combo-transform-rotate+scale.html
trunk/LayoutTests/animations/simultaneous-start-transform.html
trunk/LayoutTests/compositing/animation/layer-for-filling-animation.html
trunk/LayoutTests/compositing/reflections/animation-inside-reflection.html
trunk/LayoutTests/compositing/reflections/nested-reflection-animated.html
trunk/LayoutTests/css3/filters/backdrop/animation.html
trunk/LayoutTests/css3/filters/composited-during-animation.html
trunk/LayoutTests/css3/filters/filter-animation-from-none-hw.html