[webkit-changes] [264693] trunk/Source/ThirdParty/libwebrtc
Title: [264693] trunk/Source/ThirdParty/libwebrtc
Revision 264693
Author jer.no...@apple.com
Date 2020-07-21 22:08:44 -0700 (Tue, 21 Jul 2020)
Log Message
Unreviewed build fix after r264685; copy headers to the correct path during a DEPLOYMENT_LOCATION build.
* Configurations/libwebm.xcconfig:
* libwebrtc.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (264692 => 264693)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-07-22 04:45:40 UTC (rev 264692)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-07-22 05:08:44 UTC (rev 264693)
@@ -1,5 +1,12 @@
2020-07-21 Jer Noble
+Unreviewed build fix after r264685; copy headers to the correct path during a DEPLOYMENT_LOCATION build.
+
+* Configurations/libwebm.xcconfig:
+* libwebrtc.xcodeproj/project.pbxproj:
+
+2020-07-21 Jer Noble
+
[Cocoa] Add experimental MSE WebM parser
https://bugs.webkit.org/show_bug.cgi?id=214529
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig (264692 => 264693)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig 2020-07-22 04:45:40 UTC (rev 264692)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig 2020-07-22 05:08:44 UTC (rev 264693)
@@ -8,6 +8,9 @@
HEADER_SEARCH_PATHS = Source/third_party/libwebm Source/third_party/libwebm/webm_parser Source/third_party/libwebm/webm_parser/include;
INSTALL_PATH = /usr/local/lib;
-PRIVATE_HEADERS_FOLDER_PATH = /usr/local/include;
USE_HEADERMAP = NO;
+INSTALL_HEADERS_PATH = /usr/local/include;
+LIBWEBM_HEADERS_FOLDER_PATH = $(LIBWEBM_HEADERS_FOLDER_PATH_$(DEPLOYMENT_LOCATION));
+LIBWEBM_HEADERS_FOLDER_PATH_NO = $(BUILT_PRODUCTS_DIR)/$(INSTALL_HEADERS_PATH);
+LIBWEBM_HEADERS_FOLDER_PATH_YES = $(INSTALL_HEADERS_PATH);
Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (264692 => 264693)
--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2020-07-22 04:45:40 UTC (rev 264692)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2020-07-22 05:08:44 UTC (rev 264693)
@@ -4185,8 +4185,8 @@
CDFD2FC424C4D9D10048DAC3 /* Copy webm headers */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
- dstPath = usr/local/include/webm;
- dstSubfolderSpec = 16;
+ dstPath = "$(LIBWEBM_HEADERS_FOLDER_PATH)/webm";
+ dstSubfolderSpec = 0;
files = (
CDFD2FC524C4DAF70048DAC3 /* buffer_reader.h in Copy webm headers */,
CDFD2FC624C4DAF70048DAC3 /* callback.h in Copy webm headers */,
@@ -4205,8 +4205,8 @@
CDFD2FCF24C4DB0C0048DAC3 /* Copy common headers */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
- dstPath = usr/local/include/common;
- dstSubfolderSpec = 16;
+ dstPath = "$(LIBWEBM_HEADERS_FOLDER_PATH)/common";
+ dstSubfolderSpec = 0;
files = (
CDFD2FD024C4DB2F0048DAC3 /* vp9_header_parser.h in Copy common headers */,
);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264691] trunk
Title: [264691] trunk Revision 264691 Author commit-qu...@webkit.org Date 2020-07-21 21:07:58 -0700 (Tue, 21 Jul 2020) Log Message [WebGL2] Implement multiple render target entry points https://bugs.webkit.org/show_bug.cgi?id=211156 Patch by Kenneth Russell on 2020-07-21 Reviewed by Myles C. Maxfield. Source/WebCore: Implement the drawBuffers and clearBuffer entry points. Integrate the clearBuffer APIs with preserveDrawingBuffer:false's auto-clearing. Covered by existing WebGL conformance tests. * html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::drawBuffers): (WebCore::WebGL2RenderingContext::clearBufferiv): (WebCore::WebGL2RenderingContext::clearBufferuiv): (WebCore::WebGL2RenderingContext::clearBufferfv): (WebCore::WebGL2RenderingContext::clearBufferfi): (WebCore::WebGL2RenderingContext::validateClearBuffer): (WebCore::WebGL2RenderingContext::updateBuffersToAutoClear): * html/canvas/WebGL2RenderingContext.h: * html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::drawBuffersIfNecessary): * html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::clearIfComposited): * platform/graphics/GraphicsContextGL.h: * platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLOpenGL::markLayerComposited): (WebCore::GraphicsContextGLOpenGL::drawBuffers): (WebCore::GraphicsContextGLOpenGL::clearBufferiv): (WebCore::GraphicsContextGLOpenGL::clearBufferuiv): (WebCore::GraphicsContextGLOpenGL::clearBufferfv): (WebCore::GraphicsContextGLOpenGL::clearBufferfi): * platform/graphics/opengl/GraphicsContextGLOpenGL.cpp: (WebCore::GraphicsContextGLOpenGL::resetBuffersToAutoClear): (WebCore::GraphicsContextGLOpenGL::setBuffersToAutoClear): (WebCore::GraphicsContextGLOpenGL::getBuffersToAutoClear const): * platform/graphics/opengl/GraphicsContextGLOpenGL.h: * platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp: (WebCore::GraphicsContextGLOpenGL::markLayerComposited): (WebCore::GraphicsContextGLOpenGL::drawBuffers): LayoutTests: Rebaseline one layout test which is now fully passing, and another which now properly detects errors. * fast/canvas/webgl/webgl2/sequences-expected.txt: * webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt trunk/LayoutTests/webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h trunk/Source/WebCore/html/canvas/WebGLFramebuffer.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp trunk/Source/WebCore/platform/graphics/GraphicsContextGL.h trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp Diff Modified: trunk/LayoutTests/ChangeLog (264690 => 264691) --- trunk/LayoutTests/ChangeLog 2020-07-22 02:47:29 UTC (rev 264690) +++ trunk/LayoutTests/ChangeLog 2020-07-22 04:07:58 UTC (rev 264691) @@ -1,3 +1,16 @@ +2020-07-21 Kenneth Russell + +[WebGL2] Implement multiple render target entry points +https://bugs.webkit.org/show_bug.cgi?id=211156 + +Reviewed by Myles C. Maxfield. + +Rebaseline one layout test which is now fully passing, and another +which now properly detects errors. + +* fast/canvas/webgl/webgl2/sequences-expected.txt: +* webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt: + 2020-07-21 Wenson Hsieh REGRESSION (r258871): Shift + click to extend selection loses currently selected text Modified: trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt (264690 => 264691) --- trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt 2020-07-22 02:47:29 UTC (rev 264690) +++ trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt 2020-07-22 04:07:58 UTC (rev 264691) @@ -2,6 +2,12 @@ CONSOLE MESSAGE: WebGL: INVALID_VALUE: vertexAttribI4iv: array too small CONSOLE MESSAGE: WebGL: INVALID_VALUE: vertexAttribI4uiv: array too small CONSOLE MESSAGE: WebGL: INVALID_VALUE: vertexAttribI4uiv: array too small +CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferiv: invalid array size / srcOffset +CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferiv: invalid array size / srcOffset +CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferuiv: invalid array size / srcOffset +CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferuiv: invalid array size / srcOffset +CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferfv: invalid array size / srcOffset +CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferfv: invalid array size / srcOffset PASS uniform1uiv
[webkit-changes] [264690] trunk
Title: [264690] trunk Revision 264690 Author wenson_hs...@apple.com Date 2020-07-21 19:47:29 -0700 (Tue, 21 Jul 2020) Log Message REGRESSION (r258871): Shift + click to extend selection loses currently selected text https://bugs.webkit.org/show_bug.cgi?id=214617 Reviewed by Megan Gardner. Source/WebCore: After the changes in r258871, shift clicking sometimes fails to preserve the existing selected text range on macOS and iOS. The logic in `EventHandler::handleMousePressEventSingleClick` uses the `textDistance` helper method to count the number of characters between the start of the current selection to the newly selected extent, as well as the number of characters between the end of the current selection and the newly selected extent position. It compares these two character counts, and attempts to choose the new selection extents in such a way that maximizes the amount of selected text. However, after r258871, `textDistance` uses `characterCount` instead of `TextIterator::rangeLength`. Unlike the former, `rangeLength` is robust in the case where the start position comes after the end position (in document order), since the process of creating a live `Range` object swaps the start and end if needed. This isn't the case when using `SimpleRange`. Instead, when given a simple range where the start comes after the end, `characterCount` will iterate text in the DOM, starting from the start position and ending at the end of the document rather than the end position. The result is that `characterCount` actually counts the number of characters between the start position and the end of the document, rather than the number of characters between the two positions. In the context of this bug, if the start of the current selection is "far away" (in terms of character count) from the end of the document and the new extent position comes after end of the current selection, we will end up choosing the end (instead of the start) as one of the new extents of the updated selection. To fix this (as well as other similar issues that might've arisen when replacing uses of `TextIterator::rangeLength` with `characterCount`), simply teach `characterCount` to flip the start and end positions if the end position of the `SimpleRange` comes before the start. Test: editing/selection/shift-click-includes-existing-selection.html * editing/TextIterator.cpp: (WebCore::characterCount): LayoutTests: Add a new layout test to verify that the bug does not occur. * editing/mac/spelling/autocorrection-contraction-expected.txt: Rebaseline an existing layout test, restoring the test expectations to what they were prior to r258871. It seems that the more recently added expectations (while not seemingly incorrect) were dependent on `characterCount` computing the number of characters from the start position to the end of the document, rather than the end. * editing/selection/shift-click-includes-existing-selection-expected.txt: Added. * editing/selection/shift-click-includes-existing-selection.html: Added. * resources/ui-helper.js: (window.UIHelper.activateAt.return.new.Promise): (window.UIHelper.activateAt): (window.UIHelper.activateElement): Add an optional `modifiers` argument to the `activateAt` and `activateElement` helper methods, which can be used to simulate key modifiers being held while synthesizing the "activation" (i.e. tap or click). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/mac/spelling/autocorrection-contraction-expected.txt trunk/LayoutTests/resources/ui-helper.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/TextIterator.cpp Added Paths trunk/LayoutTests/editing/selection/shift-click-includes-existing-selection-expected.txt trunk/LayoutTests/editing/selection/shift-click-includes-existing-selection.html Diff Modified: trunk/LayoutTests/ChangeLog (264689 => 264690) --- trunk/LayoutTests/ChangeLog 2020-07-22 02:09:48 UTC (rev 264689) +++ trunk/LayoutTests/ChangeLog 2020-07-22 02:47:29 UTC (rev 264690) @@ -1,3 +1,29 @@ +2020-07-21 Wenson Hsieh + +REGRESSION (r258871): Shift + click to extend selection loses currently selected text +https://bugs.webkit.org/show_bug.cgi?id=214617 + + +Reviewed by Megan Gardner. + +Add a new layout test to verify that the bug does not occur. + +* editing/mac/spelling/autocorrection-contraction-expected.txt: + +Rebaseline an existing layout test, restoring the test expectations to what they were prior to r258871. It seems +that the more recently added expectations (while not seemingly incorrect) were dependent on `characterCount` +computing the number of characters from the start position to the end of the document, rather than the end. + +* editing/selection/shift-click-includes-existing-selection-expected.txt: Added. +* editing/selection/shift-click-includes-existing-selection.html: Added. +* resources/ui-helper.js: +
[webkit-changes] [264689] trunk/Source/WebCore
Title: [264689] trunk/Source/WebCore
Revision 264689
Author achristen...@apple.com
Date 2020-07-21 19:09:48 -0700 (Tue, 21 Jul 2020)
Log Message
Fix Windows build.
https://bugs.webkit.org/show_bug.cgi?id=214623
* platform/network/curl/CertificateInfo.h:
* platform/network/curl/CertificateInfoCurl.cpp:
(WebCore::CertificateInfo::summary const):
(WebCore::CertificateInfo::summaryInfo const): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CertificateInfo.h
trunk/Source/WebCore/platform/network/curl/CertificateInfoCurl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (264688 => 264689)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 01:40:59 UTC (rev 264688)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 02:09:48 UTC (rev 264689)
@@ -1,5 +1,15 @@
2020-07-21 Alex Christensen
+Fix Windows build.
+https://bugs.webkit.org/show_bug.cgi?id=214623
+
+* platform/network/curl/CertificateInfo.h:
+* platform/network/curl/CertificateInfoCurl.cpp:
+(WebCore::CertificateInfo::summary const):
+(WebCore::CertificateInfo::summaryInfo const): Deleted.
+
+2020-07-21 Alex Christensen
+
Remove unneeded CertificateInfoBase
https://bugs.webkit.org/show_bug.cgi?id=214623
Modified: trunk/Source/WebCore/platform/network/curl/CertificateInfo.h (264688 => 264689)
--- trunk/Source/WebCore/platform/network/curl/CertificateInfo.h 2020-07-22 01:40:59 UTC (rev 264688)
+++ trunk/Source/WebCore/platform/network/curl/CertificateInfo.h 2020-07-22 02:09:48 UTC (rev 264689)
@@ -50,7 +50,7 @@
bool containsNonRootSHA1SignedCertificate() const { notImplemented(); return false; }
-Optional summaryInfo() const;
+Optional summary() const;
bool isEmpty() const { return m_certificateChain.isEmpty(); }
Modified: trunk/Source/WebCore/platform/network/curl/CertificateInfoCurl.cpp (264688 => 264689)
--- trunk/Source/WebCore/platform/network/curl/CertificateInfoCurl.cpp 2020-07-22 01:40:59 UTC (rev 264688)
+++ trunk/Source/WebCore/platform/network/curl/CertificateInfoCurl.cpp 2020-07-22 02:09:48 UTC (rev 264689)
@@ -57,7 +57,7 @@
return certificate;
}
-Optional CertificateInfo::summaryInfo() const
+Optional CertificateInfo::summary() const
{
if (!m_certificateChain.size())
return WTF::nullopt;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264688] trunk/Source/JavaScriptCore
Title: [264688] trunk/Source/_javascript_Core Revision 264688 Author mark@apple.com Date 2020-07-21 18:40:59 -0700 (Tue, 21 Jul 2020) Log Message Simplify DisallowScope, DisallowGC, and DisallowVMReentry implementations. https://bugs.webkit.org/show_bug.cgi?id=214539 Reviewed by Keith Miller. Previously, DisallowScope needed to support enabling and disabling. This was only needed to enable the implementation of ObjectInitializationScope. Now, we can make the DisallowGC and DisallowVMReentry inside ObjectInitializationScope optional with WTF::Optional. With that we can simplify these scopes and make them true RAII scope objects. This patch also does the following: 1. Renamed DisallowVMReentry to DisallowVMEntry. The scope can be used to disable VM entry completely. There's no need to restrict it to only re-entries. 2. Enforcement of DisallowVMReentry is now done in the LLInt's doVMEntry() instead of the VMEntryScope's constructor. This is a stronger guarantee. If Options::crashOnDisallowedVMEntry() is true, the VM will crash if it sees an attempt to enter the VM while disallowed. If Options::crashOnDisallowedVMEntry() is false, an attempt to call into the VM while disallowed will return immediately with an undefined result without invoking any script. By default, Options::crashOnDisallowedVMEntry() is true if ASSERT_ENABLED is true. 3. Change DisallowScope and DisallowGC to be based on ASSERT_ENABLED instead of NEBUG. 4. Make DisallowVMEntry always enforceable, not just when ASSERT_ENABLED. It's enforcement action depends on Options::crashOnDisallowedVMEntry() as described above. * CMakeLists.txt: * _javascript_Core.xcodeproj/project.pbxproj: * Sources.txt: * heap/DeferGC.cpp: * heap/DeferGC.h: (JSC::DisallowGC::DisallowGC): (JSC::DisallowGC::initialize): * interpreter/Interpreter.cpp: (JSC::Interpreter::executeProgram): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::execute): (JSC::Interpreter::executeModuleProgram): * llint/LLIntSlowPaths.cpp: (JSC::LLInt::llint_check_vm_entry_permission): * llint/LLIntSlowPaths.h: * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: * runtime/DisallowScope.h: (JSC::DisallowScope::DisallowScope): (JSC::DisallowScope::~DisallowScope): (JSC::DisallowScope::isInEffectOnCurrentThread): (JSC::DisallowScope::enable): Deleted. (JSC::DisallowScope::disable): Deleted. (JSC::DisallowScope::enterScope): Deleted. (JSC::DisallowScope::exitScope): Deleted. * runtime/DisallowVMEntry.h: Copied from Source/_javascript_Core/runtime/DisallowVMReentry.h. (JSC::DisallowVMEntryImpl::DisallowVMEntryImpl): (JSC::DisallowVMEntryImpl::~DisallowVMEntryImpl): (JSC::DisallowVMEntryImpl::isEngaged const): (JSC::DisallowVMEntryImpl::release): (JSC::DisallowVMReentry::DisallowVMReentry): Deleted. (JSC::DisallowVMReentry::initialize): Deleted. (JSC::DisallowVMReentry::scopeReentryCount): Deleted. (JSC::DisallowVMReentry::setScopeReentryCount): Deleted. * runtime/DisallowVMReentry.cpp: Removed. * runtime/DisallowVMReentry.h: Removed. * runtime/InitializeThreading.cpp: (JSC::initialize): * runtime/JSArray.cpp: (JSC::JSArray::tryCreateUninitializedRestricted): * runtime/ObjectInitializationScope.cpp: (JSC::ObjectInitializationScope::ObjectInitializationScope): (JSC::ObjectInitializationScope::notifyAllocated): (JSC::ObjectInitializationScope::notifyInitialized): * runtime/ObjectInitializationScope.h: (JSC::ObjectInitializationScope::vm const): (JSC::ObjectInitializationScope::ObjectInitializationScope): (JSC::ObjectInitializationScope::~ObjectInitializationScope): (JSC::ObjectInitializationScope::notifyAllocated): (JSC::ObjectInitializationScope::notifyInitialized): * runtime/OptionsList.h: * runtime/RegExpMatchesArray.h: (JSC::tryCreateUninitializedRegExpMatchesArray): * runtime/VM.h: * runtime/VMEntryScope.cpp: (JSC::VMEntryScope::VMEntryScope): Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/Sources.txt trunk/Source/_javascript_Core/heap/DeferGC.cpp trunk/Source/_javascript_Core/heap/DeferGC.h trunk/Source/_javascript_Core/interpreter/Interpreter.cpp trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp trunk/Source/_javascript_Core/llint/LLIntSlowPaths.h trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm trunk/Source/_javascript_Core/runtime/DisallowScope.h trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp trunk/Source/_javascript_Core/runtime/JSArray.cpp trunk/Source/_javascript_Core/runtime/ObjectInitializationScope.cpp trunk/Source/_javascript_Core/runtime/ObjectInitializationScope.h trunk/Source/_javascript_Core/runtime/OptionsList.h trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h
[webkit-changes] [264687] trunk/Tools
Title: [264687] trunk/Tools
Revision 264687
Author commit-qu...@webkit.org
Date 2020-07-21 18:11:14 -0700 (Tue, 21 Jul 2020)
Log Message
Safari does not present CertificateInfo for service-worker served documents
https://bugs.webkit.org/show_bug.cgi?id=206403
Patch by Alex Christensen on 2020-07-21
Reviewed by Brady Eidson.
This is actually just a failing test that reproduces the issue 100% of the time.
* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
* TestWebKitAPI/cocoa/HTTPServer.h:
* TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::cancel):
(TestWebKitAPI::HTTPServer::HTTPServer):
(TestWebKitAPI::m_protocol):
(TestWebKitAPI::HTTPServer::totalRequests const):
(TestWebKitAPI::HTTPServer::respondToRequests):
(TestWebKitAPI::Connection::terminate):
(TestWebKitAPI::Connection::cancel):
(TestWebKitAPI::Connection::terminate const): Deleted.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.h
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm
Diff
Modified: trunk/Tools/ChangeLog (264686 => 264687)
--- trunk/Tools/ChangeLog 2020-07-22 01:10:01 UTC (rev 264686)
+++ trunk/Tools/ChangeLog 2020-07-22 01:11:14 UTC (rev 264687)
@@ -1,3 +1,24 @@
+2020-07-21 Alex Christensen
+
+Safari does not present CertificateInfo for service-worker served documents
+https://bugs.webkit.org/show_bug.cgi?id=206403
+
+Reviewed by Brady Eidson.
+
+This is actually just a failing test that reproduces the issue 100% of the time.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+* TestWebKitAPI/cocoa/HTTPServer.h:
+* TestWebKitAPI/cocoa/HTTPServer.mm:
+(TestWebKitAPI::HTTPServer::cancel):
+(TestWebKitAPI::HTTPServer::HTTPServer):
+(TestWebKitAPI::m_protocol):
+(TestWebKitAPI::HTTPServer::totalRequests const):
+(TestWebKitAPI::HTTPServer::respondToRequests):
+(TestWebKitAPI::Connection::terminate):
+(TestWebKitAPI::Connection::cancel):
+(TestWebKitAPI::Connection::terminate const): Deleted.
+
2020-07-21 Jonathan Bedard
ImageDiff: Set ALWAYS_SEARCH_USER_PATHS to NO
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm (264686 => 264687)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm 2020-07-22 01:10:01 UTC (rev 264686)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm 2020-07-22 01:11:14 UTC (rev 264687)
@@ -30,6 +30,7 @@
#import "ServiceWorkerTCPServer.h"
#import "Test.h"
#import "TestNavigationDelegate.h"
+#import "TestUIDelegate.h"
#import "TestWKWebView.h"
#import
#import
@@ -2112,3 +2113,114 @@
}];
TestWebKitAPI::Util::run();
}
+
+#if HAVE(NETWORK_FRAMEWORK) && HAVE(TLS_PROTOCOL_VERSION_T)
+
+static bool isTestServerTrust(SecTrustRef trust)
+{
+if (!trust)
+return false;
+if (SecTrustGetCertificateCount(trust) != 1)
+return false;
+if (![adoptNS((NSString *)SecCertificateCopySubjectSummary(SecTrustGetCertificateAtIndex(trust, 0))) isEqualToString:@"Me"])
+return false;
+return true;
+}
+
+enum class ResponseType { Synthetic, Cached, Fetched };
+static void runTest(ResponseType responseType)
+{
+using namespace TestWebKitAPI;
+
+__block bool removedAnyExistingData = false;
+[[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
+removedAnyExistingData = true;
+}];
+TestWebKitAPI::Util::run();
+
+static const char* main =
+""
+"try {"
+"navigator.serviceWorker.register('/sw.js').then(function(reg) {"
+"if (reg.active) {"
+"alert('worker unexpectedly already active');"
+"return;"
+"}"
+"worker = reg.installing;"
+"worker.addEventListener('statechange', function() {"
+"if (worker.state == 'activated')"
+"alert('successfully registered');"
+"});"
+"}).catch(function(error) {"
+"alert('Registration failed with: ' + error);"
+"});"
+"} catch(e) {"
+"alert('Exception: ' + e);"
+"}"
+"";
+
+const char* js = nullptr;
+const char* expectedAlert = nullptr;
+size_t expectedServerRequests1 = 0;
+size_t expectedServerRequests2 = 0;
+
+switch (responseType) {
+case ResponseType::Synthetic:
+js = "self.addEventListener('fetch', (event) => { event.respondWith(new Response(new Blob(['alert(\"synthetic response\")'], {type: 'text/html'}))); })";
+expectedAlert = "synthetic response";
+expectedServerRequests1 = 2;
+expectedServerRequests2 = 2;
+break;
+case ResponseType::Cached:
+js = "self.addEventListener('install', (event) => { event.waitUntil(
[webkit-changes] [264686] trunk/Source/WebCore
Title: [264686] trunk/Source/WebCore
Revision 264686
Author commit-qu...@webkit.org
Date 2020-07-21 18:10:01 -0700 (Tue, 21 Jul 2020)
Log Message
Remove unneeded CertificateInfoBase
https://bugs.webkit.org/show_bug.cgi?id=214623
Patch by Alex Christensen on 2020-07-21
Reviewed by Brady Eidson.
I need to make CertificateInfo::isolatedCopy and this class was making it messy.
It has no shared functionality, so I removed it.
* Headers.cmake:
* WebCore.xcodeproj/project.pbxproj:
* inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
* platform/network/CertificateInfoBase.h: Removed.
* platform/network/CertificateSummary.h: Copied from Source/WebCore/platform/network/CertificateInfoBase.h.
(WebCore::CertificateInfoBase::containsNonRootSHA1SignedCertificate const): Deleted.
(WebCore::CertificateInfoBase::summaryInfo const): Deleted.
(WebCore::CertificateInfoBase::isEmpty const): Deleted.
* platform/network/cf/CertificateInfo.h:
* platform/network/cf/CertificateInfoCFNet.cpp:
(WebCore::CertificateInfo::summary const):
(WebCore::CertificateInfo::summaryInfo const): Deleted.
* platform/network/curl/CertificateInfo.h:
* platform/network/soup/CertificateInfo.h:
(WebCore::CertificateInfo::summary const):
(WebCore::CertificateInfo::summaryInfo const): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
trunk/Source/WebCore/platform/network/cf/CertificateInfo.h
trunk/Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp
trunk/Source/WebCore/platform/network/curl/CertificateInfo.h
trunk/Source/WebCore/platform/network/curl/CertificateInfoCurl.cpp
trunk/Source/WebCore/platform/network/curl/OpenSSLHelper.cpp
trunk/Source/WebCore/platform/network/curl/OpenSSLHelper.h
trunk/Source/WebCore/platform/network/soup/CertificateInfo.h
Added Paths
trunk/Source/WebCore/platform/network/CertificateSummary.h
Removed Paths
trunk/Source/WebCore/platform/network/CertificateInfoBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (264685 => 264686)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 00:25:09 UTC (rev 264685)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 01:10:01 UTC (rev 264686)
@@ -1,3 +1,31 @@
+2020-07-21 Alex Christensen
+
+Remove unneeded CertificateInfoBase
+https://bugs.webkit.org/show_bug.cgi?id=214623
+
+Reviewed by Brady Eidson.
+
+I need to make CertificateInfo::isolatedCopy and this class was making it messy.
+It has no shared functionality, so I removed it.
+
+* Headers.cmake:
+* WebCore.xcodeproj/project.pbxproj:
+* inspector/agents/InspectorNetworkAgent.cpp:
+(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
+* platform/network/CertificateInfoBase.h: Removed.
+* platform/network/CertificateSummary.h: Copied from Source/WebCore/platform/network/CertificateInfoBase.h.
+(WebCore::CertificateInfoBase::containsNonRootSHA1SignedCertificate const): Deleted.
+(WebCore::CertificateInfoBase::summaryInfo const): Deleted.
+(WebCore::CertificateInfoBase::isEmpty const): Deleted.
+* platform/network/cf/CertificateInfo.h:
+* platform/network/cf/CertificateInfoCFNet.cpp:
+(WebCore::CertificateInfo::summary const):
+(WebCore::CertificateInfo::summaryInfo const): Deleted.
+* platform/network/curl/CertificateInfo.h:
+* platform/network/soup/CertificateInfo.h:
+(WebCore::CertificateInfo::summary const):
+(WebCore::CertificateInfo::summaryInfo const): Deleted.
+
2020-07-21 Jer Noble
[Cocoa] Add experimental MSE WebM parser
Modified: trunk/Source/WebCore/Headers.cmake (264685 => 264686)
--- trunk/Source/WebCore/Headers.cmake 2020-07-22 00:25:09 UTC (rev 264685)
+++ trunk/Source/WebCore/Headers.cmake 2020-07-22 01:10:01 UTC (rev 264686)
@@ -1283,7 +1283,7 @@
platform/network/BlobRegistryImpl.h
platform/network/BlobResourceHandle.h
platform/network/CacheValidation.h
-platform/network/CertificateInfoBase.h
+platform/network/CertificateSummary.h
platform/network/CookieRequestHeaderFieldProxy.h
platform/network/CookieStorage.h
platform/network/Credential.h
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (264685 => 264686)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-07-22 00:25:09 UTC (rev 264685)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-07-22 01:10:01 UTC (rev 264686)
@@ -2608,7 +2608,7 @@
9175CE5C21E281ED00DF2C28 /* JSInspectorAuditDOMObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5821E281EC00DF2C28 /* JSInspectorAuditDOMObject.h */; };
9175CE5E21E281ED00DF2C27 /* InspectorAuditAccessibilityObject.h in Headers */ = {isa = PBXBuildFile; fileRef =
[webkit-changes] [264684] trunk/Source/WebCore
Title: [264684] trunk/Source/WebCore
Revision 264684
Author peng.l...@apple.com
Date 2020-07-21 17:21:25 -0700 (Tue, 21 Jul 2020)
Log Message
Safari is unresponsive after playing a video of youtube.com playlist in picture-in-picture mode
https://bugs.webkit.org/show_bug.cgi?id=214616
Reviewed by Eric Carlson.
Remove the function setPreparedToReturnVideoLayerToInline() from
MediaControlsHost.idl and replace all the calls to that function
in _javascript_ code with a call in HTMLVideoElement::fullscreenModeChanged().
Calling setPreparedToReturnVideoLayerToInline() in the _javascript_ code of
modern media controls can be problematic because the host object might have
been destroyed when the webkitpresentationmodechanged event is fired.
During the exit fullscreen/picture-in-picture transaction, missing a call to
setPreparedToReturnVideoLayerToInline() will block the transaction,
and the UI process will be stuck in a bad state.
* Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::setPreparedToReturnVideoLayerToInline): Deleted.
* Modules/mediacontrols/MediaControlsHost.h:
* Modules/mediacontrols/MediaControlsHost.idl:
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handlePresentationModeChange):
* Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.handleEvent):
(MediaController.prototype._returnMediaLayerToInlineIfNeeded): Deleted.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::fullscreenModeChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js
trunk/Source/WebCore/html/HTMLVideoElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (264683 => 264684)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 00:09:59 UTC (rev 264683)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 00:21:25 UTC (rev 264684)
@@ -1,3 +1,33 @@
+2020-07-21 Peng Liu
+
+Safari is unresponsive after playing a video of youtube.com playlist in picture-in-picture mode
+https://bugs.webkit.org/show_bug.cgi?id=214616
+
+Reviewed by Eric Carlson.
+
+Remove the function setPreparedToReturnVideoLayerToInline() from
+MediaControlsHost.idl and replace all the calls to that function
+in _javascript_ code with a call in HTMLVideoElement::fullscreenModeChanged().
+
+Calling setPreparedToReturnVideoLayerToInline() in the _javascript_ code of
+modern media controls can be problematic because the host object might have
+been destroyed when the webkitpresentationmodechanged event is fired.
+During the exit fullscreen/picture-in-picture transaction, missing a call to
+setPreparedToReturnVideoLayerToInline() will block the transaction,
+and the UI process will be stuck in a bad state.
+
+* Modules/mediacontrols/MediaControlsHost.cpp:
+(WebCore::MediaControlsHost::setPreparedToReturnVideoLayerToInline): Deleted.
+* Modules/mediacontrols/MediaControlsHost.h:
+* Modules/mediacontrols/MediaControlsHost.idl:
+* Modules/mediacontrols/mediaControlsApple.js:
+(Controller.prototype.handlePresentationModeChange):
+* Modules/modern-media-controls/media/media-controller.js:
+(MediaController.prototype.handleEvent):
+(MediaController.prototype._returnMediaLayerToInlineIfNeeded): Deleted.
+* html/HTMLVideoElement.cpp:
+(WebCore::HTMLVideoElement::fullscreenModeChanged):
+
2020-07-21 Tim Horton
REGRESSION (WebSQL disablement): Fudget app is unresponsive on launch
Modified: trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp (264683 => 264684)
--- trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp 2020-07-22 00:09:59 UTC (rev 264683)
+++ trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp 2020-07-22 00:21:25 UTC (rev 264684)
@@ -215,12 +215,6 @@
return m_mediaElement && m_mediaElement->document().isMediaDocument();
}
-void MediaControlsHost::setPreparedToReturnVideoLayerToInline(bool value)
-{
-if (m_mediaElement)
-m_mediaElement->setPreparedToReturnVideoLayerToInline(value);
-}
-
bool MediaControlsHost::userGestureRequired() const
{
return m_mediaElement && !m_mediaElement->mediaSession().playbackPermitted();
Modified: trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h (264683 => 264684)
--- trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h 2020-07-22 00:09:59 UTC (rev 264683)
+++ trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h 2020-07-22 00:21:25 UTC (rev 264684)
@@ -67,7 +67,6 @@
bool isInMediaDocument() const;
bool
[webkit-changes] [264683] trunk/LayoutTests
Title: [264683] trunk/LayoutTests
Revision 264683
Author bb...@apple.com
Date 2020-07-21 17:09:59 -0700 (Tue, 21 Jul 2020)
Log Message
Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=214619
Reviewed by Devin Rousso.
* inspector/canvas/memory-expected.txt:
* inspector/canvas/memory.html:
Canvas memory costs are not the same as on Intel macOS. Change the test to
simply check that the memory cost increases from zero-ish to not-zero.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/canvas/memory-expected.txt
trunk/LayoutTests/inspector/canvas/memory.html
Diff
Modified: trunk/LayoutTests/ChangeLog (264682 => 264683)
--- trunk/LayoutTests/ChangeLog 2020-07-21 23:45:54 UTC (rev 264682)
+++ trunk/LayoutTests/ChangeLog 2020-07-22 00:09:59 UTC (rev 264683)
@@ -1,3 +1,15 @@
+2020-07-21 Brian Burg
+
+Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon
+https://bugs.webkit.org/show_bug.cgi?id=214619
+
+Reviewed by Devin Rousso.
+
+* inspector/canvas/memory-expected.txt:
+* inspector/canvas/memory.html:
+Canvas memory costs are not the same as on Intel macOS. Change the test to
+simply check that the memory cost increases from zero-ish to not-zero.
+
2020-07-21 Yusuke Suzuki
Use CatchScope in microtask execution
Modified: trunk/LayoutTests/inspector/canvas/memory-expected.txt (264682 => 264683)
--- trunk/LayoutTests/inspector/canvas/memory-expected.txt 2020-07-21 23:45:54 UTC (rev 264682)
+++ trunk/LayoutTests/inspector/canvas/memory-expected.txt 2020-07-22 00:09:59 UTC (rev 264683)
@@ -7,5 +7,5 @@
-- Running test case: Canvas.memory.canvasMemoryChanged
Change size of canvas to 200x200.
-Memory cost of canvas updated to 166400.
+PASS: Memory cost should increase upon initially resizing canvas.
Modified: trunk/LayoutTests/inspector/canvas/memory.html (264682 => 264683)
--- trunk/LayoutTests/inspector/canvas/memory.html 2020-07-21 23:45:54 UTC (rev 264682)
+++ trunk/LayoutTests/inspector/canvas/memory.html 2020-07-22 00:09:59 UTC (rev 264683)
@@ -53,9 +53,10 @@
InspectorTest.assert(canvases.length === 1, "There should only be one canvas-2d.");
+let initialMemoryCost = canvases[0].memoryCost;
canvases[0].awaitEvent(WI.Canvas.Event.MemoryChanged)
.then((event) => {
-InspectorTest.log(`Memory cost of canvas updated to ${event.target.memoryCost}.`);
+InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas.");
})
.then(resolve, reject);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264682] trunk/Source
Title: [264682] trunk/Source
Revision 264682
Author timothy_hor...@apple.com
Date 2020-07-21 16:45:54 -0700 (Tue, 21 Jul 2020)
Log Message
REGRESSION (WebSQL disablement): Fudget app is unresponsive on launch
https://bugs.webkit.org/show_bug.cgi?id=214620
Reviewed by Geoffrey Garen.
Source/WebCore:
* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isFudget):
Source/WebKitLegacy/mac:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Add Fudget to the list of apps that can use WebSQL until linked on or after iOS 14.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (264681 => 264682)
--- trunk/Source/WebCore/ChangeLog 2020-07-21 21:33:29 UTC (rev 264681)
+++ trunk/Source/WebCore/ChangeLog 2020-07-21 23:45:54 UTC (rev 264682)
@@ -1,3 +1,15 @@
+2020-07-21 Tim Horton
+
+REGRESSION (WebSQL disablement): Fudget app is unresponsive on launch
+https://bugs.webkit.org/show_bug.cgi?id=214620
+
+
+Reviewed by Geoffrey Garen.
+
+* platform/RuntimeApplicationChecks.h:
+* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+(WebCore::IOSApplication::isFudget):
+
2020-07-21 Michael Catanzaro
Update Chrome and Firefox versions in user agent quirks
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (264681 => 264682)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2020-07-21 21:33:29 UTC (rev 264681)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2020-07-21 23:45:54 UTC (rev 264682)
@@ -88,6 +88,7 @@
WEBCORE_EXPORT bool isMiniBrowser();
bool isMobileStore();
WEBCORE_EXPORT bool isJesusCalling();
+WEBCORE_EXPORT bool isFudget();
WEBCORE_EXPORT bool isFamilyHealthApp();
bool isSpringBoard();
WEBCORE_EXPORT bool isWebProcess();
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (264681 => 264682)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-07-21 21:33:29 UTC (rev 264681)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-07-21 23:45:54 UTC (rev 264682)
@@ -272,6 +272,12 @@
return isJesusCalling;
}
+bool IOSApplication::isFudget()
+{
+static bool isFudget = applicationBundleIsEqualTo("com.dannyconnell.fudget"_s);
+return isFudget;
+}
+
bool IOSApplication::isFamilyHealthApp()
{
static bool isFamilyHealthApp = applicationBundleStartsWith("com.wildflowerhealth.Grow"_s) || applicationBundleStartsWith("com.wildflowerhealth.UGROW");
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (264681 => 264682)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-07-21 21:33:29 UTC (rev 264681)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-07-21 23:45:54 UTC (rev 264682)
@@ -1,3 +1,15 @@
+2020-07-21 Tim Horton
+
+REGRESSION (WebSQL disablement): Fudget app is unresponsive on launch
+https://bugs.webkit.org/show_bug.cgi?id=214620
+
+
+Reviewed by Geoffrey Garen.
+
+* WebView/WebPreferences.mm:
+(+[WebPreferences initialize]):
+Add Fudget to the list of apps that can use WebSQL until linked on or after iOS 14.
+
2020-07-21 Eric Carlson
Use AVRoutePickerView when available for choosing AirPlay devices
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (264681 => 264682)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-07-21 21:33:29 UTC (rev 264681)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-07-21 23:45:54 UTC (rev 264682)
@@ -396,7 +396,7 @@
bool allowsInlineMediaPlaybackAfterFullscreen = WebCore::deviceClass() != MGDeviceClassiPad;
bool requiresPlaysInlineAttribute = !allowsInlineMediaPlayback;
bool attachmentElementEnabled = IOSApplication::isMobileMail();
-bool webSQLEnabled = (IOSApplication::isFamilyHealthApp() || IOSApplication::isJesusCalling()) && applicationSDKVersion() < DYLD_IOS_VERSION_14_0;
+bool webSQLEnabled = (IOSApplication::isFamilyHealthApp() || IOSApplication::isJesusCalling() || IOSApplication::isFudget()) && applicationSDKVersion() < DYLD_IOS_VERSION_14_0;
#endif
NSDictionary *dict = [NSDictionary dictionaryWithObjectsAndKeys:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264681] trunk/Source/WebKit
Title: [264681] trunk/Source/WebKit Revision 264681 Author timothy_hor...@apple.com Date 2020-07-21 14:33:29 -0700 (Tue, 21 Jul 2020) Log Message watchOS: Web Content process crashes when it tries to open files https://bugs.webkit.org/show_bug.cgi?id=214614 Reviewed by Darin Adler. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Allow reading kern.maxfilesperproc, as it is allowed on macOS and in the Network process sandbox, and libc needs it. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Diff Modified: trunk/Source/WebKit/ChangeLog (264680 => 264681) --- trunk/Source/WebKit/ChangeLog 2020-07-21 21:10:31 UTC (rev 264680) +++ trunk/Source/WebKit/ChangeLog 2020-07-21 21:33:29 UTC (rev 264681) @@ -1,3 +1,14 @@ +2020-07-21 Tim Horton + +watchOS: Web Content process crashes when it tries to open files +https://bugs.webkit.org/show_bug.cgi?id=214614 + + +Reviewed by Darin Adler. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: +Allow reading kern.maxfilesperproc, as it is allowed on macOS and in the Network process sandbox, and libc needs it. + 2020-07-21 Per Arne Vollan [macOS] Layout tests exiting early with crashes Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (264680 => 264681) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-07-21 21:10:31 UTC (rev 264680) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-07-21 21:33:29 UTC (rev 264681) @@ -826,6 +826,7 @@ "hw.product" "kern.bootargs" "kern.hostname" +"kern.maxfilesperproc" ;; "kern.memorystatus_level" "kern.osproductversion" "kern.osrelease" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264680] trunk/Tools
Title: [264680] trunk/Tools Revision 264680 Author jbed...@apple.com Date 2020-07-21 14:10:31 -0700 (Tue, 21 Jul 2020) Log Message ImageDiff: Set ALWAYS_SEARCH_USER_PATHS to NO https://bugs.webkit.org/show_bug.cgi?id=214613 Reviewed by Dan Bernstein. * ImageDiff/cg/Configurations/Base.xcconfig: Modified Paths trunk/Tools/ChangeLog trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig Diff Modified: trunk/Tools/ChangeLog (264679 => 264680) --- trunk/Tools/ChangeLog 2020-07-21 21:10:29 UTC (rev 264679) +++ trunk/Tools/ChangeLog 2020-07-21 21:10:31 UTC (rev 264680) @@ -1,3 +1,13 @@ +2020-07-21 Jonathan Bedard + +ImageDiff: Set ALWAYS_SEARCH_USER_PATHS to NO +https://bugs.webkit.org/show_bug.cgi?id=214613 + + +Reviewed by Dan Bernstein. + +* ImageDiff/cg/Configurations/Base.xcconfig: + 2020-07-21 Youenn Fablet Fetch/XHR loads done by extensions should opt out of response sanitisation done in network process Modified: trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig (264679 => 264680) --- trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig 2020-07-21 21:10:29 UTC (rev 264679) +++ trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig 2020-07-21 21:10:31 UTC (rev 264680) @@ -29,6 +29,8 @@ USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK); USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK); +ALWAYS_SEARCH_USER_PATHS = NO; + CLANG_CXX_LANGUAGE_STANDARD = gnu++14; CLANG_CXX_LIBRARY = libc++; CLANG_ENABLE_OBJC_WEAK = YES; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264679] trunk/Source/JavaScriptCore
Title: [264679] trunk/Source/_javascript_Core
Revision 264679
Author mark@apple.com
Date 2020-07-21 14:10:29 -0700 (Tue, 21 Jul 2020)
Log Message
llint_slow_path_get_private_name() should not be using PropertySlot::InternalMethodType::VMInquiry.
https://bugs.webkit.org/show_bug.cgi?id=214603
Reviewed by Yusuke Suzuki.
VMInquiry means (1) the get operation should not call back into JS, (2) it should
not throw any exceptions (except for OutOfMemoryError or StackOverflowError which
can be thrown at any time), or have any side effects that is observable from JS
code. In this case, llint_slow_path_get_private_name() is just implementating
PrivateFieldGet (https://tc39.es/proposal-class-fields/#sec-privatefieldget) and
should actually be using PropertySlot::InternalMethodType::GetOwnProperty
(according to https://tc39.es/proposal-class-fields/#sec-privatefieldfind).
This patch makes the above change, and also adds an assert in JSObject::getPrivateField
to ensure that no one calls it for a VMInquiry since it is not supported.
Also added a PropertySlot::isVMInquiry() convenience query method.
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/JSObjectInlines.h:
(JSC::JSObject::getPrivateField):
* runtime/PropertySlot.h:
(JSC::PropertySlot::isVMInquiry const):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/JSObjectInlines.h
trunk/Source/_javascript_Core/runtime/PropertySlot.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (264678 => 264679)
--- trunk/Source/_javascript_Core/ChangeLog 2020-07-21 21:09:54 UTC (rev 264678)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-07-21 21:10:29 UTC (rev 264679)
@@ -1,3 +1,30 @@
+2020-07-21 Mark Lam
+
+llint_slow_path_get_private_name() should not be using PropertySlot::InternalMethodType::VMInquiry.
+https://bugs.webkit.org/show_bug.cgi?id=214603
+
+Reviewed by Yusuke Suzuki.
+
+VMInquiry means (1) the get operation should not call back into JS, (2) it should
+not throw any exceptions (except for OutOfMemoryError or StackOverflowError which
+can be thrown at any time), or have any side effects that is observable from JS
+code. In this case, llint_slow_path_get_private_name() is just implementating
+PrivateFieldGet (https://tc39.es/proposal-class-fields/#sec-privatefieldget) and
+should actually be using PropertySlot::InternalMethodType::GetOwnProperty
+(according to https://tc39.es/proposal-class-fields/#sec-privatefieldfind).
+
+This patch makes the above change, and also adds an assert in JSObject::getPrivateField
+to ensure that no one calls it for a VMInquiry since it is not supported.
+
+Also added a PropertySlot::isVMInquiry() convenience query method.
+
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::LLINT_SLOW_PATH_DECL):
+* runtime/JSObjectInlines.h:
+(JSC::JSObject::getPrivateField):
+* runtime/PropertySlot.h:
+(JSC::PropertySlot::isVMInquiry const):
+
2020-07-21 Keith Miller
Fix FinalizationRegistry GC finalizer interation
Modified: trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp (264678 => 264679)
--- trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp 2020-07-21 21:09:54 UTC (rev 264678)
+++ trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp 2020-07-21 21:10:29 UTC (rev 264679)
@@ -1093,7 +1093,7 @@
LLINT_CHECK_EXCEPTION();
ASSERT(property.isPrivateName());
-PropertySlot slot(baseValue, PropertySlot::InternalMethodType::VMInquiry);
+PropertySlot slot(baseValue, PropertySlot::InternalMethodType::GetOwnProperty);
asObject(baseValue)->getPrivateField(globalObject, property, slot);
LLINT_CHECK_EXCEPTION();
Modified: trunk/Source/_javascript_Core/runtime/JSObjectInlines.h (264678 => 264679)
--- trunk/Source/_javascript_Core/runtime/JSObjectInlines.h 2020-07-21 21:09:54 UTC (rev 264678)
+++ trunk/Source/_javascript_Core/runtime/JSObjectInlines.h 2020-07-21 21:10:29 UTC (rev 264679)
@@ -1,7 +1,7 @@
/*
* Copyright (C) 1999-2001 Harri Porten (por...@kde.org)
* Copyright (C) 2001 Peter Kelly (p...@post.com)
- * Copyright (C) 2003-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2003-2020 Apple Inc. All rights reserved.
* Copyright (C) 2007 Eric Seidel (e...@webkit.org)
*
* This library is free software; you can redistribute it and/or
@@ -603,6 +603,7 @@
{
VM& vm = getVM(globalObject);
auto scope = DECLARE_THROW_SCOPE(vm);
+ASSERT(!slot.isVMInquiry());
if (!JSObject::getPrivateFieldSlot(this, globalObject, propertyName, slot)) {
throwException(globalObject, scope, createInvalidPrivateNameError(globalObject));
RELEASE_AND_RETURN(scope, false);
Modified: trunk/Source/_javascript_Core/runtime/PropertySlot.h (264678 => 264679)
---
[webkit-changes] [264678] trunk/Source/WebKit
Title: [264678] trunk/Source/WebKit Revision 264678 Author pvol...@apple.com Date 2020-07-21 14:09:54 -0700 (Tue, 21 Jul 2020) Log Message [macOS] Layout tests exiting early with crashes https://bugs.webkit.org/show_bug.cgi?id=214612 Reviewed by Brent Fulgham. This is caused by the WebContent process making a syscall not allowed by the sandbox. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (264677 => 264678) --- trunk/Source/WebKit/ChangeLog 2020-07-21 21:07:40 UTC (rev 264677) +++ trunk/Source/WebKit/ChangeLog 2020-07-21 21:09:54 UTC (rev 264678) @@ -1,3 +1,15 @@ +2020-07-21 Per Arne Vollan + +[macOS] Layout tests exiting early with crashes +https://bugs.webkit.org/show_bug.cgi?id=214612 + + +Reviewed by Brent Fulgham. + +This is caused by the WebContent process making a syscall not allowed by the sandbox. + +* WebProcess/com.apple.WebProcess.sb.in: + 2020-07-21 David Kilzer WebKit::ColorSpaceData::decode() does not need default: case Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (264677 => 264678) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-07-21 21:07:40 UTC (rev 264677) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-07-21 21:09:54 UTC (rev 264678) @@ -1159,8 +1159,9 @@ (if (equal? (param "CPU") "arm64") (allow syscall-unix +(syscall-number SYS_fileport_makefd) +(syscall-number SYS_guarded_open_dprotected_np) ;; (syscall-number SYS_mremap_encrypted) -(syscall-number SYS_fileport_makefd) ) ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264677] trunk/Source/WebKit
Title: [264677] trunk/Source/WebKit Revision 264677 Author ddkil...@apple.com Date 2020-07-21 14:07:40 -0700 (Tue, 21 Jul 2020) Log Message WebKit::ColorSpaceData::decode() does not need default: case Reviewed by Darin Adler. * Shared/mac/ColorSpaceData.mm: (WebKit::ColorSpaceData::decode): - Remove default: case and add ASSERT_NOT_REACHED() and move `return false;` to bottom of the method. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/mac/ColorSpaceData.mm Diff Modified: trunk/Source/WebKit/ChangeLog (264676 => 264677) --- trunk/Source/WebKit/ChangeLog 2020-07-21 21:05:59 UTC (rev 264676) +++ trunk/Source/WebKit/ChangeLog 2020-07-21 21:07:40 UTC (rev 264677) @@ -1,3 +1,16 @@ +2020-07-21 David Kilzer + +WebKit::ColorSpaceData::decode() does not need default: case + + + +Reviewed by Darin Adler. + +* Shared/mac/ColorSpaceData.mm: +(WebKit::ColorSpaceData::decode): +- Remove default: case and add ASSERT_NOT_REACHED() and + move `return false;` to bottom of the method. + 2020-07-21 James Savage Unable to call WKScriptMessageHandlerWithReply's replyHandler with a nil errorMessage in Swift Modified: trunk/Source/WebKit/Shared/mac/ColorSpaceData.mm (264676 => 264677) --- trunk/Source/WebKit/Shared/mac/ColorSpaceData.mm 2020-07-21 21:05:59 UTC (rev 264676) +++ trunk/Source/WebKit/Shared/mac/ColorSpaceData.mm 2020-07-21 21:07:40 UTC (rev 264677) @@ -87,10 +87,10 @@ colorSpaceData.cgColorSpace = adoptCF(CGColorSpaceCreateWithICCData(data.get())); return true; } +} -default: -return false; -} +ASSERT_NOT_REACHED(); +return false; } } // namespace WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264676] trunk/Source/WebCore
Title: [264676] trunk/Source/WebCore
Revision 264676
Author commit-qu...@webkit.org
Date 2020-07-21 14:05:59 -0700 (Tue, 21 Jul 2020)
Log Message
Update Chrome and Firefox versions in user agent quirks
https://bugs.webkit.org/show_bug.cgi?id=214595
Patch by Michael Catanzaro on 2020-07-21
Reviewed by Adrian Perez de Castro.
* platform/UserAgentQuirks.cpp:
(WebCore::UserAgentQuirks::stringForQuirk):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/UserAgentQuirks.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (264675 => 264676)
--- trunk/Source/WebCore/ChangeLog 2020-07-21 21:02:58 UTC (rev 264675)
+++ trunk/Source/WebCore/ChangeLog 2020-07-21 21:05:59 UTC (rev 264676)
@@ -1,3 +1,13 @@
+2020-07-21 Michael Catanzaro
+
+Update Chrome and Firefox versions in user agent quirks
+https://bugs.webkit.org/show_bug.cgi?id=214595
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/UserAgentQuirks.cpp:
+(WebCore::UserAgentQuirks::stringForQuirk):
+
2020-07-21 Yusuke Suzuki
Use CatchScope in microtask execution
Modified: trunk/Source/WebCore/platform/UserAgentQuirks.cpp (264675 => 264676)
--- trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2020-07-21 21:02:58 UTC (rev 264675)
+++ trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2020-07-21 21:05:59 UTC (rev 264676)
@@ -180,9 +180,9 @@
switch (quirk) {
case NeedsChromeBrowser:
// Get versions from https://chromium.googlesource.com/chromium/src.git
-return "Chrome/83.0.4096.4"_s;
+return "Chrome/86.0.4208.2"_s;
case NeedsFirefoxBrowser:
-return "; rv:76.0) Gecko/20100101 Firefox/76.0"_s;
+return "; rv:80.0) Gecko/20100101 Firefox/80.0"_s;
case NeedsMacintoshPlatform:
return "Macintosh; Intel Mac OS X 10_15"_s;
case NeedsLinuxDesktopPlatform:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264675] trunk/Source/WebKit
Title: [264675] trunk/Source/WebKit Revision 264675 Author james.sav...@apple.com Date 2020-07-21 14:02:58 -0700 (Tue, 21 Jul 2020) Log Message Unable to call WKScriptMessageHandlerWithReply's replyHandler with a nil errorMessage in Swift https://bugs.webkit.org/show_bug.cgi?id=214581 Reviewed by Brady Eidson. * UIProcess/API/Cocoa/WKScriptMessageHandlerWithReply.h: Modify the block signature to allow nil for either argument. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/WKScriptMessageHandlerWithReply.h Diff Modified: trunk/Source/WebKit/ChangeLog (264674 => 264675) --- trunk/Source/WebKit/ChangeLog 2020-07-21 20:35:28 UTC (rev 264674) +++ trunk/Source/WebKit/ChangeLog 2020-07-21 21:02:58 UTC (rev 264675) @@ -1,3 +1,14 @@ +2020-07-21 James Savage + +Unable to call WKScriptMessageHandlerWithReply's replyHandler with a nil errorMessage in Swift +https://bugs.webkit.org/show_bug.cgi?id=214581 + + +Reviewed by Brady Eidson. + +* UIProcess/API/Cocoa/WKScriptMessageHandlerWithReply.h: Modify the block +signature to allow nil for either argument. + 2020-07-21 Kate Cheney Frequent Network error messages: "ResourceLoadStatisticsDatabaseStore::topPrevalentResourceWithUserInteractionDaysSinceUserInteractionStatement query failed to step, error message: no more rows available" Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKScriptMessageHandlerWithReply.h (264674 => 264675) --- trunk/Source/WebKit/UIProcess/API/Cocoa/WKScriptMessageHandlerWithReply.h 2020-07-21 20:35:28 UTC (rev 264674) +++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKScriptMessageHandlerWithReply.h 2020-07-21 21:02:58 UTC (rev 264675) @@ -87,7 +87,7 @@ - The _javascript_ promise is fulfilled with the value 42. - _javascript_ execution continues and the value 42 is returned. */ -- (void)userContentController:(WKUserContentController *)userContentController didReceiveScriptMessage:(WKScriptMessage *)message replyHandler:(void (^)(id reply, NSString *errorMessage))replyHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); +- (void)userContentController:(WKUserContentController *)userContentController didReceiveScriptMessage:(WKScriptMessage *)message replyHandler:(void (^)(id _Nullable reply, NSString *_Nullable errorMessage))replyHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); @end NS_ASSUME_NONNULL_END ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264674] trunk
Title: [264674] trunk Revision 264674 Author ysuz...@apple.com Date 2020-07-21 13:35:28 -0700 (Tue, 21 Jul 2020) Log Message Use CatchScope in microtask execution https://bugs.webkit.org/show_bug.cgi?id=214600 Reviewed by Mark Lam. Source/WebCore: Test: js/dom/microtask-drain-should-use-catch-scope.html Use CatchScope to suppress JSC_validateExceptionChecks. * bindings/js/JSMicrotaskCallback.h: (WebCore::JSMicrotaskCallback::call): LayoutTests: * js/dom/microtask-drain-should-use-catch-scope-expected.txt: Added. * js/dom/microtask-drain-should-use-catch-scope.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSMicrotaskCallback.h Added Paths trunk/LayoutTests/js/dom/microtask-drain-should-use-catch-scope-expected.txt trunk/LayoutTests/js/dom/microtask-drain-should-use-catch-scope.html Diff Modified: trunk/LayoutTests/ChangeLog (264673 => 264674) --- trunk/LayoutTests/ChangeLog 2020-07-21 19:36:56 UTC (rev 264673) +++ trunk/LayoutTests/ChangeLog 2020-07-21 20:35:28 UTC (rev 264674) @@ -1,3 +1,14 @@ +2020-07-21 Yusuke Suzuki + +Use CatchScope in microtask execution +https://bugs.webkit.org/show_bug.cgi?id=214600 + + +Reviewed by Mark Lam. + +* js/dom/microtask-drain-should-use-catch-scope-expected.txt: Added. +* js/dom/microtask-drain-should-use-catch-scope.html: Added. + 2020-07-21 Youenn Fablet NetworkConnectionToWebProcess should not handle NetworkRTCProvider messages Added: trunk/LayoutTests/js/dom/microtask-drain-should-use-catch-scope-expected.txt (0 => 264674) --- trunk/LayoutTests/js/dom/microtask-drain-should-use-catch-scope-expected.txt (rev 0) +++ trunk/LayoutTests/js/dom/microtask-drain-should-use-catch-scope-expected.txt 2020-07-21 20:35:28 UTC (rev 264674) @@ -0,0 +1,9 @@ +Use CatchScope in microtask draining + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/js/dom/microtask-drain-should-use-catch-scope.html (0 => 264674) --- trunk/LayoutTests/js/dom/microtask-drain-should-use-catch-scope.html (rev 0) +++ trunk/LayoutTests/js/dom/microtask-drain-should-use-catch-scope.html 2020-07-21 20:35:28 UTC (rev 264674) @@ -0,0 +1,13 @@ + + + + + +