[webkit-changes] [WebKit/WebKit] 263042: Implement ariaBrailleLabel and ariaBrailleRoleDesc...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 263042a5d0c6b67380c99c44f2da65f35fdfb886
https://github.com/WebKit/WebKit/commit/263042a5d0c6b67380c99c44f2da65f35fdfb886
Author: Tyler Wilcock
Date: 2024-03-01 (Fri, 01 Mar 2024)
Changed paths:
M LayoutTests/accessibility/ARIA-reflection-expected.txt
M LayoutTests/accessibility/ARIA-reflection.html
A LayoutTests/accessibility/aria-braillelabel-expected.txt
A LayoutTests/accessibility/aria-braillelabel.html
A LayoutTests/accessibility/aria-brailleroledescription-expected.txt
A LayoutTests/accessibility/aria-brailleroledescription.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AriaAttributes.idl
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/dom/ElementInternals.idl
M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
Log Message:
---
Implement ariaBrailleLabel and ariaBrailleRoleDescription element reflection
properties
https://bugs.webkit.org/show_bug.cgi?id=270387
rdar://problem/123926949
Reviewed by Chris Fleizach.
This patch also removes the DefaultARIAForCustomElementsEnabled feature
entirely, as it has been enabled by default for a year, and fixes a bug
where AXPropertyName::{BrailleLabel, BrailleRoleDescription} were not
updated after dynamic changes.
* LayoutTests/accessibility/aria-braillelabel-expected.txt: Added.
* LayoutTests/accessibility/aria-braillelabel.html: Added.
* LayoutTests/accessibility/aria-brailleroledescription-expected.txt: Added.
* LayoutTests/accessibility/aria-brailleroledescription.html: Added.
* LayoutTests/accessibility/ARIA-reflection-expected.txt:
* LayoutTests/accessibility/ARIA-reflection.html:
* LayoutTests/platform/ios/TestExpectations:
Enable new tests.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
Skip new tests.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
Remove DefaultARIAForCustomElementsEnabled.
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AriaAttributes.idl:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
* Source/WebCore/dom/ElementInternals.idl:
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::brailleLabel const):
(WTR::AccessibilityUIElement::brailleRoleDescription const):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::brailleLabel const):
(WTR::AccessibilityUIElement::brailleRoleDescription const):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::brailleLabel const):
(WTR::AccessibilityUIElement::brailleRoleDescription const):
Canonical link: https://commits.webkit.org/275591@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ca67b: Add fallback code for launching WebKit process ext...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ca67b41a22f9c7bee0aafa7a6669c710881c7e9 https://github.com/WebKit/WebKit/commit/5ca67b41a22f9c7bee0aafa7a6669c710881c7e9 Author: Per Arne Vollan Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebKit/Platform/cocoa/ExtensionCapability.h M Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.h M Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm M Source/WebKit/UIProcess/Cocoa/ExtensionCapabilityGranter.mm M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm M Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.h M Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.mm M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm M Source/WebKit/UIProcess/ProcessAssertion.h Log Message: --- Add fallback code for launching WebKit process extensions https://bugs.webkit.org/show_bug.cgi?id=270238 rdar://123774804 Reviewed by Timothy Hatcher and Chris Dumez. Add fallback code for launching WebKit process extensions. This is required to run layout tests in Simulator with WebKit ToT in certain older configurations. This fallback code is only needed on Simulator and only enabled there. * Source/WebKit/Platform/cocoa/ExtensionCapability.h: (WebKit::ExtensionCapability::platformCapability const): (WebKit::ExtensionCapability::hasPlatformCapability const): (WebKit::ExtensionCapability::platformCapabilityIsValid): (WebKit::ExtensionCapability::setPlatformCapability): * Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.h: * Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm: (WebKit::platformInvalidate): (WebKit::ExtensionCapabilityGrant::ExtensionCapabilityGrant): (WebKit::ExtensionCapabilityGrant::~ExtensionCapabilityGrant): (WebKit::ExtensionCapabilityGrant::isEmpty const): (WebKit::ExtensionCapabilityGrant::isValid const): (WebKit::ExtensionCapabilityGrant::setPlatformGrant): (WebKit::ExtensionCapabilityGrant::invalidate): * Source/WebKit/Shared/AuxiliaryProcessExtensions/GPUExtension-Info.plist: * Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-CaptivePortal-Info.plist: * Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Info.plist: * Source/WebKit/UIProcess/Cocoa/ExtensionCapabilityGranter.mm: (WebKit::grantCapability): (WebKit::grantCapabilityInternal): (WebKit::ExtensionCapabilityGranter::grant): (WebKit::ExtensionCapabilityGranter::setMediaCapabilityActive): (WebKit::ExtensionCapabilityGranter::invalidateGrants): * Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm: (WebKit::ProcessAssertion::ProcessAssertion): (WebKit::ProcessAssertion::acquireSync): (WebKit::ProcessAssertion::~ProcessAssertion): * Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.h: * Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.mm: (WebKit::ExtensionProcess::ExtensionProcess): (WebKit::ExtensionProcess::grantCapability const): (WebKit::ExtensionProcess::createVisibilityPropagationInteraction const): * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::serviceNameAndIdentifier): (WebKit::launchWithExtensionKitFallback): (WebKit::launchWithExtensionKit): * Source/WebKit/UIProcess/ProcessAssertion.h: Canonical link: https://commits.webkit.org/275590@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 531f60: Reduce further use of downcast<>() in WebCore/
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 531f600d2abe97ea53f47e829cf75bb3aaf8ca32 https://github.com/WebKit/WebKit/commit/531f600d2abe97ea53f47e829cf75bb3aaf8ca32 Author: Chris Dumez Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/dom/Position.cpp M Source/WebCore/dom/PositionIterator.cpp M Source/WebCore/rendering/LegacyLineLayout.cpp M Source/WebCore/rendering/RenderLineBreak.h M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/RenderTreeAsText.cpp Log Message: --- Reduce further use of downcast<>() in WebCore/ https://bugs.webkit.org/show_bug.cgi?id=270375 Reviewed by Brent Fulgham. Reduce further use of downcast<>() in WebCore/, for performance reasons. * Source/WebCore/dom/Position.cpp: (WebCore::Position::isCandidate const): (WebCore::Position::inlineBoxAndOffset const): * Source/WebCore/dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate const): * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::createInlineBoxForRenderer): * Source/WebCore/rendering/RenderLineBreak.h: * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteTextQuads): (WebCore::RenderObject::absoluteTextRects): * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isBR const): (WebCore::RenderObject::isWBR const): (WebCore::RenderObject::hasWBRLineBreakFlag const): * Source/WebCore/rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): Canonical link: https://commits.webkit.org/275589@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 199ca3: Avoid updating hidden page timer throttling interv...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 199ca3488158b61e977d8176fba7fcc8fd41a92e https://github.com/WebKit/WebKit/commit/199ca3488158b61e977d8176fba7fcc8fd41a92e Author: Ben Nham Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in Log Message: --- Avoid updating hidden page timer throttling interval for suspended processes https://bugs.webkit.org/show_bug.cgi?id=270236 rdar://problem/123773191 Reviewed by Chris Dumez. Currently, every time a tab is created or destroyed, we update the hidden page timer throttling interval and broadcast the change to all processes, including suspended processes. While this doesn't cause a suspended process to resume, it can cause messages to build up in IPC queues that never get drained. This is because the receiver might be a suspended WebContent process. To avoid this, skip sending the timer throttling interval to suspended processes and defer the update until the resume IPC. * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::hiddenPageThrottlingAutoIncreaseLimit): (WebKit::WebProcessPool::updateHiddenPageThrottlingAutoIncreaseLimit): * Source/WebKit/UIProcess/WebProcessPool.h: (WebKit::WebProcessPool::sendToAllProcesses): (WebKit::WebProcessPool::sendToAllProcessesForSession): (WebKit::WebProcessPool::sendToAllRemoteWorkerProcesses): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::sendProcessDidResume): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::setHiddenPageDOMTimerThrottlingIncreaseLimit): (WebKit::WebProcess::processDidResume): * Source/WebKit/WebProcess/WebProcess.h: * Source/WebKit/WebProcess/WebProcess.messages.in: Canonical link: https://commits.webkit.org/275588@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0a503c: AX: Parse "strong" and "emphasis" ARIA roles into ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0a503cce2c6efd211ed834279893a9c616025049 https://github.com/WebKit/WebKit/commit/0a503cce2c6efd211ed834279893a9c616025049 Author: Tyler Wilcock Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/roles-expected.txt M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm Log Message: --- AX: Parse "strong" and "emphasis" ARIA roles into internal role representation https://bugs.webkit.org/show_bug.cgi?id=270369 rdar://problem/123912792 Reviewed by Chris Fleizach. This patch parses the "strong" and "emphasis" ARIA roles into a new internal AccessibilityRole interpretation. Note that this patch does not actually hook them up into platform representations for AT consumption (we'll need to decide the best way to do that in a future patch). * LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/roles-expected.txt: Pass two more testcases. * Source/WebCore/accessibility/AXCoreObject.h: (WebCore::accessibilityRoleToString): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::initializeRoleMap): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]): * Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm: (WebCore::Accessibility::createPlatformRoleMap): Canonical link: https://commits.webkit.org/275587@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 48ca65: Provide private relay information via the didExcee...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 48ca65b1890052e3e0212e6a2608f0bc079bd98c https://github.com/WebKit/WebKit/commit/48ca65b1890052e3e0212e6a2608f0bc079bd98c Author: Ben Nham Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/MemoryFootprintThreshold.mm Log Message: --- Provide private relay information via the didExceedMemoryFootprintThreshold callback https://bugs.webkit.org/show_bug.cgi?id=270304 rdar://123799163 Reviewed by Chris Dumez. In 274733@main we added a callback which helps us observe when WebContent processes exceed certain key memory thresholds in the field. After further discussion, we decided that we need that event to carry state about whether any of the page loads in the process were private relayed or not, so we're adding that here. * Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didExceedMemoryFootprintThreshold): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h: (WebKit::WebsiteDataStoreClient::didExceedMemoryFootprintThreshold): * Tools/TestWebKitAPI/Tests/WebKitCocoa/MemoryFootprintThreshold.mm: (-[MemoryFootprintDelegate websiteDataStore:domain:didExceedMemoryFootprintThreshold:withPageCount:processLifetime:inForeground:wasPrivateRelayed:]): (-[MemoryFootprintDelegate websiteDataStore:domain:didExceedMemoryFootprintThreshold:withPageCount:processLifetime:inForeground:]): Deleted. Canonical link: https://commits.webkit.org/275586@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 914621: Unreviewed, reverting 275551@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91462164b1315831afbd066050f1a6098f702485 https://github.com/WebKit/WebKit/commit/91462164b1315831afbd066050f1a6098f702485 Author: Robert Jenner Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/Sources.txt M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/BrowsingContextGroup.h R Source/WebKit/UIProcess/FrameProcess.cpp R Source/WebKit/UIProcess/FrameProcess.h M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp M Source/WebKit/UIProcess/ProvisionalFrameProxy.h M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/RemotePageProxy.h A Source/WebKit/UIProcess/RemotePageProxyState.h M Source/WebKit/UIProcess/SuspendedPageProxy.cpp M Source/WebKit/UIProcess/SuspendedPageProxy.h M Source/WebKit/UIProcess/WebFrameProxy.cpp M Source/WebKit/UIProcess/WebFrameProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Unreviewed, reverting 275551@main https://bugs.webkit.org/show_bug.cgi?id=270384 rdar://123925831 REGRESSION(275551@main): 3X API-Tests broke across all testing queues, 15X Layout-tests are now broken on site-isolation queues Reverted change: Clean up site isolation process selection logic https://bugs.webkit.org/show_bug.cgi?id=270045 rdar://116202371 https://commits.webkit.org/275551@main Canonical link: https://commits.webkit.org/275585@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 067f08: Use smart pointers in Modules/WebGPU
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 067f08a43f10286e6d769a0b31847652244fbead https://github.com/WebKit/WebKit/commit/067f08a43f10286e6d769a0b31847652244fbead Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUBindGroupDescriptor.h M Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.h M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp M Source/WebCore/Modules/WebGPU/GPUBuffer.h M Source/WebCore/Modules/WebGPU/GPUBufferBinding.h M Source/WebCore/Modules/WebGPU/GPUCanvasConfiguration.h M Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrites.h M Source/WebCore/Modules/WebGPU/GPUImageCopyBuffer.h M Source/WebCore/Modules/WebGPU/GPUImageCopyTexture.h M Source/WebCore/Modules/WebGPU/GPUPresentationContext.cpp M Source/WebCore/Modules/WebGPU/GPUProgrammableStage.h M Source/WebCore/Modules/WebGPU/GPUQuerySet.h M Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h M Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.h M Source/WebCore/Modules/WebGPU/GPURenderPassDescriptor.h M Source/WebCore/Modules/WebGPU/GPURenderPassTimestampWrites.h M Source/WebCore/Modules/WebGPU/GPUShaderModule.h M Source/WebCore/Modules/WebGPU/GPUTexture.h M Source/WebCore/Modules/WebGPU/GPUTextureView.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroupDescriptor.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroupLayout.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBuffer.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBufferBinding.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCanvasConfiguration.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampWrites.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUDevice.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUImageCopyBuffer.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUImageCopyTexture.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineDescriptorBase.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineLayout.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUProgrammableStage.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQuerySet.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDepthStencilAttachment.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDescriptor.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassTimestampWrites.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUShaderModule.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTexture.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTextureView.h M Source/WebKit/Shared/WebGPU/WebGPUBindGroupDescriptor.cpp M Source/WebKit/Shared/WebGPU/WebGPUBufferBinding.cpp M Source/WebKit/Shared/WebGPU/WebGPUCanvasConfiguration.cpp M Source/WebKit/Shared/WebGPU/WebGPUComputePassTimestampWrites.cpp M Source/WebKit/Shared/WebGPU/WebGPUImageCopyBuffer.cpp M Source/WebKit/Shared/WebGPU/WebGPUImageCopyTexture.cpp M Source/WebKit/Shared/WebGPU/WebGPUPipelineDescriptorBase.cpp M Source/WebKit/Shared/WebGPU/WebGPUProgrammableStage.cpp M Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.cpp M Source/WebKit/Shared/WebGPU/WebGPURenderPassTimestampWrites.cpp Log Message: --- Use smart pointers in Modules/WebGPU https://bugs.webkit.org/show_bug.cgi?id=270378 rdar://123810573 Reviewed by Mike Wyrzykowski. * Source/WebCore/Modules/WebGPU/GPUBindGroupDescriptor.h: (): Deleted. * Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.h: * Source/WebCore/Modules/WebGPU/GPUBuffer.cpp: (WebCore::makeArrayBuffer): (WebCore::GPUBuffer::unmap): * Source/WebCore/Modules/WebGPU/GPUBuffer.h: * Source/WebCore/Modules/WebGPU/GPUBufferBinding.h: * Source/WebCore/Modules/WebGPU/GPUCanvasConfiguration.h: * Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrites.h: * Source/WebCore/Modules/WebGPU/GPUImageCopyBuffer.h: (): Deleted. * Source/WebCore/Modules/WebGPU/GPUImageCopyTexture.h: * Source/WebCore/Modules/WebGPU/GPUPresentationContext.cpp: (WebCore::GPUPresentationContext::configure): * Source/WebCore/Modules/WebGPU/GPUProgrammableStage.h: (): Deleted. * Source/WebCore/Modules/WebGPU/GPUQuerySet.h: * Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h: * Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.h: * Source/WebCore/Modules/WebGPU/GPURenderPassDescriptor.h: (): Deleted. * Source/WebCore/Modules/WebGPU/GPURenderPassTimestampWrites.h: * Source/WebCore/Modules/WebGPU/GPUShaderModule.h: * Source/WebCore/Modules/WebGPU/GPUTexture.h: * Source/WebCore/Modules/WebGPU/GPUTextureView.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampWrites.h: *
[webkit-changes] [WebKit/WebKit] 43475b: Add test using loadHTMLString with site isolation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43475b58f7c91962c5dad360a4b12076054461d1 https://github.com/WebKit/WebKit/commit/43475b58f7c91962c5dad360a4b12076054461d1 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Add test using loadHTMLString with site isolation https://bugs.webkit.org/show_bug.cgi?id=270372 rdar://123914567 Reviewed by Charlie Wolfe. * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275583@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85712d: PresentationContextIOSurface::present should do no...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85712d7f2f1965e3772b2173bcb1fba6e99e7a46 https://github.com/WebKit/WebKit/commit/85712d7f2f1965e3772b2173bcb1fba6e99e7a46 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/present-without-compute-pipeline-expected.txt A LayoutTests/fast/webgpu/present-without-compute-pipeline.html M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm Log Message: --- PresentationContextIOSurface::present should do nothing if there is no compute pipeline state https://bugs.webkit.org/show_bug.cgi?id=270367 rdar://123912101 Reviewed by Mike Wyrzykowski. There is nothing to do if there is no compute pipeline, but we don't want to dereference null. * LayoutTests/fast/webgpu/present-without-compute-pipeline-expected.txt: Added. * LayoutTests/fast/webgpu/present-without-compute-pipeline.html: Added. * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: Canonical link: https://commits.webkit.org/275582@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 198cfb: Assertion failure in ~CompletionHandler() via Imag...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 198cfb4f193cbb0a55f2cc4e6c4a474f19f9162f https://github.com/WebKit/WebKit/commit/198cfb4f193cbb0a55f2cc4e6c4a474f19f9162f Author: Ryosuke Niwa Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A LayoutTests/fast/images/create-image-bitmap-after-stopping-script-execution-context-expected.txt A LayoutTests/fast/images/create-image-bitmap-after-stopping-script-execution-context.html M Source/WebCore/html/ImageBitmap.cpp Log Message: --- Assertion failure in ~CompletionHandler() via ImageBitmap::createCompletionHandler https://bugs.webkit.org/show_bug.cgi?id=270379 Reviewed by Wenson Hsieh. Call the completion handler when exiting early in PendingImageBitmap::fetch. * LayoutTests/fast/images/create-image-bitmap-after-stopping-script-execution-context-expected.txt: Added. * LayoutTests/fast/images/create-image-bitmap-after-stopping-script-execution-context.html: Added. * Source/WebCore/html/ImageBitmap.cpp: Canonical link: https://commits.webkit.org/275581@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 74f965: [Gardening]: NEW TEST (269900@main): [ macOS wk1 ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74f9655cf4fc2fe1ced5006c580ad1753a617350 https://github.com/WebKit/WebKit/commit/74f9655cf4fc2fe1ced5006c580ad1753a617350 Author: Marta Darbinyan Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: NEW TEST (269900@main): [ macOS wk1 ] fast/images/jpegxl-with-color-profile.html is a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=270385 rdar://123925415 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/275580@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ee754d: Consecutive calls to `-insertTextAlternatives:` sh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee754d7dfc571ca86d2785731e52091ccaab308b https://github.com/WebKit/WebKit/commit/ee754d7dfc571ca86d2785731e52091ccaab308b Author: Wenson Hsieh Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/editing/Editor.cpp M Source/WebCore/page/EditorClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h M Source/WebKit/WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Tools/TestWebKitAPI/Tests/ios/TextAlternatives.mm M Tools/TestWebKitAPI/cocoa/TestWKWebView.h M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm Log Message: --- Consecutive calls to `-insertTextAlternatives:` should not cause dictation underlines to disappear https://bugs.webkit.org/show_bug.cgi?id=270370 rdar://107087527 Reviewed by Abrar Rahman Protyasha. Add support for preserving dictation underlines when UIKit calls into `-insertTextAlternatives:`, while finalizing dictation results. Currently, UIKit only calls into `-insertText:` with the best alternative for the dictated text, which loses all information about dictation alternatives (along with the blue dotted underlines). While there's public API on `UITextInput` to `-insertDictationResults:` which we _could_ implement, the suggestions will eventually be shown by UIKit when tapping on a dictation alternative range via `-alternativesForSelectedText`, which means that we would need to convert `UIDictationPhrase` objects into `BETextAlternatives` — something that's not possible without introducing new API surface in BrowserEngineKit. Instead, UIKit will be inserting text alternatives in the form of `BETextAlternatives` (or `NSTextAlternatives` in the case where BrowserEngineKit integration is disabled), which we'll honor by adding dictation alternative document markers. Test: TextAlternatives.InsertDictationResultsAsAlternatives * Source/WebCore/editing/Editor.cpp: (WebCore::Editor::updateMarkersForWordsAffectedByEditing): Prevent dictation markers from being removed as a result of inserting plain text, while finalizing dictation results. * Source/WebCore/page/EditorClient.h: (WebCore::EditorClient::shouldRemoveDictationAlternativesAfterEditing const): * Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h: * Source/WebKit/WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm: (WebKit::WebEditorClient::shouldRemoveDictationAlternativesAfterEditing const): * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::shouldRemoveDictationAlternativesAfterEditing const): * Tools/TestWebKitAPI/Tests/ios/TextAlternatives.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/cocoa/TestWKWebView.h: * Tools/TestWebKitAPI/cocoa/TestWKWebView.mm: Add an API test to exercise this change. (-[WKWebView insertText:alternatives:]): Canonical link: https://commits.webkit.org/275579@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 38b6c3: [Skia] Implement FontPlatformData::openTypeTable
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 38b6c344ecebfc290a84fb05f7bd20daeb24c618 https://github.com/WebKit/WebKit/commit/38b6c344ecebfc290a84fb05f7bd20daeb24c618 Author: Patrick Griffis Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp Log Message: --- [Skia] Implement FontPlatformData::openTypeTable https://bugs.webkit.org/show_bug.cgi?id=270301 Reviewed by Carlos Garcia Campos. Compared against freetype's implementation. * Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp: (WebCore::FontPlatformData::openTypeTable const): Canonical link: https://commits.webkit.org/275578@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] afa8e8: IPC testing API tries to allocate JS objects durin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: afa8e8e258fb316ecce5e0ce6d74695a07b66263 https://github.com/WebKit/WebKit/commit/afa8e8e258fb316ecce5e0ce6d74695a07b66263 Author: Ryosuke Niwa Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp Log Message: --- IPC testing API tries to allocate JS objects during sweeping https://bugs.webkit.org/show_bug.cgi?id=270328 Reviewed by Mark Lam. Delay the IPC until the next run loop to avoid sending in the middle of sweeping. * Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp: (WebKit::WebSWClientConnection::removeServiceWorkerRegistrationInServer): Canonical link: https://commits.webkit.org/275577@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 81d159: Get rid of downcast>() in ScopedEventQueue::enqueu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81d1596b36a9ff46ad8b39607e02e72deafcab4d https://github.com/WebKit/WebKit/commit/81d1596b36a9ff46ad8b39607e02e72deafcab4d Author: Chris Dumez Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/dom/EventDispatcher.cpp M Source/WebCore/dom/ScopedEventQueue.cpp M Source/WebCore/dom/ScopedEventQueue.h Log Message: --- Get rid of downcast>() in ScopedEventQueue::enqueueEvent() https://bugs.webkit.org/show_bug.cgi?id=270371 Reviewed by Ryosuke Niwa. * Source/WebCore/dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchScopedEvent): * Source/WebCore/dom/ScopedEventQueue.cpp: (WebCore::ScopedEventQueue::enqueueEvent): * Source/WebCore/dom/ScopedEventQueue.h: Canonical link: https://commits.webkit.org/275576@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c4f36: [Gardening]: REGRESSION (268354@main): [ macOS wk1...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c4f36a585151562ba1d5b27967c9b304700a46e https://github.com/WebKit/WebKit/commit/3c4f36a585151562ba1d5b27967c9b304700a46e Author: Marta Darbinyan Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: REGRESSION (268354@main): [ macOS wk1 ] fast/hidpi/filters-drop-shadow.html is a consistent failure with image diff https://bugs.webkit.org/show_bug.cgi?id=270380 rdar://123922421 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/275575@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c592c: Crash under ScrollingStateFixedNode::reconcileLaye...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c592c9b1e0c09a411af9b26f6a3e32a2c36a1fd https://github.com/WebKit/WebKit/commit/0c592c9b1e0c09a411af9b26f6a3e32a2c36a1fd Author: Nikolaos Mouchtaris Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp Log Message: --- Crash under ScrollingStateFixedNode::reconcileLayerPositionForViewportRect https://bugs.webkit.org/show_bug.cgi?id=270361 rdar://105887621 Reviewed by Simon Fraser. We need a similar fix to https://github.com/WebKit/WebKit/pull/17453 as there is the same crash signature under ScrollingStateFixedNode::reconcileLayerPositionForViewportRect this time. * Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp: (WebCore::ScrollingStateFixedNode::reconcileLayerPositionForViewportRect): Canonical link: https://commits.webkit.org/275574@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 228eeb: Address thread safety issue in log forwarding
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 228eebbe8b431b55d009517b892fb427b7d7c51e https://github.com/WebKit/WebKit/commit/228eebbe8b431b55d009517b892fb427b7d7c51e Author: Per Arne Vollan Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Address thread safety issue in log forwarding https://bugs.webkit.org/show_bug.cgi?id=270366 rdar://123748756 Reviewed by Chris Dumez. Use dispatch_once to synchronize access to the log worker queue from multiple threads. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::logQueue): (WebKit::registerLogHook): Canonical link: https://commits.webkit.org/275573@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4caf2b: Simplify handling addGrant result when granting st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4caf2bb34aabd431779463073135592c6f1f9740 https://github.com/WebKit/WebKit/commit/4caf2bb34aabd431779463073135592c6f1f9740 Author: Matthew Finkel Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp Log Message: --- Simplify handling addGrant result when granting storage access https://bugs.webkit.org/show_bug.cgi?id=270208 rdar://123728856 Reviewed by Charlie Wolfe. In 271821@main I added support for granting storage access for a group of domains. This change simplifies part of that logic. * Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp: (WebKit::ResourceLoadStatisticsStore::grantStorageAccess): Canonical link: https://commits.webkit.org/275572@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b854fb: Add JetStream2.2 plan file and make it default pla...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b854fb9084746cd16f71b002e2062d9e02e9cc73 https://github.com/WebKit/WebKit/commit/b854fb9084746cd16f71b002e2062d9e02e9cc73 Author: Dewei Zhu Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.2.plan M Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan Log Message: --- Add JetStream2.2 plan file and make it default plan file for JestStream2 https://bugs.webkit.org/show_bug.cgi?id=270373 rdar://123915656 Reviewed by Yusuke Suzuki. JetStream2.2 contains couple fixes, let's add JetStream2.2 plan file and make it default plan file for JestStream2. * Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.2.plan: Added. * Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Canonical link: https://commits.webkit.org/275571@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0291f2: [JSC] Remove some hot CommonSlowPaths
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0291f234c90dc4d75b73075976f14d2a94878d73 https://github.com/WebKit/WebKit/commit/0291f234c90dc4d75b73075976f14d2a94878d73 Author: Yusuke Suzuki Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITInlines.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/jit/JITOperations.cpp M Source/JavaScriptCore/jit/JITOperations.h M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp M Source/JavaScriptCore/llint/LLIntSlowPaths.h M Source/JavaScriptCore/llint/LowLevelInterpreter.asm M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp M Source/JavaScriptCore/runtime/CommonSlowPaths.h Log Message: --- [JSC] Remove some hot CommonSlowPaths https://bugs.webkit.org/show_bug.cgi?id=270363 rdar://123909602 Reviewed by Alexey Shvayka. CommonSlowPaths is always slower than normal operations in Baseline JIT since CommonSlowPaths accesses a lot of data like bytecode etc. This is OK for rare operations, but not OK for hot operations. This patch made following opcodes using operations. They are picked based on trace data. 1. op_create_lexical_environment 2. op_create_direct_arguments 3. op_create_scoped_arguments 4. op_create_cloned_arguments And move CommonSlowPaths for them to LLIntSlowPaths. Since LLInt needs to access to these bytecode etc. to retrieve information (JIT can skip it), SlowPath performance is the same to operations. * Source/JavaScriptCore/jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITOpcodes.cpp: (JSC::JIT::emit_op_create_lexical_environment): (JSC::JIT::emit_op_create_direct_arguments): (JSC::JIT::emit_op_create_scoped_arguments): (JSC::JIT::emit_op_create_cloned_arguments): * Source/JavaScriptCore/jit/JITOperations.cpp: (JSC::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/jit/JITOperations.h: * Source/JavaScriptCore/llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): * Source/JavaScriptCore/llint/LLIntSlowPaths.h: * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: * Source/JavaScriptCore/runtime/CommonSlowPaths.cpp: * Source/JavaScriptCore/runtime/CommonSlowPaths.h: Canonical link: https://commits.webkit.org/275570@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 252805: [Gardening]: REGRESSION (269807@main): [ MacOS Deb...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25280538e86a374586165396614d5fc3ff4287e2 https://github.com/WebKit/WebKit/commit/25280538e86a374586165396614d5fc3ff4287e2 Author: Jay Stfleur Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (269807@main): [ MacOS Debug x86_64 ] fast/mediastream/microphone-change-while-muted.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=123912735 rdar://123912735 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275569@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 56f214: [WebGPU] Remove duplicate typeError when a bottom ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 56f2145d88f7f995e572dc334dbeb43a56969951 https://github.com/WebKit/WebKit/commit/56f2145d88f7f995e572dc334dbeb43a56969951 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: --- [WebGPU] Remove duplicate typeError when a bottom type is a member of a struct https://bugs.webkit.org/show_bug.cgi?id=270350 rdar://123898425 Reviewed by Tadeu Zagallo. An error was already generated when the bottom type was inferred * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): Canonical link: https://commits.webkit.org/275568@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f76c5: Use WeakPtr for members of GPUDeviceVideoFrameRequ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f76c56c5655b26ed84f9f1b1d03a59c87e74885 https://github.com/WebKit/WebKit/commit/4f76c56c5655b26ed84f9f1b1d03a59c87e74885 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUDevice.cpp M Source/WebCore/Modules/WebGPU/GPUDevice.h Log Message: --- Use WeakPtr for members of GPUDeviceVideoFrameRequestCallback https://bugs.webkit.org/show_bug.cgi?id=270362 rdar://123908079 Reviewed by Mike Wyrzykowski. This makes it more robust against lifetime issues. * Source/WebCore/Modules/WebGPU/GPUDevice.cpp: * Source/WebCore/Modules/WebGPU/GPUDevice.h: Canonical link: https://commits.webkit.org/275567@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c26d0a: WebCore::AutoscrollType should be an enum class
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c26d0af2b563850ca7d0cc8138c19a95a0b258b9 https://github.com/WebKit/WebKit/commit/c26d0af2b563850ca7d0cc8138c19a95a0b258b9 Author: Abrar Rahman Protyasha Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/page/AutoscrollController.cpp M Source/WebCore/page/AutoscrollController.h Log Message: --- WebCore::AutoscrollType should be an enum class https://bugs.webkit.org/show_bug.cgi?id=270337 rdar://123890042 Reviewed by Aditya Keerthi. This is a mechanical patch converting WebCore::AutoscrollType to an enum class. We also take the liberty to rename individual cases now that they will always be prefixed with AutoscrollType::. * Source/WebCore/page/AutoscrollController.cpp: (WebCore::AutoscrollController::autoscrollInProgress const): (WebCore::AutoscrollController::startAutoscrollForSelection): (WebCore::AutoscrollController::stopAutoscrollTimer): (WebCore::AutoscrollController::updateDragAndDrop): (WebCore::AutoscrollController::didPanScrollStart): (WebCore::AutoscrollController::didPanScrollStop): (WebCore::AutoscrollController::handleMouseReleaseEvent): (WebCore::AutoscrollController::panScrollInProgress const): (WebCore::AutoscrollController::startPanScrolling): (WebCore::AutoscrollController::autoscrollTimerFired): (WebCore::AutoscrollController::updatePanScrollState): * Source/WebCore/page/AutoscrollController.h: Canonical link: https://commits.webkit.org/275566@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c33c6: Sever opener link for windows with an openee on ma...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c33c64d1ef537430380dad36728614f7ce77e6c https://github.com/WebKit/WebKit/commit/7c33c64d1ef537430380dad36728614f7ce77e6c Author: Ben Nham Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebProcessPool.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- Sever opener link for windows with an openee on manual navigation https://bugs.webkit.org/show_bug.cgi?id=270249 rdar://122506395 Reviewed by Chris Dumez. When a parent window uses window.open to create a child window, and the child window isn't closed, currently that causes all future navigations in the parent window to remain in the same process. In the case of a cross-origin manual navigation (e.g. navigation via the address bar), it should be safe to allow a process swap, as per the discussion here: https://github.com/whatwg/html/issues/5767#issuecomment-763855860 Note that Safari already almost always already has this behavior even though we don't do this at the engine level, since most location bar navigations occur in a new WKWebView. The new WKWebView has no opener link to the openee and loads in a different process. So there shouldn't be any new compatibility issues with doing this at the engine level as well. See also 272321@main, where we did this for the opposite case (allowing a window with an opener to process swap on a cross-origin manual navigation). * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigationInternal): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/275565@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8865cd: [webkitpy] Check if directory is writeable before ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8865cdb1ab930924c2e0480bfa376f3d8af09b93 https://github.com/WebKit/WebKit/commit/8865cdb1ab930924c2e0480bfa376f3d8af09b93 Author: Alex Atwater Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/__init__.py Log Message: --- [webkitpy] Check if directory is writeable before installing required libraries rdar://123836656 Reviewed by Jonathan Bedard. If tooling is mounted in a read-only location, it should instead install tooling at ~/Library/webkitpy * Tools/Scripts/webkitpy/__init__.py: Canonical link: https://commits.webkit.org/275564@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d7be2: AX: Avoid work in BitmapImage::canAnimate if anima...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d7be2a5f983adaea21751f2574e605802cd https://github.com/WebKit/WebKit/commit/1d7be2a5f983adaea21751f2574e605802cd Author: Joshua Hoffman Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/loader/cache/CachedImage.cpp M Source/WebCore/page/ContextMenuController.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/platform/graphics/BitmapImage.cpp M Source/WebCore/platform/graphics/Image.cpp M Source/WebCore/platform/graphics/Image.h M Source/WebCore/testing/Internals.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Tools/TestWebKitAPI/Tests/WebKit/AnimationControl.mm Log Message: --- AX: Avoid work in BitmapImage::canAnimate if animation controls are disabled https://bugs.webkit.org/show_bug.cgi?id=270136 rdar://109646792 Reviewed by Tyler Wilcock. Before this patch, the expensive work that happens in BitmapImage::canAnimate would unnecessarily occur in two cases: (1) if the image has a single-frame and (2) if image animation controls were not enabled. This patch exits early from this code path if either of those two things are true. This will improve performance for users both with and without the controls enabled. Moving `systemAllowsAnimationControls` to a static global variable on `Image` also allows us to remove the method of the same name from `Page`, since this does not need to be a per-page setting. An API test had to be updated so that we invoke `Image::setSystemAllowsImageAnimation` via Internals::setImageAnimationEnabled. This is part one of related work. In a follow up, performance issues for computing canAnimate when animation controls are enabled will be addressed. * Source/WebCore/loader/cache/CachedImage.cpp: (WebCore::CachedImage::CachedImageObserver::allowsAnimation const): (WebCore::CachedImage::allowsAnimation const): * Source/WebCore/page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate): * Source/WebCore/page/Page.cpp: (WebCore::Page::setImageAnimationEnabled): (WebCore::Page::setSystemAllowsAnimationControls): Deleted. * Source/WebCore/page/Page.h: (WebCore::Page::imageAnimationEnabled const): (WebCore::Page::systemAllowsAnimationControls const): Deleted. * Source/WebCore/platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::canAnimate const): * Source/WebCore/platform/graphics/Image.cpp: (WebCore::Image::setSystemAllowsAnimationControls): * Source/WebCore/platform/graphics/Image.h: (WebCore::Image::systemAllowsAnimationControls): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::setImageAnimationEnabled): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updateImageAnimationEnabled): * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updatePageAccessibilitySettings): * Tools/TestWebKitAPI/Tests/WebKit/AnimationControl.mm: (TEST): Canonical link: https://commits.webkit.org/275563@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ab0a1: Disable element fullscreen on digitaltrends.com on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ab0a13e324b222e3116fdfc17e900d277cab9a4 https://github.com/WebKit/WebKit/commit/9ab0a13e324b222e3116fdfc17e900d277cab9a4 Author: Dana Estra Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/page/Quirks.cpp Log Message: --- Disable element fullscreen on digitaltrends.com on iPhone https://bugs.webkit.org/show_bug.cgi?id=270359 rdar://123722375 Reviewed by Jer Noble. Adding quirk to digitaltrends.com to disable element fullscreen on iPhone, until the website fixes its custom media controls which are currently cut off on the bottom when the phone is rotated into landscape mode. * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableElementFullscreenQuirk const): Canonical link: https://commits.webkit.org/275562@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 872748: REGRESSION(275267@main): [WPE][GTK][Debug] SHOULD ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 872748a674956f5a2747f881bf14a96c6d8fc8be https://github.com/WebKit/WebKit/commit/872748a674956f5a2747f881bf14a96c6d8fc8be Author: Vitaly Dyachkov Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/dom/TouchEvent.cpp Log Message: --- REGRESSION(275267@main): [WPE][GTK][Debug] SHOULD NEVER BE REACHED in JSC::JSValue WebCore::toJSNewlyCreated() https://bugs.webkit.org/show_bug.cgi?id=270339 Reviewed by Ryosuke Niwa. This assertion was added in 275233@main. The same patch sets `EventInterfaceType::TouchEvent` for `TouchEvent` in non-empty constructors but not in the default constructor. * Source/WebCore/dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): Canonical link: https://commits.webkit.org/275561@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 90015d: [Gardening]: REGRESSION (268639@main): [ macOS wk2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 90015d3663beaf54414e5907b74d0e93e2b9bc0b https://github.com/WebKit/WebKit/commit/90015d3663beaf54414e5907b74d0e93e2b9bc0b Author: Marta Darbinyan Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (268639@main): [ macOS wk2 ] http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=270275 rdar://123801060 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275560@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 291cc0: [WPE] Fix build in older platforms
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 291cc07523180d8fcb508c042e391e80398efb9e https://github.com/WebKit/WebKit/commit/291cc07523180d8fcb508c042e391e80398efb9e Author: Claudio Saavedra Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp Log Message: --- [WPE] Fix build in older platforms https://bugs.webkit.org/show_bug.cgi?id=270355 Unreviewed build fix. The include was wrong, even if WPE_PLATFORM is not enabled, the DMABufRendererBufferFormat definition is needed for the empty vector. * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: Canonical link: https://commits.webkit.org/275559@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b84814: [iOS] AudioContext is getting suspended when page ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b848143a2ad57c80405dc5b30e61c750f5896d72 https://github.com/WebKit/WebKit/commit/b848143a2ad57c80405dc5b30e61c750f5896d72 Author: Youenn Fablet Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A LayoutTests/media/now-playing-webaudio-expected.txt A LayoutTests/media/now-playing-webaudio.html M LayoutTests/media/webaudio-background-playback-expected.txt M LayoutTests/media/webaudio-background-playback.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac/TestExpectations M Source/WebCore/Modules/mediasession/NavigatorMediaSession.cpp M Source/WebCore/Modules/mediasession/NavigatorMediaSession.h M Source/WebCore/Modules/webaudio/AudioContext.cpp M Source/WebCore/Modules/webaudio/AudioContext.h M Source/WebCore/Modules/webaudio/BaseAudioContext.cpp M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp Log Message: --- [iOS] AudioContext is getting suspended when page goes in the background even if navigator.audioSession.type is set to playback https://bugs.webkit.org/show_bug.cgi?id=261554 rdar://115485355 Reviewed by Eric Carlson. Implement isNowPlayingEligible, nowPlayingInfo and selectBestMediaSession to enable NowPlayingInfo handling. Only activated by JS AudioContext(s) are NowPlayingInfo-able if DOM AudioSession type is playback or plabyack and record. Implement canReceiveRemoteControlCommands and didReceiveRemoteControlCommand to be able to play/pause according commands. Update AudioContext::mayResumePlayback to only resume for activated by JS AudioContext(s). Update AudioContext::shouldOverrideBackgroundPlaybackRestriction to be able to continue in the background in case of playback or plabyack and record DOM AudioSession(s). Update bug in PlatformMediaSessionManager::bestEligibleSessionForRemoteControls late time optimization to only add web audio sessions to its list when there is no media element eligible session. If there is an eligible media element session, we do not want to add web audio session to the media session list. * LayoutTests/media/now-playing-webaudio-expected.txt: Added. * LayoutTests/media/now-playing-webaudio.html: Added. * LayoutTests/media/webaudio-background-playback-expected.txt: * LayoutTests/media/webaudio-background-playback.html: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/Modules/mediasession/NavigatorMediaSession.cpp: (WebCore::NavigatorMediaSession::mediaSessionIfExists): * Source/WebCore/Modules/mediasession/NavigatorMediaSession.h: * Source/WebCore/Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::AudioContext): (WebCore::AudioContext::mayResumePlayback): (WebCore::AudioContext::canReceiveRemoteControlCommands const): (WebCore::AudioContext::didReceiveRemoteControlCommand): (WebCore::hasPlayBackAudioSession): (WebCore::AudioContext::isNowPlayingEligible const): (WebCore::AudioContext::nowPlayingInfo const): (WebCore::AudioContext::selectBestMediaSession): (WebCore::AudioContext::shouldOverrideBackgroundPlaybackRestriction const): (WebCore::AudioContext::defaultDestinationWillBecomeConnected): * Source/WebCore/Modules/webaudio/AudioContext.h: * Source/WebCore/Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::setState): * Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::bestEligibleSessionForRemoteControls): Canonical link: https://commits.webkit.org/275558@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c7b84: [WGSL] Validate maximum array size
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c7b8419c6ff3be3a4ae2f5246c6327a962c8698 https://github.com/WebKit/WebKit/commit/8c7b8419c6ff3be3a4ae2f5246c6327a962c8698 Author: Tadeu Zagallo Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/tests/invalid/array.wgsl Log Message: --- [WGSL] Validate maximum array size https://bugs.webkit.org/show_bug.cgi?id=270313 rdar://123852286 Reviewed by Mike Wyrzykowski and Alex Christensen. Fix 2 issues with array sizes: - the size was being treated as unsigned and only checking for 0, but according to the spec the size can also be signed, and we should return an error for negative values - we also need to limit the maximum size of an array. the spec[1] says the minimum size we must support is 65535 bytes, but for now we just check for 65535 elements. [1]: https://www.w3.org/TR/WGSL/#limits * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): * Source/WebGPU/WGSL/tests/invalid/array.wgsl: Canonical link: https://commits.webkit.org/275557@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 568a30: [iOS] premierleague.com enters video fullscreen fr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 568a30c64835dcd59f652cf15429abdce4d9d263 https://github.com/WebKit/WebKit/commit/568a30c64835dcd59f652cf15429abdce4d9d263 Author: Jer Noble Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/html/MediaElementSession.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- [iOS] premierleague.com enters video fullscreen from element fullscreen on iPhone https://bugs.webkit.org/show_bug.cgi?id=270329 rdar://123721211 Reviewed by Eric Carlson. premierleague.com does not include a `playsinline` attribute on their video elements, which causes them to attempt to enter video fullscreen when playing, even in element fullscreen. Exempt premierleague.com from the `playsinline` attribute (and consider removing that requirement on iPhone generally). * Source/WebCore/html/MediaElementSession.cpp: (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldIgnorePlaysInlineRequirementQuirk const): * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/275556@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bd9231: Create IndexedDB version directory in network process
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bd9231efecf2d6baba24f3b2d65846a90c9259dc https://github.com/WebKit/WebKit/commit/bd9231efecf2d6baba24f3b2d65846a90c9259dc Author: Sihui Liu Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/NetworkProcess/storage/IDBStorageManager.cpp M Source/WebKit/NetworkProcess/storage/IDBStorageManager.h M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h Log Message: --- Create IndexedDB version directory in network process https://bugs.webkit.org/show_bug.cgi?id=270192 rdar://123725258 Reviewed by Geoffrey Garen and Chris Dumez. We currently create a v0 directory under IndexedDB root directory on main thread of UI process. This patch moves that to the storage queue in network process to avoid blocking UI process. Also, instead of creating a symlink that points to the root directory, we create an actual directory and move files into it, because the version upgrade was shipped over 4 years ago and most data should already be migrated to v1 directory. We don't have to keep the circular symlink now. This patch also removes the v0 directory if it is not needed. This change is covered by existing IndexedDB API tests (e.g IndexedDB.IndexedDBFileNameV0) as they are using different versions of data. * Source/WebKit/NetworkProcess/storage/IDBStorageManager.cpp: (WebKit::IDBStorageManager::createVersionDirectoryIfNeeded): * Source/WebKit/NetworkProcess/storage/IDBStorageManager.h: * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::NetworkStorageManager::NetworkStorageManager): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::addSession): (WebKit::NetworkProcessProxy::createSymLinkForFileUpgrade): Deleted. * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: Canonical link: https://commits.webkit.org/27@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5daece: [WGSL] Refactor variable initializer typing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5daecebaee8344378f5d4db67f14422fe06029ea https://github.com/WebKit/WebKit/commit/5daecebaee8344378f5d4db67f14422fe06029ea Author: Tadeu Zagallo Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A LayoutTests/http/tests/webgpu/webgpu/shader/validation/decl/var-expected.txt M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: --- [WGSL] Refactor variable initializer typing https://bugs.webkit.org/show_bug.cgi?id=270316 rdar://123854264 Reviewed by Mike Wyrzykowski. In 274615@main I fixed the failing CTS tests under shader,validation,decl,var:initializer_kind: by adding explicit checks for function calls and references to other global variables. However, the reason those tests were failing in the first place was that a global variable's initializer can only use constant and override expressions according to the spec[1]. [1]: https://www.w3.org/TR/WGSL/#var-and-value * LayoutTests/http/tests/webgpu/webgpu/shader/validation/decl/var-expected.txt: Added. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): (WGSL::TypeChecker::visitVariable): Deleted. Canonical link: https://commits.webkit.org/275554@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c79050: [WPE] WPE Platform: Crashes due to failure to trac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c79050dd5ea4017af6e347debb3afe91401567a9 https://github.com/WebKit/WebKit/commit/c79050dd5ea4017af6e347debb3afe91401567a9 Author: Lauro Moura Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.h Log Message: --- [WPE] WPE Platform: Crashes due to failure to track touch points https://bugs.webkit.org/show_bug.cgi?id=270332 Reviewed by Carlos Garcia Campos. - Use HashMap trait that allows zero as a valid key - Stop tracking points after receiving the 'up' event * Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp: * Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.h: Canonical link: https://commits.webkit.org/275553@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bbe400: [WPE] Update Cog to commit ab4045c1482
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bbe40032534b39a197c80e7126d5a1d5f1f3ddb0 https://github.com/WebKit/WebKit/commit/bbe40032534b39a197c80e7126d5a1d5f1f3ddb0 Author: Georges Basile Stavracas Neto Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Tools/PlatformWPE.cmake Log Message: --- [WPE] Update Cog to commit ab4045c1482 https://bugs.webkit.org/show_bug.cgi?id=270340 Reviewed by Philippe Normand. The most recent commits fix unscaled input coordinates, which is quite disrupting when developing and testing changes against WPE. * Tools/PlatformWPE.cmake: Canonical link: https://commits.webkit.org/275552@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 499319: Clean up site isolation process selection logic
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4993196dda0c8b38391058300b282bc802a4ffd2 https://github.com/WebKit/WebKit/commit/4993196dda0c8b38391058300b282bc802a4ffd2 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/Sources.txt M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/BrowsingContextGroup.h A Source/WebKit/UIProcess/FrameProcess.cpp A Source/WebKit/UIProcess/FrameProcess.h M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp M Source/WebKit/UIProcess/ProvisionalFrameProxy.h M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/RemotePageProxy.h R Source/WebKit/UIProcess/RemotePageProxyState.h M Source/WebKit/UIProcess/SuspendedPageProxy.cpp M Source/WebKit/UIProcess/SuspendedPageProxy.h M Source/WebKit/UIProcess/WebFrameProxy.cpp M Source/WebKit/UIProcess/WebFrameProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Clean up site isolation process selection logic https://bugs.webkit.org/show_bug.cgi?id=270045 rdar://116202371 Reviewed by Charlie Wolfe. This pulls the process selection and RemotePageProxy management logic from various places into BrowsingContextGroup. I introduce a new abstraction, FrameProcess, that represents a frame's use of a particular process. The WebFrameProxy retains a reference to a FrameProcess instead of a RemotePageProxy. When a FrameProcess is created or destroyed, the BrowsingContextGroup updates the containers of RemotePageProxy objects. This change allows us to keep track of opened pages using structures that are more elegant and robust to handle all possible combinations of window.open and iframe creation or destruction. Two small changes are observable in site isolation API tests, but they are both progressions because of processes and frames being managed more correctly in some cases. * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::allowsFirstPartyForCookies): * Source/WebKit/Shared/AuxiliaryProcess.cpp: (WebKit::AuxiliaryProcess::allowsFirstPartyForCookies): * Source/WebKit/Sources.txt: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::ensureProcessForDomain): (WebKit::BrowsingContextGroup::processForDomain): (WebKit::BrowsingContextGroup::addFrameProcess): (WebKit::BrowsingContextGroup::removeFrameProcess): (WebKit::BrowsingContextGroup::addPage): (WebKit::BrowsingContextGroup::removePage): (WebKit::BrowsingContextGroup::forEachRemotePage): (WebKit::BrowsingContextGroup::remotePageInProcess): (WebKit::BrowsingContextGroup::takeRemotePageInProcessForProvisionalPage): (WebKit::BrowsingContextGroup::transitionPageToRemotePage): (WebKit::BrowsingContextGroup::addProcessForDomain): Deleted. * Source/WebKit/UIProcess/BrowsingContextGroup.h: * Source/WebKit/UIProcess/FrameProcess.cpp: Renamed from Source/WebKit/UIProcess/RemotePageProxyState.h. (WebKit::FrameProcess::FrameProcess): (WebKit::FrameProcess::~FrameProcess): * Source/WebKit/UIProcess/FrameProcess.h: Copied from Source/WebKit/UIProcess/BrowsingContextGroup.h. (WebKit::FrameProcess::domain const): (WebKit::FrameProcess::process const): (WebKit::FrameProcess::process): (WebKit::FrameProcess::create): * Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp: (WebKit::ProvisionalFrameProxy::ProvisionalFrameProxy): (WebKit::ProvisionalFrameProxy::takeFrameProcess): (WebKit::ProvisionalFrameProxy::process const): (WebKit::ProvisionalFrameProxy::takeRemotePageProxy): Deleted. * Source/WebKit/UIProcess/ProvisionalFrameProxy.h: (WebKit::ProvisionalFrameProxy::process const): Deleted. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::~ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::process): (WebKit::ProvisionalPageProxy::setNavigation): (WebKit::ProvisionalPageProxy::cancel): (WebKit::ProvisionalPageProxy::initializeWebPage): (WebKit::ProvisionalPageProxy::loadData): (WebKit::ProvisionalPageProxy::loadRequest): (WebKit::ProvisionalPageProxy::goToBackForwardItem): (WebKit::ProvisionalPageProxy::didCreateMainFrame): (WebKit::ProvisionalPageProxy::didPerformClientRedirect): (WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
[webkit-changes] [WebKit/WebKit] fcdb5d: [WebGPU] Fix RenderPipeline color format validation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcdb5d4b016f49f0fc3c205f8cb37b7269e55312 https://github.com/WebKit/WebKit/commit/fcdb5d4b016f49f0fc3c205f8cb37b7269e55312 Author: Alex Christensen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/render-bundle-validation-color-format-expected.txt A LayoutTests/fast/webgpu/render-bundle-validation-color-format.html M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: --- [WebGPU] Fix RenderPipeline color format validation https://bugs.webkit.org/show_bug.cgi?id=270333 rdar://123810621 Reviewed by Mike Wyrzykowski. If fragment.targetCount is not equal to descriptor.colorFormatCount then we want to verify that all color formats are undefined. Otherwise, we want to verify that they are all equal to the descriptor color formats. * LayoutTests/fast/webgpu/render-bundle-validation-color-format-expected.txt: Added. * LayoutTests/fast/webgpu/render-bundle-validation-color-format.html: Added. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::RenderPipeline::validateRenderBundle const): Canonical link: https://commits.webkit.org/275550@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 590ad1: Remove duplicates of Acid1
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 590ad19dadef48cc5691fda64047c2d541fc892c https://github.com/WebKit/WebKit/commit/590ad19dadef48cc5691fda64047c2d541fc892c Author: Sam Sneddon Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: R LayoutTests/css1/box_properties/acid_test.html R LayoutTests/fast/block/basic/011.html M LayoutTests/platform/mac/TestExpectations Log Message: --- Remove duplicates of Acid1 https://bugs.webkit.org/show_bug.cgi?id=270223 Reviewed by Alan Baradlay. This removes two of the three copies of Acid1 we have in our tree, leaving only the version imported from the CSS 2.1 test suite: css2.1/t09-c5526c-display-00-e.html (and this too will ultimately be replaced when we finally import CSS2 from WPT, where Acid1 survives as css/CSS2/css1/c5526c-display-000.xht). * LayoutTests/css1/box_properties/acid_test.html: Removed. * LayoutTests/fast/block/basic/011.html: Removed. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275549@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 137708: AX: VoiceOver reads erroneous value for datetime-l...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1377080ff3c3e232ef4cae665dcad6819409f6c2 https://github.com/WebKit/WebKit/commit/1377080ff3c3e232ef4cae665dcad6819409f6c2 Author: Andres Gonzalez Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: A LayoutTests/accessibility/datetime/input-datetime-local-label-value-expected.txt A LayoutTests/accessibility/datetime/input-datetime-local-label-value.html M LayoutTests/platform/glib/TestExpectations A LayoutTests/platform/mac-monterey/accessibility/datetime/input-datetime-local-label-value-expected.txt M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/html/BaseDateAndTimeInputType.cpp M Source/WebCore/html/BaseDateAndTimeInputType.h M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLInputElement.h M Source/WebCore/html/InputType.cpp M Source/WebCore/html/InputType.h M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Log Message: --- AX: VoiceOver reads erroneous value for datetime-local input elements. https://bugs.webkit.org/show_bug.cgi?id=270276 Reviewed by Tyler Wilcock. AccessibilityNodeObject::dateTimeValue() relied on HTMLInputElement::valueAsDate(), that in turn forwards to an override of InputType::valueAsDate. The problem is that DateTimeLocalInputType::valueAsDate returns NaN unlike the overrides in the other subclasses of BaseDateAndTimeInputType. To solve this problem, we added the method accessibilityValueAsDate() that returns the right value for all BaseDateAndTimeInputType subclasses including DateTimeLocalInputType. Added the AccessibilityUIElement::dateValue() method to the TestRunner to exercise this functionality. The new test does just that for datetime-local input elements. * LayoutTests/accessibility/datetime/input-datetime-local-label-value-expected.txt: Added. * LayoutTests/accessibility/datetime/input-datetime-local-label-value.html: Added. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/mac-monterey/accessibility/datetime/input-datetime-local-label-value-expected.txt: Added. * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::dateTimeValue const): * Source/WebCore/html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::accessibilityValueAsDate const): * Source/WebCore/html/BaseDateAndTimeInputType.h: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::accessibilityValueAsDate const): * Source/WebCore/html/HTMLInputElement.h: * Source/WebCore/html/InputType.cpp: (WebCore::InputType::accessibilityValueAsDate const): * Source/WebCore/html/InputType.h: * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::stringValue): (WTR::AccessibilityUIElement::dateValue): Canonical link: https://commits.webkit.org/275548@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c3c88: REGRESSION (274945@main): [ Ventura ] tables/mozil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c3c883e1144779bc26eff1ddb1adf7103d22177 https://github.com/WebKit/WebKit/commit/4c3c883e1144779bc26eff1ddb1adf7103d22177 Author: Alan Baradlay Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M LayoutTests/platform/mac-ventura/tables/mozilla/bugs/bug4527-expected.txt Log Message: --- REGRESSION (274945@main): [ Ventura ] tables/mozilla/bugs/bug4527.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=270303 Unreviewed rebaseline. * LayoutTests/platform/mac-ventura/tables/mozilla/bugs/bug4527-expected.txt: Canonical link: https://commits.webkit.org/275547@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2f1fd: WebKit should never use CrashReporterClient.h from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2f1fdd5b7430def110676aa867ab42193de19d3 https://github.com/WebKit/WebKit/commit/c2f1fdd5b7430def110676aa867ab42193de19d3 Author: Tuomas Karkkainen Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WTF/wtf/spi/cocoa/CrashReporterClientSPI.h Log Message: --- WebKit should never use CrashReporterClient.h from APPLE_INTERNAL_SDK https://bugs.webkit.org/show_bug.cgi?id=270335 Reviewed by Jonathan Bedard. Remove use of Apple's internal CrashReporterClient.h * Source/WTF/wtf/spi/cocoa/CrashReporterClientSPI.h: Canonical link: https://commits.webkit.org/275546@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c73ac9: LibWebRTCCodecs's createRemoteEncoder is going thr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c73ac9c2ac4156120af075caee3703855f239517 https://github.com/WebKit/WebKit/commit/c73ac9c2ac4156120af075caee3703855f239517 Author: Jean-Yves Avenard Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h Log Message: --- LibWebRTCCodecs's createRemoteEncoder is going through the main thread. https://bugs.webkit.org/show_bug.cgi?id=270280 rdar://123806984 Reviewed by Youenn Fablet. Make use of new sendWithAsyncReplyOnDispatcher to avoid the now unnecessary task re-dispatch. No change in observable behaviour. * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: (WebKit::createRemoteDecoder): (WebKit::LibWebRTCCodecs::createDecoderInternal): (WebKit::createRemoteEncoder): (WebKit::LibWebRTCCodecs::createEncoderInternal): (WebKit::LibWebRTCCodecs::flushEncoder): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h: (WebKit::LibWebRTCCodecs::workQueue const): Canonical link: https://commits.webkit.org/275545@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a99725: [WPE] WPE Platform: add API to get/set the primary...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a997251a7158008b2d0d9698567f77912e114948 https://github.com/WebKit/WebKit/commit/a997251a7158008b2d0d9698567f77912e114948 Author: Carlos Garcia Campos Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/wpe/ScreenManagerWPE.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.h Log Message: --- [WPE] WPE Platform: add API to get/set the primary display https://bugs.webkit.org/show_bug.cgi?id=270336 Reviewed by Alejandro G. Castro. We are currently using the default display for the screen manager, which is wrong for apps not using the default display and explicitly creating one. In most of the cases there's only one display, and in most of the cases where there's more than one, the first one created is the primary one. So, we can add API to get the primary display that is set automatically for the first created display, but still allow to set any other display as primary. * Source/WebKit/UIProcess/wpe/ScreenManagerWPE.cpp: (WebKit::ScreenManager::ScreenManager): (WebKit::ScreenManager::updatePrimaryDisplayID): * Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp: (wpe_display_class_init): (wpe_display_get_primary): (wpe_display_set_primary): * Source/WebKit/WPEPlatform/wpe/WPEDisplay.h: Canonical link: https://commits.webkit.org/275544@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 472779: [Skia] Implement patterns with spacing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 47277981855c291da36dd487ce00c654fd2401e0 https://github.com/WebKit/WebKit/commit/47277981855c291da36dd487ce00c654fd2401e0 Author: Carlos Garcia Campos Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Implement patterns with spacing https://bugs.webkit.org/show_bug.cgi?id=270288 Reviewed by Alejandro G. Castro. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::drawPattern): Canonical link: https://commits.webkit.org/275543@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 98f239: REGRESSION (275262@main): Unable to play games in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 98f2399f9450976e2a8a780e73f6b1263b18ac15 https://github.com/WebKit/WebKit/commit/98f2399f9450976e2a8a780e73f6b1263b18ac15 Author: Jer Noble Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/platform/audio/SharedAudioDestination.cpp Log Message: --- REGRESSION (275262@main): Unable to play games in PBS Kids Games app https://bugs.webkit.org/show_bug.cgi?id=270284 rdar://123811318 Reviewed by Chris Dumez. The SharedAudioDestinationAdapter's configuration queue would become stuck, waiting on a semaphore which would never be triggered. This appears to be a latent bug in the RemoteAudioDestinationProxy/Manager, but one that has dire implications now that SharedAudioDestination depends on its Adapter's render() method being called. Rather than block on a Semaphore to ensure the Adapter is configured before calling the completion handlers, simply pass the completion handler into the Adapter's inner destination's start() or stop() methods. Only when the Adapter is already started (or when it's stopped and does not need to be restarted) should the completion handler get called explicitly. Now that blocking is not needed, neither is the Adapter's configuration queue; all the setup for configuration can happen on the main thread. * Source/WebCore/platform/audio/SharedAudioDestination.cpp: (WebCore::SharedAudioDestinationAdapter::protectedWorkBus): (WebCore::SharedAudioDestinationAdapter::~SharedAudioDestinationAdapter): (WebCore::SharedAudioDestinationAdapter::addRenderer): (WebCore::SharedAudioDestinationAdapter::removeRenderer): (WebCore::SharedAudioDestinationAdapter::configureRenderThread): (WebCore::SharedAudioDestinationAdapter::callAllConfigurationHandlers): (WebCore::SharedAudioDestinationAdapter::render): (WebCore::SharedAudioDestinationAdapter::protectedConfigurationQueue): Deleted. (WebCore::m_configurationSemaphore): Deleted. Canonical link: https://commits.webkit.org/275542@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7ee83: [Skia] Do not set synthetic bold offset
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7ee831c38599255e3ae78a2b28b71968615107f https://github.com/WebKit/WebKit/commit/c7ee831c38599255e3ae78a2b28b71968615107f Author: Carlos Garcia Campos Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontSkia.cpp Log Message: --- [Skia] Do not set synthetic bold offset https://bugs.webkit.org/show_bug.cgi?id=270291 Reviewed by Don Olmstead. It's handled internally by Skia. * Source/WebCore/platform/graphics/skia/FontSkia.cpp: (WebCore::Font::platformPathForGlyph const): (WebCore::Font::platformInit): Canonical link: https://commits.webkit.org/275541@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a7b2d: [GTK] Crash in WebPageProxy::getLoadDecisionForIcon
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a7b2d62c79487e7c4040fadf997e9238e6d9047 https://github.com/WebKit/WebKit/commit/6a7b2d62c79487e7c4040fadf997e9238e6d9047 Author: Carlos Garcia Campos Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- [GTK] Crash in WebPageProxy::getLoadDecisionForIcon https://bugs.webkit.org/show_bug.cgi?id=269699 Reviewed by Michael Catanzaro. This probably regressed in 274563@main, that changed the way a SharedBuffer is serialized for IPC and now segments are sent, instead of the contiguous. So, in getLoadDecisionForIcon() we need to handle the case of data being non contiguous, by using SharedBufferReference::unsafeBuffer() * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getLoadDecisionForIcon): Canonical link: https://commits.webkit.org/275540@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
