[webkit-changes] [WebKit/WebKit] c260b2: Re-import css/css-view-transitions WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c260b2daba967cdd051caf9f706517684a2cffdb https://github.com/WebKit/WebKit/commit/c260b2daba967cdd051caf9f706517684a2cffdb Author: Tim Nguyen Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/3d-transform-incoming.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/3d-transform-outgoing.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/block-with-overflowing-text.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/break-inside-avoid-child.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-with-offscreen-child.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-with-opacity-zero-child.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-with-visibility-mixed-descendants.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/clip-path-larger-than-border-box-on-child-of-named-element.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/content-with-transform-new-image.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/content-with-transform-old-image.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/css-tags-paint-order-with-entry.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/dialog-in-rtl-iframe.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/far-away-capture.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/fractional-box-with-overflow-children-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/fractional-box-with-overflow-children-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-new-has-scrollbar.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-old-has-scrollbar.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-transition.sub.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/inline-with-offset-from-containing-block.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-and-on-top-of-viewport-partially-onscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-viewport-offscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-viewport-offscreen-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-viewport-partially-onscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-left-of-viewport-offscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-left-of-viewport-offscreen-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-left-of-viewport-partially-onscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-left-of-viewport-partially-onscreen-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-on-top-of-viewport-offscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-on-top-of-viewport-offscreen-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-on-top-of-viewport-partially-onscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-on-top-of-viewport-partially-onscreen-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-right-and-left-of-viewport-partially-onscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-right-of-viewport-offscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-right-of-viewport-offscreen-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-right-of-viewport-partially-onscreen-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-right-of-viewport-partially-onscreen-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/multiline-span-with-overflowing-text-and-box-decorations.html M LayoutTests/imported/w3c/web-platform-tests/css/css-vi
[webkit-changes] [WebKit/WebKit] 5fc7a2: [GLIB] Modernize some argument coders
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fc7a2593e690290b50e9c9f8d30aab3374798d5 https://github.com/WebKit/WebKit/commit/5fc7a2593e690290b50e9c9f8d30aab3374798d5 Author: Claudio Saavedra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h M Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp M Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp Log Message: --- [GLIB] Modernize some argument coders https://bugs.webkit.org/show_bug.cgi?id=272983 Reviewed by Michael Catanzaro. Move some of the argument coders uses for GLib and GTK types to use the modern ArgumentCoder API. Remove the GKeyFile coders, as one can actually use GVariant for serialization of GTK printing structs and we already have a GVariant serializer. Also add UNLIKELY() for the std::nullopt bailout cases that can be optimized. * Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h: * Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp: (IPC::ArgumentCoder>::decode): (IPC::ArgumentCoder>::decode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder>::decode): * Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp: (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): (IPC::encodeGKeyFile): Deleted. (IPC::decodeGKeyFile): Deleted. Canonical link: https://commits.webkit.org/277967@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24c8e1: [WebGPU] Fix unguarded WTF::String in WebGPU.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24c8e1add6a1560618e979279220d46bbc79af1d https://github.com/WebKit/WebKit/commit/24c8e1add6a1560618e979279220d46bbc79af1d Author: Mike Wyrzykowski Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebGPU/WebGPU/WebGPU.h Log Message: --- [WebGPU] Fix unguarded WTF::String in WebGPU.h https://bugs.webkit.org/show_bug.cgi?id=273225 Unreviewed build fix for some targets. Import is guarded by cplus_plus but String was being used unconditionally. * Source/WebGPU/WebGPU/WebGPU.h: Canonical link: https://commits.webkit.org/277966@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f7f7e: [UnifiedPDF] Snapshots after the first page are pa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f7f7ed16b4fb150585c2adba8d3913f72ba1712 https://github.com/WebKit/WebKit/commit/3f7f7ed16b4fb150585c2adba8d3913f72ba1712 Author: Sammy Gill Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Snapshots after the first page are partially dark-shaded https://bugs.webkit.org/show_bug.cgi?id=273213 rdar://126817702 Reviewed by Abrar Rahman Protyasha and Simon Fraser. 277273@main attempted to address this issue by making adding in the white background as a fill as part of the async rendering codepath. It turns out that this was quite not enough and snapshots of pages after the first page are still appearing as dark. It looks like this is due to the fact that we modify the graphics context by making it so that the origin is at the bottom of the page before we pass it off to PDFKit. So, instead we will start adding the fill before we perform this coordinate space transformation. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::paintPDFContent): Canonical link: https://commits.webkit.org/277965@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9bc982: Increase TaskPool timeout threshold for layout tes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bc982313b8be4fa5fde17286807308bf6ef2a4e https://github.com/WebKit/WebKit/commit/9bc982313b8be4fa5fde17286807308bf6ef2a4e Author: Ben Schwartz Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py Log Message: --- Increase TaskPool timeout threshold for layout test runner. https://bugs.webkit.org/show_bug.cgi?id=273221 rdar://127017493 Reviewed by Jonathan Bedard. In some cases, we're seeing timeouts when attempting to start layout test runner child processes. While this is investigated, we would like to increase the timeout threshold in the interest of interim testing stability. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py: (TaskPool.__init__): Add enter_grace_period parameter, change grace_period parameter to exit_grace_period. (TaskPool.__enter__): Set enter_grace_period parameter as default when invoking Timeout. (TaskPool.__exit__): Rename grace_period parameter to exit_grace_period. * Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (LayoutTestRunner.run_tests): Increase timeout threshold from 60 -> 300 seconds. Canonical link: https://commits.webkit.org/277964@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f9e7e2: Unreviewed build fix after 277958@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f9e7e2c79bf2cfa67a9bf12c958d23e42bd169a2 https://github.com/WebKit/WebKit/commit/f9e7e2c79bf2cfa67a9bf12c958d23e42bd169a2 Author: Chris Dumez Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/dom/ViewTransition.cpp Log Message: --- Unreviewed build fix after 277958@main. * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::updatePseudoElementStyles): Canonical link: https://commits.webkit.org/277963@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 37e1a4: Use WKBundlePagePostMessageWithAsyncReply for more...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 37e1a47538f30abbd774aad206e546afd00baa71 https://github.com/WebKit/WebKit/commit/37e1a47538f30abbd774aad206e546afd00baa71 Author: Alex Christensen Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/TestInvocation.cpp M Tools/WebKitTestRunner/TestInvocation.h Log Message: --- Use WKBundlePagePostMessageWithAsyncReply for more WebKitTestRunner messages https://bugs.webkit.org/show_bug.cgi?id=273211 rdar://127008368 Reviewed by Sihui Liu. This makes tests work better with site isolation because the reply is sent to the sending process which might not be the same as the main frame process. * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::postMessageWithAsyncReply): (WTR::postMessageWithAsyncReplyImpl): Deleted. * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsDebugMode): (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode): (WTR::TestRunner::setStatisticsLastSeen): (WTR::TestRunner::setStatisticsMergeStatistic): (WTR::TestRunner::setStatisticsExpiredStatistic): (WTR::TestRunner::setStatisticsPrevalentResource): (WTR::TestRunner::setStatisticsVeryPrevalentResource): (WTR::TestRunner::setStatisticsHasHadUserInteraction): (WTR::TestRunner::statisticsUpdateCookieBlocking): (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore): (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval): (WTR::TestRunner::setStatisticsShouldDowngradeReferrer): (WTR::TestRunner::setStatisticsShouldBlockThirdPartyCookies): (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode): (WTR::TestRunner::statisticsSetToSameSiteStrictCookies): (WTR::TestRunner::statisticsSetFirstPartyHostCNAMEDomain): (WTR::TestRunner::statisticsSetThirdPartyCNAMEDomain): (WTR::TestRunner::statisticsResetToConsistentState): (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetLastSeenCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetMergeStatisticCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetExpiredStatisticCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetShouldDowngradeReferrerCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetShouldBlockThirdPartyCookiesCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetFirstPartyWebsiteDataRemovalModeCallback): Deleted. (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback): Deleted. (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetToSameSiteStrictCookiesCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetFirstPartyHostCNAMEDomainCallback): Deleted. (WTR::TestRunner::statisticsCallDidSetThirdPartyCNAMEDomainCallback): Deleted. (WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback): Deleted. * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveAsyncMessageFromInjectedBundle): (WTR::adoptAndCallCompletionHandler): (WTR::TestController::setStatisticsDebugMode): (WTR::TestController::setStatisticsPrevalentResourceForDebugMode): (WTR::TestController::setStatisticsLastSeen): (WTR::TestController::setStatisticsMergeStatistic): (WTR::TestController::setStatisticsExpiredStatistic): (WTR::TestController::setStatisticsPrevalentResource): (WTR::TestController::setStatisticsVeryPrevalentResource): (WTR::TestController::setStatisticsHasHadUserInteraction): (WTR::TestController::statisticsUpdateCookieBlocking): (WTR::TestController::statisticsClearInMemoryAndPersistentStore): (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): (WTR::TestController::setStatisticsShouldDowngradeReferrer): (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies): (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode): (WTR::TestController::setStatisticsToSameSiteStrictCookies): (WTR::TestController::set
[webkit-changes] [WebKit/WebKit] e1e849: REGRESSION (277389@main): [iOS] AutoFill not offer...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1e849f259d0a32e603e644d6fc6b6ef8774ed22 https://github.com/WebKit/WebKit/commit/e1e849f259d0a32e603e644d6fc6b6ef8774ed22 Author: Aditya Keerthi Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/Shared/WebPageCreationParameters.serialization.in A Source/WebKit/Shared/ios/HardwareKeyboardState.cpp A Source/WebKit/Shared/ios/HardwareKeyboardState.h A Source/WebKit/Shared/ios/HardwareKeyboardState.serialization.in M Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h M Source/WebKit/SourcesCocoa.txt M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/PageClient.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/ios/PageClientImplIOS.h M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M WebKitLibraries/SDKs/appletvos16.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/appletvos17.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/appletvsimulator16.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/appletvsimulator17.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/iphoneos16.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/iphoneos17.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/iphonesimulator16.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/iphonesimulator17.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/watchos10.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/watchos9.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/watchsimulator10.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd M WebKitLibraries/SDKs/watchsimulator9.0-additions.sdk/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices.tbd Log Message: --- REGRESSION (277389@main): [iOS] AutoFill not offered on autofocus with an attached hardware keyboard https://bugs.webkit.org/show_bug.cgi?id=273086 rdar://126653124 Reviewed by Chris Dumez, Abrar Rahman Protyasha and Richard Robinson. Focusing a field without user interaction should not offer AutoFill unless there is a hardware keyboard attached. In order to implement this behavior, Safari checks the returned value of `GSEventIsHardwareKeyboardAttached()` in their injected bundle. Since that call is made in the web process, where notifyd is blocked following 277389@main, it always returns false, as `GSEventIsHardwareKeyboardAttached()` relies on libnotify. Consequently, AutoFill is not offered until the user actually taps on a field, even when a hardware keyboard is attached. Simply updating `WebProcessPool::registerNotificationObservers` to register for the hardware keyboard notification is not sufficient, as the returned value of `GSEventIsHardwareKeyboardAttached()` will be incorrect if the process is launched with the hardware keyboard already attached. Fix by explicitly setting the state at process creation time, and whenever the value changes, using `GSEventSetHardwareKeyboardAttachedWithCountryCodeAndType()`. A new `HardwareKeyboardState` struct is introduced to represent the state across process boundaries. Additionally suppress updates in the UI process if the state is unchanged, to avoid notification loops in the simulator. * Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/Shared/WebPageCreationParamet
[webkit-changes] [WebKit/WebKit] 4d6152: Reduce use of WKBundlePageGetMainFrame in WebKitTe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d615268b408e70bbdbab4670ef69439c98bd2af https://github.com/WebKit/WebKit/commit/4d615268b408e70bbdbab4670ef69439c98bd2af Author: Alex Christensen Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl M Tools/WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl M Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp M Tools/WebKitTestRunner/InjectedBundle/EventSendingController.h M Tools/WebKitTestRunner/InjectedBundle/TextInputController.cpp M Tools/WebKitTestRunner/InjectedBundle/TextInputController.h Log Message: --- Reduce use of WKBundlePageGetMainFrame in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=273223 rdar://127020492 Reviewed by Pascoe. The main frame, and the main frame JS context, might not be in the current process with site isolation enabled. What we want is the current context. This PR fixes fast/events/key-events-in-frame.html with --site-isolation, among other tests. * Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * Tools/WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: * Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseDown): (WTR::EventSendingController::mouseUp): (WTR::EventSendingController::keyDown): (WTR::EventSendingController::rawKeyDown): (WTR::EventSendingController::rawKeyUp): (WTR::EventSendingController::contextClick): (WTR::EventSendingController::callAfterScrollingCompletes): * Tools/WebKitTestRunner/InjectedBundle/EventSendingController.h: * Tools/WebKitTestRunner/InjectedBundle/TextInputController.cpp: (WTR::TextInputController::setMarkedText): * Tools/WebKitTestRunner/InjectedBundle/TextInputController.h: Canonical link: https://commits.webkit.org/277960@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4321a: [view-transitions] Handle overflow:hidden on ::vie...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4321a0a6e7085a38a340b6353a0ddef31d9f5f8 https://github.com/WebKit/WebKit/commit/b4321a0a6e7085a38a340b6353a0ddef31d9f5f8 Author: Matt Woodrow Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-overflow-hidden-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-overflow-hidden-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-overflow-hidden.html M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderViewTransitionCapture.cpp M Source/WebCore/rendering/RenderViewTransitionCapture.h Log Message: --- [view-transitions] Handle overflow:hidden on ::view-transition-new/old. https://bugs.webkit.org/show_bug.cgi?id=273058 Reviewed by Tim Nguyen. Implement updateFromStyle, and make sure setHasNonVisibleOverflow gets called if necessary. Normally this only happens for RenderBlock subclasses, not RenderReplaced (which don't really support overflow properly yet, see bug 273055). If overflow is hidden, fall back to snapshotting each frame of the transition instead of using compositing layer attachment, since overflow hidden isn't supported there either. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-overflow-hidden-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-overflow-hidden-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-overflow-hidden.html: Added. * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::updatePseudoElementStyles): * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::collectViewTransitionNewContentLayers): * Source/WebCore/rendering/RenderViewTransitionCapture.cpp: (WebCore::RenderViewTransitionCapture::updateFromStyle): * Source/WebCore/rendering/RenderViewTransitionCapture.h: Canonical link: https://commits.webkit.org/277959@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6ed29: [view-transitions] Clear view transition on naviga...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6ed29f91fc8f5d7fbde9c3d4a825b07dd6111fb https://github.com/WebKit/WebKit/commit/f6ed29f91fc8f5d7fbde9c3d4a825b07dd6111fb Author: Tim Nguyen Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/dom/ViewTransition.h M Source/WebCore/dom/ViewTransition.idl Log Message: --- [view-transitions] Clear view transition on navigation https://bugs.webkit.org/show_bug.cgi?id=272792 rdar://126590072 Reviewed by Chris Dumez. The VT crashtests were causing the following test to flakily crash. To fix this, clear the view transition when the user navigates by using ActiveDOMObject and defining a stop method. Also protect the document in `ViewTransition::callUpdateCallback`. * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::ViewTransition): (WebCore::ViewTransition::create): (WebCore::ViewTransition::skipViewTransition): (WebCore::ViewTransition::callUpdateCallback): (WebCore::ViewTransition::setupViewTransition): (WebCore::ViewTransition::captureOldState): (WebCore::ViewTransition::captureNewState): (WebCore::ViewTransition::setupTransitionPseudoElements): (WebCore::ViewTransition::handleTransitionFrame): (WebCore::ViewTransition::clearViewTransition): (WebCore::ViewTransition::updatePseudoElementStyles): (WebCore::ViewTransition::stop): * Source/WebCore/dom/ViewTransition.h: (WebCore::ViewTransition::document const): (WebCore::ViewTransition::protectedDocument const): * Source/WebCore/dom/ViewTransition.idl: Canonical link: https://commits.webkit.org/277958@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd7ff2: Follow-up: Use smart pointers with WebCore::Cached...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd7ff2eb420bf4e63e3a852f890adbb43247b5ce https://github.com/WebKit/WebKit/commit/fd7ff2eb420bf4e63e3a852f890adbb43247b5ce Author: David Kilzer Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Log Message: --- Follow-up: Use smart pointers with WebCore::CachedResourceLoader in libxml2/libxslt code https://bugs.webkit.org/show_bug.cgi?id=273204 Unreviewed follow-up fix. * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::openFunc): - Switch from CachedResourceLoader::protectedDocument() to document(). Canonical link: https://commits.webkit.org/277957@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 49e16e: Use smart pointers with WebCore::CachedResourceLoa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 49e16e9ddcee72f8f19370735909ca1a677a8b14 https://github.com/WebKit/WebKit/commit/49e16e9ddcee72f8f19370735909ca1a677a8b14 Author: David Kilzer Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/xml/XSLTProcessorLibxslt.cpp M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp M Source/WebCore/xml/parser/XMLDocumentParserScope.cpp M Source/WebCore/xml/parser/XMLDocumentParserScope.h Log Message: --- Use smart pointers with WebCore::CachedResourceLoader in libxml2/libxslt code https://bugs.webkit.org/show_bug.cgi?id=273204 Reviewed by Chris Dumez and Alex Christensen. Deploy smart pointers for CachedResourceLoader objects used in libxml2/libxslt integration code. Use WeakPtr<> for storing temporary references. Use RefPtr<> when used multiple times in a method. Also change 0 to nullptr functions that were modified. * Source/WebCore/xml/XSLTProcessorLibxslt.cpp: (WebCore::globalCachedResourceLoader): Add. (WebCore::docLoaderFunc): - Add early return when there is no data to parse. This also simplifies the arguments to xmlReadMemory(). (WebCore::setXSLTLoadCallBack): (WebCore::XSLTProcessor::transformToString): * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::matchFunc): (WebCore::shouldAllowExternalLoad): (WebCore::openFunc): - Add early return when XMLDocumentParserScope::currentCachedResourceLoader() is nullptr. - Store Document in a RefPtr. (WebCore::XMLDocumentParser::doEnd): * Source/WebCore/xml/parser/XMLDocumentParserScope.cpp: (WebCore::XMLDocumentParserScope::currentCachedResourceLoader): Add. (WebCore::XMLDocumentParserScope::XMLDocumentParserScope): (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope): * Source/WebCore/xml/parser/XMLDocumentParserScope.h: - Fix old-style indentation of class declaration. - Delete unused default constructor. - Provide default initializers for instance variables. Canonical link: https://commits.webkit.org/277956@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5bc07: Reduce use of mainFrame in WebKitTestRunner
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5bc077e845e5db0074787179d7fb03de97952e9 https://github.com/WebKit/WebKit/commit/c5bc077e845e5db0074787179d7fb03de97952e9 Author: Alex Christensen Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Log Message: --- Reduce use of mainFrame in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=273154 rdar://126952996 Reviewed by Charlie Wolfe. In many places we can just get the current frame. Using the main frame is problematic with site isolation because it is often not in the current process. * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::replaceFindMatchesAtIndices): (WTR::TestRunner::isPageBoxVisible): (WTR::TestRunner::evaluateScriptInIsolatedWorld): (WTR::TestRunner::setTextDirection): (WTR::TestRunner::callShouldCloseOnWebView): (WTR::TestRunner::failNextNewCodeBlock): (WTR::TestRunner::numberOfDFGCompiles): (WTR::TestRunner::neverInlineFunction): (WTR::TestRunner::setOpenPanelFiles): (WTR::TestRunner::setAppBoundDomains): (WTR::TestRunner::setManagedDomains): (WTR::TestRunner::generateTestReport): * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: Canonical link: https://commits.webkit.org/277955@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b7ea9: TestRunner::queueLoad should resolve against main ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b7ea996dd8ed8ec444695e1a7f6522a1161eaa8 https://github.com/WebKit/WebKit/commit/6b7ea996dd8ed8ec444695e1a7f6522a1161eaa8 Author: Alex Christensen Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/WorkQueueManager.cpp Log Message: --- TestRunner::queueLoad should resolve against main frame URL in UI process https://bugs.webkit.org/show_bug.cgi?id=273215 rdar://127013069 Reviewed by Charlie Wolfe. With site isolation enabled, the main frame might not be in the same process as the caller of TestRunner::queueLoad. This is the first of at least 2 issues found by http/tests/navigation/sec-fetch-site-header-on-redirection.html * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::queueLoad): * Tools/WebKitTestRunner/WorkQueueManager.cpp: (WTR::WorkQueueManager::queueLoad): Canonical link: https://commits.webkit.org/277954@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0feced: Add support for specifying required recipient cont...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0feced788ade150bbdb6a80e0934add69b4a30dd https://github.com/WebKit/WebKit/commit/0feced788ade150bbdb6a80e0934add69b4a30dd Author: Robin Malhotra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https-expected.txt M LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html M Source/WebCore/Modules/applepay/ApplePayContactField.cpp M Source/WebCore/Modules/applepay/ApplePayContactField.h M Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.h M Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebKit/Shared/ApplePay/DisbursementPaymentRequest.h M Source/WebKit/Shared/ApplePay/cocoa/DisbursementPaymentRequestCocoa.mm M Source/WebKit/Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm M Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Add support for specifying required recipient contact fields for Disbursement requests https://bugs.webkit.org/show_bug.cgi?id=272526 rdar://115776112 Reviewed by Abrar Rahman Protyasha. We add support for the requisite types to specify recipient contact information in a DisbursementRequest * LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https-expected.txt: * LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html: * Source/WebCore/Modules/applepay/ApplePayContactField.cpp: (WebCore::convertAndValidate): * Source/WebCore/Modules/applepay/ApplePayContactField.h: * Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.h: * Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.idl: * Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebKit/Shared/ApplePay/DisbursementPaymentRequest.h: * Source/WebKit/Shared/ApplePay/cocoa/DisbursementPaymentRequestCocoa.mm: (WebKit::platformDisbursementPaymentRequest): * Source/WebKit/Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: (WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): * Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: (WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/277953@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc5c87: Improve error reporting on simulated device boot f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc5c8791d67899f74214f13a338a00aefecc639d https://github.com/WebKit/WebKit/commit/cc5c8791d67899f74214f13a338a00aefecc639d Author: Ben Schwartz Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/xcode/simulated_device.py Log Message: --- Improve error reporting on simulated device boot failure. https://bugs.webkit.org/show_bug.cgi?id=273216 rdar://127015274 Reviewed by Jonathan Bedard. If an error occurs while booting a simulated device, the actual error encountered as a result of `xcrun simctl boot ` is hidden. This output is already passed to ScriptError when it's invoked, so we should catch this exception and print this information to the log. * Tools/Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager._boot_device): Add try/except block to handle ScriptError as a result of simulated device boot failing. Canonical link: https://commits.webkit.org/277952@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ecb43: [Gardening] [DumpRenderTree] Off-by-1 failure afte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ecb437d2bc0b199b513f36774d4ac6664cb8ffa https://github.com/WebKit/WebKit/commit/8ecb437d2bc0b199b513f36774d4ac6664cb8ffa Author: Jonathan Bedard Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening] [DumpRenderTree] Off-by-1 failure after running fonts on macOS https://bugs.webkit.org/show_bug.cgi?id=273212 rdar://121476009 Unreviewed test gardening. * LayoutTests/platform/mac-wk1/TestExpectations: Skip fonts tests. Canonical link: https://commits.webkit.org/277951@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 983b6c: REGRESSION [ Sonoma wk2 Release ] fast/css/nested-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 983b6c8a16f0fbe166336a0c9653cd8eca72f639 https://github.com/WebKit/WebKit/commit/983b6c8a16f0fbe166336a0c9653cd8eca72f639 Author: Jay Stfleur Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- REGRESSION [ Sonoma wk2 Release ] fast/css/nested-table-with-collapsed-borders.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=267891 rdar://121402051 Unreviewed test gardening. Removing test expectation, issue was fixed. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/277950@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1abf6c: Unreviewed, fix the visionOS build after 277939@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1abf6c07bc5bcc82a954c22f236f3be84733f6bc https://github.com/WebKit/WebKit/commit/1abf6c07bc5bcc82a954c22f236f3be84733f6bc Author: Abrar Rahman Protyasha Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm Log Message: --- Unreviewed, fix the visionOS build after 277939@main https://bugs.webkit.org/show_bug.cgi?id=273214 rdar://127012534 Unreviewed build fix. Fix the build by replacing a call to PAL::currentUserInterfaceIdiomIsVisionOrVisionLegacy with PAL::currentUserInterfaceIdiomIsVision, since the former had been removed in 277892@main. * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::overrideAvailableScreenSize): Canonical link: https://commits.webkit.org/277949@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 52b74b: [WebGPU] IPC layer should be able to determine if ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 52b74baecbe4d4c3b8f3a1378de0ab0948f71f0b https://github.com/WebKit/WebKit/commit/52b74baecbe4d4c3b8f3a1378de0ab0948f71f0b Author: Mike Wyrzykowski Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPU.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h M Source/WebGPU/WebGPU/ExternalTexture.h M Source/WebGPU/WebGPU/ExternalTexture.mm M Source/WebGPU/WebGPU/Instance.mm M Source/WebGPU/WebGPU/PresentationContext.h M Source/WebGPU/WebGPU/PresentationContextCoreAnimation.h M Source/WebGPU/WebGPU/PresentationContextIOSurface.h M Source/WebGPU/WebGPU/WebGPU.h M Source/WebGPU/WebGPU/WebGPUExt.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.messages.in M Source/WebKit/GPUProcess/graphics/WebGPU/WebGPUObjectHeap.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/WebGPUObjectHeap.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h Log Message: --- [WebGPU] IPC layer should be able to determine if a WebGPU object is valid https://bugs.webkit.org/show_bug.cgi?id=272094 Reviewed by Tadeu Zagallo. Patch from Nils with some minor cleanup to determine if an object is valid from the IPC layer. * Source/WebCore/Modules/WebGPU/GPU.h: * Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp: (WebCore::WebGPU::GPUImpl::isValid const): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebGPU/WebGPU/ExternalTexture.h: * Source/WebGPU/WebGPU/ExternalTexture.mm: (WebGPU::ExternalTexture::isValid const): * Source/WebGPU/WebGPU/Instance.mm: (wgpuBufferIsValid): (wgpuAdapterIsValid): (wgpuBindGroupIsValid): (wgpuBindGroupLayoutIsValid): (wgpuCommandBufferIsValid): (wgpuCommandEncoderIsValid): (wgpuComputePassEncoderIsValid): (wgpuComputePipelineIsValid): (wgpuDeviceIsValid): (wgpuExternalTextureIsValid): (wgpuPipelineLayoutIsValid): (wgpuPresentationContextIsValid): (wgpuQuerySetIsValid): (wgpuQueueIsValid): (wgpuRenderBundleEncoderIsValid): (wgpuRenderBundleIsValid): (wgpuRenderPassEncoderIsValid): (wgpuRenderPipelineIsValid): (wgpuSamplerIsValid): (wgpuShaderModuleIsValid): (wgpuTextureIsValid): (wgpuTextureViewIsValid): * Source/WebGPU/WebGPU/PresentationContext.h: (WebGPU::PresentationContext::isValid): * Source/WebGPU/WebGPU/PresentationContextCoreAnimation.h: * Source/WebGPU/WebGPU/PresentationContextIOSurface.h: * Source/WebGPU/WebGPU/WebGPU.h: * Source/WebGPU/WebGPU/WebGPUExt.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp: (WebKit::RemoteGPU::isValid): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.messages.in: * Source/WebKit/GPUProcess/graphics/WebGPU/WebGPUObjectHeap.cpp: (WebKit::WebGPU::ObjectHeap::objectExistsAndValid const): * Source/WebKit/GPUProcess/graphics/WebGPU/WebGPUObjectHeap.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp: (WebKit::RemoteGPUProxy::isValid const): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h: Canonical link: https://commits.webkit.org/277948@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 812621: Re-import html/semantics/popovers WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 812621486d61df6bb975c53792858d9122276bfd https://github.com/WebKit/WebKit/commit/812621486d61df6bb975c53792858d9122276bfd Author: Luke Warlow Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-and-svg-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-appearance-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-backdrop-appearance-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-appearance-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hidden-display-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-inside-display-none-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-display-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking-context-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/wpe/TestExpectations Log Message: --- Re-import html/semantics/popovers WPT https://bugs.webkit.org/show_bug.cgi?id=273136 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/43ae6cd615fad8cd6df2cade33ad48bfb9f285cb * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/ht
[webkit-changes] [WebKit/WebKit] 44ced5: AX: Move objectsForIDs back off of the main thread
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44ced5953d9eec601879c9741c43d238caaea2bc https://github.com/WebKit/WebKit/commit/44ced5953d9eec601879c9741c43d238caaea2bc Author: Joshua Hoffman Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: A LayoutTests/accessibility/create-unconnected-node-during-layout-crash-expected.txt A LayoutTests/accessibility/create-unconnected-node-during-layout-crash.html M LayoutTests/accessibility/mac/doctype-node-in-text-marker-crash.html M Source/WebCore/accessibility/AXLogger.cpp M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm Log Message: --- AX: Move objectsForIDs back off of the main thread https://bugs.webkit.org/show_bug.cgi?id=272803 rdar://problem/126600212 Reviewed by Tyler Wilcock. This patch moves objectsForIDs back off of the main thread, which was originally done by the now-reverted commit https://commits.webkit.org/272323@main. That patch was reverted due to `addUnconnectedNode` being called at an invalid time (downstream of layout). This patch resolves that by deferring adding these nodes to performDeferredCacheUpdate, when we guarantee it is safe to do so. * LayoutTests/accessibility/create-unconnected-node-during-layout-crash-expected.txt: Added. * LayoutTests/accessibility/create-unconnected-node-during-layout-crash.html: Added. * LayoutTests/accessibility/mac/doctype-node-in-text-marker-crash.html: * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::AXLogger::log): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::deferAddUnconnectedNode): (WebCore::AXObjectCache::performDeferredCacheUpdate): (WebCore::AXObjectCache::addRelation): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::create): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: (WebCore::AXIsolatedTree::objectsForIDs): * Source/WebCore/accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::createIsolatedObjectIfNeeded): (WebCore::AXObjectCache::postTextStateChangePlatformNotification): (WebCore::AXObjectCache::postUserInfoForChanges): (WebCore::AXObjectCache::postTextReplacementPlatformNotification): (WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl): (WebCore::AXObjectCache::onSelectedTextChanged): (WebCore::createIsolatedObjectIfNeeded): Deleted. (WebCore::postUserInfoForChanges): Deleted. Canonical link: https://commits.webkit.org/277946@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a9813: [GLIB] Generate the serialization of UserMessage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a98138e00f6081207550bd007e29a4c7bc1bd25 https://github.com/WebKit/WebKit/commit/1a98138e00f6081207550bd007e29a4c7bc1bd25 Author: Claudio Saavedra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/Shared/glib/UserMessage.cpp M Source/WebKit/Shared/glib/UserMessage.h M Source/WebKit/Shared/glib/UserMessage.serialization.in Log Message: --- [GLIB] Generate the serialization of UserMessage https://bugs.webkit.org/show_bug.cgi?id=272985 Reviewed by Michael Catanzaro. Add a couple of helper data structures for each of the different types of messages, and use a variant for serialization, to avoid replicating by hand what the generated code will do for a variant type. * Source/WebKit/Shared/glib/UserMessage.cpp: (WebKit::UserMessage::toIPCData const): (WebKit::UserMessage::fromIPCData): (WebKit::UserMessage::encode const): Deleted. (WebKit::UserMessage::decode): Deleted. * Source/WebKit/Shared/glib/UserMessage.h: (WebKit::UserMessage::UserMessage): * Source/WebKit/Shared/glib/UserMessage.serialization.in: Canonical link: https://commits.webkit.org/277945@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d10b5a: Avoid changing the ordering of attributes when mar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d10b5ad2c28f6657737d54517e5d8486568c35c9 https://github.com/WebKit/WebKit/commit/d10b5ad2c28f6657737d54517e5d8486568c35c9 Author: Sihui Liu Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: A LayoutTests/http/tests/dom/resources/simple-iframe.html A LayoutTests/http/tests/dom/serialize-fragment-attributes-order-expected.txt A LayoutTests/http/tests/dom/serialize-fragment-attributes-order.html M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/ShadowRoot.cpp M Source/WebCore/editing/MarkupAccumulator.cpp M Source/WebCore/editing/MarkupAccumulator.h M Source/WebCore/editing/markup.cpp M Source/WebCore/editing/markup.h M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp Log Message: --- Avoid changing the ordering of attributes when markup is not created for saving page https://bugs.webkit.org/show_bug.cgi?id=273130 rdar://126120490 Reviewed by Ryosuke Niwa. URL replacement mode in MarkupAccumulator is introduced specifically for saving web page, and it should not affect result of other cases; otherwise it might break existing usecases. 276043@main accidentally changes the ordering of attributes by appending crossorigin attribute to the end -- even when MarkupAccumulator is not created with URL replacement mode. This patch fixes that by appending attributes in original order when URL replacement is not enabled. (see MarkupAccumulator::appendStartTag). Also, to make it easier to distinguish between URL replacement mode and others, this patch adds two functions: serializeFragmentWithURLReplacement and MarkupAccumulator::enableURLReplacement. * LayoutTests/http/tests/dom/resources/simple-iframe.html: Added. * LayoutTests/http/tests/dom/serialize-fragment-attributes-order-expected.txt: Added. * LayoutTests/http/tests/dom/serialize-fragment-attributes-order.html: Added. * Source/WebCore/dom/Element.cpp: (WebCore::Element::getHTML const): * Source/WebCore/dom/ShadowRoot.cpp: (WebCore::ShadowRoot::getHTML const): * Source/WebCore/editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::MarkupAccumulator): (WebCore::MarkupAccumulator::enableURLReplacement): (WebCore::MarkupAccumulator::appendContentsForNode): (WebCore::MarkupAccumulator::resolveURLIfNeeded const): (WebCore::MarkupAccumulator::appendStartTagWithURLReplacement): (WebCore::MarkupAccumulator::appendStartTag): (WebCore::MarkupAccumulator::frameForAttributeReplacement const): (WebCore::MarkupAccumulator::replaceAttributeIfNecessary): (WebCore::MarkupAccumulator::appendURLAttributeForReplacementIfNecessary): * Source/WebCore/editing/MarkupAccumulator.h: (WebCore::MarkupAccumulator::MarkupAccumulator): * Source/WebCore/editing/markup.cpp: (WebCore::serializeFragment): (WebCore::serializeFragmentWithURLReplacement): * Source/WebCore/editing/markup.h: (WebCore::serializeFragment): (WebCore::serializeFragmentWithURLReplacement): * Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Canonical link: https://commits.webkit.org/277944@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 28b0ed: AX: Rebase Mac WK1 inspector/dom/getAccessibilityP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 28b0eda5b023792c9c6a326a3a3963ac6fe0d11f https://github.com/WebKit/WebKit/commit/28b0eda5b023792c9c6a326a3a3963ac6fe0d11f Author: Tyler Wilcock Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt Log Message: --- AX: Rebase Mac WK1 inspector/dom/getAccessibilityPropertiesForNode.html test after 277894@main https://bugs.webkit.org/show_bug.cgi?id=273202 rdar://problem/126996058 Unreviewed test gardening. This test just needs a rebase after 277894@main. * LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt: Canonical link: https://commits.webkit.org/277943@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2cd5d: Add Cam Braverman to contributors.json.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2cd5de9d111964fe0778a3ff2af8106a71771a9 https://github.com/WebKit/WebKit/commit/c2cd5de9d111964fe0778a3ff2af8106a71771a9 Author: Cam Braverman Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M metadata/contributors.json Log Message: --- Add Cam Braverman to contributors.json. Reviewed by Jonathan Bedard. * metadata/contributors.json: Canonical link: https://commits.webkit.org/277942@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d17645: Fix typo "Fetach"
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d176453491d810fafeb25891b10135eec0e702eb https://github.com/WebKit/WebKit/commit/d176453491d810fafeb25891b10135eec0e702eb Author: Ben Schwartz Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js Log Message: --- Fix typo "Fetach" rdar://127000208 https://bugs.webkit.org/show_bug.cgi?id=273205 Unreviewed typo fix. Change "Fetach" -> "Fetch". * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js: (Dashboard.prototype.reload): Canonical link: https://commits.webkit.org/277941@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c49258: [GLIB] Generate serialization for InputMethodState
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c49258e1fca815f00b75676cb6a1e10370400b25 https://github.com/WebKit/WebKit/commit/c49258e1fca815f00b75676cb6a1e10370400b25 Author: Claudio Saavedra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/Shared/glib/InputMethodState.cpp M Source/WebKit/Shared/glib/InputMethodState.h M Source/WebKit/Shared/glib/InputMethodState.serialization.in Log Message: --- [GLIB] Generate serialization for InputMethodState https://bugs.webkit.org/show_bug.cgi?id=273197 Reviewed by Michael Catanzaro. * Source/WebKit/Shared/glib/InputMethodState.cpp: (WebKit::InputMethodState::encode const): Deleted. (WebKit::InputMethodState::decode): Deleted. * Source/WebKit/Shared/glib/InputMethodState.h: * Source/WebKit/Shared/glib/InputMethodState.serialization.in: Canonical link: https://commits.webkit.org/277940@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 309213: Make it possible to override the available screen ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 309213aa9218201bde2523ce2fb86c1d1288e055 https://github.com/WebKit/WebKit/commit/309213aa9218201bde2523ce2fb86c1d1288e055 Author: Megan Gardner Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/page/Chrome.cpp M Source/WebCore/page/Chrome.h M Source/WebCore/page/ChromeClient.h M Source/WebCore/platform/HostWindow.h M Source/WebCore/platform/PlatformScreen.h M Source/WebCore/platform/ios/PlatformScreenIOS.mm M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/Shared/WebPageCreationParameters.serialization.in M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.h M Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm Log Message: --- Make it possible to override the available screen size. https://bugs.webkit.org/show_bug.cgi?id=273150 rdar://126494764 Reviewed by Abrar Rahman Protyasha. Similar to https://bugs.webkit.org/show_bug.cgi?id=184111 allow for the override of available screen size to match the override of screen size. * Source/WebCore/page/Chrome.cpp: (WebCore::Chrome::overrideAvailableScreenSize const): * Source/WebCore/page/Chrome.h: * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::overrideAvailableScreenSize const): * Source/WebCore/platform/HostWindow.h: * Source/WebCore/platform/PlatformScreen.h: * Source/WebCore/platform/ios/PlatformScreenIOS.mm: (WebCore::screenAvailableRect): (WebCore::overrideAvailableScreenSize): * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/Shared/WebPageCreationParameters.serialization.in: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::overrideAvailableScreenSize): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::overrideAvailableScreenSize const): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::overrideAvailableScreenSize const): * Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.h: * Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::overrideAvailableScreenSize const): Canonical link: https://commits.webkit.org/277939@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] edf053: in in-window mode, video play/pauses when moving m...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: edf05350b9fb49af69ba20327ff7201f7b282979 https://github.com/WebKit/WebKit/commit/edf05350b9fb49af69ba20327ff7201f7b282979 Author: Dana Estra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/Modules/modern-media-controls/controls/button.js M Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js Log Message: --- in in-window mode, video play/pauses when moving media controls https://bugs.webkit.org/show_bug.cgi?id=273127 rdar://126300898 Reviewed by Jer Noble. On youtube.com, the click event on the media controls propagates down to the video element, Where YouTube handles the event by toggling play/pause on the video. To fix this, we do Not want events on the media controls to propagate down. And so the call to stopPropagation() on The event should be moved from the button class to the macOSFullscreenMediaControls class. * Source/WebCore/Modules/modern-media-controls/controls/button.js: (Button.prototype.handleEvent): * Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js: (MacOSFullscreenMediaControls.prototype.handleEvent): Canonical link: https://commits.webkit.org/277938@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e327d4: Allow apps to set a custom inspection name for web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e327d4468b6d6c0366404ed9e35dd215d4062610 https://github.com/WebKit/WebKit/commit/e327d4468b6d6c0366404ed9e35dd215d4062610 Author: Kiara Rose Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h M Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm M Source/WebCore/en.lproj/Localizable.strings M Source/WebCore/page/PageDebuggable.cpp M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfigurationPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.h M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Inspector/WebPageDebuggable.cpp M Source/WebKit/UIProcess/Inspector/WebPageDebuggable.h Log Message: --- Allow apps to set a custom inspection name for web extension background and popup web views https://bugs.webkit.org/show_bug.cgi?id=273161 rdar://125874004 Reviewed by Timothy Hatcher. Add API to allow apps to set a custom inspection name for background and popup web views. Also, add a `nameOverride()` method to WebPageDebuggable. This will allow us to keep track of overrides that are set for the web pages. * Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h: * Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h: * Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm: (Inspector::RemoteInspector::listingForInspectionTarget const): Set the name override on the listing. * Source/WebCore/en.lproj/Localizable.strings: Add localized strings for text shown when inspecting the extension popup. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm: (-[_WKWebExtensionAction inspectionName]): (-[_WKWebExtensionAction setInspectionName:]): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext inspectionName]): (-[_WKWebExtensionContext setInspectionName:]): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfigurationPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.h Remove guards since _WKWebExtensionDataRecord.errors API has made it into the build. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm: (WebKit::WebExtensionAction::popupWebViewInspectionName): (WebKit::WebExtensionAction::setPopupWebViewInspectionName): (WebKit::WebExtensionAction::popupWebView): Set the _remoteInspectionNameOverride for the popup web view. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::loadBackgroundWebView): (WebKit::WebExtensionContext::backgroundWebViewInspectionName): (WebKit::WebExtensionContext::setBackgroundWebViewInspectionName): * Source/WebKit/UIProcess/Extensions/WebExtensionAction.h: * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/UIProcess/Inspector/WebPageDebuggable.cpp: (WebKit::WebPageDebuggable::name const): * Source/WebKit/UIProcess/Inspector/WebPageDebuggable.h: Canonical link: https://commits.webkit.org/277937@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f811ce: AX: AXOrientation should be exposed on treegrids
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f811cecca4edab3c311fdd14dfe63acbfd3d https://github.com/WebKit/WebKit/commit/f811cecca4edab3c311fdd14dfe63acbfd3d Author: Dominic Mazzoni Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Log Message: --- AX: AXOrientation should be exposed on treegrids https://bugs.webkit.org/show_bug.cgi?id=273132 rdar://problem/126933732 Reviewed by Andres Gonzalez. The code to check which attributes to expose for a role was checking for tables first, and then tree grids, and not handling the case where a table has a tree grid role and it needs to expose both. * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::attributeValue): Canonical link: https://commits.webkit.org/277936@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 52ad46: [IFC] Do not call RenderBlockFlow::invalidateLineL...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 52ad4683bb239a6d4d9ce43337b7049f075c0a79 https://github.com/WebKit/WebKit/commit/52ad4683bb239a6d4d9ce43337b7049f075c0a79 Author: Alan Baradlay Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/rendering/RenderObject.cpp Log Message: --- [IFC] Do not call RenderBlockFlow::invalidateLineLayoutPath on renderer insertion/removal when there's no line layout https://bugs.webkit.org/show_bug.cgi?id=273104 Reviewed by Antti Koivisto. At this point invalidateLineLayoutPath is not really about invalidating the codepath (more like destroying LineLayout) so no reason to call it unless we have modernLayout. * Source/WebCore/rendering/RenderObject.cpp: (WebCore::invalidateLineLayoutAfterTreeMutationIfNeeded): Canonical link: https://commits.webkit.org/277935@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5930a2: Remove webkitpy.xcode.simulated_device.SimulatedDe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5930a2043a2b1a7786a5f4a60b31a8d3dcbbee31 https://github.com/WebKit/WebKit/commit/5930a2043a2b1a7786a5f4a60b31a8d3dcbbee31 Author: Ben Schwartz Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/xcode/simulated_device.py Log Message: --- Remove webkitpy.xcode.simulated_device.SimulatedDeviceManager.swap. https://bugs.webkit.org/show_bug.cgi?id=273160 rdar://126954534 Reviewed by Jonathan Bedard. SimulatedDeviceManager.swap is an unused function that is a remnant of an ancient experiment. It should be removed, as it has no modern use. * Tools/Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager.max_supported_simulators): (SimulatedDeviceManager.swap): Deleted. Canonical link: https://commits.webkit.org/277934@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a1e51b: Expand use of WKBundlePagePostMessageWithAsyncReply
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a1e51b3692258c8c4643de82d12d06773f1069fa https://github.com/WebKit/WebKit/commit/a1e51b3692258c8c4643de82d12d06773f1069fa Author: Alex Christensen Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/TestInvocation.cpp M Tools/WebKitTestRunner/TestInvocation.h Log Message: --- Expand use of WKBundlePagePostMessageWithAsyncReply https://bugs.webkit.org/show_bug.cgi?id=273162 rdar://126956541 Reviewed by Sihui Liu. This helps site isolation testing by sending the reply to the sending process instead of the main frame process. This is covered by 2 tests: http/tests/resourceLoadStatistics/set-custom-prevalent-resource-in-debug-mode.html http/tests/resourceLoadStatistics/enable-debug-mode.html * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::postMessageWithAsyncReplyImpl): (WTR::postMessageWithAsyncReply): * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsDebugMode): (WTR::TestRunner::statisticsCallDidSetDebugModeCallback): Deleted. * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveAsyncMessageFromInjectedBundle): (WTR::TestController::setStatisticsDebugMode): * Tools/WebKitTestRunner/TestController.h: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::didSetStatisticsDebugMode): Deleted. * Tools/WebKitTestRunner/TestInvocation.h: Canonical link: https://commits.webkit.org/277933@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e3f843: [WebGPU] maxInterStageShaderComponents should be 64
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3f843a7e2e5c0f197428e38840eb2390fc00486 https://github.com/WebKit/WebKit/commit/e3f843a7e2e5c0f197428e38840eb2390fc00486 Author: Mike Wyrzykowski Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebGPU/WebGPU/HardwareCapabilities.mm Log Message: --- [WebGPU] maxInterStageShaderComponents should be 64 https://bugs.webkit.org/show_bug.cgi?id=273191 Reviewed by Tadeu Zagallo. Spec was changed a few weeks ago and now the CTS reflects that. Increase limit from 60 -> 64. Verified https://gpuweb.github.io/cts/standalone/?q=webgpu:api,validation,capability_checks,* passes after this change. * Source/WebGPU/WebGPU/HardwareCapabilities.mm: (WebGPU::apple3): (WebGPU::mac2): (WebGPU::defaultLimits): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.messages.in: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in: Canonical link: https://commits.webkit.org/277932@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f65325: [git-webkit] Revert should include the identifier ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f65325499d4b21165de8fda96f404806bd13cc69 https://github.com/WebKit/WebKit/commit/f65325499d4b21165de8fda96f404806bd13cc69 Author: Brianna Fan Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py Log Message: --- [git-webkit] Revert should include the identifier and hash https://bugs.webkit.org/show_bug.cgi?id=265594 rdar://119329882 Reviewed by Jonathan Bedard. Replaces https://commits.webkit.org/1234@main with 1234@main () in the commit message. Also adds the hash to the commit title. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py: (Revert.create_revert_commit_msg): * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py: (TestRevert.webserver): (TestRevert): (test_update): (test_pr): (test_land_safe): (test_land_unsafe): Canonical link: https://commits.webkit.org/277931@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75e607: AX: Rebase Mac WK1 accessibility/aria-visible-elem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75e607b8464ad2acdd0e3f9846ffd5efe7c5ea60 https://github.com/WebKit/WebKit/commit/75e607b8464ad2acdd0e3f9846ffd5efe7c5ea60 Author: Tyler Wilcock Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt Log Message: --- AX: Rebase Mac WK1 accessibility/aria-visible-element-roles.html test after 277894@main https://bugs.webkit.org/show_bug.cgi?id=273192 rdar://problem/126988288 Unreviewed test gardening. This test just needs a rebase after 277894@main. * LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt: Canonical link: https://commits.webkit.org/277930@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ac73c: Disable WKWebExtensionDataRecord.RemoveDataRecords
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ac73cce95be7f8ff2e78fa1ae4bd37d002ef12a https://github.com/WebKit/WebKit/commit/8ac73cce95be7f8ff2e78fa1ae4bd37d002ef12a Author: Kiara Rose Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionDataRecord.mm Log Message: --- Disable WKWebExtensionDataRecord.RemoveDataRecords https://bugs.webkit.org/show_bug.cgi?id=273153 rdar://126951537 Reviewed by Brian Weinstein. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionDataRecord.mm: (TestWebKitAPI::TEST(WKWebExtensionDataRecord, DISABLED_RemoveDataRecords)): (TestWebKitAPI::TEST(WKWebExtensionDataRecord, RemoveDataRecords)): Deleted. Canonical link: https://commits.webkit.org/277929@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 93db88: Nested duplicate named capturing groups in regex i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93db8886b0d38f019b6504805d078e07662f93f1 https://github.com/WebKit/WebKit/commit/93db8886b0d38f019b6504805d078e07662f93f1 Author: Michael Saboff Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M JSTests/stress/regexp-duplicate-named-captures.js M Source/JavaScriptCore/yarr/YarrParser.h Log Message: --- Nested duplicate named capturing groups in regex is not syntax error https://bugs.webkit.org/show_bug.cgi?id=272659 rdar://126863735 Reviewed by Alexey Shvayka. Updated the record keeping of capture names in nested parenthesis and disjunctions. Now we agregate all group names seen in nested parenthesis and bubble them up to the cantaining disjunction. Added new test cases. Also updated the syntax error testing code to make sure that an expected error is actually thrown. This change uncovered an unrelated test case that needed updating with the addition of a flag. * JSTests/stress/regexp-duplicate-named-captures.js: (testRegExpSyntaxError): * Source/JavaScriptCore/yarr/YarrParser.h: (JSC::Yarr::Parser::NamedCaptureGroups::NamedCaptureGroups): (JSC::Yarr::Parser::NamedCaptureGroups::reset): (JSC::Yarr::Parser::NamedCaptureGroups::nextAlternative): (JSC::Yarr::Parser::NamedCaptureGroups::pushParenthesis): (JSC::Yarr::Parser::NamedCaptureGroups::popParenthesis): (JSC::Yarr::Parser::NamedCaptureGroups::add): Canonical link: https://commits.webkit.org/277928@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9706f3: [visionOS] Fix build issue and re-baseline layer b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9706f30b429bdf90adfa92bcf6305e41cc03a6db https://github.com/WebKit/WebKit/commit/9706f30b429bdf90adfa92bcf6305e41cc03a6db Author: Etienne Segonzac Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M LayoutTests/interaction-region/interaction-layers-culling-expected.txt M LayoutTests/interaction-region/interaction-layers-culling-layer-type-change-expected.txt M LayoutTests/interaction-region/layer-tree-expected.txt M LayoutTests/interaction-region/layer-tree-shape-reset-expected.txt M LayoutTests/overlay-region/fixed-node-updates-expected.txt M LayoutTests/overlay-region/full-page-dynamic-expected.txt M LayoutTests/overlay-region/full-page-expected.txt M LayoutTests/overlay-region/full-page-horizontal-expected.txt M LayoutTests/overlay-region/full-page-overflow-expected.txt M LayoutTests/overlay-region/full-page-overflow-scrolling-expected.txt M LayoutTests/overlay-region/full-page-overflow-snapping-expected.txt M LayoutTests/overlay-region/full-page-scrolling-expected.txt M LayoutTests/overlay-region/many-candidates-expected.txt M LayoutTests/overlay-region/map-expected.txt M LayoutTests/overlay-region/map-small-expected.txt M LayoutTests/overlay-region/overlay-element-expected.txt M LayoutTests/overlay-region/overlay-element-overflow-expected.txt M LayoutTests/overlay-region/snapping-expected.txt M LayoutTests/overlay-region/split-scrollers-expected.txt M Source/WebCore/rendering/EventRegion.h Log Message: --- [visionOS] Fix build issue and re-baseline layer based tests https://bugs.webkit.org/show_bug.cgi?id=273186 rdar://126984383 Reviewed by Mike Wyrzykowski. Add the missing include to fix the build failure and re-baseline layer tests (again). * Source/WebCore/rendering/EventRegion.h: Unified sources fun, prevent `explicit specialization after instantiation` error on IntRect hashes. * LayoutTests/interaction-region/interaction-layers-culling-expected.txt: * LayoutTests/interaction-region/interaction-layers-culling-layer-type-change-expected.txt: * LayoutTests/interaction-region/layer-tree-expected.txt: * LayoutTests/interaction-region/layer-tree-shape-reset-expected.txt: * LayoutTests/overlay-region/fixed-node-updates-expected.txt: * LayoutTests/overlay-region/full-page-dynamic-expected.txt: * LayoutTests/overlay-region/full-page-expected.txt: * LayoutTests/overlay-region/full-page-horizontal-expected.txt: * LayoutTests/overlay-region/full-page-overflow-expected.txt: * LayoutTests/overlay-region/full-page-overflow-scrolling-expected.txt: * LayoutTests/overlay-region/full-page-overflow-snapping-expected.txt: * LayoutTests/overlay-region/full-page-scrolling-expected.txt: * LayoutTests/overlay-region/many-candidates-expected.txt: * LayoutTests/overlay-region/map-expected.txt: * LayoutTests/overlay-region/map-small-expected.txt: * LayoutTests/overlay-region/overlay-element-expected.txt: * LayoutTests/overlay-region/overlay-element-overflow-expected.txt: * LayoutTests/overlay-region/snapping-expected.txt: * LayoutTests/overlay-region/split-scrollers-expected.txt: Re-baseline tests. Canonical link: https://commits.webkit.org/277927@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7e21ad: [JSC] Drop unnecessary ConcurrentJSLock for Baseli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7e21ad4d8bdeba3e45ee1e19c452ac123493a90f https://github.com/WebKit/WebKit/commit/7e21ad4d8bdeba3e45ee1e19c452ac123493a90f Author: Yusuke Suzuki Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/JavaScriptCore/bytecode/CodeBlock.cpp Log Message: --- [JSC] Drop unnecessary ConcurrentJSLock for BaselineJITData materialization https://bugs.webkit.org/show_bug.cgi?id=273172 rdar://126971526 Reviewed by Mark Lam. After 276292@main, we no longer need a lock for BaselineJITData population. * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::setupWithUnlinkedBaselineCode): Canonical link: https://commits.webkit.org/277926@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ddbc12: Unreviewed, reverting 277918@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ddbc1296e6d327c36bf528d8ac54931ebe934c1b https://github.com/WebKit/WebKit/commit/ddbc1296e6d327c36bf528d8ac54931ebe934c1b Author: Chris Dumez Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/Configurations/BaseExtension.xcconfig M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Unreviewed, reverting 277918@main https://bugs.webkit.org/show_bug.cgi?id=273194 rdar://126927058 Unreviewed, revert 277918@main as Isi says it is no longer needed Reverted change: Unreviewed, reverting 277816@main https://bugs.webkit.org/show_bug.cgi?id=273168 rdar://126927058 https://commits.webkit.org/277918@main Canonical link: https://commits.webkit.org/277925@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 663387: REGRESSION (269108@main): Same-origin XSLT documen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 66338748251c4f55d2b29e32e4851add3ed40f0e https://github.com/WebKit/WebKit/commit/66338748251c4f55d2b29e32e4851add3ed40f0e Author: David Kilzer Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: R LayoutTests/http/tests/security/resources/xslt-external-entity.svg R LayoutTests/http/tests/security/resources/xslt2.py A LayoutTests/http/tests/security/resources/xss-ALLOWED-xsl-external-entity-xslt-docloader.py A LayoutTests/http/tests/security/resources/xss-ALLOWED-xsl-external-entity-xslt-docloader.svg A LayoutTests/http/tests/security/resources/xss-ALLOWED-xsl-external-entity-xslt-docloader.xml A LayoutTests/http/tests/security/resources/xss-DENIED-xsl-external-entity-xslt-docloader.py A LayoutTests/http/tests/security/resources/xss-DENIED-xsl-external-entity-xslt-docloader.svg R LayoutTests/http/tests/security/xslt-external-entity-expected.txt R LayoutTests/http/tests/security/xslt-external-entity.html A LayoutTests/http/tests/security/xss-ALLOWED-xsl-external-entity-xslt-docloader-expected.txt A LayoutTests/http/tests/security/xss-ALLOWED-xsl-external-entity-xslt-docloader.html A LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-xslt-docloader-expected.txt A LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-xslt-docloader.html R LayoutTests/platform/mac-monterey/http/tests/security/xslt-external-entity-expected.txt A LayoutTests/platform/mac-monterey/http/tests/security/xss-DENIED-xsl-external-entity-xslt-docloader-expected.txt M Source/WebCore/xml/XSLTProcessorLibxslt.cpp M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Log Message: --- REGRESSION (269108@main): Same-origin XSLT document() loads fail https://bugs.webkit.org/show_bug.cgi?id=273106 Reviewed by Alex Christensen. Prior to this change, all external entity loads using docLoaderFunc() in XSLTProcessorLibxslt.cpp would fail in shouldAllowExternalLoad() because XMLDocumentParserScope::currentCachedResourceLoader was nullptr. This caused both cross-origin loads and same-origin loads to fail. The fix is to make use of XMLDocumentParserScope in docLoaderFunc() to set XMLDocumentParserScope::currentCachedResourceLoader so that the same-origin policy is applied. We keep the check added to shouldAllowExternalLoad() from 269108@main in case a load is initiated without using XMLDocumentParserScope, and this change adds a Debug assert to catch those cases before the load fails. Tests: http/tests/security/xss-ALLOWED-xsl-external-entity-xslt-docloader.html http/tests/security/xss-DENIED-xsl-external-entity-xslt-docloader.html * LayoutTests/http/tests/security/resources/xss-ALLOWED-xsl-external-entity-xslt-docloader.py: Add. * LayoutTests/http/tests/security/resources/xss-ALLOWED-xsl-external-entity-xslt-docloader.svg: Copy from LayoutTests/http/tests/security/resources/xslt-external-entity.svg. * LayoutTests/http/tests/security/resources/xss-ALLOWED-xsl-external-entity-xslt-docloader.xml: Add. * LayoutTests/http/tests/security/resources/xss-DENIED-xsl-external-entity-xslt-docloader.py: Rename from LayoutTests/http/tests/security/resources/xslt2.py. * LayoutTests/http/tests/security/resources/xss-DENIED-xsl-external-entity-xslt-docloader.svg: Rename from LayoutTests/http/tests/security/resources/xslt-external-entity.svg. * LayoutTests/http/tests/security/xss-ALLOWED-xsl-external-entity-xslt-docloader-expected.txt: Add. * LayoutTests/http/tests/security/xss-ALLOWED-xsl-external-entity-xslt-docloader.html: Copy from LayoutTests/http/tests/security/xslt-external-entity.html. * LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-xslt-docloader-expected.txt: Rename from LayoutTests/http/tests/security/xslt-external-entity-expected.txt. - Update results with denied console messages. This change is the result of the bug fix. * LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-xslt-docloader.html: Rename from LayoutTests/http/tests/security/xslt-external-entity.html. - Add xss-ALLOWED-xsl-external-entity-xslt-docloader.html to test the same-origin case. This test failed before this fix. - Rename http/tests/security/xslt-external-entity.html to xss-DENIED-xsl-external-entity-xslt-docloader.html to match similar test cases. * LayoutTests/platform/mac-monterey/http/tests/security/xss-DENIED-xsl-external-entity-xslt-docloader-expected.txt: Rename from LayoutTests/platform/mac-monterey/http/tests/security/xslt-external-entity-expected.txt. - Update results with denied console messages. This change is the result of the bug fix. * Source/WebCore/xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc): - Make use of WebCore::XMLDocumentParserScope to fix the bug. * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::shouldAllowExternalLoad): - Add Debug assert to cat
[webkit-changes] [WebKit/WebKit] 22e6de: Regression(276851@main) GPUProcessProxy::sendBookm...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22e6debaea7ab722ac27a9ccfa3f7f72a5530b23 https://github.com/WebKit/WebKit/commit/22e6debaea7ab722ac27a9ccfa3f7f72a5530b23 Author: Chris Dumez Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm Log Message: --- Regression(276851@main) GPUProcessProxy::sendBookmarkDataForCacheDirectory() hangs the main thread https://bugs.webkit.org/show_bug.cgi?id=273164 rdar://126946636 Reviewed by Per Arne Vollan. 276851@main started calling GPUProcessProxy::sendBookmarkDataForCacheDirectory() on the main thread as soon as the GPUProcess finishes launches. The issue is that this function does file system operations which may hang the UIProcess' main thread. This results in an app launch regression for certain apps. To address the issue, I moved the filesystem operation and the IPC to a background queue. * Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm: (WebKit::GPUProcessProxy::sendBookmarkDataForCacheDirectory): Canonical link: https://commits.webkit.org/277923@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e0902: REGRESSION (277633@main): [ MacOS iOS Debug ] Test...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e0902cf80f621c0d596a179bf3c71f4765ebd61 https://github.com/WebKit/WebKit/commit/4e0902cf80f621c0d596a179bf3c71f4765ebd61 Author: Geoffrey Garen Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/CheckedRef.cpp Log Message: --- REGRESSION (277633@main): [ MacOS iOS Debug ] TestWTF.WTF_CheckedPtr.CheckedRef is a consistent crash https://bugs.webkit.org/show_bug.cgi?id=273158 rdar://126954078 Unreviewed test fix. Removed use after destruction test, since we assert when you do that now. Changed test objects to be heap-allocated instead of stack-allocated. Stack allocation wasn't the direct cause of the failure we saw, but CheckedPtr requires heap allocation as of 277633@main, so let's do it right. * Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp: (TestWebKitAPI::TEST(WTF_CheckedPtr, Basic)): (TestWebKitAPI::TEST(WTF_CheckedPtr, CheckedRef)): (TestWebKitAPI::TEST(WTF_CheckedPtr, DerivedClass)): (TestWebKitAPI::TEST(WTF_CheckedPtr, HashSet)): (TestWebKitAPI::TEST(WTF_CheckedPtr, ReferenceCountLimit)): (TestWebKitAPI::TEST(WTF_CheckedPtr, CanMakeThreadSafeCheckedPtr)): * Tools/TestWebKitAPI/Tests/WTF/CheckedRef.cpp: Canonical link: https://commits.webkit.org/277922@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d81e21: [GTK][WPE] AX: Support AXActiveElement and AXSelec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d81e219170a2d89c07bff1c116ec69597757f32c https://github.com/WebKit/WebKit/commit/d81e219170a2d89c07bff1c116ec69597757f32c Author: Vitaly Dyachkov Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/SourcesGTK.txt M Source/WebCore/SourcesWPE.txt M Source/WebCore/accessibility/AXCoreObject.cpp M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp M Source/WebCore/accessibility/atspi/AccessibilityAtspi.h A Source/WebCore/accessibility/atspi/AccessibilityObjectActiveDescendantAtspi.cpp M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h M Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp Log Message: --- [GTK][WPE] AX: Support AXActiveElement and AXSelectedChildren for comboboxes, lists and listboxes. https://bugs.webkit.org/show_bug.cgi?id=272981 Reviewed by Adrian Perez de Castro. Similarly to the Mac implementation added in 277649@main. * Source/WebCore/SourcesGTK.txt: * Source/WebCore/SourcesWPE.txt: * Source/WebCore/accessibility/AXCoreObject.cpp: (WebCore::AXCoreObject::activeDescendant const): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleActiveDescendantChange): * Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp: (WebCore::AXObjectCache::postPlatformNotification): * Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp: (WebCore::AccessibilityAtspi::activeDescendantChanged): (WebCore::AccessibilityAtspi::notifyActiveDescendantChanged const): * Source/WebCore/accessibility/atspi/AccessibilityAtspi.h: * Source/WebCore/accessibility/atspi/AccessibilityObjectActiveDescendantAtspi.cpp: Added. (WebCore::AccessibilityObjectAtspi::activeDescendant const): (WebCore::AccessibilityObjectAtspi::activeDescendantChanged): * Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h: * Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp: (WebCore::AccessibilityObjectAtspi::selectedChildren const): * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::dateValue): (WTR::AccessibilityUIElement::activeElement const): (WTR::AccessibilityUIElement::selectedChildren const): * Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp: (WTR::AccessibilityUIElement::activeElement const): (WTR::AccessibilityUIElement::selectedChildren const): Canonical link: https://commits.webkit.org/277921@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 995e95: [Skia] Implement kConic_Verb in PathSkia::applyEle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 995e95883a59ae1f8bf702b00ca50029362b0b66 https://github.com/WebKit/WebKit/commit/995e95883a59ae1f8bf702b00ca50029362b0b66 Author: Carlos Garcia Campos Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/PathSkia.cpp Log Message: --- [Skia] Implement kConic_Verb in PathSkia::applyElements https://bugs.webkit.org/show_bug.cgi?id=273179 Reviewed by Alejandro G. Castro. Approximate to two quad curves using SkPath::ConvertConicToQuads(). * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::applyElements const): Canonical link: https://commits.webkit.org/277920@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 493615: Cherry-pick 277325@main (cb5290644a69). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 493615a8916f13e50db611b8de6939b90d23875c https://github.com/WebKit/WebKit/commit/493615a8916f13e50db611b8de6939b90d23875c Author: Said Abou-Hallawa Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: A LayoutTests/svg/filters/filter-on-root-tile-boundary-expected.html A LayoutTests/svg/filters/filter-on-root-tile-boundary.html M Source/WebCore/platform/graphics/filters/FilterOperations.cpp M Source/WebCore/platform/graphics/filters/FilterOperations.h M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/svg/SVGRenderingContext.cpp Log Message: --- Cherry-pick 277325@main (cb5290644a69). https://bugs.webkit.org/show_bug.cgi?id=265465 REGRESSION(267236@main): SVG may incorrectly be clipped when an SVGFilter is applied to its root https://bugs.webkit.org/show_bug.cgi?id=265465 rdar://118938065 Reviewed by Nikolas Zimmermann. Ensure the SVGFilter is applied only once to the RenderSVGRoot through the SVG rendering code. But use the RenderLayerFilters to repaint the referenced SVGFilter clients when its effects are changed. * LayoutTests/svg/filters/filter-on-root-tile-boundary-expected.html: Added. * LayoutTests/svg/filters/filter-on-root-tile-boundary.html: Added. * Source/WebCore/platform/graphics/filters/FilterOperations.cpp: (WebCore::FilterOperations::isReferenceFilter const): * Source/WebCore/platform/graphics/filters/FilterOperations.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintsWithFilters const): (WebCore::RenderLayer::calculateClipRects const): * Source/WebCore/rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::prepareToRenderSVGContent): Canonical link: https://commits.webkit.org/277325@main Canonical link: https://commits.webkit.org/274313.158@webkitglib/2.44 Commit: 13b88b35c299ee80058c524808d1c9bc07d29880 https://github.com/WebKit/WebKit/commit/13b88b35c299ee80058c524808d1c9bc07d29880 Author: Ahmad Saleem Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: A LayoutTests/editing/execCommand/canvas-counter-rooteditable-crash-expected.txt A LayoutTests/editing/execCommand/canvas-counter-rooteditable-crash.html A LayoutTests/editing/pasteboard/paste-text-009-expected.txt M LayoutTests/editing/pasteboard/paste-text-009.html R LayoutTests/platform/gtk/editing/pasteboard/paste-text-009-expected.png R LayoutTests/platform/gtk/editing/pasteboard/paste-text-009-expected.txt R LayoutTests/platform/ios-simulator/editing/pasteboard/paste-text-009-expected.png M LayoutTests/platform/ios-wk2/editing/pasteboard/paste-text-009-expected.txt R LayoutTests/platform/mac/editing/pasteboard/paste-text-009-expected.png R LayoutTests/platform/mac/editing/pasteboard/paste-text-009-expected.txt R LayoutTests/platform/wincairo/editing/pasteboard/paste-text-009-expected.txt M Source/WebCore/editing/ReplaceSelectionCommand.cpp Log Message: --- Cherry-pick 277291@main (cb8d258708a5). https://bugs.webkit.org/show_bug.cgi?id=127684 Convert an assertion to if-condition in `ReplaceSelectionCommand::doApply()` https://bugs.webkit.org/show_bug.cgi?id=127684 rdar://problem/27685262 Reviewed by Ryosuke Niwa. Merge: https://chromium.googlesource.com/chromium/src.git/+/8f313902e23e2589ddd9d3d2bfed8ee61e979f17 This patch changes following assertion: `ASSERT(insertionBlock != currentRoot)` to if-condition in `ReplaceSelectionCommand::doApply()`, since we found a pattern to hit this assertion in "paste-text-009.html". This test changes current test to use 'testharness' script but instead of full merge from Blink commit, this limits it to only test change (i.e., 009.html). Only change is 'root' editable: "past-text-009.html": (testharness) |currentRoot| is "one" | insertionBlock | is "one" "paste-text-009.html": |currentRoot| is BODY | insertionBlock | is "Omitted". * Source/WebCore/editing/ReplaceSelectionCommand.cpp: (ReplaceSelectionCommand::doApply): * LayoutTests/editing/pasteboard/paste-text-009.html: Rebaselined * LayoutTests/editing/pasteboard/paste-text-009-expected.txt: Add Test Expectation * LayoutTests/platform/gtk/editing/pasteboard/paste-text-009-expected.png: Removed * LayoutTests/platform/gtk/editing/pasteboard/paste-text-009-expected.txt: Ditto * LayoutTests/platform/ios/editing/pasteboard/paste-text-009-expected.png: Ditto * LayoutTests/platform/ios/editing/pasteboard/paste-text-009-expected.txt: Ditto * LayoutTests/platform/mac/editing/pasteboard/paste-text-009-expected.png: Ditto * LayoutTests/platform/mac/editing/pasteboard/paste-text-009-expected.txt: Ditto * LayoutTests/platform/wincairo/
[webkit-changes] [WebKit/WebKit] 0613dc: [SOUP] Add missing CheckedPtr macro to NetworkSess...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0613dc5b12781d2d63ea3fc4987c0b3ff3c44634 https://github.com/WebKit/WebKit/commit/0613dc5b12781d2d63ea3fc4987c0b3ff3c44634 Author: Claudio Saavedra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp M Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.h Log Message: --- [SOUP] Add missing CheckedPtr macro to NetworkSessionSoup https://bugs.webkit.org/show_bug.cgi?id=273134 Reviewed by Michael Catanzaro. Since 277590@main, all subclasses of classes using CheckedPtr should adopt this macro. Not having it can cause assertions during runtime in debug builds. Since NetworkSession uses CheckedPtr, NetworkSessionSoup was missing it. * Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp: (WebKit::NetworkSessionSoup::~NetworkSessionSoup): Deleted. * Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.h: Canonical link: https://commits.webkit.org/277919@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
