[webkit-changes] [181330] trunk/LayoutTests
Title: [181330] trunk/LayoutTests Revision 181330 Author rga...@webkit.org Date 2015-03-10 11:17:18 -0700 (Tue, 10 Mar 2015) Log Message Too large plugins are crashing. https://bugs.webkit.org/show_bug.cgi?id=139856 Reviewed by Darin Adler. Add layout test to cover this crash. * plugins/large-plugin-crash-expected.txt: Added. * plugins/large-plugin-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/plugins/large-plugin-crash-expected.txt trunk/LayoutTests/plugins/large-plugin-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (181329 => 181330) --- trunk/LayoutTests/ChangeLog 2015-03-10 18:00:59 UTC (rev 181329) +++ trunk/LayoutTests/ChangeLog 2015-03-10 18:17:18 UTC (rev 181330) @@ -1,3 +1,15 @@ +2015-03-10 Gabor Rapcsanyi rga...@webkit.org + +Too large plugins are crashing. +https://bugs.webkit.org/show_bug.cgi?id=139856 + +Reviewed by Darin Adler. + +Add layout test to cover this crash. + +* plugins/large-plugin-crash-expected.txt: Added. +* plugins/large-plugin-crash.html: Added. + 2015-03-09 Alexey Proskuryakov a...@apple.com Skip contentfiltering/block-after-add-data.html for now. Added: trunk/LayoutTests/plugins/large-plugin-crash-expected.txt (0 => 181330) --- trunk/LayoutTests/plugins/large-plugin-crash-expected.txt (rev 0) +++ trunk/LayoutTests/plugins/large-plugin-crash-expected.txt 2015-03-10 18:17:18 UTC (rev 181330) @@ -0,0 +1,5 @@ +Bug 139856: Large plugin crash. + +This test PASSES if it does not CRASH. + + Added: trunk/LayoutTests/plugins/large-plugin-crash.html (0 => 181330) --- trunk/LayoutTests/plugins/large-plugin-crash.html (rev 0) +++ trunk/LayoutTests/plugins/large-plugin-crash.html 2015-03-10 18:17:18 UTC (rev 181330) @@ -0,0 +1,15 @@ +html +body +pBug a href="" Large plugin crash./p +pThis test PASSES if it does not CRASH./p + +embed id=plugin width=9 type=application/x-webkit-test-netscape/embed + +script +if (window.testRunner) +testRunner.dumpAsText(); +document.getElementById('plugin').style.webkitTransform = 'scale(1)'; +/script + +/body +/html ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [177824] trunk
Title: [177824] trunk Revision 177824 Author rga...@webkit.org Date 2014-12-30 10:40:20 -0800 (Tue, 30 Dec 2014) Log Message Too large plugins are crashing. https://bugs.webkit.org/show_bug.cgi?id=139856 Reviewed by Darin Adler. Source/WebKit2: * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated. LayoutTests: Add layout test to cover this crash. * plugins/large-plugin-crash-expected.txt: Added. * plugins/large-plugin-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp Added Paths trunk/LayoutTests/plugins/large-plugin-crash-expected.txt trunk/LayoutTests/plugins/large-plugin-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (177823 => 177824) --- trunk/LayoutTests/ChangeLog 2014-12-30 17:41:13 UTC (rev 177823) +++ trunk/LayoutTests/ChangeLog 2014-12-30 18:40:20 UTC (rev 177824) @@ -1,3 +1,15 @@ +2014-12-30 Gabor Rapcsanyi rga...@webkit.org + +Too large plugins are crashing. +https://bugs.webkit.org/show_bug.cgi?id=139856 + +Reviewed by Darin Adler. + +Add layout test to cover this crash. + +* plugins/large-plugin-crash-expected.txt: Added. +* plugins/large-plugin-crash.html: Added. + 2014-12-29 Sebastian Dröge sebast...@centricular.com Enable MediaSource tests for the GTK port Added: trunk/LayoutTests/plugins/large-plugin-crash-expected.txt (0 => 177824) --- trunk/LayoutTests/plugins/large-plugin-crash-expected.txt (rev 0) +++ trunk/LayoutTests/plugins/large-plugin-crash-expected.txt 2014-12-30 18:40:20 UTC (rev 177824) @@ -0,0 +1,5 @@ +Bug 139856: Large plugin crash. + +This test PASSES if it does not CRASH. + + Added: trunk/LayoutTests/plugins/large-plugin-crash.html (0 => 177824) --- trunk/LayoutTests/plugins/large-plugin-crash.html (rev 0) +++ trunk/LayoutTests/plugins/large-plugin-crash.html 2014-12-30 18:40:20 UTC (rev 177824) @@ -0,0 +1,15 @@ +html +body +pBug a href="" Large plugin crash./p +pThis test PASSES if it does not CRASH./p + +embed id=plugin width=9 type=application/x-webkit-test-netscape/embed + +script +if (window.testRunner) +testRunner.dumpAsText(); +document.getElementById('plugin').style.webkitTransform = 'scale(1)'; +/script + +/body +/html Modified: trunk/Source/WebKit2/ChangeLog (177823 => 177824) --- trunk/Source/WebKit2/ChangeLog 2014-12-30 17:41:13 UTC (rev 177823) +++ trunk/Source/WebKit2/ChangeLog 2014-12-30 18:40:20 UTC (rev 177824) @@ -1,3 +1,13 @@ +2014-12-30 Gabor Rapcsanyi rga...@webkit.org + +Too large plugins are crashing. +https://bugs.webkit.org/show_bug.cgi?id=139856 + +Reviewed by Darin Adler. + +* WebProcess/Plugins/PluginProxy.cpp: +(WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated. + 2014-12-30 Anders Carlsson ander...@apple.com Transient local storage namespaces need to ref their storage areas Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (177823 => 177824) --- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2014-12-30 17:41:13 UTC (rev 177823) +++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2014-12-30 18:40:20 UTC (rev 177824) @@ -596,6 +596,8 @@ if (!m_backingStore) { m_backingStore = ShareableBitmap::create(backingStoreSize, ShareableBitmap::SupportsAlpha); +if (!m_backingStore) +return false; return true; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [177826] trunk
Title: [177826] trunk Revision 177826 Author rga...@webkit.org Date 2014-12-30 14:09:58 -0800 (Tue, 30 Dec 2014) Log Message Source/WebKit2: Too large plugins are crashing. https://bugs.webkit.org/show_bug.cgi?id=139868 Reviewed by Darin Adler. * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated. LayoutTests: Fix bug number typo in the previous commit. * plugins/large-plugin-crash-expected.txt: * plugins/large-plugin-crash.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/plugins/large-plugin-crash-expected.txt trunk/LayoutTests/plugins/large-plugin-crash.html trunk/Source/WebKit2/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (177825 => 177826) --- trunk/LayoutTests/ChangeLog 2014-12-30 20:43:00 UTC (rev 177825) +++ trunk/LayoutTests/ChangeLog 2014-12-30 22:09:58 UTC (rev 177826) @@ -1,7 +1,14 @@ 2014-12-30 Gabor Rapcsanyi rga...@webkit.org +Fix bug number typo in the previous commit. + +* plugins/large-plugin-crash-expected.txt: +* plugins/large-plugin-crash.html: + +2014-12-30 Gabor Rapcsanyi rga...@webkit.org + Too large plugins are crashing. -https://bugs.webkit.org/show_bug.cgi?id=139856 +https://bugs.webkit.org/show_bug.cgi?id=139868 Reviewed by Darin Adler. Modified: trunk/LayoutTests/plugins/large-plugin-crash-expected.txt (177825 => 177826) --- trunk/LayoutTests/plugins/large-plugin-crash-expected.txt 2014-12-30 20:43:00 UTC (rev 177825) +++ trunk/LayoutTests/plugins/large-plugin-crash-expected.txt 2014-12-30 22:09:58 UTC (rev 177826) @@ -1,4 +1,4 @@ -Bug 139856: Large plugin crash. +Bug 139868: Large plugin crash. This test PASSES if it does not CRASH. Modified: trunk/LayoutTests/plugins/large-plugin-crash.html (177825 => 177826) --- trunk/LayoutTests/plugins/large-plugin-crash.html 2014-12-30 20:43:00 UTC (rev 177825) +++ trunk/LayoutTests/plugins/large-plugin-crash.html 2014-12-30 22:09:58 UTC (rev 177826) @@ -1,6 +1,6 @@ html body -pBug a href="" Large plugin crash./p +pBug a href="" Large plugin crash./p pThis test PASSES if it does not CRASH./p embed id=plugin width=9 type=application/x-webkit-test-netscape/embed Modified: trunk/Source/WebKit2/ChangeLog (177825 => 177826) --- trunk/Source/WebKit2/ChangeLog 2014-12-30 20:43:00 UTC (rev 177825) +++ trunk/Source/WebKit2/ChangeLog 2014-12-30 22:09:58 UTC (rev 177826) @@ -1,7 +1,7 @@ 2014-12-30 Gabor Rapcsanyi rga...@webkit.org Too large plugins are crashing. -https://bugs.webkit.org/show_bug.cgi?id=139856 +https://bugs.webkit.org/show_bug.cgi?id=139868 Reviewed by Darin Adler. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [177627] trunk
Title: [177627] trunk Revision 177627 Author rga...@webkit.org Date 2014-12-21 15:56:55 -0800 (Sun, 21 Dec 2014) Log Message AX: Hidden aria table crash https://bugs.webkit.org/show_bug.cgi?id=139856 Reviewed by Chris Fleizach. Source/WebCore: Change axCaption to pointer and check it's value because AXObjectCache::getOrCreate() can return with nullptr. Test: accessibility/aria-hidden-crash.html * accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::addChildren): LayoutTests: Add layout test to cover this crash. * accessibility/aria-hidden-crash-expected.txt: Added. * accessibility/aria-hidden-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityTable.cpp Added Paths trunk/LayoutTests/accessibility/aria-hidden-crash-expected.txt trunk/LayoutTests/accessibility/aria-hidden-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (177626 => 177627) --- trunk/LayoutTests/ChangeLog 2014-12-21 22:11:53 UTC (rev 177626) +++ trunk/LayoutTests/ChangeLog 2014-12-21 23:56:55 UTC (rev 177627) @@ -1,3 +1,15 @@ +2014-12-21 Gabor Rapcsanyi rga...@webkit.org + +AX: Hidden aria table crash +https://bugs.webkit.org/show_bug.cgi?id=139856 + +Reviewed by Chris Fleizach. + +Add layout test to cover this crash. + +* accessibility/aria-hidden-crash-expected.txt: Added. +* accessibility/aria-hidden-crash.html: Added. + 2014-12-21 Alexey Proskuryakov a...@apple.com Update expectations for two WebGL tests to match what bots see. Added: trunk/LayoutTests/accessibility/aria-hidden-crash-expected.txt (0 => 177627) --- trunk/LayoutTests/accessibility/aria-hidden-crash-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/aria-hidden-crash-expected.txt 2014-12-21 23:56:55 UTC (rev 177627) @@ -0,0 +1,5 @@ +Bug 139856: Hidden aria table crash. + +This test PASSES if it does not CRASH. + + Added: trunk/LayoutTests/accessibility/aria-hidden-crash.html (0 => 177627) --- trunk/LayoutTests/accessibility/aria-hidden-crash.html (rev 0) +++ trunk/LayoutTests/accessibility/aria-hidden-crash.html 2014-12-21 23:56:55 UTC (rev 177627) @@ -0,0 +1,27 @@ +html +head +script +function test() +{ +if (window.testRunner) +testRunner.dumpAsText(); +} +/script +/head +body _onload_=test() +pBug a href="" Hidden aria table crash./p +pThis test PASSES if it does not CRASH./p + +ul aria-hidden=true +table +theader +td +span aria-live=assertive/span +/td +/theader +caption/caption +/table +/ul +svg _onerror_=logPass()/svg +/body +/html Modified: trunk/Source/WebCore/ChangeLog (177626 => 177627) --- trunk/Source/WebCore/ChangeLog 2014-12-21 22:11:53 UTC (rev 177626) +++ trunk/Source/WebCore/ChangeLog 2014-12-21 23:56:55 UTC (rev 177627) @@ -1,3 +1,18 @@ +2014-12-21 Gabor Rapcsanyi rga...@webkit.org + +AX: Hidden aria table crash +https://bugs.webkit.org/show_bug.cgi?id=139856 + +Reviewed by Chris Fleizach. + +Change axCaption to pointer and check it's value because +AXObjectCache::getOrCreate() can return with nullptr. + +Test: accessibility/aria-hidden-crash.html + +* accessibility/AccessibilityTable.cpp: +(WebCore::AccessibilityTable::addChildren): + 2014-12-20 Chris Dumez cdu...@apple.com Get rid of error-prone ReleaseParsedCalcValueCondition argument in CSSParser Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (177626 => 177627) --- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2014-12-21 22:11:53 UTC (rev 177626) +++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2014-12-21 23:56:55 UTC (rev 177627) @@ -364,9 +364,9 @@ if (HTMLTableElement* tableElement = this-tableElement()) { if (HTMLTableCaptionElement* caption = tableElement-caption()) { -AccessibilityObject axCaption = *axObjectCache()-getOrCreate(caption); -if (!axCaption.accessibilityIsIgnored()) -m_children.append(axCaption); +AccessibilityObject* axCaption = axObjectCache()-getOrCreate(caption); +if (axCaption !axCaption-accessibilityIsIgnored()) +m_children.append(axCaption); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167490] trunk/Source/WebCore
Title: [167490] trunk/Source/WebCore Revision 167490 Author rga...@webkit.org Date 2014-04-18 06:48:16 -0700 (Fri, 18 Apr 2014) Log Message Unreviewed. ARM64 buildfix after r167473. * platform/audio/DenormalDisabler.h: Put back the MathExtras.h include. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/audio/DenormalDisabler.h Diff Modified: trunk/Source/WebCore/ChangeLog (167489 => 167490) --- trunk/Source/WebCore/ChangeLog 2014-04-18 13:07:48 UTC (rev 167489) +++ trunk/Source/WebCore/ChangeLog 2014-04-18 13:48:16 UTC (rev 167490) @@ -1,3 +1,9 @@ +2014-04-18 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed. ARM64 buildfix after r167473. + +* platform/audio/DenormalDisabler.h: Put back the MathExtras.h include. + 2014-04-18 Radu Stavila stav...@adobe.com [CSSRegions] Incorrect background paint on positioned element hover Modified: trunk/Source/WebCore/platform/audio/DenormalDisabler.h (167489 => 167490) --- trunk/Source/WebCore/platform/audio/DenormalDisabler.h 2014-04-18 13:07:48 UTC (rev 167489) +++ trunk/Source/WebCore/platform/audio/DenormalDisabler.h 2014-04-18 13:48:16 UTC (rev 167490) @@ -25,6 +25,8 @@ #ifndef DenormalDisabler_h #define DenormalDisabler_h +#include wtf/MathExtras.h + namespace WebCore { // Deal with denormals. They can very seriously impact performance on x86. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167347] trunk/Source/JavaScriptCore
Title: [167347] trunk/Source/_javascript_Core Revision 167347 Author rga...@webkit.org Date 2014-04-16 07:24:51 -0700 (Wed, 16 Apr 2014) Log Message Unreviewed, ARM64 buildfix after r167336. * assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::branchAdd32): Add missing function. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (167346 => 167347) --- trunk/Source/_javascript_Core/ChangeLog 2014-04-16 12:25:39 UTC (rev 167346) +++ trunk/Source/_javascript_Core/ChangeLog 2014-04-16 14:24:51 UTC (rev 167347) @@ -1,3 +1,10 @@ +2014-04-16 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed, ARM64 buildfix after r167336. + +* assembler/MacroAssemblerARM64.h: +(JSC::MacroAssemblerARM64::branchAdd32): Add missing function. + 2014-04-15 Filip Pizlo fpi...@apple.com Unreviewed, add the obvious thing that marks MakeRope as exiting since it can exit. Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h (167346 => 167347) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h 2014-04-16 12:25:39 UTC (rev 167346) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h 2014-04-16 14:24:51 UTC (rev 167347) @@ -1830,6 +1830,12 @@ return branchAdd32(cond, op1, dataTempRegister, dest); } +Jump branchAdd32(ResultCondition cond, Address src, RegisterID dest) +{ +load32(src, getCachedDataTempRegisterIDAndInvalidate()); +return branchAdd32(cond, dest, dataTempRegister, dest); +} + Jump branchAdd32(ResultCondition cond, RegisterID src, RegisterID dest) { return branchAdd32(cond, dest, src, dest); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166232] trunk
Title: [166232] trunk Revision 166232 Author rga...@webkit.org Date 2014-03-25 06:08:29 -0700 (Tue, 25 Mar 2014) Log Message [EFL] Add ARM64 build support https://bugs.webkit.org/show_bug.cgi?id=130506 Rubber stamped by Gyuyoung Kim. .: * CMakeLists.txt: Set WTF_CPU_ARM64 when aarch64 is defined. Source/ThirdParty: * leveldb/port/atomic_pointer.h: Set ARCH_CPU_ARM_FAMILY when __aarch64__ is defined. Source/WTF: * wtf/Platform.h: Set WTF_CPU_ARM64 when __aarch64__ is defined. Tools: * Scripts/webkitdirs.pm: (isARM): Detect aarch64 as ARM. Modified Paths trunk/CMakeLists.txt trunk/ChangeLog trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/leveldb/port/atomic_pointer.h trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitdirs.pm Diff Modified: trunk/CMakeLists.txt (166231 => 166232) --- trunk/CMakeLists.txt 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/CMakeLists.txt 2014-03-25 13:08:29 UTC (rev 166232) @@ -77,6 +77,8 @@ endif () if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES ^arm) set(WTF_CPU_ARM 1) +elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES ^aarch64) +set(WTF_CPU_ARM64 1) elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES ^mips) set(WTF_CPU_MIPS 1) elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES sh4) Modified: trunk/ChangeLog (166231 => 166232) --- trunk/ChangeLog 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) @@ -1,3 +1,12 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[EFL] Add ARM64 build support +https://bugs.webkit.org/show_bug.cgi?id=130506 + +Rubber stamped by Gyuyoung Kim. + +* CMakeLists.txt: Set WTF_CPU_ARM64 when aarch64 is defined. + 2014-03-25 Michał Pakuła vel Rutka m.pak...@samsung.com [EFL][WK2] Add NETWORK_PROCESS build option Modified: trunk/Source/ThirdParty/ChangeLog (166231 => 166232) --- trunk/Source/ThirdParty/ChangeLog 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Source/ThirdParty/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) @@ -1,3 +1,12 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[EFL] Add ARM64 build support +https://bugs.webkit.org/show_bug.cgi?id=130506 + +Rubber stamped by Gyuyoung Kim. + +* leveldb/port/atomic_pointer.h: Set ARCH_CPU_ARM_FAMILY when __aarch64__ is defined. + 2014-03-14 Landry Breuil lan...@openbsd.org Fix leveldb build on OpenBSD/NetBSD by using the FreeBSD codepaths. Modified: trunk/Source/ThirdParty/leveldb/port/atomic_pointer.h (166231 => 166232) --- trunk/Source/ThirdParty/leveldb/port/atomic_pointer.h 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Source/ThirdParty/leveldb/port/atomic_pointer.h 2014-03-25 13:08:29 UTC (rev 166232) @@ -34,7 +34,7 @@ #define ARCH_CPU_X86_FAMILY 1 #elif defined(_M_IX86) || defined(__i386__) || defined(__i386) #define ARCH_CPU_X86_FAMILY 1 -#elif defined(__ARMEL__) +#elif defined(__ARMEL__) || defined(__aarch64__) #define ARCH_CPU_ARM_FAMILY 1 #elif defined(__ppc__) || defined(__powerpc__) || defined(__powerpc64__) #define ARCH_CPU_PPC_FAMILY 1 Modified: trunk/Source/WTF/ChangeLog (166231 => 166232) --- trunk/Source/WTF/ChangeLog 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Source/WTF/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) @@ -1,3 +1,12 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[EFL] Add ARM64 build support +https://bugs.webkit.org/show_bug.cgi?id=130506 + +Rubber stamped by Gyuyoung Kim. + +* wtf/Platform.h: Set WTF_CPU_ARM64 when __aarch64__ is defined. + 2014-03-24 Andy Estes aes...@apple.com Fix the iOS build. Modified: trunk/Source/WTF/wtf/Platform.h (166231 => 166232) --- trunk/Source/WTF/wtf/Platform.h 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Source/WTF/wtf/Platform.h 2014-03-25 13:08:29 UTC (rev 166232) @@ -152,7 +152,7 @@ #endif /* CPU(ARM64) - Apple */ -#if defined(__arm64__) defined(__APPLE__) +#if (defined(__arm64__) defined(__APPLE__)) || defined(__aarch64__) #define WTF_CPU_ARM64 1 #endif Modified: trunk/Tools/ChangeLog (166231 => 166232) --- trunk/Tools/ChangeLog 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Tools/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) @@ -1,3 +1,13 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[EFL] Add ARM64 build support +https://bugs.webkit.org/show_bug.cgi?id=130506 + +Rubber stamped by Gyuyoung Kim. + +* Scripts/webkitdirs.pm: +(isARM): Detect aarch64 as ARM. + 2014-03-25 Eva Balazsfalvi evab.u-sze...@partner.samsung.com [webkitpy] Improve _parse_bug_description to recognize more descriptions Modified: trunk/Tools/Scripts/webkitdirs.pm (166231 => 166232) --- trunk/Tools/Scripts/webkitdirs.pm 2014-03-25 12:43:47 UTC (rev 166231) +++ trunk/Tools/Scripts/webkitdirs.pm 2014-03-25 13:08:29 UTC (rev 166232) @@ -1107,7 +1107,7 @@ sub isARM()
[webkit-changes] [166233] trunk/Source/WebCore
Title: [166233] trunk/Source/WebCore Revision 166233 Author rga...@webkit.org Date 2014-03-25 06:14:42 -0700 (Tue, 25 Mar 2014) Log Message [ARM64] GNU assembler fails in TransformationMatrix::multiply https://bugs.webkit.org/show_bug.cgi?id=130454 Reviewed by Zoltan Herczeg. Change the NEON intstructions to the proper style. * platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::multiply): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (166232 => 166233) --- trunk/Source/WebCore/ChangeLog 2014-03-25 13:08:29 UTC (rev 166232) +++ trunk/Source/WebCore/ChangeLog 2014-03-25 13:14:42 UTC (rev 166233) @@ -1,3 +1,15 @@ +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + +[ARM64] GNU assembler fails in TransformationMatrix::multiply +https://bugs.webkit.org/show_bug.cgi?id=130454 + +Reviewed by Zoltan Herczeg. + +Change the NEON intstructions to the proper style. + +* platform/graphics/transforms/TransformationMatrix.cpp: +(WebCore::TransformationMatrix::multiply): + 2014-03-20 Sergio Villar Senin svil...@igalia.com [CSS Grid Layout] Vertical rectangles not considered as valid grid areas Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp (166232 => 166233) --- trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp 2014-03-25 13:08:29 UTC (rev 166232) +++ trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp 2014-03-25 13:14:42 UTC (rev 166233) @@ -1040,61 +1040,61 @@ const double* rightMatrix = (mat.m_matrix[0][0]); asm volatile ( // First, load the leftMatrix completely in memory. The leftMatrix is in v16-v23. -mov x4, %[leftMatrix]\n\t -ld1.2d {v16, v17, v18, v19}, [%[leftMatrix]], #64\n\t -ld1.2d {v20, v21, v22, v23}, [%[leftMatrix]]\n\t +mov x4, %[leftMatrix]\n\t +ld1 {v16.2d, v17.2d, v18.2d, v19.2d}, [%[leftMatrix]], #64\n\t +ld1 {v20.2d, v21.2d, v22.2d, v23.2d}, [%[leftMatrix]]\n\t // First row. -ld4r.2d {v24, v25, v26, v27}, [%[rightMatrix]], #32\n\t -fmul.2d v28, v24, v16\n\t -fmul.2d v29, v24, v17\n\t -fmla.2d v28, v25, v18\n\t -fmla.2d v29, v25, v19\n\t -fmla.2d v28, v26, v20\n\t -fmla.2d v29, v26, v21\n\t -fmla.2d v28, v27, v22\n\t -fmla.2d v29, v27, v23\n\t +ld4r {v24.2d, v25.2d, v26.2d, v27.2d}, [%[rightMatrix]], #32\n\t +fmul v28.2d, v24.2d, v16.2d\n\t +fmul v29.2d, v24.2d, v17.2d\n\t +fmla v28.2d, v25.2d, v18.2d\n\t +fmla v29.2d, v25.2d, v19.2d\n\t +fmla v28.2d, v26.2d, v20.2d\n\t +fmla v29.2d, v26.2d, v21.2d\n\t +fmla v28.2d, v27.2d, v22.2d\n\t +fmla v29.2d, v27.2d, v23.2d\n\t -ld4r.2d {v0, v1, v2, v3}, [%[rightMatrix]], #32\n\t -st1.2d {v28, v29}, [x4], #32\n\t +ld4r {v0.2d, v1.2d, v2.2d, v3.2d}, [%[rightMatrix]], #32\n\t +st1 {v28.2d, v29.2d}, [x4], #32\n\t // Second row. -fmul.2d v30, v0, v16\n\t -fmul.2d v31, v0, v17\n\t -fmla.2d v30, v1, v18\n\t -fmla.2d v31, v1, v19\n\t -fmla.2d v30, v2, v20\n\t -fmla.2d v31, v2, v21\n\t -fmla.2d v30, v3, v22\n\t -fmla.2d v31, v3, v23\n\t +fmul v30.2d, v0.2d, v16.2d\n\t +fmul v31.2d, v0.2d, v17.2d\n\t +fmla v30.2d, v1.2d, v18.2d\n\t +fmla v31.2d, v1.2d, v19.2d\n\t +fmla v30.2d, v2.2d, v20.2d\n\t +fmla v31.2d, v2.2d, v21.2d\n\t +fmla v30.2d, v3.2d, v22.2d\n\t +fmla v31.2d, v3.2d, v23.2d\n\t -ld4r.2d {v24, v25, v26, v27}, [%[rightMatrix]], #32\n\t -st1.2d {v30, v31}, [x4], #32\n\t +ld4r {v24.2d, v25.2d, v26.2d, v27.2d}, [%[rightMatrix]], #32\n\t +st1 {v30.2d, v31.2d}, [x4], #32\n\t // Third row. -fmul.2d v28, v24, v16\n\t -fmul.2d v29, v24, v17\n\t -fmla.2d v28, v25, v18\n\t -fmla.2d v29, v25, v19\n\t -fmla.2d v28, v26, v20\n\t -fmla.2d v29, v26, v21\n\t -fmla.2d v28, v27, v22\n\t -fmla.2d v29, v27, v23\n\t +fmul v28.2d, v24.2d, v16.2d\n\t +fmul v29.2d, v24.2d, v17.2d\n\t +fmla v28.2d, v25.2d, v18.2d\n\t +fmla v29.2d, v25.2d, v19.2d\n\t +fmla v28.2d, v26.2d, v20.2d\n\t +fmla v29.2d, v26.2d, v21.2d\n\t +fmla v28.2d, v27.2d, v22.2d\n\t +fmla v29.2d, v27.2d, v23.2d\n\t -ld4r.2d {v0, v1, v2, v3}, [%[rightMatrix]], #32\n\t -st1.2d {v28, v29}, [x4], #32\n\t +ld4r {v0.2d, v1.2d, v2.2d, v3.2d}, [%[rightMatrix]], #32\n\t +st1 {v28.2d, v29.2d}, [x4], #32\n\t // Fourth row. -
[webkit-changes] [166234] trunk/Source/WTF
Title: [166234] trunk/Source/WTF Revision 166234 Author rga...@webkit.org Date 2014-03-25 07:13:07 -0700 (Tue, 25 Mar 2014) Log Message [ARM64] GCC generates wrong code with -O2 flag in WTF::weakCompareAndSwap https://bugs.webkit.org/show_bug.cgi?id=130500 Reviewed by Filip Pizlo. Set the first operand to the exact register in the inline assembly with GCC. * wtf/Atomics.h: (WTF::weakCompareAndSwap): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Atomics.h Diff Modified: trunk/Source/WTF/ChangeLog (166233 => 166234) --- trunk/Source/WTF/ChangeLog 2014-03-25 13:14:42 UTC (rev 166233) +++ trunk/Source/WTF/ChangeLog 2014-03-25 14:13:07 UTC (rev 166234) @@ -1,5 +1,17 @@ 2014-03-25 Gabor Rapcsanyi rga...@webkit.org +[ARM64] GCC generates wrong code with -O2 flag in WTF::weakCompareAndSwap +https://bugs.webkit.org/show_bug.cgi?id=130500 + +Reviewed by Filip Pizlo. + +Set the first operand to the exact register in the inline assembly with GCC. + +* wtf/Atomics.h: +(WTF::weakCompareAndSwap): + +2014-03-25 Gabor Rapcsanyi rga...@webkit.org + [EFL] Add ARM64 build support https://bugs.webkit.org/show_bug.cgi?id=130506 Modified: trunk/Source/WTF/wtf/Atomics.h (166233 => 166234) --- trunk/Source/WTF/wtf/Atomics.h 2014-03-25 13:14:42 UTC (rev 166233) +++ trunk/Source/WTF/wtf/Atomics.h 2014-03-25 14:13:07 UTC (rev 166234) @@ -112,6 +112,20 @@ : r(expected), r(newValue) : memory); result = !result; +#elif CPU(ARM64) COMPILER(GCC) +unsigned tmp; +unsigned result; +asm volatile( +mov %w1, #1\n\t +ldxr %w2, [%0]\n\t +cmp %w3, %w2\n\t +b.ne 0f\n\t +stxr %w1, %w4, [%0]\n\t +0: +: +r(location), =r(result), =r(tmp) +: r(expected), r(newValue) +: memory); +result = !result; #elif CPU(ARM64) unsigned tmp; unsigned result; @@ -152,6 +166,20 @@ : memory ); return result; +#elif CPU(ARM64) COMPILER(GCC) +bool result; +void* tmp; +asm volatile( +mov %w1, #1\n\t +ldxr %x2, [%0]\n\t +cmp %x3, %x2\n\t +b.ne 0f\n\t +stxr %w1, %x4, [%0]\n\t +0: +: +r(location), =r(result), =r(tmp) +: r(expected), r(newValue) +: memory); +return !result; #elif CPU(ARM64) bool result; void* tmp; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166166] trunk/Source/JavaScriptCore
Title: [166166] trunk/Source/_javascript_Core Revision 166166 Author rga...@webkit.org Date 2014-03-24 08:24:02 -0700 (Mon, 24 Mar 2014) Log Message [ARM64] GNU assembler doesn't work with LLInt arm64 backend. https://bugs.webkit.org/show_bug.cgi?id=130453 Reviewed by Filip Pizlo. Change fp and lr to x29 and x30. Add both operand kinds to emitARM64() at sxtw and uxtw instructions. * offlineasm/arm64.rb: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/offlineasm/arm64.rb Diff Modified: trunk/Source/_javascript_Core/ChangeLog (166165 => 166166) --- trunk/Source/_javascript_Core/ChangeLog 2014-03-24 13:46:39 UTC (rev 166165) +++ trunk/Source/_javascript_Core/ChangeLog 2014-03-24 15:24:02 UTC (rev 166166) @@ -1,3 +1,15 @@ +2014-03-24 Gabor Rapcsanyi rga...@webkit.org + +[ARM64] GNU assembler doesn't work with LLInt arm64 backend. +https://bugs.webkit.org/show_bug.cgi?id=130453 + +Reviewed by Filip Pizlo. + +Change fp and lr to x29 and x30. Add both operand kinds to emitARM64() +at sxtw and uxtw instructions. + +* offlineasm/arm64.rb: + 2014-03-23 Hyowon Kim hw1008@samsung.com Move all EFL typedefs into EflTypedefs.h. Modified: trunk/Source/_javascript_Core/offlineasm/arm64.rb (166165 => 166166) --- trunk/Source/_javascript_Core/offlineasm/arm64.rb 2014-03-24 13:46:39 UTC (rev 166165) +++ trunk/Source/_javascript_Core/offlineasm/arm64.rb 2014-03-24 15:24:02 UTC (rev 166166) @@ -129,7 +129,7 @@ when 'sp' 'sp' when 'lr' -'lr' +'x30' else raise Bad register name #{@name} at #{codeOriginString} end @@ -587,9 +587,9 @@ $asm.puts stp #{ops[0].arm64Operand(:ptr)}, #{ops[1].arm64Operand(:ptr)}, [sp, #-16]! } when popLRAndFP -$asm.puts ldp fp, lr, [sp], #16 +$asm.puts ldp x29, x30, [sp], #16 when pushLRAndFP -$asm.puts stp fp, lr, [sp, #-16]! +$asm.puts stp x29, x30, [sp, #-16]! when popCalleeSaves $asm.puts ldp x28, x27, [sp], #16 $asm.puts ldp x26, x25, [sp], #16 @@ -609,13 +609,13 @@ emitARM64(mov, operands, :ptr) end when sxi2p -emitARM64(sxtw, operands, :ptr) +emitARM64(sxtw, operands, [:int, :ptr]) when sxi2q -emitARM64(sxtw, operands, :ptr) +emitARM64(sxtw, operands, [:int, :ptr]) when zxi2p -emitARM64(uxtw, operands, :ptr) +emitARM64(uxtw, operands, [:int, :ptr]) when zxi2q -emitARM64(uxtw, operands, :ptr) +emitARM64(uxtw, operands, [:int, :ptr]) when nop $asm.puts nop when bieq, bbeq ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [165961] trunk/Source/JavaScriptCore
Title: [165961] trunk/Source/_javascript_Core Revision 165961 Author rga...@webkit.org Date 2014-03-20 07:03:43 -0700 (Thu, 20 Mar 2014) Log Message [ARM64] Fix assembler build issues and add cacheFlush support for Linux https://bugs.webkit.org/show_bug.cgi?id=130502 Reviewed by Michael Saboff. Add limits.h for INT_MIN in ARM64Assembler(). Delete shouldBlindForSpecificArch(uintptr_t) because on ARM64 uint64_t and uintptr_t is the same with GCC and Clang as well. Add cacheFlush support for Linux. * assembler/ARM64Assembler.h: (JSC::ARM64Assembler::linuxPageFlush): (JSC::ARM64Assembler::cacheFlush): * assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::shouldBlindForSpecificArch): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/ARM64Assembler.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (165960 => 165961) --- trunk/Source/_javascript_Core/ChangeLog 2014-03-20 12:24:31 UTC (rev 165960) +++ trunk/Source/_javascript_Core/ChangeLog 2014-03-20 14:03:43 UTC (rev 165961) @@ -1,3 +1,20 @@ +2014-03-20 Gabor Rapcsanyi rga...@webkit.org + +[ARM64] Fix assembler build issues and add cacheFlush support for Linux +https://bugs.webkit.org/show_bug.cgi?id=130502 + +Reviewed by Michael Saboff. + +Add limits.h for INT_MIN in ARM64Assembler(). Delete shouldBlindForSpecificArch(uintptr_t) +because on ARM64 uint64_t and uintptr_t is the same with GCC and Clang as well. +Add cacheFlush support for Linux. + +* assembler/ARM64Assembler.h: +(JSC::ARM64Assembler::linuxPageFlush): +(JSC::ARM64Assembler::cacheFlush): +* assembler/MacroAssemblerARM64.h: +(JSC::MacroAssemblerARM64::shouldBlindForSpecificArch): + 2014-03-19 Gavin Barraclough barraclo...@apple.com https://bugs.webkit.org/show_bug.cgi?id=130494 Modified: trunk/Source/_javascript_Core/assembler/ARM64Assembler.h (165960 => 165961) --- trunk/Source/_javascript_Core/assembler/ARM64Assembler.h 2014-03-20 12:24:31 UTC (rev 165960) +++ trunk/Source/_javascript_Core/assembler/ARM64Assembler.h 2014-03-20 14:03:43 UTC (rev 165961) @@ -29,6 +29,7 @@ #if ENABLE(ASSEMBLER) CPU(ARM64) #include AssemblerBuffer.h +#include limits.h #include wtf/Assertions.h #include wtf/Vector.h #include stdint.h @@ -2841,10 +2842,34 @@ unsigned debugOffset() { return m_buffer.debugOffset(); } +#if OS(LINUX) COMPILER(GCC) +static inline void linuxPageFlush(uintptr_t begin, uintptr_t end) +{ +__builtin___clear_cache(reinterpret_castvoid*(begin), reinterpret_castvoid*(end)); +} +#endif + static void cacheFlush(void* code, size_t size) { #if OS(IOS) sys_cache_control(kCacheFunctionPrepareForExecution, code, size); +#elif OS(LINUX) +size_t page = pageSize(); +uintptr_t current = reinterpret_castuintptr_t(code); +uintptr_t end = current + size; +uintptr_t firstPageEnd = (current ~(page - 1)) + page; + +if (end = firstPageEnd) { +linuxPageFlush(current, end); +return; +} + +linuxPageFlush(current, firstPageEnd); + +for (current = firstPageEnd; current + page end; current += page) +linuxPageFlush(current, current + page); + +linuxPageFlush(current, end); #else #error The cacheFlush support is missing on this platform. #endif Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h (165960 => 165961) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h 2014-03-20 12:24:31 UTC (rev 165960) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h 2014-03-20 14:03:43 UTC (rev 165961) @@ -129,7 +129,6 @@ // FIXME: Get reasonable implementations for these static bool shouldBlindForSpecificArch(uint32_t value) { return value = 0x00ff; } static bool shouldBlindForSpecificArch(uint64_t value) { return value = 0x00ff; } -static bool shouldBlindForSpecificArch(uintptr_t value) { return value = 0x00ff; } // Integer operations: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [164799] trunk/Source/JavaScriptCore
Title: [164799] trunk/Source/_javascript_Core Revision 164799 Author rga...@webkit.org Date 2014-02-27 06:01:45 -0800 (Thu, 27 Feb 2014) Log Message r164764 broke the ARM build https://bugs.webkit.org/show_bug.cgi?id=129415 Reviewed by Zoltan Herczeg. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::moveWithPatch): Change reinterpret_cast to static_cast. (JSC::MacroAssemblerARM::canJumpReplacePatchableBranch32WithPatch): Add missing function. (JSC::MacroAssemblerARM::startOfPatchableBranch32WithPatchOnAddress): Add missing function. (JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranch32WithPatch): Add missing function. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (164798 => 164799) --- trunk/Source/_javascript_Core/ChangeLog 2014-02-27 14:01:37 UTC (rev 164798) +++ trunk/Source/_javascript_Core/ChangeLog 2014-02-27 14:01:45 UTC (rev 164799) @@ -1,3 +1,16 @@ +2014-02-27 Gabor Rapcsanyi rga...@webkit.org + +r164764 broke the ARM build +https://bugs.webkit.org/show_bug.cgi?id=129415 + +Reviewed by Zoltan Herczeg. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::moveWithPatch): Change reinterpret_cast to static_cast. +(JSC::MacroAssemblerARM::canJumpReplacePatchableBranch32WithPatch): Add missing function. +(JSC::MacroAssemblerARM::startOfPatchableBranch32WithPatchOnAddress): Add missing function. +(JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranch32WithPatch): Add missing function. + 2014-02-27 Mark Hahnenberg mhahnenb...@apple.com r164764 broke the ARM build Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (164798 => 164799) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2014-02-27 14:01:37 UTC (rev 164798) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2014-02-27 14:01:45 UTC (rev 164799) @@ -1031,7 +1031,7 @@ DataLabel32 moveWithPatch(TrustedImm32 initialValue, RegisterID dest) { DataLabel32 dataLabel(this); -m_assembler.ldrUniqueImmediate(dest, reinterpret_castARMWord(initialValue.m_value)); +m_assembler.ldrUniqueImmediate(dest, static_castARMWord(initialValue.m_value)); return dataLabel; } @@ -1370,7 +1370,14 @@ } static bool canJumpReplacePatchableBranchPtrWithPatch() { return false; } +static bool canJumpReplacePatchableBranch32WithPatch() { return false; } +static CodeLocationLabel startOfPatchableBranch32WithPatchOnAddress(CodeLocationDataLabel32) +{ +UNREACHABLE_FOR_PLATFORM(); +return CodeLocationLabel(); +} + static CodeLocationLabel startOfPatchableBranchPtrWithPatchOnAddress(CodeLocationDataLabelPtr) { UNREACHABLE_FOR_PLATFORM(); @@ -1387,6 +1394,11 @@ ARMAssembler::revertBranchPtrWithPatch(instructionStart.dataLocation(), reg, reinterpret_castuintptr_t(initialValue) 0x); } +static void revertJumpReplacementToPatchableBranch32WithPatch(CodeLocationLabel, Address, int32_t) +{ +UNREACHABLE_FOR_PLATFORM(); +} + static void revertJumpReplacementToPatchableBranchPtrWithPatch(CodeLocationLabel, Address, void*) { UNREACHABLE_FOR_PLATFORM(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [164433] trunk/Source/JavaScriptCore
Title: [164433] trunk/Source/_javascript_Core Revision 164433 Author rga...@webkit.org Date 2014-02-20 09:38:15 -0800 (Thu, 20 Feb 2014) Log Message ASSERTION FAILED: isUInt16() on ARMv7 after r113253. https://bugs.webkit.org/show_bug.cgi?id=129101 Reviewed by Michael Saboff. If the immediate value type is encoded then we shouldn't reach this assert. Check the immediate type to avoid assertion in alignemnt check. * assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::add): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (164432 => 164433) --- trunk/Source/_javascript_Core/ChangeLog 2014-02-20 17:27:16 UTC (rev 164432) +++ trunk/Source/_javascript_Core/ChangeLog 2014-02-20 17:38:15 UTC (rev 164433) @@ -1,3 +1,16 @@ +2014-02-20 Gabor Rapcsanyi rga...@webkit.org + +ASSERTION FAILED: isUInt16() on ARMv7 after r113253. +https://bugs.webkit.org/show_bug.cgi?id=129101 + +Reviewed by Michael Saboff. + +If the immediate value type is encoded then we shouldn't reach this assert. +Check the immediate type to avoid assertion in alignemnt check. + +* assembler/ARMv7Assembler.h: +(JSC::ARMv7Assembler::add): + 2014-02-20 Csaba Osztrogonác o...@webkit.org Get rid of redundant Platform.h includes Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (164432 => 164433) --- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2014-02-20 17:27:16 UTC (rev 164432) +++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2014-02-20 17:38:15 UTC (rev 164433) @@ -857,7 +857,7 @@ ASSERT(rn != ARMRegisters::pc); ASSERT(imm.isValid()); -if (rn == ARMRegisters::sp) { +if (rn == ARMRegisters::sp imm.isUInt16()) { ASSERT(!(imm.getUInt16() 3)); if (!(rd 8) imm.isUInt10()) { m_formatter.oneWordOp5Reg3Imm8(OP_ADD_SP_imm_T1, rd, static_castuint8_t(imm.getUInt10() 2)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163881] trunk/Source/JavaScriptCore
Title: [163881] trunk/Source/_javascript_Core Revision 163881 Author rga...@webkit.org Date 2014-02-11 09:34:39 -0800 (Tue, 11 Feb 2014) Log Message LLInt typo error after r139004. https://bugs.webkit.org/show_bug.cgi?id=128592 Reviewed by Michael Saboff. * offlineasm/arm.rb: change immediate to register in the condition Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/offlineasm/arm.rb Diff Modified: trunk/Source/_javascript_Core/ChangeLog (163880 => 163881) --- trunk/Source/_javascript_Core/ChangeLog 2014-02-11 17:33:41 UTC (rev 163880) +++ trunk/Source/_javascript_Core/ChangeLog 2014-02-11 17:34:39 UTC (rev 163881) @@ -1,3 +1,12 @@ +2014-02-11 Gabor Rapcsanyi rga...@webkit.org + +LLInt typo error after r139004. +https://bugs.webkit.org/show_bug.cgi?id=128592 + +Reviewed by Michael Saboff. + +* offlineasm/arm.rb: change immediate to register in the condition + 2014-02-10 Filip Pizlo fpi...@apple.com LICM should gracefully handle unprofiled code Modified: trunk/Source/_javascript_Core/offlineasm/arm.rb (163880 => 163881) --- trunk/Source/_javascript_Core/offlineasm/arm.rb 2014-02-11 17:33:41 UTC (rev 163880) +++ trunk/Source/_javascript_Core/offlineasm/arm.rb 2014-02-11 17:34:39 UTC (rev 163881) @@ -335,7 +335,7 @@ else $asm.puts adds #{operands[2].armOperand}, #{operands[1].armOperand}, #{operands[0].armOperand} end -elsif operands.size == 3 and operands[0].immediate? +elsif operands.size == 3 and operands[0].register? raise unless operands[1].register? raise unless operands[2].register? $asm.puts adds #{armFlippedOperands(operands)} ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163441] trunk/Tools
Title: [163441] trunk/Tools Revision 163441 Author rga...@webkit.org Date 2014-02-05 04:31:06 -0800 (Wed, 05 Feb 2014) Log Message Fix WaitForSVNServer build step after r163372. Rubber-stamped by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (WaitForSVNServer.evaluateCommand): add missing return SUCCESS Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (163440 => 163441) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-02-05 11:42:35 UTC (rev 163440) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-02-05 12:31:06 UTC (rev 163441) @@ -137,6 +137,7 @@ def evaluateCommand(self, cmd): if cmd.rc != 0: return WARNINGS +return SUCCESS class InstallWin32Dependencies(shell.Compile): description = [installing dependencies] Modified: trunk/Tools/ChangeLog (163440 => 163441) --- trunk/Tools/ChangeLog 2014-02-05 11:42:35 UTC (rev 163440) +++ trunk/Tools/ChangeLog 2014-02-05 12:31:06 UTC (rev 163441) @@ -1,3 +1,12 @@ +2014-02-05 Gabor Rapcsanyi rga...@webkit.org + +Fix WaitForSVNServer build step after r163372. + +Rubber-stamped by Csaba Osztrogonác. + +* BuildSlaveSupport/build.webkit.org-config/master.cfg: +(WaitForSVNServer.evaluateCommand): add missing return SUCCESS + 2014-02-05 Csaba Osztrogonác o...@webkit.org Remove ENABLE(SVG) guards ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163372] trunk/Tools
Title: [163372] trunk/Tools Revision 163372 Author rga...@webkit.org Date 2014-02-04 03:54:17 -0800 (Tue, 04 Feb 2014) Log Message Fine tuning the ARM EFL bots https://bugs.webkit.org/show_bug.cgi?id=128168 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (WaitForSVNServer): Make it not to halt before the first repository checkout. (WaitForSVNServer.evaluateCommand): (Factory.__init__): Disable kill-old-processes step on EFL ARM bots, because these bots run on the same machine and they kill the processes of each other. Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (163371 => 163372) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-02-04 11:40:22 UTC (rev 163371) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-02-04 11:54:17 UTC (rev 163372) @@ -189,11 +189,13 @@ { name: EFL Linux ARMv7 Thumb2 Release (Build), type: Build, builddir: efl-linux-armv7-thumb2-release, platform: efl, configuration: release, architectures: [armv7], + SVNMirror: svn://webkit.inf.u-szeged.hu/webkit/, slavenames: [efl-linux-szeged-slave-1] }, { name: EFL Linux ARMv7 Traditional Release (Build), type: Build, builddir: efl-linux-armv7-traditional-release, platform: efl, configuration: release, architectures: [armv7], + SVNMirror: svn://webkit.inf.u-szeged.hu/webkit/, slavenames: [efl-linux-szeged-slave-2] } ], Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (163371 => 163372) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-02-04 11:40:22 UTC (rev 163371) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-02-04 11:54:17 UTC (rev 163372) @@ -132,8 +132,12 @@ command = [python, ./Tools/BuildSlaveSupport/wait-for-SVN-server.py, -r, WithProperties(%(revision)s), -s, WithProperties(%(SVNMirror)s)] description = [waiting for SVN server] descriptionDone = [SVN server is ready] -haltOnFailure = True +warnOnFailure = True +def evaluateCommand(self, cmd): +if cmd.rc != 0: +return WARNINGS + class InstallWin32Dependencies(shell.Compile): description = [installing dependencies] descriptionDone = [installed dependencies] @@ -739,7 +743,8 @@ if SVNMirror: self.addStep(WaitForSVNServer()) self.addStep(CheckOutSource(SVNMirror=SVNMirror)) -self.addStep(KillOldProcesses()) +if not (platform == efl and 'armv7' in architectures): +self.addStep(KillOldProcesses()) self.addStep(CleanBuildIfScheduled()) self.addStep(DeleteStaleBuildFiles()) if platform == win: Modified: trunk/Tools/ChangeLog (163371 => 163372) --- trunk/Tools/ChangeLog 2014-02-04 11:40:22 UTC (rev 163371) +++ trunk/Tools/ChangeLog 2014-02-04 11:54:17 UTC (rev 163372) @@ -1,3 +1,17 @@ +2014-02-04 Gabor Rapcsanyi rga...@webkit.org + +Fine tuning the ARM EFL bots +https://bugs.webkit.org/show_bug.cgi?id=128168 + +Reviewed by Csaba Osztrogonác. + +* BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror. +* BuildSlaveSupport/build.webkit.org-config/master.cfg: +(WaitForSVNServer): Make it not to halt before the first repository checkout. +(WaitForSVNServer.evaluateCommand): +(Factory.__init__): Disable kill-old-processes step on EFL ARM bots, because these +bots run on the same machine and they kill the processes of each other. + 2014-02-03 Ryosuke Niwa rn...@webkit.org kill-old-processes doesn't kill plugin processes ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163179] trunk/Source/JavaScriptCore
Title: [163179] trunk/Source/_javascript_Core Revision 163179 Author rga...@webkit.org Date 2014-01-31 10:59:59 -0800 (Fri, 31 Jan 2014) Log Message Fix the ARM Thumb2 build after jsCStack branch merge https://bugs.webkit.org/show_bug.cgi?id=127903 Reviewed by Michael Saboff. SP register cannot be used as a destination register of SUB or ADD on Thumb mode. * llint/LowLevelInterpreter.asm: * llint/LowLevelInterpreter32_64.asm: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm Diff Modified: trunk/Source/_javascript_Core/ChangeLog (163178 => 163179) --- trunk/Source/_javascript_Core/ChangeLog 2014-01-31 18:49:27 UTC (rev 163178) +++ trunk/Source/_javascript_Core/ChangeLog 2014-01-31 18:59:59 UTC (rev 163179) @@ -1,3 +1,15 @@ +2014-01-31 Gabor Rapcsanyi rga...@webkit.org + +Fix the ARM Thumb2 build after jsCStack branch merge +https://bugs.webkit.org/show_bug.cgi?id=127903 + +Reviewed by Michael Saboff. + +SP register cannot be used as a destination register of SUB or ADD on Thumb mode. + +* llint/LowLevelInterpreter.asm: +* llint/LowLevelInterpreter32_64.asm: + 2014-01-31 Julien Brianceau jbria...@cisco.com [arm] Add missing pushPair/popPair implementations in MacroAssemblerARM.h Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm (163178 => 163179) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-01-31 18:49:27 UTC (rev 163178) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-01-31 18:59:59 UTC (rev 163179) @@ -339,7 +339,13 @@ end macro callToJavaScriptEpilogue() -addp CallFrameHeaderSlots * 8, cfr, sp +if ARMv7 +addp CallFrameHeaderSlots * 8, cfr, t4 +move t4, sp +else +addp CallFrameHeaderSlots * 8, cfr, sp +end + loadp CallerFrame[cfr], cfr if X86 @@ -368,7 +374,12 @@ loadi CodeBlock::m_numCalleeRegisters[codeBlock], scratch lshiftp 3, scratch addp maxFrameExtentForSlowPathCall, scratch -subp cfr, scratch, sp +if ARMv7 +subp cfr, scratch, scratch +move scratch, sp +else +subp cfr, scratch, sp +end end macro restoreStackPointerAfterCall() @@ -398,7 +409,12 @@ slowPath, macro (callee) btpz t1, .dontUpdateSP -addp CallerFrameAndPCSize, t1, sp +if ARMv7 +addp CallerFrameAndPCSize, t1, t1 +move t1, sp +else +addp CallerFrameAndPCSize, t1, sp +end .dontUpdateSP: if C_LOOP cloopCallJSFunction callee @@ -956,7 +972,12 @@ move t1, sp else # The calleeFrame is not stack aligned, move down by CallerFrameAndPCSize to align -subp t1, CallerFrameAndPCSize, sp +if ARMv7 +subp t1, CallerFrameAndPCSize, t2 +move t2, sp +else +subp t1, CallerFrameAndPCSize, sp +end end slowPathForCall(_llint_slow_path_call_varargs) Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (163178 => 163179) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2014-01-31 18:49:27 UTC (rev 163178) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2014-01-31 18:59:59 UTC (rev 163179) @@ -238,7 +238,12 @@ # before we start copying the args from the protoCallFrame below. bpaeq temp1, VM::m_jsStackLimit[vm], .stackHeightOK -subp cfr, 8, sp +if ARMv7 +subp cfr, 8, temp2 +move temp2, sp +else +subp cfr, 8, sp +end if C_LOOP move entry, temp2 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163101] trunk/Tools
Title: [163101] trunk/Tools Revision 163101 Author rga...@webkit.org Date 2014-01-30 12:43:04 -0800 (Thu, 30 Jan 2014) Log Message Add ARM EFL Linux builder bots to Apple buildmaster https://bugs.webkit.org/show_bug.cgi?id=127472 Reviewed by Csaba Osztrogonác. There is no ARM buildslaves after removing the Qt builders. * BuildSlaveSupport/build.webkit.org-config/config.json: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (163100 => 163101) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-30 20:32:50 UTC (rev 163100) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-30 20:43:04 UTC (rev 163101) @@ -41,7 +41,9 @@ { name: efl-linux-slave-1, platform: efl }, { name: efl-linux-slave-2, platform: efl }, -{ name: efl-linux-slave-3, platform: efl } +{ name: efl-linux-slave-3, platform: efl }, +{ name: efl-linux-szeged-slave-1, platform: efl }, +{ name: efl-linux-szeged-slave-2, platform: efl } ], @@ -183,13 +185,23 @@ name: EFL Linux 32-bit Release (Build), type: Build, builddir: efl-linux-32-release, platform: efl, configuration: release, architectures: [i386], slavenames: [efl-linux-slave-3] +}, +{ + name: EFL Linux ARMv7 Thumb2 Release (Build), type: Build, builddir: efl-linux-armv7-thumb2-release, + platform: efl, configuration: release, architectures: [armv7], + slavenames: [efl-linux-szeged-slave-1] +}, +{ + name: EFL Linux ARMv7 Traditional Release (Build), type: Build, builddir: efl-linux-armv7-traditional-release, + platform: efl, configuration: release, architectures: [armv7], + slavenames: [efl-linux-szeged-slave-2] } ], schedulers: [ { type: AnyBranchScheduler, name: trunk, change_filter: trunk_filter, treeStableTimer: 45.0, builderNames: [GTK Linux 32-bit Release, GTK Linux 64-bit Release, GTK Linux 64-bit Debug WK1, EFL Linux 64-bit Release WK1, EFL Linux 64-bit Release WK2, EFL Linux 32-bit Release (Build), - WinCairo Release] + EFL Linux ARMv7 Thumb2 Release (Build), EFL Linux ARMv7 Traditional Release (Build), WinCairo Release] }, { type: PlatformSpecificScheduler, platform: mac-mountainlion, branch: trunk, treeStableTimer: 45.0, builderNames: [Apple MountainLion Release (Build), Apple MountainLion Debug (Build), Apple MountainLion Release (32-bit Build)] Modified: trunk/Tools/ChangeLog (163100 => 163101) --- trunk/Tools/ChangeLog 2014-01-30 20:32:50 UTC (rev 163100) +++ trunk/Tools/ChangeLog 2014-01-30 20:43:04 UTC (rev 163101) @@ -1,3 +1,14 @@ +2014-01-30 Gabor Rapcsanyi rga...@webkit.org + +Add ARM EFL Linux builder bots to Apple buildmaster +https://bugs.webkit.org/show_bug.cgi?id=127472 + +Reviewed by Csaba Osztrogonác. + +There is no ARM buildslaves after removing the Qt builders. + +* BuildSlaveSupport/build.webkit.org-config/config.json: + 2014-01-30 Andy Estes aes...@apple.com REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161437] trunk
Title: [161437] trunk Revision 161437 Author rga...@webkit.org Date 2014-01-07 11:10:51 -0800 (Tue, 07 Jan 2014) Log Message pushFinallyContext saves wrong m_labelScopes size https://bugs.webkit.org/show_bug.cgi?id=124529 Remove free label scopes before saving finally context. Reviewed by Geoffrey Garen. Source/_javascript_Core: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::pushFinallyContext): LayoutTests: * js/script-tests/try-return-finally-break.js: Added. (foo): * js/try-return-finally-break-expected.txt: Added. * js/try-return-finally-break.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp Added Paths trunk/LayoutTests/js/script-tests/try-return-finally-break.js trunk/LayoutTests/js/try-return-finally-break-expected.txt trunk/LayoutTests/js/try-return-finally-break.html Diff Modified: trunk/LayoutTests/ChangeLog (161436 => 161437) --- trunk/LayoutTests/ChangeLog 2014-01-07 18:59:32 UTC (rev 161436) +++ trunk/LayoutTests/ChangeLog 2014-01-07 19:10:51 UTC (rev 161437) @@ -1,3 +1,17 @@ +2014-01-07 Gabor Rapcsanyi rga...@webkit.org + +pushFinallyContext saves wrong m_labelScopes size +https://bugs.webkit.org/show_bug.cgi?id=124529 + +Remove free label scopes before saving finally context. + +Reviewed by Geoffrey Garen. + +* js/script-tests/try-return-finally-break.js: Added. +(foo): +* js/try-return-finally-break-expected.txt: Added. +* js/try-return-finally-break.html: Added. + 2014-01-07 Bear Travis betra...@adobe.com [CSS Shapes] Change default value from 'auto' to 'none' Added: trunk/LayoutTests/js/script-tests/try-return-finally-break.js (0 => 161437) --- trunk/LayoutTests/js/script-tests/try-return-finally-break.js (rev 0) +++ trunk/LayoutTests/js/script-tests/try-return-finally-break.js 2014-01-07 19:10:51 UTC (rev 161437) @@ -0,0 +1,21 @@ +description( +Tests what would happen if you have a break in the finally block. The correct outcome is for this test to not crash during bytecompilation. +); + +function foo() { +do { +do {} while (false); + +try { +do { +return null; +} while (false); +} finally { +break; +} +} while (false); +} + +foo(); +testPassed(It worked.); + Added: trunk/LayoutTests/js/try-return-finally-break-expected.txt (0 => 161437) --- trunk/LayoutTests/js/try-return-finally-break-expected.txt (rev 0) +++ trunk/LayoutTests/js/try-return-finally-break-expected.txt 2014-01-07 19:10:51 UTC (rev 161437) @@ -0,0 +1,10 @@ +Tests what would happen if you have a break in the finally block. The correct outcome is for this test to not crash during bytecompilation. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS It worked. +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/js/try-return-finally-break.html (0 => 161437) --- trunk/LayoutTests/js/try-return-finally-break.html (rev 0) +++ trunk/LayoutTests/js/try-return-finally-break.html 2014-01-07 19:10:51 UTC (rev 161437) @@ -0,0 +1,10 @@ +!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN +html +head +script src="" +/head +body +script src="" +script src="" +/body +/html Modified: trunk/Source/_javascript_Core/ChangeLog (161436 => 161437) --- trunk/Source/_javascript_Core/ChangeLog 2014-01-07 18:59:32 UTC (rev 161436) +++ trunk/Source/_javascript_Core/ChangeLog 2014-01-07 19:10:51 UTC (rev 161437) @@ -1,3 +1,15 @@ +2014-01-07 Gabor Rapcsanyi rga...@webkit.org + +pushFinallyContext saves wrong m_labelScopes size +https://bugs.webkit.org/show_bug.cgi?id=124529 + +Remove free label scopes before saving finally context. + +Reviewed by Geoffrey Garen. + +* bytecompiler/BytecodeGenerator.cpp: +(JSC::BytecodeGenerator::pushFinallyContext): + 2014-01-06 Mark Hahnenberg mhahnenb...@apple.com Heap::collect shouldn't be responsible for sweeping Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (161436 => 161437) --- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2014-01-07 18:59:32 UTC (rev 161436) +++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2014-01-07 19:10:51 UTC (rev 161437) @@ -1954,6 +1954,10 @@ void BytecodeGenerator::pushFinallyContext(StatementNode* finallyBlock) { +// Reclaim free label scopes. +while (m_labelScopes.size() !m_labelScopes.last().refCount()) +m_labelScopes.removeLast(); + ControlFlowContext scope; scope.isFinallyBlock = true; FinallyContext context = { ___ webkit-changes mailing list webkit-changes@lists.webkit.org
[webkit-changes] [159552] trunk/Tools
Title: [159552] trunk/Tools Revision 159552 Author rga...@webkit.org Date 2013-11-20 00:30:29 -0800 (Wed, 20 Nov 2013) Log Message [EFL] libseccomp-2.0.0 doesn't support ARM architecture https://bugs.webkit.org/show_bug.cgi?id=124412 Reviewed by Gyuyoung Kim. Update libseccomp to a newer 2.1.0 version. * efl/jhbuild.modules: Modified Paths trunk/Tools/ChangeLog trunk/Tools/efl/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (159551 => 159552) --- trunk/Tools/ChangeLog 2013-11-20 07:21:38 UTC (rev 159551) +++ trunk/Tools/ChangeLog 2013-11-20 08:30:29 UTC (rev 159552) @@ -1,3 +1,14 @@ +2013-11-20 Gabor Rapcsanyi rga...@webkit.org + +[EFL] libseccomp-2.0.0 doesn't support ARM architecture +https://bugs.webkit.org/show_bug.cgi?id=124412 + +Reviewed by Gyuyoung Kim. + +Update libseccomp to a newer 2.1.0 version. + +* efl/jhbuild.modules: + 2013-11-19 Mark Rowe mr...@apple.com rdar://problem/15487072 Modernize WebKit.app's OS X version checking logic. Modified: trunk/Tools/efl/jhbuild.modules (159551 => 159552) --- trunk/Tools/efl/jhbuild.modules 2013-11-20 07:21:38 UTC (rev 159551) +++ trunk/Tools/efl/jhbuild.modules 2013-11-20 08:30:29 UTC (rev 159552) @@ -332,9 +332,9 @@ /autotools autotools id=libseccomp autogen-sh=configure - branch module=libseccomp/libseccomp-2.0.0.tar.gz version=2.0.0 + branch module=libseccomp/libseccomp-2.1.0.tar.gz version=2.1.0 repo=downloads.sourceforge.net - hash=sha256:07d8308502bb87ced8f03aa84e9de598940ff6b0c7235d1654712678821f9d76/ + hash=sha256:b0d6e4f0984e6632a04f0cf33c6babdb011674ba15ff208e196f037e0e09905e/ /autotools autotools id=atk ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159055] trunk/Source/JavaScriptCore
Title: [159055] trunk/Source/_javascript_Core Revision 159055 Author rga...@webkit.org Date 2013-11-11 10:14:47 -0800 (Mon, 11 Nov 2013) Log Message Fix CPU(ARM_TRADITIONAL) build after r159039. https://bugs.webkit.org/show_bug.cgi?id=124149 Reviewed by Geoffrey Garen. * assembler/ARMAssembler.h: (JSC::ARMAssembler::firstRegister): (JSC::ARMAssembler::lastRegister): (JSC::ARMAssembler::firstFPRegister): (JSC::ARMAssembler::lastFPRegister): * assembler/MacroAssemblerARM.h: * jit/FPRInfo.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/ARMAssembler.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h trunk/Source/_javascript_Core/jit/FPRInfo.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (159054 => 159055) --- trunk/Source/_javascript_Core/ChangeLog 2013-11-11 18:00:41 UTC (rev 159054) +++ trunk/Source/_javascript_Core/ChangeLog 2013-11-11 18:14:47 UTC (rev 159055) @@ -1,3 +1,18 @@ +2013-11-11 Gabor Rapcsanyi rga...@webkit.org + +Fix CPU(ARM_TRADITIONAL) build after r159039. +https://bugs.webkit.org/show_bug.cgi?id=124149 + +Reviewed by Geoffrey Garen. + +* assembler/ARMAssembler.h: +(JSC::ARMAssembler::firstRegister): +(JSC::ARMAssembler::lastRegister): +(JSC::ARMAssembler::firstFPRegister): +(JSC::ARMAssembler::lastFPRegister): +* assembler/MacroAssemblerARM.h: +* jit/FPRInfo.h: + 2013-11-09 Filip Pizlo fpi...@apple.com Switch FTL GetById/PutById IC's over to using AnyRegCC Modified: trunk/Source/_javascript_Core/assembler/ARMAssembler.h (159054 => 159055) --- trunk/Source/_javascript_Core/assembler/ARMAssembler.h 2013-11-11 18:00:41 UTC (rev 159054) +++ trunk/Source/_javascript_Core/assembler/ARMAssembler.h 2013-11-11 18:14:47 UTC (rev 159055) @@ -153,6 +153,12 @@ ARMBuffer buffer() { return m_buffer; } +static RegisterID firstRegister() { return ARMRegisters::r0; } +static RegisterID lastRegister() { return ARMRegisters::r15; } + +static FPRegisterID firstFPRegister() { return ARMRegisters::d0; } +static FPRegisterID lastFPRegister() { return ARMRegisters::d31; } + // ARM conditional constants typedef enum { EQ = 0x, // Zero / Equal. Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (159054 => 159055) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2013-11-11 18:00:41 UTC (rev 159054) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2013-11-11 18:14:47 UTC (rev 159055) @@ -42,12 +42,6 @@ public: typedef ARMRegisters::FPRegisterID FPRegisterID; -static RegisterID firstRegister() { return ARMRegisters::r0; } -static RegisterID lastRegister() { return ARMRegisters::r15; } - -static FPRegisterID firstFPRegister() { return ARMRegisters::d0; } -static FPRegisterID lastFPRegister() { return ARMRegisters::d31; } - enum RelationalCondition { Equal = ARMAssembler::EQ, NotEqual = ARMAssembler::NE, Modified: trunk/Source/_javascript_Core/jit/FPRInfo.h (159054 => 159055) --- trunk/Source/_javascript_Core/jit/FPRInfo.h 2013-11-11 18:00:41 UTC (rev 159054) +++ trunk/Source/_javascript_Core/jit/FPRInfo.h 2013-11-11 18:14:47 UTC (rev 159055) @@ -168,6 +168,8 @@ }; return nameForRegister[reg]; } + +static const unsigned InvalidIndex = 0x; }; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [156637] trunk/Source/JavaScriptCore
Title: [156637] trunk/Source/_javascript_Core Revision 156637 Author rga...@webkit.org Date 2013-09-30 01:10:12 -0700 (Mon, 30 Sep 2013) Log Message Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::fmodAsDFGOperation): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (156636 => 156637) --- trunk/Source/_javascript_Core/ChangeLog 2013-09-30 07:35:29 UTC (rev 156636) +++ trunk/Source/_javascript_Core/ChangeLog 2013-09-30 08:10:12 UTC (rev 156637) @@ -1,3 +1,10 @@ +2013-09-30 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490. + +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::fmodAsDFGOperation): + 2013-09-29 Nadav Rotem nro...@apple.com FTL: refactor compileAdd and compileArithSub into one function. Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (156636 => 156637) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2013-09-30 07:35:29 UTC (rev 156636) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2013-09-30 08:10:12 UTC (rev 156637) @@ -299,7 +299,7 @@ // On Windows we need to wrap fmod; on other platforms we can call it directly. // On ARMv7 we assert that all function pointers have to low bit set (point to thumb code). #if CALLING_CONVENTION_IS_STDCALL || CPU(ARM_THUMB2) -static double DFG_OPERATION fmodAsDFGOperation(double x, double y) +static double JIT_OPERATION fmodAsDFGOperation(double x, double y) { return fmod(x, y); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [156641] trunk/Source/JavaScriptCore
Title: [156641] trunk/Source/_javascript_Core Revision 156641 Author rga...@webkit.org Date 2013-09-30 02:33:34 -0700 (Mon, 30 Sep 2013) Log Message Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileCurrentBlock): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (156640 => 156641) --- trunk/Source/_javascript_Core/ChangeLog 2013-09-30 08:26:47 UTC (rev 156640) +++ trunk/Source/_javascript_Core/ChangeLog 2013-09-30 09:33:34 UTC (rev 156641) @@ -1,5 +1,12 @@ 2013-09-30 Gabor Rapcsanyi rga...@webkit.org +Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511. + +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::compileCurrentBlock): + +2013-09-30 Gabor Rapcsanyi rga...@webkit.org + Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490. * dfg/DFGSpeculativeJIT.cpp: Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (156640 => 156641) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2013-09-30 08:26:47 UTC (rev 156640) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2013-09-30 09:33:34 UTC (rev 156641) @@ -1739,8 +1739,8 @@ #if DFG_ENABLE(DEBUG_VERBOSE) if (m_currentNode-hasResult()) { -GenerationInfo info = m_generationInfo[m_currentNode-virtualRegister()]; -dataLogF(- %s, vr#%d, dataFormatToString(info.registerFormat()), (int)m_currentNode-virtualRegister()); +GenerationInfo info = m_generationInfo[m_currentNode-virtualRegister().toLocal()]; +dataLogF(- %s, vr#%d, dataFormatToString(info.registerFormat()), m_currentNode-virtualRegister().toLocal()); if (info.registerFormat() != DataFormatNone) { if (info.registerFormat() == DataFormatDouble) dataLogF(, %s, FPRInfo::debugName(info.fpr())); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [156549] trunk/Source/JavaScriptCore
Title: [156549] trunk/Source/_javascript_Core Revision 156549 Author rga...@webkit.org Date 2013-09-27 09:37:45 -0700 (Fri, 27 Sep 2013) Log Message LLInt alignment problem on ARM in debug mode https://bugs.webkit.org/show_bug.cgi?id=122012 Reviewed by Michael Saboff. Force GCC to put the LLInt code to .text section. * llint/LowLevelInterpreter.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (156548 => 156549) --- trunk/Source/_javascript_Core/ChangeLog 2013-09-27 16:34:54 UTC (rev 156548) +++ trunk/Source/_javascript_Core/ChangeLog 2013-09-27 16:37:45 UTC (rev 156549) @@ -1,3 +1,14 @@ +2013-09-27 Gabor Rapcsanyi rga...@webkit.org + +LLInt alignment problem on ARM in debug mode +https://bugs.webkit.org/show_bug.cgi?id=122012 + +Reviewed by Michael Saboff. + +Force GCC to put the LLInt code to .text section. + +* llint/LowLevelInterpreter.cpp: + 2013-09-06 Jer Noble jer.no...@apple.com [Mac] Implement the media controls in _javascript_. Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (156548 => 156549) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2013-09-27 16:34:54 UTC (rev 156548) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2013-09-27 16:37:45 UTC (rev 156549) @@ -533,6 +533,7 @@ #if CPU(ARM_THUMB2) #define OFFLINE_ASM_GLOBAL_LABEL(label) \ +.text\n\ .globl SYMBOL_STRING(label) \n \ HIDE_SYMBOL(label) \n \ .thumb\n \ @@ -540,6 +541,7 @@ SYMBOL_STRING(label) :\n #else #define OFFLINE_ASM_GLOBAL_LABEL(label) \ +.text\n \ .globl SYMBOL_STRING(label) \n \ HIDE_SYMBOL(label) \n \ SYMBOL_STRING(label) :\n ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [154726] trunk/LayoutTests
Title: [154726] trunk/LayoutTests Revision 154726 Author rga...@webkit.org Date 2013-08-28 01:32:42 -0700 (Wed, 28 Aug 2013) Log Message Unreviewed ARM Qt gardening. * platform/qt-arm/TestExpectations: Unskipped some tests which are already passed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-arm/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (154725 => 154726) --- trunk/LayoutTests/ChangeLog 2013-08-28 08:08:34 UTC (rev 154725) +++ trunk/LayoutTests/ChangeLog 2013-08-28 08:32:42 UTC (rev 154726) @@ -1,3 +1,10 @@ +2013-08-28 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed ARM Qt gardening. + +* platform/qt-arm/TestExpectations: +Unskipped some tests which are already passed. + 2013-08-28 Ádám Kallai ka...@inf.u-szeged.hu [Qt] Moving expectations from Qt 5.0 WK2 to Qt WK2 - Part 8. Modified: trunk/LayoutTests/platform/qt-arm/TestExpectations (154725 => 154726) --- trunk/LayoutTests/platform/qt-arm/TestExpectations 2013-08-28 08:08:34 UTC (rev 154725) +++ trunk/LayoutTests/platform/qt-arm/TestExpectations 2013-08-28 08:32:42 UTC (rev 154726) @@ -35,9 +35,6 @@ fast/dom/Window/custom-constructors.html fast/events/media-element-focus-tab.html fast/forms/form-associated-element-crash3.html -fast/js/constructor-length.html -fast/js/global-constructors-attributes.html -fast/js/instanceof-XMLHttpRequest.html fast/replaced/outline-replaced-elements.html http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html http/tests/misc/delete-frame-during-readystatechange.html @@ -63,7 +60,6 @@ compositing/self-painting-layers.html compositing/tiling/huge-layer-img.html fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html -fast/js/reentrant-caching.html http/tests/cache/subresource-expiration-1.html http/tests/cache/subresource-expiration-2.html @@ -84,8 +80,3 @@ # crashing tests fast/multicol/huge-column-gap-crash.html fast/js/create-lots-of-workers.html - -# Fix the ARM traditional DFG JIT related bugs -# https://bugs.webkit.org/show_bug.cgi?id=105304 -fast/js/integer-division-neg2tothe32-by-neg1.html -fast/js/regress/negative-zero-modulo.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [154167] trunk/Source/WebKit2
Title: [154167] trunk/Source/WebKit2 Revision 154167 Author rga...@webkit.org Date 2013-08-16 01:05:35 -0700 (Fri, 16 Aug 2013) Log Message [Qt][ARM] Unreviewed buildfix after 154127. * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h: Add missing header. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h Diff Modified: trunk/Source/WebKit2/ChangeLog (154166 => 154167) --- trunk/Source/WebKit2/ChangeLog 2013-08-16 07:17:10 UTC (rev 154166) +++ trunk/Source/WebKit2/ChangeLog 2013-08-16 08:05:35 UTC (rev 154167) @@ -1,3 +1,9 @@ +2013-08-16 Gabor Rapcsanyi rga...@webkit.org + +[Qt][ARM] Unreviewed buildfix after 154127. + +* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h: Add missing header. + 2013-08-15 Ryuan Choi ryuan.c...@samsung.com [EFL] Unreviewed build fix after r154142 and r154144. Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h (154166 => 154167) --- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h 2013-08-16 07:17:10 UTC (rev 154166) +++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h 2013-08-16 08:05:35 UTC (rev 154167) @@ -27,6 +27,7 @@ #include LayerTreeHost.h #include WebCore/CompositingCoordinator.h #include WebCore/GraphicsLayerFactory.h +#include wtf/HashSet.h #include wtf/OwnPtr.h #if ENABLE(CSS_SHADERS) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153936] trunk/Source/WebCore
Title: [153936] trunk/Source/WebCore Revision 153936 Author rga...@webkit.org Date 2013-08-12 02:38:50 -0700 (Mon, 12 Aug 2013) Log Message [Qt] Unreviewed buildfix for webaudio. * Target.pri: Add missing files Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Target.pri Diff Modified: trunk/Source/WebCore/ChangeLog (153935 => 153936) --- trunk/Source/WebCore/ChangeLog 2013-08-12 09:17:29 UTC (rev 153935) +++ trunk/Source/WebCore/ChangeLog 2013-08-12 09:38:50 UTC (rev 153936) @@ -1,3 +1,9 @@ +2013-08-12 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed buildfix for webaudio. + +* Target.pri: Add missing files + 2013-08-12 Andreas Kling akl...@apple.com Some build juice for the Windows bots after r153926 + r153927. Modified: trunk/Source/WebCore/Target.pri (153935 => 153936) --- trunk/Source/WebCore/Target.pri 2013-08-12 09:17:29 UTC (rev 153935) +++ trunk/Source/WebCore/Target.pri 2013-08-12 09:38:50 UTC (rev 153936) @@ -3404,6 +3404,7 @@ platform/audio/DenormalDisabler.h \ platform/audio/DirectConvolver.h \ platform/audio/Distance.h \ +platform/audio/DownSampler.h \ platform/audio/DynamicsCompressor.h \ platform/audio/DynamicsCompressorKernel.h \ platform/audio/EqualPowerPanner.h \ @@ -3422,6 +3423,7 @@ platform/audio/Reverb.h \ platform/audio/ReverbInputBuffer.h \ platform/audio/SincResampler.h \ +platform/audio/UpSampler.h \ platform/audio/VectorMath.h \ platform/audio/ZeroPole.h @@ -3485,6 +3487,7 @@ platform/audio/Cone.cpp \ platform/audio/DirectConvolver.cpp \ platform/audio/Distance.cpp \ +platform/audio/DownSampler.cpp \ platform/audio/DynamicsCompressor.cpp \ platform/audio/DynamicsCompressorKernel.cpp \ platform/audio/EqualPowerPanner.cpp \ @@ -3505,6 +3508,7 @@ platform/audio/Reverb.cpp \ platform/audio/ReverbInputBuffer.cpp \ platform/audio/SincResampler.cpp \ +platform/audio/UpSampler.cpp \ platform/audio/VectorMath.cpp \ platform/audio/ZeroPole.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153316] trunk/Source
Title: [153316] trunk/Source Revision 153316 Author rga...@webkit.org Date 2013-07-25 05:18:47 -0700 (Thu, 25 Jul 2013) Log Message Unreviewed, build fix on the Qt port. Source/_javascript_Core: * Target.pri: Add additional build files for the FTL. Source/WTF: * WTF.pro: Add additional build files for the FTL. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Target.pri trunk/Source/WTF/ChangeLog trunk/Source/WTF/WTF.pro Diff Modified: trunk/Source/_javascript_Core/ChangeLog (153315 => 153316) --- trunk/Source/_javascript_Core/ChangeLog 2013-07-25 12:09:30 UTC (rev 153315) +++ trunk/Source/_javascript_Core/ChangeLog 2013-07-25 12:18:47 UTC (rev 153316) @@ -1,3 +1,9 @@ +2013-07-25 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed, build fix on the Qt port. + +* Target.pri: Add additional build files for the FTL. + 2013-07-25 Ádám Kallai ka...@inf.u-szeged.hu Unreviewed buildfix after FTL upstream.. Modified: trunk/Source/_javascript_Core/Target.pri (153315 => 153316) --- trunk/Source/_javascript_Core/Target.pri 2013-07-25 12:09:30 UTC (rev 153315) +++ trunk/Source/_javascript_Core/Target.pri 2013-07-25 12:18:47 UTC (rev 153316) @@ -81,6 +81,7 @@ bytecode/Watchpoint.cpp \ bytecompiler/BytecodeGenerator.cpp \ bytecompiler/NodesCodegen.cpp \ +heap/CopiedSpaceInlines.h \ heap/CopiedSpace.cpp \ heap/CopyVisitor.cpp \ heap/ConservativeRoots.cpp \ @@ -111,33 +112,56 @@ debugger/DebuggerActivation.cpp \ debugger/DebuggerCallFrame.cpp \ debugger/Debugger.cpp \ +dfg/DFGAbstractHeap.cpp \ +dfg/DFGAbstractValue.cpp \ dfg/DFGArgumentsSimplificationPhase.cpp \ dfg/DFGArrayMode.cpp \ dfg/DFGAssemblyHelpers.cpp \ +dfg/DFGAtTailAbstractState.cpp \ dfg/DFGBackwardsPropagationPhase.cpp \ +dfg/DFGBasicBlock.cpp \ +dfg/DFGBinarySwitch.cpp \ +dfg/DFGBlockInsertionSet.cpp \ dfg/DFGByteCodeParser.cpp \ dfg/DFGCapabilities.cpp \ +dfg/DFGClobberize.cpp \ +dfg/DFGClobberSet.cpp \ dfg/DFGCommon.cpp \ dfg/DFGCommonData.cpp \ dfg/DFGCFAPhase.cpp \ dfg/DFGCFGSimplificationPhase.cpp \ dfg/DFGCPSRethreadingPhase.cpp \ dfg/DFGConstantFoldingPhase.cpp \ +dfg/DFGCriticalEdgeBreakingPhase.cpp \ dfg/DFGCSEPhase.cpp \ dfg/DFGDCEPhase.cpp \ +dfg/DFGDesiredIdentifiers.cpp \ +dfg/DFGDesiredStructureChains.cpp \ +dfg/DFGDesiredWatchpoints.cpp \ dfg/DFGDisassembler.cpp \ dfg/DFGDominators.cpp \ dfg/DFGDriver.cpp \ dfg/DFGEdge.cpp \ +dfg/DFGFailedFinalizer.cpp \ +dfg/DFGFinalizer.cpp \ dfg/DFGFixupPhase.cpp \ +dfg/DFGFlushFormat.cpp \ dfg/DFGGraph.cpp \ +dfg/DFGInPlaceAbstractState.cpp \ dfg/DFGJITCode.cpp \ dfg/DFGJITCompiler.cpp \ +dfg/DFGJITFinalizer.cpp \ +dfg/DFGLICMPhase.cpp \ +dfg/DFGLazyJSValue.cpp \ +dfg/DFGLivenessAnalysisPhase.cpp \ dfg/DFGLongLivedState.cpp \ +dfg/DFGLoopPreHeaderCreationPhase.cpp \ dfg/DFGMinifiedNode.cpp \ +dfg/DFGNaturalLoops.cpp \ dfg/DFGNode.cpp \ dfg/DFGNodeFlags.cpp \ dfg/DFGOperations.cpp \ +dfg/DFGOSRAvailabilityAnalysisPhase.cpp \ dfg/DFGOSREntry.cpp \ dfg/DFGOSRExit.cpp \ dfg/DFGOSRExitBase.cpp \ @@ -148,6 +172,7 @@ dfg/DFGOSRExitJumpPlaceholder.cpp \ dfg/DFGOSRExitPreparation.cpp \ dfg/DFGPhase.cpp \ +dfg/DFGPlan.cpp \ dfg/DFGPredictionPropagationPhase.cpp \ dfg/DFGPredictionInjectionPhase.cpp \ dfg/DFGRepatch.cpp \ @@ -164,6 +189,7 @@ dfg/DFGVariableEventStream.cpp \ dfg/DFGValidate.cpp \ dfg/DFGVirtualRegisterAllocationPhase.cpp \ +dfg/DFGWorklist.cpp \ disassembler/Disassembler.cpp \ interpreter/AbstractPC.cpp \ interpreter/CallFrame.cpp \ @@ -203,6 +229,7 @@ parser/Nodes.cpp \ parser/ParserArena.cpp \ parser/Parser.cpp \ +parser/SourceCode.cpp \ parser/SourceProvider.cpp \ parser/SourceProviderCache.cpp \ profiler/ProfilerBytecode.cpp \ @@ -241,12 +268,15 @@ runtime/CodeCache.cpp \ runtime/CodeSpecializationKind.cpp \ runtime/CommonIdentifiers.cpp \ +runtime/CommonSlowPaths.cpp \ +runtime/CompilationResult.cpp \ runtime/Completion.cpp \ runtime/ConstructData.cpp \ runtime/DateConstructor.cpp \ runtime/DateConversion.cpp \ runtime/DateInstance.cpp \ runtime/DatePrototype.cpp \ +runtime/DumpContext.cpp \ runtime/ErrorConstructor.cpp \ runtime/Error.cpp \ runtime/ErrorInstance.cpp \ @@ -262,6 +292,7 @@ runtime/Identifier.cpp \ runtime/IndexingType.cpp \ runtime/InitializeThreading.cpp \ +runtime/IntendedStructureChain.cpp \ runtime/InternalFunction.cpp \ runtime/JSActivation.cpp \ runtime/JSAPIValueWrapper.cpp \ Modified: trunk/Source/WTF/ChangeLog (153315 => 153316) --- trunk/Source/WTF/ChangeLog 2013-07-25 12:09:30 UTC (rev
[webkit-changes] [153321] trunk/Source/JavaScriptCore
Title: [153321] trunk/Source/_javascript_Core Revision 153321 Author rga...@webkit.org Date 2013-07-25 06:07:55 -0700 (Thu, 25 Jul 2013) Log Message Unreviewed build fix after FTL upstream. * dfg/DFGWorklist.cpp: (JSC::DFG::Worklist::~Worklist): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (153320 => 153321) --- trunk/Source/_javascript_Core/ChangeLog 2013-07-25 12:49:18 UTC (rev 153320) +++ trunk/Source/_javascript_Core/ChangeLog 2013-07-25 13:07:55 UTC (rev 153321) @@ -1,3 +1,10 @@ +2013-07-25 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed build fix after FTL upstream. + +* dfg/DFGWorklist.cpp: +(JSC::DFG::Worklist::~Worklist): + 2013-07-25 Ryuan Choi ryuan.c...@samsung.com Unreviewed, build fix on the EFL port. Modified: trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp (153320 => 153321) --- trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp 2013-07-25 12:49:18 UTC (rev 153320) +++ trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp 2013-07-25 13:07:55 UTC (rev 153321) @@ -44,7 +44,7 @@ { MutexLocker locker(m_lock); for (unsigned i = m_threads.size(); i--;) -m_queue.append(nullptr); // Use null plan to indicate that we want the thread to terminate. +m_queue.append(RefPtrPlan(0)); // Use null plan to indicate that we want the thread to terminate. m_planEnqueued.broadcast(); } for (unsigned i = m_threads.size(); i--;) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [150748] trunk/Source/JavaScriptCore
Title: [150748] trunk/Source/_javascript_Core Revision 150748 Author rga...@webkit.org Date 2013-05-27 05:23:13 -0700 (Mon, 27 May 2013) Log Message MacroAssemblerARM should use xor to swap registers instead of move https://bugs.webkit.org/show_bug.cgi?id=116306 Reviewed by Zoltan Herczeg. Change register swapping to xor from move and this way we don't need temporary register anymore. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::swap): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (150747 => 150748) --- trunk/Source/_javascript_Core/ChangeLog 2013-05-27 11:05:22 UTC (rev 150747) +++ trunk/Source/_javascript_Core/ChangeLog 2013-05-27 12:23:13 UTC (rev 150748) @@ -1,3 +1,16 @@ +2013-05-27 Gabor Rapcsanyi rga...@webkit.org + +MacroAssemblerARM should use xor to swap registers instead of move +https://bugs.webkit.org/show_bug.cgi?id=116306 + +Reviewed by Zoltan Herczeg. + +Change register swapping to xor from move and this way we don't need +temporary register anymore. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::swap): + 2013-05-25 Filip Pizlo fpi...@apple.com We broke (-2^31/-1)|0 in the DFG Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (150747 => 150748) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2013-05-27 11:05:22 UTC (rev 150747) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2013-05-27 12:23:13 UTC (rev 150748) @@ -539,9 +539,9 @@ void swap(RegisterID reg1, RegisterID reg2) { -move(reg1, ARMRegisters::S0); -move(reg2, reg1); -move(ARMRegisters::S0, reg2); +xor32(reg1, reg2); +xor32(reg2, reg1); +xor32(reg1, reg2); } void signExtend32ToPtr(RegisterID src, RegisterID dest) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149601] trunk/Source/JavaScriptCore
Title: [149601] trunk/Source/_javascript_Core Revision 149601 Author rga...@webkit.org Date 2013-05-06 09:37:41 -0700 (Mon, 06 May 2013) Log Message JSC ARM traditional failing on Octane NavierStokes test https://bugs.webkit.org/show_bug.cgi?id=115626 Reviewed by Zoltan Herczeg. Change the ARM traditional assembler to use double precision on value conversions. * assembler/ARMAssembler.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/ARMAssembler.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (149600 => 149601) --- trunk/Source/_javascript_Core/ChangeLog 2013-05-06 16:17:40 UTC (rev 149600) +++ trunk/Source/_javascript_Core/ChangeLog 2013-05-06 16:37:41 UTC (rev 149601) @@ -1,3 +1,15 @@ +2013-05-06 Gabor Rapcsanyi rga...@webkit.org + +JSC ARM traditional failing on Octane NavierStokes test +https://bugs.webkit.org/show_bug.cgi?id=115626 + +Reviewed by Zoltan Herczeg. + +Change the ARM traditional assembler to use double precision on value +conversions. + +* assembler/ARMAssembler.h: + 2013-05-03 Michael Saboff msab...@apple.com There should be a runtime option to constrain what functions get DFG compiled Modified: trunk/Source/_javascript_Core/assembler/ARMAssembler.h (149600 => 149601) --- trunk/Source/_javascript_Core/assembler/ARMAssembler.h 2013-05-06 16:17:40 UTC (rev 149600) +++ trunk/Source/_javascript_Core/assembler/ARMAssembler.h 2013-05-06 16:37:41 UTC (rev 149601) @@ -163,8 +163,8 @@ VMOV_VFP32 = 0x0e000a10, VMOV_ARM32 = 0x0e100a10, VCVT_F64_S32 = 0x0eb80bc0, -VCVT_S32_F64 = 0x0ebd0b40, -VCVT_U32_F64 = 0x0ebc0b40, +VCVT_S32_F64 = 0x0ebd0bc0, +VCVT_U32_F64 = 0x0ebc0bc0, VCVT_F32_F64 = 0x0eb70bc0, VCVT_F64_F32 = 0x0eb70ac0, VMRS_APSR = 0x0ef1fa10, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [148705] trunk/Source/JavaScriptCore
Title: [148705] trunk/Source/_javascript_Core Revision 148705 Author rga...@webkit.org Date 2013-04-18 14:56:32 -0700 (Thu, 18 Apr 2013) Log Message LLInt ARM backend should not use the d8 register as scratch register https://bugs.webkit.org/show_bug.cgi?id=114811 Reviewed by Filip Pizlo. The d8 register must preserved across function calls and should not used as scratch register. Changing it to d6. * offlineasm/arm.rb: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/offlineasm/arm.rb Diff Modified: trunk/Source/_javascript_Core/ChangeLog (148704 => 148705) --- trunk/Source/_javascript_Core/ChangeLog 2013-04-18 21:55:22 UTC (rev 148704) +++ trunk/Source/_javascript_Core/ChangeLog 2013-04-18 21:56:32 UTC (rev 148705) @@ -1,3 +1,15 @@ +2013-04-18 Gabor Rapcsanyi rga...@webkit.org + +LLInt ARM backend should not use the d8 register as scratch register +https://bugs.webkit.org/show_bug.cgi?id=114811 + +Reviewed by Filip Pizlo. + +The d8 register must preserved across function calls and should +not used as scratch register. Changing it to d6. + +* offlineasm/arm.rb: + 2013-04-18 Geoffrey Garen gga...@apple.com Removed HeapTimer::synchronize Modified: trunk/Source/_javascript_Core/offlineasm/arm.rb (148704 => 148705) --- trunk/Source/_javascript_Core/offlineasm/arm.rb 2013-04-18 21:55:22 UTC (rev 148704) +++ trunk/Source/_javascript_Core/offlineasm/arm.rb 2013-04-18 21:56:32 UTC (rev 148705) @@ -65,7 +65,7 @@ ARM_EXTRA_GPRS = [SpecialRegister.new(r9), SpecialRegister.new(r8), SpecialRegister.new(r3)] ARM_EXTRA_FPRS = [SpecialRegister.new(d7)] -ARM_SCRATCH_FPR = SpecialRegister.new(d8) +ARM_SCRATCH_FPR = SpecialRegister.new(d6) def armMoveImmediate(value, register) # Currently we only handle the simple cases, and fall back to mov/movt for the complex ones. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146459] trunk/Source
Title: [146459] trunk/Source Revision 146459 Author rga...@webkit.org Date 2013-03-21 06:19:40 -0700 (Thu, 21 Mar 2013) Log Message Implement LLInt for CPU(ARM_TRADITIONAL) https://bugs.webkit.org/show_bug.cgi?id=97589 Reviewed by Zoltan Herczeg. Enable LLInt for ARMv5 and ARMv7 traditional as well. Source/_javascript_Core: * llint/LLIntOfflineAsmConfig.h: * llint/LowLevelInterpreter.asm: * llint/LowLevelInterpreter32_64.asm: * offlineasm/arm.rb: * offlineasm/backends.rb: * offlineasm/instructions.rb: Source/WTF: * wtf/Platform.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LLIntOfflineAsmConfig.h trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm trunk/Source/_javascript_Core/offlineasm/arm.rb trunk/Source/_javascript_Core/offlineasm/backends.rb trunk/Source/_javascript_Core/offlineasm/instructions.rb trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (146458 => 146459) --- trunk/Source/_javascript_Core/ChangeLog 2013-03-21 13:14:32 UTC (rev 146458) +++ trunk/Source/_javascript_Core/ChangeLog 2013-03-21 13:19:40 UTC (rev 146459) @@ -1,3 +1,19 @@ +2013-03-21 Gabor Rapcsanyi rga...@webkit.org + +Implement LLInt for CPU(ARM_TRADITIONAL) +https://bugs.webkit.org/show_bug.cgi?id=97589 + +Reviewed by Zoltan Herczeg. + +Enable LLInt for ARMv5 and ARMv7 traditional as well. + +* llint/LLIntOfflineAsmConfig.h: +* llint/LowLevelInterpreter.asm: +* llint/LowLevelInterpreter32_64.asm: +* offlineasm/arm.rb: +* offlineasm/backends.rb: +* offlineasm/instructions.rb: + 2013-03-20 Cosmin Truta ctr...@blackberry.com [QNX][ARM] REGRESSION(r135330): Various failures in Octane Modified: trunk/Source/_javascript_Core/llint/LLIntOfflineAsmConfig.h (146458 => 146459) --- trunk/Source/_javascript_Core/llint/LLIntOfflineAsmConfig.h 2013-03-21 13:14:32 UTC (rev 146458) +++ trunk/Source/_javascript_Core/llint/LLIntOfflineAsmConfig.h 2013-03-21 13:19:40 UTC (rev 146459) @@ -62,6 +62,19 @@ #define OFFLINE_ASM_ARMv7 0 #endif +#if CPU(ARM_TRADITIONAL) +#if WTF_ARM_ARCH_AT_LEAST(7) +#define OFFLINE_ASM_ARMv7_TRADITIONAL 1 +#define OFFLINE_ASM_ARM 0 +#else +#define OFFLINE_ASM_ARM 1 +#define OFFLINE_ASM_ARMv7_TRADITIONAL 0 +#endif +#else +#define OFFLINE_ASM_ARMv7_TRADITIONAL 0 +#define OFFLINE_ASM_ARM 0 +#endif + #if CPU(X86_64) #define OFFLINE_ASM_X86_64 1 #else Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm (146458 => 146459) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2013-03-21 13:14:32 UTC (rev 146458) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2013-03-21 13:19:40 UTC (rev 146459) @@ -182,7 +182,7 @@ end macro preserveReturnAddressAfterCall(destinationRegister) -if C_LOOP or ARMv7 or MIPS +if C_LOOP or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS # In C_LOOP case, we're only preserving the bytecode vPC. move lr, destinationRegister elsif X86 or X86_64 @@ -193,7 +193,7 @@ end macro restoreReturnAddressBeforeReturn(sourceRegister) -if C_LOOP or ARMv7 or MIPS +if C_LOOP or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS # In C_LOOP case, we're only restoring the bytecode vPC. move sourceRegister, lr elsif X86 or X86_64 Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (146458 => 146459) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2013-03-21 13:14:32 UTC (rev 146458) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2013-03-21 13:19:40 UTC (rev 146459) @@ -105,7 +105,7 @@ end macro cCall2(function, arg1, arg2) -if ARMv7 +if ARM or ARMv7 or ARMv7_TRADITIONAL move arg1, t0 move arg2, t1 call function @@ -126,7 +126,7 @@ # This barely works. arg3 and arg4 should probably be immediates. macro cCall4(function, arg1, arg2, arg3, arg4) -if ARMv7 +if ARM or ARMv7 or ARMv7_TRADITIONAL move arg1, t0 move arg2, t1 move arg3, t2 @@ -1891,7 +1891,7 @@ call executableOffsetToFunction[t1] addp 16 - 4, sp loadp JITStackFrame::globalData + 4[sp], t3 -elsif ARMv7 +elsif ARM or ARMv7 or ARMv7_TRADITIONAL loadp JITStackFrame::globalData[sp], t3 storep cfr, JSGlobalData::topCallFrame[t3] move t0, t2 Modified: trunk/Source/_javascript_Core/offlineasm/arm.rb (146458 => 146459) --- trunk/Source/_javascript_Core/offlineasm/arm.rb 2013-03-21 13:14:32 UTC (rev 146458) +++ trunk/Source/_javascript_Core/offlineasm/arm.rb 2013-03-21 13:19:40 UTC (rev 146459) @@ -1,4 +1,5 @@ # Copyright (C) 2011, 2012 Apple Inc. All rights reserved. +# Copyright (C) 2013 University of Szeged. All rights reserved. # # Redistribution and
[webkit-changes] [146195] trunk/Source/JavaScriptCore
Title: [146195] trunk/Source/_javascript_Core Revision 146195 Author rga...@webkit.org Date 2013-03-19 02:32:54 -0700 (Tue, 19 Mar 2013) Log Message Implement and32 on ARMv7 and ARM traditional platforms https://bugs.webkit.org/show_bug.cgi?id=112663 Reviewed by Zoltan Herczeg. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::and32): Add missing method. (MacroAssemblerARM): * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::and32): Add missing method. (MacroAssemblerARMv7): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (146194 => 146195) --- trunk/Source/_javascript_Core/ChangeLog 2013-03-19 09:30:09 UTC (rev 146194) +++ trunk/Source/_javascript_Core/ChangeLog 2013-03-19 09:32:54 UTC (rev 146195) @@ -1,3 +1,17 @@ +2013-03-19 Gabor Rapcsanyi rga...@webkit.org + +Implement and32 on ARMv7 and ARM traditional platforms +https://bugs.webkit.org/show_bug.cgi?id=112663 + +Reviewed by Zoltan Herczeg. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::and32): Add missing method. +(MacroAssemblerARM): +* assembler/MacroAssemblerARMv7.h: +(JSC::MacroAssemblerARMv7::and32): Add missing method. +(MacroAssemblerARMv7): + 2013-03-18 Filip Pizlo fpi...@apple.com DFG ToString generic cases should work correctly Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (146194 => 146195) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2013-03-19 09:30:09 UTC (rev 146194) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2013-03-19 09:32:54 UTC (rev 146195) @@ -152,6 +152,12 @@ m_assembler.bitAnds(dest, src, w); } +void and32(Address src, RegisterID dest) +{ +load32(src, ARMRegisters::S1); +and32(ARMRegisters::S1, dest); +} + void lshift32(RegisterID shiftAmount, RegisterID dest) { lshift32(dest, shiftAmount, dest); Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (146194 => 146195) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2013-03-19 09:30:09 UTC (rev 146194) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2013-03-19 09:32:54 UTC (rev 146195) @@ -263,6 +263,12 @@ and32(imm, dest, dest); } +void and32(Address src, RegisterID dest) +{ +load32(src, dataTempRegister); +and32(dataTempRegister, dest); +} + void countLeadingZeros32(RegisterID src, RegisterID dest) { m_assembler.clz(dest, src); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145505] trunk/Source/JavaScriptCore
Title: [145505] trunk/Source/_javascript_Core Revision 145505 Author rga...@webkit.org Date 2013-03-12 02:41:37 -0700 (Tue, 12 Mar 2013) Log Message Making more sophisticated cache flush on ARM Linux platform https://bugs.webkit.org/show_bug.cgi?id=111854 Reviewed by Zoltan Herczeg. The cache flush on ARM Linux invalidates whole pages instead of just the required area. * assembler/ARMAssembler.h: (ARMAssembler): (JSC::ARMAssembler::linuxPageFlush): (JSC::ARMAssembler::cacheFlush): * assembler/ARMv7Assembler.h: (ARMv7Assembler): (JSC::ARMv7Assembler::linuxPageFlush): (JSC::ARMv7Assembler::cacheFlush): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/ARMAssembler.h trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (145504 => 145505) --- trunk/Source/_javascript_Core/ChangeLog 2013-03-12 09:30:33 UTC (rev 145504) +++ trunk/Source/_javascript_Core/ChangeLog 2013-03-12 09:41:37 UTC (rev 145505) @@ -1,5 +1,24 @@ 2013-03-12 Gabor Rapcsanyi rga...@webkit.org +Making more sophisticated cache flush on ARM Linux platform +https://bugs.webkit.org/show_bug.cgi?id=111854 + +Reviewed by Zoltan Herczeg. + +The cache flush on ARM Linux invalidates whole pages +instead of just the required area. + +* assembler/ARMAssembler.h: +(ARMAssembler): +(JSC::ARMAssembler::linuxPageFlush): +(JSC::ARMAssembler::cacheFlush): +* assembler/ARMv7Assembler.h: +(ARMv7Assembler): +(JSC::ARMv7Assembler::linuxPageFlush): +(JSC::ARMv7Assembler::cacheFlush): + +2013-03-12 Gabor Rapcsanyi rga...@webkit.org + Renaming the armv7.rb LLINT backend to arm.rb https://bugs.webkit.org/show_bug.cgi?id=110565 Modified: trunk/Source/_javascript_Core/assembler/ARMAssembler.h (145504 => 145505) --- trunk/Source/_javascript_Core/assembler/ARMAssembler.h 2013-03-12 09:30:33 UTC (rev 145504) +++ trunk/Source/_javascript_Core/assembler/ARMAssembler.h 2013-03-12 09:41:37 UTC (rev 145505) @@ -1022,29 +1022,46 @@ return AL | B | (offset BranchOffsetMask); } +#if OS(LINUX) COMPILER(GCC) +static inline void linuxPageFlush(uintptr_t begin, uintptr_t end) +{ +asm volatile( +push{r7}\n +mov r0, %0\n +mov r1, %1\n +mov r7, #0xf\n +add r7, r7, #0x2\n +mov r2, #0x0\n +svc 0x0\n +pop {r7}\n +: +: r (begin), r (end) +: r0, r1, r2); +} +#endif + #if OS(LINUX) COMPILER(RVCT) static __asm void cacheFlush(void* code, size_t); #else static void cacheFlush(void* code, size_t size) { #if OS(LINUX) COMPILER(GCC) -uintptr_t currentPage = reinterpret_castuintptr_t(code) ~(pageSize() - 1); -uintptr_t lastPage = (reinterpret_castuintptr_t(code) + size) ~(pageSize() - 1); -do { -asm volatile( -push{r7}\n -mov r0, %0\n -mov r1, %1\n -mov r7, #0xf\n -add r7, r7, #0x2\n -mov r2, #0x0\n -svc 0x0\n -pop {r7}\n -: -: r (currentPage), r (currentPage + pageSize()) -: r0, r1, r2); -currentPage += pageSize(); -} while (lastPage = currentPage); +size_t page = pageSize(); +uintptr_t current = reinterpret_castuintptr_t(code); +uintptr_t end = current + size; +uintptr_t firstPageEnd = (current ~(page - 1)) + page; + +if (end = firstPageEnd) { +linuxPageFlush(current, end); +return; +} + +linuxPageFlush(current, firstPageEnd); + +for (current = firstPageEnd; current + page end; current += page) +linuxPageFlush(current, current + page); + +linuxPageFlush(current, end); #elif OS(WINCE) CacheRangeFlush(code, size, CACHE_SYNC_ALL); #elif OS(QNX) ENABLE(ASSEMBLER_WX_EXCLUSIVE) Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (145504 => 145505) --- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2013-03-12 09:30:33 UTC (rev 145504) +++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2013-03-12 09:41:37 UTC (rev 145505) @@ -2213,28 +2213,45 @@ unsigned debugOffset() { return m_formatter.debugOffset(); } +#if OS(LINUX) +static inline void linuxPageFlush(uintptr_t begin, uintptr_t end) +{ +asm volatile( +push{r7}\n +mov r0, %0\n +mov r1,
[webkit-changes] [145551] trunk/Source/JavaScriptCore
Title: [145551] trunk/Source/_javascript_Core Revision 145551 Author rga...@webkit.org Date 2013-03-12 08:28:10 -0700 (Tue, 12 Mar 2013) Log Message https://bugs.webkit.org/show_bug.cgi?id=112141 LLInt CLoop backend misses Double2Ints() on 32bit architectures Reviewed by Filip Pizlo. Implement Double2Ints() in CLoop backend of LLInt on 32bit architectures. * llint/LowLevelInterpreter.cpp: (LLInt): (JSC::LLInt::Double2Ints): * offlineasm/cloop.rb: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp trunk/Source/_javascript_Core/offlineasm/cloop.rb Diff Modified: trunk/Source/_javascript_Core/ChangeLog (145550 => 145551) --- trunk/Source/_javascript_Core/ChangeLog 2013-03-12 15:23:08 UTC (rev 145550) +++ trunk/Source/_javascript_Core/ChangeLog 2013-03-12 15:28:10 UTC (rev 145551) @@ -1,5 +1,19 @@ 2013-03-12 Gabor Rapcsanyi rga...@webkit.org +https://bugs.webkit.org/show_bug.cgi?id=112141 +LLInt CLoop backend misses Double2Ints() on 32bit architectures + +Reviewed by Filip Pizlo. + +Implement Double2Ints() in CLoop backend of LLInt on 32bit architectures. + +* llint/LowLevelInterpreter.cpp: +(LLInt): +(JSC::LLInt::Double2Ints): +* offlineasm/cloop.rb: + +2013-03-12 Gabor Rapcsanyi rga...@webkit.org + Making more sophisticated cache flush on ARM Linux platform https://bugs.webkit.org/show_bug.cgi?id=111854 Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (145550 => 145551) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2013-03-12 15:23:08 UTC (rev 145550) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2013-03-12 15:28:10 UTC (rev 145551) @@ -117,6 +117,17 @@ u.ival64 = (static_castuint64_t(hi) 32) | lo; return u.dval; } + +static void Double2Ints(double val, uint32_t lo, uint32_t hi) +{ +union { +double dval; +uint64_t ival64; +} u; +u.dval = val; +hi = static_castuint32_t(u.ival64 32); +lo = static_castuint32_t(u.ival64); +} #endif // USE(JSVALUE32_64) } // namespace LLint Modified: trunk/Source/_javascript_Core/offlineasm/cloop.rb (145550 => 145551) --- trunk/Source/_javascript_Core/offlineasm/cloop.rb 2013-03-12 15:23:08 UTC (rev 145550) +++ trunk/Source/_javascript_Core/offlineasm/cloop.rb 2013-03-12 15:28:10 UTC (rev 145551) @@ -1025,7 +1025,7 @@ # 32-bit instruction: f2dii dblOp int32LoOp int32HiOp (based on ARMv7) # Encode a 64-bit double into 2 32-bit ints (low and high). when fd2ii -$asm.putc Double2Ints(#{operands[0].clValue(:double)}, #{operands[1].clValue}, #{operands[2].clValue}); +$asm.putc Double2Ints(#{operands[0].clValue(:double)}, #{operands[1].clValue(:uint32)}, #{operands[2].clValue(:uint32)}); # 64-bit instruction: fq2d int64Op dblOp (based on X64) # Copy a bit-encoded double in a 64-bit int register to a double register. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145194] trunk/Source
Title: [145194] trunk/Source Revision 145194 Author rga...@webkit.org Date 2013-03-08 01:27:38 -0800 (Fri, 08 Mar 2013) Log Message Cache flush problem on ARMv7 JSC https://bugs.webkit.org/show_bug.cgi?id=111441 Reviewed by Zoltan Herczeg. Not proper cache flush causing random crashes on ARMv7 Linux with V8 tests. The problem is similar to https://bugs.webkit.org/show_bug.cgi?id=77712. Change the cache fulsh mechanism similar to ARM traditinal and revert the temporary fix. Source/_javascript_Core: * assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::cacheFlush): Source/WTF: * wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveUncommitted): (WTF::OSAllocator::decommit): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/OSAllocatorPosix.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (145193 => 145194) --- trunk/Source/_javascript_Core/ChangeLog 2013-03-08 09:21:24 UTC (rev 145193) +++ trunk/Source/_javascript_Core/ChangeLog 2013-03-08 09:27:38 UTC (rev 145194) @@ -1,3 +1,18 @@ +2013-03-08 Gabor Rapcsanyi rga...@webkit.org + +Cache flush problem on ARMv7 JSC +https://bugs.webkit.org/show_bug.cgi?id=111441 + +Reviewed by Zoltan Herczeg. + +Not proper cache flush causing random crashes on ARMv7 Linux with V8 tests. +The problem is similar to https://bugs.webkit.org/show_bug.cgi?id=77712. +Change the cache fulsh mechanism similar to ARM traditinal and revert the +temporary fix. + +* assembler/ARMv7Assembler.h: +(JSC::ARMv7Assembler::cacheFlush): + 2013-03-07 Geoffrey Garen gga...@apple.com REGRESSION (r143759): 40% JSBench regression, 20% Octane/closure regression, 40% Octane/jquery regression, 2% Octane regression Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (145193 => 145194) --- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2013-03-08 09:21:24 UTC (rev 145193) +++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2013-03-08 09:27:38 UTC (rev 145194) @@ -2218,18 +2218,23 @@ #if OS(IOS) sys_cache_control(kCacheFunctionPrepareForExecution, code, size); #elif OS(LINUX) -asm volatile( -push{r7}\n -mov r0, %0\n -mov r1, %1\n -movwr7, #0x2\n -movtr7, #0xf\n -movsr2, #0x0\n -svc 0x0\n -pop {r7}\n -: -: r (code), r (reinterpret_castchar*(code) + size) -: r0, r1, r2); +uintptr_t currentPage = reinterpret_castuintptr_t(code) ~(pageSize() - 1); +uintptr_t lastPage = (reinterpret_castuintptr_t(code) + size) ~(pageSize() - 1); +do { +asm volatile( +push{r7}\n +mov r0, %0\n +mov r1, %1\n +movwr7, #0x2\n +movtr7, #0xf\n +movsr2, #0x0\n +svc 0x0\n +pop {r7}\n +: +: r (currentPage), r (currentPage + pageSize()) +: r0, r1, r2); +currentPage += pageSize(); +} while (lastPage = currentPage); #elif OS(WINCE) CacheRangeFlush(code, size, CACHE_SYNC_ALL); #elif OS(QNX) Modified: trunk/Source/WTF/ChangeLog (145193 => 145194) --- trunk/Source/WTF/ChangeLog 2013-03-08 09:21:24 UTC (rev 145193) +++ trunk/Source/WTF/ChangeLog 2013-03-08 09:27:38 UTC (rev 145194) @@ -1,3 +1,19 @@ +2013-03-08 Gabor Rapcsanyi rga...@webkit.org + +Cache flush problem on ARMv7 JSC +https://bugs.webkit.org/show_bug.cgi?id=111441 + +Reviewed by Zoltan Herczeg. + +Not proper cache flush causing random crashes on ARMv7 Linux with V8 tests. +The problem is similar to https://bugs.webkit.org/show_bug.cgi?id=77712. +Change the cache fulsh mechanism similar to ARM traditinal and revert the +temporary fix. + +* wtf/OSAllocatorPosix.cpp: +(WTF::OSAllocator::reserveUncommitted): +(WTF::OSAllocator::decommit): + 2013-03-07 Andrew Bortz and...@abortz.net Replace Mersenne Twister random number generator with a simpler one. Modified: trunk/Source/WTF/wtf/OSAllocatorPosix.cpp (145193 => 145194) --- trunk/Source/WTF/wtf/OSAllocatorPosix.cpp 2013-03-08 09:21:24 UTC (rev 145193) +++ trunk/Source/WTF/wtf/OSAllocatorPosix.cpp 2013-03-08 09:27:38 UTC (rev 145194) @@ -43,7 +43,7 @@ void* result = mmap(0, bytes, PROT_NONE, MAP_LAZY | MAP_PRIVATE | MAP_ANON, -1, 0); if (result == MAP_FAILED) CRASH(); -#elif OS(LINUX) !CPU(ARM) +#elif OS(LINUX) UNUSED_PARAM(usage); UNUSED_PARAM(writable); UNUSED_PARAM(executable); @@ -165,7 +165,7 @@ #if OS(QNX) // Use PROT_NONE and MAP_LAZY to decommit the pages. mmap(address,
[webkit-changes] [142616] trunk/Source/JavaScriptCore
Title: [142616] trunk/Source/_javascript_Core Revision 142616 Author rga...@webkit.org Date 2013-02-12 06:40:40 -0800 (Tue, 12 Feb 2013) Log Message JSC asserting with long parameter list functions in debug mode on ARM traditional https://bugs.webkit.org/show_bug.cgi?id=109565 Reviewed by Zoltan Herczeg. Increase the value of sequenceGetByIdSlowCaseInstructionSpace to 80. * jit/JIT.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/jit/JIT.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (142615 => 142616) --- trunk/Source/_javascript_Core/ChangeLog 2013-02-12 14:33:18 UTC (rev 142615) +++ trunk/Source/_javascript_Core/ChangeLog 2013-02-12 14:40:40 UTC (rev 142616) @@ -1,3 +1,14 @@ +2013-02-12 Gabor Rapcsanyi rga...@webkit.org + +JSC asserting with long parameter list functions in debug mode on ARM traditional +https://bugs.webkit.org/show_bug.cgi?id=109565 + +Reviewed by Zoltan Herczeg. + +Increase the value of sequenceGetByIdSlowCaseInstructionSpace to 80. + +* jit/JIT.h: + 2013-02-11 Oliver Hunt oli...@apple.com Make JSC API more NULL tolerant Modified: trunk/Source/_javascript_Core/jit/JIT.h (142615 => 142616) --- trunk/Source/_javascript_Core/jit/JIT.h 2013-02-12 14:33:18 UTC (rev 142615) +++ trunk/Source/_javascript_Core/jit/JIT.h 2013-02-12 14:40:40 UTC (rev 142616) @@ -558,7 +558,7 @@ static const int sequenceGetByIdHotPathInstructionSpace = 36; static const int sequenceGetByIdHotPathConstantSpace = 4; // sequenceGetByIdSlowCase -static const int sequenceGetByIdSlowCaseInstructionSpace = 64; +static const int sequenceGetByIdSlowCaseInstructionSpace = 80; static const int sequenceGetByIdSlowCaseConstantSpace = 4; // sequencePutById static const int sequencePutByIdInstructionSpace = 36; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [142481] trunk/Source/JavaScriptCore
Title: [142481] trunk/Source/_javascript_Core Revision 142481 Author rga...@webkit.org Date 2013-02-11 09:01:06 -0800 (Mon, 11 Feb 2013) Log Message JSC build failing with verbose debug mode https://bugs.webkit.org/show_bug.cgi?id=109441 Reviewed by Darin Adler. Fixing some verbose messages which caused build errors. * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::mergeToSuccessors): * dfg/DFGCFAPhase.cpp: (JSC::DFG::CFAPhase::performBlockCFA): * dfg/DFGCSEPhase.cpp: (JSC::DFG::CSEPhase::setReplacement): (JSC::DFG::CSEPhase::eliminate): * dfg/DFGPredictionInjectionPhase.cpp: (JSC::DFG::PredictionInjectionPhase::run): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp trunk/Source/_javascript_Core/dfg/DFGCFAPhase.cpp trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp trunk/Source/_javascript_Core/dfg/DFGPredictionInjectionPhase.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (142480 => 142481) --- trunk/Source/_javascript_Core/ChangeLog 2013-02-11 16:52:27 UTC (rev 142480) +++ trunk/Source/_javascript_Core/ChangeLog 2013-02-11 17:01:06 UTC (rev 142481) @@ -1,3 +1,22 @@ +2013-02-11 Gabor Rapcsanyi rga...@webkit.org + +JSC build failing with verbose debug mode +https://bugs.webkit.org/show_bug.cgi?id=109441 + +Reviewed by Darin Adler. + +Fixing some verbose messages which caused build errors. + +* dfg/DFGAbstractState.cpp: +(JSC::DFG::AbstractState::mergeToSuccessors): +* dfg/DFGCFAPhase.cpp: +(JSC::DFG::CFAPhase::performBlockCFA): +* dfg/DFGCSEPhase.cpp: +(JSC::DFG::CSEPhase::setReplacement): +(JSC::DFG::CSEPhase::eliminate): +* dfg/DFGPredictionInjectionPhase.cpp: +(JSC::DFG::PredictionInjectionPhase::run): + 2013-02-10 Martin Robinson mrobin...@igalia.com Fix the GTK+ gyp build Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (142480 => 142481) --- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2013-02-11 16:52:27 UTC (rev 142480) +++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2013-02-11 17:01:06 UTC (rev 142481) @@ -2010,7 +2010,7 @@ case Jump: { ASSERT(basicBlock-cfaBranchDirection == InvalidBranchDirection); #if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE) -dataLogF(Merging to block #%u.\n, terminal.takenBlockIndex()); +dataLogF(Merging to block #%u.\n, terminal-takenBlockIndex()); #endif return merge(basicBlock, graph.m_blocks[terminal-takenBlockIndex()].get()); } @@ -2024,7 +2024,7 @@ if (basicBlock-cfaBranchDirection != TakeFalse) changed |= merge(basicBlock, graph.m_blocks[terminal-takenBlockIndex()].get()); #if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE) -dataLogF(Merging to block #%u.\n, terminal.notTakenBlockIndex()); +dataLogF(Merging to block #%u.\n, terminal-notTakenBlockIndex()); #endif if (basicBlock-cfaBranchDirection != TakeTrue) changed |= merge(basicBlock, graph.m_blocks[terminal-notTakenBlockIndex()].get()); Modified: trunk/Source/_javascript_Core/dfg/DFGCFAPhase.cpp (142480 => 142481) --- trunk/Source/_javascript_Core/dfg/DFGCFAPhase.cpp 2013-02-11 16:52:27 UTC (rev 142480) +++ trunk/Source/_javascript_Core/dfg/DFGCFAPhase.cpp 2013-02-11 17:01:06 UTC (rev 142481) @@ -92,7 +92,7 @@ if (!node-shouldGenerate()) continue; #if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE) -dataLogF( %s @%u: , Graph::opName(m_graph[nodeIndex].op()), node-index()); +dataLogF( %s @%u: , Graph::opName(node-op()), node-index()); m_state.dump(WTF::dataFile()); dataLogF(\n); #endif Modified: trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp (142480 => 142481) --- trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2013-02-11 16:52:27 UTC (rev 142480) +++ trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2013-02-11 17:01:06 UTC (rev 142481) @@ -1006,7 +1006,7 @@ return false; #if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE) -dataLogF( Replacing @%u - @%u, m_compileNode-index(), replacement-index()); +dataLogF( Replacing @%u - @%u, m_currentNode-index(), replacement-index()); #endif m_currentNode-setOpAndDefaultFlags(Phantom); @@ -1024,7 +1024,7 @@ void eliminate() { #if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE) -dataLogF( Eliminating @%u, m_compileIndex); +dataLogF( Eliminating @%u, m_currentNode-index()); #endif ASSERT(m_currentNode-refCount() == 1); Modified: trunk/Source/_javascript_Core/dfg/DFGPredictionInjectionPhase.cpp (142480 => 142481) --- trunk/Source/_javascript_Core/dfg/DFGPredictionInjectionPhase.cpp 2013-02-11 16:52:27 UTC (rev 142480) +++ trunk/Source/_javascript_Core/dfg/DFGPredictionInjectionPhase.cpp 2013-02-11 17:01:06 UTC (rev
[webkit-changes] [138936] trunk/Source/WebCore
Title: [138936] trunk/Source/WebCore Revision 138936 Author rga...@webkit.org Date 2013-01-07 06:31:32 -0800 (Mon, 07 Jan 2013) Log Message Optimizing RGBA16, RGB16, ARGB16, BGRA16 unpacking functions with NEON intrinsics https://bugs.webkit.org/show_bug.cgi?id=103614 Reviewed by Zoltan Herczeg. Optimizing RGBA16, RGB16, ARGB16, BGRA16 unpacking functions in GraphicsContext3D with ARM NEON intrinsics. The optimized functions are 2-3x faster than the origin. * platform/graphics/GraphicsContext3D.cpp: (WebCore): * platform/graphics/cpu/arm/GraphicsContext3DNEON.h: (WebCore::SIMD::unpackOneRowOfRGBA16LittleToRGBA8): (SIMD): (WebCore::SIMD::unpackOneRowOfRGB16LittleToRGBA8): (WebCore::SIMD::unpackOneRowOfARGB16LittleToRGBA8): (WebCore::SIMD::unpackOneRowOfBGRA16LittleToRGBA8): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h Diff Modified: trunk/Source/WebCore/ChangeLog (138935 => 138936) --- trunk/Source/WebCore/ChangeLog 2013-01-07 13:26:13 UTC (rev 138935) +++ trunk/Source/WebCore/ChangeLog 2013-01-07 14:31:32 UTC (rev 138936) @@ -1,3 +1,22 @@ +2013-01-07 Gabor Rapcsanyi rga...@webkit.org + +Optimizing RGBA16, RGB16, ARGB16, BGRA16 unpacking functions with NEON intrinsics +https://bugs.webkit.org/show_bug.cgi?id=103614 + +Reviewed by Zoltan Herczeg. + +Optimizing RGBA16, RGB16, ARGB16, BGRA16 unpacking functions in GraphicsContext3D +with ARM NEON intrinsics. The optimized functions are 2-3x faster than the origin. + +* platform/graphics/GraphicsContext3D.cpp: +(WebCore): +* platform/graphics/cpu/arm/GraphicsContext3DNEON.h: +(WebCore::SIMD::unpackOneRowOfRGBA16LittleToRGBA8): +(SIMD): +(WebCore::SIMD::unpackOneRowOfRGB16LittleToRGBA8): +(WebCore::SIMD::unpackOneRowOfARGB16LittleToRGBA8): +(WebCore::SIMD::unpackOneRowOfBGRA16LittleToRGBA8): + 2013-01-07 Christophe Dumez christophe.du...@intel.com Regression(r138786): Causes webaudio tests to crash Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp (138935 => 138936) --- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2013-01-07 13:26:13 UTC (rev 138935) +++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2013-01-07 14:31:32 UTC (rev 138936) @@ -392,6 +392,9 @@ void unpackOneRowOfRGBA16LittleToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { +#if HAVE(ARM_NEON_INTRINSICS) +SIMD::unpackOneRowOfRGBA16LittleToRGBA8(source, destination, pixelsPerRow); +#endif for (unsigned int i = 0; i pixelsPerRow; ++i) { destination[0] = convertColor16LittleTo8(source[0]); destination[1] = convertColor16LittleTo8(source[1]); @@ -428,6 +431,9 @@ void unpackOneRowOfRGB16LittleToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { +#if HAVE(ARM_NEON_INTRINSICS) +SIMD::unpackOneRowOfRGB16LittleToRGBA8(source, destination, pixelsPerRow); +#endif for (unsigned int i = 0; i pixelsPerRow; ++i) { destination[0] = convertColor16LittleTo8(source[0]); destination[1] = convertColor16LittleTo8(source[1]); @@ -476,6 +482,9 @@ void unpackOneRowOfARGB16LittleToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { +#if HAVE(ARM_NEON_INTRINSICS) +SIMD::unpackOneRowOfARGB16LittleToRGBA8(source, destination, pixelsPerRow); +#endif for (unsigned int i = 0; i pixelsPerRow; ++i) { destination[0] = convertColor16LittleTo8(source[1]); destination[1] = convertColor16LittleTo8(source[2]); @@ -530,6 +539,9 @@ void unpackOneRowOfBGRA16LittleToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { +#if HAVE(ARM_NEON_INTRINSICS) +SIMD::unpackOneRowOfBGRA16LittleToRGBA8(source, destination, pixelsPerRow); +#endif for (unsigned int i = 0; i pixelsPerRow; ++i) { destination[0] = convertColor16LittleTo8(source[2]); destination[1] = convertColor16LittleTo8(source[1]); Modified: trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h (138935 => 138936) --- trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h 2013-01-07 13:26:13 UTC (rev 138935) +++ trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h 2013-01-07 14:31:32 UTC (rev 138936) @@ -34,6 +34,86 @@ namespace SIMD { +ALWAYS_INLINE void unpackOneRowOfRGBA16LittleToRGBA8(const uint16_t* source, uint8_t* destination, unsigned pixelsPerRow) +{ +unsigned componentsPerRow = pixelsPerRow * 4; +unsigned tailComponents = componentsPerRow % 16; +unsigned componentsSize = componentsPerRow - tailComponents; +const uint8_t* src = "" uint8_t*(source); + +for (unsigned i = 0; i componentsSize; i += 16) { +uint8x16x2_t components =
[webkit-changes] [137884] trunk/Source/WebCore
Title: [137884] trunk/Source/WebCore Revision 137884 Author rga...@webkit.org Date 2012-12-17 00:56:19 -0800 (Mon, 17 Dec 2012) Log Message Reduce the code size of ARM SIMD in GraphicsContext3D https://bugs.webkit.org/show_bug.cgi?id=105086 Reviewed by Zoltan Herczeg. Reduce the code size of ARM SIMD in GraphicsContext3D and change the ARM namespace to SIMD. * platform/graphics/GraphicsContext3D.cpp: (WebCore): * platform/graphics/cpu/arm/GraphicsContext3DNEON.h: (WebCore::SIMD::unpackOneRowOfRGBAToRGBA8): (WebCore::SIMD::packOneRowOfRGBA8ToUnsignedShort): (WebCore::SIMD::unpackOneRowOfRGBA5551ToRGBA8): (WebCore::SIMD::packOneRowOfRGBA8ToUnsignedShort5551): (WebCore::SIMD::unpackOneRowOfRGB565ToRGBA8): (WebCore::SIMD::packOneRowOfRGBA8ToUnsignedShort565): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h Diff Modified: trunk/Source/WebCore/ChangeLog (137883 => 137884) --- trunk/Source/WebCore/ChangeLog 2012-12-17 08:53:25 UTC (rev 137883) +++ trunk/Source/WebCore/ChangeLog 2012-12-17 08:56:19 UTC (rev 137884) @@ -1,3 +1,23 @@ +2012-12-17 Gabor Rapcsanyi rga...@webkit.org + +Reduce the code size of ARM SIMD in GraphicsContext3D +https://bugs.webkit.org/show_bug.cgi?id=105086 + +Reviewed by Zoltan Herczeg. + +Reduce the code size of ARM SIMD in GraphicsContext3D and change the ARM +namespace to SIMD. + +* platform/graphics/GraphicsContext3D.cpp: +(WebCore): +* platform/graphics/cpu/arm/GraphicsContext3DNEON.h: +(WebCore::SIMD::unpackOneRowOfRGBAToRGBA8): +(WebCore::SIMD::packOneRowOfRGBA8ToUnsignedShort): +(WebCore::SIMD::unpackOneRowOfRGBA5551ToRGBA8): +(WebCore::SIMD::packOneRowOfRGBA8ToUnsignedShort5551): +(WebCore::SIMD::unpackOneRowOfRGB565ToRGBA8): +(WebCore::SIMD::packOneRowOfRGBA8ToUnsignedShort565): + 2012-12-16 Andrey Kosyakov ca...@chromium.org Web Inspector: frame bars on timeline do not react on hover and double click Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp (137883 => 137884) --- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2012-12-17 08:53:25 UTC (rev 137883) +++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2012-12-17 08:56:19 UTC (rev 137884) @@ -555,14 +555,7 @@ void unpackOneRowOfRGBA5551ToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { #if HAVE(ARM_NEON_INTRINSICS) -unsigned tailPixels = pixelsPerRow % 8; -unsigned pixelSize = pixelsPerRow - tailPixels; - -ARM::unpackOneRowOfRGBA5551ToRGBA8NEON(source, destination, pixelSize); - -source += pixelSize; -destination += pixelSize * 4; -pixelsPerRow = tailPixels; +SIMD::unpackOneRowOfRGBA5551ToRGBA8(source, destination, pixelsPerRow); #endif for (unsigned int i = 0; i pixelsPerRow; ++i) { uint16_t packedValue = source[0]; @@ -581,14 +574,7 @@ void unpackOneRowOfRGBAToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { #if HAVE(ARM_NEON_INTRINSICS) -unsigned tailPixels = pixelsPerRow % 8; -unsigned pixelSize = pixelsPerRow - tailPixels; - -ARM::unpackOneRowOfRGBAToRGBA8NEON(source, destination, pixelSize); - -source += pixelSize; -destination += pixelSize * 4; -pixelsPerRow = tailPixels; +SIMD::unpackOneRowOfRGBAToRGBA8(source, destination, pixelsPerRow); #endif for (unsigned int i = 0; i pixelsPerRow; ++i) { uint16_t packedValue = source[0]; @@ -608,14 +594,7 @@ void unpackOneRowOfRGB565ToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { #if HAVE(ARM_NEON_INTRINSICS) -unsigned tailPixels = pixelsPerRow % 8; -unsigned pixelSize = pixelsPerRow - tailPixels; - -ARM::unpackOneRowOfRGB565ToRGBA8NEON(source, destination, pixelSize); - -source += pixelSize; -destination += pixelSize * 4; -pixelsPerRow = tailPixels; +SIMD::unpackOneRowOfRGB565ToRGBA8(source, destination, pixelsPerRow); #endif for (unsigned int i = 0; i pixelsPerRow; ++i) { uint16_t packedValue = source[0]; @@ -1007,15 +986,7 @@ void packOneRowOfRGBA8ToUnsignedShort(const uint8_t* source, uint16_t* destination, unsigned int pixelsPerRow) { #if HAVE(ARM_NEON_INTRINSICS) -unsigned componentsPerRow = pixelsPerRow * 4; -unsigned tailComponents = componentsPerRow % 32; -unsigned componentsSize = componentsPerRow - tailComponents; - -ARM::packOneRowOfRGBA8ToUnsignedShortNEON(source, destination, componentsSize); - -source += componentsSize; -destination += componentsSize / 4; -pixelsPerRow = tailComponents / 4; +SIMD::packOneRowOfRGBA8ToUnsignedShort(source, destination, pixelsPerRow); #endif for (unsigned int i = 0; i pixelsPerRow; ++i) {
[webkit-changes] [136375] trunk/Source/WebCore
Title: [136375] trunk/Source/WebCore Revision 136375 Author rga...@webkit.org Date 2012-12-03 02:15:16 -0800 (Mon, 03 Dec 2012) Log Message [Qt] Remove an unnecessary masking from swapBgrToRgb() https://bugs.webkit.org/show_bug.cgi?id=103630 Reviewed by Zoltan Herczeg. Get rid of a masking command in swapBgrToRgb() to speed up a little bit. * platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::swapBgrToRgb): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (136374 => 136375) --- trunk/Source/WebCore/ChangeLog 2012-12-03 10:01:29 UTC (rev 136374) +++ trunk/Source/WebCore/ChangeLog 2012-12-03 10:15:16 UTC (rev 136375) @@ -1,3 +1,15 @@ +2012-12-03 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Remove an unnecessary masking from swapBgrToRgb() +https://bugs.webkit.org/show_bug.cgi?id=103630 + +Reviewed by Zoltan Herczeg. + +Get rid of a masking command in swapBgrToRgb() to speed up a little bit. + +* platform/graphics/qt/GraphicsContext3DQt.cpp: +(WebCore::swapBgrToRgb): + 2012-12-03 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com CSS Device Adaptation: window.innerWidth returns wrong value if CSS viewport descriptors are applied Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp (136374 => 136375) --- trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp 2012-12-03 10:01:29 UTC (rev 136374) +++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp 2012-12-03 10:15:16 UTC (rev 136375) @@ -204,7 +204,7 @@ static inline quint32 swapBgrToRgb(quint32 pixel) { -return ((pixel 16) 0xff) | ((pixel 16) 0xff) | (pixel 0xff00ff00); +return (((pixel 16) | (pixel 16)) 0x00ff00ff) | (pixel 0xff00ff00); } #if USE(ACCELERATED_COMPOSITING) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134611] trunk/Source/WebCore
Title: [134611] trunk/Source/WebCore Revision 134611 Author rga...@webkit.org Date 2012-11-14 08:02:43 -0800 (Wed, 14 Nov 2012) Log Message Fix [-Wmissing-braces] warnings in graphics/cpu/arm/GraphicsContext3DNEON.h https://bugs.webkit.org/show_bug.cgi?id=102205 Reviewed by Csaba Osztrogonác. Fixing some warnings in GraphicsContext3DNEON.h which have been caused by missing braces. * platform/graphics/cpu/arm/GraphicsContext3DNEON.h: (WebCore::ARM::unpackOneRowOfRGBAToRGBA8NEON): (WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON): (WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h Diff Modified: trunk/Source/WebCore/ChangeLog (134610 => 134611) --- trunk/Source/WebCore/ChangeLog 2012-11-14 15:55:48 UTC (rev 134610) +++ trunk/Source/WebCore/ChangeLog 2012-11-14 16:02:43 UTC (rev 134611) @@ -1,3 +1,17 @@ +2012-11-14 Gabor Rapcsanyi rga...@webkit.org + +Fix [-Wmissing-braces] warnings in graphics/cpu/arm/GraphicsContext3DNEON.h +https://bugs.webkit.org/show_bug.cgi?id=102205 + +Reviewed by Csaba Osztrogonác. + +Fixing some warnings in GraphicsContext3DNEON.h which have been caused by missing braces. + +* platform/graphics/cpu/arm/GraphicsContext3DNEON.h: +(WebCore::ARM::unpackOneRowOfRGBAToRGBA8NEON): +(WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON): +(WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON): + 2012-11-14 Erik Arvidsson a...@chromium.org Update DOMException name: NoDataAllowedError Modified: trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h (134610 => 134611) --- trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h 2012-11-14 15:55:48 UTC (rev 134610) +++ trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h 2012-11-14 16:02:43 UTC (rev 134611) @@ -50,7 +50,7 @@ componentB = vorr_u8(vshl_n_u8(componentB, 4), componentB); componentA = vorr_u8(vshl_n_u8(componentA, 4), componentA); -uint8x8x4_t destComponents = {componentR, componentG, componentB, componentA}; +uint8x8x4_t destComponents = {{componentR, componentG, componentB, componentA}}; vst4_u8(destination, destComponents); destination += 32; } @@ -96,7 +96,7 @@ componentB = vorr_u8(vshl_n_u8(componentB, 3), vand_u8(componentB, immediate0x7)); componentA = vmul_u8(componentA, immediate0xff); -uint8x8x4_t destComponents = {componentR, componentG, componentB, componentA}; +uint8x8x4_t destComponents = {{componentR, componentG, componentB, componentA}}; vst4_u8(destination, destComponents); destination += 32; } @@ -146,7 +146,7 @@ componentG = vorr_u8(vshl_n_u8(componentG, 2), vand_u8(componentG, immediate0x3)); componentB = vorr_u8(vshl_n_u8(componentB, 3), vand_u8(componentB, immediate0x7)); -uint8x8x4_t destComponents = {componentR, componentG, componentB, componentA}; +uint8x8x4_t destComponents = {{componentR, componentG, componentB, componentA}}; vst4_u8(destination, destComponents); destination += 32; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134378] trunk/Source/WebCore
Title: [134378] trunk/Source/WebCore Revision 134378 Author rga...@webkit.org Date 2012-11-13 00:33:08 -0800 (Tue, 13 Nov 2012) Log Message Optimize RGBAToRGBA8 packing/unpacking functions with NEON intrinsics in GraphicsContext3D https://bugs.webkit.org/show_bug.cgi?id=101473 Reviewed by Zoltan Herczeg. With NEON intrinsics the packing/unpacking functions can be optimized well. This particular function is about 3 times faster with ARM NEON. On top level tests the speed up was 1.18x. * CMakeLists.txt: * GNUmakefile.am: * GNUmakefile.list.am: * Target.pri: * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * WebCore.pri: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/GraphicsContext3D.cpp: (WebCore): * platform/graphics/cpu/arm/GraphicsContext3DNEON.h: Added. (WebCore): (ARM): (WebCore::ARM::unpackOneRowOfRGBAToRGBA8NEON): (WebCore::ARM::packOneRowOfRGBA8ToUnsignedShortNEON): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.pri trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp Added Paths trunk/Source/WebCore/platform/graphics/cpu/ trunk/Source/WebCore/platform/graphics/cpu/arm/ trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (134377 => 134378) --- trunk/Source/WebCore/CMakeLists.txt 2012-11-13 08:23:48 UTC (rev 134377) +++ trunk/Source/WebCore/CMakeLists.txt 2012-11-13 08:33:08 UTC (rev 134378) @@ -48,6 +48,7 @@ ${WEBCORE_DIR}/platform/animation ${WEBCORE_DIR}/platform/audio ${WEBCORE_DIR}/platform/graphics +${WEBCORE_DIR}/platform/graphics/cpu/arm ${WEBCORE_DIR}/platform/graphics/filters ${WEBCORE_DIR}/platform/graphics/filters/arm ${WEBCORE_DIR}/platform/graphics/harfbuzz Modified: trunk/Source/WebCore/ChangeLog (134377 => 134378) --- trunk/Source/WebCore/ChangeLog 2012-11-13 08:23:48 UTC (rev 134377) +++ trunk/Source/WebCore/ChangeLog 2012-11-13 08:33:08 UTC (rev 134378) @@ -1,3 +1,30 @@ +2012-11-13 Gabor Rapcsanyi rga...@webkit.org + +Optimize RGBAToRGBA8 packing/unpacking functions with NEON intrinsics in GraphicsContext3D +https://bugs.webkit.org/show_bug.cgi?id=101473 + +Reviewed by Zoltan Herczeg. + +With NEON intrinsics the packing/unpacking functions can be optimized well. +This particular function is about 3 times faster with ARM NEON. On top level tests +the speed up was 1.18x. + +* CMakeLists.txt: +* GNUmakefile.am: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gyp/WebCore.gyp: +* WebCore.gypi: +* WebCore.pri: +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/GraphicsContext3D.cpp: +(WebCore): +* platform/graphics/cpu/arm/GraphicsContext3DNEON.h: Added. +(WebCore): +(ARM): +(WebCore::ARM::unpackOneRowOfRGBAToRGBA8NEON): +(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShortNEON): + 2012-11-13 Takashi Sakamoto ta...@google.com Crash when replacing parts of text inputs with content: url(...) Modified: trunk/Source/WebCore/GNUmakefile.am (134377 => 134378) --- trunk/Source/WebCore/GNUmakefile.am 2012-11-13 08:23:48 UTC (rev 134377) +++ trunk/Source/WebCore/GNUmakefile.am 2012-11-13 08:33:08 UTC (rev 134378) @@ -54,6 +54,7 @@ -I$(srcdir)/Source/WebCore/platform/animation \ -I$(srcdir)/Source/WebCore/platform/audio \ -I$(srcdir)/Source/WebCore/platform/graphics \ + -I$(srcdir)/Source/WebCore/platform/graphics/cpu/arm \ -I$(srcdir)/Source/WebCore/platform/graphics/filters \ -I$(srcdir)/Source/WebCore/platform/graphics/filters/arm \ -I$(srcdir)/Source/WebCore/platform/graphics/gpu \ Modified: trunk/Source/WebCore/GNUmakefile.list.am (134377 => 134378) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-11-13 08:23:48 UTC (rev 134377) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-11-13 08:33:08 UTC (rev 134378) @@ -4270,6 +4270,7 @@ Source/WebCore/platform/HistogramSupport.h \ Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp \ Source/WebCore/platform/graphics/ANGLEWebKitBridge.h \ + Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h \ Source/WebCore/platform/graphics/BitmapImage.cpp \ Source/WebCore/platform/graphics/BitmapImage.h \ Source/WebCore/platform/graphics/Color.cpp \ Modified: trunk/Source/WebCore/Target.pri (134377 => 134378) --- trunk/Source/WebCore/Target.pri 2012-11-13 08:23:48 UTC (rev 134377) +++ trunk/Source/WebCore/Target.pri 2012-11-13 08:33:08 UTC (rev 134378) @@ -3956,6 +3956,7 @@ use?(3D_GRAPHICS) { HEADERS += \ +
[webkit-changes] [134403] trunk/Source/WebCore
Title: [134403] trunk/Source/WebCore Revision 134403 Author rga...@webkit.org Date 2012-11-13 05:44:31 -0800 (Tue, 13 Nov 2012) Log Message Optimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics https://bugs.webkit.org/show_bug.cgi?id=102060 Reviewed by Zoltan Herczeg. Adding more NEONized packing functions to GraphicsContext3DNEON.h. These functions are three times faster with this intrinsics optimizations. * platform/graphics/GraphicsContext3D.cpp: (WebCore): * platform/graphics/cpu/arm/GraphicsContext3DNEON.h: (WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON): (ARM): (WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort5551NEON): (WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON): (WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort565NEON): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp trunk/Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h Diff Modified: trunk/Source/WebCore/ChangeLog (134402 => 134403) --- trunk/Source/WebCore/ChangeLog 2012-11-13 13:26:44 UTC (rev 134402) +++ trunk/Source/WebCore/ChangeLog 2012-11-13 13:44:31 UTC (rev 134403) @@ -1,3 +1,22 @@ +2012-11-13 Gabor Rapcsanyi rga...@webkit.org + +Optimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics +https://bugs.webkit.org/show_bug.cgi?id=102060 + +Reviewed by Zoltan Herczeg. + +Adding more NEONized packing functions to GraphicsContext3DNEON.h. +These functions are three times faster with this intrinsics optimizations. + +* platform/graphics/GraphicsContext3D.cpp: +(WebCore): +* platform/graphics/cpu/arm/GraphicsContext3DNEON.h: +(WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON): +(ARM): +(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort5551NEON): +(WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON): +(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort565NEON): + 2012-11-13 Csaba Osztrogonác o...@webkit.org [Qt] Enable Mutation observer Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp (134402 => 134403) --- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2012-11-13 13:26:44 UTC (rev 134402) +++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2012-11-13 13:44:31 UTC (rev 134403) @@ -526,6 +526,16 @@ void unpackOneRowOfRGBA5551ToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { +#if HAVE(ARM_NEON_INTRINSICS) +unsigned tailPixels = pixelsPerRow % 8; +unsigned pixelSize = pixelsPerRow - tailPixels; + +ARM::unpackOneRowOfRGBA5551ToRGBA8NEON(source, destination, pixelSize); + +source += pixelSize; +destination += pixelSize * 4; +pixelsPerRow = tailPixels; +#endif for (unsigned int i = 0; i pixelsPerRow; ++i) { uint16_t packedValue = source[0]; uint8_t r = packedValue 11; @@ -569,6 +579,16 @@ void unpackOneRowOfRGB565ToRGBA8(const uint16_t* source, uint8_t* destination, unsigned int pixelsPerRow) { +#if HAVE(ARM_NEON_INTRINSICS) +unsigned tailPixels = pixelsPerRow % 8; +unsigned pixelSize = pixelsPerRow - tailPixels; + +ARM::unpackOneRowOfRGB565ToRGBA8NEON(source, destination, pixelSize); + +source += pixelSize; +destination += pixelSize * 4; +pixelsPerRow = tailPixels; +#endif for (unsigned int i = 0; i pixelsPerRow; ++i) { uint16_t packedValue = source[0]; uint8_t r = packedValue 11; @@ -1014,6 +1034,17 @@ void packOneRowOfRGBA8ToUnsignedShort5551(const uint8_t* source, uint16_t* destination, unsigned int pixelsPerRow) { +#if HAVE(ARM_NEON_INTRINSICS) +unsigned componentsPerRow = pixelsPerRow * 4; +unsigned tailComponents = componentsPerRow % 32; +unsigned componentsSize = componentsPerRow - tailComponents; + +ARM::packOneRowOfRGBA8ToUnsignedShort5551NEON(source, destination, componentsSize); + +source += componentsSize; +destination += componentsSize / 4; +pixelsPerRow = tailComponents / 4; +#endif for (unsigned int i = 0; i pixelsPerRow; ++i) { *destination = (((source[0] 0xF8) 8) | ((source[1] 0xF8) 3) @@ -1059,6 +1090,17 @@ void packOneRowOfRGBA8ToUnsignedShort565(const uint8_t* source, uint16_t* destination, unsigned int pixelsPerRow) { +#if HAVE(ARM_NEON_INTRINSICS) +unsigned componentsPerRow = pixelsPerRow * 4; +unsigned tailComponents = componentsPerRow % 32; +unsigned componentsSize = componentsPerRow - tailComponents; + +ARM::packOneRowOfRGBA8ToUnsignedShort565NEON(source, destination, componentsSize); + +source += componentsSize; +destination += componentsSize / 4; +pixelsPerRow = tailComponents / 4; +#endif for (unsigned int i = 0; i pixelsPerRow; ++i) { *destination = (((source[0] 0xF8) 8) | ((source[1] 0xFC) 3) Modified:
[webkit-changes] [132890] trunk/Source/WebCore
Title: [132890] trunk/Source/WebCore Revision 132890 Author rga...@webkit.org Date 2012-10-30 03:50:42 -0700 (Tue, 30 Oct 2012) Log Message Optimize vclip for NEON in VectorMath https://bugs.webkit.org/show_bug.cgi?id=100737 Reviewed by Zoltan Herczeg. Speed up vclip in VectorMath with NEON intrinsics. * platform/audio/VectorMath.cpp: (WebCore::VectorMath::vclip): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/audio/VectorMath.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (132889 => 132890) --- trunk/Source/WebCore/ChangeLog 2012-10-30 10:33:11 UTC (rev 132889) +++ trunk/Source/WebCore/ChangeLog 2012-10-30 10:50:42 UTC (rev 132890) @@ -1,3 +1,15 @@ +2012-10-30 Gabor Rapcsanyi rga...@webkit.org + +Optimize vclip for NEON in VectorMath +https://bugs.webkit.org/show_bug.cgi?id=100737 + +Reviewed by Zoltan Herczeg. + +Speed up vclip in VectorMath with NEON intrinsics. + +* platform/audio/VectorMath.cpp: +(WebCore::VectorMath::vclip): + 2012-10-30 Alexandru Chiculita ach...@adobe.com [CSS Shaders] Software and composited filters should have a common path Modified: trunk/Source/WebCore/platform/audio/VectorMath.cpp (132889 => 132890) --- trunk/Source/WebCore/platform/audio/VectorMath.cpp 2012-10-30 10:33:11 UTC (rev 132889) +++ trunk/Source/WebCore/platform/audio/VectorMath.cpp 2012-10-30 10:50:42 UTC (rev 132890) @@ -655,7 +655,22 @@ float highThreshold = *highThresholdP; // FIXME: Optimize for SSE2. -// FIXME: Optimize for NEON. +#if HAVE(ARM_NEON_INTRINSICS) +if ((sourceStride == 1) (destStride == 1)) { +int tailFrames = n % 4; +const float* endP = destP + n - tailFrames; + +float32x4_t low = vdupq_n_f32(lowThreshold); +float32x4_t high = vdupq_n_f32(highThreshold); +while (destP endP) { +float32x4_t source = vld1q_f32(sourceP); +vst1q_f32(destP, vmaxq_f32(vminq_f32(source, high), low)); +sourceP += 4; +destP += 4; +} +n = tailFrames; +} +#endif while (n--) { *destP = std::max(std::min(*sourceP, highThreshold), lowThreshold); sourceP += sourceStride; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [131562] trunk/Source/WebCore
Title: [131562] trunk/Source/WebCore Revision 131562 Author rga...@webkit.org Date 2012-10-17 01:06:55 -0700 (Wed, 17 Oct 2012) Log Message NEON intrinsics Gauss filter does not work properly https://bugs.webkit.org/show_bug.cgi?id=98875 Reviewed by Zoltan Herczeg. Fixing the NEON intrinsics Gauss filter. The stride parameter was missing from the intrinsics algorithm. Tested with pixel checks, now it's working properly. * platform/graphics/filters/arm/FEGaussianBlurNEON.h: (WebCore::boxBlurNEON): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h Diff Modified: trunk/Source/WebCore/ChangeLog (131561 => 131562) --- trunk/Source/WebCore/ChangeLog 2012-10-17 08:00:16 UTC (rev 131561) +++ trunk/Source/WebCore/ChangeLog 2012-10-17 08:06:55 UTC (rev 131562) @@ -1,3 +1,17 @@ +2012-10-17 Gabor Rapcsanyi rga...@webkit.org + +NEON intrinsics Gauss filter does not work properly +https://bugs.webkit.org/show_bug.cgi?id=98875 + +Reviewed by Zoltan Herczeg. + +Fixing the NEON intrinsics Gauss filter. The stride parameter +was missing from the intrinsics algorithm. Tested with pixel +checks, now it's working properly. + +* platform/graphics/filters/arm/FEGaussianBlurNEON.h: +(WebCore::boxBlurNEON): + 2012-10-17 MORITA Hajime morr...@google.com Crash on Frame::inScope() part 2 Modified: trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h (131561 => 131562) --- trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h 2012-10-17 08:00:16 UTC (rev 131561) +++ trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h 2012-10-17 08:06:55 UTC (rev 131562) @@ -35,13 +35,14 @@ namespace WebCore { inline void boxBlurNEON(Uint8ClampedArray* srcPixelArray, Uint8ClampedArray* dstPixelArray, -unsigned dx, int dxLeft, int dxRight, int stride, int strideLine, int effectWidth, int effectHeight) +unsigned dx, int dxLeft, int dxRight, int stride, int strideLine, int effectWidth, int effectHeight) { uint32_t* sourcePixel = reinterpret_castuint32_t*(srcPixelArray-data()); uint32_t* destinationPixel = reinterpret_castuint32_t*(dstPixelArray-data()); float32x4_t deltaX = vdupq_n_f32(1.0 / dx); int pixelLine = strideLine / 4; +int pixelStride = stride / 4; for (int y = 0; y effectHeight; ++y) { int line = y * pixelLine; @@ -49,21 +50,21 @@ // Fill the kernel int maxKernelSize = std::min(dxRight, effectWidth); for (int i = 0; i maxKernelSize; ++i) { -float32x4_t sourcePixelAsFloat = loadRGBA8AsFloat(sourcePixel + line + i); +float32x4_t sourcePixelAsFloat = loadRGBA8AsFloat(sourcePixel + line + i * pixelStride); sum = vaddq_f32(sum, sourcePixelAsFloat); } // Blurring for (int x = 0; x effectWidth; ++x) { -int pixelOffset = line + x; +int pixelOffset = line + x * pixelStride; float32x4_t result = vmulq_f32(sum, deltaX); -storeFloatAsRGBA8(result, destinationPixel+pixelOffset); +storeFloatAsRGBA8(result, destinationPixel + pixelOffset); if (x = dxLeft) { -float32x4_t sourcePixelAsFloat = loadRGBA8AsFloat(sourcePixel + pixelOffset - dxLeft); +float32x4_t sourcePixelAsFloat = loadRGBA8AsFloat(sourcePixel + pixelOffset - dxLeft * pixelStride); sum = vsubq_f32(sum, sourcePixelAsFloat); } if (x + dxRight effectWidth) { -float32x4_t sourcePixelAsFloat = loadRGBA8AsFloat(sourcePixel + pixelOffset + dxRight); +float32x4_t sourcePixelAsFloat = loadRGBA8AsFloat(sourcePixel + pixelOffset + dxRight * pixelStride); sum = vaddq_f32(sum, sourcePixelAsFloat); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130497] trunk/Source/WebCore
Title: [130497] trunk/Source/WebCore Revision 130497 Author rga...@webkit.org Date 2012-10-05 05:47:40 -0700 (Fri, 05 Oct 2012) Log Message Add ARM-NEON support to VectorMath in WebAudio https://bugs.webkit.org/show_bug.cgi?id=98131 Reviewed by Zoltan Herczeg. Speed up vector operations in WebAudio with NEON intrinsics. * platform/audio/VectorMath.cpp: (WebCore::VectorMath::vsma): (WebCore::VectorMath::vsmul): (WebCore::VectorMath::vadd): (WebCore::VectorMath::vmul): (WebCore::VectorMath::zvmul): (WebCore::VectorMath::vsvesq): (WebCore::VectorMath::vmaxmgv): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/audio/VectorMath.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (130496 => 130497) --- trunk/Source/WebCore/ChangeLog 2012-10-05 12:36:36 UTC (rev 130496) +++ trunk/Source/WebCore/ChangeLog 2012-10-05 12:47:40 UTC (rev 130497) @@ -1,3 +1,21 @@ +2012-10-05 Gabor Rapcsanyi rga...@webkit.org + +Add ARM-NEON support to VectorMath in WebAudio +https://bugs.webkit.org/show_bug.cgi?id=98131 + +Reviewed by Zoltan Herczeg. + +Speed up vector operations in WebAudio with NEON intrinsics. + +* platform/audio/VectorMath.cpp: +(WebCore::VectorMath::vsma): +(WebCore::VectorMath::vsmul): +(WebCore::VectorMath::vadd): +(WebCore::VectorMath::vmul): +(WebCore::VectorMath::zvmul): +(WebCore::VectorMath::vsvesq): +(WebCore::VectorMath::vmaxmgv): + 2012-10-05 Simon Hausmann simon.hausm...@digia.com Unreviewed, rolling out r130495. Modified: trunk/Source/WebCore/platform/audio/VectorMath.cpp (130496 => 130497) --- trunk/Source/WebCore/platform/audio/VectorMath.cpp 2012-10-05 12:36:36 UTC (rev 130496) +++ trunk/Source/WebCore/platform/audio/VectorMath.cpp 2012-10-05 12:47:40 UTC (rev 130497) @@ -36,6 +36,10 @@ #include emmintrin.h #endif +#if HAVE(ARM_NEON_INTRINSICS) +#include arm_neon.h +#endif + #include algorithm #include math.h @@ -155,6 +159,24 @@ n = tailFrames; } +#elif HAVE(ARM_NEON_INTRINSICS) +if ((sourceStride == 1) (destStride == 1)) { +int tailFrames = n % 4; +const float* endP = destP + n - tailFrames; + +float32x4_t k = vdupq_n_f32(*scale); +while (destP endP) { +float32x4_t source = vld1q_f32(sourceP); +float32x4_t dest = vld1q_f32(destP); + +dest = vmlaq_f32(dest, source, k); +vst1q_f32(destP, dest); + +sourceP += 4; +destP += 4; +} +n = tailFrames; +} #endif while (n) { *destP += *sourceP * *scale; @@ -166,10 +188,10 @@ void vsmul(const float* sourceP, int sourceStride, const float* scale, float* destP, int destStride, size_t framesToProcess) { +int n = framesToProcess; + #ifdef __SSE2__ if ((sourceStride == 1) (destStride == 1)) { - -int n = framesToProcess; float k = *scale; // If the sourceP address is not 16-byte aligned, the first several frames (at most three) should be processed separately. @@ -217,8 +239,22 @@ n--; } } else { // If strides are not 1, rollback to normal algorithm. +#elif HAVE(ARM_NEON_INTRINSICS) +if ((sourceStride == 1) (destStride == 1)) { +float k = *scale; +int tailFrames = n % 4; +const float* endP = destP + n - tailFrames; + +while (destP endP) { +float32x4_t source = vld1q_f32(sourceP); +vst1q_f32(destP, vmulq_n_f32(source, k)); + +sourceP += 4; +destP += 4; +} +n = tailFrames; +} #endif -int n = framesToProcess; float k = *scale; while (n--) { *destP = k * *sourceP; @@ -232,11 +268,10 @@ void vadd(const float* source1P, int sourceStride1, const float* source2P, int sourceStride2, float* destP, int destStride, size_t framesToProcess) { +int n = framesToProcess; + #ifdef __SSE2__ if ((sourceStride1 ==1) (sourceStride2 == 1) (destStride == 1)) { - -int n = framesToProcess; - // If the sourceP address is not 16-byte aligned, the first several frames (at most three) should be processed separately. while ((reinterpret_castsize_t(source1P) 0x0F) n) { *destP = *source1P + *source2P; @@ -315,8 +350,23 @@ n--; } } else { // if strides are not 1, rollback to normal algorithm +#elif HAVE(ARM_NEON_INTRINSICS) +if ((sourceStride1 ==1) (sourceStride2 == 1) (destStride == 1)) { +int tailFrames = n % 4; +const float* endP = destP + n - tailFrames; + +while (destP endP) { +float32x4_t source1 = vld1q_f32(source1P); +float32x4_t source2 = vld1q_f32(source2P); +vst1q_f32(destP, vaddq_f32(source1, source2)); + +source1P += 4; +source2P += 4; +destP += 4; +} +n =
[webkit-changes] [128981] trunk/LayoutTests
Title: [128981] trunk/LayoutTests Revision 128981 Author rga...@webkit.org Date 2012-09-19 02:39:17 -0700 (Wed, 19 Sep 2012) Log Message [Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails https://bugs.webkit.org/show_bug.cgi?id=97084 Unreviewed gardeing. Patch by Balazs Ankes b...@inf.u-szeged.hu on 2012-09-19 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (128980 => 128981) --- trunk/LayoutTests/ChangeLog 2012-09-19 09:10:33 UTC (rev 128980) +++ trunk/LayoutTests/ChangeLog 2012-09-19 09:39:17 UTC (rev 128981) @@ -1,3 +1,12 @@ +2012-09-19 Balazs Ankes b...@inf.u-szeged.hu + +[Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails +https://bugs.webkit.org/show_bug.cgi?id=97084 + +Unreviewed gardeing. + +* platform/qt/Skipped: + 2012-09-19 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r128976. Modified: trunk/LayoutTests/platform/qt/Skipped (128980 => 128981) --- trunk/LayoutTests/platform/qt/Skipped 2012-09-19 09:10:33 UTC (rev 128980) +++ trunk/LayoutTests/platform/qt/Skipped 2012-09-19 09:39:17 UTC (rev 128981) @@ -2803,3 +2803,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=96931 http/tests/inspector/network/network-xhr-replay.html +# [Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails +# https://bugs.webkit.org/show_bug.cgi?id=97084 +inspector/extensions/extensions-panel.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127561] trunk/Source
Title: [127561] trunk/Source Revision 127561 Author rga...@webkit.org Date 2012-09-05 00:51:46 -0700 (Wed, 05 Sep 2012) Log Message DFG JIT doesn't work properly on ARM hardfp https://bugs.webkit.org/show_bug.cgi?id=95684 Reviewed by Filip Pizlo. Add hardfp support to DFG JIT. The patch is created with the help of Zoltan Herczeg. Source/_javascript_Core: * dfg/DFGCCallHelpers.h: (CCallHelpers): (JSC::DFG::CCallHelpers::setupArguments): * dfg/DFGFPRInfo.h: (FPRInfo): * dfg/DFGSpeculativeJIT.h: (SpeculativeJIT): (JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult): (JSC::DFG::SpeculativeJIT::appendCallSetResult): Source/WTF: * wtf/Platform.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGCCallHelpers.h trunk/Source/_javascript_Core/dfg/DFGFPRInfo.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (127560 => 127561) --- trunk/Source/_javascript_Core/ChangeLog 2012-09-05 07:22:42 UTC (rev 127560) +++ trunk/Source/_javascript_Core/ChangeLog 2012-09-05 07:51:46 UTC (rev 127561) @@ -1,3 +1,23 @@ +2012-09-05 Gabor Rapcsanyi rga...@webkit.org + +DFG JIT doesn't work properly on ARM hardfp +https://bugs.webkit.org/show_bug.cgi?id=95684 + +Reviewed by Filip Pizlo. + +Add hardfp support to DFG JIT. The patch is created with the +help of Zoltan Herczeg. + +* dfg/DFGCCallHelpers.h: +(CCallHelpers): +(JSC::DFG::CCallHelpers::setupArguments): +* dfg/DFGFPRInfo.h: +(FPRInfo): +* dfg/DFGSpeculativeJIT.h: +(SpeculativeJIT): +(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult): +(JSC::DFG::SpeculativeJIT::appendCallSetResult): + 2012-09-04 Mark Lam mark@apple.com Allow the YarrJIT to use the assembler even when useJIT() is false. Modified: trunk/Source/_javascript_Core/dfg/DFGCCallHelpers.h (127560 => 127561) --- trunk/Source/_javascript_Core/dfg/DFGCCallHelpers.h 2012-09-05 07:22:42 UTC (rev 127560) +++ trunk/Source/_javascript_Core/dfg/DFGCCallHelpers.h 2012-09-05 07:51:46 UTC (rev 127561) @@ -456,8 +456,30 @@ setupTwoStubArgsFPRInfo::argumentFPR0, FPRInfo::argumentFPR1(arg1, arg2); } #elif CPU(ARM) +#if CPU(ARM_HARDFP) ALWAYS_INLINE void setupArguments(FPRReg arg1) { +moveDouble(arg1, FPRInfo::argumentFPR0); +} + +ALWAYS_INLINE void setupArguments(FPRReg arg1, FPRReg arg2) +{ +if (arg2 != FPRInfo::argumentFPR0) { +moveDouble(arg1, FPRInfo::argumentFPR0); +moveDouble(arg2, FPRInfo::argumentFPR1); +} else if (arg1 != FPRInfo::argumentFPR1) { +moveDouble(arg2, FPRInfo::argumentFPR1); +moveDouble(arg1, FPRInfo::argumentFPR0); +} else { +// Swap arg1, arg2. +moveDouble(FPRInfo::argumentFPR0, ARMRegisters::d2); +moveDouble(FPRInfo::argumentFPR1, FPRInfo::argumentFPR0); +moveDouble(ARMRegisters::d2, FPRInfo::argumentFPR1); +} +} +#else +ALWAYS_INLINE void setupArguments(FPRReg arg1) +{ assembler().vmov(GPRInfo::argumentGPR0, GPRInfo::argumentGPR1, arg1); } @@ -466,6 +488,7 @@ assembler().vmov(GPRInfo::argumentGPR0, GPRInfo::argumentGPR1, arg1); assembler().vmov(GPRInfo::argumentGPR2, GPRInfo::argumentGPR3, arg2); } +#endif // CPU(ARM_HARDFP) #else #error DFG JIT not supported on this platform. #endif Modified: trunk/Source/_javascript_Core/dfg/DFGFPRInfo.h (127560 => 127561) --- trunk/Source/_javascript_Core/dfg/DFGFPRInfo.h 2012-09-05 07:22:42 UTC (rev 127560) +++ trunk/Source/_javascript_Core/dfg/DFGFPRInfo.h 2012-09-05 07:51:46 UTC (rev 127561) @@ -122,6 +122,11 @@ // we'll return in d0 for simplicity. static const FPRReg returnValueFPR = ARMRegisters::d0; // fpRegT0 +#if CPU(ARM_HARDFP) +static const FPRReg argumentFPR0 = ARMRegisters::d0; // fpRegT0 +static const FPRReg argumentFPR1 = ARMRegisters::d1; // fpRegT1 +#endif + // FPRReg mapping is direct, the machine regsiter numbers can // be used directly as indices into the FPR RegisterBank. COMPILE_ASSERT(ARMRegisters::d0 == 0, d0_is_0); Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (127560 => 127561) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2012-09-05 07:22:42 UTC (rev 127560) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2012-09-05 07:51:46 UTC (rev 127561) @@ -1835,9 +1835,23 @@ return call; } #elif CPU(ARM) +#if CPU(ARM_HARDFP) JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr function, FPRReg result) { JITCompiler::Call call = appendCallWithExceptionCheck(function); +m_jit.moveDouble(result, FPRInfo::argumentFPR0); +return call; +} +
[webkit-changes] [126876] trunk/Tools
Title: [126876] trunk/Tools Revision 126876 Author rga...@webkit.org Date 2012-08-28 07:51:43 -0700 (Tue, 28 Aug 2012) Log Message [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT https://bugs.webkit.org/show_bug.cgi?id=95194 Reviewed by Simon Hausmann. * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort.setup_environ_for_server): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py Diff Modified: trunk/Tools/ChangeLog (126875 => 126876) --- trunk/Tools/ChangeLog 2012-08-28 14:41:34 UTC (rev 126875) +++ trunk/Tools/ChangeLog 2012-08-28 14:51:43 UTC (rev 126876) @@ -1,3 +1,13 @@ +2012-08-28 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT +https://bugs.webkit.org/show_bug.cgi?id=95194 + +Reviewed by Simon Hausmann. + +* Scripts/webkitpy/layout_tests/port/qt.py: +(QtPort.setup_environ_for_server): + 2012-08-28 Andras Becsi andras.be...@nokia.com [watchlist] Unreviewed, subscribe to Qt bugs. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (126875 => 126876) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2012-08-28 14:41:34 UTC (rev 126875) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2012-08-28 14:51:43 UTC (rev 126876) @@ -161,6 +161,7 @@ self._copy_value_from_environ_if_set(clean_env, 'QT_WEBKIT_LOG') self._copy_value_from_environ_if_set(clean_env, 'DISABLE_NI_WARNING') self._copy_value_from_environ_if_set(clean_env, 'QT_WEBKIT_PAUSE_UI_PROCESS') +self._copy_value_from_environ_if_set(clean_env, 'QT_QPA_PLATFORM_PLUGIN_PATH') return clean_env # FIXME: We should find a way to share this implmentation with Gtk, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122818] trunk/Source/JavaScriptCore
Title: [122818] trunk/Source/_javascript_Core Revision 122818 Author rga...@webkit.org Date 2012-07-17 00:59:57 -0700 (Tue, 17 Jul 2012) Log Message Unreviewed buildfix from Zoltan Herczeg after 122768. * dfg/DFGCCallHelpers.h: (JSC::DFG::CCallHelpers::setupArgumentsWithExecState): (CCallHelpers): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGCCallHelpers.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (122817 => 122818) --- trunk/Source/_javascript_Core/ChangeLog 2012-07-17 07:52:29 UTC (rev 122817) +++ trunk/Source/_javascript_Core/ChangeLog 2012-07-17 07:59:57 UTC (rev 122818) @@ -1,3 +1,11 @@ +2012-07-17 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed buildfix from Zoltan Herczeg after 122768. + +* dfg/DFGCCallHelpers.h: +(JSC::DFG::CCallHelpers::setupArgumentsWithExecState): +(CCallHelpers): + 2012-07-17 David Barr davidb...@chromium.org Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag Modified: trunk/Source/_javascript_Core/dfg/DFGCCallHelpers.h (122817 => 122818) --- trunk/Source/_javascript_Core/dfg/DFGCCallHelpers.h 2012-07-17 07:52:29 UTC (rev 122817) +++ trunk/Source/_javascript_Core/dfg/DFGCCallHelpers.h 2012-07-17 07:59:57 UTC (rev 122818) @@ -591,6 +591,14 @@ move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0); } +ALWAYS_INLINE void setupArgumentsWithExecState(GPRReg arg1, TrustedImmPtr arg2, TrustedImm32 arg3) +{ +move(arg1, GPRInfo::argumentGPR1); +move(arg2, GPRInfo::argumentGPR2); +move(arg3, GPRInfo::argumentGPR3); +move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0); +} + ALWAYS_INLINE void setupArgumentsWithExecState(GPRReg arg1, TrustedImmPtr arg2, TrustedImmPtr arg3) { move(arg1, GPRInfo::argumentGPR1); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122729] trunk/Source/JavaScriptCore
Title: [122729] trunk/Source/_javascript_Core Revision 122729 Author rga...@webkit.org Date 2012-07-16 08:05:57 -0700 (Mon, 16 Jul 2012) Log Message Unreviewed buildfix from Zoltan Herczeg after r122677. Implement missing add32 function to MacroAssemblerARM. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::add32): (MacroAssemblerARM): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (122728 => 122729) --- trunk/Source/_javascript_Core/ChangeLog 2012-07-16 14:56:19 UTC (rev 122728) +++ trunk/Source/_javascript_Core/ChangeLog 2012-07-16 15:05:57 UTC (rev 122729) @@ -1,3 +1,12 @@ +2012-07-16 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed buildfix from Zoltan Herczeg after r122677. +Implement missing add32 function to MacroAssemblerARM. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::add32): +(MacroAssemblerARM): + 2012-07-14 Filip Pizlo fpi...@apple.com DFG PutByVal opcodes should accept more than 3 operands Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (122728 => 122729) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2012-07-16 14:56:19 UTC (rev 122728) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2012-07-16 15:05:57 UTC (rev 122729) @@ -107,6 +107,13 @@ m_assembler.adds_r(dest, dest, m_assembler.getImm(imm.m_value, ARMRegisters::S0)); } +void add32(AbsoluteAddress src, RegisterID dest) +{ +move(TrustedImmPtr(address.m_ptr), ARMRegisters::S1); +m_assembler.dtr_u(ARMAssembler::LoadUint32, ARMRegisters::S1, ARMRegisters::S1, 0); +add32(ARMRegisters::S1, dest); +} + void add32(Address src, RegisterID dest) { load32(src, ARMRegisters::S1); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122734] trunk/Source/JavaScriptCore
Title: [122734] trunk/Source/_javascript_Core Revision 122734 Author rga...@webkit.org Date 2012-07-16 09:16:03 -0700 (Mon, 16 Jul 2012) Log Message Unreviewed buildfix after r122729. Typo fix. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::add32): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (122733 => 122734) --- trunk/Source/_javascript_Core/ChangeLog 2012-07-16 15:49:54 UTC (rev 122733) +++ trunk/Source/_javascript_Core/ChangeLog 2012-07-16 16:16:03 UTC (rev 122734) @@ -1,5 +1,12 @@ 2012-07-16 Gabor Rapcsanyi rga...@webkit.org +Unreviewed buildfix after r122729. Typo fix. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::add32): + +2012-07-16 Gabor Rapcsanyi rga...@webkit.org + Unreviewed buildfix from Zoltan Herczeg after r122677. Implement missing add32 function to MacroAssemblerARM. Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (122733 => 122734) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2012-07-16 15:49:54 UTC (rev 122733) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2012-07-16 16:16:03 UTC (rev 122734) @@ -109,7 +109,7 @@ void add32(AbsoluteAddress src, RegisterID dest) { -move(TrustedImmPtr(address.m_ptr), ARMRegisters::S1); +move(TrustedImmPtr(src.m_ptr), ARMRegisters::S1); m_assembler.dtr_u(ARMAssembler::LoadUint32, ARMRegisters::S1, ARMRegisters::S1, 0); add32(ARMRegisters::S1, dest); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122579] trunk/LayoutTests
Title: [122579] trunk/LayoutTests Revision 122579 Author rga...@webkit.org Date 2012-07-13 08:05:00 -0700 (Fri, 13 Jul 2012) Log Message [Qt] Unreviewed gardening after r122528. Skipped some new tests. https://bugs.webkit.org/show_bug.cgi?id=91218 Patch by Szilard Ledan szle...@inf.u-szeged.hu on 2012-07-13 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (122578 => 122579) --- trunk/LayoutTests/ChangeLog 2012-07-13 15:02:22 UTC (rev 122578) +++ trunk/LayoutTests/ChangeLog 2012-07-13 15:05:00 UTC (rev 122579) @@ -1,3 +1,10 @@ +2012-07-13 Szilard Ledan szle...@inf.u-szeged.hu + +[Qt] Unreviewed gardening after r122528. Skipped some new tests. +https://bugs.webkit.org/show_bug.cgi?id=91218 + +* platform/qt/Skipped: + 2012-07-13 Simon Pena sp...@igalia.com [GTK] Gardening: new baseline after r122550 and rebaseline after r122556 Modified: trunk/LayoutTests/platform/qt/Skipped (122578 => 122579) --- trunk/LayoutTests/platform/qt/Skipped 2012-07-13 15:02:22 UTC (rev 122578) +++ trunk/LayoutTests/platform/qt/Skipped 2012-07-13 15:05:00 UTC (rev 122579) @@ -696,6 +696,13 @@ # https://bugs.webkit.org/show_bug.cgi?id=87208 http/tests/cookies/js-get-and-set-http-only-cookie.html +# [Qt] new tests introduced in r122528 fail +# https://bugs.webkit.org/show_bug.cgi?id=91218 +http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html +http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html +http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object.html +http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect.html + # === # # Failing xmlhttprequest tests # # === # ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122582] trunk/Source/WebCore
Title: [122582] trunk/Source/WebCore Revision 122582 Author rga...@webkit.org Date 2012-07-13 08:31:06 -0700 (Fri, 13 Jul 2012) Log Message Optimizing blend filter to ARM-NEON with intrinsics https://bugs.webkit.org/show_bug.cgi?id=90949 Reviewed by Zoltan Herczeg. The feBlend SVG filter modes can be greatly fasten up with ARM-NEON since we are able to calculate with 2 pixels (8 channels) at the same time. The code is written with NEON intrinsics and it doesn't affect the general - it has the same behaviour as the original algorithm. With this NEON optimization the calculation is ~4.5 times faster for each mode. Existing tests cover this issue. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::platformApplyGeneric): (WebCore): (WebCore::FEBlend::platformApplySoftware): * platform/graphics/filters/FEBlend.h: (FEBlend): * platform/graphics/filters/arm/FEBlendNEON.h: Added. (WebCore): (FEBlendUtilitiesNEON): (WebCore::FEBlendUtilitiesNEON::div255): integer divison with 255 (WebCore::FEBlendUtilitiesNEON::normal): calculate normal mode blending for two pixels (WebCore::FEBlendUtilitiesNEON::multiply): calculate multiply mode blending for two pixels (WebCore::FEBlendUtilitiesNEON::screen): calculate screen mode blending for two pixels (WebCore::FEBlendUtilitiesNEON::darken): calculate darken mode blending for two pixels (WebCore::FEBlendUtilitiesNEON::lighten): calculate lighten mode blending for two pixels (WebCore::FEBlend::platformApplyNEON): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/filters/FEBlend.cpp trunk/Source/WebCore/platform/graphics/filters/FEBlend.h Added Paths trunk/Source/WebCore/platform/graphics/filters/arm/FEBlendNEON.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (122581 => 122582) --- trunk/Source/WebCore/CMakeLists.txt 2012-07-13 15:15:40 UTC (rev 122581) +++ trunk/Source/WebCore/CMakeLists.txt 2012-07-13 15:31:06 UTC (rev 122582) @@ -1246,6 +1246,7 @@ platform/graphics/filters/SourceGraphic.cpp platform/graphics/filters/arm/NEONHelpers.h +platform/graphics/filters/arm/FEBlendNEON.h platform/graphics/filters/arm/FECompositeArithmeticNEON.h platform/graphics/filters/arm/FEGaussianBlurNEON.h platform/graphics/filters/arm/FELightingNEON.cpp Modified: trunk/Source/WebCore/ChangeLog (122581 => 122582) --- trunk/Source/WebCore/ChangeLog 2012-07-13 15:15:40 UTC (rev 122581) +++ trunk/Source/WebCore/ChangeLog 2012-07-13 15:31:06 UTC (rev 122582) @@ -1,3 +1,41 @@ +2012-07-13 Gabor Rapcsanyi rga...@webkit.org + +Optimizing blend filter to ARM-NEON with intrinsics +https://bugs.webkit.org/show_bug.cgi?id=90949 + +Reviewed by Zoltan Herczeg. + +The feBlend SVG filter modes can be greatly fasten up with ARM-NEON since +we are able to calculate with 2 pixels (8 channels) at the same time. +The code is written with NEON intrinsics and it doesn't affect the +general - it has the same behaviour as the original algorithm. +With this NEON optimization the calculation is ~4.5 times faster for each mode. + +Existing tests cover this issue. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/filters/FEBlend.cpp: +(WebCore::FEBlend::platformApplyGeneric): +(WebCore): +(WebCore::FEBlend::platformApplySoftware): +* platform/graphics/filters/FEBlend.h: +(FEBlend): +* platform/graphics/filters/arm/FEBlendNEON.h: Added. +(WebCore): +(FEBlendUtilitiesNEON): +(WebCore::FEBlendUtilitiesNEON::div255): integer divison with 255 +(WebCore::FEBlendUtilitiesNEON::normal): calculate normal mode blending for two pixels +(WebCore::FEBlendUtilitiesNEON::multiply): calculate multiply mode blending for two pixels +(WebCore::FEBlendUtilitiesNEON::screen): calculate screen mode blending for two pixels +(WebCore::FEBlendUtilitiesNEON::darken): calculate darken mode blending for two pixels +(WebCore::FEBlendUtilitiesNEON::lighten): calculate lighten mode blending for two pixels +(WebCore::FEBlend::platformApplyNEON): + 2012-07-13 Ilya Tikhonovsky loi...@chromium.org Web Inspector: native memory instrumentation: extract instrumentation methods into MemoryClassInfo Modified: trunk/Source/WebCore/GNUmakefile.list.am (122581 => 122582) ---
[webkit-changes] [121951] trunk/Source/WebCore
Title: [121951] trunk/Source/WebCore Revision 121951 Author rga...@webkit.org Date 2012-07-06 03:05:07 -0700 (Fri, 06 Jul 2012) Log Message Fixing defines for NEON intrinsics. https://bugs.webkit.org/show_bug.cgi?id=90666 Reviewed by Zoltan Herczeg. Existing tests cover this issue. * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyGeneric): * platform/graphics/filters/arm/FEGaussianBlurNEON.h: * platform/graphics/filters/arm/NEONHelpers.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h trunk/Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h Diff Modified: trunk/Source/WebCore/ChangeLog (121950 => 121951) --- trunk/Source/WebCore/ChangeLog 2012-07-06 10:04:56 UTC (rev 121950) +++ trunk/Source/WebCore/ChangeLog 2012-07-06 10:05:07 UTC (rev 121951) @@ -1,3 +1,17 @@ +2012-07-06 Gabor Rapcsanyi rga...@webkit.org + +Fixing defines for NEON intrinsics. +https://bugs.webkit.org/show_bug.cgi?id=90666 + +Reviewed by Zoltan Herczeg. + +Existing tests cover this issue. + +* platform/graphics/filters/FEGaussianBlur.cpp: +(WebCore::FEGaussianBlur::platformApplyGeneric): +* platform/graphics/filters/arm/FEGaussianBlurNEON.h: +* platform/graphics/filters/arm/NEONHelpers.h: + 2012-07-05 Vsevolod Vlasov vse...@chromium.org Web Inspector: Workspace should dispatch WorkspaceReset event on navigation. Modified: trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp (121950 => 121951) --- trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp 2012-07-06 10:04:56 UTC (rev 121950) +++ trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp 2012-07-06 10:05:07 UTC (rev 121951) @@ -120,7 +120,7 @@ for (int i = 0; i 3; ++i) { if (kernelSizeX) { kernelPosition(i, kernelSizeX, dxLeft, dxRight); -#if CPU(ARM_NEON) COMPILER(GCC) +#if HAVE(ARM_NEON_INTRINSICS) if (!isAlphaImage()) boxBlurNEON(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride, paintSize.width(), paintSize.height()); else @@ -133,7 +133,7 @@ if (kernelSizeY) { kernelPosition(i, kernelSizeY, dyLeft, dyRight); -#if CPU(ARM_NEON) COMPILER(GCC) +#if HAVE(ARM_NEON_INTRINSICS) if (!isAlphaImage()) boxBlurNEON(src, dst, kernelSizeY, dyLeft, dyRight, stride, 4, paintSize.height(), paintSize.width()); else Modified: trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h (121950 => 121951) --- trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h 2012-07-06 10:04:56 UTC (rev 121950) +++ trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h 2012-07-06 10:05:07 UTC (rev 121951) @@ -29,7 +29,7 @@ #include wtf/Platform.h -#if CPU(ARM_NEON) COMPILER(GCC) +#if ENABLE(FILTERS) HAVE(ARM_NEON_INTRINSICS) #include FEGaussianBlur.h #include NEONHelpers.h @@ -74,6 +74,6 @@ } // namespace WebCore -#endif // CPU(ARM_NEON) COMPILER(GCC) +#endif // ENABLE(FILTERS) HAVE(ARM_NEON_INTRINSICS) #endif // FEGaussianBlurNEON_h Modified: trunk/Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h (121950 => 121951) --- trunk/Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h 2012-07-06 10:04:56 UTC (rev 121950) +++ trunk/Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h 2012-07-06 10:05:07 UTC (rev 121951) @@ -29,7 +29,7 @@ #include wtf/Platform.h -#if CPU(ARM_NEON) COMPILER(GCC) +#if ENABLE(FILTERS) HAVE(ARM_NEON_INTRINSICS) #include arm_neon.h @@ -51,6 +51,6 @@ } // namespace WebCore -#endif // CPU(ARM_NEON) COMPILER(GCC) +#endif // ENABLE(FILTERS) HAVE(ARM_NEON_INTRINSICS) #endif // NEONHelpers_h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121900] trunk/Source/WebCore
Title: [121900] trunk/Source/WebCore Revision 121900 Author rga...@webkit.org Date 2012-07-05 05:31:56 -0700 (Thu, 05 Jul 2012) Log Message NEON intrinsics should be used with gaussian blur filter https://bugs.webkit.org/show_bug.cgi?id=90166 Reviewed by Zoltan Herczeg. Rewrite inline assembly to NEON intrinsics for better portabilty and readibility. Remove unnecessary FEGaussianBlurNEON.cpp and add NEONHelpers.h to the project which will contains the shared NEON code of the filters. Existing tests cover this issue. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyGeneric): (WebCore::FEGaussianBlur::platformApplyWorker): * platform/graphics/filters/FEGaussianBlur.h: (FEGaussianBlur): * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Removed. * platform/graphics/filters/arm/FEGaussianBlurNEON.h: (WebCore::boxBlurNEON): * platform/graphics/filters/arm/NEONHelpers.h: Added. (WebCore): (WebCore::loadRGBA8AsFloat): (WebCore::storeFloatAsRGBA8): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h Added Paths trunk/Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h Removed Paths trunk/Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (121899 => 121900) --- trunk/Source/WebCore/CMakeLists.txt 2012-07-05 11:21:47 UTC (rev 121899) +++ trunk/Source/WebCore/CMakeLists.txt 2012-07-05 12:31:56 UTC (rev 121900) @@ -1239,8 +1239,8 @@ platform/graphics/filters/SourceAlpha.cpp platform/graphics/filters/SourceGraphic.cpp +platform/graphics/filters/arm/NEONHelpers.h platform/graphics/filters/arm/FECompositeArithmeticNEON.h -platform/graphics/filters/arm/FEGaussianBlurNEON.cpp platform/graphics/filters/arm/FEGaussianBlurNEON.h platform/graphics/filters/arm/FELightingNEON.cpp platform/graphics/filters/arm/FELightingNEON.h Modified: trunk/Source/WebCore/ChangeLog (121899 => 121900) --- trunk/Source/WebCore/ChangeLog 2012-07-05 11:21:47 UTC (rev 121899) +++ trunk/Source/WebCore/ChangeLog 2012-07-05 12:31:56 UTC (rev 121900) @@ -1,3 +1,36 @@ +2012-07-05 Gabor Rapcsanyi rga...@webkit.org + +NEON intrinsics should be used with gaussian blur filter +https://bugs.webkit.org/show_bug.cgi?id=90166 + +Reviewed by Zoltan Herczeg. + +Rewrite inline assembly to NEON intrinsics for better portabilty +and readibility. Remove unnecessary FEGaussianBlurNEON.cpp and add +NEONHelpers.h to the project which will contains the shared +NEON code of the filters. + +Existing tests cover this issue. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/filters/FEGaussianBlur.cpp: +(WebCore::FEGaussianBlur::platformApplyGeneric): +(WebCore::FEGaussianBlur::platformApplyWorker): +* platform/graphics/filters/FEGaussianBlur.h: +(FEGaussianBlur): +* platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Removed. +* platform/graphics/filters/arm/FEGaussianBlurNEON.h: +(WebCore::boxBlurNEON): +* platform/graphics/filters/arm/NEONHelpers.h: Added. +(WebCore): +(WebCore::loadRGBA8AsFloat): +(WebCore::storeFloatAsRGBA8): + 2012-07-05 Sam D dsam2...@gmail.com Web Inspector: Having a Scroll into view for nodes through web inspector. Modified: trunk/Source/WebCore/GNUmakefile.list.am (121899 => 121900) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-07-05 11:21:47 UTC (rev 121899) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-07-05 12:31:56 UTC (rev 121900) @@ -3284,8 +3284,8 @@ Source/WebCore/platform/graphics/filters/SourceGraphic.h \ Source/WebCore/platform/graphics/filters/SpotLightSource.cpp \ Source/WebCore/platform/graphics/filters/SpotLightSource.h \ + Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h \ Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h \ - Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.cpp \ Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h \ Source/WebCore/platform/graphics/filters/arm/FELightingNEON.cpp \
[webkit-changes] [109206] trunk/Tools
Title: [109206] trunk/Tools Revision 109206 Author rga...@webkit.org Date 2012-02-29 04:33:16 -0800 (Wed, 29 Feb 2012) Log Message [GTK] Small fix for cross compilation to not generate gtkdoc. Rubber-stamped by Csaba Osztrogonác. * Scripts/webkitdirs.pm: (isCrossCompilation): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitdirs.pm Diff Modified: trunk/Tools/ChangeLog (109205 => 109206) --- trunk/Tools/ChangeLog 2012-02-29 08:58:22 UTC (rev 109205) +++ trunk/Tools/ChangeLog 2012-02-29 12:33:16 UTC (rev 109206) @@ -1,3 +1,12 @@ +2012-02-29 Gabor Rapcsanyi rga...@webkit.org + +[GTK] Small fix for cross compilation to not generate gtkdoc. + +Rubber-stamped by Csaba Osztrogonác. + +* Scripts/webkitdirs.pm: +(isCrossCompilation): + 2012-02-28 Lucas Forschler lforsch...@apple.com Fix a typo in config.json Modified: trunk/Tools/Scripts/webkitdirs.pm (109205 => 109206) --- trunk/Tools/Scripts/webkitdirs.pm 2012-02-29 08:58:22 UTC (rev 109205) +++ trunk/Tools/Scripts/webkitdirs.pm 2012-02-29 12:33:16 UTC (rev 109206) @@ -1264,7 +1264,8 @@ sub isCrossCompilation() { - my $compiler = unless $ENV{'CC'}; + my $compiler = ; + $compiler = $ENV{'CC'} if (defined($ENV{'CC'})); if ($compiler =~ /gcc/) { my $compiler_options = `$compiler -v 21`; my @host = $compiler_options =~ m/--host=(.*?)\s/; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108513] trunk/Tools
Title: [108513] trunk/Tools Revision 108513 Author rga...@webkit.org Date 2012-02-22 10:10:40 -0800 (Wed, 22 Feb 2012) Log Message build-webkit should use environment variable at number of CPU detection on all platform https://bugs.webkit.org/show_bug.cgi?id=79227 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (determineNumberOfCPUs): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitdirs.pm Diff Modified: trunk/Tools/ChangeLog (108512 => 108513) --- trunk/Tools/ChangeLog 2012-02-22 17:44:16 UTC (rev 108512) +++ trunk/Tools/ChangeLog 2012-02-22 18:10:40 UTC (rev 108513) @@ -1,3 +1,14 @@ +2012-02-22 Gabor Rapcsanyi rga...@webkit.org + +build-webkit should use environment variable at number of CPU +detection on all platform +https://bugs.webkit.org/show_bug.cgi?id=79227 + +Reviewed by Martin Robinson. + +* Scripts/webkitdirs.pm: +(determineNumberOfCPUs): + 2012-02-22 Mihnea Ovidenie mih...@adobe.com [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail Modified: trunk/Tools/Scripts/webkitdirs.pm (108512 => 108513) --- trunk/Tools/Scripts/webkitdirs.pm 2012-02-22 17:44:16 UTC (rev 108512) +++ trunk/Tools/Scripts/webkitdirs.pm 2012-02-22 18:10:40 UTC (rev 108513) @@ -326,7 +326,9 @@ sub determineNumberOfCPUs { return if defined $numberOfCPUs; -if (isLinux()) { +if (defined($ENV{NUMBER_OF_PROCESSORS})) { +$numberOfCPUs = $ENV{NUMBER_OF_PROCESSORS}; +} elsif (isLinux()) { # First try the nproc utility, if it exists. If we get no # results fall back to just interpretting /proc directly. chomp($numberOfCPUs = `nproc 2 /dev/null`); @@ -334,12 +336,8 @@ $numberOfCPUs = (grep /processor/, `cat /proc/cpuinfo`); } } elsif (isWindows() || isCygwin()) { -if (defined($ENV{NUMBER_OF_PROCESSORS})) { -$numberOfCPUs = $ENV{NUMBER_OF_PROCESSORS}; -} else { -# Assumes cygwin -$numberOfCPUs = `ls /proc/registry/HKEY_LOCAL_MACHINE/HARDWARE/DESCRIPTION/System/CentralProcessor | wc -w`; -} +# Assumes cygwin +$numberOfCPUs = `ls /proc/registry/HKEY_LOCAL_MACHINE/HARDWARE/DESCRIPTION/System/CentralProcessor | wc -w`; } elsif (isDarwin()) { chomp($numberOfCPUs = `sysctl -n hw.ncpu`); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106369] trunk/Tools
Title: [106369] trunk/Tools Revision 106369 Author rga...@webkit.org Date 2012-01-31 11:00:21 -0800 (Tue, 31 Jan 2012) Log Message [GTK] build-webkit warning. https://bugs.webkit.org/show_bug.cgi?id=77411 Reviewed by Philippe Normand. * Scripts/webkitdirs.pm: (isCrossCompilation): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitdirs.pm Diff Modified: trunk/Tools/ChangeLog (106368 => 106369) --- trunk/Tools/ChangeLog 2012-01-31 18:06:23 UTC (rev 106368) +++ trunk/Tools/ChangeLog 2012-01-31 19:00:21 UTC (rev 106369) @@ -1,3 +1,13 @@ +2012-01-31 Gabor Rapcsanyi rga...@webkit.org + +[GTK] build-webkit warning. +https://bugs.webkit.org/show_bug.cgi?id=77411 + +Reviewed by Philippe Normand. + +* Scripts/webkitdirs.pm: +(isCrossCompilation): + 2012-01-31 Dan Bernstein m...@apple.com When generating derived sources, use the same compiler that is used to compile WebKitTestRunner. Modified: trunk/Tools/Scripts/webkitdirs.pm (106368 => 106369) --- trunk/Tools/Scripts/webkitdirs.pm 2012-01-31 18:06:23 UTC (rev 106368) +++ trunk/Tools/Scripts/webkitdirs.pm 2012-01-31 19:00:21 UTC (rev 106369) @@ -1266,7 +1266,7 @@ sub isCrossCompilation() { - my $compiler = $ENV{'CC'}; + my $compiler = unless $ENV{'CC'}; if ($compiler =~ /gcc/) { my $compiler_options = `$compiler -v 21`; my @host = $compiler_options =~ m/--host=(.*?)\s/; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105974] trunk/Tools
Title: [105974] trunk/Tools Revision 105974 Author rga...@webkit.org Date 2012-01-26 01:01:21 -0800 (Thu, 26 Jan 2012) Log Message [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc https://bugs.webkit.org/show_bug.cgi?id=76138 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (isCrossCompilation): (buildAutotoolsProject): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitdirs.pm Diff Modified: trunk/Tools/ChangeLog (105973 => 105974) --- trunk/Tools/ChangeLog 2012-01-26 08:56:21 UTC (rev 105973) +++ trunk/Tools/ChangeLog 2012-01-26 09:01:21 UTC (rev 105974) @@ -1,3 +1,14 @@ +2012-01-26 Gabor Rapcsanyi rga...@webkit.org + +[GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc +https://bugs.webkit.org/show_bug.cgi?id=76138 + +Reviewed by Martin Robinson. + +* Scripts/webkitdirs.pm: +(isCrossCompilation): +(buildAutotoolsProject): + 2012-01-25 Adam Barth aba...@webkit.org Kentaro is a reviewer now. Yay! Modified: trunk/Tools/Scripts/webkitdirs.pm (105973 => 105974) --- trunk/Tools/Scripts/webkitdirs.pm 2012-01-26 08:56:21 UTC (rev 105973) +++ trunk/Tools/Scripts/webkitdirs.pm 2012-01-26 09:01:21 UTC (rev 105974) @@ -1232,6 +1232,19 @@ return $Config{archname} =~ /^arm-/; } +sub isCrossCompilation() +{ + my $compiler = $ENV{'CC'}; + if ($compiler =~ /gcc/) { + my $compiler_options = `$compiler -v 21`; + my @host = $compiler_options =~ m/--host=(.*?)\s/; + my @target = $compiler_options =~ m/--target=(.*?)\s/; + + return ($host[0] ne $target[0] ne $host[0] ne $target[0]); + } + return 0; +} + sub isAppleWebKit() { return !(isQt() or isGtk() or isWx() or isChromium() or isEfl() or isWinCE() or isBlackBerry()); @@ -1907,7 +1920,7 @@ chdir .. or die; -if ($project eq 'WebKit') { +if ($project eq 'WebKit' !isCrossCompilation()) { my @docGenerationOptions = ($runWithJhbuild, $gtkScriptsPath/generate-gtkdoc, --skip-html); if ($debug) { push(@docGenerationOptions, --debug); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105889] trunk/LayoutTests
Title: [105889] trunk/LayoutTests Revision 105889 Author rga...@webkit.org Date 2012-01-25 09:56:54 -0800 (Wed, 25 Jan 2012) Log Message Unreviewed Qt gardening. Temporally skip failing tests after r105878. Patch by Balazs Kelemen kbal...@webkit.org on 2012-01-25 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (105888 => 105889) --- trunk/LayoutTests/ChangeLog 2012-01-25 17:51:20 UTC (rev 105888) +++ trunk/LayoutTests/ChangeLog 2012-01-25 17:56:54 UTC (rev 105889) @@ -1,3 +1,11 @@ +2012-01-25 Balazs Kelemen kbal...@webkit.org + +Unreviewed Qt gardening. + +Temporally skip failing tests after r105878. + +* platform/qt/Skipped: + 2012-01-25 Levi Weintraub le...@chromium.org Unreviewed. Adding platform expectations after 105879 Modified: trunk/LayoutTests/platform/qt/Skipped (105888 => 105889) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-25 17:51:20 UTC (rev 105888) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-25 17:56:54 UTC (rev 105889) @@ -2528,3 +2528,10 @@ # [Qt] new test fast/forms/radio/radio-group.html failing after r104668 # https://bugs.webkit.org/show_bug.cgi?id=76051 fast/forms/radio/radio-group.html + +# Linecaps wrong for zero length lines +# https://bugs.webkit.org/show_bug.cgi?id=71820 +# Temporarily skip these tests after r105878 until necessary functionality lands and new results added. +svg/W3C-SVG-1.1-SE/painting-control-04-f.svg +svg/custom/zero-path-square-cap-rendering.svg +svg/stroke/zero-length-arc-linecaps-rendering.svg ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105265] trunk/LayoutTests
Title: [105265] trunk/LayoutTests Revision 105265 Author rga...@webkit.org Date 2012-01-18 05:15:09 -0800 (Wed, 18 Jan 2012) Log Message [Qt] Update some SVG expected after r105247. Unreviewed. * platform/qt/svg/custom/linking-a-03-b-all-expected.png: * platform/qt/svg/custom/linking-a-03-b-all-expected.txt: * platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png: * platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt: * platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png: * platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt: * platform/qt/svg/custom/mouse-move-on-svg-container-expected.png: * platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt: * platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png: * platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: * platform/qt/svg/custom/mouse-move-on-svg-root-expected.png: * platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt: * platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png: * platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: * platform/qt/svg/custom/pointer-events-image-css-transform-expected.png: * platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt: * platform/qt/svg/custom/pointer-events-image-expected.png: * platform/qt/svg/custom/pointer-events-image-expected.txt: * platform/qt/svg/custom/pointer-events-text-expected.png: * platform/qt/svg/custom/pointer-events-text-expected.txt: * platform/qt/svg/foreignObject/text-tref-02-b-expected.png: * platform/qt/svg/foreignObject/text-tref-02-b-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/svg/custom/linking-a-03-b-all-expected.png trunk/LayoutTests/platform/qt/svg/custom/linking-a-03-b-all-expected.txt trunk/LayoutTests/platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png trunk/LayoutTests/platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt trunk/LayoutTests/platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png trunk/LayoutTests/platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt trunk/LayoutTests/platform/qt/svg/custom/mouse-move-on-svg-container-expected.png trunk/LayoutTests/platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt trunk/LayoutTests/platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png trunk/LayoutTests/platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt trunk/LayoutTests/platform/qt/svg/custom/mouse-move-on-svg-root-expected.png trunk/LayoutTests/platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt trunk/LayoutTests/platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png trunk/LayoutTests/platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt trunk/LayoutTests/platform/qt/svg/custom/pointer-events-image-css-transform-expected.png trunk/LayoutTests/platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt trunk/LayoutTests/platform/qt/svg/custom/pointer-events-image-expected.png trunk/LayoutTests/platform/qt/svg/custom/pointer-events-image-expected.txt trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-expected.png trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-expected.txt trunk/LayoutTests/platform/qt/svg/foreignObject/text-tref-02-b-expected.png trunk/LayoutTests/platform/qt/svg/foreignObject/text-tref-02-b-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (105264 => 105265) --- trunk/LayoutTests/ChangeLog 2012-01-18 13:00:55 UTC (rev 105264) +++ trunk/LayoutTests/ChangeLog 2012-01-18 13:15:09 UTC (rev 105265) @@ -1,3 +1,32 @@ +2012-01-18 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Update some SVG expected after r105247. + +Unreviewed. + +* platform/qt/svg/custom/linking-a-03-b-all-expected.png: +* platform/qt/svg/custom/linking-a-03-b-all-expected.txt: +* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png: +* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt: +* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png: +* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt: +* platform/qt/svg/custom/mouse-move-on-svg-container-expected.png: +* platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt: +* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png: +* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: +* platform/qt/svg/custom/mouse-move-on-svg-root-expected.png: +* platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt: +* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png: +* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: +* platform/qt/svg/custom/pointer-events-image-css-transform-expected.png: +
[webkit-changes] [105269] trunk/LayoutTests
Title: [105269] trunk/LayoutTests Revision 105269 Author rga...@webkit.org Date 2012-01-18 05:57:05 -0800 (Wed, 18 Jan 2012) Log Message [Qt] svg/carto.net/frameless-svg-parse-error.html asserting after r105143 https://bugs.webkit.org/show_bug.cgi?id=76534 Reviewed by Csaba Osztrogonác. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (105268 => 105269) --- trunk/LayoutTests/ChangeLog 2012-01-18 13:52:02 UTC (rev 105268) +++ trunk/LayoutTests/ChangeLog 2012-01-18 13:57:05 UTC (rev 105269) @@ -1,3 +1,12 @@ +2012-01-18 Gabor Rapcsanyi rga...@webkit.org + +[Qt] svg/carto.net/frameless-svg-parse-error.html asserting after r105143 +https://bugs.webkit.org/show_bug.cgi?id=76534 + +Reviewed by Csaba Osztrogonác. + +* platform/qt/Skipped: + 2012-01-18 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed gardening after testfonts update. Modified: trunk/LayoutTests/platform/qt/Skipped (105268 => 105269) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-18 13:52:02 UTC (rev 105268) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-18 13:57:05 UTC (rev 105269) @@ -2578,3 +2578,7 @@ # [Qt] REGRESSION(r105090): css3/filters/filtered-compositing-descendant.html fails # https://bugs.webkit.org/show_bug.cgi?id=76432 css3/filters/filtered-compositing-descendant.html + +# [Qt] REGRESSION(r105143): svg/carto.net/frameless-svg-parse-error.html asserting +# https://bugs.webkit.org/show_bug.cgi?id=76534 +svg/carto.net/frameless-svg-parse-error.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105271] trunk/LayoutTests
Title: [105271] trunk/LayoutTests Revision 105271 Author rga...@webkit.org Date 2012-01-18 06:15:06 -0800 (Wed, 18 Jan 2012) Log Message [Qt] Update another SVG expected after r105247. Unreviewed. * platform/qt/svg/custom/pointer-events-text-css-transform-expected.png: * platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.png trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (105270 => 105271) --- trunk/LayoutTests/ChangeLog 2012-01-18 14:15:05 UTC (rev 105270) +++ trunk/LayoutTests/ChangeLog 2012-01-18 14:15:06 UTC (rev 105271) @@ -1,5 +1,14 @@ 2012-01-18 Gabor Rapcsanyi rga...@webkit.org +[Qt] Update another SVG expected after r105247. + +Unreviewed. + +* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png: +* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt: + +2012-01-18 Gabor Rapcsanyi rga...@webkit.org + [Qt] svg/carto.net/frameless-svg-parse-error.html asserting after r105143 https://bugs.webkit.org/show_bug.cgi?id=76534 Modified: trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt (105270 => 105271) --- trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt 2012-01-18 14:15:05 UTC (rev 105270) +++ trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt 2012-01-18 14:15:06 UTC (rev 105271) @@ -519,4 +519,4 @@ RenderSVGText {text} at (504,547) size 33x21 contains 1 chunk(s) RenderSVGInlineText {#text} at (0,0) size 33x21 chunk 1 text run 1 at (504.00,563.00) startOffset 0 endOffset 4 width 33.00: miss -caret: position 18 of child 0 {#text} of child 5 {text} of child 1 {svg} of document +caret: position 0 of child 0 {#text} of child 3 {text} of child 1 {svg} of document ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104942] trunk/Tools
Title: [104942] trunk/Tools Revision 104942 Author rga...@webkit.org Date 2012-01-13 09:04:29 -0800 (Fri, 13 Jan 2012) Log Message [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables https://bugs.webkit.org/show_bug.cgi?id=76269 Reviewed by Martin Robinson. * gtk/gtkdoc.py: (GTKDoc._run_gtkdoc_scangobj): Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/gtkdoc.py Diff Modified: trunk/Tools/ChangeLog (104941 => 104942) --- trunk/Tools/ChangeLog 2012-01-13 16:35:33 UTC (rev 104941) +++ trunk/Tools/ChangeLog 2012-01-13 17:04:29 UTC (rev 104942) @@ -1,3 +1,13 @@ +2012-01-13 Gabor Rapcsanyi rga...@webkit.org + +[GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables +https://bugs.webkit.org/show_bug.cgi?id=76269 + +Reviewed by Martin Robinson. + +* gtk/gtkdoc.py: +(GTKDoc._run_gtkdoc_scangobj): + 2012-01-13 Csaba Osztrogonác o...@webkit.org [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests Modified: trunk/Tools/gtk/gtkdoc.py (104941 => 104942) --- trunk/Tools/gtk/gtkdoc.py 2012-01-13 16:35:33 UTC (rev 104941) +++ trunk/Tools/gtk/gtkdoc.py 2012-01-13 17:04:29 UTC (rev 104942) @@ -290,9 +290,9 @@ env['RUN'] = 'LD_LIBRARY_PATH=%s ' % self.library_path if ldflags: -env['LDFLAGS'] = ldflags +env['LDFLAGS'] = '%s %s' % (env.get('LDFLAGS', ''), ldflags) if self.cflags: -env['CFLAGS'] = self.cflags +env['CFLAGS'] = '%s %s' % (env.get('CFLAGS', ''), self.cflags) if 'CFLAGS' in env: self.logger.debug('CFLAGS=%s', env['CFLAGS']) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104700] trunk/LayoutTests
Title: [104700] trunk/LayoutTests Revision 104700 Author rga...@webkit.org Date 2012-01-11 04:46:45 -0800 (Wed, 11 Jan 2012) Log Message [Qt] new test fast/forms/radio/radio-group.html failing after r104668 https://bugs.webkit.org/show_bug.cgi?id=76051 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (104699 => 104700) --- trunk/LayoutTests/ChangeLog 2012-01-11 12:24:42 UTC (rev 104699) +++ trunk/LayoutTests/ChangeLog 2012-01-11 12:46:45 UTC (rev 104700) @@ -1,3 +1,12 @@ +2012-01-11 Gabor Rapcsanyi rga...@webkit.org + +[Qt] new test fast/forms/radio/radio-group.html failing after r104668 +https://bugs.webkit.org/show_bug.cgi?id=76051 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2012-01-11 Alexander Pavlov apav...@chromium.org [Chromium] Skip failing fast/text/font-kerning.html reftest on Win7. Modified: trunk/LayoutTests/platform/qt/Skipped (104699 => 104700) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-11 12:24:42 UTC (rev 104699) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-11 12:46:45 UTC (rev 104700) @@ -2566,3 +2566,7 @@ # [Qt] REGRESSION(r104267): fast/js/date-constructor.html fails # https://bugs.webkit.org/show_bug.cgi?id=75692 fast/js/date-constructor.html + +# [Qt] new test fast/forms/radio/radio-group.html failing after r104668 +# https://bugs.webkit.org/show_bug.cgi?id=76051 +fast/forms/radio/radio-group.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104704] trunk/LayoutTests
Title: [104704] trunk/LayoutTests Revision 104704 Author rga...@webkit.org Date 2012-01-11 05:47:47 -0800 (Wed, 11 Jan 2012) Log Message [Qt] Some css3 filter tests are failing after r104698 https://bugs.webkit.org/show_bug.cgi?id=76055 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (104703 => 104704) --- trunk/LayoutTests/ChangeLog 2012-01-11 13:38:03 UTC (rev 104703) +++ trunk/LayoutTests/ChangeLog 2012-01-11 13:47:47 UTC (rev 104704) @@ -1,3 +1,12 @@ +2012-01-11 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Some css3 filter tests are failing after r104698 +https://bugs.webkit.org/show_bug.cgi?id=76055 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2012-01-09 Alexandru Chiculita ach...@adobe.com [CSS Shaders] Move CustomFilterOperation to the platform layer Modified: trunk/LayoutTests/platform/qt/Skipped (104703 => 104704) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-11 13:38:03 UTC (rev 104703) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-11 13:47:47 UTC (rev 104704) @@ -2570,3 +2570,16 @@ # [Qt] new test fast/forms/radio/radio-group.html failing after r104668 # https://bugs.webkit.org/show_bug.cgi?id=76051 fast/forms/radio/radio-group.html + +# [Qt] Some css3 filter tests are failing after r104698 +# https://bugs.webkit.org/show_bug.cgi?id=76055 +css3/filters/effect-blur.html +css3/filters/effect-brightness.html +css3/filters/effect-contrast.html +css3/filters/effect-drop-shadow.html +css3/filters/effect-grayscale.html +css3/filters/effect-hue-rotate.html +css3/filters/effect-invert.html +css3/filters/effect-opacity.html +css3/filters/effect-saturate.html +css3/filters/effect-sepia.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104461] trunk/Tools
Title: [104461] trunk/Tools Revision 104461 Author rga...@webkit.org Date 2012-01-09 07:32:16 -0800 (Mon, 09 Jan 2012) Log Message [Gtk][ARM] Cross compiler buildbot is failing after r103040 https://bugs.webkit.org/show_bug.cgi?id=75846 Reviewed by Philippe Normand. * Scripts/webkitdirs.pm: (runAutogenForAutotoolsProjectIfNecessary): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitdirs.pm Diff Modified: trunk/Tools/ChangeLog (104460 => 104461) --- trunk/Tools/ChangeLog 2012-01-09 15:19:59 UTC (rev 104460) +++ trunk/Tools/ChangeLog 2012-01-09 15:32:16 UTC (rev 104461) @@ -1,3 +1,13 @@ +2012-01-09 Gabor Rapcsanyi rga...@webkit.org + +[Gtk][ARM] Cross compiler buildbot is failing after r103040 +https://bugs.webkit.org/show_bug.cgi?id=75846 + +Reviewed by Philippe Normand. + +* Scripts/webkitdirs.pm: +(runAutogenForAutotoolsProjectIfNecessary): + 2012-01-09 Alexander Færøy a...@0x90.dk [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser Modified: trunk/Tools/Scripts/webkitdirs.pm (104460 => 104461) --- trunk/Tools/Scripts/webkitdirs.pm 2012-01-09 15:19:59 UTC (rev 104460) +++ trunk/Tools/Scripts/webkitdirs.pm 2012-01-09 15:32:16 UTC (rev 104461) @@ -1770,7 +1770,7 @@ # between 32-bit and 64-bit architectures. The options are also # used on Chromium build. determineArchitecture(); -if ($architecture ne x86_64) { +if ($architecture ne x86_64 !isARM()) { $ENV{'CXXFLAGS'} = -march=pentium4 -msse2 -mfpmath=sse; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100431] trunk/LayoutTests
Title: [100431] trunk/LayoutTests Revision 100431 Author rga...@webkit.org Date 2011-11-16 04:48:30 -0800 (Wed, 16 Nov 2011) Log Message [Qt] Update Qt specific expected results. Unreviewed gardening. * platform/qt/fast/loader/file-protocol-fragment-expected.png: Added. * platform/qt/fast/loader/file-protocol-fragment-expected.txt: * platform/qt/inspector: Added. * platform/qt/inspector/console: Added. * platform/qt/inspector/console/console-format-expected.png: Added. * platform/qt/inspector/console/console-format-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.txt Added Paths trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.png trunk/LayoutTests/platform/qt/inspector/ trunk/LayoutTests/platform/qt/inspector/console/ trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.png trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100430 => 100431) --- trunk/LayoutTests/ChangeLog 2011-11-16 12:33:04 UTC (rev 100430) +++ trunk/LayoutTests/ChangeLog 2011-11-16 12:48:30 UTC (rev 100431) @@ -1,3 +1,16 @@ +2011-11-16 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Update Qt specific expected results. + +Unreviewed gardening. + +* platform/qt/fast/loader/file-protocol-fragment-expected.png: Added. +* platform/qt/fast/loader/file-protocol-fragment-expected.txt: +* platform/qt/inspector: Added. +* platform/qt/inspector/console: Added. +* platform/qt/inspector/console/console-format-expected.png: Added. +* platform/qt/inspector/console/console-format-expected.txt: Added. + 2011-11-16 Steve Block stevebl...@google.com Compositing LayoutTests failing on Chromium Mac Added: trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.png ___ Added: svn:mime-type Modified: trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.txt (100430 => 100431) --- trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.txt 2011-11-16 12:33:04 UTC (rev 100430) +++ trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.txt 2011-11-16 12:48:30 UTC (rev 100431) @@ -4,4 +4,5 @@ resources/stylesheet.css#a - didReceiveResponse NSURLResponse resources/stylesheet.css#a, http status code 0 resources/stylesheet.css#a - didFinishLoading resources/stylesheet.css#b - didReceiveResponse NSURLResponse resources/stylesheet.css#b, http status code 0 +resources/stylesheet.css#b - didFinishLoading This tests that file: URL are loaded separately even if they differ by the fragment only. Added: trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.txt (0 => 100431) --- trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.txt 2011-11-16 12:48:30 UTC (rev 100431) @@ -0,0 +1,139 @@ +CONSOLE MESSAGE: line 12: Message format number %i, %d and %f +CONSOLE MESSAGE: line 13: Message %s for %s +CONSOLE MESSAGE: line 14: Object %o +CONSOLE MESSAGE: line 20: test,test2,,,test4 +CONSOLE MESSAGE: line 21: %o +CONSOLE MESSAGE: line 22: %O +CONSOLE MESSAGE: line 54: /^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\.))*|'(?:[^\\\']|(?:\\[\da-f]{1,6}\s?|\.))*')|(?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i +CONSOLE MESSAGE: line 55: /^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\.))*|'(?:[^\\\']|(?:\\[\da-f]{1,6}\s?|\.))*')|(?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i +CONSOLE MESSAGE: line 54: /foo\\bar\sbaz/i +CONSOLE MESSAGE: line 55: /foo\\bar\sbaz/i +CONSOLE MESSAGE: line 54: test +CONSOLE MESSAGE: line 55: test +CONSOLE MESSAGE: line 54: test named test +CONSOLE MESSAGE: line 55: test named test +CONSOLE MESSAGE: line 54: Error +CONSOLE MESSAGE: line 55: Error +CONSOLE MESSAGE: line 54: [object HTMLBodyElement] +CONSOLE MESSAGE: line 55: [object HTMLBodyElement] +CONSOLE MESSAGE: line 54: function () { return 1; } +CONSOLE MESSAGE: line 55: function () { return 1; } +CONSOLE MESSAGE: line 54: function () { +return 2; +} +CONSOLE MESSAGE: line 55: function () { +return 2; +} +CONSOLE MESSAGE: line 54: 0.12 +CONSOLE MESSAGE: line 55: 0.12 +CONSOLE MESSAGE: line 54: http://webkit.org/ +CONSOLE MESSAGE: line 55: http://webkit.org/ +CONSOLE
[webkit-changes] [100434] trunk/LayoutTests
Title: [100434] trunk/LayoutTests Revision 100434 Author rga...@webkit.org Date 2011-11-16 05:09:25 -0800 (Wed, 16 Nov 2011) Log Message [Qt] new test css3/flexbox/line-wrapping.html failing https://bugs.webkit.org/show_bug.cgi?id=72490 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100433 => 100434) --- trunk/LayoutTests/ChangeLog 2011-11-16 12:56:21 UTC (rev 100433) +++ trunk/LayoutTests/ChangeLog 2011-11-16 13:09:25 UTC (rev 100434) @@ -1,3 +1,12 @@ +2011-11-16 Gabor Rapcsanyi rga...@webkit.org + +[Qt] new test css3/flexbox/line-wrapping.html failing +https://bugs.webkit.org/show_bug.cgi?id=72490 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-11-15 Andrey Kosyakov ca...@chromium.org Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead Modified: trunk/LayoutTests/platform/qt/Skipped (100433 => 100434) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-16 12:56:21 UTC (rev 100433) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-16 13:09:25 UTC (rev 100434) @@ -2482,3 +2482,7 @@ # [Qt] fast/forms/file/file-input-reset.html failing on Qt # https://bugs.webkit.org/show_bug.cgi?id=72429 fast/forms/file/file-input-reset.html + +# [Qt] new test css3/flexbox/line-wrapping.html failing +# https://bugs.webkit.org/show_bug.cgi?id=72490 +css3/flexbox/line-wrapping.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100443] trunk/LayoutTests
Title: [100443] trunk/LayoutTests Revision 100443 Author rga...@webkit.org Date 2011-11-16 06:42:14 -0800 (Wed, 16 Nov 2011) Log Message [Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433 https://bugs.webkit.org/show_bug.cgi?id=72493 [Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311 https://bugs.webkit.org/show_bug.cgi?id=72491 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100442 => 100443) --- trunk/LayoutTests/ChangeLog 2011-11-16 14:28:05 UTC (rev 100442) +++ trunk/LayoutTests/ChangeLog 2011-11-16 14:42:14 UTC (rev 100443) @@ -1,3 +1,15 @@ +2011-11-16 Gabor Rapcsanyi rga...@webkit.org + +[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433 +https://bugs.webkit.org/show_bug.cgi?id=72493 + +[Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311 +https://bugs.webkit.org/show_bug.cgi?id=72491 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-11-16 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r100281 and r100437. Modified: trunk/LayoutTests/platform/qt/Skipped (100442 => 100443) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-16 14:28:05 UTC (rev 100442) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-16 14:42:14 UTC (rev 100443) @@ -2526,3 +2526,11 @@ # [Qt] new test css3/flexbox/line-wrapping.html failing # https://bugs.webkit.org/show_bug.cgi?id=72490 css3/flexbox/line-wrapping.html + +# [Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433 +# https://bugs.webkit.org/show_bug.cgi?id=72493 +inspector/extensions/extensions-sidebar.html + +# [Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311 +# https://bugs.webkit.org/show_bug.cgi?id=72491 +http/tests/misc/onload-remove-iframe-crash-2.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100444] trunk/LayoutTests
Title: [100444] trunk/LayoutTests Revision 100444 Author rga...@webkit.org Date 2011-11-16 06:54:01 -0800 (Wed, 16 Nov 2011) Log Message [Qt] Skip new failing tests. Unreviewed gardening. * platform/qt-mac/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100443 => 100444) --- trunk/LayoutTests/ChangeLog 2011-11-16 14:42:14 UTC (rev 100443) +++ trunk/LayoutTests/ChangeLog 2011-11-16 14:54:01 UTC (rev 100444) @@ -1,5 +1,13 @@ 2011-11-16 Gabor Rapcsanyi rga...@webkit.org +[Qt] Skip new failing tests. + +Unreviewed gardening. + +* platform/qt-mac/Skipped: + +2011-11-16 Gabor Rapcsanyi rga...@webkit.org + [Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433 https://bugs.webkit.org/show_bug.cgi?id=72493 Modified: trunk/LayoutTests/platform/qt-mac/Skipped (100443 => 100444) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-11-16 14:42:14 UTC (rev 100443) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-11-16 14:54:01 UTC (rev 100444) @@ -5219,3 +5219,37 @@ svg/as-image/svg-image-change-content-size.xhtml svg/as-object/svg-embedded-in-html-in-iframe.html svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html + +# crashing tests +canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html +http/tests/misc/onload-remove-iframe-crash-2.html +fast/canvas/2d.text.draw.fill.maxWidth.negative.html +fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html + +# new failing tests +css2.1/20110323/border-spacing-applies-to-015.htm +css2.1/20110323/table-caption-001.htm +css2.1/20110323/table-caption-002.htm +css2.1/20110323/table-caption-horizontal-alignment-001.htm +css2.1/20110323/table-caption-margins-001.htm +css2.1/20110323/table-caption-optional-001.htm +css2.1/20110323/table-caption-optional-002.htm +fast/dom/rtl-scroll-to-leftmost-and-resize.html +fast/multicol/pagination-h-horizontal-bt.html +fast/multicol/pagination-h-horizontal-tb.html +fast/multicol/pagination-h-vertical-lr.html +fast/multicol/pagination-h-vertical-rl.html +fast/multicol/pagination-v-horizontal-bt.html +fast/multicol/pagination-v-horizontal-tb.html +fast/multicol/pagination-v-vertical-lr.html +fast/multicol/pagination-v-vertical-rl.html +http/tests/security/contentSecurityPolicy/policy-does-not-affect-child.html +svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html +svg/as-image/animated-svg-as-image-same-image.html +svg/foreignObject/background-render-phase.html +svg/foreignObject/clip.html +svg/foreignObject/filter.html +svg/foreignObject/mask.html +svg/foreignObject/multiple-foreign-objects.html +svg/zoom/page/zoom-background-images.html +svg/zoom/page/zoom-svg-as-background-with-relative-size.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99671] trunk/LayoutTests
Title: [99671] trunk/LayoutTests Revision 99671 Author rga...@webkit.org Date 2011-11-09 01:42:03 -0800 (Wed, 09 Nov 2011) Log Message [Qt] Unreviewed. Update fast/forms/listbox-clip.html expected. * platform/qt/fast/forms/listbox-clip-expected.png: * platform/qt/fast/forms/listbox-clip-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.png trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (99670 => 99671) --- trunk/LayoutTests/ChangeLog 2011-11-09 09:25:30 UTC (rev 99670) +++ trunk/LayoutTests/ChangeLog 2011-11-09 09:42:03 UTC (rev 99671) @@ -1,3 +1,10 @@ +2011-11-09 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed. Update fast/forms/listbox-clip.html expected. + +* platform/qt/fast/forms/listbox-clip-expected.png: +* platform/qt/fast/forms/listbox-clip-expected.txt: + 2011-11-09 Yuta Kitamura yu...@chromium.org [Chromium] Unreviewed, update test expectation for listbox-clip.html on Mac. Modified: trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.txt (99670 => 99671) --- trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.txt 2011-11-09 09:25:30 UTC (rev 99670) +++ trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.txt 2011-11-09 09:42:03 UTC (rev 99671) @@ -3,6 +3,6 @@ layer at (0,0) size 800x600 RenderBlock {HTML} at (0,0) size 800x600 RenderBody {BODY} at (8,8) size 784x584 - RenderListBox {SELECT} at (0,2) size 100x106 [bgcolor=#FF] [border: (1px inset #808080)] + RenderListBox {SELECT} at (0,2) size 100x85 [bgcolor=#FF] [border: (1px inset #808080)] RenderText {#text} at (0,0) size 0x0 RenderText {#text} at (0,0) size 0x0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99700] trunk/Source/JavaScriptCore
Title: [99700] trunk/Source/_javascript_Core Revision 99700 Author rga...@webkit.org Date 2011-11-09 06:07:24 -0800 (Wed, 09 Nov 2011) Log Message Buildfix for 32bit debug mode. Reviewed by Csaba Osztrogonác. * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::dump): * dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (99699 => 99700) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 14:00:52 UTC (rev 99699) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 14:07:24 UTC (rev 99700) @@ -1,3 +1,14 @@ +2011-11-09 Gabor Rapcsanyi rga...@webkit.org + +Buildfix for 32bit debug mode. + +Reviewed by Csaba Osztrogonác. + +* dfg/DFGAbstractState.cpp: +(JSC::DFG::AbstractState::dump): +* dfg/DFGGraph.cpp: +(JSC::DFG::Graph::dump): + 2011-11-09 Andy Wingo wi...@igalia.com Enable the DFG JIT on X86-64 Linux platforms Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (99699 => 99700) --- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2011-11-09 14:00:52 UTC (rev 99699) +++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2011-11-09 14:07:24 UTC (rev 99700) @@ -800,7 +800,7 @@ first = false; else fprintf(out, ); -fprintf(out, @%lu:, i + m_block-begin); +fprintf(out, @%lu:, static_castunsigned long(i + m_block-begin)); m_nodes[i].dump(out); } } Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (99699 => 99700) --- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2011-11-09 14:00:52 UTC (rev 99699) +++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2011-11-09 14:07:24 UTC (rev 99700) @@ -209,7 +209,7 @@ else printf(%sid%u, hasPrinted ? , : , storageAccessData.identifierNumber); -printf(, %lu, storageAccessData.offset); +printf(, %lu, static_castunsigned long(storageAccessData.offset)); hasPrinted = true; } ASSERT(node.hasVariableAccessData() == node.hasLocal()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99048] trunk/LayoutTests
Title: [99048] trunk/LayoutTests Revision 99048 Author rga...@webkit.org Date 2011-11-02 02:09:35 -0700 (Wed, 02 Nov 2011) Log Message [Qt] Unreviewed gardening. Unskip the Qt mobility tests because they are working now. * platform/qt-arm/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-arm/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99047 => 99048) --- trunk/LayoutTests/ChangeLog 2011-11-02 09:00:26 UTC (rev 99047) +++ trunk/LayoutTests/ChangeLog 2011-11-02 09:09:35 UTC (rev 99048) @@ -1,3 +1,9 @@ +2011-11-02 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed gardening. Unskip the Qt mobility tests because they are working now. + +* platform/qt-arm/Skipped: + 2011-11-02 Philippe Normand pnorm...@igalia.com Unreviewed, GTK rebaseline after r98852 and r99027. Modified: trunk/LayoutTests/platform/qt-arm/Skipped (99047 => 99048) --- trunk/LayoutTests/platform/qt-arm/Skipped 2011-11-02 09:00:26 UTC (rev 99047) +++ trunk/LayoutTests/platform/qt-arm/Skipped 2011-11-02 09:09:35 UTC (rev 99048) @@ -115,61 +115,3 @@ # https://bugs.webkit.org/show_bug.cgi?id=69925 inspector/elements/edit-dom-actions.html inspector/elements/elements-delete-inline-style.html - -# Skip failing tests temporarily because of missing Qt Mobility on the buildbot -fast/dom/DeviceMotion/create-event.html -fast/dom/DeviceMotion/no-page-cache.html -fast/dom/DeviceMotion/optional-event-properties.html -fast/dom/DeviceMotion/window-property.html -fast/dom/DeviceOrientation/add-listener-from-callback.html -fast/dom/DeviceOrientation/basic-operation.html -fast/dom/DeviceOrientation/create-event.html -fast/dom/DeviceOrientation/multiple-frames.html -fast/dom/DeviceOrientation/no-page-cache.html -fast/dom/DeviceOrientation/no-synchronous-events.html -fast/dom/DeviceOrientation/null-values.html -fast/dom/DeviceOrientation/optional-event-properties.html -fast/dom/DeviceOrientation/updates.html -fast/dom/DeviceOrientation/window-property.html -fast/dom/Geolocation/argument-types.html -fast/dom/Geolocation/callback-exception.html -fast/dom/Geolocation/callback-to-deleted-context.html -fast/dom/Geolocation/callback-to-remote-context.html -fast/dom/Geolocation/callback-to-remote-context2.html -fast/dom/Geolocation/clear-watch-invalid-id-crash.html -fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html -fast/dom/Geolocation/delayed-permission-allowed.html -fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html -fast/dom/Geolocation/delayed-permission-denied.html -fast/dom/Geolocation/disconnected-frame-already.html -fast/dom/Geolocation/disconnected-frame-permission-denied.html -fast/dom/Geolocation/disconnected-frame.html -fast/dom/Geolocation/enabled.html -fast/dom/Geolocation/error.html -fast/dom/Geolocation/maximum-age.html -fast/dom/Geolocation/multiple-requests.html -fast/dom/Geolocation/no-page-cache.html -fast/dom/Geolocation/not-enough-arguments.html -fast/dom/Geolocation/notimer-after-unload.html -fast/dom/Geolocation/page-reload-cancel-permission-requests.html -fast/dom/Geolocation/permission-denied-already-clear-watch.html -fast/dom/Geolocation/permission-denied-already-error.html -fast/dom/Geolocation/permission-denied-already-success.html -fast/dom/Geolocation/permission-denied-stops-watches.html -fast/dom/Geolocation/permission-denied.html -fast/dom/Geolocation/position-string.html -fast/dom/Geolocation/reentrant-error.html -fast/dom/Geolocation/reentrant-permission-denied.html -fast/dom/Geolocation/reentrant-success.html -fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html -fast/dom/Geolocation/success.html -fast/dom/Geolocation/timeout-clear-watch.html -fast/dom/Geolocation/timeout-zero.html -fast/dom/Geolocation/timeout.html -fast/dom/Geolocation/timestamp.html -fast/dom/Geolocation/watch.html -fast/dom/Geolocation/window-close-crash.html -fast/dom/Orientation/create-event-orientationchange.html -fast/dom/Window/window-properties-device-orientation.html -fast/dom/Window/window-properties-geolocation.html -fast/dom/Window/window-property-descriptors.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98539] trunk/LayoutTests
Title: [98539] trunk/LayoutTests Revision 98539 Author rga...@webkit.org Date 2011-10-27 01:54:57 -0700 (Thu, 27 Oct 2011) Log Message Unreviewed. Add bugzilla link to skipped test. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (98538 => 98539) --- trunk/LayoutTests/ChangeLog 2011-10-27 07:53:44 UTC (rev 98538) +++ trunk/LayoutTests/ChangeLog 2011-10-27 08:54:57 UTC (rev 98539) @@ -1,3 +1,9 @@ +2011-10-27 Gabor Rapcsanyi rga...@webkit.org + +Unreviewed. Add bugzilla link to skipped test. + +* platform/qt/Skipped: + 2011-10-27 Ilya Tikhonovsky loi...@chromium.org inspector/storage-panel-dom-storage.html has results platform dependant? Modified: trunk/LayoutTests/platform/qt/Skipped (98538 => 98539) --- trunk/LayoutTests/platform/qt/Skipped 2011-10-27 07:53:44 UTC (rev 98538) +++ trunk/LayoutTests/platform/qt/Skipped 2011-10-27 08:54:57 UTC (rev 98539) @@ -2456,6 +2456,7 @@ fast/events/touch/page-scaled-touch-gesture-click.html # fast/canvas/canvas-composite-image.html is failing +https://bugs.webkit.org/show_bug.cgi?id=70893 fast/canvas/canvas-composite-image.html # [Qt] inspector/extensions/extensions-console.html is failing ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98540] trunk/LayoutTests
Title: [98540] trunk/LayoutTests Revision 98540 Author rga...@webkit.org Date 2011-10-27 02:33:59 -0700 (Thu, 27 Oct 2011) Log Message Unreviewed, fix typo in skiplist. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (98539 => 98540) --- trunk/LayoutTests/ChangeLog 2011-10-27 08:54:57 UTC (rev 98539) +++ trunk/LayoutTests/ChangeLog 2011-10-27 09:33:59 UTC (rev 98540) @@ -1,5 +1,11 @@ 2011-10-27 Gabor Rapcsanyi rga...@webkit.org +Unreviewed, fix typo in skiplist. + +* platform/qt/Skipped: + +2011-10-27 Gabor Rapcsanyi rga...@webkit.org + Unreviewed. Add bugzilla link to skipped test. * platform/qt/Skipped: Modified: trunk/LayoutTests/platform/qt/Skipped (98539 => 98540) --- trunk/LayoutTests/platform/qt/Skipped 2011-10-27 08:54:57 UTC (rev 98539) +++ trunk/LayoutTests/platform/qt/Skipped 2011-10-27 09:33:59 UTC (rev 98540) @@ -2456,7 +2456,7 @@ fast/events/touch/page-scaled-touch-gesture-click.html # fast/canvas/canvas-composite-image.html is failing -https://bugs.webkit.org/show_bug.cgi?id=70893 +# https://bugs.webkit.org/show_bug.cgi?id=70893 fast/canvas/canvas-composite-image.html # [Qt] inspector/extensions/extensions-console.html is failing ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98459] trunk/LayoutTests
Title: [98459] trunk/LayoutTests Revision 98459 Author rga...@webkit.org Date 2011-10-26 02:41:27 -0700 (Wed, 26 Oct 2011) Log Message [Qt] Unreviewed skip. fast/canvas/canvas-composite-image.html failing on Qt * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (98458 => 98459) --- trunk/LayoutTests/ChangeLog 2011-10-26 09:38:42 UTC (rev 98458) +++ trunk/LayoutTests/ChangeLog 2011-10-26 09:41:27 UTC (rev 98459) @@ -1,3 +1,9 @@ +2011-10-26 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed skip. fast/canvas/canvas-composite-image.html failing on Qt + +* platform/qt/Skipped: + 2011-10-26 Ryosuke Niwa rn...@webkit.org Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac Modified: trunk/LayoutTests/platform/qt/Skipped (98458 => 98459) --- trunk/LayoutTests/platform/qt/Skipped 2011-10-26 09:38:42 UTC (rev 98458) +++ trunk/LayoutTests/platform/qt/Skipped 2011-10-26 09:41:27 UTC (rev 98459) @@ -2460,3 +2460,6 @@ # Introduced in r97988. Failure: Gesture manager is not implemented. # https://bugs.webkit.org/show_bug.cgi?id=70593 fast/events/touch/page-scaled-touch-gesture-click.html + +# fast/canvas/canvas-composite-image.html is failing +fast/canvas/canvas-composite-image.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98223] trunk/LayoutTests
Title: [98223] trunk/LayoutTests Revision 98223 Author rga...@webkit.org Date 2011-10-24 01:52:09 -0700 (Mon, 24 Oct 2011) Log Message [Qt] Unreviewed gardening after r98199 Patch by Kosztyo Kristof kkris...@inf.u-szeged.hu on 2011-10-24 * platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98222 => 98223) --- trunk/LayoutTests/ChangeLog 2011-10-24 08:14:02 UTC (rev 98222) +++ trunk/LayoutTests/ChangeLog 2011-10-24 08:52:09 UTC (rev 98223) @@ -1,3 +1,9 @@ +2011-10-24 Kosztyo Kristof kkris...@inf.u-szeged.hu + +[Qt] Unreviewed gardening after r98199 + +* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: + 2011-10-24 Yosifumi Inoue yo...@chromium.org [Forms] Setting defaultValue should hide an input placeholder. Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt (98222 => 98223) --- trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt 2011-10-24 08:14:02 UTC (rev 98222) +++ trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt 2011-10-24 08:52:09 UTC (rev 98223) @@ -168,19 +168,19 @@ PASS MediaListPrototype from inner.document.forms.testForm.0.ownerDocument.styleSheets.0.media.__proto__ PASS MemoryInfo from inner.document.forms.testForm.0.ownerDocument.defaultView.performance.memory PASS MemoryInfoPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.performance.memory.__proto__ -PASS MimeType from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0 -PASS MimeTypeArray from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes -PASS MimeTypeArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.constructor -PASS MimeTypeArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.__proto__ -PASS MimeTypeConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.constructor -PASS MimeTypePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.__proto__ +PASS MimeType from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0 +PASS MimeTypeArray from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes +PASS MimeTypeArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.constructor +PASS MimeTypeArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.__proto__ +PASS MimeTypeConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0.constructor +PASS MimeTypePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0.__proto__ PASS NamedNodeMap from inner.document.forms.testForm.0.parentNode.attributes -PASS Navigator from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation -PASS NavigatorPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.__proto__ +PASS Navigator from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator +PASS NavigatorPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.__proto__ PASS NodeList from inner.document.forms.testForm PASS NodeListConstructor from inner.document.forms.testForm.constructor PASS NodeListPrototype from inner.document.forms.testForm.__proto__ -PASS NodePrototype from inner.document.forms.testForm.0.attributes.0.__proto__.__proto__ +PASS NodePrototype from inner.document.forms.testForm.0.ownerDocument.__proto__.__proto__.__proto__ PASS NotificationCenter from inner.document.forms.testForm.0.ownerDocument.defaultView.webkitNotifications PASS NotificationCenterPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.webkitNotifications.__proto__ PASS Object from inner.document.location.__proto__.__proto__ @@ -190,12 +190,12 @@ PASS PerformancePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.performance.__proto__ PASS PerformanceTiming from inner.document.forms.testForm.0.ownerDocument.defaultView.performance.timing PASS PerformanceTimingPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.performance.timing.__proto__ -PASS Plugin from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.enabledPlugin -PASS PluginArray from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.plugins -PASS PluginArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.plugins.constructor -PASS PluginArrayPrototype from
[webkit-changes] [97842] trunk/LayoutTests
Title: [97842] trunk/LayoutTests Revision 97842 Author rga...@webkit.org Date 2011-10-19 02:45:48 -0700 (Wed, 19 Oct 2011) Log Message [Qt] Unreviewed gardening. Add platform specific expected result for new tests. * platform/qt/fast/multicol/vertical-rl/rule-style-expected.png: Added. * platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt: Added. * platform/qt/fast/selectors/visited-descendant-expected.png: Added. * platform/qt/fast/selectors/visited-descendant-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/qt/fast/multicol/vertical-rl/rule-style-expected.png trunk/LayoutTests/platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt trunk/LayoutTests/platform/qt/fast/selectors/visited-descendant-expected.png trunk/LayoutTests/platform/qt/fast/selectors/visited-descendant-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97841 => 97842) --- trunk/LayoutTests/ChangeLog 2011-10-19 08:32:30 UTC (rev 97841) +++ trunk/LayoutTests/ChangeLog 2011-10-19 09:45:48 UTC (rev 97842) @@ -1,3 +1,12 @@ +2011-10-19 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed gardening. Add platform specific expected result for new tests. + +* platform/qt/fast/multicol/vertical-rl/rule-style-expected.png: Added. +* platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt: Added. +* platform/qt/fast/selectors/visited-descendant-expected.png: Added. +* platform/qt/fast/selectors/visited-descendant-expected.txt: Added. + 2011-10-19 Yuzo Fujishima y...@google.com [chromium] Test expectation change. Added: trunk/LayoutTests/platform/qt/fast/multicol/vertical-rl/rule-style-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/qt/fast/multicol/vertical-rl/rule-style-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt (0 => 97842) --- trunk/LayoutTests/platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt 2011-10-19 09:45:48 UTC (rev 97842) @@ -0,0 +1,44 @@ +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 +RenderBody {BODY} at (8,8) size 784x584 + RenderText {#text} at (184,20) size 22x4 +text run at (184,20) width 4: + RenderText {#text} at (184,44) size 22x4 +text run at (184,44) width 4: + RenderText {#text} at (184,68) size 22x4 +text run at (184,68) width 4: + RenderText {#text} at (184,92) size 22x4 +text run at (184,92) width 4: + RenderText {#text} at (184,116) size 22x4 +text run at (184,116) width 4: + RenderText {#text} at (184,140) size 22x4 +text run at (184,140) width 4: + RenderText {#text} at (184,164) size 22x4 +text run at (184,164) width 4: + RenderText {#text} at (0,0) size 0x0 +layer at (592,8) size 200x20 + RenderBlock {DIV} at (0,0) size 200x20 +RenderBlock {DIV} at (0,0) size 400x2 +layer at (592,32) size 200x20 + RenderBlock {DIV} at (0,24) size 200x20 +RenderBlock {DIV} at (0,0) size 400x2 +layer at (592,56) size 200x20 + RenderBlock {DIV} at (0,48) size 200x20 +RenderBlock {DIV} at (0,0) size 400x2 +layer at (592,80) size 200x20 + RenderBlock {DIV} at (0,72) size 200x20 +RenderBlock {DIV} at (0,0) size 400x2 +layer at (592,104) size 200x20 + RenderBlock {DIV} at (0,96) size 200x20 +RenderBlock {DIV} at (0,0) size 400x2 +layer at (592,128) size 200x20 + RenderBlock {DIV} at (0,120) size 200x20 +RenderBlock {DIV} at (0,0) size 400x2 +layer at (592,152) size 200x20 + RenderBlock {DIV} at (0,144) size 200x20 +RenderBlock {DIV} at (0,0) size 400x2 +layer at (592,176) size 200x20 + RenderBlock {DIV} at (0,168) size 200x20 +RenderBlock {DIV} at (0,0) size 400x2 Added: trunk/LayoutTests/platform/qt/fast/selectors/visited-descendant-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/qt/fast/selectors/visited-descendant-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/qt/fast/selectors/visited-descendant-expected.txt (0 => 97842) --- trunk/LayoutTests/platform/qt/fast/selectors/visited-descendant-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/fast/selectors/visited-descendant-expected.txt 2011-10-19 09:45:48 UTC (rev 97842) @@ -0,0 +1,62 @@ +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 +RenderBody {BODY} at (8,8) size 784x576 + RenderBlock {P} at (0,0) size 784x44 +
[webkit-changes] [97856] trunk/Tools
Title: [97856] trunk/Tools Revision 97856 Author rga...@webkit.org Date 2011-10-19 06:59:23 -0700 (Wed, 19 Oct 2011) Log Message [GTK] Enable to use built-product-archive on GTK platform https://bugs.webkit.org/show_bug.cgi?id=70319 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/built-product-archive: Modified Paths trunk/Tools/BuildSlaveSupport/built-product-archive trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (97855 => 97856) --- trunk/Tools/BuildSlaveSupport/built-product-archive 2011-10-19 13:36:47 UTC (rev 97855) +++ trunk/Tools/BuildSlaveSupport/built-product-archive 2011-10-19 13:59:23 UTC (rev 97856) @@ -48,7 +48,7 @@ def archiveBuiltProduct(configuration, platform): -assert platform in ('mac', 'win','qt') +assert platform in ('mac', 'win', 'qt', 'gtk') archiveFile = os.path.join(buildDirectory, configuration + .zip) @@ -82,14 +82,19 @@ shutil.rmtree(thinDirectory) -elif platform == 'qt': +elif platform == 'qt' or platform == 'gtk': thinDirectory = os.path.join(configurationBuildDirectory, thin) if os.path.isdir(thinDirectory): shutil.rmtree(thinDirectory) os.mkdir(thinDirectory) -for dirname in [bin, lib, _javascript_Core]: +if platform == 'qt': +neededDirectories = [bin, lib, _javascript_Core] +elif platform == 'gtk': +neededDirectories = [Programs, .libs] + +for dirname in neededDirectories: fromDir = os.path.join(configurationBuildDirectory, dirname, *) toDir = os.path.join(thinDirectory, dirname) os.makedirs(toDir) @@ -105,7 +110,7 @@ return 1 def extractBuiltProduct(configuration, platform): -assert platform in ('mac', 'win','qt') +assert platform in ('mac', 'win', 'qt', 'gtk') archiveFile = os.path.join(buildDirectory, configuration + .zip) configurationBuildDirectory = os.path.join(buildDirectory, configuration.title()) @@ -134,7 +139,7 @@ if subprocess.call([unzip, -o, archiveFile], cwd=configurationBuildDirectory): return 1 -elif platform == 'qt': +elif platform == 'qt' or platform == 'gtk': if os.path.isdir(configurationBuildDirectory): shutil.rmtree(configurationBuildDirectory) Modified: trunk/Tools/ChangeLog (97855 => 97856) --- trunk/Tools/ChangeLog 2011-10-19 13:36:47 UTC (rev 97855) +++ trunk/Tools/ChangeLog 2011-10-19 13:59:23 UTC (rev 97856) @@ -1,3 +1,12 @@ +2011-10-19 Gabor Rapcsanyi rga...@webkit.org + +[GTK] Enable to use built-product-archive on GTK platform +https://bugs.webkit.org/show_bug.cgi?id=70319 + +Reviewed by Csaba Osztrogonác. + +* BuildSlaveSupport/built-product-archive: + 2011-10-18 David Levin le...@chromium.org watchlist: Should try to run if it can and not throw on mistakes. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97241] trunk/LayoutTests
Title: [97241] trunk/LayoutTests Revision 97241 Author rga...@webkit.org Date 2011-10-12 01:12:56 -0700 (Wed, 12 Oct 2011) Log Message [Qt] Unreviewed gardening. Add platform specific expected result for new tests. * platform/qt/fast/writing-mode/margins-expected.png: Added. * platform/qt/fast/writing-mode/margins-expected.txt: Added. * platform/qt/plugins/iframe-plugin-bgcolor-expected.png: Added. * platform/qt/plugins/iframe-plugin-bgcolor-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.png trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.txt trunk/LayoutTests/platform/qt/plugins/iframe-plugin-bgcolor-expected.png trunk/LayoutTests/platform/qt/plugins/iframe-plugin-bgcolor-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97240 => 97241) --- trunk/LayoutTests/ChangeLog 2011-10-12 08:01:11 UTC (rev 97240) +++ trunk/LayoutTests/ChangeLog 2011-10-12 08:12:56 UTC (rev 97241) @@ -1,3 +1,12 @@ +2011-10-12 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed gardening. Add platform specific expected result for new tests. + +* platform/qt/fast/writing-mode/margins-expected.png: Added. +* platform/qt/fast/writing-mode/margins-expected.txt: Added. +* platform/qt/plugins/iframe-plugin-bgcolor-expected.png: Added. +* platform/qt/plugins/iframe-plugin-bgcolor-expected.txt: Added. + 2011-10-11 Ryosuke Niwa rn...@webkit.org Rebaseline after r97225. Added: trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.txt (0 => 97241) --- trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/fast/writing-mode/margins-expected.txt 2011-10-12 08:12:56 UTC (rev 97241) @@ -0,0 +1,24 @@ +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 +RenderBody {BODY} at (8,8) size 784x584 + RenderText {#text} at (160,124) size 4x22 +text run at (160,124) width 4: + RenderText {#text} at (324,124) size 4x22 +text run at (324,124) width 4: + RenderText {#text} at (488,124) size 4x22 +text run at (488,124) width 4: + RenderText {#text} at (0,0) size 0x0 +layer at (8,8) size 160x140 + RenderBlock (relative positioned) {DIV} at (0,0) size 160x140 [bgcolor=#FFC0CB] +RenderBlock {DIV} at (40,10) size 100x100 [bgcolor=#808080] +layer at (172,8) size 160x140 + RenderBlock (relative positioned) {DIV} at (164,0) size 160x140 [bgcolor=#FFC0CB] +RenderBlock {DIV} at (40,10) size 100x100 [bgcolor=#808080] +layer at (336,8) size 160x140 + RenderBlock (relative positioned) {DIV} at (328,0) size 160x140 [bgcolor=#FFC0CB] +RenderBlock {DIV} at (40,10) size 100x100 [bgcolor=#808080] +layer at (500,8) size 160x140 + RenderBlock (relative positioned) {DIV} at (492,0) size 160x140 [bgcolor=#FFC0CB] +RenderBlock {DIV} at (40,10) size 100x100 [bgcolor=#808080] Added: trunk/LayoutTests/platform/qt/plugins/iframe-plugin-bgcolor-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/qt/plugins/iframe-plugin-bgcolor-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/qt/plugins/iframe-plugin-bgcolor-expected.txt (0 => 97241) --- trunk/LayoutTests/platform/qt/plugins/iframe-plugin-bgcolor-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/plugins/iframe-plugin-bgcolor-expected.txt 2011-10-12 08:12:56 UTC (rev 97241) @@ -0,0 +1,13 @@ +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x172 + RenderBlock {HTML} at (0,0) size 800x172 +RenderBody {BODY} at (8,8) size 784x156 + RenderPartObject {IFRAME} at (0,0) size 300x150 +layer at (0,0) size 300x150 + RenderView at (0,0) size 300x150 +layer at (0,0) size 300x150 + RenderBlock {HTML} at (0,0) size 300x150 +RenderBody {BODY} at (0,0) size 300x150 [bgcolor=#262626] + RenderEmbeddedObject {EMBED} at (0,0) size 300x150 [QT: geometry: {at (8,8) size 300x150} isHidden: 0 isSelfVisible: 1 isParentVisible: 1 mask: {at (0,0) size 300x150} ] + RenderText {#text} at (0,0) size 0x0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97243] trunk/LayoutTests
Title: [97243] trunk/LayoutTests Revision 97243 Author rga...@webkit.org Date 2011-10-12 01:39:42 -0700 (Wed, 12 Oct 2011) Log Message [Qt] Unreviewed gardening. * platform/qt-mac/Skipped: Skip new failing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (97242 => 97243) --- trunk/LayoutTests/ChangeLog 2011-10-12 08:32:20 UTC (rev 97242) +++ trunk/LayoutTests/ChangeLog 2011-10-12 08:39:42 UTC (rev 97243) @@ -1,5 +1,11 @@ 2011-10-12 Gabor Rapcsanyi rga...@webkit.org +[Qt] Unreviewed gardening. + +* platform/qt-mac/Skipped: Skip new failing tests. + +2011-10-12 Gabor Rapcsanyi rga...@webkit.org + [Qt] Unreviewed gardening. Add platform specific expected result for new tests. * platform/qt/fast/writing-mode/margins-expected.png: Added. Modified: trunk/LayoutTests/platform/qt-mac/Skipped (97242 => 97243) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-10-12 08:32:20 UTC (rev 97242) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-10-12 08:39:42 UTC (rev 97243) @@ -5141,3 +5141,14 @@ # Qt specific result was added by r97008, but it fails on Qt-Mac platform fast/css/text-transform-select.html + +# new failing tests +fast/css-generated-content/first-letter-in-nested-before-table.html +fast/css-generated-content/table-parts-before-and-after.html +fast/lists/inline-before-content-after-list-marker.html +fast/runin/runin-between-list-marker-and-before-content.html +fast/runin/runin-into-div-with-float-child.html +fast/runin/runin-not-go-into-float.html +fast/table/table-row-before-after-content-around-table-cell.html +fast/writing-mode/margins.html +plugins/iframe-plugin-bgcolor.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97253] trunk/LayoutTests
Title: [97253] trunk/LayoutTests Revision 97253 Author rga...@webkit.org Date 2011-10-12 04:42:01 -0700 (Wed, 12 Oct 2011) Log Message [Qt] Unreviewed gardening. Skip failing tests on WK2. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (97252 => 97253) --- trunk/LayoutTests/ChangeLog 2011-10-12 11:27:45 UTC (rev 97252) +++ trunk/LayoutTests/ChangeLog 2011-10-12 11:42:01 UTC (rev 97253) @@ -1,3 +1,9 @@ +2011-10-12 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed gardening. Skip failing tests on WK2. + +* platform/qt-wk2/Skipped: + 2011-10-12 Kristóf Kosztyó kkris...@inf.u-szeged.hu new-run-webkit-tests does not support qt-4.8 results Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (97252 => 97253) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-10-12 11:27:45 UTC (rev 97252) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-10-12 11:42:01 UTC (rev 97253) @@ -7414,3 +7414,17 @@ # Qt specific result was added by r97008, but it fails on Qt-WK2 platform fast/css/text-transform-select.html + +# Skip failing tests +editing/selection/4975120.html +fast/css-generated-content/first-letter-in-nested-before-table.html +fast/css-generated-content/table-parts-before-and-after.html +fast/events/blur-focus-window-should-blur-focus-element.html +fast/lists/inline-before-content-after-list-marker.html +fast/runin/runin-between-list-marker-and-before-content.html +fast/runin/runin-into-div-with-float-child.html +fast/runin/runin-not-go-into-float.html +fast/table/table-row-before-after-content-around-table-cell.html +fast/writing-mode/margins.html +plugins/iframe-plugin-bgcolor.html +plugins/netscape-plugin-setwindow-size-2.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96681] trunk/LayoutTests
Title: [96681] trunk/LayoutTests Revision 96681 Author rga...@webkit.org Date 2011-10-05 01:09:16 -0700 (Wed, 05 Oct 2011) Log Message [Qt] Unreviewed gardening. * platform/qt-mac/Skipped: Skip new failing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (96680 => 96681) --- trunk/LayoutTests/ChangeLog 2011-10-05 08:03:01 UTC (rev 96680) +++ trunk/LayoutTests/ChangeLog 2011-10-05 08:09:16 UTC (rev 96681) @@ -1,3 +1,9 @@ +2011-10-05 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed gardening. + +* platform/qt-mac/Skipped: Skip new failing tests. + 2011-10-04 Kent Tamura tk...@chromium.org Introduce feature flags for incomplete input types Modified: trunk/LayoutTests/platform/qt-mac/Skipped (96680 => 96681) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-10-05 08:03:01 UTC (rev 96680) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-10-05 08:09:16 UTC (rev 96681) @@ -5125,3 +5125,16 @@ # Qt specific results were added by r95723, but they fail on Qt-Mac platform css3/selectors3 + +# new failing tests +fast/block/positioning/absolute-position-direction.html +fast/css-generated-content/first-letter-in-nested-before.html +fast/css/outline-narrowLine.html +fast/dynamic/first-letter-after-list-marker.html +fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html +fast/multicol/float-paginate-empty-lines.html +fast/ruby/ruby-base-merge-block-children-crash.html +fast/ruby/ruby-text-before-after-content.html +fast/table/quote-text-around-iframe.html +fast/text/complex-synthetic-bold-space-width.html +inspector/styles/styles-disable-then-delete.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96683] trunk/LayoutTests
Title: [96683] trunk/LayoutTests Revision 96683 Author rga...@webkit.org Date 2011-10-05 02:03:01 -0700 (Wed, 05 Oct 2011) Log Message [Qt] Unreviewed gardening, update expected file after r96509. * platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (96682 => 96683) --- trunk/LayoutTests/ChangeLog 2011-10-05 08:21:59 UTC (rev 96682) +++ trunk/LayoutTests/ChangeLog 2011-10-05 09:03:01 UTC (rev 96683) @@ -1,5 +1,11 @@ 2011-10-05 Gabor Rapcsanyi rga...@webkit.org +[Qt] Unreviewed gardening, update expected file after r96509. + +* platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt: + +2011-10-05 Gabor Rapcsanyi rga...@webkit.org + [Qt] Unreviewed gardening. * platform/qt-mac/Skipped: Skip new failing tests. Modified: trunk/LayoutTests/platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt (96682 => 96683) --- trunk/LayoutTests/platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt 2011-10-05 08:21:59 UTC (rev 96682) +++ trunk/LayoutTests/platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt 2011-10-05 09:03:01 UTC (rev 96683) @@ -16,8 +16,8 @@ RenderInline {A} at (0,0) size 186x27 RenderText {#text} at (0,0) size 186x27 text run at (0,0) width 186: Table of Contents -RenderTable {TABLE} at (0,43) size 4x4 - RenderTableSection {TBODY} at (0,0) size 4x4 -RenderTableRow {TR} at (0,2) size 4x0 +RenderTable {TABLE} at (0,43) size 2x4 + RenderTableSection {TBODY} at (0,0) size 2x4 +RenderTableRow {TR} at (0,2) size 2x0 RenderBlock (anonymous) at (0,97) size 784x0 RenderInline {FONT} at (0,0) size 0x0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96486] trunk/LayoutTests
Title: [96486] trunk/LayoutTests Revision 96486 Author rga...@webkit.org Date 2011-10-03 02:30:18 -0700 (Mon, 03 Oct 2011) Log Message Unreviewed Qt gardening after r96404 Patch by Kristóf Kosztyó kkris...@inf.u-szeged.hu on 2011-10-03 * platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png: Added. * platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png trunk/LayoutTests/platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (96485 => 96486) --- trunk/LayoutTests/ChangeLog 2011-10-03 09:16:12 UTC (rev 96485) +++ trunk/LayoutTests/ChangeLog 2011-10-03 09:30:18 UTC (rev 96486) @@ -1,3 +1,10 @@ +2011-10-03 Kristóf Kosztyó kkris...@inf.u-szeged.hu + +Unreviewed Qt gardening after r96404 + +* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png: Added. +* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt: Added. + 2011-10-02 Kent Tamura tk...@chromium.org method/enctype/formMethod/formEnctype properties should be limited to known values. Added: trunk/LayoutTests/platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt (0 => 96486) --- trunk/LayoutTests/platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt 2011-10-03 09:30:18 UTC (rev 96486) @@ -0,0 +1,14 @@ +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 +RenderBody {BODY} at (8,8) size 784x584 + RenderBlock (anonymous) at (0,0) size 784x22 +RenderText {#text} at (0,0) size 270x22 + text run at (0,0) width 270: These lines should have the same width: + RenderBlock {DIV} at (0,22) size 784x42 +RenderText {#text} at (0,0) size 73x21 + text run at (0,0) width 73: . . . . . . . . a +RenderBR {BR} at (73,16) size 0x0 +RenderText {#text} at (0,21) size 73x21 + text run at (0,21) width 73: . . . . . . . . a\x{300} ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95615] trunk/LayoutTests
Title: [95615] trunk/LayoutTests Revision 95615 Author rga...@webkit.org Date 2011-09-21 04:57:23 -0700 (Wed, 21 Sep 2011) Log Message [Qt][Mac] Unreviewed gardening after r95601. * platform/qt-mac/Skipped: Paint the Qt-Mac bot green. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95614 => 95615) --- trunk/LayoutTests/ChangeLog 2011-09-21 11:50:05 UTC (rev 95614) +++ trunk/LayoutTests/ChangeLog 2011-09-21 11:57:23 UTC (rev 95615) @@ -1,3 +1,9 @@ +2011-09-21 Gabor Rapcsanyi rga...@webkit.org + +[Qt][Mac] Unreviewed gardening after r95601. + +* platform/qt-mac/Skipped: Paint the Qt-Mac bot green. + 2011-09-21 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r95608. Modified: trunk/LayoutTests/platform/qt-mac/Skipped (95614 => 95615) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-09-21 11:50:05 UTC (rev 95614) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-09-21 11:57:23 UTC (rev 95615) @@ -5118,3 +5118,7 @@ fast/table/table-cell-before-after-content-around-table.html fast/table/table-row-before-after-content-around-block.html fast/table/table-row-before-after-content-around-table.html + +# Qt specific results were added by r95601, but they fail on Qt-Mac platform +fast/clip/overflow-border-radius-fixed-position.html +fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95407] trunk/LayoutTests
Title: [95407] trunk/LayoutTests Revision 95407 Author rga...@webkit.org Date 2011-09-19 05:48:48 -0700 (Mon, 19 Sep 2011) Log Message [Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav-media-elements.html fail https://bugs.webkit.org/show_bug.cgi?id=68341 Patch by Kristóf Kosztyó kkris...@inf.u-szeged.hu on 2011-09-19 * platform/qt-arm/Skipped: Skip the failing tests Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-arm/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95406 => 95407) --- trunk/LayoutTests/ChangeLog 2011-09-19 09:19:33 UTC (rev 95406) +++ trunk/LayoutTests/ChangeLog 2011-09-19 12:48:48 UTC (rev 95407) @@ -1,3 +1,10 @@ +2011-09-19 Kristóf Kosztyó kkris...@inf.u-szeged.hu + +[Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav-media-elements.html fail +https://bugs.webkit.org/show_bug.cgi?id=68341 + +* platform/qt-arm/Skipped: Skip the failing tests + 2011-09-18 Ilya Tikhonovsky loi...@chromium.org Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel. Modified: trunk/LayoutTests/platform/qt-arm/Skipped (95406 => 95407) --- trunk/LayoutTests/platform/qt-arm/Skipped 2011-09-19 09:19:33 UTC (rev 95406) +++ trunk/LayoutTests/platform/qt-arm/Skipped 2011-09-19 12:48:48 UTC (rev 95407) @@ -105,3 +105,8 @@ # https://bugs.webkit.org/show_bug.cgi?id=68151 inspector/timeline/timeline-animation-frame.html inspector/timeline/timeline-enum-stability.html + +# [Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav-media-elements.html fail +# https://bugs.webkit.org/show_bug.cgi?id=68341 +fast/events/media-element-focus-tab.html +fast/spatial-navigation/snav-media-elements.html \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95081] trunk/LayoutTests
Title: [95081] trunk/LayoutTests Revision 95081 Author rga...@webkit.org Date 2011-09-14 01:25:20 -0700 (Wed, 14 Sep 2011) Log Message [Qt] Unreviewed, update test expectations for svg/custom/dynamic-svg-document-creation.svg after r95030 * platform/qt/svg/custom/dynamic-svg-document-creation-expected.png: * platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.png trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (95080 => 95081) --- trunk/LayoutTests/ChangeLog 2011-09-14 08:10:05 UTC (rev 95080) +++ trunk/LayoutTests/ChangeLog 2011-09-14 08:25:20 UTC (rev 95081) @@ -1,3 +1,11 @@ +2011-09-14 Gabor Rapcsanyi rga...@webkit.org + +[Qt] Unreviewed, update test expectations for +svg/custom/dynamic-svg-document-creation.svg after r95030 + +* platform/qt/svg/custom/dynamic-svg-document-creation-expected.png: +* platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt: + 2011-09-14 Ben Wells benwe...@chromium.org Large canvas fills should not crash or create unnecessarily large image buffers Modified: trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt (95080 => 95081) --- trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt 2011-09-14 08:10:05 UTC (rev 95080) +++ trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt 2011-09-14 08:25:20 UTC (rev 95081) @@ -24,11 +24,11 @@ RenderText {#text} at (0,0) size 668x22 text run at (0,0) width 668: SVGDocument's rootElement first child: [object SVGGElement] should be: [object SVGGElement] RenderBlock {div} at (0,132) size 800x88 -RenderText {#text} at (0,0) size 798x88 +RenderText {#text} at (0,0) size 789x88 text run at (0,0) width 786: XMLSerializer.serializeToString returned: svg xmlns=\http://www.w3.org/2000/svg\ width=\400\ height=\400\ text run at (0,22) width 675: g transform=\translate(-50, -50)\path id=\path\ _onclick_=\mouseHandler(evt)\ fill=\#FF\ - text run at (0,44) width 798: stroke=\#00C000\ d=\M 250 130 C 185 130 150 80 150 80 S 115 25 50 25 m 0 105 c 65 0 100 -50 100 -50 s 35 -55 100 - - text run at (0,66) width 112: 55\//g/svg + text run at (0,44) width 789: stroke=\#00C000\ d=\M 250 130 C 185 130 150 80 150 80 S 115 25 50 25 m 0 105 c 65 0 100 -50 100 -50 s 35 -55 100 + text run at (0,66) width 117: -55\//g/svg RenderBlock {div} at (0,220) size 800x22 RenderText {#text} at (0,0) size 722x22 text run at (0,0) width 722: Imported the SVGGElement into our document: [object SVGGElement] should be: [object SVGGElement] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes