[webkit-changes] [193812] trunk
Title: [193812] trunk
Revision 193812
Author gyuyoung@webkit.org
Date 2015-12-09 01:58:07 -0800 (Wed, 09 Dec 2015)
Log Message
[EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
https://bugs.webkit.org/show_bug.cgi?id=151942
Reviewed by Darin Adler.
Source/WebKit2:
As wkpreference settings were moved from EwkView to WKPreferenceEfl, the offline-web-application-cache feature
is enabled by default when running API test. It seems this option should be enabled by MiniBrowser.
* UIProcess/efl/WebPreferencesEfl.cpp:
(WebKit::WebPreferences::platformInitializeStore): Remove to enable web application cache feature here.
Tools:
* MiniBrowser/efl/main.c:
(window_create): Enable offline web application cache feature on MiniBrowser.
(elm_main):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/efl/WebPreferencesEfl.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/efl/main.c
Diff
Modified: trunk/Source/WebKit2/ChangeLog (193811 => 193812)
--- trunk/Source/WebKit2/ChangeLog 2015-12-09 09:42:39 UTC (rev 193811)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-09 09:58:07 UTC (rev 193812)
@@ -1,3 +1,16 @@
+2015-12-09 Gyuyoung Kim
+
+[EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
+https://bugs.webkit.org/show_bug.cgi?id=151942
+
+Reviewed by Darin Adler.
+
+As wkpreference settings were moved from EwkView to WKPreferenceEfl, the offline-web-application-cache feature
+is enabled by default when running API test. It seems this option should be enabled by MiniBrowser.
+
+* UIProcess/efl/WebPreferencesEfl.cpp:
+(WebKit::WebPreferences::platformInitializeStore): Remove to enable web application cache feature here.
+
2015-12-09 Ryuan Choi
[CoordinatedGraphics] layerTreeHost always exist in CoordinatedDrawingArea
Modified: trunk/Source/WebKit2/UIProcess/efl/WebPreferencesEfl.cpp (193811 => 193812)
--- trunk/Source/WebKit2/UIProcess/efl/WebPreferencesEfl.cpp 2015-12-09 09:42:39 UTC (rev 193811)
+++ trunk/Source/WebKit2/UIProcess/efl/WebPreferencesEfl.cpp 2015-12-09 09:58:07 UTC (rev 193812)
@@ -35,7 +35,6 @@
setWebGLEnabled(true);
setFullScreenEnabled(true);
setWebAudioEnabled(true);
-setOfflineWebApplicationCacheEnabled(true);
#if ENABLE(SPELLCHECK)
setAsynchronousSpellCheckingEnabled(true);
#endif
Modified: trunk/Tools/ChangeLog (193811 => 193812)
--- trunk/Tools/ChangeLog 2015-12-09 09:42:39 UTC (rev 193811)
+++ trunk/Tools/ChangeLog 2015-12-09 09:58:07 UTC (rev 193812)
@@ -1,3 +1,14 @@
+2015-12-09 Gyuyoung Kim
+
+[EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
+https://bugs.webkit.org/show_bug.cgi?id=151942
+
+Reviewed by Darin Adler.
+
+* MiniBrowser/efl/main.c:
+(window_create): Enable offline web application cache feature on MiniBrowser.
+(elm_main):
+
2015-12-08 Aakash Jain
https://bugs.webkit.org/show_bug.cgi?id=151243
Modified: trunk/Tools/MiniBrowser/efl/main.c (193811 => 193812)
--- trunk/Tools/MiniBrowser/efl/main.c 2015-12-09 09:42:39 UTC (rev 193811)
+++ trunk/Tools/MiniBrowser/efl/main.c 2015-12-09 09:58:07 UTC (rev 193812)
@@ -47,6 +47,7 @@
static Eina_Bool encoding_detector_enabled = EINA_FALSE;
static Eina_Bool frame_flattening_enabled = EINA_FALSE;
static Eina_Bool local_storage_enabled = EINA_TRUE;
+static Eina_Bool offline_web_application_cache_enabled = EINA_TRUE;
static Eina_Bool fullscreen_enabled = EINA_FALSE;
static Eina_Bool spell_checking_enabled = EINA_FALSE;
static Eina_Bool web_security_enabled = EINA_TRUE;
@@ -2354,6 +2355,7 @@
ewk_settings_encoding_detector_enabled_set(settings, encoding_detector_enabled);
ewk_settings_frame_flattening_enabled_set(settings, frame_flattening_enabled);
ewk_settings_local_storage_enabled_set(settings, local_storage_enabled);
+ewk_settings_offline_web_application_cache_enabled_set(settings, offline_web_application_cache_enabled);
INFO("HTML5 local storage is %s for this view.", local_storage_enabled ? "enabled" : "disabled");
ewk_settings_developer_extras_enabled_set(settings, EINA_TRUE);
ewk_settings_preferred_minimum_contents_width_set(settings, 0);
@@ -2420,6 +2422,7 @@
ECORE_GETOPT_VALUE_STR(background_color_string),
ECORE_GETOPT_VALUE_BOOL(frame_flattening_enabled),
ECORE_GETOPT_VALUE_BOOL(local_storage_enabled),
+ECORE_GETOPT_VALUE_BOOL(offline_web_application_cache_enabled),
ECORE_GETOPT_VALUE_BOOL(fullscreen_enabled),
ECORE_GETOPT_VALUE_BOOL(spell_checking_enabled),
ECORE_GETOPT_VALUE_BOOL(touch_events_enabled),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193814] trunk/Source/WebCore
Title: [193814] trunk/Source/WebCore
Revision 193814
Author zandober...@gmail.com
Date 2015-12-09 02:35:35 -0800 (Wed, 09 Dec 2015)
Log Message
Make AudioBusGtk implementation GLib-specific
https://bugs.webkit.org/show_bug.cgi?id=152049
Reviewed by Philippe Normand.
AudioBusGtk only depends on GLib, so it should be moved to
Source/WebCore/platform/audio/glib and the implementation file
renamed to AudioBusGLib.cpp.
The hard-coded webkitgtk path component can be addressed later.
* PlatformGTK.cmake: Update the build target.
* platform/audio/glib/AudioBusGLib.cpp: Renamed from Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp.
(WebCore::AudioBus::loadPlatformResource):
* platform/audio/gtk/AudioBusGtk.cpp:
(WebCore::AudioBus::loadPlatformResource): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
Added Paths
trunk/Source/WebCore/platform/audio/glib/
trunk/Source/WebCore/platform/audio/glib/AudioBusGLib.cpp
Removed Paths
trunk/Source/WebCore/platform/audio/gtk/
Diff
Modified: trunk/Source/WebCore/ChangeLog (193813 => 193814)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 10:09:05 UTC (rev 193813)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 10:35:35 UTC (rev 193814)
@@ -1,3 +1,22 @@
+2015-12-09 Zan Dobersek
+
+Make AudioBusGtk implementation GLib-specific
+https://bugs.webkit.org/show_bug.cgi?id=152049
+
+Reviewed by Philippe Normand.
+
+AudioBusGtk only depends on GLib, so it should be moved to
+Source/WebCore/platform/audio/glib and the implementation file
+renamed to AudioBusGLib.cpp.
+
+The hard-coded webkitgtk path component can be addressed later.
+
+* PlatformGTK.cmake: Update the build target.
+* platform/audio/glib/AudioBusGLib.cpp: Renamed from Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp.
+(WebCore::AudioBus::loadPlatformResource):
+* platform/audio/gtk/AudioBusGtk.cpp:
+(WebCore::AudioBus::loadPlatformResource): Deleted.
+
2015-12-09 Joanmarie Diggs
AX: [EFL] Consider deferring to WebCore Accessibility for table exposure
Modified: trunk/Source/WebCore/PlatformGTK.cmake (193813 => 193814)
--- trunk/Source/WebCore/PlatformGTK.cmake 2015-12-09 10:09:05 UTC (rev 193813)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2015-12-09 10:35:35 UTC (rev 193814)
@@ -77,14 +77,14 @@
platform/KillRingNone.cpp
platform/PlatformStrategies.cpp
+platform/audio/glib/AudioBusGLib.cpp
+
platform/audio/gstreamer/AudioDestinationGStreamer.cpp
platform/audio/gstreamer/AudioFileReaderGStreamer.cpp
platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp
platform/audio/gstreamer/FFTFrameGStreamer.cpp
platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
-platform/audio/gtk/AudioBusGtk.cpp
-
platform/geoclue/GeolocationProviderGeoclue1.cpp
platform/geoclue/GeolocationProviderGeoclue2.cpp
Added: trunk/Source/WebCore/platform/audio/glib/AudioBusGLib.cpp (0 => 193814)
--- trunk/Source/WebCore/platform/audio/glib/AudioBusGLib.cpp (rev 0)
+++ trunk/Source/WebCore/platform/audio/glib/AudioBusGLib.cpp 2015-12-09 10:35:35 UTC (rev 193814)
@@ -0,0 +1,42 @@
+/*
+ * Copyright (C) 2011 Igalia S.L
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include "config.h"
+
+#if ENABLE(WEB_AUDIO)
+
+#include "AudioBus.h"
+
+#include "AudioFileReader.h"
+#include
+#include
+#include
+
+namespace WebCore {
+
+PassRefPtr AudioBus::loadPlatformResource(const char* name, float sampleRate)
+{
+GUniquePtr path(g_strdup_printf("/org/webkitgtk/resources/audio/%s", name));
+GRefPtr data = "" G_RESOURCE_LOOKUP_FLAGS_NONE, nullptr));
+ASSERT(data);
+return createBusFromInMemoryAudioFile(g_bytes_get_data(data.get(), nullptr), g_bytes_get_size(data.get()), false, sampleRate);
+}
+
+} // namespace WebCore
+
+#endif // ENABLE(WEB_AUDIO)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193815] trunk/Tools
Title: [193815] trunk/Tools
Revision 193815
Author ma...@webkit.org
Date 2015-12-09 03:09:31 -0800 (Wed, 09 Dec 2015)
Log Message
Refactored initialization code in LoadTrackingTest.
Rubber-stamped by Carlos Garcia Campos.
Small refactoring to make sure that the state of a LoadTrackingTest
gets properly reset before loading new web content.
* TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
* TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
(LoadTrackingTest::reset): New, refactored code from *load*() and go*()
functions and reset the remaining local variables.
(LoadTrackingTest::loadURI): Call reset();
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadBytes): Ditto.
(LoadTrackingTest::loadRequest): Ditto.
(LoadTrackingTest::reload): Ditto.
(LoadTrackingTest::goBack): Ditto.
(LoadTrackingTest::goForward): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp
trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h
Diff
Modified: trunk/Tools/ChangeLog (193814 => 193815)
--- trunk/Tools/ChangeLog 2015-12-09 10:35:35 UTC (rev 193814)
+++ trunk/Tools/ChangeLog 2015-12-09 11:09:31 UTC (rev 193815)
@@ -1,3 +1,25 @@
+2015-12-09 Mario Sanchez Prada
+
+Refactored initialization code in LoadTrackingTest.
+
+Rubber-stamped by Carlos Garcia Campos.
+
+Small refactoring to make sure that the state of a LoadTrackingTest
+gets properly reset before loading new web content.
+
+* TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
+* TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
+(LoadTrackingTest::reset): New, refactored code from *load*() and go*()
+functions and reset the remaining local variables.
+(LoadTrackingTest::loadURI): Call reset();
+(LoadTrackingTest::loadHtml): Ditto.
+(LoadTrackingTest::loadPlainText): Ditto.
+(LoadTrackingTest::loadBytes): Ditto.
+(LoadTrackingTest::loadRequest): Ditto.
+(LoadTrackingTest::reload): Ditto.
+(LoadTrackingTest::goBack): Ditto.
+(LoadTrackingTest::goForward): Ditto.
+
2015-12-09 Gyuyoung Kim
[EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
Modified: trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp (193814 => 193815)
--- trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp 2015-12-09 10:35:35 UTC (rev 193814)
+++ trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp 2015-12-09 11:09:31 UTC (rev 193815)
@@ -180,64 +180,57 @@
void LoadTrackingTest::loadURI(const char* uri)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadURI(uri);
}
void LoadTrackingTest::loadHtml(const char* html, const char* baseURI)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadHtml(html, baseURI);
}
void LoadTrackingTest::loadPlainText(const char* plainText)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadPlainText(plainText);
}
void LoadTrackingTest::loadBytes(GBytes* bytes, const char* mimeType, const char* encoding, const char* baseURI)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadBytes(bytes, mimeType, encoding, baseURI);
}
void LoadTrackingTest::loadRequest(WebKitURIRequest* request)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadRequest(request);
}
void LoadTrackingTest::reload()
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
webkit_web_view_reload(m_webView);
}
void LoadTrackingTest::goBack()
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::goBack();
}
void LoadTrackingTest::goForward()
{
+reset();
+WebViewTest::goForward();
+}
+
+void LoadTrackingTest::reset()
+{
+m_runLoadUntilCompletion = false;
+m_loadFailed = false;
m_loadEvents.clear();
m_estimatedProgress = 0;
m_error.reset();
-WebViewTest::goForward();
}
Modified: trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h (193814 => 193815)
--- trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h 2015-12-09 10:35:35 UTC (rev 193814)
+++ trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h 2015-12-09 11:09:31 UTC (rev 193815)
@@ -48,6 +48,7 @@
void reload();
void goBack();
void goForward();
+void reset();
void setRedirectURI(const char* uri) { m_redirectURI = uri; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193817] trunk/Source/WebCore
Title: [193817] trunk/Source/WebCore Revision 193817 Author zandober...@gmail.com Date 2015-12-09 03:20:33 -0800 (Wed, 09 Dec 2015) Log Message [Soup] SocketStreamHandle should call g_source_destroy() on the write-ready source https://bugs.webkit.org/show_bug.cgi?id=152040 Reviewed by Carlos Garcia Campos. * platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Instead of calling the g_source_get_id()-g_source_remove() pair, destroy the source via the g_source_destroy() call. Also use nullptr to clear out the pointer variable. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (193816 => 193817) --- trunk/Source/WebCore/ChangeLog 2015-12-09 11:12:52 UTC (rev 193816) +++ trunk/Source/WebCore/ChangeLog 2015-12-09 11:20:33 UTC (rev 193817) @@ -1,5 +1,18 @@ 2015-12-09 Zan Dobersek +[Soup] SocketStreamHandle should call g_source_destroy() on the write-ready source +https://bugs.webkit.org/show_bug.cgi?id=152040 + +Reviewed by Carlos Garcia Campos. + +* platform/network/soup/SocketStreamHandleSoup.cpp: +(WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Instead of +calling the g_source_get_id()-g_source_remove() pair, destroy the source via +the g_source_destroy() call. Also use nullptr to clear out the pointer +variable. + +2015-12-09 Zan Dobersek + Make AudioBusGtk implementation GLib-specific https://bugs.webkit.org/show_bug.cgi?id=152049 Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (193816 => 193817) --- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2015-12-09 11:12:52 UTC (rev 193816) +++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2015-12-09 11:20:33 UTC (rev 193817) @@ -253,8 +253,8 @@ if (!m_writeReadySource) // Not waiting. return; -g_source_remove(g_source_get_id(m_writeReadySource.get())); -m_writeReadySource = 0; +g_source_destroy(m_writeReadySource.get()); +m_writeReadySource = nullptr; } static void connectedCallback(GSocketClient* client, GAsyncResult* result, void* id) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193818] trunk/Source/WebCore
Title: [193818] trunk/Source/WebCore Revision 193818 Author zandober...@gmail.com Date 2015-12-09 03:22:00 -0800 (Wed, 09 Dec 2015) Log Message [Soup] Attach the SocketStreamHandleSoup write-ready source to the thread-default context https://bugs.webkit.org/show_bug.cgi?id=152041 Reviewed by Carlos Garcia Campos. * platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Attach the write-ready source to the thread-default context, instead of implicitly relying on the default context for dispatching. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (193817 => 193818) --- trunk/Source/WebCore/ChangeLog 2015-12-09 11:20:33 UTC (rev 193817) +++ trunk/Source/WebCore/ChangeLog 2015-12-09 11:22:00 UTC (rev 193818) @@ -1,5 +1,17 @@ 2015-12-09 Zan Dobersek +[Soup] Attach the SocketStreamHandleSoup write-ready source to the thread-default context +https://bugs.webkit.org/show_bug.cgi?id=152041 + +Reviewed by Carlos Garcia Campos. + +* platform/network/soup/SocketStreamHandleSoup.cpp: +(WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Attach the +write-ready source to the thread-default context, instead of implicitly +relying on the default context for dispatching. + +2015-12-09 Zan Dobersek + [Soup] SocketStreamHandle should call g_source_destroy() on the write-ready source https://bugs.webkit.org/show_bug.cgi?id=152040 Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (193817 => 193818) --- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2015-12-09 11:20:33 UTC (rev 193817) +++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2015-12-09 11:22:00 UTC (rev 193818) @@ -245,7 +245,7 @@ m_writeReadySource = adoptGRef(g_pollable_output_stream_create_source(m_outputStream.get(), 0)); g_source_set_callback(m_writeReadySource.get(), reinterpret_cast(writeReadyCallback), m_id, 0); -g_source_attach(m_writeReadySource.get(), 0); +g_source_attach(m_writeReadySource.get(), g_main_context_get_thread_default()); } void SocketStreamHandle::stopWaitingForSocketWritability() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193819] trunk/Source/WebCore
Title: [193819] trunk/Source/WebCore
Revision 193819
Author zandober...@gmail.com
Date 2015-12-09 03:26:30 -0800 (Wed, 09 Dec 2015)
Log Message
[TextureMapper] TextureMapperShaderProgram::setMatrix() should use TransformationMatrix::FloatMatrix4
https://bugs.webkit.org/show_bug.cgi?id=152042
Reviewed by Martin Robinson.
* platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore::TextureMapperShaderProgram::setMatrix): Instead of manually writing out
the complete matrix in a C array, simply use TransformationMatrix::FloatMatrix4
and fill that via the TransformationMatrix::toColumnMajorFloatArray() method
called on the passed-in TransformationMatrix.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (193818 => 193819)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 11:22:00 UTC (rev 193818)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 11:26:30 UTC (rev 193819)
@@ -1,5 +1,18 @@
2015-12-09 Zan Dobersek
+[TextureMapper] TextureMapperShaderProgram::setMatrix() should use TransformationMatrix::FloatMatrix4
+https://bugs.webkit.org/show_bug.cgi?id=152042
+
+Reviewed by Martin Robinson.
+
+* platform/graphics/texmap/TextureMapperShaderProgram.cpp:
+(WebCore::TextureMapperShaderProgram::setMatrix): Instead of manually writing out
+the complete matrix in a C array, simply use TransformationMatrix::FloatMatrix4
+and fill that via the TransformationMatrix::toColumnMajorFloatArray() method
+called on the passed-in TransformationMatrix.
+
+2015-12-09 Zan Dobersek
+
[Soup] Attach the SocketStreamHandleSoup write-ready source to the thread-default context
https://bugs.webkit.org/show_bug.cgi?id=152041
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp (193818 => 193819)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp 2015-12-09 11:22:00 UTC (rev 193818)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp 2015-12-09 11:26:30 UTC (rev 193819)
@@ -73,14 +73,9 @@
void TextureMapperShaderProgram::setMatrix(GC3Duint location, const TransformationMatrix& matrix)
{
-GC3Dfloat matrixAsFloats[] = {
-GC3Dfloat(matrix.m11()), GC3Dfloat(matrix.m12()), GC3Dfloat(matrix.m13()), GC3Dfloat(matrix.m14()),
-GC3Dfloat(matrix.m21()), GC3Dfloat(matrix.m22()), GC3Dfloat(matrix.m23()), GC3Dfloat(matrix.m24()),
-GC3Dfloat(matrix.m31()), GC3Dfloat(matrix.m32()), GC3Dfloat(matrix.m33()), GC3Dfloat(matrix.m34()),
-GC3Dfloat(matrix.m41()), GC3Dfloat(matrix.m42()), GC3Dfloat(matrix.m43()), GC3Dfloat(matrix.m44())
-};
-
-m_context->uniformMatrix4fv(location, 1, false, matrixAsFloats);
+TransformationMatrix::FloatMatrix4 floatMatrix;
+matrix.toColumnMajorFloatArray(floatMatrix);
+m_context->uniformMatrix4fv(location, 1, false, floatMatrix);
}
GC3Duint TextureMapperShaderProgram::getLocation(const AtomicString& name, VariableType type)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193820] trunk/Source/WebCore
Title: [193820] trunk/Source/WebCore Revision 193820 Author zandober...@gmail.com Date 2015-12-09 03:27:56 -0800 (Wed, 09 Dec 2015) Log Message Make MainThreadSharedTimerGtk implementation GLib-specific https://bugs.webkit.org/show_bug.cgi?id=152044 Reviewed by Carlos Garcia Campos. MainThreadSharedTimerGtk has implementation that only directly depends on GLib, and not GTK+. Because of that it can be moved under Source/WebCore/platform/glib and slightly renamed. * PlatformGTK.cmake: * platform/glib/MainThreadSharedTimerGLib.cpp: Renamed from Source/WebCore/platform/gtk/MainThreadSharedTimerGtk.cpp. (WebCore::MainThreadSharedTimer::MainThreadSharedTimer): (WebCore::MainThreadSharedTimer::setFireInterval): (WebCore::MainThreadSharedTimer::stop): (WebCore::MainThreadSharedTimer::invalidate): * platform/gtk/MainThreadSharedTimerGtk.cpp: (WebCore::MainThreadSharedTimer::MainThreadSharedTimer): Deleted. (WebCore::MainThreadSharedTimer::setFireInterval): Deleted. (WebCore::MainThreadSharedTimer::stop): Deleted. (WebCore::MainThreadSharedTimer::invalidate): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformGTK.cmake Added Paths trunk/Source/WebCore/platform/glib/MainThreadSharedTimerGLib.cpp Removed Paths trunk/Source/WebCore/platform/gtk/MainThreadSharedTimerGtk.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (193819 => 193820) --- trunk/Source/WebCore/ChangeLog 2015-12-09 11:26:30 UTC (rev 193819) +++ trunk/Source/WebCore/ChangeLog 2015-12-09 11:27:56 UTC (rev 193820) @@ -1,5 +1,28 @@ 2015-12-09 Zan Dobersek +Make MainThreadSharedTimerGtk implementation GLib-specific +https://bugs.webkit.org/show_bug.cgi?id=152044 + +Reviewed by Carlos Garcia Campos. + +MainThreadSharedTimerGtk has implementation that only directly depends +on GLib, and not GTK+. Because of that it can be moved under +Source/WebCore/platform/glib and slightly renamed. + +* PlatformGTK.cmake: +* platform/glib/MainThreadSharedTimerGLib.cpp: Renamed from Source/WebCore/platform/gtk/MainThreadSharedTimerGtk.cpp. +(WebCore::MainThreadSharedTimer::MainThreadSharedTimer): +(WebCore::MainThreadSharedTimer::setFireInterval): +(WebCore::MainThreadSharedTimer::stop): +(WebCore::MainThreadSharedTimer::invalidate): +* platform/gtk/MainThreadSharedTimerGtk.cpp: +(WebCore::MainThreadSharedTimer::MainThreadSharedTimer): Deleted. +(WebCore::MainThreadSharedTimer::setFireInterval): Deleted. +(WebCore::MainThreadSharedTimer::stop): Deleted. +(WebCore::MainThreadSharedTimer::invalidate): Deleted. + +2015-12-09 Zan Dobersek + [TextureMapper] TextureMapperShaderProgram::setMatrix() should use TransformationMatrix::FloatMatrix4 https://bugs.webkit.org/show_bug.cgi?id=152042 Modified: trunk/Source/WebCore/PlatformGTK.cmake (193819 => 193820) --- trunk/Source/WebCore/PlatformGTK.cmake 2015-12-09 11:26:30 UTC (rev 193819) +++ trunk/Source/WebCore/PlatformGTK.cmake 2015-12-09 11:27:56 UTC (rev 193820) @@ -90,6 +90,7 @@ platform/glib/KeyedDecoderGlib.cpp platform/glib/KeyedEncoderGlib.cpp +platform/glib/MainThreadSharedTimerGLib.cpp platform/graphics/GLContext.cpp platform/graphics/GraphicsContext3DPrivate.cpp @@ -162,7 +163,6 @@ platform/gtk/LanguageGtk.cpp platform/gtk/LoggingGtk.cpp platform/gtk/MIMETypeRegistryGtk.cpp -platform/gtk/MainThreadSharedTimerGtk.cpp platform/gtk/SharedBufferGtk.cpp platform/gtk/TemporaryLinkStubs.cpp platform/gtk/UserAgentGtk.cpp Added: trunk/Source/WebCore/platform/glib/MainThreadSharedTimerGLib.cpp (0 => 193820) --- trunk/Source/WebCore/platform/glib/MainThreadSharedTimerGLib.cpp (rev 0) +++ trunk/Source/WebCore/platform/glib/MainThreadSharedTimerGLib.cpp 2015-12-09 11:27:56 UTC (rev 193820) @@ -0,0 +1,57 @@ +/* + * Copyright (C) 2006 Apple Inc. All rights reserved. + * Copyright (C) 2006 Michael Emmel mike.em...@gmail.com + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR + * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, + * EXEMPLARY, OR CONSEQUENTIA
[webkit-changes] [193822] trunk/Source/WebKit2
Title: [193822] trunk/Source/WebKit2
Revision 193822
Author gyuyoung@webkit.org
Date 2015-12-09 03:43:18 -0800 (Wed, 09 Dec 2015)
Log Message
[EFL] Missing to set ignoreTLSError to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=152047
Reviewed by Csaba Osztrogonác.
NetworkProcess has been enabled for all ports since r192796 though, EFL port
didn't send the ignoreTLSError value to NetworkProcess. This has caused failure of EFL API tests
related with ssl feature.
* UIProcess/efl/WebProcessPoolEfl.cpp:
(WebKit::WebProcessPool::setIgnoreTLSErrors):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/efl/WebProcessPoolEfl.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (193821 => 193822)
--- trunk/Source/WebKit2/ChangeLog 2015-12-09 11:33:24 UTC (rev 193821)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-09 11:43:18 UTC (rev 193822)
@@ -1,5 +1,19 @@
2015-12-09 Gyuyoung Kim
+[EFL] Missing to set ignoreTLSError to NetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=152047
+
+Reviewed by Csaba Osztrogonác.
+
+NetworkProcess has been enabled for all ports since r192796 though, EFL port
+didn't send the ignoreTLSError value to NetworkProcess. This has caused failure of EFL API tests
+related with ssl feature.
+
+* UIProcess/efl/WebProcessPoolEfl.cpp:
+(WebKit::WebProcessPool::setIgnoreTLSErrors):
+
+2015-12-09 Gyuyoung Kim
+
[EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
https://bugs.webkit.org/show_bug.cgi?id=151942
Modified: trunk/Source/WebKit2/UIProcess/efl/WebProcessPoolEfl.cpp (193821 => 193822)
--- trunk/Source/WebKit2/UIProcess/efl/WebProcessPoolEfl.cpp 2015-12-09 11:33:24 UTC (rev 193821)
+++ trunk/Source/WebKit2/UIProcess/efl/WebProcessPoolEfl.cpp 2015-12-09 11:43:18 UTC (rev 193822)
@@ -28,6 +28,7 @@
#include "APIProcessPoolConfiguration.h"
#include "Logging.h"
+#include "NetworkProcessMessages.h"
#include "WebCookieManagerProxy.h"
#include "WebInspectorServer.h"
#include "WebProcessCreationParameters.h"
@@ -140,6 +141,8 @@
void WebProcessPool::setIgnoreTLSErrors(bool ignoreTLSErrors)
{
m_ignoreTLSErrors = ignoreTLSErrors;
+if (networkProcess())
+networkProcess()->send(Messages::NetworkProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors), 0);
}
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193826] trunk
Title: [193826] trunk Revision 193826 Author carlo...@webkit.org Date 2015-12-09 05:32:54 -0800 (Wed, 09 Dec 2015) Log Message [GTK] Add API to handle beforeunload events https://bugs.webkit.org/show_bug.cgi?id=139090 Reviewed by Gustavo Noronha Silva. Source/WebKit2: beforeunload is fired when a page is about to be closed, to ask the user for confirmation. This happens when reloading a page, when navigating to another page or when the page is closed by a user action (a tab or window closed). In the first two cases, the event is automatically fired by WebCore, but in the case of a user action we need additional API to ensure the event is fired before the page is closed. A new script dialog type has been added to handle beforeunload events and webkit_web_view_try_close() to allow applications to try to close the page. * UIProcess/API/gtk/WebKitScriptDialog.cpp: (webkit_script_dialog_confirm_set_confirmed): BeforeUnloadConfirm dialogs can also be confirmed. * UIProcess/API/gtk/WebKitScriptDialog.h: Add WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM script dialog type. * UIProcess/API/gtk/WebKitUIClient.cpp: Implement canRunBeforeUnloadConfirmPanel() and runBeforeUnloadConfirmPanel(). * UIProcess/API/gtk/WebKitWebView.cpp: (webkitWebViewCreateJavaScriptDialog): Add secondaryText optional parameter for BeforeUnloadConfirm dialogs. Do not set the default response if the dialog was created without buttons. (webkitWebViewScriptDialog): Handle WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM script dialog type to create a message dialog for beforeunlos events. (webkit_web_view_class_init): Update documentation of WebKitWebView::close and WebKitWebView::script-dialog. (webkitWebViewRunJavaScriptBeforeUnloadConfirm): Emit WebKitWebView::script-dialog. (webkit_web_view_try_close): Try to close the page. * UIProcess/API/gtk/WebKitWebView.h: * UIProcess/API/gtk/WebKitWebViewPrivate.h: * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol. Tools: * MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): (browserWindowDeleteEvent): (browser_window_class_init): Handle delete-event to prevent the window from being closed when the page has beforeunload handlers. Use webkit_web_view_try_close() when the window is requested to be closed. * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewJavaScriptDialogs): Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM script dialog type. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitScriptDialog.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitScriptDialog.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/gtk/BrowserWindow.c trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (193825 => 193826) --- trunk/Source/WebKit2/ChangeLog 2015-12-09 13:30:11 UTC (rev 193825) +++ trunk/Source/WebKit2/ChangeLog 2015-12-09 13:32:54 UTC (rev 193826) @@ -1,3 +1,42 @@ +2015-12-09 Carlos Garcia Campos + +[GTK] Add API to handle beforeunload events +https://bugs.webkit.org/show_bug.cgi?id=139090 + +Reviewed by Gustavo Noronha Silva. + +beforeunload is fired when a page is about to be closed, to ask +the user for confirmation. This happens when reloading a page, +when navigating to another page or when the page is closed by a +user action (a tab or window closed). In the first two cases, the +event is automatically fired by WebCore, but in the case of a user +action we need additional API to ensure the event is fired before +the page is closed. A new script dialog type has been added to +handle beforeunload events and webkit_web_view_try_close() to +allow applications to try to close the page. + +* UIProcess/API/gtk/WebKitScriptDialog.cpp: +(webkit_script_dialog_confirm_set_confirmed): BeforeUnloadConfirm +dialogs can also be confirmed. +* UIProcess/API/gtk/WebKitScriptDialog.h: Add +WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM script dialog type. +* UIProcess/API/gtk/WebKitUIClient.cpp: Implement +canRunBeforeUnloadConfirmPanel() and runBeforeUnloadConfirmPanel(). +* UIProcess/API/gtk/WebKitWebView.cpp: +(webkitWebViewCreateJavaScriptDialog): Add secondaryText optional +parameter for BeforeUnloadConfirm dialogs. Do not set the default +response if the dialog was created without buttons. +(webkitWebViewScriptDialog): Handle +WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM script dialog type to +create a message dialog for beforeunlos events. +(web
[webkit-changes] [193828] trunk/Source/WebCore
Title: [193828] trunk/Source/WebCore
Revision 193828
Author zandober...@gmail.com
Date 2015-12-09 06:03:34 -0800 (Wed, 09 Dec 2015)
Log Message
[TexMap] TextureMapperTiledBackingStore should notify the ImageObserver of the data access
https://bugs.webkit.org/show_bug.cgi?id=152053
Reviewed by Martin Robinson.
TextureMapperTiledBackingStore should call ImageObserver::didDraw() on the Image's
observer after updating the tile with the Image's data. This way the CachedImage
(i.e. the observer) can mark the data access with the current timestamp, avoiding
removing the decoded data in the very near future during a cache purge.
* platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperTiledBackingStore.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (193827 => 193828)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 14:00:03 UTC (rev 193827)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 14:03:34 UTC (rev 193828)
@@ -1,5 +1,20 @@
2015-12-09 Zan Dobersek
+[TexMap] TextureMapperTiledBackingStore should notify the ImageObserver of the data access
+https://bugs.webkit.org/show_bug.cgi?id=152053
+
+Reviewed by Martin Robinson.
+
+TextureMapperTiledBackingStore should call ImageObserver::didDraw() on the Image's
+observer after updating the tile with the Image's data. This way the CachedImage
+(i.e. the observer) can mark the data access with the current timestamp, avoiding
+removing the decoded data in the very near future during a cache purge.
+
+* platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
+(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
+
+2015-12-09 Zan Dobersek
+
Make MainThreadSharedTimerGtk implementation GLib-specific
https://bugs.webkit.org/show_bug.cgi?id=152044
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperTiledBackingStore.cpp (193827 => 193828)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperTiledBackingStore.cpp 2015-12-09 14:00:03 UTC (rev 193827)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperTiledBackingStore.cpp 2015-12-09 14:03:34 UTC (rev 193828)
@@ -23,6 +23,7 @@
#include "TextureMapperTiledBackingStore.h"
#include "ImageBuffer.h"
+#include "ImageObserver.h"
#include "TextureMapper.h"
namespace WebCore {
@@ -35,6 +36,9 @@
return;
updateContents(textureMapper, m_image.get(), m_image->size(), enclosingIntRect(m_image->rect()), BitmapTexture::UpdateCannotModifyOriginalImageData);
+
+if (m_image->imageObserver())
+m_image->imageObserver()->didDraw(m_image.get());
m_image = nullptr;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193829] trunk
Title: [193829] trunk
Revision 193829
Author fred.w...@free.fr
Date 2015-12-09 06:46:11 -0800 (Wed, 09 Dec 2015)
Log Message
Bad position of large operators inside an munderover element
https://bugs.webkit.org/show_bug.cgi?id=151916
Reviewed by Alejandro G. Castro.
Source/WebCore:
Test: mathml/opentype/large-operators-munderover.html
* rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::isVertical): Expose the direction of the operator.
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout): Remove call to horizontal stretching for vertical operators.
LayoutTests:
* mathml/opentype/large-operators-munderover-expected.txt: Added.
* mathml/opentype/large-operators-munderover.html: Added.
Add a test to verify the position and size of a large operator used as an munderover base.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h
trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp
Added Paths
trunk/LayoutTests/mathml/opentype/large-operators-munderover-expected.txt
trunk/LayoutTests/mathml/opentype/large-operators-munderover.html
Diff
Modified: trunk/LayoutTests/ChangeLog (193828 => 193829)
--- trunk/LayoutTests/ChangeLog 2015-12-09 14:03:34 UTC (rev 193828)
+++ trunk/LayoutTests/ChangeLog 2015-12-09 14:46:11 UTC (rev 193829)
@@ -1,3 +1,15 @@
+2015-12-09 Frederic Wang
+
+Bad position of large operators inside an munderover element
+https://bugs.webkit.org/show_bug.cgi?id=151916
+
+Reviewed by Alejandro G. Castro.
+
+* mathml/opentype/large-operators-munderover-expected.txt: Added.
+* mathml/opentype/large-operators-munderover.html: Added.
+
+Add a test to verify the position and size of a large operator used as an munderover base.
+
2015-12-09 Joanmarie Diggs
[AX][GTK] Accessibility gardening
Added: trunk/LayoutTests/mathml/opentype/large-operators-munderover-expected.txt (0 => 193829)
--- trunk/LayoutTests/mathml/opentype/large-operators-munderover-expected.txt (rev 0)
+++ trunk/LayoutTests/mathml/opentype/large-operators-munderover-expected.txt 2015-12-09 14:46:11 UTC (rev 193829)
@@ -0,0 +1,7 @@
+This test passes if you see a large black square with a green bar overscript and a red bar underscript.
+
+largeop width: PASS
+largeop height: PASS
+green bar is above: PASS
+red bar is below: PASS
+
Property changes on: trunk/LayoutTests/mathml/opentype/large-operators-munderover-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/mathml/opentype/large-operators-munderover.html (0 => 193829)
--- trunk/LayoutTests/mathml/opentype/large-operators-munderover.html (rev 0)
+++ trunk/LayoutTests/mathml/opentype/large-operators-munderover.html 2015-12-09 14:46:11 UTC (rev 193829)
@@ -0,0 +1,54 @@
+
+
+
+Large Operator Munderover
+
+
+ /* This font is taken from Mozilla's test suite. */
+ @font-face {
+ font-family: stretchy;
+src: url("stretchy.woff");
+ }
+ math {
+font-family: stretchy;
+ }
+
+
+ var result;
+ var epsilon = 1;
+ function almostEqual(x, y) {
+return Math.abs(x - y) < epsilon;
+ }
+ function assert(text, condition) {
+result += text + ": " + (condition ? "PASS" : "FAIL") + "\n";
+ }
+ function test() {
+result = "";
+// font em is 1024, size of glyph L8 is 8389 and font-size is 16px
+var largeop = document.getElementById("largeop").getBoundingClientRect();
+var green = document.getElementById("green").getBoundingClientRect();
+var red = document.getElementById("red").getBoundingClientRect();
+var size = (8389/1024)*16;
+
+assert("largeop width", almostEqual(largeop.width, size));
+assert("largeop height", almostEqual(largeop.height, size));
+assert("green bar is above", green.bottom <= largeop.top);
+assert("red bar is below", red.top >= largeop.bottom);
+document.getElementById("result").innerText = result;
+if (window.testRunner)
+ testRunner.dumpAsText();
+ }
+
+
+
+This test passes if you see a large black square with a green bar overscript and a red bar underscript.
+
+
+⨜
+
+
+
+
+
+
+
Property changes on: trunk/LayoutTests/mathml/opentype/large-operators-munderover.html
___
Added: svn:mime-type
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (193828 => 193829)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 14:03:34 UTC (rev 193828)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 14:46:11 UTC (rev 193829)
@@ -1,3 +1,17 @@
+2015-12-09 Frederic Wang
+
+Bad pos
[webkit-changes] [193830] trunk
Title: [193830] trunk Revision 193830 Author ma...@webkit.org Date 2015-12-09 06:52:46 -0800 (Wed, 09 Dec 2015) Log Message [GTK] Crash in WebProcess when loading large content with custom URI schemes https://bugs.webkit.org/show_bug.cgi?id=144262 Reviewed by Carlos Garcia Campos. Source/WebKit2: Properly handle scenarios where errors happen after reading the first chunk of data coming from the GInputStream provided by the application. * UIProcess/API/gtk/WebKitWebContextPrivate.h: * UIProcess/API/gtk/WebKitWebContext.cpp: (webkitWebContextIsLoadingCustomProtocol): New, checks whether a load is still in progress, after the startLoading method has been called. * UIProcess/API/gtk/WebKitURISchemeRequest.cpp: (webkitURISchemeRequestReadCallback): Early return if the stream has been cancelled on finish_error, so that we make sure we don't keep on reading the GInputStream after that point. (webkit_uri_scheme_request_finish_error): Don't send a didFailWithError message to the Network process if the load is not longer in progress. * Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp: (WebKit::CustomProtocolManagerImpl::didFailWithError): Handle the case where an error is notified from the UI process after the first chunk has been read. (WebKit::CustomProtocolManagerImpl::didReceiveResponse): Handle the case where data might no longer be available if an error happened even before this point. * WebProcess/soup/WebKitSoupRequestInputStream.h: * WebProcess/soup/WebKitSoupRequestInputStream.cpp: (webkitSoupRequestInputStreamDidFailWithError): Notify the custom GInputStream that we no longer want to keep reading data in chunks due to a specific error. (webkitSoupRequestInputStreamReadAsync): Early finish the GTask with a specific error whenever webkitSoupRequestInputStreamDidFailWithError() has been called. Tools: Added new unit test to check the additional scenarios we now handle for custom URI schemes. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (generateHTMLContent): New helper function to generate big enough content. (testWebContextURIScheme): New unit test. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURISchemeRequest.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h trunk/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp trunk/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (193829 => 193830) --- trunk/Source/WebKit2/ChangeLog 2015-12-09 14:46:11 UTC (rev 193829) +++ trunk/Source/WebKit2/ChangeLog 2015-12-09 14:52:46 UTC (rev 193830) @@ -1,3 +1,35 @@ +2015-12-09 Mario Sanchez Prada + +[GTK] Crash in WebProcess when loading large content with custom URI schemes +https://bugs.webkit.org/show_bug.cgi?id=144262 + +Reviewed by Carlos Garcia Campos. + +Properly handle scenarios where errors happen after reading the first +chunk of data coming from the GInputStream provided by the application. + +* UIProcess/API/gtk/WebKitWebContextPrivate.h: +* UIProcess/API/gtk/WebKitWebContext.cpp: +(webkitWebContextIsLoadingCustomProtocol): New, checks whether a load +is still in progress, after the startLoading method has been called. +* UIProcess/API/gtk/WebKitURISchemeRequest.cpp: +(webkitURISchemeRequestReadCallback): Early return if the stream has been +cancelled on finish_error, so that we make sure we don't keep on reading +the GInputStream after that point. +(webkit_uri_scheme_request_finish_error): Don't send a didFailWithError +message to the Network process if the load is not longer in progress. +* Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp: +(WebKit::CustomProtocolManagerImpl::didFailWithError): Handle the case where +an error is notified from the UI process after the first chunk has been read. +(WebKit::CustomProtocolManagerImpl::didReceiveResponse): Handle the case where +data might no longer be available if an error happened even before this point. +* WebProcess/soup/WebKitSoupRequestInputStream.h: +* WebProcess/soup/WebKitSoupRequestInputStream.cpp: +(webkitSoupRequestInputStreamDidFailWithError): Notify the custom GInputStream +that we no longer want to keep reading data in chunks due to a specific error. +(webkitSoupRequestInputStreamReadAsync): Early finish the GTask with a specific +error whenever webkitSoupRequestInputStreamDidFailWithError() has been called. + 2015-12-09 Ryuan Choi [CoordinatedGraphics][EFL] Fix unhandled web process message wh
[webkit-changes] [193832] trunk
Title: [193832] trunk
Revision 193832
Author calva...@igalia.com
Date 2015-12-09 07:34:28 -0800 (Wed, 09 Dec 2015)
Log Message
[Streams API] pipeThrough test failing
https://bugs.webkit.org/show_bug.cgi?id=152061
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
* web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.
Source/WebCore:
Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html
* Modules/streams/ReadableStream.js:
(pipeThrough): Mimic destructuring for the streams parameter.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/streams/ReadableStream.js
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (193831 => 193832)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-12-09 15:01:26 UTC (rev 193831)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-12-09 15:34:28 UTC (rev 193832)
@@ -1,5 +1,14 @@
2015-12-09 Xabier Rodriguez Calvar
+[Streams API] pipeThrough test failing
+https://bugs.webkit.org/show_bug.cgi?id=152061
+
+Reviewed by Youenn Fablet.
+
+* web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.
+
+2015-12-09 Xabier Rodriguez Calvar
+
[Streams API] Import the web-platform-tests directly from the spec
https://bugs.webkit.org/show_bug.cgi?id=152051
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt (193831 => 193832)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt 2015-12-09 15:01:26 UTC (rev 193831)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt 2015-12-09 15:34:28 UTC (rev 193832)
@@ -2,7 +2,7 @@
PASS ReadableStream.prototype.pipeThrough should work generically on its this and its arguments
PASS ReadableStream.prototype.pipeThrough should throw when its first argument is not convertible to an object
PASS ReadableStream.prototype.pipeThrough should throw when "this" has no pipeTo method
-FAIL ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable assert_unreached: pipeTo should not be called Reached unreachable code
+PASS ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable
PASS ReadableStream.prototype.pipeThrough should work with missing readable, writable, or options
FAIL Load pipe-through.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
Modified: trunk/Source/WebCore/ChangeLog (193831 => 193832)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 15:01:26 UTC (rev 193831)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 15:34:28 UTC (rev 193832)
@@ -1,3 +1,15 @@
+2015-12-09 Xabier Rodriguez Calvar
+
+[Streams API] pipeThrough test failing
+https://bugs.webkit.org/show_bug.cgi?id=152061
+
+Reviewed by Youenn Fablet.
+
+Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html
+
+* Modules/streams/ReadableStream.js:
+(pipeThrough): Mimic destructuring for the streams parameter.
+
2015-12-09 Frederic Wang
Bad position of large operators inside an munderover element
Modified: trunk/Source/WebCore/Modules/streams/ReadableStream.js (193831 => 193832)
--- trunk/Source/WebCore/Modules/streams/ReadableStream.js 2015-12-09 15:01:26 UTC (rev 193831)
+++ trunk/Source/WebCore/Modules/streams/ReadableStream.js 2015-12-09 15:34:28 UTC (rev 193832)
@@ -94,8 +94,10 @@
{
"use strict";
-this.pipeTo(streams.writable, options);
-return streams.readable;
+const writable = streams.writable;
+const readable = streams.readable;
+this.pipeTo(writable, options);
+return readable;
}
function pipeTo(destination, options)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193833] trunk/Websites/webkit.org
Title: [193833] trunk/Websites/webkit.org
Revision 193833
Author j...@apple.com
Date 2015-12-09 07:41:54 -0800 (Wed, 09 Dec 2015)
Log Message
Fixed function call reference.
* wp-content/themes/webkit/scripts/global.js:
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/themes/webkit/scripts/global.js
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (193832 => 193833)
--- trunk/Websites/webkit.org/ChangeLog 2015-12-09 15:34:28 UTC (rev 193832)
+++ trunk/Websites/webkit.org/ChangeLog 2015-12-09 15:41:54 UTC (rev 193833)
@@ -1,3 +1,9 @@
+2015-12-09 Jonathan Davis
+
+Fix function reference change.
+
+* wp-content/themes/webkit/scripts/global.js:
+
2015-12-08 Jonathan Davis
Wide tables should be scrollable on narrow mobile screens.
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/scripts/global.js (193832 => 193833)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/scripts/global.js 2015-12-09 15:34:28 UTC (rev 193832)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/scripts/global.js 2015-12-09 15:41:54 UTC (rev 193833)
@@ -76,7 +76,7 @@
function onMovement() {
if (!updating)
-requestAnimationFrame(update);
+requestAnimationFrame(updateImages);
updating = true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193834] trunk/LayoutTests
Title: [193834] trunk/LayoutTests Revision 193834 Author ryanhad...@apple.com Date 2015-12-09 08:54:37 -0800 (Wed, 09 Dec 2015) Log Message Marking inspector/debugger/command-line-api-exception.html as flaky on Mac https://bugs.webkit.org/show_bug.cgi?id=152029 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (193833 => 193834) --- trunk/LayoutTests/ChangeLog 2015-12-09 15:41:54 UTC (rev 193833) +++ trunk/LayoutTests/ChangeLog 2015-12-09 16:54:37 UTC (rev 193834) @@ -1,3 +1,12 @@ +2015-12-09 Ryan Haddad + +Marking inspector/debugger/command-line-api-exception.html as flaky on Mac +https://bugs.webkit.org/show_bug.cgi?id=152029 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2015-12-09 Joanmarie Diggs AX: [GTK] Remove duplicate/platform media-emits-object-replacement.html and move expectations where they belong Modified: trunk/LayoutTests/platform/mac/TestExpectations (193833 => 193834) --- trunk/LayoutTests/platform/mac/TestExpectations 2015-12-09 15:41:54 UTC (rev 193833) +++ trunk/LayoutTests/platform/mac/TestExpectations 2015-12-09 16:54:37 UTC (rev 193834) @@ -1240,6 +1240,8 @@ webkit.org/b/148636 inspector/page/main-frame-resource.html [ Pass Timeout ] webkit.org/b/148636 inspector/model/remote-object-weak-collection.html [ Pass Failure ] +webkit.org/b/152029 inspector/debugger/command-line-api-exception.html [ Pass Timeout ] + # Colorspaces on CA OpenGL layers not available in Yosemite [ Yosemite ] fast/canvas/webgl/match-page-color-space.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193835] trunk/Websites/webkit.org
Title: [193835] trunk/Websites/webkit.org
Revision 193835
Author j...@apple.com
Date 2015-12-09 09:34:04 -0800 (Wed, 09 Dec 2015)
Log Message
Fixed broken link: https://webkit.org/old/security/security-group-members.html
https://bugs.webkit.org/show_bug.cgi?id=152010
Reviewed by Timothy Hatcher.
* .htaccess:
* security-policy.md:
* wp-content/themes/webkit/style.css:
(article h4):
(article h5):
Modified Paths
trunk/Websites/webkit.org/.htaccess
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/security-policy.md
trunk/Websites/webkit.org/wp-content/themes/webkit/style.css
Diff
Modified: trunk/Websites/webkit.org/.htaccess (193834 => 193835)
--- trunk/Websites/webkit.org/.htaccess 2015-12-09 16:54:37 UTC (rev 193834)
+++ trunk/Websites/webkit.org/.htaccess 2015-12-09 17:34:04 UTC (rev 193835)
@@ -62,7 +62,7 @@
Redirect 301 /quality/testing.html /testing-contributions/
Redirect 301 /quality/testwriting.html /writing-new-tests/
Redirect 301 /security/index.html /security-policy/
-Redirect 301 /security/security-group-members.html /security-policy/
+Redirect 301 /security/security-group-members.html /security-team/
Redirect 301 /security/ /security-policy/
Redirect 301 /security /security-policy/
Redirect 301 /status.html /status/
Modified: trunk/Websites/webkit.org/ChangeLog (193834 => 193835)
--- trunk/Websites/webkit.org/ChangeLog 2015-12-09 16:54:37 UTC (rev 193834)
+++ trunk/Websites/webkit.org/ChangeLog 2015-12-09 17:34:04 UTC (rev 193835)
@@ -1,5 +1,18 @@
2015-12-09 Jonathan Davis
+Fixed broken link: https://webkit.org/old/security/security-group-members.html
+https://bugs.webkit.org/show_bug.cgi?id=152010
+
+Reviewed by Timothy Hatcher.
+
+* .htaccess:
+* security-policy.md:
+* wp-content/themes/webkit/style.css:
+(article h4):
+(article h5):
+
+2015-12-09 Jonathan Davis
+
Fix function reference change.
* wp-content/themes/webkit/scripts/global.js:
Modified: trunk/Websites/webkit.org/security-policy.md (193834 => 193835)
--- trunk/Websites/webkit.org/security-policy.md 2015-12-09 16:54:37 UTC (rev 193834)
+++ trunk/Websites/webkit.org/security-policy.md 2015-12-09 17:34:04 UTC (rev 193835)
@@ -4,7 +4,7 @@
2. **Scope of disclosure:** If you would like to limit further dissemination of the information in the bug report, please say so in the bug. Otherwise the WebKit Security Group may share information with other vendors if we find they may be affected by the same vulnerability. The WebKit Security Group will handle the information you provide responsibly. See the other sections of this document for details.
3. **Getting feedback:** We cannot guarantee a prompt human response to every security bug filed. If you would like immediate feedback on a security issue, or would like to discuss details with members of the WebKit Security Group, please email [secur...@webkit.org](mailto:secur...@webkit.org) and include a link to the relevant Bugzilla bug. Your message will be acknowledged within a week at most.
-The current member list will be published at [http://webkit.org/security/security-group-members.html](security-group-members.html).
+The current member list is published on the [Security Team](/security-team) page.
### How To Join the WebKit Security Group
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/style.css (193834 => 193835)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/style.css 2015-12-09 16:54:37 UTC (rev 193834)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/style.css 2015-12-09 17:34:04 UTC (rev 193835)
@@ -793,7 +793,7 @@
article h4 {
font-size: 2.2rem;
line-height: 1.125;
-font-weight: 200;
+font-weight: 600;
}
article h5 {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193836] trunk/Source/WebCore
Title: [193836] trunk/Source/WebCore
Revision 193836
Author y...@igalia.com
Date 2015-12-09 09:37:29 -0800 (Wed, 09 Dec 2015)
Log Message
[ThreadedCompositor] Support HTML5 Video
https://bugs.webkit.org/show_bug.cgi?id=143301
Reviewed by Žan Doberšek.
This patch implements HTML5 Video supports in Threaded Compositor.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
Added to support GStreamer GL by ensuring unmapping of the swapped
GstVideoFrame performed at GStreamer GL's gl thread.
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
Modified to upload decoded frame to the given texture instead of
creating a texture itself because we should use a texture from the
proxy when we are using the threaded compositor.
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
Implements two ways to send a texture from GStreamer to the compositor.
1. If we are not using GStreamer GL, we are going to acquire a free texture
from a TextureMapperPlatformLayerProxy and upload the decoded frame to the
texture. This should be done at the compositing thread because we
don't have a Gst's GL thread.
2. If we are using GStreamer GL, we map a texture for the given frame
and passes it to the compositing thread. The mapped frame will be
freed if it is swapped out or the layer is removed.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
Modified to aquire a new texture itself.
* platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
Adds a way to pass a function to the compositing thread to allocate /
upload textures at the compositing thread.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (193835 => 193836)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 17:34:04 UTC (rev 193835)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 17:37:29 UTC (rev 193836)
@@ -1,3 +1,38 @@
+2015-12-09 Gwang Yoon Hwang
+
+[ThreadedCompositor] Support HTML5 Video
+https://bugs.webkit.org/show_bug.cgi?id=143301
+
+Reviewed by Žan Doberšek.
+
+This patch implements HTML5 Video supports in Threaded Compositor.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
+Added to support GStreamer GL by ensuring unmapping of the swapped
+GstVideoFrame performed at GStreamer GL's gl thread.
+(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
+Modified to upload decoded frame to the given texture instead of
+creating a texture itself because we should use a texture from the
+proxy when we are using the threaded compositor.
+(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
+Implements two ways to send a texture from GStreamer to the compositor.
+1. If we are not using GStreamer GL, we are going to acquire a free texture
+from a TextureMapperPlatformLayerProxy and upload the decoded frame to the
+texture. This should be done at the compositing thread because we
+don't have a Gst's GL thread.
+2. If we are using GStreamer GL, we map a texture for the given frame
+and passes it to the compositing thread. The mapped frame will be
+freed if it is swapped out or the layer is removed.
+
+(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
+Modified to aquire a new texture itself.
+
+* platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
+Adds a way to pass a function to the compositing thread to allocate /
+upload textures at the compositing thread.
+
+
2015-12-09 Xabier Rodriguez Calvar
[Streams API] pipeThrough test failing
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (193835 => 193836)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2015-12-09 17:34:04 UTC (rev 193835)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2015-12-09 17:37:29 UTC (rev 193836)
@@ -55,6 +55,9 @@
#include "BitmapTexturePool.h"
#include "TextureMapperGL.h"
#endif
+#if USE(COORDINATED_GRAPHICS_THREADED)
+#include "TextureMapperPlatformLayerBuffer.h"
+#endif
#if USE(GSTREAMER_GL)
#include "GLContext.h"
@@ -102,6 +105,67 @@
return ABS(a);
}
+#if USE(COORDINATED_GRAPHICS_THREADED) && USE(GSTREAMER_GL)
+class GstVideoFrameHolder : public TextureMapperPlatformLayerBuffer::UnmanagedBufferDataHolder {
+public:
+exp
[webkit-changes] [193837] branches/safari-601.4-branch
Title: [193837] branches/safari-601.4-branch
Revision 193837
Author bshaf...@apple.com
Date 2015-12-09 09:44:15 -0800 (Wed, 09 Dec 2015)
Log Message
Roll out r192369. rdar://problem/23787108
Modified Paths
branches/safari-601.4-branch/LayoutTests/ChangeLog
branches/safari-601.4-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-on-history-traversal.html
branches/safari-601.4-branch/Source/WebCore/ChangeLog
branches/safari-601.4-branch/Source/WebCore/dom/Document.cpp
Removed Paths
branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt
branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html
branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt
branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html
branches/safari-601.4-branch/LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt
branches/safari-601.4-branch/LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous.html
Diff
Modified: branches/safari-601.4-branch/LayoutTests/ChangeLog (193836 => 193837)
--- branches/safari-601.4-branch/LayoutTests/ChangeLog 2015-12-09 17:37:29 UTC (rev 193836)
+++ branches/safari-601.4-branch/LayoutTests/ChangeLog 2015-12-09 17:44:15 UTC (rev 193837)
@@ -1,3 +1,7 @@
+2015-12-09 Babak Shafiei
+
+Roll out r192369.
+
2015-12-08 Babak Shafiei
Merge r191731.
Deleted: branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt (193836 => 193837)
--- branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt 2015-12-09 17:37:29 UTC (rev 193836)
+++ branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt 2015-12-09 17:44:15 UTC (rev 193837)
@@ -1 +0,0 @@
-TEST PASSED
Deleted: branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html (193836 => 193837)
--- branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html 2015-12-09 17:37:29 UTC (rev 193836)
+++ branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html 2015-12-09 17:44:15 UTC (rev 193837)
@@ -1,31 +0,0 @@
-
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-// One iframe's popstate handler removes another iframe from the
-// document during a history navigation that affects both frames. The
-// history navigation loads a different document in the other frame.
-window._onload_ = function () {
-frames[0].history.pushState("first", "first");
-frames[0]._onpopstate_ = function () {
-document.body.innerHTML = "TEST PASSED";
-if (window.testRunner)
-testRunner.notifyDone();
-};
-document.querySelectorAll("iframe")[1]._onload_ = function () {
-setTimeout("history.go(-2);", 10);
-};
-setTimeout(function () {
-frames[1].location.href = ""
-}, 10);
-}
-
-
-
-NOT TESTED
-
Deleted: branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt (193836 => 193837)
--- branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt 2015-12-09 17:37:29 UTC (rev 193836)
+++ branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt 2015-12-09 17:44:15 UTC (rev 193837)
@@ -1 +0,0 @@
-TEST PASSED
Deleted: branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html (193836 => 193837)
--- branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html 2015-12-09 17:37:29 UTC (rev 193836)
+++ branches/safari-601.4-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html 2015-12-09 17:44:15 UTC (rev 193837)
@@ -1,28 +0,0 @@
-
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-// One iframe's popstate handler removes another iframe from the
-// document during a history navigation that affects both frames. The
-// history navigation selects the same document in both frames.
-window._onload_ = function () {
-frames[0].history.pushState("first", "first");
-frames[0]._onpopstate_ = function () {
-document.body.innerHTML = "TEST PASSED";
-if (window.testRunner)
-testRunner.notifyDone();
-};
-frames[1].history.pushState("second", "second");
-
-history.go(-2);
-}
-
-
-
-
[webkit-changes] [193838] trunk/LayoutTests
Title: [193838] trunk/LayoutTests Revision 193838 Author ryanhad...@apple.com Date 2015-12-09 09:48:36 -0800 (Wed, 09 Dec 2015) Log Message Replacing Yosemite flag with Release flag for two flaky xmlhttprequest tests. https://bugs.webkit.org/show_bug.cgi?id=151729 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (193837 => 193838) --- trunk/LayoutTests/ChangeLog 2015-12-09 17:44:15 UTC (rev 193837) +++ trunk/LayoutTests/ChangeLog 2015-12-09 17:48:36 UTC (rev 193838) @@ -1,5 +1,14 @@ 2015-12-09 Ryan Haddad +Replacing Yosemite flag with Release flag for two flaky xmlhttprequest tests. +https://bugs.webkit.org/show_bug.cgi?id=151729 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +2015-12-09 Ryan Haddad + Marking inspector/debugger/command-line-api-exception.html as flaky on Mac https://bugs.webkit.org/show_bug.cgi?id=152029 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (193837 => 193838) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-12-09 17:44:15 UTC (rev 193837) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-12-09 17:48:36 UTC (rev 193838) @@ -280,13 +280,13 @@ webkit.org/b/151326 [ Yosemite+ ] webarchive/loading/missing-data.html [ Pass Crash ] -webkit.org/b/151455 [ Yosemite ] http/tests/xmlhttprequest/workers/methods-async.html [ Pass Timeout ] +webkit.org/b/151455 [ Release ] http/tests/xmlhttprequest/workers/methods-async.html [ Pass Timeout ] webkit.org/b/151661 http/tests/cache/disk-cache/disk-cache-request-max-stale.html [ Pass Timeout ] webkit.org/b/150542 fast/forms/state-restore-per-form.html [ Pass Timeout ] -webkit.org/b/151709 [ Yosemite ] http/tests/xmlhttprequest/workers/methods.html [ Pass Timeout ] +webkit.org/b/151709 [ Release ] http/tests/xmlhttprequest/workers/methods.html [ Pass Timeout ] webkit.org/b/151729 [ Yosemite ] http/tests/xmlhttprequest/methods-async.html [ Pass Timeout ] ### END OF (1) Classified failures with bug reports ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193839] branches/safari-601.1.46.60-branch
Title: [193839] branches/safari-601.1.46.60-branch
Revision 193839
Author bshaf...@apple.com
Date 2015-12-09 10:11:22 -0800 (Wed, 09 Dec 2015)
Log Message
Roll out r192369. rdar://problem/23787037
Modified Paths
branches/safari-601.1.46.60-branch/LayoutTests/ChangeLog
branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-on-history-traversal.html
branches/safari-601.1.46.60-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46.60-branch/Source/WebCore/dom/Document.cpp
Removed Paths
branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt
branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html
branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt
branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html
branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt
branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous.html
Diff
Modified: branches/safari-601.1.46.60-branch/LayoutTests/ChangeLog (193838 => 193839)
--- branches/safari-601.1.46.60-branch/LayoutTests/ChangeLog 2015-12-09 17:48:36 UTC (rev 193838)
+++ branches/safari-601.1.46.60-branch/LayoutTests/ChangeLog 2015-12-09 18:11:22 UTC (rev 193839)
@@ -1,3 +1,7 @@
+2015-12-09 Babak Shafiei
+
+Roll out r192369.
+
2015-12-07 Babak Shafiei
Merge r191731.
Deleted: branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt (193838 => 193839)
--- branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt 2015-12-09 17:48:36 UTC (rev 193838)
+++ branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt 2015-12-09 18:11:22 UTC (rev 193839)
@@ -1 +0,0 @@
-TEST PASSED
Deleted: branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html (193838 => 193839)
--- branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html 2015-12-09 17:48:36 UTC (rev 193838)
+++ branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html 2015-12-09 18:11:22 UTC (rev 193839)
@@ -1,31 +0,0 @@
-
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-// One iframe's popstate handler removes another iframe from the
-// document during a history navigation that affects both frames. The
-// history navigation loads a different document in the other frame.
-window._onload_ = function () {
-frames[0].history.pushState("first", "first");
-frames[0]._onpopstate_ = function () {
-document.body.innerHTML = "TEST PASSED";
-if (window.testRunner)
-testRunner.notifyDone();
-};
-document.querySelectorAll("iframe")[1]._onload_ = function () {
-setTimeout("history.go(-2);", 10);
-};
-setTimeout(function () {
-frames[1].location.href = ""
-}, 10);
-}
-
-
-
-NOT TESTED
-
Deleted: branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt (193838 => 193839)
--- branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt 2015-12-09 17:48:36 UTC (rev 193838)
+++ branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt 2015-12-09 18:11:22 UTC (rev 193839)
@@ -1 +0,0 @@
-TEST PASSED
Deleted: branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html (193838 => 193839)
--- branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html 2015-12-09 17:48:36 UTC (rev 193838)
+++ branches/safari-601.1.46.60-branch/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html 2015-12-09 18:11:22 UTC (rev 193839)
@@ -1,28 +0,0 @@
-
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-// One iframe's popstate handler removes another iframe from the
-// document during a history navigation that affects both frames. The
-// history navigation selects the same document in both frames.
-window._onload_ = function () {
-frames[0].history.pushState("first", "first");
-frames[0]._onpopstate_ = function () {
-document.body.innerHTML = "TEST PASSED";
-if (window.testRunner
[webkit-changes] [193840] trunk
Title: [193840] trunk Revision 193840 Author commit-qu...@webkit.org Date 2015-12-09 10:19:08 -0800 (Wed, 09 Dec 2015) Log Message form.elements should reflect the element ordering after the HTML tree builder algorithm https://bugs.webkit.org/show_bug.cgi?id=148870 rdar://problem/22589879 Patch by Keith Rollin on 2015-12-09 Reviewed by Ryosuke Niwa. LayoutTests/imported/w3c: Rebaseline existing test. * web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt: Source/WebCore: form.elements should return form-associated elements in tree order. However, when presented with an HTML fragment like the following, forms.elements is not built in tree order. Instead, the elements appear in forms.element in the same order they appear in the HTML -- that is in the same order as they are parsed. r1" value=1> r2" value=2> r0" value=0> The reason why elements appear in forms.elements in parse order is because they register themselves with the designated form when they are created. At this time, they are not in the DOM tree, so the form can only assume that the element will be appended to the DOM tree, with the result that it records the elements in the HTML fragment above as [r1, r2, r0]. However, it's not always the case that the newly-created element will be appended to the current tree. In the HTML fragment above, the r0 input element is hoised out of the table element. It ends up being the preceding sibling of the table element, with the result that the actual tree-order of the input elements is [r0, r1, r2]. Because the problem is due to registering form-associated elements with the form *before* the elements are added to the DOM tree, the solution is to defer that registration until afterwards. With the new element in the tree, the form can now use its current location in the tree to correctly place the element in form.elements. Existing tests now pass: - imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-html * html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::FormAssociatedElement): (WebCore::FormAssociatedElement::insertedInto): (WebCore::FormAssociatedElement::removedFrom): (WebCore::FormAssociatedElement::formRemovedFromTree): (WebCore::FormAssociatedElement::formWillBeDestroyed): * html/FormAssociatedElement.h: * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::HTMLImageElement): (WebCore::HTMLImageElement::insertedInto): (WebCore::HTMLImageElement::removedFrom): * html/HTMLImageElement.h: * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/FormAssociatedElement.cpp trunk/Source/WebCore/html/FormAssociatedElement.h trunk/Source/WebCore/html/HTMLFormControlElement.cpp trunk/Source/WebCore/html/HTMLImageElement.cpp trunk/Source/WebCore/html/HTMLImageElement.h trunk/Source/WebCore/html/HTMLObjectElement.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (193839 => 193840) --- trunk/LayoutTests/imported/w3c/ChangeLog 2015-12-09 18:11:22 UTC (rev 193839) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-12-09 18:19:08 UTC (rev 193840) @@ -1,3 +1,15 @@ +2015-12-09 Keith Rollin + +form.elements should reflect the element ordering after the HTML tree builder algorithm +https://bugs.webkit.org/show_bug.cgi?id=148870 +rdar://problem/22589879 + +Reviewed by Ryosuke Niwa. + +Rebaseline existing test. + +* web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt: + 2015-12-09 Xabier Rodriguez Calvar [Streams API] pipeThrough test failing Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt (193839 => 193840) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt 2015-12-09 18:11:22 UTC (rev 193839) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt 2015-12-09 18:19:08 UTC (rev 193840) @@ -1,5 +1,5 @@ -FAIL form.elements should work correctly in the face of table syntax errors assert_array_equals: property 0, expected Element node but got Element node +PASS form.elements should work correctly in the face of table syntax errors Modified: trunk/Source/WebCore/ChangeLog (193839 => 193840) --- trunk/Source/WebCore/ChangeLog 2015-12-09 18:11:22 UTC (rev 193839) +++ trunk/Source/WebCore/ChangeLog 2015-12-
[webkit-changes] [193842] trunk/Source/JavaScriptCore
Title: [193842] trunk/Source/_javascript_Core
Revision 193842
Author sbar...@apple.com
Date 2015-12-09 10:31:24 -0800 (Wed, 09 Dec 2015)
Log Message
we should emit op_watchdog after op_enter
https://bugs.webkit.org/show_bug.cgi?id=151972
Reviewed by Mark Lam.
This also solves the issue of watchdog not being
observed when we loop purely through tail calls.
* API/tests/ExecutionTimeLimitTest.cpp:
(testExecutionTimeLimit):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitProfiledOpcode):
(JSC::BytecodeGenerator::emitEnter):
(JSC::BytecodeGenerator::emitLoopHint):
* bytecompiler/BytecodeGenerator.h:
Modified Paths
trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
Diff
Modified: trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp (193841 => 193842)
--- trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp 2015-12-09 18:24:35 UTC (rev 193841)
+++ trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp 2015-12-09 18:31:24 UTC (rev 193842)
@@ -171,6 +171,49 @@
testResetAfterTimeout(failed);
}
+/* Test script timeout with tail calls: */
+timeLimit = (100 + tierAdjustmentMillis) / 1000.0;
+JSContextGroupSetExecutionTimeLimit(contextGroup, timeLimit, shouldTerminateCallback, 0);
+{
+unsigned timeAfterWatchdogShouldHaveFired = 300 + tierAdjustmentMillis;
+
+StringBuilder scriptBuilder;
+scriptBuilder.append("var startTime = currentCPUTime();"
+ "function recurse(i) {"
+ "'use strict';"
+ "if (i % 1000 === 0) {"
+"if (currentCPUTime() - startTime >");
+scriptBuilder.appendNumber(timeAfterWatchdogShouldHaveFired / 1000.0);
+scriptBuilder.append(" ) { return; }");
+scriptBuilder.append("}");
+scriptBuilder.append("return recurse(i + 1); }");
+scriptBuilder.append("recurse(0);");
+
+JSStringRef script = JSStringCreateWithUTF8CString(scriptBuilder.toString().utf8().data());
+exception = nullptr;
+shouldTerminateCallbackWasCalled = false;
+auto startTime = currentCPUTime();
+JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
+auto endTime = currentCPUTime();
+
+if (((endTime - startTime) < milliseconds(timeAfterWatchdogShouldHaveFired)) && shouldTerminateCallbackWasCalled)
+printf("PASS: %s script with infinite tail calls timed out as expected .\n", tierOptions.tier);
+else {
+if ((endTime - startTime) >= milliseconds(timeAfterWatchdogShouldHaveFired))
+printf("FAIL: %s script with infinite tail calls did not time out as expected.\n", tierOptions.tier);
+if (!shouldTerminateCallbackWasCalled)
+printf("FAIL: %s script with infinite tail calls' timeout callback was not called.\n", tierOptions.tier);
+failed = true;
+}
+
+if (!exception) {
+printf("FAIL: %s TerminatedExecutionException was not thrown.\n", tierOptions.tier);
+failed = true;
+}
+
+testResetAfterTimeout(failed);
+}
+
/* Test the script timeout's TerminatedExecutionException should NOT be catchable: */
timeLimit = (100 + tierAdjustmentMillis) / 1000.0;
JSContextGroupSetExecutionTimeLimit(contextGroup, timeLimit, shouldTerminateCallback, 0);
Modified: trunk/Source/_javascript_Core/ChangeLog (193841 => 193842)
--- trunk/Source/_javascript_Core/ChangeLog 2015-12-09 18:24:35 UTC (rev 193841)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-12-09 18:31:24 UTC (rev 193842)
@@ -1,3 +1,22 @@
+2015-12-09 Saam barati
+
+we should emit op_watchdog after op_enter
+https://bugs.webkit.org/show_bug.cgi?id=151972
+
+Reviewed by Mark Lam.
+
+This also solves the issue of watchdog not being
+observed when we loop purely through tail calls.
+
+* API/tests/ExecutionTimeLimitTest.cpp:
+(testExecutionTimeLimit):
+* bytecompiler/BytecodeGenerator.cpp:
+(JSC::BytecodeGenerator::BytecodeGenerator):
+(JSC::BytecodeGenerator::emitProfiledOpcode):
+(JSC::BytecodeGenerator::emitEnter):
+(JSC::BytecodeGenerator::emitLoopHint):
+* bytecompiler/BytecodeGenerator.h:
+
2015-12-08 Benjamin Poulain
[JSC] Improve how B3 lowers Add() and Sub() on x86
Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (193841
[webkit-changes] [193844] trunk/Source/WebKit2
Title: [193844] trunk/Source/WebKit2
Revision 193844
Author y...@igalia.com
Date 2015-12-09 10:52:16 -0800 (Wed, 09 Dec 2015)
Log Message
[ThreadedCompositor] Add support for HiDPI
https://bugs.webkit.org/show_bug.cgi?id=152071
Reviewed by Carlos Garcia Campos.
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::setDeviceScaleFactor): Added to receive the
device scale factor from the layer tree host.
(WebKit::ThreadedCompositor::renderLayerTree):
Apply device scale factor before rendering the page.
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
Send a updated device scale factor to the compositing thread.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp
trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (193843 => 193844)
--- trunk/Source/WebKit2/ChangeLog 2015-12-09 18:32:22 UTC (rev 193843)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-09 18:52:16 UTC (rev 193844)
@@ -1,3 +1,20 @@
+2015-12-09 Gwang Yoon Hwang
+
+[ThreadedCompositor] Add support for HiDPI
+https://bugs.webkit.org/show_bug.cgi?id=152071
+
+Reviewed by Carlos Garcia Campos.
+
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
+(WebKit::ThreadedCompositor::setDeviceScaleFactor): Added to receive the
+device scale factor from the layer tree host.
+(WebKit::ThreadedCompositor::renderLayerTree):
+Apply device scale factor before rendering the page.
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
+* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
+(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
+Send a updated device scale factor to the compositing thread.
+
2015-12-09 Ryuan Choi
[CoordinatedGraphics] Remove unnecessary guards in CoordinatedDrawingArea
Modified: trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp (193843 => 193844)
--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp 2015-12-09 18:32:22 UTC (rev 193843)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp 2015-12-09 18:52:16 UTC (rev 193844)
@@ -116,6 +116,7 @@
ThreadedCompositor::ThreadedCompositor(Client* client)
: m_client(client)
+, m_deviceScaleFactor(1)
, m_threadIdentifier(0)
{
createCompositingThread();
@@ -143,6 +144,14 @@
});
}
+void ThreadedCompositor::setDeviceScaleFactor(float scale)
+{
+RefPtr protector(this);
+callOnCompositingThread([=] {
+protector->m_deviceScaleFactor = scale;
+protector->scheduleDisplayImmediately();
+});
+}
void ThreadedCompositor::didChangeViewportSize(const IntSize& newSize)
{
@@ -262,7 +271,7 @@
TransformationMatrix viewportTransform;
FloatPoint scrollPostion = viewportController()->visibleContentsRect().location();
-viewportTransform.scale(viewportController()->pageScaleFactor());
+viewportTransform.scale(viewportController()->pageScaleFactor() * m_deviceScaleFactor);
viewportTransform.translate(-scrollPostion.x(), -scrollPostion.y());
m_scene->paintToCurrentGLContext(viewportTransform, 1, clipRect, Color::white, false, scrollPostion);
Modified: trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h (193843 => 193844)
--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h 2015-12-09 18:32:22 UTC (rev 193843)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h 2015-12-09 18:52:16 UTC (rev 193844)
@@ -67,6 +67,7 @@
void setNeedsDisplay();
void setNativeSurfaceHandleForCompositing(uint64_t);
+void setDeviceScaleFactor(float);
void updateSceneState(const WebCore::CoordinatedGraphicsState&);
@@ -106,6 +107,7 @@
std::unique_ptr m_context;
WebCore::IntSize m_viewportSize;
+float m_deviceScaleFactor;
uint64_t m_nativeSurfaceHandle;
std::unique_ptr m_compositingRunLoop;
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp (193843 => 193844)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp 2015-12-09 18:32:22 UTC (rev 193843)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp 2015-12-09 18:52:16 UTC (re
[webkit-changes] [193845] branches/safari-601-branch
Title: [193845] branches/safari-601-branch Revision 193845 Author bshaf...@apple.com Date 2015-12-09 10:53:17 -0800 (Wed, 09 Dec 2015) Log Message Merged r190505. rdar://problem/23822539 Modified Paths branches/safari-601-branch/LayoutTests/ChangeLog branches/safari-601-branch/LayoutTests/fast/history/same-document-iframes-changing-fragment-expected.txt branches/safari-601-branch/LayoutTests/fast/history/same-document-iframes-changing-pushstate-expected.txt branches/safari-601-branch/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/document-destroyed-navigate-back.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-on-history-traversal.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/pushstate-object-types.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/pushstate-then-replacestate.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/replacestate-then-pushstate.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html branches/safari-601-branch/LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html branches/safari-601-branch/LayoutTests/http/tests/history/popstate-fires-with-pending-requests.html branches/safari-601-branch/LayoutTests/http/tests/navigation/redirect-on-back-updates-history-item-expected.txt branches/safari-601-branch/LayoutTests/http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt branches/safari-601-branch/Source/WebCore/ChangeLog branches/safari-601-branch/Source/WebCore/dom/Document.cpp branches/safari-601-branch/Source/WebKit2/ChangeLog branches/safari-601-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Diff Modified: branches/safari-601-branch/LayoutTests/ChangeLog (193844 => 193845) --- branches/safari-601-branch/LayoutTests/ChangeLog 2015-12-09 18:52:16 UTC (rev 193844) +++ branches/safari-601-branch/LayoutTests/ChangeLog 2015-12-09 18:53:17 UTC (rev 193845) @@ -1,3 +1,40 @@ +2015-12-09 Babak Shafiei + +Merge r190505. + +2015-10-02 Antoine Quint + +popstate is fired at the wrong time on load +https://bugs.webkit.org/show_bug.cgi?id=94265 + +Reviewed by Darin Adler. + +Updating tests that relied on a "popstate" event being fired at page load. + +* fast/history/same-document-iframes-changing-fragment-expected.txt: +* fast/history/same-document-iframes-changing-pushstate-expected.txt: +* fast/loader/_javascript_-url-iframe-remove-on-navigate.html: +* fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html: +* fast/loader/stateobjects/document-destroyed-navigate-back.html: +* fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html: +* fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html: +* fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html: +* fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html: +* fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt: +* fast/loader/stateobjects/popstate-fires-on-history-traversal.html: +* fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt: +* fast/loader/stateobjects/popstate-fires-with-page-cache.html: +* fast/loader/stateobjects/pushstate-object-types.html: +* fast/loader/stateobjects/pushstate-then-replacestate.html: +* fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html: +
[webkit-changes] [193846] branches/safari-601.1.46-branch
Title: [193846] branches/safari-601.1.46-branch Revision 193846 Author bshaf...@apple.com Date 2015-12-09 10:58:41 -0800 (Wed, 09 Dec 2015) Log Message Merged r190505. rdar://problem/23822557 Modified Paths branches/safari-601.1.46-branch/LayoutTests/ChangeLog branches/safari-601.1.46-branch/LayoutTests/fast/history/same-document-iframes-changing-fragment-expected.txt branches/safari-601.1.46-branch/LayoutTests/fast/history/same-document-iframes-changing-pushstate-expected.txt branches/safari-601.1.46-branch/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/document-destroyed-navigate-back.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-on-history-traversal.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/pushstate-object-types.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/pushstate-then-replacestate.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/replacestate-then-pushstate.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html branches/safari-601.1.46-branch/LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html branches/safari-601.1.46-branch/LayoutTests/http/tests/history/popstate-fires-with-pending-requests.html branches/safari-601.1.46-branch/LayoutTests/http/tests/navigation/redirect-on-back-updates-history-item-expected.txt branches/safari-601.1.46-branch/LayoutTests/http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt branches/safari-601.1.46-branch/Source/WebCore/ChangeLog branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Diff Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (193845 => 193846) --- branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-12-09 18:53:17 UTC (rev 193845) +++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-12-09 18:58:41 UTC (rev 193846) @@ -1,3 +1,40 @@ +2015-12-09 Babak Shafiei + +Merge r190505. + +2015-10-02 Antoine Quint + +popstate is fired at the wrong time on load +https://bugs.webkit.org/show_bug.cgi?id=94265 + +Reviewed by Darin Adler. + +Updating tests that relied on a "popstate" event being fired at page load. + +* fast/history/same-document-iframes-changing-fragment-expected.txt: +* fast/history/same-document-iframes-changing-pushstate-expected.txt: +* fast/loader/_javascript_-url-iframe-remove-on-navigate.html: +* fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html: +* fast/loader/stateobjects/document-destroyed-navigate-back.html: +* fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html: +* fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html: +* fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html: +* fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html: +* fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt: +* fast/loader/stateobjects/popstate-fires-on-history-traversal.html: +* fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt: +* fast/loader/stateobjects/popstate-fires-with-page-cache.html: +* fast/loader/stateobjects/pushstate-object-types.html: +
[webkit-changes] [193847] trunk/Source/WebKit2
Title: [193847] trunk/Source/WebKit2
Revision 193847
Author gyuyoung@webkit.org
Date 2015-12-09 11:20:49 -0800 (Wed, 09 Dec 2015)
Log Message
[EFL] Need to change expectation result in ewk_settings_offline_web_application_cache_enabled API test
https://bugs.webkit.org/show_bug.cgi?id=152063
Reviewed by Csaba Osztrogonác.
Expect false initial value of ewk_settings_offline_web_application_cache_enabled_get()
because r193812 didn't enable it by default.
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (193846 => 193847)
--- trunk/Source/WebKit2/ChangeLog 2015-12-09 18:58:41 UTC (rev 193846)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-09 19:20:49 UTC (rev 193847)
@@ -1,3 +1,16 @@
+2015-12-09 Gyuyoung Kim
+
+[EFL] Need to change expectation result in ewk_settings_offline_web_application_cache_enabled API test
+https://bugs.webkit.org/show_bug.cgi?id=152063
+
+Reviewed by Csaba Osztrogonác.
+
+Expect false initial value of ewk_settings_offline_web_application_cache_enabled_get()
+because r193812 didn't enable it by default.
+
+* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+(TEST_F):
+
2015-12-09 Gwang Yoon Hwang
[ThreadedCompositor] Add support for HiDPI
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp (193846 => 193847)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp 2015-12-09 18:58:41 UTC (rev 193846)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp 2015-12-09 19:20:49 UTC (rev 193847)
@@ -198,8 +198,8 @@
{
Ewk_Settings* settings = ewk_page_group_settings_get(ewk_view_page_group_get(webView()));
-// The offline web application cache is enabled by default.
-ASSERT_TRUE(ewk_settings_offline_web_application_cache_enabled_get(settings));
+// The offline web application cache is disabled by default.
+ASSERT_FALSE(ewk_settings_offline_web_application_cache_enabled_get(settings));
ASSERT_TRUE(ewk_settings_offline_web_application_cache_enabled_set(settings, true));
ASSERT_TRUE(ewk_settings_offline_web_application_cache_enabled_get(settings));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193848] tags/Safari-602.1.13.2/Source
Title: [193848] tags/Safari-602.1.13.2/Source
Revision 193848
Author bshaf...@apple.com
Date 2015-12-09 11:48:32 -0800 (Wed, 09 Dec 2015)
Log Message
Merged r193645. rdar://problem/23751214
Modified Paths
tags/Safari-602.1.13.2/Source/WebCore/ChangeLog
tags/Safari-602.1.13.2/Source/WebCore/WebCore.xcodeproj/project.pbxproj
tags/Safari-602.1.13.2/Source/WebCore/editing/Editor.cpp
tags/Safari-602.1.13.2/Source/WebCore/loader/EmptyClients.h
tags/Safari-602.1.13.2/Source/WebCore/page/EditorClient.h
tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog
tags/Safari-602.1.13.2/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h
tags/Safari-602.1.13.2/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm
tags/Safari-602.1.13.2/Source/WebKit2/ChangeLog
tags/Safari-602.1.13.2/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h
Added Paths
tags/Safari-602.1.13.2/Source/WebCore/platform/spi/mac/NSSpellCheckerSPI.h
Diff
Modified: tags/Safari-602.1.13.2/Source/WebCore/ChangeLog (193847 => 193848)
--- tags/Safari-602.1.13.2/Source/WebCore/ChangeLog 2015-12-09 19:20:49 UTC (rev 193847)
+++ tags/Safari-602.1.13.2/Source/WebCore/ChangeLog 2015-12-09 19:48:32 UTC (rev 193848)
@@ -1,3 +1,29 @@
+2015-12-09 Babak Shafiei
+
+Merge r193645.
+
+2015-12-07 Beth Dakin
+
+Hook up request and show for typing candidates in WK1
+https://bugs.webkit.org/show_bug.cgi?id=151831
+-and corresponding-
+
+
+Reviewed by Enrica Casucci.
+
+New SPI that is needed.
+* WebCore.xcodeproj/project.pbxproj:
+* platform/spi/mac/NSSpellCheckerSPI.h: Added.
+
+Request candidates for editable content whenever selection changes.
+* editing/Editor.cpp:
+(WebCore::Editor::respondToChangedSelection):
+
+Implement requestCandidatesForSelection on the EditorClient.
+* loader/EmptyClients.h:
+* page/EditorClient.h:
+(WebCore::EditorClient::requestCandidatesForSelection):
+
2015-12-08 Babak Shafiei
Roll out r193645.
Modified: tags/Safari-602.1.13.2/Source/WebCore/WebCore.xcodeproj/project.pbxproj (193847 => 193848)
--- tags/Safari-602.1.13.2/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2015-12-09 19:20:49 UTC (rev 193847)
+++ tags/Safari-602.1.13.2/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2015-12-09 19:48:32 UTC (rev 193848)
@@ -3571,6 +3571,7 @@
933A14AA0B7D1D0900A53FFD /* DOMTextEvent.mm in Sources */ = {isa = PBXBuildFile; fileRef = 933A14A90B7D1D0900A53FFD /* DOMTextEvent.mm */; };
933A14B80B7D1D5200A53FFD /* JSTextEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 933A14B60B7D1D5200A53FFD /* JSTextEvent.cpp */; };
933A14B90B7D1D5200A53FFD /* JSTextEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 933A14B70B7D1D5200A53FFD /* JSTextEvent.h */; };
+ 933C7A751C0FBC440034FB97 /* NSSpellCheckerSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 933C7A741C0FBC440034FB97 /* NSSpellCheckerSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
9343CB8112F25E510033C5EE /* TextCodecUTF8.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9343CB7F12F25E510033C5EE /* TextCodecUTF8.cpp */; };
9343CB8212F25E510033C5EE /* TextCodecUTF8.h in Headers */ = {isa = PBXBuildFile; fileRef = 9343CB8012F25E510033C5EE /* TextCodecUTF8.h */; };
93442C9E0D2B335C00338FF9 /* HTMLTableRowsCollection.h in Headers */ = {isa = PBXBuildFile; fileRef = 93442C9D0D2B335C00338FF9 /* HTMLTableRowsCollection.h */; };
@@ -11095,6 +11096,7 @@
933A14A90B7D1D0900A53FFD /* DOMTextEvent.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DOMTextEvent.mm; sourceTree = ""; };
933A14B60B7D1D5200A53FFD /* JSTextEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSTextEvent.cpp; sourceTree = ""; };
933A14B70B7D1D5200A53FFD /* JSTextEvent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSTextEvent.h; sourceTree = ""; };
+ 933C7A741C0FBC440034FB97 /* NSSpellCheckerSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSSpellCheckerSPI.h; sourceTree = ""; };
9343CB7F12F25E510033C5EE /* TextCodecUTF8.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TextCodecUTF8.cpp; sourceTree = ""; };
9343CB8012F25E510033C5EE /* TextCodecUTF8.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextCodecUTF8.h; sourceTree = ""; };
93442C9D0D2B335C00338FF9 /* HTMLTableRowsCollection.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLTableRowsCollection.h; sourceTree = ""; };
@@ -18737,6 +18739,7 @@
F40EA8AA1B867D6500CE5581 /* NSScrollingInputFilterSPI.h */,
2DCB837719F99BBA00A7FBE4 /* NSSharingServicePicker
[webkit-changes] [193849] tags/Safari-602.1.13.2/Source/WebKit/mac
Title: [193849] tags/Safari-602.1.13.2/Source/WebKit/mac
Revision 193849
Author bshaf...@apple.com
Date 2015-12-09 11:55:53 -0800 (Wed, 09 Dec 2015)
Log Message
Merged r193661. rdar://problem/23639610
Modified Paths
tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog
tags/Safari-602.1.13.2/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm
tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebView.mm
tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h
tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewInternal.h
Diff
Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog (193848 => 193849)
--- tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog 2015-12-09 19:48:32 UTC (rev 193848)
+++ tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog 2015-12-09 19:55:53 UTC (rev 193849)
@@ -1,5 +1,24 @@
2015-12-09 Babak Shafiei
+Merge r193661.
+
+2015-12-07 Beth Dakin
+
+Add support for WebViewAdditions
+https://bugs.webkit.org/show_bug.cgi?id=151967
+
+Reviewed by Sam Weinig.
+
+* WebCoreSupport/WebEditorClient.mm:
+(WebEditorClient::respondToChangedSelection):
+* WebView/WebView.mm:
+(-[WebView _commonInitializationWithFrameName:groupName:]):
+(-[WebView updateWebViewAdditions]):
+* WebView/WebViewData.h:
+* WebView/WebViewInternal.h:
+
+2015-12-09 Babak Shafiei
+
Merge r193645.
2015-12-07 Beth Dakin
Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm (193848 => 193849)
--- tags/Safari-602.1.13.2/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2015-12-09 19:48:32 UTC (rev 193848)
+++ tags/Safari-602.1.13.2/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2015-12-09 19:55:53 UTC (rev 193849)
@@ -356,8 +356,10 @@
void WebEditorClient::respondToChangedSelection(Frame* frame)
{
NSView *documentView = [[kit(frame) frameView] documentView];
-if ([documentView isKindOfClass:[WebHTMLView class]])
+if ([documentView isKindOfClass:[WebHTMLView class]]) {
[(WebHTMLView *)documentView _selectionChanged];
+[m_webView updateWebViewAdditions];
+}
#if !PLATFORM(IOS)
// FIXME: This quirk is needed due to - We can phase it out once Aperture can adopt the new behavior on their end
Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebView.mm (193848 => 193849)
--- tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebView.mm 2015-12-09 19:48:32 UTC (rev 193848)
+++ tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebView.mm 2015-12-09 19:55:53 UTC (rev 193849)
@@ -911,6 +911,8 @@
}
#endif
+[self updateWebViewAdditions];
+
#if !PLATFORM(IOS)
static bool didOneTimeInitialization = false;
#endif
@@ -6604,6 +6606,18 @@
@end
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK)
+#import
+#else
+@implementation WebView (UpdateWebViewAdditions)
+
+- (void)updateWebViewAdditions
+{
+}
+
+@end
+#endif // PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK)
+
@implementation WebView (WebPendingPublic)
#if !PLATFORM(IOS)
Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h (193848 => 193849)
--- tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h 2015-12-09 19:48:32 UTC (rev 193848)
+++ tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h 2015-12-09 19:55:53 UTC (rev 193849)
@@ -171,6 +171,11 @@
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
WebImmediateActionController *immediateActionController;
#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK)
+#import
+#endif
+
std::unique_ptr textIndicatorWindow;
BOOL hasInitializedLookupObserver;
RetainPtr windowVisibilityObserver;
Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewInternal.h (193848 => 193849)
--- tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewInternal.h 2015-12-09 19:48:32 UTC (rev 193848)
+++ tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewInternal.h 2015-12-09 19:55:53 UTC (rev 193849)
@@ -290,3 +290,7 @@
#endif
@end
+
+@interface WebView (UpdateWebViewAdditions)
+- (void)updateWebViewAdditions;
+@end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193850] tags/Safari-602.1.13.2/Source/WebKit/mac
Title: [193850] tags/Safari-602.1.13.2/Source/WebKit/mac
Revision 193850
Author bshaf...@apple.com
Date 2015-12-09 11:57:29 -0800 (Wed, 09 Dec 2015)
Log Message
Merged r193675. rdar://problem/23639610
Modified Paths
tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog
tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h
Diff
Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog (193849 => 193850)
--- tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog 2015-12-09 19:55:53 UTC (rev 193849)
+++ tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog 2015-12-09 19:57:29 UTC (rev 193850)
@@ -1,5 +1,17 @@
2015-12-09 Babak Shafiei
+Merge r193675.
+
+2015-12-07 Alex Christensen
+
+Build fix after r193661.
+
+Reviewed by Beth Dakin.
+
+* WebView/WebViewData.h:
+
+2015-12-09 Babak Shafiei
+
Merge r193661.
2015-12-07 Beth Dakin
Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h (193849 => 193850)
--- tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h 2015-12-09 19:55:53 UTC (rev 193849)
+++ tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h 2015-12-09 19:57:29 UTC (rev 193850)
@@ -97,6 +97,10 @@
class WebSelectionServiceController;
#endif
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#import
+#endif
+
class WebViewLayerFlushScheduler : public WebCore::LayerFlushScheduler {
public:
WebViewLayerFlushScheduler(LayerFlushController*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193851] trunk/Source/JavaScriptCore
Title: [193851] trunk/Source/_javascript_Core
Revision 193851
Author sbar...@apple.com
Date 2015-12-09 11:58:28 -0800 (Wed, 09 Dec 2015)
Log Message
Update features.json w.r.t tail calls
https://bugs.webkit.org/show_bug.cgi?id=152072
Reviewed by Michael Saboff.
* features.json:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/features.json
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (193850 => 193851)
--- trunk/Source/_javascript_Core/ChangeLog 2015-12-09 19:57:29 UTC (rev 193850)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-12-09 19:58:28 UTC (rev 193851)
@@ -1,5 +1,14 @@
2015-12-09 Saam barati
+Update features.json w.r.t tail calls
+https://bugs.webkit.org/show_bug.cgi?id=152072
+
+Reviewed by Michael Saboff.
+
+* features.json:
+
+2015-12-09 Saam barati
+
we should emit op_watchdog after op_enter
https://bugs.webkit.org/show_bug.cgi?id=151972
Modified: trunk/Source/_javascript_Core/features.json (193850 => 193851)
--- trunk/Source/_javascript_Core/features.json 2015-12-09 19:57:29 UTC (rev 193850)
+++ trunk/Source/_javascript_Core/features.json 2015-12-09 19:58:28 UTC (rev 193851)
@@ -288,7 +288,7 @@
{
"name": "Tail Calls",
"status": {
-"status": "In Development",
+"status": "Done",
"enabled-by-default": true
},
"url": "http://www.ecma-international.org/ecma-262/6.0/index.html#sec-tail-position-calls",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193852] tags/Safari-602.1.13.2/Source/WebKit/mac
Title: [193852] tags/Safari-602.1.13.2/Source/WebKit/mac Revision 193852 Author bshaf...@apple.com Date 2015-12-09 11:58:50 -0800 (Wed, 09 Dec 2015) Log Message Merged r193676. rdar://problem/23639610 Modified Paths tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h Diff Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog (193851 => 193852) --- tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog 2015-12-09 19:58:28 UTC (rev 193851) +++ tags/Safari-602.1.13.2/Source/WebKit/mac/ChangeLog 2015-12-09 19:58:50 UTC (rev 193852) @@ -1,5 +1,15 @@ 2015-12-09 Babak Shafiei +Merge r193676. + +2015-12-07 Alex Christensen + +Build fix after r193675. + +* WebView/WebViewData.h: + +2015-12-09 Babak Shafiei + Merge r193675. 2015-12-07 Alex Christensen Modified: tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h (193851 => 193852) --- tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h 2015-12-09 19:58:28 UTC (rev 193851) +++ tags/Safari-602.1.13.2/Source/WebKit/mac/WebView/WebViewData.h 2015-12-09 19:58:50 UTC (rev 193852) @@ -97,7 +97,7 @@ class WebSelectionServiceController; #endif -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK) #import #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193853] trunk/LayoutTests
Title: [193853] trunk/LayoutTests
Revision 193853
Author clo...@igalia.com
Date 2015-12-09 12:12:29 -0800 (Wed, 09 Dec 2015)
Log Message
[GTK] Unreviewed GTK Gardening.
Rebaseline media tests after r190054 and r190200.
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/media-controls-clone-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-volume-slider-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/media/audio-controls-rendering-expected.txt
trunk/LayoutTests/platform/gtk/media/controls-strict-expected.txt
trunk/LayoutTests/platform/gtk/media/media-controls-clone-expected.txt
trunk/LayoutTests/platform/gtk/media/video-controls-rendering-expected.txt
trunk/LayoutTests/platform/gtk/media/video-display-toggle-expected.txt
trunk/LayoutTests/platform/gtk/media/video-empty-source-expected.txt
trunk/LayoutTests/platform/gtk/media/video-no-audio-expected.txt
trunk/LayoutTests/platform/gtk/media/video-volume-slider-expected.txt
trunk/LayoutTests/platform/gtk/media/video-zoom-controls-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (193852 => 193853)
--- trunk/LayoutTests/ChangeLog 2015-12-09 19:58:50 UTC (rev 193852)
+++ trunk/LayoutTests/ChangeLog 2015-12-09 20:12:29 UTC (rev 193853)
@@ -1,3 +1,19 @@
+2015-12-09 Carlos Alberto Lopez Perez
+
+[GTK] Unreviewed GTK Gardening.
+
+Rebaseline media tests after r190054 and r190200.
+
+* platform/gtk/media/audio-controls-rendering-expected.txt:
+* platform/gtk/media/controls-strict-expected.txt:
+* platform/gtk/media/media-controls-clone-expected.txt:
+* platform/gtk/media/video-controls-rendering-expected.txt:
+* platform/gtk/media/video-display-toggle-expected.txt:
+* platform/gtk/media/video-empty-source-expected.txt:
+* platform/gtk/media/video-no-audio-expected.txt:
+* platform/gtk/media/video-volume-slider-expected.txt:
+* platform/gtk/media/video-zoom-controls-expected.txt:
+
2015-12-09 Joanmarie Diggs
AX: [GTK] Anonymous render block flow elements should be exposed as ATK_ROLE_SECTION; not ATK_ROLE_PANEL
Modified: trunk/LayoutTests/platform/gtk/media/audio-controls-rendering-expected.txt (193852 => 193853)
--- trunk/LayoutTests/platform/gtk/media/audio-controls-rendering-expected.txt 2015-12-09 19:58:50 UTC (rev 193852)
+++ trunk/LayoutTests/platform/gtk/media/audio-controls-rendering-expected.txt 2015-12-09 20:12:29 UTC (rev 193853)
@@ -19,7 +19,6 @@
RenderBlock {DIV} at (0,0) size 300x30
layer at (8,41) size 300x30
RenderFlexibleBox {DIV} at (0,0) size 300x30 [bgcolor=#141414CC]
-RenderButton {BUTTON} at (9,0) size 30x30
RenderSlider {INPUT} at (49,11) size 157x8 [color=#E6E6E659]
RenderFlexibleBox {DIV} at (0,0) size 157x8 [border: (1px solid #E6E6E659)]
RenderBlock {DIV} at (1,-2) size 169x12
@@ -29,12 +28,13 @@
text run at (0,7) width 32: "00:07"
RenderFlexibleBox {DIV} at (261,0) size 30x30
RenderButton {BUTTON} at (0,0) size 30x30
+layer at (17,41) size 30x30
+ RenderButton {BUTTON} at (9,0) size 30x30
layer at (8,88) size 320x30
RenderFlexibleBox {DIV} at (0,0) size 320x30
RenderBlock {DIV} at (0,0) size 320x30
layer at (8,88) size 320x30
RenderFlexibleBox {DIV} at (0,0) size 320x30 [bgcolor=#141414CC]
-RenderButton {BUTTON} at (9,0) size 30x30
RenderSlider {INPUT} at (49,11) size 177x8 [color=#E6E6E659]
RenderFlexibleBox {DIV} at (0,0) size 177x8 [border: (1px solid #E6E6E659)]
RenderBlock {DIV} at (1,-2) size 189x12
@@ -44,6 +44,8 @@
text run at (0,7) width 32: "00:07"
RenderFlexibleBox {DIV} at (281,0) size 30x30
RenderButton {BUTTON} at (0,0) size 30x30
+layer at (17,88) size 30x30
+ RenderButton {BUTTON} at (9,0) size 30x30
layer at (8,135) size 320x100
RenderMedia {AUDIO} at (8,135) size 320x100 [bgcolor=#FF]
layer at (8,135) size 320x100
@@ -51,7 +53,6 @@
RenderBlock {DIV} at (0,70) size 320x30
layer at (8,205) size 320x30
RenderFlexibleBox {DIV} at (0,0) size 320x30 [bgcolor=#141414CC]
-RenderButton {BUTTON} at (9,0) size 30x30
RenderSlider {INPUT} at (49,11) size 177x8 [color=#E6E6E659]
RenderFlexibleBox {DIV} at (0,0) size 177x8 [border: (1px solid #E6E6E659)]
RenderBlock {DIV} at (1,-2) size 189x12
@@ -61,3 +62,5 @@
text run at (0,7) width 32: "00:07"
RenderFlexibleBox {DIV} at (281,0) size 30x30
RenderButton {BUTTON} at (0,0) size 30x30
+layer at (17,205) size 30x30
+ RenderButton {BUTTON} at (9,0) size 30x30
Modified: trunk/LayoutTests/platform/gtk/
[webkit-changes] [193854] trunk/Source/JavaScriptCore
Title: [193854] trunk/Source/_javascript_Core
Revision 193854
Author sbar...@apple.com
Date 2015-12-09 12:22:51 -0800 (Wed, 09 Dec 2015)
Log Message
Update generators' features.json to indicate that we have a spec compliant implementation
https://bugs.webkit.org/show_bug.cgi?id=152085
Reviewed by Joseph Pecoraro.
* features.json:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/features.json
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (193853 => 193854)
--- trunk/Source/_javascript_Core/ChangeLog 2015-12-09 20:12:29 UTC (rev 193853)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-12-09 20:22:51 UTC (rev 193854)
@@ -1,5 +1,14 @@
2015-12-09 Saam barati
+Update generators' features.json to indicate that we have a spec compliant implementation
+https://bugs.webkit.org/show_bug.cgi?id=152085
+
+Reviewed by Joseph Pecoraro.
+
+* features.json:
+
+2015-12-09 Saam barati
+
Update features.json w.r.t tail calls
https://bugs.webkit.org/show_bug.cgi?id=152072
Modified: trunk/Source/_javascript_Core/features.json (193853 => 193854)
--- trunk/Source/_javascript_Core/features.json 2015-12-09 20:12:29 UTC (rev 193853)
+++ trunk/Source/_javascript_Core/features.json 2015-12-09 20:22:51 UTC (rev 193854)
@@ -128,12 +128,12 @@
{
"name": "Generators",
"status": {
-"status": "In Development",
+"status": "Done",
"enabled-by-default": true
},
"url": "http://www.ecma-international.org/ecma-262/6.0/index.html#sec-generator-objects",
"specification": "ES6",
-"description": "An iterative function object that is interruptable and resumable.",
+"description": "An iterative function object that is interruptible and resumable. Generators are currently spec compliant, however, we're still actively working on improving their performance.",
"webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=150290",
"documentation-url": "https://hacks.mozilla.org/2015/05/es6-in-depth-generators/",
"contact": {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193855] trunk/LayoutTests
Title: [193855] trunk/LayoutTests Revision 193855 Author mark@apple.com Date 2015-12-09 13:07:23 -0800 (Wed, 09 Dec 2015) Log Message Rename ftl-object-* tests to ftl-polymorphic-*. https://bugs.webkit.org/show_bug.cgi?id=152091 Reviewed by Saam Barati. This is because those tests are actually testing the effects of polymorphic operands on performance, and not the correctness of operations on objects. * js/regress/ftl-object-div-expected.txt: Removed. * js/regress/ftl-object-div.html: Removed. * js/regress/ftl-object-mul-expected.txt: Removed. * js/regress/ftl-object-mul.html: Removed. * js/regress/ftl-object-sub-expected.txt: Removed. * js/regress/ftl-object-sub.html: Removed. * js/regress/ftl-polymorphic-div-expected.txt: Copied from LayoutTests/js/regress/ftl-object-div-expected.txt. * js/regress/ftl-polymorphic-div.html: Copied from LayoutTests/js/regress/ftl-object-div.html. * js/regress/ftl-polymorphic-mul-expected.txt: Copied from LayoutTests/js/regress/ftl-object-mul-expected.txt. * js/regress/ftl-polymorphic-mul.html: Copied from LayoutTests/js/regress/ftl-object-mul.html. * js/regress/ftl-polymorphic-sub-expected.txt: Copied from LayoutTests/js/regress/ftl-object-sub-expected.txt. * js/regress/ftl-polymorphic-sub.html: Copied from LayoutTests/js/regress/ftl-object-sub.html. * js/regress/script-tests/ftl-object-div.js: Removed. * js/regress/script-tests/ftl-object-mul.js: Removed. * js/regress/script-tests/ftl-object-sub.js: Removed. * js/regress/script-tests/ftl-polymorphic-div.js: Copied from LayoutTests/js/regress/script-tests/ftl-object-div.js. * js/regress/script-tests/ftl-polymorphic-mul.js: Copied from LayoutTests/js/regress/script-tests/ftl-object-mul.js. * js/regress/script-tests/ftl-polymorphic-sub.js: Copied from LayoutTests/js/regress/script-tests/ftl-object-sub.js. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/js/regress/ftl-polymorphic-div-expected.txt trunk/LayoutTests/js/regress/ftl-polymorphic-div.html trunk/LayoutTests/js/regress/ftl-polymorphic-mul-expected.txt trunk/LayoutTests/js/regress/ftl-polymorphic-mul.html trunk/LayoutTests/js/regress/ftl-polymorphic-sub-expected.txt trunk/LayoutTests/js/regress/ftl-polymorphic-sub.html trunk/LayoutTests/js/regress/script-tests/ftl-polymorphic-div.js trunk/LayoutTests/js/regress/script-tests/ftl-polymorphic-mul.js trunk/LayoutTests/js/regress/script-tests/ftl-polymorphic-sub.js Removed Paths trunk/LayoutTests/js/regress/ftl-object-div-expected.txt trunk/LayoutTests/js/regress/ftl-object-div.html trunk/LayoutTests/js/regress/ftl-object-mul-expected.txt trunk/LayoutTests/js/regress/ftl-object-mul.html trunk/LayoutTests/js/regress/ftl-object-sub-expected.txt trunk/LayoutTests/js/regress/ftl-object-sub.html trunk/LayoutTests/js/regress/script-tests/ftl-object-div.js trunk/LayoutTests/js/regress/script-tests/ftl-object-mul.js trunk/LayoutTests/js/regress/script-tests/ftl-object-sub.js Diff Modified: trunk/LayoutTests/ChangeLog (193854 => 193855) --- trunk/LayoutTests/ChangeLog 2015-12-09 20:22:51 UTC (rev 193854) +++ trunk/LayoutTests/ChangeLog 2015-12-09 21:07:23 UTC (rev 193855) @@ -1,3 +1,32 @@ +2015-12-09 Mark Lam + +Rename ftl-object-* tests to ftl-polymorphic-*. +https://bugs.webkit.org/show_bug.cgi?id=152091 + +Reviewed by Saam Barati. + +This is because those tests are actually testing the effects of polymorphic +operands on performance, and not the correctness of operations on objects. + +* js/regress/ftl-object-div-expected.txt: Removed. +* js/regress/ftl-object-div.html: Removed. +* js/regress/ftl-object-mul-expected.txt: Removed. +* js/regress/ftl-object-mul.html: Removed. +* js/regress/ftl-object-sub-expected.txt: Removed. +* js/regress/ftl-object-sub.html: Removed. +* js/regress/ftl-polymorphic-div-expected.txt: Copied from LayoutTests/js/regress/ftl-object-div-expected.txt. +* js/regress/ftl-polymorphic-div.html: Copied from LayoutTests/js/regress/ftl-object-div.html. +* js/regress/ftl-polymorphic-mul-expected.txt: Copied from LayoutTests/js/regress/ftl-object-mul-expected.txt. +* js/regress/ftl-polymorphic-mul.html: Copied from LayoutTests/js/regress/ftl-object-mul.html. +* js/regress/ftl-polymorphic-sub-expected.txt: Copied from LayoutTests/js/regress/ftl-object-sub-expected.txt. +* js/regress/ftl-polymorphic-sub.html: Copied from LayoutTests/js/regress/ftl-object-sub.html. +* js/regress/script-tests/ftl-object-div.js: Removed. +* js/regress/script-tests/ftl-object-mul.js: Removed. +* js/regress/script-tests/ftl-object-sub.js: Removed. +* js/regress/script-tests/ftl-polymorphic-div.js: Copied from LayoutTests/js/regress/script-tests/ftl-object-div.js. +* js/regress/script-tests/ftl-polymorphic-mul.js: Copied from LayoutTests/js/regress/script-tests/ftl-object-mul.js. +* js/regress/scri
[webkit-changes] [193856] trunk/Tools
Title: [193856] trunk/Tools
Revision 193856
Author commit-qu...@webkit.org
Date 2015-12-09 13:14:03 -0800 (Wed, 09 Dec 2015)
Log Message
Run atleast one simulator even if max process limit is low
https://bugs.webkit.org/show_bug.cgi?id=152081
Patch by Aakash Jain on 2015-12-09
Reviewed by Alexey Proskuryakov.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py
Diff
Modified: trunk/Tools/ChangeLog (193855 => 193856)
--- trunk/Tools/ChangeLog 2015-12-09 21:07:23 UTC (rev 193855)
+++ trunk/Tools/ChangeLog 2015-12-09 21:14:03 UTC (rev 193856)
@@ -1,3 +1,11 @@
+2015-12-09 Aakash Jain
+
+Run atleast one simulator even if max process limit is low
+https://bugs.webkit.org/show_bug.cgi?id=152081
+
+
+Reviewed by Alexey Proskuryakov.
+
2015-12-09 Mario Sanchez Prada
[GTK] Crash in WebProcess when loading large content with custom URI schemes
Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (193855 => 193856)
--- trunk/Tools/Scripts/webkitpy/port/ios.py 2015-12-09 21:07:23 UTC (rev 193855)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py 2015-12-09 21:14:03 UTC (rev 193856)
@@ -148,6 +148,9 @@
_log.warn('Run "launchctl limit" to check these limits')
# FIXME: Add url for webpage explaining how to increase these limits.
+if maximum_simulator_count_on_this_system == 0:
+maximum_simulator_count_on_this_system = 1
+
return min(maximum_simulator_count_on_this_system, best_child_process_count_for_cpu)
def default_timeout_ms(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193857] trunk/Source/WebCore
Title: [193857] trunk/Source/WebCore
Revision 193857
Author za...@apple.com
Date 2015-12-09 13:22:03 -0800 (Wed, 09 Dec 2015)
Log Message
TextPainter: Rename start and end position to selectionStart and selectionEnd.
https://bugs.webkit.org/show_bug.cgi?id=152088
Reviewed by Myles C. Maxfield.
They actually mean selection start/end.
No change in functionality.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/TextPainter.cpp:
(WebCore::TextPainter::TextPainter):
(WebCore::TextPainter::paintText):
* rendering/TextPainter.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/rendering/TextPainter.cpp
trunk/Source/WebCore/rendering/TextPainter.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (193856 => 193857)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 21:14:03 UTC (rev 193856)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 21:22:03 UTC (rev 193857)
@@ -1,3 +1,21 @@
+2015-12-09 Zalan Bujtas
+
+TextPainter: Rename start and end position to selectionStart and selectionEnd.
+https://bugs.webkit.org/show_bug.cgi?id=152088
+
+Reviewed by Myles C. Maxfield.
+
+They actually mean selection start/end.
+
+No change in functionality.
+
+* rendering/InlineTextBox.cpp:
+(WebCore::InlineTextBox::paint):
+* rendering/TextPainter.cpp:
+(WebCore::TextPainter::TextPainter):
+(WebCore::TextPainter::paintText):
+* rendering/TextPainter.h:
+
2015-12-09 Joanmarie Diggs
AX: [GTK] Anonymous render block flow elements should be exposed as ATK_ROLE_SECTION; not ATK_ROLE_PANEL
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (193856 => 193857)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2015-12-09 21:14:03 UTC (rev 193856)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2015-12-09 21:22:03 UTC (rev 193857)
@@ -581,14 +581,14 @@
if (hasHyphen())
length = textRun.length();
-int sPos = 0;
-int ePos = 0;
+int selectionStart = 0;
+int selectionEnd = 0;
if (haveSelection && (paintSelectedTextOnly || paintSelectedTextSeparately))
-selectionStartEnd(sPos, ePos);
+selectionStartEnd(selectionStart, selectionEnd);
if (m_truncation != cNoTruncation) {
-sPos = std::min(sPos, m_truncation);
-ePos = std::min(ePos, m_truncation);
+selectionStart = std::min(selectionStart, m_truncation);
+selectionEnd = std::min(selectionEnd, m_truncation);
length = m_truncation;
}
@@ -612,7 +612,7 @@
else
textOrigin.setX(roundToDevicePixel(LayoutUnit(textOrigin.x()), renderer().document().deviceScaleFactor()));
-TextPainter textPainter(context, paintSelectedTextOnly, paintSelectedTextSeparately, font, sPos, ePos, length, emphasisMark, combinedText, textRun, boxRect, textOrigin, emphasisMarkOffset, textShadow, selectionShadow, isHorizontal(), textPaintStyle, selectionPaintStyle);
+TextPainter textPainter(context, paintSelectedTextOnly, paintSelectedTextSeparately, font, selectionStart, selectionEnd, length, emphasisMark, combinedText, textRun, boxRect, textOrigin, emphasisMarkOffset, textShadow, selectionShadow, isHorizontal(), textPaintStyle, selectionPaintStyle);
textPainter.paintText();
// Paint decorations
Modified: trunk/Source/WebCore/rendering/TextPainter.cpp (193856 => 193857)
--- trunk/Source/WebCore/rendering/TextPainter.cpp 2015-12-09 21:14:03 UTC (rev 193856)
+++ trunk/Source/WebCore/rendering/TextPainter.cpp 2015-12-09 21:22:03 UTC (rev 193857)
@@ -79,8 +79,8 @@
m_context.clearShadow();
}
-TextPainter::TextPainter(GraphicsContext& context, bool paintSelectedTextOnly, bool paintSelectedTextSeparately, const FontCascade& font, int startPositionInTextRun,
-int endPositionInTextBoxString, int length, const AtomicString& emphasisMark, RenderCombineText* combinedText, TextRun& textRun, FloatRect& boxRect,
+TextPainter::TextPainter(GraphicsContext& context, bool paintSelectedTextOnly, bool paintSelectedTextSeparately, const FontCascade& font, int selectionStart,
+int selectionEnd, int length, const AtomicString& emphasisMark, RenderCombineText* combinedText, TextRun& textRun, FloatRect& boxRect,
FloatPoint& textOrigin, int emphasisMarkOffset, const ShadowData* textShadow, const ShadowData* selectionShadow, bool textBoxIsHorizontal,
TextPaintStyle& textPaintStyle, TextPaintStyle& selectionPaintStyle)
: m_context(context)
@@ -91,8 +91,8 @@
, m_paintSelectedTextOnly(paintSelectedTextOnly)
, m_paintSelectedTextSeparately(paintSelectedTextSeparately)
, m_font(font)
-, m_startPositionInTextRun(startPositionInTextRun)
-, m_endPositionInTextRun(endPositionInTextBoxString)
+, m_selectionStart(selectionStart)
+, m_selectionEnd(selectionEnd)
, m_length(length)
, m_emphasisMark(emphasisMark)
, m_combinedText
[webkit-changes] [193858] trunk/Source/WebInspectorUI
Title: [193858] trunk/Source/WebInspectorUI
Revision 193858
Author bb...@apple.com
Date 2015-12-09 13:34:52 -0800 (Wed, 09 Dec 2015)
Log Message
Web Inspector: zoom with Ctrl +/- doesn't work correctly when inspector is docked
https://bugs.webkit.org/show_bug.cgi?id=152076
Reviewed by Timothy Hatcher.
When computing the new width or height of the inspector, take the zoom level into
account. window.inner{Width,Height} are in document pixels, but we need to specify
device pixels to InspectorFrontendHost.
* UserInterface/Base/Main.js:
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (193857 => 193858)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-09 21:22:03 UTC (rev 193857)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-09 21:34:52 UTC (rev 193858)
@@ -1,3 +1,16 @@
+2015-12-09 Brian Burg
+
+Web Inspector: zoom with Ctrl +/- doesn't work correctly when inspector is docked
+https://bugs.webkit.org/show_bug.cgi?id=152076
+
+Reviewed by Timothy Hatcher.
+
+When computing the new width or height of the inspector, take the zoom level into
+account. window.inner{Width,Height} are in document pixels, but we need to specify
+device pixels to InspectorFrontendHost.
+
+* UserInterface/Base/Main.js:
+
2015-12-08 Joseph Pecoraro
Web Inspector: Workaround arrow function issue in TimelineOverviewGraph.js
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (193857 => 193858)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-09 21:22:03 UTC (rev 193857)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-09 21:34:52 UTC (rev 193858)
@@ -1586,7 +1586,10 @@
if (delta < 0 && clientPosition > firstClientPosition)
return;
-var dimension = Math.max(0, window[windowProperty] - delta);
+let dimension = Math.max(0, window[windowProperty] - delta);
+// If zoomed in/out, there be greater/fewer document pixels shown, but the inspector's
+// width or height should be the same in device pixels regardless of the document zoom.
+dimension *= InspectorFrontendHost.zoomFactor();
if (this._dockSide === "bottom")
InspectorFrontendHost.setAttachedWindowHeight(dimension);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193860] trunk/LayoutTests
Title: [193860] trunk/LayoutTests
Revision 193860
Author ryanhad...@apple.com
Date 2015-12-09 13:48:00 -0800 (Wed, 09 Dec 2015)
Log Message
Baseline fast/text/text-combine-shrink-on-color-change.html for iOS
https://bugs.webkit.org/show_bug.cgi?id=151218
Unreviewed test gardening.
* platform/ios-simulator/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/ios-simulator/fast/text/text-combine-shrink-on-color-change-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (193859 => 193860)
--- trunk/LayoutTests/ChangeLog 2015-12-09 21:42:25 UTC (rev 193859)
+++ trunk/LayoutTests/ChangeLog 2015-12-09 21:48:00 UTC (rev 193860)
@@ -1,3 +1,12 @@
+2015-12-09 Ryan Haddad
+
+Baseline fast/text/text-combine-shrink-on-color-change.html for iOS
+https://bugs.webkit.org/show_bug.cgi?id=151218
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
+
2015-12-09 David Hyatt
Picture element needs to respond to dynamic viewport changes.
Added: trunk/LayoutTests/platform/ios-simulator/fast/text/text-combine-shrink-on-color-change-expected.txt (0 => 193860)
--- trunk/LayoutTests/platform/ios-simulator/fast/text/text-combine-shrink-on-color-change-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/fast/text/text-combine-shrink-on-color-change-expected.txt 2015-12-09 21:48:00 UTC (rev 193860)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 55x200 [color=#008000]
+RenderText {#text} at (9,0) size 37x34
+ text run at (9,0) width 34: "1 "
+RenderInline {SPAN} at (0,0) size 37x37
+ RenderCombineText {#text} at (9,33) size 37x37
+text run at (9,33) width 36: "\x{FFFC}"
+RenderText {#text} at (9,69) size 37x34
+ text run at (9,69) width 34: " 2"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193862] tags/Safari-601.1.46.85/
Title: [193862] tags/Safari-601.1.46.85/ Revision 193862 Author bshaf...@apple.com Date 2015-12-09 14:07:10 -0800 (Wed, 09 Dec 2015) Log Message New tag. Added Paths tags/Safari-601.1.46.85/ Diff Property changes: tags/Safari-601.1.46.85 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193861] trunk/LayoutTests
Title: [193861] trunk/LayoutTests
Revision 193861
Author ryanhad...@apple.com
Date 2015-12-09 14:06:22 -0800 (Wed, 09 Dec 2015)
Log Message
Baseline fast/dom/HTMLProgressElement/native-progress-bar.html for iOS
https://bugs.webkit.org/show_bug.cgi?id=152094
Unreviewed test gardening.
* platform/ios-simulator/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/ios-simulator/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (193860 => 193861)
--- trunk/LayoutTests/ChangeLog 2015-12-09 21:48:00 UTC (rev 193860)
+++ trunk/LayoutTests/ChangeLog 2015-12-09 22:06:22 UTC (rev 193861)
@@ -1,5 +1,14 @@
2015-12-09 Ryan Haddad
+Baseline fast/dom/HTMLProgressElement/native-progress-bar.html for iOS
+https://bugs.webkit.org/show_bug.cgi?id=152094
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
+
+2015-12-09 Ryan Haddad
+
Baseline fast/text/text-combine-shrink-on-color-change.html for iOS
https://bugs.webkit.org/show_bug.cgi?id=151218
Added: trunk/LayoutTests/platform/ios-simulator/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt (0 => 193861)
--- trunk/LayoutTests/platform/ios-simulator/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt 2015-12-09 22:06:22 UTC (rev 193861)
@@ -0,0 +1,16 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x108
+ RenderBlock {HTML} at (0,0) size 800x108
+RenderBody {BODY} at (8,16) size 784x76
+ RenderBlock {P} at (0,0) size 784x20
+RenderText {#text} at (0,0) size 361x19
+ text run at (0,0) width 361: "Test passes if following bars are filled 30% with a color."
+ RenderBlock {P} at (0,36) size 784x40
+RenderProgress {PROGRESS} at (0,2) size 160x17
+RenderBR {BR} at (160,0) size 0x19
+RenderBlock {PROGRESS} at (0,22) size 160x17
+ RenderProgress {DIV} at (0,0) size 160x16
+RenderBlock {DIV} at (0,0) size 160x16 [bgcolor=#808080]
+ RenderBlock {DIV} at (0,0) size 48x16 [bgcolor=#008000]
+RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193864] trunk/Source/WebKit2
Title: [193864] trunk/Source/WebKit2 Revision 193864 Author bb...@apple.com Date 2015-12-09 14:11:41 -0800 (Wed, 09 Dec 2015) Log Message Web Inspector: reproducible debug ASSERT when inspecting the inspector (WK2) https://bugs.webkit.org/show_bug.cgi?id=152080 Reviewed by Timothy Hatcher. We hit an assert underneath ChildProcessProxy::addMessageReceiver because we tried to connect the inspector page and inspected page more than once. This relationship is already set up in the constructor of WebProcessProxy. * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::eagerlyCreateInspectorPage): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (193863 => 193864) --- trunk/Source/WebKit2/ChangeLog 2015-12-09 22:11:12 UTC (rev 193863) +++ trunk/Source/WebKit2/ChangeLog 2015-12-09 22:11:41 UTC (rev 193864) @@ -1,3 +1,17 @@ +2015-12-09 Brian Burg + +Web Inspector: reproducible debug ASSERT when inspecting the inspector (WK2) +https://bugs.webkit.org/show_bug.cgi?id=152080 + +Reviewed by Timothy Hatcher. + +We hit an assert underneath ChildProcessProxy::addMessageReceiver because +we tried to connect the inspector page and inspected page more than once. +This relationship is already set up in the constructor of WebProcessProxy. + +* UIProcess/WebInspectorProxy.cpp: +(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage): + 2015-12-09 Gyuyoung Kim [EFL] Need to change expectation result in ewk_settings_offline_web_application_cache_enabled API test Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (193863 => 193864) --- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-09 22:11:12 UTC (rev 193863) +++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-09 22:11:41 UTC (rev 193864) @@ -510,7 +510,6 @@ WKPageSetPageLoaderClient(toAPI(m_inspectorPage), &loaderClient.base); WKPageSetPageContextMenuClient(toAPI(m_inspectorPage), &contextMenuClient.base); -m_inspectorPage->process().addMessageReceiver(Messages::WebInspectorProxy::messageReceiverName(), m_inspectedPage->pageID(), *this); m_inspectorPage->process().assumeReadAccessToBaseURL(WebInspectorProxy::inspectorBaseURL()); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193863] branches/safari-601.1.46-branch/Source
Title: [193863] branches/safari-601.1.46-branch/Source Revision 193863 Author bshaf...@apple.com Date 2015-12-09 14:11:12 -0800 (Wed, 09 Dec 2015) Log Message Versioning. Modified Paths branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (193862 => 193863) --- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-12-09 22:07:10 UTC (rev 193862) +++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-12-09 22:11:12 UTC (rev 193863) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 85; +MICRO_VERSION = 86; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (193862 => 193863) --- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig 2015-12-09 22:07:10 UTC (rev 193862) +++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig 2015-12-09 22:11:12 UTC (rev 193863) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 85; +MICRO_VERSION = 86; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (193862 => 193863) --- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-12-09 22:07:10 UTC (rev 193862) +++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-12-09 22:11:12 UTC (rev 193863) @@ -1,7 +1,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 85; +MICRO_VERSION = 86; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (193862 => 193863) --- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-12-09 22:07:10 UTC (rev 193862) +++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-12-09 22:11:12 UTC (rev 193863) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 85; +MICRO_VERSION = 86; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (193862 => 193863) --- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-12-09 22:07:10 UTC (rev 193862) +++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-12-09 22:11:12 UTC (rev 193863) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 85; +MICRO_VERSION = 86; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193865] trunk/LayoutTests
Title: [193865] trunk/LayoutTests
Revision 193865
Author beid...@apple.com
Date 2015-12-09 14:22:26 -0800 (Wed, 09 Dec 2015)
Log Message
Modern IDB: storage/indexeddb/createIndex-after-failure.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152078
Reviewed by Alex Christensen.
* platform/mac-wk1/TestExpectations:
* storage/indexeddb/createIndex-after-failure-expected.txt:
* storage/indexeddb/resources/createIndex-after-failure.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js
Diff
Modified: trunk/LayoutTests/ChangeLog (193864 => 193865)
--- trunk/LayoutTests/ChangeLog 2015-12-09 22:11:41 UTC (rev 193864)
+++ trunk/LayoutTests/ChangeLog 2015-12-09 22:22:26 UTC (rev 193865)
@@ -1,3 +1,14 @@
+2015-12-09 Brady Eidson
+
+Modern IDB: storage/indexeddb/createIndex-after-failure.html fails.
+https://bugs.webkit.org/show_bug.cgi?id=152078
+
+Reviewed by Alex Christensen.
+
+* platform/mac-wk1/TestExpectations:
+* storage/indexeddb/createIndex-after-failure-expected.txt:
+* storage/indexeddb/resources/createIndex-after-failure.js:
+
2015-12-09 Ryan Haddad
Baseline fast/dom/HTMLProgressElement/native-progress-bar.html for iOS
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193864 => 193865)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 22:11:41 UTC (rev 193864)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 22:22:26 UTC (rev 193865)
@@ -92,7 +92,6 @@
storage/indexeddb/unblocked-version-changes.html [ Skip ]
# IDB tests with text failures
-storage/indexeddb/createIndex-after-failure.html [ Failure ]
storage/indexeddb/cursor-continue.html [ Failure ]
storage/indexeddb/database-closepending-flag.html [ Failure ]
storage/indexeddb/database-deletepending-flag.html [ Failure ]
Modified: trunk/LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt (193864 => 193865)
--- trunk/LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt 2015-12-09 22:11:41 UTC (rev 193864)
+++ trunk/LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt 2015-12-09 22:22:26 UTC (rev 193865)
@@ -1,4 +1,4 @@
-Test IndexedDB's basics.
+Test createIndex failing due to a ConstraintError
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -17,17 +17,8 @@
Exception message: Failed to execute 'deleteIndex' on 'IDBObjectStore': The specified index was not found.
Now requesting object2
now we wait.
-deleteIndexAfterGet()
-Expecting exception from objectStore.deleteIndex('index')
-PASS Exception was thrown.
-PASS code is DOMException.NOT_FOUND_ERR
-PASS ename is 'NotFoundError'
-Exception message: Failed to execute 'deleteIndex' on 'IDBObjectStore': The specified index was not found.
-Expecting exception from objectStore.deleteIndex('index')
-PASS Exception was thrown.
-PASS code is DOMException.NOT_FOUND_ERR
-PASS ename is 'NotFoundError'
-Exception message: Failed to execute 'deleteIndex' on 'IDBObjectStore': The specified index was not found.
+Error function called: (AbortError) undefined
+PASS Abort function called: (ConstraintError) undefined
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js (193864 => 193865)
--- trunk/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js 2015-12-09 22:11:41 UTC (rev 193864)
+++ trunk/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js 2015-12-09 22:22:26 UTC (rev 193865)
@@ -3,12 +3,13 @@
importScripts('shared.js');
}
-description("Test IndexedDB's basics.");
+description("Test createIndex failing due to a ConstraintError");
indexedDBTest(prepareDatabase);
function prepareDatabase(event)
{
trans = event.target.transaction;
+trans._onabort_ = abortCallback;
db = event.target.result;
db.createObjectStore("objectStore");
@@ -29,18 +30,20 @@
// confused and crash, or think the index still exists.
evalAndExpectException("objectStore.deleteIndex('index')", "DOMException.NOT_FOUND_ERR", "'NotFoundError'");
debug("Now requesting object2");
+
+// None of the following 3 lines will actually do anything because the call to createIndex will forcefully abort the transaction.
var req3 = objectStore.get("object2");
-req3._onsuccess_ = deleteIndexAfterGet;
-req3._onerror_ = unexpectedErrorCallback;
+req3._onsuccess_ = unexpectedSuccessCallback;
+req3._onerror_ = errorCallback;
+
debug("now we wait.");
}
-function deleteIndexAfterGet() {
-// so we will delete it next, but it should already be gone... right?
-debug("deleteIndexAf
[webkit-changes] [193866] tags/Safari-601.1.46.60.1/
Title: [193866] tags/Safari-601.1.46.60.1/ Revision 193866 Author bshaf...@apple.com Date 2015-12-09 14:32:42 -0800 (Wed, 09 Dec 2015) Log Message New tag. Added Paths tags/Safari-601.1.46.60.1/ Diff Property changes: tags/Safari-601.1.46.60.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193867] trunk/LayoutTests
Title: [193867] trunk/LayoutTests
Revision 193867
Author beid...@apple.com
Date 2015-12-09 14:36:04 -0800 (Wed, 09 Dec 2015)
Log Message
Modern IDB: Some tests expect UInt8Array to be a valid key.
https://bugs.webkit.org/show_bug.cgi?id=152092
Reviewed by Alex Christensen.
Everything that expected UInt8Array to be a valid key needs to be updated to expect it to be invalid.
* platform/mac-wk1/TestExpectations:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/key-type-binary-expected.txt:
* storage/indexeddb/resources/factory-cmp.js:
* storage/indexeddb/resources/key-type-binary.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/storage/indexeddb/factory-cmp-expected.txt
trunk/LayoutTests/storage/indexeddb/key-type-binary-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/factory-cmp.js
trunk/LayoutTests/storage/indexeddb/resources/key-type-binary.js
Diff
Modified: trunk/LayoutTests/ChangeLog (193866 => 193867)
--- trunk/LayoutTests/ChangeLog 2015-12-09 22:32:42 UTC (rev 193866)
+++ trunk/LayoutTests/ChangeLog 2015-12-09 22:36:04 UTC (rev 193867)
@@ -1,5 +1,20 @@
2015-12-09 Brady Eidson
+Modern IDB: Some tests expect UInt8Array to be a valid key.
+https://bugs.webkit.org/show_bug.cgi?id=152092
+
+Reviewed by Alex Christensen.
+
+Everything that expected UInt8Array to be a valid key needs to be updated to expect it to be invalid.
+
+* platform/mac-wk1/TestExpectations:
+* storage/indexeddb/factory-cmp-expected.txt:
+* storage/indexeddb/key-type-binary-expected.txt:
+* storage/indexeddb/resources/factory-cmp.js:
+* storage/indexeddb/resources/key-type-binary.js:
+
+2015-12-09 Brady Eidson
+
Modern IDB: storage/indexeddb/createIndex-after-failure.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152078
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193866 => 193867)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 22:32:42 UTC (rev 193866)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 22:36:04 UTC (rev 193867)
@@ -97,7 +97,6 @@
storage/indexeddb/database-deletepending-flag.html [ Failure ]
storage/indexeddb/delete-closed-database-object.html [ Failure ]
storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html [ Failure ]
-storage/indexeddb/factory-cmp.html [ Failure ]
storage/indexeddb/index-basics.html [ Failure ]
storage/indexeddb/index-count.html [ Failure ]
storage/indexeddb/index-duplicate-keypaths.html [ Failure ]
@@ -112,7 +111,6 @@
storage/indexeddb/intversion-two-opens-no-versions.html [ Failure ]
storage/indexeddb/intversion-upgrades.html [ Failure ]
storage/indexeddb/key-type-array.html [ Failure ]
-storage/indexeddb/key-type-binary.html [ Failure ]
storage/indexeddb/lazy-index-types.html [ Failure ]
storage/indexeddb/metadata.html [ Failure ]
storage/indexeddb/objectstore-autoincrement.html [ Failure ]
Modified: trunk/LayoutTests/storage/indexeddb/factory-cmp-expected.txt (193866 => 193867)
--- trunk/LayoutTests/storage/indexeddb/factory-cmp-expected.txt 2015-12-09 22:32:42 UTC (rev 193866)
+++ trunk/LayoutTests/storage/indexeddb/factory-cmp-expected.txt 2015-12-09 22:36:04 UTC (rev 193867)
@@ -92,41 +92,9 @@
PASS indexedDB.cmp('�','𝄞') is 1
PASS indexedDB.cmp('𝄞','𝄞') is 0
PASS indexedDB.cmp('�','�') is 0
-PASS indexedDB.cmp('�',new Uint8Array()) is -1
-PASS indexedDB.cmp(new Uint8Array(),'�') is 1
+PASS indexedDB.cmp('�',[]) is -1
+PASS indexedDB.cmp([],'�') is 1
PASS indexedDB.cmp('�','�') is 0
-PASS indexedDB.cmp(new Uint8Array(),new Uint8Array()) is 0
-PASS indexedDB.cmp(new Uint8Array(),new Uint8Array([0])) is -1
-PASS indexedDB.cmp(new Uint8Array([0]),new Uint8Array()) is 1
-PASS indexedDB.cmp(new Uint8Array(),new Uint8Array()) is 0
-PASS indexedDB.cmp(new Uint8Array([0]),new Uint8Array([0])) is 0
-PASS indexedDB.cmp(new Uint8Array([0]),new Uint8Array([0, 0])) is -1
-PASS indexedDB.cmp(new Uint8Array([0, 0]),new Uint8Array([0])) is 1
-PASS indexedDB.cmp(new Uint8Array([0]),new Uint8Array([0])) is 0
-PASS indexedDB.cmp(new Uint8Array([0, 0]),new Uint8Array([0, 0])) is 0
-PASS indexedDB.cmp(new Uint8Array([0, 0]),new Uint8Array([0, 1])) is -1
-PASS indexedDB.cmp(new Uint8Array([0, 1]),new Uint8Array([0, 0])) is 1
-PASS indexedDB.cmp(new Uint8Array([0, 0]),new Uint8Array([0, 0])) is 0
-PASS indexedDB.cmp(new Uint8Array([0, 1]),new Uint8Array([0, 1])) is 0
-PASS indexedDB.cmp(new Uint8Array([0, 1]),new Uint8Array([1])) is -1
-PASS indexedDB.cmp(new Uint8Array([1]),new Uint8Array([0, 1])) is 1
-PASS indexedDB.cmp(new Uint8Array([0, 1]),new Uint8Array([0, 1])) is 0
-PASS indexedDB.cmp(new Uint8Array([1]),new Uint8Array([1])) is 0
-PASS indexedDB.cmp(new Uint8Array([1]),new Uint8Array([1, 0])) is -1
-PASS indexedDB.cmp(new Uint8Array([1, 0]),new Uint8Array([1])) is 1
-PASS indexedDB.cmp(new Uint8Arra
[webkit-changes] [193869] branches/safari-601.1.46-branch
Title: [193869] branches/safari-601.1.46-branch
Revision 193869
Author matthew_han...@apple.com
Date 2015-12-09 14:39:46 -0800 (Wed, 09 Dec 2015)
Log Message
Merge r192639. rdar://problem/23814338
Modified Paths
branches/safari-601.1.46-branch/LayoutTests/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/FontCascade.cpp
branches/safari-601.1.46-branch/Source/WebCore/rendering/RenderCombineText.cpp
Added Paths
branches/safari-601.1.46-branch/LayoutTests/fast/text/resources/tatechuyoko.svg
branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-placement-expected.html
branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-placement.html
Diff
Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (193868 => 193869)
--- branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-12-09 22:39:42 UTC (rev 193868)
+++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-12-09 22:39:46 UTC (rev 193869)
@@ -1,5 +1,21 @@
2015-12-09 Matthew Hanson
+Merge r192639. rdar://problem/23814338
+
+2015-11-19 Myles C. Maxfield
+
+Tatechuyoko in ruby sits too high
+https://bugs.webkit.org/show_bug.cgi?id=151309
+
+
+Reviewed by Darin Adler.
+
+* fast/text/resources/tatechuyoko.svg: Added.
+* fast/text/text-combine-placement-expected.html: Added.
+* fast/text/text-combine-placement.html: Added.
+
+2015-12-09 Matthew Hanson
+
Merge r192388. rdar://problem/23814336
2015-11-12 David Hyatt
Added: branches/safari-601.1.46-branch/LayoutTests/fast/text/resources/tatechuyoko.svg (0 => 193869)
--- branches/safari-601.1.46-branch/LayoutTests/fast/text/resources/tatechuyoko.svg (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/fast/text/resources/tatechuyoko.svg 2015-12-09 22:39:46 UTC (rev 193869)
@@ -0,0 +1,11 @@
+
+
+
+
+
+
+
+
+
+
+
Added: branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-placement-expected.html (0 => 193869)
--- branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-placement-expected.html (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-placement-expected.html 2015-12-09 22:39:46 UTC (rev 193869)
@@ -0,0 +1,19 @@
+
+
+
+
+@font-face {
+font-family: "Litherum";
+src: url("resources/tatechuyoko.svg#Litherum") format("svg");
+}
+
+
+
+This test makes sure that tatechuyoko glyphs are centered correctly within the space left for them. The test is successful if the three boxes on the left have the same vertical positions as the three boxes on the right. The two vertically-middle boxes should be vertically centered between the four corner boxes.
+Note that the boxes' horizontal spacing is irrelevant here. We are only interested in vertical spacing.
+
+AAA
+AAA
+
+
+
\ No newline at end of file
Added: branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-placement.html (0 => 193869)
--- branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-placement.html (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-placement.html 2015-12-09 22:39:46 UTC (rev 193869)
@@ -0,0 +1,19 @@
+
+
+
+
+@font-face {
+font-family: "Litherum";
+src: url("resources/tatechuyoko.svg#Litherum") format("svg");
+}
+
+
+
+This test makes sure that tatechuyoko glyphs are centered correctly within the space left for them. The test is successful if the three boxes on the left have the same vertical positions as the three boxes on the right. The two vertically-middle boxes should be vertically centered between the four corner boxes.
+Note that the boxes' horizontal spacing is irrelevant here. We are only interested in vertical spacing.
+
+AAA
+AのA
+
+
+
\ No newline at end of file
Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (193868 => 193869)
--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-12-09 22:39:42 UTC (rev 193868)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-12-09 22:39:46 UTC (rev 193869)
@@ -1,5 +1,32 @@
2015-12-09 Matthew Hanson
+Merge r192639. rdar://problem/23814338
+
+2015-11-19 Myles C. Maxfield
+
+Tatechuyoko in ruby sits too high
+https://bugs.webkit.org/show_bug.cgi?id=151309
+
+
+Reviewed by Darin Adler.
+
+When combining text, we ask what the text's width is in order to determine if it fits in the
+column. However, when we do that, we were not setting the font's orientation to horizontal.
+This means that, for CJK text, the "width" which was returned was actually the height of the
+glyph, and the GlyphOverflow data was similarly garbled.
+
+We ac
[webkit-changes] [193868] branches/safari-601.1.46-branch
Title: [193868] branches/safari-601.1.46-branch
Revision 193868
Author matthew_han...@apple.com
Date 2015-12-09 14:39:42 -0800 (Wed, 09 Dec 2015)
Log Message
Merge r192388. rdar://problem/23814336
Modified Paths
branches/safari-601.1.46-branch/LayoutTests/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/rendering/RenderCombineText.cpp
Added Paths
branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-shrink-on-color-change.html
branches/safari-601.1.46-branch/LayoutTests/platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png
branches/safari-601.1.46-branch/LayoutTests/platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt
Diff
Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (193867 => 193868)
--- branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-12-09 22:36:04 UTC (rev 193867)
+++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-12-09 22:39:42 UTC (rev 193868)
@@ -1,3 +1,19 @@
+2015-12-09 Matthew Hanson
+
+Merge r192388. rdar://problem/23814336
+
+2015-11-12 David Hyatt
+
+Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
+https://bugs.webkit.org/show_bug.cgi?id=151218
+
+
+Reviewed by Myles Maxfield.
+
+* fast/text/text-combine-shrink-on-color-change.html: Added.
+* platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
+* platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
+
2015-12-09 Babak Shafiei
Merge r190505.
Added: branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-shrink-on-color-change.html (0 => 193868)
--- branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-shrink-on-color-change.html (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/fast/text/text-combine-shrink-on-color-change.html 2015-12-09 22:39:42 UTC (rev 193868)
@@ -0,0 +1,13 @@
+
+1 123456 2
+
+
+document.body.offsetLeft;
+document.getElementById('change').style.color='green';
+document.body.offsetLeft;
+
\ No newline at end of file
Added: branches/safari-601.1.46-branch/LayoutTests/platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png (0 => 193868)
--- branches/safari-601.1.46-branch/LayoutTests/platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png 2015-12-09 22:39:42 UTC (rev 193868)
@@ -0,0 +1,83 @@
+\x89PNG
+
++IHDR X\x9Av\x82p)tEXtchecksumc326ea77f53fe0e7cb13239520796f88\xBE\x80ZhsRGB\xAE\xCE \xE95fIDATx\xED\xDD{\x90\xDEy/\xF0gs%\xE1~ 0J\xB9\xC9\xC5\xE7\xD4\x83VJS\x918\xE8\x95*N-7 k\xC7)N\xE9\x8C\xE90\xF5tlaF+\x96x9N\xA5\xEDA-\x8C"##\x90\x8B\xA6(\xE8\xE1~" \xB7!!\x81\x90\xDDl\xF6\xE4\xF7c\xF6u\xB3\xEC `\xF8\xE5Y\xFA|6\x93\xEC\xFB\xFE\xDEw\xCF~?O\xFE\xF9\xCE{\xEB\xDA\xF8\xBE @\x80 \xB0&l\x85F @\x80 @\xA0P@\xFCG @\x80 @`\xAB ( [\x8D\xDA @\x80\xFF @\x80\xD8j
+\xC8V\xA36\x88 @\x80\xC4\xFF @\x80\xB6\x9A\x80\xB2ը+"@\x80 @@\xF1\x80 @\x80\x81\xAD&\xA0\x80l5j\x83 @\x80P@\xFC @\x80 @`\xAB ( [\x8D\xDA @\x80\xFF @\x80\xD8j\x9D\x90\xC1+\x83\xB1~\xC3\xFA\xCEB4\xE7nf\xF8"@\x80 @\xE0\xB5%\xD0I\xF9\xDCM\x9F\x8BO\xFC\xE0\x9DI\x9C\xF7 \xE7\xC5_\xFF\xE8\xAF;;\xBF @\x80 Ѝ\xC0\xA4nN\xF1\xC83\x8Ftu\xEA \x8Ce\xCF.\xEB\xEC\xFCNL\x80 @\x80@7\x9D<\xD2\xFC\xAA7,\xB9!\xAF\\xDC\xC9o\xBDhŢX\xBAzi'\xE7vR @\x80\xBA\xE8\xEC\x90\xD5\xFD\xAB\xE3\xC0\xF9\xC6a{ 3\xA6ψ)\xA7D__\xDF\xEF\x9Cd`p \xD6+\xAE\x8BkW\xC4\xEDKo\x8Fw=\xF0w>\x97 $@\x80 @ G\xA0\xB3\xD2\xC4i
+\xC3\xC2\xC7v\x92l\xD1Ӌ\xA2\xB0\xBF-6\x9D pR @\x80^u\x81Ξ\x82\xF5\xAA\xFF\xA6\xA3N8\xB0a \xEEy\xF2\x9EQG]%@\x80 @`< t\xFA\xC8\xEE\xD3w\x8Fw\xED\xFF\xAE\xD8e\xDA.1y\xC2\xE4W\xF4\xAC+Cbhh\xA8}\xC1y\xF3HG\xF3\xAC\xE7\x9E\x8B5\xFDk\xE2فg\xDB\xEFK\xD7,\x8D\xC37\xFE\xF1E\x80 @\x80\xC0kC\xA0\xB3\xB2\xEF\x8E\xFB\xC6\xDD \xBF;\xA6O\x9E\xFEڐ\xF0[ @\x80 й@gO\xC1:v\x9Fc\x95\x8F\xCE\xD7g @\x80\x81ז@'\x8F\x80\xCC\xDC~fL\x9D4\xF5\xB5%\xE1\xB7%@\x80 @\xA0s\x81\xBE\x8D\xAF\xB3\xEA|\x8A @\x80\xD8(\xD0\xD9S\xB0\xE8 @\x80 @`\xB4\x802Z\xC4u @\x80:P@:\xA3ub @\x80F ( \xA3E\'@\x80 @\xA03\xA43Z'&@\x80 @`\xB4\x802Z\xC4u @\x80:P@:\xA3ub @\x80F ( \xA3E\'@\x80 @\xA03\xA43Z'&@\x80 @`\xB4\x802Z\xC4u @\x80:P@:\xA3ub @\x80F ( \xA3E\'@\x80 @\xA03\xA43Z'&@\x80 @`\xB4\x802Z\xC4u @\x80:P@:\xA3ub @\x80F ( \xA3E\'@
\x80 @\xA03\xA43Z'&@\x80 @`\xB4\x802Z\xC4u @\x80:P@:\xA3ub @\x80F
[webkit-changes] [193870] trunk/Source/WebInspectorUI
Title: [193870] trunk/Source/WebInspectorUI Revision 193870 Author bb...@apple.com Date 2015-12-09 14:45:21 -0800 (Wed, 09 Dec 2015) Log Message Web Inspector: control whether to collect and dump protocol messages using a WebInspector.Setting https://bugs.webkit.org/show_bug.cgi?id=151635 Reviewed by Timothy Hatcher. When closing and reopening the inspector, the setting for whether to dump protocol messages should be persisted. Otherwise, enabling dumping from the debug-only UI will miss the initial flood of messages that are processed when the Inspector loads initial data. To support a persistent setting, and build some infrastructure for more advanced uses of collected protocol messages, this patch adds a new object to trace protocol events. It gets callbacks for each and implements the console-dumping functionality previously baked in to InspectorBackend. In follow-up patches, other protocol tracers will be added to save protocol data to disk, marshall it to a higher inspection level, or provide more fine-grained control over what is logged. This change moves Setting.js into the Base/ directory, since it is used by Views, Models, and now Protocol classes. * UserInterface/Base/Setting.js: Renamed from Source/WebInspectorUI/UserInterface/Models/Setting.js. (WebInspector.Setting): (WebInspector.Setting.prototype.get name): (WebInspector.Setting.prototype.get value): (WebInspector.Setting.prototype.set value): * UserInterface/Main.html: * UserInterface/Protocol/InspectorBackend.js: (InspectorBackendClass): (InspectorBackendClass.prototype.set dumpInspectorProtocolMessages): (InspectorBackendClass.prototype.get dumpInspectorProtocolMessages): We still want to support the legacy way to enable dumping: `InspectorBackend.dumpInspectorProtocolMessages = true`. This is because some tests always use it, and it's easier to set this flag in a custom Bootstrap.js file than to configure the Setting. (InspectorBackendClass.prototype.set dumpInspectorTimeStats): (InspectorBackendClass.prototype.get dumpInspectorTimeStats): We still want to support the legacy way to enable dumping: `InspectorBackend.dumpInspectorTimeStats = true`. This is because MessageDispatcher checks this flag for its logging. (InspectorBackendClass.prototype.set activeTracer): (InspectorBackendClass.prototype.get activeTracer): Set the active tracer, finalizing and removing any active tracer if one exists. If removing a custom tracer (setting to null), then re-sync activeTracer with the automatic tracing Setting. (InspectorBackendClass.prototype.dispatch): (InspectorBackendClass.prototype._startOrStopAutomaticTracing): Sync the Setting with activeTracer. If an custom tracer is active, don't replace it with the automatic logging tracer. (InspectorBackendClass.prototype._sendCommandToBackendWithCallback): (InspectorBackendClass.prototype._sendCommandToBackendExpectingPromise): (InspectorBackendClass.prototype._sendMessageToBackend): (InspectorBackendClass.prototype._dispatchResponse): (InspectorBackendClass.prototype._dispatchEvent): (InspectorBackendClass.prototype._flushPendingScripts): * UserInterface/Protocol/LoggingProtocolTracer.js: Added. (WebInspector.LoggingProtocolTracer): (WebInspector.LoggingProtocolTracer.prototype.set dumpMessagesToConsole): (WebInspector.LoggingProtocolTracer.prototype.get dumpMessagesToConsole): (WebInspector.LoggingProtocolTracer.prototype.set dumpTimingDataToConsole): (WebInspector.LoggingProtocolTracer.prototype.get dumpTimingDataToConsole): (WebInspector.LoggingProtocolTracer.prototype.logFrontendException): (WebInspector.LoggingProtocolTracer.prototype.logProtocolError): (WebInspector.LoggingProtocolTracer.prototype.logFrontendRequest): (WebInspector.LoggingProtocolTracer.prototype.logWillHandleResponse): (WebInspector.LoggingProtocolTracer.prototype.logDidHandleResponse): (WebInspector.LoggingProtocolTracer.prototype.logWillHandleEvent): (WebInspector.LoggingProtocolTracer.prototype.logDidHandleEvent): (WebInspector.LoggingProtocolTracer.prototype._processEntry): * UserInterface/Protocol/ProtocolTracer.js: Added. (WebInspector.ProtocolTracer.prototype.logStarted): (WebInspector.ProtocolTracer.prototype.logFrontendException): (WebInspector.ProtocolTracer.prototype.logProtocolError): (WebInspector.ProtocolTracer.prototype.logFrontendRequest): (WebInspector.ProtocolTracer.prototype.logWillHandleResponse): (WebInspector.ProtocolTracer.prototype.logDidHandleResponse): (WebInspector.ProtocolTracer.prototype.logWillHandleEvent): (WebInspector.ProtocolTracer.prototype.logDidHandleEvent):(WebInspector.ProtocolTracer.prototype.logFinished): (WebInspector.ProtocolTracer): * UserInterface/Test.html: Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js trunk/Source/WebInspectorUI/UserInterface/Test.html Added Paths trunk/
[webkit-changes] [193871] trunk
Title: [193871] trunk Revision 193871 Author beid...@apple.com Date 2015-12-09 14:46:10 -0800 (Wed, 09 Dec 2015) Log Message Modern IDB: storage/indexeddb/database-closepending-flag.html fails. https://bugs.webkit.org/show_bug.cgi?id=152095 Reviewed by Alex Christensen. Source/WebCore: No new tests (At least one failing test now passes). The server-side checks the closepending flag before dispatching the event to the client, but due to the inherent asynchronous race between server and client, the client needs to check its closePending flag as well. * Modules/indexeddb/client/IDBDatabaseImpl.cpp: (WebCore::IDBClient::IDBDatabase::fireVersionChangeEvent): Don't fire if m_closePending is set. LayoutTests: * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp Diff Modified: trunk/LayoutTests/ChangeLog (193870 => 193871) --- trunk/LayoutTests/ChangeLog 2015-12-09 22:45:21 UTC (rev 193870) +++ trunk/LayoutTests/ChangeLog 2015-12-09 22:46:10 UTC (rev 193871) @@ -1,5 +1,14 @@ 2015-12-09 Brady Eidson +Modern IDB: storage/indexeddb/database-closepending-flag.html fails. +https://bugs.webkit.org/show_bug.cgi?id=152095 + +Reviewed by Alex Christensen. + +* platform/mac-wk1/TestExpectations: + +2015-12-09 Brady Eidson + Modern IDB: Some tests expect UInt8Array to be a valid key. https://bugs.webkit.org/show_bug.cgi?id=152092 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193870 => 193871) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 22:45:21 UTC (rev 193870) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 22:46:10 UTC (rev 193871) @@ -93,7 +93,6 @@ # IDB tests with text failures storage/indexeddb/cursor-continue.html [ Failure ] -storage/indexeddb/database-closepending-flag.html [ Failure ] storage/indexeddb/database-deletepending-flag.html [ Failure ] storage/indexeddb/delete-closed-database-object.html [ Failure ] storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html [ Failure ] Modified: trunk/Source/WebCore/ChangeLog (193870 => 193871) --- trunk/Source/WebCore/ChangeLog 2015-12-09 22:45:21 UTC (rev 193870) +++ trunk/Source/WebCore/ChangeLog 2015-12-09 22:46:10 UTC (rev 193871) @@ -1,3 +1,19 @@ +2015-12-09 Brady Eidson + +Modern IDB: storage/indexeddb/database-closepending-flag.html fails. +https://bugs.webkit.org/show_bug.cgi?id=152095 + +Reviewed by Alex Christensen. + +No new tests (At least one failing test now passes). + +The server-side checks the closepending flag before dispatching the event to the client, +but due to the inherent asynchronous race between server and client, the client needs to +check its closePending flag as well. + +* Modules/indexeddb/client/IDBDatabaseImpl.cpp: +(WebCore::IDBClient::IDBDatabase::fireVersionChangeEvent): Don't fire if m_closePending is set. + 2015-12-09 David Hyatt Picture element needs to respond to dynamic viewport changes. Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp (193870 => 193871) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp 2015-12-09 22:45:21 UTC (rev 193870) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp 2015-12-09 22:46:10 UTC (rev 193871) @@ -362,9 +362,9 @@ uint64_t currentVersion = m_info.version(); LOG(IndexedDB, "IDBDatabase::fireVersionChangeEvent - current version %" PRIu64 ", requested version %" PRIu64, currentVersion, requestedVersion); -if (!scriptExecutionContext()) +if (!scriptExecutionContext() || m_closePending) return; - + Ref event = IDBVersionChangeEvent::create(currentVersion, requestedVersion, eventNames().versionchangeEvent); event->setTarget(this); scriptExecutionContext()->eventQueue().enqueueEvent(WTF::move(event)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193872] trunk/Source/WebInspectorUI
Title: [193872] trunk/Source/WebInspectorUI
Revision 193872
Author mattba...@apple.com
Date 2015-12-09 15:07:10 -0800 (Wed, 09 Dec 2015)
Log Message
Web Inspector: when a marked-dirty subview is attached to a parent View, dirtyDescendantsCount gets out of sync
https://bugs.webkit.org/show_bug.cgi?id=151876
Reviewed by Brian Burg.
* UserInterface/Base/Main.js:
Use root view singleton instead of creating it explicitly.
* UserInterface/Views/View.js:
(WebInspector.View):
(WebInspector.View.rootView):
Singleton root view access. Lazily create and return a view backed
by the document's body element.
(WebInspector.View.prototype.isDescendantOf):
(WebInspector.View.prototype.insertSubviewBefore):
(WebInspector.View.prototype.removeSubview):
(WebInspector.View.prototype.didMoveToWindow):
Notify the view when it becomes, or is no longer, descended from the root view.
(WebInspector.View.prototype.didMoveToParent):
Notify the view when it's added to, or removed from, a parent view.
(WebInspector.View._scheduleLayoutForView):
(WebInspector.View._cancelScheduledLayoutForView):
(WebInspector.View.prototype.makeRootView): Deleted.
No longer needed.
(WebInspector.View.prototype.didAttach): Deleted.
(WebInspector.View.prototype.didDetach): Deleted.
Replaced by didMoveToParent.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/View.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (193871 => 193872)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-09 22:46:10 UTC (rev 193871)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-09 23:07:10 UTC (rev 193872)
@@ -1,3 +1,33 @@
+2015-12-09 Matt Baker
+
+Web Inspector: when a marked-dirty subview is attached to a parent View, dirtyDescendantsCount gets out of sync
+https://bugs.webkit.org/show_bug.cgi?id=151876
+
+Reviewed by Brian Burg.
+
+* UserInterface/Base/Main.js:
+Use root view singleton instead of creating it explicitly.
+
+* UserInterface/Views/View.js:
+(WebInspector.View):
+(WebInspector.View.rootView):
+Singleton root view access. Lazily create and return a view backed
+by the document's body element.
+(WebInspector.View.prototype.isDescendantOf):
+(WebInspector.View.prototype.insertSubviewBefore):
+(WebInspector.View.prototype.removeSubview):
+(WebInspector.View.prototype.didMoveToWindow):
+Notify the view when it becomes, or is no longer, descended from the root view.
+(WebInspector.View.prototype.didMoveToParent):
+Notify the view when it's added to, or removed from, a parent view.
+(WebInspector.View._scheduleLayoutForView):
+(WebInspector.View._cancelScheduledLayoutForView):
+(WebInspector.View.prototype.makeRootView): Deleted.
+No longer needed.
+(WebInspector.View.prototype.didAttach): Deleted.
+(WebInspector.View.prototype.didDetach): Deleted.
+Replaced by didMoveToParent.
+
2015-12-09 Brian Burg
Web Inspector: control whether to collect and dump protocol messages using a WebInspector.Setting
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (193871 => 193872)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-09 22:46:10 UTC (rev 193871)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-09 23:07:10 UTC (rev 193872)
@@ -1438,7 +1438,7 @@
WebInspector._setupViewHierarchy = function()
{
-let rootView = new WebInspector.View(document.body);
+let rootView = WebInspector.View.rootView();
rootView.addSubview(this.toolbar);
rootView.addSubview(this.tabBar);
rootView.addSubview(this.navigationSidebar);
@@ -1446,8 +1446,6 @@
rootView.addSubview(this.splitContentBrowser);
rootView.addSubview(this.quickConsole);
rootView.addSubview(this.detailsSidebar);
-
-rootView.makeRootView();
};
WebInspector._tabBrowserSelectedTabContentViewDidChange = function(event)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/View.js (193871 => 193872)
--- trunk/Source/WebInspectorUI/UserInterface/Views/View.js 2015-12-09 22:46:10 UTC (rev 193871)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/View.js 2015-12-09 23:07:10 UTC (rev 193872)
@@ -35,8 +35,20 @@
this._subviews = [];
this._dirty = false;
this._dirtyDescendantsCount = 0;
+this._needsLayoutWhenAttachedToRoot = false;
+this._isAttachedToRoot = false;
}
+// Static
+
+static rootView()
+{
+if (!WebInspector.View._rootView)
+WebInspector.View._rootView = new WebInspector.View(document.body);
+
+return WebInspector.View._rootView;
+}
+
// Public
get element()
@@ -59,14 +71,16 @@
return this._subviews;
}
-makeRootView()
+isDescendantOf(view)
{
-conso
[webkit-changes] [193873] trunk/Source
Title: [193873] trunk/Source Revision 193873 Author akl...@apple.com Date 2015-12-09 15:21:14 -0800 (Wed, 09 Dec 2015) Log Message [iOS] ResourceUsageOverlay should work on iOS. Reviewed by Antti Koivisto. Source/WebCore: Make ResourceUsageOverlay work on iOS and on Mac desktops with UI-side compositing. * page/ResourceUsageOverlay.cpp: (WebCore::ResourceUsageOverlay::initialize): Move the overlay to the top of the view on iOS for now. * page/ResourceUsageOverlay.h: * page/cocoa/ResourceUsageOverlayCocoa.mm: (WebCore::createColor): Make a custom CGColor factory since we can't use CGColorCreateGenericRGB on iOS. (WebCore::MemoryCategoryInfo::MemoryCategoryInfo): (WebCore::ResourceUsageOverlay::platformInitialize): Put the overlay CALayer into a container layer and hook it up with GraphicsLayer::setContentsToPlatformLayer so it works with all compositing modes. (WebCore::showText): Move CGContextSaveGState call to the top of the function to preserve everything. (WebCore::drawGraphLabel): (WebCore::drawCpuHistory): (WebCore::drawGCHistory): (WebCore::ResourceUsageOverlay::platformDraw): Flip the CGContext if needed. (WebCore::runSamplerThread): Update the layer rects on each thread iteration. This shouldn't be necessary but it papers over an issue where the containing layer would shrink down to 0x0 and disappear. Added a FIXME for this. * platform/spi/cocoa/MachVMSPI.h: Add purgeable VM SPI. Source/WTF: * wtf/Platform.h: Enable RESOURCE_USAGE_OVERLAY for all COCOA platforms. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/ResourceUsageOverlay.cpp trunk/Source/WebCore/page/ResourceUsageOverlay.h trunk/Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm trunk/Source/WebCore/platform/spi/cocoa/MachVMSPI.h Diff Modified: trunk/Source/WTF/ChangeLog (193872 => 193873) --- trunk/Source/WTF/ChangeLog 2015-12-09 23:07:10 UTC (rev 193872) +++ trunk/Source/WTF/ChangeLog 2015-12-09 23:21:14 UTC (rev 193873) @@ -1,3 +1,12 @@ +2015-12-09 Andreas Kling + +[iOS] ResourceUsageOverlay should work on iOS. + + +Reviewed by Antti Koivisto. + +* wtf/Platform.h: Enable RESOURCE_USAGE_OVERLAY for all COCOA platforms. + 2015-12-08 Joseph Pecoraro Create a Sandbox SPI header Modified: trunk/Source/WTF/wtf/Platform.h (193872 => 193873) --- trunk/Source/WTF/wtf/Platform.h 2015-12-09 23:07:10 UTC (rev 193872) +++ trunk/Source/WTF/wtf/Platform.h 2015-12-09 23:21:14 UTC (rev 193873) @@ -1079,7 +1079,7 @@ #define USE_IOSURFACE 1 #endif -#if PLATFORM(MAC) +#if PLATFORM(COCOA) #define ENABLE_RESOURCE_USAGE_OVERLAY 1 #endif Modified: trunk/Source/WebCore/ChangeLog (193872 => 193873) --- trunk/Source/WebCore/ChangeLog 2015-12-09 23:07:10 UTC (rev 193872) +++ trunk/Source/WebCore/ChangeLog 2015-12-09 23:21:14 UTC (rev 193873) @@ -1,3 +1,30 @@ +2015-12-09 Andreas Kling + +[iOS] ResourceUsageOverlay should work on iOS. + + +Reviewed by Antti Koivisto. + +Make ResourceUsageOverlay work on iOS and on Mac desktops with UI-side compositing. + +* page/ResourceUsageOverlay.cpp: +(WebCore::ResourceUsageOverlay::initialize): Move the overlay to the top of the view on iOS for now. +* page/ResourceUsageOverlay.h: +* page/cocoa/ResourceUsageOverlayCocoa.mm: +(WebCore::createColor): Make a custom CGColor factory since we can't use CGColorCreateGenericRGB on iOS. +(WebCore::MemoryCategoryInfo::MemoryCategoryInfo): +(WebCore::ResourceUsageOverlay::platformInitialize): Put the overlay CALayer into a container layer and +hook it up with GraphicsLayer::setContentsToPlatformLayer so it works with all compositing modes. +(WebCore::showText): Move CGContextSaveGState call to the top of the function to preserve everything. +(WebCore::drawGraphLabel): +(WebCore::drawCpuHistory): +(WebCore::drawGCHistory): +(WebCore::ResourceUsageOverlay::platformDraw): Flip the CGContext if needed. +(WebCore::runSamplerThread): Update the layer rects on each thread iteration. This shouldn't be +necessary but it papers over an issue where the containing layer would shrink down to 0x0 and +disappear. Added a FIXME for this. +* platform/spi/cocoa/MachVMSPI.h: Add purgeable VM SPI. + 2015-12-09 Brady Eidson Modern IDB: storage/indexeddb/database-closepending-flag.html fails. Modified: trunk/Source/WebCore/page/ResourceUsageOverlay.cpp (193872 => 193873) --- trunk/Source/WebCore/page/ResourceUsageOverlay.cpp 2015-12-09 23:07:10 UTC (rev 193872) +++ trunk/Source/WebCore/page/ResourceUsageOverlay.cpp 2015-12-09 23:21:14 UTC (rev 193873) @@ -61,7 +61,15 @@ return; FrameView& frameView = *m_page.mainFrame().view(); -m_overlay->setFrame(IntRect(frameView.width() / 2 - normalWidth / 2, frameView.height() - normalHeight
[webkit-changes] [193874] tags/Safari-601.4.2/
Title: [193874] tags/Safari-601.4.2/ Revision 193874 Author bshaf...@apple.com Date 2015-12-09 15:23:57 -0800 (Wed, 09 Dec 2015) Log Message New tag. Added Paths tags/Safari-601.4.2/ Diff Property changes: tags/Safari-601.4.2 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193875] trunk
Title: [193875] trunk
Revision 193875
Author beid...@apple.com
Date 2015-12-09 15:40:18 -0800 (Wed, 09 Dec 2015)
Log Message
Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152096
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes).
* bindings/js/JSIDBDatabaseCustom.cpp:
(WebCore::JSIDBDatabase::transaction): In addition to JSArrays, treat DOMStringLists as a valid string sequence.
LayoutTests:
* platform/mac-wk1/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (193874 => 193875)
--- trunk/LayoutTests/ChangeLog 2015-12-09 23:23:57 UTC (rev 193874)
+++ trunk/LayoutTests/ChangeLog 2015-12-09 23:40:18 UTC (rev 193875)
@@ -1,5 +1,14 @@
2015-12-09 Brady Eidson
+Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
+https://bugs.webkit.org/show_bug.cgi?id=152096
+
+Reviewed by Alex Christensen.
+
+* platform/mac-wk1/TestExpectations:
+
+2015-12-09 Brady Eidson
+
Modern IDB: storage/indexeddb/database-closepending-flag.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152095
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193874 => 193875)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 23:23:57 UTC (rev 193874)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 23:40:18 UTC (rev 193875)
@@ -100,7 +100,6 @@
storage/indexeddb/index-count.html [ Failure ]
storage/indexeddb/index-duplicate-keypaths.html [ Failure ]
storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html [ Failure ]
-storage/indexeddb/intversion-close-between-events.html [ Failure ]
storage/indexeddb/intversion-close-in-oncomplete.html [ Failure ]
storage/indexeddb/intversion-close-in-upgradeneeded.html [ Failure ]
storage/indexeddb/intversion-gated-on-delete.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (193874 => 193875)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 23:23:57 UTC (rev 193874)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 23:40:18 UTC (rev 193875)
@@ -1,3 +1,15 @@
+2015-12-09 Brady Eidson
+
+Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
+https://bugs.webkit.org/show_bug.cgi?id=152096
+
+Reviewed by Alex Christensen.
+
+No new tests (At least one failing test now passes).
+
+* bindings/js/JSIDBDatabaseCustom.cpp:
+(WebCore::JSIDBDatabase::transaction): In addition to JSArrays, treat DOMStringLists as a valid string sequence.
+
2015-12-09 Andreas Kling
[iOS] ResourceUsageOverlay should work on iOS.
Modified: trunk/Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp (193874 => 193875)
--- trunk/Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp 2015-12-09 23:23:57 UTC (rev 193874)
+++ trunk/Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp 2015-12-09 23:40:18 UTC (rev 193875)
@@ -36,6 +36,7 @@
#include "IDBKeyPath.h"
#include "IDBObjectStore.h"
#include "JSDOMBinding.h"
+#include "JSDOMStringList.h"
#include "JSIDBObjectStore.h"
#include
#include
@@ -93,11 +94,13 @@
Vector scope;
JSValue scopeArg(exec.argument(0));
-if (scopeArg.isObject() && isJSArray(scopeArg)) {
-scope = toNativeArray(&exec, scopeArg);
-if (exec.hadException())
-return jsUndefined();
-} else {
+auto domStringList = JSDOMStringList::toWrapped(&exec, scopeArg);
+if (exec.hadException())
+return jsUndefined();
+
+if (domStringList)
+scope = Vector(*domStringList);
+else {
scope.append(scopeArg.toString(&exec)->value(&exec));
if (exec.hadException())
return jsUndefined();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193876] trunk/Source/WebCore
Title: [193876] trunk/Source/WebCore
Revision 193876
Author simon.fra...@apple.com
Date 2015-12-09 15:51:54 -0800 (Wed, 09 Dec 2015)
Log Message
Adjust layer backing store format
https://bugs.webkit.org/show_bug.cgi?id=152097
rdar://problem/23305376
Reviewed by Tim Horton.
Call setBackingStoreFormat() on UIWebView tile grid layers, and on compositing
layers which can allocate backing store.
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::setBackingStoreFormat):
(PlatformCALayerCocoa::commonInit):
* platform/ios/LegacyTileGridTile.mm:
(WebCore::setBackingStoreFormat):
(WebCore::LegacyTileGridTile::LegacyTileGridTile):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
trunk/Source/WebCore/platform/ios/LegacyTileGridTile.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (193875 => 193876)
--- trunk/Source/WebCore/ChangeLog 2015-12-09 23:40:18 UTC (rev 193875)
+++ trunk/Source/WebCore/ChangeLog 2015-12-09 23:51:54 UTC (rev 193876)
@@ -1,3 +1,21 @@
+2015-12-09 Simon Fraser
+
+Adjust layer backing store format
+https://bugs.webkit.org/show_bug.cgi?id=152097
+rdar://problem/23305376
+
+Reviewed by Tim Horton.
+
+Call setBackingStoreFormat() on UIWebView tile grid layers, and on compositing
+layers which can allocate backing store.
+
+* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
+(WebCore::setBackingStoreFormat):
+(PlatformCALayerCocoa::commonInit):
+* platform/ios/LegacyTileGridTile.mm:
+(WebCore::setBackingStoreFormat):
+(WebCore::LegacyTileGridTile::LegacyTileGridTile):
+
2015-12-09 Brady Eidson
Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
Modified: trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm (193875 => 193876)
--- trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm 2015-12-09 23:40:18 UTC (rev 193875)
+++ trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm 2015-12-09 23:51:54 UTC (rev 193876)
@@ -65,6 +65,16 @@
@end
#endif
+#if __has_include()
+#import
+#else
+namespace WebCore {
+static void setBackingStoreFormat(CALayer *)
+{
+}
+} // namespace WebCore
+#endif
+
SOFT_LINK_FRAMEWORK_OPTIONAL(AVFoundation)
SOFT_LINK_CLASS(AVFoundation, AVPlayerLayer)
@@ -297,6 +307,9 @@
else
[m_layer setDelegate:[WebActionDisablingCALayerDelegate shared]];
+if (m_layerType == LayerTypeWebLayer || m_layerType == LayerTypeTiledBackingTileLayer)
+setBackingStoreFormat(m_layer.get());
+
// So that the scrolling thread's performance logging code can find all the tiles, mark this as being a tile.
if (m_layerType == LayerTypeTiledBackingTileLayer)
[m_layer setValue:@YES forKey:@"isTile"];
Modified: trunk/Source/WebCore/platform/ios/LegacyTileGridTile.mm (193875 => 193876)
--- trunk/Source/WebCore/platform/ios/LegacyTileGridTile.mm 2015-12-09 23:40:18 UTC (rev 193875)
+++ trunk/Source/WebCore/platform/ios/LegacyTileGridTile.mm 2015-12-09 23:51:54 UTC (rev 193876)
@@ -38,8 +38,18 @@
#include
#include
+#if __has_include()
+#import
+#else
namespace WebCore {
+static void setBackingStoreFormat(CALayer *)
+{
+}
+} // namespace WebCore
+#endif
+namespace WebCore {
+
#if LOG_TILING
static int totalTileCount;
#endif
@@ -60,6 +70,7 @@
m_tileLayer = adoptNS([[LegacyTileLayer alloc] init]);
}
LegacyTileLayer* layer = m_tileLayer.get();
+setBackingStoreFormat(layer);
[layer setTileGrid:tileGrid];
[layer setOpaque:m_tileGrid->tileCache().tilesOpaque()];
[layer setEdgeAntialiasingMask:0];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193877] trunk/Source/WebKit2
Title: [193877] trunk/Source/WebKit2 Revision 193877 Author commit-qu...@webkit.org Date 2015-12-09 15:57:59 -0800 (Wed, 09 Dec 2015) Log Message Unreviewed, rolling out r193864. https://bugs.webkit.org/show_bug.cgi?id=152100 caused all inspector tests to assert in WK2 Debug (Requested by brrian on #webkit). Reverted changeset: "Web Inspector: reproducible debug ASSERT when inspecting the inspector (WK2)" https://bugs.webkit.org/show_bug.cgi?id=152080 http://trac.webkit.org/changeset/193864 Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (193876 => 193877) --- trunk/Source/WebKit2/ChangeLog 2015-12-09 23:51:54 UTC (rev 193876) +++ trunk/Source/WebKit2/ChangeLog 2015-12-09 23:57:59 UTC (rev 193877) @@ -1,3 +1,18 @@ +2015-12-09 Commit Queue + +Unreviewed, rolling out r193864. +https://bugs.webkit.org/show_bug.cgi?id=152100 + +caused all inspector tests to assert in WK2 Debug (Requested +by brrian on #webkit). + +Reverted changeset: + +"Web Inspector: reproducible debug ASSERT when inspecting the +inspector (WK2)" +https://bugs.webkit.org/show_bug.cgi?id=152080 +http://trac.webkit.org/changeset/193864 + 2015-12-09 Brian Burg Web Inspector: reproducible debug ASSERT when inspecting the inspector (WK2) Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (193876 => 193877) --- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-09 23:51:54 UTC (rev 193876) +++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-09 23:57:59 UTC (rev 193877) @@ -510,6 +510,7 @@ WKPageSetPageLoaderClient(toAPI(m_inspectorPage), &loaderClient.base); WKPageSetPageContextMenuClient(toAPI(m_inspectorPage), &contextMenuClient.base); +m_inspectorPage->process().addMessageReceiver(Messages::WebInspectorProxy::messageReceiverName(), m_inspectedPage->pageID(), *this); m_inspectorPage->process().assumeReadAccessToBaseURL(WebInspectorProxy::inspectorBaseURL()); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193878] trunk
Title: [193878] trunk
Revision 193878
Author beid...@apple.com
Date 2015-12-09 16:53:11 -0800 (Wed, 09 Dec 2015)
Log Message
Modern IDB: storage/indexeddb/metadata.html fails
https://bugs.webkit.org/show_bug.cgi?id=152099
Reviewed by Alex Christensen.
Source/WebCore:
Test: storage/indexeddb/modern/abort-objectstore-info.html
And at least one existing failure now passes.
We did not properly reset object store info when version change transactions aborted.
* Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::IDBObjectStore):
(WebCore::IDBClient::IDBObjectStore::rollbackInfoForVersionChangeAbort):
* Modules/indexeddb/client/IDBObjectStoreImpl.h:
* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::abort):
LayoutTests:
* platform/mac-wk1/TestExpectations:
* storage/indexeddb/modern/abort-objectstore-info-expected.txt: Added.
* storage/indexeddb/modern/abort-objectstore-info.html: Added.
* storage/indexeddb/modern/resources/abort-objectstore-info.js: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp
Added Paths
trunk/LayoutTests/storage/indexeddb/modern/abort-objectstore-info-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/abort-objectstore-info.html
trunk/LayoutTests/storage/indexeddb/modern/resources/abort-objectstore-info.js
Diff
Modified: trunk/LayoutTests/ChangeLog (193877 => 193878)
--- trunk/LayoutTests/ChangeLog 2015-12-09 23:57:59 UTC (rev 193877)
+++ trunk/LayoutTests/ChangeLog 2015-12-10 00:53:11 UTC (rev 193878)
@@ -1,5 +1,17 @@
2015-12-09 Brady Eidson
+Modern IDB: storage/indexeddb/metadata.html fails
+https://bugs.webkit.org/show_bug.cgi?id=152099
+
+Reviewed by Alex Christensen.
+
+* platform/mac-wk1/TestExpectations:
+* storage/indexeddb/modern/abort-objectstore-info-expected.txt: Added.
+* storage/indexeddb/modern/abort-objectstore-info.html: Added.
+* storage/indexeddb/modern/resources/abort-objectstore-info.js: Added.
+
+2015-12-09 Brady Eidson
+
Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152096
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193877 => 193878)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-09 23:57:59 UTC (rev 193877)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-10 00:53:11 UTC (rev 193878)
@@ -110,7 +110,6 @@
storage/indexeddb/intversion-upgrades.html [ Failure ]
storage/indexeddb/key-type-array.html [ Failure ]
storage/indexeddb/lazy-index-types.html [ Failure ]
-storage/indexeddb/metadata.html [ Failure ]
storage/indexeddb/objectstore-autoincrement.html [ Failure ]
storage/indexeddb/objectstore-basics.html [ Failure ]
storage/indexeddb/objectstore-count.html [ Failure ]
Added: trunk/LayoutTests/storage/indexeddb/modern/abort-objectstore-info-expected.txt (0 => 193878)
--- trunk/LayoutTests/storage/indexeddb/modern/abort-objectstore-info-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/modern/abort-objectstore-info-expected.txt 2015-12-10 00:53:11 UTC (rev 193878)
@@ -0,0 +1,62 @@
+Explores the edge cases of what IDBObjectStore objects look like after a version change transaction that changed them aborts.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+dbname = "abort-objectstore-info.html"
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+connection1 = event.target.result;
+objectStore1_1 = connection1.createObjectStore('objectStore1');
+objectStore1_2 = connection1.createObjectStore('objectStore2');
+objectStore1_2.createIndex('index', 'foo');
+
+PASS connection1.version is 1
+PASS connection1.objectStoreNames.length is 2
+PASS objectStore1_1.indexNames.length is 0
+PASS objectStore1_2.indexNames.length is 1
+
+connection1.close();
+secondRequest = indexedDB.open(dbname, 2);
+secondRequest._onupgradeneeded_ = secondUpgradeNeeded;
+connection2 = event.target.result;
+objectStore2_1 = secondRequest.transaction.objectStore('objectStore1');
+objectStore2_2 = secondRequest.transaction.objectStore('objectStore2');
+objectStore2_3 = connection2.createObjectStore('objectStore3');
+
+PASS connection2.version is 2
+PASS connection2.objectStoreNames.length is 3
+PASS objectStore2_1.indexNames.length is 0
+PASS objectStore2_2.indexNames.length is 1
+PASS objectStore2_3.indexNames.length is 0
+
+objectStore2_1.createIndex('index', 'foo');
+objectStore2_2.deleteIndex('index');
+
[webkit-changes] [193879] tags/Safari-601.5.5/
Title: [193879] tags/Safari-601.5.5/ Revision 193879 Author bshaf...@apple.com Date 2015-12-09 16:59:40 -0800 (Wed, 09 Dec 2015) Log Message New tag. Added Paths tags/Safari-601.5.5/ Diff Property changes: tags/Safari-601.5.5 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193880] branches/safari-601.1.46.60-branch/Source
Title: [193880] branches/safari-601.1.46.60-branch/Source Revision 193880 Author bshaf...@apple.com Date 2015-12-09 17:08:55 -0800 (Wed, 09 Dec 2015) Log Message Versioning. Modified Paths branches/safari-601.1.46.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.1.46.60-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.1.46.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.1.46.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.1.46.60-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.1.46.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig (193879 => 193880) --- branches/safari-601.1.46.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-12-10 00:59:40 UTC (rev 193879) +++ branches/safari-601.1.46.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 46; MICRO_VERSION = 60; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-601.1.46.60-branch/Source/WebCore/Configurations/Version.xcconfig (193879 => 193880) --- branches/safari-601.1.46.60-branch/Source/WebCore/Configurations/Version.xcconfig 2015-12-10 00:59:40 UTC (rev 193879) +++ branches/safari-601.1.46.60-branch/Source/WebCore/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 46; MICRO_VERSION = 60; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-601.1.46.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (193879 => 193880) --- branches/safari-601.1.46.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-12-10 00:59:40 UTC (rev 193879) +++ branches/safari-601.1.46.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 46; MICRO_VERSION = 60; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-601.1.46.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig (193879 => 193880) --- branches/safari-601.1.46.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-12-10 00:59:40 UTC (rev 193879) +++ branches/safari-601.1.46.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 46; MICRO_VERSION = 60; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-601.1.46.60-branch/Source/WebKit2/Configurations/Version.xcconfig (193879 => 193880) --- branches/safari-601.1.46.60-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-12-10 00:59:40 UTC (rev 193879) +++ branches/safari-601.1.46.60-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 46; MICRO_VERSION = 60; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193881] branches/safari-601-branch/Source
Title: [193881] branches/safari-601-branch/Source Revision 193881 Author bshaf...@apple.com Date 2015-12-09 17:12:46 -0800 (Wed, 09 Dec 2015) Log Message Versioning. Modified Paths branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig (193880 => 193881) --- branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) +++ branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 5; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig (193880 => 193881) --- branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) +++ branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 5; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (193880 => 193881) --- branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) +++ branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) @@ -1,6 +1,6 @@ MAJOR_VERSION = 601; MINOR_VERSION = 5; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig (193880 => 193881) --- branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) +++ branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 5; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig (193880 => 193881) --- branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-12-10 01:08:55 UTC (rev 193880) +++ branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 5; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193882] branches/safari-601.4-branch/Source
Title: [193882] branches/safari-601.4-branch/Source Revision 193882 Author bshaf...@apple.com Date 2015-12-09 17:18:08 -0800 (Wed, 09 Dec 2015) Log Message Versioning. Modified Paths branches/safari-601.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.4-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.4-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (193881 => 193882) --- branches/safari-601.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) +++ branches/safari-601.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-12-10 01:18:08 UTC (rev 193882) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 4; -TINY_VERSION = 2; +TINY_VERSION = 3; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.4-branch/Source/WebCore/Configurations/Version.xcconfig (193881 => 193882) --- branches/safari-601.4-branch/Source/WebCore/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) +++ branches/safari-601.4-branch/Source/WebCore/Configurations/Version.xcconfig 2015-12-10 01:18:08 UTC (rev 193882) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 4; -TINY_VERSION = 2; +TINY_VERSION = 3; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (193881 => 193882) --- branches/safari-601.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) +++ branches/safari-601.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-12-10 01:18:08 UTC (rev 193882) @@ -1,6 +1,6 @@ MAJOR_VERSION = 601; MINOR_VERSION = 4; -TINY_VERSION = 2; +TINY_VERSION = 3; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig (193881 => 193882) --- branches/safari-601.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) +++ branches/safari-601.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-12-10 01:18:08 UTC (rev 193882) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 4; -TINY_VERSION = 2; +TINY_VERSION = 3; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.4-branch/Source/WebKit2/Configurations/Version.xcconfig (193881 => 193882) --- branches/safari-601.4-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-12-10 01:12:46 UTC (rev 193881) +++ branches/safari-601.4-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-12-10 01:18:08 UTC (rev 193882) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 4; -TINY_VERSION = 2; +TINY_VERSION = 3; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193883] trunk/Source/WebKit2
Title: [193883] trunk/Source/WebKit2
Revision 193883
Author dba...@webkit.org
Date 2015-12-09 18:50:31 -0800 (Wed, 09 Dec 2015)
Log Message
[iOS] Bail out if the page proxy is invalid when WebPageProxy::processWillBecome{Foreground, Suspended}() are called
https://bugs.webkit.org/show_bug.cgi?id=151877
Reviewed by Darin Adler.
We cannot assume that a WebPageProxy is in a valid state when WebPageProxy::processWillBecome{Foreground, Suspended}()
are called because these callbacks may occur after the web process crashed and before a
WebPageProxy attaches to a new web process (and hence is considered in a valid state).
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processWillBecomeSuspended): Early return if the page proxy is invalid.
(WebKit::WebPageProxy::processWillBecomeForeground): Ditto.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (193882 => 193883)
--- trunk/Source/WebKit2/ChangeLog 2015-12-10 01:18:08 UTC (rev 193882)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-10 02:50:31 UTC (rev 193883)
@@ -1,3 +1,18 @@
+2015-12-09 Daniel Bates
+
+[iOS] Bail out if the page proxy is invalid when WebPageProxy::processWillBecome{Foreground, Suspended}() are called
+https://bugs.webkit.org/show_bug.cgi?id=151877
+
+Reviewed by Darin Adler.
+
+We cannot assume that a WebPageProxy is in a valid state when WebPageProxy::processWillBecome{Foreground, Suspended}()
+are called because these callbacks may occur after the web process crashed and before a
+WebPageProxy attaches to a new web process (and hence is considered in a valid state).
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::processWillBecomeSuspended): Early return if the page proxy is invalid.
+(WebKit::WebPageProxy::processWillBecomeForeground): Ditto.
+
2015-12-09 Commit Queue
Unreviewed, rolling out r193864.
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (193882 => 193883)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-12-10 01:18:08 UTC (rev 193882)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-12-10 02:50:31 UTC (rev 193883)
@@ -4902,7 +4902,8 @@
#if PLATFORM(IOS)
void WebPageProxy::processWillBecomeSuspended()
{
-ASSERT(m_isValid);
+if (!isValid())
+return;
m_hasNetworkRequestsOnSuspended = m_pageLoadState.networkRequestsInProgress();
if (m_hasNetworkRequestsOnSuspended)
@@ -4911,7 +4912,8 @@
void WebPageProxy::processWillBecomeForeground()
{
-ASSERT(m_isValid);
+if (!isValid())
+return;
if (m_hasNetworkRequestsOnSuspended) {
setNetworkRequestsInProgress(true);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193884] trunk/Source/WebCore
Title: [193884] trunk/Source/WebCore
Revision 193884
Author dba...@webkit.org
Date 2015-12-09 18:51:11 -0800 (Wed, 09 Dec 2015)
Log Message
Unify iOS Frame::setTimersPaused() logic and Frame::{suspend, resume}ActiveDOMObjectsAndAnimations()
https://bugs.webkit.org/show_bug.cgi?id=152006
Reviewed by Simon Fraser.
Currently we have almost identical logic to suspend and resume a web page for iOS and non-iOS ports.
We should unify this logic instead of duplicating it.
* dom/ActiveDOMObject.h: Remove iOS-specific enumeration DocumentWillBePaused and standardize on
enumerator PageWillBeSuspended.
* dom/Document.cpp:
(WebCore::Document::didBecomeCurrentDocumentInFrame): Unify iOS and non-iOS-specific code.
(WebCore::Document::suspendScheduledTasks): Ignore subsequent calls to this function so long as the reason for
the first invocation was ActiveDOMObject::PageWillBeSuspended. Such a subsequent call may occur as part of
handling a scroll or zoom gesture.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Ignore subsequent calls to this function
so long as the reason for the first invocation was ActiveDOMObject::PageWillBeSuspended. Such a subsequent
call may occur as part of the process of a page being added to the page cache.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend): Remove case for ActiveDOMObject::DocumentWillBePaused as this
enumerator is being removed.
* page/DOMTimer.cpp:
(WebCore::DOMTimer::install): Write logic that used Frame::timersPaused() terms of
ScriptExecutionContext::activeDOMObjectsAreSuspended() as we are removing Frame::timersPaused().
(WebCore::DOMTimer::fired): Remove iOS-specific assertion with respect to Frame::timersPaused().
This function already asserts the equivalent condition that ScriptExecutionContext::activeDOMObjectsAreSuspended()
evaluates to false. Clean up iOS-specific code that depends on the ScriptExecutionContext being a
Document object by taking advantage of the fact that this assumption is true when shouldBeginObservingChanges
evaluates to true.
* page/Frame.cpp:
(WebCore::Frame::Frame): Remove instance variable m_timersPausedCount and unify the iOS and non-iOS logic.
(WebCore::Frame::suspendActiveDOMObjectsAndAnimations): Standardize on the iOS logic for suspending
DOM objects and animations because it is more comprehensive on what it suspends and works with the deferred
loading machinery (Page::setDefersLoading() - see remarks in Frame::resumeActiveDOMObjectsAndAnimations() for
more details). Specifically, make use of Frame::clearTimers() to suspend non-scripted animations (i.e. non-requestAnimationFrame()
animations), auto-scroll timer, and pending relayouts. And use Document::suspendScheduledTasks() to suspend
all other tasks, including WebSQL database callbacks, active DOM objects, scripted animations and execution of
[webkit-changes] [193885] trunk
Title: [193885] trunk
Revision 193885
Author dba...@webkit.org
Date 2015-12-09 18:53:12 -0800 (Wed, 09 Dec 2015)
Log Message
[iOS] Suspend and resume device motion and device orientation updates when page is hidden and visible, respectively
https://bugs.webkit.org/show_bug.cgi?id=151840
Reviewed by Simon Fraser.
.:
Add a manual test that can be used to verify that we suspend dispatching device motion and
device orientation events when the page is hidden.
* ManualTests/ios/resources/suspend-orientation-and-motion-events-when-page-becomes-hidden.js: Added.
(resetTest):
(checkEvent):
(handleVisibilityChange):
* ManualTests/ios/suspend-orientation-and-motion-events-when-page-becomes-hidden.html: Added.
Source/WebCore:
* dom/Document.cpp:
(WebCore::Document::suspendDeviceMotionAndOrientationUpdates): Added.
(WebCore::Document::resumeDeviceMotionAndOrientationUpdates): Added.
(WebCore::Document::platformSuspendOrStopActiveDOMObjects): Moved logic to suspend device motion and
orientation updates from here to Document::suspendDeviceMotionAndOrientationUpdates().
(WebCore::Document::suspendActiveDOMObjects): Modified to call Document::suspendDeviceMotionAndOrientationUpdates().
(WebCore::Document::resumeActiveDOMObjects): Modified to call Document::resumeDeviceMotionAndOrientationUpdates().
* dom/Document.h:
* page/Page.cpp:
(WebCore::Page::setIsVisibleInternal): Suspend device motion and orientation updates when the page is hidden and
resume updates when the page is visible.
(WebCore::Page::suspendDeviceMotionAndOrientationUpdates): Added.
(WebCore::Page::resumeDeviceMotionAndOrientationUpdates): Added.
* page/Page.h:
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
Added Paths
trunk/ManualTests/ios/resources/
trunk/ManualTests/ios/resources/suspend-orientation-and-motion-events-when-page-becomes-hidden.js
trunk/ManualTests/ios/suspend-orientation-and-motion-events-when-page-becomes-hidden.html
Diff
Modified: trunk/ChangeLog (193884 => 193885)
--- trunk/ChangeLog 2015-12-10 02:51:11 UTC (rev 193884)
+++ trunk/ChangeLog 2015-12-10 02:53:12 UTC (rev 193885)
@@ -1,3 +1,20 @@
+2015-12-09 Daniel Bates
+
+[iOS] Suspend and resume device motion and device orientation updates when page is hidden and visible, respectively
+https://bugs.webkit.org/show_bug.cgi?id=151840
+
+
+Reviewed by Simon Fraser.
+
+Add a manual test that can be used to verify that we suspend dispatching device motion and
+device orientation events when the page is hidden.
+
+* ManualTests/ios/resources/suspend-orientation-and-motion-events-when-page-becomes-hidden.js: Added.
+(resetTest):
+(checkEvent):
+(handleVisibilityChange):
+* ManualTests/ios/suspend-orientation-and-motion-events-when-page-becomes-hidden.html: Added.
+
2015-12-07 Alex Christensen
Fix internal Windows build
Added: trunk/ManualTests/ios/resources/suspend-orientation-and-motion-events-when-page-becomes-hidden.js (0 => 193885)
--- trunk/ManualTests/ios/resources/suspend-orientation-and-motion-events-when-page-becomes-hidden.js (rev 0)
+++ trunk/ManualTests/ios/resources/suspend-orientation-and-motion-events-when-page-becomes-hidden.js 2015-12-10 02:53:12 UTC (rev 193885)
@@ -0,0 +1,41 @@
+var eventFrequencyTable;
+
+function resetTest()
+{
+eventFrequencyTable = {};
+}
+
+function log(message)
+{
+document.getElementById("console").appendChild(document.createTextNode(message + "\n"));
+}
+
+function checkEvent(event)
+{
+if (document.visibilityState === "visible")
+return;
+var type = event.type;
+if (!eventFrequencyTable[type])
+eventFrequencyTable[type] = 0;
+++eventFrequencyTable[type];
+}
+
+function handleVisibilityChange()
+{
+if (document.visibilityState === "hidden")
+return;
+var receivedEventsMessageParts = [];
+for (var type in eventFrequencyTable)
+receivedEventsMessageParts.push(type + " (\u00D7 " + eventFrequencyTable[type] + ")");
+if (receivedEventsMessageParts.length)
+log("Expected to receive no events when the page was hidden, but received: " + receivedEventsMessageParts.join(", ") + ".");
+else
+log("Received no events when the page was hidden.");
+resetTest();
+}
+
+resetTest();
+
+window.addEventListener("devicemotion", checkEvent, false);
+window.addEventListener("deviceorientation", checkEvent, false);
+document.addEventListener("visibilitychange", handleVisibilityChange, false);
Added: trunk/ManualTests/ios/suspend-orientation-and-motion-events-when-page-becomes-hidden.html (0 => 193885)
--- trunk/ManualTests/ios/suspend-orientation-and-motion-events-when-page-becomes-hidden.html (rev 0)
+++ trunk/ManualTests/ios/suspend-orienta
[webkit-changes] [193886] branches/safari-601.1.46-branch/Source/WebCore
Title: [193886] branches/safari-601.1.46-branch/Source/WebCore Revision 193886 Author simon.fra...@apple.com Date 2015-12-09 19:16:43 -0800 (Wed, 09 Dec 2015) Log Message Merge r190910. rdar://problem/23432368 Modified Paths branches/safari-601.1.46-branch/Source/WebCore/ChangeLog branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/BitmapImage.cpp branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/BitmapImage.h branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/GeneratedImage.h branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/GradientImage.cpp branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/GradientImage.h branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/GraphicsContext.cpp branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/GraphicsContext.h branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/Image.cpp branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/Image.h branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/ImageBuffer.h branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/NamedImageGeneratedImage.cpp branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/NamedImageGeneratedImage.h branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cg/ImageCG.cpp branches/safari-601.1.46-branch/Source/WebCore/rendering/RenderBoxModelObject.cpp branches/safari-601.1.46-branch/Source/WebCore/svg/graphics/SVGImage.cpp branches/safari-601.1.46-branch/Source/WebCore/svg/graphics/SVGImage.h branches/safari-601.1.46-branch/Source/WebCore/svg/graphics/SVGImageForContainer.cpp branches/safari-601.1.46-branch/Source/WebCore/svg/graphics/SVGImageForContainer.h Diff Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (193885 => 193886) --- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-12-10 02:53:12 UTC (rev 193885) +++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-12-10 03:16:43 UTC (rev 193886) @@ -1,3 +1,56 @@ +2015-12-09 Simon Fraser + +Merge r190910. rdar://problem/23432368 + +2015-10-12 Simon Fraser + +Remove Image::spaceSize() and ImageBuffer::spaceSize() +https://bugs.webkit.org/show_bug.cgi?id=150064 + +Reviewed by Tim Horton. + +Image spacing when tiled should not be a property of the image; but a description +of how it's drawn, like tile size. So remove spacing from Image and ImageBuffer, +and pass it in as an argument. + +* platform/graphics/BitmapImage.cpp: +(WebCore::BitmapImage::drawPattern): +* platform/graphics/BitmapImage.h: +* platform/graphics/CrossfadeGeneratedImage.cpp: +(WebCore::CrossfadeGeneratedImage::drawPattern): +* platform/graphics/CrossfadeGeneratedImage.h: +* platform/graphics/GeneratedImage.h: +* platform/graphics/GradientImage.cpp: +(WebCore::GradientImage::drawPattern): +* platform/graphics/GradientImage.h: +* platform/graphics/GraphicsContext.cpp: +(WebCore::GraphicsContext::drawTiledImage): +* platform/graphics/GraphicsContext.h: +* platform/graphics/Image.cpp: +(WebCore::Image::drawTiled): +* platform/graphics/Image.h: +(WebCore::Image::spaceSize): Deleted. +(WebCore::Image::setSpaceSize): Deleted. +* platform/graphics/ImageBuffer.h: +(WebCore::ImageBuffer::spaceSize): Deleted. +(WebCore::ImageBuffer::setSpaceSize): Deleted. +* platform/graphics/NamedImageGeneratedImage.cpp: +(WebCore::NamedImageGeneratedImage::drawPattern): +* platform/graphics/NamedImageGeneratedImage.h: +* platform/graphics/cg/ImageBufferCG.cpp: +(WebCore::ImageBuffer::copyImage): +(WebCore::ImageBuffer::drawPattern): +* platform/graphics/cg/ImageCG.cpp: +(WebCore::Image::drawPattern): +* rendering/RenderBoxModelObject.cpp: +(WebCore::RenderBoxModelObject::paintFillLayerExtended): +* svg/graphics/SVGImage.cpp: +(WebCore::SVGImage::drawPatternForContainer): +* svg/graphics/SVGImage.h: +* svg/graphics/SVGImageForContainer.cpp: +(WebCore::SVGImageForContainer::drawPattern): +* svg/graphics/SVGImageForContainer.h: + 2015-12-09 Matthew Hanson Merge r192639. rdar://problem/23814338 Modified: branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/BitmapImage.cpp (193885 => 19
[webkit-changes] [193888] branches/safari-601.1.46-branch
Title: [193888] branches/safari-601.1.46-branch
Revision 193888
Author simon.fra...@apple.com
Date 2015-12-09 19:16:48 -0800 (Wed, 09 Dec 2015)
Log Message
Merge r191590. rdar://problem/23432368
Modified Paths
branches/safari-601.1.46-branch/LayoutTests/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/Image.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cg/ImageCG.cpp
Added Paths
branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-round-expected.html
branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-round.html
branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-space-expected.html
branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-space.html
branches/safari-601.1.46-branch/LayoutTests/fast/borders/resources/big-border-image-lines.png
branches/safari-601.1.46-branch/LayoutTests/fast/borders/resources/big-border-image.png
Diff
Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (193887 => 193888)
--- branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-12-10 03:16:45 UTC (rev 193887)
+++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-12-10 03:16:48 UTC (rev 193888)
@@ -1,3 +1,23 @@
+2015-12-09 Simon Fraser
+
+Merge r191590. rdar://problem/23432368
+
+2015-10-26 Simon Fraser
+
+Implement 'round' and 'space' values for border-image
+https://bugs.webkit.org/show_bug.cgi?id=14185
+
+Reviewed by Tim Horton.
+
+Ref tests that clip, leaving relevant parts of the images.
+
+* fast/borders/border-image-round-expected.html: Added.
+* fast/borders/border-image-round.html: Added.
+* fast/borders/border-image-space-expected.html: Added.
+* fast/borders/border-image-space.html: Added.
+* fast/borders/resources/big-border-image-lines.png: Added.
+* fast/borders/resources/big-border-image.png: Added.
+
2015-12-09 Matthew Hanson
Merge r192639. rdar://problem/23814338
Added: branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-round-expected.html (0 => 193888)
--- branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-round-expected.html (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-round-expected.html 2015-12-10 03:16:48 UTC (rev 193888)
@@ -0,0 +1,43 @@
+
+
+
+div {
+border-width: 50px 0 0 0;
+margin: 10px;
+width: 50px;
+height: 50px;
+box-sizing: border-box;
+background-color: gray;
+border-image: url('resources/big-border-image-lines.png') 30 70 60 40;
+border-image-repeat: stretch;
+}
+
+.one {
+width: 159px;
+}
+
+.two {
+width: 239px;
+}
+
+.three {
+width: 319px;
+}
+
+.vertical {
+border-width: 0 50px 0 0;
+width: 50px;
+display: inline-block;
+}
+
+
+
+
+
+
+
+
+
+
+
+
Added: branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-round.html (0 => 193888)
--- branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-round.html (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-round.html 2015-12-10 03:16:48 UTC (rev 193888)
@@ -0,0 +1,44 @@
+
+
+
+div {
+border-width: 50px 0 0 0;
+margin: 10px;
+width: 50px;
+height: 50px;
+box-sizing: border-box;
+background-color: gray;
+border-image: url('resources/big-border-image-lines.png') 30 70 60 40;
+border-image-repeat: round;
+}
+
+.one {
+width: 159px;
+}
+
+.two {
+width: 239px;
+}
+
+.three {
+width: 319px;
+}
+
+.vertical {
+border-width: 0 50px 0 0;
+width: 50px;
+display: inline-block;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
Added: branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-space-expected.html (0 => 193888)
--- branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-space-expected.html (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/fast/borders/border-image-space-expected.html 2015-12-10 03:16:48 UTC (rev 193888)
@@ -0,0 +1,41 @@
+
+
+
+div {
+border-width: 50px 0 0 0;
+margin: 10px;
+width: 50px;
+height: 50px;
+box-sizing: border-box;
+background-color: gray;
+}
[webkit-changes] [193887] branches/safari-601.1.46-branch/Source/WebCore
Title: [193887] branches/safari-601.1.46-branch/Source/WebCore
Revision 193887
Author simon.fra...@apple.com
Date 2015-12-09 19:16:45 -0800 (Wed, 09 Dec 2015)
Log Message
Merge r190914. rdar://problem/23432368
Modified Paths
branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp
Diff
Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (193886 => 193887)
--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-12-10 03:16:43 UTC (rev 193886)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-12-10 03:16:45 UTC (rev 193887)
@@ -1,5 +1,18 @@
2015-12-09 Simon Fraser
+Merge r190914. rdar://problem/23432368
+
+2015-10-12 Simon Fraser
+
+Speculative Cairo build fixes after r190910.
+
+* platform/graphics/cairo/ImageBufferCairo.cpp:
+(WebCore::ImageBuffer::drawPattern):
+* platform/graphics/cairo/ImageCairo.cpp:
+(WebCore::Image::drawPattern):
+
+2015-12-09 Simon Fraser
+
Merge r190910. rdar://problem/23432368
2015-10-12 Simon Fraser
Modified: branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp (193886 => 193887)
--- branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp 2015-12-10 03:16:43 UTC (rev 193886)
+++ branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp 2015-12-10 03:16:45 UTC (rev 193887)
@@ -159,10 +159,10 @@
}
void ImageBuffer::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransform,
-const FloatPoint& phase, ColorSpace styleColorSpace, CompositeOperator op, const FloatRect& destRect, BlendMode)
+const FloatPoint& phase, const FloatSize& spacing, ColorSpace styleColorSpace, CompositeOperator op, const FloatRect& destRect, BlendMode)
{
if (RefPtr image = copyImage(DontCopyBackingStore))
-image->drawPattern(context, srcRect, patternTransform, phase, styleColorSpace, op, destRect);
+image->drawPattern(context, srcRect, patternTransform, phase, spacing, styleColorSpace, op, destRect);
}
void ImageBuffer::platformTransformColorSpace(const Vector& lookUpTable)
Modified: branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp (193886 => 193887)
--- branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp 2015-12-10 03:16:43 UTC (rev 193886)
+++ branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp 2015-12-10 03:16:45 UTC (rev 193887)
@@ -42,7 +42,7 @@
namespace WebCore {
void Image::drawPattern(GraphicsContext* context, const FloatRect& tileRect, const AffineTransform& patternTransform,
-const FloatPoint& phase, ColorSpace, CompositeOperator op, const FloatRect& destRect, BlendMode)
+const FloatPoint& phase, const FloatSize&, ColorSpace, CompositeOperator op, const FloatRect& destRect, BlendMode)
{
RefPtr surface = nativeImageForCurrentFrame();
if (!surface) // If it's too early we won't have an image yet.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193889] trunk/Websites/bugs.webkit.org
Title: [193889] trunk/Websites/bugs.webkit.org
Revision 193889
Author dba...@webkit.org
Date 2015-12-09 19:42:46 -0800 (Wed, 09 Dec 2015)
Log Message
REGRESSION: code-review-tests.html fails with error "Received an error at line 214"
https://bugs.webkit.org/show_bug.cgi?id=152103
Reviewed by Darin Adler.
Fixes an issue where opening the file code-review-test.html in Safari shows the error message
"FAIL: Received an error at line 214" and in the console there is a _javascript_ TypeError:
undefined is not an object (evaluating '$('.overallComments textarea').val().trim')
Notice that test testReaddDiscardedCommentWithPreviousComment() is the only test that appends
the toolbar, which inserts the overall comments textarea. The test testSaveCommentsWithMissingLineIds()
assumes that the own properties of the window object are enumerated in the same order as they
were defined in the file code-review-test.html such that the test testReaddDiscardedCommentWithPreviousComment()
is executed before test testSaveCommentsWithMissingLineIds(). The behavior of _javascript_Core with
respect to the enumeration order of properties on the window object have changed since the
test testSaveCommentsWithMissingLineIds() was written such that the order of the own properties
on the window object do not reflect the order in which they were defined in the file. We should
append the toolbar before running the tests and explicitly execute the tests in chosen order so
as to be able to reason of the test results regardless of the enumeration ordering of the
properties in the DOM window object.
Also, removed duplicate 'd' in the name of function "testReaddDiscardedCommentWithPreviousComment"
such that it reads "testReadDiscardedCommentWithPreviousComment".
* code-review-test.html:
Modified Paths
trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/code-review-test.html
Diff
Modified: trunk/Websites/bugs.webkit.org/ChangeLog (193888 => 193889)
--- trunk/Websites/bugs.webkit.org/ChangeLog 2015-12-10 03:16:48 UTC (rev 193888)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2015-12-10 03:42:46 UTC (rev 193889)
@@ -1,3 +1,31 @@
+2015-12-09 Daniel Bates
+
+REGRESSION: code-review-tests.html fails with error "Received an error at line 214"
+https://bugs.webkit.org/show_bug.cgi?id=152103
+
+Reviewed by Darin Adler.
+
+Fixes an issue where opening the file code-review-test.html in Safari shows the error message
+"FAIL: Received an error at line 214" and in the console there is a _javascript_ TypeError:
+undefined is not an object (evaluating '$('.overallComments textarea').val().trim')
+
+Notice that test testReaddDiscardedCommentWithPreviousComment() is the only test that appends
+the toolbar, which inserts the overall comments textarea. The test testSaveCommentsWithMissingLineIds()
+assumes that the own properties of the window object are enumerated in the same order as they
+were defined in the file code-review-test.html such that the test testReaddDiscardedCommentWithPreviousComment()
+is executed before test testSaveCommentsWithMissingLineIds(). The behavior of _javascript_Core with
+respect to the enumeration order of properties on the window object have changed since the
+test testSaveCommentsWithMissingLineIds() was written such that the order of the own properties
+on the window object do not reflect the order in which they were defined in the file. We should
+append the toolbar before running the tests and explicitly execute the tests in chosen order so
+as to be able to reason of the test results regardless of the enumeration ordering of the
+properties in the DOM window object.
+
+Also, removed duplicate 'd' in the name of function "testReaddDiscardedCommentWithPreviousComment"
+such that it reads "testReadDiscardedCommentWithPreviousComment".
+
+* code-review-test.html:
+
2015-11-17 Lucas Forschler
bugs.webkit.org is running with changes that are not checked in.
Modified: trunk/Websites/bugs.webkit.org/code-review-test.html (193888 => 193889)
--- trunk/Websites/bugs.webkit.org/code-review-test.html 2015-12-10 03:16:48 UTC (rev 193888)
+++ trunk/Websites/bugs.webkit.org/code-review-test.html 2015-12-10 03:42:46 UTC (rev 193889)
@@ -218,7 +218,7 @@
handler.call(this);
}
-function testReaddDiscardedCommentWithPreviousComment() {
+function testReadDiscardedCommentWithPreviousComment() {
document.getElementById('diff-content').innerHTML =
'' +
'@@ -247,7 +247,6 @@
eraseDraftComments();
crawlDiff();
- appendToolbar();
var line = document.getElementById('line0');
var author = "o...@chromium.org";
@@ -456,9 +455,17 @@
}
-for (var property in window) {
- if (property.indexOf('test') == 0) {
-window[property]();
- }
-}
+var tests_to_run = [
+window.testTracLinks,
+
[webkit-changes] [193890] trunk/Source
Title: [193890] trunk/Source
Revision 193890
Author fpi...@apple.com
Date 2015-12-09 19:50:07 -0800 (Wed, 09 Dec 2015)
Log Message
FTL B3 should have basic GetById support
https://bugs.webkit.org/show_bug.cgi?id=152035
Reviewed by Saam Barati.
Source/_javascript_Core:
Adds basic GetById support. This was so easy to do. Unlike the LLVM code for this, the B3 code is
entirely self-contained within the getById() method in LowerDFG.
I discovered that we weren't folding Check(NotEqual(x, 0)) to Check(x). This was preventing us
from generating good code for Check(NotEqual(BitAnd(x, tagMask), 0)), since the BitAnd was
concealed. This was an easy strength reduction rule to add.
Finally, I found it easier to say append(value, rep) than append(ConstrainedValue(value, rep)), so
I added that API. The old ConstrainedValue form is still super useful in other places, like
compileCallOrConstruct(), where the two-argument form would be awkward. It's great to have both
APIs to pick from.
* b3/B3ReduceStrength.cpp:
* b3/B3StackmapValue.cpp:
(JSC::B3::StackmapValue::~StackmapValue):
(JSC::B3::StackmapValue::append):
* b3/B3StackmapValue.h:
* dfg/DFGCommon.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
Source/WTF:
When dealing with shared task lambdas, you often want to force a value to be allocated so that it
has reference semantics, but you still want the lambda to execute OK when we pop stack. In PL we
usually call this a "box". This is easy to do if the value that happened to be stack-allocated
is also RefCounted, but that's rare, since stack-allocated values often have copy semantics. So,
I've added a Box type to WTF. Behind the scenes, it allocates your object with fast malloc inside
a ThreadSAfeRefCounted. When you pass Box, you're passing the reference. This makes it a lot
easier to work with by-reference capture.
* WTF.xcodeproj/project.pbxproj:
* wtf/Box.h: Added.
(WTF::Box::Box):
(WTF::Box::create):
(WTF::Box::get):
(WTF::Box::operator*):
(WTF::Box::operator->):
(WTF::Box::operator bool):
(WTF::Box::Data::Data):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp
trunk/Source/_javascript_Core/b3/B3StackmapValue.cpp
trunk/Source/_javascript_Core/b3/B3StackmapValue.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WTF/wtf/Box.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (193889 => 193890)
--- trunk/Source/_javascript_Core/ChangeLog 2015-12-10 03:42:46 UTC (rev 193889)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-12-10 03:50:07 UTC (rev 193890)
@@ -1,3 +1,31 @@
+2015-12-08 Filip Pizlo
+
+FTL B3 should have basic GetById support
+https://bugs.webkit.org/show_bug.cgi?id=152035
+
+Reviewed by Saam Barati.
+
+Adds basic GetById support. This was so easy to do. Unlike the LLVM code for this, the B3 code is
+entirely self-contained within the getById() method in LowerDFG.
+
+I discovered that we weren't folding Check(NotEqual(x, 0)) to Check(x). This was preventing us
+from generating good code for Check(NotEqual(BitAnd(x, tagMask), 0)), since the BitAnd was
+concealed. This was an easy strength reduction rule to add.
+
+Finally, I found it easier to say append(value, rep) than append(ConstrainedValue(value, rep)), so
+I added that API. The old ConstrainedValue form is still super useful in other places, like
+compileCallOrConstruct(), where the two-argument form would be awkward. It's great to have both
+APIs to pick from.
+
+* b3/B3ReduceStrength.cpp:
+* b3/B3StackmapValue.cpp:
+(JSC::B3::StackmapValue::~StackmapValue):
+(JSC::B3::StackmapValue::append):
+* b3/B3StackmapValue.h:
+* dfg/DFGCommon.h:
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::getById):
+
2015-12-09 Saam barati
Update generators' features.json to indicate that we have a spec compliant implementation
Modified: trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp (193889 => 193890)
--- trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp 2015-12-10 03:42:46 UTC (rev 193889)
+++ trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp 2015-12-10 03:50:07 UTC (rev 193890)
@@ -861,6 +861,12 @@
m_changed = true;
break;
}
+
+if (m_value->child(0)->opcode() == NotEqual && m_value->child(0)->child(1)->isInt(0)) {
+m_value->child(0) = m_value->child(0)->child(0);
+m_changed = true;
+break;
+}
break;
case Branch: {
Modified: trunk/Source/_javascript_Core/b3/B3StackmapValue.cpp (193889 => 193890)
--- trunk/Source/_javascript_Core/b3/B3StackmapValue.cpp 2015-12-10 03:42:46 UTC (rev 193889)
+++ trunk/S
[webkit-changes] [193891] trunk/Source/WebCore
Title: [193891] trunk/Source/WebCore
Revision 193891
Author za...@apple.com
Date 2015-12-09 20:59:56 -0800 (Wed, 09 Dec 2015)
Log Message
TextPainter: Make before and after selection painting more explicit.
https://bugs.webkit.org/show_bug.cgi?id=152104
Reviewed by Myles C. Maxfield.
Instead of swapping start end end positions and expecting TextPainter::drawTextOrEmphasisMarks()
to recognize it, we call painting with 0 - startPosition and endPosition - length.
No change in functionality.
* rendering/TextPainter.cpp:
(WebCore::TextPainter::drawTextOrEmphasisMarks):
(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
(WebCore::TextPainter::paintText):
(WebCore::TextPainter::paintEmphasisMarksIfNeeded): Deleted.
(WebCore::TextPainter::paintTextWithStyle): Deleted.
* rendering/TextPainter.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/TextPainter.cpp
trunk/Source/WebCore/rendering/TextPainter.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (193890 => 193891)
--- trunk/Source/WebCore/ChangeLog 2015-12-10 03:50:07 UTC (rev 193890)
+++ trunk/Source/WebCore/ChangeLog 2015-12-10 04:59:56 UTC (rev 193891)
@@ -1,3 +1,23 @@
+2015-12-09 Zalan Bujtas
+
+TextPainter: Make before and after selection painting more explicit.
+https://bugs.webkit.org/show_bug.cgi?id=152104
+
+Reviewed by Myles C. Maxfield.
+
+Instead of swapping start end end positions and expecting TextPainter::drawTextOrEmphasisMarks()
+to recognize it, we call painting with 0 - startPosition and endPosition - length.
+
+No change in functionality.
+
+* rendering/TextPainter.cpp:
+(WebCore::TextPainter::drawTextOrEmphasisMarks):
+(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
+(WebCore::TextPainter::paintText):
+(WebCore::TextPainter::paintEmphasisMarksIfNeeded): Deleted.
+(WebCore::TextPainter::paintTextWithStyle): Deleted.
+* rendering/TextPainter.h:
+
2015-12-09 Daniel Bates
[iOS] Suspend and resume device motion and device orientation updates when page is hidden and visible, respectively
Modified: trunk/Source/WebCore/rendering/TextPainter.cpp (193890 => 193891)
--- trunk/Source/WebCore/rendering/TextPainter.cpp 2015-12-10 03:50:07 UTC (rev 193890)
+++ trunk/Source/WebCore/rendering/TextPainter.cpp 2015-12-10 04:59:56 UTC (rev 193891)
@@ -107,23 +107,11 @@
void TextPainter::drawTextOrEmphasisMarks(const FontCascade& font, const TextRun& textRun, const AtomicString& emphasisMark,
int emphasisMarkOffset, const FloatPoint& textOrigin, int startOffset, int endOffset)
{
-auto drawText = [&](int from, int to)
-{
-if (emphasisMark.isEmpty())
-m_context.drawText(font, textRun, textOrigin, from, to);
-else
-m_context.drawEmphasisMarks(font, textRun, emphasisMark, textOrigin + IntSize(0, emphasisMarkOffset), from, to);
-};
-
-if (startOffset <= endOffset) {
-drawText(startOffset, endOffset);
-return;
-}
-
-if (endOffset > 0)
-drawText(0, endOffset);
-if (startOffset < m_length)
-drawText(startOffset, m_length);
+ASSERT(startOffset < endOffset);
+if (emphasisMark.isEmpty())
+m_context.drawText(font, textRun, textOrigin, startOffset, endOffset);
+else
+m_context.drawEmphasisMarks(font, textRun, emphasisMark, textOrigin + IntSize(0, emphasisMarkOffset), startOffset, endOffset);
}
void TextPainter::paintTextWithShadows(const ShadowData* shadow, const FontCascade& font, const TextRun& textRun, const AtomicString& emphasisMark,
@@ -153,8 +141,11 @@
}
}
-void TextPainter::paintEmphasisMarksIfNeeded(int startOffset, int endOffset, const TextPaintStyle& paintStyle, const ShadowData* shadow)
+void TextPainter::paintTextAndEmphasisMarksIfNeeded(int startOffset, int endOffset, const TextPaintStyle& paintStyle, const ShadowData* shadow)
{
+// FIXME: Truncate right-to-left text correctly.
+paintTextWithShadows(shadow, m_font, m_textRun, nullAtom, 0, startOffset, endOffset, m_textOrigin, paintStyle.strokeWidth > 0);
+
if (m_emphasisMark.isEmpty())
return;
@@ -172,29 +163,30 @@
if (m_combinedText)
m_context.concatCTM(rotation(m_boxRect, Counterclockwise));
}
-
-void TextPainter::paintTextWithStyle(const TextPaintStyle& paintStyle, int startOffset, int endOffset, const ShadowData* shadow)
-{
-GraphicsContextStateSaver stateSaver(m_context, paintStyle.strokeWidth > 0);
-updateGraphicsContext(m_context, paintStyle);
-// FIXME: Truncate right-to-left text correctly.
-paintTextWithShadows(shadow, m_font, m_textRun, nullAtom, 0, startOffset, endOffset, m_textOrigin, paintStyle.strokeWidth > 0);
-paintEmphasisMarksIfNeeded(startOffset, endOffset, paintStyle, shadow);
-}
void TextPainter::paintText()
{
if (!m_paintSelectedTextOnly) {
// For stroked painting, we
[webkit-changes] [193892] trunk
Title: [193892] trunk Revision 193892 Author beid...@apple.com Date 2015-12-09 23:09:34 -0800 (Wed, 09 Dec 2015) Log Message Modern IDB: storage/indexeddb/objectstore-basics.html fails. https://bugs.webkit.org/show_bug.cgi?id=152101 Reviewed by Alex Christensen. Source/WebCore: No new tests (Multiple tests updated to the new error messaging cover it). * Modules/indexeddb/client/IDBObjectStoreImpl.cpp: (WebCore::IDBClient::IDBObjectStore::putOrAdd): Add plenty of detailed error messaging. LayoutTests: * platform/mac-wk1/TestExpectations: * platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt. * platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt. * platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt. * platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt. * storage/indexeddb/invalid-keys-expected.txt: * storage/indexeddb/key-type-binary-expected.txt: * storage/indexeddb/keypath-edges-expected.txt: * storage/indexeddb/mozilla/bad-keypath-expected.txt: * storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: * storage/indexeddb/objectstore-basics-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/storage/indexeddb/invalid-keys-expected.txt trunk/LayoutTests/storage/indexeddb/key-type-binary-expected.txt trunk/LayoutTests/storage/indexeddb/keypath-edges-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt trunk/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp Added Paths trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt trunk/LayoutTests/platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (193891 => 193892) --- trunk/LayoutTests/ChangeLog 2015-12-10 04:59:56 UTC (rev 193891) +++ trunk/LayoutTests/ChangeLog 2015-12-10 07:09:34 UTC (rev 193892) @@ -1,5 +1,26 @@ 2015-12-09 Brady Eidson +Modern IDB: storage/indexeddb/objectstore-basics.html fails. +https://bugs.webkit.org/show_bug.cgi?id=152101 + +Reviewed by Alex Christensen. + +* platform/mac-wk1/TestExpectations: +* platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt. +* platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt. +* platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt. +* platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt. +* storage/indexeddb/invalid-keys-expected.txt: +* storage/indexeddb/key-type-binary-expected.txt: +* storage/indexeddb/keypath-edges-expected.txt: +* storage/indexeddb/mozilla/bad-keypath-expected.txt: +* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: +* storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: +* storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: +* storage/indexeddb/objectstore-basics-expected.txt: + +2015-12-09 Brady Eidson + Modern IDB: storage/indexeddb/metadata.html fails https://bugs.webkit.org/show_bug.cgi?id=152099 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193891 => 193892) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-10 04:59:56 UTC (rev 193891) +++ trunk/LayoutTests/platform/mac-w
