[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Krinkle  changed:

   What|Removed |Added

Version|1.16|1.16.x

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Krinkle  changed:

   What|Removed |Added

Version|1.16.1  |1.16

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

--- Comment #12 from matthieu.far...@smile.public.lu 2011-01-24 13:50:13 UTC ---
Andrew, although such a statement would clarify if Wikimedia was clear or not
to make use of JSMin, it wouldn't solve everything...

In particular, it wouldn't allow the licensing scheme chosen for the derivative
and distributed work based on the latter (MediaWiki) - GNU GPL v2.

The issue would remain: such a statement unfortunately makes the code under
license non-free software.
Which is evil in itself :-)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Trevor Parscal  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #11 from Trevor Parscal  2011-01-20 
22:15:54 UTC ---
LOL - JSLint? You mean JSMin surely.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Andrew Garrett  changed:

   What|Removed |Added

 CC||agarr...@wikimedia.org

--- Comment #10 from Andrew Garrett  2011-01-20 
22:14:10 UTC ---
What we really need is a statement from Douglas Crockford, along these lines:

"I give permission for Wikimedia, its customers, partners, and minions, to use
JSLint for evil."

()

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

--- Comment #9 from Trevor Parscal  2011-01-20 22:11:23 
UTC ---
Resolved in r80656 by replacing JSMin with a new library called
JavaScriptDistiller, which is essentially an improved version of the
minification step that JavaScriptPacker uses before doing it's evil packing
magic.

Good news, it's really fast!

+---+-+--
Library  Time (sec)  Minified (bytes)  Compressed (bytes)
+---+-+--
JSMin (Original) 3.5010022127983
JSMin (MediaWiki)1.7110599029087
JavaScriptPacker 1.3654886 26327
JSMinPlus5.4798382 27636
+---+-+--
JavaScriptDistiller  0.8711017829987
+---+-+--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

--- Comment #8 from Trevor Parscal  2011-01-19 00:32:23 
UTC ---
As Chad mentioned, JSMin is now in includes/libs/JSMin.php - ResourceLoader
uses it.

We can either request special permission from the author, or use something else
entirely.


I did some benchmarking with JSMin, Tim's modified JSMin, and some GPL friendly
alternatives. Tests were run on the development version of jQuery 1.4.4.

--+---+-+--
LibraryTime (sec)  Minified (bytes)  Compressed (bytes)
--+---+-+--
JSMin (Original)   3.5010022127983
JSMin (MediaWiki)  1.7110599029087
JavaScriptPacker   1.3654886 26327
JSMinPlus  5.4798382 27636
--+---+-+--

As you can see, Tim's changes to JSMin got the cost of running it down a bit.
JavaScriptPacker is still the fastest, but it does some really scary things to
try and get the minified size down, which are pretty much done in vein since
the gzipped version is so similar in size as all the other minifiers which
output much more sane and reliable code. JSMinPlus is really expensive to run,
but I'm sure we could optimize it - at least it's a GPL compatible starting
point.

The alternative is of course, we write something of our own. I ended up doing
just that for CSS minification since we wanted to do some really particular
things that other libraries did not do or did not do well enough for our needs,
such as data URI embedding and URL remapping. But the most compelling reason
was that all the CSS minifiers out there were way too complex, and caused a lot
of problems when CSS hacks were introduced. Furthermore, the difference between
running the text through about 5 regular expression replacements and parsing
the CSS into a structure and spitting it back out was negligable. This may or
may not prove to be the case with JavaScript, but it's something to consider.

If we could have something incredibly simple and 80% effective and support
hooking into things like Google ClosureCompiler or the JSMin PHP extension on
our own cluster, we will be in the clear license-wise and still be able to get
the final 20% in our own production environments.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Rob Lanphier  changed:

   What|Removed |Added

 CC||ro...@wikimedia.org
 Blocks|26611   |

--- Comment #7 from Rob Lanphier  2011-01-18 19:43:26 UTC 
---
Which maintenance script(s) use this component?  Reedy marked this as a blocker
for bug 26611, but I disagree that this should block our deployment to WMF
sites.  We *may* want to block 1.17 tarball release for this.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Reedy  changed:

   What|Removed |Added

 Blocks||26611

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

LordAndrew  changed:

   What|Removed |Added

 CC||reachouttothetruth@hotmail.
   ||com

--- Comment #6 from LordAndrew  2011-01-18 
15:59:33 UTC ---
The Free Software Foundation also says this license is non-free and therefore
incompatible with the GPL. See
http://www.gnu.org/licenses/license-list.html#JSON

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

--- Comment #5 from Chad H.  2011-01-18 14:14:40 UTC 
---
My mistake, I was confusing it with removing a Makefile to run minify.php on a
series of JS files (see r79641).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

--- Comment #4 from matthieu.far...@smile.public.lu 2011-01-18 14:08:25 UTC ---
I just checked in the nightly build tarball, MediaWiki 1.17alpha, and
minify.php is still in the maintenance directory and JSMin.php is still used by
this component.

>From where has it been removed?

Cheers,

M.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Ashar Voultoiz  changed:

   What|Removed |Added

   Keywords||upstream
 CC||has...@free.fr
  Component|General/Unknown |Maintenance scripts

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Chad H.  changed:

   What|Removed |Added

  Component|Maintenance scripts |General/Unknown

--- Comment #3 from Chad H.  2011-01-18 13:57:27 UTC 
---
minify.php was removed, so this isn't a maintenance issue anymore. 

This is an issue with includes/libs/JSMin.php

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Raimond Spekking  changed:

   What|Removed |Added

 CC||raimond.spekk...@gmail.com
Version|1.18-svn|1.16.1

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

matthieu.far...@smile.public.lu changed:

   What|Removed |Added

  Component|General/Unknown |Maintenance scripts

--- Comment #2 from matthieu.far...@smile.public.lu 2011-01-18 13:52:25 UTC ---
Hi,

Thanks for your quick answer.

JSMin is a core class from Mediawiki.

grep -C 4 -r JSMin.php .

Load for by the global loader and it seems called
one time by a maintenance script : minify.php

   switch ( $extension ) {
   case 'js':
   $outText = JSMin::minify( $inText );
   break;
   default:
   $this->error( "No minifier defined for
extension \"$extension\"" );
   }

As you can see the only script relying on JSMin is basically
a maintenance script and that's the reason why we put it there.

Although legal, this is NOT a docs issue. This impacts the very "free" nature
of MediaWiki.

Regards,

Matthieu

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 26791] Modified MIT licensed component incompatible with GPL

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=26791

Chad H.  changed:

   What|Removed |Added

  Component|Maintenance scripts |General/Unknown
Version|1.16.1  |1.18-svn

--- Comment #1 from Chad H.  2011-01-18 13:32:06 UTC 
---
Not a maintenance script issue, reassigning to General/Unknown (or is it a Docs
issue?) instead of me.

Also removing my CC, because I'm not really interested.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l