[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #6 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-03-06 
09:49:40 UTC ---
This behavior is present on all boolean values.

Changing this would be a breaking change, for esthetic purposes only, so I
recommend WONTFIX.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #7 from Reedy s...@reedyboy.net 2011-03-06 20:17:50 UTC ---
Indeed.

It's how HTML elements do stuff - disable= means true, else it's false.

I think it's just a cause for documentation change, and WONTFIX...

Ryan, what sort of documentation are you suggesting? For all boolean types
(probably makes sense).. Though, for properties, we don't store this level of
granduality..

Tags if the user can and wants to receive e-mail through
[[Special:Emailuser]]

Might be a manual process.

Per Bryan, changing emailable=true or whatever would be a breaking change
from the api... And the only time we try to make them is when security is
involved...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #8 from Reedy s...@reedyboy.net 2011-03-06 20:41:13 UTC ---
Indeed.

It's how HTML elements do stuff - disable= means true, else it's false.

I think it's just a cause for documentation change, and WONTFIX...

Ryan, what sort of documentation are you suggesting? For all boolean types
(probably makes sense).. Though, for properties, we don't store this level of
granduality..

Tags if the user can and wants to receive e-mail through
[[Special:Emailuser]]

Might be a manual process.

Per Bryan, changing emailable=true or whatever would be a breaking change
from the api... And the only time we try to make them is when security is
involved...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||roan.katt...@gmail.com
 Resolution||WONTFIX

--- Comment #9 from Roan Kattouw roan.katt...@gmail.com 2011-03-06 20:45:20 
UTC ---
As Reedy and Bryan have said, this is just the way boolean attributes work in
the API. This is a convention that I don't particularly like either, but it was
introduced before my time and we've stuck with it ever since. Old properties
aren't gonna be moved to a true/false format because that would be a breaking
change (and we never make those for aesthetic reasons only, like Bryan said),
and introducing new properties with a true/false format while keeping old
properties with the present/absent format around would lead a weird,
inconsistent state where no one remembers which property uses which format any
more. So we're kinda stuck in the status quo.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #10 from Ryan Kaldari rkald...@wikimedia.org 2011-03-07 02:21:42 
UTC ---
That's fine. I've added a new section to the API:E-mail documentation on
checking the emailable property:
http://www.mediawiki.org/wiki/API:E-mail#Checking_emailable_status

It includes some sample code, so hopefully that will help people figure it out
without too much trouble.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #1 from Ryan Kaldari rkald...@wikimedia.org 2011-03-05 22:53:40 
UTC ---
XML versions for easier viewing...

True example:
http://en.wikipedia.org/w/api.php?action=querylist=usersususers=Kaldariusprop=emailable

False example:
http://en.wikipedia.org/w/api.php?action=querylist=usersususers=Jormusprop=emailable

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #2 from Reedy s...@reedyboy.net 2011-03-05 22:54:08 UTC ---
This is a slightly strange one. We tend to use (in xml) blah= for defined,
and nothing for undefined..

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #3 from Ryan Kaldari rkald...@wikimedia.org 2011-03-05 22:58:41 
UTC ---
For gender, for example, we return 'male', 'female', or 'unknown'. Wouldn't it
make more sense for emailable to be 'true' or 'false'? It would certainly make
things more intuitive for API users, in my opinion.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #4 from Ryan Kaldari rkald...@wikimedia.org 2011-03-05 23:32:37 
UTC ---
It looks like we do the same thing for the 'readable' property of pages. I
don't think that using empty strings to indicate truth is a good idea
(especially since empty strings are interpreted as false in both PHP and
Javascript). I understand why it was built this way, since all the properties
are universally set up as XML attributes (when in some cases they might make
more sense as attribute values or full nodes). Unfortunately, this leaves our
users with rather unintuitive data that requires more verbose code.

If the resolution is WONTFIX, the return behavior of the property should at
least be documented so that people know they have to test for whether or not
the attribute is defined rather than testing for truth.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27881] the 'emailable' property (from API) should be true or false (currently empty string or undefined)

2011-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27881

--- Comment #5 from Reedy s...@reedyboy.net 2011-03-05 23:55:56 UTC ---
I've asked Roan to chime in...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l