[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #25 from James Forrester --- Finally closed! Yay. (Merged, will go out in wmf4.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #24 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/63148 (Gerrit Change Ica006404227dcd286c387de4f637036341b17eae) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2013-04-29|VE-deploy-2013-05-13 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #23 from Liangent --- (In reply to comment #22) > @Liangent: Some developer-focussed documentation of this area of MW would be > wonderful - all I can find is about how it works for the user (and mostly > from > 2004). I updated https://www.mediawiki.org/w/index.php?title=Language_in_MediaWiki&diff=677107&oldid=599175 which is related to this bug... Actually the whole conversion system needs some re-design, though it doesn't have any timetable, but it still occurs to me that documenting the old stuff is not so worthwhile. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Assignee|krinklem...@gmail.com |roan.katt...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #22 from James Forrester --- @Liangent: Some developer-focussed documentation of this area of MW would be wonderful - all I can find is about how it works for the user (and mostly from 2004). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #21 from Liangent --- (In reply to comment #19) > and if VisualEditor and Parsoid are not > aware of variation / conversion, they're processing content in the first > language (code). Sorry I mean the second in this sentence. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #20 from Liangent --- (In reply to comment #19) > (In reply to comment #18) > > So there is a case where the #mw-content-text isn't set to the wiki content > > language but to the user language, if the content language has a variation? > > That sounds like a MediaWiki core bug perhaps. Though we could export > > Title::getPageLanguage() in VisualEditor specifically, looks like this > > should > > be fixed in core instead, given that it sounds like the regular view of an > > article when reading articles would be broken now as well. And I think the > > VisualEditor edit surface should match what the regular page view does. > > On wikis with variation, there're three language codes. One for user language > (to fetch interface messages), another for content language (wikitext written > in) and the third for page view language (after wikitext gets rendered, it's > converted to another language / variant then displayed to user, by > LanguageConverter). The third can be the same as or different from the first; > they're used for different things. However in practice they're usually set to > the same one by users but we shouldn't assume this. #mw-content-text has the > third language code mentioned above, and if VisualEditor and Parsoid are not > aware of variation / conversion, they're processing content in the first > language (code). ^ I guess this should be explained on some MW.org page. I have been asked about this stuff several times. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #19 from Liangent --- (In reply to comment #18) > So there is a case where the #mw-content-text isn't set to the wiki content > language but to the user language, if the content language has a variation? > That sounds like a MediaWiki core bug perhaps. Though we could export > Title::getPageLanguage() in VisualEditor specifically, looks like this should > be fixed in core instead, given that it sounds like the regular view of an > article when reading articles would be broken now as well. And I think the > VisualEditor edit surface should match what the regular page view does. On wikis with variation, there're three language codes. One for user language (to fetch interface messages), another for content language (wikitext written in) and the third for page view language (after wikitext gets rendered, it's converted to another language / variant then displayed to user, by LanguageConverter). The third can be the same as or different from the first; they're used for different things. However in practice they're usually set to the same one by users but we shouldn't assume this. #mw-content-text has the third language code mentioned above, and if VisualEditor and Parsoid are not aware of variation / conversion, they're processing content in the first language (code). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #18 from Krinkle --- (In reply to comment #12) > The content direction issues were resolved in Iaf61fb9e8ad0ba > by copying the dir and lang attributes from the #mw-content-text > div to the document. > > The toolbar issues should be reported separately and with greater detail. Can someone confirm that the edit surface in VisualEditor is now properly using the directionality of the wiki content language (instead of the user language)? From what I can see this bug is fixed in that regard by change Iaf61fb9e8ad0ba indeed. (In reply to comment #16) > (In reply to comment #14) > > Reopening, the issue will still appear when someone visits [[kk:pagename]] > > with > > variant=kk-arab set where wikitext is written in kk-latn. (where kk and > > kk-latn > > is ltr and kk-arab is rtl). > > Yup, that's a bug. We need to use Title::getPageLanguage() instead of looking > at #mw-content-text (which is controlled by getPageViewLanguage()). > > However, MW core doesn't quite get this right either, see bug 46463. So there is a case where the #mw-content-text isn't set to the wiki content language but to the user language, if the content language has a variation? That sounds like a MediaWiki core bug perhaps. Though we could export Title::getPageLanguage() in VisualEditor specifically, looks like this should be fixed in core instead, given that it sounds like the regular view of an article when reading articles would be broken now as well. And I think the VisualEditor edit surface should match what the regular page view does. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Assignee|roan.katt...@gmail.com |krinklem...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Priority|Normal |High Target Milestone|VE-deploy-2013-04-15|VE-deploy-2013-04-29 --- Comment #17 from James Forrester --- This didn't make it to the milestone; pushing back. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2013-04-01|VE-deploy-2013-04-15 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 Roan Kattouw changed: What|Removed |Added Target Milestone|--- |VE-deploy-2013-04-01 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 Roan Kattouw changed: What|Removed |Added Assignee|krinklem...@gmail.com |roan.katt...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #16 from Roan Kattouw --- (In reply to comment #14) > Reopening, the issue will still appear when someone visits [[kk:pagename]] > with > variant=kk-arab set where wikitext is written in kk-latn. (where kk and > kk-latn > is ltr and kk-arab is rtl). Yup, that's a bug. We need to use Title::getPageLanguage() instead of looking at #mw-content-text (which is controlled by getPageViewLanguage()). However, MW core doesn't quite get this right either, see bug 46463. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2013-03-04|--- -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2013-02-18|VE-deploy-2013-03-04 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2013-02-04|VE-deploy-2013-02-18 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2013-01-16|VE-deploy-2013-02-04 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Target Milestone|--- |VE-deploy-2013-01-16 --- Comment #15 from James Forrester --- Assigning to current milestone, as it's been sitting around for four months untouched at this point. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 Trevor Parscal changed: What|Removed |Added AssignedTo|tpars...@wikimedia.org |krinklem...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Status|REOPENED|ASSIGNED Target Milestone|VE-deploy-2012-09-03|--- -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 Liangent changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #14 from Liangent 2012-09-04 16:25:44 UTC --- Reopening, the issue will still appear when someone visits [[kk:pagename]] with variant=kk-arab set where wikitext is written in kk-latn. (where kk and kk-latn is ltr and kk-arab is rtl). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 Liangent changed: What|Removed |Added CC||liang...@gmail.com --- Comment #13 from Liangent 2012-09-04 16:22:00 UTC --- (In reply to comment #12) > The content direction issues were resolved in > Iaf61fb9e8ad0ba3ab70ffa00c75da4c6f01aad61 by copying the dir and lang > attributes from the #mw-content-text div to the document. > > The toolbar issues should be reported separately and with greater detail. With my gerrit 9860, the attribs of #mw-content-text don't always belong to $wgContLang now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Target Milestone|--- |VE-deploy-2012-09-03 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 Trevor Parscal changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #12 from Trevor Parscal 2012-08-22 21:03:01 UTC --- The content direction issues were resolved in Iaf61fb9e8ad0ba3ab70ffa00c75da4c6f01aad61 by copying the dir and lang attributes from the #mw-content-text div to the document. The toolbar issues should be reported separately and with greater detail. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #11 from Robin Pepermans (SPQRobin) 2012-07-23 22:23:32 UTC --- (In reply to comment #7) > Rob, it looks like this might be as easy as copying the lang and dir > attributes > from the #mw-content-text element and applying them to the .ve-surface > element. Yep, that's what I said in comment 4 :-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #10 from Amir E. Aharoni 2012-07-23 21:42:01 UTC --- ... Sorry, saved before completing. If you haven't already, take a look at https://www.mediawiki.org/wiki/VisualEditor/Internationalization_requirements It is supposed to give an idea about the general framework of how information about content language should be stored and used in MW in the VE age. It is up for discussion, of course. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 --- Comment #9 from Amir E. Aharoni 2012-07-23 21:40:42 UTC --- If you haven't already, take a look at https://www.mediawiki.org/wiki/VisualEditor/Internationalization_requirements It is supposed to give an idea about the general framework of how language is handled in MW. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 Christian Williams changed: What|Removed |Added CC||roan.katt...@gmail.com Component|ContentEditable |Initialisation and ||integration AssignedTo|rm...@wikimedia.org |tpars...@wikimedia.org --- Comment #8 from Christian Williams 2012-07-23 21:32:16 UTC --- Switching to integration. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 Christian Williams changed: What|Removed |Added AssignedTo|i...@wikia-inc.com |rm...@wikimedia.org --- Comment #7 from Christian Williams 2012-07-23 21:31:20 UTC --- Rob, it looks like this might be as easy as copying the lang and dir attributes from the #mw-content-text element and applying them to the .ve-surface element. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33175] VisualEditor: Content in an LTR wiki is displayed RTL in CE block if the interface language is RTL
https://bugzilla.wikimedia.org/show_bug.cgi?id=33175 James Forrester changed: What|Removed |Added Summary|Content in an LTR wiki is |VisualEditor: Content in an |displayed RTL in|LTR wiki is displayed RTL |VisualEditor if the |in CE block if the |interface language is RTL |interface language is RTL -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
