[Bug 36439] Setting labels should normalize some things, API should return the actual label on success

2012-12-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

Anja Jentzsch anja.jentz...@wikimedia.de changed:

   What|Removed |Added

Summary|Setting labels should   |Setting labels should
   |normalize some things, API  |normalize some things, API
   |should return the actual|should return the actual
   |label on success (5)|label on success
 Whiteboard||storypoints: 5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-11-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

Anja Jentzsch anja.jentz...@wikimedia.de changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-11-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #13 from Anja Jentzsch anja.jentz...@wikimedia.de 2012-11-29 
12:37:21 UTC ---
Verified in Wikidata demo time for sprint 8

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #9 from jeb...@gmail.com 2012-07-04 10:41:59 UTC ---
Accidently done in https://gerrit.wikimedia.org/r/#/c/14032/

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #10 from jeb...@gmail.com 2012-07-04 11:19:54 UTC ---
Normalization of aliases is done in https://gerrit.wikimedia.org/r/#/c/13492/

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #11 from jeb...@gmail.com 2012-07-04 17:30:51 UTC ---
Some results from normalization
Source   - encoded - normalized - comment
Åland- %C3%85land  - %C3%85land - codepoint for char
Åland- A%CC%8Aland - %C3%85land - combining ring above
Ångstrom - %E2%84%ABngstrom - %C3%85ngstrom - The initial letter is code point
for an unit

So seems like our current normalization (C) rewrites from capital letter A with
an combining ring above into a valid code point.

Characters are decomposed and then recomposed by canonical equivalence.

Seems like it only will fail in kases with multiple combining characters, but
I'm not sure if that will ever happen.

In my opinion, this works now, case closed.

See also http://en.wikipedia.org/wiki/Unicode_normalization#Normalization

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #12 from jeb...@gmail.com 2012-07-04 17:55:42 UTC ---
Just for the record, conversion of the initial letter in Ångstrøm into a normal
codepoint for Å seems a little bit weird.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

denny vrandecic denny.vrande...@wikimedia.de changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-07-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #8 from denny vrandecic denny.vrande...@wikimedia.de 2012-07-02 
12:38:16 UTC ---
Thanks for the write up!

What would

 toNFC(a1) == toNFC(a2)

return?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-06-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #7 from jeb...@gmail.com 2012-06-29 10:06:52 UTC ---
Note
* the vast majority of input data is already in form C, using precomposed
  characters
* Form C is supposed to be relatively lossless, with the only changes being
  invisible transformations between base character + combining character
  sequences and precomposed chars. In theory text should never change
  appearance because it's been normalized to form C.
* and further, the W3C recommends it

http://www.mediawiki.org/wiki/Unicode_normalization_considerations#What_is_it.3F

This means that an accented character works if it can be normalized into a
precomposed character. For example O₂ and O² works because they can be
normalized into precomposed characters. The code sequence U+30A COMBINING RING
ABOVE preceded by a might be interpreted as a U+00E5 LATIN SMALL LETTER A WITH
RING ABOVE, but it can also be interpreted as an a followed by a small ring.
The same thing happens with a lot of accented letters.

There are also the problem with similarly looking character, which the
following shows

package main
import fmt
func main() {
a1 := string([]byte{0xe2,0x84,0xab})
a2 := string([]byte{0xc3,0x85})
fmt.Println(a1, a2, a1 == a2)
}

Prints:

Å Å false

One character is Angstrom while the other is an A with a ring above, that is
the usual character in Danish and Norwegian.

For now the aliases, labels and descriptions will be normalized into the form
C, and the text will then be trimmed for leading and trailing whitespace and
internal whitespace will be compressed. Whitespace will only be handled for a
limited set of whitespace characters.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-06-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

denny vrandecic denny.vrande...@wikimedia.de changed:

   What|Removed |Added

Summary|Setting labels should   |Setting labels should
   |normalize some things, API  |normalize some things, API
   |should return the actual|should return the actual
   |label on success|label on success (5)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success (5)

2012-06-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

denny vrandecic denny.vrande...@wikimedia.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #6 from denny vrandecic denny.vrande...@wikimedia.de 2012-06-28 
11:35:46 UTC ---
Picked up for Sprint 8.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success

2012-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #5 from denny vrandecic denny.vrande...@wikimedia.de 2012-06-21 
12:52:24 UTC ---
The following normalization should be done for Labels, Descriptions, and
Aliases:
* Unicode normalization of the labels to be done on the Repo.
* Trimming
* Internal whitespace compression

The UI should display the returned normalized value.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success

2012-06-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

denny vrandecic denny.vrande...@wikimedia.de changed:

   What|Removed |Added

 CC||denny.vrandecic@wikimedia.d
   ||e

--- Comment #3 from denny vrandecic denny.vrande...@wikimedia.de 2012-06-20 
22:02:14 UTC ---
This actually does work for the labels if I am not mistaken -- but it does not
seem to work for descriptions and aliases.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success

2012-06-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

denny vrandecic denny.vrande...@wikimedia.de changed:

   What|Removed |Added

   Priority|Normal  |Highest

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success

2012-06-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #4 from jeb...@gmail.com 2012-06-20 22:39:09 UTC ---
There is a very rudimentary mechanism in place for labels. I propose we do
something similar as for titles for the labels and aliases, but I am more
unsure about how harshly we shall normalize the description. I'm tempted to do
something similar as for summary. That is allow links but disallow templates.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success

2012-05-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

--- Comment #2 from jeb...@gmail.com 2012-05-10 11:40:25 UTC ---
API does report the new values as is fter it is set in the same style as the
rest of the API, but this is somewhat cumbersome to unwind later. It is set in
a normalized structure with from and to, if they are different, but this
can later lead to a inconsistency if several language attributes are set at the
same time.

A better solution would be to unconditionally report back the structure as it
actually are after changes.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success

2012-05-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

jeb...@gmail.com changed:

   What|Removed |Added

 CC||jeb...@gmail.com
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=36432

--- Comment #1 from jeb...@gmail.com 2012-05-04 07:17:43 UTC ---
Se also Bug 36432 - Normalize titles and namespaces. Whitespace (and also the
underscore) is stripped in front of text and afterwards, some places also
stripped infix, it is done some up-/lowercasing and so forth.

It is not clear where ordinary normalization should be done, that is in the API
or in the WikibaseItem.

If the strings somehow changes before, during or after storing the pre- and
post normalized form should be reported. so the UI could adjust itself
accordingly.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36439] Setting labels should normalize some things, API should return the actual label on success

2012-05-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36439

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l