[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2013-05-22 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

 Blocks||48719

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

Vitaliy Filippov vita...@yourcmc.ru changed:

   What|Removed |Added

Summary|ParserOptions::mEditSection |ParserOptions::mEditSection
   |is not pushed down to   |is not passed to
   ||ParserOutput

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

Sumana Harihareswara suma...@panix.com changed:

   What|Removed |Added

   Keywords||need-review, patch
 CC||b...@wikidev.net,
   ||suma...@panix.com

--- Comment #1 from Sumana Harihareswara suma...@panix.com 2012-02-24 
12:58:36 UTC ---
Thanks for the patch, Vitaliy! I added keywords to indicate that this bug has a
patch that awaits review.

Do you know of specific extensions that got broken?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

Platonides platoni...@gmail.com changed:

   What|Removed |Added

 CC||platoni...@gmail.com

--- Comment #2 from Platonides platoni...@gmail.com 2012-02-24 16:09:01 UTC 
---
ParserOutput-mEditSectionTokens() defaults to false, and is set to true if 
$this-mOptions-getEditSection() so I don't see any improvement on the
reported issue with your patch (you are ignoring __NOEDITSECTION__, but as the
markers are not outputed, it's probably irrelevant).

Can you provide a test for what this? I am not seeing that behavior:

$ php maintenance/eval.php 
 $popts = new ParserOptions;
 $popts-setEditSection(false);
 $output = $wgParser-parse(== Hello ==\n\nHi\n, Title::newFromText('Bug 
 34687'), $popts);
 echo $output-getText();
h2 span class=mw-headline id=Hello Hello /span/h2
pHi
/p

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Keywords|need-review |reviewed
 CC||m...@everybody.org

--- Comment #3 from Mark A. Hershberger m...@everybody.org 2012-02-24 
16:30:42 UTC ---
s/need-review/reviewed/ per comment #2

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

--- Comment #4 from Vitaliy Filippov vita...@yourcmc.ru 2012-02-24 16:58:07 
UTC ---
Ok, I see... The problem shows when $wgParser is used in extensions with
clearState=false. In that case, a new ParserOutput is not created and
editsection flag is not reset in it...
Patching extensions so they use cloned $wgParser is probably more correct...
But anyway, if somebody will call parse() with clearState=false and
$options-mEditSection=true while editsection was turned off for the original
page, the result will have editsection links turned on...
So is this about parser non-reenterability again? =)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

Vitaliy Filippov vita...@yourcmc.ru changed:

   What|Removed |Added

   Severity|major   |normal

--- Comment #5 from Vitaliy Filippov vita...@yourcmc.ru 2012-02-24 16:58:32 
UTC ---
s/major/normal/ :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

--- Comment #6 from Platonides platoni...@gmail.com 2012-02-24 17:01:46 UTC 
---
Yes, it seems they shouldn't have been reusing the parser. What extension was
it?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

--- Comment #7 from Vitaliy Filippov vita...@yourcmc.ru 2012-02-24 17:08:34 
UTC ---
Two my own extensions and a non-up-to-trunk Wikilog :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

--- Comment #8 from Vitaliy Filippov vita...@yourcmc.ru 2012-02-24 17:09:54 
UTC ---
Sorry - trunk Wikilog also reuses $wgParser.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34687] ParserOptions::mEditSection is not passed to ParserOutput

2012-02-24 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l