[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-08-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Sprint-∞).
Lucas_Werkmeister_WMDE set the point value for this task to "2".

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-08-06 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-08-06 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Isabelladantes1983, Themindcoder, Adamm71, 
Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-08-06 Thread gerritbot 
gerritbot added a comment.


  Change 943577 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Disable InstantCommons in 
WikibaseValueFormatterBuildersTest
  
  https://gerrit.wikimedia.org/r/943577

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-07-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-07-31 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-07-31 Thread gerritbot 
gerritbot added a comment.


  Change 943577 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Disable InstantCommons in 
WikibaseValueFormatterBuildersTest
  
  https://gerrit.wikimedia.org/r/943577

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-07-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T343133: WikibaseValueFormatterBuildersTest::testNewFormatter() fails if InstantCommons is enabled

2023-07-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, wdwb-tech.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  As a Wikibase developer, I want to run the test suite locally without errors, 
to see if there’s something wrong with my changes or not.
  
  **Problem:**
  With `$wgUseInstantCommons = true` in my LocalSettings.php, this test fails:
  
  counterexample
1) 
Wikibase\Lib\Tests\Formatters\WikibaseValueFormatterBuildersTest::testNewFormatter
 with data set "html commons inline image" ('CommonsMedia', 'text/html; 
disposition=verbose', ValueFormatters\FormatterOptions Object (...), 
DataValues\StringValue Object (...), '@^.*https://...iv>$@s')
HTTP request blocked: 
https://commons.wikimedia.org/w/api.php?titles=File%3ADOES-NOT-EXIST-dfsdf.jpg=timestamp%7Cuser%7Ccomment%7Curl%7Csize%7Csha1%7Cmetadata%7Cmime%7Cmediatype%7Cextmetadata=imageinfo=2=1=json=query=true=en
 by ForeignAPIRepo::httpGet. Use MockHttpTrait.

/var/www/html/wiki1/tests/phpunit/mocks/NullHttpRequestFactory.php:46
/var/www/html/wiki1/includes/filerepo/ForeignAPIRepo.php:557
/var/www/html/wiki1/includes/filerepo/ForeignAPIRepo.php:605

/var/www/html/wiki1/includes/libs/objectcache/wancache/WANObjectCache.php:1725

/var/www/html/wiki1/includes/libs/objectcache/wancache/WANObjectCache.php:1555
/var/www/html/wiki1/includes/filerepo/ForeignAPIRepo.php:617
/var/www/html/wiki1/includes/filerepo/ForeignAPIRepo.php:224
/var/www/html/wiki1/includes/filerepo/file/ForeignAPIFile.php:68
/var/www/html/wiki1/includes/filerepo/FileRepo.php:432
/var/www/html/wiki1/includes/filerepo/ForeignAPIRepo.php:137
/var/www/html/wiki1/includes/filerepo/FileRepo.php:473
/var/www/html/wiki1/includes/filerepo/RepoGroup.php:145

/var/www/html/wiki1/extensions/Wikibase/lib/includes/Formatters/CommonsInlineImageFormatter.php:105

/var/www/html/wiki1/extensions/Wikibase/lib/tests/phpunit/Formatters/WikibaseValueFormatterBuildersTest.php:249
/var/www/html/wiki1/tests/phpunit/MediaWikiIntegrationTestCase.php:530
=== Logs generated by test case
[objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"HashBagOStuff"}
[localisation] [debug] LocalisationCache using store LCStoreNull []
[objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"HashBagOStuff"}
[objectcache] [debug] 
fetchOrRegenerate(global:filerepo-file:wiki1-unittest_:3937355f25a3ccacedd1c95a2b4bcc55bd44c56f):
 miss, new value computed []
[objectcache] [debug] 
fetchOrRegenerate(global:filerepo-file-redirect:wiki1-unittest_:05f5d62c0b2c71339397357ff08781fd):
 miss, new value computed []
[wfDebug] [debug] ForeignAPIRepo: HTTP GET: 
https://commons.wikimedia.org/w/api.php?titles=File%3ADOES-NOT-EXIST-dfsdf.jpg=timestamp%7Cuser%7Ccomment%7Curl%7Csize%7Csha1%7Cmetadata%7Cmime%7Cmediatype%7Cextmetadata=imageinfo=2=1=json=query=true=en
 {"private":false}
===
  
  **Workaround:**
  
$wgUseInstantCommons = !defined( 'MW_PHPUNIT_TEST' ); // T343133

 
  
  **Notes:**
  This has happened before, see T268890: Some Wikibase API tests fail if 
Instant Commons is enabled  (I 
blatantly reused parts of the task description).

TASK DETAIL
  https://phabricator.wikimedia.org/T343133

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org