[MediaWiki-CodeReview] [MediaWiki r92231]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r92231. Old Status: ok New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r92231. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92231#c21532 Commit summary: * Use local context instead of global variables * Removed parameters that could be replaced by context * Call Linker methods statically * Removed two unused methods: countWatchlist() and showItemCount() * The parameter of SpecialEditWatch::buildTools() is now unused Comment: pre - $wgUser-invalidateCache(); + $this-clearWatchlist(); + $this-getLang()-invalidateCache(); /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92231]: New comment added, and revision status changed
User IAlex changed the status of MediaWiki.r92231. Old Status: fixme New Status: new User IAlex also posted a comment on MediaWiki.r92231. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92231#c21549 Commit summary: * Use local context instead of global variables * Removed parameters that could be replaced by context * Call Linker methods statically * Removed two unused methods: countWatchlist() and showItemCount() * The parameter of SpecialEditWatch::buildTools() is now unused Comment: Fixed in r95608. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92231]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r92231. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r92231. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92231#c19630 Commit summary: * Use local context instead of global variables * Removed parameters that could be replaced by context * Call Linker methods statically * Removed two unused methods: countWatchlist() and showItemCount() * The parameter of SpecialEditWatch::buildTools() is now unused Comment: pre - $wgOut-readOnlyPage(); + throw new ReadOnlyError; return; /pre The return is now unreachable. Content language is not part of the context? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
