Re: revert of a6c07ffba4b2b37d01affb4c39f032bb5f8d34bf
On Thu, 19 Feb 2009, Steven Edwards wrote: On Thu, Feb 19, 2009 at 5:43 AM, Francois Gouget fgou...@free.fr wrote: A little bit of explanation would be nice... I thought the Changelog in the patch would explain enough. MSG_WAITALL is not defined on Cygwin when building wininet or winhttp without it. Since I can't rebuild all of Wine and I've not checked on MSVC to see if its just a w32api thing, maybe this one should be held off. Since it was a revert I did not expect anything in the patch. In fact it's not a revert at all since the diff is completely different from the original patch. Well, since Cygwin is a Unix platform after a fashion (iirc), I don't think you need to check with MSVC (with MinGW it would be different). So I think your patch is ok. -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0
Re: revert of a6c07ffba4b2b37d01affb4c39f032bb5f8d34bf
On Fri, 20 Feb 2009, Francois Gouget wrote: [...] Well, since Cygwin is a Unix platform after a fashion (iirc), I don't think you need to check with MSVC (with MinGW it would be different). So I think your patch is ok. You should add a comment in the port.h file saying that this define is needed for Cygwin though (so the next one who stumbles on this suspicious define knows why it was put there). -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ Lotto: A tax on people who are bad at math. -- unknown Windows: Microsoft's tax on computer illiterates. -- WE7U
Re: [12/13] fusion: Sort the list of assemblies built during enumeration.
On Friday 20 February 2009 08:38:09 James Hawkins wrote: It would hurt overall performance if we do it at the directory API level, so the same logic does not apply. I'm not advocating adding it to the directory API. I'm saying if we don't care about it at that level, then we shouldn't care about it in fusion, and we certainly shouldn't add that functionality to fusion where it doesn't exist in native fusion. Where that functionality exists in Windows is an implementation detail, we don't have to copy that. -Hans
TrainingPeaks WKO+ Version 22 build 105
I'm trying to use WKO, it is software which communicates via USB to an external device (watch/heart rate monitor/bike odometer) using FTDI drivers. When I plug in the device dmesg tells me it's recognized and placed on /dev/ttyUSB0. I've put a link to that inside of .wine/dosdevices/com1. I still can't get communication to work, on stdout I get the following message repeated many times: fixme:comm:wait_on EV_RXFLAG not handled I think I know how to implement this feature of Win32 serial comm, but before I attempted I wanted to broadcast my intent to do so. Is anyone else working on this, or in the serial.c area that would like to discuss it? Software is available as demo here: http://home.trainingpeaks.com/wko-desktop-software/download.aspx
Re: Status of USB driver support?
On Thursday 19 February 2009 16:55:20 emiliano esposito wrote:
Unhandled exception: unimplemented function
usbd.sys.USBD_GetUSBDIVersion called in 32-bit code (0x7ee2e923)
You can try attached patch
From b7fad82130608126244ba2aee3f91b3337229fb3 Mon Sep 17 00:00:00 2001
From: Alexander Morozov amoro...@etersoft.ru
Date: Fri, 20 Feb 2009 12:14:33 +0300
Subject: [PATCH 3/3] usbd.sys: Implement USBD_GetUSBDIVersion.
---
dlls/usbd.sys/usbd.c|7 +++
dlls/usbd.sys/usbd.sys.spec |2 +-
include/ddk/usb.h |6 ++
3 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/dlls/usbd.sys/usbd.c b/dlls/usbd.sys/usbd.c
index 8c2a8f9..c7c8fab 100644
--- a/dlls/usbd.sys/usbd.c
+++ b/dlls/usbd.sys/usbd.c
@@ -132,6 +132,13 @@ PURB WINAPI USBD_CreateConfigurationRequest(
return urb;
}
+void WINAPI USBD_GetUSBDIVersion( PUSBD_VERSION_INFORMATION VersionInformation
)
+{
+TRACE( %p\n, VersionInformation );
+VersionInformation-USBDI_Version = 0x300;
+VersionInformation-Supported_USB_Version = 0x100;
+}
+
NTSTATUS WINAPI DriverEntry( DRIVER_OBJECT *driver, UNICODE_STRING *path )
{
return STATUS_SUCCESS;
diff --git a/dlls/usbd.sys/usbd.sys.spec b/dlls/usbd.sys/usbd.sys.spec
index 5d0377c..a18bbf8 100644
--- a/dlls/usbd.sys/usbd.sys.spec
+++ b/dlls/usbd.sys/usbd.sys.spec
@@ -19,7 +19,7 @@
@ stub USBD_GetInterfaceLength
@ stub USBD_GetPdoRegistryParameter
@ stub USBD_GetSuspendPowerState
-@ stub USBD_GetUSBDIVersion
+@ stdcall USBD_GetUSBDIVersion(ptr)
@ stub USBD_InitializeDevice
@ stub USBD_MakePdoName
@ stub USBD_ParseConfigurationDescriptor
diff --git a/include/ddk/usb.h b/include/ddk/usb.h
index b8f5f3f..a5db726 100644
--- a/include/ddk/usb.h
+++ b/include/ddk/usb.h
@@ -82,6 +82,12 @@ typedef PVOID USBD_PIPE_HANDLE;
typedef PVOID USBD_CONFIGURATION_HANDLE;
typedef PVOID USBD_INTERFACE_HANDLE;
+typedef struct _USBD_VERSION_INFORMATION {
+ULONG USBDI_Version;
+ULONG Supported_USB_Version;
+} USBD_VERSION_INFORMATION;
+typedef struct _USBD_VERSION_INFORMATION *PUSBD_VERSION_INFORMATION;
+
typedef enum _USBD_PIPE_TYPE {
UsbdPipeTypeControl,
UsbdPipeTypeIsochronous,
--
1.6.1.3.GIT
Re: [12/13] fusion: Sort the list of assemblies built during enumeration.
2009/2/20 Hans Leidekker h...@codeweavers.com: On Friday 20 February 2009 08:38:09 James Hawkins wrote: It would hurt overall performance if we do it at the directory API level, so the same logic does not apply. I'm not advocating adding it to the directory API. I'm saying if we don't care about it at that level, then we shouldn't care about it in fusion, and we certainly shouldn't add that functionality to fusion where it doesn't exist in native fusion. Where that functionality exists in Windows is an implementation detail, we don't have to copy that. I don't know the details, but this is not the mentality of Wine. The problem is if some application expects a particular behaviour, that behaviour needs to be replicated in Wine. Binary compatibility is important, so Wine tries to be bug-for-bug compatible. This might be off-topic for this thread, but I feel it is relevant. Feel free to ignore or correct me if I'm wrong here.
Re: msi: begin support for finding network last sources in find_published_source
Hello, No i never saw the e-mail that you send to Jeremy. I will admit that i did not dig really deep for this patch as it appeared to me that the fix was obvious (there was even a fixme in the code saying we needed to do what the installer was asking for) There are about 4 CAB files that the service pack asks for to install (and only installs a few files out of each) that are accessed by this method. Each one does not exist on the original media at all and only seems accessable via the LastSource location. I am curious what tests you did to prove that you did not need the original media or even the copied cab files? Did you do a test on windows where you deleted them all and the upgrade worked? I will investigate some more, but i do not feel that this patch is incorrect, even if it should not be needed. Am I right there? thanks, -aric James Hawkins wrote: On Thu, Feb 19, 2009 at 12:28 PM, Aric Stewart a...@codeweavers.com wrote: Fix for office 2007 sp 1 install. --- dlls/msi/media.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) I believe you're going down the wrong road with respect to the Office 2007 SP1 installer. None of the files installed/patched by SP1 need access to the original media, or stored local copies of the cab archives. With the fullfile install (which I'm not sure there's another version), you should be able to remove the original media, erase the stored cab files, and successfully install SP1. The fact that our implementation tries to access those cabs or the original media is the bug. There are many conditions and variables that factor in to whether a file should be reinstalled or not, and most of them have been fixed, but this patch is hiding all of the rest of the bugs. I'm not sure if you got the email I sent Jer about this problem, but the real bug is that we aren't handling the REINSTALL variable correctly (or REINSTALLMODE for that matter.) Can you please describe the exact case for why this patch is needed?
Re: msadp32.acm, winemp3.acm: Removed compiler warning
you should send one patch per email, dan should have told you that :P good to see you guys on the project :) 2009/2/20 Adam Stoelting astoelt...@ucla.edu Hello, These are my first patches. I am graduate student at UCLA and am trying to help with porting Wine to 64 bit. I haven't seen any Microsoft source code or done any dll dissasembly on my own. Change Log: Removed the compiler pointer cast warning for dlls/msadp32.acm/msadp32.c and dlls/winemp3.acm/mpegl3.c. Thanks, Adam
Re: TrainingPeaks WKO+ Version 22 build 105
Hi Chris! I think I know how to implement this feature of Win32 serial comm, but before I attempted I wanted to broadcast my intent to do so. Is anyone else working on this, or in the serial.c area that would like to discuss it? No one that I know of is working in this area. Periodically someone might work on serial comm stuff, particularly Uwe Bonnes, but in general this area languishes until someone motivated comes along. So please, work away :) Out of curiosity, which device are you playing with? Cheers, --Juan
Wine download page usability problem
I got email from a friend who complained how hard it was to install wine. Turns out he assumed he had to go to winehq.org and follow the download instructions there, when all he needed to do was do Applications / Add/Remove and pick Wine. Can we add in a line at the top saying Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). If that doesn't work, or if you need a newer version of Wine, here's how to get it. ? I know, that clutters things even more. Suggestions for achieving the same thing more concisely would be welcome. I think we should also move the text This endorsement is the primary recognition that CodeWeavers has requested in exchange for hosting the Wine web site. to the bottom of the page, and change it to read Thanks to CodeWeavers for hosting WineHQ.org. - Dan
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 11:24 AM, Dan Kegel d...@kegel.com wrote: I got email from a friend who complained how hard it was to install wine. Turns out he assumed he had to go to winehq.org and follow the download instructions there, when all he needed to do was do Applications / Add/Remove and pick Wine. Can we add in a line at the top saying Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). Nitpick, but instead of 'Linux', use 'native'. FreeBSD's ports contains wine, as well as NetBSD's. I think we should also move the text This endorsement is the primary recognition that CodeWeavers has requested in exchange for hosting the Wine web site. to the bottom of the page, and change it to read Thanks to CodeWeavers for hosting WineHQ.org. +1 -- -Austin
Re: msi: begin support for finding network last sources in find_published_source
On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart a...@codeweavers.com wrote: Hello, No i never saw the e-mail that you send to Jeremy. I will admit that i did not dig really deep for this patch as it appeared to me that the fix was obvious (there was even a fixme in the code saying we needed to do what the installer was asking for) Unfortunately the error is misleading. A good mentality to take is that if you see the error about 'unable to extract ABC.cab' then we're trying to install a file that shouldn't be installed (or reinstalled.) There are about 4 CAB files that the service pack asks for to install (and only installs a few files out of each) that are accessed by this method. Each one does not exist on the original media at all and only seems accessable via the LastSource location. I don't see how that's possible. If they're in LastSource, that means we used them before and came from the original media. I'm confused about that though, because the only cabs that should be accessed by the SP1 installer are stored in the package itself. Any other file that tries to be installed is improperly being reinstalled. I am curious what tests you did to prove that you did not need the original media or even the copied cab files? Did you do a test on windows where you deleted them all and the upgrade worked? Yes that is one way to test it. The fullfile SP1 does not, and should not, rely on the original media and stored cabs. If our msi is asking for those old cabs, it means we're reinstalling a file that shouldn't be reinstalled (which is a bug.) I will investigate some more, but i do not feel that this patch is incorrect, even if it should not be needed. Am I right there? No, I think the patch is wrong in that if you remove the original media and the stored cabs, the install will fail. -- James Hawkins
Re: Wine download page usability problem
Austin English austinengl...@gmail.com wrote: Sent: Feb 20, 2009 10:32 AM To: Dan Kegel d...@kegel.com Cc: wine-devel@winehq.org wine-devel@winehq.org Subject: Re: Wine download page usability problem On Fri, Feb 20, 2009 at 11:24 AM, Dan Kegel d...@kegel.com wrote: Can we add in a line at the top saying Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). Nitpick, but instead of 'Linux', use 'native'. FreeBSD's ports contains wine, as well as NetBSD's. Please exclude MacOSX which does not include Wine and I doubt it ever will. I think we should also move the text This endorsement is the primary recognition that CodeWeavers has requested in exchange for hosting the Wine web site. to the bottom of the page, and change it to read Thanks to CodeWeavers for hosting WineHQ.org. +1 ++1 James McKenzie
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 11:37 AM, James Mckenzie jjmckenzi...@earthlink.net wrote: Austin English austinengl...@gmail.com wrote: Sent: Feb 20, 2009 10:32 AM To: Dan Kegel d...@kegel.com Cc: wine-devel@winehq.org wine-devel@winehq.org Subject: Re: Wine download page usability problem On Fri, Feb 20, 2009 at 11:24 AM, Dan Kegel d...@kegel.com wrote: Can we add in a line at the top saying Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). Nitpick, but instead of 'Linux', use 'native'. FreeBSD's ports contains wine, as well as NetBSD's. Please exclude MacOSX which does not include Wine and I doubt it ever will. MacOSX doesn't have a native/builtin package manager that is used to download and install applications. Fink/etc. come close, but A) they aren't there by default and B) that's why the qualifier 'usually' is there. -- -Austin
Re: Wine download page usability problem
I think we should also move the text This endorsement is the primary recognition that CodeWeavers has requested in exchange for hosting the Wine web site. to the bottom of the page, and change it to read Thanks to CodeWeavers for hosting WineHQ.org. +1 To be very honest, that would hurt. We get an appreciable amount of traffic from that more prominent location, and that traffic helps to pay our salaries. I feel that it is reasonable for us to ask for that prominent placement, given our contributions, particularly since we're quite honest and clear about it. Cheers, Jeremy
Re: Wine download page usability problem
On Fri, 20 Feb 2009 09:24:09 -0800 Dan Kegel d...@kegel.com wrote: Can we add in a line at the top saying Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). If that doesn't work, or if you need a newer version of Wine, here's how to get it. ? The problem with the way you've phrased it is that it's simply not true. Ubuntu users have complained on the forum more than once that there are no 1.0.1 packages in their repository. I've also never seen any 1.0.1 packages for openSUSE in any of the repositories or the Sourceforge archive. Take out the Stable version 1.0.1 of and it works. -- Rosanne DiMesio dime...@earthlink.net
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 9:42 AM, Jeremy White jwh...@winehq.org wrote: I think we should also move the text This endorsement is the primary recognition that CodeWeavers has requested in exchange for hosting the Wine web site. to the bottom of the page, and change it to read Thanks to CodeWeavers for hosting WineHQ.org. To be very honest, that would hurt. We get an appreciable amount of traffic from that more prominent location, and that traffic helps to pay our salaries. I'm not proposing moving the download link, just the endorsement, which currently isn't a link. (We should probably turn the endorsement into a link.) I feel that it is reasonable for us to ask for that prominent placement, given our contributions, particularly since we're quite honest and clear about it. No argument there, but the thing you want prominently placed is the download link, not the thankyou, right?
Re: Wine download page usability problem
No argument there, but the thing you want prominently placed is the download link, not the thankyou, right? Oh, sorry; I didn't understand. I was trying to be honorable on this point by clearly revealing why that prominent placement was given to us; a truth in advertising sort of thing. I can see that it consumes vertical white space, and I can get over myself. I remove my objection :-/. Cheers, Jeremy
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 11:47:16AM -0600, Rosanne DiMesio wrote: On Fri, 20 Feb 2009 09:24:09 -0800 Dan Kegel d...@kegel.com wrote: Can we add in a line at the top saying Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). If that doesn't work, or if you need a newer version of Wine, here's how to get it. ? The problem with the way you've phrased it is that it's simply not true. Ubuntu users have complained on the forum more than once that there are no 1.0.1 packages in their repository. I've also never seen any 1.0.1 packages for openSUSE in any of the repositories or the Sourceforge archive. Take out the Stable version 1.0.1 of and it works. I actually build them, in http://download.opensuse.org/repositories/Emulators:/Wine:/STABLE/distro but up to adding them I never had a single request for the stable version. I think the regular downloading user might not be interested, and our regular development releases are stable enough. Ciao, Marcus
Re: msi: begin support for finding network last sources in find_published_source
Ok i am following you but. James Hawkins wrote: On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart a...@codeweavers.com wrote: Hello, . . . No, I think the patch is wrong in that if you remove the original media and the stored cabs, the install will fail. By that thinking then the whole function find_published_source is a horrible hack and should be removed as being wrong. It is not the case that these published sources should be accessible? Maybe this is not the correct fix for SP1. But is this patch incorrect for msi also? I am looking at the REINSTALL logic and it looks like it may be tricky. -aric
Re: msi: begin support for finding network last sources in find_published_source
On Fri, Feb 20, 2009 at 9:56 AM, Aric Stewart a...@codeweavers.com wrote: Ok i am following you but. James Hawkins wrote: On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart a...@codeweavers.com wrote: Hello, . . . No, I think the patch is wrong in that if you remove the original media and the stored cabs, the install will fail. By that thinking then the whole function find_published_source is a horrible hack and should be removed as being wrong. It is not the case that these published sources should be accessible? Na it's not a hack. Some patches require the old source to be available (older versions of Office patches for example.) But those all work fine, so I can't say whether the patch is correct or not without tests. My main concern is that we're now *hiding* other bugs because of the changed behavior. Maybe this is not the correct fix for SP1. But is this patch incorrect for msi also? I am looking at the REINSTALL logic and it looks like it may be tricky. I think you're best bet is to append tests to tests/package.c:test_states() that set REINSTALL and REINSTALLMODE to various values and see what the states are. From there the necessary implementation should be apparent. The most important part of REINSTALL(MODE) is that it allows an already installed non-versioned file to not be reinstalled (in certain cases.) If I remember correctly, we needed this one for SP1. Also, REINSTALL is set to the features that are requested to be reinstalled, and we shouldn't try to reinstall anything else in that situation. -- James Hawkins
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 9:55 AM, Jeremy White jwh...@winehq.org wrote: I can see that it consumes vertical white space, and I can get over myself. I remove my objection :-/. Thanks! Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. I'm kind of excited about this technique for cleaning up install flows... - Dan
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 12:40 PM, Dan Kegel d...@kegel.com wrote: [...] Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. I'm kind of excited about this technique for cleaning up install flows... - Dan On Gentoo with www-client/mozilla-firefox (not mozilla-firefox-bin) the page just detects unknown distribution Linux. Thanks, -- Daniel Verkamp
Re: Wine download page usability problem
On Fri, 20 Feb 2009 10:40:28 -0800 Dan Kegel d...@kegel.com wrote: Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. It does not my detect distro version. Can that be done?
Re: Wine download page usability problem
Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Can we also have a non-Javascript page, please? People with accessibility issues, and crufty old curmudgeons like me who disable Javascript by default, would appreciate it. --Juan
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 10:45 AM, Daniel Verkamp dan...@drv.nu wrote: Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, On Gentoo with www-client/mozilla-firefox (not mozilla-firefox-bin) the page just detects unknown distribution Linux. Try it now...
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 10:53 AM, Juan Lang juan.l...@gmail.com wrote: Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Can we also have a non-Javascript page, please? People with accessibility issues, and crufty old curmudgeons like me who disable Javascript by default, would appreciate it. Of course. I think we should only have a single page, and if Javascript is active, it should simply work better.
Re: Wine download page usability problem
For me, it got Gentoo just fine. using: www-client/mozilla-firefox-3.1_beta2-r1 You're using Firefox 3.1 on Gentoo Linux! --Murph On Fri, Feb 20, 2009 at 12:45 PM, Daniel Verkamp dan...@drv.nu wrote: On Fri, Feb 20, 2009 at 12:40 PM, Dan Kegel d...@kegel.com wrote: [...] Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. I'm kind of excited about this technique for cleaning up install flows... - Dan On Gentoo with www-client/mozilla-firefox (not mozilla-firefox-bin) the page just detects unknown distribution Linux. Thanks, -- Daniel Verkamp
Re: user32: implement support for HBMENU_POPUP_* magic menu bitmaps and use them to decorate the system menu
On Freitag 20 Februar 2009, Rein Klazes wrote:
Hi,
See subject.
Rein.
Hi,
mostly minor code style comments.
if( hMenu ) {
+ MENUINFO minfo;
+ MENUITEMINFOW miteminfo;
POPUPMENU* menu = MENU_GetMenu(hMenu);
menu-wFlags |= MF_SYSMENU | MF_POPUP;
SetMenuDefaultItem(hMenu, SC_CLOSE, FALSE);
+
+ minfo.cbSize = sizeof( MENUINFO);
+ minfo.dwStyle = MNS_CHECKORBMP;
+ minfo.fMask = MIM_STYLE;
+ SetMenuInfo( hMenu, minfo);
+
+ miteminfo.cbSize = sizeof( MENUITEMINFOW);
+ miteminfo.fMask = MIIM_BITMAP;
+ miteminfo.hbmpItem = HBMMENU_POPUP_CLOSE;
+ SetMenuItemInfoW( hMenu, SC_CLOSE, FALSE, miteminfo);
+ miteminfo.hbmpItem = HBMMENU_POPUP_RESTORE;
+ SetMenuItemInfoW( hMenu, SC_RESTORE, FALSE, miteminfo);
+ miteminfo.hbmpItem = HBMMENU_POPUP_MAXIMIZE;
+ SetMenuItemInfoW( hMenu, SC_MAXIMIZE, FALSE, miteminfo);
+ miteminfo.hbmpItem = HBMMENU_POPUP_MINIMIZE;
+ SetMenuItemInfoW( hMenu, SC_MINIMIZE, FALSE, miteminfo);
}
I think this part deserves a bit more spacing to be readable.
Something like the above looks better IMO.
Also there is some inconsistent spacing around the beginning and end ()/{}
which does not match the rest of the file.
+logfont.lfHeight = min( h, w) - 2 ;
+TextOutW( hdc, rect-left, rect-top, bmchr, 1);
double space after '=' and ','
case (INT_PTR)HBMMENU_POPUP_CLOSE:
+bmchr[0] = 0x72;
+break;
case (INT_PTR)HBMMENU_POPUP_RESTORE:
+bmchr[0] = 0x32;
+break;
case (INT_PTR)HBMMENU_POPUP_MAXIMIZE:
+bmchr[0] = 0x31;
+break;
case (INT_PTR)HBMMENU_POPUP_MINIMIZE:
+bmchr[0] = 0x30;
+break;
The constants seem to be equal to DFCS_CAPTION...
I just tried to use DrawFrameControl but it seems to always draw a border
around the images.
And i did not find the right parameters for not drawing a border.
It could save some code for font setup but i guess it is not usable for this :-(
+TRACE( height %d rect %s\n, logfont.lfHeight,
wine_dbgstr_rect( rect));
leftover from debugging or is it still needed?
Greetings Peter
Re: user32: implement support for HBMENU_POPUP_* magic menu bitmaps and use them to decorate the system menu
2009/2/20 Rein Klazes w...@online.nl: Hi, See subject. Rein. A testcase would be helpful. -- -Austin
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 12:55 PM, Dan Kegel d...@kegel.com wrote: On Fri, Feb 20, 2009 at 10:45 AM, Daniel Verkamp dan...@drv.nu wrote: Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, On Gentoo with www-client/mozilla-firefox (not mozilla-firefox-bin) the page just detects unknown distribution Linux. Try it now... Indeed, works now. (As a side note, since there are no Gentoo packages on the download page, maybe it makes sense to point the user at some appropriate documentation about how to install it.)
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 11:56 AM, Dan Kegel d...@kegel.com wrote: On Fri, Feb 20, 2009 at 10:53 AM, Juan Lang juan.l...@gmail.com wrote: Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Can we also have a non-Javascript page, please? People with accessibility issues, and crufty old curmudgeons like me who disable Javascript by default, would appreciate it. Of course. I think we should only have a single page, and if Javascript is active, it should simply work better. You could use the HTTP_USER_AGENT environment variable to do a first-order attempt. That way for people with Javascript disabled there's at least a chance you'll detect their distribution. Erich Hoover ehoo...@mines.edu
Re: Wine download page usability problem
2009/2/20 Dan Kegel d...@kegel.com: Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. You're running Mozilla 1.9 on an unknown distribution Windows! (Actually Firefox 3.1 in Wine on Ubuntu, but there's nothing in the user-agent that says it's not Windows ;-) ) - d.
Re: Wine download page usability problem
Hi Dan, Firefox 3.1b2 on OpenSolaris 2008.11 returns: 'unknown distribution of an unknown OS'. Cheers Hark Dan Kegel wrote: On Fri, Feb 20, 2009 at 9:55 AM, Jeremy White jwh...@winehq.org wrote: I can see that it consumes vertical white space, and I can get over myself. I remove my objection :-/. Thanks! Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. I'm kind of excited about this technique for cleaning up install flows... - Dan
Re: Wine download page usability problem
On Fri, 20 Feb 2009 10:40:28 -0800 Dan Kegel d...@kegel.com wrote: On Fri, Feb 20, 2009 at 9:55 AM, Jeremy White jwh...@winehq.org wrote: I can see that it consumes vertical white space, and I can get over myself. I remove my objection :-/. Thanks! Next idea: why don't we detect the user's distro via javascript, and put a targeted link to the 'right' package above the table? Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. I'm kind of excited about this technique for cleaning up install flows... - Dan You're running Firefox 3 on an unknown distribution Linux! (That's for Firefox 3 on openSUSE 10.3). -- Rosanne DiMesio dime...@earthlink.net
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 11:52 AM, Erich Hoover ehoo...@mines.edu wrote: You could use the HTTP_USER_AGENT environment variable to do a first-order attempt. That way for people with Javascript disabled there's at least a chance you'll detect their distribution. Yeah, we could probably do it all in php instead of javascript.
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 7:40 PM, Dan Kegel d...@kegel.com wrote: Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. You're running Firefox 3 on an unknown distribution Linux! Actually: Epiphany 2.24.1 on Ubuntu 8.10 x86-64
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 7:40 PM, Dan Kegel d...@kegel.com wrote: Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. It's probably a more useful test if you also print the reported user agent string. (By the way, Dan, could you somehow coerce your colleagues into making a bottom-posting Gmail? ;) ) Remco
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 1:24 PM, Remco remc...@gmail.com wrote: On Fri, Feb 20, 2009 at 7:40 PM, Dan Kegel d...@kegel.com wrote: Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed. It's probably a more useful test if you also print the reported user agent string. (By the way, Dan, could you somehow coerce your colleagues into making a bottom-posting Gmail? ;) ) Remco Seconded. Attached is a simple (read: dumb) distro finder in PHP. Erich Hoover ehoo...@mines.edu attachment: distro.php
Re: Wine download page usability problem
And now also to the list: On Fri, Feb 20, 2009 at 9:32 PM, Remco remc...@gmail.com wrote: On Fri, Feb 20, 2009 at 9:28 PM, Dan Kegel d...@kegel.com wrote: Please try again, and paste the entire output page, I've added more info. Thanks! Firefox 3 on an unknown distribution Linux! userAgent Mozilla/5.0 (X11; U; Linux x86_64; en; rv:1.9.0.6) Gecko/20080528 Epiphany/2.22 Firefox/3.0 I don't think you're gonna be able to get the distribution name out of that... a problem with Epiphany I guess. Remco
Re: Wine download page usability problem
Firefox 3 on an unknown distribution Linux! userAgent Mozilla/5.0 (X11; U; Linux x86_64; en; rv:1.9.0.6) Gecko/20080528 Epiphany/2.22 Firefox/3.0 I don't think you're gonna be able to get the distribution name out of that... a problem with Epiphany I guess. Right, same with Konqueror. Fortunately, web access logs on kegel.com show that an overwhelming majority of visitors do specify the distro; the first entry that doesn't (Konqueror) is only #14 and accounts for a small percentage. And even then we won't break, we'll just show the current download page. 69 Mozilla/5.0 (compatible; Konqueror/4.2; Linux) KHTML/4.2.0 (like Gecko) 72 Mozilla/5.0 (X11; U; Linux i686; de; Gecko Ubuntu/8.10 (intrepid) Firefox/3.0.6 73 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko Ubuntu/8.10 (intrepid) Firefox/3.0.3 74 Mozilla/5.0 (X11; U; Linux x86_64; en-US; Gecko Ubuntu/8.04 (hardy) Firefox/3.0.6 75 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko Fedora/3.0.6-1.fc10 Firefox/3.0.6 78 Mozilla/5.0 (X11; U; Linux i686; zh-CN; Gecko Ubuntu/8.10 (intrepid) Firefox/3.0.6 81 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko Iceweasel/2.0.0.19 (Debian-2.0.0.19-0etch1) 87 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko GranParadiso/3.0.6 114 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko Gentoo Firefox/3.0.5 138 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko Mandriva/1.9.0.5-0.1mdv2009.0 (2009.0) Firefox/3.0.5 150 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko GranParadiso/3.0.5 229 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko Ubuntu/8.04 (hardy) Firefox/3.0.6 254 Mozilla/5.0 (X11; U; Linux x86_64; en-US; Gecko Ubuntu/8.10 (intrepid) Firefox/3.0.6 832 Mozilla/5.0 (X11; U; Linux i686; en-US; Gecko Ubuntu/8.10 (intrepid) Firefox/3.0.6
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 9:32 PM, Remco remc...@gmail.com wrote: Firefox 3 on an unknown distribution Linux! userAgent Mozilla/5.0 (X11; U; Linux x86_64; en; rv:1.9.0.6) Gecko/20080528 Epiphany/2.22 Firefox/3.0 I don't think you're gonna be able to get the distribution name out of that... a problem with Epiphany I guess. Remco Filed a bug with epiphany-browser: https://bugs.launchpad.net/ubuntu/+source/epiphany-browser/+bug/332253 Remco
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 1:47 PM, Remco remc...@gmail.com wrote: On Fri, Feb 20, 2009 at 9:32 PM, Remco remc...@gmail.com wrote: Firefox 3 on an unknown distribution Linux! userAgent Mozilla/5.0 (X11; U; Linux x86_64; en; rv:1.9.0.6) Gecko/20080528 Epiphany/2.22 Firefox/3.0 I don't think you're gonna be able to get the distribution name out of that... a problem with Epiphany I guess. Remco Filed a bug with epiphany-browser: https://bugs.launchpad.net/ubuntu/+source/epiphany-browser/+bug/332253 Remco See if any of the properties on this page will reveal your distro: https://developer.mozilla.org/en/DOM/window.navigator Hint: you can test them by running them in the address bar, ie: javascript:alert(window.navigator.vendor); Erich Hoover ehoo...@mines.edu
Greatings
Hi. I want help you. I know c glibc and svn. I don't know git(but i'm leraning) and winapi(i don't know how learn without windows). Where my skils will be usefull. I have StarCraft and i want help you with dib engine but my skils are still too low (i don't know how patch my git tree with max dib engine). Bye. Piotr Skólski (SQLek) s...@wp.pl
Re: Wine download page usability problem
2009/2/21 Dan Kegel d...@kegel.com: Can we add in a line at the top saying Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). I know some versions of Ubuntu ship with 1.0.1 in official repositories, but I don't know of any other distros that do. Regarding the browser-detection, server-side scripting is the best way. I'm always against needlessly adding Javascript to pages. What I'd like to see is some option to view the full list of distros/sources even when the detection worked. Something like: To see download pages for more distributions, click here It can be useful to be able to see one system's instructions from another, especially when doing user support.
RE: Wine download page usability problem
On Fri, Feb 20, 2009 at 7:40 PM, Dan Kegel d...@kegel.com wrote: Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed.You're running Firefox 3 on an unknown distribution Windows an unknown CPU! Firefox 3.0.6 on Windows XP SP3 userAgent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 Rolf Kalbermatter
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 11:02:16PM +0100, Rolf Kalbermatter wrote: On Fri, Feb 20, 2009 at 7:40 PM, Dan Kegel d...@kegel.com wrote: Please try http://kegel.com/wine/distro.html and let me know if it detects your distro properly, I'll fix it up as needed.You're running Firefox 3 on an unknown distribution Windows an unknown CPU! Firefox 3.0.6 on Windows XP SP3 userAgent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 You're running Konqueror 3.5 on an unknown distribution Linux an unknown CPU! Please let Dan Kegel (d...@kegel.com) know if this isn't accurate. Please include the incorrect output, the correct distro name, and the following information: userAgent Mozilla/5.0 (compatible; Konqueror/3.5) KHTML/3.5.9 (like Gecko) SUSE (openSUSE 11.0) Ciao, Marcus
Possible to run arbitrary PHP code on pipermail server
I read the following e-mail on pipermail: http://www.winehq.org/pipermail/wine-devel/2009-February/073428.html Try downloading the PHP attachment from there; it will actually execute and give you an HTML page. This could easily be abused! Remco
Re: Possible to run arbitrary PHP code on pipermail server
On Fri, Feb 20, 2009 at 4:21 PM, Remco remc...@gmail.com wrote:
I read the following e-mail on pipermail:
http://www.winehq.org/pipermail/wine-devel/2009-February/073428.html
Try downloading the PHP attachment from there; it will actually
execute and give you an HTML page. This could easily be abused!
Remco
Wow, that is really awesome and really scary at the same time. Attached is
the same deal with a text extension, for your viewing pleasure.
Erich Hoover
ehoo...@mines.edu
?php
$agent = $_SERVER['HTTP_USER_AGENT'];
$OS = Array(Windows, Linux, Mac);
$Distro = Array(Ubuntu);
$Browser = Array(Firefox, MSIE, Safari);
$os_data = match_strings($agent, $OS);
$distro_data = match_strings($agent, $Distro);
$browser_data = match_strings($agent, $Browser);
print You are using $browser_data on $os_data ($distro_data).;
function match_strings($haystack, $matches) {
$found = false;
foreach($matches as $needle) {
if(strstr($haystack, $needle)) {
$result = $needle;
$found = true;
}
}
if(!$found) {
return Unknown;
}
return $result;
}
?
Problem cross compiling after adding tests for inet_ntop
I have been writing some tests for InetNtop/inet_ntop and placed them in
dlls/ws2_32/tests/sock.c (snip of the code is below) but when I cross
compile I get:
make crosstest
i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include-g
-O2 -o sock.cross.o sock.c
i386-mingw32-gcc protocol.cross.o sock.cross.o testlist.cross.o -o
ws2_32_crosstest.exe -L../../../dlls ../../../libs/port/libwine_port.a
-L../../../dlls/ws2_32 -L../../../dlls/kernel32 -lws2_32 -lkernel32
sock.cross.o: In function `test_inet_addr':
/wing/dlls/ws2_32/tests/sock.c:2013: undefined reference to `_inet_n...@16'
/wing/dlls/ws2_32/tests/sock.c:2025: undefined reference to `_inet_n...@16'
/wing/dlls/ws2_32/tests/sock.c:2029: undefined reference to `_inet_n...@16'
/wing/dlls/ws2_32/tests/sock.c:2032: undefined reference to `_inet_n...@16'
collect2: ld returned 1 exit status
make: *** [ws2_32_crosstest.exe] Error 1
I am using unmodified winsock.spec and ws2_32.spec files. It does not
look like inet_ntop has been used in tests previously. Any ideas on
what I need to do to get crosstest to work?
dlls/ws2_32/tests/sock.c
static void test_inet_addr(void)
{
u_long addr;
char dst[16];
char dst6[64];
u_char ip6_addr[16] = {0x20,0x30,0xa4,0xb1};
const char * pdst;
struct in_addr in;
struct in6_addr in6;
u_long addr0_Num = 0x;
PCSTR addr0_Str = 0.0.0.0;
u_long addr1_Num = 0x20201015;
PCSTR addr1_Str = 21.16.32.32;
u_char addr2_Num[16] =
{0,0,0,0,0,0,0,0,0,0,0xff,0xfe,0xcC,0x98,0xbd,0x74};
PCSTR addr2_Str = ::fffe:cc98:bd74;
addr = inet_addr(NULL);
in.S_un.S_addr = addr;
trace(addr=%ld\n,addr);
ok(addr == INADDR_NONE, inet_addr succeeded unexpectedly\n);
in.S_un.S_addr = addr0_Num;
pdst = InetNtop(AF_INET,(void*)in.S_un.S_addr,dst,sizeof(dst));
ok(strcmp(pdst, addr1_Str),Address %s != %s\n, pdst, addr0_Str);
ok(pdst != NULL, InetNtop failed %s\n, dst);
pdst = inet_ntoa(*((struct in_addr*)in.s_addr));
ok(pdst != NULL, InetNtop succeeded unexpectedly %s\n, dst);
ok(!strcmp(pdst, addr1_Str),Address %s != %s\n, pdst, addr0_Str);
trace (addr=%s\n,pdst);
in.S_un.S_addr = addr1_Num;
pdst = inet_ntoa(*((struct in_addr*)in.s_addr));
ok(pdst != NULL, inet_ntoa succeeded unexpectedly %s\n, dst);
ok(!strcmp(pdst, addr1_Str),Address %s != %s\n, pdst, addr1_Str);
trace (addr=%s\n,pdst);
pdst = InetNtop(AF_INET6,(void*)in.S_un.S_addr,dst,sizeof(dst));
trace (addr=%s\n,pdst);
ok(pdst != NULL, InetNtop failed %s\n, dst);
memcpy(in6.s6_addr,ip6_addr,sizeof(ip6_addr));
pdst = InetNtop(AF_INET6,(void*)in6.s6_addr,dst6,sizeof(dst6));
ok(pdst != NULL, InetNtop failed %s\n, dst6);
memcpy(in6.u.Byte,addr2_Num,sizeof(addr2_Num));
pdst = InetNtop(AF_INET6,(void*)in6.s6_addr,dst6,sizeof(dst6));
ok(pdst != NULL, InetNtop failed %s\n, dst6);
ok(!strcmp(pdst, addr2_Str),Address %s != %s\n, pdst, addr2_Str);
}
Re: Wine download page usability problem
On Fri, Feb 20, 2009 at 12:47 PM, Remco remc...@gmail.com wrote: Filed a bug with epiphany-browser: https://bugs.launchpad.net/ubuntu/+source/epiphany-browser/+bug/332253 Thanks. I filed one for Konqueror, https://bugs.launchpad.net/ubuntu/+source/kdebase/+bug/332340 -Dan
Re: Closing fixed bugs
On Saturday 14 February 2009, Dan Kegel wrote: A few months ago, Alexandre started including lists of fixed bugs in his release announcements. See e.g. http://www.winehq.org/announce/1.1.15, which says Bugs fixed in 1.1.15: 5694 Lionhead Black White 2 demo crashes 7014 Unhandled page fault when exiting Commandos - BEL 7297 MIDI in/out fails, ports recognized ... I rather like those lists. He generates them by simply querying for open but fixed bugs right when he does the release; he then closes the bugs. They're good for PR if nothing else. For this to work, we have to let Alexandre be the only person to close fixed bugs. (Of course, it's ok for other people to mark bugs fixed, and it's ok for anyone to close invalid or dup bugs.) If anybody else closes a fixed bug, it won't show up in the list of fixed bugs for any release. A corner case is when a bug is marked fixed sometime after release. I think it's ok to leave it for Alexandre to close; that way it shows up in at least one release announcement. Even if it shows up a few releases late, that's better than not showing up at all. Sound reasonable? I ask because Vitaliy closed http://bugs.winehq.org/show_bug.cgi?id=10923 even after I tried to explain this to him, so I figured it needed a wider discussion. - Dan Couldn't you just query Bugzilla for all the bugs closed between $release and $lastrelease? - Neil
Re: Wine download page usability problem
Rosanne DiMesio wrote: On Fri, 20 Feb 2009 09:24:09 -0800 Dan Kegel d...@kegel.com wrote: Can we add in a line at the top saying Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). If that doesn't work, or if you need a newer version of Wine, here's how to get it. ? The problem with the way you've phrased it is that it's simply not true. Ubuntu users have complained on the forum more than once that there are no 1.0.1 packages in their repository. I've also never seen any 1.0.1 packages for openSUSE in any of the repositories or the Sourceforge archive. 1.0.1 is included in Ubuntu 8.10. 8.04 still has 1.0.0 though. I think I started a backport a long time ago, but I guess it never finished. Thanks, Scott Ritchie
Re: Problem cross compiling after adding tests for inet_ntop
Jeff Latimer wrote: Any ideas on what I need to do to get crosstest to work? Problem fixed. When in doubt read the documentation ie. I searched went to the wiki http://wiki.jswindle.com/index.php/Coding_Hints:Test_Cases which had a post from Hans.
