Re: [PATCH 4/4] mshtml: Added IHTMLElement:removeAttribute tests.
Hi Jacek,
On 03/24/2010 08:01 PM, Jacek Caban wrote:
+function test_removeAttribute(e) {
+ok(e.removeAttribute('nonexisting') === false, removeAttribute('nonexisting')
didn't return false);
+
+e.title = title;
+ok(e.removeAttribute('title') === true, removeAttribute('title') didn't return
true);
+ok(e.title === , e.title = + e.title);
+ok((title in e) === true, title is not in e);
(commenting that one)
+
+e[myattr] = test;
+ok(e.removeAttribute('myattr') === true, removeAttribute('myattr') didn't
return true);
+ok(e[myattr] === undefined, e['myattr'] = + e['myattr']);
(and that one)
+ok((myattr in e) === false, myattr is in e);
(and that one makes the tests run again).
+
+}
These new tests introduce timeouts on IE5 (and lower?).
If I just open the jstest.html in a IE5 browser I get a warning for some
of the lines:
+ok((title in e) === true, title is not in e);
+ok((myattr in e) === false, myattr is in e);
shows:
Line: 14
Char: 17 (18 for that second one of course)
Error: Expected ')'
--
Cheers,
Paul.
Re: 3/4 wined3d: add color_fill to blit_shader [try 2]
That's more reasonable, but you still have a NULL function pointer in arbfp_blit for color_fill(), and blit_operation is unused.
Re: [PATCH 4/4] mshtml: Added IHTMLElement:removeAttribute tests.
Hi Paul,
On 03/26/10 10:40, Paul Vriens wrote:
Hi Jacek,
On 03/24/2010 08:01 PM, Jacek Caban wrote:
+function test_removeAttribute(e) {
+ok(e.removeAttribute('nonexisting') === false,
removeAttribute('nonexisting') didn't return false);
+
+e.title = title;
+ok(e.removeAttribute('title') === true,
removeAttribute('title') didn't return true);
+ok(e.title === , e.title = + e.title);
+ok((title in e) === true, title is not in e);
(commenting that one)
+
+e[myattr] = test;
+ok(e.removeAttribute('myattr') === true,
removeAttribute('myattr') didn't return true);
+ok(e[myattr] === undefined, e['myattr'] = + e['myattr']);
(and that one)
+ok((myattr in e) === false, myattr is in e);
(and that one makes the tests run again).
+
+}
These new tests introduce timeouts on IE5 (and lower?).
I think we should skip tests on these IEs. I've sent a patch.
Thanks,
Jacek
Latest Git Fails tools/install
Compiling Wine. Grab a lunch or two, rent a video, or whatever, in the meantime... config.status: executing Makefile commands cat: Make.tmp: No such file or directory config.status: error: could not create Makefile make: *** [Makefile] Error 1 config.status: executing Makefile commands cat: Make.tmp: No such file or directory config.status: error: could not create Makefile make: *** [Makefile] Error 1 Compilation failed, aborting install. Ideas? Chris
Re: Latest Git Fails tools/install
On 3/26/2010 22:48, chris ahrendt wrote: Compiling Wine. Grab a lunch or two, rent a video, or whatever, in the meantime... config.status: executing Makefile commands cat: Make.tmp: No such file or directory config.status: error: could not create Makefile make: *** [Makefile] Error 1 config.status: executing Makefile commands cat: Make.tmp: No such file or directory config.status: error: could not create Makefile make: *** [Makefile] Error 1 Compilation failed, aborting install. Ideas? As usual, run ./configure. Chris
Re: Latest Git Fails tools/install
As usual, run ./configure. Doesn't help, same problem here with ./configure. Make distclean also fails. --Juan
Re: Latest Git Fails tools/install
On Fri, Mar 26, 2010 at 12:48:06PM -0700, chris ahrendt wrote: Compiling Wine. Grab a lunch or two, rent a video, or whatever, in the meantime... config.status: executing Makefile commands cat: Make.tmp: No such file or directory config.status: error: could not create Makefile make: *** [Makefile] Error 1 config.status: executing Makefile commands cat: Make.tmp: No such file or directory config.status: error: could not create Makefile make: *** [Makefile] Error 1 Compilation failed, aborting install. Ideas? If you run configure again it is gone at least. Ciao, Marcus
Re: Latest Git Fails tools/install
On 3/26/2010 22:55, Juan Lang wrote: As usual, run ./configure. Doesn't help, same problem here with ./configure. Make distclean also fails. --Juan Don't know then, I'm building right now, on m* modules already.
Re: Latest Git Fails tools/install
chris ahrendt wrote: Compiling Wine. Grab a lunch or two, rent a video, or whatever, in the meantime... config.status: executing Makefile commands cat: Make.tmp: No such file or directory config.status: error: could not create Makefile make: *** [Makefile] Error 1 config.status: executing Makefile commands cat: Make.tmp: No such file or directory config.status: error: could not create Makefile make: *** [Makefile] Error 1 Compilation failed, aborting install. Ideas? I had the same problem. Fixed with git clean -fd. Note that this will remove any files in the tree that aren't tracked. See man git-clean for more info, of course. Andrew
Re: Latest Git Fails tools/install
If you run configure again it is gone at least. You're right, that fixed it for me too. Thanks. --Juan
Re: Verbose explanation about the cygwin issue
Sorry for the delay, First of all, I would like to explain why I tried to compile wine on cygwin. My first goal was to help wine as some of you improve wine on different systems (native 64 bits. WOW...). I knew that wine compiled well on MinGW but I'm not using it. Cygwin is, on my mind, simpler to set up and to use. If you want git or gdb you have to click next several times and that's done. On MinGW, there is no bash or you have to install MSYS (from what I remember) : it's painful to have a basic system. But I'm not here to argue... The previous answers of this topic made me wonder what do we know ?. Either we want to build wine on cygwin (depending on cygwin1.dll) or to build it as a native Windows app. The first approach means that we're going to build a windows emulator on an emulator of unix system on a computer running Windows OS. (I *know* that wine stands for Wine Is Not An Emulator but you understood what I mean) Does it make any sense ? And the second one is building wine with MinGW. -- But I agree we should replace -no-cygwin by something more .. meaningful. It's not up to me to say what we should do, I'm only telling you my opinion. Comments are, as always, welcome.
wisotool: a script to automate multi-cd installs
I was looking at the bookshelf full of old games I've collected over the years, and was annoyed that there wasn't any sort of unattended regression test for their installers... 'course, that's hard, since you'd have to somehow insert the cd-roms automatically. But you can kind of fake it by mounting .iso files, at least for some games, so I tried doing it for Diablo II. And it seems to work! I wrapped it up in an extensible script, with a menu and some functions stolen from winetricks. It's at http://code.google.com/p/winezeug/source/browse/trunk/wisotool (though you have to check out that directory from svn to run it, as it currently depends on two other files there). The idea is you run the script like this to load a cd-rom into its cache of .iso files: sh wisotool load If the cd-rom has a key associated with it, specify it like this: sh wisotool load=XXX-YYY-ZZZ-WWW The .iso files are cached in ~/.wisotoolcache in filenames named after their sha1sums (so best run on a fast machine :-) Then (assuming somebody has added a verb for the app to the script), you can then run the script to install from the .iso files. For instance, sh wisotool diablo2 or sh wisotool morrowind It only supports those two games at the moment, it doesn't run on windows yet (though it should eventually), and the diablo2 verb starts the game (I couldn't figure out how to stop it). It's kind of like playonlinux in that it has separate scripts (well, functions) for each game it supports, but utterly unlike playonlinux because it doesn't try to patch or futz with wine in any way (beyond running winetricks if needed), and the installs are totally unattended (unlike playonlinux, where you have to click things and insert discs). I have no idea how many games this will work for, but heck, may as well try it. I expect to use this in automated testing sometime, and welcome additional verbs if people feel like writing them. - Dan
Re: wisotool: a script to automate multi-cd installs
On Fri, Mar 26, 2010 at 9:16 PM, Dan Kegel d...@kegel.com wrote: But you can kind of fake it by mounting .iso files, at least for some games, so I tried doing it for Diablo II. And it seems to work! I wrapped it up in an extensible script, with a menu and some functions stolen from winetricks. It's at http://code.google.com/p/winezeug/source/browse/trunk/wisotool I forgot to mention: Austin already contributed a verb for morowind (with a little borrowed code from appinstall). So that's two apps supported so far. One big difference between wisotool and appinstall is that wisotool tries to be a building block, whereas appinstall was the whole enchilada. We might end up refactoring appinstall to use wisotool, who knows. - Dan
