Re: [2/2] msvcrt: Forward strftime() to wcsftime(). Take 2.
Alexandre Julliard wrote: > The overflow handling still looks suspicious. It probably needs some > more test cases. I'm probably missing something, why new attempt is marked as pending? -- Dmitry.
Re: MacOS recording audio - chunking 4096 frames
On Jan 10, 2012, at 7:36 AM, joerg-cyril.hoe...@t-systems.com wrote: > looking at mmdevapi/tests/capture logs, I found 2 issues > > 1. the 5 buffers initially sent are all returned with 0 bytes > So I added a loop to return empty buffers to the audio input queue, > such that GetBuffer returns data when GetCurrentPadding shows it. > > But why were these buffers returned at all? Don't know off-hand. I haven't looked, but could we be calling AudioQueuePrime() for the capture case? We shouldn't be and who knows what it does. Alternatively, are we calling AudioQueueFlush() or AudioQueueStop() after enqueuing the buffers? > 2. Using a ~500ms mmdevapi duration, Wine gave MacOS CoreAudio 5 buffers > of ~4399 frames each. However, MacOS solely returned 4096 frames. > > Is anybody aware of such chunking? Again, not off-hand, but it doesn't surprise me that it would have an internal buffer size and prefer to return whole buffers. See, for example, the device property kAudioDevicePropertyBufferFrameSize. Regards, Ken
Re: Vista/w2k8/w7 users, please test mmdevapi capture
Two runs, one after the other. W7 home premium, samsung r780 laptop. C:\Users\samsung\Downloads>mmdevapi_test.exe capture capture.c:663: Returned periods: 10.1587 ms 3. ms capture.c:675: pwfx: 002CB8D8 capture.c:676: Tag: fffe capture.c:677: bits: 32 capture.c:678: chan: 2 capture.c:679: rate: 44100 capture.c:680: align: 8 capture.c:681: extra: 22 capture.c:686: Res: 32 capture.c:687: Mask: 3 capture.c:688: Alg: FLOAT capture.c:745: Returned latency: 5.8050 ms capture.c:170: Test failed: Position 896 expected 0 capture.c:175: Device position 896 pad 0 flags 1, amount of frames locked: 448 capture.c:217: Test failed: Position 1344 expected 448 capture.c:225: Test failed: GCP 16576 past ReleaseBuffer(0) initially 16128 capture.c:235: Device position 1344 pad 16128 flags 0, amount of frames locked: 448 capture.c:243: Test failed: Position 1344 expected 448 capture.c:281: GetBufferSize 21996 period size 448 capture.c:290: Device position 2240 pad 21996 flags 1, amount of frames locked: 448 capture.c:298: Test failed: Position 2240 expected 896 capture.c:312: Device position 2688 pad 21548 flags 0, amount of frames locked: 448 capture.c:333: Device position 3136 pad 21548 flags 0, amount of frames locked: 448 capture.c:356: Test failed: Valid IAudioCaptureClient_GetBuffer returns 08890001 capture.c:357: Device position -1 pad 0 flags 0, amount of frames locked: 0 capture.c:372: Device position 40768 pad 0 flags 1, amount of frames locked: 448 capture.c:375: Test failed: Position 40768 expected 3584 capture.c:484: Device position -1 pad 0 flags abadcafe, amount of frames locked: 0 capture.c:488: Test failed: GetNextPacketSize 448 vs. GetBuffer 0 capture.c:544: Device position 56896 pad 16576 flags 0, amount of frames locked: 448 capture.c:552: Test failed: Position 56896 expected 0 capture.c:590: GetBufferSize 21996 period size 448 capture.c:599: Device position 57792 pad 21996 flags 1, amount of frames locked: 448 capture.c:605: Test failed: Position 57792 expected 448 capture: 302 tests executed (0 marked as todo, 10 failures), 0 skipped. C:\Users\samsung\Downloads>mmdevapi_test.exe capture capture.c:663: Returned periods: 10.1587 ms 3. ms capture.c:675: pwfx: 0081B8D8 capture.c:676: Tag: fffe capture.c:677: bits: 32 capture.c:678: chan: 2 capture.c:679: rate: 44100 capture.c:680: align: 8 capture.c:681: extra: 22 capture.c:686: Res: 32 capture.c:687: Mask: 3 capture.c:688: Alg: FLOAT capture.c:745: Returned latency: 5.8050 ms capture.c:175: Device position 0 pad 0 flags 1, amount of frames locked: 448 capture.c:235: Device position 448 pad 15232 flags 0, amount of frames locked: 4 48 capture.c:281: GetBufferSize 21996 period size 448 capture.c:290: Device position 1344 pad 21996 flags 1, amount of frames locked: 448 capture.c:298: Test failed: Position 1344 expected 896 capture.c:312: Device position 1792 pad 21548 flags 0, amount of frames locked: 448 capture.c:333: Device position 2240 pad 21548 flags 0, amount of frames locked: 448 capture.c:356: Test failed: Valid IAudioCaptureClient_GetBuffer returns 08890001 capture.c:357: Device position -1 pad 0 flags 0, amount of frames locked: 0 capture.c:372: Device position 37184 pad 0 flags 1, amount of frames locked: 448 capture.c:375: Test failed: Position 37184 expected 2688 capture.c:484: Device position -1 pad 0 flags abadcafe, amount of frames locked: 0 capture.c:488: Test failed: GetNextPacketSize 448 vs. GetBuffer 0 capture.c:544: Device position 52864 pad 17024 flags 0, amount of frames locked: 448 capture.c:552: Test failed: Position 52864 expected 0 capture.c:590: GetBufferSize 21996 period size 448 capture.c:599: Device position 53760 pad 21996 flags 1, amount of frames locked: 448 capture.c:605: Test failed: Position 53760 expected 448 capture: 302 tests executed (0 marked as todo, 6 failures), 0 skipped. J. Leclanche On Wed, Jan 11, 2012 at 5:48 PM, Matijn Woudt wrote: > On Wed, Jan 11, 2012 at 9:51 AM, > wrote: > > Hi, > > > > you don't need a microphone, just a capture capable sound card, unlike > testbot. > > > > Please download mmdevapi_test32|64.exe from testbot: > > http://testbot.winehq.org/JobDetails.pl?Key=16376 > > run: > > mmdevapi_test capture > > and post or send me the results -- not just the failures, > > the console output too including position/padding/flags. > > > > Don't be afraid of some test failures in lines 300-499. > > I'm still investigating underrun and start/stop/reset behaviour. > > > > Thank you for testing, > >Jörg Höhle > > > > Hi, > > Attached are my results from Win7 x64 (both 32bit and 64bit test results). > > Matijn > > > >
Re: Vista/w2k8/w7 users, please test mmdevapi capture
On Wed, Jan 11, 2012 at 9:51 AM, wrote: > Hi, > > you don't need a microphone, just a capture capable sound card, unlike > testbot. > > Please download mmdevapi_test32|64.exe from testbot: > http://testbot.winehq.org/JobDetails.pl?Key=16376 > run: > mmdevapi_test capture > and post or send me the results -- not just the failures, > the console output too including position/padding/flags. > > Don't be afraid of some test failures in lines 300-499. > I'm still investigating underrun and start/stop/reset behaviour. > > Thank you for testing, > Jörg Höhle > Hi, Attached are my results from Win7 x64 (both 32bit and 64bit test results). Matijn mmdevapi_test.exe capture capture.c:663: Returned periods: 10. ms 3. ms capture.c:675: pwfx: 0095D368 capture.c:676: Tag: fffe capture.c:677: bits: 32 capture.c:678: chan: 2 capture.c:679: rate: 48000 capture.c:680: align: 8 capture.c:681: extra: 22 capture.c:686: Res: 32 capture.c:687: Mask: 3 capture.c:688: Alg: FLOAT capture.c:745: Returned latency: 5. ms capture.c:170: Test failed: Position 480 expected 0 capture.c:175: Device position 480 pad 0 flags 1, amount of frames locked: 480 capture.c:217: Test failed: Position 960 expected 480 capture.c:225: Test failed: GCP 17280 past ReleaseBuffer(0) initially 16800 capture.c:235: Device position 960 pad 16800 flags 0, amount of frames locked: 480 capture.c:243: Test failed: Position 960 expected 480 capture.c:281: GetBufferSize 23941 period size 480 capture.c:290: Device position 1920 pad 23941 flags 1, amount of frames locked:480 capture.c:298: Test failed: Position 1920 expected 960 capture.c:312: Device position 2400 pad 23461 flags 0, amount of frames locked:480 capture.c:333: Device position 2880 pad 23461 flags 0, amount of frames locked:480 capture.c:356: Test failed: Valid IAudioCaptureClient_GetBuffer returns 08890001 capture.c:357: Device position -1 pad 0 flags 0, amount of frames locked: 0 capture.c:372: Device position 39840 pad 0 flags 0, amount of frames locked: 480 capture.c:375: Test failed: Position 39840 expected 3360 capture.c:484: Device position -1 pad 0 flags abadcafe, amount of frames locked: 0 capture.c:544: Device position 55680 pad 16800 flags 0, amount of frames locked: 480 capture.c:552: Test failed: Position 55680 expected 0 capture.c:590: GetBufferSize 23941 period size 480 capture.c:599: Device position 56640 pad 23941 flags 1, amount of frames locked: 480 capture.c:605: Test failed: Position 56640 expected 480 capture.c:1020: Test failed: Master volume wasn't 1: 0.199526 capture: 302 tests executed (0 marked as todo, 10 failures), 0 skipped. mmdevapi_test64.exe capture capture.c:663: Returned periods: 10. ms 3. ms capture.c:675: pwfx: 0058BD80 capture.c:676: Tag: fffe capture.c:677: bits: 32 capture.c:678: chan: 2 capture.c:679: rate: 48000 capture.c:680: align: 8 capture.c:681: extra: 22 capture.c:686: Res: 32 capture.c:687: Mask: 3 capture.c:688: Alg: FLOAT capture.c:713: Test failed: IsFormatSupported(0x) call returns 88890008 capture.c:745: Returned latency: 5. ms capture.c:175: Device position -1 pad 0 flags abadcafe, amount of frames locked: 0 capture.c:235: Device position 0 pad 16800 flags 1, amount of frames locked: 480 capture.c:281: GetBufferSize 23941 period size 480 capture.c:290: Device position 960 pad 23941 flags 1, amount of frames locked: 480 capture.c:298: Test failed: Position 960 expected 480 capture.c:312: Device position 1440 pad 23461 flags 0, amount of frames locked:480 capture.c:333: Device position 1920 pad 23461 flags 0, amount of frames locked:480 capture.c:356: Test failed: Valid IAudioCaptureClient_GetBuffer returns 08890001 capture.c:357: Device position -1 pad 0 flags 0, amount of frames locked: 0 capture.c:372: Device position 37920 pad 0 flags 0, amount of frames locked: 480 capture.c:375: Test failed: Position 37920 expected 2400 capture.c:484: Device position -1 pad 0 flags abadcafe, amount of frames locked: 0 capture.c:544: Device position 53760 pad 16800 flags 0, amount of frames locked: 480 capture.c:552: Test failed: Position 53760 expected 0 capture.c:590: GetBufferSize 23941 period size 480 capture.c:599: Device position 54720 pad 23941 flags 1, amount of frames locked: 480 capture.c:605: Test failed: Position 54720 expected 480 capture: 301 tests executed (0 marked as todo, 6 failures), 0 skipped.
Re: mscoree: Implement DllGetClassObject
> I found if you used GetIUnknownForObject and then queried for the IDispatch > interface, mono returned E_NOINTERFACE. Maybe this is a bug with mono. If that's true, using IDispatch instead of IUnknown is probably not an acceptable work-around, as we don't know how that works when a class explicitly implements a non-IDispatch interface that the caller requests. It sounds like a mono bug to me, but it needs a testcase.
Re: Rethinking WineConf
Am Dienstag, 10. Januar 2012, 23:00:38 schrieb Marcus Meissner: > - Users ... as this was brought up > > Reality check: Wine users will not travel 100s of kms to a standalone > conference. > > This would make sense only if we attach wineconf to another general > conference An unconventional thought crossed my mind: Attach it to one of those gigantic Lan parties like the DreamHack. A big number of private users are gamers, this might catch some of them. Of course we can't simultanously attach it to a Lan party and a classic conference, but we can variate things over the years.
Re: [PATCH 3/5] d3d9: Don't expose wined3d internal flags to the application.
Henri Verbeet writes: > Yeah, I don't usually run the d3dx9 tests, I should probably add them. > Please use the attached patch instead. When sending an updated patch like this, could you please send to wine-patches so that it goes into the patch tracker? That makes it easier for me to handle. Thanks. -- Alexandre Julliard julli...@winehq.org
Re: [PATCH 3/5] d3d9: Don't expose wined3d internal flags to the application.
On 2012-01-11 14:31, Alexandre Julliard wrote:
> Henri Verbeet writes:
>
>> ---
>> dlls/d3d9/buffer.c|4 ++--
>> dlls/d3d9/cubetexture.c |2 +-
>> dlls/d3d9/surface.c |2 +-
>> dlls/d3d9/texture.c |2 +-
>> dlls/d3d9/volume.c|2 +-
>> dlls/d3d9/volumetexture.c |2 +-
>> 6 files changed, 7 insertions(+), 7 deletions(-)
>
> This is causing test failures:
>
> ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p
> d3dx9_36_test.exe.so mesh.c && touch mesh.ok
> mesh.c:331: Test succeeded inside todo block: Test createmesh1, result 0,
> expected 0
> mesh.c:331: Test succeeded inside todo block: Test createmesh2, result 0,
> expected 0
> mesh.c:331: Test succeeded inside todo block: Test createmeshfvf, result 0,
> expected 0
> mesh.c:2497: Tests skipped: D3DXCreateBox failed
> mesh.c:331: Test succeeded inside todo block: Test sphere (0, 2, 2), result
> 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test sphere (1, 2, 2), result
> 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test sphere (1, 3, 2), result
> 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test sphere (1, 4, 4), result
> 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test sphere (1, 3, 4), result
> 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test sphere (5, 6, 7), result
> 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test sphere (10, 11, 12),
> result 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test cylinder (0, 0, 0, 2, 1),
> result 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test cylinder (1, 1, 1, 2, 1),
> result 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test cylinder (1, 1, 2, 3, 4),
> result 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test cylinder (3, 2, 4, 3, 4),
> result 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test cylinder (2, 3, 4, 3, 4),
> result 0, expected 0
> mesh.c:331: Test succeeded inside todo block: Test cylinder (3, 4, 5, 11,
> 20), result 0, expected 0
> mesh.c:3679: Test succeeded inside todo block: Test text ('wine',
> 340282346638528859811704183484516925440.00, 0.40), result 0, expected > 0
> mesh.c:3679: Test succeeded inside todo block: Test text ('wine', 0.001000,
> 0.00), result 0, expected 0
> mesh.c:3679: Test succeeded inside todo block: Test text ('wine', 0.001000,
> 0.00), result 0, expected 0
> mesh.c:3679: Test succeeded inside todo block: Test text ('wine', 0.001000,
> 340282346638528859811704183484516925440.00), result 0, expected 0
> mesh.c:3679: Test succeeded inside todo block: Test text ('wine', 0.00,
> 1.00), result 0, expected 0
> make: *** [mesh.ok] Error 21
>
Yeah, I don't usually run the d3dx9 tests, I should probably add them.
Please use the attached patch instead.
0003-d3d9-Don-t-expose-wined3d-internal-flags-to-the-appl.patch
Description: application/text
Re: [PATCH 3/5] d3d9: Don't expose wined3d internal flags to the application.
Henri Verbeet writes:
> ---
> dlls/d3d9/buffer.c|4 ++--
> dlls/d3d9/cubetexture.c |2 +-
> dlls/d3d9/surface.c |2 +-
> dlls/d3d9/texture.c |2 +-
> dlls/d3d9/volume.c|2 +-
> dlls/d3d9/volumetexture.c |2 +-
> 6 files changed, 7 insertions(+), 7 deletions(-)
This is causing test failures:
../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p
d3dx9_36_test.exe.so mesh.c && touch mesh.ok
mesh.c:331: Test succeeded inside todo block: Test createmesh1, result 0,
expected 0
mesh.c:331: Test succeeded inside todo block: Test createmesh2, result 0,
expected 0
mesh.c:331: Test succeeded inside todo block: Test createmeshfvf, result 0,
expected 0
mesh.c:2497: Tests skipped: D3DXCreateBox failed
mesh.c:331: Test succeeded inside todo block: Test sphere (0, 2, 2), result 0,
expected 0
mesh.c:331: Test succeeded inside todo block: Test sphere (1, 2, 2), result 0,
expected 0
mesh.c:331: Test succeeded inside todo block: Test sphere (1, 3, 2), result 0,
expected 0
mesh.c:331: Test succeeded inside todo block: Test sphere (1, 4, 4), result 0,
expected 0
mesh.c:331: Test succeeded inside todo block: Test sphere (1, 3, 4), result 0,
expected 0
mesh.c:331: Test succeeded inside todo block: Test sphere (5, 6, 7), result 0,
expected 0
mesh.c:331: Test succeeded inside todo block: Test sphere (10, 11, 12), result
0, expected 0
mesh.c:331: Test succeeded inside todo block: Test cylinder (0, 0, 0, 2, 1),
result 0, expected 0
mesh.c:331: Test succeeded inside todo block: Test cylinder (1, 1, 1, 2, 1),
result 0, expected 0
mesh.c:331: Test succeeded inside todo block: Test cylinder (1, 1, 2, 3, 4),
result 0, expected 0
mesh.c:331: Test succeeded inside todo block: Test cylinder (3, 2, 4, 3, 4),
result 0, expected 0
mesh.c:331: Test succeeded inside todo block: Test cylinder (2, 3, 4, 3, 4),
result 0, expected 0
mesh.c:331: Test succeeded inside todo block: Test cylinder (3, 4, 5, 11, 20),
result 0, expected 0
mesh.c:3679: Test succeeded inside todo block: Test text ('wine',
340282346638528859811704183484516925440.00, 0.40), result 0, expected 0
mesh.c:3679: Test succeeded inside todo block: Test text ('wine', 0.001000,
0.00), result 0, expected 0
mesh.c:3679: Test succeeded inside todo block: Test text ('wine', 0.001000,
0.00), result 0, expected 0
mesh.c:3679: Test succeeded inside todo block: Test text ('wine', 0.001000,
340282346638528859811704183484516925440.00), result 0, expected 0
mesh.c:3679: Test succeeded inside todo block: Test text ('wine', 0.00,
1.00), result 0, expected 0
make: *** [mesh.ok] Error 21
--
Alexandre Julliard
julli...@winehq.org
Re: httpapi: add method stub for HttpAddUrl()
On 11 January 2012 12:56, Nikolay Sivov wrote:
> On 1/11/2012 13:41, Arash Cordi wrote:
>
>> +
>> +ULONG WINAPI HttpAddUrl( HANDLE handle, PCWSTR url, PVOID reserved )
>> +{
>> + FIXME( "(%p %p %p): stub!\n", handle, url, reserved);
>> + return ERROR_CALL_NOT_IMPLEMENTED;
>> +}
>> +
>
> Please use %s format for 'url' so it will be visible in logs.
>
But note that you need debugstr_w() as well in that case.
Re: [PATCH 1/5] ddraw/tests: Add some clipper tests.
On 7 January 2012 10:47, Saulius Krasuckas wrote: > These tests fail on real machines (running XP and w7) with nVidia cards > (FX5200 and GF 310M): > > http://test.winehq.org/data/b00e7039c5fcaa613b9776a38fe60bb697146b42/index_XP.html#ddraw:ddraw1 > http://test.winehq.org/data/a86b765a50cdf76e66c8993977f892d825f52ec0/index_Win7.html#ddraw:ddraw1 > > On XP + FX5200 the first three tests (dd1, dd2, dd4) generates crash with > failing hr = 0x8876021c. > > The other cases just fail by some color matches. > Does the attached patch make it any better? patch.diff Description: application/pgp-keys
Re: What other conferences do Wine people attend?
On Tue, Jan 10, 2012 at 02:55:33PM -0800, Dan Kegel wrote: > In the wineconf thread, the question came up: > What other conferences people do wine developers/users attend, if any? > > If you send me the names of the conference(s) you attended in the last > two years, > I'll summarize for the list. not much I go voluntary to. LinuxTag Berlin FOSDEM Brussels perhaps was at LinuxCon prague by chance only this year. Ciao, Marcus
Re: httpapi: add method stub for HttpAddUrl()
On 1/11/2012 13:41, Arash Cordi wrote:
+
+ULONG WINAPI HttpAddUrl( HANDLE handle, PCWSTR url, PVOID reserved )
+{
+FIXME( "(%p %p %p): stub!\n", handle, url, reserved);
+return ERROR_CALL_NOT_IMPLEMENTED;
+}
+
Please use %s format for 'url' so it will be visible in logs.
Re: cryptui: Use the same capitalization for the same string
On Wed, 11 Jan 2012, Francois Gouget wrote: [...] > Group box labels are supposed to use sentence-style capitalization: > http://msdn.microsoft.com/en-us/library/aa511459.aspx > > But dialog box titles are supposed to use title-style capitalization, > hence the case difference: > http://msdn.microsoft.com/en-us/library/aa511268.aspx#titles One more precision though: capitalization rules are language-specific and often poorly or completely undocumented for anything but English. For instance, from memory, the Gnome Interface Guidelines, which are written in English, specify that buttons must use title-style capitalization. However in French the rule is that everything uses sentence-style capitalization. So what I wrote in my previous email only applies to English and translators will need to figure out on their own what is appropriate for their language. -- Francois Gouget http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service
Re: mscoree: Implement DllGetClassObject
Hi Vincent, On 11/01/2012 5:13 PM, Vincent Povirk wrote: You can't just use a static class factory for all the classes. There's no need for GetIDispatchForObject when we already have GetIUnknownForObject (and all you use is QueryInterface). I found if you used GetIUnknownForObject and then queried for the IDispatch interface, mono returned E_NOINTERFACE. Maybe this is a bug with mono. +res = RegGetValueA( key, NULL, "Class", RRF_RT_REG_SZ, NULL, classname,&dwBufLen); We should probably use a W function here and convert to utf8, rather than assume that's the default encoding. I'll give it a go. Best Regards Alistair Leslie-Hughes
Vista/w2k8/w7 users, please test mmdevapi capture
Hi, you don't need a microphone, just a capture capable sound card, unlike testbot. Please download mmdevapi_test32|64.exe from testbot: http://testbot.winehq.org/JobDetails.pl?Key=16376 run: mmdevapi_test capture and post or send me the results -- not just the failures, the console output too including position/padding/flags. Don't be afraid of some test failures in lines 300-499. I'm still investigating underrun and start/stop/reset behaviour. Thank you for testing, Jörg Höhle
Re: cryptui: Use the same capitalization for the same string
On Tue, 10 Jan 2012, André Hentschel wrote: > So that the string needs only one translation in po files - GROUPBOX "Certification path", -1,6,10,245,165, BS_GROUPBOX + GROUPBOX "Certification Path", -1,6,10,245,165, BS_GROUPBOX Unfortunately this goes against the Windows User Experience Interaction Guidelines. Group box labels are supposed to use sentence-style capitalization: http://msdn.microsoft.com/en-us/library/aa511459.aspx But dialog box titles are supposed to use title-style capitalization, hence the case difference: http://msdn.microsoft.com/en-us/library/aa511268.aspx#titles Glossary: * Sentence-style capitalization http://msdn.microsoft.com/en-us/library/aa511441.aspx#SentenceCaps * Title-style capitalization http://msdn.microsoft.com/en-us/library/aa511441.aspx#TitleCaps -- Francois Gouget http://fgouget.free.fr/ E-Voting: Those who cast the votes decide nothing. Those who count the votes decide everything.
