Re: [3/4] windowscodecs: Implement Image Descriptor metadata reader.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21584 Your paranoid android. === WINEBUILD (build) === Patch failed to apply
Re: [4/4] windowscodecs: Implement Graphic Control Extension metadata reader.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21585 Your paranoid android. === WINEBUILD (build) === Patch failed to apply
Re: [PATCH] advapi32: Eliminate dead stores (Clang).
Charles Davis cdavi...@gmail.com writes: @@ -615,9 +613,9 @@ static DWORD mac_write_credential(const CREDENTIALW *credential, BOOL preserve_b attr_list.count = 0; attr_list.attr = NULL; } -status = SecKeychainItemModifyAttributesAndData(keychain_item, attr_list, -preserve_blob ? 0 : strlen(password), -preserve_blob ? NULL : password); +SecKeychainItemModifyAttributesAndData(keychain_item, attr_list, + preserve_blob ? 0 : strlen(password), + preserve_blob ? NULL : password); I expect you'd want to handle that error instead. -- Alexandre Julliard julli...@winehq.org
Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
On 14.09.2012 11:07, Nozomi Kodama wrote:
Hello
one remark about this patch.
Test in real windows shows that D3DXSHEvalDirectionalLight accepts order
D3DXSH_MAXORDER or order D3DXSH_MINORDER.
But in these cases, the colour outputs are unpredictable. For the same
calling arguments, D3DSXHEvalDirectionalLight returns different colours.
That explains the simplicity of the implementation of this function.
Nozomi.
+FLOAT s, temp[max( 1, order * order )];
Is this allowed in c and does it really work the way one would expect?
+for (order = D3DXSH_MINORDER; order = D3DXSH_MAXORDER; order++)
...
+if ( ( order == 0 ) || ( j = order * order ) )
Why would you check for order == 0? That's imho never the case that this
is true. At least if you only test from D3DXSH_MINORDER onward.
+unsigned int j, order, start[] = {0, 4, 13, 29, 54};
Using the start[] looks a bit ugly ... why don't you calculate the index?
+expected = table[start[order - 2] + j];!
You've again trailing white spaces.
What happens in the following test case? Which result is returned?
D3DXSHEvalDirectionalLight(order, dir, 1.7f, 2.6f, 3.5f, rout, rout, rout);
Well the implementation seems to be correct, but it may be nice to test
for this as well. Maybe in another patch.
Cheers
Rico
Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).
Sergey Guralnik ser...@etersoft.ru writes: I've sent next patch more than month ago, and have no comments about it. From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik ser...@etersoft.ru Date: Thu, 9 Aug 2012 17:12:56 +0400 Subject: user32/tests: Add test for SetFocus() (with few todo)(Try 2). Is anything wrong with this one? That's mostly testing the window manager focus policy, I don't think that makes sense. What are you trying to demonstrate with this? -- Alexandre Julliard julli...@winehq.org
Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
On 14 September 2012 14:04, Rico Schüller kgbric...@web.de wrote: +FLOAT s, temp[max( 1, order * order )]; Is this allowed in c and does it really work the way one would expect? It is in C99 (look into VLAs), but Wine doesn't allow C99 features.
