Re: d3dx9: Specify arguments in trace to ease debugging

2013-02-15 Thread Alexandre Julliard 
Nozomi Kodama  writes:

> Hello.
>
> I took advantage of this minor patch to clean up and  make uniform the
> coding style of this file.

Please don't do that.

-- 
Alexandre Julliard
julli...@winehq.org

Re: d3dx9: Specify arguments in trace to ease debugging

2013-02-15 Thread Rico Schüller 

On 15.02.2013 08:20, Nozomi Kodama wrote:

@@ -721,9 +739,10 @@ D3DXMATRIX* WINAPI D3DXMatrixTransformation(D3DXMATRIX 
*pout, const D3DXVECTOR3

@@ -797,69 +821,70 @@ D3DXMATRIX* WINAPI D3DXMatrixTransformation2D(D3DXMATRIX 
*pout, const D3DXVECTOR
Those two functions need a speed improvement. Normally we change only 
the code (and it's style) if we touch that area. I'm not a fan of 
changing that in one go in a huge patch, as it might introduce new 
mistakes, see below. I'm not sure if I caught all issues.



+rot.w = cos(rotation/2.0f);

rot.w = cos(rotation / 2.0f);



-TRACE("iface %p\n", iface);
+TRACE("iface %p, %pm\n", iface, pm);

Typo.


+TRACE("iface %p, x %f, y %f, z %f\n", iface, x, y, z);

+TRACE("(pout %p, pvpoint %p, pvnormal %p)\n", pout, pvpoint, pvnormal);

Well, I would use the same style for both... I'd prefer the first one.

Cheers
Rico