Re: gdi32: Tests for the codepages supported by TranslateCharsetInfo

2010-01-27 Thread Dmitry Timoshkov
Ilya Shpigor  wrote:

> +static void test_TranslateCharsetInfo(void)
> +{
> +/* Any other codepages are not supported
> + * by TranslateCharsetInfo in Windows XP
> + */
> +test_codepage(42, 2);
> +test_codepage(874, 222);
> +test_codepage(932, 128);
> +test_codepage(936, 134);
> +test_codepage(949, 129);
> +test_codepage(950, 136);
> +test_codepage(1250, 238);
> +test_codepage(1251, 204);
> +test_codepage(1252, 0);
> +test_codepage(1253, 161);
> +test_codepage(1254, 162);
> +test_codepage(1255, 177);
> +test_codepage(1256, 178);
> +test_codepage(1257, 186);
> +test_codepage(1258, 163);
> +test_codepage(1361, 130);

It would be better to create a table and run the tests in the loop,
use symbolic charset names, and actually test some codepages which
would fail.

-- 
Dmitry.




Re: gdi32: Tests for the codepages supported by TranslateCharsetInfo

2010-01-27 Thread Paul Vriens

On 01/27/2010 11:01 AM, Ilya Shpigor wrote:




Hi Ilya,

These tests introduce failures on Win9x/NT4:

https://winetestbot.geldorp.nl/JobDetails.pl?Key=456

It would maybe be worthwhile to add some more info to the traces by 
using __LINE__ for example (see examples in other tests).


You can request an account on this winetestbot so you can check other 
platforms yourself if needed.


--
Cheers,

Paul.