Re: kernel32/tests: initial tests for cdrom.c
Francois Gouget asked: Are there tests that are impossible if there is a CD in the drive? Some tests combinations. I believe Dan's tests want a DVD, whereas mcicda expects audio CD-ROMs. Either you play disk jockey while running the tests, or some tests will be skipped. Note that mcicda will skip some tests unless you use a mixed audio+data CD-ROM. Few people have those. An audio only CD-ROM will not run all tests. The mcicda testsuite is known to skip correctly when no disk or a DVD is inserted. Anything else is a regression. Regards, Jörg Höhle
Re: kernel32/tests: initial tests for cdrom.c
On Fri, 10 Feb 2012, joerg-cyril.hoe...@t-systems.com wrote: Dan Kegel wrote: These require a DVD in the drive, so they are skipped without WINETEST_INTERACTIVE=1. I don't see the causality. Presumably the tests require no human intervention. winmm/tests/mcicda also skips tests if no CD-ROM is in the bay. However, even a regular winetest.exe run *will* run as many tests as it can should it find a CD-ROM. Users are invited to submit test results to test.winehq with audio and/or mixed data CD-ROMs in the drive. Any such instructions on how to run WineTest should be mentioned on the page below, which is not the case here: http://wiki.winehq.org/ConformanceTests Are there tests that are impossible if there is a CD in the drive? -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm
kernel32/tests: initial tests for cdrom.c
Dan Kegel wrote: These require a DVD in the drive, so they are skipped without WINETEST_INTERACTIVE=1. I don't see the causality. Presumably the tests require no human intervention. winmm/tests/mcicda also skips tests if no CD-ROM is in the bay. However, even a regular winetest.exe run *will* run as many tests as it can should it find a CD-ROM. Users are invited to submit test results to test.winehq with audio and/or mixed data CD-ROMs in the drive. There's no need for winetest_interactive here. Regards, Jörg Höhle
Re: [PATCH 4/7] kernel32/tests: initial tests for cdrom.c (try 2)
On Feb 10, 2012, at 1:30 PM, Dan Kegel wrote:
+START_TEST(cdrom)
+{
[...]
+/* GENERIC_WRITE because without it, passthrough doesn't work on win7 */
But with it, you can't open the device at all on Mac. As I explained on bug
29669, the device file only has 0440 access.
Chip
