Re: programs/extrac32: The debug channel is not used, remove it.

2009-10-26 Thread Andrey Turkin
Don't do this please, initial part was just submitted, the channel will 
be used once other parts are in place.


Francois Gouget wrote:

---
 programs/extrac32/extrac32.c |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/programs/extrac32/extrac32.c b/programs/extrac32/extrac32.c
index 7e8fbed..4e53af9 100644
--- a/programs/extrac32/extrac32.c
+++ b/programs/extrac32/extrac32.c
@@ -21,9 +21,7 @@
 #include windows.h
 
 #include wine/unicode.h

-#include wine/debug.h
 
-WINE_DEFAULT_DEBUG_CHANNEL(extrac32);
 
 int PASCAL wWinMain(HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show)

 {
  






Re: programs/extrac32: The debug channel is not used, remove it.

2009-10-26 Thread Jerome Leclanche
I'm unsure programs themselves should use Wine's debug channels, either way.

J. Leclanche / Adys



On Mon, Oct 26, 2009 at 10:35 AM, Andrey Turkin andrey.tur...@gmail.com wrote:
 Don't do this please, initial part was just submitted, the channel will be
 used once other parts are in place.

 Francois Gouget wrote:

 ---
  programs/extrac32/extrac32.c |    2 --
  1 files changed, 0 insertions(+), 2 deletions(-)

 diff --git a/programs/extrac32/extrac32.c b/programs/extrac32/extrac32.c
 index 7e8fbed..4e53af9 100644
 --- a/programs/extrac32/extrac32.c
 +++ b/programs/extrac32/extrac32.c
 @@ -21,9 +21,7 @@
  #include windows.h
   #include wine/unicode.h
 -#include wine/debug.h
  -WINE_DEFAULT_DEBUG_CHANNEL(extrac32);
   int PASCAL wWinMain(HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline,
 int show)
  {









Re: programs/extrac32: The debug channel is not used, remove it.

2009-10-26 Thread Andrey Turkin

Virtually any Wine program uses it (even winemine) so why not?

Jerome Leclanche wrote:

I'm unsure programs themselves should use Wine's debug channels, either way.

J. Leclanche / Adys



On Mon, Oct 26, 2009 at 10:35 AM, Andrey Turkin andrey.tur...@gmail.com wrote:
  

Don't do this please, initial part was just submitted, the channel will be
used once other parts are in place.