[Wireshark-commits] master 89c24ee: [ieee80211] Cleanup
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=89c24ee8e8086dc88042d9f048479487b342702e Submitter: Bill Meier (wme...@newsguy.com) Changed: branch: master Repository: wireshark Commits: 89c24ee by Bill Meier (wme...@newsguy.com): [ieee80211] Cleanup Primarily: Call fixed_field functions directly instead of doing a linear search by "function number" in a large table of dissector addresses to determine the function address for each function call. As part of this change, the order of certain fixed_field functions was changed to fix any forward references. Also: Spelling Whitespace Change-Id: I9bb7e239086f9b65044929f2cb7e7f9d9b9adaee Reviewed-on: https://code.wireshark.org/review/9563 Reviewed-by: Bill Meier Actions performed: from ccdd4be GSM A RR: fix GSM H/L bits management adds 89c24ee [ieee80211] Cleanup Summary of changes: epan/dissectors/packet-ieee80211.c | 3013 +--- 1 file changed, 1443 insertions(+), 1570 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master f96a592: Revert "[ieee80211] Cleanup"
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f96a5923c3958b663b0befb5720e53359295ccc8 Submitter: Bill Meier (wme...@newsguy.com) Changed: branch: master Repository: wireshark Commits: f96a592 by Bill Meier (wme...@newsguy.com): Revert "[ieee80211] Cleanup" This reverts commit 89c24ee8e8086dc88042d9f048479487b342702e. Further investigation of unused functions required Change-Id: I0c015cf067eaa0ce5bdafa0bce29bed373e9a82f Reviewed-on: https://code.wireshark.org/review/9565 Reviewed-by: Bill Meier Actions performed: from 89c24ee [ieee80211] Cleanup adds f96a592 Revert "[ieee80211] Cleanup" Summary of changes: epan/dissectors/packet-ieee80211.c | 3011 +++- 1 file changed, 1569 insertions(+), 1442 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 6a35ee3: dapp: cleanup, make elements filterable
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a35ee33efe18f4159bc99fb64fd1669ace23007 Submitter: Martin Kaiser (wiresh...@kaiser.cx) Changed: branch: master Repository: wireshark Commits: 6a35ee3 by Martin Kaiser (wiresh...@kaiser.cx): dapp: cleanup, make elements filterable don't squeeze all info into the subtree title remove an unnecessary THROW() Change-Id: I542f220d9d786d0fa879a0b2fe4549ffa1ca87af Reviewed-on: https://code.wireshark.org/review/9544 Reviewed-by: Martin Kaiser Actions performed: from f96a592 Revert "[ieee80211] Cleanup" adds 6a35ee3 dapp: cleanup, make elements filterable Summary of changes: epan/dissectors/packet-daap.c | 568 ++--- 1 file changed, 305 insertions(+), 263 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 5c8b92c: Make sure we get the Qt tools for the Qt version with which we're building.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c8b92c28b08d439b080232c2c686a11a15a5f39 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 5c8b92c by Guy Harris (g...@alum.mit.edu): Make sure we get the Qt tools for the Qt version with which we're building. For example, Qt 4's uic produces .h files that don't compile with Qt 5, as they use header #include paths that work with Qt 4's headers but not Qt 5's headers. Change-Id: I50c7bd15fca05475180a933a6c77955dc686c0c5 Reviewed-on: https://code.wireshark.org/review/9567 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris Actions performed: from 6a35ee3 dapp: cleanup, make elements filterable adds 5c8b92c Make sure we get the Qt tools for the Qt version with which we're building. Summary of changes: acinclude.m4 | 248 ++ configure.ac | 93 ++ 2 files changed, 208 insertions(+), 133 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master e312d41: GTK+: Add a Telephony/ANSI menu placeholder.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e312d418831c2f1cbb256584550b2c6ff765b7bc Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: e312d41 by Gerald Combs (ger...@wireshark.org): GTK+: Add a Telephony/ANSI menu placeholder. Add REGISTER_STAT_GROUP_TELEPHONY_ANSI as well, and use it to add recently updated stats. Make sure we properly escape our path separators. Change-Id: I979d5c29a82acddec1a9bcae7e3cb9c5ea3f9d33 Reviewed-on: https://code.wireshark.org/review/9564 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs Actions performed: from 5c8b92c Make sure we get the Qt tools for the Qt version with which we're building. adds e312d41 GTK+: Add a Telephony/ANSI menu placeholder. Summary of changes: asn1/ansi_map/packet-ansi_map-template.c |4 ++-- epan/dissectors/packet-ansi_a.c |8 epan/dissectors/packet-ansi_map.c|4 ++-- epan/stat_groups.h |1 + ui/gtk/main_menubar.c| 10 +++--- ui/gtk/tap_param_dlg.c | 15 ++- 6 files changed, 30 insertions(+), 12 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 131e0ab: Handle setModule(NULL) more safely.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=131e0ab7ea461d519f0fbe80b03aa6bc99b9d452 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 131e0ab by Guy Harris (g...@alum.mit.edu): Handle setModule(NULL) more safely. If module_name is null, we can't do much of anything - we don't have a protocol ID, so we don't have a protocol. Change-Id: I42c2fa4b47e39d7ac122c60be91b5d408bf30a1d Reviewed-on: https://code.wireshark.org/review/9569 Reviewed-by: Guy Harris Actions performed: from e312d41 GTK+: Add a Telephony/ANSI menu placeholder. adds 131e0ab Handle setModule(NULL) more safely. Summary of changes: ui/qt/protocol_preferences_menu.cpp |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master a8faa04: Qt: Add dynamic menu support.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8faa04234a5ac07c37da41d42ed943e8ebf5406 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: a8faa04 by Gerald Combs (ger...@wireshark.org): Qt: Add dynamic menu support. Generalize the dynamic menu code and make it possible to connect multiple types of actions to their corresponding slots. Change-Id: Ib915ad5a666310e2a6e366fada006336820d1653 Reviewed-on: https://code.wireshark.org/review/9568 Reviewed-by: Gerald Combs Actions performed: from 131e0ab Handle setModule(NULL) more safely. adds a8faa04 Qt: Add dynamic menu support. Summary of changes: epan/stat_groups.h |2 +- ui/qt/funnel_statistics.cpp |4 +- ui/qt/funnel_statistics.h |2 + ui/qt/main_window.cpp | 147 ++- ui/qt/main_window.h |3 +- ui/qt/main_window.ui| 15 ui/qt/tap_parameter_dialog.cpp |4 +- ui/qt/tap_parameter_dialog.h|2 + ui/qt/wireshark_application.cpp | 35 +++--- ui/qt/wireshark_application.h |7 +- 10 files changed, 122 insertions(+), 99 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 9cb2f76: ARP: Remove double space before Tell
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9cb2f76ed3c38067ffa4bc81b3d5be8b9d42ecdb Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 9cb2f76 by Alexis La Goutte (alexis.lagou...@gmail.com): ARP: Remove double space before Tell Change-Id: I5d8f79e01912c010ca74a0134a0f397c62f1e106 Reviewed-on: https://code.wireshark.org/review/9556 Reviewed-by: Michael Mann Actions performed: from a8faa04 Qt: Add dynamic menu support. adds 9cb2f76 ARP: Remove double space before Tell Summary of changes: epan/dissectors/packet-arp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master d88639c: qt_ui_utils.h: fix empty paragraph passed to '@return' command [-Wdocumentation]
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d88639cb4a9bfd630915f793015a869af93372b4 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: d88639c by Alexis La Goutte (alexis.lagou...@gmail.com): qt_ui_utils.h: fix empty paragraph passed to '@return' command [-Wdocumentation] Change-Id: I120ed85ee88253084646db4817ae77a8c90492f2 Reviewed-on: https://code.wireshark.org/review/9557 Reviewed-by: Michael Mann Actions performed: from 9cb2f76 ARP: Remove double space before Tell adds d88639c qt_ui_utils.h: fix empty paragraph passed to '@return' command [-Wdocumentation] Summary of changes: ui/qt/qt_ui_utils.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master ac7a465: main_window(.h): fix parameter 'menu_path' not found in the function declaration [-Wdocumentation]
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac7a46505fbebe433b1cbc8fc348684079fd3d4b Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: ac7a465 by Alexis La Goutte (alexis.lagou...@gmail.com): main_window(.h): fix parameter 'menu_path' not found in the function declaration [-Wdocumentation] Change-Id: I98a9388f44fe38261fde5422ac821fbb6c1d993c Reviewed-on: https://code.wireshark.org/review/9553 Reviewed-by: Alexis La Goutte Reviewed-by: Michael Mann Actions performed: from d88639c qt_ui_utils.h: fix empty paragraph passed to '@return' command [-Wdocumentation] adds ac7a465 main_window(.h): fix parameter 'menu_path' not found in the function declaration [-Wdocumentation] Summary of changes: ui/qt/main_window.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 7b85f62: service_response_time_dialog/response_time_delay_dialog(.h): fix '@return' command used in a comment that is attached to a function returning void [-Wdocumentation]
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b85f62ba3fe95e20004c31165c989a4fd29beb3 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 7b85f62 by Alexis La Goutte (alexis.lagou...@gmail.com): service_response_time_dialog/response_time_delay_dialog(.h): fix '@return' command used in a comment that is attached to a function returning void [-Wdocumentation] Change-Id: I84682651f40ab9e8f54a6ae656d0670096b5a3bc Reviewed-on: https://code.wireshark.org/review/9559 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Michael Mann Actions performed: from ac7a465 main_window(.h): fix parameter 'menu_path' not found in the function declaration [-Wdocumentation] adds 7b85f62 service_response_time_dialog/response_time_delay_dialog(.h): fix '@return' command used in a comment that is attached to a function returning void [-Wdocumentation] Summary of changes: ui/qt/response_time_delay_dialog.h |1 - ui/qt/service_response_time_dialog.h |1 - 2 files changed, 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 281055a: Lua: add functions for more field information
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=281055af9ccdd701ba18accb39f3d25ab77168df Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master Repository: wireshark Commits: 281055a by Hadriel Kaplan (hadri...@yahoo.com): Lua: add functions for more field information Add Lua functions so a plugin can introspect field information, such as the type of field, flags, tvb, etc. Also add a couple of Tvb and ByteArray methods. And cleanup the TreeItem code a little. Change-Id: I7b58ce589ace91cce14b8abccd01ceabb63e2653 Reviewed-on: https://code.wireshark.org/review/6500 Petri-Dish: Hadriel Kaplan Tested-by: Petri Dish Buildbot Reviewed-by: Hadriel Kaplan Tested-by: Hadriel Kaplan Actions performed: from 7b85f62 service_response_time_dialog/response_time_delay_dialog(.h): fix '@return' command used in a comment that is attached to a function returning void [-Wdocumentation] adds 281055a Lua: add functions for more field information Summary of changes: epan/wslua/init_wslua.c | 12 +-- epan/wslua/lrexlib.h |6 +- epan/wslua/lrexlib_glib.c |3 - epan/wslua/wslua.h|9 +- epan/wslua/wslua_field.c | 197 +++ epan/wslua/wslua_proto.c | 35 epan/wslua/wslua_tree.c | 203 + epan/wslua/wslua_tvb.c| 108 ++-- test/lua/field.lua| 34 9 files changed, 532 insertions(+), 75 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 7082b86: Clean up the "Build wireshark" message.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7082b86ab6bf125fffc7b50850a05b7304686f9a Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 7082b86 by Guy Harris (g...@alum.mit.edu): Clean up the "Build wireshark" message. Change-Id: I40883aee5207dd8a437fcde827386bd370fbe96c Reviewed-on: https://code.wireshark.org/review/9570 Reviewed-by: Guy Harris Actions performed: from 281055a Lua: add functions for more field information adds 7082b86 Clean up the "Build wireshark" message. Summary of changes: configure.ac |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 949ff7a: Update the release notes.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=949ff7a112d7728afea1039306f17dc78211bf29 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 949ff7a by Gerald Combs (ger...@wireshark.org): Update the release notes. Change-Id: I290cd22e46ac88401524781ea027bbc8200452a6 Reviewed-on: https://code.wireshark.org/review/9576 Reviewed-by: Gerald Combs Actions performed: from 7082b86 Clean up the "Build wireshark" message. adds 949ff7a Update the release notes. Summary of changes: docbook/release-notes.asciidoc | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master d36930e: HTTP2: fix dissection of traffic over HTTP port
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d36930e2d4a5118023182fd8ac3237e546436c87 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: d36930e by Pascal Quantin (pascal.quan...@gmail.com): HTTP2: fix dissection of traffic over HTTP port Bug: 11331 Change-Id: Ib85e18ebb3c958d68ee3a4295d35982ffcd375ee Reviewed-on: https://code.wireshark.org/review/9525 Reviewed-by: Pascal Quantin Actions performed: from 949ff7a Update the release notes. adds d36930e HTTP2: fix dissection of traffic over HTTP port Summary of changes: epan/dissectors/packet-http.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master fdd07c4: Make sure we uncheck the "Find Packet" action.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fdd07c4d3a5e7d83e235957dc731502770e709f1 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: fdd07c4 by Gerald Combs (ger...@wireshark.org): Make sure we uncheck the "Find Packet" action. Make sure we uncheck the "Find Packet" action when we're done finding packets. Make the "Go To Packet" action checkable and ensure that it's properly checked an unchecked as well. Change-Id: I979cabfd950ec4807ebcd40664b44b600557cf48 Reviewed-on: https://code.wireshark.org/review/9577 Reviewed-by: Gerald Combs Actions performed: from d36930e HTTP2: fix dissection of traffic over HTTP port adds fdd07c4 Make sure we uncheck the "Find Packet" action. Summary of changes: ui/qt/accordion_frame.h |5 + ui/qt/main_window.cpp |5 + ui/qt/main_window.ui|3 +++ ui/qt/search_frame.h|2 +- 4 files changed, 14 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 2a5a560: VXLAN: Add Group Based Policy dissector
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a5a560a64e73832c6a91b4a3772ddbda0e7d5fb Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 2a5a560 by Amine Kherbouche (amine.kherbou...@6wind.com): VXLAN: Add Group Based Policy dissector According to some advices from my last commit,i made some changes, and i use proto_tree_add_bitmask for bits field. Editing VXLAN dissector for supporting GBP extension described in the following draft link : https://tools.ietf.org/html/draft-smith-vxlan-group-policy-00 This pach works fine with "old" version of VXLAN (no GBP support) The flags are now extended to 16 bits to support GBP extension, Group Policy Id is on 16 bits, VNI always on 24 bits and remaining bits are reserved. The following bits are defined in addition to the existing VXLAN fields: bit 0 : "G" Group Based Policy Extension bit bit 9 : "D" Don't Learn bit bit 12 : "A" Policy Applied bit the remaining bits are reserved Bug: 11348 Change-Id: I425ed63cf76f134eb3d1680a1753ed31f252dfa8 Signed-off-by: Amine Kherbouche Reviewed-on: https://code.wireshark.org/review/9537 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from fdd07c4 Make sure we uncheck the "Find Packet" action. adds 2a5a560 VXLAN: Add Group Based Policy dissector Summary of changes: epan/dissectors/packet-vxlan.c | 101 epan/dissectors/packet-wccp.c |2 +- epan/tfs.c |1 + epan/tfs.h |1 + 4 files changed, 44 insertions(+), 61 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 38e0477: Use tfs_defined_not_defined
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=38e0477a4e4d5792a75b8ec94515878189387c3e Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 38e0477 by Michael Mann (mman...@netscape.net): Use tfs_defined_not_defined Change-Id: Id9409109ffe667d1f8b3201792f7b4146b1f73f5 Reviewed-on: https://code.wireshark.org/review/9582 Reviewed-by: Michael Mann Actions performed: from 2a5a560 VXLAN: Add Group Based Policy dissector adds 38e0477 Use tfs_defined_not_defined Summary of changes: epan/dissectors/packet-ieee80211.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master b820d74: xip: add support for XIP packets
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b820d749bf1509bb8c098213e07d5f1ab9fcb75b Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: b820d74 by Cody Doucette (douce...@bu.edu): xip: add support for XIP packets The eXpressive Internet Protocol (XIP) is the network layer protocol for the eXpressive Internet Architecture (XIA), a future Internet architecture project. The addresses in XIP are directed acyclic graphs, so much of the code included in this addition verifies the correctness of the DAGs and displays them in human-readable form. Bug: 11265 Change-Id: I948aaa73b927f8afc162d89689d184c5657f60b1 Reviewed-on: https://code.wireshark.org/review/8881 Reviewed-by: Evan Huus Petri-Dish: Evan Huus Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from 38e0477 Use tfs_defined_not_defined adds b820d74 xip: add support for XIP packets Summary of changes: docbook/release-notes.asciidoc |1 + epan/CMakeLists.txt|1 + epan/dissectors/Makefile.common|1 + epan/dissectors/packet-ethertype.c |1 + epan/dissectors/packet-xip.c | 686 epan/etypes.h |4 + 6 files changed, 694 insertions(+) create mode 100644 epan/dissectors/packet-xip.c ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0aaf0f0: Add the "Resolved Addresses" dialog.
URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0aaf0f04cff9385984ce8966f95af0726355dbde
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark
Commits:
0aaf0f0 by Gerald Combs (ger...@wireshark.org):
Add the "Resolved Addresses" dialog.
The GTK+ equivalent is named "Address Resolution" but "Resolved
Addresses" seemed (to me at least) to be more clear.
Change-Id: I1806354d91bb5ce8af11d20568b92a04c78d4d73
Reviewed-on: https://code.wireshark.org/review/9580
Petri-Dish: Gerald Combs
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs
Actions performed:
from b820d74 xip: add support for XIP packets
adds 0aaf0f0 Add the "Resolved Addresses" dialog.
Summary of changes:
ui/qt/CMakeLists.txt |3 +
ui/qt/Makefile.am |2 +
ui/qt/Makefile.common |4 +
ui/qt/Wireshark.pro|3 +
ui/qt/accordion_frame.h| 13 +
ui/qt/main_window.h|1 +
ui/qt/main_window.ui |9 +
ui/qt/main_window_slots.cpp|7 +
ui/qt/resolved_addresses_dialog.cpp| 455
...{search_frame.h => resolved_addresses_dialog.h} | 66 +--
ui/qt/resolved_addresses_dialog.ui | 175
11 files changed, 706 insertions(+), 32 deletions(-)
create mode 100644 ui/qt/resolved_addresses_dialog.cpp
copy ui/qt/{search_frame.h => resolved_addresses_dialog.h} (50%)
create mode 100644 ui/qt/resolved_addresses_dialog.ui
___
Sent via:Wireshark-commits mailing list
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master d6631c6: Bugfix GTK RPC SRT dialog use of direct hashing.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d6631c62f959384807fa5f8a14391e8a50033a62 Submitter: Evan Huus (eapa...@gmail.com) Changed: branch: master Repository: wireshark Commits: d6631c6 by Michael Mann (mman...@netscape.net): Bugfix GTK RPC SRT dialog use of direct hashing. Change-Id: I3db6ee3e6c5cb79b9cc31068930c9fe9c9d8aa7a Reviewed-on: https://code.wireshark.org/review/9581 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Evan Huus Actions performed: from 0aaf0f0 Add the "Resolved Addresses" dialog. adds d6631c6 Bugfix GTK RPC SRT dialog use of direct hashing. Summary of changes: ui/gtk/rpc_stat.c |8 1 file changed, 4 insertions(+), 4 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master f6a4826: LTE RRC: upgrade dissector to v12.6.0
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f6a482656b0b0931e72136565980bed04db45c31 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: f6a4826 by Pascal Quantin (pascal.quan...@gmail.com): LTE RRC: upgrade dissector to v12.6.0 Change-Id: I6e8271f98cba0074b27df73a21337d388efcdc7a Reviewed-on: https://code.wireshark.org/review/9578 Reviewed-by: Pascal Quantin Actions performed: from d6631c6 Bugfix GTK RPC SRT dialog use of direct hashing. adds f6a4826 LTE RRC: upgrade dissector to v12.6.0 Summary of changes: asn1/lte-rrc/EUTRA-InterNodeDefinitions.asn |2 +- asn1/lte-rrc/EUTRA-RRC-Definitions.asn | 39 -- asn1/lte-rrc/EUTRA-Sidelink-Preconf.asn |2 +- asn1/lte-rrc/EUTRA-UE-Variables.asn |2 +- asn1/lte-rrc/PC5-RRC-Definitions.asn|2 +- asn1/lte-rrc/packet-lte-rrc-template.c |2 +- epan/dissectors/packet-lte-rrc.c| 198 --- 7 files changed, 215 insertions(+), 32 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 4da081b: IEEE 802.11: tap all packets
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4da081b0d5a2a00011da633400b456296c39ddb3 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: 4da081b by Pascal Quantin (pascal.quan...@gmail.com): IEEE 802.11: tap all packets And only take into account management, non null data and or extension frames in WLAN traffic statistics, as previously Bug: 11318 Change-Id: I32c059a2594331c4e317380b9de43fb582f7f8cb Reviewed-on: https://code.wireshark.org/review/9566 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Pascal Quantin Actions performed: from f6a4826 LTE RRC: upgrade dissector to v12.6.0 adds 4da081b IEEE 802.11: tap all packets Summary of changes: epan/dissectors/packet-ieee80211.c |9 - ui/gtk/wlan_stat_dlg.c |7 +++ 2 files changed, 11 insertions(+), 5 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 52d04fd: Fix a typo
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=52d04fdc1ed19d4c234a77b08dcad28ab009d12a Submitter: J?rg Mayer (jma...@loplof.de) Changed: branch: master Repository: wireshark Commits: 52d04fd by Joerg Mayer (jma...@loplof.de): Fix a typo Change-Id: If608ef78526c1876cba7650b42eca1d9c9b4e817 Reviewed-on: https://code.wireshark.org/review/9586 Reviewed-by: Jörg Mayer Actions performed: from 4da081b IEEE 802.11: tap all packets adds 52d04fd Fix a typo Summary of changes: ui/qt/qcustomplot.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 76a450f: MPTCP small options
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76a450f573971cb4a8d614a7454c99febe90e45d Submitter: Alexis La Goutte (alexis.lagou...@gmail.com) Changed: branch: master Repository: wireshark Commits: 76a450f by Benjamin Hesmans (benjamin.hesm...@uclouvain.be): MPTCP small options The minimum length of MPTCP option is 3 (MP_PRIO) Signed-off-by: Benjamin Hesmans Change-Id: I9742a7923497b07b9a7c761b02d52ac541e28cc7 Reviewed-on: https://code.wireshark.org/review/9585 Reviewed-by: Alexis La Goutte Actions performed: from 52d04fd Fix a typo adds 76a450f MPTCP small options Summary of changes: epan/dissectors/packet-tcp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master aa839b3: wslua_tree: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa839b373608e559b0da8913a43b2eb5fb4939d3 Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master Repository: wireshark Commits: aa839b3 by Alexis La Goutte (alexis.lagou...@gmail.com): wslua_tree: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Change-Id: I2bbc4c0a76935367692a5fd382013cbd074754e0 Reviewed-on: https://code.wireshark.org/review/9588 Reviewed-by: Hadriel Kaplan Actions performed: from 76a450f MPTCP small options adds aa839b3 wslua_tree: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Summary of changes: epan/wslua/wslua_tree.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master a63f841: Netflow: Fix sequence analysis to work for different protocol versions
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a63f841fec2a7c0dd3d42f24a85fde0b447ee790 Submitter: Martin Mathieson (martin.r.mathie...@googlemail.com) Changed: branch: master Repository: wireshark Commits: a63f841 by Martin Mathieson (martin.r.mathie...@googlemail.com): Netflow: Fix sequence analysis to work for different protocol versions Change-Id: Iaf7cb50e88e81578f79f92a2387c29c71e0e1d9d Reviewed-on: https://code.wireshark.org/review/9574 Reviewed-by: Martin Mathieson Actions performed: from aa839b3 wslua_tree: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang adds a63f841 Netflow: Fix sequence analysis to work for different protocol versions Summary of changes: epan/dissectors/packet-netflow.c | 41 +- 1 file changed, 27 insertions(+), 14 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master a1a2d50: Make .o files, not .cpp and .h files, depend on the ui_*.h files.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a1a2d50716ae3c1fb882726c82e98815faca2b27 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: a1a2d50 by Guy Harris (g...@alum.mit.edu): Make .o files, not .cpp and .h files, depend on the ui_*.h files. That's one of the mechanisms the autotools documentation suggests using to handle generated header files. Using it means that "make dist" will no longer try to build those files (they're not part of the distribution - and they can't be, as the files would be different for Qt 4 and Qt 5, and need to be generated by the uic from the same version of Qt as the one against which Wireshark is being built). This means we don't need to try to find uic, moc, or rcc if we're not building with Qt, so don't do so. Change-Id: Id2aadb8289598b82e14e4ed402ff8cdc15fdef74 Reviewed-on: https://code.wireshark.org/review/9583 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris Actions performed: from a63f841 Netflow: Fix sequence analysis to work for different protocol versions adds a1a2d50 Make .o files, not .cpp and .h files, depend on the ui_*.h files. Summary of changes: acinclude.m4 | 116 +++--- configure.ac | 43 ++-- ui/qt/Makefile.am | 144 - 3 files changed, 132 insertions(+), 171 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 44408ed: Update library release dates.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=44408ed5d9f39f49e871f302c97a6044c0fe4e7e Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 44408ed by Gerald Combs (ger...@wireshark.org): Update library release dates. Change-Id: I053096551a18242062766d966a2f28da047d5761 Reviewed-on: https://code.wireshark.org/review/9592 Reviewed-by: Gerald Combs Actions performed: from a1a2d50 Make .o files, not .cpp and .h files, depend on the ui_*.h files. adds 44408ed Update library release dates. Summary of changes: configure.ac | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master d564ea9: Qt: Add Colorize Conversation menu items.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d564ea9bea6ba07ac601ca555609677b498845dd Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: d564ea9 by Gerald Combs (ger...@wireshark.org): Qt: Add Colorize Conversation menu items. Add the "View→Colorize Conversation" menu similar to the GTK+ UI. Add the "Reset" item under the "Colorize Conversation" menu instead of the top-level "View" menu. Make sure the "Reset" shortcut is Ctrl+Space even on OS X. Normally Qt would convert it to Cmd+Space, but that's used by Spotlight. Add StockIcon::colorIcon and use it to create filled square icons. Change-Id: I2af9e26d025cdaf97482422bbb9440e28e18d1ac Reviewed-on: https://code.wireshark.org/review/9595 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs Actions performed: from 44408ed Update library release dates. adds d564ea9 Qt: Add Colorize Conversation menu items. Summary of changes: color_filters.c | 18 ++- color_filters.h |8 +++ ui/qt/io_graph_dialog.cpp |6 +-- ui/qt/main_window.cpp |1 + ui/qt/main_window.h |5 ++ ui/qt/main_window.ui| 118 ++ ui/qt/main_window_slots.cpp | 120 ++- ui/qt/stock_icon.cpp| 28 ++ ui/qt/stock_icon.h |1 + 9 files changed, 288 insertions(+), 17 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master c7dbc5a: Set the font.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c7dbc5a01b0bbcfb7df13a7fe7039fddedae0d4f Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: c7dbc5a by Gerald Combs (ger...@zing.org): Set the font. Change-Id: I97abd504727ef71bb29969f0a7555e17eaa70561 Reviewed-on: https://code.wireshark.org/review/9596 Reviewed-by: Gerald Combs Actions performed: from d564ea9 Qt: Add Colorize Conversation menu items. adds c7dbc5a Set the font. Summary of changes: ui/qt/stock_icon.cpp |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 080c27f: simple_statistics_dialog(.h): fix parameter 'rtd_table/user_table' not found in the function declaration [-Wdocumentation]
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=080c27f7ff697d99d9cc8699cc98ff02b0b22c52 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 080c27f by Alexis La Goutte (alexis.lagou...@gmail.com): simple_statistics_dialog(.h): fix parameter 'rtd_table/user_table' not found in the function declaration [-Wdocumentation] Change-Id: Ie82d8528953169f1a95f985b36848176a45f8187 Reviewed-on: https://code.wireshark.org/review/9571 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from c7dbc5a Set the font. adds 080c27f simple_statistics_dialog(.h): fix parameter 'rtd_table/user_table' not found in the function declaration [-Wdocumentation] Summary of changes: ui/qt/simple_statistics_dialog.h |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master e478267: Lua: fix docs and default base for ProtoField.framenum()
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e47826734e9d3d6ca2c3589883ff62fce08e7339 Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master Repository: wireshark Commits: e478267 by Hadriel Kaplan (hadri...@yahoo.com): Lua: fix docs and default base for ProtoField.framenum() The ProtoField.framenum() Lua function says to use base.DEC, HEX, etc. But it really can only allow base.NONE. Also, the code defaults to base.DEC if none was given, and then errors if it's a FT_FRAMENUM; instead the default base for FT_FRAMENUM should be base.NONE. Change-Id: I0ec867069c66dbb58399ac2db4652469bfb39152 Reviewed-on: https://code.wireshark.org/review/9599 Petri-Dish: Hadriel Kaplan Tested-by: Petri Dish Buildbot Reviewed-by: Hadriel Kaplan Actions performed: from 080c27f simple_statistics_dialog(.h): fix parameter 'rtd_table/user_table' not found in the function declaration [-Wdocumentation] adds e478267 Lua: fix docs and default base for ProtoField.framenum() Summary of changes: epan/wslua/wslua_proto.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master a68518f: terminate readlink result
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a68518f4996310792860628b5f860d0005cd4f6a Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: a68518f by Tobias Stoeckmann (tob...@stoeckmann.org): terminate readlink result The readlink function does not guarantee to nul-terminate its result string. Therefore, it should be done in wsutil/filesystem.c. Change-Id: Id96533e825a302a1922ce9ac7ee47d5525ac9c39 Reviewed-on: https://code.wireshark.org/review/9597 Reviewed-by: Guy Harris Actions performed: from e478267 Lua: fix docs and default base for ProtoField.framenum() adds a68518f terminate readlink result Summary of changes: wsutil/filesystem.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-1.12 fad97e3: terminate readlink result
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fad97e314f5f7ae369f05eea630ba1cda589a404 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-1.12 Repository: wireshark Commits: fad97e3 by Tobias Stoeckmann (tob...@stoeckmann.org): terminate readlink result The readlink function does not guarantee to nul-terminate its result string. Therefore, it should be done in wsutil/filesystem.c. Change-Id: Id96533e825a302a1922ce9ac7ee47d5525ac9c39 Reviewed-on: https://code.wireshark.org/review/9597 Reviewed-by: Guy Harris (cherry picked from commit a68518f4996310792860628b5f860d0005cd4f6a) Reviewed-on: https://code.wireshark.org/review/9600 Actions performed: from 8354b0e8 MySQL: dissector adds packet content to INFO column without scrubbing it adds fad97e3 terminate readlink result Summary of changes: wsutil/filesystem.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0bcbb2c: Update to Qt 5.5.0, to fix context menu issues.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0bcbb2c20b43ab664cd7795ea2bbc37c5d709e06 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 0bcbb2c by Guy Harris (g...@alum.mit.edu): Update to Qt 5.5.0, to fix context menu issues. This requires still *more* .pc file fixes. Change-Id: I74a385e272063b3342a29122c87331bc8191f7f5 Ping-Bug: 11355 Reviewed-on: https://code.wireshark.org/review/9601 Reviewed-by: Guy Harris Actions performed: from a68518f terminate readlink result adds 0bcbb2c Update to Qt 5.5.0, to fix context menu issues. Summary of changes: macosx-setup.sh |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master ec1e099: Note the Qt bugs about the broken .pc files.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec1e099dc0b1a1307df1c7f002905e7d38a5f2c7 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: ec1e099 by Guy Harris (g...@alum.mit.edu): Note the Qt bugs about the broken .pc files. Change-Id: I050caef2a20b0c6c567f810465a3bcfe40b04a11 Reviewed-on: https://code.wireshark.org/review/9603 Reviewed-by: Guy Harris Actions performed: from 0bcbb2c Update to Qt 5.5.0, to fix context menu issues. adds ec1e099 Note the Qt bugs about the broken .pc files. Summary of changes: macosx-setup.sh |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0caf061: Lua: split up wslua files into class-based files
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0caf0616ba53282cf4ef5587e13989a7aacc9588 Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master Repository: wireshark Commits: 0caf061 by Hadriel Kaplan (hadri...@yahoo.com): Lua: split up wslua files into class-based files The size of some of the wslua source files has grown large, and it's hard to quickly find things. So split them up based on class name, as much as seems reasonable. Also have the make-wsluarm.pl Perl script handle this. Change-Id: Ib495ec5c2a4df90495c0a05504856288a0b09213 Reviewed-on: https://code.wireshark.org/review/9579 Petri-Dish: Hadriel Kaplan Tested-by: Petri Dish Buildbot Reviewed-by: Hadriel Kaplan Actions performed: from ec1e099 Note the Qt bugs about the broken .pc files. adds 0caf061 Lua: split up wslua files into class-based files Summary of changes: doc/README.wslua | 10 + docbook/CMakeLists.txt | 14 + docbook/Makefile.common| 14 + docbook/make-wsluarm.pl| 57 +- epan/wslua/CMakeLists.txt | 34 +- epan/wslua/Makefile.am | 55 +- epan/wslua/Makefile.nmake | 68 +- epan/wslua/wslua.h |1 + epan/wslua/wslua_address.c | 275 +++ epan/wslua/wslua_byte_array.c | 410 epan/wslua/wslua_capture_info.c| 513 + epan/wslua/wslua_column.c | 393 epan/wslua/wslua_dissector.c | 692 +++ epan/wslua/wslua_file.c| 1966 +- epan/wslua/wslua_file_common.c | 205 ++ epan/wslua/wslua_file_common.h | 86 + epan/wslua/wslua_file_handler.c| 997 + epan/wslua/wslua_frame_info.c | 415 epan/wslua/wslua_nstime.c | 210 ++ epan/wslua/wslua_pinfo.c | 730 +-- wsutil/floorl.h => epan/wslua/wslua_pinfo_common.h | 23 +- epan/wslua/wslua_pref.c| 463 + epan/wslua/wslua_proto.c | 2146 +--- epan/wslua/wslua_proto_expert.c| 145 ++ epan/wslua/wslua_proto_field.c | 997 + epan/wslua/wslua_tvb.c | 555 + 26 files changed, 6142 insertions(+), 5332 deletions(-) create mode 100644 epan/wslua/wslua_address.c create mode 100644 epan/wslua/wslua_byte_array.c create mode 100644 epan/wslua/wslua_capture_info.c create mode 100644 epan/wslua/wslua_column.c create mode 100644 epan/wslua/wslua_dissector.c create mode 100644 epan/wslua/wslua_file_common.c create mode 100644 epan/wslua/wslua_file_common.h create mode 100644 epan/wslua/wslua_file_handler.c create mode 100644 epan/wslua/wslua_frame_info.c create mode 100644 epan/wslua/wslua_nstime.c copy wsutil/floorl.h => epan/wslua/wslua_pinfo_common.h (68%) create mode 100644 epan/wslua/wslua_pref.c create mode 100644 epan/wslua/wslua_proto_expert.c create mode 100644 epan/wslua/wslua_proto_field.c ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master be7d295: Add "user presentable" and "unique string ids" to heuristic table entries.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be7d295fbf06788c7fec948cf8755c218ad7c32d Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: be7d295 by Michael Mann (mman...@netscape.net): Add "user presentable" and "unique string ids" to heuristic table entries. This allows better presentation of heuristic dissectors to the end user. Change-Id: I2ff3985ab914e83c2989880cc0c7b9904045b3f6 Reviewed-on: https://code.wireshark.org/review/9602 Petri-Dish: Michael Mann Reviewed-by: Michael Mann Actions performed: from 0caf061 Lua: split up wslua files into class-based files adds be7d295 Add "user presentable" and "unique string ids" to heuristic table entries. Summary of changes: asn1/atn-cm/packet-atn-cm-template.c |2 ++ asn1/atn-cpdlc/packet-atn-cpdlc-template.c |2 ++ asn1/atn-ulcs/packet-atn-ulcs-template.c |2 ++ asn1/credssp/packet-credssp-template.c |2 +- asn1/mms/packet-mms-template.c |4 +-- asn1/mpeg-audio/packet-mpeg-audio-template.c |2 +- asn1/mpeg-pes/packet-mpeg-pes-template.c |2 +- asn1/ranap/packet-ranap-template.c |4 +-- asn1/rnsap/packet-rnsap-template.c |2 +- asn1/t124/packet-t124-template.c |2 +- asn1/t125/packet-t125-template.c |4 +-- epan/dissectors/file-btsnoop.c |2 +- epan/dissectors/file-elf.c |2 +- epan/dissectors/file-gif.c |4 +-- epan/dissectors/file-jpeg.c |4 +-- epan/dissectors/file-png.c |4 +-- epan/dissectors/packet-3com-njack.c |4 +-- epan/dissectors/packet-6lowpan.c |2 +- epan/dissectors/packet-acn.c |2 +- epan/dissectors/packet-adwin-config.c|4 +-- epan/dissectors/packet-aeron.c |2 +- epan/dissectors/packet-applemidi.c |3 +- epan/dissectors/packet-ar_drone.c|2 +- epan/dissectors/packet-artnet.c |2 +- epan/dissectors/packet-at.c |4 +-- epan/dissectors/packet-atn-cm.c |2 ++ epan/dissectors/packet-atn-cpdlc.c |2 ++ epan/dissectors/packet-atn-ulcs.c|2 ++ epan/dissectors/packet-bfcp.c|4 +-- epan/dissectors/packet-bitcoin.c |2 +- epan/dissectors/packet-bittorrent.c |2 +- epan/dissectors/packet-bssap.c |4 +-- epan/dissectors/packet-bt-dht.c |2 +- epan/dissectors/packet-bt-utp.c |2 +- epan/dissectors/packet-carp.c|2 +- epan/dissectors/packet-cattp.c |2 +- epan/dissectors/packet-ceph.c|2 +- epan/dissectors/packet-cigi.c|2 +- epan/dissectors/packet-cimd.c|2 +- epan/dissectors/packet-cip.c |2 +- epan/dissectors/packet-cipsafety.c |2 +- epan/dissectors/packet-classicstun.c |4 +-- epan/dissectors/packet-clique-rm.c |2 +- epan/dissectors/packet-credssp.c |2 +- epan/dissectors/packet-ctdb.c|2 +- epan/dissectors/packet-dcc.c |2 +- epan/dissectors/packet-dcerpc.c | 12 epan/dissectors/packet-dcm.c |2 +- epan/dissectors/packet-dcp-etsi.c|2 +- epan/dissectors/packet-dnp.c |4 +-- epan/dissectors/packet-dplay.c |4 +-- epan/dissectors/packet-drda.c|2 +- epan/dissectors/packet-dtls.c|2 +- epan/dissectors/packet-dvb-s2-bb.c |2 +- epan/dissectors/packet-e100.c|2 +- epan/dissectors/packet-etch.c|2 +- epan/dissectors/packet-fcip.c|2 +- epan/dissectors/packet-fcoib.c |2 +- epan/dissectors/packet-fix.c |2 +- epan/dissectors/packet-fmtp.c|2 +- epan/dissectors/packet-giop.c|4 +-- epan/dissectors/packet-gmhdr.c |4 +-- epan/dissectors/packet-gvsp.c|2 +- epan/dissectors/packet-h1.c |6 ++-- epan/dissectors/packet-h225.c|5 ++- epan/dissectors/packet-hdcp2.c |2 +- epan/dissectors/packet-hislip.c |2 +- epan/dissectors/packet-http.c|2 +- epan/dissectors/packet-http2.c |4 +-- epan/dissectors/packet-icep.c|4 +-- epan/dissectors/packet-ifcp.c|2 +- epan/dissectors/packet-infiniband_sdp.c |4 +-- epan/dissectors/packet-interlink.c |2 +- epan/dissectors/packet-ip.c |2 +- epan/
[Wireshark-commits] master 8c2fc91: VXLAN: Remove a (flag) subtree level
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8c2fc911dfe6b3296bbd2d7e404b15fd55a3b3a4 Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 8c2fc91 by Alexis La Goutte (alexis.lagou...@gmail.com): VXLAN: Remove a (flag) subtree level Change-Id: Ic7cdb78d6a162351900e9e1ea8f4ad74ded167d3 Reviewed-on: https://code.wireshark.org/review/9587 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman Actions performed: from be7d295 Add "user presentable" and "unique string ids" to heuristic table entries. adds 8c2fc91 VXLAN: Remove a (flag) subtree level Summary of changes: epan/dissectors/packet-vxlan.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 71190bc: megaco: replace THROW() with an expert info + return
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71190bca22189f678f164a81a35ac19feec34724 Submitter: Martin Kaiser (wiresh...@kaiser.cx) Changed: branch: master Repository: wireshark Commits: 71190bc by Martin Kaiser (wiresh...@kaiser.cx): megaco: replace THROW() with an expert info + return Change-Id: Ib876ad4b0c6d700da1eec8c8512225c123ad14da Reviewed-on: https://code.wireshark.org/review/9604 Reviewed-by: Martin Kaiser Actions performed: from 8c2fc91 VXLAN: Remove a (flag) subtree level adds 71190bc megaco: replace THROW() with an expert info + return Summary of changes: epan/dissectors/packet-megaco.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0f45a13: [Automatic update for 2015-07-12]
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0f45a13518129ea0bda3ed732b57e3da10fa97c3 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 0f45a13 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2015-07-12] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Icf621f6bcde5736653771c3789772b692d5cdd43 Reviewed-on: https://code.wireshark.org/review/9605 Reviewed-by: Gerald Combs Actions performed: from 71190bc megaco: replace THROW() with an expert info + return adds 0f45a13 [Automatic update for 2015-07-12] Summary of changes: debian/po/cs.po |2 +- debian/po/da.po |2 +- debian/po/de.po |2 +- debian/po/es.po |2 +- debian/po/eu.po |2 +- debian/po/fi.po |2 +- debian/po/fr.po |2 +- debian/po/hu.po |2 +- debian/po/id.po |2 +- debian/po/it.po |2 +- debian/po/ja.po |2 +- debian/po/ko.po |2 +- debian/po/nl.po |2 +- debian/po/pt.po |2 +- debian/po/pt_BR.po |2 +- debian/po/ru.po |2 +- debian/po/sk.po |2 +- debian/po/sv.po |2 +- debian/po/vi.po |2 +- epan/enterprise-numbers | 144 +++- epan/sminmpec.c | 35 +- manuf| 53 +- services |2 +- ui/qt/wireshark_de.qm| Bin 205186 -> 205450 bytes ui/qt/wireshark_de.ts| 1766 +++-- ui/qt/wireshark_en.ts| 1766 +++-- ui/qt/wireshark_fr.qm| Bin 139543 -> 139825 bytes ui/qt/wireshark_fr.ts| 1766 +++-- ui/qt/wireshark_it.qm| Bin 257272 -> 258394 bytes ui/qt/wireshark_it.ts| 1770 -- ui/qt/wireshark_ja_JP.qm | Bin 152430 -> 152682 bytes ui/qt/wireshark_ja_JP.ts | 1766 +++-- ui/qt/wireshark_pl.qm| Bin 245778 -> 246884 bytes ui/qt/wireshark_pl.ts| 1770 -- ui/qt/wireshark_zh_CN.qm | Bin 185673 -> 186585 bytes ui/qt/wireshark_zh_CN.ts | 1770 -- 36 files changed, 7705 insertions(+), 4941 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-1.12 693ae12: [Automatic update for 2015-07-12]
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=693ae12abbf270542dde5055726eda9a0400e2ac Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master-1.12 Repository: wireshark Commits: 693ae12 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2015-07-12] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I9faf405797ba595b52fda296d46302b2bb221381 Reviewed-on: https://code.wireshark.org/review/9606 Reviewed-by: Gerald Combs Actions performed: from fad97e3 terminate readlink result adds 693ae12 [Automatic update for 2015-07-12] Summary of changes: epan/enterprise-numbers | 144 +-- epan/sminmpec.c | 35 +++- manuf | 53 ++--- services|2 +- 4 files changed, 218 insertions(+), 16 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master a17bb6c: Update a comment.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a17bb6c3508cea056113f4a54ebcaf44312e50aa Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: a17bb6c by Guy Harris (g...@alum.mit.edu): Update a comment. Change-Id: I38e42ec1ea86a0678333093795be707d6e68ab62 Reviewed-on: https://code.wireshark.org/review/9607 Reviewed-by: Guy Harris Actions performed: from 0f45a13 [Automatic update for 2015-07-12] adds a17bb6c Update a comment. Summary of changes: configure.ac |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 39a2d94: Fixup packet list selection.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39a2d9468b019c5c7de4b21eb497772b1336c36f Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 39a2d94 by Gerald Combs (ger...@zing.org): Fixup packet list selection. Be less aggressive about resetting the packet list model so that we retain our selection when (un)coloring packets or rebuilding columns. Correctly enable a colorization menu item while we're here. Change-Id: I8d1c8f26dbb8a814b8344b609695b77632006e4b Reviewed-on: https://code.wireshark.org/review/9608 Reviewed-by: Gerald Combs Actions performed: from a17bb6c Update a comment. adds 39a2d94 Fixup packet list selection. Summary of changes: ui/qt/main_window_slots.cpp |3 ++- ui/qt/packet_list.cpp |5 ++--- ui/qt/packet_list_model.cpp |7 +++ 3 files changed, 7 insertions(+), 8 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master e920868: Revert "[MSVC2015] TRy to fix Warnings turned errors."
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e92086849af8e8611ec2e789aa33a4734ff4208b Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: e920868 by Anders Broman (a.broma...@gmail.com): Revert "[MSVC2015] TRy to fix Warnings turned errors." This reverts commit 8d78077d0d931c6afee6d0e27b5df7c5477e21e5. Reverted as requested. Change-Id: I99461820d28215a52cc6bae6792f2892018d28b8 Reviewed-on: https://code.wireshark.org/review/9609 Reviewed-by: Anders Broman Actions performed: from 39a2d94 Fixup packet list selection. adds e920868 Revert "[MSVC2015] TRy to fix Warnings turned errors." Summary of changes: epan/dissectors/packet-btatt.c| 14 -- epan/dissectors/packet-btavctp.c |7 ++- epan/dissectors/packet-btl2cap.c | 21 ++--- epan/dissectors/packet-btobex.c |7 ++- epan/dissectors/packet-btrfcomm.c | 14 -- epan/dissectors/packet-h223.c |2 +- 6 files changed, 55 insertions(+), 10 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 494457d: Make OS X .app bundling work with Qt 5.5.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=494457d3b55630595909d4db883e93f2d3f57986 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 494457d by Guy Harris (g...@alum.mit.edu): Make OS X .app bundling work with Qt 5.5. macdeployqt doesn't actually seem to deploy any of Qt into the app bundle, probably because we're using it in a fashion they didn't intend (i.e., not doing everything with *their* build tools), so we just extend our dependency-binding stuff to handle the Qt libraries, and copy over the Qt plugins ourselves. We also add the rpaths to the executables and libraries as part of the app bundle building process; I thought it'd fix macdeployqt's problem, but it didn't, however, it's probably cleaner to do it there anyway. Change-Id: I134c2b1a32e168e82de67f0b674d17167481d69a Reviewed-on: https://code.wireshark.org/review/9612 Reviewed-by: Guy Harris Actions performed: from e920868 Revert "[MSVC2015] TRy to fix Warnings turned errors." adds 494457d Make OS X .app bundling work with Qt 5.5. Summary of changes: configure.ac| 12 ++- packaging/macosx/osx-app.sh | 80 --- 2 files changed, 77 insertions(+), 15 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master c305f08: PacketList column fixes.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c305f08921feb30f5411bc8f8e0b01ebf1cfbe2e Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: c305f08 by Gerald Combs (ger...@wireshark.org): PacketList column fixes. Add a columnsChanged slot to PacketList and move the column update code from redrawVisiblePackets there. Make sure we call packet_list_model_->recreateVisibleRows, which should fix the behavior described in bug 11324. Call columnsChanged when we, uh, change columns. Add a sectionMoved slot to handle column reordering. Don't rebuild the column list when we update the widgets in the column preferences frame. Do enable and disable the "remove" button as needed. Try to keep the user from removing all of the columns in both the packet list and column preferences. Left as an exercise for the reader: The GTK+ UI also fails when you remove all of the columns via the preferences: packet_list.c:377:packet_list_sort_column: assertion failed: (col) Bug: 11324 Change-Id: Id58cf98e42cbda9aa2fc370ea06b8bcc6098c8ca Reviewed-on: https://code.wireshark.org/review/9591 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs Actions performed: from 494457d Make OS X .app bundling work with Qt 5.5. adds c305f08 PacketList column fixes. Summary of changes: ui/qt/column_preferences_frame.cpp | 32 ++- ui/qt/column_preferences_frame.h |4 +- ui/qt/main_window.cpp |2 +- ui/qt/main_window_slots.cpp|2 +- ui/qt/packet_list.cpp | 75 ++-- ui/qt/packet_list.h|2 + 6 files changed, 92 insertions(+), 25 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master c6aa2b5: Don't add rpaths with CMake, either; osx-app.sh will do so.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c6aa2b5b2c687f855d0c0a5a1fa7ea53f4b89415 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: c6aa2b5 by Guy Harris (g...@alum.mit.edu): Don't add rpaths with CMake, either; osx-app.sh will do so. Change-Id: Ie8f39e5e89ed8dc21c66ee7f1235c406c3028304 Reviewed-on: https://code.wireshark.org/review/9613 Reviewed-by: Guy Harris Actions performed: from c305f08 PacketList column fixes. adds c6aa2b5 Don't add rpaths with CMake, either; osx-app.sh will do so. Summary of changes: CMakeLists.txt | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0571d84: Handle both @rpath/ and absolute paths in Qt framework install names.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0571d849dfdf54bc7253daf5d36bab9527892b8a Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 0571d84 by Guy Harris (g...@alum.mit.edu): Handle both @rpath/ and absolute paths in Qt framework install names. When looking for Qt framework dependencies, look for dependencies that begin either with @rpath or with the Qt framework directory. Then, first transform @rpath/ to a path relative to the Qt framework directory, and then strip off everything past the framework directory, to get the absolute path of the framework directory (not of the framework binary - we want to copy the whole framework). In the loop looking for dependencies on things *other* than Qt frameworks, exclude Qt framework references with absolute paths from the dependencies we find; they get processed later. (We already excluded those with @rpath paths.) Change-Id: I1e345a5fb82c758d5c1541693b46cb36d2677fab Reviewed-on: https://code.wireshark.org/review/9614 Reviewed-by: Guy Harris Actions performed: from c6aa2b5 Don't add rpaths with CMake, either; osx-app.sh will do so. adds 0571d84 Handle both @rpath/ and absolute paths in Qt framework install names. Summary of changes: packaging/macosx/osx-app.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 7cf25a5: Handle Qt 4 when looking for the Qt frameworks directory.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7cf25a5c1fdd3d56d4e933d9bc5973da041ab478 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 7cf25a5 by Guy Harris (g...@alum.mit.edu): Handle Qt 4 when looking for the Qt frameworks directory. Do it in a loop, so we can change it to handle Qt 6 if, as, and when it comes out (assuming they label its packages as Qt6Package). Change-Id: I1d33d3e9726981b1940fb4409184c486628cb31b Reviewed-on: https://code.wireshark.org/review/9615 Reviewed-by: Guy Harris Actions performed: from 0571d84 Handle both @rpath/ and absolute paths in Qt framework install names. adds 7cf25a5 Handle Qt 4 when looking for the Qt frameworks directory. Summary of changes: packaging/macosx/osx-app.sh |9 - 1 file changed, 8 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master a9d4f20: Remove unintended removal of a / in a pathname.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9d4f20daf7fa45608f6b8d7863618dc8d78a987 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: a9d4f20 by Guy Harris (g...@alum.mit.edu): Remove unintended removal of a / in a pathname. Change-Id: Ibc951e418c497e915e4391258677366a077e5531 Reviewed-on: https://code.wireshark.org/review/9616 Reviewed-by: Guy Harris Actions performed: from 7cf25a5 Handle Qt 4 when looking for the Qt frameworks directory. adds a9d4f20 Remove unintended removal of a / in a pathname. Summary of changes: packaging/macosx/osx-app.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master a8f3b3d: Don't copy the entire framework.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8f3b3d3d93908b92f68e75a50426c71c581d906 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: a8f3b3d by Guy Harris (g...@alum.mit.edu): Don't copy the entire framework. Copy only the stuff needed at run time; don't bother with all the headers, etc.. Change-Id: Id9d2ec916b6742a6cb6e2ec3c0f7ed1a65a8a93c Reviewed-on: https://code.wireshark.org/review/9617 Reviewed-by: Guy Harris Actions performed: from a9d4f20 Remove unintended removal of a / in a pathname. adds a8f3b3d Don't copy the entire framework. Summary of changes: packaging/macosx/osx-app.sh | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 00b34f4: Lua: all protocol tree entries expand/contract together
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=00b34f45ca7308a87fc765b26936fcdf9b980d0e Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master Repository: wireshark Commits: 00b34f4 by Hadriel Kaplan (hadri...@yahoo.com): Lua: all protocol tree entries expand/contract together Make each Lua Proto object have an alloacted ett value, so that they expand/contract only for the same protocol. Bug: 11356 Change-Id: I68fb3ff00e080b47d540344aba2554e392b7f1c4 Reviewed-on: https://code.wireshark.org/review/9611 Petri-Dish: Hadriel Kaplan Tested-by: Petri Dish Buildbot Reviewed-by: Hadriel Kaplan Actions performed: from a8f3b3d Don't copy the entire framework. adds 00b34f4 Lua: all protocol tree entries expand/contract together Summary of changes: epan/wslua/wslua_proto.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-1.12 8cb0d78: Lua: all protocol tree entries expand/contract together
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8cb0d78a678ccc67ac2c25a75415c5933e6b6226 Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master-1.12 Repository: wireshark Commits: 8cb0d78 by Hadriel Kaplan (hadri...@yahoo.com): Lua: all protocol tree entries expand/contract together Make each Lua Proto object have an alloacted ett value, so that they expand/contract only for the same protocol. Bug: 11356 Change-Id: I68fb3ff00e080b47d540344aba2554e392b7f1c4 Reviewed-on: https://code.wireshark.org/review/9611 Petri-Dish: Hadriel Kaplan Tested-by: Petri Dish Buildbot Reviewed-by: Hadriel Kaplan (cherry picked from commit 00b34f45ca7308a87fc765b26936fcdf9b980d0e) Reviewed-on: https://code.wireshark.org/review/9618 Actions performed: from 693ae12 [Automatic update for 2015-07-12] adds 8cb0d78 Lua: all protocol tree entries expand/contract together Summary of changes: epan/wslua/wslua_proto.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master eeccdf3: Copy over the entire framework and then clean it up.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eeccdf3fe4065cf26fc925a1186dd99e49128184 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: eeccdf3 by Guy Harris (g...@alum.mit.edu): Copy over the entire framework and then clean it up. That's easier than trying to carefully copy the relevant bits. Change-Id: I2f174a735bf91f6434929c25ca33aced03e19597 Reviewed-on: https://code.wireshark.org/review/9620 Reviewed-by: Guy Harris Actions performed: from 00b34f4 Lua: all protocol tree entries expand/contract together adds eeccdf3 Copy over the entire framework and then clean it up. Summary of changes: packaging/macosx/osx-app.sh | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 3a78901: Rpathify references to Qt frameworks separately from references to libraries.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a7890193554c954728f8898bb6083e3f29d85eb Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 3a78901 by Guy Harris (g...@alum.mit.edu): Rpathify references to Qt frameworks separately from references to libraries. We need to preserve the full path of the framework binary. Change-Id: I3a13eaffc07028a26fbd970db02cc1cce3fdcd5d Reviewed-on: https://code.wireshark.org/review/9621 Reviewed-by: Guy Harris Actions performed: from eeccdf3 Copy over the entire framework and then clean it up. adds 3a78901 Rpathify references to Qt frameworks separately from references to libraries. Summary of changes: packaging/macosx/osx-app.sh | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master af12e33: Change Lua's tvbrange:*int64() to read only the number of bytes specified in the range.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=af12e335093dc913cd9ec0e9efe5bceba071cfd1 Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master Repository: wireshark Commits: af12e33 by Cédric Delmas (cedri...@outlook.fr): Change Lua's tvbrange:*int64() to read only the number of bytes specified in the range. Previously the length was ignored and 8 bytes were always read. The constraint on int64() and le_int64() becomes stricter to match int()'s ones: the range must be 1, 2, 4 or 8 octets long. Change-Id: Ic66798757564ac840c332b978effb418726a654c Reviewed-on: https://code.wireshark.org/review/9622 Petri-Dish: Hadriel Kaplan Tested-by: Petri Dish Buildbot Reviewed-by: Hadriel Kaplan Actions performed: from 3a78901 Rpathify references to Qt frameworks separately from references to libraries. adds af12e33 Change Lua's tvbrange:*int64() to read only the number of bytes specified in the range. Summary of changes: epan/wslua/wslua_tvb.c | 64 ++-- 1 file changed, 46 insertions(+), 18 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 7b9b3d4: Go back to using macdeployqt for now.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b9b3d469375c9d3ac1b5f7280ca64413b4811bf Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 7b9b3d4 by Guy Harris (g...@alum.mit.edu): Go back to using macdeployqt for now. I have some other hammers to try it hit it with to get it to actually work with Qt 5.5. Change-Id: Ie20ccbcee62fa48f768ba22478d07b9dc18d0139 Reviewed-on: https://code.wireshark.org/review/9623 Reviewed-by: Guy Harris Actions performed: from af12e33 Change Lua's tvbrange:*int64() to read only the number of bytes specified in the range. adds 7b9b3d4 Go back to using macdeployqt for now. Summary of changes: packaging/macosx/osx-app.sh | 131 --- 1 file changed, 10 insertions(+), 121 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 9f03aa1: On OS X, add an rpath for the Qt frameworks, and remove it in the app bundle.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f03aa131e851447f6c3a89b6e57ff560df0afe2 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 9f03aa1 by Guy Harris (g...@alum.mit.edu): On OS X, add an rpath for the Qt frameworks, and remove it in the app bundle. Qt 5.5 and later have @rpath-based install names for the frameworks, which means that, if they're not installed in some frameworks directory searched by default (such as /Library/Frameworks) - which is the default case with the Qt installer - they won't be found by default. Add the directory in which the frameworks exist as an rpath in the Wireshark binary, so that they'll be found, and then remove it from the Wireshark binary in the app bundle, as the directory in which the frameworks exist on the machine on which Wireshark was built is irrelevant to the machines on which it's being deployed - the frameworks are included in the bundle, and we already add an rpath to find them there. Change-Id: I54e033743e7b17eab26976064dcd7cd000f97c78 Reviewed-on: https://code.wireshark.org/review/9625 Reviewed-by: Guy Harris Actions performed: from 7b9b3d4 Go back to using macdeployqt for now. adds 9f03aa1 On OS X, add an rpath for the Qt frameworks, and remove it in the app bundle. Summary of changes: Makefile.am |2 +- configure.ac| 22 +- packaging/macosx/osx-app.sh | 21 + 3 files changed, 43 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 8ba9479: GTK: Don't crash when we click on an RTP sample.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ba94798ec1506b86abf9418a3fb849d375e62b6 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 8ba9479 by Gerald Combs (ger...@wireshark.org): GTK: Don't crash when we click on an RTP sample. This doesn't fix any of the underlying problems discussed in bug 10613 but it does keep us from dereferencing a NULL pointer. Change-Id: I9317366a6ae6e563dcadb32bccee87e8803c37e3 Ping-Bug: 10613. Reviewed-on: https://code.wireshark.org/review/9626 Reviewed-by: Gerald Combs Actions performed: from 9f03aa1 On OS X, add an rpath for the Qt frameworks, and remove it in the app bundle. adds 8ba9479 GTK: Don't crash when we click on an RTP sample. Summary of changes: ui/gtk/rtp_player.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 5c2a98b: Don't treat Qt frameworks as dependencies.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c2a98bf57348254f8686f8cd2378b8fcae096a7 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 5c2a98b by Guy Harris (g...@alum.mit.edu): Don't treat Qt frameworks as dependencies. macdeployqt will stuff them into the bundle for us; exclude anything in the Qt frameworks directory from the lists of dependencies for us to copy or munge. (We don't copy them correctly - that results in the underlying binary being copied to the Frameworks directory - and we leave it up to macdeployqt to do the munging.) Change-Id: I10cfb8dcb2abadde9d5c52252979267912710f80 Reviewed-on: https://code.wireshark.org/review/9627 Reviewed-by: Guy Harris Actions performed: from 8ba9479 GTK: Don't crash when we click on an RTP sample. adds 5c2a98b Don't treat Qt frameworks as dependencies. Summary of changes: packaging/macosx/osx-app.sh |5 + 1 file changed, 5 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master bed3163: Crank down the log level for macdeployqt.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bed31637255464d890cb74d4c7edc57c20c9a2f4 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: bed3163 by Guy Harris (g...@alum.mit.edu): Crank down the log level for macdeployqt. Adding the additional rpath in the build process appears to have fixed the problem I was trying to debug. Change-Id: I518deea67837f7e084e503b8e5ae7c3f188df3c8 Reviewed-on: https://code.wireshark.org/review/9628 Reviewed-by: Guy Harris Actions performed: from 5c2a98b Don't treat Qt frameworks as dependencies. adds bed3163 Crank down the log level for macdeployqt. Summary of changes: packaging/macosx/osx-app.sh |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master ef3cc4a: RTP updates.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef3cc4a2c15cc351a38193e44adf938624634666 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: ef3cc4a by Gerald Combs (ger...@wireshark.org): RTP updates. Merge rtp_sample_header_t into rtp_sample_t. That's the only place it was used. Note that rtp_sample_t is used for writing rtpdump files. Move the rtp_sample_t definition to tap-rtp-common.c. Rename it to rtpdump_info_t. Make rtp_write_sample static. Change-Id: I04e7428f634efa87a98e5d6c82a354f94ab1765d Reviewed-on: https://code.wireshark.org/review/9629 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs Actions performed: from bed3163 Crank down the log level for macdeployqt. adds ef3cc4a RTP updates. Summary of changes: ui/gtk/rtp_player.c |2 +- ui/rtp_stream.h | 17 - ui/tap-rtp-common.c | 28 ++-- ui/tap-rtp-common.h |1 - 4 files changed, 19 insertions(+), 29 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master cab4450: The toolkit is called "Qt", not "QT".
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cab4450935ed0adce009879dc23531ba045f8bb3 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: cab4450 by Guy Harris (g...@alum.mit.edu): The toolkit is called "Qt", not "QT". Change-Id: If6c0c66bc429a041b3454f1f2355d4659cb17bbf Reviewed-on: https://code.wireshark.org/review/9630 Reviewed-by: Guy Harris Actions performed: from ef3cc4a RTP updates. adds cab4450 The toolkit is called "Qt", not "QT". Summary of changes: CMakeLists.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 5cd7601: tftp: stop TFTP heuristic incorrectly matching TURN ChannelData messages
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5cd76010d90ed262698eedbac637088d5a407e1a Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master Repository: wireshark Commits: 5cd7601 by Hadriel Kaplan (hadri...@yahoo.com): tftp: stop TFTP heuristic incorrectly matching TURN ChannelData messages Make TURN-based TFTP heuristic dissector check for valid opcode and error code before matching TURN payload content. The TFTP heuristic dissector incorrectly matched TURN ChannelData message data content when it shouldn't. Unfortunately, the TFTP protocol has very little constrained structure to perform heuristic detection with. It basically always matched/succeeded. Bug: 11335 Change-Id: I950fd5a273fef63d7b069c87d1146cbd752c3bd9 Reviewed-on: https://code.wireshark.org/review/9489 Petri-Dish: Hadriel Kaplan Reviewed-by: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Hadriel Kaplan Actions performed: from cab4450 The toolkit is called "Qt", not "QT". adds 5cd7601 tftp: stop TFTP heuristic incorrectly matching TURN ChannelData messages Summary of changes: epan/dissectors/packet-tftp.c | 86 + 1 file changed, 62 insertions(+), 24 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 873d598: stun/turn: stop STUN heuristic incorrectly matching TURN ChannelData messages
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=873d5980cd1d83b7f6728657b98a37c3a882f5e7 Submitter: Hadriel Kaplan (hadri...@yahoo.com) Changed: branch: master Repository: wireshark Commits: 873d598 by Hadriel Kaplan (hadri...@yahoo.com): stun/turn: stop STUN heuristic incorrectly matching TURN ChannelData messages The STUN heuristic dissector decoded a packet as a TURN ChannelData message with a relatively weak heuristic. In order to avoid incorrect matches, it checked for an existing conversation first, but the UDP layer dissector will create a conversation so this check was basically useless. Therefore, the STUN heuristic dissector no longer matches TURN ChannelData messages at all. If it matches another TURN message type, then it sets the dissector for the conversation to be the non-heuristic dissector, and then ChannelData messages will be decoded by that. Based on the new heuristic dissector enable/disable model, in the near future I might add another heuristic for a weaker check, to include TURN ChannelData. Bug: 11152 Change-Id: I3f3763ce5f7be71e1402e620424df45e7ea99ee5 Reviewed-on: https://code.wireshark.org/review/9486 Petri-Dish: Hadriel Kaplan Reviewed-by: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Hadriel Kaplan Actions performed: from 5cd7601 tftp: stop TFTP heuristic incorrectly matching TURN ChannelData messages adds 873d598 stun/turn: stop STUN heuristic incorrectly matching TURN ChannelData messages Summary of changes: epan/dissectors/packet-stun.c | 66 ++--- 1 file changed, 49 insertions(+), 17 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master b19846d: RTCP heuristic only matches odd port-number TURN ChannelData packets
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b19846d40eff42c28f8209e07f9c193736710749 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: b19846d by Hadriel Kaplan (hadri...@yahoo.com): RTCP heuristic only matches odd port-number TURN ChannelData packets RTCP can be carried within TURN CannelData messages, or STUN/TURN Send messages. The TURN message can be in UDP or TCP, of any port number (by default the even port 3478). So the RTCP heuristic dissector used inside the TURN ChannelData/Send payload needs to match regardless of the port number of the packet. Bug: 11336 Change-Id: I155b87c3e666478d3245366784d7d4e49c8e42c8 Reviewed-on: https://code.wireshark.org/review/9624 Petri-Dish: Hadriel Kaplan Reviewed-by: Evan Huus Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from 873d598 stun/turn: stop STUN heuristic incorrectly matching TURN ChannelData messages adds b19846d RTCP heuristic only matches odd port-number TURN ChannelData packets Summary of changes: epan/dissectors/packet-rtcp.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 2ebe879: Correct eventlog.eventlog_OpenEventLogW.Module dissection by providing lsa_String type in .cnf
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ebe8792fb969581a0d719c50ec108d65568 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 2ebe879 by Michael Mann (mman...@netscape.net): Correct eventlog.eventlog_OpenEventLogW.Module dissection by providing lsa_String type in .cnf There seem to be multiple definitions of an "lsa_String" depending on the DCE/RPC dissector, so change was made just in EventLog. Bug: 10264 Change-Id: I32e97c2a537b01d3bfe9dd03452b8ee1af4d1c2e Reviewed-on: https://code.wireshark.org/review/9598 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from b19846d RTCP heuristic only matches odd port-number TURN ChannelData packets adds 2ebe879 Correct eventlog.eventlog_OpenEventLogW.Module dissection by providing lsa_String type in .cnf Summary of changes: epan/dissectors/packet-dcerpc-eventlog.c | 44 +++--- epan/dissectors/pidl/eventlog.cnf| 15 +- 2 files changed, 17 insertions(+), 42 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 1d708ce: If the IP length says there no data following the IP layer, don't try to dissect the next layer.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d708cef72dc230f58a9ed046a6a27355d98de1c Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 1d708ce by Michael Mann (mman...@netscape.net): If the IP length says there no data following the IP layer, don't try to dissect the next layer. Bug: 11354 Change-Id: I24a6f2b04e138902fb548ca500af35b18f08acdc Reviewed-on: https://code.wireshark.org/review/9619 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from 2ebe879 Correct eventlog.eventlog_OpenEventLogW.Module dissection by providing lsa_String type in .cnf adds 1d708ce If the IP length says there no data following the IP layer, don't try to dissect the next layer. Summary of changes: epan/dissectors/packet-ip.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master cdeae7e: Add a "heuristic dissectors" tab to the Enable Protocols dialog.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cdeae7e72b749cdd68207d6e97dafb67783e2de4 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: cdeae7e by Michael Mann (mman...@netscape.net): Add a "heuristic dissectors" tab to the Enable Protocols dialog. This allows for a global place to enable/disable all heuristic dissectors. This removes the need for individual dissector preferences, but those will be removed at a later date. The more important part is the epan code to save/restore the enabled state of the heuristic dissector. The GTK dialog was more for quickly testing the feature (there was already some GTK code in place that started the heuristic dialog tab) Change-Id: Ie10687505c27a4456c49d5c4c69a5fc5f6394275 Ping-Bug:11152 Reviewed-on: https://code.wireshark.org/review/9508 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from 1d708ce If the IP length says there no data following the IP layer, don't try to dissect the next layer. adds cdeae7e Add a "heuristic dissectors" tab to the Enable Protocols dialog. Summary of changes: debian/libwireshark0.symbols|1 + echld/dispatcher.c |3 +- epan/disabled_protos.c | 388 - epan/disabled_protos.h | 41 +- epan/packet.c |7 +- epan/packet.h |7 + rawshark.c |3 + tfshark.c |3 + tshark.c|3 + ui/gtk/main.c |4 + ui/gtk/proto_dlg.c | 1146 --- ui/help_url.c |3 + ui/help_url.h |1 + ui/qt/wireshark_application.cpp |3 + wireshark-qt.cpp|1 + 15 files changed, 1055 insertions(+), 559 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 9230834: Don't copy zero bytes of data.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9230834fbe06f893bd581ab889b94122df5a9998 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 9230834 by Guy Harris (g...@alum.mit.edu): Don't copy zero bytes of data. memcpy(NULL, NULL, 0) isn't guaranteed by ISO C90 to work, so don't do it. Check whether the length is zero, and don't copy if it is. (If the count is non-zero and the pointer is null, that's an error, and we should fail there, so base the test on the length, not the pointer.) Change-Id: I0b3dc1541b52670d8fef459754c9494cfcc59e5d Reviewed-on: https://code.wireshark.org/review/9633 Reviewed-by: Guy Harris Actions performed: from cdeae7e Add a "heuristic dissectors" tab to the Enable Protocols dialog. adds 9230834 Don't copy zero bytes of data. Summary of changes: epan/address.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 4f1b8d7: Add a bounds check.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f1b8d74338ca2a6ded8498e9d87cbc3294454c0 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 4f1b8d7 by Guy Harris (g...@alum.mit.edu): Add a bounds check. AirPDcapStoreSa() was assuming that ctx->first_free_index would always be within the ctx->sa array; nothing guarantees that. Fail if it's past the end of the array; that means there *are* no free indices. Change-Id: I73145ea3f3dda1b3800a41fa3a2b01ac344dcbfc Reviewed-on: https://code.wireshark.org/review/9634 Reviewed-by: Guy Harris Actions performed: from 9230834 Don't copy zero bytes of data. adds 4f1b8d7 Add a bounds check. Summary of changes: epan/crypt/airpdcap.c |4 1 file changed, 4 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-1.12 4632823: Add a bounds check.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=46328232bc42d356a3d7c89901699d2220b9f420 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-1.12 Repository: wireshark Commits: 4632823 by Guy Harris (g...@alum.mit.edu): Add a bounds check. AirPDcapStoreSa() was assuming that ctx->first_free_index would always be within the ctx->sa array; nothing guarantees that. Fail if it's past the end of the array; that means there *are* no free indices. Change-Id: I73145ea3f3dda1b3800a41fa3a2b01ac344dcbfc Reviewed-on: https://code.wireshark.org/review/9634 Reviewed-by: Guy Harris (cherry picked from commit 4f1b8d74338ca2a6ded8498e9d87cbc3294454c0) Reviewed-on: https://code.wireshark.org/review/9635 Actions performed: from 8cb0d78 Lua: all protocol tree entries expand/contract together adds 4632823 Add a bounds check. Summary of changes: epan/crypt/airpdcap.c |4 1 file changed, 4 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 1ac7de5: Resize the name column every time we re-display the interface tree.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1ac7de58c7c2d5c030fe0202e8e76bff8608624e Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 1ac7de5 by Guy Harris (g...@alum.mit.edu): Resize the name column every time we re-display the interface tree. Interfaces can appear and disappear, changing the maximum length of the interface name column; resize it each time we reconstruct the tree. Change-Id: I38b40f6c3ce51272e8bbb0c7f7fbaa7255886e0e Reviewed-on: https://code.wireshark.org/review/9641 Reviewed-by: Guy Harris Actions performed: from 4f1b8d7 Add a bounds check. adds 1ac7de5 Resize the name column every time we re-display the interface tree. Summary of changes: ui/qt/interface_tree.cpp |1 + 1 file changed, 1 insertion(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 828358d: Openflow - prevent infinite loop
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=828358d22c6bcf0a1ade5b3ffaa8018a385bfc6c Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 828358d by Michael Mann (mman...@netscape.net): Openflow - prevent infinite loop Change-Id: I93ce7151467c890c12f7d612b5a7eecf5f91c189 Ping-Bug: 11358 Reviewed-on: https://code.wireshark.org/review/9640 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from 1ac7de5 Resize the name column every time we re-display the interface tree. adds 828358d Openflow - prevent infinite loop Summary of changes: epan/dissectors/packet-openflow_v5.c |6 ++ 1 file changed, 6 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 52e2908: Filter UDP packets on port 3389 when capturing from a Remote Desktop session
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=52e2908729c0d0d45df572ff3aaf3e41258c2d4e Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 52e2908 by Pascal Quantin (pascal.quan...@gmail.com): Filter UDP packets on port 3389 when capturing from a Remote Desktop session As reported in https://www.wireshark.org/lists/wireshark-dev/201507/msg00069.html Change-Id: I171b934fd97748f17586ffcee8012fd4c0d156b1 Reviewed-on: https://code.wireshark.org/review/9642 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from 828358d Openflow - prevent infinite loop adds 52e2908 Filter UDP packets on port 3389 when capturing from a Remote Desktop session Summary of changes: ui/util.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-1.12 6cb9d38: Openflow - prevent infinite loop
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6cb9d38f200e2ef9109479135a94fba11b5a1a77 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master-1.12 Repository: wireshark Commits: 6cb9d38 by Michael Mann (mman...@netscape.net): Openflow - prevent infinite loop Change-Id: I93ce7151467c890c12f7d612b5a7eecf5f91c189 Ping-Bug: 11358 Reviewed-on: https://code.wireshark.org/review/9640 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann (cherry picked from commit 828358d22c6bcf0a1ade5b3ffaa8018a385bfc6c) Reviewed-on: https://code.wireshark.org/review/9643 Actions performed: from 4632823 Add a bounds check. adds 6cb9d38 Openflow - prevent infinite loop Summary of changes: epan/dissectors/packet-openflow_v5.c |6 ++ 1 file changed, 6 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 7977432: Simply code for export of PDUs coming from heuristic dissectors
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79774329d7cc324b3d7c3a5a013abea85a20885e Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: 7977432 by Pascal Quantin (pascal.quan...@gmail.com): Simply code for export of PDUs coming from heuristic dissectors Let's use the newly introduced find_heur_dissector_by_unique_short_name() function Change-Id: I5781b9b2f1ab679da07e97755b71840b4b3a9361 Reviewed-on: https://code.wireshark.org/review/9645 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin Actions performed: from 52e2908 Filter UDP packets on port 3389 when capturing from a Remote Desktop session adds 7977432 Simply code for export of PDUs coming from heuristic dissectors Summary of changes: debian/libwireshark0.symbols |1 - epan/dissectors/packet-dtls.c |4 +--- epan/dissectors/packet-exported_pdu.c | 14 -- epan/dissectors/packet-ssl.c |4 +--- epan/exported_pdu.h |4 ++-- epan/packet.c | 17 - epan/packet.h |9 - 7 files changed, 8 insertions(+), 45 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master a41e8e6: Qt: fix detection of WinPcap / AirPcap
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a41e8e66230a90c6d83e93f4529b16e840e45562 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: a41e8e6 by Pascal Quantin (pascal.quan...@gmail.com): Qt: fix detection of WinPcap / AirPcap Libraries must be loaded before calling get_runtime_version_info() Change-Id: Ic95ccde4ce80338b058a22a653736b663c517b38 Reviewed-on: https://code.wireshark.org/review/9637 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin Actions performed: from 7977432 Simply code for export of PDUs coming from heuristic dissectors adds a41e8e6 Qt: fix detection of WinPcap / AirPcap Summary of changes: wireshark-qt.cpp | 103 +++--- 1 file changed, 51 insertions(+), 52 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master c8c8eef: zvt: handle multi-byte tags
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8c8eefb47adf4a24e9745ae68521c6dbad04e10 Submitter: Martin Kaiser (wiresh...@kaiser.cx) Changed: branch: master Repository: wireshark Commits: c8c8eef by Martin Kaiser (wiresh...@kaiser.cx): zvt: handle multi-byte tags and dissect the components of a tag add a global true-false string for constructed vs. primitive Change-Id: If10ecf97cde59e2be9ff5e3163073f6d14e6c61e Reviewed-on: https://code.wireshark.org/review/9636 Reviewed-by: Martin Kaiser Actions performed: from a41e8e6 Qt: fix detection of WinPcap / AirPcap adds c8c8eef zvt: handle multi-byte tags Summary of changes: epan/dissectors/packet-zvt.c | 64 +++--- epan/tfs.c |1 + epan/tfs.h |1 + 3 files changed, 56 insertions(+), 10 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 79be831: ssl-utils: remove unused, broken libgcrypt code
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79be8312da5f572664e8a56d6e98d92dc34fdc95 Submitter: Peter Wu (pe...@lekensteyn.nl) Changed: branch: master Repository: wireshark Commits: 79be831 by Peter Wu (pe...@lekensteyn.nl): ssl-utils: remove unused, broken libgcrypt code Remove unused SSL_FAST code. That approach cannot work in modern libgcrypt anyway since the symbols were renamed and private to libgcrypt. The RSA decryption routine is not even a hot path, it is only called for decrypting the encrypted pre-master secret. While at it, expand the SSL_PRIVATE_KEY macro and remove its definition. Change-Id: Ied556d18501ea6cbac5fb27218364b3479ad62ce Reviewed-on: https://code.wireshark.org/review/9572 Reviewed-by: Martin Kaiser Reviewed-by: Peter Wu Actions performed: from c8c8eef zvt: handle multi-byte tags adds 79be831 ssl-utils: remove unused, broken libgcrypt code Summary of changes: epan/dissectors/packet-ssl-utils.c | 38 epan/dissectors/packet-ssl-utils.h | 17 2 files changed, 12 insertions(+), 43 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 85f8a99: ssl-utils: fix failing decryption for some RSA keys
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=85f8a99f354850d5fbf774b04e9721195614d7d8 Submitter: Peter Wu (pe...@lekensteyn.nl) Changed: branch: master Repository: wireshark Commits: 85f8a99 by Peter Wu (pe...@lekensteyn.nl): ssl-utils: fix failing decryption for some RSA keys Reported at https://ask.wireshark.org/questions/43788/struggling-to-decrypt-ssl "u" requirement is documented at https://www.gnupg.org/documentation/manuals/gcrypt/RSA-key-parameters.html#RSA-key-parameters Add regression test (key is generated manually with p and q swapped and qInv recalculated). Change-Id: I5505ddcdb54bb47d7a58867b8c3e53fcc0f66dde Reviewed-on: https://code.wireshark.org/review/9573 Tested-by: Peter Wu Reviewed-by: Peter Wu Actions performed: from 79be831 ssl-utils: remove unused, broken libgcrypt code adds 85f8a99 ssl-utils: fix failing decryption for some RSA keys Summary of changes: epan/dissectors/packet-ssl-utils.c |5 + test/captures/rsa-p-lt-q.pcap | Bin 0 -> 2111 bytes test/keys/rsa-p-lt-q.key | 15 +++ test/suite-decryption.sh | 16 4 files changed, 36 insertions(+) create mode 100644 test/captures/rsa-p-lt-q.pcap create mode 100644 test/keys/rsa-p-lt-q.key ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 4a39706: On OS X, add the Qt -Wl, -rpath hack in CMake, as we do with autotools.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a39706272a59d43530e038f8b20436e2c3052ce Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 4a39706 by Guy Harris (g...@alum.mit.edu): On OS X, add the Qt -Wl,-rpath hack in CMake, as we do with autotools. Change-Id: I281e1bf790b7eefbbd43a3406622262cfe8b36df Reviewed-on: https://code.wireshark.org/review/9651 Reviewed-by: Guy Harris Actions performed: from 85f8a99 ssl-utils: fix failing decryption for some RSA keys adds 4a39706 On OS X, add the Qt -Wl,-rpath hack in CMake, as we do with autotools. Summary of changes: CMakeLists.txt | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0744e67: Check for a valid pointer when ignoring a frame.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0744e677d3d4540ad5233a34667e4e416867732d Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 0744e67 by Gerald Combs (ger...@wireshark.org): Check for a valid pointer when ignoring a frame. Change-Id: I1a4a6b3f729c818a68bee1b6b8de3778130252a4 Reviewed-on: https://code.wireshark.org/review/9652 Reviewed-by: Gerald Combs Actions performed: from 4a39706 On OS X, add the Qt -Wl,-rpath hack in CMake, as we do with autotools. adds 0744e67 Check for a valid pointer when ignoring a frame. Summary of changes: ui/qt/packet_list.cpp |1 + 1 file changed, 1 insertion(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 5523726: WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to walk a packet and protect against a really big tag value
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5523726e6960fe9d7e301376fd7a94599f65fd42 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 5523726 by Michael Mann (mman...@netscape.net): WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to walk a packet and protect against a really big tag value Ping-Bug: 11358 Change-Id: I9ecb5fe6bcd7f25c763d968bf56fb2d9bce2180c Reviewed-on: https://code.wireshark.org/review/9639 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Actions performed: from 0744e67 Check for a valid pointer when ignoring a frame. adds 5523726 WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to walk a packet and protect against a really big tag value Summary of changes: epan/dissectors/packet-waveagent.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 2e215db: Revert "On OS X, add the Qt -Wl, -rpath hack in CMake, as we do with autotools."
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e215db532f408697ba16f2d83524a64cc9e6424 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 2e215db by Guy Harris (g...@alum.mit.edu): Revert "On OS X, add the Qt -Wl,-rpath hack in CMake, as we do with autotools." This reverts commit 4a39706272a59d43530e038f8b20436e2c3052ce. At least in one quick check, CMake 2.8.12.2 added that already with Qt 5.5.0. Change-Id: Iabf0e4aa0aa34b380f981f7d039fb3d95847041e Reviewed-on: https://code.wireshark.org/review/9654 Reviewed-by: Guy Harris Actions performed: from 5523726 WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to walk a packet and protect against a really big tag value adds 2e215db Revert "On OS X, add the Qt -Wl,-rpath hack in CMake, as we do with autotools." Summary of changes: CMakeLists.txt | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master d2acb04: Add the RTP Stream Analysis dialog.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2acb04b4cadd90bf09bdc4959e6bffb25dcfd38 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: d2acb04 by Gerald Combs (ger...@wireshark.org): Add the RTP Stream Analysis dialog. Combine the GTK+ RTP Stream Analysis and RTP Graph Analysis dialogs into one. Yell at the user less. Disable the Analyze RTP Stream menu item if we don't have an RTP stream selected. There are a *lot* of moving parts in this dialog. I've tested with the few RTP captures I have but it's by no means complete. "To do" items are listed at the top of rtp_analysis.cpp. Change-Id: Id503977f069bebc46cc68bc749f0c9cbf4d37bf6 Reviewed-on: https://code.wireshark.org/review/9650 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs Actions performed: from 2e215db Revert "On OS X, add the Qt -Wl,-rpath hack in CMake, as we do with autotools." adds d2acb04 Add the RTP Stream Analysis dialog. Summary of changes: epan/proto.c |5 +- epan/proto.h |3 +- ui/gtk/main_menubar.c |2 +- ui/gtk/rtp_analysis.c | 27 +- ui/qt/CMakeLists.txt |3 + ui/qt/Makefile.am |4 + ui/qt/Makefile.common |4 + ui/qt/Wireshark.pro|3 + ui/qt/color_utils.cpp | 20 +- ui/qt/color_utils.h|1 + ui/qt/follow_stream_dialog.cpp |2 +- ui/qt/io_graph_dialog.cpp | 18 +- ui/qt/main_window.cpp |2 +- ui/qt/main_window.h|1 + ui/qt/main_window.ui |9 + ui/qt/main_window_slots.cpp| 14 +- ui/qt/packet_list.cpp |2 +- ui/qt/qt_ui_utils.cpp |6 +- ui/qt/qt_ui_utils.h|3 +- ui/qt/rtp_analysis_dialog.cpp | 1538 ui/qt/rtp_analysis_dialog.h| 156 ui/qt/rtp_analysis_dialog.ui | 346 + ui/qt/rtp_stream_dialog.cpp|5 +- ui/qt/syntax_line_edit.cpp |2 +- ui/rtp_analysis.h | 10 +- ui/tap-rtp-common.c|2 +- ui/tap-rtp-common.h| 36 +- ui/utf8_entities.h | 19 +- 28 files changed, 2183 insertions(+), 60 deletions(-) create mode 100644 ui/qt/rtp_analysis_dialog.cpp create mode 100644 ui/qt/rtp_analysis_dialog.h create mode 100644 ui/qt/rtp_analysis_dialog.ui ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 78bc3dd: GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=78bc3dd93a562ca1b1c5dbc8f71d2967008be7ed Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: 78bc3dd by Pascal Quantin (pascal.quan...@gmail.com): GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header Change-Id: Ibba32a2860f80979ee9df3caeeaeda14fde7e7d0 Ping-Bug: 11358 Reviewed-on: https://code.wireshark.org/review/9649 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Reviewed-by: Pascal Quantin Actions performed: from d2acb04 Add the RTP Stream Analysis dialog. adds 78bc3dd GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header Summary of changes: epan/dissectors/packet-gsm_rlcmac.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-1.12 6be36c1: GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6be36c11d0553d8fe63b663ae539a9910bebfc68 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master-1.12 Repository: wireshark Commits: 6be36c1 by Pascal Quantin (pascal.quan...@gmail.com): GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header Change-Id: Ibba32a2860f80979ee9df3caeeaeda14fde7e7d0 Ping-Bug: 11358 Reviewed-on: https://code.wireshark.org/review/9649 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Reviewed-by: Pascal Quantin (cherry picked from commit 78bc3dd93a562ca1b1c5dbc8f71d2967008be7ed) Conflicts: epan/dissectors/packet-gsm_rlcmac.c Reviewed-on: https://code.wireshark.org/review/9656 Actions performed: from 6cb9d38 Openflow - prevent infinite loop adds 6be36c1 GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header Summary of changes: epan/dissectors/packet-gsm_rlcmac.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-1.12 5411d70: epl: Make detection of duplication frame optional
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5411d70e2ea8b90932161605b7576590d5c2eb5b Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master-1.12 Repository: wireshark Commits: 5411d70 by Roland Knall (roland.kn...@br-automation.com): epl: Make detection of duplication frame optional The detection seems to work in most cases, but the number of false-positive detections is still very high (around 20%) Therefore the detection is changed to optional, with an option to enable it if necessary. Bug: 11341 Change-Id: I94ed281b826c80674e6fce09bdd0bd9c12a0ff79 Reviewed-on: https://code.wireshark.org/review/9657 Reviewed-by: Roland Knall Reviewed-by: Pascal Quantin Actions performed: from 6be36c1 GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header adds 5411d70 epl: Make detection of duplication frame optional Summary of changes: epan/dissectors/packet-epl.c | 212 ++ 1 file changed, 110 insertions(+), 102 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 6d33c12: Add display_is_remote.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6d33c124d55c1fdbe8225e82256b77e8f0a13e3c Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 6d33c12 by Gerald Combs (ger...@wireshark.org): Add display_is_remote. Add a display_is_remote function and use it instead of get_conn_cfilter to check for remoteness. Change-Id: Ia93d113afec36ede55daf7dc8394b2dc0d8c9abf Reviewed-on: https://code.wireshark.org/review/9659 Reviewed-by: Gerald Combs Actions performed: from 78bc3dd GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header adds 6d33c12 Add display_is_remote. Summary of changes: ui/qt/accordion_frame.cpp |4 ++-- ui/qt/splash_overlay.cpp |2 +- ui/util.c | 11 +++ ui/util.h |5 + 4 files changed, 19 insertions(+), 3 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master da91443: LTE RRC: fix dissection of ETWS/CMAS warning messages
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=da914431ce2d4e5b154b1491490a54d1de15366f Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: da91443 by Pascal Quantin (pascal.quan...@gmail.com): LTE RRC: fix dissection of ETWS/CMAS warning messages Change-Id: I20bb219a32b6c7e39ac415c5c13ad5379f78cba2 Reviewed-on: https://code.wireshark.org/review/9658 Petri-Dish: Pascal Quantin Reviewed-by: Pascal Quantin Actions performed: from 6d33c12 Add display_is_remote. adds da91443 LTE RRC: fix dissection of ETWS/CMAS warning messages Summary of changes: asn1/lte-rrc/lte-rrc.cnf | 44 - asn1/lte-rrc/packet-lte-rrc-template.c | 194 +- epan/dissectors/packet-lte-rrc.c | 284 ++-- 3 files changed, 501 insertions(+), 21 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-1.12 c911b08: LTE RRC: fix dissection of ETWS/CMAS warning messages
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c911b089661e07d553b60613eac65715a8c79583 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master-1.12 Repository: wireshark Commits: c911b08 by Pascal Quantin (pascal.quan...@gmail.com): LTE RRC: fix dissection of ETWS/CMAS warning messages Change-Id: I20bb219a32b6c7e39ac415c5c13ad5379f78cba2 Reviewed-on: https://code.wireshark.org/review/9660 Reviewed-by: Pascal Quantin Actions performed: from 5411d70 epl: Make detection of duplication frame optional adds c911b08 LTE RRC: fix dissection of ETWS/CMAS warning messages Summary of changes: asn1/lte-rrc/lte-rrc.cnf | 44 - asn1/lte-rrc/packet-lte-rrc-template.c | 192 +- epan/dissectors/packet-lte-rrc.c | 282 ++-- 3 files changed, 497 insertions(+), 21 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 6fcfb5e: Add support to the SMB2 protocol for one of the proposals for POSIX Extensions to the SMB2 protocol.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6fcfb5ed56c09af30ed50c4fe41103436f8b91cc Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 6fcfb5e by Richard Sharpe (rsha...@samba.org): Add support to the SMB2 protocol for one of the proposals for POSIX Extensions to the SMB2 protocol. I am submitting this purely so that it is available for others to play with. Change-Id: I379b9da90731cc61ce38a1fdf21dc7c09d0d114e Signed-off-by: Richard Sharpe Reviewed-on: https://code.wireshark.org/review/9496 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Evan Huus Reviewed-by: Michael Mann Actions performed: from da91443 LTE RRC: fix dissection of ETWS/CMAS warning messages adds 6fcfb5e Add support to the SMB2 protocol for one of the proposals for POSIX Extensions to the SMB2 protocol. Summary of changes: epan/dissectors/packet-smb2.c | 193 - 1 file changed, 191 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0801cd3: DTLS: fix compilation without libgcrypt or libgnutls
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0801cd399f4e21a57944fa71a24bcb7f21dc3af0 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: 0801cd3 by Pascal Quantin (pascal.quan...@gmail.com): DTLS: fix compilation without libgcrypt or libgnutls Change-Id: I571f1ddaaa9579af65d558afc7162493a7393703 Reviewed-on: https://code.wireshark.org/review/9661 Reviewed-by: Pascal Quantin Actions performed: from 6fcfb5e Add support to the SMB2 protocol for one of the proposals for POSIX Extensions to the SMB2 protocol. adds 0801cd3 DTLS: fix compilation without libgcrypt or libgnutls Summary of changes: epan/dissectors/packet-dtls.c |4 1 file changed, 4 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master b1e0f43: One definition of the same typedef suffices.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1e0f439e1231b4bb3feff5d6449a6ca56c016da Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: b1e0f43 by Guy Harris (g...@alum.mit.edu): One definition of the same typedef suffices. Change-Id: Ic221bf911f6de9bc94278350e0642143d14f6e82 Reviewed-on: https://code.wireshark.org/review/9662 Reviewed-by: Guy Harris Actions performed: from 0801cd3 DTLS: fix compilation without libgcrypt or libgnutls adds b1e0f43 One definition of the same typedef suffices. Summary of changes: epan/dissectors/packet-smb2.c |2 -- 1 file changed, 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 41ed712: Qt: Frame flag updates.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41ed7127a566a2758c8a5a0716ea0276f4182ed0 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 41ed712 by Gerald Combs (ger...@wireshark.org): Qt: Frame flag updates. Move frame flag (mark, ignore, ref_time) member functions from PacketList to PacketListModel. They arguably belong there and we can emit dataChanged to signal updates. Rename some variables named "index" since they shadow a function name. Change-Id: I9a731a76e4e63e562b561c29d13915278d5a7dbb Reviewed-on: https://code.wireshark.org/review/9663 Reviewed-by: Gerald Combs Actions performed: from b1e0f43 One definition of the same typedef suffices. adds 41ed712 Qt: Frame flag updates. Summary of changes: ui/qt/packet_list.cpp| 122 + ui/qt/packet_list.h |3 - ui/qt/packet_list_model.cpp | 125 ++ ui/qt/packet_list_model.h| 12 +++- ui/qt/packet_list_record.cpp |1 + 5 files changed, 137 insertions(+), 126 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0b11d5d: Win32: fix generation of NSIS installer when compiling with Qt 5.5
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b11d5dc75f3d8fb4de1c5d4274732c0780e20e3 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: 0b11d5d by Pascal Quantin (pascal.quan...@gmail.com): Win32: fix generation of NSIS installer when compiling with Qt 5.5 *.qm files are now in a translations subfolder Change-Id: I233152cd2662aec7072769e27f7a278c6890d8ec Reviewed-on: https://code.wireshark.org/review/9646 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin Actions performed: from 41ed712 Qt: Frame flag updates. adds 0b11d5d Win32: fix generation of NSIS installer when compiling with Qt 5.5 Summary of changes: packaging/nsis/uninstall.nsi |2 ++ packaging/nsis/wireshark.nsi | 24 +++- 2 files changed, 25 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master d23ff4f: Qt: remove unused parameters
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d23ff4f5f8f48ed1b8d3c4d902ef508cce48c454 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: d23ff4f by Pascal Quantin (pascal.quan...@gmail.com): Qt: remove unused parameters Change-Id: I45fcf87f99dc15eb49343119fa134fb5698b15cf Reviewed-on: https://code.wireshark.org/review/9664 Reviewed-by: Pascal Quantin Actions performed: from 0b11d5d Win32: fix generation of NSIS installer when compiling with Qt 5.5 adds d23ff4f Qt: remove unused parameters Summary of changes: ui/qt/resolved_addresses_dialog.cpp |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
