Re: [Xen-devel] [PATCH] xen-netfront: Remove the meaningless code

2015-06-28 Thread David Miller
From: David Vrabel david.vra...@citrix.com
Date: Fri, 26 Jun 2015 16:15:18 +0100

 On 27/06/15 00:17, Liang Li wrote:
 The function netif_set_real_num_tx_queues() will return -EINVAL if
 the second parameter  1, so call this function with the second
 parameter set to 0 is meaningless.
 
 Reviewed-by: David Vrabel david.vra...@citrix.com

Applied.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH] xen-netfront: Remove the meaningless code

2015-06-26 Thread David Vrabel
On 27/06/15 00:17, Liang Li wrote:
 The function netif_set_real_num_tx_queues() will return -EINVAL if
 the second parameter  1, so call this function with the second
 parameter set to 0 is meaningless.

Reviewed-by: David Vrabel david.vra...@citrix.com

David

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [PATCH] xen-netfront: Remove the meaningless code

2015-06-26 Thread Liang Li
The function netif_set_real_num_tx_queues() will return -EINVAL if
the second parameter  1, so call this function with the second
parameter set to 0 is meaningless.

Signed-off-by: Liang Li liang.z...@intel.com
---
 drivers/net/xen-netfront.c | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 56d8afd..1807cd1 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1245,10 +1245,6 @@ static struct net_device *xennet_create_dev(struct 
xenbus_device *dev)
np   = netdev_priv(netdev);
np-xbdev= dev;
 
-   /* No need to use rtnl_lock() before the call below as it
-* happens before register_netdev().
-*/
-   netif_set_real_num_tx_queues(netdev, 0);
np-queues = NULL;
 
err = -ENOMEM;
@@ -1900,9 +1896,6 @@ abort_transaction_no_dev_fatal:
xennet_disconnect_backend(info);
kfree(info-queues);
info-queues = NULL;
-   rtnl_lock();
-   netif_set_real_num_tx_queues(info-netdev, 0);
-   rtnl_unlock();
  out:
return err;
 }
-- 
1.9.1


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel