Re: [PATCH xserver 0/7] xwin: misc small fixes

2017-08-22 Thread Emil Velikov 
On 14 August 2017 at 18:15, Jon Turney  wrote:
> On 03/08/2017 20:15, Emil Velikov wrote:
>>
>> Hi all,
>>
>> Here's a few small cleanups that I had lying around for months.
>> Patches are dead trivial, although completely untested.
>>
>> Please review,
>
>
> Thanks very much for doing this.  Getting rid of those conditionals has been
> on my todo list for a long time...
>
> With the small corrections noted for 4/7 and 5/7,
>
> Reviewed-by: Jon Turney 
>
Thanks Jon. I've spotted a small issue in 7/7 so I've respinned/resent
the whole series with your comments addressed.

-Emil
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 0/7] xwin: misc small fixes

2017-08-14 Thread Jon Turney 

On 03/08/2017 20:15, Emil Velikov wrote:

Hi all,

Here's a few small cleanups that I had lying around for months.
Patches are dead trivial, although completely untested.

Please review,


Thanks very much for doing this.  Getting rid of those conditionals has 
been on my todo list for a long time...


With the small corrections noted for 4/7 and 5/7,

Reviewed-by: Jon Turney 

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 0/7] xwin: misc small fixes

2017-08-03 Thread Emil Velikov 
Hi all,

Here's a few small cleanups that I had lying around for months.
Patches are dead trivial, although completely untested.

Please review,
Emil


Emil Velikov (7):
  xwin/glx: remove unused __GLXWinScreen::glx_enable_bits
  os: make GenerateRandomData() independent of XCSECURITY
  os: make MitGenerateCookie() independent of XCSECURITY
  xwin: remove always true/set XWIN_CLIPBOARD conditional/define
  xwin: remove always true/set XWIN_MULTIWINDOW conditional/define
  xwin: remove always true/set XWIN_RANDR conditional/define
  xwin: automake: remove unused {SRCS,DEFS}_{NATIVEGDI,PRIMARYFB}

 configure.ac  |  3 ---
 hw/xwin/InitInput.c   |  4 
 hw/xwin/InitOutput.c  | 17 -
 hw/xwin/Makefile.am   | 21 +++--
 hw/xwin/glx/Makefile.am   |  8 +++-
 hw/xwin/glx/indirect.h|  3 ---
 hw/xwin/glx/meson.build   |  1 -
 hw/xwin/glx/winpriv.c |  4 
 hw/xwin/meson.build   |  4 
 hw/xwin/win.h | 22 --
 hw/xwin/winauth.c | 36 
 hw/xwin/winblock.c|  4 
 hw/xwin/wincreatewnd.c| 14 --
 hw/xwin/wincursor.c   |  2 --
 hw/xwin/windialogs.c  |  8 
 hw/xwin/winengine.c   |  2 --
 hw/xwin/winerror.c|  4 
 hw/xwin/winglobals.c  |  2 --
 hw/xwin/winglobals.h  |  7 ---
 hw/xwin/winkeyhook.c  |  2 --
 hw/xwin/winmultiwindowicons.c |  2 --
 hw/xwin/winprefs.c| 10 --
 hw/xwin/winprocarg.c  | 24 
 hw/xwin/winrandr.c|  2 --
 hw/xwin/winscrinit.c  | 12 +---
 hw/xwin/winshadddnl.c |  2 --
 hw/xwin/winshadgdi.c  | 16 
 hw/xwin/wintrayicon.c |  8 
 hw/xwin/winvalargs.c  |  9 +
 hw/xwin/winwindow.h   |  2 --
 hw/xwin/winwndproc.c  | 16 
 os/auth.c |  4 ++--
 os/mitauth.c  |  4 
 33 files changed, 10 insertions(+), 269 deletions(-)

-- 
2.13.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel