[Yahoo-eng-team] [Bug 1967686] Re: [DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI middleware
** Changed in: ec2-api Assignee: (unassigned) => Takashi Kajinami (kajinamit) ** No longer affects: ec2-api -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1967686 Title: [DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI middleware Status in Cinder: In Progress Status in OpenStack Shared File Systems Service (Manila): In Progress Status in OpenStack Compute (nova): In Progress Bug description: The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header. However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library. Now the HTTPProxyToWSGI middleware is enabled in api pipeline by default, and also is globally used by multiple components, the own use_forwarded_for parameter can be removed. To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1967686/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1967686] Re: [DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI middleware
** Also affects: ec2-api Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1967686 Title: [DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI middleware Status in Cinder: In Progress Status in OpenStack Shared File Systems Service (Manila): In Progress Status in OpenStack Compute (nova): In Progress Bug description: The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header. However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library. Now the HTTPProxyToWSGI middleware is enabled in api pipeline by default, and also is globally used by multiple components, the own use_forwarded_for parameter can be removed. To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1967686/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1967686] [NEW] [DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI middleware
Public bug reported: The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header. However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library. Now the HTTPProxyToWSGI middleware is enabled in api pipeline by default, and also is globally used by multiple components, the own use_forwarded_for parameter can be removed. ** Affects: cinder Importance: Undecided Assignee: Takashi Kajinami (kajinamit) Status: In Progress ** Affects: manila Importance: Undecided Assignee: Takashi Kajinami (kajinamit) Status: In Progress ** Affects: nova Importance: Undecided Assignee: Takashi Kajinami (kajinamit) Status: In Progress ** Also affects: nova Importance: Undecided Status: New ** Also affects: manila Importance: Undecided Status: New ** Changed in: cinder Assignee: (unassigned) => Takashi Kajinami (kajinamit) ** Changed in: nova Assignee: (unassigned) => Takashi Kajinami (kajinamit) ** Changed in: manila Assignee: (unassigned) => Takashi Kajinami (kajinamit) ** Description changed: The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header. - However this functionality is duplicate of the HTTPProxyToWSGI middleware. + However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library. Now the HTTPProxyToWSGI middleware is enabled in api pipeline by default, and also is globally used by multiple components, the own use_forwarded_for parameter can be removed. -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1967686 Title: [DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI middleware Status in Cinder: In Progress Status in OpenStack Shared File Systems Service (Manila): In Progress Status in OpenStack Compute (nova): In Progress Bug description: The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header. However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library. Now the HTTPProxyToWSGI middleware is enabled in api pipeline by default, and also is globally used by multiple components, the own use_forwarded_for parameter can be removed. To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1967686/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1967683] Re: Wrong property to look up remote address
** Also affects: masakari Importance: Undecided Status: New ** No longer affects: masakari ** Changed in: cinder Assignee: (unassigned) => Takashi Kajinami (kajinamit) ** Changed in: nova Assignee: (unassigned) => Takashi Kajinami (kajinamit) ** Changed in: manila Assignee: (unassigned) => Takashi Kajinami (kajinamit) ** Changed in: ec2-api Assignee: (unassigned) => Takashi Kajinami (kajinamit) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1967683 Title: Wrong property to look up remote address Status in Cinder: In Progress Status in ec2-api: In Progress Status in OpenStack Shared File Systems Service (Manila): In Progress Status in OpenStack Compute (nova): In Progress Bug description: Currently, remote_address attribute of the Reqeust object is used to look up client address in multiple places. eg. https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64 ~~~ def _set_request_context(req, **kwargs): """Sets request context based on parameters and request.""" remote_address = getattr(req, 'remote_address', '127.0.0.1') ~~~ However, webob.Request has no remote_address attribute but only remote_addr attribute. https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1967683/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1967683] Re: Wrong property to look up remote address
** Also affects: ec2-api Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1967683 Title: Wrong property to look up remote address Status in Cinder: In Progress Status in ec2-api: In Progress Status in OpenStack Shared File Systems Service (Manila): In Progress Status in OpenStack Compute (nova): In Progress Bug description: Currently, remote_address attribute of the Reqeust object is used to look up client address in multiple places. eg. https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64 ~~~ def _set_request_context(req, **kwargs): """Sets request context based on parameters and request.""" remote_address = getattr(req, 'remote_address', '127.0.0.1') ~~~ However, webob.Request has no remote_address attribute but only remote_addr attribute. https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1967683/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1967683] Re: Wrong property to look up remote address
** Also affects: manila Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1967683 Title: Wrong property to look up remote address Status in Cinder: In Progress Status in ec2-api: In Progress Status in OpenStack Shared File Systems Service (Manila): In Progress Status in OpenStack Compute (nova): In Progress Bug description: Currently, remote_address attribute of the Reqeust object is used to look up client address in multiple places. eg. https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64 ~~~ def _set_request_context(req, **kwargs): """Sets request context based on parameters and request.""" remote_address = getattr(req, 'remote_address', '127.0.0.1') ~~~ However, webob.Request has no remote_address attribute but only remote_addr attribute. https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1967683/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1967683] [NEW] Wrong property to look up remote address
Public bug reported: Currently, remote_address attribute of the Reqeust object is used to look up client address in multiple places. eg. https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64 ~~~ def _set_request_context(req, **kwargs): """Sets request context based on parameters and request.""" remote_address = getattr(req, 'remote_address', '127.0.0.1') ~~~ However, webob.Request has no remote_address attribute but only remote_addr attribute. https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr ** Affects: cinder Importance: Undecided Status: In Progress ** Affects: nova Importance: Undecided Status: New ** Also affects: nova Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1967683 Title: Wrong property to look up remote address Status in Cinder: In Progress Status in OpenStack Compute (nova): New Bug description: Currently, remote_address attribute of the Reqeust object is used to look up client address in multiple places. eg. https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64 ~~~ def _set_request_context(req, **kwargs): """Sets request context based on parameters and request.""" remote_address = getattr(req, 'remote_address', '127.0.0.1') ~~~ However, webob.Request has no remote_address attribute but only remote_addr attribute. https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1967683/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
