[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827224#comment-13827224 ] Hadoop QA commented on YARN-1181: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610205/yarn-1181-2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart org.apache.hadoop.yarn.server.TestMiniYARNClusterForHA {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2491//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2491//console This message is automatically generated. > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828071#comment-13828071 ] Karthik Kambatla commented on YARN-1181: Will take a look at the failed tests in a couple of days. > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835310#comment-13835310 ] Hadoop QA commented on YARN-1181: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12616356/yarn-1181-3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: org.apache.hadoop.yarn.server.TestContainerManagerSecurity org.apache.hadoop.yarn.server.TestRMNMSecretKeys {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2564//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2564//console This message is automatically generated. > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837051#comment-13837051 ] Karthik Kambatla commented on YARN-1181: The failing tests are unrelated - YARN-1463 and YARN-1464 respectively. > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837183#comment-13837183 ] Hadoop QA commented on YARN-1181: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12616645/yarn-1181-4.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: org.apache.hadoop.yarn.server.TestContainerManagerSecurity org.apache.hadoop.yarn.server.TestRMNMSecretKeys {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2575//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2575//console This message is automatically generated. > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838293#comment-13838293 ] Sandy Ryza commented on YARN-1181: -- Just a few stylistic comments. {code} +if (resourceManagers.length == 1) + return 0; {code} Should have curly braces. {code} +} catch (IOException e) { + throw new YarnRuntimeException("Couldn't read the status of " + + "a ResourceManger in the HA ensemble."); +} {code} We should include the original exception as the cause? {code} +super.serviceInit(conf instanceof YarnConfiguration +? conf +: new YarnConfiguration(conf)); {code} Unless this was intentional, can move the last two lines onto the same line. {code} + @InterfaceAudience.Private + int getActiveRMIndex() { {code} Can we add short doc to this method that explains what it's doing / that it can take some time? {code} +assertFalse("RM never turned active", -1 == cluster.getActiveRMIndex()); {code} Should use assertNotEqual > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838444#comment-13838444 ] Hadoop QA commented on YARN-1181: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12616901/yarn-1181-5.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: org.apache.hadoop.yarn.server.TestContainerManagerSecurity org.apache.hadoop.yarn.server.TestRMNMSecretKeys {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2592//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2592//console This message is automatically generated. > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch, yarn-1181-5.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838534#comment-13838534 ] Karthik Kambatla commented on YARN-1181: Again, the test failures are unrelated to this patch. > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch, yarn-1181-5.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839519#comment-13839519 ] Sandy Ryza commented on YARN-1181: -- +1 > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch, yarn-1181-5.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840721#comment-13840721 ] Karthik Kambatla commented on YARN-1181: Thanks for the review, Sandy. Just committed this to trunk and branch-2. > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch, yarn-1181-5.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840747#comment-13840747 ] Hudson commented on YARN-1181: -- SUCCESS: Integrated in Hadoop-trunk-Commit #4841 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4841/]) YARN-1181. Augment MiniYARNCluster to support HA mode (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1548330) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYARNClusterForHA.java > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Fix For: 2.4.0 > > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch, yarn-1181-5.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841186#comment-13841186 ] Hudson commented on YARN-1181: -- FAILURE: Integrated in Hadoop-Yarn-trunk #413 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/413/]) YARN-1181. Augment MiniYARNCluster to support HA mode (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1548330) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYARNClusterForHA.java > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Fix For: 2.4.0 > > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch, yarn-1181-5.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841253#comment-13841253 ] Hudson commented on YARN-1181: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1630 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1630/]) YARN-1181. Augment MiniYARNCluster to support HA mode (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1548330) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYARNClusterForHA.java > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Fix For: 2.4.0 > > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch, yarn-1181-5.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1181) Augment MiniYARNCluster to support HA mode
[ https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841270#comment-13841270 ] Hudson commented on YARN-1181: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1604 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1604/]) YARN-1181. Augment MiniYARNCluster to support HA mode (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1548330) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYARNClusterForHA.java > Augment MiniYARNCluster to support HA mode > -- > > Key: YARN-1181 > URL: https://issues.apache.org/jira/browse/YARN-1181 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Karthik Kambatla >Assignee: Karthik Kambatla > Fix For: 2.4.0 > > Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch, > yarn-1181-4.patch, yarn-1181-5.patch > > > MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for > end-to-end HA tests. -- This message was sent by Atlassian JIRA (v6.1#6144)