[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-03-20 Thread Vinod Kumar Vavilapalli (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942406#comment-13942406
 ] 

Vinod Kumar Vavilapalli commented on YARN-1551:
---

Checking the patch for review/commit.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.3.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch, 
> YARN-1551.v06.patch, YARN-1551.v06.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-03-10 Thread Gera Shegalov (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925761#comment-13925761
 ] 

Gera Shegalov commented on YARN-1551:
-

Hi [~vinodkv], are you interested in reviewing this patch, or is [~kkambatl]'s 
review sufficient?

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch, 
> YARN-1551.v06.patch, YARN-1551.v06.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-02-12 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900109#comment-13900109
 ] 

Hadoop QA commented on YARN-1551:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12628673/YARN-1551.v06.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3094//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3094//console

This message is automatically generated.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch, 
> YARN-1551.v06.patch, YARN-1551.v06.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-02-12 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899971#comment-13899971
 ] 

Hadoop QA commented on YARN-1551:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12628624/YARN-1551.v06.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

  org.apache.hadoop.mapreduce.v2.TestUberAM

  The following test timeouts occurred in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

org.apache.hadoop.yarn.client.api.impl.TestNMClient

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3087//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3087//console

This message is automatically generated.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch, 
> YARN-1551.v06.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-02-12 Thread Gera Shegalov (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899833#comment-13899833
 ] 

Gera Shegalov commented on YARN-1551:
-

s/v07/v06 in previous comment.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch, 
> YARN-1551.v06.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-02-12 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899697#comment-13899697
 ] 

Karthik Kambatla commented on YARN-1551:


My previous comment applies to the latest patch as well. Otherwise, +1.

[~vinodkv] - do you have any other comments. Otherwise, can I go ahead and 
commit this later tomorrow? 

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-02-10 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897504#comment-13897504
 ] 

Hadoop QA commented on YARN-1551:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12628129/YARN-1551.v05.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3061//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3061//console

This message is automatically generated.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-02-10 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897409#comment-13897409
 ] 

Karthik Kambatla commented on YARN-1551:


And, of course, we should also look at the test failures and fix any related 
ones. 

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-02-10 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897404#comment-13897404
 ] 

Karthik Kambatla commented on YARN-1551:


The patch looks good to me, but for the following nit: 
# If it is not adding anything, I would remove the if-else
{code}
if (reason == null) {
  client.killApplication(app.getApplicationId());
} else {
  client.killApplication(app.getApplicationId(), reason);
}
{code}

Let us wait for [~vinodkv] also to look at it. 

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch, YARN-1551.v05.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-02-10 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897311#comment-13897311
 ] 

Hadoop QA commented on YARN-1551:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12628082/YARN-1551.v04.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

  org.apache.hadoop.mapreduce.v2.TestUberAM
  org.apache.hadoop.mapreduce.v2.TestMRJobs
  org.apache.hadoop.yarn.client.cli.TestYarnCLI

  The test build failed in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3054//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3054//console

This message is automatically generated.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch, YARN-1551.v04.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-01-14 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871286#comment-13871286
 ] 

Karthik Kambatla commented on YARN-1551:


I am not particular about this, but I think adding reason to killApplication is 
a YARN-feature and can be tested in YARN itself. To test the YARN changes, we 
can add tests to TestClientRMService and TestYarnClient. ResourceMgrDelegate 
and TestMRJobs are changes in MR to leverage this feature can be in an MR JIRA. 

Comments on the patch for YARN changes:
# Can we add InterfaceStability annotations as well as javadoc?
{code}
@Public
public abstract String getReason();

@Public
public abstract void setReason(String reason);
{code}
# Nit: I am not particular on this, instead of a {{null}} reason, something 
like {[N/A}} might be better? 
# The constant MAX_KILL_REASON_LENGTH can be private.
# We need separate javadoc for the new method
{code}

+   * @param reason justification for application kill
* @throws YarnException
*   in case of errors or if YARN rejects the request due to
*   access-control restrictions.
* @throws IOException
* @see #getQueueAclsInfo()
*/
+  public abstract void killApplication(ApplicationId applicationId,
+  String reason) throws YarnException, IOException;
+
{code}



> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-01-13 Thread Gera Shegalov (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869858#comment-13869858
 ] 

Gera Shegalov commented on YARN-1551:
-

[~kkambatl], [~vinodkv], do you have any additional comments?

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-01-02 Thread Gera Shegalov (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861188#comment-13861188
 ] 

Gera Shegalov commented on YARN-1551:
-

Test failure is unrelated. TestYarnClient.testAMMRTokens fails on trunk without 
patch as well.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2014-01-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861163#comment-13861163
 ] 

Hadoop QA commented on YARN-1551:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12621207/YARN-1551.v03.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

  org.apache.hadoop.yarn.client.api.impl.TestYarnClient

  The test build failed in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/2780//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2780//console

This message is automatically generated.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, 
> YARN-1551.v03.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2013-12-31 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859830#comment-13859830
 ] 

Hadoop QA commented on YARN-1551:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12620919/YARN-1551.v02.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

  org.apache.hadoop.yarn.client.cli.TestYarnCLI
  
org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/2767//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2767//console

This message is automatically generated.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2013-12-30 Thread Gera Shegalov (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859036#comment-13859036
 ] 

Gera Shegalov commented on YARN-1551:
-

[~kkambatl], I find it difficult to separate MR code out of this patch. The 
reason is ResourceMgrDelegate extends abstract YarnClient. You are right, the 
test is not YARN-specific but it tests end-to-end cli and YARN-api on a MR-job.

[~vinodkv], thanks for suggestion. I'll work on incorporating a limit here and 
in MAPREDUCE-5648. 

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2013-12-30 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858871#comment-13858871
 ] 

Karthik Kambatla commented on YARN-1551:


We should wrap this JIRA up before MAPREDUCE-5648. 

Just skimmed through the patch. Looks reasonable at first glance. There are 
still map reduce changes in the patch, can we move them to the MR jira? Also, 
we should add some YARN specific tests. 

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication

2013-12-30 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858803#comment-13858803
 ] 

Hadoop QA commented on YARN-1551:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12620843/YARN-1551.v01.patch
  against trunk revision .

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2757//console

This message is automatically generated.

> Allow user-specified reason for killApplication
> ---
>
> Key: YARN-1551
> URL: https://issues.apache.org/jira/browse/YARN-1551
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
> Attachments: YARN-1551.v01.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)