[jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
[
https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185931#comment-14185931
]
Hadoop QA commented on YARN-2753:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12677417/YARN-2753.000.patch
against trunk revision 5b1dfe7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 1287 javac
compiler warnings (more than the trunk's current 1266 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell:
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5584//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/5584//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5584//console
This message is automatically generated.
potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
-
Key: YARN-2753
URL: https://issues.apache.org/jira/browse/YARN-2753
Project: Hadoop YARN
Issue Type: Bug
Reporter: zhihai xu
Assignee: zhihai xu
Attachments: YARN-2753.000.patch
potential NPE(NullPointerException) in checkRemoveLabelsFromNode of
CommonNodeLabelsManager.
It because when a Node is created, Node.labels can be null.
In this case, nm.labels; may be null.
So we need check originalLabels not null before use
it(originalLabels.containsAll).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
[
https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185977#comment-14185977
]
Wangda Tan commented on YARN-2753:
--
[~zxu],
Nice finding! Thanks for the patch, looks good to me. And could you remove
{code}
labels == null
{code}
Of the check,
{code}
if (labels == null || labels.isEmpty()) {
continue;
}
{code}
In the patch together? Since the labels will never be null.
Thanks,
Wangda
potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
-
Key: YARN-2753
URL: https://issues.apache.org/jira/browse/YARN-2753
Project: Hadoop YARN
Issue Type: Bug
Reporter: zhihai xu
Assignee: zhihai xu
Attachments: YARN-2753.000.patch
potential NPE(NullPointerException) in checkRemoveLabelsFromNode of
CommonNodeLabelsManager.
It because when a Node is created, Node.labels can be null.
In this case, nm.labels; may be null.
So we need check originalLabels not null before use
it(originalLabels.containsAll).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186047#comment-14186047 ] zhihai xu commented on YARN-2753: - [~leftnoteasy], thanks to review the patch, I remove labels == null in the new patch YARN-2753.001.patch. potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager - Key: YARN-2753 URL: https://issues.apache.org/jira/browse/YARN-2753 Project: Hadoop YARN Issue Type: Sub-task Reporter: zhihai xu Assignee: zhihai xu Attachments: YARN-2753.000.patch, YARN-2753.001.patch potential NPE(NullPointerException) in checkRemoveLabelsFromNode of CommonNodeLabelsManager. It because when a Node is created, Node.labels can be null. In this case, nm.labels; may be null. So we need check originalLabels not null before use it(originalLabels.containsAll). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
[
https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186125#comment-14186125
]
Hadoop QA commented on YARN-2753:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12677455/YARN-2753.001.patch
against trunk revision 00b4e44.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5591//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5591//console
This message is automatically generated.
potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
-
Key: YARN-2753
URL: https://issues.apache.org/jira/browse/YARN-2753
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: zhihai xu
Assignee: zhihai xu
Attachments: YARN-2753.000.patch, YARN-2753.001.patch
potential NPE(NullPointerException) in checkRemoveLabelsFromNode of
CommonNodeLabelsManager.
It because when a Node is created, Node.labels can be null.
In this case, nm.labels; may be null.
So we need check originalLabels not null before use
it(originalLabels.containsAll).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
[
https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186276#comment-14186276
]
zhihai xu commented on YARN-2753:
-
I added a unit test in new patch YARN-2753.002.patch, without the fix, there
will be NPE :
{code}
java.lang.NullPointerException: null
at
org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.checkRemoveLabelsFromNode(CommonNodeLabelsManager.java:461)
at
org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.removeLabelsFromNode(CommonNodeLabelsManager.java:516)
at
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.RMNodeLabelsManager.removeLabelsFromNode(RMNodeLabelsManager.java:139)
at
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.TestRMNodeLabelsManager.testRemoveLabelsFromNode(TestRMNodeLabelsManager.java:412)
{code}
potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
-
Key: YARN-2753
URL: https://issues.apache.org/jira/browse/YARN-2753
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: zhihai xu
Assignee: zhihai xu
Attachments: YARN-2753.000.patch, YARN-2753.001.patch,
YARN-2753.002.patch
potential NPE(NullPointerException) in checkRemoveLabelsFromNode of
CommonNodeLabelsManager.
It because when a Node is created, Node.labels can be null.
In this case, nm.labels; may be null.
So we need check originalLabels not null before use
it(originalLabels.containsAll).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
[
https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186279#comment-14186279
]
Hadoop QA commented on YARN-2753:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12677509/YARN-2753.002.patch
against trunk revision f6b963f.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5598//console
This message is automatically generated.
potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
-
Key: YARN-2753
URL: https://issues.apache.org/jira/browse/YARN-2753
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: zhihai xu
Assignee: zhihai xu
Attachments: YARN-2753.000.patch, YARN-2753.001.patch,
YARN-2753.002.patch
potential NPE(NullPointerException) in checkRemoveLabelsFromNode of
CommonNodeLabelsManager.
It because when a Node is created, Node.labels can be null.
In this case, nm.labels; may be null.
So we need check originalLabels not null before use
it(originalLabels.containsAll).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
[
https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186411#comment-14186411
]
Hadoop QA commented on YARN-2753:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12677530/YARN-2753.003.patch
against trunk revision 971e91c.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5599//console
This message is automatically generated.
potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
-
Key: YARN-2753
URL: https://issues.apache.org/jira/browse/YARN-2753
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: zhihai xu
Assignee: zhihai xu
Attachments: YARN-2753.000.patch, YARN-2753.001.patch,
YARN-2753.002.patch, YARN-2753.003.patch
potential NPE(NullPointerException) in checkRemoveLabelsFromNode of
CommonNodeLabelsManager.
It because when a Node is created, Node.labels can be null.
In this case, nm.labels; may be null.
So we need check originalLabels not null before use
it(originalLabels.containsAll).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2753) potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186421#comment-14186421 ] zhihai xu commented on YARN-2753: - Hi [~leftnoteasy], I merged the patch in YARN-2759 into the new patch YARN-2753.003.patch because both patches touched same files. thanks zhihai potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager - Key: YARN-2753 URL: https://issues.apache.org/jira/browse/YARN-2753 Project: Hadoop YARN Issue Type: Sub-task Reporter: zhihai xu Assignee: zhihai xu Attachments: YARN-2753.000.patch, YARN-2753.001.patch, YARN-2753.002.patch, YARN-2753.003.patch potential NPE(NullPointerException) in checkRemoveLabelsFromNode of CommonNodeLabelsManager. It because when a Node is created, Node.labels can be null. In this case, nm.labels; may be null. So we need check originalLabels not null before use it(originalLabels.containsAll). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
