[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259776#comment-14259776
]
Yi Liu commented on YARN-2993:
--
Thanks [~djp] for the review and commit.
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Fix For: 2.7.0
>
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259386#comment-14259386
]
Hudson commented on YARN-2993:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2005 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2005/])
YARN-2993. Several fixes (missing acl check, error log msg ...) and some
refinement in AdminService. (Contributed by Yi Liu) (junping_du: rev
40ee4bff65b2bfdabfd16ee7d9be3382a0476565)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
* hadoop-yarn-project/CHANGES.txt
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259382#comment-14259382
]
Hudson commented on YARN-2993:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #55 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/55/])
YARN-2993. Several fixes (missing acl check, error log msg ...) and some
refinement in AdminService. (Contributed by Yi Liu) (junping_du: rev
40ee4bff65b2bfdabfd16ee7d9be3382a0476565)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259374#comment-14259374
]
Hudson commented on YARN-2993:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #51 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/51/])
YARN-2993. Several fixes (missing acl check, error log msg ...) and some
refinement in AdminService. (Contributed by Yi Liu) (junping_du: rev
40ee4bff65b2bfdabfd16ee7d9be3382a0476565)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
* hadoop-yarn-project/CHANGES.txt
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259369#comment-14259369
]
Hudson commented on YARN-2993:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1986 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1986/])
YARN-2993. Several fixes (missing acl check, error log msg ...) and some
refinement in AdminService. (Contributed by Yi Liu) (junping_du: rev
40ee4bff65b2bfdabfd16ee7d9be3382a0476565)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259354#comment-14259354
]
Hudson commented on YARN-2993:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #788 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/788/])
YARN-2993. Several fixes (missing acl check, error log msg ...) and some
refinement in AdminService. (Contributed by Yi Liu) (junping_du: rev
40ee4bff65b2bfdabfd16ee7d9be3382a0476565)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259348#comment-14259348
]
Hudson commented on YARN-2993:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #54 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/54/])
YARN-2993. Several fixes (missing acl check, error log msg ...) and some
refinement in AdminService. (Contributed by Yi Liu) (junping_du: rev
40ee4bff65b2bfdabfd16ee7d9be3382a0476565)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
* hadoop-yarn-project/CHANGES.txt
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259105#comment-14259105
]
Hudson commented on YARN-2993:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6791 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6791/])
YARN-2993. Several fixes (missing acl check, error log msg ...) and some
refinement in AdminService. (Contributed by Yi Liu) (junping_du: rev
40ee4bff65b2bfdabfd16ee7d9be3382a0476565)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258990#comment-14258990
]
Junping Du commented on YARN-2993:
--
The test failure and findbugs warning should be unrelated.
+1. The patch looks good to me. Will commit it soon.
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258929#comment-14258929
]
Yi Liu commented on YARN-2993:
--
Findbugs failure is *not related*, also test failure is *not related*
(https://issues.apache.org/jira/browse/YARN-2991).
The patch is direct, no need test case.
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
[
https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258910#comment-14258910
]
Hadoop QA commented on YARN-2993:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689142/YARN-2993.001.patch
against trunk revision a164ce2.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 15 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6193//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6193//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6193//console
This message is automatically generated.
> Several fixes (missing acl check, error log msg ...) and some refinement in
> AdminService
>
>
> Key: YARN-2993
> URL: https://issues.apache.org/jira/browse/YARN-2993
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in
> {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can
> not refresh Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService",
> "ResourceManager is not active. Can not remove labels.");
> throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
> adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine
> it into one common method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
