[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001721#comment-17001721 ] Eric Payne commented on YARN-10009: --- Thanks a lot for the help, [~ebadger] and [~leftnoteasy]! > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.10.1 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Fix For: 3.3.0, 3.2.2, 3.1.4, 2.10.1 > > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.004.patch, YARN-10009.UT.patch, > YARN-10009.branch-2.10.003.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001203#comment-17001203 ] Hadoop QA commented on YARN-10009: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 35s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 55s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 23s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 12s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 18s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 42s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 16m 7s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 27s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 46s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 1m 16s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 14m 17s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 58s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 89m 30s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 50s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}175m 13s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/hadoop:e573ea49085 | | JIRA Issue | YARN-10009 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12989282/YARN-10009.004.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux adb691a5 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / f777cd3 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_232 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.o
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001069#comment-17001069 ] Hudson commented on YARN-10009: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17784 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/17784/]) YARN-10009. In Capacity Scheduler, DRC can treat minimum user limit (ebadger: rev 412035b47a1b0116cb53ce612a61cd087d5edc41) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerWithMultiResourceTypes.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/resource/DominantResourceCalculator.java > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.10.1 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Fix For: 3.3.0 > > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.004.patch, YARN-10009.UT.patch, > YARN-10009.branch-2.10.003.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001030#comment-17001030 ] Eric Payne commented on YARN-10009: --- [~ebadger], thanks for the review. bq. the other divideAndCeil method uses getNumberOfCountableResourceTypes(), while your patch uses getNumberOfKnownResourceTypes(). Is this intentional? Good catch. No, that was not intentional. I made the 2.10 changes first and then just copied those into trunk. In 2.10 getNumberOfKnownResourceTypes() is the norm. I uploaded v004 of the patch for trunk. > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.10.1 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.004.patch, YARN-10009.UT.patch, > YARN-10009.branch-2.10.003.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001029#comment-17001029 ] Eric Badger commented on YARN-10009: Hey [~epayne], it looks like in trunk the other {{divideAndCeil}} method uses {{getNumberOfCountableResourceTypes()}}, while your patch uses {{getNumberOfKnownResourceTypes()}}. Is this intentional? > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.10.1 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.UT.patch, YARN-10009.branch-2.10.003.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000184#comment-17000184 ] Eric Payne commented on YARN-10009: --- This is kind of a blocker for us. Would it be okay if [~ebadger] had a look? > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.10.1 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.UT.patch, YARN-10009.branch-2.10.003.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998290#comment-16998290 ] Eric Payne commented on YARN-10009: --- [~leftnoteasy], any cycles for this? > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.10.1 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.UT.patch, YARN-10009.branch-2.10.003.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993913#comment-16993913 ] Eric Payne commented on YARN-10009: --- [~leftnoteasy], just a gentle reminder, asking you to take another look at this patch. > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.10.1 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.UT.patch, YARN-10009.branch-2.10.003.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990258#comment-16990258 ] Hadoop QA commented on YARN-10009: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-2.10 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 43s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 23s{color} | {color:green} branch-2.10 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 6s{color} | {color:green} branch-2.10 passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 8s{color} | {color:green} branch-2.10 passed with JDK v1.8.0_222 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 5s{color} | {color:green} branch-2.10 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 56s{color} | {color:green} branch-2.10 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 4s{color} | {color:green} branch-2.10 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 39s{color} | {color:green} branch-2.10 passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s{color} | {color:green} branch-2.10 passed with JDK v1.8.0_222 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 36s{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 58s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 58s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 49s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 11 unchanged - 6 fixed = 14 total (was 17) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 17s{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 6s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 65m 59s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 46s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}140m 18s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/hadoop:1c7ae55d7d3 | | JIRA Issue | YARN-10009 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987784/YARN-10009.branch-2.10.003.patch | | Optional Tests | dupname
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990202#comment-16990202 ] Eric Payne commented on YARN-10009: --- [~leftnoteasy], thanks for looking at this. bq. is the failure related? I pulled trunk and TestFairSchedulerPreemption ran successfully with and without my patch, so I don't think so. I also put up patch version 003 for branch-2.10 > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.11.0 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.UT.patch, YARN-10009.branch-2.10.003.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990169#comment-16990169 ] Wangda Tan commented on YARN-10009: --- [~epayne], is the failure related? Thanks > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.11.0 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.UT.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990159#comment-16990159 ] Hadoop QA commented on YARN-10009: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 38s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m 18s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 20s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 16m 22s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 19s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 1m 21s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 21s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 58s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 86m 34s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 38s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}176m 19s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/hadoop:104ccca9169 | | JIRA Issue | YARN-10009 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987773/YARN-10009.003.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux df35cf570fe7 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 705b172 | | maven | ver
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990024#comment-16990024 ] Eric Payne commented on YARN-10009: --- Upmerged and attached patch version 003. > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.11.0 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.003.patch, YARN-10009.UT.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989003#comment-16989003 ] Hadoop QA commented on YARN-10009: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color} | {color:red} YARN-10009 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | YARN-10009 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987628/YARN-10009.002.patch | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/25257/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.11.0 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.UT.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989002#comment-16989002 ] Eric Payne commented on YARN-10009: --- Thank you very much for the review, [~leftnoteasy]. I uploaded a new patch for trunk that fixes the above-mentioned comment (and a couple of other comments), and I fixed a checkstyle warning while I was at it. The 2.10 patch needs a little adjustment for the unit test. I will upload that once the pre-commit build has completed on YARN-10009.002.patch. > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.11.0 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.002.patch, > YARN-10009.UT.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988283#comment-16988283 ] Wangda Tan commented on YARN-10009: --- +1 from my side, except one comment: {quote}[^YARN-10009.001.patch]+ // allocate 5 containers for app1 with 1GB memory, 1 vcore, 5 res_1s {quote} The above comment is not right in the test case. [~sunilg], do you want to take a look? > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.11.0 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Critical > Attachments: YARN-10009.001.patch, YARN-10009.UT.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987181#comment-16987181 ] Eric Payne commented on YARN-10009: --- [~sunilg], [~jhung], [~leftnoteasy], could I please request that you review this? > In Capacity Scheduler, DRC can treat minimum user limit percent as a max when > custom resource is defined > > > Key: YARN-10009 > URL: https://issues.apache.org/jira/browse/YARN-10009 > Project: Hadoop YARN > Issue Type: Improvement > Components: capacity scheduler >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3, 2.11.0 >Reporter: Eric Payne >Assignee: Eric Payne >Priority: Major > Attachments: YARN-10009.001.patch, YARN-10009.UT.patch > > > | |Memory|Vcores|res_1| > |Queue1 Totals|20GB|100|80| > |Resources requested by App1 in Queue1|8GB (40% of total)|8 (8% of total)|80 > (100% of total)| > In the previous use case: > - Queue1 has a value of 25 for {{miminum-user-limit-percent}} > - User1 has requested 8 containers with {{}} > each > - {{res_1}} will be the dominant resource this case. > All 8 containers should be assigned by the capacity scheduler, but with min > user limit pct set to 25, only 2 containers are assigned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10009) In Capacity Scheduler, DRC can treat minimum user limit percent as a max when custom resource is defined
[ https://issues.apache.org/jira/browse/YARN-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987121#comment-16987121 ] Hadoop QA commented on YARN-10009: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 32s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 49s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 38s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 20s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 39s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 16m 8s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 28s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 17s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 1m 16s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 12 unchanged - 0 fixed = 14 total (was 12) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 15m 13s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 45s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 9s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 86m 21s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 38s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}175m 10s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/hadoop:104ccca9169 | | JIRA Issue | YARN-10009 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987377/YARN-10009.001.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux a031af742580 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 0c217fe | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.o