Re: [yocto] [meta-raspberrypi][PATCH 2/5] rpi-config: Allow to mask GPU irqs
On Mon, Aug 10, 2015 at 09:48:43AM +0200, Javier Martinez Canillas wrote: > Hello Andrei, > > Thanks a lot for your feedback and for picking patches #1 and #3! > > On 08/10/2015 12:44 AM, Andrei Gherzan wrote: > > Hello, > > > > On Thu, Jul 30, 2015 at 10:34:08AM +0200, Javier Martinez Canillas wrote: > >> From: Derek Foreman > >> > >> The rpi config.txt file has a mask_gpu_interrupt option which needs to > >> be set when using the new VC4 DRM/KMS driver. Since this option exists > >> in the config file and needed by some kernels, add a option to set it. > >> > > > > I understand the scope of this change and it makes sense. The only > > confusion is > > in the "since this option exixts in the config file". This option is not in > > the > > config file. What do you mean by that? > > > > Right, that was worded badly. I meant that the option is a valid one for > the config.txt file. IOW, that is a supported option by the RPi firmware > but it was not possible to setup from the meta-raspberrypi layer. > > I'll fix the commit message on v2. > Uh. Got it now. Thanks. Waiting for V2s. Cheers! -- Andrei Gherzan -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [meta-raspberrypi][PATCH 2/5] rpi-config: Allow to mask GPU irqs
Hello Andrei, Thanks a lot for your feedback and for picking patches #1 and #3! On 08/10/2015 12:44 AM, Andrei Gherzan wrote: > Hello, > > On Thu, Jul 30, 2015 at 10:34:08AM +0200, Javier Martinez Canillas wrote: >> From: Derek Foreman >> >> The rpi config.txt file has a mask_gpu_interrupt option which needs to >> be set when using the new VC4 DRM/KMS driver. Since this option exists >> in the config file and needed by some kernels, add a option to set it. >> > > I understand the scope of this change and it makes sense. The only confusion > is > in the "since this option exixts in the config file". This option is not in > the > config file. What do you mean by that? > Right, that was worded badly. I meant that the option is a valid one for the config.txt file. IOW, that is a supported option by the RPi firmware but it was not possible to setup from the meta-raspberrypi layer. I'll fix the commit message on v2. > -- > Andrei Gherzan > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
Re: [yocto] [meta-raspberrypi][PATCH 2/5] rpi-config: Allow to mask GPU irqs
Hello, On Thu, Jul 30, 2015 at 10:34:08AM +0200, Javier Martinez Canillas wrote: > From: Derek Foreman > > The rpi config.txt file has a mask_gpu_interrupt option which needs to > be set when using the new VC4 DRM/KMS driver. Since this option exists > in the config file and needed by some kernels, add a option to set it. > I understand the scope of this change and it makes sense. The only confusion is in the "since this option exixts in the config file". This option is not in the config file. What do you mean by that? -- Andrei Gherzan -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
[yocto] [meta-raspberrypi][PATCH 2/5] rpi-config: Allow to mask GPU irqs
From: Derek Foreman The rpi config.txt file has a mask_gpu_interrupt option which needs to be set when using the new VC4 DRM/KMS driver. Since this option exists in the config file and needed by some kernels, add a option to set it. Signed-off-by: Derek Foreman [javier: Made it a config option] Signed-off-by: Javier Martinez Canillas --- README | 22 ++ recipes-bsp/bootfiles/rpi-config_git.bb | 6 ++ 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/README b/README index d70f21fe06ed..678c0eb4a4e3 100644 --- a/README +++ b/README @@ -20,10 +20,11 @@ Contents: 2.F. Optional - Video camera support with V4L2 drivers 2.G. Optional - Enable offline compositing support 2.H. Optional - Enable kgdb over console support -2.I. Images -2.J. Boot to U-Boot -2.K. Image with Initramfs -2.L. Device tree support +2.I. Optional - Mask GPU interrupts +2.J. Images +2.K. Boot to U-Boot +2.L. Image with Initramfs +2.M. Device tree support 3. Extra apps 3.A. omxplayer 4. Source code and mirrors @@ -145,7 +146,12 @@ To add the kdbg over console (kgdboc) parameter to the kernel command line, set this variable in local.conf: ENABLE_KGDB = "1" -2.I. Images +2.I. Optional - Mask GPU interrupts +=== +To mask the GPU interrupts, set in your local.conf +MASK_GPU_INTERRUPT = "0x400" + +2.J. Images === * rpi-hwup-image Hardware up image @@ -155,7 +161,7 @@ ENABLE_KGDB = "1" Image based on rpi-basic-image which includes most of the packages in this layer and some media samples. -2.J. Boot to U-Boot +2.K. Boot to U-Boot === To have u-boot load kernel image, set in your local.conf KERNEL_IMAGETYPE = "uImage" @@ -163,7 +169,7 @@ KERNEL_IMAGETYPE = "uImage" This will make kernel.img be u-boot image which will load uImage. By default, kernel.img is the actual kernel image (ex. Image). -2.K. Image with Initramfs +2.L. Image with Initramfs = To build an initramfs image : * Set this 3 kernel variables (in linux-raspberrypi.inc for example) @@ -176,7 +182,7 @@ To build an initramfs image : * Set the meta-rasberrypi variable (in raspberrypi.conf for example) - KERNEL_INITRAMFS = "-initramfs" -2.L. Device tree support +2.M. Device tree support = Device tree for RPi is only supported when using linux-raspberrypi 3.18+ kernels. diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb index 29ced342426c..56477a8821bb 100644 --- a/recipes-bsp/bootfiles/rpi-config_git.bb +++ b/recipes-bsp/bootfiles/rpi-config_git.bb @@ -66,6 +66,12 @@ do_deploy() { echo "# Enable offline compositing" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt echo "dispmanx_offline=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt fi + +# Mask GPU interrupts +if [ -n "${MASK_GPU_INTERRUPT}" ]; then +echo "# Mask GPU interrupts" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt +echo "mask_gpu_interrupt0=${MASK_GPU_INTERRUPT}" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt +fi } addtask deploy before do_package after do_install -- 2.4.3 -- ___ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto