[jira] Updated: (ZOOKEEPER-354) to fix javadoc warning in the source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-354: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. > to fix javadoc warning in the source files > -- > > Key: ZOOKEEPER-354 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 > Project: Zookeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-354.patch > > > [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "60" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "62" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see: can't find create(String, byte[], List, CreateMode) > in org.apache.zookeeper.ZooKeeper > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: > warning - @param argument "flags" is not a parameter name. > [javadoc] Building index for all the packages and classes... > [javadoc] Building index for all classes... > [javadoc] Generating trunk/build/docs/api/stylesheet.css... > [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-354) to fix javadoc warning in the source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689813#action_12689813 ] Patrick Hunt commented on ZOOKEEPER-354: +1 for the patch. I reviewed, ran javadoc gen and it looks good. > to fix javadoc warning in the source files > -- > > Key: ZOOKEEPER-354 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 > Project: Zookeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-354.patch > > > [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "60" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "62" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see: can't find create(String, byte[], List, CreateMode) > in org.apache.zookeeper.ZooKeeper > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: > warning - @param argument "flags" is not a parameter name. > [javadoc] Building index for all the packages and classes... > [javadoc] Building index for all classes... > [javadoc] Generating trunk/build/docs/api/stylesheet.css... > [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-355) make validatePath non public in Zookeeper client api.
make validatePath non public in Zookeeper client api. -- Key: ZOOKEEPER-355 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0, 3.1.1 Reporter: Mahadev konar Fix For: 3.2.0 make validatePath non public in Zookeeper client api. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-348) Creating node with path ending in "/" with sequence flag set
[ https://issues.apache.org/jira/browse/ZOOKEEPER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Terrace updated ZOOKEEPER-348: --- Affects Version/s: 3.1.0 Confirmed same issue on 3.1.0 > Creating node with path ending in "/" with sequence flag set > > > Key: ZOOKEEPER-348 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-348 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.1.0, 3.1.1 >Reporter: Jeff Terrace >Priority: Minor > Fix For: 3.2.0 > > > In 3.0.1, I could create a sequence node like this: > /nodes/001 > like this: > string path = "/nodes/"; > string value = "data"; > int rc = zoo_acreate(zh, path.c_str(), value.c_str(), value.length(), > &ZOO_OPEN_ACL_UNSAFE, ZOO_EPHEMERAL | ZOO_SEQUENCE, &czoo_created, &where); > In 3.1.1, this fails with error -8 (ZBADARGUMENTS). > Adding something after the "/" in the path makes the code work fine: > string path = "/nodes/n"; > I assume something is checking if the path ends in "/" but not checking the > sequence flag. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-354) to fix javadoc warning in the source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-354: Component/s: documentation Description: [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: "60" in "#create(String, byte[], List, CreateMode)" [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: "62" in "#create(String, byte[], List, CreateMode)" [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see: can't find create(String, byte[], List, CreateMode) in org.apache.zookeeper.ZooKeeper [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: warning - @param argument "flags" is not a parameter name. [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating trunk/build/docs/api/stylesheet.css... [javadoc] 24 warnings was: [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: "60" in "#create(String, byte[], List, CreateMode)" [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: "62" in "#create(String, byte[], List, CreateMode)" [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see: can't find create(String, byte[], List, CreateMode) in org.apache.zookeeper.ZooKeeper [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: warning - @param argument "flags" is not a parameter name. [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating trunk/build/docs/api/stylesheet.css... [javadoc] 24 warnings Affects Version/s: 3.1.1 3.0.0 3.0.1 3.1.0 Fix Version/s: 3.2.0 > to fix javadoc warning in the source files > -- > > Key: ZOOKEEPER-354 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 > Project: Zookeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-354.patch > > > [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "60" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "62" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see: can't find create(String, byte[], List, CreateMode) > in org.apache.zookeeper.ZooKeeper > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: > warning - @param argument "flags" is not a parameter name. > [javadoc] Building index for all the packages and classes... > [javadoc] Building index for all classes... > [javadoc] Generating trunk/build/docs/api/stylesheet.css... > [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-354) to fix javadoc warning in the source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-354: Attachment: ZOOKEEPER-354.patch this patch fixes the javadoc warnings. > to fix javadoc warning in the source files > -- > > Key: ZOOKEEPER-354 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 > Project: Zookeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-354.patch > > > [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "60" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "62" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see: can't find create(String, byte[], List, CreateMode) > in org.apache.zookeeper.ZooKeeper > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: > warning - @param argument "flags" is not a parameter name. > [javadoc] Building index for all the packages and classes... > [javadoc] Building index for all classes... > [javadoc] Generating trunk/build/docs/api/stylesheet.css... > [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-354) to fix javadoc warning in the source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-354: Status: Patch Available (was: Open) > to fix javadoc warning in the source files > -- > > Key: ZOOKEEPER-354 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 > Project: Zookeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.1.0, 3.0.1, 3.0.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-354.patch > > > [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "60" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "62" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see: can't find create(String, byte[], List, CreateMode) > in org.apache.zookeeper.ZooKeeper > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: > warning - @param argument "flags" is not a parameter name. > [javadoc] Building index for all the packages and classes... > [javadoc] Building index for all classes... > [javadoc] Generating trunk/build/docs/api/stylesheet.css... > [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-350: Component/s: build > to run rats for releaseaudit > - > > Key: ZOOKEEPER-350 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-350.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-353:
Affects Version/s: 3.1.1
3.0.0
3.0.1
3.1.0
> javadoc warnings needs to be fixed
> ---
>
> Key: ZOOKEEPER-353
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
> Project: Zookeeper
> Issue Type: Sub-task
> Components: build
>Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
>Reporter: Giridharan Kesavan
>Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: ZK-353.patch, ZK-353.patch
>
>
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
> cannot find symbol
> [javadoc] symbol : class OutputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void serialize(OutputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
> cannot find symbol
> [javadoc] symbol : class InputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void deserialize(InputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
> [javadoc] 4 errors
> [javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-353:
Resolution: Fixed
Fix Version/s: 3.2.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 to the patch. i just committed this (thanks giri).
> javadoc warnings needs to be fixed
> ---
>
> Key: ZOOKEEPER-353
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
> Project: Zookeeper
> Issue Type: Sub-task
> Components: build
>Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
>Reporter: Giridharan Kesavan
>Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: ZK-353.patch, ZK-353.patch
>
>
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
> cannot find symbol
> [javadoc] symbol : class OutputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void serialize(OutputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
> cannot find symbol
> [javadoc] symbol : class InputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void deserialize(InputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
> [javadoc] 4 errors
> [javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-353:
Component/s: build
> javadoc warnings needs to be fixed
> ---
>
> Key: ZOOKEEPER-353
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
> Project: Zookeeper
> Issue Type: Sub-task
> Components: build
>Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
>Reporter: Giridharan Kesavan
>Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: ZK-353.patch, ZK-353.patch
>
>
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
> cannot find symbol
> [javadoc] symbol : class OutputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void serialize(OutputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
> cannot find symbol
> [javadoc] symbol : class InputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void deserialize(InputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
> [javadoc] 4 errors
> [javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-353:
Attachment: ZK-353.patch
the patch did not apply cleanly. it had some stubs that had been already
committed. an updated patch.
> javadoc warnings needs to be fixed
> ---
>
> Key: ZOOKEEPER-353
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
> Project: Zookeeper
> Issue Type: Sub-task
>Reporter: Giridharan Kesavan
>Assignee: Giridharan Kesavan
> Attachments: ZK-353.patch, ZK-353.patch
>
>
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
> cannot find symbol
> [javadoc] symbol : class OutputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void serialize(OutputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
> cannot find symbol
> [javadoc] symbol : class InputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void deserialize(InputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
> [javadoc] 4 errors
> [javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689767#action_12689767
]
Patrick Hunt commented on ZOOKEEPER-353:
I think this is the case from looking at the patch but wanted to verify:
javadoc target will only include javadoc on "user public" apis?
ie the limited subset of classes that we expose to users directly, the
programming api etc...
while javadoc-dev will include javadoc on all (public) apis?
> javadoc warnings needs to be fixed
> ---
>
> Key: ZOOKEEPER-353
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
> Project: Zookeeper
> Issue Type: Sub-task
>Reporter: Giridharan Kesavan
>Assignee: Giridharan Kesavan
> Attachments: ZK-353.patch
>
>
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
> cannot find symbol
> [javadoc] symbol : class OutputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void serialize(OutputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
> cannot find symbol
> [javadoc] symbol : class InputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void deserialize(InputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
> [javadoc] 4 errors
> [javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-352) to add standard ant targets required by test-patch.sh script
[ https://issues.apache.org/jira/browse/ZOOKEEPER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-352: Affects Version/s: 3.1.1 3.0.0 3.0.1 3.1.0 > to add standard ant targets required by test-patch.sh script > > > Key: ZOOKEEPER-352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-352 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-352.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-352) to add standard ant targets required by test-patch.sh script
[ https://issues.apache.org/jira/browse/ZOOKEEPER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-352: Resolution: Fixed Fix Version/s: 3.2.0 Release Note: add standard test targets required by test-patch. Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1 for the patch. I just committed this. thanks giri. > to add standard ant targets required by test-patch.sh script > > > Key: ZOOKEEPER-352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-352 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-352.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-348) Creating node with path ending in "/" with sequence flag set
[ https://issues.apache.org/jira/browse/ZOOKEEPER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689764#action_12689764 ] Patrick Hunt commented on ZOOKEEPER-348: We started verifying paths in 3.1 - this is likely happening in 3.1.0+ We are checking the path and not handling the case where sequential flag is specified, we need to check for this case. we should add tests specific to this case one thing I noticed - validatepath was never intended to be part of the public API this method should be made private, or moved out of ZooKeeper class ASAP > Creating node with path ending in "/" with sequence flag set > > > Key: ZOOKEEPER-348 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-348 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.1.1 >Reporter: Jeff Terrace >Priority: Minor > Fix For: 3.2.0 > > > In 3.0.1, I could create a sequence node like this: > /nodes/001 > like this: > string path = "/nodes/"; > string value = "data"; > int rc = zoo_acreate(zh, path.c_str(), value.c_str(), value.length(), > &ZOO_OPEN_ACL_UNSAFE, ZOO_EPHEMERAL | ZOO_SEQUENCE, &czoo_created, &where); > In 3.1.1, this fails with error -8 (ZBADARGUMENTS). > Adding something after the "/" in the path makes the code work fine: > string path = "/nodes/n"; > I assume something is checking if the path ends in "/" but not checking the > sequence flag. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-350: Affects Version/s: 3.1.1 > to run rats for releaseaudit > - > > Key: ZOOKEEPER-350 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 > Project: Zookeeper > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-350.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-351) to run checkstyle
[ https://issues.apache.org/jira/browse/ZOOKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-351: Affects Version/s: 3.1.1 Release Note: run checkstyle > to run checkstyle > - > > Key: ZOOKEEPER-351 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-351 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-351.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-350: Resolution: Fixed Fix Version/s: 3.2.0 Release Note: run rats for release audits. Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1 for the patch... i just committed this. > to run rats for releaseaudit > - > > Key: ZOOKEEPER-350 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 > Project: Zookeeper > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.0.1, 3.1.0 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-350.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-350: Affects Version/s: 3.0.0 3.0.1 3.1.0 > to run rats for releaseaudit > - > > Key: ZOOKEEPER-350 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 > Project: Zookeeper > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.0.1, 3.1.0 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-350.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-351) to run checkstyle
[ https://issues.apache.org/jira/browse/ZOOKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-351: Resolution: Fixed Fix Version/s: 3.2.0 Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1... I just committed this. thanks giri. > to run checkstyle > - > > Key: ZOOKEEPER-351 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-351 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Affects Versions: 3.0.0, 3.0.1, 3.1.0 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-351.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-351) to run checkstyle
[ https://issues.apache.org/jira/browse/ZOOKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-351: Affects Version/s: 3.0.0 3.0.1 3.1.0 > to run checkstyle > - > > Key: ZOOKEEPER-351 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-351 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Affects Versions: 3.0.0, 3.0.1, 3.1.0 >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: ZK-351.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-352) to add standard ant targets required by test-patch.sh script
[ https://issues.apache.org/jira/browse/ZOOKEEPER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-352: - Status: Patch Available (was: Open) > to add standard ant targets required by test-patch.sh script > > > Key: ZOOKEEPER-352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-352 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Attachments: ZK-352.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-351) to run checkstyle
[ https://issues.apache.org/jira/browse/ZOOKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-351: - Status: Patch Available (was: Open) > to run checkstyle > - > > Key: ZOOKEEPER-351 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-351 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Attachments: ZK-351.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-350: - Status: Patch Available (was: Open) > to run rats for releaseaudit > - > > Key: ZOOKEEPER-350 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Attachments: ZK-350.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Giridharan Kesavan updated ZOOKEEPER-353:
-
Status: Patch Available (was: Open)
> javadoc warnings needs to be fixed
> ---
>
> Key: ZOOKEEPER-353
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
> Project: Zookeeper
> Issue Type: Sub-task
>Reporter: Giridharan Kesavan
>Assignee: Giridharan Kesavan
> Attachments: ZK-353.patch
>
>
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
> cannot find symbol
> [javadoc] symbol : class OutputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void serialize(OutputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
> cannot find symbol
> [javadoc] symbol : class InputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void deserialize(InputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
> [javadoc] 4 errors
> [javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-349) to automate patch testing
[ https://issues.apache.org/jira/browse/ZOOKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689753#action_12689753 ] Giridharan Kesavan commented on ZOOKEEPER-349: -- we should do the following changes once the above listed sub-tasks gets revolved.. test-patch.sh script resides in http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch dir. To get this pulled as part of Zookeeper trunk we may have to configure svn:externals. Commands to configure svn externals for test-patch.sh script.. check out zookeeper trunk cd /src/java export EDITOR=vim svn propedit svn:externals test [ the above step will open up the vim editor type in the following line and save it] bin http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch svn commit Once this is done we can create hudson job to enable patch testing for zookeeper. > to automate patch testing > -- > > Key: ZOOKEEPER-349 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-349 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-354) to fix javadoc warning in the source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan reassigned ZOOKEEPER-354: Assignee: Mahadev konar Mahadev said he will look into this. > to fix javadoc warning in the source files > -- > > Key: ZOOKEEPER-354 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Giridharan Kesavan >Assignee: Mahadev konar > > [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "60" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see:illegal character: "62" in "#create(String, byte[], > List, CreateMode)" > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: > warning - Tag @see: can't find create(String, byte[], List, CreateMode) > in org.apache.zookeeper.ZooKeeper > [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: > warning - @param argument "flags" is not a parameter name. > [javadoc] Building index for all the packages and classes... > [javadoc] Building index for all classes... > [javadoc] Generating trunk/build/docs/api/stylesheet.css... > [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-354) to fix javadoc warning in the source files
to fix javadoc warning in the source files -- Key: ZOOKEEPER-354 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 Project: Zookeeper Issue Type: Sub-task Reporter: Giridharan Kesavan [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: "60" in "#create(String, byte[], List, CreateMode)" [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: "62" in "#create(String, byte[], List, CreateMode)" [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see: can't find create(String, byte[], List, CreateMode) in org.apache.zookeeper.ZooKeeper [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: warning - @param argument "flags" is not a parameter name. [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating trunk/build/docs/api/stylesheet.css... [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Giridharan Kesavan updated ZOOKEEPER-353:
-
Attachment: ZK-353.patch
this patch removes 100 warnings and 4 errors.
Still those 24 warnings needs to be fixes which requires editing the source
file..
For the remaining 24 warning's I'm going to file a different jira.
tnx!
> javadoc warnings needs to be fixed
> ---
>
> Key: ZOOKEEPER-353
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
> Project: Zookeeper
> Issue Type: Sub-task
>Reporter: Giridharan Kesavan
> Attachments: ZK-353.patch
>
>
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
> cannot find symbol
> [javadoc] symbol : class OutputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void serialize(OutputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
> cannot find symbol
> [javadoc] symbol : class InputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void deserialize(InputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
> [javadoc] 4 errors
> [javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Giridharan Kesavan reassigned ZOOKEEPER-353:
Assignee: Giridharan Kesavan
> javadoc warnings needs to be fixed
> ---
>
> Key: ZOOKEEPER-353
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
> Project: Zookeeper
> Issue Type: Sub-task
>Reporter: Giridharan Kesavan
>Assignee: Giridharan Kesavan
> Attachments: ZK-353.patch
>
>
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
> cannot find symbol
> [javadoc] symbol : class OutputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void serialize(OutputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc]
> /.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
> cannot find symbol
> [javadoc] symbol : class InputArchive
> [javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
> [javadoc] public void deserialize(InputArchive a_, String tag) throws
> java.io.IOException {
> [javadoc] ^
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
> [javadoc] 4 errors
> [javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-348) Creating node with path ending in "/" with sequence flag set
[ https://issues.apache.org/jira/browse/ZOOKEEPER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689741#action_12689741 ] Mahadev konar commented on ZOOKEEPER-348: - it just came to my mind that we put validating path at the client side in ZOOKEEPER-16. can you try using 3.1* versions? you should get errors in both the cases in 3.1* versions. > Creating node with path ending in "/" with sequence flag set > > > Key: ZOOKEEPER-348 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-348 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.1.1 >Reporter: Jeff Terrace >Priority: Minor > Fix For: 3.2.0 > > > In 3.0.1, I could create a sequence node like this: > /nodes/001 > like this: > string path = "/nodes/"; > string value = "data"; > int rc = zoo_acreate(zh, path.c_str(), value.c_str(), value.length(), > &ZOO_OPEN_ACL_UNSAFE, ZOO_EPHEMERAL | ZOO_SEQUENCE, &czoo_created, &where); > In 3.1.1, this fails with error -8 (ZBADARGUMENTS). > Adding something after the "/" in the path makes the code work fine: > string path = "/nodes/n"; > I assume something is checking if the path ends in "/" but not checking the > sequence flag. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-348) Creating node with path ending in "/" with sequence flag set
[ https://issues.apache.org/jira/browse/ZOOKEEPER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-348: Fix Version/s: (was: 3.0.1) 3.2.0 makring this to be fixed in 3.2. 3.0.1 has already been released. > Creating node with path ending in "/" with sequence flag set > > > Key: ZOOKEEPER-348 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-348 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.1.1 >Reporter: Jeff Terrace >Priority: Minor > Fix For: 3.2.0 > > > In 3.0.1, I could create a sequence node like this: > /nodes/001 > like this: > string path = "/nodes/"; > string value = "data"; > int rc = zoo_acreate(zh, path.c_str(), value.c_str(), value.length(), > &ZOO_OPEN_ACL_UNSAFE, ZOO_EPHEMERAL | ZOO_SEQUENCE, &czoo_created, &where); > In 3.1.1, this fails with error -8 (ZBADARGUMENTS). > Adding something after the "/" in the path makes the code work fine: > string path = "/nodes/n"; > I assume something is checking if the path ends in "/" but not checking the > sequence flag. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-353) javadoc warnings needs to be fixed
javadoc warnings needs to be fixed
---
Key: ZOOKEEPER-353
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
Project: Zookeeper
Issue Type: Sub-task
Reporter: Giridharan Kesavan
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
cannot find symbol
[javadoc] symbol : class OutputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void serialize(OutputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
cannot find symbol
[javadoc] symbol : class InputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void deserialize(InputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc] Building index for all the packages and classes...
[javadoc] Building index for all classes...
[javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
[javadoc] 4 errors
[javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-352) to add standard ant targets required by test-patch.sh script
[ https://issues.apache.org/jira/browse/ZOOKEEPER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-352: - Attachment: ZK-352.patch patch adds test-patch and hudson-test-patch , test-contrib and test-core targets to builds.xml which is required by test-patch.sh > to add standard ant targets required by test-patch.sh script > > > Key: ZOOKEEPER-352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-352 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Attachments: ZK-352.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-352) to add standard ant targets required by test-patch.sh script
to add standard ant targets required by test-patch.sh script Key: ZOOKEEPER-352 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-352 Project: Zookeeper Issue Type: Sub-task Components: build Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-351) to run checkstyle
[ https://issues.apache.org/jira/browse/ZOOKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-351: - Attachment: ZK-351.patch enables checkstyle for zk > to run checkstyle > - > > Key: ZOOKEEPER-351 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-351 > Project: Zookeeper > Issue Type: Sub-task > Components: build >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Attachments: ZK-351.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-351) to run checkstyle
to run checkstyle - Key: ZOOKEEPER-351 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-351 Project: Zookeeper Issue Type: Sub-task Components: build Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-349) to automate patch testing
[ https://issues.apache.org/jira/browse/ZOOKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-349: - Component/s: build > to automate patch testing > -- > > Key: ZOOKEEPER-349 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-349 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giridharan Kesavan updated ZOOKEEPER-350: - Attachment: ZK-350.patch this patch enables releaseaudit target for zk > to run rats for releaseaudit > - > > Key: ZOOKEEPER-350 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Giridharan Kesavan >Assignee: Giridharan Kesavan > Attachments: ZK-350.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-350) to run rats for releaseaudit
to run rats for releaseaudit - Key: ZOOKEEPER-350 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 Project: Zookeeper Issue Type: Sub-task Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-349) to automate patch testing
to automate patch testing -- Key: ZOOKEEPER-349 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-349 Project: Zookeeper Issue Type: Improvement Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-348) Creating node with path ending in "/" with sequence flag set
Creating node with path ending in "/" with sequence flag set Key: ZOOKEEPER-348 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-348 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.1 Reporter: Jeff Terrace Priority: Minor Fix For: 3.0.1 In 3.0.1, I could create a sequence node like this: /nodes/001 like this: string path = "/nodes/"; string value = "data"; int rc = zoo_acreate(zh, path.c_str(), value.c_str(), value.length(), &ZOO_OPEN_ACL_UNSAFE, ZOO_EPHEMERAL | ZOO_SEQUENCE, &czoo_created, &where); In 3.1.1, this fails with error -8 (ZBADARGUMENTS). Adding something after the "/" in the path makes the code work fine: string path = "/nodes/n"; I assume something is checking if the path ends in "/" but not checking the sequence flag. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #265
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/265/ -- [...truncated 49338 lines...] [junit] 2009-03-26 13:38:56,759 - INFO [main:finalrequestproces...@268] - shutdown of request processor complete [junit] 2009-03-26 13:38:56,759 - INFO [SyncThread:0:syncrequestproces...@119] - SyncRequestProcessor exited! [junit] 2009-03-26 13:38:56,759 - INFO [ProcessThread:-1:preprequestproces...@111] - PrepRequestProcessor exited loop! [junit] 2009-03-26 13:38:56,858 - INFO [main:clientb...@306] - STARTING server [junit] 2009-03-26 13:38:56,858 - INFO [main:zookeeperser...@160] - Created server [junit] 2009-03-26 13:38:56,859 - INFO [main:files...@71] - Reading snapshot http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/test/tmp/test435279925878357111.junit.dir/version-2/snapshot.0 [junit] 2009-03-26 13:38:56,860 - INFO [main:filetxnsnap...@198] - Snapshotting: 3 [junit] 2009-03-26 13:38:56,862 - INFO [NIOServerCxn.Factory:33221:nioserverc...@635] - Processing stat command from /127.0.0.1:58922 [junit] 2009-03-26 13:38:56,862 - WARN [NIOServerCxn.Factory:33221:nioserverc...@431] - Exception causing close of session 0x0 due to java.io.IOException: Responded to info probe [junit] 2009-03-26 13:38:56,862 - INFO [NIOServerCxn.Factory:33221:nioserverc...@766] - closing session:0x0 NIOServerCnxn: java.nio.channels.SocketChannel[connected local=/127.0.0.1:33221 remote=/127.0.0.1:58922] [junit] 2009-03-26 13:38:57,000 - INFO [SessionTracker:sessiontrackeri...@142] - SessionTrackerImpl exited loop! [junit] 2009-03-26 13:38:57,000 - INFO [SessionTracker:sessiontrackeri...@142] - SessionTrackerImpl exited loop! [junit] 2009-03-26 13:38:57,000 - INFO [SessionTracker:sessiontrackeri...@142] - SessionTrackerImpl exited loop! [junit] 2009-03-26 13:38:58,102 - INFO [main-SendThread:clientcnxn$sendthr...@800] - Attempting connection to server /127.0.0.1:33221 [junit] 2009-03-26 13:38:58,102 - INFO [main-SendThread:clientcnxn$sendthr...@716] - Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:58923 remote=/127.0.0.1:33221] [junit] 2009-03-26 13:38:58,102 - INFO [main-SendThread:clientcnxn$sendthr...@868] - Server connection successful [junit] 2009-03-26 13:38:58,103 - INFO [NIOServerCxn.Factory:33221:nioserverc...@517] - Connected to /127.0.0.1:58923 lastZxid 3 [junit] 2009-03-26 13:38:58,103 - INFO [NIOServerCxn.Factory:33221:nioserverc...@895] - Finished init of 0x12043014064 valid:true [junit] 2009-03-26 13:38:58,103 - INFO [NIOServerCxn.Factory:33221:nioserverc...@545] - Renewing session 0x12043014064 [junit] 2009-03-26 13:39:32,112 - INFO [main:clientb...@300] - STOPPING server [junit] 2009-03-26 13:39:32,113 - INFO [main:nioserverc...@766] - closing session:0x12043014064 NIOServerCnxn: java.nio.channels.SocketChannel[connected local=/127.0.0.1:33221 remote=/127.0.0.1:58923] [junit] 2009-03-26 13:39:32,114 - WARN [main-SendThread:clientcnxn$sendthr...@898] - Exception closing session 0x12043014064 to sun.nio.ch.selectionkeyi...@6397eb [junit] java.io.IOException: Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:632) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:876) [junit] 2009-03-26 13:39:32,114 - INFO [NIOServerCxn.Factory:33221:nioservercnxn$fact...@177] - NIOServerCnxn factory exited run method [junit] 2009-03-26 13:39:32,115 - INFO [ProcessThread:-1:preprequestproces...@111] - PrepRequestProcessor exited loop! [junit] 2009-03-26 13:39:32,115 - INFO [main:finalrequestproces...@268] - shutdown of request processor complete [junit] 2009-03-26 13:39:32,115 - INFO [SyncThread:0:syncrequestproces...@119] - SyncRequestProcessor exited! [junit] 2009-03-26 13:39:32,214 - INFO [main:clientb...@306] - STARTING server [junit] 2009-03-26 13:39:32,215 - INFO [main:zookeeperser...@160] - Created server [junit] 2009-03-26 13:39:32,216 - INFO [main:files...@71] - Reading snapshot http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/test/tmp/test435279925878357111.junit.dir/version-2/snapshot.3 [junit] 2009-03-26 13:39:32,217 - INFO [main:filetxnsnap...@198] - Snapshotting: 5 [junit] 2009-03-26 13:39:32,220 - INFO [NIOServerCxn.Factory:33221:nioserverc...@635] - Processing stat command from /127.0.0.1:58925 [junit] 2009-03-26 13:39:32,220 - WARN [NIOServerCxn.Factory:33221:nioserverc...@431] - Exception causing close of session 0x0 due to java.io.IOException: Responded to info probe [junit] 2009-03-26 13:39:32,230 - INFO [NIOServerCxn.Factory:33221:nioserverc...@766] - closing session:0x0 NIOServerCnxn: java.nio.channels.SocketChannel[connected l
[jira] Updated: (ZOOKEEPER-288) Cleanup and fixes to BookKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-288: - Attachment: ZOOKEEPER-BOOKKEEPER-288.patch > Cleanup and fixes to BookKeeper > --- > > Key: ZOOKEEPER-288 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-288 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-BOOKKEEPER-288.patch, > ZOOKEEPER-BOOKKEEPER-288.patch, ZOOKEEPER-BOOKKEEPER-288.patch, > ZOOKEEPER-BOOKKEEPER-288.patch > > > We observed one race condition when multiple threads try to write > concurrently. This patch should fix it. I will also remove some commented > code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-288) Cleanup and fixes to BookKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689443#action_12689443 ] Flavio Paiva Junqueira commented on ZOOKEEPER-288: -- Thanks, Ben. > > 1) you have genSecurePadding() in two different classes. for > > maintainability, you should only have it in one place. Those methods are not necessary anymore, so I have just removed them in the new patch I'm uploading. > > 2) in genLedgerKey and genMacKey, why do you allocate a byte array, do the > > copy and then do the > > digest.update(), rather than calling digest.update() twice? i think it > > makes is simpler and more readable. When profiling BK, I noticed that reducing the number of calls to update increases performance by a notch, so I've been following this strategy of only calling update once. I don't have a strong argument for why that happens, so I can go either way. > > 3) MasterKeys should start with a lower case letter. you never remove from > > MasterKeys, so you should probably > > make that a WeakHashMap, so that it can get GCed. Done. Do you think that "ledgers" in Bookie.java should also be a WeakHashMap? > > 4) are the masterkeys stored with the ledger fragment? i couldn't find it. Currently it is not stored with the fragment. Do you think it should? > Cleanup and fixes to BookKeeper > --- > > Key: ZOOKEEPER-288 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-288 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-BOOKKEEPER-288.patch, > ZOOKEEPER-BOOKKEEPER-288.patch, ZOOKEEPER-BOOKKEEPER-288.patch, > ZOOKEEPER-BOOKKEEPER-288.patch > > > We observed one race condition when multiple threads try to write > concurrently. This patch should fix it. I will also remove some commented > code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Incorrect implementation of QuorumCnxManager.haveDelivered()?
Hi Raghu, I'm moving this thread to the zookeeper-dev list. I think
this discussion is more appropriate to that list.
With respect to the implementation of haveDelivered, please check the
posts on jira, issue 275 (https://issues.apache.org/jira/browse/ZOOKEEPER-275
) for a scenario that makes it necessary, and let me know if it is
still not clear after you check it out or you simply don't agree.
About the queue of messages, it was our intention originally to have
all quorum communication going through the same channel (leader
election and broadcast), and we thought about using QuorumCnxManager
for that. We haven't had to time to make that change mainly because it
would be a major change it seems. So, we have a more general
implementation that queues messages to be delivered to other peers.
This is not supposed to be a problem, though, because it simply
implements a channel that eventually delivers messages.
-Flavio
On Mar 26, 2009, at 3:28 AM, rag...@yahoo.com wrote:
Hello,
I am a ZooKeeper newbie, so pardon me if I am repeating questions
that have been raised before.
I believe the implementation of QuorumCnxManager.haveDelivered() is
incorrect. If I understand correctly, queueSendMap contains a queue
of messages for each peer to which the local peer is trying to send
election messages. When FastLeaderElection notices a timeout while
polling for inbound messages, it checks to see if all the messages
have been delivered by calling this function. So shouldn't this
function actually check each queue in the hash map and return true
if all of them are empty? This method is rather returning true the
if just one of the queues is empty?
/**
* Check if all queues are empty, indicating that all messages
have been delivered.
*/
boolean haveDelivered() {
for (ArrayBlockingQueue queue :
queueSendMap.values()) {
LOG.debug("Queue size: " + queue.size());
if (queue.size() == 0)
return true;
}
return false;
}
Also, could someone expain the reason behind maitaining a queue of
messages for each peer in queueSendMap? Why do we need a per peer
queue here? Since this is used during election, the local peer is
not sending more than one message at a time to the remote peer. So
the hash map needs to store just one message per remote peer?
-Raghu
