[jira] Updated: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-754: --- Status: Resolved (was: Patch Available) Hadoop Flags: [Reviewed] Resolution: Fixed +1, Thanks Andrei! Committed to 3.3 branch and trunk. > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib-bindings, documentation >Affects Versions: 3.3.0 >Reporter: Thomas Koch >Assignee: Savu Andrei > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-754.patch, ZOOKEEPER-754.patch > > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861601#action_12861601 ] Hadoop QA commented on ZOOKEEPER-754: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443009/ZOOKEEPER-754.patch against trunk revision 938212. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/76/console This message is automatically generated. > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib-bindings, documentation >Affects Versions: 3.3.0 >Reporter: Thomas Koch >Assignee: Savu Andrei > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-754.patch, ZOOKEEPER-754.patch > > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861594#action_12861594 ] Mahadev konar commented on ZOOKEEPER-737: - ben, would you be able to review this patch? > some 4 letter words may fail with netcat (nc) > - > > Key: ZOOKEEPER-737 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.3.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch > > > nc closes the write channel as soon as it's sent it's information, for > example "echo stat|nc localhost 2181" > in general this is fine, however the server code will close the socket as > soon as it receives notice that nc has > closed it's write channel. if not all the 4 letter word result has been > written back to the client yet, this will cause > some or all of the result to be lost - ie the client will not see the full > result. this was introduced in 3.3.0 as part > of a change to reduce blocking of the selector by long running 4letter words. > here's an example of the logs from the server during this > echo -n stat | nc localhost 2181 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - > Accepted socket connection from /127.0.0.1:42179 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing > stat command from /127.0.0.1:42179 > 2010-04-09 21:55:36,125 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > 2010-04-09 21:55:36,125 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed > socket connection for client /127.0.0.1:42179 (no session established for > client) > [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR > [Thread-15:nioserverc...@422] - Unexpected Exception: > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59) > at > org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) > 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - > Thread Thread[Thread-15,5,main] died > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861592#action_12861592 ] Patrick Hunt commented on ZOOKEEPER-737: Looks good to me, +1. Tests pass on my system. Would be a good idea to get a review from another commiter though. > some 4 letter words may fail with netcat (nc) > - > > Key: ZOOKEEPER-737 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.3.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch > > > nc closes the write channel as soon as it's sent it's information, for > example "echo stat|nc localhost 2181" > in general this is fine, however the server code will close the socket as > soon as it receives notice that nc has > closed it's write channel. if not all the 4 letter word result has been > written back to the client yet, this will cause > some or all of the result to be lost - ie the client will not see the full > result. this was introduced in 3.3.0 as part > of a change to reduce blocking of the selector by long running 4letter words. > here's an example of the logs from the server during this > echo -n stat | nc localhost 2181 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - > Accepted socket connection from /127.0.0.1:42179 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing > stat command from /127.0.0.1:42179 > 2010-04-09 21:55:36,125 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > 2010-04-09 21:55:36,125 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed > socket connection for client /127.0.0.1:42179 (no session established for > client) > [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR > [Thread-15:nioserverc...@422] - Unexpected Exception: > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59) > at > org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) > 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - > Thread Thread[Thread-15,5,main] died > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Savu Andrei updated ZOOKEEPER-754: -- Status: Patch Available (was: Open) Release Note: fixed numerous misspellings of "succesfully" in the c client and python bindings > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib-bindings, documentation >Affects Versions: 3.3.0 >Reporter: Thomas Koch >Assignee: Savu Andrei > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-754.patch, ZOOKEEPER-754.patch > > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Savu Andrei updated ZOOKEEPER-754: -- Attachment: ZOOKEEPER-754.patch Fixed patch. It will replace all errors in all the files. > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib-bindings, documentation >Affects Versions: 3.3.0 >Reporter: Thomas Koch >Assignee: Savu Andrei > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-754.patch, ZOOKEEPER-754.patch > > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861570#action_12861570 ] Hadoop QA commented on ZOOKEEPER-737: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443006/ZOOKEEPER-737.patch against trunk revision 938212. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/75/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/75/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/75/console This message is automatically generated. > some 4 letter words may fail with netcat (nc) > - > > Key: ZOOKEEPER-737 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.3.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch > > > nc closes the write channel as soon as it's sent it's information, for > example "echo stat|nc localhost 2181" > in general this is fine, however the server code will close the socket as > soon as it receives notice that nc has > closed it's write channel. if not all the 4 letter word result has been > written back to the client yet, this will cause > some or all of the result to be lost - ie the client will not see the full > result. this was introduced in 3.3.0 as part > of a change to reduce blocking of the selector by long running 4letter words. > here's an example of the logs from the server during this > echo -n stat | nc localhost 2181 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - > Accepted socket connection from /127.0.0.1:42179 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing > stat command from /127.0.0.1:42179 > 2010-04-09 21:55:36,125 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > 2010-04-09 21:55:36,125 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed > socket connection for client /127.0.0.1:42179 (no session established for > client) > [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR > [Thread-15:nioserverc...@422] - Unexpected Exception: > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59) > at > org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) > 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - > Thread Thread[Thread-15,5,main] died > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWr
[jira] Commented: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861569#action_12861569 ] Patrick Hunt commented on ZOOKEEPER-754: Better, but running this at the toplevel directory: egrep -R succesfully src shows a number of issues in zookeeper.c and zookeeper.h (under src/c/..., not contrib) Makes sense to clean those up at the same time (then click "submit patch" on this page to move the workflow to the next step) Thanks! > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib-bindings, documentation >Affects Versions: 3.3.0 >Reporter: Thomas Koch >Assignee: Savu Andrei > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-754.patch > > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-754: -- Assignee: Savu Andrei > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib-bindings, documentation >Affects Versions: 3.3.0 >Reporter: Thomas Koch >Assignee: Savu Andrei > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-754.patch > > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-754: --- Fix Version/s: 3.3.1 3.4.0 Component/s: contrib-bindings documentation (was: contrib) > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib-bindings, documentation >Affects Versions: 3.3.0 >Reporter: Thomas Koch >Assignee: Savu Andrei > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-754.patch > > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-737: Status: Patch Available (was: Open) > some 4 letter words may fail with netcat (nc) > - > > Key: ZOOKEEPER-737 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.3.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch > > > nc closes the write channel as soon as it's sent it's information, for > example "echo stat|nc localhost 2181" > in general this is fine, however the server code will close the socket as > soon as it receives notice that nc has > closed it's write channel. if not all the 4 letter word result has been > written back to the client yet, this will cause > some or all of the result to be lost - ie the client will not see the full > result. this was introduced in 3.3.0 as part > of a change to reduce blocking of the selector by long running 4letter words. > here's an example of the logs from the server during this > echo -n stat | nc localhost 2181 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - > Accepted socket connection from /127.0.0.1:42179 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing > stat command from /127.0.0.1:42179 > 2010-04-09 21:55:36,125 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > 2010-04-09 21:55:36,125 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed > socket connection for client /127.0.0.1:42179 (no session established for > client) > [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR > [Thread-15:nioserverc...@422] - Unexpected Exception: > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59) > at > org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) > 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - > Thread Thread[Thread-15,5,main] died > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-737: Attachment: ZOOKEEPER-737.patch Updated the patch to use blocking IO for commands so that we dont have any spinning issues with the socket channels. > some 4 letter words may fail with netcat (nc) > - > > Key: ZOOKEEPER-737 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.3.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.1, 3.4.0 > > Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, > ZOOKEEPER-737.patch > > > nc closes the write channel as soon as it's sent it's information, for > example "echo stat|nc localhost 2181" > in general this is fine, however the server code will close the socket as > soon as it receives notice that nc has > closed it's write channel. if not all the 4 letter word result has been > written back to the client yet, this will cause > some or all of the result to be lost - ie the client will not see the full > result. this was introduced in 3.3.0 as part > of a change to reduce blocking of the selector by long running 4letter words. > here's an example of the logs from the server during this > echo -n stat | nc localhost 2181 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - > Accepted socket connection from /127.0.0.1:42179 > 2010-04-09 21:55:36,124 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing > stat command from /127.0.0.1:42179 > 2010-04-09 21:55:36,125 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > 2010-04-09 21:55:36,125 - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed > socket connection for client /127.0.0.1:42179 (no session established for > client) > [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR > [Thread-15:nioserverc...@422] - Unexpected Exception: > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59) > at > org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) > 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - > Thread Thread[Thread-15,5,main] died > java.nio.channels.CancelledKeyException > at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) > at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909) > at > org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) > at java.io.BufferedWriter.flush(BufferedWriter.java:236) > at java.io.PrintWriter.flush(PrintWriter.java:276) > at > org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Savu Andrei updated ZOOKEEPER-754: -- Attachment: ZOOKEEPER-754.patch The patch affects a single file: pyzk_docstrings.h. It applies cleanly on trunk and on the latest release (3.3.0). > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib >Affects Versions: 3.3.0 >Reporter: Thomas Koch > Attachments: ZOOKEEPER-754.patch > > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-755) Improve c client documentation to reflect that zookeeper_init() creates its own copy of list of host.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861523#action_12861523 ] Mahadev konar commented on ZOOKEEPER-755: - good point!!! > Improve c client documentation to reflect that zookeeper_init() creates its > own copy of list of host. > - > > Key: ZOOKEEPER-755 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-755 > Project: Zookeeper > Issue Type: Improvement > Components: c client >Reporter: Mahadev konar >Assignee: Mahadev konar > Fix For: 3.4.0 > > > The zookeeper.h file does not mention if zookeeper_init() creates its own > copy of host string or not. We need to clarify that in the documentation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-755) Improve c client documentation to reflect that zookeeper_init() creates its own copy of list of host.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861522#action_12861522 ] Patrick Hunt commented on ZOOKEEPER-755: While we're at it we should update all the c docs to provide such detail, not just init. > Improve c client documentation to reflect that zookeeper_init() creates its > own copy of list of host. > - > > Key: ZOOKEEPER-755 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-755 > Project: Zookeeper > Issue Type: Improvement > Components: c client >Reporter: Mahadev konar >Assignee: Mahadev konar > Fix For: 3.4.0 > > > The zookeeper.h file does not mention if zookeeper_init() creates its own > copy of host string or not. We need to clarify that in the documentation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-755) Improve c client documentation to reflect that zookeeper_init() creates its own copy of list of host.
Improve c client documentation to reflect that zookeeper_init() creates its own copy of list of host. - Key: ZOOKEEPER-755 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-755 Project: Zookeeper Issue Type: Improvement Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.4.0 The zookeeper.h file does not mention if zookeeper_init() creates its own copy of host string or not. We need to clarify that in the documentation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-755) Improve c client documentation to reflect that zookeeper_init() creates its own copy of list of host.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-755: Component/s: c client > Improve c client documentation to reflect that zookeeper_init() creates its > own copy of list of host. > - > > Key: ZOOKEEPER-755 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-755 > Project: Zookeeper > Issue Type: Improvement > Components: c client >Reporter: Mahadev konar >Assignee: Mahadev konar > Fix For: 3.4.0 > > > The zookeeper.h file does not mention if zookeeper_init() creates its own > copy of host string or not. We need to clarify that in the documentation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-678) Browser application to view and edit the contents of a zookeeper instance
[ https://issues.apache.org/jira/browse/ZOOKEEPER-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861445#action_12861445 ] Patrick Hunt commented on ZOOKEEPER-678: Thomas, would you mind opening a new JIRA to track this? Assign Colin as he's interested to followup. Thanks! > Browser application to view and edit the contents of a zookeeper instance > - > > Key: ZOOKEEPER-678 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-678 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.3.0 >Reporter: Colin Goodheart-Smithe >Assignee: Colin Goodheart-Smithe > Fix For: 3.3.0 > > Attachments: zooInspector.sh, ZooInspector.zip, ZooInspector.zip, > ZooInspector.zip > > > An application which shows a tree view of the nodes currently in a zookeeper > instance and allow the user to view and update the contents of the nodes as > well as allowing users to add and remove nodes from the tree, similar in use > to the Luke application in the Lucene project. > I have a list of other features that I want to add to this application but I > wanted to gauge the response before I implemented them all. I have found > this useful when debugging my application and thought that it may be useful > to others. > I was going to submit this as a patch file but I have used some icon files > and one library which isn't available in the maven/ivy repositories and these > don't seem to work when creating a patch file using subversion. Because of > this I have attached a zip containing this application to this issue. If > there is a better way to submit this please let me know. > The zip contains two directories, the src directory contains the source as it > would be added to the contrib folder and the build folder contains a build > version of the with a runnable jar. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-754) numerous misspellings "succesfully"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861443#action_12861443 ] Patrick Hunt commented on ZOOKEEPER-754: Hi Thomas, this would be a great opportunity for someone to give back to the community, and gain some experience as an Apache ZooKeeper Contributor at the same time. ;-) Seems like you have the data at hand, would you mind contributing a patch? http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute > numerous misspellings "succesfully" > --- > > Key: ZOOKEEPER-754 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 > Project: Zookeeper > Issue Type: Task > Components: contrib >Affects Versions: 3.3.0 >Reporter: Thomas Koch > > When testing the debian package of zookeeper with the standard tool > "lintian", it fills my screen with complains about the misspelling of > "succesfully" in several places of the zkpython contrib. Please be so kind to > correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-678) Browser application to view and edit the contents of a zookeeper instance
[ https://issues.apache.org/jira/browse/ZOOKEEPER-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861422#action_12861422 ] Colin Goodheart-Smithe commented on ZOOKEEPER-678: -- I will probably not have time to look at this until the weekend, but I will try to sort out these issues at that time > Browser application to view and edit the contents of a zookeeper instance > - > > Key: ZOOKEEPER-678 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-678 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.3.0 >Reporter: Colin Goodheart-Smithe >Assignee: Colin Goodheart-Smithe > Fix For: 3.3.0 > > Attachments: zooInspector.sh, ZooInspector.zip, ZooInspector.zip, > ZooInspector.zip > > > An application which shows a tree view of the nodes currently in a zookeeper > instance and allow the user to view and update the contents of the nodes as > well as allowing users to add and remove nodes from the tree, similar in use > to the Luke application in the Lucene project. > I have a list of other features that I want to add to this application but I > wanted to gauge the response before I implemented them all. I have found > this useful when debugging my application and thought that it may be useful > to others. > I was going to submit this as a patch file but I have used some icon files > and one library which isn't available in the maven/ivy repositories and these > don't seem to work when creating a patch file using subversion. Because of > this I have attached a zip containing this application to this issue. If > there is a better way to submit this please let me know. > The zip contains two directories, the src directory contains the source as it > would be added to the contrib folder and the build folder contains a build > version of the with a runnable jar. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-678) Browser application to view and edit the contents of a zookeeper instance
[ https://issues.apache.org/jira/browse/ZOOKEEPER-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861419#action_12861419 ] Thomas Koch commented on ZOOKEEPER-678: --- There are several places, where viewers is missspelled as "Veiwers". Please do a case insensitive search for "veiw" to correct these. Even the config file "defaultNodeVeiwers.cfg" is missspelled like this. This has the potential to confuse the hell out of people when debugging something! > Browser application to view and edit the contents of a zookeeper instance > - > > Key: ZOOKEEPER-678 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-678 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.3.0 >Reporter: Colin Goodheart-Smithe >Assignee: Colin Goodheart-Smithe > Fix For: 3.3.0 > > Attachments: zooInspector.sh, ZooInspector.zip, ZooInspector.zip, > ZooInspector.zip > > > An application which shows a tree view of the nodes currently in a zookeeper > instance and allow the user to view and update the contents of the nodes as > well as allowing users to add and remove nodes from the tree, similar in use > to the Luke application in the Lucene project. > I have a list of other features that I want to add to this application but I > wanted to gauge the response before I implemented them all. I have found > this useful when debugging my application and thought that it may be useful > to others. > I was going to submit this as a patch file but I have used some icon files > and one library which isn't available in the maven/ivy repositories and these > don't seem to work when creating a patch file using subversion. Because of > this I have attached a zip containing this application to this issue. If > there is a better way to submit this please let me know. > The zip contains two directories, the src directory contains the source as it > would be added to the contrib folder and the build folder contains a build > version of the with a runnable jar. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-678) Browser application to view and edit the contents of a zookeeper instance
[ https://issues.apache.org/jira/browse/ZOOKEEPER-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861390#action_12861390 ] Thomas Koch commented on ZOOKEEPER-678: --- It seems, that zooinspector finds it's icons only if the icons folder is in the current path. But when I install zooinspector as part of the Zookeeper Debian package, I want to be able to call it regardless of the current path. Could you use getRessources or something so that I can point to the icons location from the wrapper shell script? Can I place the zooinspector config files in /etc/zookeeper/zooinspector/ ? Could I give zooinspector a property to point to the config file location? > Browser application to view and edit the contents of a zookeeper instance > - > > Key: ZOOKEEPER-678 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-678 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.3.0 >Reporter: Colin Goodheart-Smithe >Assignee: Colin Goodheart-Smithe > Fix For: 3.3.0 > > Attachments: zooInspector.sh, ZooInspector.zip, ZooInspector.zip, > ZooInspector.zip > > > An application which shows a tree view of the nodes currently in a zookeeper > instance and allow the user to view and update the contents of the nodes as > well as allowing users to add and remove nodes from the tree, similar in use > to the Luke application in the Lucene project. > I have a list of other features that I want to add to this application but I > wanted to gauge the response before I implemented them all. I have found > this useful when debugging my application and thought that it may be useful > to others. > I was going to submit this as a patch file but I have used some icon files > and one library which isn't available in the maven/ivy repositories and these > don't seem to work when creating a patch file using subversion. Because of > this I have attached a zip containing this application to this issue. If > there is a better way to submit this please let me know. > The zip contains two directories, the src directory contains the source as it > would be added to the contrib folder and the build folder contains a build > version of the with a runnable jar. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-754) numerous misspellings "succesfully"
numerous misspellings "succesfully" --- Key: ZOOKEEPER-754 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-754 Project: Zookeeper Issue Type: Task Components: contrib Affects Versions: 3.3.0 Reporter: Thomas Koch When testing the debian package of zookeeper with the standard tool "lintian", it fills my screen with complains about the misspelling of "succesfully" in several places of the zkpython contrib. Please be so kind to correct this, when you touch the code the next time. Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: ZooKeeper gets three Google Summer of Code students
3 GSOC projects approved, that's great! Thank you students for applying for a project, should be some interesting new functionality/features developed over the summer. Thanks to all the mentors for stepping up and volunteering their time and Henry for shepherding the gsoc process (as well as being a mentor). I encourage our user base to engage with the students if they have interest in a particular project. If you have ideas, problems, or suggestions for features please discuss with the student (on the list is great). Exposing the mentees to how ZK based software is used in real life production environments will allow them to build a better product. Regards, Patrick On Mon, Apr 26, 2010 at 4:55 PM, Henry Robinson wrote: > Hi - > > Just wanted to announce to the community that we are lucky to have three > talented students working on Google's Summer of Code projects directly > related to ZooKeeper. > > Andrei Savu will be working with Patrick Hunt on a Web-based > Administrative > Interface, extending and improving Patrick's Django-based front end. > Abmar Barros will be working with Flavio Junqueira on improving ZooKeeper's > failure detector module - making the code cleaner and easier to try out new > implementations, as well as implementing a few failure detection algorithms > himself! > Finally, Sergey Doroshenko will be working with me on a Read-Only Mode for > ZooKeeper, which will help bolster ZK's availability in certain > circumstances when a network partition is detected, as well as potentially > optimising the read-path. > > (The full list of 450 GSoC students is here: > http://socghop.appspot.com/gsoc/program/list_projects/google/gsoc2010) > > Congratulations to all three - we look forward to seeing what you produce > over the summer. Thanks to everyone who applied, suggested projects and > offered to mentor students; this program will have a big effect on > ZooKeeper's visibility and community, as well as hopefully producing some > great code! > > cheers, > Henry > > -- > Henry Robinson > Software Engineer > Cloudera > 415-994-6679 >
