[jira] Updated: (ZOOKEEPER-511) bad error handling in FollowerHandler.sendPackets

2010-03-11 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-511:
-

Resolution: Fixed
Status: Resolved  (was: Patch Available)

+1, thanks mahadev! Committed revision 921853.

> bad error handling in FollowerHandler.sendPackets
> -
>
> Key: ZOOKEEPER-511
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-511
> Project: Zookeeper
>  Issue Type: Bug
>  Components: quorum, server
>Affects Versions: 3.2.0
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-511.patch
>
>
> in FollowerHandler if sendPackets gets an ioexception on writeRecord the send 
> thread will exit, however the 
> socket isn't necessarily closed.
> 2009-08-19 15:28:46,869 - WARN  [Sender-/127.0.0.1:58179:followerhand...@131] 
> - Unexpected exception
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.sendPackets(FollowerHandler.java:128)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.access$0(FollowerHandler.java:107)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler$1.run(FollowerHandler.java:325)
> This results in the follower taking a very long time to recover and rejoin 
> the quorum.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-511) bad error handling in FollowerHandler.sendPackets

2010-03-05 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-511:


Status: Patch Available  (was: Open)

> bad error handling in FollowerHandler.sendPackets
> -
>
> Key: ZOOKEEPER-511
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-511
> Project: Zookeeper
>  Issue Type: Bug
>  Components: quorum, server
>Affects Versions: 3.2.0
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-511.patch
>
>
> in FollowerHandler if sendPackets gets an ioexception on writeRecord the send 
> thread will exit, however the 
> socket isn't necessarily closed.
> 2009-08-19 15:28:46,869 - WARN  [Sender-/127.0.0.1:58179:followerhand...@131] 
> - Unexpected exception
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.sendPackets(FollowerHandler.java:128)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.access$0(FollowerHandler.java:107)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler$1.run(FollowerHandler.java:325)
> This results in the follower taking a very long time to recover and rejoin 
> the quorum.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-511) bad error handling in FollowerHandler.sendPackets

2010-03-05 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-511:


Fix Version/s: (was: 3.4.0)
   3.3.0

moving it to 3.3.

> bad error handling in FollowerHandler.sendPackets
> -
>
> Key: ZOOKEEPER-511
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-511
> Project: Zookeeper
>  Issue Type: Bug
>  Components: quorum, server
>Affects Versions: 3.2.0
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-511.patch
>
>
> in FollowerHandler if sendPackets gets an ioexception on writeRecord the send 
> thread will exit, however the 
> socket isn't necessarily closed.
> 2009-08-19 15:28:46,869 - WARN  [Sender-/127.0.0.1:58179:followerhand...@131] 
> - Unexpected exception
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.sendPackets(FollowerHandler.java:128)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.access$0(FollowerHandler.java:107)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler$1.run(FollowerHandler.java:325)
> This results in the follower taking a very long time to recover and rejoin 
> the quorum.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-511) bad error handling in FollowerHandler.sendPackets

2010-03-05 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-511:


Attachment: ZOOKEEPER-511.patch

this patch fixes the issue by closing the socket on a write error on the 
sendthread which will cause immediate notification of tcp socket error on the 
learner/observer side.

> bad error handling in FollowerHandler.sendPackets
> -
>
> Key: ZOOKEEPER-511
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-511
> Project: Zookeeper
>  Issue Type: Bug
>  Components: quorum, server
>Affects Versions: 3.2.0
>Reporter: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-511.patch
>
>
> in FollowerHandler if sendPackets gets an ioexception on writeRecord the send 
> thread will exit, however the 
> socket isn't necessarily closed.
> 2009-08-19 15:28:46,869 - WARN  [Sender-/127.0.0.1:58179:followerhand...@131] 
> - Unexpected exception
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.sendPackets(FollowerHandler.java:128)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.access$0(FollowerHandler.java:107)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler$1.run(FollowerHandler.java:325)
> This results in the follower taking a very long time to recover and rejoin 
> the quorum.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-511) bad error handling in FollowerHandler.sendPackets

2010-03-05 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-511:
---

Fix Version/s: (was: 3.3.0)
   3.4.0

> bad error handling in FollowerHandler.sendPackets
> -
>
> Key: ZOOKEEPER-511
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-511
> Project: Zookeeper
>  Issue Type: Bug
>  Components: quorum, server
>Affects Versions: 3.2.0
>Reporter: Patrick Hunt
> Fix For: 3.4.0
>
>
> in FollowerHandler if sendPackets gets an ioexception on writeRecord the send 
> thread will exit, however the 
> socket isn't necessarily closed.
> 2009-08-19 15:28:46,869 - WARN  [Sender-/127.0.0.1:58179:followerhand...@131] 
> - Unexpected exception
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.sendPackets(FollowerHandler.java:128)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler.access$0(FollowerHandler.java:107)
>   at 
> org.apache.zookeeper.server.quorum.FollowerHandler$1.run(FollowerHandler.java:325)
> This results in the follower taking a very long time to recover and rejoin 
> the quorum.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.