[Zope-dev] Re: Please vote about conflict errors logging
Here's my own vote :) 1. Do you want these ConflictErrors retried logs to be at level: BLATHER 2. In addition, please specify if you feel those retried ConflictErrors should have their full traceback logged? No, without traceback 3. Finally, please tell us if the ConflictErrors that *can't* be retried (and are returned to the user as an error, and are also logged to the error_log) should be additionally explicitely logged to the event log, and at which level: ERROR Florent -- Florent Guillaume, Nuxeo (Paris, France) Director of R&D +33 1 40 33 71 59 http://nuxeo.com [EMAIL PROTECTED] ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Please vote about conflict errors logging
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Florent Guillaume wrote: > Please vote for the level at which you want to log retried conflict > errors. These are the ConflictErrors that aren't returned to the user > but automatically retried by the Zope publisher. > > 1. Do you want these ConflictErrors retried logs to be at level: > - INFO > - BLATHER > - DEBUG > - not logged > - other BLATHER > 2. In addition, please specify if you feel those retried ConflictErrors > should have their full traceback logged? > - Yes, with traceback > - No, without traceback Yes, with traceback > 3. Finally, please tell us if the ConflictErrors that *can't* be > retried (and are returned to the user as an error, and are also logged > to the error_log) should be additionally explicitely logged to the > event log, and at which level: > - ERROR > - not logged > - other ERROR > (Also, if you feel the logging should be different between 2.8 and 2.9, > please say so.) Make it the same. Tres. - -- === Tres Seaver +1 202-558-7113 [EMAIL PROTECTED] Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDkQ+++gerLs4ltQ4RAhDrAJ9pjTXb9F6bEoZGQ1xTA2lyI47knQCgiXWK 8blEg0KiwVIIKlt95gK9CPg= =JUyS -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Please vote about conflict errors logging
Ok after a week the consensus is pretty much in favor of 1. INFO 2. no traceback 3. ERROR So here's what I'll do: 1. There's enough votes for BLATHER that I'll add zope.conf option to change the level, but it will default to INFO. 2. No traceback will be logged anymore. Note that you'll still have the traceback from point 3. 3. Here maybe things were unclear. Everybody agrees that the error should happen at ERROR level, but I must point out again that no explicit logging is needed because it is already done if you configure error_log to copy exceptions to the event.log. So I propose another little change: have the error_log copy to event.log be the default behaviour. Today the default is off. Florent Florent Guillaume wrote: Please vote for the level at which you want to log retried conflict errors. These are the ConflictErrors that aren't returned to the user but automatically retried by the Zope publisher. 1. Do you want these ConflictErrors retried logs to be at level: - INFO - BLATHER - DEBUG - not logged - other 2. In addition, please specify if you feel those retried ConflictErrors should have their full traceback logged? - Yes, with traceback - No, without traceback 3. Finally, please tell us if the ConflictErrors that *can't* be retried (and are returned to the user as an error, and are also logged to the error_log) should be additionally explicitely logged to the event log, and at which level: - ERROR - not logged - other (Also, if you feel the logging should be different between 2.8 and 2.9, please say so.) I'll wait until Wednesday morning to collect results. -- Florent Guillaume, Nuxeo (Paris, France) CTO, Director of R&D +33 1 40 33 71 59 http://nuxeo.com [EMAIL PROTECTED] ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Please vote about conflict errors logging
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Florent Guillaume wrote: > Ok after a week the consensus is pretty much in favor of > 1. INFO > 2. no traceback > 3. ERROR > > So here's what I'll do: > > 1. There's enough votes for BLATHER that I'll add zope.conf option to > change the level, but it will default to INFO. OK, I can live with that. I was going to suggest a config option, but defaulted the other way. > 2. No traceback will be logged anymore. Note that you'll still have the > traceback from point 3. > > 3. Here maybe things were unclear. Everybody agrees that the error > should happen at ERROR level, but I must point out again that no > explicit logging is needed because it is already done if you configure > error_log to copy exceptions to the event.log. > > So I propose another little change: have the error_log copy to event.log > be the default behaviour. Today the default is off. +1 to that (as long as we leave Unauthorized, NotFound, and Redirect excluded by default). Tres. - -- === Tres Seaver +1 202-558-7113 [EMAIL PROTECTED] Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDmfRJ+gerLs4ltQ4RAnRoAKCiWk45LPc55C71Uuji6qGHgfEnfgCfbHvr fpKYRC+teAopydRnW6esJmA= =IR1c -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Please vote about conflict errors logging
On Fri, Dec 09, 2005 at 03:45:18PM +0100, Florent Guillaume wrote: > So I propose another little change: have the error_log copy to event.log be > the default behaviour. Today the default is off. +100 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Please vote about conflict errors logging
On 9 Dec 2005, at 14:45, Florent Guillaume wrote: So I propose another little change: have the error_log copy to event.log be the default behaviour. Today the default is off. +1 jens ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Please vote about conflict errors logging
Florent Guillaume wrote: Ok after a week the consensus is pretty much in favor of 1. INFO 2. no traceback 3. ERROR 1. There's enough votes for BLATHER that I'll add zope.conf option to change the level, but it will default to INFO. As an idea, make your zope.conf key be of the same type as the "level" parameter in the eventlog section, that way, you should be able to change the code to be: logger.log(whatever_your_zconfig_option_is,...whatever I used...) ...making it even more flexible at no extra cost. Some people (maybe me ;-) might even like this stuff logged at logging.error so I get a MailingLogger entry _whenever_ a ConflictError is logged, not just when a user sees it. (this is because I have a good idea that ConflictErrors due to silly use of the temp_folder in the largest of the projects I'm currently working on is a major source of poor performance) Also, in case you don't manage the above, please use logging.debug, not BLATHER, since I'll be eradicating that silly name as part of my work to deprecate zLOG... 2. No traceback will be logged anymore. Note that you'll still have the traceback from point 3. Indeed, and it's still just as useless there ;-) 3. Here maybe things were unclear. Everybody agrees that the error should happen at ERROR level, but I must point out again that no explicit logging is needed because it is already done if you configure error_log to copy exceptions to the event.log. Yup :-) So I propose another little change: have the error_log copy to event.log be the default behaviour. Today the default is off. +lotz :-) Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Please vote about conflict errors logging
On Fri, 2005-12-09 at 15:45 +0100, Florent Guillaume wrote: > So I propose another little change: have the error_log copy to event.log be > the default behaviour. Today the default is off. > > Florent > +1 A ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Please vote about conflict errors logging
Florent Guillaume wrote at 2005-12-9 15:45 +0100: > ... >So I propose another little change: have the error_log copy to event.log be >the default behaviour. Today the default is off. +1 -- Dieter ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
