Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-31 Thread Jim Graham
I want to elaborate on winding count issues for segments to the left of the clip for both winding modes. All curves have the property that the winding count of any sample point to the right of them is identical to the winding count of a line from their starting point to their ending point. Co

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-31 Thread Jim Graham
I had another thought here. If you have some plan where you can identify incoming paths as "probably benefiting from more aggressive clipping logic" vs others that are classified as "most likely will have little to no clipping" and you want to avoid the overhead of having the early-rejection cl

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-31 Thread Jim Graham
First, consider what is handled inside the guts of the Renderer process. - It doesn't need to process any segments above or below the clip, they have no impact on the rendered pieces inside the clip - It needs to process segments that are out-left only in so far as it needs to come up with a pro

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-31 Thread Laurent Bourgès
Hi Jim, I am answering your first message: Area is overkill for this as it tries to find exact intersection points of arbitrary geometry. You simply need something that will trace accurately around the outside of a clip to get from an exit point back to an entry point. That is a much simpler op

Re: [OpenJDK 2D-Dev] RFR: 8183351: Better cleanup for jdk/test/javax/imageio/spi/AppletContextTest/BadPluginConfigurationTest.sh

2017-08-31 Thread Tim Bell
Hi Phil Looks good to me as well. Tim On 08/31/17 12:48, Sergey Bylokhov wrote: +1 On 8/31/17 12:21, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8183351 Webrev: http://cr.openjdk.java.net/~prr/8183351/ This bug caused an internal test system to report a failure of this te

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-31 Thread Jim Graham
To be clear, all that would be needed in cubicTo would be: if (y0 > bot && y1 > bot && y2 > bot && y3 > bot) { xy0 = xy3; return; } if (y0 < top && y1 < top && y2 < top && y3 < top) { xy0 = xy3; return; } if (x0 > rgt && x1 > rgt && x2 > rgt && x3 > rgt) { xy0 = xy3; return; } if (x0 < lft && x1

Re: [OpenJDK 2D-Dev] RFR: 8183351: Better cleanup for jdk/test/javax/imageio/spi/AppletContextTest/BadPluginConfigurationTest.sh

2017-08-31 Thread Sergey Bylokhov
+1 On 8/31/17 12:21, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8183351 Webrev: http://cr.openjdk.java.net/~prr/8183351/ This bug caused an internal test system to report a failure of this test when the userid used to run the tests changed due to lack of this cleanup, so I'd

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-31 Thread Jim Graham
Hi Laurent, Area is overkill for this as it tries to find exact intersection points of arbitrary geometry. You simply need something that will trace accurately around the outside of a clip to get from an exit point back to an entry point. That is a much simpler operation. The performance is

[OpenJDK 2D-Dev] RFR: 8183351: Better cleanup for jdk/test/javax/imageio/spi/AppletContextTest/BadPluginConfigurationTest.sh

2017-08-31 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8183351 Webrev: http://cr.openjdk.java.net/~prr/8183351/ This bug caused an internal test system to report a failure of this test when the userid used to run the tests changed due to lack of this cleanup, so I'd like to get this one in soon. It is a

[OpenJDK 2D-Dev] Font bug with minimal fonts installed

2017-08-31 Thread Mario Torre
I have a weird issue with fonts in RHEL (and that means likely means all derivative, like CentOS and Oracle Linux), although it appears that the same issue can be replicated on a Fedora 26. The issue is this one, in case you want to see more details: https://bugzilla.redhat.com/show_bug.cgi?id=14

[OpenJDK 2D-Dev] [10] RFR JDK-8186987:NullPointerException in RasterPrinterJob without PrinterResolution

2017-08-31 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it a NPE is seen when an attempt is made to print to Brother HL-2240D series printer. It seems when RasterPrinterJob#setAttributes() is called with no PrinterResolution attribute set, it first checks if PrinterResolution category is supported. I

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

2017-08-31 Thread Laurent Bourgès
Jim, FYI I am working on a more general clipper for filled shapes (only non zero winding rule) that ignores useless segments on left / right sides but leaves the path closed for filling primitives. It is more tricky... to handle turning points (corners) but I think it could be applied later to th