Re: [OpenJDK 2D-Dev] RFR: 8233006: freetype incorrectly adjusts advances when emboldening rotated glyphs

2020-04-15 Thread Jayathirth D v
Hi Phil, Thanks for the detailed evaluation in bug and here. Change looks good to me. Newly added file has copyright year 2018. Please update it before pushing. I ran smaller set of rotate tests for font and they all pass with this change. Does this new change handle non-bold use cases also as

[OpenJDK 2D-Dev] RFR: 8233006: freetype incorrectly adjusts advances when emboldening rotated glyphs

2020-04-15 Thread Philip Race
Bug : https://bugs.openjdk.java.net/browse/JDK-8233006 Webrev : http://cr.openjdk.java.net/~prr/8233006 The bug here is that the freetype function for synthesising bold is not ready to handle rotation. In the process I noticed it did not adjust the advance used by the fractional metrics