https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/76030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/76171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/76766
BreakpointResolverAddress optionally can include the module name related to the
address that gets resolved. Currently this will never work because it sets the
name to itself (which is empty).
>From 519f2db688
bulbazord wrote:
> Can this be tested?
I took a look at existing tests, but I'm not sure how to best test this. I
think we would need to create a breakpoint in a module by address and make sure
the resolver correctly serializes the name (in `statistics dump` or otherwise).
Does that sound app
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/76766
>From a9b6b6fee19fd19bf1fdce6fe8e9ed35f7c1567a Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 2 Jan 2024 15:44:30 -0800
Subject: [PATCH] [lldb] Fix breakpoint resolver serialization bug
BreakpointReso
bulbazord wrote:
@clayborg I was able to write a test similar to what you suggested (without
needing to set two breakpoints). I also changed the actual fix since a module's
object name isn't quite what I wanted in the first place.
https://github.com/llvm/llvm-project/pull/76766
___
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/76766
>From 9688e85a01c8c952a3db17510cc97ce6db570e96 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 2 Jan 2024 15:44:30 -0800
Subject: [PATCH] [lldb] Fix breakpoint resolver serialization bug
BreakpointReso
@@ -49,6 +49,37 @@ def test_scripted_extra_args(self):
self.setup_targets_and_cleanup()
self.do_check_extra_args()
+def test_resolver_serialization(self):
+"""Test that breakpoint resolvers contain the expected information"""
+self.build()
+
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/76766
>From 9688e85a01c8c952a3db17510cc97ce6db570e96 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 2 Jan 2024 15:44:30 -0800
Subject: [PATCH 1/2] [lldb] Fix breakpoint resolver serialization bug
Breakpoint
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/76766
>From 9688e85a01c8c952a3db17510cc97ce6db570e96 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 2 Jan 2024 15:44:30 -0800
Subject: [PATCH 1/3] [lldb] Fix breakpoint resolver serialization bug
Breakpoint
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/76766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
Looks like this broke on aarch64-windows. Taking a look now.
https://github.com/llvm/llvm-project/pull/76766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
```
==
ERROR: test_resolver_serialization
(TestBreakpointSerialization.BreakpointSerialization)
Test that breakpoint resolvers contain the expected information
Author: Alex Langford
Date: 2024-01-03T15:50:25-08:00
New Revision: bdaedffc43a608ef5fdc8a0e0c524be0a3a8f72e
URL:
https://github.com/llvm/llvm-project/commit/bdaedffc43a608ef5fdc8a0e0c524be0a3a8f72e
DIFF:
https://github.com/llvm/llvm-project/commit/bdaedffc43a608ef5fdc8a0e0c524be0a3a8f72e.diff
bulbazord wrote:
Speculative fix in bdaedffc43a608ef5fdc8a0e0c524be0a3a8f72e
https://github.com/llvm/llvm-project/pull/76766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/76974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/77161
This abstraction is leaky and BreakpointIDList does not need to know about
CommandReturnObject.
Additionally, setting the CommandReturnObject inout param to a success state
does very little. The function retur
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/77166
There are 2 motivations here:
1.) There is no need to hand out constant references to BreakpointIDs,
they are only 8 bytes big. In addition, every use of this method already
makes a copy anyway.
2.) Each Bre
bulbazord wrote:
> LGTM!
>
> I see that we still have `FindAndReplaceIDRanges` referencing
> CommandReturnObject; out of curiosity, have you had a chance to look into
> removing that one (if it makes sense)? I see that `CommandReturnObject` is
> neither `#include`ed nor forward declared in th
@@ -20,17 +20,15 @@ using namespace lldb_private;
// class BreakpointIDList
-BreakpointIDList::BreakpointIDList()
-: m_invalid_id(LLDB_INVALID_BREAK_ID, LLDB_INVALID_BREAK_ID) {}
+BreakpointIDList::BreakpointIDList() : m_breakpoint_ids() {}
BreakpointIDList::~Breakpoin
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/77161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/77166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
I don't have a lot of knowledge about the C++20 calendar types, but the LLDB
implementation looks ok to me.
What do you think @Michael137?
https://github.com/llvm/llvm-project/pull/76983
___
lldb-commits mailin
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/71228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/71993
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/77854
TLS implementation on Apple OSes has changed. Instead of acquiring a
pthread_key and calling pthread_getspecific, we instead acquire a function
pointer and perform a function call with it. This fixes accessing
@@ -1048,70 +1048,107 @@ DynamicLoaderDarwin::GetThreadLocalData(const
lldb::ModuleSP module_sp,
std::lock_guard guard(m_mutex);
- const uint32_t addr_size = m_process->GetAddressByteSize();
+ lldb_private::Address tls_addr;
+ if (!module_sp->ResolveFileAddress(tls_file
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/77858
BreakpointIDList does not need to know about CommandReturnObject.
BreakpointIDList::FindAndReplaceIDRanges is the last place that uses it in
BreakpointIDList.
Instead of passing in a CommandReturnObject, it n
bulbazord wrote:
> LGTM!
>
> Should we `#include llvm/Support/Error.h"` in the BreakpointIDList header?
Ah, I didn't add it but it builds so it's probably getting it transitively.
I'll add it for future-proofing.
https://github.com/llvm/llvm-project/pull/77858
bulbazord wrote:
> Currently this is a little hard to read given a bunch of shared setup
> followed by two possible ways to read the TLS data. If those implementations
> don't require too many inputs, it might be worth splitting this out into two
> helper functions to make this easier to follo
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/77858
>From d138a85dbddf5373e0a60d8467768c186e343f1b Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 11 Jan 2024 16:51:03 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Remove CommandReturnObject from
BreakpointIDL
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/77988
I decided to resubmit #77854 but broken up into multiple commits for better
reviewability. I recommend reviewing each commit individually, the overall
change is quite large.
rdar://120676969
>From cf2597f907
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/77854
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
I broke up this PR into multiple commits and resubmitted at
https://github.com/llvm/llvm-project/pull/77988. Please take a look!
https://github.com/llvm/llvm-project/pull/77854
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/77858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,291 @@
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/78029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/78029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/78370
This is a speculative fix for TestRosetta.py which is currently failing on
Green Dragon.
TestRosetta just makes sure we can debug an x86_64 process on Apple Silicon.
However, we're failing to build the x86_64
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/78370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1048,74 +1048,103 @@ DynamicLoaderDarwin::GetThreadLocalData(const
lldb::ModuleSP module_sp,
std::lock_guard guard(m_mutex);
+ lldb_private::Address tls_addr;
+ if (!module_sp->ResolveFileAddress(tls_file_addr, tls_addr))
+return LLDB_INVALID_ADDRESS;
+
+ Target
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/77988
>From cf2597f907fd2566e202d763a91834515d9c8ae4 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 12 Jan 2024 13:03:27 -0800
Subject: [PATCH 1/4] [lldb][NFCI] Re-organize
DynamicLoaderDarwin::GetThreadLoc
@@ -1048,74 +1048,103 @@ DynamicLoaderDarwin::GetThreadLocalData(const
lldb::ModuleSP module_sp,
std::lock_guard guard(m_mutex);
+ lldb_private::Address tls_addr;
+ if (!module_sp->ResolveFileAddress(tls_file_addr, tls_addr))
+return LLDB_INVALID_ADDRESS;
+
+ Target
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/77988
>From cf2597f907fd2566e202d763a91834515d9c8ae4 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 12 Jan 2024 13:03:27 -0800
Subject: [PATCH 1/5] [lldb][NFCI] Re-organize
DynamicLoaderDarwin::GetThreadLoc
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/77988
>From cf2597f907fd2566e202d763a91834515d9c8ae4 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 12 Jan 2024 13:03:27 -0800
Subject: [PATCH 1/6] [lldb][NFCI] Re-organize
DynamicLoaderDarwin::GetThreadLoc
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/77988
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/78508
The lifetime of these BreakpointEventData objects is difficult to reason about.
These BreakpointEventData pointers are created and passed along to `Event`
which takes the raw pointer and sticks them in a share
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/78508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
Hmm, yeah testing this is probably tricky to do.
Nonetheless, I think your cleanup logic makes sense. It's also nice that you've
documented the intended behavior. 😄
https://github.com/llvm/llvm-project/pull/78652
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/78773
BroadcastEvent currently takes its EventData* param and shoves it into an Event
object, which takes ownership of the pointer and places it into a shared_ptr to
manage the lifetime.
Instead of relying on `new`
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/78773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79045
Instead of passing the data to BroadcastEventIfUnique to create an Event object
on the behalf of the caller, the caller can create the Event up-front.
>From 9cb80e3f334d3cf3dafed4bda6f87289ad330054 Mon Sep 17
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79064
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
I thought about this more and talked with Jim offline. I think that it makes
sense for Broadcaster to create Events with the event_type and the EventDataSP.
I'm going to switch my approach and abandon this one.
https://github.com/llvm/llvm-project/pull/79064
__
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79189
This overload is completely unused.
>From c04b7a72444b167ab59604a7dce84bfadad0d45e Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 23 Jan 2024 10:33:07 -0800
Subject: [PATCH] [lldb][NFCI] Remove unused
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79194
This was likely overlooked when SBFormat was added.
>From d96c07d55a76d333193a033cd0516243d01e2bf4 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 23 Jan 2024 11:20:19 -0800
Subject: [PATCH] [lldb] Inc
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79194
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79189
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79215
None
>From 0e22f21875041f98e42b8573491bf8b9cfc1e01f Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 23 Jan 2024 13:54:00 -0800
Subject: [PATCH] [lldb][NFCI] Remove unused method
BreakpointIDList::Find
https://github.com/bulbazord approved this pull request.
Thanks for taking care of that!
https://github.com/llvm/llvm-project/pull/79385
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/79389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79508
There are 3 ways to create an EventDataBytes object: (const char *),
(llvm::StringRef), and (const void *, size_t len). All of these cases can be
handled under `llvm::StringRef`. Additionally, this allows us t
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79517
`FindBreakpointID` take a BreakpointID and a pointer to a size_t (so you can
get position information). It returns a bool to indicate whether the id was
found in the list or not.
There are 2 callers of this c
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4281,25 +4281,31 @@ void
Process::CalculateExecutionContext(ExecutionContext &exe_ctx) {
//return Host::GetArchSpecForExistingProcess (process_name);
//}
+EventSP Process::CreateEventFromProcessState(uint32_t event_type) {
+ auto event_data_sp =
+ std::make_shar
@@ -0,0 +1,105 @@
+#include "Plugins/Platform/MacOSX/PlatformMacOSX.h"
bulbazord wrote:
Don't forget to include the license header in this file
https://github.com/llvm/llvm-project/pull/79533
___
lldb-commits mailing l
@@ -4281,25 +4281,31 @@ void
Process::CalculateExecutionContext(ExecutionContext &exe_ctx) {
//return Host::GetArchSpecForExistingProcess (process_name);
//}
+EventSP Process::CreateEventFromProcessState(uint32_t event_type) {
+ auto event_data_sp =
+ std::make_shar
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79045
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/79644
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/79649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ Status status;
bulbazord wrote:
Suggestion: You can remove this and just return {} below.
https://github.com/llvm/llvm-project/pull/79662
__
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ Status status;
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+
https://github.com/bulbazord approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/79656
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ Status status;
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79716
The purpose of m_being_created in these classes was to prevent broadcasting an
event related to these Breakpoints during the creation of the breakpoint (i.e.
in the constructor). In Breakpoint and Watchpoint,
@@ -313,6 +313,8 @@ class BreakpointLocation
void UndoBumpHitCount();
+ void SetThreadIDInternal(lldb::tid_t thread_id);
bulbazord wrote:
Sure
https://github.com/llvm/llvm-project/pull/79716
___
lldb-commits ma
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79716
>From fc0c5da871d32a7cf5a6c96ef7f36c49aeccd074 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Sat, 27 Jan 2024 15:54:16 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Remove m_being_created from Breakpoint
classe
@@ -313,6 +313,8 @@ class BreakpointLocation
void UndoBumpHitCount();
+ void SetThreadIDInternal(lldb::tid_t thread_id);
bulbazord wrote:
@jimingham how does this look to you?
https://github.com/llvm/llvm-project/pull/79716
__
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79901
I was refactoring something else but ran into this function. It was somewhat
confusing to read through and understand, but it boils down to two steps:
- First we try `OptionArgParser::ToBoolean`. If that works,
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79901
>From 7ce769f1a5bde83e0ff7ae36852c7a742bbb990b Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 29 Jan 2024 13:15:24 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Minor refactor to
CommandObjectProcessHandle:
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79716
>From 1f81c3e01a12682ad514038d2e9f1baea80dcf03 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Sat, 27 Jan 2024 15:54:16 -0800
Subject: [PATCH 1/3] [lldb][NFCI] Remove m_being_created from Breakpoint
classe
bulbazord wrote:
> This version is still a little awkward because there's an ambiguity about
> what the incoming string being empty means. In the VerifyCommandOptionValue,
> it means "No Value" and the return is not distinguishable from "error" - but
> in a bunch of the places where you use Ve
@@ -1591,24 +1591,24 @@ class CommandObjectProcessHandle : public
CommandObjectParsed {
Options *GetOptions() override { return &m_options; }
- bool VerifyCommandOptionValue(const std::string &option, int &real_value) {
-bool okay = true;
+ std::optional VerifyComman
bulbazord wrote:
Okay, here's what I'll do then:
1. I will remove `VerifyCommandOptionValue` and replace uses of it with
`OptionArgParser::ToBoolean`.
2. Afterwards, I will change the interface of `OptionArgParser::ToBoolean`.
https://github.com/llvm/llvm-project/pull/79901
__
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79901
>From 3cd6afa16fb8b282712b1d3cf103abbd3329fc17 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 29 Jan 2024 13:15:24 -0800
Subject: [PATCH 1/3] [lldb][NFCI] Minor refactor to
CommandObjectProcessHandle:
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,146 @@
+//===-- WatchpointAlgorithms.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord commented:
I haven't looked at the algorithm in great detail yet but a lot of the
surrounding stuff looks pretty reasonable I think.
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commi
@@ -0,0 +1,38 @@
+//===-- WatchpointAlgorithms.h *- C++
bulbazord wrote:
The header needs adjustment
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lld
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,38 @@
+//===-- WatchpointAlgorithms.h *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
bulbazord wrote:
@clayborg how does this look to you?
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79716
>From f7bc2e013fb4a5cac93d2c5856983796459fb84b Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Sat, 27 Jan 2024 15:54:16 -0800
Subject: [PATCH 1/4] [lldb][NFCI] Remove m_being_created from Breakpoint
classe
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/79716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/80602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
701 - 800 of 1001 matches
Mail list logo
