Re: [PATCH v3 07/10] media: intel: Add Displayport RX IP driver

2024-06-07 Thread Hans Verkuil
On 04/06/2024 14:32, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 10:37 AM Hans Verkuil wrote: >> >> On 07/05/2024 17:54, Paweł Anikiel wrote: >>> Add v4l2 subdev driver for the Intel Displayport receiver FPGA IP. >>> It is a part of the DisplayPort

[git:v4l-utils/master] v4l2-compliance: Fix building against libc++

2024-06-07 Thread Hans Verkuil
. compiler.h is for C as well as C++ though, so use __cplusplus to check for a C++ compiler before including . Signed-off-by: James Le Cuirot Signed-off-by: Hans Verkuil include/compiler.h | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) --- http

[git:edid-decode/master] edid-decode: build: compile with -Wno-variadic-macros

2024-06-07 Thread Hans Verkuil
different standard versions but did not manage. So, I'm not sure why this is needed other than silencing annoying warnings in libdisplay-info. Signed-off-by: Sebastian Wick Signed-off-by: Hans Verkuil meson.build | 1 + 1 file changed, 1 insertion(+) --- diff --git a/meson.build b/meson.build index

[git:edid-decode/master] edid-decode: build: Use override_find_program to help subproject usage

2024-06-06 Thread Hans Verkuil
is a subproject: subproject('edid-decode') edid_decode = find_program('edid-decode') Signed-off-by: Sebastian Wick Signed-off-by: Hans Verkuil meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) --- diff --git a/meson.build b/meson.build index 1e0fe251dcc8..2340714bc879

[git:edid-decode/master] edid-decode: build: Move sources to its own variable and fix formatting

2024-06-06 Thread Hans Verkuil
. Signed-off-by: Sebastian Wick Signed-off-by: Hans Verkuil meson.build | 12 1 file changed, 8 insertions(+), 4 deletions(-) --- diff --git a/meson.build b/meson.build index ca5765276bc5..1e0fe251dcc8 100644 --- a/meson.build +++ b/meson.build @@ -46,8 +46,7 @@ if target_machine.system

[git:edid-decode/master] edid-decode: Cannot support NonMixed MS without MS

2024-06-05 Thread Hans Verkuil
cannot support NonMixed MS. An EDID with Max Stream Count = 0 and Non Mixed MS = 1 can be found in linuxhw/EDID ./Digital/TCL/TCL5655/1723FF2DC6D1 at commit cff7fe4d44. v2: * Log a failure instead of silently ignoring Non Mixed MS Signed-off-by: Sebastian Wick Signed-off-by: Hans Verkuil

[git:media_stage/master] media: av7110: remove old documentation files

2024-06-04 Thread Hans Verkuil
/media/dvb/legacy_dvb_osd.rst linux/Documentation/userspace-api/media/dvb/legacy_dvb_audio.rst linux/Documentation/userspace-api/media/dvb/legacy_dvb_video.rst The .rst files of the old documentation aren't necessary any more, remove them. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil

[git:media_stage/master] media: av7110: remove budget-patch driver

2024-06-04 Thread Hans Verkuil
he full-ts mod quiet a while now. Remove the budget-patch driver left over from development. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/Kconfig| 22 - drivers/staging/media/av7110/Makefile | 2 - drivers/staging/media/av7110/

[git:media_stage/master] media: sp8870: coding style fixes: miscellaneous

2024-06-04 Thread Hans Verkuil
Signed-off-by: Hans Verkuil drivers/staging/media/av7110/sp8870.c | 24 +--- drivers/staging/media/av7110/sp8870.h | 3 +-- 2 files changed, 14 insertions(+), 13 deletions(-) --- diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index

[git:media_stage/master] media: sp8870: coding style fixes: whitespace

2024-06-04 Thread Hans Verkuil
ce '{' WARNING:SPACING: space prohibited between function name and open parenthesis '(' CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis Whitespace changes only. "git diff -w" shows no changes. Signed-off-by: Stefan Herdler Signed-off-by: Hans Ver

[git:media_stage/master] media: sp8870: coding style fixes: newline, comments and braces

2024-06-04 Thread Hans Verkuil
changes only. [* The remaining trailing statement will be fixed in the logging patch.] Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/sp8870.c | 50 --- drivers/staging/media/av7110/sp8870.h | 13 - 2 files changed, 34

[git:media_stage/master] media: sp8870: coding style fixes: logging

2024-06-04 Thread Hans Verkuil
: trailing statements should be on next line Convert logging to the recommend pr_* macros. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/sp8870.c | 46 --- drivers/staging/media/av7110/sp8870.h | 2 +- 2 files changed, 27

[git:media_stage/master] media: av7110: coding style fixes: pointer_location

2024-06-04 Thread Hans Verkuil
: "foo * bar" should be "foo *bar" ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" Whitespace changes only. "git diff -w" shows no changes. Signed-off-by: Stefan Herdler

[git:media_stage/master] media: av7110: coding style fixes: whitespace

2024-06-04 Thread Hans Verkuil
git diff -w" shows no changes. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c | 62 ++--- drivers/staging/media/av7110/av7110_av.c| 30 +++--- drivers/staging/media/av7110/av7110_ca.c

[git:media_stage/master] media: av7110: coding style fixes: blank lines

2024-06-04 Thread Hans Verkuil
after declarations Added or removed blank lines only. "git diff --ignore-blank-lines" shows no changes. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c | 55 - drivers/staging/media/av7110/av7110.h

[git:media_stage/master] media: av7110: coding style fixes: whitespace (strict)

2024-06-04 Thread Hans Verkuil
preferred around that '|' (ctx:VxV) Additional whitespace fixes found by "checkpatch.pl --strict". Whitespace changes only. "git diff -w" shows no changes. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c | 60 ++

[git:media_stage/master] media: av7110: coding style fixes: miscellaneous

2024-06-04 Thread Hans Verkuil
unnecessary 'out of memory' message CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fe_func' - possible side-effects? The MACRO_ARG_REUSE isn't really fixed but marked as intentional. The comment is visible in the checkpatch warning. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil

[git:media_stage/master] media: av7110: coding style fixes: newline

2024-06-04 Thread Hans Verkuil
CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line Newline and whitespace changes only. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c | 22 +-- drivers/staging/media/av7110/av7110_av.c

[git:media_stage/master] media: av7110: coding style fixes: braces

2024-06-04 Thread Hans Verkuil
{} are not necessary for any arm of this statement WARNING:BRACES: braces {} are not necessary for single statement blocks CHECK:BRACES: braces {} should be used on all arms of this statement CHECK:BRACES: Unbalanced braces around else statement Signed-off-by: Stefan Herdler Signed-off-by: Hans

[git:media_stage/master] media: av7110: coding style fixes: comments

2024-06-04 Thread Hans Verkuil
-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c | 14 -- drivers/staging/media/av7110/av7110_av.c | 6 -- drivers/staging/media/av7110/av7110_ca.c | 3 ++- drivers/staging/media/av7110/av7110_hw.c | 9 ++--- drivers/staging

[git:media_stage/master] media: av7110: coding style fixes: assignments

2024-06-04 Thread Hans Verkuil
assignment in if condition CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c | 30 ++--- drivers/staging/media/av7110/av7110_av.c| 18

[git:media_stage/master] media: av7110: coding style fixes: comparsations

2024-06-04 Thread Hans Verkuil
: Comparisons should place the constant on the right side of the test CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written ... Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c | 10 +- drivers/staging/media/av7110/av7110_hw.c

[git:media_stage/master] media: av7110: coding style fixes: sizeof

2024-06-04 Thread Hans Verkuil
Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c | 2 +- drivers/staging/media/av7110/av7110_v4l.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) --- diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c

[git:media_stage/master] media: av7110: coding style fixes: variable types

2024-06-04 Thread Hans Verkuil
-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.c| 4 ++-- drivers/staging/media/av7110/av7110.h| 2 +- drivers/staging/media/av7110/av7110_av.c | 12 ++-- drivers/staging/media/av7110/av7110_av.h | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) --- diff

[git:media_stage/master] media: av7110: coding style fixes: avoid_externs

2024-06-04 Thread Hans Verkuil
prototypes should be avoided in .h files Removing unnecessary 'extern' declaration of function prototypes in header files. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110.h | 16 ++--- drivers/staging/media/av7110/av7110_av.h| 36

[git:media_stage/master] media: av7110: coding style fixes: deep_indentation

2024-06-04 Thread Hans Verkuil
: WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring Invert "if" statement to reduce indention level by 1. Signed-off-by: Stefan Herdler Signed-off-by: Hans Verkuil drivers/staging/media/av7110/av7110_ipack.c | 234 ++-- 1 file changed, 117 insertio

[git:media_stage/master] media: av7110: coding style fixes: logging

2024-06-04 Thread Hans Verkuil
nclude KERN_ facility level WARNING:TRACING_LOGGING: Unnecessary ftrace-like logging - prefer using ftrace There where different logging styles in this drivers. Convert everything to the recommend pr_* macros. Log messages should mostly be unchanged by this patch. Signed-off-by: Stefan Herdl

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-04 Thread Hans Verkuil
On 04/06/2024 14:03, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 4:56 PM Hans Verkuil wrote: >> >> On 03/06/2024 16:32, Paweł Anikiel wrote: >>> On Mon, Jun 3, 2024 at 9:57 AM Hans Verkuil >>> wrote: >>>> >>>> On 07/05/2024 17:54,

[git:media_stage/master] media: i2c: imx258: Support faster pixel rate on binned modes

2024-06-04 Thread Hans Verkuil
for the link frequency to pixel rate function that needs to be added to the configuration tables. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 109

[git:media_stage/master] media: i2c: imx258: Make V4L2_CID_VBLANK configurable.

2024-06-04 Thread Hans Verkuil
there is no reason for it to be a read only control. Remove the register values from the mode lists, add the handler, and remove the read only flag. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c

[git:media_stage/master] media: i2c: imx258: Issue reset before starting streaming

2024-06-04 Thread Hans Verkuil
for the sensor, so send it before trying to configure the sensor. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 12 1 file changed, 12 insertions(+) --- diff --git

[git:media_stage/master] dt-bindings: media: imx258: Rename to include vendor prefix

2024-06-04 Thread Hans Verkuil
it. Update the id entry and MAINTAINERS to match. Signed-off-by: Dave Stevenson Acked-by: Conor Dooley Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil .../devicetree/bindings/media/i2c/{imx258.yaml => sony,imx258.yaml}

[git:media_stage/master] media: dt-bindings: media: Add bindings for IMX283

2024-06-04 Thread Hans Verkuil
entry for Sony IMX283 binding documentation Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Signed-off-by: Umang Jain Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil .../devicetree/bindings/media/i2c/sony,imx283.yaml | 107 + MAINTAINERS

[git:media_stage/master] media: i2c: imx258: Make HFLIP and VFLIP controls writable

2024-06-04 Thread Hans Verkuil
Note that the Bayer order changes with these flips, therefore they set the V4L2_CTRL_FLAG_MODIFY_LAYOUT property. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c |

[git:media_stage/master] media: subdev: Improve v4l2_subdev_enable/disable_streams_fallback

2024-06-04 Thread Hans Verkuil
restriction that v4l2_subdev_enable/disable_streams_fallback() only supports a single source pad. Reviewed-by: Laurent Pinchart Tested-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-s

[git:media_stage/master] media: i2c: dw9768: remove unused struct 'regval_list'

2024-06-04 Thread Hans Verkuil
("media: i2c: dw9768: Add DW9768 VCM driver") Remove it. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/dw9768.c | 5 - 1 file changed, 5 deletions(-) --- diff --git a/drivers/media/i2c/dw9768.c b/drivers/media/i2

[git:media_stage/master] media: i2c: imx258: Disable digital cropping on binned modes

2024-06-04 Thread Hans Verkuil
Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) --- diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index 4a7048d834c6..0ae4371940ca 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c

[git:media_stage/master] media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure

2024-06-04 Thread Hans Verkuil
Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258

[git:media_stage/master] media: i2c: imx258: Remove redundant I2C writes.

2024-06-04 Thread Hans Verkuil
for V4L2_CID_EXPOSURE, so are not needed from the mode lists. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 6 -- 1 file changed, 6 deletions(-) --- diff

[git:media_stage/master] media: i2c: imx258: Remove unused defines

2024-06-04 Thread Hans Verkuil
Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 6 -- 1 file changed, 6 deletions(-) --- diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index a577afb530b7

[git:media_stage/master] media: subdev: Support privacy led in v4l2_subdev_enable/disable_streams()

2024-06-04 Thread Hans Verkuil
Reviewed-by: Laurent Pinchart Tested-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-subdev.c | 9 + 1 file changed, 9 insertions(+) --- diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media

[git:media_stage/master] media: ipu6: Rework CSI-2 sub-device streaming control

2024-06-04 Thread Hans Verkuil
by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c | 98 +++--- drivers/media/pci/intel/ipu6/ipu6-isys-csi2.h | 2 - drivers/media/pci/intel/ipu6/ipu6-isys-queue.c | 3 - drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 43 ++--

[git:media_stage/master] media: i2c: imx258: Convert to new CCI register access helpers

2024-06-04 Thread Hans Verkuil
register access helpers in the imx258 driver. Signed-off-by: Luis Garcia Reviewed-by: Tommaso Merciai Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/imx258.c | 817 +++-- 2 files changed, 349

[git:media_stage/master] media: i2c: imx258: Use v4l2_link_freq_to_bitmap helper

2024-06-04 Thread Hans Verkuil
link freq can be used on a given system. Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Reviewed-by: Tommaso Merciai Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 12 1 file changed, 12 insertions(+) --- diff --git a/drivers/media

[git:media_stage/master] media: subdev: Support non-routing subdevs in v4l2_subdev_s_stream_helper()

2024-06-04 Thread Hans Verkuil
works for subdevices that support routing. As enable/disable_streams now also works for subdevices without routing, improve v4l2_subdev_s_stream_helper() to do the same. Reviewed-by: Laurent Pinchart Tested-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans

[git:media_stage/master] media: i2c: Add imx283 camera sensor driver

2024-06-04 Thread Hans Verkuil
: - 5472x3648 @ 20fps (SRGGB12) - 5472x3648 @ 25fps (SRGGB10) - 2736x1824 @ 50fps (SRGGB12) Signed-off-by: Kieran Bingham Signed-off-by: Umang Jain [Sakari Ailus: Take upstream runtime PM API changes into account.] Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil MAINTAINERS

[git:media_stage/master] media: subdev: Refactor v4l2_subdev_enable/disable_streams()

2024-06-04 Thread Hans Verkuil
-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-subdev.c | 109 +++--- 1 file changed, 60 insertions(+), 49 deletions(-) --- diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b

[git:media_stage/master] media: i2c: hi846: Fix V4L2_SUBDEV_FORMAT_TRY get_selection()

2024-06-04 Thread Hans Verkuil
ot;media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera") Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart [Sakari Ailus: code -> core.] Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/hi846.c | 2 +- 1 file changed, 1 insertio

[git:media_stage/master] media: subdev: Fix use of sd->enabled_streams in call_s_stream()

2024-06-04 Thread Hans Verkuil
g Jain Reviewed-by: Laurent Pinchart Tested-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-subdev.c | 8 ++-- include/media/v4l2-subdev.h | 3 +++ 2 files changed, 5 insertions(+), 6 del

[git:media_stage/master] media: async: Warn on attept to create an ancillary link to a non-subdev

2024-06-04 Thread Hans Verkuil
to a non-sub-device notifier. This isn't meaningful and unlikely to happen in practice but print a warning as we nevertheless won't consider this an error. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-async.c | 6 +- 1 file changed, 5 insertions(+), 1

[git:media_stage/master] media: i2c: imx258: Correct max FRM_LENGTH_LINES value

2024-06-04 Thread Hans Verkuil
FRM_LENGTH_LINES is 65525(decimal), not the 0x defined in this driver. Correct this limit. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 2

[git:media_stage/master] media: subdev: Add privacy led helpers

2024-06-04 Thread Hans Verkuil
the call site to the privacy led functions, and makes adding privacy led support to v4l2_subdev_enable/disable_streams() cleaner. Reviewed-by: Umang Jain Reviewed-by: Laurent Pinchart Tested-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil

[git:media_stage/master] media: i2c: imx258: Allow configuration of clock lane behaviour

2024-06-04 Thread Hans Verkuil
during frame blanking, or dropping to LP11. Add configuration of the mode via V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 13

[git:media_stage/master] media: i2c: imx258: Set pixel_rate range to the same as the value

2024-06-04 Thread Hans Verkuil
a minimum and maximum for the control, so change to set the value, min, and max all to the selected pixel rate. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media

[git:media_stage/master] media: subdev: Improve s_stream documentation

2024-06-04 Thread Hans Verkuil
subdevices too, there's no reason to use the old s_stream operation on new drivers. Extend the documentation reflecting this. Signed-off-by: Tomi Valkeinen Reviewed-by: Umang Jain Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil include/media/v4l2-subdev.h | 9

[git:media_stage/master] media: i2c: imx258: Add regulator control

2024-06-04 Thread Hans Verkuil
the driver to request the regulators and control them at the appropriate times. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 42 +- 1 file changed, 41 insertions

[git:media_stage/master] dt-bindings: media: imx258: Add alternate compatible strings

2024-06-04 Thread Hans Verkuil
not be differentiated at runtime, so add compatible strings for the PDAF variant. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Acked-by: Conor Dooley Reviewed-by: Pavel Machek Reviewed-by: Rob Herring Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Documentation/devicetree

[git:media_stage/master] media: subdev: Use v4l2_subdev_has_op() in v4l2_subdev_enable/disable_streams()

2024-06-04 Thread Hans Verkuil
/disable_streams() instead of open coding the same. Reviewed-by: Umang Jain Reviewed-by: Laurent Pinchart Tested-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-subdev.c | 4 ++-- 1 file changed, 2 insertions

[git:media_stage/master] media: i2c: imx258: Make image geometry meet sensor requirements

2024-06-04 Thread Hans Verkuil
configuration is for H flips to be enabled, so readout is from Y_STA_END to Y_ADD_STA, and this patch has changed Y_STA_END. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil

[git:media_stage/master] media: i2c: imx258: Add support for 24MHz clock

2024-06-04 Thread Hans Verkuil
a frequency listed in the datasheet. Add support for 24MHz as well. The PLL settings result in slightly different link frequencies, so parameterise those. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil

[git:media_stage/master] media: i2c: imx258: Add get_selection for pixel array information

2024-06-04 Thread Hans Verkuil
this information to the driver. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 90 ++ 1 file changed, 90 insertions

[git:media_stage/master] media: staging: max96712: Store format in subdev active state

2024-06-04 Thread Hans Verkuil
state. This change do not have a huge effect on the driver as it do not yet support changing the format. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/staging/media/max96712/max96712.c | 37

[git:media_stage/master] media: i2c: imx258: Change register settings for variants of the sensor

2024-06-04 Thread Hans Verkuil
for that variant Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 47 ++ 1 file changed, 43 insertions(+), 4 deletions(-) --- diff

[git:media_stage/master] media: subdev: Add checks for subdev features

2024-06-04 Thread Hans Verkuil
-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-subdev.c | 27 +++ 1 file changed, 27 insertions(+) --- diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2

[git:media_stage/master] media: i2c: Fix imx412 exposure control

2024-06-04 Thread Hans Verkuil
opo Mondi Reviewed-by: Gjorgji Rosikopulos Signed-off-by: Bryan O'Donoghue Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx412.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) --- diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c

[git:media_stage/master] media: subdev: Add v4l2_subdev_is_streaming()

2024-06-04 Thread Hans Verkuil
. if .s_stream or .enable_streams has been called successfully. Reviewed-by: Umang Jain Reviewed-by: Laurent Pinchart Tested-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-subdev.c | 25

[git:media_stage/master] media: ipu-bridge: add mod_devicetable.h header inclusion

2024-06-04 Thread Hans Verkuil
be guaranteed to included in ipu-bridge.h instead of the source files which include ipu-bridge.h. Signed-off-by: Bingbu Cao Reviewed-by: Andy Shevchenko Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil include/media/ipu-bridge.h | 1 + 1 file changed, 1 insertion(+) --- diff --git a/include

[git:media_stage/master] media: i2c: imx258: Split out common registers from the mode based ones

2024-06-04 Thread Hans Verkuil
, only around 10 differ between the modes. Split the table into common and mode specific ones. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 236

[git:media_stage/master] media: v4l: async: Fix NULL pointer dereference in adding ancillary links

2024-06-04 Thread Hans Verkuil
in v4l2_async_create_ancillary_links(). Fixes: aa4faf6eb271 ("media: v4l2-async: Create links during v4l2_async_match_notify()") Signed-off-by: ChiYuan Huang [Sakari Ailus: Reword the subject and commit messages slightly.] Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-a

[git:media_stage/master] media: subdev: Support single-stream case in v4l2_subdev_enable/disable_streams()

2024-06-04 Thread Hans Verkuil
ams() code has ever been tested with sink pads, so to be on the safe side, I added the same check to the v4l2_subdev_enable/disable_streams() functions. Reviewed-by: Laurent Pinchart Tested-by: Umang Jain Signed-off-by: Tomi Valkeinen Signed-off-by: Sakari Ailus Signed-off-by: Hans Verk

[git:media_stage/master] media: i2c: imx258: Add support for running on 2 CSI data lanes

2024-06-04 Thread Hans Verkuil
are obviously more restricted on 2 lanes, but some hardware simply hasn't wired more up. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx258.c | 214 - 1 file changed

[git:media_stage/master] media: i2c: adv7511: remove unused struct 'i2c_reg_value'

2024-06-04 Thread Hans Verkuil
("[media] adv7511: add new video encoder"). Remove it. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/adv7511-v4l2.c | 5 - 1 file changed, 5 deletions(-) --- diff --git a/drivers/media/i2c/adv7511-v4l2.c b/dri

[git:media_stage/master] media: i2c: tw9910: remove unused strust 'regval_list'

2024-06-04 Thread Hans Verkuil
L/DVB (13666): tw9910: modify V/H outpit pin setting to use VALID"). Remove it. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/tw9910.c | 5 - 1 file changed, 5 deletions(-) --- diff --git a/drivers/media/i2c/tw9910.c

[git:media_stage/master] media: i2c: ks0127: remove unused struct 'adjust'

2024-06-04 Thread Hans Verkuil
L/DVB (3916): AverMedia 6 Eyes AVS6EYES support"). Remove it. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/ks0127.c | 8 1 file changed, 8 deletions(-) --- diff --git a/drivers/media/i2c/ks0127.c b/drivers/media/

[git:media_stage/master] media: ipu6: Print CSR messages using debug level

2024-06-04 Thread Hans Verkuil
). There's no need to warn the user about that. Suggested-by: Bingbu Cao Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/pci/intel/ipu6/ipu6-buttress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.c b

[git:media_stage/master] media: v4l2-subdev: Fix v4l2_subdev_state_get_format() documentation

2024-06-04 Thread Hans Verkuil
-off-by: Sakari Ailus Signed-off-by: Hans Verkuil include/media/v4l2-subdev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index df66365576dd..ed339f0116bf 100644 --- a/include/media/v4l2-subdev.h +++ b

[git:media_stage/master] media: v4l2-cci: Always assign *val

2024-06-04 Thread Hans Verkuil
of the variables data is read to using cci_read(). Once smatch is fixed, it could catch the use of uninitialised reads. Signed-off-by: Sakari Ailus Tested-by: Benjamin Mugnier Reviewed-by: Hans de Goede Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-cci.c | 9 + 1 file changed

[git:media_stage/master] media: v4l2-subdev: Provide const-aware subdev state accessors

2024-06-04 Thread Hans Verkuil
the word "below" from the text.] Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil include/media/v4l2-subdev.h | 54 ++--- 1 file changed, 36 insertions(+), 18 deletions(-) --- diff --git a/include/media/v4l2-subdev.h b/include/media/v4l

[git:media_stage/master] media: rkisp1: Mark subdev state pointers as const

2024-06-04 Thread Hans Verkuil
them as const. Signed-off-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen Reviewed-by: Nicolas Dufresne Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 8 drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c | 8

[git:media_stage/master] dt-bindings: media: add Maxim MAX96717 GMSL2 Serializer

2024-06-04 Thread Hans Verkuil
Dooley Signed-off-by: Julien Massot Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil .../bindings/media/i2c/maxim,max96717.yaml | 157 + 1 file changed, 157 insertions(+) --- diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml b

[git:media_stage/master] media: i2c: add MAX96717 driver

2024-06-04 Thread Hans Verkuil
will be tunneled through the GMSL2 link. The MAX96717 driver can handle MAX96717 and MAX96717F variants with the same "maxim,max96717f" compatible. Signed-off-by: Julien Massot [Sakari Ailus: Adapt to changed i2c_mux_add_adapter arguments.] Signed-off-by: Sakari Ailus Signed-off-by: Ha

[git:media_stage/master] media: i2c: add MAX96714 driver

2024-06-04 Thread Hans Verkuil
the CSI traffic forwarded by the remote serializer. The MAX96714 driver can handle MAX96714 and MAX96714F variants with the same "maxim,max96714f" compatible. Signed-off-by: Julien Massot [Sakari Ailus: Adapt to changed i2c_mux_add_adapter arguments.] Signed-off-by: Sakari Ailus Signed-of

[git:media_stage/master] media: ov5693: Drop privacy-LED GPIO control

2024-06-04 Thread Hans Verkuil
de Goede Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/ov5693.c | 10 -- 1 file changed, 10 deletions(-) --- diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 8deb28b55983..46b9ce111676 100644 --- a/drivers/media/i2c/ov5693.c +++ b

[git:media_stage/master] dt-bindings: media: add Maxim MAX96714 GMSL2 Deserializer

2024-06-04 Thread Hans Verkuil
-by: Conor Dooley Signed-off-by: Julien Massot Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil .../bindings/media/i2c/maxim,max96714.yaml | 174 + 1 file changed, 174 insertions(+) --- diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml b

[git:media_stage/master] drivers: media: max96717: stop the csi receiver before the source

2024-06-04 Thread Hans Verkuil
-by: Julien Massot Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/max96717.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) --- diff --git a/drivers/media/i2c/max96717.c b/drivers/media/i2c/max96717.c index 62df822a193f..949306485873 100644

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Hans Verkuil
On 03/06/2024 16:32, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 9:57 AM Hans Verkuil wrote: >> >> On 07/05/2024 17:54, Paweł Anikiel wrote: >>> Add v4l2 driver for the video interface present on the Google >>> Chameleon v3. The Chameleon v3 uses the video

Re: [PATCH v3 00/10] Add Chameleon v3 video support

2024-06-03 Thread Hans Verkuil
Hi Paweł, On 07/05/2024 17:54, Paweł Anikiel wrote: > Google Chameleon v3 is a testing device capable of emulating multiple > DisplayPort monitors, used for testing purposes. It is based on an Arria > 10 SoCFPGA. This patchset adds V4L2 drivers for two IP blocks used in the > device's FPGA: the

Re: [PATCH v3 07/10] media: intel: Add Displayport RX IP driver

2024-06-03 Thread Hans Verkuil
On 07/05/2024 17:54, Paweł Anikiel wrote: > Add v4l2 subdev driver for the Intel Displayport receiver FPGA IP. > It is a part of the DisplayPort Intel FPGA IP Core, and supports > DisplayPort 1.4, HBR3 video capture and Multi-Stream Transport. > > Signed-off-by: Paweł Anikiel > --- >

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Hans Verkuil
On 07/05/2024 17:54, Paweł Anikiel wrote: > Add v4l2 driver for the video interface present on the Google > Chameleon v3. The Chameleon v3 uses the video interface to capture > a single video source from a given HDMI or DP connector and write > the resulting frames to memory. > > Signed-off-by:

[git:media_stage/master] media: dvb-usb: Fix unexpected infinite loop in dvb_usb_read_remote_control()

2024-05-31 Thread Hans Verkuil
): Multi-input patch for DVB-USB device") Signed-off-by: Zheng Yejian Signed-off-by: Sean Young Signed-off-by: Hans Verkuil drivers/media/usb/dvb-usb/dvb-usb-init.c | 35 1 file changed, 31 insertions(+), 4 deletions(-) --- diff --git a/drivers/media/usb/dvb-usb

[git:media_stage/master] media: mceusb: No need for vendor/product ID in name

2024-05-31 Thread Hans Verkuil
. Signed-off-by: Sean Young Signed-off-by: Hans Verkuil drivers/media/rc/mceusb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) --- diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index c76ba24c1f55..615f48898300 100644 --- a/drivers/media/rc/mceusb.c

[git:media_stage/master] media: imon: Fix race getting ictx->lock

2024-05-31 Thread Hans Verkuil
ine 1153 Fixes: 23ef710e1a6c ("[media] imon: add conditional locking in change_protocol") Signed-off-by: Ricardo Ribalda Signed-off-by: Sean Young Signed-off-by: Hans Verkuil drivers/media/rc/imon.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) --- diff --git a/drivers/media/rc/

[git:media_stage/master] media: pci: ivtv: Add check for DMA map result

2024-05-31 Thread Hans Verkuil
I") Signed-off-by: Mikhail Kobuk Signed-off-by: Hans Verkuil drivers/media/pci/ivtv/ivtv-udma.c | 8 drivers/media/pci/ivtv/ivtv-yuv.c | 6 ++ drivers/media/pci/ivtv/ivtvfb.c| 6 +++--- 3 files changed, 17 insertions(+), 3 deletions(-) --- diff --git a/drivers/media/pci/

[git:media_stage/master] dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga

2024-05-31 Thread Hans Verkuil
an RGA, which is called RGA2 in the TRM Part2. It is the same core as used on the rk3288 and rk3568, which documents the same RGA2. Signed-off-by: Jianfeng Liu Acked-by: Conor Dooley Signed-off-by: Hans Verkuil Documentation/devicetree/bindings/media/rockchip-rga.yaml | 1 + 1 file changed, 1

[git:media_stage/master] media: dvb-frontends: drx39xyj: remove unused struct 'drxjeq_stat'

2024-05-31 Thread Hans Verkuil
38b2df95c53b ("[media] drx-j: add a driver for Trident drx-j frontend"). The name was changed by commit 57afe2f0bb0c ("[media] drx-j: Don't use CamelCase") and it was originally DRXJEQStat_t. Remove it. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Hans Verkuil drivers

[git:media_stage/master] media: ivtv: Factor out schedule functions

2024-05-31 Thread Hans Verkuil
: preceding lock on line 689 drivers/media/pci/ivtv/ivtv-fileops.c:648:3-9: preceding lock on line 627 drivers/media/pci/ivtv/ivtv-fileops.c:648:3-9: preceding lock on line 689 drivers/media/pci/ivtv/ivtv-fileops.c:692:4-10: preceding lock on line 689 Signed-off-by: Ricardo Ribalda Signed-off-by: Hans

[git:media_stage/master] media: go7007: Refactor Adlink PCI-MPG24 i2c mutex

2024-05-31 Thread Hans Verkuil
happier. Fix the following cocci warning: drivers/media/usb/go7007/go7007-i2c.c:125:1-7: preceding lock on line 61 Signed-off-by: Ricardo Ribalda Signed-off-by: Hans Verkuil drivers/media/usb/go7007/go7007-i2c.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions

[git:media_stage/master] media: dvb-frontends/stv090x: Refactor tuner_i2c_lock

2024-05-31 Thread Hans Verkuil
and cocci is much happier. Fix the following cocci warning: drivers/media/dvb-frontends/stv090x.c:799:1-7: preceding lock on line 768 Signed-off-by: Ricardo Ribalda Signed-off-by: Hans Verkuil drivers/media/dvb-frontends/stv090x.c | 37 --- 1 file changed, 21

[git:media_stage/master] media: dvb-frontends: stv0910: remove unused struct 'sinit_table'

2024-05-31 Thread Hans Verkuil
cd21b3349437 ("media: dvb-frontends: add ST STV0910 DVB-S/S2 demodulator frontend driver"). Remove it. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Hans Verkuil drivers/media/dvb-frontends/stv0910.c | 5 - 1 file changed, 5 deletions(-) --- diff --git a/drivers

[git:media_stage/master] media: gs1662: remove unused struct 'gs_reg_fmt_custom'

2024-05-31 Thread Hans Verkuil
7aae6e2df127 ("[media] Add GS1662 driver, a video serializer"). Remove it. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Hans Verkuil drivers/media/spi/gs1662.c | 8 1 file changed, 8 deletions(-) --- diff --git a/drivers/media/spi/gs1662.c b/drivers/media/spi/gs16

  1   2   3   4   5   6   7   8   9   10   >