[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
@@ -2218,6 +2218,9 @@ printTo(raw_ostream &OS, ArrayRef Args, const PrintingPolicy &Policy, } else { if (!FirstArg) OS << Comma; + //if (Argument.getKind() == TemplateArgument::Type) + // OS << "class "; + zahiraam wrote: TODO: if

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam unassigned https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam unassigned https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam unassigned https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam unassigned https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
@@ -2339,6 +2345,28 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, // LLVM counterparts if the call is marked 'const' (known to never set errno). // In case FP exceptions are enabled, the experimental versions of the // intrinsics mo

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66381 >From 997e3b69ac5c20a9130b957c86c08b16d23af07c Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 14 Sep 2023 06:27:35 -0700 Subject: [PATCH 1/5] Fix math-errno issue --- clang/lib/CodeGen/CGBuiltin

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
@@ -2339,6 +2345,28 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, // LLVM counterparts if the call is marked 'const' (known to never set errno). // In case FP exceptions are enabled, the experimental versions of the // intrinsics mo

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-15 Thread Zahira Ammarguellat via cfe-commits
@@ -2339,6 +2345,28 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, // LLVM counterparts if the call is marked 'const' (known to never set errno). // In case FP exceptions are enabled, the experimental versions of the // intrinsics mo

[clang] Fix math-errno issue (PR #66381)

2023-09-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66381 >From 997e3b69ac5c20a9130b957c86c08b16d23af07c Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 14 Sep 2023 06:27:35 -0700 Subject: [PATCH 1/6] Fix math-errno issue --- clang/lib/CodeGen/CGBuiltin

[clang] Fix math-errno issue (PR #66381)

2023-09-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam resolved https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam resolved https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66381 >From 997e3b69ac5c20a9130b957c86c08b16d23af07c Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 14 Sep 2023 06:27:35 -0700 Subject: [PATCH 1/7] Fix math-errno issue --- clang/lib/CodeGen/CGBuiltin

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/2] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/E

[clang] Fix math-errno issue (PR #66381)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/3] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/E

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/3] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/E

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: There are still some debug info LIT tests that are failing, but I am not going to edit them because I am not quite sure that's correct. Probably adding the "class" keyword shouldn't happen at all times even when the MSVCPolicy is true? https://github.com/llvm/llvm-project/pull/

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: There are still some debug info LIT tests that are failing, but I am not going to edit them because I am not quite sure that's correct. Probably adding the "class" keyword shouldn't happen at all times even when the MSVCPolicy is true? https://github.com/llvm/llvm-project/pull/

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9fc3b4a - [clang] Add a namespace for interesting identifiers.

2023-06-22 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-06-22T13:24:00-04:00 New Revision: 9fc3b4acbc920dc93f4b6eefb4e2b3f795fa9aac URL: https://github.com/llvm/llvm-project/commit/9fc3b4acbc920dc93f4b6eefb4e2b3f795fa9aac DIFF: https://github.com/llvm/llvm-project/commit/9fc3b4acbc920dc93f4b6eefb4e2b3f795fa9aac

[clang] 63b0b82 - When float_t and double_t types are used inside a scope with

2023-06-23 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-06-23T15:12:51-04:00 New Revision: 63b0b82fd6bee672fa20078aa2fbe3c4ee2b8970 URL: https://github.com/llvm/llvm-project/commit/63b0b82fd6bee672fa20078aa2fbe3c4ee2b8970 DIFF: https://github.com/llvm/llvm-project/commit/63b0b82fd6bee672fa20078aa2fbe3c4ee2b8970

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Could you add a description explaining what is currently wrong with the value > of `__FUNCTION__` is MSVC mode? I think we also need a release note. Hope the RN is at the right place? Thanks. https://github.com/llvm/llvm-project/pull/67592

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/68106 None >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/2] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file cha

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/3] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/4] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/5] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[clang] Complex div (PR #68106)

2023-10-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/68106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 01/11] Fix value of __FUNCTION__ and __func__ in MSVC mode. ---

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 01/11] Fix value of __FUNCTION__ and __func__ in MSVC mode. ---

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-05 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > struct S { int x; }; > namespace NS { > class C {}; > } > > S foo(S s1, NS::C c1) { > S s12{12}; > using namespace NS; > C c; > } @AaronBallman By pretty printed you mean the use of __PRETTY_FUNCTION__ right? In MSVC this macro is not defined. The equivalent one is FUNCS

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-05 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > struct S { int x; }; > namespace NS { > class C {}; > } > > S foo(S s1, NS::C c1) { > S s12{12}; > using namespace NS; > C c; > } @AaronBallman By pretty printed you mean the use of __PRETTY_FUNCTION__ right? In MSVC this macro is not defined. The equivalent one is FUNCS

[clang] clang: Add pragma clang fp reciprocal (PR #68267)

2023-10-06 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: and a test for it. https://github.com/llvm/llvm-project/pull/68267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Add pragma clang fp reciprocal (PR #68267)

2023-10-06 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: Can you please fix the description of the patch. Please note that Melanie has retired. You can add me as a reviewer for all FP related work. Thanks. https://github.com/llvm/llvm-project/pull/68267 ___ cfe-commits mailing list cfe-commi

[clang] Add support for -fcx-limited-range and #pragma CX_LIMTED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/68820 None >From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 10 Oct 2023 08:31:41 -0700 Subject: [PATCH] Add support for -fcx-limited-range and #pragma CX_LIMTED_R

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/68820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68820 >From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 10 Oct 2023 08:31:41 -0700 Subject: [PATCH 1/2] Add support for -fcx-limited-range and #pragma CX_LIMTED_RAN

[clang] 2c93e3c - Take math-errno into account with '#pragma float_control(precise,on)' and

2023-09-08 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-09-08T09:48:53-04:00 New Revision: 2c93e3c1c8ba70694bc0d3fd71ac90836a147f2d URL: https://github.com/llvm/llvm-project/commit/2c93e3c1c8ba70694bc0d3fd71ac90836a147f2d DIFF: https://github.com/llvm/llvm-project/commit/2c93e3c1c8ba70694bc0d3fd71ac90836a147f2d

[clang] d4ff8f8 - Fix buildbot failure

2023-09-08 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-09-08T17:56:51-04:00 New Revision: d4ff8f815c21c6c511d7cdecda3f5376b8a9fb28 URL: https://github.com/llvm/llvm-project/commit/d4ff8f815c21c6c511d7cdecda3f5376b8a9fb28 DIFF: https://github.com/llvm/llvm-project/commit/d4ff8f815c21c6c511d7cdecda3f5376b8a9fb28

[clang] Macro func (PR #65909)

2023-09-10 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/65909: None >From d0e74f731cc728cbe8e701eda5ca9553862a4b9c Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Sun, 10 Sep 2023 15:54:41 -0400 Subject: [PATCH 1/2] Testing. --- clang/lib/AST/Expr.cpp | 1 + 1

[clang] Macro func (PR #65909)

2023-09-10 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/65909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9fd3321 - Fix test regression on 32-bit x86.

2023-06-29 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-06-29T11:02:38-04:00 New Revision: 9fd3321db7429098e115c2c46bf6528a85070e53 URL: https://github.com/llvm/llvm-project/commit/9fd3321db7429098e115c2c46bf6528a85070e53 DIFF: https://github.com/llvm/llvm-project/commit/9fd3321db7429098e115c2c46bf6528a85070e53

[clang] e692654 - The methods visited for a special class must have an identifier.

2022-02-02 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2022-02-02T13:12:33-08:00 New Revision: e692654a4dc017b0bddc4366b328dd6d68d2740a URL: https://github.com/llvm/llvm-project/commit/e692654a4dc017b0bddc4366b328dd6d68d2740a DIFF: https://github.com/llvm/llvm-project/commit/e692654a4dc017b0bddc4366b328dd6d68d2740a

[clang] 4bafe65 - Add support for floating-point option `ffp-eval-method` and for

2022-02-15 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2022-02-15T13:59:27-08:00 New Revision: 4bafe65c2b2f1ce745894a509a6d80c87fb1c335 URL: https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335 DIFF: https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335

[clang] 6278682 - In spir functions, llvm.dbg.declare intrinsics created

2021-11-05 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-11-05T15:08:09-07:00 New Revision: 627868263cd4d57c230b61904483a3dad9e1a1da URL: https://github.com/llvm/llvm-project/commit/627868263cd4d57c230b61904483a3dad9e1a1da DIFF: https://github.com/llvm/llvm-project/commit/627868263cd4d57c230b61904483a3dad9e1a1da

[clang] 17d9560 - Making the code compliant to the documentation about Floating Point

2021-11-08 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-11-08T07:51:29-05:00 New Revision: 17d9560294eee1eae5e2d3ac1ab84f514318409e URL: https://github.com/llvm/llvm-project/commit/17d9560294eee1eae5e2d3ac1ab84f514318409e DIFF: https://github.com/llvm/llvm-project/commit/17d9560294eee1eae5e2d3ac1ab84f514318409e

[clang] 438437c - Making the code compliant to the documentation about Floating Point

2021-11-08 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-11-08T08:35:19-05:00 New Revision: 438437cbb61a39ce27b3d6218ac426b8f8a0132e URL: https://github.com/llvm/llvm-project/commit/438437cbb61a39ce27b3d6218ac426b8f8a0132e DIFF: https://github.com/llvm/llvm-project/commit/438437cbb61a39ce27b3d6218ac426b8f8a0132e

[clang] f04e387 - Making the code compliant to the documentation about Floating Point

2021-11-11 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-11-11T07:40:35-05:00 New Revision: f04e387055e495e3e14570087d68e93593cf2918 URL: https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918 DIFF: https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918

[clang] 95edd7f - Making the code compliant to the documentation about Floating Point

2021-11-15 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-11-15T15:30:10-05:00 New Revision: 95edd7f53e77415ca30abefdcdc5ce723c292ebd URL: https://github.com/llvm/llvm-project/commit/95edd7f53e77415ca30abefdcdc5ce723c292ebd DIFF: https://github.com/llvm/llvm-project/commit/95edd7f53e77415ca30abefdcdc5ce723c292ebd

[clang] 6623c02 - The _Float16 type is supported on x86 systems with SSE2 enabled.

2021-11-19 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-11-19T08:59:50-05:00 New Revision: 6623c02d70c3732dbea59c6d79c69501baf9627b URL: https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b DIFF: https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b

[clang] fd759d4 - Revert "The _Float16 type is supported on x86 systems with SSE2 enabled."

2021-11-23 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-11-23T08:00:57-05:00 New Revision: fd759d42c9f84d16efa99a59620cbb3e6836fed4 URL: https://github.com/llvm/llvm-project/commit/fd759d42c9f84d16efa99a59620cbb3e6836fed4 DIFF: https://github.com/llvm/llvm-project/commit/fd759d42c9f84d16efa99a59620cbb3e6836fed4

[clang] 32b73bc - Add support for floating-point option `ffp-eval-method` and for

2022-02-17 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2022-02-17T08:59:21-08:00 New Revision: 32b73bc6ab8234b670c34d5ef999300e072cc706 URL: https://github.com/llvm/llvm-project/commit/32b73bc6ab8234b670c34d5ef999300e072cc706 DIFF: https://github.com/llvm/llvm-project/commit/32b73bc6ab8234b670c34d5ef999300e072cc706

[clang] 4dfa68e - [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue.

2022-02-17 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2022-02-17T10:59:54-08:00 New Revision: 4dfa68e483137cc13eb9027c0dd834ede19f2fd4 URL: https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4 DIFF: https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4

[clang] 1592d88 - Add support for floating-point option `ffp-eval-method` and for

2022-02-23 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2022-02-23T15:00:18-08:00 New Revision: 1592d88aa7bc13c9f53cf09d25b98e7318a57bfb URL: https://github.com/llvm/llvm-project/commit/1592d88aa7bc13c9f53cf09d25b98e7318a57bfb DIFF: https://github.com/llvm/llvm-project/commit/1592d88aa7bc13c9f53cf09d25b98e7318a57bfb

[clang] 8ba9c79 - Add support for sycl_special_class attribute.

2022-01-25 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2022-01-25T14:17:09-08:00 New Revision: 8ba9c794feb30cd969b9776c39873def10c51bff URL: https://github.com/llvm/llvm-project/commit/8ba9c794feb30cd969b9776c39873def10c51bff DIFF: https://github.com/llvm/llvm-project/commit/8ba9c794feb30cd969b9776c39873def10c51bff

[clang] e84c541 - Fix indentation and pragma name.

2021-10-26 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-10-26T13:58:43-04:00 New Revision: e84c5419e2264375e9fef9b025a0dd8ecb251429 URL: https://github.com/llvm/llvm-project/commit/e84c5419e2264375e9fef9b025a0dd8ecb251429 DIFF: https://github.com/llvm/llvm-project/commit/e84c5419e2264375e9fef9b025a0dd8ecb251429

[clang] cec7c2b - Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly"

2021-09-01 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2021-09-01T04:48:50-07:00 New Revision: cec7c2b32ecfd38151822a6e01ec78afaf98bf9a URL: https://github.com/llvm/llvm-project/commit/cec7c2b32ecfd38151822a6e01ec78afaf98bf9a DIFF: https://github.com/llvm/llvm-project/commit/cec7c2b32ecfd38151822a6e01ec78afaf98bf9a

[clang] 2f12642 - Revert "Currently the control of the eval-method is mixed with fast-math."

2023-03-10 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-03-10T14:44:06-05:00 New Revision: 2f1264260b37e9bd79737181e459ae20e10c5fea URL: https://github.com/llvm/llvm-project/commit/2f1264260b37e9bd79737181e459ae20e10c5fea DIFF: https://github.com/llvm/llvm-project/commit/2f1264260b37e9bd79737181e459ae20e10c5fea

[clang] 6d3b779 - Set 'rounding_mode' to 'tonearest' with '#pragma STDC FENV_ACCESS OFF'.

2023-04-12 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-04-12T06:44:45-04:00 New Revision: 6d3b779792fbf9ec5cc119f1812655da01020b7a URL: https://github.com/llvm/llvm-project/commit/6d3b779792fbf9ec5cc119f1812655da01020b7a DIFF: https://github.com/llvm/llvm-project/commit/6d3b779792fbf9ec5cc119f1812655da01020b7a

[clang] b4b06d8 - __arithmetic_fence enforces ordering on expression evaluation when fast-math

2023-01-26 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-01-26T14:18:28-05:00 New Revision: b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2 URL: https://github.com/llvm/llvm-project/commit/b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2 DIFF: https://github.com/llvm/llvm-project/commit/b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2

[clang] 4707468 - Add support for clang-cl's option `-fexcess-precision`.

2023-01-20 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-01-20T11:25:36-05:00 New Revision: 47074683c906f920cb7bba462beeb57ca4b84ab0 URL: https://github.com/llvm/llvm-project/commit/47074683c906f920cb7bba462beeb57ca4b84ab0 DIFF: https://github.com/llvm/llvm-project/commit/47074683c906f920cb7bba462beeb57ca4b84ab0

[clang] f97cdc0 - Revert "Add support for clang-cl's option `-fexcess-precision`."

2023-01-20 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-01-20T16:44:51-05:00 New Revision: f97cdc013fe75e18f74fd7bba7de4913c38875a6 URL: https://github.com/llvm/llvm-project/commit/f97cdc013fe75e18f74fd7bba7de4913c38875a6 DIFF: https://github.com/llvm/llvm-project/commit/f97cdc013fe75e18f74fd7bba7de4913c38875a6

[clang] 3759ef9 - Add support for clang-cl's option `-fexcess-precision`.

2023-01-23 Thread Zahira Ammarguellat via cfe-commits
Author: Zahira Ammarguellat Date: 2023-01-23T12:08:07-05:00 New Revision: 3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118 URL: https://github.com/llvm/llvm-project/commit/3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118 DIFF: https://github.com/llvm/llvm-project/commit/3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118

[clang] [llvm] Add support for decimal-float-abi option. (PR #102958)

2024-08-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/102958 None >From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001 From: Tom Honermann Date: Sun, 24 Sep 2023 22:38:01 -0400 Subject: [PATCH 1/6] [clang][DFP] Add basic builtin type representation fo

[clang] [llvm] Add support for decimal-float-abi option. (PR #102958)

2024-08-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/102958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-12 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: Ping? https://github.com/llvm/llvm-project/pull/88978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-13 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Also, if at all possible, I think we only want the extra field for "library > builtins" and not all builtins. Yes, I have tried limiting it to `LibBuiltin` but the addition of `FrexpF16F128` led me to add it `Builtin` too. > Alternatively, we don't need tablegen changes if w

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-13 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 01/16] Adding C23 constexpr math functions fmin and frexp.

[clang] Add __builtin_fmaf16. (PR #97424)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/97424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/6] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] [TBAA] Emit int TBAA metadata on FP math libcall expf (PR #96025)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,43 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// The test may fail as time out on windows +// REQUIRES: system-linux + +// RUN: %clang -S -O3 -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/7] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/5] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/8] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/6] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/9] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 01/10] [NFC] Add assertion to ensure that FiniteMathOnly to

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 01/11] [NFC] Add assertion to ensure that FiniteMathOnly to

[clang] [TBAA] Emit int TBAA metadata on FP math libcall expf (PR #96025)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,43 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// The test may fail as time out on windows +// REQUIRES: system-linux + +// RUN: %clang -S -O3 -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
@@ -344,10 +352,17 @@ class ComplexExprEmitter return QualType(); } + template + FPOptionsOverride getStoredFPFeaturesOrDefault(const T *E, + const CodeGenFunction &CGF) { zahiraam wrote: `Expr` doesn't

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/98520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/7] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/8] The pragma STDC CX_LIMITED_RANGE ON should have prece

<    1   2   3   4   5   6   >